1 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
3 Unreviewed, remove empty directories.
5 * public/data: Removed.
7 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
9 Perf dashboard should show the results of A/B testing
10 https://bugs.webkit.org/show_bug.cgi?id=141500
12 Reviewed by Chris Dumez.
14 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
15 analysis task page to fetch results for each test group.
17 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
18 can use the formatter.
20 * public/api/runs.php:
21 (fetch_runs_for_config_and_test_group): Added.
22 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
23 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
24 use RunsGenerator to format results.
25 (RunsGenerator): Added.
26 (RunsGenerator::__construct): Added.
27 (RunsGenerator::add_runs): Added.
28 (RunsGenerator::format_run): Moved.
29 (RunsGenerator::parse_revisions_array): Moved.
31 * public/v2/analysis.js:
32 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
33 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
34 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
35 configuration associated with this build request such as "A" and "B".
36 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
37 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
38 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
42 (App.Pane._fetch): Set chartData directly here.
43 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
44 now that it's done in App.Pane._fetch.
45 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
48 (Measurement.prototype.buildId): Added.
49 (TimeSeries.prototype.findPointByBuild): Added.
51 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
52 url is not an Ember routed path.
54 * public/v2/manifest.js:
55 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
56 App.createChartData here so that App.BuildRequest can use the formatter
58 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
60 v2 UI should adjust the number of ticks on dashboards based on screen size
61 https://bugs.webkit.org/show_bug.cgi?id=141502
63 Reviewed by Chris Dumez.
65 * public/v2/interactive-chart.js:
66 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
69 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
71 New perf dashboard shows too much space around interesting data points
72 https://bugs.webkit.org/show_bug.cgi?id=141487
74 Reviewed by Chris Dumez.
76 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
77 show the current time series excluding points in the series outside the moving average envelope.
80 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
81 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
82 time series if the point lies outside the moving average envelope. Don't expose the moving average or
83 the envelope computed for this purpose if they're not set by the user.
86 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
87 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
89 * public/v2/interactive-chart.js:
90 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
91 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
92 to deal with showFullYAxis here.
93 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
94 argument instead of directly inspecting showFullYAxis.
96 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
98 New perf dashboard shouldn't always show outliners
99 https://bugs.webkit.org/show_bug.cgi?id=141445
101 Reviewed by Chris Dumez.
103 Use the simple moving average with an average difference envelope to compute the y-axis range to show
104 to avoid expanding it spuriously to show one off outlier.
107 (App.Pane): Don't show the full y-axis range by default.
108 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
109 one is not specified by the user but without showing them in the charts.
110 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
111 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
113 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
114 (App.ChartsController._serializePaneList): Ditto.
116 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
118 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
120 * public/v2/interactive-chart.js:
121 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
122 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
123 if they are not specified by the user (i.e. only used to adjust y-axis range).
124 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
125 x-axis domain remained the same. Without this change, the charts would never redraw.
126 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
127 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
128 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
130 * public/v2/js/statistics.js:
131 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
133 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
135 Unreviewed build fix.
138 (set get App.Pane.Ember.Object.extend):
140 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
142 New perf dashboard should have the ability to overlay moving average with an envelope
143 https://bugs.webkit.org/show_bug.cgi?id=141438
145 Reviewed by Andreas Kling.
147 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
149 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
150 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
151 n, backward window size, and m, forward window size, as an argument.
153 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
154 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
156 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
157 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
160 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
161 between each x_i and x̄_i.
163 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
164 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
165 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
166 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
169 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
170 The configuration of the currently chosen strategies is saved in the query string for convenience.
172 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
174 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
177 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
178 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
179 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
180 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
181 from the query string via ChartsController.
182 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
183 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
184 (App.Pane._executeStrategy): Added.
185 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
187 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
188 selections, and added two new arguments for the moving average and the enveloping configurations.
189 (App.ChartsController._serializePaneList): Ditto.
190 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
191 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
192 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
193 (App.PaneController.actions.toggleStatPane): Added.
195 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
196 current (as opposed to baseline and target) time series for when it's the most foreground graph without
197 moving average and its envelope overlapping on top of it.
199 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
201 * public/v2/interactive-chart.js:
202 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
203 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
204 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
205 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
206 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
207 but don't bother removing individual paths and circles. Added the code to show the moving average time
208 series when there is one. Also add "foreground" class on SVG elements for the current time series when
209 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
210 series when "foreground" is not set.
211 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
212 account when computing the y-axis range.
213 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
215 * public/v2/js/statistics.js:
216 (Statistics.MovingAverageStrategies): Added.
217 (Statistics.EnvelopingStrategies): Added.
219 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
221 The delta value in the chart pane sometimes doens't show '+' for a positive delta
222 https://bugs.webkit.org/show_bug.cgi?id=141340
224 Reviewed by Andreas Kling.
226 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
227 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
230 (App.Pane.computeStatus):
231 (App.createChartData):
233 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
235 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
238 (App.PaneController._updateDetails):
240 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
242 Unreviewed. Commit the forgotten change.
244 * public/include/manifest.php:
246 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
248 New perf dashboard should have multiple dashboard pages
249 https://bugs.webkit.org/show_bug.cgi?id=141339
251 Reviewed by Chris Dumez.
253 Added the support for multiple dashboard pages. Also added the status of the latest data point.
254 e.g. "5% better than target"
256 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
257 Also hid the border lines around charts on the dashboard page for a cleaner look.
260 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
261 (App.IndexRoute.beforeModel): Added.
262 (App.DashboardRoute): Added.
263 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
264 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
265 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
266 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
267 (App.DashboardController): Renamed from App.IndexController.
268 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
269 and "defaultDashboard" as these are taken care of by newly added routers.
270 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
271 now done in actions.toggleEditMode.
272 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
273 an existing dashboard.
275 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
276 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
277 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
278 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
280 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
282 (App.PaneController._updateDetails): Updated per changes to computeStatus.
284 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
287 (TimeSeries.prototype.lastPoint): Added.
289 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
290 on the dashboard, and enumerate all predefined dashboards.
292 * public/v2/interactive-chart.js:
293 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
294 for the dashboard page.
296 * public/v2/manifest.js:
297 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
298 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
299 IDs are generated for each dashboard for forward compatibility.
301 (App.Manifest.dashboardByName): Added.
302 (App.Manifest.defaultDashboardName): Added.
303 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
305 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
307 Move commits viewer to the end of details view
308 https://bugs.webkit.org/show_bug.cgi?id=141315
310 Rubber-stamped by Andreas Kling.
312 Show the difference instead of the old value per kling's request.
315 (App.PaneController._updateDetails):
316 * public/v2/index.html:
318 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
320 Move commits viewer to the end of details view
321 https://bugs.webkit.org/show_bug.cgi?id=141315
323 Reviewed by Andreas Kling.
325 Improved the way list of commits are shown per kling's request.
328 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
330 * public/v2/chart-pane.css: Updated the style for the commits viewer.
332 * public/v2/commits-viewer.js:
333 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
334 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
336 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
337 moved the commits viewers out of the details tables so that they don't interleave revision data.
339 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
341 New perf dashboard should compare results to baseline and target
342 https://bugs.webkit.org/show_bug.cgi?id=141286
344 Reviewed by Chris Dumez.
346 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
347 Also use d3.format to format the selected value to show four significant figures.
350 (App.Pane.searchCommit):
351 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
352 to compute the status text without having to recreate them.
353 (App.createChartData): Added.
354 (App.PaneController._updateDetails): Use 3d.format on current and old values.
355 (App.PaneController._computeStatus): Added. Computes the status text.
356 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
357 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
358 format the values using chartData.formatter.
360 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
361 the baseline and in blue if it's better than the target.
364 (TimeSeries.prototype.findPointAfterTime): Added.
366 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
367 the bug that we were not showing the old value's unit.
369 * public/v2/interactive-chart.js:
370 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
371 the code to show the baseline and the target lines.
373 * public/v2/manifest.js:
374 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
376 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
378 Unreviewed build fix.
381 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
383 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
385 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
386 https://bugs.webkit.org/show_bug.cgi?id=141280
388 Reviewed by Chris Dumez.
390 Fixed the bug by passing in "since" as a query parameter to the charts page.
392 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
394 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
396 (App.IndexController): Changed the default number of days from one month to one week.
397 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
398 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
400 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
402 New perf dashboard erroneously clears zoom when poping history items
403 https://bugs.webkit.org/show_bug.cgi?id=141278
405 Reviewed by Chris Dumez.
407 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
409 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
410 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
413 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
414 shown in the main plot.
415 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
416 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
418 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
420 New perf dashboard shows null as the aggregator name if no aggregation is done
421 https://bugs.webkit.org/show_bug.cgi?id=141256
423 Reviewed by Chris Dumez.
425 Don't show the aggregator name if there isn't one.
427 * public/v2/manifest.js:
430 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
432 Unreviewed build fix after r179611.
434 * public/v2/interactive-chart.js:
436 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
438 Perf dashboard doesn’t show the right unit for Safari UI tests
439 https://bugs.webkit.org/show_bug.cgi?id=141238
441 Reviewed by Darin Adler.
443 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
444 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
445 between metrics and their units.
447 * public/js/helper-classes.js:
448 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
449 * public/v2/manifest.js:
450 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
451 * public/v2/interactive-chart.js:
452 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
453 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
455 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
457 Interactive chart component provides two duplicate API for highlighting points
458 https://bugs.webkit.org/show_bug.cgi?id=141234
460 Reviewed by Chris Dumez.
462 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
463 on the main charts page and markedPoints to show the two end points in the analysis task page.
465 This patch merges markedPoints into highlightedItems.
468 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
469 * public/v2/chart-pane.css:
470 * public/v2/index.html: Ditto.
471 * public/v2/interactive-chart.js:
472 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
473 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
474 items if highlightedItems was set before the initial layout.
475 (App.InteractiveChartComponent._relayoutDataAndAxes):
476 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
477 vertical lines, just set cx and cy as done for other "dots".
478 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
479 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
480 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
481 set the radius of highlight circles here.
483 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
485 Don’t use repository names as id’s.
486 https://bugs.webkit.org/show_bug.cgi?id=141226
488 Reviewed by Chris Dumez.
490 Not using repository names as their id's reduces the need to fetch the entire repositories table.
491 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
493 * Websites/perf.webkit.org/public/api/runs.php:
494 (parse_revisions_array): No longer uses $repository_id_to_name.
495 (main): No longer populates $repository_id_to_name.
497 * Websites/perf.webkit.org/public/api/triggerables.php:
498 (main): Don't resolve repository names.
500 * Websites/perf.webkit.org/public/include/manifest.php:
501 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
502 (ManifestGenerator::bug_trackers): Don't resolve repository names.
504 * Websites/perf.webkit.org/public/js/helper-classes.js:
505 (TestBuild): Renamed repositoryName to repositoryId.
506 (TestBuild.revision): Ditto.
507 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
508 since this is the text shown to human.
510 * Websites/perf.webkit.org/public/v2/app.js:
511 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
512 (App.PaneController._updateDetails): Ditto.
513 (App.AnalysisTaskController.updateRoots): Ditto.
515 * Websites/perf.webkit.org/public/v2/data.js:
516 (Measurement): Ditto.
517 (Measurement.prototype.commitTimeForRepository): Ditto.
518 (Measurement.prototype.formattedRevisions): Ditto.
520 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
521 select element's label and value respectively.
523 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
525 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
527 * public/api/runs.php:
529 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
531 /api/runs.php should have main function
532 https://bugs.webkit.org/show_bug.cgi?id=141220
534 Reviewed by Benjamin Poulain.
536 Wrapped the code inside main function for clarity.
538 * public/api/runs.php:
540 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
542 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
544 * tools/sync-with-buildbot.py:
545 (find_request_updates):
547 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
549 Perf dashboard always assigns the result of A/B testing with build request 1
550 https://bugs.webkit.org/show_bug.cgi?id=140382
552 Reviewed by Darin Adler.
554 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
555 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
557 Also fixed a typo as well as a bug that reports were never associated with builds.
559 * public/include/report-processor.php:
560 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
561 instead of the first non-null value.
562 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
563 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
565 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
567 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
569 * public/admin/tests.php:
571 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
573 Unreviewed build fix. Removed the stale code.
575 * public/admin/triggerables.php:
577 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
579 Perf dashboard should have the ability to post A/B testing builds
580 https://bugs.webkit.org/show_bug.cgi?id=140317
582 Rubber-stamped by Simon Fraser.
584 This patch adds the support for triggering A/B testing from the perf dashboard.
586 We add a few new tables to the database. "build_triggerables", which represents a set of builders
587 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
588 of repositories for which an arbitrary revision can be specified for A/B testing.
589 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
590 "roots" table which specifies the revision used in a given root set in each repository.
592 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
593 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
594 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
595 to build_requests table. Also made each test group's name unique in a given analysis task as it
596 would be confusing to have multiple test groups of the same name.
598 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
600 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
601 for which a specific revision can be set in an A/B testing on a given triggerable.
603 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
604 triggerable. Also updates the status' and the status urls of specified build requests when
605 buildRequestUpdates is provided in the raw POST data.
608 * public/api/runs.php:
609 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
610 results of an A/B testing.
612 * public/api/test-groups.php:
613 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
615 * public/api/triggerables.php: Added.
616 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
618 * public/include/admin-header.php:
620 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
621 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
622 and root sets used in those requests.D
623 (BuildRequestsFetcher::__construct):
624 (BuildRequestsFetcher::fetch_for_task):
625 (BuildRequestsFetcher::fetch_for_group):
626 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
627 (BuildRequestsFetcher::has_results):
628 (BuildRequestsFetcher::results):
629 (BuildRequestsFetcher::results_with_resolved_ids):
630 (BuildRequestsFetcher::results_internal):
631 (BuildRequestsFetcher::root_sets):
632 (BuildRequestsFetcher::fetch_roots_for_set):
634 * public/include/db.php:
635 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
636 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
637 table since it only has the primary key, id, column.
638 (Database::select_or_insert_row):
639 (Database::update_or_insert_row):
640 (Database::update_row): Added.
641 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
642 should be inserted when no row matches the specified criteria. This is used while updating
643 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
644 new build requests in that API.
645 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
646 This is used in public/api/triggerables.php when no analysis task is specified.
648 * public/include/json-header.php:
649 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
650 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
651 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
652 find the closest ancestor with a triggerable.
654 * public/include/report-processor.php:
655 (ReportProcessor::process):
656 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
657 if jobId or buildRequest is specified.
659 * public/include/test-name-resolver.php:
660 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
661 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
662 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
665 * public/include/test-path-resolver.php: Added.
666 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
667 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
668 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
669 in order to compute full test metric names.
670 (TestPathResolver::__construct):
671 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
672 the highest (a test without a parent).
673 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
674 the highest ancestor to the test itself.
675 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
677 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
679 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
680 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
681 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
682 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
684 * public/v2/analysis.js:
685 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
686 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
687 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
688 (App.TestGroup.create): Added. Creates a new A/B testing group.
689 (App.Triggerable): Added.
690 (App.TriggerableAdapter): Added.
691 (App.TriggerableAdapter.buildURL): Added.
692 (App.BuildRequest.testGroup): Renamed from group.
693 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
694 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
695 in this build request.
696 (App.BuildRequest.status): Added.
697 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
698 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
701 (App.AnalysisTaskController.testGroups): Added.
702 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
703 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
704 but an observer that updates "roots" property. Filter out the repositories that are not accepted
705 by the associated triggerable as they will be ignored.
706 (App.AnalysisTaskController.actions.createTestGroup): Added.
708 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
710 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
711 the status of those builds to the perf dashboard. A similar script can be written to support
712 other continuous builds systems.
713 (main): Fetches the list of pending builds as well as currently running or completed builds from
714 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
715 a single new build on each builder with no pending builds, and marks the set of open build requests
716 that have been scheduled to run on the buildbot but not found in the first step as stale.
717 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
720 "platform": "mac-mavericks",
721 "test": ["Parser", "html5-full-render.html"],
722 "builder": "Trunk Syrah Production Perf AB Tests",
724 "forcescheduler": "force-mac-mavericks-release-perf",
725 "webkit_revision": "$WebKit",
726 "jobid": "$buildRequest"
731 (find_request_updates): Return a list of build request status updates to make based on the pending
732 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
733 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
734 if the build request had not been completed. This is necessary because a failed build will not
735 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
736 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
737 of open requests the perf dashboard has.
738 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
739 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
740 or human canceling a build may trigger such a state.
741 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
742 replacing repository names with their revisions and buildRequest with the build request id.
743 (config_for_request): Finds a builder for the test and the platform of a build request.
744 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
745 (property_value_from_build): Returns the value of a specific property in a buildbot build.
746 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
748 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
750 Cache-control should be set only on api/runs
751 https://bugs.webkit.org/show_bug.cgi?id=140312
753 Reviewed by Andreas Kling.
755 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
756 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
757 just set cache-control there instead of json-header.php which is used by other JSON APIs.
759 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
761 * public/api/analysis-tasks.php:
762 * public/api/runs.php: Set the cache control headers.
763 * public/api/test-groups.php:
764 * public/include/db.php: Set the default timezone to UTC.
765 * public/include/json-header.php: Don't set the cache control headers.
767 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
769 api/report-commit should authenticate with a slave name and password
770 https://bugs.webkit.org/show_bug.cgi?id=140308
772 Reviewed by Benjamin Poulain.
774 Use a slave name and a password to authenticate new commit reports.
776 * public/api/report-commits.php:
778 * public/include/json-header.php:
779 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
780 a slave name and a password instead of a builder name and a password.
781 * tests/api-report-commits.js: Updated tests.
783 (main): Renamed variables.
784 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
786 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
788 Perf dashboard should support authentication via a slave password
789 https://bugs.webkit.org/show_bug.cgi?id=139837
791 Reviewed by Andreas Kling.
793 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
794 having to add multiple builders with the same password when a single build slave is shared among them.
796 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
798 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
800 * public/admin/build-slaves.php: Added.
802 * public/admin/builders.php: Added the support for updating passwords.
804 * public/include/admin-header.php:
805 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
806 being retrieved from $_POST.
807 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
808 the raw may not exist (e.g. new_password).
809 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
810 control here when this flag evaluates to TRUE.
812 * public/include/report-processor.php:
813 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
814 values are present in the report. In addition, try authenticating builderName with slavePassword if
815 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
816 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
817 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
819 (ReportProcessor::store_report): Store the slave ID with the report.
820 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
821 the matching build is different from what's being reported.
823 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
826 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
828 New perf dashboard should not duplicate author information in each commit
829 https://bugs.webkit.org/show_bug.cgi?id=139756
831 Reviewed by Darin Adler.
833 Instead of each commit having author name and email, make it reference a newly added committers table.
834 Also replace "email" by "account" since some repositories don't use emails as account names.
836 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
837 which only contains as many rows as there are accounts in each repository, instead of commits table
838 which contains every commit ever happened in each repository.
840 To migrate an existing database into match the new schema, run:
844 INSERT INTO committers (committer_repository, committer_name, committer_email)
845 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
846 FROM commits WHERE commit_author_email IS NOT NULL);
848 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
850 UPDATE commits SET commit_committer = committer_id FROM committers
851 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
853 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
854 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
858 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
859 reference to committers. Also added the missing drop table statements.
861 * public/api/commits.php:
862 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
863 an array here instead of doing it in format_commit.
864 (fetch_commits_between): Updated queries to JOIN commits with committers.
865 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
868 * public/api/report-commits.php:
869 (main): Store the reported committer information or update the existing entry if there is one.
871 * tests/admin-regenerate-manifest.js: Fixed tests.
873 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
875 * tools/pull-svn.py: Renamed email to account.
877 (fetch_commit_and_resolve_author):
879 (resolve_author_name_from_account):
880 (resolve_author_name_from_email): Deleted.
882 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
884 Unreviewed build fix.
886 * public/v2/index.html: Include js files we extracted in r177424.
888 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
890 Unreviewed. Adding the forgotten svnprop.
892 * tools/pull-svn.py: Added property svn:executable.
894 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
896 Split InteractiveChartComponent and CommitsViewerComponent into separate files
897 https://bugs.webkit.org/show_bug.cgi?id=139716
899 Rubber-stamped by Benjamin Poulain.
901 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
902 and interactive-chart.js respectively since app.js has gotten really large.
905 * public/v2/commits-viewer.js: Added.
906 * public/v2/interactive-chart.js: Added.
908 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
910 New perf dashboard's chart UI is buggy
911 https://bugs.webkit.org/show_bug.cgi?id=139214
913 Reviewed by Chris Dumez.
915 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
917 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
918 component. This is not how Ember.js components should interact to begin with. The component now exposes
919 selectedPoints and always updates selection instead of sharedSelection.
922 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
923 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
924 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
925 and end time should be completely determined by "since" and the present time.
926 (App.ChartsController._startTimeChanged): Ditto.
927 (App.ChartsController._scheduleQueryStringUpdate):
928 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
930 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
932 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
933 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
934 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
935 observes the changes to selectedPoints property as it gets updated by the main chart.
936 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
937 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
939 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
940 when domain arrays aren't identical. This was causing a subtle race with other logic.
941 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
942 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
943 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
944 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
945 see if those two points correspond to a range or a single data point. Rewrote all that logic by
946 directly observing selectedPoints and currentItem properties instead of taking points and relying on
947 an instance variable, which was a terrible API.
948 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
949 when the main plot has a selected range, we don't have to check this._hasRange anymore.
951 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
952 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
953 (App.InteractiveChartComponent._updateSelection):
954 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
955 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
956 selectedPoints property.
958 (App.AnalysisTaskController._fetchedRuns):
959 (App.AnalysisTaskController._rootChangedForTestSet):
961 * public/v2/index.html:
962 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
964 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
966 Unreviewed. Fixed syntax errors.
969 * public/api/commits.php:
971 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
973 The dashboard on new perf monitor should be configurable
974 https://bugs.webkit.org/show_bug.cgi?id=138994
976 Reviewed by Benjamin Poulain.
978 For now, make it configurable via config.json. We should eventually make it configurable via
979 an administrative page but this will do for now.
981 * config.json: Added the empty dashboard configuration.
983 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
986 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
987 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
988 Also obtain the default configuration from App.Manifest.
989 (App.IndexController._normalizeTable): Moved to App.Dashboard.
991 * public/v2/manifest.js:
992 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
993 (App.Repository.urlForRevisionRange): Ditto.
994 (App.Dashboard): Added.
995 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
996 (App.Dashboard.rows): Ditto.
997 (App.Dashboard.headerColumns): Ditto.
998 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
999 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
1000 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
1001 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
1003 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1005 There should be a way to associate bugs with analysis tasks
1006 https://bugs.webkit.org/show_bug.cgi?id=138977
1008 Reviewed by Benjamin Poulain.
1010 Updated associate-bug.php to match the new database schema.
1012 * public/include/json-header.php:
1013 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
1014 already camel-cased in require_existence_of. This makes the function usable elsewhere.
1016 * public/privileged-api/associate-bug.php:
1017 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
1018 Also verify that those values are integers using require_format.
1020 * public/v2/analysis.js:
1021 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
1022 (App.Bug.label): Added.
1023 (App.BugAdapter): Added.
1024 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
1025 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
1027 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
1028 containing the bug information.
1031 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
1032 (App.AnalysisTaskRoute):
1033 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
1034 (App.AnalysisTaskController._fetchedManifest): Added.
1035 (App.AnalysisTaskController.actions.associateBug): Added.
1037 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
1039 * public/v2/data.js:
1040 (Measurement.prototype.associateBug): Deleted.
1042 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
1043 Added a table show the bug information. Also hide the chart until chartData is available.
1045 * public/v2/manifest.js:
1048 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1050 Fix misc bugs and typos in app.js
1051 https://bugs.webkit.org/show_bug.cgi?id=138946
1053 Reviewed by Benjamin Poulain.
1056 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1057 (App.ChartsController.init):
1058 (App.buildPopup): Renamed from App.BuildPopup.
1059 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1060 remove() on the wrong object (an array as opposed to elements in the array).
1061 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1062 _highlights is always an array and evalutes to true.
1064 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1066 New perf dashboard should provide UI to create a new analysis task
1067 https://bugs.webkit.org/show_bug.cgi?id=138910
1069 Reviewed by Benjamin Poulain.
1071 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1072 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1074 With this patch, we can create a new analysis task by selection a range of points and opening
1075 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1076 in the chart hyperlinked to the analysis task.
1078 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1080 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1081 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1083 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1084 and adds the associated bugs to each task in the array.
1087 * public/api/runs.php: Reverted changes made in r175006.
1088 (fetch_runs_for_config):
1091 * public/api/test-groups.php:
1092 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1094 * public/include/db.php:
1095 (Database::select_first_or_last_row):
1096 (Database::select_rows): Extracted from select_first_or_last_row.
1098 * public/v2/analysis.js:
1099 (App.AnalysisTask): Added "bugs" property.
1100 (App.Bug): Added now that bugs are regular data store objects.
1103 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1104 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1105 platform that are associated with a specific range of runs.
1106 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1107 (App.PaneController.actions.associateBug): Deleted.
1108 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1109 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1110 once we've created one.
1111 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1112 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1113 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1114 (App.PaneController._updateBugs): Deleted.
1115 (App.PaneController._updateMarkedPoints): Deleted.
1116 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1117 the name is missing or when at most one point is selected.
1119 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1120 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1121 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1122 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1123 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1124 clickable bars for analysis tasks.
1125 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1126 bar for analysis tasks to place them at the right location.
1127 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1129 * public/v2/chart-pane.css:
1130 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1131 (.chart .rangeBar): Added.
1133 * public/v2/data.js:
1134 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1136 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1137 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1138 task bars in the interactive chart component.
1140 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1142 Fix typos in r176203.
1145 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1146 (App.AnalysisTaskRoute):
1148 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1150 Unreviewed. Updated the install instruction.
1154 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1156 App.Manifest shouldn't use App.__container__.lookup
1157 https://bugs.webkit.org/show_bug.cgi?id=138768
1159 Reviewed by Andreas Kling.
1161 Removed the hack to find the store object via App.__container__.lookup.
1162 Pass around the store object instead.
1165 (App.DashboardRow._createPane): Add "store" property to the pane.
1166 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1167 (App.IndexController.gridChanged): Ditto.
1168 (App.IndexController.actions.addRow): Ditto.
1169 (App.IndexController.init): Ditto.
1170 (App.Pane._fetch): Ditto.
1171 (App.ChartsController._parsePaneList): Ditto.
1172 (App.ChartsController._updateQueryString): Ditto.
1173 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1174 (App.BuildPopup): Ditto.
1175 (App.AnalysisTaskRoute.model): Ditto.
1176 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1178 * public/v2/manifest.js:
1179 (App.Manifest.fetch): Removed the code to find the store object.
1181 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1183 Fix Ember.js warnings the new perf dashboard
1184 https://bugs.webkit.org/show_bug.cgi?id=138531
1186 Reviewed by Darin Adler.
1188 Fixed various warnings.
1191 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1192 * public/v2/data.js:
1193 (PrivilegedAPI._post): Removed the superfluous console.log.
1194 (CommitLogs.fetchForTimeRange): Ditto.
1195 * public/v2/index.html: Added tbody as required by the HTML specification.
1197 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1199 Fix typos in r175768.
1202 (App.AnalysisTaskViewModel.roots):
1204 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1206 Introduce the concept of analysis task to perf dashboard
1207 https://bugs.webkit.org/show_bug.cgi?id=138517
1209 Reviewed by Andreas Kling.
1211 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1212 a single platform and used to bisect regressions in the range.
1214 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1216 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1217 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1218 test runs. Analysis tasks not associated with test runs are used for try new patches.
1219 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1220 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1221 build_requests - A build request represents a single pending build for A/B testing.
1223 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1227 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1228 the specified analysis task group as well as build requests associated with them.
1230 (fetch_test_groups_for_task):
1231 (fetch_build_requests_for_task):
1232 (fetch_build_requests_for_group):
1233 (format_test_group):
1234 (format_build_request):
1236 * public/include/json-header.php:
1237 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1240 * public/privileged-api/associate-bug.php:
1241 (main): Fixed a typo.
1243 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1246 (ensure_config_from_runs):
1248 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1250 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1252 (App.AnalysisTask.create):
1254 (App.TestGroupAdapter):
1255 (App.AnalysisTaskSerializer):
1256 (App.TestGroupSerializer):
1259 * public/v2/app.css: Added style rules for the analysis page.
1262 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1264 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1265 exactly one selected point as we can still create an analysis task.
1266 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1267 grammatical and also alert'ed the error message when there is one.
1268 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1269 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1270 once XHR request has completed.
1271 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1272 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1273 is selected in the details pane.
1275 (App.AnalysisRoute): Added.
1276 (App.AnalysisTaskRoute): Added.
1277 (App.AnalysisTaskViewModel): Added.
1278 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1279 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1280 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1281 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1282 the user selects an option for all roots in A or B configuration.
1283 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1285 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1287 * public/v2/data.js:
1288 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1289 point so that we can use it in App.AnalysisTaskViewModel.roots.
1290 (TimeSeries.prototype.findPointByMeasurementId): Added.
1291 (TimeSeries.prototype.seriesBetweenPoints): Added.
1293 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1294 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1295 when multiple points are selected. Finally, added a new template for the analysis task page.
1297 * public/v2/manifest.js:
1298 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1299 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1300 App.AnalysisTaskViewModel._taskUpdated.
1302 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1304 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1305 https://bugs.webkit.org/show_bug.cgi?id=138111
1307 Reviewed by Darin Adler.
1310 (App.PaneController.bugsChangeCount): Removed.
1311 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1312 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1313 Finds the list of current run's points that are associated with bugs.
1314 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1315 * public/v2/chart-pane.css:
1316 (.chart .marked): Renamed from .hasBugs.
1317 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1319 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1321 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1322 https://bugs.webkit.org/show_bug.cgi?id=138099
1324 Reviewed by Benjamin Poulain.
1326 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1327 _showDetails inverting the order of the current and old measurements.
1330 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1331 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1332 current (latest) measurement and the first point is the oldest measurement.
1333 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1335 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1337 Perf dashboard should provide a way to associate bugs with a test run
1338 https://bugs.webkit.org/show_bug.cgi?id=137857
1340 Reviewed by Andreas Kling.
1342 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1343 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1344 the Apache configuration.
1347 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1348 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1349 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1350 via the cookie and returns a token computed from those two values as well as the remote username.
1352 The font end code then POST's the request along with the returned token. The server side code verifies
1353 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1354 the token hasn't expired.
1357 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1358 have zero or exactly one bug associated with a test run.
1360 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1361 * public/api/runs.php:
1362 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1363 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1364 an associated bug if there is one.
1365 (format_run): Calls parse_bugs_array.
1367 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1368 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1369 have a valid JSON payload.
1370 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1371 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1372 the expiration time stored in the cookie.
1373 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1375 * public/include/manifest.php:
1376 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1377 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1379 * public/index.html:
1380 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1382 * public/privileged-api/associate-bug.php: Added.
1383 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1384 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1386 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1388 * public/v2/app.css:
1389 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1390 selected in a chart.
1393 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1394 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1395 they would overlap on each other if both of them are shown.
1396 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1397 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1398 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1399 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1400 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1401 showing the search pane.
1402 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1403 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1404 bugs in the selected range.
1406 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1407 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1408 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1409 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1410 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1411 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1412 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1413 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1415 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1416 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1417 to selectionChanged action instead of just finding the first and the last points.
1419 * public/v2/chart-pane.css: Updated the style.
1421 * public/v2/data.js:
1422 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1423 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1424 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1425 we haven't already obtained a CSRF token or if the token has already been expired.
1426 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1428 (Measurement.prototype.bugs): Added.
1429 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1430 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1432 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1435 * public/v2/manifest.js:
1436 (App.BugTracker.bugUrl):
1437 (App.BugTracker.newBugUrl): Added.
1438 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1439 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1440 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1441 (App.Manifest.bugTrackers): Added.
1442 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1443 their respective ids to make the ordering stable.
1445 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1447 Remove unused jobs table
1448 https://bugs.webkit.org/show_bug.cgi?id=137724
1450 Reviewed by Daniel Bates.
1452 Removed jobs table in the database as well as related code.
1454 * init-database.sql:
1455 * public/admin/jobs.php: Removed.
1456 * public/admin/tests.php:
1457 * public/include/admin-header.php:
1459 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1461 New perf dashboard should have an ability to search commits by a keyword
1462 https://bugs.webkit.org/show_bug.cgi?id=137675
1464 Reviewed by Geoffrey Garen.
1466 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1467 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1468 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1470 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1471 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1473 * public/api/commits.php:
1474 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1475 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1476 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1477 (format_commit): Renamed from format_commits. Now only formats one commit.
1479 * public/include/db.php:
1480 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1482 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1485 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1486 which is a hash table that contains highlighted items' measurements' ids as keys.
1487 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1488 the default commit repository.
1489 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1490 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1491 Added the code to initialize this._highlights.
1492 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1493 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1494 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1495 the existing lines for the old highlighted items.
1496 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1497 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1499 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1501 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1502 (CommitLogs): Added.
1503 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1504 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1505 (CommitLogs._cacheConsecutiveCommits): Ditto.
1506 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1507 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1508 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1510 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1511 for showingDetails since this property is no longer used.
1513 * public/v2/manifest.js:
1514 (App.Manifest.repositories): Added.
1515 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1516 the default repository to search.
1517 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1519 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1521 Unreviewed build fix after r174555.
1523 * public/include/manifest.php:
1524 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1525 * tests/admin-regenerate-manifest.js: Fixed the test case.
1527 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1529 New perf dashboard UI tries to fetch commits all the time
1530 https://bugs.webkit.org/show_bug.cgi?id=137592
1532 Reviewed by Andreas Kling.
1534 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1535 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1536 no reported commits as they are all going to fail.
1538 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1539 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1540 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1541 of commits sorted chronologically by time.
1543 * public/include/manifest.php:
1546 (App.CommitsViewerComponent.commitsChanged):
1548 * public/v2/data.js:
1549 (FetchCommitsForTimeRange):
1550 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1552 * public/v2/manifest.js:
1555 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1557 Another unreviewed build fix after r174477.
1559 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1561 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1563 * public/include/report-processor.php:
1565 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1567 Unreviewed build fix after r174477.
1569 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1570 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1572 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1573 This is necessary for baseline and target values manually added via admin pages.
1575 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1577 Add v2 UI for the perf dashboard
1578 https://bugs.webkit.org/show_bug.cgi?id=137537
1580 Rubber-stamped by Andreas Kling.
1583 * public/v2/app.css: Added.
1584 * public/v2/app.js: Added.
1585 * public/v2/chart-pane.css: Added.
1586 * public/v2/data.js: Added.
1587 * public/v2/index.html: Added.
1588 * public/v2/js: Added.
1589 * public/v2/js/d3: Added.
1590 * public/v2/js/d3/LICENSE: Added.
1591 * public/v2/js/d3/d3.js: Added.
1592 * public/v2/js/d3/d3.min.js: Added.
1593 * public/v2/js/ember-data.js: Added.
1594 * public/v2/js/ember.js: Added.
1595 * public/v2/js/handlebars.js: Added.
1596 * public/v2/js/jquery.min.js: Added.
1597 * public/v2/js/statistics.js: Added.
1598 * public/v2/manifest.js: Added.
1599 * public/v2/popup.js: Added.
1601 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1603 Remove superfluously duplicated code in public/api/report-commits.php.
1605 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1607 Perf dashboard should store commit logs
1608 https://bugs.webkit.org/show_bug.cgi?id=137510
1610 Reviewed by Darin Adler.
1612 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
1614 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
1615 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
1616 a subversion directory. The git version of this script will be added in a follow up patch.
1619 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
1620 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
1621 relationship via "build_commits" relations.
1623 In order to migrate an existing instance of this application, run the following SQL commands:
1627 INSERT INTO commits (commit_repository, commit_revision, commit_time)
1628 (SELECT DISTINCT ON (revision_repository, revision_value)
1629 revision_repository, revision_value, revision_time FROM build_revisions);
1631 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
1632 FROM commits, build_revisions
1633 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
1635 DROP TABLE build_revisions;
1640 The helper script to submit commit logs can be used as follows:
1642 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
1643 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
1645 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
1646 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
1647 "feeder-slave-password" as the builder name and the builder password respectively.
1649 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
1650 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
1653 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
1655 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
1656 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
1658 - Not specified - It returns every single commit for a given repository.
1659 - Matches "oldest" - It returns the commit with the oldest timestamp.
1660 - Matches "latest" - It returns the commit with the latest timestamp.
1661 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
1662 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
1663 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
1664 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
1665 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
1666 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
1668 (commit_from_revision):
1669 (fetch_commits_between):
1672 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
1673 See tests/api-report-commits.js for examples on how to use this API.
1675 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
1676 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
1677 to optimize this and other JSON APIs.
1679 * public/include/db.php:
1680 (Database::select_or_insert_row):
1681 (Database::update_or_insert_row): Added.
1682 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
1683 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
1685 (Database::select_first_row):
1686 (Database::select_last_row): Added.
1687 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
1688 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
1690 * public/include/report-processor.php:
1691 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
1692 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
1693 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
1696 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
1698 * tests/api-report-commits.js: Added.
1699 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
1702 * tools/pull-svn.py: Added. See above for how to use this script.
1704 (determine_first_revision_to_fetch):
1705 (fetch_revision_from_dasbhoard):
1706 (fetch_commit_and_resolve_author):
1709 (resolve_author_name_from_email):
1712 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
1714 Update Install.md for Mavericks and fix typos
1715 https://bugs.webkit.org/show_bug.cgi?id=137276
1717 Reviewed by Benjamin Poulain.
1719 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
1721 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
1723 Finally, init-database.sql is no longer located inside database directory.
1727 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1729 Report run id's in api/runs.php for the new dashboard UI
1730 https://bugs.webkit.org/show_bug.cgi?id=135813
1732 Reviewed by Andreas Kling.
1734 Include run_id in the generated JSON.
1736 * public/api/runs.php:
1737 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
1740 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1742 Merging platforms mixes baselines and targets into reported data
1743 https://bugs.webkit.org/show_bug.cgi?id=135260
1745 Reviewed by Andreas Kling.
1747 When merging two platforms, move test configurations of a different type (baseline, target)
1748 as well as of different metric (Time, Runs).
1750 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
1751 It's sufficient to detect one such test_runs object.
1753 * public/admin/platforms.php:
1756 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
1758 Merging platforms mixes baselines and targets into reported data
1759 https://bugs.webkit.org/show_bug.cgi?id=135260
1761 Reviewed by Geoffrey Garen.
1763 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
1764 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
1766 * public/admin/platforms.php:
1768 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
1770 Build fix after r171361.
1772 * public/js/helper-classes.js:
1773 (.this.formattedBuildTime):
1775 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
1777 Perf dashboard spends 2s processing JSON data during the page loads
1778 https://bugs.webkit.org/show_bug.cgi?id=135152
1780 Reviewed by Andreas Kling.
1782 In the Apple internal dashboard, we were spending as much as 2 seconds
1783 converting raw JSON data into proper JS objects while loading the dashboard.
1785 This caused the apparent unresponsiveness of the dashboard despite of the fact
1786 charts themselves updated almost instantaneously.
1788 * public/index.html:
1789 * public/js/helper-classes.js:
1790 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
1791 lazily as creating new Date objects and running string replace is expensive.
1792 (TestBuild.formattedTime):
1793 (TestBuild.formattedBuildTime):
1794 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
1795 (PerfTestRuns.addResult): Deleted.
1797 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
1799 Perf dashboard shouldn't show the full git hash
1800 https://bugs.webkit.org/show_bug.cgi?id=135083
1802 Reviewed by Benjamin Poulain.
1804 Detect Git/Mercurial hash by checking the length.
1806 If it's a hash, use the first 8 characters in the label
1807 while retaining the full length to be used in hyperlinks.
1809 * public/js/helper-classes.js:
1810 (.this.formattedRevisions):
1813 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
1815 Add an instruction on how to backup the database.
1816 https://bugs.webkit.org/show_bug.cgi?id=133391
1818 Rubber-stamped by Andreas Kling.
1822 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1824 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
1826 * public/js/helper-classes.js:
1827 (PerfTestRuns.smallerIsBetter):
1829 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1833 * public/common.css:
1835 * public/index.html:
1839 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1841 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
1842 https://bugs.webkit.org/show_bug.cgi?id=131157
1844 Reviewed by Andreas Kling.
1846 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
1847 This allows, for example, adding all metrics such as Arithmetic and Geometric for
1848 a given test suite without also adding its subtests.
1850 * public/index.html:
1854 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1856 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
1857 https://bugs.webkit.org/show_bug.cgi?id=131155
1859 Reviewed by Andreas Kling.
1861 The bug was caused by Chart.attach binding event listeners on plot container on each call.
1862 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
1863 click when attach() has been called even number of times, keeping the tooltip invisible.
1865 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
1866 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
1867 is called for the first time.
1869 * public/index.html:
1871 (Chart..bindPlotEventHandlers):
1873 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1875 WebKitPerfMonitor: Tooltips can be cut off at the top
1876 https://bugs.webkit.org/show_bug.cgi?id=130960
1878 Reviewed by Andreas Kling.
1880 * public/common.css:
1881 (#title): Removed the gradients, box shadows, and border from the header.
1882 (#title h1): Reduce the font size.
1883 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
1884 * public/index.html:
1885 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
1886 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
1887 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
1888 * public/js/helper-classes.js:
1889 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
1890 tooltip extending above y=0.
1892 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1894 WebKitPerfMonitor: Y-axis adjustment is too aggressive
1895 https://bugs.webkit.org/show_bug.cgi?id=130937
1897 Reviewed by Andreas Kling.
1899 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
1900 results. This had two major problems:
1901 1. Two standard deviations can be too small to show the confidence interval for results.
1902 2. Sometimes baseline and target can be more than two standards deviations away.
1904 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
1905 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
1906 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
1907 the margin on each side separately to reduce the empty space on either side.
1909 A more rigorous approach would involve computing least squared value of results with respect to intervals
1910 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
1912 * public/index.html:
1913 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
1914 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
1915 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
1916 We wouldn't see the difference between measured values versus baseline and target values otherwise.
1917 * public/js/helper-classes.js:
1918 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
1919 interval delta cannot be computed.
1920 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
1921 within the given interval.
1922 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
1923 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
1924 (PerfTestRuns..unscaledMeansForAllResults):
1925 (PerfTestRuns.min): Take the confidence interval delta into account.
1926 (PerfTestRuns.max): Ditto.
1927 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
1928 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
1930 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
1932 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
1934 Some CSS tweaks after r166477 and r166479,
1936 * public/index.html:
1938 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1940 WebKitPerfMonitor: Sometimes text inside panes overlap
1941 https://bugs.webkit.org/show_bug.cgi?id=130956
1943 Reviewed by Gyuyoung Kim.
1945 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
1946 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
1947 reduces the total height of the pane and fits more information per screen capita on the dashboard.
1949 * public/index.html: Updated and added a bunch of CSS rules for the new look.
1950 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
1951 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
1952 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
1953 of the build info shown in a chart pane and a tooltip.
1954 (Chart): Made .status a table.
1955 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
1956 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
1957 now that status.text no longer contains it.
1958 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
1960 * public/js/helper-classes.js:
1961 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
1962 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
1963 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
1964 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
1965 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
1966 capital letter; e.g. "MB" instead of "M B".
1968 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1970 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
1971 https://bugs.webkit.org/show_bug.cgi?id=130957
1973 Reviewed by Gyuyoung Kim.
1975 Moved the slider into the header. Also reduced the spacing between the header and platform names.
1976 This reclaims 50px × width of the screen real estate.
1978 * public/common.css:
1979 (#title): Reduced the space below the header from 20px to 10px.
1980 * public/index.html:
1981 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
1982 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
1983 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
1984 real estate between the header and the platform names.
1986 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
1988 Update the install guidelines for perf.webkit.org
1989 https://bugs.webkit.org/show_bug.cgi?id=129895
1991 Reviewed by Ryosuke Niwa.
1993 The current install guideline for perf.webkit.org discourages the use of the installed
1994 Server application. I've actualized the documentation for Mavericks, and modified the
1995 guideline to include the instructions for Server.app also.
1999 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
2001 Update perf.webkit.org json example
2002 https://bugs.webkit.org/show_bug.cgi?id=129907
2004 Reviewed by Andreas Kling.
2006 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
2010 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
2012 Merge database-common.js and utility.js into run-tests.js.
2014 Reviewed by Matthew Hanson.
2016 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
2017 Also moved init-database.sql out of the database directory and removed the directory entirely.
2019 * database: Removed.
2020 * database/database-common.js: Removed.
2021 * database/utility.js: Removed.
2022 * init-database.sql: Moved from database/init-database.sql.
2024 (connect): Moved from database-common.js.
2025 (pathToDatabseSQL): Extracted from pathToLocalScript.
2026 (pathToTests): Moved from database-common.js.
2029 (SerializedTaskQueue): Ditto.
2031 (initializeDatabase):
2032 (TestEnvironment.it):
2033 (TestEnvironment.queryAndFetchAll):
2036 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2038 Remove the dependency on node.js from the production code.
2040 Reviewed by Ricky Mondello.
2042 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
2044 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
2045 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
2046 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
2047 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
2048 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
2050 Also removed the js files that are no longer used.
2052 * config.json: Moved from database/config.json.
2053 * database/aggregate.js: Removed. No longer used.
2054 * database/database-common.js: Removed unused functions, and updated the path to config.json.
2055 * database/process-jobs.js: Removed. No longer used.
2056 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2057 * database/schema.graffle: Removed. It's completely obsolete.
2058 * public/include/db.php: Updated the path to config.json.
2059 * public/include/evaluator.js: Removed.
2061 * public/include/report-processor.php:
2062 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2063 storing values into $expressions and calling evaluate_expressions_by_node.
2064 (TestRunsGenerator::aggregate_values): Added.
2065 (TestRunsGenerator::compute_caches): Directly compute the caches.
2067 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2069 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2071 * public/admin/platforms.php:
2072 * public/include/db.php:
2074 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2076 Zoomed y-axis view is ununsable when the last result is an outlier.
2078 Reviewed by Stephanie Lewis.
2080 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2081 the last result so that the graph looks sane if the last result was an outlier. However, always show
2082 the last result's mean even if it was an outlier.
2084 * public/index.html:
2085 * public/js/helper-classes.js:
2086 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2087 Also added the ability to cache the unscaled means to avoid recomputation.
2088 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2089 (PerfTestRuns.max): Ditto.
2090 (PerfTestRuns.sampleStandardDeviation): Ditto.
2091 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2093 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2097 * public/admin/tests.php:
2098 * public/js/helper-classes.js:
2100 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2102 Use two standard deviations instead as I mentioned in the mailing list.
2104 * public/index.html:
2106 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2108 The performance dashboard erroneously shows upward arrow for combined metrics.
2110 A single outlier can ruin the zoomed y-axis view.
2112 Rubber-stamped by Antti Koivisto.
2114 * public/index.html:
2115 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2116 from the latest results' mean.
2117 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2118 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2119 (Chart.toggleYAxis):
2120 * public/js/helper-classes.js:
2121 (PerfTestRuns.sampleStandardDeviation): Added.
2122 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2124 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2126 Don't include the confidence interval when computing the y-axis.
2128 Rubber-stamped by Simon Fraser.
2130 * public/js/helper-classes.js:
2134 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2136 Tiny CSS tweak for tooltips.
2138 * public/index.html:
2140 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2142 Remove the erroneously repeated code.
2144 * public/admin/test-configurations.php:
2146 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2148 <rdar://problem/15704893> perf dashboard should show baseline numbers
2150 Reviewed by Stephanie Lewis.
2152 * public/admin/bug-trackers.php:
2153 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2156 * public/admin/platforms.php:
2157 (merge_list): Ditto.
2159 * public/admin/test-configurations.php: Added.
2160 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2161 build_revisions as they're not meaningful for baseline / target numbers.
2162 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2163 one test run so that we don't accidentally delete a reported test run.
2164 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2165 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2166 and delete existing ones.
2168 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2169 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2170 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2172 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2173 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2174 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2175 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2176 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2178 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2180 * public/include/admin-header.php:
2181 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2182 have id and type sub columns, and each custom column could generate multiple rows.
2184 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2185 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2186 We then proceed to generate the second header row with sub column names.
2188 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2189 which case regular columns need rowspan set to the maximum number of rows.
2191 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2194 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2195 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2196 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2197 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2198 expanded to occupy all sub columns.
2200 * public/include/manifest.php:
2201 (ManifestGenerator::platforms): Don't add the metric more than once.
2203 * public/include/test-name-resolver.php:
2204 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2205 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2206 full metric name later.
2207 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2208 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2209 (TestNameResolver::full_name_for_test): Added.
2210 (TestNameResolver::full_name_for_metric): Added.
2211 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2213 * public/js/helper-classes.js:
2214 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2215 test runs created to set baseline and target points.
2217 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2219 Build fix after r57928. Removed a superfluous close parenthesis.
2221 * public/api/runs.php:
2223 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2225 Unreviewed build & typo fixes.
2227 * public/admin/platforms.php:
2228 * tests/admin-platforms.js:
2230 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2232 <rdar://problem/15704893> perf dashboard should show baseline numbers
2234 Rubber-stamped by Antti Koivisto.
2236 Organize some code into functions in runs.php.
2238 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2240 * public/api/runs.php:
2241 (fetch_runs_for_config): Extracted.
2242 (format_run): Ditto.
2244 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2246 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2248 * database/config.json:
2249 * public/admin/reprocess-report.php:
2250 * public/api/report.php:
2251 * public/api/runs.php:
2252 * public/include/json-header.php:
2254 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2256 Commit yet another forgotten change.
2258 Something went horribly wrong with my merge :(
2260 * database/init-database.sql:
2262 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2264 Commit one more forgotten change. Sorry for making a mess here.
2266 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2268 Commit the forgotten files.
2270 * public/admin/platforms.php: Added.
2271 * tests/admin-platforms.js: Added.
2273 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2275 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2277 Reviewed by Stephanie Lewis.
2279 Added /admin/platforms/ page to hide and merge platforms.
2281 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2282 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2283 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2284 each test configuration a distinct "test run" for each build.
2286 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2287 their test configurations into platform B.
2289 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2290 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2291 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2292 in platform B, in which case R should relate to T_B instead.
2294 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2295 new platform. We then migrate the test configurations of the remaining test runs.
2297 * database/init-database.sql: Added platform_hidden.
2299 * public/admin/platforms.php: Added.
2300 (merge_platforms): Added. Implements the algorithm described above.
2301 (merge_list): Added.
2303 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2304 is hidden since it doesn't do anything.
2306 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2307 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2308 missing it since unchecked checkbox doesn't set the value in $_POST.
2309 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2310 switch statement instead of repeated if's.
2311 (AdministrativePage::render_table): Emit "update-column" for update_field.
2313 * public/include/db.php: Disable warnings when we're not in the debug mode.
2315 * public/include/manifest.php:
2316 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2319 (TestEnvironment.postJSON):
2320 (TestEnvironment.httpGet):
2321 (TestEnvironment.httpPost): Added.
2322 (sendHttpRequest): Set the content type if specified.
2324 * tests/admin-platforms.js: Added tests.
2326 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2328 Extract the code to compute full test names from tests.php.
2330 Reviewed by Stephanie Lewis.
2332 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2333 and paves our way to re-use the code in other pages.
2335 * public/admin/tests.php:
2337 * public/include/db.php:
2338 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2339 tests.php and test-name-resolver.php.
2341 * public/include/test-name-resolver.php: Added.
2342 (TestNameResolver::__construct):
2343 (TestNameResolver::compute_full_name): Moved from tests.php.
2344 (TestNameResolver::map_metrics_to_tests): Ditto.
2345 (TestNameResolver::sort_tests_by_full_name): Ditto.
2346 (TestNameResolver::tests): Added.
2347 (TestNameResolver::test_id_for_full_name): Ditto.
2348 (TestNameResolver::metrics_for_test_id): Ditto.
2349 (TestNameResolver::child_metrics_for_test_id): Ditto.
2350 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2352 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2354 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2356 Reviewed by Stephanie Lewis.
2358 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2360 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2361 but that's sufficient to correct the wrongfully processed reports for now.
2363 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2364 We should eventually add a nice UI to find and reprocess reports.
2366 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2368 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2370 * public/include/report-processor.php: Copied from public/api/report.php.
2371 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2372 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2373 create a new report or authenticate the builder password (the password is never stored in the report).
2374 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2375 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2376 (ReportProcessor::store_report): Ditto.
2378 * tests/admin-reprocess-report.js: Added.
2380 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2382 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2384 Reviewed by Ricky Mondello.
2386 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2387 for the same build number as a single build by ignoring build time. This was necessary to associate
2388 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2389 we use to submit results computed its own "build time" when they're called.
2391 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2392 last week; new reports were wrongfully associated with old build numbers.
2394 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2395 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2396 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2398 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2399 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2400 (builder, build number, build time).
2402 * public/api/report.php:
2403 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2404 when no such build exists. This prevents a report from being associated with a very old build of the same
2407 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2408 a similar bug in the future sooner.
2410 * tests/api-report.js: Added three test cases.
2412 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2414 Merged the upstream changes to db.php
2415 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2417 * public/include/db.php:
2419 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2421 Update other scripts and tests per previous patch.
2423 * public/include/manifest.php:
2424 * tests/admin-regenerate-manifest.js:
2426 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2428 Remove metrics_unit.
2430 Reviewed by Ricky Mondello.
2432 This column is no longer used by the front-end code since r48360.
2434 * database/init-database.sql:
2435 * public/admin/tests.php:
2437 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2439 Unreviewed build fix.
2441 * public/api/report.php:
2443 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2445 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2447 Reviewed by Ricky Mondello.
2449 Support a new alternative format for aggregated results where we have raw values as well as
2450 the list aggregators so that instead of
2451 "metrics": {"Time": ["Arithmetic"]}
2453 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2455 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2456 dashboard and the generated results page, which doesn't know how to aggregate values.
2458 We need to keep the support for the old format because all other existing performance tests
2459 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2460 the old format during the transition.
2462 * public/api/report.php:
2463 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2464 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2466 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2468 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2470 Unreviewed; Tweak the CSS so that chart panes align vertically.
2472 * public/index.html:
2474 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2476 SafariPerfMonitor should support Combined metric.
2478 * public/js/helper-classes.js:
2479 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2480 value as well but assume it to be greater-is-better for now.
2482 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2484 Commit the forgotten init-database change to add iteration_relative_time.
2486 * database/init-database.sql:
2488 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2490 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2492 Reviewed by Ricky Mondello.
2494 Add the support for each value to have a relative time. This is necessary for frame rate history
2495 since a frame rate needs to be associated with a time it was sampled.
2497 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2499 * public/api/report.php:
2500 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2501 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2502 with relative time since taking the average of two frame rates for two subtests taken at two
2503 different times doesn't make any sense.
2504 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2505 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2506 Also exit early with an error if the number of elements in the array is not a pair.
2507 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2509 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2510 iteration_relative_time.
2512 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2514 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2516 Reviewed by Ricky Mondello.
2518 Support that. It's one line change.
2520 * public/api/report.php:
2521 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2522 to match the convention assumed elsewhere.
2523 * tests/api-report.js: Added a test case.
2525 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2527 SafariPerfMonitor shows popups for points outside of the visible region.
2529 Rubber-stamped by Simon Fraser.
2531 * public/index.html:
2532 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2533 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2534 may return an item underneath y-axis labels.
2536 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2538 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2540 * public/index.html:
2542 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2544 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2546 * public/index.html:
2548 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2550 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2551 <rdar://problem/13992271> Should scale Y axis to include error ranges
2553 Reviewed by Ricky Mondello.
2555 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2556 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2558 * database/config.json:
2559 * public/index.html:
2560 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2561 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2562 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2564 * public/js/helper-classes.js:
2565 (PerfTestResult.confidenceIntervalDelta):
2566 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2567 (PerfTestRuns.min): Take confidence interval delta into account.
2568 (PerfTestRuns.max): Ditto.
2569 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2571 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2573 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2575 * public/api/report.php:
2576 (ReportProcessor::recursively_ensure_tests):
2577 * tests/api-report.js: Added a test.
2579 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2581 Unreviewed build fixes.
2583 * public/api/report.php:
2584 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
2585 Also, tolerate reports without any revision information.
2587 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
2590 * tests/api-report.js: Added few test cases.
2592 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2594 Commit another change that was supposed to be committed in r50331.
2597 (TestEnvironment.this.postJSON):
2598 (TestEnvironment.this.httpGet):
2601 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
2603 Commit the remaining files.
2605 * public/admin/regenerate-manifest.php:
2606 * public/include/admin-header.php:
2607 * public/include/json-header.php:
2608 * public/include/manifest.php:
2610 (TestEnvironment.this.postJSON):
2611 (TestEnvironment.this.httpGet):
2614 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
2616 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
2618 Reviewed by Ricky Mondello.
2620 Added some tests for admin/regenerate-manifest.
2622 * public/admin/regenerate-manifest.php: Use require_once instead of require.
2623 * public/include/admin-header.php: Ditto.
2624 * public/include/json-header.php: Ditto.
2626 * public/include/manifest.php:
2627 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
2628 When there are no builders, simply return an empty array.
2631 (TestEnvironment.postJSON):
2632 (TestEnvironment.httpGet): Added.
2633 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
2635 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
2637 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
2639 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
2640 and run_iterations. Also fixed a typo in report.php found by new tests.
2642 * public/api/report.php:
2643 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
2644 * tests/api-report.js: Added more test cases.
2646 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
2648 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
2650 Reviewed by Ricky Mondello.
2652 Add a test runner script and some simple test cases.
2654 * database/config.json: Added the configuration for "testServer".
2655 * database/database-common.js:
2656 (pathToTests): Added.
2657 * run-tests.js: Added.
2660 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
2661 and if there are, asks the user if it’s okay to delete all of the data contained therein.
2662 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
2664 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
2665 in the current database using PostgreSQL's information_schema.
2666 (askYesOrNoQuestion):
2668 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
2670 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
2671 (TestEnvironment.assert): Exposes assert to tests.
2672 (TestEnvironment.console): Exposes console to tests.
2673 (TestEnvironment.describe): Adds a description.
2674 (TestEnvironment.it): Adds a test case.
2675 (TestEnvironment.postJSON):
2676 (TestEnvironment.queryAndFetchAll):
2677 (TestEnvironment.sha256):
2678 (TestEnvironment.notifyDone): Ends the current test case.
2682 (TestContext): An object created for each test case. Conceptually, this object is always on
2683 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
2684 this object via currentTestContext.
2685 (TestContext.description):
2687 (TestContext.logError):
2690 * tests/api-report.js: Added some basic tests for /api/report.php.
2692 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2694 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
2696 The problem was that we were detecting whether we're updating dashboard or not by checking
2697 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
2698 all configurations. Use separate 'dashboard' action to execute the code even when
2699 metric_configurations is empty.
2701 * public/admin/tests.php:
2703 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2705 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
2707 Reviewed by Ricky Mondello.
2709 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
2710 from ReportProcessor as a preparation to replace deprecated aggregate.js.
2712 * public/api/report.php:
2713 (ReportProcessor::exit_with_error): Moved.
2714 (ReportProcessor::process): Use the extracted TestRunsGenerator.
2715 (TestRunsGenerator): Added.
2716 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
2717 (TestRunsGenerator::add_aggregated_metric): Moved.
2718 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
2719 (TestRunsGenerator::aggregate): Moved. Made public.
2720 (TestRunsGenerator::aggregate_current_test_level): Moved.
2721 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
2722 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
2723 (TestRunsGenerator::compute_caches): Moved. Made public.
2724 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
2725 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
2726 (TestRunsGenerator::rollback_with_error): Moved.
2728 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2730 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
2732 Reviewed by Remy Demarest.
2734 Regenerate the manifest file when updating fields or adding new items that are included in
2737 * public/admin/bug-trackers.php:
2738 * public/admin/builders.php:
2739 * public/admin/regenerate-manifest.php:
2740 * public/admin/repositories.php:
2741 * public/admin/tests.php:
2742 * public/include/admin-header.php:
2743 (regenerate_manifest): Extracted from regenerate-manifest.php.
2745 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2747 Unreviewed build fix for memory test results.
2749 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
2750 aggregating at each level.
2752 * public/api/report.php:
2753 (ReportProcessor::recursively_ensure_tests):
2754 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
2755 (ReportProcessor::add_values_for_aggregation):
2756 (ReportProcessor::aggregate):
2757 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
2759 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
2761 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
2762 not the number of iteration groups. Also, don't set group number when the entire run belongs
2763 a single iteration group.
2765 * public/api/report.php:
2766 (ReportProcessor::commit):
2768 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2770 SafariPerfMonitor: Introduce iteration groups
2772 Reviewed by Remy Demarest.
2774 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
2775 the runtime environment variances to get more stable results. And it's desirable to keep track of
2776 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
2778 This patch introduces "iteration groups" to keep track of this extra information.
2780 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
2781 the outer array denotes iteration groups and each inner array contains iteration values for each group.
2784 * database/init-database.sql: Add iteration_group column.
2785 * public/api/report.php:
2786 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
2788 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
2789 contains the list of values indexed by the iteration order and group sizes. Store the group size so
2790 that we can restore the iteration groups before passing it to node.js and restore them later.
2792 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
2793 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
2795 Also check that each iteration group in each subtest are consistent with one another. To see why we need
2796 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
2797 that each iteration group in T1 and T2 have the same size:
2798 T1 = [[1, 2], [3, 4, 5]]
2799 T2 = [[6, 7], [8, 9, 10]]
2801 so that the aggregated result (the sum in this case) can have the same groups as in:
2802 T = [[7, 9], [11, 13, 15]]
2804 If some iteration groups in T1 and T2 had a different size as in:
2805 T1 = [[1, 2, 3], [4, 5]]
2806 T2 = [[6, 7], [8, 9, 10]]
2808 Then iteration groups of the aggregated T is ambiguous.
2810 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
2811 (ReportProcessor::commit): Store iteration_group values.
2813 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2815 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
2816 migrated to perf.webkit.org.
2818 * database/perf-webkit-migrator.js: Removed.
2820 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2822 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
2824 * public/index.html:
2827 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2829 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
2831 Reviewed by Ricky Mondello.
2833 It is often desirable to see charts of a given test for all platforms, or to be able to see
2834 charts of all subtests on a given platform when trying to triage perf. regressions.
2836 Support this use case by adding the ability to do so on the charts page.
2838 Also, we used to disable items on the test list based on the platform chosen. This turned out
2839 to be a bad UI because in many situations you want to be able to compare results of the same test
2840 on multiple platforms.
2842 In this new UI, we have three select elements, each of which selects the following:
2843 1. Top-level test - Test suite such as Dromaeo
2844 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
2845 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
2846 3. Platform - Mountain Lion, Qt, etc...
2848 A user can select "all" for metric and platform but we disallow doing both at once since adding
2849 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
2850 think of a use case where you want to look at that many charts at once. We can support this later
2851 if valid use cases come up.
2853 * public/index.html:
2854 (.showCharts.addOption): Extracted.
2855 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
2856 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
2857 metricList has onchange handler that enables/disables items on platformList.
2859 (init): Sort tests and test metrics here instead of doing that in showCharts.
2861 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
2863 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
2865 Reviewed by Remy Demarest and Ricky Mondello.
2867 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
2868 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
2869 templates to the manifest file instead. Each build now only contains the builder id.
2871 * public/api/runs.php: Removed the part of the query that joined builders table. This
2872 speeds up the query quite a bit.
2874 * public/include/manifest.php:
2875 (ManifestGenerator::generate): Generate builders field.
2876 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
2877 associative array that contains name and its build URL template.
2879 * public/index.html:
2880 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
2881 instead of a revision since this function is used for revisions and build page URLs now.
2882 (.buildLabelWithLinks): Include the linkified build number.
2884 * public/js/helper-classes.js:
2885 (TestBuild.builder): Added.
2886 (TestBuild.buildNumber): Added.
2887 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
2888 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
2890 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
2892 Tooltips interfere with user interactions
2894 Rubber-stamped by Simon Fraser.
2896 Disable tooltip on the dashboard page since graphs are too small to be useful there.
2897 Also, show graphs for only 10 days by default as opposed to 20.
2898 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
2900 * public/index.html:
2901 * public/js/helper-classes.js:
2903 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
2905 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
2906 to be compatible with webkit-perf.appspot.com.
2908 * public/admin/builders.php:
2909 * public/api/report.php:
2911 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
2915 Add a missing constraint on builds table. For a given builder, there should be exactly
2916 one build for a given build number.
2918 Also add report_committed_at to reports table to record the time at which a given report
2919 was processed and test_runs and run_iterations rows were committed into the database.
2921 * database/config.json:
2922 * public/api/report.php:
2924 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
2926 Unreviewed. Add more checks for empty SQL query results.
2928 * public/include/manifest.php:
2930 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2932 More build fixes on perf.webkit.org.
2934 * public/api/runs.php: Make PostgreSQL happier.
2935 * public/include/manifest.php: Don't assume we always have bug trackers.
2937 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2939 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
2940 and fix other miscellaneous UI bugs.
2942 Rubber-stamped by Simon Fraser.
2944 Removed the code to determine whether smaller value is better or not for a given test in index.html
2945 in the favor of using that of PerfTestRuns.
2947 * public/include/manifest.php: Fixed a typo.
2948 * public/index.html:
2950 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
2952 * public/js/helper-classes.js:
2953 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
2955 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
2956 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
2957 at roughly 2,000 units to avoid this.
2959 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
2960 The only thing we can avoid is innerHTML.
2962 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2964 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
2966 * public/include/evaluator.js:
2968 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2970 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
2972 Reviewed by Remy Demarest.
2974 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
2975 admin/bug-trackers.php and can be associated with multiple repositories.
2977 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
2978 to determine the set of bug trackers to show for a given set of blame lists.
2979 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
2980 a place to file bugs against the regression.
2982 * database/init-database.sql: Added bug_trackers and tracker_repositories.
2983 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
2985 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
2986 bug trackers, namely associated repositories.
2988 * public/include/admin-header.php: Added a link to bug-trackers.php
2989 * public/include/manifest.php:
2990 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
2991 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
2993 (ManifestGenerator::repositories):
2995 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
2996 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
2997 'repositories' where the latter contains the list of associated repository names.
2999 * public/index.html:
3000 (Chart): Takes bugTrackers as as argument.
3001 (Chart.showTooltipWithResults): Removed the hard-coded list.
3003 (init.addPlatformsToDashboard):
3004 (init.showCharts.createChartFromListPair):
3005 (init): Stores the list of bug trackers in the manifest to a local variable.
3007 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3009 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
3011 * public/include/evaluator.js:
3013 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3015 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
3017 Reviewed by Remy Demarest.
3019 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
3020 new row into the database.
3022 * public/admin/aggregators.php: Use AdministrativePage.
3023 * public/admin/builders.php: Ditto.
3024 * public/admin/repositories.php: Ditto.
3025 * public/include/admin-header.php:
3026 (AdministrativePage): Added.
3027 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
3028 to an associative array that describes the column.
3029 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
3030 - label: Human readable name of the column.
3031 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
3032 column exists only before we create password_hash column at the insertion time.
3034 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
3035 titlecase (e.g. new_bug is converted to New Bug).
3036 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
3037 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
3038 textarea for a given editing mode ('text', 'url', or 'string').
3039 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
3040 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
3042 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
3044 Build fix. Some systems don't support r+. Use proc_open instead.
3046 * public/api/report.php:
3048 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3050 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
3051 when computing the y-axis of data points to show tooltips at.
3053 * public/index.html:
3055 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3057 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
3060 * public/.htaccess: Removed.
3062 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
3066 * public/include/manifest.php: Build fix. db is on this.
3067 * public/js/statistics.js:
3068 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
3070 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
3072 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
3074 Reviewed by Anders Carlsson.
3076 Rewrote and merged populate-from-report.js into report.php.
3078 * database/config.json: Added a path to node.js.
3080 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
3081 Once we land this patch and update the administrative pages, we can remove this column.
3083 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
3084 that table is going away once we remove the node.js backend.
3086 * database/populate-from-report.js: Removed.
3087 * public/api/report.php: Added.
3089 (ReportProcessor.__construct):
3090 (ReportProcessor.process):
3092 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
3093 verified to be submitted by a known builder.
3095 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
3096 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
3097 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
3098 inside a transaction because there could be multiple reports for a single build, each containing results for
3101 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
3102 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
3103 add_values_to_commit, and add_values_for_aggregation.
3105 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
3106 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
3107 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
3110 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
3111 to be aggregated in ReportProcessor.aggregate.
3113 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
3115 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
3116 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
3117 given for each row (child metrics of M). This function extracts each column (iteration) via
3118 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
3119 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
3121 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
3122 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
3123 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
3125 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
3126 (ReportProcessor.evaluate_expressions_by_node): See above.
3128 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
3129 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
3130 results also need the said caches.
3132 (ReportProcessor.add_values_to_commit):
3134 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
3135 the transaction as needed if anything goes wrong.
3137 (ReportProcessor.rollback_with_error)
3139 * public/include/db.php:
3140 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
3141 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
3142 contiguously in a SQL statement.
3144 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
3145 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
3146 a column value of the choice.
3148 (Database.begin_transaction): Added.
3149 (Database.commit_transaction): Added.
3150 (Database.rollback_transaction): Added.
3152 * public/include/evaluator.js: Added.
3153 * public/include/json-header.php:
3154 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
3155 context under which the request failed.
3156 (successful_exit): Merge "additional details".
3157 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
3158 (merge_additional_details):
3160 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
3162 SafariPerfMonitor: Add more helper functions to db.php
3164 Reviewed by Remy Demarest.
3166 Added Database::insert_row and array_get to make common database operations easier.
3168 * public/admin/aggregators.php: Use Database::insert_row instead of
3169 execute_query_and_expect_one_row_to_be_affected.
3171 * public/admin/builders.php: Ditto.
3173 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
3174 inserting a row. With insert_row, we don't need that.
3176 * public/include/admin-header.php: Ditto.
3178 * public/include/db.php:
3179 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
3180 return the default value (defaults to NULL) if the key doesn't exist.
3182 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
3185 (Database::prepare_params): Added. Takes an associative array of column names and their values,
3186 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
3187 column names all in the same order.
3189 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
3190 the given prefix. Values are given in a form of an associative array where keys are unprefixed
3191 column names and values are corresponding values. When the row is successfully inserted, it returns
3192 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
3193 indicating the success of the insertion.
3195 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3197 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
3199 Reviewed by Conrad Shultz.
3201 Rewrote the manifest generator in PHP.
3203 * database/generate-manifest.js: Removed.
3204 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
3205 * public/include/db.php:
3206 (array_ensure_item_has_array): Added.
3207 * public/include/evaluator.js: Added.
3208 * public/include/json-header.php:
3209 * public/include/manifest.php: Added.
3211 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3213 Dates on overflow plot are overlapping
3215 Rubber-stamped by Simon Fraser.
3217 Don't show more than 5 days.
3219 * public/index.html:
3220 * public/js/helper-classes.js:
3221 (TestBuild.UTCtoPST):
3224 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3226 Show build time as well as commit time on the dashboard and tooltips.
3228 Rubber-stamped by Simon Fraser.
3230 Include both the maximum commit time and build time in buildLabelWithLinks.
3231 Also use ISO format to save the screen real estate.
3233 * public/index.html:
3234 (buildLabelWithLinks):
3235 * public/js/helper-classes.js:
3237 (TestBuild.buildTime):
3238 (TestBuild.formattedBuildTime):
3240 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
3242 Unreviewed; Convert metric.name to metric.unit in the front end.
3244 * public/js/helper-classes.js:
3246 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3248 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
3250 Rubber-stamped by Simon Fraser.
3252 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
3253 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
3254 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
3256 * public/index.html:
3257 (.buildLabelWithLinks): Extracted from TestBuild.label.
3258 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
3259 on Radar and WebKit Bugzilla.
3260 * public/js/helper-classes.js:
3261 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
3262 (PerfTestResult.isBetterThan): Added.
3263 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
3264 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
3265 to indicate progressions or regressions.
3266 (PerfTestResult.label):
3267 (TestBuild.formattedTime): Added.
3268 (TestBuild.platform): Added.
3269 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
3270 (TestBuild.smallerIsBetter): Added.
3271 (Tooltip.show): Take a raw markup instead of two results.
3273 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
3275 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
3277 Rubber-stamped by Tim Horton.
3279 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
3280 since each platform may have a different number of tests to be shown on the dashboard.
3282 * public/index.html:
3284 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3286 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
3288 * public/js/helper-classes.js:
3291 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3293 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
3295 Rubber-stamped by Tim Horton.
3297 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
3299 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
3300 the revision r1234 was the revision used in the previous build.
3302 * public/api/runs.php:
3303 (parse_revisions_array): Trim double quotations around repository names and revisions.
3304 * public/js/helper-classes.js:
3307 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3309 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
3311 Rubber-stamped by Tim Horton.
3313 * public/index.html:
3314 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
3315 on the dashboard page as it's way too noisy.
3317 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
3319 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
3320 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
3321 so that the tooltip for hover can be reused further.
3323 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
3324 and find the first point that lies on the right of the cursor position. We then compute the midpoint
3325 between this and the previous point and pick the closer of the two. It returns an item-like object
3326 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
3328 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
3330 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
3331 the first or "current" data points (as opposed to target or baseline data points).
3333 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
3334 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
3335 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
3337 * public/js/helper-classes.js:
3338 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
3339 work to the client via bindClick.
3341 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
3343 (Tooltip.bindClick): Added.
3345 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3347 Yet another build fix. metricId*s*.
3349 * public/admin/tests.php:
3351 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3353 Another build fix. Use the new payload format for the aggregate job.
3355 * public/admin/tests.php:
3357 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3361 * database/aggregate.js: Use variables that actually exist.
3362 * database/database-common.js:
3363 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
3364 function calls will find this configuration.
3366 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3368 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
3370 Reviewed by Ricky Mondello.
3372 Turned InstallManual into a proper markdown document and added ReadMe.md.
3374 * InstallManual: Removed.
3375 * InstallManual.md: Moved from InstallManual.
3378 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3380 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
3382 Reviewed by Ricky Mondello.
3384 This patch prepares the front end code to process baseline and target results properly.
3386 * public/index.html:
3387 (fetchTest.createRunAndResults): Extracted.
3388 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
3389 Deleted the comment about how sorting will be unnecessary once we start results in the server side
3390 since sorting by the maximum revision commit time turned out to be non-trivial in php.
3392 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3394 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
3396 Reviewed by Tim Horton.
3398 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
3399 These files are "dynamically linked" to our app.
3401 * public/index.html:
3402 * public/js/jquery-1.8.2.min.js: Removed.
3403 * public/js/jquery.colorhelpers.js: Added.
3404 * public/js/jquery.flot.categories.js: Added.
3405 * public/js/jquery.flot.crosshair.js: Added.
3406 * public/js/jquery.flot.errorbars.js: Added.
3407 * public/js/jquery.flot.fillbetween.js: Added.
3408 * public/js/jquery.flot.js: Added.
3409 * public/js/jquery.flot.min.js: Removed.
3410 * public/js/jquery.flot.navigate.js: Added.
3411 * public/js/jquery.flot.resize.js: Added.
3412 * public/js/jquery.flot.selection.js: Added.
3413 * public/js/jquery.flot.stack.js: Added.
3414 * public/js/jquery.flot.symbol.js: Added.
3415 * public/js/jquery.flot.threshold.js: Added.
3416 * public/js/jquery.flot.time.js: Added.
3417 * public/js/jquery.js: Added.
3419 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3421 Return NaN instead of throwing when there aren't enough samples.
3423 Reviewed by Sam Weinig.
3425 It's better to return NaN when we don't have enough samples so that we can treat it
3426 as if we don't have any confidence interval.
3428 * public/js/statistics.js:
3431 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3433 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
3435 * public/js/helper-classes.js:
3436 (URLState.parseIfNeeded):
3438 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3440 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
3442 Reviewed by Ricky Mondello.
3444 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
3446 * public/admin/aggregators.php: Use heredoc.
3447 * public/admin/builders.php:
3448 * public/admin/jobs.php:
3449 * public/admin/repositories.php:
3450 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
3451 This allows us to use update_field when updating test's url and metric's unit. Changed the action
3452 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
3453 Also removed a stray code to update unit and url simultaneously since it's never used.
3454 * public/include/admin-header.php:
3455 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
3456 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
3457 (update_field): Moved from repositories.php.
3459 * public/include/db.php:
3460 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
3462 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
3464 Build fixes. Treat mean, sum, and square sum as float, not int.
3466 Also use 95% confidence interval instead of 90% confidence interval.
3468 * public/api/runs.php:
3469 * public/js/helper-classes.js:
3470 (.this.confidenceIntervalDelta):
3472 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
3474 Add an administrative page to edit repository information.
3476 Reviewed by Ricky Mondello.
3478 * public/admin/repositories.php: Added.
3479 * public/include/admin-header.php:
3481 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
3483 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
3485 Reviewed by Ricky Mondello.
3487 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
3488 to aggregate results for those matrix in populate-from-report.js.
3490 * database/generate-manifest.js:
3491 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
3492 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
3493 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
3494 * database/populate-from-report.js:
3496 (getReport): No change even though the diff looks as if it moved.
3497 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
3498 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
3499 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
3500 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
3501 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
3503 (ensureMetricId): Take an aggregator id as an argument.
3504 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
3505 for all builds when the build id is not specified.
3506 * public/admin/tests.php:
3507 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
3508 of the same name with different aggregators.
3510 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
3512 Build fix. Don't pass in arguments to in the wrong order.
3514 * database/aggregate.js:
3516 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3518 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
3520 Reviewed by Ricky Mondello.
3522 Since the version of flot we use doesn't support showing graphs in the current locate or
3523 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
3524 treat them as in UTC). We don't want to use the current locate because other websites on
3525 webkit.org assume PST.
3527 Also append this information to build's label.
3529 * public/js/helper-classes.js:
3533 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3535 Store test URLs reported by builders.
3537 Reviewed by Ricky Mondello.
3539 * database/populate-from-report.js:
3540 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
3541 (ensureTestId): Store the URL.
3543 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
3545 Yet another build fix; don't blow up even if we didn't have any test configurations.
3547 * public/admin/tests.php:
3549 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3551 Build fix; don't instantiate Date when a timestamp wasn't provided.
3553 * database/populate-from-report.js:
3555 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
3557 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
3559 Reviewed by Tim Horton.
3561 Added an install manual.
3563 * InstallManual: Added.
3565 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
3567 Minor build fix. Don't unset builderPassword when it's not set.
3569 * public/api/report.php:
3571 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3573 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
3575 Reviewed by Ricky Mondello.
3577 * public/admin/admin.css: Make a very large payload scrollable.
3578 * public/admin/jobs.php: Format JSONs.
3580 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
3582 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
3584 Reviewed by Ricky Mondello.
3586 Add report.php and populate-from-report.js that process JSON files submitted by builders.
3588 * database/populate-from-report.js: Added.
3590 (getReport): Obtains the payload (the actual report) from "jobs" table.
3591 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
3592 and their results. This function recursively traverses tests and metrics and ensure their ids.
3594 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
3595 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
3596 is a "function" in mathematical sense).
3598 (ensureRepositoryIdsForAllRevisions):
3599 (getIdOrCreateBuildWithRevisions):
3600 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
3601 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
3602 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
3604 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
3605 test results all in a single transaction. This allows us to keep the database consistent in that either
3606 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
3607 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
3608 other parts of the application are concerned.
3609 (scheduleQueriesToInsertRun):
3610 * database/process-jobs.js: Add a call to populate-from-report.js.
3611 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
3612 * public/include/db.php: Support parameterized query.
3613 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
3614 a test result could confirm that the submission indeed succeeded.
3616 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3618 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
3620 * database/aggregate.js:
3621 * database/database-common.js:
3622 (selectColumnCreatingRowIfNeeded):
3623 (ensureRepositoryId):
3624 (ensureConfigurationIdFromList):
3625 * database/perf-webkit-migrator.js:
3628 (getOrCreateBuildId):
3630 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
3632 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
3634 Reviewed by Ricky Mondello.
3636 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
3637 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
3639 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
3642 (saveAggregatedResults):
3643 * database/database-common.js:
3644 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
3645 (getIdOrCreateRepository): Ditto.
3646 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
3647 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
3648 * database/perf-webkit-migrator.js:
3649 * database/utility.js: Added.
3650 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
3651 from being executed.
3652 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
3653 call the callback passed into start().
3654 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
3655 (TaskQueue.addTask):
3657 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
3658 (SerializedTaskQueue.executeNextTask):
3659 (SerializedTaskQueue.addTask):
3660 (SerializedTaskQueue.start):
3662 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3664 Revert erroneously committed changes.
3666 * database/config.json:
3668 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3670 aggregator.js should be able to accept multiple metric ids and a single build id.
3672 Reviewed by Ricky Mondello.
3674 Make aggregator.js accept multiple ids and generate results for single build when bots are
3675 reporting new results.
3677 * database/aggregate.js:
3678 (parseArgv): Added. Returns an object containing the parsed representation of argv,
3679 which currently contains metricIDs and buildIds.
3680 (main): Use parseArgv and processConfigurations
3681 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
3682 (processPlatform.processConfigurations): Extracted.
3684 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
3686 Add an administrative page for builders.
3688 Reviewed by Ricky Mondello.
3690 We need an administrative page to add and edit builder information.
3691 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
3693 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
3694 since we don't have plans to use those columns in near future. Also make builder_name unique
3695 as required by the rest of the app.
3696 * public/admin/builders.php: Added.
3697 * public/api/runs.php: Updated per the table rename.
3698 * public/include/admin-header.php: Added a link to builders.php.
3700 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
3702 Build fixes for r46982.
3704 * database/aggregate.js:
3705 (fetchConfigurations): Bind i so that it's not always metricIds.length.
3706 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller&