1 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
3 Unreviewed build fix after r174555.
5 * public/include/manifest.php:
6 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
7 * tests/admin-regenerate-manifest.js: Fixed the test case.
9 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
11 New perf dashboard UI tries to fetch commits all the time
12 https://bugs.webkit.org/show_bug.cgi?id=137592
14 Reviewed by Andreas Kling.
16 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
17 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
18 no reported commits as they are all going to fail.
20 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
21 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
22 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
23 of commits sorted chronologically by time.
25 * public/include/manifest.php:
28 (App.CommitsViewerComponent.commitsChanged):
31 (FetchCommitsForTimeRange):
32 (FetchCommitsForTimeRange._cachedCommitsByRepository):
34 * public/v2/manifest.js:
37 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
39 Another unreviewed build fix after r174477.
41 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
43 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
45 * public/include/report-processor.php:
47 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
49 Unreviewed build fix after r174477.
51 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
52 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
54 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
55 This is necessary for baseline and target values manually added via admin pages.
57 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
59 Add v2 UI for the perf dashboard
60 https://bugs.webkit.org/show_bug.cgi?id=137537
62 Rubber-stamped by Andreas Kling.
65 * public/v2/app.css: Added.
66 * public/v2/app.js: Added.
67 * public/v2/chart-pane.css: Added.
68 * public/v2/data.js: Added.
69 * public/v2/index.html: Added.
70 * public/v2/js: Added.
71 * public/v2/js/d3: Added.
72 * public/v2/js/d3/LICENSE: Added.
73 * public/v2/js/d3/d3.js: Added.
74 * public/v2/js/d3/d3.min.js: Added.
75 * public/v2/js/ember-data.js: Added.
76 * public/v2/js/ember.js: Added.
77 * public/v2/js/handlebars.js: Added.
78 * public/v2/js/jquery.min.js: Added.
79 * public/v2/js/statistics.js: Added.
80 * public/v2/manifest.js: Added.
81 * public/v2/popup.js: Added.
83 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
85 Remove superfluously duplicated code in public/api/report-commits.php.
87 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
89 Perf dashboard should store commit logs
90 https://bugs.webkit.org/show_bug.cgi?id=137510
92 Reviewed by Darin Adler.
94 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
96 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
97 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
98 a subversion directory. The git version of this script will be added in a follow up patch.
101 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
102 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
103 relationship via "build_commits" relations.
105 In order to migrate an existing instance of this application, run the following SQL commands:
109 INSERT INTO commits (commit_repository, commit_revision, commit_time)
110 (SELECT DISTINCT ON (revision_repository, revision_value)
111 revision_repository, revision_value, revision_time FROM build_revisions);
113 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
114 FROM commits, build_revisions
115 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
117 DROP TABLE build_revisions;
122 The helper script to submit commit logs can be used as follows:
124 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
125 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
127 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
128 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
129 "feeder-slave-password" as the builder name and the builder password respectively.
131 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
132 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
135 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
137 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
138 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
140 - Not specified - It returns every single commit for a given repository.
141 - Matches "oldest" - It returns the commit with the oldest timestamp.
142 - Matches "latest" - It returns the commit with the latest timestamp.
143 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
144 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
145 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
146 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
147 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
148 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
150 (commit_from_revision):
151 (fetch_commits_between):
154 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
155 See tests/api-report-commits.js for examples on how to use this API.
157 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
158 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
159 to optimize this and other JSON APIs.
161 * public/include/db.php:
162 (Database::select_or_insert_row):
163 (Database::update_or_insert_row): Added.
164 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
165 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
167 (Database::select_first_row):
168 (Database::select_last_row): Added.
169 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
170 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
172 * public/include/report-processor.php:
173 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
174 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
175 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
178 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
180 * tests/api-report-commits.js: Added.
181 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
184 * tools/pull-svn.py: Added. See above for how to use this script.
186 (determine_first_revision_to_fetch):
187 (fetch_revision_from_dasbhoard):
188 (fetch_commit_and_resolve_author):
191 (resolve_author_name_from_email):
194 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
196 Update Install.md for Mavericks and fix typos
197 https://bugs.webkit.org/show_bug.cgi?id=137276
199 Reviewed by Benjamin Poulain.
201 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
203 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
205 Finally, init-database.sql is no longer located inside database directory.
209 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
211 Report run id's in api/runs.php for the new dashboard UI
212 https://bugs.webkit.org/show_bug.cgi?id=135813
214 Reviewed by Andreas Kling.
216 Include run_id in the generated JSON.
218 * public/api/runs.php:
219 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
222 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
224 Merging platforms mixes baselines and targets into reported data
225 https://bugs.webkit.org/show_bug.cgi?id=135260
227 Reviewed by Andreas Kling.
229 When merging two platforms, move test configurations of a different type (baseline, target)
230 as well as of different metric (Time, Runs).
232 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
233 It's sufficient to detect one such test_runs object.
235 * public/admin/platforms.php:
238 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
240 Merging platforms mixes baselines and targets into reported data
241 https://bugs.webkit.org/show_bug.cgi?id=135260
243 Reviewed by Geoffrey Garen.
245 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
246 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
248 * public/admin/platforms.php:
250 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
252 Build fix after r171361.
254 * public/js/helper-classes.js:
255 (.this.formattedBuildTime):
257 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
259 Perf dashboard spends 2s processing JSON data during the page loads
260 https://bugs.webkit.org/show_bug.cgi?id=135152
262 Reviewed by Andreas Kling.
264 In the Apple internal dashboard, we were spending as much as 2 seconds
265 converting raw JSON data into proper JS objects while loading the dashboard.
267 This caused the apparent unresponsiveness of the dashboard despite of the fact
268 charts themselves updated almost instantaneously.
271 * public/js/helper-classes.js:
272 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
273 lazily as creating new Date objects and running string replace is expensive.
274 (TestBuild.formattedTime):
275 (TestBuild.formattedBuildTime):
276 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
277 (PerfTestRuns.addResult): Deleted.
279 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
281 Perf dashboard shouldn't show the full git hash
282 https://bugs.webkit.org/show_bug.cgi?id=135083
284 Reviewed by Benjamin Poulain.
286 Detect Git/Mercurial hash by checking the length.
288 If it's a hash, use the first 8 characters in the label
289 while retaining the full length to be used in hyperlinks.
291 * public/js/helper-classes.js:
292 (.this.formattedRevisions):
295 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
297 Add an instruction on how to backup the database.
298 https://bugs.webkit.org/show_bug.cgi?id=133391
300 Rubber-stamped by Andreas Kling.
304 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
306 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
308 * public/js/helper-classes.js:
309 (PerfTestRuns.smallerIsBetter):
311 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
321 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
323 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
324 https://bugs.webkit.org/show_bug.cgi?id=131157
326 Reviewed by Andreas Kling.
328 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
329 This allows, for example, adding all metrics such as Arithmetic and Geometric for
330 a given test suite without also adding its subtests.
336 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
338 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
339 https://bugs.webkit.org/show_bug.cgi?id=131155
341 Reviewed by Andreas Kling.
343 The bug was caused by Chart.attach binding event listeners on plot container on each call.
344 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
345 click when attach() has been called even number of times, keeping the tooltip invisible.
347 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
348 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
349 is called for the first time.
353 (Chart..bindPlotEventHandlers):
355 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
357 WebKitPerfMonitor: Tooltips can be cut off at the top
358 https://bugs.webkit.org/show_bug.cgi?id=130960
360 Reviewed by Andreas Kling.
363 (#title): Removed the gradients, box shadows, and border from the header.
364 (#title h1): Reduce the font size.
365 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
367 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
368 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
369 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
370 * public/js/helper-classes.js:
371 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
372 tooltip extending above y=0.
374 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
376 WebKitPerfMonitor: Y-axis adjustment is too aggressive
377 https://bugs.webkit.org/show_bug.cgi?id=130937
379 Reviewed by Andreas Kling.
381 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
382 results. This had two major problems:
383 1. Two standard deviations can be too small to show the confidence interval for results.
384 2. Sometimes baseline and target can be more than two standards deviations away.
386 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
387 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
388 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
389 the margin on each side separately to reduce the empty space on either side.
391 A more rigorous approach would involve computing least squared value of results with respect to intervals
392 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
395 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
396 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
397 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
398 We wouldn't see the difference between measured values versus baseline and target values otherwise.
399 * public/js/helper-classes.js:
400 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
401 interval delta cannot be computed.
402 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
403 within the given interval.
404 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
405 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
406 (PerfTestRuns..unscaledMeansForAllResults):
407 (PerfTestRuns.min): Take the confidence interval delta into account.
408 (PerfTestRuns.max): Ditto.
409 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
410 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
412 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
414 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
416 Some CSS tweaks after r166477 and r166479,
420 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
422 WebKitPerfMonitor: Sometimes text inside panes overlap
423 https://bugs.webkit.org/show_bug.cgi?id=130956
425 Reviewed by Gyuyoung Kim.
427 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
428 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
429 reduces the total height of the pane and fits more information per screen capita on the dashboard.
431 * public/index.html: Updated and added a bunch of CSS rules for the new look.
432 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
433 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
434 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
435 of the build info shown in a chart pane and a tooltip.
436 (Chart): Made .status a table.
437 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
438 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
439 now that status.text no longer contains it.
440 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
442 * public/js/helper-classes.js:
443 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
444 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
445 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
446 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
447 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
448 capital letter; e.g. "MB" instead of "M B".
450 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
452 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
453 https://bugs.webkit.org/show_bug.cgi?id=130957
455 Reviewed by Gyuyoung Kim.
457 Moved the slider into the header. Also reduced the spacing between the header and platform names.
458 This reclaims 50px × width of the screen real estate.
461 (#title): Reduced the space below the header from 20px to 10px.
463 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
464 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
465 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
466 real estate between the header and the platform names.
468 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
470 Update the install guidelines for perf.webkit.org
471 https://bugs.webkit.org/show_bug.cgi?id=129895
473 Reviewed by Ryosuke Niwa.
475 The current install guideline for perf.webkit.org discourages the use of the installed
476 Server application. I've actualized the documentation for Mavericks, and modified the
477 guideline to include the instructions for Server.app also.
481 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
483 Update perf.webkit.org json example
484 https://bugs.webkit.org/show_bug.cgi?id=129907
486 Reviewed by Andreas Kling.
488 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
492 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
494 Merge database-common.js and utility.js into run-tests.js.
496 Reviewed by Matthew Hanson.
498 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
499 Also moved init-database.sql out of the database directory and removed the directory entirely.
502 * database/database-common.js: Removed.
503 * database/utility.js: Removed.
504 * init-database.sql: Moved from database/init-database.sql.
506 (connect): Moved from database-common.js.
507 (pathToDatabseSQL): Extracted from pathToLocalScript.
508 (pathToTests): Moved from database-common.js.
511 (SerializedTaskQueue): Ditto.
513 (initializeDatabase):
514 (TestEnvironment.it):
515 (TestEnvironment.queryAndFetchAll):
518 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
520 Remove the dependency on node.js from the production code.
522 Reviewed by Ricky Mondello.
524 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
526 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
527 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
528 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
529 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
530 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
532 Also removed the js files that are no longer used.
534 * config.json: Moved from database/config.json.
535 * database/aggregate.js: Removed. No longer used.
536 * database/database-common.js: Removed unused functions, and updated the path to config.json.
537 * database/process-jobs.js: Removed. No longer used.
538 * database/sample-data.sql: Removed. We have a much better corpus of data now.
539 * database/schema.graffle: Removed. It's completely obsolete.
540 * public/include/db.php: Updated the path to config.json.
541 * public/include/evaluator.js: Removed.
543 * public/include/report-processor.php:
544 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
545 storing values into $expressions and calling evaluate_expressions_by_node.
546 (TestRunsGenerator::aggregate_values): Added.
547 (TestRunsGenerator::compute_caches): Directly compute the caches.
549 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
551 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
553 * public/admin/platforms.php:
554 * public/include/db.php:
556 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
558 Zoomed y-axis view is ununsable when the last result is an outlier.
560 Reviewed by Stephanie Lewis.
562 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
563 the last result so that the graph looks sane if the last result was an outlier. However, always show
564 the last result's mean even if it was an outlier.
567 * public/js/helper-classes.js:
568 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
569 Also added the ability to cache the unscaled means to avoid recomputation.
570 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
571 (PerfTestRuns.max): Ditto.
572 (PerfTestRuns.sampleStandardDeviation): Ditto.
573 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
575 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
579 * public/admin/tests.php:
580 * public/js/helper-classes.js:
582 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
584 Use two standard deviations instead as I mentioned in the mailing list.
588 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
590 The performance dashboard erroneously shows upward arrow for combined metrics.
592 A single outlier can ruin the zoomed y-axis view.
594 Rubber-stamped by Antti Koivisto.
597 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
598 from the latest results' mean.
599 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
600 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
602 * public/js/helper-classes.js:
603 (PerfTestRuns.sampleStandardDeviation): Added.
604 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
606 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
608 Don't include the confidence interval when computing the y-axis.
610 Rubber-stamped by Simon Fraser.
612 * public/js/helper-classes.js:
616 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
618 Tiny CSS tweak for tooltips.
622 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
624 Remove the erroneously repeated code.
626 * public/admin/test-configurations.php:
628 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
630 <rdar://problem/15704893> perf dashboard should show baseline numbers
632 Reviewed by Stephanie Lewis.
634 * public/admin/bug-trackers.php:
635 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
638 * public/admin/platforms.php:
641 * public/admin/test-configurations.php: Added.
642 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
643 build_revisions as they're not meaningful for baseline / target numbers.
644 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
645 one test run so that we don't accidentally delete a reported test run.
646 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
647 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
648 and delete existing ones.
650 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
651 on each platform; there could be configurations of distinct types such as "current" and "baseline".
652 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
654 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
655 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
656 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
657 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
658 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
660 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
662 * public/include/admin-header.php:
663 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
664 have id and type sub columns, and each custom column could generate multiple rows.
666 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
667 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
668 We then proceed to generate the second header row with sub column names.
670 When generating the actual content, we first generate all custom columns as they may have multiple rows in
671 which case regular columns need rowspan set to the maximum number of rows.
673 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
676 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
677 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
678 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
679 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
680 expanded to occupy all sub columns.
682 * public/include/manifest.php:
683 (ManifestGenerator::platforms): Don't add the metric more than once.
685 * public/include/test-name-resolver.php:
686 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
687 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
688 full metric name later.
689 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
690 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
691 (TestNameResolver::full_name_for_test): Added.
692 (TestNameResolver::full_name_for_metric): Added.
693 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
695 * public/js/helper-classes.js:
696 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
697 test runs created to set baseline and target points.
699 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
701 Build fix after r57928. Removed a superfluous close parenthesis.
703 * public/api/runs.php:
705 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
707 Unreviewed build & typo fixes.
709 * public/admin/platforms.php:
710 * tests/admin-platforms.js:
712 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
714 <rdar://problem/15704893> perf dashboard should show baseline numbers
716 Rubber-stamped by Antti Koivisto.
718 Organize some code into functions in runs.php.
720 Also added back $paths that was erroneously removed in r57925 from json-header.php.
722 * public/api/runs.php:
723 (fetch_runs_for_config): Extracted.
726 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
728 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
730 * database/config.json:
731 * public/admin/reprocess-report.php:
732 * public/api/report.php:
733 * public/api/runs.php:
734 * public/include/json-header.php:
736 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
738 Commit yet another forgotten change.
740 Something went horribly wrong with my merge :(
742 * database/init-database.sql:
744 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
746 Commit one more forgotten change. Sorry for making a mess here.
748 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
750 Commit the forgotten files.
752 * public/admin/platforms.php: Added.
753 * tests/admin-platforms.js: Added.
755 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
757 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
759 Reviewed by Stephanie Lewis.
761 Added /admin/platforms/ page to hide and merge platforms.
763 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
764 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
765 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
766 each test configuration a distinct "test run" for each build.
768 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
769 their test configurations into platform B.
771 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
772 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
773 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
774 in platform B, in which case R should relate to T_B instead.
776 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
777 new platform. We then migrate the test configurations of the remaining test runs.
779 * database/init-database.sql: Added platform_hidden.
781 * public/admin/platforms.php: Added.
782 (merge_platforms): Added. Implements the algorithm described above.
785 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
786 is hidden since it doesn't do anything.
788 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
789 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
790 missing it since unchecked checkbox doesn't set the value in $_POST.
791 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
792 switch statement instead of repeated if's.
793 (AdministrativePage::render_table): Emit "update-column" for update_field.
795 * public/include/db.php: Disable warnings when we're not in the debug mode.
797 * public/include/manifest.php:
798 (ManifestGenerator::platforms): Skip platforms that have been hidden.
801 (TestEnvironment.postJSON):
802 (TestEnvironment.httpGet):
803 (TestEnvironment.httpPost): Added.
804 (sendHttpRequest): Set the content type if specified.
806 * tests/admin-platforms.js: Added tests.
808 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
810 Extract the code to compute full test names from tests.php.
812 Reviewed by Stephanie Lewis.
814 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
815 and paves our way to re-use the code in other pages.
817 * public/admin/tests.php:
819 * public/include/db.php:
820 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
821 tests.php and test-name-resolver.php.
823 * public/include/test-name-resolver.php: Added.
824 (TestNameResolver::__construct):
825 (TestNameResolver::compute_full_name): Moved from tests.php.
826 (TestNameResolver::map_metrics_to_tests): Ditto.
827 (TestNameResolver::sort_tests_by_full_name): Ditto.
828 (TestNameResolver::tests): Added.
829 (TestNameResolver::test_id_for_full_name): Ditto.
830 (TestNameResolver::metrics_for_test_id): Ditto.
831 (TestNameResolver::child_metrics_for_test_id): Ditto.
832 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
834 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
836 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
838 Reviewed by Stephanie Lewis.
840 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
842 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
843 but that's sufficient to correct the wrongfully processed reports for now.
845 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
846 We should eventually add a nice UI to find and reprocess reports.
848 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
850 * public/include/db.php: Added the forgotten call to prefixed_column_names.
852 * public/include/report-processor.php: Copied from public/api/report.php.
853 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
854 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
855 create a new report or authenticate the builder password (the password is never stored in the report).
856 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
857 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
858 (ReportProcessor::store_report): Ditto.
860 * tests/admin-reprocess-report.js: Added.
862 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
864 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
866 Reviewed by Ricky Mondello.
868 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
869 for the same build number as a single build by ignoring build time. This was necessary to associate
870 multiple reports by a single build - e.g. for different performance test suites - because the scripts
871 we use to submit results computed its own "build time" when they're called.
873 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
874 last week; new reports were wrongfully associated with old build numbers.
876 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
877 to the same build. Instead, we create a new build object for those reports. Since the longest set of
878 tests we have only take a couple of hours to run, 24 hours should be more than enough.
880 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
881 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
882 (builder, build number, build time).
884 * public/api/report.php:
885 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
886 when no such build exists. This prevents a report from being associated with a very old build of the same
889 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
890 a similar bug in the future sooner.
892 * tests/api-report.js: Added three test cases.
894 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
896 Merged the upstream changes to db.php
897 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
899 * public/include/db.php:
901 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
903 Update other scripts and tests per previous patch.
905 * public/include/manifest.php:
906 * tests/admin-regenerate-manifest.js:
908 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
912 Reviewed by Ricky Mondello.
914 This column is no longer used by the front-end code since r48360.
916 * database/init-database.sql:
917 * public/admin/tests.php:
919 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
921 Unreviewed build fix.
923 * public/api/report.php:
925 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
927 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
929 Reviewed by Ricky Mondello.
931 Support a new alternative format for aggregated results where we have raw values as well as
932 the list aggregators so that instead of
933 "metrics": {"Time": ["Arithmetic"]}
935 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
937 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
938 dashboard and the generated results page, which doesn't know how to aggregate values.
940 We need to keep the support for the old format because all other existing performance tests
941 all rely on the old format. Even if we updated the tests, we need the dashboard to support
942 the old format during the transition.
944 * public/api/report.php:
945 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
946 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
948 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
950 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
952 Unreviewed; Tweak the CSS so that chart panes align vertically.
956 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
958 SafariPerfMonitor should support Combined metric.
960 * public/js/helper-classes.js:
961 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
962 value as well but assume it to be greater-is-better for now.
964 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
966 Commit the forgotten init-database change to add iteration_relative_time.
968 * database/init-database.sql:
970 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
972 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
974 Reviewed by Ricky Mondello.
976 Add the support for each value to have a relative time. This is necessary for frame rate history
977 since a frame rate needs to be associated with a time it was sampled.
979 * database/init-database.sql: Added iteration_relative_time to run_iterations.
981 * public/api/report.php:
982 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
983 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
984 with relative time since taking the average of two frame rates for two subtests taken at two
985 different times doesn't make any sense.
986 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
987 etc..., use the second element since we assume values are of the form (relative time, frame rate).
988 Also exit early with an error if the number of elements in the array is not a pair.
989 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
991 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
992 iteration_relative_time.
994 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
996 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
998 Reviewed by Ricky Mondello.
1000 Support that. It's one line change.
1002 * public/api/report.php:
1003 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
1004 to match the convention assumed elsewhere.
1005 * tests/api-report.js: Added a test case.
1007 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1009 SafariPerfMonitor shows popups for points outside of the visible region.
1011 Rubber-stamped by Simon Fraser.
1013 * public/index.html:
1014 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
1015 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
1016 may return an item underneath y-axis labels.
1018 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1020 Tweak the CSS a little to avoid the test name overlapping with the summary table.
1022 * public/index.html:
1024 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1026 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
1028 * public/index.html:
1030 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1032 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
1033 <rdar://problem/13992271> Should scale Y axis to include error ranges
1035 Reviewed by Ricky Mondello.
1037 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
1038 the main graph doesn't go outside the graph even when the y-axis is adjusted.
1040 * database/config.json:
1041 * public/index.html:
1042 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
1043 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
1044 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
1046 * public/js/helper-classes.js:
1047 (PerfTestResult.confidenceIntervalDelta):
1048 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
1049 (PerfTestRuns.min): Take confidence interval delta into account.
1050 (PerfTestRuns.max): Ditto.
1051 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
1053 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1055 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
1057 * public/api/report.php:
1058 (ReportProcessor::recursively_ensure_tests):
1059 * tests/api-report.js: Added a test.
1061 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1063 Unreviewed build fixes.
1065 * public/api/report.php:
1066 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
1067 Also, tolerate reports without any revision information.
1069 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
1072 * tests/api-report.js: Added few test cases.
1074 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1076 Commit another change that was supposed to be committed in r50331.
1079 (TestEnvironment.this.postJSON):
1080 (TestEnvironment.this.httpGet):
1083 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
1085 Commit the remaining files.
1087 * public/admin/regenerate-manifest.php:
1088 * public/include/admin-header.php:
1089 * public/include/json-header.php:
1090 * public/include/manifest.php:
1092 (TestEnvironment.this.postJSON):
1093 (TestEnvironment.this.httpGet):
1096 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
1098 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
1100 Reviewed by Ricky Mondello.
1102 Added some tests for admin/regenerate-manifest.
1104 * public/admin/regenerate-manifest.php: Use require_once instead of require.
1105 * public/include/admin-header.php: Ditto.
1106 * public/include/json-header.php: Ditto.
1108 * public/include/manifest.php:
1109 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
1110 When there are no builders, simply return an empty array.
1113 (TestEnvironment.postJSON):
1114 (TestEnvironment.httpGet): Added.
1115 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
1117 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
1119 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
1121 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
1122 and run_iterations. Also fixed a typo in report.php found by new tests.
1124 * public/api/report.php:
1125 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
1126 * tests/api-report.js: Added more test cases.
1128 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
1130 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
1132 Reviewed by Ricky Mondello.
1134 Add a test runner script and some simple test cases.
1136 * database/config.json: Added the configuration for "testServer".
1137 * database/database-common.js:
1138 (pathToTests): Added.
1139 * run-tests.js: Added.
1142 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
1143 and if there are, asks the user if it’s okay to delete all of the data contained therein.
1144 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
1146 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
1147 in the current database using PostgreSQL's information_schema.
1148 (askYesOrNoQuestion):
1150 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
1152 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
1153 (TestEnvironment.assert): Exposes assert to tests.
1154 (TestEnvironment.console): Exposes console to tests.
1155 (TestEnvironment.describe): Adds a description.
1156 (TestEnvironment.it): Adds a test case.
1157 (TestEnvironment.postJSON):
1158 (TestEnvironment.queryAndFetchAll):
1159 (TestEnvironment.sha256):
1160 (TestEnvironment.notifyDone): Ends the current test case.
1164 (TestContext): An object created for each test case. Conceptually, this object is always on
1165 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
1166 this object via currentTestContext.
1167 (TestContext.description):
1169 (TestContext.logError):
1172 * tests/api-report.js: Added some basic tests for /api/report.php.
1174 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1176 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
1178 The problem was that we were detecting whether we're updating dashboard or not by checking
1179 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
1180 all configurations. Use separate 'dashboard' action to execute the code even when
1181 metric_configurations is empty.
1183 * public/admin/tests.php:
1185 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1187 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
1189 Reviewed by Ricky Mondello.
1191 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
1192 from ReportProcessor as a preparation to replace deprecated aggregate.js.
1194 * public/api/report.php:
1195 (ReportProcessor::exit_with_error): Moved.
1196 (ReportProcessor::process): Use the extracted TestRunsGenerator.
1197 (TestRunsGenerator): Added.
1198 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
1199 (TestRunsGenerator::add_aggregated_metric): Moved.
1200 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
1201 (TestRunsGenerator::aggregate): Moved. Made public.
1202 (TestRunsGenerator::aggregate_current_test_level): Moved.
1203 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
1204 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
1205 (TestRunsGenerator::compute_caches): Moved. Made public.
1206 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
1207 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
1208 (TestRunsGenerator::rollback_with_error): Moved.
1210 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1212 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
1214 Reviewed by Remy Demarest.
1216 Regenerate the manifest file when updating fields or adding new items that are included in
1219 * public/admin/bug-trackers.php:
1220 * public/admin/builders.php:
1221 * public/admin/regenerate-manifest.php:
1222 * public/admin/repositories.php:
1223 * public/admin/tests.php:
1224 * public/include/admin-header.php:
1225 (regenerate_manifest): Extracted from regenerate-manifest.php.
1227 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1229 Unreviewed build fix for memory test results.
1231 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
1232 aggregating at each level.
1234 * public/api/report.php:
1235 (ReportProcessor::recursively_ensure_tests):
1236 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
1237 (ReportProcessor::add_values_for_aggregation):
1238 (ReportProcessor::aggregate):
1239 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
1241 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1243 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
1244 not the number of iteration groups. Also, don't set group number when the entire run belongs
1245 a single iteration group.
1247 * public/api/report.php:
1248 (ReportProcessor::commit):
1250 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1252 SafariPerfMonitor: Introduce iteration groups
1254 Reviewed by Remy Demarest.
1256 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
1257 the runtime environment variances to get more stable results. And it's desirable to keep track of
1258 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
1260 This patch introduces "iteration groups" to keep track of this extra information.
1262 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
1263 the outer array denotes iteration groups and each inner array contains iteration values for each group.
1266 * database/init-database.sql: Add iteration_group column.
1267 * public/api/report.php:
1268 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
1270 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
1271 contains the list of values indexed by the iteration order and group sizes. Store the group size so
1272 that we can restore the iteration groups before passing it to node.js and restore them later.
1274 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
1275 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
1277 Also check that each iteration group in each subtest are consistent with one another. To see why we need
1278 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
1279 that each iteration group in T1 and T2 have the same size:
1280 T1 = [[1, 2], [3, 4, 5]]
1281 T2 = [[6, 7], [8, 9, 10]]
1283 so that the aggregated result (the sum in this case) can have the same groups as in:
1284 T = [[7, 9], [11, 13, 15]]
1286 If some iteration groups in T1 and T2 had a different size as in:
1287 T1 = [[1, 2, 3], [4, 5]]
1288 T2 = [[6, 7], [8, 9, 10]]
1290 Then iteration groups of the aggregated T is ambiguous.
1292 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
1293 (ReportProcessor::commit): Store iteration_group values.
1295 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1297 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
1298 migrated to perf.webkit.org.
1300 * database/perf-webkit-migrator.js: Removed.
1302 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1304 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
1306 * public/index.html:
1309 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1311 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
1313 Reviewed by Ricky Mondello.
1315 It is often desirable to see charts of a given test for all platforms, or to be able to see
1316 charts of all subtests on a given platform when trying to triage perf. regressions.
1318 Support this use case by adding the ability to do so on the charts page.
1320 Also, we used to disable items on the test list based on the platform chosen. This turned out
1321 to be a bad UI because in many situations you want to be able to compare results of the same test
1322 on multiple platforms.
1324 In this new UI, we have three select elements, each of which selects the following:
1325 1. Top-level test - Test suite such as Dromaeo
1326 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
1327 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
1328 3. Platform - Mountain Lion, Qt, etc...
1330 A user can select "all" for metric and platform but we disallow doing both at once since adding
1331 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
1332 think of a use case where you want to look at that many charts at once. We can support this later
1333 if valid use cases come up.
1335 * public/index.html:
1336 (.showCharts.addOption): Extracted.
1337 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
1338 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
1339 metricList has onchange handler that enables/disables items on platformList.
1341 (init): Sort tests and test metrics here instead of doing that in showCharts.
1343 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
1345 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
1347 Reviewed by Remy Demarest and Ricky Mondello.
1349 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
1350 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
1351 templates to the manifest file instead. Each build now only contains the builder id.
1353 * public/api/runs.php: Removed the part of the query that joined builders table. This
1354 speeds up the query quite a bit.
1356 * public/include/manifest.php:
1357 (ManifestGenerator::generate): Generate builders field.
1358 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
1359 associative array that contains name and its build URL template.
1361 * public/index.html:
1362 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
1363 instead of a revision since this function is used for revisions and build page URLs now.
1364 (.buildLabelWithLinks): Include the linkified build number.
1366 * public/js/helper-classes.js:
1367 (TestBuild.builder): Added.
1368 (TestBuild.buildNumber): Added.
1369 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
1370 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
1372 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
1374 Tooltips interfere with user interactions
1376 Rubber-stamped by Simon Fraser.
1378 Disable tooltip on the dashboard page since graphs are too small to be useful there.
1379 Also, show graphs for only 10 days by default as opposed to 20.
1380 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
1382 * public/index.html:
1383 * public/js/helper-classes.js:
1385 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
1387 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
1388 to be compatible with webkit-perf.appspot.com.
1390 * public/admin/builders.php:
1391 * public/api/report.php:
1393 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
1397 Add a missing constraint on builds table. For a given builder, there should be exactly
1398 one build for a given build number.
1400 Also add report_committed_at to reports table to record the time at which a given report
1401 was processed and test_runs and run_iterations rows were committed into the database.
1403 * database/config.json:
1404 * public/api/report.php:
1406 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
1408 Unreviewed. Add more checks for empty SQL query results.
1410 * public/include/manifest.php:
1412 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1414 More build fixes on perf.webkit.org.
1416 * public/api/runs.php: Make PostgreSQL happier.
1417 * public/include/manifest.php: Don't assume we always have bug trackers.
1419 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1421 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
1422 and fix other miscellaneous UI bugs.
1424 Rubber-stamped by Simon Fraser.
1426 Removed the code to determine whether smaller value is better or not for a given test in index.html
1427 in the favor of using that of PerfTestRuns.
1429 * public/include/manifest.php: Fixed a typo.
1430 * public/index.html:
1432 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
1434 * public/js/helper-classes.js:
1435 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
1437 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
1438 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
1439 at roughly 2,000 units to avoid this.
1441 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
1442 The only thing we can avoid is innerHTML.
1444 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1446 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
1448 * public/include/evaluator.js:
1450 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1452 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
1454 Reviewed by Remy Demarest.
1456 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
1457 admin/bug-trackers.php and can be associated with multiple repositories.
1459 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
1460 to determine the set of bug trackers to show for a given set of blame lists.
1461 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
1462 a place to file bugs against the regression.
1464 * database/init-database.sql: Added bug_trackers and tracker_repositories.
1465 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
1467 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
1468 bug trackers, namely associated repositories.
1470 * public/include/admin-header.php: Added a link to bug-trackers.php
1471 * public/include/manifest.php:
1472 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
1473 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
1475 (ManifestGenerator::repositories):
1477 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
1478 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
1479 'repositories' where the latter contains the list of associated repository names.
1481 * public/index.html:
1482 (Chart): Takes bugTrackers as as argument.
1483 (Chart.showTooltipWithResults): Removed the hard-coded list.
1485 (init.addPlatformsToDashboard):
1486 (init.showCharts.createChartFromListPair):
1487 (init): Stores the list of bug trackers in the manifest to a local variable.
1489 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1491 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
1493 * public/include/evaluator.js:
1495 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1497 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
1499 Reviewed by Remy Demarest.
1501 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
1502 new row into the database.
1504 * public/admin/aggregators.php: Use AdministrativePage.
1505 * public/admin/builders.php: Ditto.
1506 * public/admin/repositories.php: Ditto.
1507 * public/include/admin-header.php:
1508 (AdministrativePage): Added.
1509 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
1510 to an associative array that describes the column.
1511 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
1512 - label: Human readable name of the column.
1513 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
1514 column exists only before we create password_hash column at the insertion time.
1516 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
1517 titlecase (e.g. new_bug is converted to New Bug).
1518 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
1519 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
1520 textarea for a given editing mode ('text', 'url', or 'string').
1521 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
1522 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
1524 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
1526 Build fix. Some systems don't support r+. Use proc_open instead.
1528 * public/api/report.php:
1530 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1532 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
1533 when computing the y-axis of data points to show tooltips at.
1535 * public/index.html:
1537 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1539 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
1542 * public/.htaccess: Removed.
1544 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
1548 * public/include/manifest.php: Build fix. db is on this.
1549 * public/js/statistics.js:
1550 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
1552 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
1554 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
1556 Reviewed by Anders Carlsson.
1558 Rewrote and merged populate-from-report.js into report.php.
1560 * database/config.json: Added a path to node.js.
1562 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
1563 Once we land this patch and update the administrative pages, we can remove this column.
1565 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
1566 that table is going away once we remove the node.js backend.
1568 * database/populate-from-report.js: Removed.
1569 * public/api/report.php: Added.
1571 (ReportProcessor.__construct):
1572 (ReportProcessor.process):
1574 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
1575 verified to be submitted by a known builder.
1577 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
1578 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
1579 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
1580 inside a transaction because there could be multiple reports for a single build, each containing results for
1583 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
1584 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
1585 add_values_to_commit, and add_values_for_aggregation.
1587 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
1588 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
1589 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
1592 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
1593 to be aggregated in ReportProcessor.aggregate.
1595 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
1597 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
1598 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
1599 given for each row (child metrics of M). This function extracts each column (iteration) via
1600 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
1601 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
1603 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
1604 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
1605 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
1607 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
1608 (ReportProcessor.evaluate_expressions_by_node): See above.
1610 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
1611 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
1612 results also need the said caches.
1614 (ReportProcessor.add_values_to_commit):
1616 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
1617 the transaction as needed if anything goes wrong.
1619 (ReportProcessor.rollback_with_error)
1621 * public/include/db.php:
1622 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
1623 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
1624 contiguously in a SQL statement.
1626 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
1627 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
1628 a column value of the choice.
1630 (Database.begin_transaction): Added.
1631 (Database.commit_transaction): Added.
1632 (Database.rollback_transaction): Added.
1634 * public/include/evaluator.js: Added.
1635 * public/include/json-header.php:
1636 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
1637 context under which the request failed.
1638 (successful_exit): Merge "additional details".
1639 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
1640 (merge_additional_details):
1642 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
1644 SafariPerfMonitor: Add more helper functions to db.php
1646 Reviewed by Remy Demarest.
1648 Added Database::insert_row and array_get to make common database operations easier.
1650 * public/admin/aggregators.php: Use Database::insert_row instead of
1651 execute_query_and_expect_one_row_to_be_affected.
1653 * public/admin/builders.php: Ditto.
1655 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
1656 inserting a row. With insert_row, we don't need that.
1658 * public/include/admin-header.php: Ditto.
1660 * public/include/db.php:
1661 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
1662 return the default value (defaults to NULL) if the key doesn't exist.
1664 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
1667 (Database::prepare_params): Added. Takes an associative array of column names and their values,
1668 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
1669 column names all in the same order.
1671 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
1672 the given prefix. Values are given in a form of an associative array where keys are unprefixed
1673 column names and values are corresponding values. When the row is successfully inserted, it returns
1674 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
1675 indicating the success of the insertion.
1677 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1679 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
1681 Reviewed by Conrad Shultz.
1683 Rewrote the manifest generator in PHP.
1685 * database/generate-manifest.js: Removed.
1686 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
1687 * public/include/db.php:
1688 (array_ensure_item_has_array): Added.
1689 * public/include/evaluator.js: Added.
1690 * public/include/json-header.php:
1691 * public/include/manifest.php: Added.
1693 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1695 Dates on overflow plot are overlapping
1697 Rubber-stamped by Simon Fraser.
1699 Don't show more than 5 days.
1701 * public/index.html:
1702 * public/js/helper-classes.js:
1703 (TestBuild.UTCtoPST):
1706 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1708 Show build time as well as commit time on the dashboard and tooltips.
1710 Rubber-stamped by Simon Fraser.
1712 Include both the maximum commit time and build time in buildLabelWithLinks.
1713 Also use ISO format to save the screen real estate.
1715 * public/index.html:
1716 (buildLabelWithLinks):
1717 * public/js/helper-classes.js:
1719 (TestBuild.buildTime):
1720 (TestBuild.formattedBuildTime):
1722 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
1724 Unreviewed; Convert metric.name to metric.unit in the front end.
1726 * public/js/helper-classes.js:
1728 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1730 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
1732 Rubber-stamped by Simon Fraser.
1734 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
1735 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
1736 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
1738 * public/index.html:
1739 (.buildLabelWithLinks): Extracted from TestBuild.label.
1740 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
1741 on Radar and WebKit Bugzilla.
1742 * public/js/helper-classes.js:
1743 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
1744 (PerfTestResult.isBetterThan): Added.
1745 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
1746 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
1747 to indicate progressions or regressions.
1748 (PerfTestResult.label):
1749 (TestBuild.formattedTime): Added.
1750 (TestBuild.platform): Added.
1751 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
1752 (TestBuild.smallerIsBetter): Added.
1753 (Tooltip.show): Take a raw markup instead of two results.
1755 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
1757 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
1759 Rubber-stamped by Tim Horton.
1761 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
1762 since each platform may have a different number of tests to be shown on the dashboard.
1764 * public/index.html:
1766 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1768 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
1770 * public/js/helper-classes.js:
1773 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1775 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
1777 Rubber-stamped by Tim Horton.
1779 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
1781 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
1782 the revision r1234 was the revision used in the previous build.
1784 * public/api/runs.php:
1785 (parse_revisions_array): Trim double quotations around repository names and revisions.
1786 * public/js/helper-classes.js:
1789 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1791 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
1793 Rubber-stamped by Tim Horton.
1795 * public/index.html:
1796 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
1797 on the dashboard page as it's way too noisy.
1799 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
1801 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
1802 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
1803 so that the tooltip for hover can be reused further.
1805 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
1806 and find the first point that lies on the right of the cursor position. We then compute the midpoint
1807 between this and the previous point and pick the closer of the two. It returns an item-like object
1808 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
1810 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
1812 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
1813 the first or "current" data points (as opposed to target or baseline data points).
1815 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
1816 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
1817 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
1819 * public/js/helper-classes.js:
1820 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
1821 work to the client via bindClick.
1823 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
1825 (Tooltip.bindClick): Added.
1827 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1829 Yet another build fix. metricId*s*.
1831 * public/admin/tests.php:
1833 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1835 Another build fix. Use the new payload format for the aggregate job.
1837 * public/admin/tests.php:
1839 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1843 * database/aggregate.js: Use variables that actually exist.
1844 * database/database-common.js:
1845 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
1846 function calls will find this configuration.
1848 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1850 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
1852 Reviewed by Ricky Mondello.
1854 Turned InstallManual into a proper markdown document and added ReadMe.md.
1856 * InstallManual: Removed.
1857 * InstallManual.md: Moved from InstallManual.
1860 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1862 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
1864 Reviewed by Ricky Mondello.
1866 This patch prepares the front end code to process baseline and target results properly.
1868 * public/index.html:
1869 (fetchTest.createRunAndResults): Extracted.
1870 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
1871 Deleted the comment about how sorting will be unnecessary once we start results in the server side
1872 since sorting by the maximum revision commit time turned out to be non-trivial in php.
1874 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1876 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
1878 Reviewed by Tim Horton.
1880 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
1881 These files are "dynamically linked" to our app.
1883 * public/index.html:
1884 * public/js/jquery-1.8.2.min.js: Removed.
1885 * public/js/jquery.colorhelpers.js: Added.
1886 * public/js/jquery.flot.categories.js: Added.
1887 * public/js/jquery.flot.crosshair.js: Added.
1888 * public/js/jquery.flot.errorbars.js: Added.
1889 * public/js/jquery.flot.fillbetween.js: Added.
1890 * public/js/jquery.flot.js: Added.
1891 * public/js/jquery.flot.min.js: Removed.
1892 * public/js/jquery.flot.navigate.js: Added.
1893 * public/js/jquery.flot.resize.js: Added.
1894 * public/js/jquery.flot.selection.js: Added.
1895 * public/js/jquery.flot.stack.js: Added.
1896 * public/js/jquery.flot.symbol.js: Added.
1897 * public/js/jquery.flot.threshold.js: Added.
1898 * public/js/jquery.flot.time.js: Added.
1899 * public/js/jquery.js: Added.
1901 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1903 Return NaN instead of throwing when there aren't enough samples.
1905 Reviewed by Sam Weinig.
1907 It's better to return NaN when we don't have enough samples so that we can treat it
1908 as if we don't have any confidence interval.
1910 * public/js/statistics.js:
1913 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1915 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
1917 * public/js/helper-classes.js:
1918 (URLState.parseIfNeeded):
1920 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1922 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
1924 Reviewed by Ricky Mondello.
1926 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
1928 * public/admin/aggregators.php: Use heredoc.
1929 * public/admin/builders.php:
1930 * public/admin/jobs.php:
1931 * public/admin/repositories.php:
1932 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
1933 This allows us to use update_field when updating test's url and metric's unit. Changed the action
1934 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
1935 Also removed a stray code to update unit and url simultaneously since it's never used.
1936 * public/include/admin-header.php:
1937 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
1938 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
1939 (update_field): Moved from repositories.php.
1941 * public/include/db.php:
1942 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
1944 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
1946 Build fixes. Treat mean, sum, and square sum as float, not int.
1948 Also use 95% confidence interval instead of 90% confidence interval.
1950 * public/api/runs.php:
1951 * public/js/helper-classes.js:
1952 (.this.confidenceIntervalDelta):
1954 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
1956 Add an administrative page to edit repository information.
1958 Reviewed by Ricky Mondello.
1960 * public/admin/repositories.php: Added.
1961 * public/include/admin-header.php:
1963 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
1965 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
1967 Reviewed by Ricky Mondello.
1969 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
1970 to aggregate results for those matrix in populate-from-report.js.
1972 * database/generate-manifest.js:
1973 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
1974 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
1975 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
1976 * database/populate-from-report.js:
1978 (getReport): No change even though the diff looks as if it moved.
1979 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
1980 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
1981 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
1982 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
1983 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
1985 (ensureMetricId): Take an aggregator id as an argument.
1986 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
1987 for all builds when the build id is not specified.
1988 * public/admin/tests.php:
1989 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
1990 of the same name with different aggregators.
1992 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
1994 Build fix. Don't pass in arguments to in the wrong order.
1996 * database/aggregate.js:
1998 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2000 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
2002 Reviewed by Ricky Mondello.
2004 Since the version of flot we use doesn't support showing graphs in the current locate or
2005 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
2006 treat them as in UTC). We don't want to use the current locate because other websites on
2007 webkit.org assume PST.
2009 Also append this information to build's label.
2011 * public/js/helper-classes.js:
2015 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2017 Store test URLs reported by builders.
2019 Reviewed by Ricky Mondello.
2021 * database/populate-from-report.js:
2022 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
2023 (ensureTestId): Store the URL.
2025 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
2027 Yet another build fix; don't blow up even if we didn't have any test configurations.
2029 * public/admin/tests.php:
2031 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2033 Build fix; don't instantiate Date when a timestamp wasn't provided.
2035 * database/populate-from-report.js:
2037 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
2039 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
2041 Reviewed by Tim Horton.
2043 Added an install manual.
2045 * InstallManual: Added.
2047 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
2049 Minor build fix. Don't unset builderPassword when it's not set.
2051 * public/api/report.php:
2053 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2055 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
2057 Reviewed by Ricky Mondello.
2059 * public/admin/admin.css: Make a very large payload scrollable.
2060 * public/admin/jobs.php: Format JSONs.
2062 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
2064 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
2066 Reviewed by Ricky Mondello.
2068 Add report.php and populate-from-report.js that process JSON files submitted by builders.
2070 * database/populate-from-report.js: Added.
2072 (getReport): Obtains the payload (the actual report) from "jobs" table.
2073 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
2074 and their results. This function recursively traverses tests and metrics and ensure their ids.
2076 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
2077 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
2078 is a "function" in mathematical sense).
2080 (ensureRepositoryIdsForAllRevisions):
2081 (getIdOrCreateBuildWithRevisions):
2082 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
2083 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
2084 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
2086 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
2087 test results all in a single transaction. This allows us to keep the database consistent in that either
2088 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
2089 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
2090 other parts of the application are concerned.
2091 (scheduleQueriesToInsertRun):
2092 * database/process-jobs.js: Add a call to populate-from-report.js.
2093 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
2094 * public/include/db.php: Support parameterized query.
2095 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
2096 a test result could confirm that the submission indeed succeeded.
2098 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2100 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
2102 * database/aggregate.js:
2103 * database/database-common.js:
2104 (selectColumnCreatingRowIfNeeded):
2105 (ensureRepositoryId):
2106 (ensureConfigurationIdFromList):
2107 * database/perf-webkit-migrator.js:
2110 (getOrCreateBuildId):
2112 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2114 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
2116 Reviewed by Ricky Mondello.
2118 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
2119 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
2121 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
2124 (saveAggregatedResults):
2125 * database/database-common.js:
2126 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
2127 (getIdOrCreateRepository): Ditto.
2128 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
2129 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
2130 * database/perf-webkit-migrator.js:
2131 * database/utility.js: Added.
2132 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
2133 from being executed.
2134 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
2135 call the callback passed into start().
2136 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
2137 (TaskQueue.addTask):
2139 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
2140 (SerializedTaskQueue.executeNextTask):
2141 (SerializedTaskQueue.addTask):
2142 (SerializedTaskQueue.start):
2144 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2146 Revert erroneously committed changes.
2148 * database/config.json:
2150 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2152 aggregator.js should be able to accept multiple metric ids and a single build id.
2154 Reviewed by Ricky Mondello.
2156 Make aggregator.js accept multiple ids and generate results for single build when bots are
2157 reporting new results.
2159 * database/aggregate.js:
2160 (parseArgv): Added. Returns an object containing the parsed representation of argv,
2161 which currently contains metricIDs and buildIds.
2162 (main): Use parseArgv and processConfigurations
2163 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
2164 (processPlatform.processConfigurations): Extracted.
2166 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2168 Add an administrative page for builders.
2170 Reviewed by Ricky Mondello.
2172 We need an administrative page to add and edit builder information.
2173 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
2175 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
2176 since we don't have plans to use those columns in near future. Also make builder_name unique
2177 as required by the rest of the app.
2178 * public/admin/builders.php: Added.
2179 * public/api/runs.php: Updated per the table rename.
2180 * public/include/admin-header.php: Added a link to builders.php.
2182 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
2184 Build fixes for r46982.
2186 * database/aggregate.js:
2187 (fetchConfigurations): Bind i so that it's not always metricIds.length.
2188 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
2189 (processBuild): Don't print "." until we've committed transactions. It's misleading.
2191 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2193 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
2195 * public/admin/aggregators.php:
2196 * public/admin/footer.php: Removed.
2197 * public/admin/header.php: Removed.
2198 * public/admin/index.php:
2199 * public/admin/jobs.php:
2200 * public/admin/tests.php:
2201 * public/api/json-header.php: Removed.
2202 * public/api/runs.php:
2203 * public/db.php: Removed.
2204 * public/include: Added.
2205 * public/include/admin-footer.php: Copied from public/admin/footer.php.
2206 * public/include/admin-header.php: Copied from public/admin/header.php.
2207 * public/include/db.php: Copied from public/db.php.
2208 * public/include/json-header.php: Copied from public/api/json-header.php.
2210 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2212 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
2214 Reviewed by Ricky Mondello.
2216 Added the initial implementation of value aggregation.
2217 Also added abilities to configure the dashboard page in tests.php.
2219 * database/aggregate.js: Added.
2220 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
2221 (TaskQueue.addTask):
2223 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
2224 (SerializedTaskQueue.addTask):
2225 (SerializedTaskQueue.start):
2228 (fetchConfigurations):
2229 (fetchBuildsForPlatform):
2231 (testsWithDifferentIterationCounts):
2232 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
2233 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
2234 (getOrInsertConfiguration):
2236 * database/database-common.js:
2237 (fetchTable): Log an error as an error.
2238 (getOrCreateId): Extracted from perf-webkit-migrator.
2239 (statistics): Added.
2240 * database/perf-webkit-migrator.js:
2241 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
2242 runs JSON since runs JSONs are generated on demand now.
2244 (getOrCreatePlatformId):
2245 (getOrCreateTestId):
2246 (getOrCreateConfigurationId):
2247 (getOrCreateRevisionId):
2248 (getOrCreateRepositoryId):
2249 (getOrCreateBuildId):
2250 * database/process-jobs.js:
2251 (processJob): Handle 'aggregate' type.
2253 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
2255 Fix the dashboard after adding test_metrics.
2257 Reviewed by Ricky Mondello.
2259 Rename test to metrics in various functions and sort tests on the charts page.
2260 Also representing whether a test appears or not by setting a flag on dashboard
2261 was bogus because test objects are shared by multiple platforms. Instead, store
2262 dashboard platform list as intended by the manifest JSON.
2264 * public/index.html:
2265 (PerfTestRuns): Renamed test to metric.
2267 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
2268 (fullName): Moved so that it appears above where it's called.
2269 * public/js/helper-classes.js:
2271 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
2273 Update tests.php to reflect recent changes in the database schema.
2275 Reviewed by Conrad Shultz.
2277 Made the following changes to tests.php:
2278 1. Disallow adding metrics to tests without subtests.
2279 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
2280 3. Linkified tests with subtests instead of showing all them at once.
2282 * public/admin/admin.css:
2283 (.action-field, .notice):
2285 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
2286 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
2287 (add_job): Extracted.
2288 * public/admin/tests.php: See above.
2289 (array_item_set_default): Added.
2290 (array_item_or_default): Renamed from get_value_with_default.
2291 (compute_full_name): Extracted.
2292 (sort_tests): Ditto.
2293 (map_metrics_to_tests): Ditto.
2295 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
2297 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
2299 Reviewed by Simon Fraser.
2301 Linkify the headers using metric.test.url when it's provided.
2303 * public/index.html:
2305 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2307 Use parameterized pg_query_params in query_and_fetch_all
2309 Reviewed by Conrad Shultz.
2311 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
2313 * public/api/runs.php:
2315 (ctype_alnum_underscore): Added.
2317 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
2319 Update the migration tool to support test_metrics.
2321 Reviewed by Mark Rowe.
2323 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
2324 Also import run_iteration rows as runs JSON files now include individual values.
2326 * database/database-common.js:
2327 (addJob): Extracted.
2328 * database/perf-webkit-migrator.js:
2329 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
2330 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
2331 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
2334 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2336 Build fix. Suppress "Undefined index" warning.
2338 * public/admin/tests.php:
2340 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2342 Fix a commit error in r46756. api/ should obviously be added under public/
2345 * api/json-header.php: Removed.
2346 * api/runs.php: Removed.
2347 * public/api: Copied from api.
2349 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2351 SafariPerfMonitor: Linkify revisions and revisions range
2352 <rdar://problem/12801010>
2354 Reviewed by Mark Rowe.
2356 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
2357 since it needs to know "url" and "blameUrl".
2359 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
2361 * public/index.html:
2362 * public/js/helper-classes.js:
2364 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
2365 (TestBuild.label): Add labels for all revisions.
2369 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2371 Make the generation of "runs" JSON dynamic and support test_metrics.
2373 Reviewed by Mark Rowe.
2375 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
2377 Since there could be hundreds, if not thousands, of tests for each configuration and users
2378 aren't necessarily interested in looking at all test results, it's much more efficient to
2379 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
2380 when bots report new results (i.e. pushing).
2382 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
2385 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
2386 (exit_with_error): Added.
2387 (successful_exit): Added.
2388 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
2389 * database/generate-runs.js: Removed.
2390 * database/process-jobs.js: No longer supports "runs".
2391 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
2392 * public/db.php: Print "Nothing to see here." when it's accessed directly.
2394 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
2396 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2398 Update tests.php and sample-data.sql per addition of test_metrics.
2400 Rubber-stamped by Timothy Hatcher.
2402 Remove a useless code from tests.php that used to update the unit and the url of a test
2403 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
2405 Also update the sample data to reflect the addition of test_metrics.
2407 * database/sample-data.sql:
2408 * public/admin/tests.php:
2410 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
2412 Share more code between admin pages.
2414 Reviewed by Timothy Hatcher.
2416 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
2417 between admin pages.
2419 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
2420 to check the nullity of global $db now.
2422 * public/admin/aggregators.php:
2423 * public/admin/header.php:
2425 (execute_query_and_expect_one_row_to_be_affected): Added.
2426 * public/admin/index.php:
2427 * public/admin/jobs.php:
2428 * public/admin/tests.php:
2430 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
2432 SafariPerfMonitor: Add admin page to edit aggregators
2433 <rdar://problem/12782687>
2435 Reviewed by Mark Rowe.
2437 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
2439 * public/admin/aggregators.php: Added.
2440 * public/admin/header.php:
2441 * public/admin/jobs.php: Removed an erroneous hidden input element.
2443 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2445 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
2447 * database/init-database.sql:
2449 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2451 SafariPerfMonitor: Allow multiple metrics per test
2452 <rdar://problem/12773506>
2454 Rubber-stamped by Mark Rowe.
2456 Introduce a new table test_metrics. This table represents metrics each test can have
2457 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
2460 Updated admin/tests.php and index.html accordingly.
2462 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
2464 * database/generate-manifest.js:
2465 (buildPlatformMapIfPossible):
2466 * database/generate-runs.js:
2468 * database/init-database.sql:
2469 * database/schema.graffle:
2470 * public/admin/admin.css:
2473 * public/admin/tests.php:
2474 * public/index.html:
2476 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
2478 SafariPerfMonitor: Improve the webkit-perf migration tool
2479 <rdar://problem/12760882>
2481 Reviewed by Mark Rowe.
2483 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
2484 and we don't want to pause the whole importation process until the user comes back to decide whether
2487 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
2488 down to make modifications.
2490 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
2491 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
2493 * database/init-database.sql:
2494 * database/perf-webkit-migrator.js:
2495 (migrateTestConfig):
2496 * database/schema.graffle:
2497 * public/admin/admin.css:
2499 * public/admin/tests.php:
2501 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
2503 Create a new performance dashboard
2504 <rdar://problem/12625582>
2506 Rubber-stamped by Mark Rowe.
2508 Add the initial implementation of the perf dashboard.
2511 * database/config.json: Added.
2512 * database/database-common.js: Added.
2517 (pathToLocalScript):
2519 * database/generate-manifest.js: Added.
2522 (buildPlatformMapIfPossible):
2523 (generateFileIfPossible):
2524 * database/perf-webkit-migrator.js: Added.
2525 * database/process-jobs.js: Added.
2526 * database/sample-data.sql: Added.
2527 * database/schema.graffle: Added.
2529 * public/admin: Added.
2530 * public/admin/README: Added.
2531 * public/admin/admin.css: Added.
2532 * public/admin/footer.php: Added.
2533 * public/admin/header.php: Added.
2534 * public/admin/index.php: Added.
2535 * public/admin/jobs.php: Added.
2536 * public/admin/tests.php: Added.
2537 * public/common.css: Added.
2538 * public/data: Added.
2539 * public/db.php: Added.
2540 * public/index.html: Added.
2542 * public/js/helper-classes.js: Added.
2543 * public/js/jquery-1.8.2.min.js: Added.
2544 * public/js/jquery.flot.min.js: Added.
2545 * public/js/jquery.flot.plugins.js: Added.
2546 * public/js/shared.js: Added.
2547 (fileNameFromPlatformAndTest):
2548 * public/js/statistics.js: Added.