1 2015-04-20 Ryosuke Niwa <rniwa@webkit.org>
3 Perf dashboard should have UI to set status on analysis tasks
4 https://bugs.webkit.org/show_bug.cgi?id=143977
6 Reviewed by Chris Dumez.
8 Added the UI to set the result of an analysis task to 'progression', 'regression', 'unchanged', and 'inconclusive'
9 as well as a boolean indicating whether creating the analysis task was the right thing to do or not.
10 The latter will be a useful metric once we start automatically creating analysis tasks.
12 * init-database.sql: Added two columns to analysis_tasks table.
13 * public/api/analysis-tasks.php: Include the added columns in the JSON.
14 * public/include/db.php:
15 (Database::to_database_boolean): Added.
16 * public/include/json-header.php:
17 (require_match_one_of_values): Added.
18 * public/privileged-api/update-analysis-task.php: Added. Updates 'result' and 'needed' values of an analysis task.
20 * public/v2/analysis.js:
21 (App.AnalysisTask.result): Added.
22 (App.AnalysisTask.needed): Added. We don't use DS.attr('boolean') here since that would coerce null into false
23 and we want to differentiate null from false in order to differentiate the null-ness of the value.
24 (App.AnalysisTask.saveStatus): Added.
25 (App.AnalysisTask.statusLabel): Use 'result' as the label if it's set and all build requests have been processed.
28 (App.AnalysisTaskController.analysisResultOptions): Added.
29 (App.AnalysisTaskController.shouldNotHaveBeenCreated): Added.
30 (App.AnalysisTaskController.needsFeedback): Added. Show the checkbox to indicate the analysis task should not have
31 been created if 'no change' is selected.
32 (App.AnalysisTaskController._updateChosenAnalysisResult): Added.
33 (App.AnalysisTaskController.actions.saveStatus): Added.
34 * public/v2/index.html: Extracted a partial template for updating the bug numbers. Also added the UI to update
35 'result' and 'needed' values of the analysis task.
37 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
39 Unreviewed build fix. Updated config.json after recent changes.
43 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
45 Make the analysis page more useful
46 https://bugs.webkit.org/show_bug.cgi?id=143617
48 Reviewed by Chris Dumez.
50 * public/api/analysis-tasks.php:
51 (fetch_and_push_bugs_to_tasks): Added total and finished numbers of build requests associated
52 with the fetched analysis tasks as buildRequestCount and finishedBuildRequestCount respectively.
53 * public/v2/analysis.js:
54 (App.AnalysisTask.formattedCreatedAt): Added.
55 (App.AnalysisTask._addLeadingZero): Added.
56 (App.AnalysisTask.buildRequestCount): Added.
57 (App.AnalysisTask.finishedBuildRequestCount): Added.
58 (App.AnalysisTask.statusLabel): Added. Status total and finished numbers of build requests.
59 (App.AnalysisTask.testGroups):
60 (App.AnalysisTask.triggerable):
61 (App.AnalysisTask.label):
63 * public/v2/app.css: Tweaked style rules for the analysis page.
66 (App.buildPopup): Sort the list of platforms by name.
67 (App.AnalysisRoute.model): Sort the list of analysis tasks by the order they are created.
68 (App.AnalysisTaskController._fetchedManifest): Added elementId to associate bug tracker names
69 such as "Bugzilla" with the corresponding text field.
71 * public/v2/index.html: Added a bunch of columns to the analysis page and also wrapped the table
72 showing A/B testing results in a div with overflow: scroll so that it always leaves enough space
73 for the accompanying graph.
75 2015-04-09 Ryosuke Niwa <rniwa@webkit.org>
77 Perf dashboard should automatically select ranges for A/B testing
78 https://bugs.webkit.org/show_bug.cgi?id=143580
80 Reviewed by Chris Dumez.
82 Added a new statistics option for picking a A/B test range selection strategy.
83 The selected ranges are shown in the graph using the same UI to show analysis tasks.
86 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Updated the query parameters for
87 charts page used by the dashboard since we've added a new parameter at the end.
88 (App.Pane.ranges): Added. Merges ranges created for analysis tasks and A/B testing.
89 (App.Pane.updateStatisticsTools): Clone and set the test range selection strategies.
90 (App.Pane._cloneStrategy): Copy isSegmentation.
91 (App.Pane._updateMovingAverageAndEnvelope): Set testRangeCandidates.
92 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Update the charts when a new text range
93 selection strategy is picked by the user.
94 (App.Pane._computeMovingAverageAndOutliers): Compute the test ranges using the chosen strategy.
95 Avoid going through isAnomalyArray when no anomaly detection strategy is enabled. Also changed
96 the return value from the moving average time series to a dictionary that contains the moving
97 average time series, a dictionary of anomalies, and an array of test ranges.
98 (App.ChartsController._parsePaneList): Parse the test range selection strategy configuration.
99 (App.ChartsController._serializePaneList): Ditto for serialization.
100 (App.ChartsController._scheduleQueryStringUpdate): Update the URL hash when the user picks a new
101 test range selection strategy.
103 * public/v2/chart-pane.css: Fixed a typo as well as added a CSS rule for test ranges markers.
105 * public/v2/index.html: Added UI for selecting a test range selection strategy.
107 * public/v2/interactive-chart.js:
108 (App.InteractiveChartComponent._rangesChanged): Pass down "status" to be used as a class name.
110 * public/v2/js/statistics.js:
111 (Statistics.MovingAverageStrategies): Added isSegmentation to segmentation strategies.
112 (Statistics.TestRangeSelectionStrategies): Added.
114 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
116 The results of A/B testing should state statistical significance
117 https://bugs.webkit.org/show_bug.cgi?id=143552
119 Reviewed by Chris Dumez.
121 Added statistical comparisons between results for each configuration on analysis task page using
122 Welch's t-test. The probability as well as t-statistics and the degrees of freedoms are reported.
125 (App.TestGroupPane._populate): Report the list of statistical comparison between every pair of
126 root configurations in the results. e.g. if we've got A, B, C configurations then compare A/B, A/C
128 (App.TestGroupPane._computeStatisticalSignificance): Compute the statistical significance using
129 Welch's t-test. Report the probability by which two samples do not come from the same distribution.
130 (App.TestGroupPane._createConfigurationSummary): Include the array of results for this configuration.
131 Also renamed "items" to "requests" for clarity.
133 * public/v2/index.html: Added the template for showing statistical comparisons.
135 * public/v2/js/statistics.js: Renamed tDistributionQuantiles to tDistributionByOneSidedProbability
136 for clarity. Also factored out the functions to convert from one-sided probability to two-sided
137 probability and vice versa.
138 (Statistics.supportedConfidenceIntervalProbabilities):
139 (Statistics.confidenceIntervalDelta):
140 (Statistics.probabilityRangeForWelchsT): Added. Computes the lower bound and the upper bound for
141 the probability that two values are sampled from distinct distributions using Welch's t-test.
142 (Statistics.computeWelchsT): This function now takes two-sided probability like all other functions.
143 (.tDistributionByOneSidedProbability): Renamed from tDistributionQuantiles.
144 (.oneSidedToTwoSidedProbability): Extracted.
145 (.twoSidedToOneSidedProbability): Extracted.
146 (Statistics.MovingAverageStrategies): Converted the one-sided probability to the two-sided probability
147 now that computeWelchsT takes two-sided probability.
149 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
151 Unreviewed fix after r182496 for when the cached runs JSON doesn't exist.
155 (App.Pane.refetchRuns):
157 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
159 Perf dashboard should have a way of marking outliers
160 https://bugs.webkit.org/show_bug.cgi?id=143466
162 Reviewed by Chris Dumez.
164 Address kling's in-person comment to notify users when the new run status is saved in the database.
167 (App.PaneController._selectedItemIsMarkedOutlierDidChange)
168 * public/v2/chart-pane.css: Fixed a typo.
170 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
172 Perf dashboard should have a way of marking outliers
173 https://bugs.webkit.org/show_bug.cgi?id=143466
175 Reviewed by Chris Dumez.
177 Added UI to mark a data point as an outlier as well as a button to toggle the visibility of outliers.
178 Added a new privileged API /privileged-api/update-run-status to store this boolean flag.
180 * init-database.sql: Added run_marked_outlier column to test_runs table.
182 * public/admin/tests.php:
184 * public/api/runs.php:
185 (main): Only emit Cache-Control and Expires headers in v1 UI.
186 (RunsGenerator::format_run): Emit markedOutlier.
188 * public/include/admin-header.php:
190 * public/include/db.php:
191 (Database::is_true): Made it static.
193 * public/include/manifest.php:
194 (Manifest::platforms):
196 * public/index.html: Call into /api/runs/ with ?cache=true.
198 * public/privileged-api/update-run-status.php: Added.
199 (main): Updates the newly added column in test_runs table.
203 (App.Pane.refetchRuns): Extracted from App.Pane._fetch.
204 (App.Pane._didFetchRuns): Renamed from _updateChartData.
205 (App.Pane._setNewChartData): Added. Pick the right time series based based on the value of showOutlier.
206 Cloning chartData is necessary when toggling the outlier visibility or using statistics tools because
207 the interactive chart component only observes changes to chartData and not individual properties of it.
208 (App.Pane._highlightPointsMarkedAsOutlier): Added. Highlight points marked as outliers.
209 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Call to _setNewChartData replaced the code to
210 clone chartData here.
212 (App.PaneController.actions.toggleShowOutlier): Toggle the visibility of points marked as outliers by
213 invoking App.Pane._setNewChartData.
214 (App.PaneController._detailsChanged): Don't hide the analysis pane when details changed since keep
215 opening the pane for marking points as outliers would be annoying.
216 (App.PaneController._updateCanAnalyze): Update 'cannotMarkOutlier' as well as 'cannotAnalyze'.
217 (App.PaneController.selectedMeasurement): Added.
218 (App.PaneController.showOutlierTitle): Added.
219 (App.PaneController._selectedItemIsMarkedOutlierDidChange): Added. Call out to setMarkedOutlier to
220 mark the selected point as an outlier via the newly added privileged API.
222 * public/v2/chart-pane.css: Updated styles.
225 (PrivilegedAPI._post): Report the semantic errors.
226 (Measurement.prototype.markedOutlier): Added.
227 (Measurement.prototype.setMarkedOutlier): Added. Uses PrivilegedAPI to update the database.
228 (RunsData.prototype.timeSeriesByCommitTime): Added a new argument, includeOutliers, to indicate
229 whether the time series should include measurements marked as outliers or not.
230 (RunsData.prototype.timeSeriesByBuildTime): Ditto.
231 (RunsData.prototype._timeSeriesByTimeInternal): Extracted from timeSeriesByCommitTime and
232 timeSeriesByBuildTime to share code. Now ignores measurements marked as outliers if needed.
234 * public/v2/index.html: Added an icon for showing and hiding outliers. Also added a checkbox to
235 mark individual points as outliers.
237 * public/v2/interactive-chart.js:
238 (App.InteractiveChartComponent._selectClosestPointToMouseAsCurrentItem): Re-enable the distance
239 heuristics that takes vertical closeness into account. This heuristics is more useful when marking
240 some points as outliers. This heuristics was disabled because the behavior was unpredictable but
241 with the arrow key navigation support, this is no longer an issue.
243 * public/v2/manifest.js:
244 (App.Manifest._formatFetchedData): Added showOutlier to the chart data. This function dynamically
245 updates the time series in this chart data in order to include or exclude outliers.
247 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
249 Perf dashboard should be able to trigger A/B testing jobs for iOS
250 https://bugs.webkit.org/show_bug.cgi?id=143398
252 Reviewed by Chris Dumez.
254 Fix various bugs in the perf dashboard so that it can schedule A/B testing jobs for iOS.
256 Also generalized sync-with-buildbot.py slightly to meet the requirements of iOS builders.
258 * public/api/triggerables.php:
259 (main): Avoid spitting a warning when $id_to_triggerable doesn't contain the triggerable.
260 * public/v2/analysis.js:
261 (App.AnalysisTask.triggerable): Log an error when failed to fetch triggerables for debugging purposes.
263 (App.AnalysisTaskController.updateRootConfigurations): Show 'None' when a revision is missing from
264 some of the data points. This will happen when we modify the list of projects we build for iOS.
265 (App.AnalysisTaskController.actions.createTestGroup): Gracefully fail by showing alerts when an user
266 attempts to create an invalid test group; when there is already another test group of the same or when
267 only either configuration specifies the revision for some repository.
268 (App.AnalysisTaskController._updateRootsBySelectedPoints): Fixed a typo: sets[i] -> set.
269 * public/v2/index.html: Don't show the form to create a new test group if it's not available.
270 * tools/sync-with-buildbot.py:
271 (find_request_updates):
272 (schedule_request): iOS builders take a JSON that contains the list of roots. Generate this JSON when
273 a dictionary of the form {rootsExcluding: ["WebKit"]} is specified. Also replaced the way we refer to
274 a revision from $-based text replacements to an explicit dictionary of the form {root: "WebKit"}.
275 (request_id_from_build): Don't hard code the parameter name here. Retrieve the name from the config.
277 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
279 Add time series segmentation algorithms as moving averages
280 https://bugs.webkit.org/show_bug.cgi?id=143362
282 Reviewed by Chris Dumez.
284 This patch implements two preliminary time series segmentation algorithms as moving averages.
286 Recursive t-test: Compute Welch's t-statistic at each point in a given segment of the time series.
287 If Welch's t-test implicates a statistically significance difference, then split the segment into two
288 sub segments with the maximum t-statistic (i.e. the point at which if split would yield the highest
289 probability that two segments do not share the same "underlying" mean in classical / frequentist sense).
290 We repeat this process recursively. See [1] for the evaluation of this particular algorithm.
292 Schwarz criterion: Use Schwarz or Bayesian information criterion to heuristically find the optimal
293 segmentation. Intuitively, the problem of finding the best segmentation comes down to minimizing the
294 residual sum of squares in each segment as in linear regressions. That is, for a given segment with
295 values y_1 through y_n with mean y_avg, we want to minimize the sum of (y_i - y_avg)^2 over i = 1
296 through i = n. However, we also don't want to split every data point into a separate segment so we need
297 to account the "cost" of introducing new segments. We use a cost function that's loosely based on two
298 models discussed in [2] for simplicity. We will tune this cost function further in the future.
300 The problem of finding the best segmentation then reduces to a search problem. Unfortunately, our problem
301 space is exponential with respect to the size of the time series since we could split at each data point.
302 We workaround this problem by first splitting the time series into a manageable smaller grids, and only
303 considering segmentation of a fixed size (i.e. the number of segments is constant). Since time series
304 tend to contain a lot more data points than segments, this strategy finds the optimal solution without
305 exploring much of the problem space.
307 Finding the optimal segmentation of a fixed size is, itself, another search problem that is equivalent to
308 finding the shortest path of a fixed length in DAG. Here, we use dynamic programming with a matrix of size
309 n by n where n is the length of the time series (grid). Each entry in this matrix at (i, k) stores
310 the minimum cost of segmenting data points 1 through i using k segments. We start our search at i = 1.
311 Clearly C(1, 0) = 0 (note the actual code uses 0-based index). In i-th iteration, we compute the cost
312 S(i, j) of each segment starting at i and ending at another point j after i and update C(j, k + 1) by
313 min( C(j, k + 1), C(i, k) + S(i, j) ) for all values of j above i.
315 [1] Kensuke Fukuda, H. Eugene Stanley, and Luis A. Nunes Amaral, "Heuristic segmentation of
316 a nonstationary time series", Physical Review E 69, 021108 (2004)
318 [2] Marc Lavielle, Gilles Teyssi`ere, "Detection of Multiple Change–Points in Multivariate Time Series"
319 Lithuanian Mathematical Journal, vol 46, 2006
321 * public/v2/index.html: Show the optional description for the chosen moving average strategy.
322 * public/v2/js/statistics.js:
323 (Statistics.testWelchsT):
324 (Statistics.computeWelchsT): Extracted from testWelchsT. Generalized to take the offset and the length
325 of each value array between which Welch's t-statistic is computed. This generalization helps the
326 Schwarz criterion segmentation algorithm avoid splitting values array O(n^2) times.
327 (.sampleMeanAndVarianceForValues): Ditto for the generalization.
328 (.recursivelySplitIntoTwoSegmentsAtMaxTIfSignificantlyDifferent): Added. Implements recursive t-test.
329 (.splitIntoSegmentsUntilGoodEnough): Added. Implements Schwarz criterion.
330 (.findOptimalSegmentation): Added. Implements the algorithm to find the optimal segmentation of a fixed
332 (.SampleVarianceUpperTriangularMatrix): Added. Stores S(i, j) used by findOptimalSegmentation.
333 (.SampleVarianceUpperTriangularMatrix.prototype.costBetween): Added.
335 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
337 REGRESSION: Perf dashboard sometimes fails to update zooming level
338 https://bugs.webkit.org/show_bug.cgi?id=143359
340 Reviewed by Darin Adler.
342 The bug was caused by various bugs that ended up in an exception.
345 (App.Pane._handleFetchErrors): Removed superfluous console.log.
346 (App.Pane.computeStatus): Fixed the bug in r182185 that previousPoint could be null.
347 (App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
348 * public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
349 to # when Ember.js fails to attach event listeners on time.
350 * public/v2/interactive-chart.js:
351 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
352 the containing element's size is 0.
353 (App.InteractiveChartComponent._updateBrush): Ditto.
355 2015-04-02 Ryosuke Niwa <rniwa@webkit.org>
357 Perf dashboard should have UI to test out anomaly detection strategies
358 https://bugs.webkit.org/show_bug.cgi?id=143290
360 Reviewed by Benjamin Poulain.
362 Added the UI to select anomaly detection strategies. The detected anomalies are highlighted in the graph.
364 Implemented the Western Electric Rules 1 through 4 in http://en.wikipedia.org/wiki/Western_Electric_rules
365 as well as Welch's t-test that compares the last five points to the prior twenty points.
367 The latter is what Mozilla uses (or at least did in the past) to detect performance regressions on their
368 performance tests although they compare medians instead of means.
370 All of these strategies don't quite work for us since our data points are too noisy but this is a good start.
373 (App.Pane.updateStatisticsTools): Clone anomaly detection strategies.
374 (App.Pane._updateMovingAverageAndEnvelope): Highlight anomalies detected by the enabled strategies.
375 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Observe changes to anomaly detection strategies.
376 (App.Pane._computeMovingAverageAndOutliers): Detect anomalies by each strategy and aggregate results.
377 Only report the first data point when multiple consecutive data points are detected as anomalies.
378 * public/v2/chart-pane.css: Updated styles.
379 * public/v2/index.html: Added the pane for selecting anomaly detection strategies.
380 * public/v2/js/statistics.js:
381 (Statistics.testWelchsT): Added. Implements Welch's t-test.
382 (.sampleMeanAndVarianceForValues): Added.
383 (.createWesternElectricRule): Added.
384 (.countValuesOnSameSide): Added.
385 (Statistics.AnomalyDetectionStrategy): Added.
387 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
389 REGRESSION: Searching commits can highlight wrong data points
390 https://bugs.webkit.org/show_bug.cgi?id=143272
392 Reviewed by Antti Koivisto.
394 The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
395 return commit times with only second precision. This resulted in the frontend code to match a commit
396 with the data point that included the next commit when the millisecond component of commit's timestamp
397 wasn't identically 0.
399 This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
400 was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
401 so miliseconds component was only preserved in /api/commits.
403 Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
404 it returns time in milisecond precision.
406 * public/api/commits.php:
407 (fetch_commits_between): Use Database::to_js_time for format commit times.
408 (format_commit): Ditto.
409 * public/include/db.php:
410 (Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
412 (CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
414 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
416 Perf dashboard should show relative change in values
417 https://bugs.webkit.org/show_bug.cgi?id=143252
419 Reviewed by Antti Koivisto.
421 When a range of values are selected, show the percentage difference between the start and the end
422 in addition to the absolute value difference. When a single point is selected, show the relative
423 difference with respect to the previous point. Use two significant figures and always show plus sign
424 when the difference is positive.
426 * public/v2/app.js: Compute and format the relative difference.
427 * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
428 * public/v2/index.html: Show the relative difference.
430 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
432 REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
433 https://bugs.webkit.org/show_bug.cgi?id=143254
435 Reviewed by Antti Koivisto.
437 The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
438 or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
439 so that the interactive chart component will observe a change to 'chartData'.
442 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
444 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
446 Unreviewed build fixes.
448 * public/include/manifest.php:
449 (Manifest::generate): These should be {} instead of [] when they're empty.
451 (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
452 * public/v2/manifest.js:
453 (App.Metric.fullName): Fixed the typo.
454 * tests/admin-regenerate-manifest.js: Fixed the test.
456 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
458 Commit the erroneously reverted change.
460 * public/api/runs.php:
461 (RunsGenerator::results):
463 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
465 Loading the perf dashboard takes multiple seconds
466 https://bugs.webkit.org/show_bug.cgi?id=141860
468 Reviewed by Andreas Kling.
470 This patch introduces the caches of JSON files returned by /api/ in /data/ directory. It also records
471 the last time test_runs rows associated with the requested platforms and metrics are inserted, updated,
472 or removed in the caches as well as the manifest JSON files ("last modified time"). Because the manifest
473 is regenerated each time a new test result is reported, the front end can compare last modified time in
474 the manifest file with that in a /api/runs JSON cache to detect the stale-ness.
476 More concretely, the front end first optimistically fetches the JSON in /data/. If the cache doesn't exit
477 or the last modified time in the cache doesn't match with that in the manifest file, it would fetch it
478 again via /api/runs. In the case the cache did exist, we render the charts based on the cache meanwhile.
479 This dramatically reduces the perceived latency for the page load since charts are drawn immediately using
480 the cache and we would only re-render the charts as new up-to-date JSON comes in.
482 This patch also changes the format of runs JSONs by pushing the exiting properties into 'configurations'
483 and adding 'lastModified' and 'elapsedTime' at the top level.
485 * init-database.sql: Added config_runs_last_modified to test_configurations table as well as a trigger to
486 auto-update this column upon changes to test_runs table.
488 * public/admin/test-configurations.php:
489 (add_run): Regenerate the manifest file to invalidate the /api/runs JSON cache.
492 * public/api/runs.php:
493 (main): Fetch all columns of test_configurations table including config_runs_last_modified. Also generate
494 the cache in /data/ directory.
495 (RunsGenerator::__construct): Compute the last modified time for this (platform, metric) pair.
496 (RunsGenerator::results): Put the old content in 'configurations' property and include 'lastModified' and
497 'elapsedTime' properties. 'elapsedTime' is added for debugging purposes.
498 (RunsGenerator::add_runs):
499 (RunsGenerator::parse_revisions_array):
501 * public/include/db.php:
503 (generate_data_file): Added based on ManifestGenerator::store.
504 (Database::to_js_time): Extracted from RunsGenerator::add_runs to share code.
506 * public/include/json-header.php:
507 (echo_success): Renamed from success_json. Return the serialized JSON instead of echo'ing it so that we can
508 generate caches in /api/runs/.
511 * public/include/manifest.php:
512 (ManifestGenerator::generate): Added 'elapsedTime' property for the time taken to generate the manifest.
513 It seems like we're generating it in 200-300ms for now so that's good.
514 (ManifestGenerator::store): Uses generate_data_file.
515 (ManifestGenerator::platforms): Added 'lastModified' array to each platform entry. This array contains the
516 last modified time for each (platform, metric) pair.
519 (fetchTest): Updated per the format change in runs JSON.
522 (App.Pane._fetch): Fetch the cached JSON first. Refetch the uncached version if instructed as such.
523 (App.Pane._updateChartData): Extracted from App.Pane._fetch.
524 (App.Pane._handleFetchErrors): Ditto.
527 (RunsData.fetchRuns): Takes the fourth argument indicating whether we should fetch the cached version or not.
528 The cached JSON is located in /data/ with the same filename. When fetching a cached JSON results in 404,
529 fulfill the promise with null as the result instead of rejecting it. The only client of this function which
530 sets useCache to true is App.Manifest.fetchRunsWithPlatformAndMetric, and it handles this special case.
532 * public/v2/manifest.js:
533 (App.DateArrayTransform): Added. Handles the array of last modified dates in platform objects.
534 (App.Platform.lastModifiedTimeForMetric): Added. Returns the last modified date in the manifest JSON.
535 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes "useCache" like RunsData.fetchRuns. Set shouldRefetch
536 to true if response is null (the cache didn't exit) or the cache is out-of-date.
537 (App.Manifest._formatFetchedData): Extracted from App.Manifest.fetchRunsWithPlatformAndMetric.
540 (initializeDatabase): Avoid splitting function definitions in the middle.
542 * tests/api-report.js: Added tests to verify that reporting new test results updates the last modified time
543 in test_configurations.
545 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
547 REGRESSION(r180333): Analysis tasks can't be associated with bugs
548 https://bugs.webkit.org/show_bug.cgi?id=141858
550 Reviewed by Andreas Kling.
552 Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
553 of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
555 * public/v2/chart-pane.css:
556 * public/v2/index.html:
558 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
560 Selecting revisions for A/B testing is hard
561 https://bugs.webkit.org/show_bug.cgi?id=141824
563 Reviewed by Andreas Kling.
565 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
566 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
567 select A/B testing points manually.
569 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
570 sets to 'options' for clarity.
572 * public/v2/app.css: Reorganized style rules.
575 (App.AnalysisTaskController):
576 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
577 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
578 a property, which sets 'overviewDomain' property as well as other properties.
579 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
580 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
581 in the overview chart.
583 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
584 individual build requests / test results are shown or not.
586 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
587 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
589 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
591 Unreviewed test fixes after r179037, r179591, and r179763.
593 * tests/admin-regenerate-manifest.js:
594 * tests/admin-reprocess-report.js:
596 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
598 Relationship between A/B testing results are unclear
599 https://bugs.webkit.org/show_bug.cgi?id=141810
601 Reviewed by Andreas Kling.
603 Show a "reference chart" indicating which two points have been tested in each test group pane.
605 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
606 and the domain used in this chart to show charts in each test group.
608 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
610 * public/v2/analysis.js:
611 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
612 since this is the results of A/B testing results, not the data for charts shown next to them.
614 * public/v2/app.css: Added CSS rules for reference charts.
617 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
618 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
619 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
620 identically matches root sets. If one of configuration used a set of revisions for which no measurement
621 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
622 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
623 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
624 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
627 (Measurement.prototype.revisionForRepository): Added.
628 (Measurement.prototype.commitTimeForRepository): Cleanup.
629 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
631 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
632 by including the build number in the title attribute instead of in the markup.
634 * public/v2/interactive-chart.js:
635 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
636 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
637 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
639 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
641 Analysis task pages are unusable
642 https://bugs.webkit.org/show_bug.cgi?id=141786
644 Reviewed by Andreas Kling.
646 This patch makes following improvements to analysis task pages:
647 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
648 compute the data for the details pane from PaneController.
649 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
650 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
651 This change required the creation of App.TestGroupPane as well as its methods.
652 4. Show a box plot for each root set configuration as well as each build request. This change required
653 App.BoxPlotComponent.
654 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
656 * public/api/build-requests.php:
657 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
659 * public/api/test-groups.php:
660 (main): Include root sets and roots in the response.
663 * public/include/build-requests-fetcher.php:
664 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
665 (BuildRequestsFetcher::root_sets): Added.
666 (BuildRequestsFetcher::roots): Added.
667 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
668 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
669 tools/sync-with-buildbot.py can't convert repository names to their ids.
671 * public/v2/analysis.js:
673 (App.RootSet): Added.
674 (App.RootSet.revisionForRepository): Added.
675 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
676 response at /api/test-groups will include them.
677 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
678 _createConfigurationSummary.
679 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
680 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
682 * public/v2/app.css: Updated style rules for analysis task pages.
685 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
686 (App.Pane._updateDetails): Moved from App.PaneController.
688 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
690 (App.AnalysisTaskController): Added 'details'.
691 (App.AnalysisTaskController._taskUpdated):
692 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
693 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
694 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
696 (App.TestGroupPane): Added.
697 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
698 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
699 of all repositories appearing in root sets and builds associated with A/B testing results.
700 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
701 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
702 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
703 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
704 is a union of revisions in the root set and the first build request in the group. We null-out revision info
705 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
706 by the values in the group as well as 95% percentile confidence interval.
708 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
709 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
710 the mean and the confidence interval.
711 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
712 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
713 calls _updateBars to update the rects.
715 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
718 (Measurement.prototype.formattedRevisions):
719 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
720 called in _createConfigurationSummary.
722 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
723 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
724 Also made the fetching of chartData no longer block showing of test groups.
726 * public/v2/interactive-chart.js:
727 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
728 (App.InteractiveChartComponent._domainChanged): Ditto.
729 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
731 * public/v2/js/statistics.js:
732 (Statistics.min): Added.
733 (Statistics.max): Added.
735 * public/v2/manifest.js:
736 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
738 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
740 Build URL on new perf dashboard doesn't resolve $builderName
741 https://bugs.webkit.org/show_bug.cgi?id=141583
743 Reviewed by Darin Adler.
745 Support $builderName in the build URL template.
747 * public/js/helper-classes.js:
748 (TestBuild.buildUrl): Replaced $builderName with the builder name.
750 * public/v2/manifest.js:
751 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
752 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
754 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
756 Unreviewed build fix after r179591.
758 * public/api/commits.php:
760 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
762 The status of a A/B testing request always eventually becomes "Failed"
763 https://bugs.webkit.org/show_bug.cgi?id=141523
765 Reviewed by Andreas Kling.
767 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
768 'failedIfNotCompleted' was sent by the buildbot sync'er.
770 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
772 * public/api/build-requests.php:
775 2015-02-13 Csaba OsztrogonĂ¡c <ossy@webkit.org>
777 Unreviewed, remove empty directories.
779 * public/data: Removed.
781 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
783 Perf dashboard should show the results of A/B testing
784 https://bugs.webkit.org/show_bug.cgi?id=141500
786 Reviewed by Chris Dumez.
788 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
789 analysis task page to fetch results for each test group.
791 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
792 can use the formatter.
794 * public/api/runs.php:
795 (fetch_runs_for_config_and_test_group): Added.
796 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
797 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
798 use RunsGenerator to format results.
799 (RunsGenerator): Added.
800 (RunsGenerator::__construct): Added.
801 (RunsGenerator::add_runs): Added.
802 (RunsGenerator::format_run): Moved.
803 (RunsGenerator::parse_revisions_array): Moved.
805 * public/v2/analysis.js:
806 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
807 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
808 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
809 configuration associated with this build request such as "A" and "B".
810 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
811 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
812 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
816 (App.Pane._fetch): Set chartData directly here.
817 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
818 now that it's done in App.Pane._fetch.
819 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
822 (Measurement.prototype.buildId): Added.
823 (TimeSeries.prototype.findPointByBuild): Added.
825 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
826 url is not an Ember routed path.
828 * public/v2/manifest.js:
829 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
830 App.createChartData here so that App.BuildRequest can use the formatter
832 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
834 v2 UI should adjust the number of ticks on dashboards based on screen size
835 https://bugs.webkit.org/show_bug.cgi?id=141502
837 Reviewed by Chris Dumez.
839 * public/v2/interactive-chart.js:
840 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
843 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
845 New perf dashboard shows too much space around interesting data points
846 https://bugs.webkit.org/show_bug.cgi?id=141487
848 Reviewed by Chris Dumez.
850 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
851 show the current time series excluding points in the series outside the moving average envelope.
854 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
855 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
856 time series if the point lies outside the moving average envelope. Don't expose the moving average or
857 the envelope computed for this purpose if they're not set by the user.
860 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
861 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
863 * public/v2/interactive-chart.js:
864 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
865 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
866 to deal with showFullYAxis here.
867 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
868 argument instead of directly inspecting showFullYAxis.
870 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
872 New perf dashboard shouldn't always show outliners
873 https://bugs.webkit.org/show_bug.cgi?id=141445
875 Reviewed by Chris Dumez.
877 Use the simple moving average with an average difference envelope to compute the y-axis range to show
878 to avoid expanding it spuriously to show one off outlier.
881 (App.Pane): Don't show the full y-axis range by default.
882 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
883 one is not specified by the user but without showing them in the charts.
884 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
885 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
887 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
888 (App.ChartsController._serializePaneList): Ditto.
890 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
892 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
894 * public/v2/interactive-chart.js:
895 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
896 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
897 if they are not specified by the user (i.e. only used to adjust y-axis range).
898 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
899 x-axis domain remained the same. Without this change, the charts would never redraw.
900 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
901 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
902 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
904 * public/v2/js/statistics.js:
905 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
907 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
909 Unreviewed build fix.
912 (set get App.Pane.Ember.Object.extend):
914 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
916 New perf dashboard should have the ability to overlay moving average with an envelope
917 https://bugs.webkit.org/show_bug.cgi?id=141438
919 Reviewed by Andreas Kling.
921 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
923 Simple Moving Average - The moving average x̀„_i of x_i is computed as the arithmetic mean of values
924 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
925 n, backward window size, and m, forward window size, as an argument.
927 Cumulative Moving Average - x̀„_i is computed as the arithmetic mean of all values x_0 though x_i.
928 That is, x̀„_1 = x_1 and x̀„_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
930 Exponential Moving Average - x̀„_i is computed as the weighted average of x_i and x̀„_(i - 1) with α as
931 an argument specifying x_i's weight. To be precise, x̀„_1 = x_1 and x̀„_i = α * x_i + (α - 1) x̀„_(i-1).
934 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
935 between each x_i and x̀„_i.
937 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
938 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
939 the average of (x_i - x̀„_i)^2 as the "sample variance" instead of the conventional (x_i - x̀„)^2 where
940 x̀„ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
943 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
944 The configuration of the currently chosen strategies is saved in the query string for convenience.
946 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
948 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
951 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
952 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
953 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
954 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
955 from the query string via ChartsController.
956 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
957 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
958 (App.Pane._executeStrategy): Added.
959 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
961 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
962 selections, and added two new arguments for the moving average and the enveloping configurations.
963 (App.ChartsController._serializePaneList): Ditto.
964 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
965 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
966 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
967 (App.PaneController.actions.toggleStatPane): Added.
969 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
970 current (as opposed to baseline and target) time series for when it's the most foreground graph without
971 moving average and its envelope overlapping on top of it.
973 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
975 * public/v2/interactive-chart.js:
976 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
977 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
978 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
979 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
980 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
981 but don't bother removing individual paths and circles. Added the code to show the moving average time
982 series when there is one. Also add "foreground" class on SVG elements for the current time series when
983 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
984 series when "foreground" is not set.
985 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
986 account when computing the y-axis range.
987 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
989 * public/v2/js/statistics.js:
990 (Statistics.MovingAverageStrategies): Added.
991 (Statistics.EnvelopingStrategies): Added.
993 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
995 The delta value in the chart pane sometimes doens't show '+' for a positive delta
996 https://bugs.webkit.org/show_bug.cgi?id=141340
998 Reviewed by Andreas Kling.
1000 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
1001 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
1004 (App.Pane.computeStatus):
1005 (App.createChartData):
1007 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1009 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
1012 (App.PaneController._updateDetails):
1014 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1016 Unreviewed. Commit the forgotten change.
1018 * public/include/manifest.php:
1020 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1022 New perf dashboard should have multiple dashboard pages
1023 https://bugs.webkit.org/show_bug.cgi?id=141339
1025 Reviewed by Chris Dumez.
1027 Added the support for multiple dashboard pages. Also added the status of the latest data point.
1028 e.g. "5% better than target"
1030 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
1031 Also hid the border lines around charts on the dashboard page for a cleaner look.
1034 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
1035 (App.IndexRoute.beforeModel): Added.
1036 (App.DashboardRoute): Added.
1037 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
1038 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
1039 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
1040 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
1041 (App.DashboardController): Renamed from App.IndexController.
1042 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
1043 and "defaultDashboard" as these are taken care of by newly added routers.
1044 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
1045 now done in actions.toggleEditMode.
1046 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
1047 an existing dashboard.
1049 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
1050 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
1051 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
1052 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
1054 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
1056 (App.PaneController._updateDetails): Updated per changes to computeStatus.
1058 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
1060 * public/v2/data.js:
1061 (TimeSeries.prototype.lastPoint): Added.
1063 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
1064 on the dashboard, and enumerate all predefined dashboards.
1066 * public/v2/interactive-chart.js:
1067 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
1068 for the dashboard page.
1070 * public/v2/manifest.js:
1071 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
1072 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
1073 IDs are generated for each dashboard for forward compatibility.
1075 (App.Manifest.dashboardByName): Added.
1076 (App.Manifest.defaultDashboardName): Added.
1077 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
1079 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1081 Move commits viewer to the end of details view
1082 https://bugs.webkit.org/show_bug.cgi?id=141315
1084 Rubber-stamped by Andreas Kling.
1086 Show the difference instead of the old value per kling's request.
1089 (App.PaneController._updateDetails):
1090 * public/v2/index.html:
1092 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1094 Move commits viewer to the end of details view
1095 https://bugs.webkit.org/show_bug.cgi?id=141315
1097 Reviewed by Andreas Kling.
1099 Improved the way list of commits are shown per kling's request.
1102 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
1104 * public/v2/chart-pane.css: Updated the style for the commits viewer.
1106 * public/v2/commits-viewer.js:
1107 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
1108 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
1110 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
1111 moved the commits viewers out of the details tables so that they don't interleave revision data.
1113 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1115 New perf dashboard should compare results to baseline and target
1116 https://bugs.webkit.org/show_bug.cgi?id=141286
1118 Reviewed by Chris Dumez.
1120 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
1121 Also use d3.format to format the selected value to show four significant figures.
1124 (App.Pane.searchCommit):
1125 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
1126 to compute the status text without having to recreate them.
1127 (App.createChartData): Added.
1128 (App.PaneController._updateDetails): Use 3d.format on current and old values.
1129 (App.PaneController._computeStatus): Added. Computes the status text.
1130 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
1131 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
1132 format the values using chartData.formatter.
1134 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
1135 the baseline and in blue if it's better than the target.
1137 * public/v2/data.js:
1138 (TimeSeries.prototype.findPointAfterTime): Added.
1140 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
1141 the bug that we were not showing the old value's unit.
1143 * public/v2/interactive-chart.js:
1144 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
1145 the code to show the baseline and the target lines.
1147 * public/v2/manifest.js:
1148 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
1150 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1152 Unreviewed build fix.
1155 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
1157 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1159 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
1160 https://bugs.webkit.org/show_bug.cgi?id=141280
1162 Reviewed by Chris Dumez.
1164 Fixed the bug by passing in "since" as a query parameter to the charts page.
1166 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
1168 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
1170 (App.IndexController): Changed the default number of days from one month to one week.
1171 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
1172 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
1174 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1176 New perf dashboard erroneously clears zoom when poping history items
1177 https://bugs.webkit.org/show_bug.cgi?id=141278
1179 Reviewed by Chris Dumez.
1181 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
1183 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
1184 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
1187 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
1188 shown in the main plot.
1189 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
1190 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
1192 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1194 New perf dashboard shows null as the aggregator name if no aggregation is done
1195 https://bugs.webkit.org/show_bug.cgi?id=141256
1197 Reviewed by Chris Dumez.
1199 Don't show the aggregator name if there isn't one.
1201 * public/v2/manifest.js:
1204 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1206 Unreviewed build fix after r179611.
1208 * public/v2/interactive-chart.js:
1210 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1212 Perf dashboard doesn’t show the right unit for Safari UI tests
1213 https://bugs.webkit.org/show_bug.cgi?id=141238
1215 Reviewed by Darin Adler.
1217 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
1218 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
1219 between metrics and their units.
1221 * public/js/helper-classes.js:
1222 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
1223 * public/v2/manifest.js:
1224 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
1225 * public/v2/interactive-chart.js:
1226 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
1227 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
1229 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1231 Interactive chart component provides two duplicate API for highlighting points
1232 https://bugs.webkit.org/show_bug.cgi?id=141234
1234 Reviewed by Chris Dumez.
1236 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
1237 on the main charts page and markedPoints to show the two end points in the analysis task page.
1239 This patch merges markedPoints into highlightedItems.
1242 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
1243 * public/v2/chart-pane.css:
1244 * public/v2/index.html: Ditto.
1245 * public/v2/interactive-chart.js:
1246 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
1247 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
1248 items if highlightedItems was set before the initial layout.
1249 (App.InteractiveChartComponent._relayoutDataAndAxes):
1250 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
1251 vertical lines, just set cx and cy as done for other "dots".
1252 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
1253 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
1254 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
1255 set the radius of highlight circles here.
1257 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1259 Don’t use repository names as id’s.
1260 https://bugs.webkit.org/show_bug.cgi?id=141226
1262 Reviewed by Chris Dumez.
1264 Not using repository names as their id's reduces the need to fetch the entire repositories table.
1265 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
1267 * Websites/perf.webkit.org/public/api/runs.php:
1268 (parse_revisions_array): No longer uses $repository_id_to_name.
1269 (main): No longer populates $repository_id_to_name.
1271 * Websites/perf.webkit.org/public/api/triggerables.php:
1272 (main): Don't resolve repository names.
1274 * Websites/perf.webkit.org/public/include/manifest.php:
1275 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
1276 (ManifestGenerator::bug_trackers): Don't resolve repository names.
1278 * Websites/perf.webkit.org/public/js/helper-classes.js:
1279 (TestBuild): Renamed repositoryName to repositoryId.
1280 (TestBuild.revision): Ditto.
1281 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
1282 since this is the text shown to human.
1284 * Websites/perf.webkit.org/public/v2/app.js:
1285 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
1286 (App.PaneController._updateDetails): Ditto.
1287 (App.AnalysisTaskController.updateRoots): Ditto.
1289 * Websites/perf.webkit.org/public/v2/data.js:
1290 (Measurement): Ditto.
1291 (Measurement.prototype.commitTimeForRepository): Ditto.
1292 (Measurement.prototype.formattedRevisions): Ditto.
1294 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
1295 select element's label and value respectively.
1297 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1299 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
1301 * public/api/runs.php:
1303 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1305 /api/runs.php should have main function
1306 https://bugs.webkit.org/show_bug.cgi?id=141220
1308 Reviewed by Benjamin Poulain.
1310 Wrapped the code inside main function for clarity.
1312 * public/api/runs.php:
1314 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
1316 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
1318 * tools/sync-with-buildbot.py:
1319 (find_request_updates):
1321 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1323 Perf dashboard always assigns the result of A/B testing with build request 1
1324 https://bugs.webkit.org/show_bug.cgi?id=140382
1326 Reviewed by Darin Adler.
1328 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
1329 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
1331 Also fixed a typo as well as a bug that reports were never associated with builds.
1333 * public/include/report-processor.php:
1334 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
1335 instead of the first non-null value.
1336 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
1337 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
1339 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1341 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
1343 * public/admin/tests.php:
1345 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
1347 Unreviewed build fix. Removed the stale code.
1349 * public/admin/triggerables.php:
1351 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1353 Perf dashboard should have the ability to post A/B testing builds
1354 https://bugs.webkit.org/show_bug.cgi?id=140317
1356 Rubber-stamped by Simon Fraser.
1358 This patch adds the support for triggering A/B testing from the perf dashboard.
1360 We add a few new tables to the database. "build_triggerables", which represents a set of builders
1361 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
1362 of repositories for which an arbitrary revision can be specified for A/B testing.
1363 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
1364 "roots" table which specifies the revision used in a given root set in each repository.
1366 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
1367 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
1368 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
1369 to build_requests table. Also made each test group's name unique in a given analysis task as it
1370 would be confusing to have multiple test groups of the same name.
1372 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
1374 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
1375 for which a specific revision can be set in an A/B testing on a given triggerable.
1377 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
1378 triggerable. Also updates the status' and the status urls of specified build requests when
1379 buildRequestUpdates is provided in the raw POST data.
1382 * public/api/runs.php:
1383 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
1384 results of an A/B testing.
1386 * public/api/test-groups.php:
1387 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
1389 * public/api/triggerables.php: Added.
1390 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
1392 * public/include/admin-header.php:
1394 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
1395 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
1396 and root sets used in those requests.D
1397 (BuildRequestsFetcher::__construct):
1398 (BuildRequestsFetcher::fetch_for_task):
1399 (BuildRequestsFetcher::fetch_for_group):
1400 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
1401 (BuildRequestsFetcher::has_results):
1402 (BuildRequestsFetcher::results):
1403 (BuildRequestsFetcher::results_with_resolved_ids):
1404 (BuildRequestsFetcher::results_internal):
1405 (BuildRequestsFetcher::root_sets):
1406 (BuildRequestsFetcher::fetch_roots_for_set):
1408 * public/include/db.php:
1409 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
1410 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
1411 table since it only has the primary key, id, column.
1412 (Database::select_or_insert_row):
1413 (Database::update_or_insert_row):
1414 (Database::update_row): Added.
1415 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
1416 should be inserted when no row matches the specified criteria. This is used while updating
1417 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
1418 new build requests in that API.
1419 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
1420 This is used in public/api/triggerables.php when no analysis task is specified.
1422 * public/include/json-header.php:
1423 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
1424 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
1425 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
1426 find the closest ancestor with a triggerable.
1428 * public/include/report-processor.php:
1429 (ReportProcessor::process):
1430 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
1431 if jobId or buildRequest is specified.
1433 * public/include/test-name-resolver.php:
1434 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
1435 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
1436 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
1439 * public/include/test-path-resolver.php: Added.
1440 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
1441 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
1442 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
1443 in order to compute full test metric names.
1444 (TestPathResolver::__construct):
1445 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
1446 the highest (a test without a parent).
1447 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
1448 the highest ancestor to the test itself.
1449 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
1451 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
1453 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
1454 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
1455 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
1456 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
1458 * public/v2/analysis.js:
1459 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
1460 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
1461 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
1462 (App.TestGroup.create): Added. Creates a new A/B testing group.
1463 (App.Triggerable): Added.
1464 (App.TriggerableAdapter): Added.
1465 (App.TriggerableAdapter.buildURL): Added.
1466 (App.BuildRequest.testGroup): Renamed from group.
1467 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
1468 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
1469 in this build request.
1470 (App.BuildRequest.status): Added.
1471 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
1472 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
1475 (App.AnalysisTaskController.testGroups): Added.
1476 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
1477 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
1478 but an observer that updates "roots" property. Filter out the repositories that are not accepted
1479 by the associated triggerable as they will be ignored.
1480 (App.AnalysisTaskController.actions.createTestGroup): Added.
1482 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
1484 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
1485 the status of those builds to the perf dashboard. A similar script can be written to support
1486 other continuous builds systems.
1487 (main): Fetches the list of pending builds as well as currently running or completed builds from
1488 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
1489 a single new build on each builder with no pending builds, and marks the set of open build requests
1490 that have been scheduled to run on the buildbot but not found in the first step as stale.
1491 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
1494 "platform": "mac-mavericks",
1495 "test": ["Parser", "html5-full-render.html"],
1496 "builder": "Trunk Syrah Production Perf AB Tests",
1498 "forcescheduler": "force-mac-mavericks-release-perf",
1499 "webkit_revision": "$WebKit",
1500 "jobid": "$buildRequest"
1505 (find_request_updates): Return a list of build request status updates to make based on the pending
1506 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
1507 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
1508 if the build request had not been completed. This is necessary because a failed build will not
1509 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
1510 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
1511 of open requests the perf dashboard has.
1512 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
1513 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
1514 or human canceling a build may trigger such a state.
1515 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
1516 replacing repository names with their revisions and buildRequest with the build request id.
1517 (config_for_request): Finds a builder for the test and the platform of a build request.
1518 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
1519 (property_value_from_build): Returns the value of a specific property in a buildbot build.
1520 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
1522 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1524 Cache-control should be set only on api/runs
1525 https://bugs.webkit.org/show_bug.cgi?id=140312
1527 Reviewed by Andreas Kling.
1529 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
1530 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
1531 just set cache-control there instead of json-header.php which is used by other JSON APIs.
1533 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
1535 * public/api/analysis-tasks.php:
1536 * public/api/runs.php: Set the cache control headers.
1537 * public/api/test-groups.php:
1538 * public/include/db.php: Set the default timezone to UTC.
1539 * public/include/json-header.php: Don't set the cache control headers.
1541 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1543 api/report-commit should authenticate with a slave name and password
1544 https://bugs.webkit.org/show_bug.cgi?id=140308
1546 Reviewed by Benjamin Poulain.
1548 Use a slave name and a password to authenticate new commit reports.
1550 * public/api/report-commits.php:
1552 * public/include/json-header.php:
1553 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
1554 a slave name and a password instead of a builder name and a password.
1555 * tests/api-report-commits.js: Updated tests.
1556 * tools/pull-svn.py:
1557 (main): Renamed variables.
1558 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
1560 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
1562 Perf dashboard should support authentication via a slave password
1563 https://bugs.webkit.org/show_bug.cgi?id=139837
1565 Reviewed by Andreas Kling.
1567 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
1568 having to add multiple builders with the same password when a single build slave is shared among them.
1570 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
1572 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
1574 * public/admin/build-slaves.php: Added.
1576 * public/admin/builders.php: Added the support for updating passwords.
1578 * public/include/admin-header.php:
1579 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
1580 being retrieved from $_POST.
1581 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
1582 the raw may not exist (e.g. new_password).
1583 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
1584 control here when this flag evaluates to TRUE.
1586 * public/include/report-processor.php:
1587 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
1588 values are present in the report. In addition, try authenticating builderName with slavePassword if
1589 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
1590 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
1591 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
1593 (ReportProcessor::store_report): Store the slave ID with the report.
1594 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
1595 the matching build is different from what's being reported.
1597 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
1600 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
1602 New perf dashboard should not duplicate author information in each commit
1603 https://bugs.webkit.org/show_bug.cgi?id=139756
1605 Reviewed by Darin Adler.
1607 Instead of each commit having author name and email, make it reference a newly added committers table.
1608 Also replace "email" by "account" since some repositories don't use emails as account names.
1610 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
1611 which only contains as many rows as there are accounts in each repository, instead of commits table
1612 which contains every commit ever happened in each repository.
1614 To migrate an existing database into match the new schema, run:
1618 INSERT INTO committers (committer_repository, committer_name, committer_email)
1619 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
1620 FROM commits WHERE commit_author_email IS NOT NULL);
1622 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
1624 UPDATE commits SET commit_committer = committer_id FROM committers
1625 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
1627 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
1628 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
1632 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
1633 reference to committers. Also added the missing drop table statements.
1635 * public/api/commits.php:
1636 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
1637 an array here instead of doing it in format_commit.
1638 (fetch_commits_between): Updated queries to JOIN commits with committers.
1639 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
1640 is now done in main.
1642 * public/api/report-commits.php:
1643 (main): Store the reported committer information or update the existing entry if there is one.
1645 * tests/admin-regenerate-manifest.js: Fixed tests.
1647 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
1649 * tools/pull-svn.py: Renamed email to account.
1651 (fetch_commit_and_resolve_author):
1653 (resolve_author_name_from_account):
1654 (resolve_author_name_from_email): Deleted.
1656 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
1658 Unreviewed build fix.
1660 * public/v2/index.html: Include js files we extracted in r177424.
1662 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1664 Unreviewed. Adding the forgotten svnprop.
1666 * tools/pull-svn.py: Added property svn:executable.
1668 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1670 Split InteractiveChartComponent and CommitsViewerComponent into separate files
1671 https://bugs.webkit.org/show_bug.cgi?id=139716
1673 Rubber-stamped by Benjamin Poulain.
1675 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
1676 and interactive-chart.js respectively since app.js has gotten really large.
1679 * public/v2/commits-viewer.js: Added.
1680 * public/v2/interactive-chart.js: Added.
1682 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
1684 New perf dashboard's chart UI is buggy
1685 https://bugs.webkit.org/show_bug.cgi?id=139214
1687 Reviewed by Chris Dumez.
1689 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
1691 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
1692 component. This is not how Ember.js components should interact to begin with. The component now exposes
1693 selectedPoints and always updates selection instead of sharedSelection.
1696 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
1697 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
1698 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
1699 and end time should be completely determined by "since" and the present time.
1700 (App.ChartsController._startTimeChanged): Ditto.
1701 (App.ChartsController._scheduleQueryStringUpdate):
1702 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
1704 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
1706 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
1707 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
1708 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
1709 observes the changes to selectedPoints property as it gets updated by the main chart.
1710 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
1711 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
1713 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
1714 when domain arrays aren't identical. This was causing a subtle race with other logic.
1715 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
1716 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
1717 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
1718 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
1719 see if those two points correspond to a range or a single data point. Rewrote all that logic by
1720 directly observing selectedPoints and currentItem properties instead of taking points and relying on
1721 an instance variable, which was a terrible API.
1722 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
1723 when the main plot has a selected range, we don't have to check this._hasRange anymore.
1725 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
1726 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
1727 (App.InteractiveChartComponent._updateSelection):
1728 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
1729 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
1730 selectedPoints property.
1732 (App.AnalysisTaskController._fetchedRuns):
1733 (App.AnalysisTaskController._rootChangedForTestSet):
1735 * public/v2/index.html:
1736 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
1738 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1740 Unreviewed. Fixed syntax errors.
1742 * init-database.sql:
1743 * public/api/commits.php:
1745 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1747 The dashboard on new perf monitor should be configurable
1748 https://bugs.webkit.org/show_bug.cgi?id=138994
1750 Reviewed by Benjamin Poulain.
1752 For now, make it configurable via config.json. We should eventually make it configurable via
1753 an administrative page but this will do for now.
1755 * config.json: Added the empty dashboard configuration.
1757 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1760 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1761 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1762 Also obtain the default configuration from App.Manifest.
1763 (App.IndexController._normalizeTable): Moved to App.Dashboard.
1765 * public/v2/manifest.js:
1766 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
1767 (App.Repository.urlForRevisionRange): Ditto.
1768 (App.Dashboard): Added.
1769 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
1770 (App.Dashboard.rows): Ditto.
1771 (App.Dashboard.headerColumns): Ditto.
1772 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
1773 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
1774 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
1775 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
1777 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1779 There should be a way to associate bugs with analysis tasks
1780 https://bugs.webkit.org/show_bug.cgi?id=138977
1782 Reviewed by Benjamin Poulain.
1784 Updated associate-bug.php to match the new database schema.
1786 * public/include/json-header.php:
1787 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
1788 already camel-cased in require_existence_of. This makes the function usable elsewhere.
1790 * public/privileged-api/associate-bug.php:
1791 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
1792 Also verify that those values are integers using require_format.
1794 * public/v2/analysis.js:
1795 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
1796 (App.Bug.label): Added.
1797 (App.BugAdapter): Added.
1798 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
1799 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
1801 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
1802 containing the bug information.
1805 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
1806 (App.AnalysisTaskRoute):
1807 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
1808 (App.AnalysisTaskController._fetchedManifest): Added.
1809 (App.AnalysisTaskController.actions.associateBug): Added.
1811 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
1813 * public/v2/data.js:
1814 (Measurement.prototype.associateBug): Deleted.
1816 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
1817 Added a table show the bug information. Also hide the chart until chartData is available.
1819 * public/v2/manifest.js:
1822 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1824 Fix misc bugs and typos in app.js
1825 https://bugs.webkit.org/show_bug.cgi?id=138946
1827 Reviewed by Benjamin Poulain.
1830 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1831 (App.ChartsController.init):
1832 (App.buildPopup): Renamed from App.BuildPopup.
1833 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1834 remove() on the wrong object (an array as opposed to elements in the array).
1835 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1836 _highlights is always an array and evalutes to true.
1838 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1840 New perf dashboard should provide UI to create a new analysis task
1841 https://bugs.webkit.org/show_bug.cgi?id=138910
1843 Reviewed by Benjamin Poulain.
1845 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1846 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1848 With this patch, we can create a new analysis task by selection a range of points and opening
1849 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1850 in the chart hyperlinked to the analysis task.
1852 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1854 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1855 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1857 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1858 and adds the associated bugs to each task in the array.
1861 * public/api/runs.php: Reverted changes made in r175006.
1862 (fetch_runs_for_config):
1865 * public/api/test-groups.php:
1866 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1868 * public/include/db.php:
1869 (Database::select_first_or_last_row):
1870 (Database::select_rows): Extracted from select_first_or_last_row.
1872 * public/v2/analysis.js:
1873 (App.AnalysisTask): Added "bugs" property.
1874 (App.Bug): Added now that bugs are regular data store objects.
1877 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1878 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1879 platform that are associated with a specific range of runs.
1880 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1881 (App.PaneController.actions.associateBug): Deleted.
1882 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1883 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1884 once we've created one.
1885 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1886 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1887 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1888 (App.PaneController._updateBugs): Deleted.
1889 (App.PaneController._updateMarkedPoints): Deleted.
1890 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1891 the name is missing or when at most one point is selected.
1893 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1894 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1895 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1896 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1897 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1898 clickable bars for analysis tasks.
1899 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1900 bar for analysis tasks to place them at the right location.
1901 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1903 * public/v2/chart-pane.css:
1904 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1905 (.chart .rangeBar): Added.
1907 * public/v2/data.js:
1908 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1910 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1911 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1912 task bars in the interactive chart component.
1914 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1916 Fix typos in r176203.
1919 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1920 (App.AnalysisTaskRoute):
1922 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1924 Unreviewed. Updated the install instruction.
1928 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1930 App.Manifest shouldn't use App.__container__.lookup
1931 https://bugs.webkit.org/show_bug.cgi?id=138768
1933 Reviewed by Andreas Kling.
1935 Removed the hack to find the store object via App.__container__.lookup.
1936 Pass around the store object instead.
1939 (App.DashboardRow._createPane): Add "store" property to the pane.
1940 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1941 (App.IndexController.gridChanged): Ditto.
1942 (App.IndexController.actions.addRow): Ditto.
1943 (App.IndexController.init): Ditto.
1944 (App.Pane._fetch): Ditto.
1945 (App.ChartsController._parsePaneList): Ditto.
1946 (App.ChartsController._updateQueryString): Ditto.
1947 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1948 (App.BuildPopup): Ditto.
1949 (App.AnalysisTaskRoute.model): Ditto.
1950 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1952 * public/v2/manifest.js:
1953 (App.Manifest.fetch): Removed the code to find the store object.
1955 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1957 Fix Ember.js warnings the new perf dashboard
1958 https://bugs.webkit.org/show_bug.cgi?id=138531
1960 Reviewed by Darin Adler.
1962 Fixed various warnings.
1965 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1966 * public/v2/data.js:
1967 (PrivilegedAPI._post): Removed the superfluous console.log.
1968 (CommitLogs.fetchForTimeRange): Ditto.
1969 * public/v2/index.html: Added tbody as required by the HTML specification.
1971 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1973 Fix typos in r175768.
1976 (App.AnalysisTaskViewModel.roots):
1978 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1980 Introduce the concept of analysis task to perf dashboard
1981 https://bugs.webkit.org/show_bug.cgi?id=138517
1983 Reviewed by Andreas Kling.
1985 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1986 a single platform and used to bisect regressions in the range.
1988 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1990 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1991 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1992 test runs. Analysis tasks not associated with test runs are used for try new patches.
1993 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1994 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1995 build_requests - A build request represents a single pending build for A/B testing.
1997 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
2001 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
2002 the specified analysis task group as well as build requests associated with them.
2004 (fetch_test_groups_for_task):
2005 (fetch_build_requests_for_task):
2006 (fetch_build_requests_for_group):
2007 (format_test_group):
2008 (format_build_request):
2010 * public/include/json-header.php:
2011 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
2014 * public/privileged-api/associate-bug.php:
2015 (main): Fixed a typo.
2017 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
2020 (ensure_config_from_runs):
2022 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
2024 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
2026 (App.AnalysisTask.create):
2028 (App.TestGroupAdapter):
2029 (App.AnalysisTaskSerializer):
2030 (App.TestGroupSerializer):
2033 * public/v2/app.css: Added style rules for the analysis page.
2036 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
2038 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
2039 exactly one selected point as we can still create an analysis task.
2040 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
2041 grammatical and also alert'ed the error message when there is one.
2042 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
2043 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
2044 once XHR request has completed.
2045 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
2046 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
2047 is selected in the details pane.
2049 (App.AnalysisRoute): Added.
2050 (App.AnalysisTaskRoute): Added.
2051 (App.AnalysisTaskViewModel): Added.
2052 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
2053 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
2054 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
2055 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
2056 the user selects an option for all roots in A or B configuration.
2057 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
2059 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
2061 * public/v2/data.js:
2062 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
2063 point so that we can use it in App.AnalysisTaskViewModel.roots.
2064 (TimeSeries.prototype.findPointByMeasurementId): Added.
2065 (TimeSeries.prototype.seriesBetweenPoints): Added.
2067 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
2068 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
2069 when multiple points are selected. Finally, added a new template for the analysis task page.
2071 * public/v2/manifest.js:
2072 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
2073 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
2074 App.AnalysisTaskViewModel._taskUpdated.
2076 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
2078 Remove App.PaneController.bugsChangeCount in the new perf dashboard
2079 https://bugs.webkit.org/show_bug.cgi?id=138111
2081 Reviewed by Darin Adler.
2084 (App.PaneController.bugsChangeCount): Removed.
2085 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
2086 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
2087 Finds the list of current run's points that are associated with bugs.
2088 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
2089 * public/v2/chart-pane.css:
2090 (.chart .marked): Renamed from .hasBugs.
2091 * public/v2/index.html: Specify chartPointRadius and markedPoints.
2093 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
2095 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
2096 https://bugs.webkit.org/show_bug.cgi?id=138099
2098 Reviewed by Benjamin Poulain.
2100 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
2101 _showDetails inverting the order of the current and old measurements.
2104 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
2105 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
2106 current (latest) measurement and the first point is the oldest measurement.
2107 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
2109 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
2111 Perf dashboard should provide a way to associate bugs with a test run
2112 https://bugs.webkit.org/show_bug.cgi?id=137857
2114 Reviewed by Andreas Kling.
2116 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
2117 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
2118 the Apache configuration.
2121 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
2122 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
2123 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
2124 via the cookie and returns a token computed from those two values as well as the remote username.
2126 The font end code then POST's the request along with the returned token. The server side code verifies
2127 that the specified token can be generated from the salt and the expiration time set in the cookie, and
2128 the token hasn't expired.
2131 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
2132 have zero or exactly one bug associated with a test run.
2134 * public/admin/bug-trackers.php: Added the support for editing bug_url.
2135 * public/api/runs.php:
2136 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
2137 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
2138 an associated bug if there is one.
2139 (format_run): Calls parse_bugs_array.
2141 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
2142 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
2143 have a valid JSON payload.
2144 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
2145 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
2146 the expiration time stored in the cookie.
2147 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
2149 * public/include/manifest.php:
2150 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
2151 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
2153 * public/index.html:
2154 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
2156 * public/privileged-api/associate-bug.php: Added.
2157 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
2158 attack via ensure_privileged_api_data_and_token, which calls verify_token.
2160 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
2162 * public/v2/app.css:
2163 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
2164 selected in a chart.
2167 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
2168 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
2169 they would overlap on each other if both of them are shown.
2170 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
2171 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
2172 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
2173 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
2174 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
2175 showing the search pane.
2176 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
2177 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
2178 bugs in the selected range.
2180 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
2181 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
2182 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
2183 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
2184 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
2185 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
2186 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
2187 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
2189 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
2190 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
2191 to selectionChanged action instead of just finding the first and the last points.
2193 * public/v2/chart-pane.css: Updated the style.
2195 * public/v2/data.js:
2196 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
2197 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
2198 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
2199 we haven't already obtained a CSRF token or if the token has already been expired.
2200 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
2202 (Measurement.prototype.bugs): Added.
2203 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
2204 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
2206 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
2209 * public/v2/manifest.js:
2210 (App.BugTracker.bugUrl):
2211 (App.BugTracker.newBugUrl): Added.
2212 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
2213 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
2214 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
2215 (App.Manifest.bugTrackers): Added.
2216 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
2217 their respective ids to make the ordering stable.
2219 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
2221 Remove unused jobs table
2222 https://bugs.webkit.org/show_bug.cgi?id=137724
2224 Reviewed by Daniel Bates.
2226 Removed jobs table in the database as well as related code.
2228 * init-database.sql:
2229 * public/admin/jobs.php: Removed.
2230 * public/admin/tests.php:
2231 * public/include/admin-header.php:
2233 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2235 New perf dashboard should have an ability to search commits by a keyword
2236 https://bugs.webkit.org/show_bug.cgi?id=137675
2238 Reviewed by Geoffrey Garen.
2240 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
2241 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
2242 This API change allows fetch_commits_between to generate results without processing Postgres query results.
2244 In the front end side, we've added a search pane in pane controller, and the interactive chart component
2245 now has a concept of highlighted items which is used to indicate commits found by the search pane.
2247 * public/api/commits.php:
2248 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
2249 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
2250 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
2251 (format_commit): Renamed from format_commits. Now only formats one commit.
2253 * public/include/db.php:
2254 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
2256 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
2259 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
2260 which is a hash table that contains highlighted items' measurements' ids as keys.
2261 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
2262 the default commit repository.
2263 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
2264 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
2265 Added the code to initialize this._highlights.
2266 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
2267 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
2268 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
2269 the existing lines for the old highlighted items.
2270 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
2271 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
2273 * public/v2/chart-pane.css: Added style for the search pane and the search button.
2275 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
2276 (CommitLogs): Added.
2277 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
2278 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
2279 (CommitLogs._cacheConsecutiveCommits): Ditto.
2280 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
2281 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
2282 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
2284 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
2285 for showingDetails since this property is no longer used.
2287 * public/v2/manifest.js:
2288 (App.Manifest.repositories): Added.
2289 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
2290 the default repository to search.
2291 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
2293 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2295 Unreviewed build fix after r174555.
2297 * public/include/manifest.php:
2298 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
2299 * tests/admin-regenerate-manifest.js: Fixed the test case.
2301 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
2303 New perf dashboard UI tries to fetch commits all the time
2304 https://bugs.webkit.org/show_bug.cgi?id=137592
2306 Reviewed by Andreas Kling.
2308 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
2309 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
2310 no reported commits as they are all going to fail.
2312 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
2313 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
2314 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
2315 of commits sorted chronologically by time.
2317 * public/include/manifest.php:
2320 (App.CommitsViewerComponent.commitsChanged):
2322 * public/v2/data.js:
2323 (FetchCommitsForTimeRange):
2324 (FetchCommitsForTimeRange._cachedCommitsByRepository):
2326 * public/v2/manifest.js:
2329 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2331 Another unreviewed build fix after r174477.
2333 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
2335 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
2337 * public/include/report-processor.php:
2339 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2341 Unreviewed build fix after r174477.
2343 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
2344 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
2346 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
2347 This is necessary for baseline and target values manually added via admin pages.
2349 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2351 Add v2 UI for the perf dashboard
2352 https://bugs.webkit.org/show_bug.cgi?id=137537
2354 Rubber-stamped by Andreas Kling.
2357 * public/v2/app.css: Added.
2358 * public/v2/app.js: Added.
2359 * public/v2/chart-pane.css: Added.
2360 * public/v2/data.js: Added.
2361 * public/v2/index.html: Added.
2362 * public/v2/js: Added.
2363 * public/v2/js/d3: Added.
2364 * public/v2/js/d3/LICENSE: Added.
2365 * public/v2/js/d3/d3.js: Added.
2366 * public/v2/js/d3/d3.min.js: Added.
2367 * public/v2/js/ember-data.js: Added.
2368 * public/v2/js/ember.js: Added.
2369 * public/v2/js/handlebars.js: Added.
2370 * public/v2/js/jquery.min.js: Added.
2371 * public/v2/js/statistics.js: Added.
2372 * public/v2/manifest.js: Added.
2373 * public/v2/popup.js: Added.
2375 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2377 Remove superfluously duplicated code in public/api/report-commits.php.
2379 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2381 Perf dashboard should store commit logs
2382 https://bugs.webkit.org/show_bug.cgi?id=137510
2384 Reviewed by Darin Adler.
2386 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
2388 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
2389 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
2390 a subversion directory. The git version of this script will be added in a follow up patch.
2393 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
2394 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
2395 relationship via "build_commits" relations.
2397 In order to migrate an existing instance of this application, run the following SQL commands:
2401 INSERT INTO commits (commit_repository, commit_revision, commit_time)
2402 (SELECT DISTINCT ON (revision_repository, revision_value)
2403 revision_repository, revision_value, revision_time FROM build_revisions);
2405 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
2406 FROM commits, build_revisions
2407 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
2409 DROP TABLE build_revisions;
2414 The helper script to submit commit logs can be used as follows:
2416 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
2417 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
2419 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
2420 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
2421 "feeder-slave-password" as the builder name and the builder password respectively.
2423 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
2424 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
2427 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
2429 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
2430 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
2432 - Not specified - It returns every single commit for a given repository.
2433 - Matches "oldest" - It returns the commit with the oldest timestamp.
2434 - Matches "latest" - It returns the commit with the latest timestamp.
2435 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
2436 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
2437 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
2438 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
2439 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
2440 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
2442 (commit_from_revision):
2443 (fetch_commits_between):
2446 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
2447 See tests/api-report-commits.js for examples on how to use this API.
2449 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
2450 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
2451 to optimize this and other JSON APIs.
2453 * public/include/db.php:
2454 (Database::select_or_insert_row):
2455 (Database::update_or_insert_row): Added.
2456 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
2457 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
2459 (Database::select_first_row):
2460 (Database::select_last_row): Added.
2461 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
2462 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
2464 * public/include/report-processor.php:
2465 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
2466 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
2467 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
2470 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
2472 * tests/api-report-commits.js: Added.
2473 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
2476 * tools/pull-svn.py: Added. See above for how to use this script.
2478 (determine_first_revision_to_fetch):
2479 (fetch_revision_from_dasbhoard):
2480 (fetch_commit_and_resolve_author):
2483 (resolve_author_name_from_email):
2486 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
2488 Update Install.md for Mavericks and fix typos
2489 https://bugs.webkit.org/show_bug.cgi?id=137276
2491 Reviewed by Benjamin Poulain.
2493 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
2495 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
2497 Finally, init-database.sql is no longer located inside database directory.
2501 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2503 Report run id's in api/runs.php for the new dashboard UI
2504 https://bugs.webkit.org/show_bug.cgi?id=135813
2506 Reviewed by Andreas Kling.
2508 Include run_id in the generated JSON.
2510 * public/api/runs.php:
2511 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
2514 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2516 Merging platforms mixes baselines and targets into reported data
2517 https://bugs.webkit.org/show_bug.cgi?id=135260
2519 Reviewed by Andreas Kling.
2521 When merging two platforms, move test configurations of a different type (baseline, target)
2522 as well as of different metric (Time, Runs).
2524 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
2525 It's sufficient to detect one such test_runs object.
2527 * public/admin/platforms.php:
2530 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
2532 Merging platforms mixes baselines and targets into reported data
2533 https://bugs.webkit.org/show_bug.cgi?id=135260
2535 Reviewed by Geoffrey Garen.
2537 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
2538 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
2540 * public/admin/platforms.php:
2542 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
2544 Build fix after r171361.
2546 * public/js/helper-classes.js:
2547 (.this.formattedBuildTime):
2549 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
2551 Perf dashboard spends 2s processing JSON data during the page loads
2552 https://bugs.webkit.org/show_bug.cgi?id=135152
2554 Reviewed by Andreas Kling.
2556 In the Apple internal dashboard, we were spending as much as 2 seconds
2557 converting raw JSON data into proper JS objects while loading the dashboard.
2559 This caused the apparent unresponsiveness of the dashboard despite of the fact
2560 charts themselves updated almost instantaneously.
2562 * public/index.html:
2563 * public/js/helper-classes.js:
2564 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
2565 lazily as creating new Date objects and running string replace is expensive.
2566 (TestBuild.formattedTime):
2567 (TestBuild.formattedBuildTime):
2568 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
2569 (PerfTestRuns.addResult): Deleted.
2571 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
2573 Perf dashboard shouldn't show the full git hash
2574 https://bugs.webkit.org/show_bug.cgi?id=135083
2576 Reviewed by Benjamin Poulain.
2578 Detect Git/Mercurial hash by checking the length.
2580 If it's a hash, use the first 8 characters in the label
2581 while retaining the full length to be used in hyperlinks.
2583 * public/js/helper-classes.js:
2584 (.this.formattedRevisions):
2587 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
2589 Add an instruction on how to backup the database.
2590 https://bugs.webkit.org/show_bug.cgi?id=133391
2592 Rubber-stamped by Andreas Kling.
2596 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2598 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
2600 * public/js/helper-classes.js:
2601 (PerfTestRuns.smallerIsBetter):
2603 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2607 * public/common.css:
2609 * public/index.html:
2613 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2615 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
2616 https://bugs.webkit.org/show_bug.cgi?id=131157
2618 Reviewed by Andreas Kling.
2620 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
2621 This allows, for example, adding all metrics such as Arithmetic and Geometric for
2622 a given test suite without also adding its subtests.
2624 * public/index.html:
2628 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2630 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
2631 https://bugs.webkit.org/show_bug.cgi?id=131155
2633 Reviewed by Andreas Kling.
2635 The bug was caused by Chart.attach binding event listeners on plot container on each call.
2636 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
2637 click when attach() has been called even number of times, keeping the tooltip invisible.
2639 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
2640 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
2641 is called for the first time.
2643 * public/index.html:
2645 (Chart..bindPlotEventHandlers):
2647 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2649 WebKitPerfMonitor: Tooltips can be cut off at the top
2650 https://bugs.webkit.org/show_bug.cgi?id=130960
2652 Reviewed by Andreas Kling.
2654 * public/common.css:
2655 (#title): Removed the gradients, box shadows, and border from the header.
2656 (#title h1): Reduce the font size.
2657 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
2658 * public/index.html:
2659 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
2660 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
2661 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
2662 * public/js/helper-classes.js:
2663 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
2664 tooltip extending above y=0.
2666 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2668 WebKitPerfMonitor: Y-axis adjustment is too aggressive
2669 https://bugs.webkit.org/show_bug.cgi?id=130937
2671 Reviewed by Andreas Kling.
2673 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
2674 results. This had two major problems:
2675 1. Two standard deviations can be too small to show the confidence interval for results.
2676 2. Sometimes baseline and target can be more than two standards deviations away.
2678 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
2679 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
2680 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
2681 the margin on each side separately to reduce the empty space on either side.
2683 A more rigorous approach would involve computing least squared value of results with respect to intervals
2684 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
2686 * public/index.html:
2687 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
2688 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
2689 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
2690 We wouldn't see the difference between measured values versus baseline and target values otherwise.
2691 * public/js/helper-classes.js:
2692 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
2693 interval delta cannot be computed.
2694 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
2695 within the given interval.
2696 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
2697 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
2698 (PerfTestRuns..unscaledMeansForAllResults):
2699 (PerfTestRuns.min): Take the confidence interval delta into account.
2700 (PerfTestRuns.max): Ditto.
2701 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
2702 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
2704 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
2706 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
2708 Some CSS tweaks after r166477 and r166479,
2710 * public/index.html:
2712 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2714 WebKitPerfMonitor: Sometimes text inside panes overlap
2715 https://bugs.webkit.org/show_bug.cgi?id=130956
2717 Reviewed by Gyuyoung Kim.
2719 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
2720 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
2721 reduces the total height of the pane and fits more information per screen capita on the dashboard.
2723 * public/index.html: Updated and added a bunch of CSS rules for the new look.
2724 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
2725 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
2726 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
2727 of the build info shown in a chart pane and a tooltip.
2728 (Chart): Made .status a table.
2729 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
2730 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
2731 now that status.text no longer contains it.
2732 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
2734 * public/js/helper-classes.js:
2735 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
2736 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
2737 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
2738 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
2739 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
2740 capital letter; e.g. "MB" instead of "M B".
2742 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2744 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
2745 https://bugs.webkit.org/show_bug.cgi?id=130957
2747 Reviewed by Gyuyoung Kim.
2749 Moved the slider into the header. Also reduced the spacing between the header and platform names.
2750 This reclaims 50px Ă— width of the screen real estate.
2752 * public/common.css:
2753 (#title): Reduced the space below the header from 20px to 10px.
2754 * public/index.html:
2755 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
2756 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
2757 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
2758 real estate between the header and the platform names.
2760 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2762 Update the install guidelines for perf.webkit.org
2763 https://bugs.webkit.org/show_bug.cgi?id=129895
2765 Reviewed by Ryosuke Niwa.
2767 The current install guideline for perf.webkit.org discourages the use of the installed
2768 Server application. I've actualized the documentation for Mavericks, and modified the
2769 guideline to include the instructions for Server.app also.
2773 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
2775 Update perf.webkit.org json example
2776 https://bugs.webkit.org/show_bug.cgi?id=129907
2778 Reviewed by Andreas Kling.
2780 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
2784 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
2786 Merge database-common.js and utility.js into run-tests.js.
2788 Reviewed by Matthew Hanson.
2790 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
2791 Also moved init-database.sql out of the database directory and removed the directory entirely.
2793 * database: Removed.
2794 * database/database-common.js: Removed.
2795 * database/utility.js: Removed.
2796 * init-database.sql: Moved from database/init-database.sql.
2798 (connect): Moved from database-common.js.
2799 (pathToDatabseSQL): Extracted from pathToLocalScript.
2800 (pathToTests): Moved from database-common.js.
2803 (SerializedTaskQueue): Ditto.
2805 (initializeDatabase):
2806 (TestEnvironment.it):
2807 (TestEnvironment.queryAndFetchAll):
2810 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2812 Remove the dependency on node.js from the production code.
2814 Reviewed by Ricky Mondello.
2816 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
2818 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
2819 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
2820 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
2821 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
2822 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
2824 Also removed the js files that are no longer used.
2826 * config.json: Moved from database/config.json.
2827 * database/aggregate.js: Removed. No longer used.
2828 * database/database-common.js: Removed unused functions, and updated the path to config.json.
2829 * database/process-jobs.js: Removed. No longer used.
2830 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2831 * database/schema.graffle: Removed. It's completely obsolete.
2832 * public/include/db.php: Updated the path to config.json.
2833 * public/include/evaluator.js: Removed.
2835 * public/include/report-processor.php:
2836 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2837 storing values into $expressions and calling evaluate_expressions_by_node.
2838 (TestRunsGenerator::aggregate_values): Added.
2839 (TestRunsGenerator::compute_caches): Directly compute the caches.
2841 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2843 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2845 * public/admin/platforms.php:
2846 * public/include/db.php:
2848 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2850 Zoomed y-axis view is ununsable when the last result is an outlier.
2852 Reviewed by Stephanie Lewis.
2854 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2855 the last result so that the graph looks sane if the last result was an outlier. However, always show
2856 the last result's mean even if it was an outlier.
2858 * public/index.html:
2859 * public/js/helper-classes.js:
2860 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2861 Also added the ability to cache the unscaled means to avoid recomputation.
2862 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2863 (PerfTestRuns.max): Ditto.
2864 (PerfTestRuns.sampleStandardDeviation): Ditto.
2865 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2867 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2871 * public/admin/tests.php:
2872 * public/js/helper-classes.js:
2874 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2876 Use two standard deviations instead as I mentioned in the mailing list.
2878 * public/index.html:
2880 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2882 The performance dashboard erroneously shows upward arrow for combined metrics.
2884 A single outlier can ruin the zoomed y-axis view.
2886 Rubber-stamped by Antti Koivisto.
2888 * public/index.html:
2889 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2890 from the latest results' mean.
2891 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2892 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2893 (Chart.toggleYAxis):
2894 * public/js/helper-classes.js:
2895 (PerfTestRuns.sampleStandardDeviation): Added.
2896 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2898 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2900 Don't include the confidence interval when computing the y-axis.
2902 Rubber-stamped by Simon Fraser.
2904 * public/js/helper-classes.js:
2908 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2910 Tiny CSS tweak for tooltips.
2912 * public/index.html:
2914 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2916 Remove the erroneously repeated code.
2918 * public/admin/test-configurations.php:
2920 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2922 <rdar://problem/15704893> perf dashboard should show baseline numbers
2924 Reviewed by Stephanie Lewis.
2926 * public/admin/bug-trackers.php:
2927 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2930 * public/admin/platforms.php:
2931 (merge_list): Ditto.
2933 * public/admin/test-configurations.php: Added.
2934 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2935 build_revisions as they're not meaningful for baseline / target numbers.
2936 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2937 one test run so that we don't accidentally delete a reported test run.
2938 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2939 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2940 and delete existing ones.
2942 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2943 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2944 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2946 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2947 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2948 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2949 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2950 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2952 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2954 * public/include/admin-header.php:
2955 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2956 have id and type sub columns, and each custom column could generate multiple rows.
2958 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2959 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2960 We then proceed to generate the second header row with sub column names.
2962 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2963 which case regular columns need rowspan set to the maximum number of rows.
2965 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2968 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2969 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2970 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2971 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2972 expanded to occupy all sub columns.
2974 * public/include/manifest.php:
2975 (ManifestGenerator::platforms): Don't add the metric more than once.
2977 * public/include/test-name-resolver.php:
2978 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2979 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2980 full metric name later.
2981 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2982 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2983 (TestNameResolver::full_name_for_test): Added.
2984 (TestNameResolver::full_name_for_metric): Added.
2985 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2987 * public/js/helper-classes.js:
2988 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2989 test runs created to set baseline and target points.
2991 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2993 Build fix after r57928. Removed a superfluous close parenthesis.
2995 * public/api/runs.php:
2997 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2999 Unreviewed build & typo fixes.
3001 * public/admin/platforms.php:
3002 * tests/admin-platforms.js:
3004 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
3006 <rdar://problem/15704893> perf dashboard should show baseline numbers
3008 Rubber-stamped by Antti Koivisto.
3010 Organize some code into functions in runs.php.
3012 Also added back $paths that was erroneously removed in r57925 from json-header.php.
3014 * public/api/runs.php:
3015 (fetch_runs_for_config): Extracted.
3016 (format_run): Ditto.
3018 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
3020 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
3022 * database/config.json:
3023 * public/admin/reprocess-report.php:
3024 * public/api/report.php:
3025 * public/api/runs.php:
3026 * public/include/json-header.php:
3028 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
3030 Commit yet another forgotten change.
3032 Something went horribly wrong with my merge :(
3034 * database/init-database.sql:
3036 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
3038 Commit one more forgotten change. Sorry for making a mess here.
3040 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
3042 Commit the forgotten files.
3044 * public/admin/platforms.php: Added.
3045 * tests/admin-platforms.js: Added.
3047 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
3049 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
3051 Reviewed by Stephanie Lewis.
3053 Added /admin/platforms/ page to hide and merge platforms.
3055 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
3056 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
3057 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
3058 each test configuration a distinct "test run" for each build.
3060 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
3061 their test configurations into platform B.
3063 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
3064 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
3065 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
3066 in platform B, in which case R should relate to T_B instead.
3068 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
3069 new platform. We then migrate the test configurations of the remaining test runs.
3071 * database/init-database.sql: Added platform_hidden.
3073 * public/admin/platforms.php: Added.
3074 (merge_platforms): Added. Implements the algorithm described above.
3075 (merge_list): Added.
3077 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
3078 is hidden since it doesn't do anything.
3080 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
3081 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
3082 missing it since unchecked checkbox doesn't set the value in $_POST.
3083 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
3084 switch statement instead of repeated if's.
3085 (AdministrativePage::render_table): Emit "update-column" for update_field.
3087 * public/include/db.php: Disable warnings when we're not in the debug mode.
3089 * public/include/manifest.php:
3090 (ManifestGenerator::platforms): Skip platforms that have been hidden.
3093 (TestEnvironment.postJSON):
3094 (TestEnvironment.httpGet):
3095 (TestEnvironment.httpPost): Added.
3096 (sendHttpRequest): Set the content type if specified.
3098 * tests/admin-platforms.js: Added tests.
3100 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
3102 Extract the code to compute full test names from tests.php.
3104 Reviewed by Stephanie Lewis.
3106 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
3107 and paves our way to re-use the code in other pages.
3109 * public/admin/tests.php:
3111 * public/include/db.php:
3112 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
3113 tests.php and test-name-resolver.php.
3115 * public/include/test-name-resolver.php: Added.
3116 (TestNameResolver::__construct):
3117 (TestNameResolver::compute_full_name): Moved from tests.php.
3118 (TestNameResolver::map_metrics_to_tests): Ditto.
3119 (TestNameResolver::sort_tests_by_full_name): Ditto.
3120 (TestNameResolver::tests): Added.
3121 (TestNameResolver::test_id_for_full_name): Ditto.
3122 (TestNameResolver::metrics_for_test_id): Ditto.
3123 (TestNameResolver::child_metrics_for_test_id): Ditto.
3124 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
3126 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
3128 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
3130 Reviewed by Stephanie Lewis.
3132 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
3134 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
3135 but that's sufficient to correct the wrongfully processed reports for now.
3137 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
3138 We should eventually add a nice UI to find and reprocess reports.
3140 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
3142 * public/include/db.php: Added the forgotten call to prefixed_column_names.
3144 * public/include/report-processor.php: Copied from public/api/report.php.
3145 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
3146 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
3147 create a new report or authenticate the builder password (the password is never stored in the report).
3148 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
3149 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
3150 (ReportProcessor::store_report): Ditto.
3152 * tests/admin-reprocess-report.js: Added.
3154 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
3156 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
3158 Reviewed by Ricky Mondello.
3160 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
3161 for the same build number as a single build by ignoring build time. This was necessary to associate
3162 multiple reports by a single build - e.g. for different performance test suites - because the scripts
3163 we use to submit results computed its own "build time" when they're called.
3165 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
3166 last week; new reports were wrongfully associated with old build numbers.
3168 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
3169 to the same build. Instead, we create a new build object for those reports. Since the longest set of
3170 tests we have only take a couple of hours to run, 24 hours should be more than enough.
3172 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
3173 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
3174 (builder, build number, build time).
3176 * public/api/report.php:
3177 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
3178 when no such build exists. This prevents a report from being associated with a very old build of the same
3181 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
3182 a similar bug in the future sooner.
3184 * tests/api-report.js: Added three test cases.
3186 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
3188 Merged the upstream changes to db.php
3189 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
3191 * public/include/db.php:
3193 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
3195 Update other scripts and tests per previous patch.
3197 * public/include/manifest.php:
3198 * tests/admin-regenerate-manifest.js:
3200 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
3202 Remove metrics_unit.
3204 Reviewed by Ricky Mondello.
3206 This column is no longer used by the front-end code since r48360.
3208 * database/init-database.sql:
3209 * public/admin/tests.php:
3211 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
3213 Unreviewed build fix.
3215 * public/api/report.php:
3217 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
3219 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
3221 Reviewed by Ricky Mondello.
3223 Support a new alternative format for aggregated results where we have raw values as well as
3224 the list aggregators so that instead of
3225 "metrics": {"Time": ["Arithmetic"]}
3227 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
3229 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
3230 dashboard and the generated results page, which doesn't know how to aggregate values.
3232 We need to keep the support for the old format because all other existing performance tests
3233 all rely on the old format. Even if we updated the tests, we need the dashboard to support
3234 the old format during the transition.
3236 * public/api/report.php:
3237 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
3238 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
3240 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
3242 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
3244 Unreviewed; Tweak the CSS so that chart panes align vertically.
3246 * public/index.html:
3248 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
3250 SafariPerfMonitor should support Combined metric.
3252 * public/js/helper-classes.js:
3253 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
3254 value as well but assume it to be greater-is-better for now.
3256 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
3258 Commit the forgotten init-database change to add iteration_relative_time.
3260 * database/init-database.sql:
3262 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
3264 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
3266 Reviewed by Ricky Mondello.
3268 Add the support for each value to have a relative time. This is necessary for frame rate history
3269 since a frame rate needs to be associated with a time it was sampled.
3271 * database/init-database.sql: Added iteration_relative_time to run_iterations.
3273 * public/api/report.php:
3274 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
3275 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
3276 with relative time since taking the average of two frame rates for two subtests taken at two
3277 different times doesn't make any sense.
3278 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
3279 etc..., use the second element since we assume values are of the form (relative time, frame rate).
3280 Also exit early with an error if the number of elements in the array is not a pair.
3281 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
3283 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
3284 iteration_relative_time.
3286 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
3288 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
3290 Reviewed by Ricky Mondello.
3292 Support that. It's one line change.
3294 * public/api/report.php:
3295 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
3296 to match the convention assumed elsewhere.
3297 * tests/api-report.js: Added a test case.
3299 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
3301 SafariPerfMonitor shows popups for points outside of the visible region.
3303 Rubber-stamped by Simon Fraser.
3305 * public/index.html:
3306 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
3307 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
3308 may return an item underneath y-axis labels.
3310 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
3312 Tweak the CSS a little to avoid the test name overlapping with the summary table.
3314 * public/index.html:
3316 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
3318 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
3320 * public/index.html:
3322 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
3324 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
3325 <rdar://problem/13992271> Should scale Y axis to include error ranges
3327 Reviewed by Ricky Mondello.
3329 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
3330 the main graph doesn't go outside the graph even when the y-axis is adjusted.
3332 * database/config.json:
3333 * public/index.html:
3334 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
3335 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
3336 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
3338 * public/js/helper-classes.js:
3339 (PerfTestResult.confidenceIntervalDelta):
3340 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
3341 (PerfTestRuns.min): Take confidence interval delta into account.
3342 (PerfTestRuns.max): Ditto.
3343 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
3345 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
3347 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
3349 * public/api/report.php:
3350 (ReportProcessor::recursively_ensure_tests):
3351 * tests/api-report.js: Added a test.
3353 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
3355 Unreviewed build fixes.
3357 * public/api/report.php:
3358 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
3359 Also, tolerate reports without any revision information.
3361 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
3364 * tests/api-report.js: Added few test cases.
3366 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
3368 Commit another change that was supposed to be committed in r50331.
3371 (TestEnvironment.this.postJSON):
3372 (TestEnvironment.this.httpGet):
3375 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
3377 Commit the remaining files.
3379 * public/admin/regenerate-manifest.php:
3380 * public/include/admin-header.php:
3381 * public/include/json-header.php:
3382 * public/include/manifest.php:
3384 (TestEnvironment.this.postJSON):
3385 (TestEnvironment.this.httpGet):
3388 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
3390 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
3392 Reviewed by Ricky Mondello.
3394 Added some tests for admin/regenerate-manifest.
3396 * public/admin/regenerate-manifest.php: Use require_once instead of require.
3397 * public/include/admin-header.php: Ditto.
3398 * public/include/json-header.php: Ditto.
3400 * public/include/manifest.php:
3401 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
3402 When there are no builders, simply return an empty array.
3405 (TestEnvironment.postJSON):
3406 (TestEnvironment.httpGet): Added.
3407 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
3409 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
3411 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
3413 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
3414 and run_iterations. Also fixed a typo in report.php found by new tests.
3416 * public/api/report.php:
3417 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
3418 * tests/api-report.js: Added more test cases.
3420 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
3422 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
3424 Reviewed by Ricky Mondello.
3426 Add a test runner script and some simple test cases.
3428 * database/config.json: Added the configuration for "testServer".
3429 * database/database-common.js:
3430 (pathToTests): Added.
3431 * run-tests.js: Added.
3434 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
3435 and if there are, asks the user if it’s okay to delete all of the data contained therein.
3436 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
3438 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
3439 in the current database using PostgreSQL's information_schema.
3440 (askYesOrNoQuestion):
3442 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
3444 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
3445 (TestEnvironment.assert): Exposes assert to tests.
3446 (TestEnvironment.console): Exposes console to tests.
3447 (TestEnvironment.describe): Adds a description.
3448 (TestEnvironment.it): Adds a test case.
3449 (TestEnvironment.postJSON):
3450 (TestEnvironment.queryAndFetchAll):
3451 (TestEnvironment.sha256):
3452 (TestEnvironment.notifyDone): Ends the current test case.
3456 (TestContext): An object created for each test case. Conceptually, this object is always on
3457 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
3458 this object via currentTestContext.
3459 (TestContext.description):
3461 (TestContext.logError):
3464 * tests/api-report.js: Added some basic tests for /api/report.php.
3466 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3468 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
3470 The problem was that we were detecting whether we're updating dashboard or not by checking
3471 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
3472 all configurations. Use separate 'dashboard' action to execute the code even when
3473 metric_configurations is empty.
3475 * public/admin/tests.php:
3477 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3479 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
3481 Reviewed by Ricky Mondello.
3483 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
3484 from ReportProcessor as a preparation to replace deprecated aggregate.js.
3486 * public/api/report.php:
3487 (ReportProcessor::exit_with_error): Moved.
3488 (ReportProcessor::process): Use the extracted TestRunsGenerator.
3489 (TestRunsGenerator): Added.
3490 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
3491 (TestRunsGenerator::add_aggregated_metric): Moved.
3492 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
3493 (TestRunsGenerator::aggregate): Moved. Made public.
3494 (TestRunsGenerator::aggregate_current_test_level): Moved.
3495 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
3496 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
3497 (TestRunsGenerator::compute_caches): Moved. Made public.
3498 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
3499 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
3500 (TestRunsGenerator::rollback_with_error): Moved.
3502 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3504 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
3506 Reviewed by Remy Demarest.
3508 Regenerate the manifest file when updating fields or adding new items that are included in
3511 * public/admin/bug-trackers.php:
3512 * public/admin/builders.php:
3513 * public/admin/regenerate-manifest.php:
3514 * public/admin/repositories.php:
3515 * public/admin/tests.php:
3516 * public/include/admin-header.php:
3517 (regenerate_manifest): Extracted from regenerate-manifest.php.
3519 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3521 Unreviewed build fix for memory test results.
3523 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
3524 aggregating at each level.
3526 * public/api/report.php:
3527 (ReportProcessor::recursively_ensure_tests):
3528 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
3529 (ReportProcessor::add_values_for_aggregation):
3530 (ReportProcessor::aggregate):
3531 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
3533 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
3535 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
3536 not the number of iteration groups. Also, don't set group number when the entire run belongs
3537 a single iteration group.
3539 * public/api/report.php:
3540 (ReportProcessor::commit):
3542 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3544 SafariPerfMonitor: Introduce iteration groups
3546 Reviewed by Remy Demarest.
3548 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
3549 the runtime environment variances to get more stable results. And it's desirable to keep track of
3550 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
3552 This patch introduces "iteration groups" to keep track of this extra information.
3554 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
3555 the outer array denotes iteration groups and each inner array contains iteration values for each group.
3558 * database/init-database.sql: Add iteration_group column.
3559 * public/api/report.php:
3560 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
3562 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
3563 contains the list of values indexed by the iteration order and group sizes. Store the group size so
3564 that we can restore the iteration groups before passing it to node.js and restore them later.
3566 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
3567 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
3569 Also check that each iteration group in each subtest are consistent with one another. To see why we need
3570 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
3571 that each iteration group in T1 and T2 have the same size:
3572 T1 = [[1, 2], [3, 4, 5]]
3573 T2 = [[6, 7], [8, 9, 10]]
3575 so that the aggregated result (the sum in this case) can have the same groups as in:
3576 T = [[7, 9], [11, 13, 15]]
3578 If some iteration groups in T1 and T2 had a different size as in:
3579 T1 = [[1, 2, 3], [4, 5]]
3580 T2 = [[6, 7], [8, 9, 10]]
3582 Then iteration groups of the aggregated T is ambiguous.
3584 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
3585 (ReportProcessor::commit): Store iteration_group values.
3587 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3589 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
3590 migrated to perf.webkit.org.
3592 * database/perf-webkit-migrator.js: Removed.
3594 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3596 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
3598 * public/index.html:
3601 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3603 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
3605 Reviewed by Ricky Mondello.
3607 It is often desirable to see charts of a given test for all platforms, or to be able to see
3608 charts of all subtests on a given platform when trying to triage perf. regressions.
3610 Support this use case by adding the ability to do so on the charts page.
3612 Also, we used to disable items on the test list based on the platform chosen. This turned out
3613 to be a bad UI because in many situations you want to be able to compare results of the same test
3614 on multiple platforms.
3616 In this new UI, we have three select elements, each of which selects the following:
3617 1. Top-level test - Test suite such as Dromaeo
3618 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
3619 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
3620 3. Platform - Mountain Lion, Qt, etc...
3622 A user can select "all" for metric and platform but we disallow doing both at once since adding
3623 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
3624 think of a use case where you want to look at that many charts at once. We can support this later
3625 if valid use cases come up.
3627 * public/index.html:
3628 (.showCharts.addOption): Extracted.
3629 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
3630 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
3631 metricList has onchange handler that enables/disables items on platformList.
3633 (init): Sort tests and test metrics here instead of doing that in showCharts.
3635 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
3637 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
3639 Reviewed by Remy Demarest and Ricky Mondello.
3641 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
3642 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
3643 templates to the manifest file instead. Each build now only contains the builder id.
3645 * public/api/runs.php: Removed the part of the query that joined builders table. This
3646 speeds up the query quite a bit.
3648 * public/include/manifest.php:
3649 (ManifestGenerator::generate): Generate builders field.
3650 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
3651 associative array that contains name and its build URL template.
3653 * public/index.html: