1 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
3 REGRESSION: Perf dashboard sometimes fails to update zooming level
4 https://bugs.webkit.org/show_bug.cgi?id=143359
6 Reviewed by Darin Adler.
8 The bug was caused by various bugs that ended up in an exception.
11 (App.Pane._handleFetchErrors): Removed superfluous console.log.
12 (App.Pane.computeStatus): Fixed the bug in r182185 that previousPoint could be null.
13 (App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
14 * public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
15 to # when Ember.js fails to attach event listeners on time.
16 * public/v2/interactive-chart.js:
17 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
18 the containing element's size is 0.
19 (App.InteractiveChartComponent._updateBrush): Ditto.
21 2015-04-02 Ryosuke Niwa <rniwa@webkit.org>
23 Perf dashboard should have UI to test out anomaly detection strategies
24 https://bugs.webkit.org/show_bug.cgi?id=143290
26 Reviewed by Benjamin Poulain.
28 Added the UI to select anomaly detection strategies. The detected anomalies are highlighted in the graph.
30 Implemented the Western Electric Rules 1 through 4 in http://en.wikipedia.org/wiki/Western_Electric_rules
31 as well as Welch's t-test that compares the last five points to the prior twenty points.
33 The latter is what Mozilla uses (or at least did in the past) to detect performance regressions on their
34 performance tests although they compare medians instead of means.
36 All of these strategies don't quite work for us since our data points are too noisy but this is a good start.
39 (App.Pane.updateStatisticsTools): Clone anomaly detection strategies.
40 (App.Pane._updateMovingAverageAndEnvelope): Highlight anomalies detected by the enabled strategies.
41 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Observe changes to anomaly detection strategies.
42 (App.Pane._computeMovingAverageAndOutliers): Detect anomalies by each strategy and aggregate results.
43 Only report the first data point when multiple consecutive data points are detected as anomalies.
44 * public/v2/chart-pane.css: Updated styles.
45 * public/v2/index.html: Added the pane for selecting anomaly detection strategies.
46 * public/v2/js/statistics.js:
47 (Statistics.testWelchsT): Added. Implements Welch's t-test.
48 (.sampleMeanAndVarianceForValues): Added.
49 (.createWesternElectricRule): Added.
50 (.countValuesOnSameSide): Added.
51 (Statistics.AnomalyDetectionStrategy): Added.
53 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
55 REGRESSION: Searching commits can highlight wrong data points
56 https://bugs.webkit.org/show_bug.cgi?id=143272
58 Reviewed by Antti Koivisto.
60 The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
61 return commit times with only second precision. This resulted in the frontend code to match a commit
62 with the data point that included the next commit when the millisecond component of commit's timestamp
65 This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
66 was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
67 so miliseconds component was only preserved in /api/commits.
69 Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
70 it returns time in milisecond precision.
72 * public/api/commits.php:
73 (fetch_commits_between): Use Database::to_js_time for format commit times.
74 (format_commit): Ditto.
75 * public/include/db.php:
76 (Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
78 (CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
80 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
82 Perf dashboard should show relative change in values
83 https://bugs.webkit.org/show_bug.cgi?id=143252
85 Reviewed by Antti Koivisto.
87 When a range of values are selected, show the percentage difference between the start and the end
88 in addition to the absolute value difference. When a single point is selected, show the relative
89 difference with respect to the previous point. Use two significant figures and always show plus sign
90 when the difference is positive.
92 * public/v2/app.js: Compute and format the relative difference.
93 * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
94 * public/v2/index.html: Show the relative difference.
96 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
98 REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
99 https://bugs.webkit.org/show_bug.cgi?id=143254
101 Reviewed by Antti Koivisto.
103 The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
104 or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
105 so that the interactive chart component will observe a change to 'chartData'.
108 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
110 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
112 Unreviewed build fixes.
114 * public/include/manifest.php:
115 (Manifest::generate): These should be {} instead of [] when they're empty.
117 (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
118 * public/v2/manifest.js:
119 (App.Metric.fullName): Fixed the typo.
120 * tests/admin-regenerate-manifest.js: Fixed the test.
122 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
124 Commit the erroneously reverted change.
126 * public/api/runs.php:
127 (RunsGenerator::results):
129 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
131 Loading the perf dashboard takes multiple seconds
132 https://bugs.webkit.org/show_bug.cgi?id=141860
134 Reviewed by Andreas Kling.
136 This patch introduces the caches of JSON files returned by /api/ in /data/ directory. It also records
137 the last time test_runs rows associated with the requested platforms and metrics are inserted, updated,
138 or removed in the caches as well as the manifest JSON files ("last modified time"). Because the manifest
139 is regenerated each time a new test result is reported, the front end can compare last modified time in
140 the manifest file with that in a /api/runs JSON cache to detect the stale-ness.
142 More concretely, the front end first optimistically fetches the JSON in /data/. If the cache doesn't exit
143 or the last modified time in the cache doesn't match with that in the manifest file, it would fetch it
144 again via /api/runs. In the case the cache did exist, we render the charts based on the cache meanwhile.
145 This dramatically reduces the perceived latency for the page load since charts are drawn immediately using
146 the cache and we would only re-render the charts as new up-to-date JSON comes in.
148 This patch also changes the format of runs JSONs by pushing the exiting properties into 'configurations'
149 and adding 'lastModified' and 'elapsedTime' at the top level.
151 * init-database.sql: Added config_runs_last_modified to test_configurations table as well as a trigger to
152 auto-update this column upon changes to test_runs table.
154 * public/admin/test-configurations.php:
155 (add_run): Regenerate the manifest file to invalidate the /api/runs JSON cache.
158 * public/api/runs.php:
159 (main): Fetch all columns of test_configurations table including config_runs_last_modified. Also generate
160 the cache in /data/ directory.
161 (RunsGenerator::__construct): Compute the last modified time for this (platform, metric) pair.
162 (RunsGenerator::results): Put the old content in 'configurations' property and include 'lastModified' and
163 'elapsedTime' properties. 'elapsedTime' is added for debugging purposes.
164 (RunsGenerator::add_runs):
165 (RunsGenerator::parse_revisions_array):
167 * public/include/db.php:
169 (generate_data_file): Added based on ManifestGenerator::store.
170 (Database::to_js_time): Extracted from RunsGenerator::add_runs to share code.
172 * public/include/json-header.php:
173 (echo_success): Renamed from success_json. Return the serialized JSON instead of echo'ing it so that we can
174 generate caches in /api/runs/.
177 * public/include/manifest.php:
178 (ManifestGenerator::generate): Added 'elapsedTime' property for the time taken to generate the manifest.
179 It seems like we're generating it in 200-300ms for now so that's good.
180 (ManifestGenerator::store): Uses generate_data_file.
181 (ManifestGenerator::platforms): Added 'lastModified' array to each platform entry. This array contains the
182 last modified time for each (platform, metric) pair.
185 (fetchTest): Updated per the format change in runs JSON.
188 (App.Pane._fetch): Fetch the cached JSON first. Refetch the uncached version if instructed as such.
189 (App.Pane._updateChartData): Extracted from App.Pane._fetch.
190 (App.Pane._handleFetchErrors): Ditto.
193 (RunsData.fetchRuns): Takes the fourth argument indicating whether we should fetch the cached version or not.
194 The cached JSON is located in /data/ with the same filename. When fetching a cached JSON results in 404,
195 fulfill the promise with null as the result instead of rejecting it. The only client of this function which
196 sets useCache to true is App.Manifest.fetchRunsWithPlatformAndMetric, and it handles this special case.
198 * public/v2/manifest.js:
199 (App.DateArrayTransform): Added. Handles the array of last modified dates in platform objects.
200 (App.Platform.lastModifiedTimeForMetric): Added. Returns the last modified date in the manifest JSON.
201 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes "useCache" like RunsData.fetchRuns. Set shouldRefetch
202 to true if response is null (the cache didn't exit) or the cache is out-of-date.
203 (App.Manifest._formatFetchedData): Extracted from App.Manifest.fetchRunsWithPlatformAndMetric.
206 (initializeDatabase): Avoid splitting function definitions in the middle.
208 * tests/api-report.js: Added tests to verify that reporting new test results updates the last modified time
209 in test_configurations.
211 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
213 REGRESSION(r180333): Analysis tasks can't be associated with bugs
214 https://bugs.webkit.org/show_bug.cgi?id=141858
216 Reviewed by Andreas Kling.
218 Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
219 of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
221 * public/v2/chart-pane.css:
222 * public/v2/index.html:
224 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
226 Selecting revisions for A/B testing is hard
227 https://bugs.webkit.org/show_bug.cgi?id=141824
229 Reviewed by Andreas Kling.
231 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
232 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
233 select A/B testing points manually.
235 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
236 sets to 'options' for clarity.
238 * public/v2/app.css: Reorganized style rules.
241 (App.AnalysisTaskController):
242 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
243 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
244 a property, which sets 'overviewDomain' property as well as other properties.
245 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
246 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
247 in the overview chart.
249 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
250 individual build requests / test results are shown or not.
252 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
253 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
255 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
257 Unreviewed test fixes after r179037, r179591, and r179763.
259 * tests/admin-regenerate-manifest.js:
260 * tests/admin-reprocess-report.js:
262 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
264 Relationship between A/B testing results are unclear
265 https://bugs.webkit.org/show_bug.cgi?id=141810
267 Reviewed by Andreas Kling.
269 Show a "reference chart" indicating which two points have been tested in each test group pane.
271 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
272 and the domain used in this chart to show charts in each test group.
274 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
276 * public/v2/analysis.js:
277 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
278 since this is the results of A/B testing results, not the data for charts shown next to them.
280 * public/v2/app.css: Added CSS rules for reference charts.
283 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
284 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
285 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
286 identically matches root sets. If one of configuration used a set of revisions for which no measurement
287 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
288 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
289 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
290 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
293 (Measurement.prototype.revisionForRepository): Added.
294 (Measurement.prototype.commitTimeForRepository): Cleanup.
295 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
297 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
298 by including the build number in the title attribute instead of in the markup.
300 * public/v2/interactive-chart.js:
301 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
302 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
303 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
305 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
307 Analysis task pages are unusable
308 https://bugs.webkit.org/show_bug.cgi?id=141786
310 Reviewed by Andreas Kling.
312 This patch makes following improvements to analysis task pages:
313 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
314 compute the data for the details pane from PaneController.
315 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
316 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
317 This change required the creation of App.TestGroupPane as well as its methods.
318 4. Show a box plot for each root set configuration as well as each build request. This change required
319 App.BoxPlotComponent.
320 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
322 * public/api/build-requests.php:
323 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
325 * public/api/test-groups.php:
326 (main): Include root sets and roots in the response.
329 * public/include/build-requests-fetcher.php:
330 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
331 (BuildRequestsFetcher::root_sets): Added.
332 (BuildRequestsFetcher::roots): Added.
333 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
334 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
335 tools/sync-with-buildbot.py can't convert repository names to their ids.
337 * public/v2/analysis.js:
339 (App.RootSet): Added.
340 (App.RootSet.revisionForRepository): Added.
341 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
342 response at /api/test-groups will include them.
343 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
344 _createConfigurationSummary.
345 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
346 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
348 * public/v2/app.css: Updated style rules for analysis task pages.
351 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
352 (App.Pane._updateDetails): Moved from App.PaneController.
354 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
356 (App.AnalysisTaskController): Added 'details'.
357 (App.AnalysisTaskController._taskUpdated):
358 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
359 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
360 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
362 (App.TestGroupPane): Added.
363 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
364 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
365 of all repositories appearing in root sets and builds associated with A/B testing results.
366 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
367 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
368 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
369 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
370 is a union of revisions in the root set and the first build request in the group. We null-out revision info
371 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
372 by the values in the group as well as 95% percentile confidence interval.
374 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
375 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
376 the mean and the confidence interval.
377 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
378 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
379 calls _updateBars to update the rects.
381 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
384 (Measurement.prototype.formattedRevisions):
385 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
386 called in _createConfigurationSummary.
388 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
389 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
390 Also made the fetching of chartData no longer block showing of test groups.
392 * public/v2/interactive-chart.js:
393 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
394 (App.InteractiveChartComponent._domainChanged): Ditto.
395 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
397 * public/v2/js/statistics.js:
398 (Statistics.min): Added.
399 (Statistics.max): Added.
401 * public/v2/manifest.js:
402 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
404 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
406 Build URL on new perf dashboard doesn't resolve $builderName
407 https://bugs.webkit.org/show_bug.cgi?id=141583
409 Reviewed by Darin Adler.
411 Support $builderName in the build URL template.
413 * public/js/helper-classes.js:
414 (TestBuild.buildUrl): Replaced $builderName with the builder name.
416 * public/v2/manifest.js:
417 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
418 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
420 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
422 Unreviewed build fix after r179591.
424 * public/api/commits.php:
426 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
428 The status of a A/B testing request always eventually becomes "Failed"
429 https://bugs.webkit.org/show_bug.cgi?id=141523
431 Reviewed by Andreas Kling.
433 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
434 'failedIfNotCompleted' was sent by the buildbot sync'er.
436 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
438 * public/api/build-requests.php:
441 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
443 Unreviewed, remove empty directories.
445 * public/data: Removed.
447 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
449 Perf dashboard should show the results of A/B testing
450 https://bugs.webkit.org/show_bug.cgi?id=141500
452 Reviewed by Chris Dumez.
454 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
455 analysis task page to fetch results for each test group.
457 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
458 can use the formatter.
460 * public/api/runs.php:
461 (fetch_runs_for_config_and_test_group): Added.
462 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
463 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
464 use RunsGenerator to format results.
465 (RunsGenerator): Added.
466 (RunsGenerator::__construct): Added.
467 (RunsGenerator::add_runs): Added.
468 (RunsGenerator::format_run): Moved.
469 (RunsGenerator::parse_revisions_array): Moved.
471 * public/v2/analysis.js:
472 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
473 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
474 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
475 configuration associated with this build request such as "A" and "B".
476 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
477 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
478 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
482 (App.Pane._fetch): Set chartData directly here.
483 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
484 now that it's done in App.Pane._fetch.
485 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
488 (Measurement.prototype.buildId): Added.
489 (TimeSeries.prototype.findPointByBuild): Added.
491 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
492 url is not an Ember routed path.
494 * public/v2/manifest.js:
495 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
496 App.createChartData here so that App.BuildRequest can use the formatter
498 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
500 v2 UI should adjust the number of ticks on dashboards based on screen size
501 https://bugs.webkit.org/show_bug.cgi?id=141502
503 Reviewed by Chris Dumez.
505 * public/v2/interactive-chart.js:
506 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
509 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
511 New perf dashboard shows too much space around interesting data points
512 https://bugs.webkit.org/show_bug.cgi?id=141487
514 Reviewed by Chris Dumez.
516 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
517 show the current time series excluding points in the series outside the moving average envelope.
520 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
521 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
522 time series if the point lies outside the moving average envelope. Don't expose the moving average or
523 the envelope computed for this purpose if they're not set by the user.
526 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
527 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
529 * public/v2/interactive-chart.js:
530 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
531 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
532 to deal with showFullYAxis here.
533 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
534 argument instead of directly inspecting showFullYAxis.
536 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
538 New perf dashboard shouldn't always show outliners
539 https://bugs.webkit.org/show_bug.cgi?id=141445
541 Reviewed by Chris Dumez.
543 Use the simple moving average with an average difference envelope to compute the y-axis range to show
544 to avoid expanding it spuriously to show one off outlier.
547 (App.Pane): Don't show the full y-axis range by default.
548 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
549 one is not specified by the user but without showing them in the charts.
550 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
551 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
553 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
554 (App.ChartsController._serializePaneList): Ditto.
556 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
558 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
560 * public/v2/interactive-chart.js:
561 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
562 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
563 if they are not specified by the user (i.e. only used to adjust y-axis range).
564 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
565 x-axis domain remained the same. Without this change, the charts would never redraw.
566 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
567 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
568 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
570 * public/v2/js/statistics.js:
571 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
573 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
575 Unreviewed build fix.
578 (set get App.Pane.Ember.Object.extend):
580 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
582 New perf dashboard should have the ability to overlay moving average with an envelope
583 https://bugs.webkit.org/show_bug.cgi?id=141438
585 Reviewed by Andreas Kling.
587 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
589 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
590 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
591 n, backward window size, and m, forward window size, as an argument.
593 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
594 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
596 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
597 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
600 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
601 between each x_i and x̄_i.
603 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
604 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
605 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
606 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
609 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
610 The configuration of the currently chosen strategies is saved in the query string for convenience.
612 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
614 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
617 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
618 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
619 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
620 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
621 from the query string via ChartsController.
622 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
623 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
624 (App.Pane._executeStrategy): Added.
625 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
627 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
628 selections, and added two new arguments for the moving average and the enveloping configurations.
629 (App.ChartsController._serializePaneList): Ditto.
630 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
631 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
632 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
633 (App.PaneController.actions.toggleStatPane): Added.
635 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
636 current (as opposed to baseline and target) time series for when it's the most foreground graph without
637 moving average and its envelope overlapping on top of it.
639 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
641 * public/v2/interactive-chart.js:
642 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
643 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
644 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
645 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
646 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
647 but don't bother removing individual paths and circles. Added the code to show the moving average time
648 series when there is one. Also add "foreground" class on SVG elements for the current time series when
649 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
650 series when "foreground" is not set.
651 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
652 account when computing the y-axis range.
653 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
655 * public/v2/js/statistics.js:
656 (Statistics.MovingAverageStrategies): Added.
657 (Statistics.EnvelopingStrategies): Added.
659 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
661 The delta value in the chart pane sometimes doens't show '+' for a positive delta
662 https://bugs.webkit.org/show_bug.cgi?id=141340
664 Reviewed by Andreas Kling.
666 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
667 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
670 (App.Pane.computeStatus):
671 (App.createChartData):
673 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
675 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
678 (App.PaneController._updateDetails):
680 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
682 Unreviewed. Commit the forgotten change.
684 * public/include/manifest.php:
686 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
688 New perf dashboard should have multiple dashboard pages
689 https://bugs.webkit.org/show_bug.cgi?id=141339
691 Reviewed by Chris Dumez.
693 Added the support for multiple dashboard pages. Also added the status of the latest data point.
694 e.g. "5% better than target"
696 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
697 Also hid the border lines around charts on the dashboard page for a cleaner look.
700 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
701 (App.IndexRoute.beforeModel): Added.
702 (App.DashboardRoute): Added.
703 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
704 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
705 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
706 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
707 (App.DashboardController): Renamed from App.IndexController.
708 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
709 and "defaultDashboard" as these are taken care of by newly added routers.
710 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
711 now done in actions.toggleEditMode.
712 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
713 an existing dashboard.
715 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
716 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
717 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
718 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
720 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
722 (App.PaneController._updateDetails): Updated per changes to computeStatus.
724 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
727 (TimeSeries.prototype.lastPoint): Added.
729 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
730 on the dashboard, and enumerate all predefined dashboards.
732 * public/v2/interactive-chart.js:
733 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
734 for the dashboard page.
736 * public/v2/manifest.js:
737 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
738 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
739 IDs are generated for each dashboard for forward compatibility.
741 (App.Manifest.dashboardByName): Added.
742 (App.Manifest.defaultDashboardName): Added.
743 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
745 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
747 Move commits viewer to the end of details view
748 https://bugs.webkit.org/show_bug.cgi?id=141315
750 Rubber-stamped by Andreas Kling.
752 Show the difference instead of the old value per kling's request.
755 (App.PaneController._updateDetails):
756 * public/v2/index.html:
758 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
760 Move commits viewer to the end of details view
761 https://bugs.webkit.org/show_bug.cgi?id=141315
763 Reviewed by Andreas Kling.
765 Improved the way list of commits are shown per kling's request.
768 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
770 * public/v2/chart-pane.css: Updated the style for the commits viewer.
772 * public/v2/commits-viewer.js:
773 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
774 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
776 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
777 moved the commits viewers out of the details tables so that they don't interleave revision data.
779 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
781 New perf dashboard should compare results to baseline and target
782 https://bugs.webkit.org/show_bug.cgi?id=141286
784 Reviewed by Chris Dumez.
786 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
787 Also use d3.format to format the selected value to show four significant figures.
790 (App.Pane.searchCommit):
791 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
792 to compute the status text without having to recreate them.
793 (App.createChartData): Added.
794 (App.PaneController._updateDetails): Use 3d.format on current and old values.
795 (App.PaneController._computeStatus): Added. Computes the status text.
796 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
797 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
798 format the values using chartData.formatter.
800 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
801 the baseline and in blue if it's better than the target.
804 (TimeSeries.prototype.findPointAfterTime): Added.
806 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
807 the bug that we were not showing the old value's unit.
809 * public/v2/interactive-chart.js:
810 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
811 the code to show the baseline and the target lines.
813 * public/v2/manifest.js:
814 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
816 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
818 Unreviewed build fix.
821 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
823 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
825 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
826 https://bugs.webkit.org/show_bug.cgi?id=141280
828 Reviewed by Chris Dumez.
830 Fixed the bug by passing in "since" as a query parameter to the charts page.
832 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
834 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
836 (App.IndexController): Changed the default number of days from one month to one week.
837 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
838 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
840 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
842 New perf dashboard erroneously clears zoom when poping history items
843 https://bugs.webkit.org/show_bug.cgi?id=141278
845 Reviewed by Chris Dumez.
847 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
849 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
850 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
853 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
854 shown in the main plot.
855 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
856 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
858 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
860 New perf dashboard shows null as the aggregator name if no aggregation is done
861 https://bugs.webkit.org/show_bug.cgi?id=141256
863 Reviewed by Chris Dumez.
865 Don't show the aggregator name if there isn't one.
867 * public/v2/manifest.js:
870 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
872 Unreviewed build fix after r179611.
874 * public/v2/interactive-chart.js:
876 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
878 Perf dashboard doesn’t show the right unit for Safari UI tests
879 https://bugs.webkit.org/show_bug.cgi?id=141238
881 Reviewed by Darin Adler.
883 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
884 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
885 between metrics and their units.
887 * public/js/helper-classes.js:
888 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
889 * public/v2/manifest.js:
890 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
891 * public/v2/interactive-chart.js:
892 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
893 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
895 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
897 Interactive chart component provides two duplicate API for highlighting points
898 https://bugs.webkit.org/show_bug.cgi?id=141234
900 Reviewed by Chris Dumez.
902 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
903 on the main charts page and markedPoints to show the two end points in the analysis task page.
905 This patch merges markedPoints into highlightedItems.
908 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
909 * public/v2/chart-pane.css:
910 * public/v2/index.html: Ditto.
911 * public/v2/interactive-chart.js:
912 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
913 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
914 items if highlightedItems was set before the initial layout.
915 (App.InteractiveChartComponent._relayoutDataAndAxes):
916 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
917 vertical lines, just set cx and cy as done for other "dots".
918 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
919 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
920 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
921 set the radius of highlight circles here.
923 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
925 Don’t use repository names as id’s.
926 https://bugs.webkit.org/show_bug.cgi?id=141226
928 Reviewed by Chris Dumez.
930 Not using repository names as their id's reduces the need to fetch the entire repositories table.
931 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
933 * Websites/perf.webkit.org/public/api/runs.php:
934 (parse_revisions_array): No longer uses $repository_id_to_name.
935 (main): No longer populates $repository_id_to_name.
937 * Websites/perf.webkit.org/public/api/triggerables.php:
938 (main): Don't resolve repository names.
940 * Websites/perf.webkit.org/public/include/manifest.php:
941 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
942 (ManifestGenerator::bug_trackers): Don't resolve repository names.
944 * Websites/perf.webkit.org/public/js/helper-classes.js:
945 (TestBuild): Renamed repositoryName to repositoryId.
946 (TestBuild.revision): Ditto.
947 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
948 since this is the text shown to human.
950 * Websites/perf.webkit.org/public/v2/app.js:
951 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
952 (App.PaneController._updateDetails): Ditto.
953 (App.AnalysisTaskController.updateRoots): Ditto.
955 * Websites/perf.webkit.org/public/v2/data.js:
956 (Measurement): Ditto.
957 (Measurement.prototype.commitTimeForRepository): Ditto.
958 (Measurement.prototype.formattedRevisions): Ditto.
960 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
961 select element's label and value respectively.
963 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
965 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
967 * public/api/runs.php:
969 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
971 /api/runs.php should have main function
972 https://bugs.webkit.org/show_bug.cgi?id=141220
974 Reviewed by Benjamin Poulain.
976 Wrapped the code inside main function for clarity.
978 * public/api/runs.php:
980 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
982 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
984 * tools/sync-with-buildbot.py:
985 (find_request_updates):
987 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
989 Perf dashboard always assigns the result of A/B testing with build request 1
990 https://bugs.webkit.org/show_bug.cgi?id=140382
992 Reviewed by Darin Adler.
994 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
995 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
997 Also fixed a typo as well as a bug that reports were never associated with builds.
999 * public/include/report-processor.php:
1000 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
1001 instead of the first non-null value.
1002 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
1003 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
1005 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1007 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
1009 * public/admin/tests.php:
1011 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
1013 Unreviewed build fix. Removed the stale code.
1015 * public/admin/triggerables.php:
1017 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1019 Perf dashboard should have the ability to post A/B testing builds
1020 https://bugs.webkit.org/show_bug.cgi?id=140317
1022 Rubber-stamped by Simon Fraser.
1024 This patch adds the support for triggering A/B testing from the perf dashboard.
1026 We add a few new tables to the database. "build_triggerables", which represents a set of builders
1027 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
1028 of repositories for which an arbitrary revision can be specified for A/B testing.
1029 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
1030 "roots" table which specifies the revision used in a given root set in each repository.
1032 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
1033 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
1034 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
1035 to build_requests table. Also made each test group's name unique in a given analysis task as it
1036 would be confusing to have multiple test groups of the same name.
1038 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
1040 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
1041 for which a specific revision can be set in an A/B testing on a given triggerable.
1043 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
1044 triggerable. Also updates the status' and the status urls of specified build requests when
1045 buildRequestUpdates is provided in the raw POST data.
1048 * public/api/runs.php:
1049 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
1050 results of an A/B testing.
1052 * public/api/test-groups.php:
1053 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
1055 * public/api/triggerables.php: Added.
1056 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
1058 * public/include/admin-header.php:
1060 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
1061 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
1062 and root sets used in those requests.D
1063 (BuildRequestsFetcher::__construct):
1064 (BuildRequestsFetcher::fetch_for_task):
1065 (BuildRequestsFetcher::fetch_for_group):
1066 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
1067 (BuildRequestsFetcher::has_results):
1068 (BuildRequestsFetcher::results):
1069 (BuildRequestsFetcher::results_with_resolved_ids):
1070 (BuildRequestsFetcher::results_internal):
1071 (BuildRequestsFetcher::root_sets):
1072 (BuildRequestsFetcher::fetch_roots_for_set):
1074 * public/include/db.php:
1075 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
1076 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
1077 table since it only has the primary key, id, column.
1078 (Database::select_or_insert_row):
1079 (Database::update_or_insert_row):
1080 (Database::update_row): Added.
1081 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
1082 should be inserted when no row matches the specified criteria. This is used while updating
1083 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
1084 new build requests in that API.
1085 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
1086 This is used in public/api/triggerables.php when no analysis task is specified.
1088 * public/include/json-header.php:
1089 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
1090 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
1091 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
1092 find the closest ancestor with a triggerable.
1094 * public/include/report-processor.php:
1095 (ReportProcessor::process):
1096 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
1097 if jobId or buildRequest is specified.
1099 * public/include/test-name-resolver.php:
1100 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
1101 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
1102 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
1105 * public/include/test-path-resolver.php: Added.
1106 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
1107 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
1108 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
1109 in order to compute full test metric names.
1110 (TestPathResolver::__construct):
1111 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
1112 the highest (a test without a parent).
1113 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
1114 the highest ancestor to the test itself.
1115 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
1117 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
1119 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
1120 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
1121 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
1122 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
1124 * public/v2/analysis.js:
1125 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
1126 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
1127 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
1128 (App.TestGroup.create): Added. Creates a new A/B testing group.
1129 (App.Triggerable): Added.
1130 (App.TriggerableAdapter): Added.
1131 (App.TriggerableAdapter.buildURL): Added.
1132 (App.BuildRequest.testGroup): Renamed from group.
1133 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
1134 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
1135 in this build request.
1136 (App.BuildRequest.status): Added.
1137 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
1138 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
1141 (App.AnalysisTaskController.testGroups): Added.
1142 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
1143 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
1144 but an observer that updates "roots" property. Filter out the repositories that are not accepted
1145 by the associated triggerable as they will be ignored.
1146 (App.AnalysisTaskController.actions.createTestGroup): Added.
1148 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
1150 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
1151 the status of those builds to the perf dashboard. A similar script can be written to support
1152 other continuous builds systems.
1153 (main): Fetches the list of pending builds as well as currently running or completed builds from
1154 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
1155 a single new build on each builder with no pending builds, and marks the set of open build requests
1156 that have been scheduled to run on the buildbot but not found in the first step as stale.
1157 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
1160 "platform": "mac-mavericks",
1161 "test": ["Parser", "html5-full-render.html"],
1162 "builder": "Trunk Syrah Production Perf AB Tests",
1164 "forcescheduler": "force-mac-mavericks-release-perf",
1165 "webkit_revision": "$WebKit",
1166 "jobid": "$buildRequest"
1171 (find_request_updates): Return a list of build request status updates to make based on the pending
1172 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
1173 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
1174 if the build request had not been completed. This is necessary because a failed build will not
1175 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
1176 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
1177 of open requests the perf dashboard has.
1178 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
1179 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
1180 or human canceling a build may trigger such a state.
1181 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
1182 replacing repository names with their revisions and buildRequest with the build request id.
1183 (config_for_request): Finds a builder for the test and the platform of a build request.
1184 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
1185 (property_value_from_build): Returns the value of a specific property in a buildbot build.
1186 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
1188 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1190 Cache-control should be set only on api/runs
1191 https://bugs.webkit.org/show_bug.cgi?id=140312
1193 Reviewed by Andreas Kling.
1195 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
1196 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
1197 just set cache-control there instead of json-header.php which is used by other JSON APIs.
1199 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
1201 * public/api/analysis-tasks.php:
1202 * public/api/runs.php: Set the cache control headers.
1203 * public/api/test-groups.php:
1204 * public/include/db.php: Set the default timezone to UTC.
1205 * public/include/json-header.php: Don't set the cache control headers.
1207 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1209 api/report-commit should authenticate with a slave name and password
1210 https://bugs.webkit.org/show_bug.cgi?id=140308
1212 Reviewed by Benjamin Poulain.
1214 Use a slave name and a password to authenticate new commit reports.
1216 * public/api/report-commits.php:
1218 * public/include/json-header.php:
1219 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
1220 a slave name and a password instead of a builder name and a password.
1221 * tests/api-report-commits.js: Updated tests.
1222 * tools/pull-svn.py:
1223 (main): Renamed variables.
1224 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
1226 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
1228 Perf dashboard should support authentication via a slave password
1229 https://bugs.webkit.org/show_bug.cgi?id=139837
1231 Reviewed by Andreas Kling.
1233 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
1234 having to add multiple builders with the same password when a single build slave is shared among them.
1236 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
1238 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
1240 * public/admin/build-slaves.php: Added.
1242 * public/admin/builders.php: Added the support for updating passwords.
1244 * public/include/admin-header.php:
1245 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
1246 being retrieved from $_POST.
1247 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
1248 the raw may not exist (e.g. new_password).
1249 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
1250 control here when this flag evaluates to TRUE.
1252 * public/include/report-processor.php:
1253 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
1254 values are present in the report. In addition, try authenticating builderName with slavePassword if
1255 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
1256 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
1257 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
1259 (ReportProcessor::store_report): Store the slave ID with the report.
1260 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
1261 the matching build is different from what's being reported.
1263 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
1266 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
1268 New perf dashboard should not duplicate author information in each commit
1269 https://bugs.webkit.org/show_bug.cgi?id=139756
1271 Reviewed by Darin Adler.
1273 Instead of each commit having author name and email, make it reference a newly added committers table.
1274 Also replace "email" by "account" since some repositories don't use emails as account names.
1276 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
1277 which only contains as many rows as there are accounts in each repository, instead of commits table
1278 which contains every commit ever happened in each repository.
1280 To migrate an existing database into match the new schema, run:
1284 INSERT INTO committers (committer_repository, committer_name, committer_email)
1285 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
1286 FROM commits WHERE commit_author_email IS NOT NULL);
1288 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
1290 UPDATE commits SET commit_committer = committer_id FROM committers
1291 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
1293 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
1294 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
1298 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
1299 reference to committers. Also added the missing drop table statements.
1301 * public/api/commits.php:
1302 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
1303 an array here instead of doing it in format_commit.
1304 (fetch_commits_between): Updated queries to JOIN commits with committers.
1305 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
1306 is now done in main.
1308 * public/api/report-commits.php:
1309 (main): Store the reported committer information or update the existing entry if there is one.
1311 * tests/admin-regenerate-manifest.js: Fixed tests.
1313 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
1315 * tools/pull-svn.py: Renamed email to account.
1317 (fetch_commit_and_resolve_author):
1319 (resolve_author_name_from_account):
1320 (resolve_author_name_from_email): Deleted.
1322 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
1324 Unreviewed build fix.
1326 * public/v2/index.html: Include js files we extracted in r177424.
1328 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1330 Unreviewed. Adding the forgotten svnprop.
1332 * tools/pull-svn.py: Added property svn:executable.
1334 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1336 Split InteractiveChartComponent and CommitsViewerComponent into separate files
1337 https://bugs.webkit.org/show_bug.cgi?id=139716
1339 Rubber-stamped by Benjamin Poulain.
1341 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
1342 and interactive-chart.js respectively since app.js has gotten really large.
1345 * public/v2/commits-viewer.js: Added.
1346 * public/v2/interactive-chart.js: Added.
1348 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
1350 New perf dashboard's chart UI is buggy
1351 https://bugs.webkit.org/show_bug.cgi?id=139214
1353 Reviewed by Chris Dumez.
1355 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
1357 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
1358 component. This is not how Ember.js components should interact to begin with. The component now exposes
1359 selectedPoints and always updates selection instead of sharedSelection.
1362 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
1363 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
1364 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
1365 and end time should be completely determined by "since" and the present time.
1366 (App.ChartsController._startTimeChanged): Ditto.
1367 (App.ChartsController._scheduleQueryStringUpdate):
1368 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
1370 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
1372 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
1373 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
1374 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
1375 observes the changes to selectedPoints property as it gets updated by the main chart.
1376 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
1377 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
1379 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
1380 when domain arrays aren't identical. This was causing a subtle race with other logic.
1381 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
1382 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
1383 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
1384 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
1385 see if those two points correspond to a range or a single data point. Rewrote all that logic by
1386 directly observing selectedPoints and currentItem properties instead of taking points and relying on
1387 an instance variable, which was a terrible API.
1388 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
1389 when the main plot has a selected range, we don't have to check this._hasRange anymore.
1391 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
1392 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
1393 (App.InteractiveChartComponent._updateSelection):
1394 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
1395 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
1396 selectedPoints property.
1398 (App.AnalysisTaskController._fetchedRuns):
1399 (App.AnalysisTaskController._rootChangedForTestSet):
1401 * public/v2/index.html:
1402 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
1404 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1406 Unreviewed. Fixed syntax errors.
1408 * init-database.sql:
1409 * public/api/commits.php:
1411 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1413 The dashboard on new perf monitor should be configurable
1414 https://bugs.webkit.org/show_bug.cgi?id=138994
1416 Reviewed by Benjamin Poulain.
1418 For now, make it configurable via config.json. We should eventually make it configurable via
1419 an administrative page but this will do for now.
1421 * config.json: Added the empty dashboard configuration.
1423 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1426 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1427 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1428 Also obtain the default configuration from App.Manifest.
1429 (App.IndexController._normalizeTable): Moved to App.Dashboard.
1431 * public/v2/manifest.js:
1432 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
1433 (App.Repository.urlForRevisionRange): Ditto.
1434 (App.Dashboard): Added.
1435 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
1436 (App.Dashboard.rows): Ditto.
1437 (App.Dashboard.headerColumns): Ditto.
1438 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
1439 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
1440 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
1441 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
1443 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1445 There should be a way to associate bugs with analysis tasks
1446 https://bugs.webkit.org/show_bug.cgi?id=138977
1448 Reviewed by Benjamin Poulain.
1450 Updated associate-bug.php to match the new database schema.
1452 * public/include/json-header.php:
1453 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
1454 already camel-cased in require_existence_of. This makes the function usable elsewhere.
1456 * public/privileged-api/associate-bug.php:
1457 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
1458 Also verify that those values are integers using require_format.
1460 * public/v2/analysis.js:
1461 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
1462 (App.Bug.label): Added.
1463 (App.BugAdapter): Added.
1464 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
1465 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
1467 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
1468 containing the bug information.
1471 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
1472 (App.AnalysisTaskRoute):
1473 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
1474 (App.AnalysisTaskController._fetchedManifest): Added.
1475 (App.AnalysisTaskController.actions.associateBug): Added.
1477 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
1479 * public/v2/data.js:
1480 (Measurement.prototype.associateBug): Deleted.
1482 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
1483 Added a table show the bug information. Also hide the chart until chartData is available.
1485 * public/v2/manifest.js:
1488 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1490 Fix misc bugs and typos in app.js
1491 https://bugs.webkit.org/show_bug.cgi?id=138946
1493 Reviewed by Benjamin Poulain.
1496 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1497 (App.ChartsController.init):
1498 (App.buildPopup): Renamed from App.BuildPopup.
1499 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1500 remove() on the wrong object (an array as opposed to elements in the array).
1501 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1502 _highlights is always an array and evalutes to true.
1504 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1506 New perf dashboard should provide UI to create a new analysis task
1507 https://bugs.webkit.org/show_bug.cgi?id=138910
1509 Reviewed by Benjamin Poulain.
1511 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1512 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1514 With this patch, we can create a new analysis task by selection a range of points and opening
1515 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1516 in the chart hyperlinked to the analysis task.
1518 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1520 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1521 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1523 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1524 and adds the associated bugs to each task in the array.
1527 * public/api/runs.php: Reverted changes made in r175006.
1528 (fetch_runs_for_config):
1531 * public/api/test-groups.php:
1532 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1534 * public/include/db.php:
1535 (Database::select_first_or_last_row):
1536 (Database::select_rows): Extracted from select_first_or_last_row.
1538 * public/v2/analysis.js:
1539 (App.AnalysisTask): Added "bugs" property.
1540 (App.Bug): Added now that bugs are regular data store objects.
1543 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1544 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1545 platform that are associated with a specific range of runs.
1546 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1547 (App.PaneController.actions.associateBug): Deleted.
1548 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1549 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1550 once we've created one.
1551 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1552 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1553 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1554 (App.PaneController._updateBugs): Deleted.
1555 (App.PaneController._updateMarkedPoints): Deleted.
1556 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1557 the name is missing or when at most one point is selected.
1559 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1560 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1561 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1562 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1563 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1564 clickable bars for analysis tasks.
1565 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1566 bar for analysis tasks to place them at the right location.
1567 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1569 * public/v2/chart-pane.css:
1570 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1571 (.chart .rangeBar): Added.
1573 * public/v2/data.js:
1574 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1576 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1577 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1578 task bars in the interactive chart component.
1580 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1582 Fix typos in r176203.
1585 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1586 (App.AnalysisTaskRoute):
1588 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1590 Unreviewed. Updated the install instruction.
1594 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1596 App.Manifest shouldn't use App.__container__.lookup
1597 https://bugs.webkit.org/show_bug.cgi?id=138768
1599 Reviewed by Andreas Kling.
1601 Removed the hack to find the store object via App.__container__.lookup.
1602 Pass around the store object instead.
1605 (App.DashboardRow._createPane): Add "store" property to the pane.
1606 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1607 (App.IndexController.gridChanged): Ditto.
1608 (App.IndexController.actions.addRow): Ditto.
1609 (App.IndexController.init): Ditto.
1610 (App.Pane._fetch): Ditto.
1611 (App.ChartsController._parsePaneList): Ditto.
1612 (App.ChartsController._updateQueryString): Ditto.
1613 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1614 (App.BuildPopup): Ditto.
1615 (App.AnalysisTaskRoute.model): Ditto.
1616 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1618 * public/v2/manifest.js:
1619 (App.Manifest.fetch): Removed the code to find the store object.
1621 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1623 Fix Ember.js warnings the new perf dashboard
1624 https://bugs.webkit.org/show_bug.cgi?id=138531
1626 Reviewed by Darin Adler.
1628 Fixed various warnings.
1631 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1632 * public/v2/data.js:
1633 (PrivilegedAPI._post): Removed the superfluous console.log.
1634 (CommitLogs.fetchForTimeRange): Ditto.
1635 * public/v2/index.html: Added tbody as required by the HTML specification.
1637 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1639 Fix typos in r175768.
1642 (App.AnalysisTaskViewModel.roots):
1644 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1646 Introduce the concept of analysis task to perf dashboard
1647 https://bugs.webkit.org/show_bug.cgi?id=138517
1649 Reviewed by Andreas Kling.
1651 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1652 a single platform and used to bisect regressions in the range.
1654 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1656 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1657 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1658 test runs. Analysis tasks not associated with test runs are used for try new patches.
1659 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1660 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1661 build_requests - A build request represents a single pending build for A/B testing.
1663 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1667 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1668 the specified analysis task group as well as build requests associated with them.
1670 (fetch_test_groups_for_task):
1671 (fetch_build_requests_for_task):
1672 (fetch_build_requests_for_group):
1673 (format_test_group):
1674 (format_build_request):
1676 * public/include/json-header.php:
1677 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1680 * public/privileged-api/associate-bug.php:
1681 (main): Fixed a typo.
1683 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1686 (ensure_config_from_runs):
1688 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1690 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1692 (App.AnalysisTask.create):
1694 (App.TestGroupAdapter):
1695 (App.AnalysisTaskSerializer):
1696 (App.TestGroupSerializer):
1699 * public/v2/app.css: Added style rules for the analysis page.
1702 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1704 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1705 exactly one selected point as we can still create an analysis task.
1706 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1707 grammatical and also alert'ed the error message when there is one.
1708 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1709 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1710 once XHR request has completed.
1711 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1712 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1713 is selected in the details pane.
1715 (App.AnalysisRoute): Added.
1716 (App.AnalysisTaskRoute): Added.
1717 (App.AnalysisTaskViewModel): Added.
1718 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1719 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1720 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1721 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1722 the user selects an option for all roots in A or B configuration.
1723 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1725 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1727 * public/v2/data.js:
1728 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1729 point so that we can use it in App.AnalysisTaskViewModel.roots.
1730 (TimeSeries.prototype.findPointByMeasurementId): Added.
1731 (TimeSeries.prototype.seriesBetweenPoints): Added.
1733 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1734 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1735 when multiple points are selected. Finally, added a new template for the analysis task page.
1737 * public/v2/manifest.js:
1738 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1739 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1740 App.AnalysisTaskViewModel._taskUpdated.
1742 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1744 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1745 https://bugs.webkit.org/show_bug.cgi?id=138111
1747 Reviewed by Darin Adler.
1750 (App.PaneController.bugsChangeCount): Removed.
1751 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1752 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1753 Finds the list of current run's points that are associated with bugs.
1754 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1755 * public/v2/chart-pane.css:
1756 (.chart .marked): Renamed from .hasBugs.
1757 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1759 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1761 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1762 https://bugs.webkit.org/show_bug.cgi?id=138099
1764 Reviewed by Benjamin Poulain.
1766 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1767 _showDetails inverting the order of the current and old measurements.
1770 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1771 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1772 current (latest) measurement and the first point is the oldest measurement.
1773 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1775 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1777 Perf dashboard should provide a way to associate bugs with a test run
1778 https://bugs.webkit.org/show_bug.cgi?id=137857
1780 Reviewed by Andreas Kling.
1782 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1783 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1784 the Apache configuration.
1787 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1788 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1789 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1790 via the cookie and returns a token computed from those two values as well as the remote username.
1792 The font end code then POST's the request along with the returned token. The server side code verifies
1793 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1794 the token hasn't expired.
1797 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1798 have zero or exactly one bug associated with a test run.
1800 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1801 * public/api/runs.php:
1802 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1803 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1804 an associated bug if there is one.
1805 (format_run): Calls parse_bugs_array.
1807 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1808 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1809 have a valid JSON payload.
1810 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1811 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1812 the expiration time stored in the cookie.
1813 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1815 * public/include/manifest.php:
1816 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1817 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1819 * public/index.html:
1820 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1822 * public/privileged-api/associate-bug.php: Added.
1823 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1824 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1826 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1828 * public/v2/app.css:
1829 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1830 selected in a chart.
1833 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1834 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1835 they would overlap on each other if both of them are shown.
1836 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1837 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1838 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1839 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1840 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1841 showing the search pane.
1842 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1843 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1844 bugs in the selected range.
1846 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1847 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1848 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1849 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1850 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1851 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1852 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1853 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1855 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1856 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1857 to selectionChanged action instead of just finding the first and the last points.
1859 * public/v2/chart-pane.css: Updated the style.
1861 * public/v2/data.js:
1862 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1863 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1864 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1865 we haven't already obtained a CSRF token or if the token has already been expired.
1866 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1868 (Measurement.prototype.bugs): Added.
1869 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1870 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1872 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1875 * public/v2/manifest.js:
1876 (App.BugTracker.bugUrl):
1877 (App.BugTracker.newBugUrl): Added.
1878 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1879 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1880 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1881 (App.Manifest.bugTrackers): Added.
1882 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1883 their respective ids to make the ordering stable.
1885 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1887 Remove unused jobs table
1888 https://bugs.webkit.org/show_bug.cgi?id=137724
1890 Reviewed by Daniel Bates.
1892 Removed jobs table in the database as well as related code.
1894 * init-database.sql:
1895 * public/admin/jobs.php: Removed.
1896 * public/admin/tests.php:
1897 * public/include/admin-header.php:
1899 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1901 New perf dashboard should have an ability to search commits by a keyword
1902 https://bugs.webkit.org/show_bug.cgi?id=137675
1904 Reviewed by Geoffrey Garen.
1906 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1907 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1908 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1910 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1911 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1913 * public/api/commits.php:
1914 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1915 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1916 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1917 (format_commit): Renamed from format_commits. Now only formats one commit.
1919 * public/include/db.php:
1920 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1922 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1925 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1926 which is a hash table that contains highlighted items' measurements' ids as keys.
1927 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1928 the default commit repository.
1929 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1930 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1931 Added the code to initialize this._highlights.
1932 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1933 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1934 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1935 the existing lines for the old highlighted items.
1936 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1937 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1939 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1941 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1942 (CommitLogs): Added.
1943 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1944 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1945 (CommitLogs._cacheConsecutiveCommits): Ditto.
1946 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1947 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1948 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1950 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1951 for showingDetails since this property is no longer used.
1953 * public/v2/manifest.js:
1954 (App.Manifest.repositories): Added.
1955 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1956 the default repository to search.
1957 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1959 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1961 Unreviewed build fix after r174555.
1963 * public/include/manifest.php:
1964 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1965 * tests/admin-regenerate-manifest.js: Fixed the test case.
1967 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1969 New perf dashboard UI tries to fetch commits all the time
1970 https://bugs.webkit.org/show_bug.cgi?id=137592
1972 Reviewed by Andreas Kling.
1974 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1975 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1976 no reported commits as they are all going to fail.
1978 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1979 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1980 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1981 of commits sorted chronologically by time.
1983 * public/include/manifest.php:
1986 (App.CommitsViewerComponent.commitsChanged):
1988 * public/v2/data.js:
1989 (FetchCommitsForTimeRange):
1990 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1992 * public/v2/manifest.js:
1995 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1997 Another unreviewed build fix after r174477.
1999 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
2001 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
2003 * public/include/report-processor.php:
2005 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2007 Unreviewed build fix after r174477.
2009 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
2010 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
2012 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
2013 This is necessary for baseline and target values manually added via admin pages.
2015 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2017 Add v2 UI for the perf dashboard
2018 https://bugs.webkit.org/show_bug.cgi?id=137537
2020 Rubber-stamped by Andreas Kling.
2023 * public/v2/app.css: Added.
2024 * public/v2/app.js: Added.
2025 * public/v2/chart-pane.css: Added.
2026 * public/v2/data.js: Added.
2027 * public/v2/index.html: Added.
2028 * public/v2/js: Added.
2029 * public/v2/js/d3: Added.
2030 * public/v2/js/d3/LICENSE: Added.
2031 * public/v2/js/d3/d3.js: Added.
2032 * public/v2/js/d3/d3.min.js: Added.
2033 * public/v2/js/ember-data.js: Added.
2034 * public/v2/js/ember.js: Added.
2035 * public/v2/js/handlebars.js: Added.
2036 * public/v2/js/jquery.min.js: Added.
2037 * public/v2/js/statistics.js: Added.
2038 * public/v2/manifest.js: Added.
2039 * public/v2/popup.js: Added.
2041 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2043 Remove superfluously duplicated code in public/api/report-commits.php.
2045 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2047 Perf dashboard should store commit logs
2048 https://bugs.webkit.org/show_bug.cgi?id=137510
2050 Reviewed by Darin Adler.
2052 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
2054 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
2055 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
2056 a subversion directory. The git version of this script will be added in a follow up patch.
2059 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
2060 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
2061 relationship via "build_commits" relations.
2063 In order to migrate an existing instance of this application, run the following SQL commands:
2067 INSERT INTO commits (commit_repository, commit_revision, commit_time)
2068 (SELECT DISTINCT ON (revision_repository, revision_value)
2069 revision_repository, revision_value, revision_time FROM build_revisions);
2071 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
2072 FROM commits, build_revisions
2073 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
2075 DROP TABLE build_revisions;
2080 The helper script to submit commit logs can be used as follows:
2082 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
2083 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
2085 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
2086 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
2087 "feeder-slave-password" as the builder name and the builder password respectively.
2089 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
2090 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
2093 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
2095 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
2096 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
2098 - Not specified - It returns every single commit for a given repository.
2099 - Matches "oldest" - It returns the commit with the oldest timestamp.
2100 - Matches "latest" - It returns the commit with the latest timestamp.
2101 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
2102 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
2103 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
2104 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
2105 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
2106 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
2108 (commit_from_revision):
2109 (fetch_commits_between):
2112 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
2113 See tests/api-report-commits.js for examples on how to use this API.
2115 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
2116 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
2117 to optimize this and other JSON APIs.
2119 * public/include/db.php:
2120 (Database::select_or_insert_row):
2121 (Database::update_or_insert_row): Added.
2122 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
2123 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
2125 (Database::select_first_row):
2126 (Database::select_last_row): Added.
2127 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
2128 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
2130 * public/include/report-processor.php:
2131 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
2132 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
2133 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
2136 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
2138 * tests/api-report-commits.js: Added.
2139 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
2142 * tools/pull-svn.py: Added. See above for how to use this script.
2144 (determine_first_revision_to_fetch):
2145 (fetch_revision_from_dasbhoard):
2146 (fetch_commit_and_resolve_author):
2149 (resolve_author_name_from_email):
2152 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
2154 Update Install.md for Mavericks and fix typos
2155 https://bugs.webkit.org/show_bug.cgi?id=137276
2157 Reviewed by Benjamin Poulain.
2159 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
2161 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
2163 Finally, init-database.sql is no longer located inside database directory.
2167 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2169 Report run id's in api/runs.php for the new dashboard UI
2170 https://bugs.webkit.org/show_bug.cgi?id=135813
2172 Reviewed by Andreas Kling.
2174 Include run_id in the generated JSON.
2176 * public/api/runs.php:
2177 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
2180 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2182 Merging platforms mixes baselines and targets into reported data
2183 https://bugs.webkit.org/show_bug.cgi?id=135260
2185 Reviewed by Andreas Kling.
2187 When merging two platforms, move test configurations of a different type (baseline, target)
2188 as well as of different metric (Time, Runs).
2190 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
2191 It's sufficient to detect one such test_runs object.
2193 * public/admin/platforms.php:
2196 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
2198 Merging platforms mixes baselines and targets into reported data
2199 https://bugs.webkit.org/show_bug.cgi?id=135260
2201 Reviewed by Geoffrey Garen.
2203 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
2204 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
2206 * public/admin/platforms.php:
2208 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
2210 Build fix after r171361.
2212 * public/js/helper-classes.js:
2213 (.this.formattedBuildTime):
2215 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
2217 Perf dashboard spends 2s processing JSON data during the page loads
2218 https://bugs.webkit.org/show_bug.cgi?id=135152
2220 Reviewed by Andreas Kling.
2222 In the Apple internal dashboard, we were spending as much as 2 seconds
2223 converting raw JSON data into proper JS objects while loading the dashboard.
2225 This caused the apparent unresponsiveness of the dashboard despite of the fact
2226 charts themselves updated almost instantaneously.
2228 * public/index.html:
2229 * public/js/helper-classes.js:
2230 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
2231 lazily as creating new Date objects and running string replace is expensive.
2232 (TestBuild.formattedTime):
2233 (TestBuild.formattedBuildTime):
2234 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
2235 (PerfTestRuns.addResult): Deleted.
2237 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
2239 Perf dashboard shouldn't show the full git hash
2240 https://bugs.webkit.org/show_bug.cgi?id=135083
2242 Reviewed by Benjamin Poulain.
2244 Detect Git/Mercurial hash by checking the length.
2246 If it's a hash, use the first 8 characters in the label
2247 while retaining the full length to be used in hyperlinks.
2249 * public/js/helper-classes.js:
2250 (.this.formattedRevisions):
2253 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
2255 Add an instruction on how to backup the database.
2256 https://bugs.webkit.org/show_bug.cgi?id=133391
2258 Rubber-stamped by Andreas Kling.
2262 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2264 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
2266 * public/js/helper-classes.js:
2267 (PerfTestRuns.smallerIsBetter):
2269 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2273 * public/common.css:
2275 * public/index.html:
2279 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2281 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
2282 https://bugs.webkit.org/show_bug.cgi?id=131157
2284 Reviewed by Andreas Kling.
2286 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
2287 This allows, for example, adding all metrics such as Arithmetic and Geometric for
2288 a given test suite without also adding its subtests.
2290 * public/index.html:
2294 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2296 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
2297 https://bugs.webkit.org/show_bug.cgi?id=131155
2299 Reviewed by Andreas Kling.
2301 The bug was caused by Chart.attach binding event listeners on plot container on each call.
2302 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
2303 click when attach() has been called even number of times, keeping the tooltip invisible.
2305 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
2306 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
2307 is called for the first time.
2309 * public/index.html:
2311 (Chart..bindPlotEventHandlers):
2313 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2315 WebKitPerfMonitor: Tooltips can be cut off at the top
2316 https://bugs.webkit.org/show_bug.cgi?id=130960
2318 Reviewed by Andreas Kling.
2320 * public/common.css:
2321 (#title): Removed the gradients, box shadows, and border from the header.
2322 (#title h1): Reduce the font size.
2323 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
2324 * public/index.html:
2325 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
2326 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
2327 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
2328 * public/js/helper-classes.js:
2329 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
2330 tooltip extending above y=0.
2332 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2334 WebKitPerfMonitor: Y-axis adjustment is too aggressive
2335 https://bugs.webkit.org/show_bug.cgi?id=130937
2337 Reviewed by Andreas Kling.
2339 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
2340 results. This had two major problems:
2341 1. Two standard deviations can be too small to show the confidence interval for results.
2342 2. Sometimes baseline and target can be more than two standards deviations away.
2344 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
2345 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
2346 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
2347 the margin on each side separately to reduce the empty space on either side.
2349 A more rigorous approach would involve computing least squared value of results with respect to intervals
2350 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
2352 * public/index.html:
2353 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
2354 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
2355 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
2356 We wouldn't see the difference between measured values versus baseline and target values otherwise.
2357 * public/js/helper-classes.js:
2358 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
2359 interval delta cannot be computed.
2360 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
2361 within the given interval.
2362 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
2363 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
2364 (PerfTestRuns..unscaledMeansForAllResults):
2365 (PerfTestRuns.min): Take the confidence interval delta into account.
2366 (PerfTestRuns.max): Ditto.
2367 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
2368 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
2370 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
2372 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
2374 Some CSS tweaks after r166477 and r166479,
2376 * public/index.html:
2378 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2380 WebKitPerfMonitor: Sometimes text inside panes overlap
2381 https://bugs.webkit.org/show_bug.cgi?id=130956
2383 Reviewed by Gyuyoung Kim.
2385 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
2386 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
2387 reduces the total height of the pane and fits more information per screen capita on the dashboard.
2389 * public/index.html: Updated and added a bunch of CSS rules for the new look.
2390 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
2391 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
2392 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
2393 of the build info shown in a chart pane and a tooltip.
2394 (Chart): Made .status a table.
2395 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
2396 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
2397 now that status.text no longer contains it.
2398 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
2400 * public/js/helper-classes.js:
2401 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
2402 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
2403 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
2404 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
2405 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
2406 capital letter; e.g. "MB" instead of "M B".
2408 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2410 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
2411 https://bugs.webkit.org/show_bug.cgi?id=130957
2413 Reviewed by Gyuyoung Kim.
2415 Moved the slider into the header. Also reduced the spacing between the header and platform names.
2416 This reclaims 50px × width of the screen real estate.
2418 * public/common.css:
2419 (#title): Reduced the space below the header from 20px to 10px.
2420 * public/index.html:
2421 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
2422 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
2423 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
2424 real estate between the header and the platform names.
2426 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2428 Update the install guidelines for perf.webkit.org
2429 https://bugs.webkit.org/show_bug.cgi?id=129895
2431 Reviewed by Ryosuke Niwa.
2433 The current install guideline for perf.webkit.org discourages the use of the installed
2434 Server application. I've actualized the documentation for Mavericks, and modified the
2435 guideline to include the instructions for Server.app also.
2439 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
2441 Update perf.webkit.org json example
2442 https://bugs.webkit.org/show_bug.cgi?id=129907
2444 Reviewed by Andreas Kling.
2446 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
2450 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
2452 Merge database-common.js and utility.js into run-tests.js.
2454 Reviewed by Matthew Hanson.
2456 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
2457 Also moved init-database.sql out of the database directory and removed the directory entirely.
2459 * database: Removed.
2460 * database/database-common.js: Removed.
2461 * database/utility.js: Removed.
2462 * init-database.sql: Moved from database/init-database.sql.
2464 (connect): Moved from database-common.js.
2465 (pathToDatabseSQL): Extracted from pathToLocalScript.
2466 (pathToTests): Moved from database-common.js.
2469 (SerializedTaskQueue): Ditto.
2471 (initializeDatabase):
2472 (TestEnvironment.it):
2473 (TestEnvironment.queryAndFetchAll):
2476 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2478 Remove the dependency on node.js from the production code.
2480 Reviewed by Ricky Mondello.
2482 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
2484 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
2485 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
2486 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
2487 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
2488 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
2490 Also removed the js files that are no longer used.
2492 * config.json: Moved from database/config.json.
2493 * database/aggregate.js: Removed. No longer used.
2494 * database/database-common.js: Removed unused functions, and updated the path to config.json.
2495 * database/process-jobs.js: Removed. No longer used.
2496 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2497 * database/schema.graffle: Removed. It's completely obsolete.
2498 * public/include/db.php: Updated the path to config.json.
2499 * public/include/evaluator.js: Removed.
2501 * public/include/report-processor.php:
2502 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2503 storing values into $expressions and calling evaluate_expressions_by_node.
2504 (TestRunsGenerator::aggregate_values): Added.
2505 (TestRunsGenerator::compute_caches): Directly compute the caches.
2507 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2509 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2511 * public/admin/platforms.php:
2512 * public/include/db.php:
2514 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2516 Zoomed y-axis view is ununsable when the last result is an outlier.
2518 Reviewed by Stephanie Lewis.
2520 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2521 the last result so that the graph looks sane if the last result was an outlier. However, always show
2522 the last result's mean even if it was an outlier.
2524 * public/index.html:
2525 * public/js/helper-classes.js:
2526 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2527 Also added the ability to cache the unscaled means to avoid recomputation.
2528 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2529 (PerfTestRuns.max): Ditto.
2530 (PerfTestRuns.sampleStandardDeviation): Ditto.
2531 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2533 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2537 * public/admin/tests.php:
2538 * public/js/helper-classes.js:
2540 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2542 Use two standard deviations instead as I mentioned in the mailing list.
2544 * public/index.html:
2546 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2548 The performance dashboard erroneously shows upward arrow for combined metrics.
2550 A single outlier can ruin the zoomed y-axis view.
2552 Rubber-stamped by Antti Koivisto.
2554 * public/index.html:
2555 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2556 from the latest results' mean.
2557 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2558 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2559 (Chart.toggleYAxis):
2560 * public/js/helper-classes.js:
2561 (PerfTestRuns.sampleStandardDeviation): Added.
2562 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2564 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2566 Don't include the confidence interval when computing the y-axis.
2568 Rubber-stamped by Simon Fraser.
2570 * public/js/helper-classes.js:
2574 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2576 Tiny CSS tweak for tooltips.
2578 * public/index.html:
2580 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2582 Remove the erroneously repeated code.
2584 * public/admin/test-configurations.php:
2586 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2588 <rdar://problem/15704893> perf dashboard should show baseline numbers
2590 Reviewed by Stephanie Lewis.
2592 * public/admin/bug-trackers.php:
2593 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2596 * public/admin/platforms.php:
2597 (merge_list): Ditto.
2599 * public/admin/test-configurations.php: Added.
2600 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2601 build_revisions as they're not meaningful for baseline / target numbers.
2602 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2603 one test run so that we don't accidentally delete a reported test run.
2604 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2605 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2606 and delete existing ones.
2608 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2609 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2610 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2612 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2613 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2614 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2615 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2616 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2618 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2620 * public/include/admin-header.php:
2621 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2622 have id and type sub columns, and each custom column could generate multiple rows.
2624 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2625 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2626 We then proceed to generate the second header row with sub column names.
2628 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2629 which case regular columns need rowspan set to the maximum number of rows.
2631 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2634 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2635 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2636 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2637 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2638 expanded to occupy all sub columns.
2640 * public/include/manifest.php:
2641 (ManifestGenerator::platforms): Don't add the metric more than once.
2643 * public/include/test-name-resolver.php:
2644 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2645 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2646 full metric name later.
2647 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2648 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2649 (TestNameResolver::full_name_for_test): Added.
2650 (TestNameResolver::full_name_for_metric): Added.
2651 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2653 * public/js/helper-classes.js:
2654 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2655 test runs created to set baseline and target points.
2657 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2659 Build fix after r57928. Removed a superfluous close parenthesis.
2661 * public/api/runs.php:
2663 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2665 Unreviewed build & typo fixes.
2667 * public/admin/platforms.php:
2668 * tests/admin-platforms.js:
2670 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2672 <rdar://problem/15704893> perf dashboard should show baseline numbers
2674 Rubber-stamped by Antti Koivisto.
2676 Organize some code into functions in runs.php.
2678 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2680 * public/api/runs.php:
2681 (fetch_runs_for_config): Extracted.
2682 (format_run): Ditto.
2684 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2686 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2688 * database/config.json:
2689 * public/admin/reprocess-report.php:
2690 * public/api/report.php:
2691 * public/api/runs.php:
2692 * public/include/json-header.php:
2694 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2696 Commit yet another forgotten change.
2698 Something went horribly wrong with my merge :(
2700 * database/init-database.sql:
2702 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2704 Commit one more forgotten change. Sorry for making a mess here.
2706 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2708 Commit the forgotten files.
2710 * public/admin/platforms.php: Added.
2711 * tests/admin-platforms.js: Added.
2713 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2715 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2717 Reviewed by Stephanie Lewis.
2719 Added /admin/platforms/ page to hide and merge platforms.
2721 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2722 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2723 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2724 each test configuration a distinct "test run" for each build.
2726 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2727 their test configurations into platform B.
2729 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2730 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2731 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2732 in platform B, in which case R should relate to T_B instead.
2734 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2735 new platform. We then migrate the test configurations of the remaining test runs.
2737 * database/init-database.sql: Added platform_hidden.
2739 * public/admin/platforms.php: Added.
2740 (merge_platforms): Added. Implements the algorithm described above.
2741 (merge_list): Added.
2743 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2744 is hidden since it doesn't do anything.
2746 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2747 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2748 missing it since unchecked checkbox doesn't set the value in $_POST.
2749 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2750 switch statement instead of repeated if's.
2751 (AdministrativePage::render_table): Emit "update-column" for update_field.
2753 * public/include/db.php: Disable warnings when we're not in the debug mode.
2755 * public/include/manifest.php:
2756 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2759 (TestEnvironment.postJSON):
2760 (TestEnvironment.httpGet):
2761 (TestEnvironment.httpPost): Added.
2762 (sendHttpRequest): Set the content type if specified.
2764 * tests/admin-platforms.js: Added tests.
2766 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2768 Extract the code to compute full test names from tests.php.
2770 Reviewed by Stephanie Lewis.
2772 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2773 and paves our way to re-use the code in other pages.
2775 * public/admin/tests.php:
2777 * public/include/db.php:
2778 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2779 tests.php and test-name-resolver.php.
2781 * public/include/test-name-resolver.php: Added.
2782 (TestNameResolver::__construct):
2783 (TestNameResolver::compute_full_name): Moved from tests.php.
2784 (TestNameResolver::map_metrics_to_tests): Ditto.
2785 (TestNameResolver::sort_tests_by_full_name): Ditto.
2786 (TestNameResolver::tests): Added.
2787 (TestNameResolver::test_id_for_full_name): Ditto.
2788 (TestNameResolver::metrics_for_test_id): Ditto.
2789 (TestNameResolver::child_metrics_for_test_id): Ditto.
2790 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2792 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2794 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2796 Reviewed by Stephanie Lewis.
2798 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2800 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2801 but that's sufficient to correct the wrongfully processed reports for now.
2803 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2804 We should eventually add a nice UI to find and reprocess reports.
2806 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2808 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2810 * public/include/report-processor.php: Copied from public/api/report.php.
2811 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2812 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2813 create a new report or authenticate the builder password (the password is never stored in the report).
2814 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2815 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2816 (ReportProcessor::store_report): Ditto.
2818 * tests/admin-reprocess-report.js: Added.
2820 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2822 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2824 Reviewed by Ricky Mondello.
2826 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2827 for the same build number as a single build by ignoring build time. This was necessary to associate
2828 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2829 we use to submit results computed its own "build time" when they're called.
2831 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2832 last week; new reports were wrongfully associated with old build numbers.
2834 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2835 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2836 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2838 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2839 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2840 (builder, build number, build time).
2842 * public/api/report.php:
2843 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2844 when no such build exists. This prevents a report from being associated with a very old build of the same
2847 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2848 a similar bug in the future sooner.
2850 * tests/api-report.js: Added three test cases.
2852 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2854 Merged the upstream changes to db.php
2855 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2857 * public/include/db.php:
2859 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2861 Update other scripts and tests per previous patch.
2863 * public/include/manifest.php:
2864 * tests/admin-regenerate-manifest.js:
2866 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2868 Remove metrics_unit.
2870 Reviewed by Ricky Mondello.
2872 This column is no longer used by the front-end code since r48360.
2874 * database/init-database.sql:
2875 * public/admin/tests.php:
2877 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2879 Unreviewed build fix.
2881 * public/api/report.php:
2883 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2885 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2887 Reviewed by Ricky Mondello.
2889 Support a new alternative format for aggregated results where we have raw values as well as
2890 the list aggregators so that instead of
2891 "metrics": {"Time": ["Arithmetic"]}
2893 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2895 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2896 dashboard and the generated results page, which doesn't know how to aggregate values.
2898 We need to keep the support for the old format because all other existing performance tests
2899 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2900 the old format during the transition.
2902 * public/api/report.php:
2903 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2904 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2906 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2908 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2910 Unreviewed; Tweak the CSS so that chart panes align vertically.
2912 * public/index.html:
2914 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2916 SafariPerfMonitor should support Combined metric.
2918 * public/js/helper-classes.js:
2919 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2920 value as well but assume it to be greater-is-better for now.
2922 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2924 Commit the forgotten init-database change to add iteration_relative_time.
2926 * database/init-database.sql:
2928 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2930 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2932 Reviewed by Ricky Mondello.
2934 Add the support for each value to have a relative time. This is necessary for frame rate history
2935 since a frame rate needs to be associated with a time it was sampled.
2937 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2939 * public/api/report.php:
2940 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2941 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2942 with relative time since taking the average of two frame rates for two subtests taken at two
2943 different times doesn't make any sense.
2944 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2945 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2946 Also exit early with an error if the number of elements in the array is not a pair.
2947 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2949 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2950 iteration_relative_time.
2952 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2954 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2956 Reviewed by Ricky Mondello.
2958 Support that. It's one line change.
2960 * public/api/report.php:
2961 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2962 to match the convention assumed elsewhere.
2963 * tests/api-report.js: Added a test case.
2965 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2967 SafariPerfMonitor shows popups for points outside of the visible region.
2969 Rubber-stamped by Simon Fraser.
2971 * public/index.html:
2972 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2973 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2974 may return an item underneath y-axis labels.
2976 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2978 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2980 * public/index.html:
2982 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2984 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2986 * public/index.html:
2988 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2990 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2991 <rdar://problem/13992271> Should scale Y axis to include error ranges
2993 Reviewed by Ricky Mondello.
2995 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2996 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2998 * database/config.json:
2999 * public/index.html:
3000 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
3001 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
3002 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
3004 * public/js/helper-classes.js:
3005 (PerfTestResult.confidenceIntervalDelta):
3006 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
3007 (PerfTestRuns.min): Take confidence interval delta into account.
3008 (PerfTestRuns.max): Ditto.
3009 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
3011 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
3013 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
3015 * public/api/report.php:
3016 (ReportProcessor::recursively_ensure_tests):
3017 * tests/api-report.js: Added a test.
3019 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
3021 Unreviewed build fixes.
3023 * public/api/report.php:
3024 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
3025 Also, tolerate reports without any revision information.
3027 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
3030 * tests/api-report.js: Added few test cases.
3032 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
3034 Commit another change that was supposed to be committed in r50331.
3037 (TestEnvironment.this.postJSON):
3038 (TestEnvironment.this.httpGet):
3041 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
3043 Commit the remaining files.
3045 * public/admin/regenerate-manifest.php:
3046 * public/include/admin-header.php:
3047 * public/include/json-header.php:
3048 * public/include/manifest.php:
3050 (TestEnvironment.this.postJSON):
3051 (TestEnvironment.this.httpGet):
3054 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
3056 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
3058 Reviewed by Ricky Mondello.
3060 Added some tests for admin/regenerate-manifest.
3062 * public/admin/regenerate-manifest.php: Use require_once instead of require.
3063 * public/include/admin-header.php: Ditto.
3064 * public/include/json-header.php: Ditto.
3066 * public/include/manifest.php:
3067 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
3068 When there are no builders, simply return an empty array.
3071 (TestEnvironment.postJSON):
3072 (TestEnvironment.httpGet): Added.
3073 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
3075 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
3077 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
3079 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
3080 and run_iterations. Also fixed a typo in report.php found by new tests.
3082 * public/api/report.php:
3083 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
3084 * tests/api-report.js: Added more test cases.
3086 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
3088 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
3090 Reviewed by Ricky Mondello.
3092 Add a test runner script and some simple test cases.
3094 * database/config.json: Added the configuration for "testServer".
3095 * database/database-common.js:
3096 (pathToTests): Added.
3097 * run-tests.js: Added.
3100 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
3101 and if there are, asks the user if it’s okay to delete all of the data contained therein.
3102 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
3104 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
3105 in the current database using PostgreSQL's information_schema.
3106 (askYesOrNoQuestion):
3108 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
3110 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
3111 (TestEnvironment.assert): Exposes assert to tests.
3112 (TestEnvironment.console): Exposes console to tests.
3113 (TestEnvironment.describe): Adds a description.
3114 (TestEnvironment.it): Adds a test case.
3115 (TestEnvironment.postJSON):
3116 (TestEnvironment.queryAndFetchAll):
3117 (TestEnvironment.sha256):
3118 (TestEnvironment.notifyDone): Ends the current test case.
3122 (TestContext): An object created for each test case. Conceptually, this object is always on
3123 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
3124 this object via currentTestContext.
3125 (TestContext.description):
3127 (TestContext.logError):
3130 * tests/api-report.js: Added some basic tests for /api/report.php.
3132 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3134 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
3136 The problem was that we were detecting whether we're updating dashboard or not by checking
3137 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
3138 all configurations. Use separate 'dashboard' action to execute the code even when
3139 metric_configurations is empty.
3141 * public/admin/tests.php:
3143 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3145 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
3147 Reviewed by Ricky Mondello.
3149 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
3150 from ReportProcessor as a preparation to replace deprecated aggregate.js.
3152 * public/api/report.php:
3153 (ReportProcessor::exit_with_error): Moved.
3154 (ReportProcessor::process): Use the extracted TestRunsGenerator.
3155 (TestRunsGenerator): Added.
3156 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
3157 (TestRunsGenerator::add_aggregated_metric): Moved.
3158 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
3159 (TestRunsGenerator::aggregate): Moved. Made public.
3160 (TestRunsGenerator::aggregate_current_test_level): Moved.
3161 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
3162 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
3163 (TestRunsGenerator::compute_caches): Moved. Made public.
3164 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
3165 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
3166 (TestRunsGenerator::rollback_with_error): Moved.
3168 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3170 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
3172 Reviewed by Remy Demarest.
3174 Regenerate the manifest file when updating fields or adding new items that are included in
3177 * public/admin/bug-trackers.php:
3178 * public/admin/builders.php:
3179 * public/admin/regenerate-manifest.php:
3180 * public/admin/repositories.php:
3181 * public/admin/tests.php:
3182 * public/include/admin-header.php:
3183 (regenerate_manifest): Extracted from regenerate-manifest.php.
3185 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3187 Unreviewed build fix for memory test results.
3189 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
3190 aggregating at each level.
3192 * public/api/report.php:
3193 (ReportProcessor::recursively_ensure_tests):
3194 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
3195 (ReportProcessor::add_values_for_aggregation):
3196 (ReportProcessor::aggregate):
3197 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
3199 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
3201 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
3202 not the number of iteration groups. Also, don't set group number when the entire run belongs
3203 a single iteration group.
3205 * public/api/report.php:
3206 (ReportProcessor::commit):
3208 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3210 SafariPerfMonitor: Introduce iteration groups
3212 Reviewed by Remy Demarest.
3214 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
3215 the runtime environment variances to get more stable results. And it's desirable to keep track of
3216 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
3218 This patch introduces "iteration groups" to keep track of this extra information.
3220 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
3221 the outer array denotes iteration groups and each inner array contains iteration values for each group.
3224 * database/init-database.sql: Add iteration_group column.
3225 * public/api/report.php:
3226 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
3228 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
3229 contains the list of values indexed by the iteration order and group sizes. Store the group size so
3230 that we can restore the iteration groups before passing it to node.js and restore them later.
3232 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
3233 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
3235 Also check that each iteration group in each subtest are consistent with one another. To see why we need
3236 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
3237 that each iteration group in T1 and T2 have the same size:
3238 T1 = [[1, 2], [3, 4, 5]]
3239 T2 = [[6, 7], [8, 9, 10]]
3241 so that the aggregated result (the sum in this case) can have the same groups as in:
3242 T = [[7, 9], [11, 13, 15]]
3244 If some iteration groups in T1 and T2 had a different size as in:
3245 T1 = [[1, 2, 3], [4, 5]]
3246 T2 = [[6, 7], [8, 9, 10]]
3248 Then iteration groups of the aggregated T is ambiguous.
3250 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
3251 (ReportProcessor::commit): Store iteration_group values.
3253 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3255 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
3256 migrated to perf.webkit.org.
3258 * database/perf-webkit-migrator.js: Removed.
3260 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3262 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
3264 * public/index.html:
3267 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3269 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
3271 Reviewed by Ricky Mondello.
3273 It is often desirable to see charts of a given test for all platforms, or to be able to see
3274 charts of all subtests on a given platform when trying to triage perf. regressions.
3276 Support this use case by adding the ability to do so on the charts page.
3278 Also, we used to disable items on the test list based on the platform chosen. This turned out
3279 to be a bad UI because in many situations you want to be able to compare results of the same test
3280 on multiple platforms.
3282 In this new UI, we have three select elements, each of which selects the following:
3283 1. Top-level test - Test suite such as Dromaeo
3284 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
3285 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
3286 3. Platform - Mountain Lion, Qt, etc...
3288 A user can select "all" for metric and platform but we disallow doing both at once since adding
3289 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
3290 think of a use case where you want to look at that many charts at once. We can support this later
3291 if valid use cases come up.
3293 * public/index.html:
3294 (.showCharts.addOption): Extracted.
3295 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
3296 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
3297 metricList has onchange handler that enables/disables items on platformList.
3299 (init): Sort tests and test metrics here instead of doing that in showCharts.
3301 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
3303 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
3305 Reviewed by Remy Demarest and Ricky Mondello.
3307 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
3308 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
3309 templates to the manifest file instead. Each build now only contains the builder id.
3311 * public/api/runs.php: Removed the part of the query that joined builders table. This
3312 speeds up the query quite a bit.
3314 * public/include/manifest.php:
3315 (ManifestGenerator::generate): Generate builders field.
3316 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
3317 associative array that contains name and its build URL template.
3319 * public/index.html:
3320 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
3321 instead of a revision since this function is used for revisions and build page URLs now.
3322 (.buildLabelWithLinks): Include the linkified build number.
3324 * public/js/helper-classes.js:
3325 (TestBuild.builder): Added.
3326 (TestBuild.buildNumber): Added.
3327 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
3328 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
3330 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
3332 Tooltips interfere with user interactions
3334 Rubber-stamped by Simon Fraser.
3336 Disable tooltip on the dashboard page since graphs are too small to be useful there.
3337 Also, show graphs for only 10 days by default as opposed to 20.
3338 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
3340 * public/index.html:
3341 * public/js/helper-classes.js:
3343 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
3345 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
3346 to be compatible with webkit-perf.appspot.com.
3348 * public/admin/builders.php:
3349 * public/api/report.php:
3351 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
3355 Add a missing constraint on builds table. For a given builder, there should be exactly
3356 one build for a given build number.
3358 Also add report_committed_at to reports table to record the time at which a given report
3359 was processed and test_runs and run_iterations rows were committed into the database.
3361 * database/config.json:
3362 * public/api/report.php:
3364 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
3366 Unreviewed. Add more checks for empty SQL query results.
3368 * public/include/manifest.php:
3370 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3372 More build fixes on perf.webkit.org.
3374 * public/api/runs.php: Make PostgreSQL happier.
3375 * public/include/manifest.php: Don't assume we always have bug trackers.
3377 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3379 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
3380 and fix other miscellaneous UI bugs.
3382 Rubber-stamped by Simon Fraser.
3384 Removed the code to determine whether smaller value is better or not for a given test in index.html
3385 in the favor of using that of PerfTestRuns.
3387 * public/include/manifest.php: Fixed a typo.
3388 * public/index.html:
3390 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
3392 * public/js/helper-classes.js:
3393 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
3395 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
3396 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
3397 at roughly 2,000 units to avoid this.
3399 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
3400 The only thing we can avoid is innerHTML.
3402 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3404 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
3406 * public/include/evaluator.js:
3408 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3410 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
3412 Reviewed by Remy Demarest.
3414 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
3415 admin/bug-trackers.php and can be associated with multiple repositories.
3417 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
3418 to determine the set of bug trackers to show for a given set of blame lists.
3419 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
3420 a place to file bugs against the regression.
3422 * database/init-database.sql: Added bug_trackers and tracker_repositories.
3423 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
3425 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
3426 bug trackers, namely associated repositories.
3428 * public/include/admin-header.php: Added a link to bug-trackers.php
3429 * public/include/manifest.php:
3430 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
3431 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
3433 (ManifestGenerator::repositories):
3435 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
3436 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
3437 'repositories' where the latter contains the list of associated repository names.
3439 * public/index.html:
3440 (Chart): Takes bugTrackers as as argument.
3441 (Chart.showTooltipWithResults): Removed the hard-coded list.
3443 (init.addPlatformsToDashboard):
3444 (init.showCharts.createChartFromListPair):
3445 (init): Stores the list of bug trackers in the manifest to a local variable.
3447 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3449 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
3451 * public/include/evaluator.js:
3453 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3455 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
3457 Reviewed by Remy Demarest.
3459 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
3460 new row into the database.
3462 * public/admin/aggregators.php: Use AdministrativePage.
3463 * public/admin/builders.php: Ditto.
3464 * public/admin/repositories.php: Ditto.
3465 * public/include/admin-header.php:
3466 (AdministrativePage): Added.
3467 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
3468 to an associative array that describes the column.
3469 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
3470 - label: Human readable name of the column.
3471 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
3472 column exists only before we create password_hash column at the insertion time.
3474 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
3475 titlecase (e.g. new_bug is converted to New Bug).
3476 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
3477 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
3478 textarea for a given editing mode ('text', 'url', or 'string').
3479 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
3480 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
3482 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
3484 Build fix. Some systems don't support r+. Use proc_open instead.
3486 * public/api/report.php:
3488 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3490 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
3491 when computing the y-axis of data points to show tooltips at.
3493 * public/index.html:
3495 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3497 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
3500 * public/.htaccess: Removed.
3502 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
3506 * public/include/manifest.php: Build fix. db is on this.
3507 * public/js/statistics.js:
3508 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
3510 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
3512 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
3514 Reviewed by Anders Carlsson.
3516 Rewrote and merged populate-from-report.js into report.php.
3518 * database/config.json: Added a path to node.js.
3520 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
3521 Once we land this patch and update the administrative pages, we can remove this column.
3523 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
3524 that table is going away once we remove the node.js backend.
3526 * database/populate-from-report.js: Removed.
3527 * public/api/report.php: Added.
3529 (ReportProcessor.__construct):
3530 (ReportProcessor.process):
3532 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
3533 verified to be submitted by a known builder.
3535 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
3536 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
3537 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
3538 inside a transaction because there could be multiple reports for a single build, each containing results for
3541 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
3542 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
3543 add_values_to_commit, and add_values_for_aggregation.
3545 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
3546 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
3547 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
3550 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
3551 to be aggregated in ReportProcessor.aggregate.
3553 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
3555 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
3556 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
3557 given for each row (child metrics of M). This function extracts each column (iteration) via
3558 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
3559 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
3561 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
3562 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
3563 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
3565 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
3566 (ReportProcessor.evaluate_expressions_by_node): See above.
3568 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
3569 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
3570 results also need the said caches.
3572 (ReportProcessor.add_values_to_commit):
3574 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
3575 the transaction as needed if anything goes wrong.
3577 (ReportProcessor.rollback_with_error)
3579 * public/include/db.php:
3580 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
3581 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
3582 contiguously in a SQL statement.
3584 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
3585 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
3586 a column value of the choice.
3588 (Database.begin_transaction): Added.
3589 (Database.commit_transaction): Added.
3590 (Database.rollback_transaction): Added.
3592 * public/include/evaluator.js: Added.
3593 * public/include/json-header.php:
3594 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
3595 context under which the request failed.
3596 (successful_exit): Merge "additional details".
3597 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
3598 (merge_additional_details):
3600 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
3602 SafariPerfMonitor: Add more helper functions to db.php
3604 Reviewed by Remy Demarest.
3606 Added Database::insert_row and array_get to make common database operations easier.
3608 * public/admin/aggregators.php: Use Database::insert_row instead of
3609 execute_query_and_expect_one_row_to_be_affected.
3611 * public/admin/builders.php: Ditto.
3613 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
3614 inserting a row. With insert_row, we don't need that.
3616 * public/include/admin-header.php: Ditto.
3618 * public/include/db.php:
3619 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
3620 return the default value (defaults to NULL) if the key doesn't exist.
3622 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
3625 (Database::prepare_params): Added. Takes an associative array of column names and their values,
3626 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
3627 column names all in the same order.
3629 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
3630 the given prefix. Values are given in a form of an associative array where keys are unprefixed
3631 column names and values are corresponding values. When the row is successfully inserted, it returns
3632 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
3633 indicating the success of the insertion.
3635 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3637 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
3639 Reviewed by Conrad Shultz.
3641 Rewrote the manifest generator in PHP.
3643 * database/generate-manifest.js: Removed.
3644 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
3645 * public/include/db.php:
3646 (array_ensure_item_has_array): Added.
3647 * public/include/evaluator.js: Added.
3648 * public/include/json-header.php:
3649 * public/include/manifest.php: Added.
3651 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3653 Dates on overflow plot are overlapping
3655 Rubber-stamped by Simon Fraser.
3657 Don't show more than 5 days.
3659 * public/index.html:
3660 * public/js/helper-classes.js:
3661 (TestBuild.UTCtoPST):
3664 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3666 Show build time as well as commit time on the dashboard and tooltips.
3668 Rubber-stamped by Simon Fraser.
3670 Include both the maximum commit time and build time in buildLabelWithLinks.
3671 Also use ISO format to save the screen real estate.
3673 * public/index.html:
3674 (buildLabelWithLinks):
3675 * public/js/helper-classes.js:
3677 (TestBuild.buildTime):
3678 (TestBuild.formattedBuildTime):