1 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
3 v2 UI should adjust the number of ticks on dashboards based on screen size
4 https://bugs.webkit.org/show_bug.cgi?id=141502
6 Reviewed by Chris Dumez.
8 * public/v2/interactive-chart.js:
9 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
12 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
14 New perf dashboard shows too much space around interesting data points
15 https://bugs.webkit.org/show_bug.cgi?id=141487
17 Reviewed by Chris Dumez.
19 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
20 show the current time series excluding points in the series outside the moving average envelope.
23 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
24 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
25 time series if the point lies outside the moving average envelope. Don't expose the moving average or
26 the envelope computed for this purpose if they're not set by the user.
29 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
30 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
32 * public/v2/interactive-chart.js:
33 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
34 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
35 to deal with showFullYAxis here.
36 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
37 argument instead of directly inspecting showFullYAxis.
39 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
41 New perf dashboard shouldn't always show outliners
42 https://bugs.webkit.org/show_bug.cgi?id=141445
44 Reviewed by Chris Dumez.
46 Use the simple moving average with an average difference envelope to compute the y-axis range to show
47 to avoid expanding it spuriously to show one off outlier.
50 (App.Pane): Don't show the full y-axis range by default.
51 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
52 one is not specified by the user but without showing them in the charts.
53 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
54 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
56 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
57 (App.ChartsController._serializePaneList): Ditto.
59 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
61 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
63 * public/v2/interactive-chart.js:
64 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
65 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
66 if they are not specified by the user (i.e. only used to adjust y-axis range).
67 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
68 x-axis domain remained the same. Without this change, the charts would never redraw.
69 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
70 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
71 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
73 * public/v2/js/statistics.js:
74 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
76 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
81 (set get App.Pane.Ember.Object.extend):
83 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
85 New perf dashboard should have the ability to overlay moving average with an envelope
86 https://bugs.webkit.org/show_bug.cgi?id=141438
88 Reviewed by Andreas Kling.
90 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
92 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
93 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
94 n, backward window size, and m, forward window size, as an argument.
96 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
97 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
99 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
100 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
103 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
104 between each x_i and x̄_i.
106 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
107 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
108 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
109 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
112 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
113 The configuration of the currently chosen strategies is saved in the query string for convenience.
115 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
117 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
120 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
121 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
122 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
123 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
124 from the query string via ChartsController.
125 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
126 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
127 (App.Pane._executeStrategy): Added.
128 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
130 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
131 selections, and added two new arguments for the moving average and the enveloping configurations.
132 (App.ChartsController._serializePaneList): Ditto.
133 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
134 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
135 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
136 (App.PaneController.actions.toggleStatPane): Added.
138 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
139 current (as opposed to baseline and target) time series for when it's the most foreground graph without
140 moving average and its envelope overlapping on top of it.
142 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
144 * public/v2/interactive-chart.js:
145 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
146 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
147 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
148 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
149 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
150 but don't bother removing individual paths and circles. Added the code to show the moving average time
151 series when there is one. Also add "foreground" class on SVG elements for the current time series when
152 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
153 series when "foreground" is not set.
154 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
155 account when computing the y-axis range.
156 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
158 * public/v2/js/statistics.js:
159 (Statistics.MovingAverageStrategies): Added.
160 (Statistics.EnvelopingStrategies): Added.
162 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
164 The delta value in the chart pane sometimes doens't show '+' for a positive delta
165 https://bugs.webkit.org/show_bug.cgi?id=141340
167 Reviewed by Andreas Kling.
169 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
170 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
173 (App.Pane.computeStatus):
174 (App.createChartData):
176 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
178 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
181 (App.PaneController._updateDetails):
183 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
185 Unreviewed. Commit the forgotten change.
187 * public/include/manifest.php:
189 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
191 New perf dashboard should have multiple dashboard pages
192 https://bugs.webkit.org/show_bug.cgi?id=141339
194 Reviewed by Chris Dumez.
196 Added the support for multiple dashboard pages. Also added the status of the latest data point.
197 e.g. "5% better than target"
199 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
200 Also hid the border lines around charts on the dashboard page for a cleaner look.
203 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
204 (App.IndexRoute.beforeModel): Added.
205 (App.DashboardRoute): Added.
206 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
207 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
208 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
209 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
210 (App.DashboardController): Renamed from App.IndexController.
211 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
212 and "defaultDashboard" as these are taken care of by newly added routers.
213 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
214 now done in actions.toggleEditMode.
215 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
216 an existing dashboard.
218 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
219 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
220 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
221 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
223 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
225 (App.PaneController._updateDetails): Updated per changes to computeStatus.
227 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
230 (TimeSeries.prototype.lastPoint): Added.
232 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
233 on the dashboard, and enumerate all predefined dashboards.
235 * public/v2/interactive-chart.js:
236 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
237 for the dashboard page.
239 * public/v2/manifest.js:
240 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
241 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
242 IDs are generated for each dashboard for forward compatibility.
244 (App.Manifest.dashboardByName): Added.
245 (App.Manifest.defaultDashboardName): Added.
246 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
248 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
250 Move commits viewer to the end of details view
251 https://bugs.webkit.org/show_bug.cgi?id=141315
253 Rubber-stamped by Andreas Kling.
255 Show the difference instead of the old value per kling's request.
258 (App.PaneController._updateDetails):
259 * public/v2/index.html:
261 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
263 Move commits viewer to the end of details view
264 https://bugs.webkit.org/show_bug.cgi?id=141315
266 Reviewed by Andreas Kling.
268 Improved the way list of commits are shown per kling's request.
271 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
273 * public/v2/chart-pane.css: Updated the style for the commits viewer.
275 * public/v2/commits-viewer.js:
276 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
277 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
279 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
280 moved the commits viewers out of the details tables so that they don't interleave revision data.
282 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
284 New perf dashboard should compare results to baseline and target
285 https://bugs.webkit.org/show_bug.cgi?id=141286
287 Reviewed by Chris Dumez.
289 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
290 Also use d3.format to format the selected value to show four significant figures.
293 (App.Pane.searchCommit):
294 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
295 to compute the status text without having to recreate them.
296 (App.createChartData): Added.
297 (App.PaneController._updateDetails): Use 3d.format on current and old values.
298 (App.PaneController._computeStatus): Added. Computes the status text.
299 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
300 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
301 format the values using chartData.formatter.
303 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
304 the baseline and in blue if it's better than the target.
307 (TimeSeries.prototype.findPointAfterTime): Added.
309 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
310 the bug that we were not showing the old value's unit.
312 * public/v2/interactive-chart.js:
313 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
314 the code to show the baseline and the target lines.
316 * public/v2/manifest.js:
317 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
319 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
321 Unreviewed build fix.
324 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
326 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
328 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
329 https://bugs.webkit.org/show_bug.cgi?id=141280
331 Reviewed by Chris Dumez.
333 Fixed the bug by passing in "since" as a query parameter to the charts page.
335 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
337 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
339 (App.IndexController): Changed the default number of days from one month to one week.
340 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
341 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
343 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
345 New perf dashboard erroneously clears zoom when poping history items
346 https://bugs.webkit.org/show_bug.cgi?id=141278
348 Reviewed by Chris Dumez.
350 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
352 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
353 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
356 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
357 shown in the main plot.
358 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
359 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
361 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
363 New perf dashboard shows null as the aggregator name if no aggregation is done
364 https://bugs.webkit.org/show_bug.cgi?id=141256
366 Reviewed by Chris Dumez.
368 Don't show the aggregator name if there isn't one.
370 * public/v2/manifest.js:
373 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
375 Unreviewed build fix after r179611.
377 * public/v2/interactive-chart.js:
379 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
381 Perf dashboard doesn’t show the right unit for Safari UI tests
382 https://bugs.webkit.org/show_bug.cgi?id=141238
384 Reviewed by Darin Adler.
386 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
387 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
388 between metrics and their units.
390 * public/js/helper-classes.js:
391 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
392 * public/v2/manifest.js:
393 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
394 * public/v2/interactive-chart.js:
395 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
396 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
398 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
400 Interactive chart component provides two duplicate API for highlighting points
401 https://bugs.webkit.org/show_bug.cgi?id=141234
403 Reviewed by Chris Dumez.
405 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
406 on the main charts page and markedPoints to show the two end points in the analysis task page.
408 This patch merges markedPoints into highlightedItems.
411 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
412 * public/v2/chart-pane.css:
413 * public/v2/index.html: Ditto.
414 * public/v2/interactive-chart.js:
415 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
416 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
417 items if highlightedItems was set before the initial layout.
418 (App.InteractiveChartComponent._relayoutDataAndAxes):
419 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
420 vertical lines, just set cx and cy as done for other "dots".
421 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
422 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
423 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
424 set the radius of highlight circles here.
426 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
428 Don’t use repository names as id’s.
429 https://bugs.webkit.org/show_bug.cgi?id=141226
431 Reviewed by Chris Dumez.
433 Not using repository names as their id's reduces the need to fetch the entire repositories table.
434 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
436 * Websites/perf.webkit.org/public/api/runs.php:
437 (parse_revisions_array): No longer uses $repository_id_to_name.
438 (main): No longer populates $repository_id_to_name.
440 * Websites/perf.webkit.org/public/api/triggerables.php:
441 (main): Don't resolve repository names.
443 * Websites/perf.webkit.org/public/include/manifest.php:
444 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
445 (ManifestGenerator::bug_trackers): Don't resolve repository names.
447 * Websites/perf.webkit.org/public/js/helper-classes.js:
448 (TestBuild): Renamed repositoryName to repositoryId.
449 (TestBuild.revision): Ditto.
450 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
451 since this is the text shown to human.
453 * Websites/perf.webkit.org/public/v2/app.js:
454 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
455 (App.PaneController._updateDetails): Ditto.
456 (App.AnalysisTaskController.updateRoots): Ditto.
458 * Websites/perf.webkit.org/public/v2/data.js:
459 (Measurement): Ditto.
460 (Measurement.prototype.commitTimeForRepository): Ditto.
461 (Measurement.prototype.formattedRevisions): Ditto.
463 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
464 select element's label and value respectively.
466 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
468 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
470 * public/api/runs.php:
472 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
474 /api/runs.php should have main function
475 https://bugs.webkit.org/show_bug.cgi?id=141220
477 Reviewed by Benjamin Poulain.
479 Wrapped the code inside main function for clarity.
481 * public/api/runs.php:
483 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
485 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
487 * tools/sync-with-buildbot.py:
488 (find_request_updates):
490 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
492 Perf dashboard always assigns the result of A/B testing with build request 1
493 https://bugs.webkit.org/show_bug.cgi?id=140382
495 Reviewed by Darin Adler.
497 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
498 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
500 Also fixed a typo as well as a bug that reports were never associated with builds.
502 * public/include/report-processor.php:
503 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
504 instead of the first non-null value.
505 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
506 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
508 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
510 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
512 * public/admin/tests.php:
514 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
516 Unreviewed build fix. Removed the stale code.
518 * public/admin/triggerables.php:
520 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
522 Perf dashboard should have the ability to post A/B testing builds
523 https://bugs.webkit.org/show_bug.cgi?id=140317
525 Rubber-stamped by Simon Fraser.
527 This patch adds the support for triggering A/B testing from the perf dashboard.
529 We add a few new tables to the database. "build_triggerables", which represents a set of builders
530 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
531 of repositories for which an arbitrary revision can be specified for A/B testing.
532 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
533 "roots" table which specifies the revision used in a given root set in each repository.
535 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
536 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
537 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
538 to build_requests table. Also made each test group's name unique in a given analysis task as it
539 would be confusing to have multiple test groups of the same name.
541 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
543 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
544 for which a specific revision can be set in an A/B testing on a given triggerable.
546 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
547 triggerable. Also updates the status' and the status urls of specified build requests when
548 buildRequestUpdates is provided in the raw POST data.
551 * public/api/runs.php:
552 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
553 results of an A/B testing.
555 * public/api/test-groups.php:
556 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
558 * public/api/triggerables.php: Added.
559 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
561 * public/include/admin-header.php:
563 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
564 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
565 and root sets used in those requests.D
566 (BuildRequestsFetcher::__construct):
567 (BuildRequestsFetcher::fetch_for_task):
568 (BuildRequestsFetcher::fetch_for_group):
569 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
570 (BuildRequestsFetcher::has_results):
571 (BuildRequestsFetcher::results):
572 (BuildRequestsFetcher::results_with_resolved_ids):
573 (BuildRequestsFetcher::results_internal):
574 (BuildRequestsFetcher::root_sets):
575 (BuildRequestsFetcher::fetch_roots_for_set):
577 * public/include/db.php:
578 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
579 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
580 table since it only has the primary key, id, column.
581 (Database::select_or_insert_row):
582 (Database::update_or_insert_row):
583 (Database::update_row): Added.
584 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
585 should be inserted when no row matches the specified criteria. This is used while updating
586 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
587 new build requests in that API.
588 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
589 This is used in public/api/triggerables.php when no analysis task is specified.
591 * public/include/json-header.php:
592 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
593 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
594 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
595 find the closest ancestor with a triggerable.
597 * public/include/report-processor.php:
598 (ReportProcessor::process):
599 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
600 if jobId or buildRequest is specified.
602 * public/include/test-name-resolver.php:
603 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
604 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
605 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
608 * public/include/test-path-resolver.php: Added.
609 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
610 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
611 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
612 in order to compute full test metric names.
613 (TestPathResolver::__construct):
614 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
615 the highest (a test without a parent).
616 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
617 the highest ancestor to the test itself.
618 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
620 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
622 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
623 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
624 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
625 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
627 * public/v2/analysis.js:
628 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
629 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
630 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
631 (App.TestGroup.create): Added. Creates a new A/B testing group.
632 (App.Triggerable): Added.
633 (App.TriggerableAdapter): Added.
634 (App.TriggerableAdapter.buildURL): Added.
635 (App.BuildRequest.testGroup): Renamed from group.
636 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
637 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
638 in this build request.
639 (App.BuildRequest.status): Added.
640 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
641 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
644 (App.AnalysisTaskController.testGroups): Added.
645 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
646 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
647 but an observer that updates "roots" property. Filter out the repositories that are not accepted
648 by the associated triggerable as they will be ignored.
649 (App.AnalysisTaskController.actions.createTestGroup): Added.
651 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
653 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
654 the status of those builds to the perf dashboard. A similar script can be written to support
655 other continuous builds systems.
656 (main): Fetches the list of pending builds as well as currently running or completed builds from
657 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
658 a single new build on each builder with no pending builds, and marks the set of open build requests
659 that have been scheduled to run on the buildbot but not found in the first step as stale.
660 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
663 "platform": "mac-mavericks",
664 "test": ["Parser", "html5-full-render.html"],
665 "builder": "Trunk Syrah Production Perf AB Tests",
667 "forcescheduler": "force-mac-mavericks-release-perf",
668 "webkit_revision": "$WebKit",
669 "jobid": "$buildRequest"
674 (find_request_updates): Return a list of build request status updates to make based on the pending
675 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
676 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
677 if the build request had not been completed. This is necessary because a failed build will not
678 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
679 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
680 of open requests the perf dashboard has.
681 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
682 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
683 or human canceling a build may trigger such a state.
684 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
685 replacing repository names with their revisions and buildRequest with the build request id.
686 (config_for_request): Finds a builder for the test and the platform of a build request.
687 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
688 (property_value_from_build): Returns the value of a specific property in a buildbot build.
689 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
691 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
693 Cache-control should be set only on api/runs
694 https://bugs.webkit.org/show_bug.cgi?id=140312
696 Reviewed by Andreas Kling.
698 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
699 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
700 just set cache-control there instead of json-header.php which is used by other JSON APIs.
702 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
704 * public/api/analysis-tasks.php:
705 * public/api/runs.php: Set the cache control headers.
706 * public/api/test-groups.php:
707 * public/include/db.php: Set the default timezone to UTC.
708 * public/include/json-header.php: Don't set the cache control headers.
710 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
712 api/report-commit should authenticate with a slave name and password
713 https://bugs.webkit.org/show_bug.cgi?id=140308
715 Reviewed by Benjamin Poulain.
717 Use a slave name and a password to authenticate new commit reports.
719 * public/api/report-commits.php:
721 * public/include/json-header.php:
722 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
723 a slave name and a password instead of a builder name and a password.
724 * tests/api-report-commits.js: Updated tests.
726 (main): Renamed variables.
727 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
729 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
731 Perf dashboard should support authentication via a slave password
732 https://bugs.webkit.org/show_bug.cgi?id=139837
734 Reviewed by Andreas Kling.
736 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
737 having to add multiple builders with the same password when a single build slave is shared among them.
739 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
741 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
743 * public/admin/build-slaves.php: Added.
745 * public/admin/builders.php: Added the support for updating passwords.
747 * public/include/admin-header.php:
748 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
749 being retrieved from $_POST.
750 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
751 the raw may not exist (e.g. new_password).
752 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
753 control here when this flag evaluates to TRUE.
755 * public/include/report-processor.php:
756 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
757 values are present in the report. In addition, try authenticating builderName with slavePassword if
758 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
759 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
760 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
762 (ReportProcessor::store_report): Store the slave ID with the report.
763 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
764 the matching build is different from what's being reported.
766 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
769 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
771 New perf dashboard should not duplicate author information in each commit
772 https://bugs.webkit.org/show_bug.cgi?id=139756
774 Reviewed by Darin Adler.
776 Instead of each commit having author name and email, make it reference a newly added committers table.
777 Also replace "email" by "account" since some repositories don't use emails as account names.
779 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
780 which only contains as many rows as there are accounts in each repository, instead of commits table
781 which contains every commit ever happened in each repository.
783 To migrate an existing database into match the new schema, run:
787 INSERT INTO committers (committer_repository, committer_name, committer_email)
788 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
789 FROM commits WHERE commit_author_email IS NOT NULL);
791 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
793 UPDATE commits SET commit_committer = committer_id FROM committers
794 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
796 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
797 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
801 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
802 reference to committers. Also added the missing drop table statements.
804 * public/api/commits.php:
805 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
806 an array here instead of doing it in format_commit.
807 (fetch_commits_between): Updated queries to JOIN commits with committers.
808 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
811 * public/api/report-commits.php:
812 (main): Store the reported committer information or update the existing entry if there is one.
814 * tests/admin-regenerate-manifest.js: Fixed tests.
816 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
818 * tools/pull-svn.py: Renamed email to account.
820 (fetch_commit_and_resolve_author):
822 (resolve_author_name_from_account):
823 (resolve_author_name_from_email): Deleted.
825 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
827 Unreviewed build fix.
829 * public/v2/index.html: Include js files we extracted in r177424.
831 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
833 Unreviewed. Adding the forgotten svnprop.
835 * tools/pull-svn.py: Added property svn:executable.
837 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
839 Split InteractiveChartComponent and CommitsViewerComponent into separate files
840 https://bugs.webkit.org/show_bug.cgi?id=139716
842 Rubber-stamped by Benjamin Poulain.
844 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
845 and interactive-chart.js respectively since app.js has gotten really large.
848 * public/v2/commits-viewer.js: Added.
849 * public/v2/interactive-chart.js: Added.
851 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
853 New perf dashboard's chart UI is buggy
854 https://bugs.webkit.org/show_bug.cgi?id=139214
856 Reviewed by Chris Dumez.
858 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
860 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
861 component. This is not how Ember.js components should interact to begin with. The component now exposes
862 selectedPoints and always updates selection instead of sharedSelection.
865 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
866 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
867 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
868 and end time should be completely determined by "since" and the present time.
869 (App.ChartsController._startTimeChanged): Ditto.
870 (App.ChartsController._scheduleQueryStringUpdate):
871 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
873 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
875 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
876 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
877 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
878 observes the changes to selectedPoints property as it gets updated by the main chart.
879 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
880 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
882 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
883 when domain arrays aren't identical. This was causing a subtle race with other logic.
884 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
885 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
886 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
887 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
888 see if those two points correspond to a range or a single data point. Rewrote all that logic by
889 directly observing selectedPoints and currentItem properties instead of taking points and relying on
890 an instance variable, which was a terrible API.
891 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
892 when the main plot has a selected range, we don't have to check this._hasRange anymore.
894 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
895 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
896 (App.InteractiveChartComponent._updateSelection):
897 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
898 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
899 selectedPoints property.
901 (App.AnalysisTaskController._fetchedRuns):
902 (App.AnalysisTaskController._rootChangedForTestSet):
904 * public/v2/index.html:
905 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
907 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
909 Unreviewed. Fixed syntax errors.
912 * public/api/commits.php:
914 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
916 The dashboard on new perf monitor should be configurable
917 https://bugs.webkit.org/show_bug.cgi?id=138994
919 Reviewed by Benjamin Poulain.
921 For now, make it configurable via config.json. We should eventually make it configurable via
922 an administrative page but this will do for now.
924 * config.json: Added the empty dashboard configuration.
926 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
929 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
930 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
931 Also obtain the default configuration from App.Manifest.
932 (App.IndexController._normalizeTable): Moved to App.Dashboard.
934 * public/v2/manifest.js:
935 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
936 (App.Repository.urlForRevisionRange): Ditto.
937 (App.Dashboard): Added.
938 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
939 (App.Dashboard.rows): Ditto.
940 (App.Dashboard.headerColumns): Ditto.
941 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
942 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
943 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
944 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
946 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
948 There should be a way to associate bugs with analysis tasks
949 https://bugs.webkit.org/show_bug.cgi?id=138977
951 Reviewed by Benjamin Poulain.
953 Updated associate-bug.php to match the new database schema.
955 * public/include/json-header.php:
956 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
957 already camel-cased in require_existence_of. This makes the function usable elsewhere.
959 * public/privileged-api/associate-bug.php:
960 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
961 Also verify that those values are integers using require_format.
963 * public/v2/analysis.js:
964 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
965 (App.Bug.label): Added.
966 (App.BugAdapter): Added.
967 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
968 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
970 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
971 containing the bug information.
974 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
975 (App.AnalysisTaskRoute):
976 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
977 (App.AnalysisTaskController._fetchedManifest): Added.
978 (App.AnalysisTaskController.actions.associateBug): Added.
980 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
983 (Measurement.prototype.associateBug): Deleted.
985 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
986 Added a table show the bug information. Also hide the chart until chartData is available.
988 * public/v2/manifest.js:
991 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
993 Fix misc bugs and typos in app.js
994 https://bugs.webkit.org/show_bug.cgi?id=138946
996 Reviewed by Benjamin Poulain.
999 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1000 (App.ChartsController.init):
1001 (App.buildPopup): Renamed from App.BuildPopup.
1002 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1003 remove() on the wrong object (an array as opposed to elements in the array).
1004 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1005 _highlights is always an array and evalutes to true.
1007 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1009 New perf dashboard should provide UI to create a new analysis task
1010 https://bugs.webkit.org/show_bug.cgi?id=138910
1012 Reviewed by Benjamin Poulain.
1014 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1015 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1017 With this patch, we can create a new analysis task by selection a range of points and opening
1018 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1019 in the chart hyperlinked to the analysis task.
1021 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1023 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1024 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1026 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1027 and adds the associated bugs to each task in the array.
1030 * public/api/runs.php: Reverted changes made in r175006.
1031 (fetch_runs_for_config):
1034 * public/api/test-groups.php:
1035 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1037 * public/include/db.php:
1038 (Database::select_first_or_last_row):
1039 (Database::select_rows): Extracted from select_first_or_last_row.
1041 * public/v2/analysis.js:
1042 (App.AnalysisTask): Added "bugs" property.
1043 (App.Bug): Added now that bugs are regular data store objects.
1046 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1047 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1048 platform that are associated with a specific range of runs.
1049 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1050 (App.PaneController.actions.associateBug): Deleted.
1051 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1052 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1053 once we've created one.
1054 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1055 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1056 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1057 (App.PaneController._updateBugs): Deleted.
1058 (App.PaneController._updateMarkedPoints): Deleted.
1059 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1060 the name is missing or when at most one point is selected.
1062 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1063 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1064 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1065 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1066 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1067 clickable bars for analysis tasks.
1068 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1069 bar for analysis tasks to place them at the right location.
1070 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1072 * public/v2/chart-pane.css:
1073 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1074 (.chart .rangeBar): Added.
1076 * public/v2/data.js:
1077 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1079 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1080 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1081 task bars in the interactive chart component.
1083 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1085 Fix typos in r176203.
1088 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1089 (App.AnalysisTaskRoute):
1091 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1093 Unreviewed. Updated the install instruction.
1097 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1099 App.Manifest shouldn't use App.__container__.lookup
1100 https://bugs.webkit.org/show_bug.cgi?id=138768
1102 Reviewed by Andreas Kling.
1104 Removed the hack to find the store object via App.__container__.lookup.
1105 Pass around the store object instead.
1108 (App.DashboardRow._createPane): Add "store" property to the pane.
1109 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1110 (App.IndexController.gridChanged): Ditto.
1111 (App.IndexController.actions.addRow): Ditto.
1112 (App.IndexController.init): Ditto.
1113 (App.Pane._fetch): Ditto.
1114 (App.ChartsController._parsePaneList): Ditto.
1115 (App.ChartsController._updateQueryString): Ditto.
1116 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1117 (App.BuildPopup): Ditto.
1118 (App.AnalysisTaskRoute.model): Ditto.
1119 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1121 * public/v2/manifest.js:
1122 (App.Manifest.fetch): Removed the code to find the store object.
1124 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1126 Fix Ember.js warnings the new perf dashboard
1127 https://bugs.webkit.org/show_bug.cgi?id=138531
1129 Reviewed by Darin Adler.
1131 Fixed various warnings.
1134 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1135 * public/v2/data.js:
1136 (PrivilegedAPI._post): Removed the superfluous console.log.
1137 (CommitLogs.fetchForTimeRange): Ditto.
1138 * public/v2/index.html: Added tbody as required by the HTML specification.
1140 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1142 Fix typos in r175768.
1145 (App.AnalysisTaskViewModel.roots):
1147 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1149 Introduce the concept of analysis task to perf dashboard
1150 https://bugs.webkit.org/show_bug.cgi?id=138517
1152 Reviewed by Andreas Kling.
1154 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1155 a single platform and used to bisect regressions in the range.
1157 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1159 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1160 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1161 test runs. Analysis tasks not associated with test runs are used for try new patches.
1162 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1163 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1164 build_requests - A build request represents a single pending build for A/B testing.
1166 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1170 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1171 the specified analysis task group as well as build requests associated with them.
1173 (fetch_test_groups_for_task):
1174 (fetch_build_requests_for_task):
1175 (fetch_build_requests_for_group):
1176 (format_test_group):
1177 (format_build_request):
1179 * public/include/json-header.php:
1180 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1183 * public/privileged-api/associate-bug.php:
1184 (main): Fixed a typo.
1186 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1189 (ensure_config_from_runs):
1191 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1193 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1195 (App.AnalysisTask.create):
1197 (App.TestGroupAdapter):
1198 (App.AnalysisTaskSerializer):
1199 (App.TestGroupSerializer):
1202 * public/v2/app.css: Added style rules for the analysis page.
1205 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1207 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1208 exactly one selected point as we can still create an analysis task.
1209 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1210 grammatical and also alert'ed the error message when there is one.
1211 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1212 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1213 once XHR request has completed.
1214 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1215 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1216 is selected in the details pane.
1218 (App.AnalysisRoute): Added.
1219 (App.AnalysisTaskRoute): Added.
1220 (App.AnalysisTaskViewModel): Added.
1221 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1222 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1223 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1224 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1225 the user selects an option for all roots in A or B configuration.
1226 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1228 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1230 * public/v2/data.js:
1231 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1232 point so that we can use it in App.AnalysisTaskViewModel.roots.
1233 (TimeSeries.prototype.findPointByMeasurementId): Added.
1234 (TimeSeries.prototype.seriesBetweenPoints): Added.
1236 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1237 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1238 when multiple points are selected. Finally, added a new template for the analysis task page.
1240 * public/v2/manifest.js:
1241 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1242 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1243 App.AnalysisTaskViewModel._taskUpdated.
1245 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1247 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1248 https://bugs.webkit.org/show_bug.cgi?id=138111
1250 Reviewed by Darin Adler.
1253 (App.PaneController.bugsChangeCount): Removed.
1254 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1255 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1256 Finds the list of current run's points that are associated with bugs.
1257 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1258 * public/v2/chart-pane.css:
1259 (.chart .marked): Renamed from .hasBugs.
1260 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1262 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1264 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1265 https://bugs.webkit.org/show_bug.cgi?id=138099
1267 Reviewed by Benjamin Poulain.
1269 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1270 _showDetails inverting the order of the current and old measurements.
1273 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1274 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1275 current (latest) measurement and the first point is the oldest measurement.
1276 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1278 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1280 Perf dashboard should provide a way to associate bugs with a test run
1281 https://bugs.webkit.org/show_bug.cgi?id=137857
1283 Reviewed by Andreas Kling.
1285 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1286 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1287 the Apache configuration.
1290 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1291 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1292 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1293 via the cookie and returns a token computed from those two values as well as the remote username.
1295 The font end code then POST's the request along with the returned token. The server side code verifies
1296 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1297 the token hasn't expired.
1300 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1301 have zero or exactly one bug associated with a test run.
1303 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1304 * public/api/runs.php:
1305 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1306 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1307 an associated bug if there is one.
1308 (format_run): Calls parse_bugs_array.
1310 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1311 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1312 have a valid JSON payload.
1313 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1314 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1315 the expiration time stored in the cookie.
1316 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1318 * public/include/manifest.php:
1319 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1320 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1322 * public/index.html:
1323 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1325 * public/privileged-api/associate-bug.php: Added.
1326 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1327 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1329 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1331 * public/v2/app.css:
1332 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1333 selected in a chart.
1336 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1337 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1338 they would overlap on each other if both of them are shown.
1339 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1340 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1341 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1342 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1343 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1344 showing the search pane.
1345 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1346 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1347 bugs in the selected range.
1349 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1350 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1351 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1352 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1353 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1354 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1355 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1356 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1358 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1359 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1360 to selectionChanged action instead of just finding the first and the last points.
1362 * public/v2/chart-pane.css: Updated the style.
1364 * public/v2/data.js:
1365 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1366 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1367 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1368 we haven't already obtained a CSRF token or if the token has already been expired.
1369 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1371 (Measurement.prototype.bugs): Added.
1372 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1373 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1375 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1378 * public/v2/manifest.js:
1379 (App.BugTracker.bugUrl):
1380 (App.BugTracker.newBugUrl): Added.
1381 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1382 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1383 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1384 (App.Manifest.bugTrackers): Added.
1385 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1386 their respective ids to make the ordering stable.
1388 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1390 Remove unused jobs table
1391 https://bugs.webkit.org/show_bug.cgi?id=137724
1393 Reviewed by Daniel Bates.
1395 Removed jobs table in the database as well as related code.
1397 * init-database.sql:
1398 * public/admin/jobs.php: Removed.
1399 * public/admin/tests.php:
1400 * public/include/admin-header.php:
1402 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1404 New perf dashboard should have an ability to search commits by a keyword
1405 https://bugs.webkit.org/show_bug.cgi?id=137675
1407 Reviewed by Geoffrey Garen.
1409 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1410 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1411 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1413 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1414 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1416 * public/api/commits.php:
1417 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1418 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1419 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1420 (format_commit): Renamed from format_commits. Now only formats one commit.
1422 * public/include/db.php:
1423 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1425 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1428 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1429 which is a hash table that contains highlighted items' measurements' ids as keys.
1430 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1431 the default commit repository.
1432 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1433 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1434 Added the code to initialize this._highlights.
1435 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1436 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1437 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1438 the existing lines for the old highlighted items.
1439 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1440 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1442 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1444 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1445 (CommitLogs): Added.
1446 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1447 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1448 (CommitLogs._cacheConsecutiveCommits): Ditto.
1449 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1450 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1451 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1453 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1454 for showingDetails since this property is no longer used.
1456 * public/v2/manifest.js:
1457 (App.Manifest.repositories): Added.
1458 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1459 the default repository to search.
1460 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1462 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1464 Unreviewed build fix after r174555.
1466 * public/include/manifest.php:
1467 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1468 * tests/admin-regenerate-manifest.js: Fixed the test case.
1470 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1472 New perf dashboard UI tries to fetch commits all the time
1473 https://bugs.webkit.org/show_bug.cgi?id=137592
1475 Reviewed by Andreas Kling.
1477 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1478 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1479 no reported commits as they are all going to fail.
1481 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1482 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1483 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1484 of commits sorted chronologically by time.
1486 * public/include/manifest.php:
1489 (App.CommitsViewerComponent.commitsChanged):
1491 * public/v2/data.js:
1492 (FetchCommitsForTimeRange):
1493 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1495 * public/v2/manifest.js:
1498 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1500 Another unreviewed build fix after r174477.
1502 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1504 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1506 * public/include/report-processor.php:
1508 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1510 Unreviewed build fix after r174477.
1512 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1513 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1515 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1516 This is necessary for baseline and target values manually added via admin pages.
1518 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1520 Add v2 UI for the perf dashboard
1521 https://bugs.webkit.org/show_bug.cgi?id=137537
1523 Rubber-stamped by Andreas Kling.
1526 * public/v2/app.css: Added.
1527 * public/v2/app.js: Added.
1528 * public/v2/chart-pane.css: Added.
1529 * public/v2/data.js: Added.
1530 * public/v2/index.html: Added.
1531 * public/v2/js: Added.
1532 * public/v2/js/d3: Added.
1533 * public/v2/js/d3/LICENSE: Added.
1534 * public/v2/js/d3/d3.js: Added.
1535 * public/v2/js/d3/d3.min.js: Added.
1536 * public/v2/js/ember-data.js: Added.
1537 * public/v2/js/ember.js: Added.
1538 * public/v2/js/handlebars.js: Added.
1539 * public/v2/js/jquery.min.js: Added.
1540 * public/v2/js/statistics.js: Added.
1541 * public/v2/manifest.js: Added.
1542 * public/v2/popup.js: Added.
1544 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1546 Remove superfluously duplicated code in public/api/report-commits.php.
1548 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1550 Perf dashboard should store commit logs
1551 https://bugs.webkit.org/show_bug.cgi?id=137510
1553 Reviewed by Darin Adler.
1555 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
1557 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
1558 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
1559 a subversion directory. The git version of this script will be added in a follow up patch.
1562 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
1563 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
1564 relationship via "build_commits" relations.
1566 In order to migrate an existing instance of this application, run the following SQL commands:
1570 INSERT INTO commits (commit_repository, commit_revision, commit_time)
1571 (SELECT DISTINCT ON (revision_repository, revision_value)
1572 revision_repository, revision_value, revision_time FROM build_revisions);
1574 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
1575 FROM commits, build_revisions
1576 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
1578 DROP TABLE build_revisions;
1583 The helper script to submit commit logs can be used as follows:
1585 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
1586 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
1588 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
1589 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
1590 "feeder-slave-password" as the builder name and the builder password respectively.
1592 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
1593 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
1596 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
1598 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
1599 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
1601 - Not specified - It returns every single commit for a given repository.
1602 - Matches "oldest" - It returns the commit with the oldest timestamp.
1603 - Matches "latest" - It returns the commit with the latest timestamp.
1604 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
1605 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
1606 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
1607 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
1608 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
1609 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
1611 (commit_from_revision):
1612 (fetch_commits_between):
1615 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
1616 See tests/api-report-commits.js for examples on how to use this API.
1618 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
1619 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
1620 to optimize this and other JSON APIs.
1622 * public/include/db.php:
1623 (Database::select_or_insert_row):
1624 (Database::update_or_insert_row): Added.
1625 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
1626 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
1628 (Database::select_first_row):
1629 (Database::select_last_row): Added.
1630 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
1631 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
1633 * public/include/report-processor.php:
1634 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
1635 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
1636 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
1639 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
1641 * tests/api-report-commits.js: Added.
1642 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
1645 * tools/pull-svn.py: Added. See above for how to use this script.
1647 (determine_first_revision_to_fetch):
1648 (fetch_revision_from_dasbhoard):
1649 (fetch_commit_and_resolve_author):
1652 (resolve_author_name_from_email):
1655 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
1657 Update Install.md for Mavericks and fix typos
1658 https://bugs.webkit.org/show_bug.cgi?id=137276
1660 Reviewed by Benjamin Poulain.
1662 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
1664 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
1666 Finally, init-database.sql is no longer located inside database directory.
1670 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1672 Report run id's in api/runs.php for the new dashboard UI
1673 https://bugs.webkit.org/show_bug.cgi?id=135813
1675 Reviewed by Andreas Kling.
1677 Include run_id in the generated JSON.
1679 * public/api/runs.php:
1680 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
1683 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1685 Merging platforms mixes baselines and targets into reported data
1686 https://bugs.webkit.org/show_bug.cgi?id=135260
1688 Reviewed by Andreas Kling.
1690 When merging two platforms, move test configurations of a different type (baseline, target)
1691 as well as of different metric (Time, Runs).
1693 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
1694 It's sufficient to detect one such test_runs object.
1696 * public/admin/platforms.php:
1699 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
1701 Merging platforms mixes baselines and targets into reported data
1702 https://bugs.webkit.org/show_bug.cgi?id=135260
1704 Reviewed by Geoffrey Garen.
1706 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
1707 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
1709 * public/admin/platforms.php:
1711 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
1713 Build fix after r171361.
1715 * public/js/helper-classes.js:
1716 (.this.formattedBuildTime):
1718 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
1720 Perf dashboard spends 2s processing JSON data during the page loads
1721 https://bugs.webkit.org/show_bug.cgi?id=135152
1723 Reviewed by Andreas Kling.
1725 In the Apple internal dashboard, we were spending as much as 2 seconds
1726 converting raw JSON data into proper JS objects while loading the dashboard.
1728 This caused the apparent unresponsiveness of the dashboard despite of the fact
1729 charts themselves updated almost instantaneously.
1731 * public/index.html:
1732 * public/js/helper-classes.js:
1733 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
1734 lazily as creating new Date objects and running string replace is expensive.
1735 (TestBuild.formattedTime):
1736 (TestBuild.formattedBuildTime):
1737 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
1738 (PerfTestRuns.addResult): Deleted.
1740 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
1742 Perf dashboard shouldn't show the full git hash
1743 https://bugs.webkit.org/show_bug.cgi?id=135083
1745 Reviewed by Benjamin Poulain.
1747 Detect Git/Mercurial hash by checking the length.
1749 If it's a hash, use the first 8 characters in the label
1750 while retaining the full length to be used in hyperlinks.
1752 * public/js/helper-classes.js:
1753 (.this.formattedRevisions):
1756 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
1758 Add an instruction on how to backup the database.
1759 https://bugs.webkit.org/show_bug.cgi?id=133391
1761 Rubber-stamped by Andreas Kling.
1765 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1767 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
1769 * public/js/helper-classes.js:
1770 (PerfTestRuns.smallerIsBetter):
1772 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1776 * public/common.css:
1778 * public/index.html:
1782 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1784 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
1785 https://bugs.webkit.org/show_bug.cgi?id=131157
1787 Reviewed by Andreas Kling.
1789 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
1790 This allows, for example, adding all metrics such as Arithmetic and Geometric for
1791 a given test suite without also adding its subtests.
1793 * public/index.html:
1797 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1799 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
1800 https://bugs.webkit.org/show_bug.cgi?id=131155
1802 Reviewed by Andreas Kling.
1804 The bug was caused by Chart.attach binding event listeners on plot container on each call.
1805 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
1806 click when attach() has been called even number of times, keeping the tooltip invisible.
1808 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
1809 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
1810 is called for the first time.
1812 * public/index.html:
1814 (Chart..bindPlotEventHandlers):
1816 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1818 WebKitPerfMonitor: Tooltips can be cut off at the top
1819 https://bugs.webkit.org/show_bug.cgi?id=130960
1821 Reviewed by Andreas Kling.
1823 * public/common.css:
1824 (#title): Removed the gradients, box shadows, and border from the header.
1825 (#title h1): Reduce the font size.
1826 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
1827 * public/index.html:
1828 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
1829 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
1830 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
1831 * public/js/helper-classes.js:
1832 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
1833 tooltip extending above y=0.
1835 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1837 WebKitPerfMonitor: Y-axis adjustment is too aggressive
1838 https://bugs.webkit.org/show_bug.cgi?id=130937
1840 Reviewed by Andreas Kling.
1842 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
1843 results. This had two major problems:
1844 1. Two standard deviations can be too small to show the confidence interval for results.
1845 2. Sometimes baseline and target can be more than two standards deviations away.
1847 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
1848 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
1849 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
1850 the margin on each side separately to reduce the empty space on either side.
1852 A more rigorous approach would involve computing least squared value of results with respect to intervals
1853 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
1855 * public/index.html:
1856 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
1857 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
1858 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
1859 We wouldn't see the difference between measured values versus baseline and target values otherwise.
1860 * public/js/helper-classes.js:
1861 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
1862 interval delta cannot be computed.
1863 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
1864 within the given interval.
1865 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
1866 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
1867 (PerfTestRuns..unscaledMeansForAllResults):
1868 (PerfTestRuns.min): Take the confidence interval delta into account.
1869 (PerfTestRuns.max): Ditto.
1870 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
1871 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
1873 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
1875 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
1877 Some CSS tweaks after r166477 and r166479,
1879 * public/index.html:
1881 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1883 WebKitPerfMonitor: Sometimes text inside panes overlap
1884 https://bugs.webkit.org/show_bug.cgi?id=130956
1886 Reviewed by Gyuyoung Kim.
1888 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
1889 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
1890 reduces the total height of the pane and fits more information per screen capita on the dashboard.
1892 * public/index.html: Updated and added a bunch of CSS rules for the new look.
1893 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
1894 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
1895 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
1896 of the build info shown in a chart pane and a tooltip.
1897 (Chart): Made .status a table.
1898 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
1899 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
1900 now that status.text no longer contains it.
1901 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
1903 * public/js/helper-classes.js:
1904 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
1905 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
1906 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
1907 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
1908 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
1909 capital letter; e.g. "MB" instead of "M B".
1911 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1913 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
1914 https://bugs.webkit.org/show_bug.cgi?id=130957
1916 Reviewed by Gyuyoung Kim.
1918 Moved the slider into the header. Also reduced the spacing between the header and platform names.
1919 This reclaims 50px × width of the screen real estate.
1921 * public/common.css:
1922 (#title): Reduced the space below the header from 20px to 10px.
1923 * public/index.html:
1924 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
1925 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
1926 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
1927 real estate between the header and the platform names.
1929 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
1931 Update the install guidelines for perf.webkit.org
1932 https://bugs.webkit.org/show_bug.cgi?id=129895
1934 Reviewed by Ryosuke Niwa.
1936 The current install guideline for perf.webkit.org discourages the use of the installed
1937 Server application. I've actualized the documentation for Mavericks, and modified the
1938 guideline to include the instructions for Server.app also.
1942 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
1944 Update perf.webkit.org json example
1945 https://bugs.webkit.org/show_bug.cgi?id=129907
1947 Reviewed by Andreas Kling.
1949 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
1953 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
1955 Merge database-common.js and utility.js into run-tests.js.
1957 Reviewed by Matthew Hanson.
1959 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
1960 Also moved init-database.sql out of the database directory and removed the directory entirely.
1962 * database: Removed.
1963 * database/database-common.js: Removed.
1964 * database/utility.js: Removed.
1965 * init-database.sql: Moved from database/init-database.sql.
1967 (connect): Moved from database-common.js.
1968 (pathToDatabseSQL): Extracted from pathToLocalScript.
1969 (pathToTests): Moved from database-common.js.
1972 (SerializedTaskQueue): Ditto.
1974 (initializeDatabase):
1975 (TestEnvironment.it):
1976 (TestEnvironment.queryAndFetchAll):
1979 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1981 Remove the dependency on node.js from the production code.
1983 Reviewed by Ricky Mondello.
1985 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
1987 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
1988 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
1989 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
1990 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
1991 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
1993 Also removed the js files that are no longer used.
1995 * config.json: Moved from database/config.json.
1996 * database/aggregate.js: Removed. No longer used.
1997 * database/database-common.js: Removed unused functions, and updated the path to config.json.
1998 * database/process-jobs.js: Removed. No longer used.
1999 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2000 * database/schema.graffle: Removed. It's completely obsolete.
2001 * public/include/db.php: Updated the path to config.json.
2002 * public/include/evaluator.js: Removed.
2004 * public/include/report-processor.php:
2005 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2006 storing values into $expressions and calling evaluate_expressions_by_node.
2007 (TestRunsGenerator::aggregate_values): Added.
2008 (TestRunsGenerator::compute_caches): Directly compute the caches.
2010 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2012 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2014 * public/admin/platforms.php:
2015 * public/include/db.php:
2017 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2019 Zoomed y-axis view is ununsable when the last result is an outlier.
2021 Reviewed by Stephanie Lewis.
2023 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2024 the last result so that the graph looks sane if the last result was an outlier. However, always show
2025 the last result's mean even if it was an outlier.
2027 * public/index.html:
2028 * public/js/helper-classes.js:
2029 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2030 Also added the ability to cache the unscaled means to avoid recomputation.
2031 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2032 (PerfTestRuns.max): Ditto.
2033 (PerfTestRuns.sampleStandardDeviation): Ditto.
2034 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2036 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2040 * public/admin/tests.php:
2041 * public/js/helper-classes.js:
2043 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2045 Use two standard deviations instead as I mentioned in the mailing list.
2047 * public/index.html:
2049 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2051 The performance dashboard erroneously shows upward arrow for combined metrics.
2053 A single outlier can ruin the zoomed y-axis view.
2055 Rubber-stamped by Antti Koivisto.
2057 * public/index.html:
2058 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2059 from the latest results' mean.
2060 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2061 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2062 (Chart.toggleYAxis):
2063 * public/js/helper-classes.js:
2064 (PerfTestRuns.sampleStandardDeviation): Added.
2065 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2067 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2069 Don't include the confidence interval when computing the y-axis.
2071 Rubber-stamped by Simon Fraser.
2073 * public/js/helper-classes.js:
2077 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2079 Tiny CSS tweak for tooltips.
2081 * public/index.html:
2083 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2085 Remove the erroneously repeated code.
2087 * public/admin/test-configurations.php:
2089 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2091 <rdar://problem/15704893> perf dashboard should show baseline numbers
2093 Reviewed by Stephanie Lewis.
2095 * public/admin/bug-trackers.php:
2096 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2099 * public/admin/platforms.php:
2100 (merge_list): Ditto.
2102 * public/admin/test-configurations.php: Added.
2103 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2104 build_revisions as they're not meaningful for baseline / target numbers.
2105 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2106 one test run so that we don't accidentally delete a reported test run.
2107 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2108 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2109 and delete existing ones.
2111 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2112 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2113 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2115 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2116 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2117 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2118 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2119 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2121 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2123 * public/include/admin-header.php:
2124 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2125 have id and type sub columns, and each custom column could generate multiple rows.
2127 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2128 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2129 We then proceed to generate the second header row with sub column names.
2131 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2132 which case regular columns need rowspan set to the maximum number of rows.
2134 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2137 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2138 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2139 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2140 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2141 expanded to occupy all sub columns.
2143 * public/include/manifest.php:
2144 (ManifestGenerator::platforms): Don't add the metric more than once.
2146 * public/include/test-name-resolver.php:
2147 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2148 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2149 full metric name later.
2150 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2151 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2152 (TestNameResolver::full_name_for_test): Added.
2153 (TestNameResolver::full_name_for_metric): Added.
2154 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2156 * public/js/helper-classes.js:
2157 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2158 test runs created to set baseline and target points.
2160 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2162 Build fix after r57928. Removed a superfluous close parenthesis.
2164 * public/api/runs.php:
2166 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2168 Unreviewed build & typo fixes.
2170 * public/admin/platforms.php:
2171 * tests/admin-platforms.js:
2173 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2175 <rdar://problem/15704893> perf dashboard should show baseline numbers
2177 Rubber-stamped by Antti Koivisto.
2179 Organize some code into functions in runs.php.
2181 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2183 * public/api/runs.php:
2184 (fetch_runs_for_config): Extracted.
2185 (format_run): Ditto.
2187 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2189 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2191 * database/config.json:
2192 * public/admin/reprocess-report.php:
2193 * public/api/report.php:
2194 * public/api/runs.php:
2195 * public/include/json-header.php:
2197 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2199 Commit yet another forgotten change.
2201 Something went horribly wrong with my merge :(
2203 * database/init-database.sql:
2205 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2207 Commit one more forgotten change. Sorry for making a mess here.
2209 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2211 Commit the forgotten files.
2213 * public/admin/platforms.php: Added.
2214 * tests/admin-platforms.js: Added.
2216 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2218 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2220 Reviewed by Stephanie Lewis.
2222 Added /admin/platforms/ page to hide and merge platforms.
2224 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2225 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2226 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2227 each test configuration a distinct "test run" for each build.
2229 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2230 their test configurations into platform B.
2232 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2233 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2234 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2235 in platform B, in which case R should relate to T_B instead.
2237 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2238 new platform. We then migrate the test configurations of the remaining test runs.
2240 * database/init-database.sql: Added platform_hidden.
2242 * public/admin/platforms.php: Added.
2243 (merge_platforms): Added. Implements the algorithm described above.
2244 (merge_list): Added.
2246 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2247 is hidden since it doesn't do anything.
2249 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2250 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2251 missing it since unchecked checkbox doesn't set the value in $_POST.
2252 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2253 switch statement instead of repeated if's.
2254 (AdministrativePage::render_table): Emit "update-column" for update_field.
2256 * public/include/db.php: Disable warnings when we're not in the debug mode.
2258 * public/include/manifest.php:
2259 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2262 (TestEnvironment.postJSON):
2263 (TestEnvironment.httpGet):
2264 (TestEnvironment.httpPost): Added.
2265 (sendHttpRequest): Set the content type if specified.
2267 * tests/admin-platforms.js: Added tests.
2269 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2271 Extract the code to compute full test names from tests.php.
2273 Reviewed by Stephanie Lewis.
2275 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2276 and paves our way to re-use the code in other pages.
2278 * public/admin/tests.php:
2280 * public/include/db.php:
2281 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2282 tests.php and test-name-resolver.php.
2284 * public/include/test-name-resolver.php: Added.
2285 (TestNameResolver::__construct):
2286 (TestNameResolver::compute_full_name): Moved from tests.php.
2287 (TestNameResolver::map_metrics_to_tests): Ditto.
2288 (TestNameResolver::sort_tests_by_full_name): Ditto.
2289 (TestNameResolver::tests): Added.
2290 (TestNameResolver::test_id_for_full_name): Ditto.
2291 (TestNameResolver::metrics_for_test_id): Ditto.
2292 (TestNameResolver::child_metrics_for_test_id): Ditto.
2293 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2295 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2297 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2299 Reviewed by Stephanie Lewis.
2301 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2303 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2304 but that's sufficient to correct the wrongfully processed reports for now.
2306 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2307 We should eventually add a nice UI to find and reprocess reports.
2309 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2311 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2313 * public/include/report-processor.php: Copied from public/api/report.php.
2314 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2315 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2316 create a new report or authenticate the builder password (the password is never stored in the report).
2317 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2318 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2319 (ReportProcessor::store_report): Ditto.
2321 * tests/admin-reprocess-report.js: Added.
2323 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2325 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2327 Reviewed by Ricky Mondello.
2329 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2330 for the same build number as a single build by ignoring build time. This was necessary to associate
2331 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2332 we use to submit results computed its own "build time" when they're called.
2334 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2335 last week; new reports were wrongfully associated with old build numbers.
2337 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2338 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2339 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2341 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2342 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2343 (builder, build number, build time).
2345 * public/api/report.php:
2346 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2347 when no such build exists. This prevents a report from being associated with a very old build of the same
2350 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2351 a similar bug in the future sooner.
2353 * tests/api-report.js: Added three test cases.
2355 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2357 Merged the upstream changes to db.php
2358 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2360 * public/include/db.php:
2362 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2364 Update other scripts and tests per previous patch.
2366 * public/include/manifest.php:
2367 * tests/admin-regenerate-manifest.js:
2369 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2371 Remove metrics_unit.
2373 Reviewed by Ricky Mondello.
2375 This column is no longer used by the front-end code since r48360.
2377 * database/init-database.sql:
2378 * public/admin/tests.php:
2380 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2382 Unreviewed build fix.
2384 * public/api/report.php:
2386 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2388 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2390 Reviewed by Ricky Mondello.
2392 Support a new alternative format for aggregated results where we have raw values as well as
2393 the list aggregators so that instead of
2394 "metrics": {"Time": ["Arithmetic"]}
2396 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2398 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2399 dashboard and the generated results page, which doesn't know how to aggregate values.
2401 We need to keep the support for the old format because all other existing performance tests
2402 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2403 the old format during the transition.
2405 * public/api/report.php:
2406 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2407 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2409 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2411 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2413 Unreviewed; Tweak the CSS so that chart panes align vertically.
2415 * public/index.html:
2417 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2419 SafariPerfMonitor should support Combined metric.
2421 * public/js/helper-classes.js:
2422 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2423 value as well but assume it to be greater-is-better for now.
2425 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2427 Commit the forgotten init-database change to add iteration_relative_time.
2429 * database/init-database.sql:
2431 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2433 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2435 Reviewed by Ricky Mondello.
2437 Add the support for each value to have a relative time. This is necessary for frame rate history
2438 since a frame rate needs to be associated with a time it was sampled.
2440 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2442 * public/api/report.php:
2443 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2444 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2445 with relative time since taking the average of two frame rates for two subtests taken at two
2446 different times doesn't make any sense.
2447 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2448 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2449 Also exit early with an error if the number of elements in the array is not a pair.
2450 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2452 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2453 iteration_relative_time.
2455 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2457 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2459 Reviewed by Ricky Mondello.
2461 Support that. It's one line change.
2463 * public/api/report.php:
2464 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2465 to match the convention assumed elsewhere.
2466 * tests/api-report.js: Added a test case.
2468 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2470 SafariPerfMonitor shows popups for points outside of the visible region.
2472 Rubber-stamped by Simon Fraser.
2474 * public/index.html:
2475 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2476 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2477 may return an item underneath y-axis labels.
2479 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2481 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2483 * public/index.html:
2485 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2487 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2489 * public/index.html:
2491 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2493 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2494 <rdar://problem/13992271> Should scale Y axis to include error ranges
2496 Reviewed by Ricky Mondello.
2498 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2499 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2501 * database/config.json:
2502 * public/index.html:
2503 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2504 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2505 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2507 * public/js/helper-classes.js:
2508 (PerfTestResult.confidenceIntervalDelta):
2509 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2510 (PerfTestRuns.min): Take confidence interval delta into account.
2511 (PerfTestRuns.max): Ditto.
2512 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2514 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2516 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2518 * public/api/report.php:
2519 (ReportProcessor::recursively_ensure_tests):
2520 * tests/api-report.js: Added a test.
2522 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2524 Unreviewed build fixes.
2526 * public/api/report.php:
2527 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
2528 Also, tolerate reports without any revision information.
2530 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
2533 * tests/api-report.js: Added few test cases.
2535 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2537 Commit another change that was supposed to be committed in r50331.
2540 (TestEnvironment.this.postJSON):
2541 (TestEnvironment.this.httpGet):
2544 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
2546 Commit the remaining files.
2548 * public/admin/regenerate-manifest.php:
2549 * public/include/admin-header.php:
2550 * public/include/json-header.php:
2551 * public/include/manifest.php:
2553 (TestEnvironment.this.postJSON):
2554 (TestEnvironment.this.httpGet):
2557 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
2559 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
2561 Reviewed by Ricky Mondello.
2563 Added some tests for admin/regenerate-manifest.
2565 * public/admin/regenerate-manifest.php: Use require_once instead of require.
2566 * public/include/admin-header.php: Ditto.
2567 * public/include/json-header.php: Ditto.
2569 * public/include/manifest.php:
2570 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
2571 When there are no builders, simply return an empty array.
2574 (TestEnvironment.postJSON):
2575 (TestEnvironment.httpGet): Added.
2576 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
2578 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
2580 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
2582 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
2583 and run_iterations. Also fixed a typo in report.php found by new tests.
2585 * public/api/report.php:
2586 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
2587 * tests/api-report.js: Added more test cases.
2589 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
2591 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
2593 Reviewed by Ricky Mondello.
2595 Add a test runner script and some simple test cases.
2597 * database/config.json: Added the configuration for "testServer".
2598 * database/database-common.js:
2599 (pathToTests): Added.
2600 * run-tests.js: Added.
2603 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
2604 and if there are, asks the user if it’s okay to delete all of the data contained therein.
2605 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
2607 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
2608 in the current database using PostgreSQL's information_schema.
2609 (askYesOrNoQuestion):
2611 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
2613 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
2614 (TestEnvironment.assert): Exposes assert to tests.
2615 (TestEnvironment.console): Exposes console to tests.
2616 (TestEnvironment.describe): Adds a description.
2617 (TestEnvironment.it): Adds a test case.
2618 (TestEnvironment.postJSON):
2619 (TestEnvironment.queryAndFetchAll):
2620 (TestEnvironment.sha256):
2621 (TestEnvironment.notifyDone): Ends the current test case.
2625 (TestContext): An object created for each test case. Conceptually, this object is always on
2626 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
2627 this object via currentTestContext.
2628 (TestContext.description):
2630 (TestContext.logError):
2633 * tests/api-report.js: Added some basic tests for /api/report.php.
2635 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2637 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
2639 The problem was that we were detecting whether we're updating dashboard or not by checking
2640 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
2641 all configurations. Use separate 'dashboard' action to execute the code even when
2642 metric_configurations is empty.
2644 * public/admin/tests.php:
2646 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2648 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
2650 Reviewed by Ricky Mondello.
2652 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
2653 from ReportProcessor as a preparation to replace deprecated aggregate.js.
2655 * public/api/report.php:
2656 (ReportProcessor::exit_with_error): Moved.
2657 (ReportProcessor::process): Use the extracted TestRunsGenerator.
2658 (TestRunsGenerator): Added.
2659 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
2660 (TestRunsGenerator::add_aggregated_metric): Moved.
2661 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
2662 (TestRunsGenerator::aggregate): Moved. Made public.
2663 (TestRunsGenerator::aggregate_current_test_level): Moved.
2664 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
2665 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
2666 (TestRunsGenerator::compute_caches): Moved. Made public.
2667 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
2668 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
2669 (TestRunsGenerator::rollback_with_error): Moved.
2671 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2673 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
2675 Reviewed by Remy Demarest.
2677 Regenerate the manifest file when updating fields or adding new items that are included in
2680 * public/admin/bug-trackers.php:
2681 * public/admin/builders.php:
2682 * public/admin/regenerate-manifest.php:
2683 * public/admin/repositories.php:
2684 * public/admin/tests.php:
2685 * public/include/admin-header.php:
2686 (regenerate_manifest): Extracted from regenerate-manifest.php.
2688 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2690 Unreviewed build fix for memory test results.
2692 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
2693 aggregating at each level.
2695 * public/api/report.php:
2696 (ReportProcessor::recursively_ensure_tests):
2697 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
2698 (ReportProcessor::add_values_for_aggregation):
2699 (ReportProcessor::aggregate):
2700 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
2702 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
2704 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
2705 not the number of iteration groups. Also, don't set group number when the entire run belongs
2706 a single iteration group.
2708 * public/api/report.php:
2709 (ReportProcessor::commit):
2711 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2713 SafariPerfMonitor: Introduce iteration groups
2715 Reviewed by Remy Demarest.
2717 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
2718 the runtime environment variances to get more stable results. And it's desirable to keep track of
2719 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
2721 This patch introduces "iteration groups" to keep track of this extra information.
2723 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
2724 the outer array denotes iteration groups and each inner array contains iteration values for each group.
2727 * database/init-database.sql: Add iteration_group column.
2728 * public/api/report.php:
2729 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
2731 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
2732 contains the list of values indexed by the iteration order and group sizes. Store the group size so
2733 that we can restore the iteration groups before passing it to node.js and restore them later.
2735 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
2736 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
2738 Also check that each iteration group in each subtest are consistent with one another. To see why we need
2739 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
2740 that each iteration group in T1 and T2 have the same size:
2741 T1 = [[1, 2], [3, 4, 5]]
2742 T2 = [[6, 7], [8, 9, 10]]
2744 so that the aggregated result (the sum in this case) can have the same groups as in:
2745 T = [[7, 9], [11, 13, 15]]
2747 If some iteration groups in T1 and T2 had a different size as in:
2748 T1 = [[1, 2, 3], [4, 5]]
2749 T2 = [[6, 7], [8, 9, 10]]
2751 Then iteration groups of the aggregated T is ambiguous.
2753 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
2754 (ReportProcessor::commit): Store iteration_group values.
2756 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2758 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
2759 migrated to perf.webkit.org.
2761 * database/perf-webkit-migrator.js: Removed.
2763 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2765 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
2767 * public/index.html:
2770 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2772 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
2774 Reviewed by Ricky Mondello.
2776 It is often desirable to see charts of a given test for all platforms, or to be able to see
2777 charts of all subtests on a given platform when trying to triage perf. regressions.
2779 Support this use case by adding the ability to do so on the charts page.
2781 Also, we used to disable items on the test list based on the platform chosen. This turned out
2782 to be a bad UI because in many situations you want to be able to compare results of the same test
2783 on multiple platforms.
2785 In this new UI, we have three select elements, each of which selects the following:
2786 1. Top-level test - Test suite such as Dromaeo
2787 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
2788 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
2789 3. Platform - Mountain Lion, Qt, etc...
2791 A user can select "all" for metric and platform but we disallow doing both at once since adding
2792 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
2793 think of a use case where you want to look at that many charts at once. We can support this later
2794 if valid use cases come up.
2796 * public/index.html:
2797 (.showCharts.addOption): Extracted.
2798 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
2799 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
2800 metricList has onchange handler that enables/disables items on platformList.
2802 (init): Sort tests and test metrics here instead of doing that in showCharts.
2804 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
2806 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
2808 Reviewed by Remy Demarest and Ricky Mondello.
2810 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
2811 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
2812 templates to the manifest file instead. Each build now only contains the builder id.
2814 * public/api/runs.php: Removed the part of the query that joined builders table. This
2815 speeds up the query quite a bit.
2817 * public/include/manifest.php:
2818 (ManifestGenerator::generate): Generate builders field.
2819 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
2820 associative array that contains name and its build URL template.
2822 * public/index.html:
2823 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
2824 instead of a revision since this function is used for revisions and build page URLs now.
2825 (.buildLabelWithLinks): Include the linkified build number.
2827 * public/js/helper-classes.js:
2828 (TestBuild.builder): Added.
2829 (TestBuild.buildNumber): Added.
2830 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
2831 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
2833 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
2835 Tooltips interfere with user interactions
2837 Rubber-stamped by Simon Fraser.
2839 Disable tooltip on the dashboard page since graphs are too small to be useful there.
2840 Also, show graphs for only 10 days by default as opposed to 20.
2841 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
2843 * public/index.html:
2844 * public/js/helper-classes.js:
2846 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
2848 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
2849 to be compatible with webkit-perf.appspot.com.
2851 * public/admin/builders.php:
2852 * public/api/report.php:
2854 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
2858 Add a missing constraint on builds table. For a given builder, there should be exactly
2859 one build for a given build number.
2861 Also add report_committed_at to reports table to record the time at which a given report
2862 was processed and test_runs and run_iterations rows were committed into the database.
2864 * database/config.json:
2865 * public/api/report.php:
2867 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
2869 Unreviewed. Add more checks for empty SQL query results.
2871 * public/include/manifest.php:
2873 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2875 More build fixes on perf.webkit.org.
2877 * public/api/runs.php: Make PostgreSQL happier.
2878 * public/include/manifest.php: Don't assume we always have bug trackers.
2880 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2882 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
2883 and fix other miscellaneous UI bugs.
2885 Rubber-stamped by Simon Fraser.
2887 Removed the code to determine whether smaller value is better or not for a given test in index.html
2888 in the favor of using that of PerfTestRuns.
2890 * public/include/manifest.php: Fixed a typo.
2891 * public/index.html:
2893 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
2895 * public/js/helper-classes.js:
2896 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
2898 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
2899 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
2900 at roughly 2,000 units to avoid this.
2902 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
2903 The only thing we can avoid is innerHTML.
2905 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2907 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
2909 * public/include/evaluator.js:
2911 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2913 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
2915 Reviewed by Remy Demarest.
2917 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
2918 admin/bug-trackers.php and can be associated with multiple repositories.
2920 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
2921 to determine the set of bug trackers to show for a given set of blame lists.
2922 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
2923 a place to file bugs against the regression.
2925 * database/init-database.sql: Added bug_trackers and tracker_repositories.
2926 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
2928 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
2929 bug trackers, namely associated repositories.
2931 * public/include/admin-header.php: Added a link to bug-trackers.php
2932 * public/include/manifest.php:
2933 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
2934 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
2936 (ManifestGenerator::repositories):
2938 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
2939 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
2940 'repositories' where the latter contains the list of associated repository names.
2942 * public/index.html:
2943 (Chart): Takes bugTrackers as as argument.
2944 (Chart.showTooltipWithResults): Removed the hard-coded list.
2946 (init.addPlatformsToDashboard):
2947 (init.showCharts.createChartFromListPair):
2948 (init): Stores the list of bug trackers in the manifest to a local variable.
2950 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2952 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
2954 * public/include/evaluator.js:
2956 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2958 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
2960 Reviewed by Remy Demarest.
2962 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
2963 new row into the database.
2965 * public/admin/aggregators.php: Use AdministrativePage.
2966 * public/admin/builders.php: Ditto.
2967 * public/admin/repositories.php: Ditto.
2968 * public/include/admin-header.php:
2969 (AdministrativePage): Added.
2970 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
2971 to an associative array that describes the column.
2972 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
2973 - label: Human readable name of the column.
2974 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
2975 column exists only before we create password_hash column at the insertion time.
2977 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
2978 titlecase (e.g. new_bug is converted to New Bug).
2979 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
2980 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
2981 textarea for a given editing mode ('text', 'url', or 'string').
2982 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
2983 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
2985 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
2987 Build fix. Some systems don't support r+. Use proc_open instead.
2989 * public/api/report.php:
2991 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2993 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
2994 when computing the y-axis of data points to show tooltips at.
2996 * public/index.html:
2998 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3000 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
3003 * public/.htaccess: Removed.
3005 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
3009 * public/include/manifest.php: Build fix. db is on this.
3010 * public/js/statistics.js:
3011 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
3013 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
3015 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
3017 Reviewed by Anders Carlsson.
3019 Rewrote and merged populate-from-report.js into report.php.
3021 * database/config.json: Added a path to node.js.
3023 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
3024 Once we land this patch and update the administrative pages, we can remove this column.
3026 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
3027 that table is going away once we remove the node.js backend.
3029 * database/populate-from-report.js: Removed.
3030 * public/api/report.php: Added.
3032 (ReportProcessor.__construct):
3033 (ReportProcessor.process):
3035 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
3036 verified to be submitted by a known builder.
3038 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
3039 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
3040 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
3041 inside a transaction because there could be multiple reports for a single build, each containing results for
3044 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
3045 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
3046 add_values_to_commit, and add_values_for_aggregation.
3048 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
3049 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
3050 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
3053 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
3054 to be aggregated in ReportProcessor.aggregate.
3056 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
3058 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
3059 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
3060 given for each row (child metrics of M). This function extracts each column (iteration) via
3061 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
3062 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
3064 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
3065 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
3066 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
3068 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
3069 (ReportProcessor.evaluate_expressions_by_node): See above.
3071 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
3072 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
3073 results also need the said caches.
3075 (ReportProcessor.add_values_to_commit):
3077 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
3078 the transaction as needed if anything goes wrong.
3080 (ReportProcessor.rollback_with_error)
3082 * public/include/db.php:
3083 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
3084 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
3085 contiguously in a SQL statement.
3087 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
3088 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
3089 a column value of the choice.
3091 (Database.begin_transaction): Added.
3092 (Database.commit_transaction): Added.
3093 (Database.rollback_transaction): Added.
3095 * public/include/evaluator.js: Added.
3096 * public/include/json-header.php:
3097 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
3098 context under which the request failed.
3099 (successful_exit): Merge "additional details".
3100 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
3101 (merge_additional_details):
3103 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
3105 SafariPerfMonitor: Add more helper functions to db.php
3107 Reviewed by Remy Demarest.
3109 Added Database::insert_row and array_get to make common database operations easier.
3111 * public/admin/aggregators.php: Use Database::insert_row instead of
3112 execute_query_and_expect_one_row_to_be_affected.
3114 * public/admin/builders.php: Ditto.
3116 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
3117 inserting a row. With insert_row, we don't need that.
3119 * public/include/admin-header.php: Ditto.
3121 * public/include/db.php:
3122 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
3123 return the default value (defaults to NULL) if the key doesn't exist.
3125 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
3128 (Database::prepare_params): Added. Takes an associative array of column names and their values,
3129 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
3130 column names all in the same order.
3132 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
3133 the given prefix. Values are given in a form of an associative array where keys are unprefixed
3134 column names and values are corresponding values. When the row is successfully inserted, it returns
3135 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
3136 indicating the success of the insertion.
3138 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3140 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
3142 Reviewed by Conrad Shultz.
3144 Rewrote the manifest generator in PHP.
3146 * database/generate-manifest.js: Removed.
3147 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
3148 * public/include/db.php:
3149 (array_ensure_item_has_array): Added.
3150 * public/include/evaluator.js: Added.
3151 * public/include/json-header.php:
3152 * public/include/manifest.php: Added.
3154 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3156 Dates on overflow plot are overlapping
3158 Rubber-stamped by Simon Fraser.
3160 Don't show more than 5 days.
3162 * public/index.html:
3163 * public/js/helper-classes.js:
3164 (TestBuild.UTCtoPST):
3167 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3169 Show build time as well as commit time on the dashboard and tooltips.
3171 Rubber-stamped by Simon Fraser.
3173 Include both the maximum commit time and build time in buildLabelWithLinks.
3174 Also use ISO format to save the screen real estate.
3176 * public/index.html:
3177 (buildLabelWithLinks):
3178 * public/js/helper-classes.js:
3180 (TestBuild.buildTime):
3181 (TestBuild.formattedBuildTime):
3183 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
3185 Unreviewed; Convert metric.name to metric.unit in the front end.
3187 * public/js/helper-classes.js:
3189 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3191 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
3193 Rubber-stamped by Simon Fraser.
3195 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
3196 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
3197 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
3199 * public/index.html:
3200 (.buildLabelWithLinks): Extracted from TestBuild.label.
3201 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
3202 on Radar and WebKit Bugzilla.
3203 * public/js/helper-classes.js:
3204 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
3205 (PerfTestResult.isBetterThan): Added.
3206 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
3207 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
3208 to indicate progressions or regressions.
3209 (PerfTestResult.label):
3210 (TestBuild.formattedTime): Added.
3211 (TestBuild.platform): Added.
3212 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
3213 (TestBuild.smallerIsBetter): Added.
3214 (Tooltip.show): Take a raw markup instead of two results.
3216 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
3218 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
3220 Rubber-stamped by Tim Horton.
3222 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
3223 since each platform may have a different number of tests to be shown on the dashboard.
3225 * public/index.html:
3227 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3229 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
3231 * public/js/helper-classes.js:
3234 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3236 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
3238 Rubber-stamped by Tim Horton.
3240 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
3242 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
3243 the revision r1234 was the revision used in the previous build.
3245 * public/api/runs.php:
3246 (parse_revisions_array): Trim double quotations around repository names and revisions.
3247 * public/js/helper-classes.js:
3250 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3252 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
3254 Rubber-stamped by Tim Horton.
3256 * public/index.html:
3257 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
3258 on the dashboard page as it's way too noisy.
3260 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
3262 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
3263 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
3264 so that the tooltip for hover can be reused further.
3266 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
3267 and find the first point that lies on the right of the cursor position. We then compute the midpoint
3268 between this and the previous point and pick the closer of the two. It returns an item-like object
3269 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
3271 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
3273 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
3274 the first or "current" data points (as opposed to target or baseline data points).
3276 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
3277 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
3278 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
3280 * public/js/helper-classes.js:
3281 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
3282 work to the client via bindClick.
3284 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
3286 (Tooltip.bindClick): Added.
3288 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3290 Yet another build fix. metricId*s*.
3292 * public/admin/tests.php:
3294 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3296 Another build fix. Use the new payload format for the aggregate job.
3298 * public/admin/tests.php:
3300 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3304 * database/aggregate.js: Use variables that actually exist.
3305 * database/database-common.js:
3306 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
3307 function calls will find this configuration.
3309 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3311 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
3313 Reviewed by Ricky Mondello.
3315 Turned InstallManual into a proper markdown document and added ReadMe.md.
3317 * InstallManual: Removed.
3318 * InstallManual.md: Moved from InstallManual.
3321 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3323 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
3325 Reviewed by Ricky Mondello.
3327 This patch prepares the front end code to process baseline and target results properly.
3329 * public/index.html:
3330 (fetchTest.createRunAndResults): Extracted.
3331 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
3332 Deleted the comment about how sorting will be unnecessary once we start results in the server side
3333 since sorting by the maximum revision commit time turned out to be non-trivial in php.
3335 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3337 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
3339 Reviewed by Tim Horton.
3341 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
3342 These files are "dynamically linked" to our app.
3344 * public/index.html:
3345 * public/js/jquery-1.8.2.min.js: Removed.
3346 * public/js/jquery.colorhelpers.js: Added.
3347 * public/js/jquery.flot.categories.js: Added.
3348 * public/js/jquery.flot.crosshair.js: Added.
3349 * public/js/jquery.flot.errorbars.js: Added.
3350 * public/js/jquery.flot.fillbetween.js: Added.
3351 * public/js/jquery.flot.js: Added.
3352 * public/js/jquery.flot.min.js: Removed.
3353 * public/js/jquery.flot.navigate.js: Added.
3354 * public/js/jquery.flot.resize.js: Added.
3355 * public/js/jquery.flot.selection.js: Added.
3356 * public/js/jquery.flot.stack.js: Added.
3357 * public/js/jquery.flot.symbol.js: Added.
3358 * public/js/jquery.flot.threshold.js: Added.
3359 * public/js/jquery.flot.time.js: Added.
3360 * public/js/jquery.js: Added.
3362 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3364 Return NaN instead of throwing when there aren't enough samples.
3366 Reviewed by Sam Weinig.
3368 It's better to return NaN when we don't have enough samples so that we can treat it
3369 as if we don't have any confidence interval.
3371 * public/js/statistics.js:
3374 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3376 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
3378 * public/js/helper-classes.js:
3379 (URLState.parseIfNeeded):
3381 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3383 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
3385 Reviewed by Ricky Mondello.
3387 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
3389 * public/admin/aggregators.php: Use heredoc.
3390 * public/admin/builders.php:
3391 * public/admin/jobs.php:
3392 * public/admin/repositories.php:
3393 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
3394 This allows us to use update_field when updating test's url and metric's unit. Changed the action
3395 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
3396 Also removed a stray code to update unit and url simultaneously since it's never used.
3397 * public/include/admin-header.php:
3398 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
3399 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
3400 (update_field): Moved from repositories.php.
3402 * public/include/db.php:
3403 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
3405 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
3407 Build fixes. Treat mean, sum, and square sum as float, not int.
3409 Also use 95% confidence interval instead of 90% confidence interval.
3411 * public/api/runs.php:
3412 * public/js/helper-classes.js:
3413 (.this.confidenceIntervalDelta):
3415 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
3417 Add an administrative page to edit repository information.
3419 Reviewed by Ricky Mondello.
3421 * public/admin/repositories.php: Added.
3422 * public/include/admin-header.php:
3424 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
3426 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
3428 Reviewed by Ricky Mondello.
3430 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
3431 to aggregate results for those matrix in populate-from-report.js.
3433 * database/generate-manifest.js:
3434 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
3435 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
3436 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
3437 * database/populate-from-report.js:
3439 (getReport): No change even though the diff looks as if it moved.
3440 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
3441 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
3442 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
3443 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
3444 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
3446 (ensureMetricId): Take an aggregator id as an argument.
3447 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
3448 for all builds when the build id is not specified.
3449 * public/admin/tests.php:
3450 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
3451 of the same name with different aggregators.
3453 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
3455 Build fix. Don't pass in arguments to in the wrong order.
3457 * database/aggregate.js:
3459 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3461 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
3463 Reviewed by Ricky Mondello.
3465 Since the version of flot we use doesn't support showing graphs in the current locate or
3466 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
3467 treat them as in UTC). We don't want to use the current locate because other websites on
3468 webkit.org assume PST.
3470 Also append this information to build's label.
3472 * public/js/helper-classes.js:
3476 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3478 Store test URLs reported by builders.
3480 Reviewed by Ricky Mondello.
3482 * database/populate-from-report.js:
3483 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
3484 (ensureTestId): Store the URL.
3486 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
3488 Yet another build fix; don't blow up even if we didn't have any test configurations.
3490 * public/admin/tests.php:
3492 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3494 Build fix; don't instantiate Date when a timestamp wasn't provided.
3496 * database/populate-from-report.js:
3498 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
3500 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
3502 Reviewed by Tim Horton.
3504 Added an install manual.
3506 * InstallManual: Added.
3508 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
3510 Minor build fix. Don't unset builderPassword when it's not set.
3512 * public/api/report.php:
3514 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3516 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
3518 Reviewed by Ricky Mondello.
3520 * public/admin/admin.css: Make a very large payload scrollable.
3521 * public/admin/jobs.php: Format JSONs.
3523 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
3525 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
3527 Reviewed by Ricky Mondello.
3529 Add report.php and populate-from-report.js that process JSON files submitted by builders.
3531 * database/populate-from-report.js: Added.
3533 (getReport): Obtains the payload (the actual report) from "jobs" table.
3534 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
3535 and their results. This function recursively traverses tests and metrics and ensure their ids.
3537 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
3538 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
3539 is a "function" in mathematical sense).
3541 (ensureRepositoryIdsForAllRevisions):
3542 (getIdOrCreateBuildWithRevisions):
3543 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
3544 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
3545 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
3547 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
3548 test results all in a single transaction. This allows us to keep the database consistent in that either
3549 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
3550 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
3551 other parts of the application are concerned.
3552 (scheduleQueriesToInsertRun):
3553 * database/process-jobs.js: Add a call to populate-from-report.js.
3554 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
3555 * public/include/db.php: Support parameterized query.
3556 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
3557 a test result could confirm that the submission indeed succeeded.
3559 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3561 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
3563 * database/aggregate.js:
3564 * database/database-common.js:
3565 (selectColumnCreatingRowIfNeeded):
3566 (ensureRepositoryId):
3567 (ensureConfigurationIdFromList):
3568 * database/perf-webkit-migrator.js:
3571 (getOrCreateBuildId):
3573 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
3575 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
3577 Reviewed by Ricky Mondello.
3579 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
3580 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
3582 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
3585 (saveAggregatedResults):
3586 * database/database-common.js:
3587 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
3588 (getIdOrCreateRepository): Ditto.
3589 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
3590 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
3591 * database/perf-webkit-migrator.js:
3592 * database/utility.js: Added.
3593 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
3594 from being executed.
3595 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
3596 call the callback passed into start().
3597 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
3598 (TaskQueue.addTask):
3600 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
3601 (SerializedTaskQueue.executeNextTask):
3602 (SerializedTaskQueue.addTask):
3603 (SerializedTaskQueue.start):
3605 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3607 Revert erroneously committed changes.
3609 * database/config.json:
3611 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3613 aggregator.js should be able to accept multiple metric ids and a single build id.
3615 Reviewed by Ricky Mondello.
3617 Make aggregator.js accept multiple ids and generate results for single build when bots are
3618 reporting new results.
3620 * database/aggregate.js:
3621 (parseArgv): Added. Returns an object containing the parsed representation of argv,
3622 which currently contains metricIDs and buildIds.
3623 (main): Use parseArgv and processConfigurations
3624 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
3625 (processPlatform.processConfigurations): Extracted.
3627 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
3629 Add an administrative page for builders.
3631 Reviewed by Ricky Mondello.
3633 We need an administrative page to add and edit builder information.
3634 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
3636 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
3637 since we don't have plans to use those columns in near future. Also make builder_name unique
3638 as required by the rest of the app.
3639 * public/admin/builders.php: Added.
3640 * public/api/runs.php: Updated per the table rename.
3641 * public/include/admin-header.php: Added a link to builders.php.
3643 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
3645 Build fixes for r46982.
3647 * database/aggregate.js:
3648 (fetchConfigurations): Bind i so that it's not always metricIds.length.
3649 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
3650 (processBuild): Don't print "." until we've committed transactions. It's misleading.
3652 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
3654 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
3656 * public/admin/aggregators.php:
3657 * public/admin/footer.php: Removed.
3658 * public/admin/header.php: Removed.
3659 * public/admin/index.php:
3660 * public/admin/jobs.php:
3661 * public/admin/tests.php:
3662 * public/api/json-header.php: Removed.
3663 * public/api/runs.php:
3664 * public/db.php: Removed.
3665 * public/include: Added.
3666 * public/include/admin-footer.php: Copied from public/admin/footer.php.
3667 * public/include/admin-header.php: Copied from public/admin/header.php.
3668 * public/include/db.php: Copied from public/db.php.
3669 * public/include/json-header.php: Copied from public/api/json-header.php.
3671 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
3673 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
3675 Reviewed by Ricky Mondello.
3677 Added the initial implementation of value aggregation.
3678 Also added abilities to configure the dashboard page in tests.php.
3680 * database/aggregate.js: Added.
3681 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
3682 (TaskQueue.addTask):
3684 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
3685 (SerializedTaskQueue.addTask):
3686 (SerializedTaskQueue.start):
3689 (fetchConfigurations):
3690 (fetchBuildsForPlatform):
3692 (testsWithDifferentIterationCounts):
3693 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
3694 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
3695 (getOrInsertConfiguration):
3697 * database/database-common.js:
3698 (fetchTable): Log an error as an error.
3699 (getOrCreateId): Extracted from perf-webkit-migrator.
3700 (statistics): Added.
3701 * database/perf-webkit-migrator.js:
3702 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
3703 runs JSON since runs JSONs are generated on demand now.
3705 (getOrCreatePlatformId):
3706 (getOrCreateTestId):
3707 (getOrCreateConfigurationId):