1 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
3 Merging platforms mixes baselines and targets into reported data
4 https://bugs.webkit.org/show_bug.cgi?id=135260
6 Reviewed by Andreas Kling.
8 When merging two platforms, move test configurations of a different type (baseline, target)
9 as well as of different metric (Time, Runs).
11 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
12 It's sufficient to detect one such test_runs object.
14 * public/admin/platforms.php:
17 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
19 Merging platforms mixes baselines and targets into reported data
20 https://bugs.webkit.org/show_bug.cgi?id=135260
22 Reviewed by Geoffrey Garen.
24 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
25 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
27 * public/admin/platforms.php:
29 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
31 Build fix after r171361.
33 * public/js/helper-classes.js:
34 (.this.formattedBuildTime):
36 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
38 Perf dashboard spends 2s processing JSON data during the page loads
39 https://bugs.webkit.org/show_bug.cgi?id=135152
41 Reviewed by Andreas Kling.
43 In the Apple internal dashboard, we were spending as much as 2 seconds
44 converting raw JSON data into proper JS objects while loading the dashboard.
46 This caused the apparent unresponsiveness of the dashboard despite of the fact
47 charts themselves updated almost instantaneously.
50 * public/js/helper-classes.js:
51 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
52 lazily as creating new Date objects and running string replace is expensive.
53 (TestBuild.formattedTime):
54 (TestBuild.formattedBuildTime):
55 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
56 (PerfTestRuns.addResult): Deleted.
58 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
60 Perf dashboard shouldn't show the full git hash
61 https://bugs.webkit.org/show_bug.cgi?id=135083
63 Reviewed by Benjamin Poulain.
65 Detect Git/Mercurial hash by checking the length.
67 If it's a hash, use the first 8 characters in the label
68 while retaining the full length to be used in hyperlinks.
70 * public/js/helper-classes.js:
71 (.this.formattedRevisions):
74 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
76 Add an instruction on how to backup the database.
77 https://bugs.webkit.org/show_bug.cgi?id=133391
79 Rubber-stamped by Andreas Kling.
83 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
85 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
87 * public/js/helper-classes.js:
88 (PerfTestRuns.smallerIsBetter):
90 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
100 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
102 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
103 https://bugs.webkit.org/show_bug.cgi?id=131157
105 Reviewed by Andreas Kling.
107 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
108 This allows, for example, adding all metrics such as Arithmetic and Geometric for
109 a given test suite without also adding its subtests.
115 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
117 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
118 https://bugs.webkit.org/show_bug.cgi?id=131155
120 Reviewed by Andreas Kling.
122 The bug was caused by Chart.attach binding event listeners on plot container on each call.
123 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
124 click when attach() has been called even number of times, keeping the tooltip invisible.
126 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
127 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
128 is called for the first time.
132 (Chart..bindPlotEventHandlers):
134 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
136 WebKitPerfMonitor: Tooltips can be cut off at the top
137 https://bugs.webkit.org/show_bug.cgi?id=130960
139 Reviewed by Andreas Kling.
142 (#title): Removed the gradients, box shadows, and border from the header.
143 (#title h1): Reduce the font size.
144 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
146 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
147 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
148 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
149 * public/js/helper-classes.js:
150 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
151 tooltip extending above y=0.
153 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
155 WebKitPerfMonitor: Y-axis adjustment is too aggressive
156 https://bugs.webkit.org/show_bug.cgi?id=130937
158 Reviewed by Andreas Kling.
160 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
161 results. This had two major problems:
162 1. Two standard deviations can be too small to show the confidence interval for results.
163 2. Sometimes baseline and target can be more than two standards deviations away.
165 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
166 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
167 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
168 the margin on each side separately to reduce the empty space on either side.
170 A more rigorous approach would involve computing least squared value of results with respect to intervals
171 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
174 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
175 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
176 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
177 We wouldn't see the difference between measured values versus baseline and target values otherwise.
178 * public/js/helper-classes.js:
179 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
180 interval delta cannot be computed.
181 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
182 within the given interval.
183 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
184 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
185 (PerfTestRuns..unscaledMeansForAllResults):
186 (PerfTestRuns.min): Take the confidence interval delta into account.
187 (PerfTestRuns.max): Ditto.
188 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
189 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
191 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
193 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
195 Some CSS tweaks after r166477 and r166479,
199 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
201 WebKitPerfMonitor: Sometimes text inside panes overlap
202 https://bugs.webkit.org/show_bug.cgi?id=130956
204 Reviewed by Gyuyoung Kim.
206 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
207 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
208 reduces the total height of the pane and fits more information per screen capita on the dashboard.
210 * public/index.html: Updated and added a bunch of CSS rules for the new look.
211 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
212 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
213 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
214 of the build info shown in a chart pane and a tooltip.
215 (Chart): Made .status a table.
216 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
217 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
218 now that status.text no longer contains it.
219 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
221 * public/js/helper-classes.js:
222 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
223 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
224 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
225 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
226 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
227 capital letter; e.g. "MB" instead of "M B".
229 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
231 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
232 https://bugs.webkit.org/show_bug.cgi?id=130957
234 Reviewed by Gyuyoung Kim.
236 Moved the slider into the header. Also reduced the spacing between the header and platform names.
237 This reclaims 50px × width of the screen real estate.
240 (#title): Reduced the space below the header from 20px to 10px.
242 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
243 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
244 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
245 real estate between the header and the platform names.
247 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
249 Update the install guidelines for perf.webkit.org
250 https://bugs.webkit.org/show_bug.cgi?id=129895
252 Reviewed by Ryosuke Niwa.
254 The current install guideline for perf.webkit.org discourages the use of the installed
255 Server application. I've actualized the documentation for Mavericks, and modified the
256 guideline to include the instructions for Server.app also.
260 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
262 Update perf.webkit.org json example
263 https://bugs.webkit.org/show_bug.cgi?id=129907
265 Reviewed by Andreas Kling.
267 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
271 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
273 Merge database-common.js and utility.js into run-tests.js.
275 Reviewed by Matthew Hanson.
277 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
278 Also moved init-database.sql out of the database directory and removed the directory entirely.
281 * database/database-common.js: Removed.
282 * database/utility.js: Removed.
283 * init-database.sql: Moved from database/init-database.sql.
285 (connect): Moved from database-common.js.
286 (pathToDatabseSQL): Extracted from pathToLocalScript.
287 (pathToTests): Moved from database-common.js.
290 (SerializedTaskQueue): Ditto.
292 (initializeDatabase):
293 (TestEnvironment.it):
294 (TestEnvironment.queryAndFetchAll):
297 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
299 Remove the dependency on node.js from the production code.
301 Reviewed by Ricky Mondello.
303 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
305 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
306 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
307 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
308 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
309 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
311 Also removed the js files that are no longer used.
313 * config.json: Moved from database/config.json.
314 * database/aggregate.js: Removed. No longer used.
315 * database/database-common.js: Removed unused functions, and updated the path to config.json.
316 * database/process-jobs.js: Removed. No longer used.
317 * database/sample-data.sql: Removed. We have a much better corpus of data now.
318 * database/schema.graffle: Removed. It's completely obsolete.
319 * public/include/db.php: Updated the path to config.json.
320 * public/include/evaluator.js: Removed.
322 * public/include/report-processor.php:
323 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
324 storing values into $expressions and calling evaluate_expressions_by_node.
325 (TestRunsGenerator::aggregate_values): Added.
326 (TestRunsGenerator::compute_caches): Directly compute the caches.
328 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
330 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
332 * public/admin/platforms.php:
333 * public/include/db.php:
335 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
337 Zoomed y-axis view is ununsable when the last result is an outlier.
339 Reviewed by Stephanie Lewis.
341 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
342 the last result so that the graph looks sane if the last result was an outlier. However, always show
343 the last result's mean even if it was an outlier.
346 * public/js/helper-classes.js:
347 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
348 Also added the ability to cache the unscaled means to avoid recomputation.
349 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
350 (PerfTestRuns.max): Ditto.
351 (PerfTestRuns.sampleStandardDeviation): Ditto.
352 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
354 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
358 * public/admin/tests.php:
359 * public/js/helper-classes.js:
361 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
363 Use two standard deviations instead as I mentioned in the mailing list.
367 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
369 The performance dashboard erroneously shows upward arrow for combined metrics.
371 A single outlier can ruin the zoomed y-axis view.
373 Rubber-stamped by Antti Koivisto.
376 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
377 from the latest results' mean.
378 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
379 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
381 * public/js/helper-classes.js:
382 (PerfTestRuns.sampleStandardDeviation): Added.
383 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
385 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
387 Don't include the confidence interval when computing the y-axis.
389 Rubber-stamped by Simon Fraser.
391 * public/js/helper-classes.js:
395 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
397 Tiny CSS tweak for tooltips.
401 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
403 Remove the erroneously repeated code.
405 * public/admin/test-configurations.php:
407 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
409 <rdar://problem/15704893> perf dashboard should show baseline numbers
411 Reviewed by Stephanie Lewis.
413 * public/admin/bug-trackers.php:
414 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
417 * public/admin/platforms.php:
420 * public/admin/test-configurations.php: Added.
421 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
422 build_revisions as they're not meaningful for baseline / target numbers.
423 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
424 one test run so that we don't accidentally delete a reported test run.
425 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
426 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
427 and delete existing ones.
429 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
430 on each platform; there could be configurations of distinct types such as "current" and "baseline".
431 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
433 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
434 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
435 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
436 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
437 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
439 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
441 * public/include/admin-header.php:
442 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
443 have id and type sub columns, and each custom column could generate multiple rows.
445 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
446 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
447 We then proceed to generate the second header row with sub column names.
449 When generating the actual content, we first generate all custom columns as they may have multiple rows in
450 which case regular columns need rowspan set to the maximum number of rows.
452 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
455 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
456 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
457 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
458 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
459 expanded to occupy all sub columns.
461 * public/include/manifest.php:
462 (ManifestGenerator::platforms): Don't add the metric more than once.
464 * public/include/test-name-resolver.php:
465 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
466 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
467 full metric name later.
468 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
469 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
470 (TestNameResolver::full_name_for_test): Added.
471 (TestNameResolver::full_name_for_metric): Added.
472 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
474 * public/js/helper-classes.js:
475 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
476 test runs created to set baseline and target points.
478 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
480 Build fix after r57928. Removed a superfluous close parenthesis.
482 * public/api/runs.php:
484 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
486 Unreviewed build & typo fixes.
488 * public/admin/platforms.php:
489 * tests/admin-platforms.js:
491 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
493 <rdar://problem/15704893> perf dashboard should show baseline numbers
495 Rubber-stamped by Antti Koivisto.
497 Organize some code into functions in runs.php.
499 Also added back $paths that was erroneously removed in r57925 from json-header.php.
501 * public/api/runs.php:
502 (fetch_runs_for_config): Extracted.
505 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
507 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
509 * database/config.json:
510 * public/admin/reprocess-report.php:
511 * public/api/report.php:
512 * public/api/runs.php:
513 * public/include/json-header.php:
515 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
517 Commit yet another forgotten change.
519 Something went horribly wrong with my merge :(
521 * database/init-database.sql:
523 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
525 Commit one more forgotten change. Sorry for making a mess here.
527 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
529 Commit the forgotten files.
531 * public/admin/platforms.php: Added.
532 * tests/admin-platforms.js: Added.
534 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
536 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
538 Reviewed by Stephanie Lewis.
540 Added /admin/platforms/ page to hide and merge platforms.
542 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
543 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
544 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
545 each test configuration a distinct "test run" for each build.
547 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
548 their test configurations into platform B.
550 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
551 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
552 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
553 in platform B, in which case R should relate to T_B instead.
555 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
556 new platform. We then migrate the test configurations of the remaining test runs.
558 * database/init-database.sql: Added platform_hidden.
560 * public/admin/platforms.php: Added.
561 (merge_platforms): Added. Implements the algorithm described above.
564 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
565 is hidden since it doesn't do anything.
567 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
568 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
569 missing it since unchecked checkbox doesn't set the value in $_POST.
570 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
571 switch statement instead of repeated if's.
572 (AdministrativePage::render_table): Emit "update-column" for update_field.
574 * public/include/db.php: Disable warnings when we're not in the debug mode.
576 * public/include/manifest.php:
577 (ManifestGenerator::platforms): Skip platforms that have been hidden.
580 (TestEnvironment.postJSON):
581 (TestEnvironment.httpGet):
582 (TestEnvironment.httpPost): Added.
583 (sendHttpRequest): Set the content type if specified.
585 * tests/admin-platforms.js: Added tests.
587 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
589 Extract the code to compute full test names from tests.php.
591 Reviewed by Stephanie Lewis.
593 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
594 and paves our way to re-use the code in other pages.
596 * public/admin/tests.php:
598 * public/include/db.php:
599 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
600 tests.php and test-name-resolver.php.
602 * public/include/test-name-resolver.php: Added.
603 (TestNameResolver::__construct):
604 (TestNameResolver::compute_full_name): Moved from tests.php.
605 (TestNameResolver::map_metrics_to_tests): Ditto.
606 (TestNameResolver::sort_tests_by_full_name): Ditto.
607 (TestNameResolver::tests): Added.
608 (TestNameResolver::test_id_for_full_name): Ditto.
609 (TestNameResolver::metrics_for_test_id): Ditto.
610 (TestNameResolver::child_metrics_for_test_id): Ditto.
611 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
613 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
615 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
617 Reviewed by Stephanie Lewis.
619 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
621 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
622 but that's sufficient to correct the wrongfully processed reports for now.
624 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
625 We should eventually add a nice UI to find and reprocess reports.
627 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
629 * public/include/db.php: Added the forgotten call to prefixed_column_names.
631 * public/include/report-processor.php: Copied from public/api/report.php.
632 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
633 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
634 create a new report or authenticate the builder password (the password is never stored in the report).
635 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
636 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
637 (ReportProcessor::store_report): Ditto.
639 * tests/admin-reprocess-report.js: Added.
641 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
643 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
645 Reviewed by Ricky Mondello.
647 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
648 for the same build number as a single build by ignoring build time. This was necessary to associate
649 multiple reports by a single build - e.g. for different performance test suites - because the scripts
650 we use to submit results computed its own "build time" when they're called.
652 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
653 last week; new reports were wrongfully associated with old build numbers.
655 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
656 to the same build. Instead, we create a new build object for those reports. Since the longest set of
657 tests we have only take a couple of hours to run, 24 hours should be more than enough.
659 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
660 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
661 (builder, build number, build time).
663 * public/api/report.php:
664 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
665 when no such build exists. This prevents a report from being associated with a very old build of the same
668 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
669 a similar bug in the future sooner.
671 * tests/api-report.js: Added three test cases.
673 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
675 Merged the upstream changes to db.php
676 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
678 * public/include/db.php:
680 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
682 Update other scripts and tests per previous patch.
684 * public/include/manifest.php:
685 * tests/admin-regenerate-manifest.js:
687 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
691 Reviewed by Ricky Mondello.
693 This column is no longer used by the front-end code since r48360.
695 * database/init-database.sql:
696 * public/admin/tests.php:
698 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
700 Unreviewed build fix.
702 * public/api/report.php:
704 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
706 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
708 Reviewed by Ricky Mondello.
710 Support a new alternative format for aggregated results where we have raw values as well as
711 the list aggregators so that instead of
712 "metrics": {"Time": ["Arithmetic"]}
714 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
716 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
717 dashboard and the generated results page, which doesn't know how to aggregate values.
719 We need to keep the support for the old format because all other existing performance tests
720 all rely on the old format. Even if we updated the tests, we need the dashboard to support
721 the old format during the transition.
723 * public/api/report.php:
724 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
725 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
727 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
729 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
731 Unreviewed; Tweak the CSS so that chart panes align vertically.
735 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
737 SafariPerfMonitor should support Combined metric.
739 * public/js/helper-classes.js:
740 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
741 value as well but assume it to be greater-is-better for now.
743 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
745 Commit the forgotten init-database change to add iteration_relative_time.
747 * database/init-database.sql:
749 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
751 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
753 Reviewed by Ricky Mondello.
755 Add the support for each value to have a relative time. This is necessary for frame rate history
756 since a frame rate needs to be associated with a time it was sampled.
758 * database/init-database.sql: Added iteration_relative_time to run_iterations.
760 * public/api/report.php:
761 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
762 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
763 with relative time since taking the average of two frame rates for two subtests taken at two
764 different times doesn't make any sense.
765 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
766 etc..., use the second element since we assume values are of the form (relative time, frame rate).
767 Also exit early with an error if the number of elements in the array is not a pair.
768 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
770 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
771 iteration_relative_time.
773 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
775 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
777 Reviewed by Ricky Mondello.
779 Support that. It's one line change.
781 * public/api/report.php:
782 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
783 to match the convention assumed elsewhere.
784 * tests/api-report.js: Added a test case.
786 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
788 SafariPerfMonitor shows popups for points outside of the visible region.
790 Rubber-stamped by Simon Fraser.
793 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
794 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
795 may return an item underneath y-axis labels.
797 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
799 Tweak the CSS a little to avoid the test name overlapping with the summary table.
803 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
805 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
809 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
811 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
812 <rdar://problem/13992271> Should scale Y axis to include error ranges
814 Reviewed by Ricky Mondello.
816 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
817 the main graph doesn't go outside the graph even when the y-axis is adjusted.
819 * database/config.json:
821 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
822 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
823 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
825 * public/js/helper-classes.js:
826 (PerfTestResult.confidenceIntervalDelta):
827 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
828 (PerfTestRuns.min): Take confidence interval delta into account.
829 (PerfTestRuns.max): Ditto.
830 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
832 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
834 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
836 * public/api/report.php:
837 (ReportProcessor::recursively_ensure_tests):
838 * tests/api-report.js: Added a test.
840 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
842 Unreviewed build fixes.
844 * public/api/report.php:
845 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
846 Also, tolerate reports without any revision information.
848 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
851 * tests/api-report.js: Added few test cases.
853 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
855 Commit another change that was supposed to be committed in r50331.
858 (TestEnvironment.this.postJSON):
859 (TestEnvironment.this.httpGet):
862 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
864 Commit the remaining files.
866 * public/admin/regenerate-manifest.php:
867 * public/include/admin-header.php:
868 * public/include/json-header.php:
869 * public/include/manifest.php:
871 (TestEnvironment.this.postJSON):
872 (TestEnvironment.this.httpGet):
875 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
877 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
879 Reviewed by Ricky Mondello.
881 Added some tests for admin/regenerate-manifest.
883 * public/admin/regenerate-manifest.php: Use require_once instead of require.
884 * public/include/admin-header.php: Ditto.
885 * public/include/json-header.php: Ditto.
887 * public/include/manifest.php:
888 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
889 When there are no builders, simply return an empty array.
892 (TestEnvironment.postJSON):
893 (TestEnvironment.httpGet): Added.
894 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
896 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
898 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
900 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
901 and run_iterations. Also fixed a typo in report.php found by new tests.
903 * public/api/report.php:
904 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
905 * tests/api-report.js: Added more test cases.
907 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
909 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
911 Reviewed by Ricky Mondello.
913 Add a test runner script and some simple test cases.
915 * database/config.json: Added the configuration for "testServer".
916 * database/database-common.js:
917 (pathToTests): Added.
918 * run-tests.js: Added.
921 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
922 and if there are, asks the user if it’s okay to delete all of the data contained therein.
923 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
925 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
926 in the current database using PostgreSQL's information_schema.
927 (askYesOrNoQuestion):
929 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
931 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
932 (TestEnvironment.assert): Exposes assert to tests.
933 (TestEnvironment.console): Exposes console to tests.
934 (TestEnvironment.describe): Adds a description.
935 (TestEnvironment.it): Adds a test case.
936 (TestEnvironment.postJSON):
937 (TestEnvironment.queryAndFetchAll):
938 (TestEnvironment.sha256):
939 (TestEnvironment.notifyDone): Ends the current test case.
943 (TestContext): An object created for each test case. Conceptually, this object is always on
944 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
945 this object via currentTestContext.
946 (TestContext.description):
948 (TestContext.logError):
951 * tests/api-report.js: Added some basic tests for /api/report.php.
953 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
955 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
957 The problem was that we were detecting whether we're updating dashboard or not by checking
958 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
959 all configurations. Use separate 'dashboard' action to execute the code even when
960 metric_configurations is empty.
962 * public/admin/tests.php:
964 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
966 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
968 Reviewed by Ricky Mondello.
970 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
971 from ReportProcessor as a preparation to replace deprecated aggregate.js.
973 * public/api/report.php:
974 (ReportProcessor::exit_with_error): Moved.
975 (ReportProcessor::process): Use the extracted TestRunsGenerator.
976 (TestRunsGenerator): Added.
977 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
978 (TestRunsGenerator::add_aggregated_metric): Moved.
979 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
980 (TestRunsGenerator::aggregate): Moved. Made public.
981 (TestRunsGenerator::aggregate_current_test_level): Moved.
982 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
983 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
984 (TestRunsGenerator::compute_caches): Moved. Made public.
985 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
986 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
987 (TestRunsGenerator::rollback_with_error): Moved.
989 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
991 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
993 Reviewed by Remy Demarest.
995 Regenerate the manifest file when updating fields or adding new items that are included in
998 * public/admin/bug-trackers.php:
999 * public/admin/builders.php:
1000 * public/admin/regenerate-manifest.php:
1001 * public/admin/repositories.php:
1002 * public/admin/tests.php:
1003 * public/include/admin-header.php:
1004 (regenerate_manifest): Extracted from regenerate-manifest.php.
1006 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1008 Unreviewed build fix for memory test results.
1010 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
1011 aggregating at each level.
1013 * public/api/report.php:
1014 (ReportProcessor::recursively_ensure_tests):
1015 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
1016 (ReportProcessor::add_values_for_aggregation):
1017 (ReportProcessor::aggregate):
1018 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
1020 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1022 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
1023 not the number of iteration groups. Also, don't set group number when the entire run belongs
1024 a single iteration group.
1026 * public/api/report.php:
1027 (ReportProcessor::commit):
1029 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1031 SafariPerfMonitor: Introduce iteration groups
1033 Reviewed by Remy Demarest.
1035 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
1036 the runtime environment variances to get more stable results. And it's desirable to keep track of
1037 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
1039 This patch introduces "iteration groups" to keep track of this extra information.
1041 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
1042 the outer array denotes iteration groups and each inner array contains iteration values for each group.
1045 * database/init-database.sql: Add iteration_group column.
1046 * public/api/report.php:
1047 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
1049 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
1050 contains the list of values indexed by the iteration order and group sizes. Store the group size so
1051 that we can restore the iteration groups before passing it to node.js and restore them later.
1053 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
1054 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
1056 Also check that each iteration group in each subtest are consistent with one another. To see why we need
1057 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
1058 that each iteration group in T1 and T2 have the same size:
1059 T1 = [[1, 2], [3, 4, 5]]
1060 T2 = [[6, 7], [8, 9, 10]]
1062 so that the aggregated result (the sum in this case) can have the same groups as in:
1063 T = [[7, 9], [11, 13, 15]]
1065 If some iteration groups in T1 and T2 had a different size as in:
1066 T1 = [[1, 2, 3], [4, 5]]
1067 T2 = [[6, 7], [8, 9, 10]]
1069 Then iteration groups of the aggregated T is ambiguous.
1071 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
1072 (ReportProcessor::commit): Store iteration_group values.
1074 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1076 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
1077 migrated to perf.webkit.org.
1079 * database/perf-webkit-migrator.js: Removed.
1081 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1083 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
1085 * public/index.html:
1088 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1090 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
1092 Reviewed by Ricky Mondello.
1094 It is often desirable to see charts of a given test for all platforms, or to be able to see
1095 charts of all subtests on a given platform when trying to triage perf. regressions.
1097 Support this use case by adding the ability to do so on the charts page.
1099 Also, we used to disable items on the test list based on the platform chosen. This turned out
1100 to be a bad UI because in many situations you want to be able to compare results of the same test
1101 on multiple platforms.
1103 In this new UI, we have three select elements, each of which selects the following:
1104 1. Top-level test - Test suite such as Dromaeo
1105 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
1106 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
1107 3. Platform - Mountain Lion, Qt, etc...
1109 A user can select "all" for metric and platform but we disallow doing both at once since adding
1110 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
1111 think of a use case where you want to look at that many charts at once. We can support this later
1112 if valid use cases come up.
1114 * public/index.html:
1115 (.showCharts.addOption): Extracted.
1116 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
1117 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
1118 metricList has onchange handler that enables/disables items on platformList.
1120 (init): Sort tests and test metrics here instead of doing that in showCharts.
1122 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
1124 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
1126 Reviewed by Remy Demarest and Ricky Mondello.
1128 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
1129 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
1130 templates to the manifest file instead. Each build now only contains the builder id.
1132 * public/api/runs.php: Removed the part of the query that joined builders table. This
1133 speeds up the query quite a bit.
1135 * public/include/manifest.php:
1136 (ManifestGenerator::generate): Generate builders field.
1137 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
1138 associative array that contains name and its build URL template.
1140 * public/index.html:
1141 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
1142 instead of a revision since this function is used for revisions and build page URLs now.
1143 (.buildLabelWithLinks): Include the linkified build number.
1145 * public/js/helper-classes.js:
1146 (TestBuild.builder): Added.
1147 (TestBuild.buildNumber): Added.
1148 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
1149 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
1151 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
1153 Tooltips interfere with user interactions
1155 Rubber-stamped by Simon Fraser.
1157 Disable tooltip on the dashboard page since graphs are too small to be useful there.
1158 Also, show graphs for only 10 days by default as opposed to 20.
1159 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
1161 * public/index.html:
1162 * public/js/helper-classes.js:
1164 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
1166 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
1167 to be compatible with webkit-perf.appspot.com.
1169 * public/admin/builders.php:
1170 * public/api/report.php:
1172 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
1176 Add a missing constraint on builds table. For a given builder, there should be exactly
1177 one build for a given build number.
1179 Also add report_committed_at to reports table to record the time at which a given report
1180 was processed and test_runs and run_iterations rows were committed into the database.
1182 * database/config.json:
1183 * public/api/report.php:
1185 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
1187 Unreviewed. Add more checks for empty SQL query results.
1189 * public/include/manifest.php:
1191 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1193 More build fixes on perf.webkit.org.
1195 * public/api/runs.php: Make PostgreSQL happier.
1196 * public/include/manifest.php: Don't assume we always have bug trackers.
1198 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1200 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
1201 and fix other miscellaneous UI bugs.
1203 Rubber-stamped by Simon Fraser.
1205 Removed the code to determine whether smaller value is better or not for a given test in index.html
1206 in the favor of using that of PerfTestRuns.
1208 * public/include/manifest.php: Fixed a typo.
1209 * public/index.html:
1211 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
1213 * public/js/helper-classes.js:
1214 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
1216 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
1217 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
1218 at roughly 2,000 units to avoid this.
1220 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
1221 The only thing we can avoid is innerHTML.
1223 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1225 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
1227 * public/include/evaluator.js:
1229 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1231 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
1233 Reviewed by Remy Demarest.
1235 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
1236 admin/bug-trackers.php and can be associated with multiple repositories.
1238 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
1239 to determine the set of bug trackers to show for a given set of blame lists.
1240 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
1241 a place to file bugs against the regression.
1243 * database/init-database.sql: Added bug_trackers and tracker_repositories.
1244 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
1246 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
1247 bug trackers, namely associated repositories.
1249 * public/include/admin-header.php: Added a link to bug-trackers.php
1250 * public/include/manifest.php:
1251 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
1252 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
1254 (ManifestGenerator::repositories):
1256 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
1257 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
1258 'repositories' where the latter contains the list of associated repository names.
1260 * public/index.html:
1261 (Chart): Takes bugTrackers as as argument.
1262 (Chart.showTooltipWithResults): Removed the hard-coded list.
1264 (init.addPlatformsToDashboard):
1265 (init.showCharts.createChartFromListPair):
1266 (init): Stores the list of bug trackers in the manifest to a local variable.
1268 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1270 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
1272 * public/include/evaluator.js:
1274 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1276 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
1278 Reviewed by Remy Demarest.
1280 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
1281 new row into the database.
1283 * public/admin/aggregators.php: Use AdministrativePage.
1284 * public/admin/builders.php: Ditto.
1285 * public/admin/repositories.php: Ditto.
1286 * public/include/admin-header.php:
1287 (AdministrativePage): Added.
1288 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
1289 to an associative array that describes the column.
1290 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
1291 - label: Human readable name of the column.
1292 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
1293 column exists only before we create password_hash column at the insertion time.
1295 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
1296 titlecase (e.g. new_bug is converted to New Bug).
1297 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
1298 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
1299 textarea for a given editing mode ('text', 'url', or 'string').
1300 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
1301 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
1303 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
1305 Build fix. Some systems don't support r+. Use proc_open instead.
1307 * public/api/report.php:
1309 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1311 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
1312 when computing the y-axis of data points to show tooltips at.
1314 * public/index.html:
1316 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1318 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
1321 * public/.htaccess: Removed.
1323 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
1327 * public/include/manifest.php: Build fix. db is on this.
1328 * public/js/statistics.js:
1329 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
1331 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
1333 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
1335 Reviewed by Anders Carlsson.
1337 Rewrote and merged populate-from-report.js into report.php.
1339 * database/config.json: Added a path to node.js.
1341 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
1342 Once we land this patch and update the administrative pages, we can remove this column.
1344 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
1345 that table is going away once we remove the node.js backend.
1347 * database/populate-from-report.js: Removed.
1348 * public/api/report.php: Added.
1350 (ReportProcessor.__construct):
1351 (ReportProcessor.process):
1353 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
1354 verified to be submitted by a known builder.
1356 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
1357 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
1358 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
1359 inside a transaction because there could be multiple reports for a single build, each containing results for
1362 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
1363 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
1364 add_values_to_commit, and add_values_for_aggregation.
1366 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
1367 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
1368 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
1371 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
1372 to be aggregated in ReportProcessor.aggregate.
1374 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
1376 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
1377 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
1378 given for each row (child metrics of M). This function extracts each column (iteration) via
1379 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
1380 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
1382 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
1383 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
1384 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
1386 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
1387 (ReportProcessor.evaluate_expressions_by_node): See above.
1389 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
1390 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
1391 results also need the said caches.
1393 (ReportProcessor.add_values_to_commit):
1395 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
1396 the transaction as needed if anything goes wrong.
1398 (ReportProcessor.rollback_with_error)
1400 * public/include/db.php:
1401 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
1402 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
1403 contiguously in a SQL statement.
1405 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
1406 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
1407 a column value of the choice.
1409 (Database.begin_transaction): Added.
1410 (Database.commit_transaction): Added.
1411 (Database.rollback_transaction): Added.
1413 * public/include/evaluator.js: Added.
1414 * public/include/json-header.php:
1415 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
1416 context under which the request failed.
1417 (successful_exit): Merge "additional details".
1418 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
1419 (merge_additional_details):
1421 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
1423 SafariPerfMonitor: Add more helper functions to db.php
1425 Reviewed by Remy Demarest.
1427 Added Database::insert_row and array_get to make common database operations easier.
1429 * public/admin/aggregators.php: Use Database::insert_row instead of
1430 execute_query_and_expect_one_row_to_be_affected.
1432 * public/admin/builders.php: Ditto.
1434 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
1435 inserting a row. With insert_row, we don't need that.
1437 * public/include/admin-header.php: Ditto.
1439 * public/include/db.php:
1440 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
1441 return the default value (defaults to NULL) if the key doesn't exist.
1443 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
1446 (Database::prepare_params): Added. Takes an associative array of column names and their values,
1447 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
1448 column names all in the same order.
1450 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
1451 the given prefix. Values are given in a form of an associative array where keys are unprefixed
1452 column names and values are corresponding values. When the row is successfully inserted, it returns
1453 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
1454 indicating the success of the insertion.
1456 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1458 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
1460 Reviewed by Conrad Shultz.
1462 Rewrote the manifest generator in PHP.
1464 * database/generate-manifest.js: Removed.
1465 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
1466 * public/include/db.php:
1467 (array_ensure_item_has_array): Added.
1468 * public/include/evaluator.js: Added.
1469 * public/include/json-header.php:
1470 * public/include/manifest.php: Added.
1472 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1474 Dates on overflow plot are overlapping
1476 Rubber-stamped by Simon Fraser.
1478 Don't show more than 5 days.
1480 * public/index.html:
1481 * public/js/helper-classes.js:
1482 (TestBuild.UTCtoPST):
1485 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1487 Show build time as well as commit time on the dashboard and tooltips.
1489 Rubber-stamped by Simon Fraser.
1491 Include both the maximum commit time and build time in buildLabelWithLinks.
1492 Also use ISO format to save the screen real estate.
1494 * public/index.html:
1495 (buildLabelWithLinks):
1496 * public/js/helper-classes.js:
1498 (TestBuild.buildTime):
1499 (TestBuild.formattedBuildTime):
1501 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
1503 Unreviewed; Convert metric.name to metric.unit in the front end.
1505 * public/js/helper-classes.js:
1507 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1509 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
1511 Rubber-stamped by Simon Fraser.
1513 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
1514 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
1515 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
1517 * public/index.html:
1518 (.buildLabelWithLinks): Extracted from TestBuild.label.
1519 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
1520 on Radar and WebKit Bugzilla.
1521 * public/js/helper-classes.js:
1522 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
1523 (PerfTestResult.isBetterThan): Added.
1524 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
1525 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
1526 to indicate progressions or regressions.
1527 (PerfTestResult.label):
1528 (TestBuild.formattedTime): Added.
1529 (TestBuild.platform): Added.
1530 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
1531 (TestBuild.smallerIsBetter): Added.
1532 (Tooltip.show): Take a raw markup instead of two results.
1534 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
1536 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
1538 Rubber-stamped by Tim Horton.
1540 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
1541 since each platform may have a different number of tests to be shown on the dashboard.
1543 * public/index.html:
1545 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1547 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
1549 * public/js/helper-classes.js:
1552 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1554 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
1556 Rubber-stamped by Tim Horton.
1558 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
1560 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
1561 the revision r1234 was the revision used in the previous build.
1563 * public/api/runs.php:
1564 (parse_revisions_array): Trim double quotations around repository names and revisions.
1565 * public/js/helper-classes.js:
1568 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1570 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
1572 Rubber-stamped by Tim Horton.
1574 * public/index.html:
1575 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
1576 on the dashboard page as it's way too noisy.
1578 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
1580 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
1581 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
1582 so that the tooltip for hover can be reused further.
1584 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
1585 and find the first point that lies on the right of the cursor position. We then compute the midpoint
1586 between this and the previous point and pick the closer of the two. It returns an item-like object
1587 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
1589 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
1591 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
1592 the first or "current" data points (as opposed to target or baseline data points).
1594 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
1595 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
1596 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
1598 * public/js/helper-classes.js:
1599 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
1600 work to the client via bindClick.
1602 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
1604 (Tooltip.bindClick): Added.
1606 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1608 Yet another build fix. metricId*s*.
1610 * public/admin/tests.php:
1612 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1614 Another build fix. Use the new payload format for the aggregate job.
1616 * public/admin/tests.php:
1618 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1622 * database/aggregate.js: Use variables that actually exist.
1623 * database/database-common.js:
1624 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
1625 function calls will find this configuration.
1627 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1629 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
1631 Reviewed by Ricky Mondello.
1633 Turned InstallManual into a proper markdown document and added ReadMe.md.
1635 * InstallManual: Removed.
1636 * InstallManual.md: Moved from InstallManual.
1639 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1641 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
1643 Reviewed by Ricky Mondello.
1645 This patch prepares the front end code to process baseline and target results properly.
1647 * public/index.html:
1648 (fetchTest.createRunAndResults): Extracted.
1649 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
1650 Deleted the comment about how sorting will be unnecessary once we start results in the server side
1651 since sorting by the maximum revision commit time turned out to be non-trivial in php.
1653 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1655 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
1657 Reviewed by Tim Horton.
1659 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
1660 These files are "dynamically linked" to our app.
1662 * public/index.html:
1663 * public/js/jquery-1.8.2.min.js: Removed.
1664 * public/js/jquery.colorhelpers.js: Added.
1665 * public/js/jquery.flot.categories.js: Added.
1666 * public/js/jquery.flot.crosshair.js: Added.
1667 * public/js/jquery.flot.errorbars.js: Added.
1668 * public/js/jquery.flot.fillbetween.js: Added.
1669 * public/js/jquery.flot.js: Added.
1670 * public/js/jquery.flot.min.js: Removed.
1671 * public/js/jquery.flot.navigate.js: Added.
1672 * public/js/jquery.flot.resize.js: Added.
1673 * public/js/jquery.flot.selection.js: Added.
1674 * public/js/jquery.flot.stack.js: Added.
1675 * public/js/jquery.flot.symbol.js: Added.
1676 * public/js/jquery.flot.threshold.js: Added.
1677 * public/js/jquery.flot.time.js: Added.
1678 * public/js/jquery.js: Added.
1680 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1682 Return NaN instead of throwing when there aren't enough samples.
1684 Reviewed by Sam Weinig.
1686 It's better to return NaN when we don't have enough samples so that we can treat it
1687 as if we don't have any confidence interval.
1689 * public/js/statistics.js:
1692 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1694 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
1696 * public/js/helper-classes.js:
1697 (URLState.parseIfNeeded):
1699 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1701 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
1703 Reviewed by Ricky Mondello.
1705 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
1707 * public/admin/aggregators.php: Use heredoc.
1708 * public/admin/builders.php:
1709 * public/admin/jobs.php:
1710 * public/admin/repositories.php:
1711 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
1712 This allows us to use update_field when updating test's url and metric's unit. Changed the action
1713 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
1714 Also removed a stray code to update unit and url simultaneously since it's never used.
1715 * public/include/admin-header.php:
1716 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
1717 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
1718 (update_field): Moved from repositories.php.
1720 * public/include/db.php:
1721 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
1723 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
1725 Build fixes. Treat mean, sum, and square sum as float, not int.
1727 Also use 95% confidence interval instead of 90% confidence interval.
1729 * public/api/runs.php:
1730 * public/js/helper-classes.js:
1731 (.this.confidenceIntervalDelta):
1733 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
1735 Add an administrative page to edit repository information.
1737 Reviewed by Ricky Mondello.
1739 * public/admin/repositories.php: Added.
1740 * public/include/admin-header.php:
1742 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
1744 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
1746 Reviewed by Ricky Mondello.
1748 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
1749 to aggregate results for those matrix in populate-from-report.js.
1751 * database/generate-manifest.js:
1752 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
1753 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
1754 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
1755 * database/populate-from-report.js:
1757 (getReport): No change even though the diff looks as if it moved.
1758 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
1759 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
1760 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
1761 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
1762 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
1764 (ensureMetricId): Take an aggregator id as an argument.
1765 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
1766 for all builds when the build id is not specified.
1767 * public/admin/tests.php:
1768 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
1769 of the same name with different aggregators.
1771 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
1773 Build fix. Don't pass in arguments to in the wrong order.
1775 * database/aggregate.js:
1777 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1779 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
1781 Reviewed by Ricky Mondello.
1783 Since the version of flot we use doesn't support showing graphs in the current locate or
1784 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
1785 treat them as in UTC). We don't want to use the current locate because other websites on
1786 webkit.org assume PST.
1788 Also append this information to build's label.
1790 * public/js/helper-classes.js:
1794 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1796 Store test URLs reported by builders.
1798 Reviewed by Ricky Mondello.
1800 * database/populate-from-report.js:
1801 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
1802 (ensureTestId): Store the URL.
1804 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
1806 Yet another build fix; don't blow up even if we didn't have any test configurations.
1808 * public/admin/tests.php:
1810 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1812 Build fix; don't instantiate Date when a timestamp wasn't provided.
1814 * database/populate-from-report.js:
1816 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
1818 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
1820 Reviewed by Tim Horton.
1822 Added an install manual.
1824 * InstallManual: Added.
1826 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
1828 Minor build fix. Don't unset builderPassword when it's not set.
1830 * public/api/report.php:
1832 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1834 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
1836 Reviewed by Ricky Mondello.
1838 * public/admin/admin.css: Make a very large payload scrollable.
1839 * public/admin/jobs.php: Format JSONs.
1841 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
1843 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
1845 Reviewed by Ricky Mondello.
1847 Add report.php and populate-from-report.js that process JSON files submitted by builders.
1849 * database/populate-from-report.js: Added.
1851 (getReport): Obtains the payload (the actual report) from "jobs" table.
1852 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
1853 and their results. This function recursively traverses tests and metrics and ensure their ids.
1855 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
1856 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
1857 is a "function" in mathematical sense).
1859 (ensureRepositoryIdsForAllRevisions):
1860 (getIdOrCreateBuildWithRevisions):
1861 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
1862 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
1863 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
1865 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
1866 test results all in a single transaction. This allows us to keep the database consistent in that either
1867 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
1868 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
1869 other parts of the application are concerned.
1870 (scheduleQueriesToInsertRun):
1871 * database/process-jobs.js: Add a call to populate-from-report.js.
1872 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
1873 * public/include/db.php: Support parameterized query.
1874 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
1875 a test result could confirm that the submission indeed succeeded.
1877 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1879 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
1881 * database/aggregate.js:
1882 * database/database-common.js:
1883 (selectColumnCreatingRowIfNeeded):
1884 (ensureRepositoryId):
1885 (ensureConfigurationIdFromList):
1886 * database/perf-webkit-migrator.js:
1889 (getOrCreateBuildId):
1891 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
1893 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
1895 Reviewed by Ricky Mondello.
1897 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
1898 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
1900 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
1903 (saveAggregatedResults):
1904 * database/database-common.js:
1905 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
1906 (getIdOrCreateRepository): Ditto.
1907 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
1908 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
1909 * database/perf-webkit-migrator.js:
1910 * database/utility.js: Added.
1911 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
1912 from being executed.
1913 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
1914 call the callback passed into start().
1915 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
1916 (TaskQueue.addTask):
1918 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
1919 (SerializedTaskQueue.executeNextTask):
1920 (SerializedTaskQueue.addTask):
1921 (SerializedTaskQueue.start):
1923 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1925 Revert erroneously committed changes.
1927 * database/config.json:
1929 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1931 aggregator.js should be able to accept multiple metric ids and a single build id.
1933 Reviewed by Ricky Mondello.
1935 Make aggregator.js accept multiple ids and generate results for single build when bots are
1936 reporting new results.
1938 * database/aggregate.js:
1939 (parseArgv): Added. Returns an object containing the parsed representation of argv,
1940 which currently contains metricIDs and buildIds.
1941 (main): Use parseArgv and processConfigurations
1942 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
1943 (processPlatform.processConfigurations): Extracted.
1945 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
1947 Add an administrative page for builders.
1949 Reviewed by Ricky Mondello.
1951 We need an administrative page to add and edit builder information.
1952 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
1954 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
1955 since we don't have plans to use those columns in near future. Also make builder_name unique
1956 as required by the rest of the app.
1957 * public/admin/builders.php: Added.
1958 * public/api/runs.php: Updated per the table rename.
1959 * public/include/admin-header.php: Added a link to builders.php.
1961 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
1963 Build fixes for r46982.
1965 * database/aggregate.js:
1966 (fetchConfigurations): Bind i so that it's not always metricIds.length.
1967 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
1968 (processBuild): Don't print "." until we've committed transactions. It's misleading.
1970 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
1972 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
1974 * public/admin/aggregators.php:
1975 * public/admin/footer.php: Removed.
1976 * public/admin/header.php: Removed.
1977 * public/admin/index.php:
1978 * public/admin/jobs.php:
1979 * public/admin/tests.php:
1980 * public/api/json-header.php: Removed.
1981 * public/api/runs.php:
1982 * public/db.php: Removed.
1983 * public/include: Added.
1984 * public/include/admin-footer.php: Copied from public/admin/footer.php.
1985 * public/include/admin-header.php: Copied from public/admin/header.php.
1986 * public/include/db.php: Copied from public/db.php.
1987 * public/include/json-header.php: Copied from public/api/json-header.php.
1989 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
1991 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
1993 Reviewed by Ricky Mondello.
1995 Added the initial implementation of value aggregation.
1996 Also added abilities to configure the dashboard page in tests.php.
1998 * database/aggregate.js: Added.
1999 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
2000 (TaskQueue.addTask):
2002 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
2003 (SerializedTaskQueue.addTask):
2004 (SerializedTaskQueue.start):
2007 (fetchConfigurations):
2008 (fetchBuildsForPlatform):
2010 (testsWithDifferentIterationCounts):
2011 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
2012 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
2013 (getOrInsertConfiguration):
2015 * database/database-common.js:
2016 (fetchTable): Log an error as an error.
2017 (getOrCreateId): Extracted from perf-webkit-migrator.
2018 (statistics): Added.
2019 * database/perf-webkit-migrator.js:
2020 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
2021 runs JSON since runs JSONs are generated on demand now.
2023 (getOrCreatePlatformId):
2024 (getOrCreateTestId):
2025 (getOrCreateConfigurationId):
2026 (getOrCreateRevisionId):
2027 (getOrCreateRepositoryId):
2028 (getOrCreateBuildId):
2029 * database/process-jobs.js:
2030 (processJob): Handle 'aggregate' type.
2032 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
2034 Fix the dashboard after adding test_metrics.
2036 Reviewed by Ricky Mondello.
2038 Rename test to metrics in various functions and sort tests on the charts page.
2039 Also representing whether a test appears or not by setting a flag on dashboard
2040 was bogus because test objects are shared by multiple platforms. Instead, store
2041 dashboard platform list as intended by the manifest JSON.
2043 * public/index.html:
2044 (PerfTestRuns): Renamed test to metric.
2046 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
2047 (fullName): Moved so that it appears above where it's called.
2048 * public/js/helper-classes.js:
2050 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
2052 Update tests.php to reflect recent changes in the database schema.
2054 Reviewed by Conrad Shultz.
2056 Made the following changes to tests.php:
2057 1. Disallow adding metrics to tests without subtests.
2058 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
2059 3. Linkified tests with subtests instead of showing all them at once.
2061 * public/admin/admin.css:
2062 (.action-field, .notice):
2064 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
2065 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
2066 (add_job): Extracted.
2067 * public/admin/tests.php: See above.
2068 (array_item_set_default): Added.
2069 (array_item_or_default): Renamed from get_value_with_default.
2070 (compute_full_name): Extracted.
2071 (sort_tests): Ditto.
2072 (map_metrics_to_tests): Ditto.
2074 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
2076 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
2078 Reviewed by Simon Fraser.
2080 Linkify the headers using metric.test.url when it's provided.
2082 * public/index.html:
2084 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2086 Use parameterized pg_query_params in query_and_fetch_all
2088 Reviewed by Conrad Shultz.
2090 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
2092 * public/api/runs.php:
2094 (ctype_alnum_underscore): Added.
2096 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
2098 Update the migration tool to support test_metrics.
2100 Reviewed by Mark Rowe.
2102 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
2103 Also import run_iteration rows as runs JSON files now include individual values.
2105 * database/database-common.js:
2106 (addJob): Extracted.
2107 * database/perf-webkit-migrator.js:
2108 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
2109 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
2110 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
2113 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2115 Build fix. Suppress "Undefined index" warning.
2117 * public/admin/tests.php:
2119 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2121 Fix a commit error in r46756. api/ should obviously be added under public/
2124 * api/json-header.php: Removed.
2125 * api/runs.php: Removed.
2126 * public/api: Copied from api.
2128 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2130 SafariPerfMonitor: Linkify revisions and revisions range
2131 <rdar://problem/12801010>
2133 Reviewed by Mark Rowe.
2135 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
2136 since it needs to know "url" and "blameUrl".
2138 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
2140 * public/index.html:
2141 * public/js/helper-classes.js:
2143 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
2144 (TestBuild.label): Add labels for all revisions.
2148 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2150 Make the generation of "runs" JSON dynamic and support test_metrics.
2152 Reviewed by Mark Rowe.
2154 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
2156 Since there could be hundreds, if not thousands, of tests for each configuration and users
2157 aren't necessarily interested in looking at all test results, it's much more efficient to
2158 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
2159 when bots report new results (i.e. pushing).
2161 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
2164 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
2165 (exit_with_error): Added.
2166 (successful_exit): Added.
2167 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
2168 * database/generate-runs.js: Removed.
2169 * database/process-jobs.js: No longer supports "runs".
2170 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
2171 * public/db.php: Print "Nothing to see here." when it's accessed directly.
2173 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
2175 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2177 Update tests.php and sample-data.sql per addition of test_metrics.
2179 Rubber-stamped by Timothy Hatcher.
2181 Remove a useless code from tests.php that used to update the unit and the url of a test
2182 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
2184 Also update the sample data to reflect the addition of test_metrics.
2186 * database/sample-data.sql:
2187 * public/admin/tests.php:
2189 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
2191 Share more code between admin pages.
2193 Reviewed by Timothy Hatcher.
2195 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
2196 between admin pages.
2198 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
2199 to check the nullity of global $db now.
2201 * public/admin/aggregators.php:
2202 * public/admin/header.php:
2204 (execute_query_and_expect_one_row_to_be_affected): Added.
2205 * public/admin/index.php:
2206 * public/admin/jobs.php:
2207 * public/admin/tests.php:
2209 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
2211 SafariPerfMonitor: Add admin page to edit aggregators
2212 <rdar://problem/12782687>
2214 Reviewed by Mark Rowe.
2216 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
2218 * public/admin/aggregators.php: Added.
2219 * public/admin/header.php:
2220 * public/admin/jobs.php: Removed an erroneous hidden input element.
2222 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2224 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
2226 * database/init-database.sql:
2228 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2230 SafariPerfMonitor: Allow multiple metrics per test
2231 <rdar://problem/12773506>
2233 Rubber-stamped by Mark Rowe.
2235 Introduce a new table test_metrics. This table represents metrics each test can have
2236 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
2239 Updated admin/tests.php and index.html accordingly.
2241 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
2243 * database/generate-manifest.js:
2244 (buildPlatformMapIfPossible):
2245 * database/generate-runs.js:
2247 * database/init-database.sql:
2248 * database/schema.graffle:
2249 * public/admin/admin.css:
2252 * public/admin/tests.php:
2253 * public/index.html:
2255 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
2257 SafariPerfMonitor: Improve the webkit-perf migration tool
2258 <rdar://problem/12760882>
2260 Reviewed by Mark Rowe.
2262 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
2263 and we don't want to pause the whole importation process until the user comes back to decide whether
2266 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
2267 down to make modifications.
2269 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
2270 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
2272 * database/init-database.sql:
2273 * database/perf-webkit-migrator.js:
2274 (migrateTestConfig):
2275 * database/schema.graffle:
2276 * public/admin/admin.css:
2278 * public/admin/tests.php:
2280 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
2282 Create a new performance dashboard
2283 <rdar://problem/12625582>
2285 Rubber-stamped by Mark Rowe.
2287 Add the initial implementation of the perf dashboard.
2290 * database/config.json: Added.
2291 * database/database-common.js: Added.
2296 (pathToLocalScript):
2298 * database/generate-manifest.js: Added.
2301 (buildPlatformMapIfPossible):
2302 (generateFileIfPossible):
2303 * database/perf-webkit-migrator.js: Added.
2304 * database/process-jobs.js: Added.
2305 * database/sample-data.sql: Added.
2306 * database/schema.graffle: Added.
2308 * public/admin: Added.
2309 * public/admin/README: Added.
2310 * public/admin/admin.css: Added.
2311 * public/admin/footer.php: Added.
2312 * public/admin/header.php: Added.
2313 * public/admin/index.php: Added.
2314 * public/admin/jobs.php: Added.
2315 * public/admin/tests.php: Added.
2316 * public/common.css: Added.
2317 * public/data: Added.
2318 * public/db.php: Added.
2319 * public/index.html: Added.
2321 * public/js/helper-classes.js: Added.
2322 * public/js/jquery-1.8.2.min.js: Added.
2323 * public/js/jquery.flot.min.js: Added.
2324 * public/js/jquery.flot.plugins.js: Added.
2325 * public/js/shared.js: Added.
2326 (fileNameFromPlatformAndTest):
2327 * public/js/statistics.js: Added.