1 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
3 Selecting revisions for A/B testing is hard
4 https://bugs.webkit.org/show_bug.cgi?id=141824
6 Reviewed by Andreas Kling.
8 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
9 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
10 select A/B testing points manually.
12 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
13 sets to 'options' for clarity.
15 * public/v2/app.css: Reorganized style rules.
18 (App.AnalysisTaskController):
19 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
20 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
21 a property, which sets 'overviewDomain' property as well as other properties.
22 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
23 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
24 in the overview chart.
26 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
27 individual build requests / test results are shown or not.
29 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
30 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
32 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
34 Unreviewed test fixes after r179037, r179591, and r179763.
36 * tests/admin-regenerate-manifest.js:
37 * tests/admin-reprocess-report.js:
39 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
41 Relationship between A/B testing results are unclear
42 https://bugs.webkit.org/show_bug.cgi?id=141810
44 Reviewed by Andreas Kling.
46 Show a "reference chart" indicating which two points have been tested in each test group pane.
48 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
49 and the domain used in this chart to show charts in each test group.
51 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
53 * public/v2/analysis.js:
54 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
55 since this is the results of A/B testing results, not the data for charts shown next to them.
57 * public/v2/app.css: Added CSS rules for reference charts.
60 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
61 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
62 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
63 identically matches root sets. If one of configuration used a set of revisions for which no measurement
64 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
65 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
66 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
67 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
70 (Measurement.prototype.revisionForRepository): Added.
71 (Measurement.prototype.commitTimeForRepository): Cleanup.
72 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
74 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
75 by including the build number in the title attribute instead of in the markup.
77 * public/v2/interactive-chart.js:
78 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
79 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
80 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
82 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
84 Analysis task pages are unusable
85 https://bugs.webkit.org/show_bug.cgi?id=141786
87 Reviewed by Andreas Kling.
89 This patch makes following improvements to analysis task pages:
90 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
91 compute the data for the details pane from PaneController.
92 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
93 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
94 This change required the creation of App.TestGroupPane as well as its methods.
95 4. Show a box plot for each root set configuration as well as each build request. This change required
97 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
99 * public/api/build-requests.php:
100 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
102 * public/api/test-groups.php:
103 (main): Include root sets and roots in the response.
106 * public/include/build-requests-fetcher.php:
107 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
108 (BuildRequestsFetcher::root_sets): Added.
109 (BuildRequestsFetcher::roots): Added.
110 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
111 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
112 tools/sync-with-buildbot.py can't convert repository names to their ids.
114 * public/v2/analysis.js:
116 (App.RootSet): Added.
117 (App.RootSet.revisionForRepository): Added.
118 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
119 response at /api/test-groups will include them.
120 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
121 _createConfigurationSummary.
122 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
123 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
125 * public/v2/app.css: Updated style rules for analysis task pages.
128 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
129 (App.Pane._updateDetails): Moved from App.PaneController.
131 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
133 (App.AnalysisTaskController): Added 'details'.
134 (App.AnalysisTaskController._taskUpdated):
135 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
136 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
137 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
139 (App.TestGroupPane): Added.
140 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
141 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
142 of all repositories appearing in root sets and builds associated with A/B testing results.
143 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
144 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
145 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
146 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
147 is a union of revisions in the root set and the first build request in the group. We null-out revision info
148 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
149 by the values in the group as well as 95% percentile confidence interval.
151 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
152 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
153 the mean and the confidence interval.
154 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
155 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
156 calls _updateBars to update the rects.
158 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
161 (Measurement.prototype.formattedRevisions):
162 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
163 called in _createConfigurationSummary.
165 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
166 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
167 Also made the fetching of chartData no longer block showing of test groups.
169 * public/v2/interactive-chart.js:
170 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
171 (App.InteractiveChartComponent._domainChanged): Ditto.
172 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
174 * public/v2/js/statistics.js:
175 (Statistics.min): Added.
176 (Statistics.max): Added.
178 * public/v2/manifest.js:
179 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
181 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
183 Build URL on new perf dashboard doesn't resolve $builderName
184 https://bugs.webkit.org/show_bug.cgi?id=141583
186 Reviewed by Darin Adler.
188 Support $builderName in the build URL template.
190 * public/js/helper-classes.js:
191 (TestBuild.buildUrl): Replaced $builderName with the builder name.
193 * public/v2/manifest.js:
194 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
195 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
197 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
199 Unreviewed build fix after r179591.
201 * public/api/commits.php:
203 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
205 The status of a A/B testing request always eventually becomes "Failed"
206 https://bugs.webkit.org/show_bug.cgi?id=141523
208 Reviewed by Andreas Kling.
210 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
211 'failedIfNotCompleted' was sent by the buildbot sync'er.
213 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
215 * public/api/build-requests.php:
218 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
220 Unreviewed, remove empty directories.
222 * public/data: Removed.
224 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
226 Perf dashboard should show the results of A/B testing
227 https://bugs.webkit.org/show_bug.cgi?id=141500
229 Reviewed by Chris Dumez.
231 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
232 analysis task page to fetch results for each test group.
234 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
235 can use the formatter.
237 * public/api/runs.php:
238 (fetch_runs_for_config_and_test_group): Added.
239 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
240 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
241 use RunsGenerator to format results.
242 (RunsGenerator): Added.
243 (RunsGenerator::__construct): Added.
244 (RunsGenerator::add_runs): Added.
245 (RunsGenerator::format_run): Moved.
246 (RunsGenerator::parse_revisions_array): Moved.
248 * public/v2/analysis.js:
249 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
250 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
251 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
252 configuration associated with this build request such as "A" and "B".
253 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
254 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
255 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
259 (App.Pane._fetch): Set chartData directly here.
260 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
261 now that it's done in App.Pane._fetch.
262 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
265 (Measurement.prototype.buildId): Added.
266 (TimeSeries.prototype.findPointByBuild): Added.
268 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
269 url is not an Ember routed path.
271 * public/v2/manifest.js:
272 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
273 App.createChartData here so that App.BuildRequest can use the formatter
275 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
277 v2 UI should adjust the number of ticks on dashboards based on screen size
278 https://bugs.webkit.org/show_bug.cgi?id=141502
280 Reviewed by Chris Dumez.
282 * public/v2/interactive-chart.js:
283 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
286 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
288 New perf dashboard shows too much space around interesting data points
289 https://bugs.webkit.org/show_bug.cgi?id=141487
291 Reviewed by Chris Dumez.
293 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
294 show the current time series excluding points in the series outside the moving average envelope.
297 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
298 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
299 time series if the point lies outside the moving average envelope. Don't expose the moving average or
300 the envelope computed for this purpose if they're not set by the user.
303 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
304 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
306 * public/v2/interactive-chart.js:
307 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
308 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
309 to deal with showFullYAxis here.
310 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
311 argument instead of directly inspecting showFullYAxis.
313 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
315 New perf dashboard shouldn't always show outliners
316 https://bugs.webkit.org/show_bug.cgi?id=141445
318 Reviewed by Chris Dumez.
320 Use the simple moving average with an average difference envelope to compute the y-axis range to show
321 to avoid expanding it spuriously to show one off outlier.
324 (App.Pane): Don't show the full y-axis range by default.
325 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
326 one is not specified by the user but without showing them in the charts.
327 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
328 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
330 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
331 (App.ChartsController._serializePaneList): Ditto.
333 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
335 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
337 * public/v2/interactive-chart.js:
338 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
339 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
340 if they are not specified by the user (i.e. only used to adjust y-axis range).
341 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
342 x-axis domain remained the same. Without this change, the charts would never redraw.
343 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
344 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
345 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
347 * public/v2/js/statistics.js:
348 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
350 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
352 Unreviewed build fix.
355 (set get App.Pane.Ember.Object.extend):
357 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
359 New perf dashboard should have the ability to overlay moving average with an envelope
360 https://bugs.webkit.org/show_bug.cgi?id=141438
362 Reviewed by Andreas Kling.
364 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
366 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
367 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
368 n, backward window size, and m, forward window size, as an argument.
370 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
371 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
373 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
374 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
377 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
378 between each x_i and x̄_i.
380 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
381 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
382 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
383 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
386 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
387 The configuration of the currently chosen strategies is saved in the query string for convenience.
389 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
391 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
394 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
395 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
396 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
397 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
398 from the query string via ChartsController.
399 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
400 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
401 (App.Pane._executeStrategy): Added.
402 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
404 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
405 selections, and added two new arguments for the moving average and the enveloping configurations.
406 (App.ChartsController._serializePaneList): Ditto.
407 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
408 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
409 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
410 (App.PaneController.actions.toggleStatPane): Added.
412 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
413 current (as opposed to baseline and target) time series for when it's the most foreground graph without
414 moving average and its envelope overlapping on top of it.
416 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
418 * public/v2/interactive-chart.js:
419 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
420 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
421 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
422 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
423 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
424 but don't bother removing individual paths and circles. Added the code to show the moving average time
425 series when there is one. Also add "foreground" class on SVG elements for the current time series when
426 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
427 series when "foreground" is not set.
428 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
429 account when computing the y-axis range.
430 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
432 * public/v2/js/statistics.js:
433 (Statistics.MovingAverageStrategies): Added.
434 (Statistics.EnvelopingStrategies): Added.
436 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
438 The delta value in the chart pane sometimes doens't show '+' for a positive delta
439 https://bugs.webkit.org/show_bug.cgi?id=141340
441 Reviewed by Andreas Kling.
443 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
444 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
447 (App.Pane.computeStatus):
448 (App.createChartData):
450 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
452 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
455 (App.PaneController._updateDetails):
457 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
459 Unreviewed. Commit the forgotten change.
461 * public/include/manifest.php:
463 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
465 New perf dashboard should have multiple dashboard pages
466 https://bugs.webkit.org/show_bug.cgi?id=141339
468 Reviewed by Chris Dumez.
470 Added the support for multiple dashboard pages. Also added the status of the latest data point.
471 e.g. "5% better than target"
473 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
474 Also hid the border lines around charts on the dashboard page for a cleaner look.
477 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
478 (App.IndexRoute.beforeModel): Added.
479 (App.DashboardRoute): Added.
480 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
481 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
482 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
483 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
484 (App.DashboardController): Renamed from App.IndexController.
485 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
486 and "defaultDashboard" as these are taken care of by newly added routers.
487 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
488 now done in actions.toggleEditMode.
489 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
490 an existing dashboard.
492 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
493 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
494 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
495 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
497 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
499 (App.PaneController._updateDetails): Updated per changes to computeStatus.
501 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
504 (TimeSeries.prototype.lastPoint): Added.
506 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
507 on the dashboard, and enumerate all predefined dashboards.
509 * public/v2/interactive-chart.js:
510 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
511 for the dashboard page.
513 * public/v2/manifest.js:
514 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
515 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
516 IDs are generated for each dashboard for forward compatibility.
518 (App.Manifest.dashboardByName): Added.
519 (App.Manifest.defaultDashboardName): Added.
520 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
522 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
524 Move commits viewer to the end of details view
525 https://bugs.webkit.org/show_bug.cgi?id=141315
527 Rubber-stamped by Andreas Kling.
529 Show the difference instead of the old value per kling's request.
532 (App.PaneController._updateDetails):
533 * public/v2/index.html:
535 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
537 Move commits viewer to the end of details view
538 https://bugs.webkit.org/show_bug.cgi?id=141315
540 Reviewed by Andreas Kling.
542 Improved the way list of commits are shown per kling's request.
545 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
547 * public/v2/chart-pane.css: Updated the style for the commits viewer.
549 * public/v2/commits-viewer.js:
550 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
551 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
553 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
554 moved the commits viewers out of the details tables so that they don't interleave revision data.
556 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
558 New perf dashboard should compare results to baseline and target
559 https://bugs.webkit.org/show_bug.cgi?id=141286
561 Reviewed by Chris Dumez.
563 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
564 Also use d3.format to format the selected value to show four significant figures.
567 (App.Pane.searchCommit):
568 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
569 to compute the status text without having to recreate them.
570 (App.createChartData): Added.
571 (App.PaneController._updateDetails): Use 3d.format on current and old values.
572 (App.PaneController._computeStatus): Added. Computes the status text.
573 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
574 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
575 format the values using chartData.formatter.
577 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
578 the baseline and in blue if it's better than the target.
581 (TimeSeries.prototype.findPointAfterTime): Added.
583 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
584 the bug that we were not showing the old value's unit.
586 * public/v2/interactive-chart.js:
587 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
588 the code to show the baseline and the target lines.
590 * public/v2/manifest.js:
591 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
593 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
595 Unreviewed build fix.
598 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
600 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
602 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
603 https://bugs.webkit.org/show_bug.cgi?id=141280
605 Reviewed by Chris Dumez.
607 Fixed the bug by passing in "since" as a query parameter to the charts page.
609 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
611 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
613 (App.IndexController): Changed the default number of days from one month to one week.
614 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
615 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
617 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
619 New perf dashboard erroneously clears zoom when poping history items
620 https://bugs.webkit.org/show_bug.cgi?id=141278
622 Reviewed by Chris Dumez.
624 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
626 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
627 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
630 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
631 shown in the main plot.
632 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
633 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
635 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
637 New perf dashboard shows null as the aggregator name if no aggregation is done
638 https://bugs.webkit.org/show_bug.cgi?id=141256
640 Reviewed by Chris Dumez.
642 Don't show the aggregator name if there isn't one.
644 * public/v2/manifest.js:
647 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
649 Unreviewed build fix after r179611.
651 * public/v2/interactive-chart.js:
653 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
655 Perf dashboard doesn’t show the right unit for Safari UI tests
656 https://bugs.webkit.org/show_bug.cgi?id=141238
658 Reviewed by Darin Adler.
660 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
661 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
662 between metrics and their units.
664 * public/js/helper-classes.js:
665 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
666 * public/v2/manifest.js:
667 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
668 * public/v2/interactive-chart.js:
669 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
670 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
672 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
674 Interactive chart component provides two duplicate API for highlighting points
675 https://bugs.webkit.org/show_bug.cgi?id=141234
677 Reviewed by Chris Dumez.
679 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
680 on the main charts page and markedPoints to show the two end points in the analysis task page.
682 This patch merges markedPoints into highlightedItems.
685 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
686 * public/v2/chart-pane.css:
687 * public/v2/index.html: Ditto.
688 * public/v2/interactive-chart.js:
689 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
690 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
691 items if highlightedItems was set before the initial layout.
692 (App.InteractiveChartComponent._relayoutDataAndAxes):
693 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
694 vertical lines, just set cx and cy as done for other "dots".
695 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
696 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
697 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
698 set the radius of highlight circles here.
700 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
702 Don’t use repository names as id’s.
703 https://bugs.webkit.org/show_bug.cgi?id=141226
705 Reviewed by Chris Dumez.
707 Not using repository names as their id's reduces the need to fetch the entire repositories table.
708 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
710 * Websites/perf.webkit.org/public/api/runs.php:
711 (parse_revisions_array): No longer uses $repository_id_to_name.
712 (main): No longer populates $repository_id_to_name.
714 * Websites/perf.webkit.org/public/api/triggerables.php:
715 (main): Don't resolve repository names.
717 * Websites/perf.webkit.org/public/include/manifest.php:
718 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
719 (ManifestGenerator::bug_trackers): Don't resolve repository names.
721 * Websites/perf.webkit.org/public/js/helper-classes.js:
722 (TestBuild): Renamed repositoryName to repositoryId.
723 (TestBuild.revision): Ditto.
724 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
725 since this is the text shown to human.
727 * Websites/perf.webkit.org/public/v2/app.js:
728 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
729 (App.PaneController._updateDetails): Ditto.
730 (App.AnalysisTaskController.updateRoots): Ditto.
732 * Websites/perf.webkit.org/public/v2/data.js:
733 (Measurement): Ditto.
734 (Measurement.prototype.commitTimeForRepository): Ditto.
735 (Measurement.prototype.formattedRevisions): Ditto.
737 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
738 select element's label and value respectively.
740 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
742 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
744 * public/api/runs.php:
746 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
748 /api/runs.php should have main function
749 https://bugs.webkit.org/show_bug.cgi?id=141220
751 Reviewed by Benjamin Poulain.
753 Wrapped the code inside main function for clarity.
755 * public/api/runs.php:
757 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
759 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
761 * tools/sync-with-buildbot.py:
762 (find_request_updates):
764 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
766 Perf dashboard always assigns the result of A/B testing with build request 1
767 https://bugs.webkit.org/show_bug.cgi?id=140382
769 Reviewed by Darin Adler.
771 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
772 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
774 Also fixed a typo as well as a bug that reports were never associated with builds.
776 * public/include/report-processor.php:
777 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
778 instead of the first non-null value.
779 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
780 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
782 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
784 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
786 * public/admin/tests.php:
788 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
790 Unreviewed build fix. Removed the stale code.
792 * public/admin/triggerables.php:
794 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
796 Perf dashboard should have the ability to post A/B testing builds
797 https://bugs.webkit.org/show_bug.cgi?id=140317
799 Rubber-stamped by Simon Fraser.
801 This patch adds the support for triggering A/B testing from the perf dashboard.
803 We add a few new tables to the database. "build_triggerables", which represents a set of builders
804 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
805 of repositories for which an arbitrary revision can be specified for A/B testing.
806 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
807 "roots" table which specifies the revision used in a given root set in each repository.
809 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
810 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
811 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
812 to build_requests table. Also made each test group's name unique in a given analysis task as it
813 would be confusing to have multiple test groups of the same name.
815 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
817 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
818 for which a specific revision can be set in an A/B testing on a given triggerable.
820 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
821 triggerable. Also updates the status' and the status urls of specified build requests when
822 buildRequestUpdates is provided in the raw POST data.
825 * public/api/runs.php:
826 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
827 results of an A/B testing.
829 * public/api/test-groups.php:
830 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
832 * public/api/triggerables.php: Added.
833 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
835 * public/include/admin-header.php:
837 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
838 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
839 and root sets used in those requests.D
840 (BuildRequestsFetcher::__construct):
841 (BuildRequestsFetcher::fetch_for_task):
842 (BuildRequestsFetcher::fetch_for_group):
843 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
844 (BuildRequestsFetcher::has_results):
845 (BuildRequestsFetcher::results):
846 (BuildRequestsFetcher::results_with_resolved_ids):
847 (BuildRequestsFetcher::results_internal):
848 (BuildRequestsFetcher::root_sets):
849 (BuildRequestsFetcher::fetch_roots_for_set):
851 * public/include/db.php:
852 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
853 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
854 table since it only has the primary key, id, column.
855 (Database::select_or_insert_row):
856 (Database::update_or_insert_row):
857 (Database::update_row): Added.
858 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
859 should be inserted when no row matches the specified criteria. This is used while updating
860 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
861 new build requests in that API.
862 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
863 This is used in public/api/triggerables.php when no analysis task is specified.
865 * public/include/json-header.php:
866 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
867 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
868 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
869 find the closest ancestor with a triggerable.
871 * public/include/report-processor.php:
872 (ReportProcessor::process):
873 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
874 if jobId or buildRequest is specified.
876 * public/include/test-name-resolver.php:
877 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
878 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
879 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
882 * public/include/test-path-resolver.php: Added.
883 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
884 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
885 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
886 in order to compute full test metric names.
887 (TestPathResolver::__construct):
888 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
889 the highest (a test without a parent).
890 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
891 the highest ancestor to the test itself.
892 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
894 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
896 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
897 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
898 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
899 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
901 * public/v2/analysis.js:
902 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
903 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
904 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
905 (App.TestGroup.create): Added. Creates a new A/B testing group.
906 (App.Triggerable): Added.
907 (App.TriggerableAdapter): Added.
908 (App.TriggerableAdapter.buildURL): Added.
909 (App.BuildRequest.testGroup): Renamed from group.
910 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
911 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
912 in this build request.
913 (App.BuildRequest.status): Added.
914 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
915 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
918 (App.AnalysisTaskController.testGroups): Added.
919 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
920 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
921 but an observer that updates "roots" property. Filter out the repositories that are not accepted
922 by the associated triggerable as they will be ignored.
923 (App.AnalysisTaskController.actions.createTestGroup): Added.
925 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
927 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
928 the status of those builds to the perf dashboard. A similar script can be written to support
929 other continuous builds systems.
930 (main): Fetches the list of pending builds as well as currently running or completed builds from
931 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
932 a single new build on each builder with no pending builds, and marks the set of open build requests
933 that have been scheduled to run on the buildbot but not found in the first step as stale.
934 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
937 "platform": "mac-mavericks",
938 "test": ["Parser", "html5-full-render.html"],
939 "builder": "Trunk Syrah Production Perf AB Tests",
941 "forcescheduler": "force-mac-mavericks-release-perf",
942 "webkit_revision": "$WebKit",
943 "jobid": "$buildRequest"
948 (find_request_updates): Return a list of build request status updates to make based on the pending
949 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
950 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
951 if the build request had not been completed. This is necessary because a failed build will not
952 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
953 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
954 of open requests the perf dashboard has.
955 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
956 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
957 or human canceling a build may trigger such a state.
958 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
959 replacing repository names with their revisions and buildRequest with the build request id.
960 (config_for_request): Finds a builder for the test and the platform of a build request.
961 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
962 (property_value_from_build): Returns the value of a specific property in a buildbot build.
963 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
965 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
967 Cache-control should be set only on api/runs
968 https://bugs.webkit.org/show_bug.cgi?id=140312
970 Reviewed by Andreas Kling.
972 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
973 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
974 just set cache-control there instead of json-header.php which is used by other JSON APIs.
976 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
978 * public/api/analysis-tasks.php:
979 * public/api/runs.php: Set the cache control headers.
980 * public/api/test-groups.php:
981 * public/include/db.php: Set the default timezone to UTC.
982 * public/include/json-header.php: Don't set the cache control headers.
984 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
986 api/report-commit should authenticate with a slave name and password
987 https://bugs.webkit.org/show_bug.cgi?id=140308
989 Reviewed by Benjamin Poulain.
991 Use a slave name and a password to authenticate new commit reports.
993 * public/api/report-commits.php:
995 * public/include/json-header.php:
996 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
997 a slave name and a password instead of a builder name and a password.
998 * tests/api-report-commits.js: Updated tests.
1000 (main): Renamed variables.
1001 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
1003 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
1005 Perf dashboard should support authentication via a slave password
1006 https://bugs.webkit.org/show_bug.cgi?id=139837
1008 Reviewed by Andreas Kling.
1010 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
1011 having to add multiple builders with the same password when a single build slave is shared among them.
1013 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
1015 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
1017 * public/admin/build-slaves.php: Added.
1019 * public/admin/builders.php: Added the support for updating passwords.
1021 * public/include/admin-header.php:
1022 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
1023 being retrieved from $_POST.
1024 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
1025 the raw may not exist (e.g. new_password).
1026 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
1027 control here when this flag evaluates to TRUE.
1029 * public/include/report-processor.php:
1030 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
1031 values are present in the report. In addition, try authenticating builderName with slavePassword if
1032 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
1033 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
1034 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
1036 (ReportProcessor::store_report): Store the slave ID with the report.
1037 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
1038 the matching build is different from what's being reported.
1040 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
1043 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
1045 New perf dashboard should not duplicate author information in each commit
1046 https://bugs.webkit.org/show_bug.cgi?id=139756
1048 Reviewed by Darin Adler.
1050 Instead of each commit having author name and email, make it reference a newly added committers table.
1051 Also replace "email" by "account" since some repositories don't use emails as account names.
1053 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
1054 which only contains as many rows as there are accounts in each repository, instead of commits table
1055 which contains every commit ever happened in each repository.
1057 To migrate an existing database into match the new schema, run:
1061 INSERT INTO committers (committer_repository, committer_name, committer_email)
1062 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
1063 FROM commits WHERE commit_author_email IS NOT NULL);
1065 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
1067 UPDATE commits SET commit_committer = committer_id FROM committers
1068 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
1070 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
1071 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
1075 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
1076 reference to committers. Also added the missing drop table statements.
1078 * public/api/commits.php:
1079 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
1080 an array here instead of doing it in format_commit.
1081 (fetch_commits_between): Updated queries to JOIN commits with committers.
1082 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
1083 is now done in main.
1085 * public/api/report-commits.php:
1086 (main): Store the reported committer information or update the existing entry if there is one.
1088 * tests/admin-regenerate-manifest.js: Fixed tests.
1090 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
1092 * tools/pull-svn.py: Renamed email to account.
1094 (fetch_commit_and_resolve_author):
1096 (resolve_author_name_from_account):
1097 (resolve_author_name_from_email): Deleted.
1099 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
1101 Unreviewed build fix.
1103 * public/v2/index.html: Include js files we extracted in r177424.
1105 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1107 Unreviewed. Adding the forgotten svnprop.
1109 * tools/pull-svn.py: Added property svn:executable.
1111 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1113 Split InteractiveChartComponent and CommitsViewerComponent into separate files
1114 https://bugs.webkit.org/show_bug.cgi?id=139716
1116 Rubber-stamped by Benjamin Poulain.
1118 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
1119 and interactive-chart.js respectively since app.js has gotten really large.
1122 * public/v2/commits-viewer.js: Added.
1123 * public/v2/interactive-chart.js: Added.
1125 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
1127 New perf dashboard's chart UI is buggy
1128 https://bugs.webkit.org/show_bug.cgi?id=139214
1130 Reviewed by Chris Dumez.
1132 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
1134 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
1135 component. This is not how Ember.js components should interact to begin with. The component now exposes
1136 selectedPoints and always updates selection instead of sharedSelection.
1139 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
1140 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
1141 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
1142 and end time should be completely determined by "since" and the present time.
1143 (App.ChartsController._startTimeChanged): Ditto.
1144 (App.ChartsController._scheduleQueryStringUpdate):
1145 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
1147 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
1149 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
1150 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
1151 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
1152 observes the changes to selectedPoints property as it gets updated by the main chart.
1153 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
1154 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
1156 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
1157 when domain arrays aren't identical. This was causing a subtle race with other logic.
1158 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
1159 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
1160 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
1161 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
1162 see if those two points correspond to a range or a single data point. Rewrote all that logic by
1163 directly observing selectedPoints and currentItem properties instead of taking points and relying on
1164 an instance variable, which was a terrible API.
1165 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
1166 when the main plot has a selected range, we don't have to check this._hasRange anymore.
1168 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
1169 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
1170 (App.InteractiveChartComponent._updateSelection):
1171 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
1172 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
1173 selectedPoints property.
1175 (App.AnalysisTaskController._fetchedRuns):
1176 (App.AnalysisTaskController._rootChangedForTestSet):
1178 * public/v2/index.html:
1179 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
1181 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1183 Unreviewed. Fixed syntax errors.
1185 * init-database.sql:
1186 * public/api/commits.php:
1188 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1190 The dashboard on new perf monitor should be configurable
1191 https://bugs.webkit.org/show_bug.cgi?id=138994
1193 Reviewed by Benjamin Poulain.
1195 For now, make it configurable via config.json. We should eventually make it configurable via
1196 an administrative page but this will do for now.
1198 * config.json: Added the empty dashboard configuration.
1200 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1203 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1204 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1205 Also obtain the default configuration from App.Manifest.
1206 (App.IndexController._normalizeTable): Moved to App.Dashboard.
1208 * public/v2/manifest.js:
1209 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
1210 (App.Repository.urlForRevisionRange): Ditto.
1211 (App.Dashboard): Added.
1212 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
1213 (App.Dashboard.rows): Ditto.
1214 (App.Dashboard.headerColumns): Ditto.
1215 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
1216 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
1217 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
1218 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
1220 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1222 There should be a way to associate bugs with analysis tasks
1223 https://bugs.webkit.org/show_bug.cgi?id=138977
1225 Reviewed by Benjamin Poulain.
1227 Updated associate-bug.php to match the new database schema.
1229 * public/include/json-header.php:
1230 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
1231 already camel-cased in require_existence_of. This makes the function usable elsewhere.
1233 * public/privileged-api/associate-bug.php:
1234 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
1235 Also verify that those values are integers using require_format.
1237 * public/v2/analysis.js:
1238 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
1239 (App.Bug.label): Added.
1240 (App.BugAdapter): Added.
1241 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
1242 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
1244 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
1245 containing the bug information.
1248 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
1249 (App.AnalysisTaskRoute):
1250 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
1251 (App.AnalysisTaskController._fetchedManifest): Added.
1252 (App.AnalysisTaskController.actions.associateBug): Added.
1254 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
1256 * public/v2/data.js:
1257 (Measurement.prototype.associateBug): Deleted.
1259 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
1260 Added a table show the bug information. Also hide the chart until chartData is available.
1262 * public/v2/manifest.js:
1265 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1267 Fix misc bugs and typos in app.js
1268 https://bugs.webkit.org/show_bug.cgi?id=138946
1270 Reviewed by Benjamin Poulain.
1273 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1274 (App.ChartsController.init):
1275 (App.buildPopup): Renamed from App.BuildPopup.
1276 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1277 remove() on the wrong object (an array as opposed to elements in the array).
1278 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1279 _highlights is always an array and evalutes to true.
1281 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1283 New perf dashboard should provide UI to create a new analysis task
1284 https://bugs.webkit.org/show_bug.cgi?id=138910
1286 Reviewed by Benjamin Poulain.
1288 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1289 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1291 With this patch, we can create a new analysis task by selection a range of points and opening
1292 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1293 in the chart hyperlinked to the analysis task.
1295 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1297 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1298 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1300 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1301 and adds the associated bugs to each task in the array.
1304 * public/api/runs.php: Reverted changes made in r175006.
1305 (fetch_runs_for_config):
1308 * public/api/test-groups.php:
1309 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1311 * public/include/db.php:
1312 (Database::select_first_or_last_row):
1313 (Database::select_rows): Extracted from select_first_or_last_row.
1315 * public/v2/analysis.js:
1316 (App.AnalysisTask): Added "bugs" property.
1317 (App.Bug): Added now that bugs are regular data store objects.
1320 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1321 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1322 platform that are associated with a specific range of runs.
1323 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1324 (App.PaneController.actions.associateBug): Deleted.
1325 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1326 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1327 once we've created one.
1328 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1329 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1330 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1331 (App.PaneController._updateBugs): Deleted.
1332 (App.PaneController._updateMarkedPoints): Deleted.
1333 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1334 the name is missing or when at most one point is selected.
1336 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1337 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1338 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1339 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1340 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1341 clickable bars for analysis tasks.
1342 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1343 bar for analysis tasks to place them at the right location.
1344 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1346 * public/v2/chart-pane.css:
1347 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1348 (.chart .rangeBar): Added.
1350 * public/v2/data.js:
1351 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1353 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1354 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1355 task bars in the interactive chart component.
1357 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1359 Fix typos in r176203.
1362 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1363 (App.AnalysisTaskRoute):
1365 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1367 Unreviewed. Updated the install instruction.
1371 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1373 App.Manifest shouldn't use App.__container__.lookup
1374 https://bugs.webkit.org/show_bug.cgi?id=138768
1376 Reviewed by Andreas Kling.
1378 Removed the hack to find the store object via App.__container__.lookup.
1379 Pass around the store object instead.
1382 (App.DashboardRow._createPane): Add "store" property to the pane.
1383 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1384 (App.IndexController.gridChanged): Ditto.
1385 (App.IndexController.actions.addRow): Ditto.
1386 (App.IndexController.init): Ditto.
1387 (App.Pane._fetch): Ditto.
1388 (App.ChartsController._parsePaneList): Ditto.
1389 (App.ChartsController._updateQueryString): Ditto.
1390 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1391 (App.BuildPopup): Ditto.
1392 (App.AnalysisTaskRoute.model): Ditto.
1393 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1395 * public/v2/manifest.js:
1396 (App.Manifest.fetch): Removed the code to find the store object.
1398 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1400 Fix Ember.js warnings the new perf dashboard
1401 https://bugs.webkit.org/show_bug.cgi?id=138531
1403 Reviewed by Darin Adler.
1405 Fixed various warnings.
1408 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1409 * public/v2/data.js:
1410 (PrivilegedAPI._post): Removed the superfluous console.log.
1411 (CommitLogs.fetchForTimeRange): Ditto.
1412 * public/v2/index.html: Added tbody as required by the HTML specification.
1414 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1416 Fix typos in r175768.
1419 (App.AnalysisTaskViewModel.roots):
1421 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1423 Introduce the concept of analysis task to perf dashboard
1424 https://bugs.webkit.org/show_bug.cgi?id=138517
1426 Reviewed by Andreas Kling.
1428 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1429 a single platform and used to bisect regressions in the range.
1431 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1433 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1434 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1435 test runs. Analysis tasks not associated with test runs are used for try new patches.
1436 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1437 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1438 build_requests - A build request represents a single pending build for A/B testing.
1440 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1444 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1445 the specified analysis task group as well as build requests associated with them.
1447 (fetch_test_groups_for_task):
1448 (fetch_build_requests_for_task):
1449 (fetch_build_requests_for_group):
1450 (format_test_group):
1451 (format_build_request):
1453 * public/include/json-header.php:
1454 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1457 * public/privileged-api/associate-bug.php:
1458 (main): Fixed a typo.
1460 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1463 (ensure_config_from_runs):
1465 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1467 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1469 (App.AnalysisTask.create):
1471 (App.TestGroupAdapter):
1472 (App.AnalysisTaskSerializer):
1473 (App.TestGroupSerializer):
1476 * public/v2/app.css: Added style rules for the analysis page.
1479 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1481 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1482 exactly one selected point as we can still create an analysis task.
1483 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1484 grammatical and also alert'ed the error message when there is one.
1485 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1486 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1487 once XHR request has completed.
1488 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1489 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1490 is selected in the details pane.
1492 (App.AnalysisRoute): Added.
1493 (App.AnalysisTaskRoute): Added.
1494 (App.AnalysisTaskViewModel): Added.
1495 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1496 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1497 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1498 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1499 the user selects an option for all roots in A or B configuration.
1500 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1502 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1504 * public/v2/data.js:
1505 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1506 point so that we can use it in App.AnalysisTaskViewModel.roots.
1507 (TimeSeries.prototype.findPointByMeasurementId): Added.
1508 (TimeSeries.prototype.seriesBetweenPoints): Added.
1510 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1511 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1512 when multiple points are selected. Finally, added a new template for the analysis task page.
1514 * public/v2/manifest.js:
1515 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1516 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1517 App.AnalysisTaskViewModel._taskUpdated.
1519 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1521 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1522 https://bugs.webkit.org/show_bug.cgi?id=138111
1524 Reviewed by Darin Adler.
1527 (App.PaneController.bugsChangeCount): Removed.
1528 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1529 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1530 Finds the list of current run's points that are associated with bugs.
1531 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1532 * public/v2/chart-pane.css:
1533 (.chart .marked): Renamed from .hasBugs.
1534 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1536 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1538 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1539 https://bugs.webkit.org/show_bug.cgi?id=138099
1541 Reviewed by Benjamin Poulain.
1543 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1544 _showDetails inverting the order of the current and old measurements.
1547 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1548 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1549 current (latest) measurement and the first point is the oldest measurement.
1550 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1552 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1554 Perf dashboard should provide a way to associate bugs with a test run
1555 https://bugs.webkit.org/show_bug.cgi?id=137857
1557 Reviewed by Andreas Kling.
1559 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1560 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1561 the Apache configuration.
1564 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1565 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1566 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1567 via the cookie and returns a token computed from those two values as well as the remote username.
1569 The font end code then POST's the request along with the returned token. The server side code verifies
1570 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1571 the token hasn't expired.
1574 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1575 have zero or exactly one bug associated with a test run.
1577 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1578 * public/api/runs.php:
1579 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1580 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1581 an associated bug if there is one.
1582 (format_run): Calls parse_bugs_array.
1584 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1585 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1586 have a valid JSON payload.
1587 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1588 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1589 the expiration time stored in the cookie.
1590 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1592 * public/include/manifest.php:
1593 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1594 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1596 * public/index.html:
1597 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1599 * public/privileged-api/associate-bug.php: Added.
1600 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1601 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1603 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1605 * public/v2/app.css:
1606 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1607 selected in a chart.
1610 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1611 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1612 they would overlap on each other if both of them are shown.
1613 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1614 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1615 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1616 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1617 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1618 showing the search pane.
1619 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1620 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1621 bugs in the selected range.
1623 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1624 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1625 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1626 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1627 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1628 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1629 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1630 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1632 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1633 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1634 to selectionChanged action instead of just finding the first and the last points.
1636 * public/v2/chart-pane.css: Updated the style.
1638 * public/v2/data.js:
1639 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1640 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1641 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1642 we haven't already obtained a CSRF token or if the token has already been expired.
1643 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1645 (Measurement.prototype.bugs): Added.
1646 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1647 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1649 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1652 * public/v2/manifest.js:
1653 (App.BugTracker.bugUrl):
1654 (App.BugTracker.newBugUrl): Added.
1655 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1656 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1657 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1658 (App.Manifest.bugTrackers): Added.
1659 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1660 their respective ids to make the ordering stable.
1662 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1664 Remove unused jobs table
1665 https://bugs.webkit.org/show_bug.cgi?id=137724
1667 Reviewed by Daniel Bates.
1669 Removed jobs table in the database as well as related code.
1671 * init-database.sql:
1672 * public/admin/jobs.php: Removed.
1673 * public/admin/tests.php:
1674 * public/include/admin-header.php:
1676 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1678 New perf dashboard should have an ability to search commits by a keyword
1679 https://bugs.webkit.org/show_bug.cgi?id=137675
1681 Reviewed by Geoffrey Garen.
1683 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1684 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1685 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1687 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1688 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1690 * public/api/commits.php:
1691 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1692 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1693 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1694 (format_commit): Renamed from format_commits. Now only formats one commit.
1696 * public/include/db.php:
1697 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1699 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1702 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1703 which is a hash table that contains highlighted items' measurements' ids as keys.
1704 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1705 the default commit repository.
1706 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1707 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1708 Added the code to initialize this._highlights.
1709 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1710 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1711 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1712 the existing lines for the old highlighted items.
1713 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1714 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1716 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1718 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1719 (CommitLogs): Added.
1720 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1721 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1722 (CommitLogs._cacheConsecutiveCommits): Ditto.
1723 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1724 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1725 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1727 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1728 for showingDetails since this property is no longer used.
1730 * public/v2/manifest.js:
1731 (App.Manifest.repositories): Added.
1732 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1733 the default repository to search.
1734 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1736 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1738 Unreviewed build fix after r174555.
1740 * public/include/manifest.php:
1741 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1742 * tests/admin-regenerate-manifest.js: Fixed the test case.
1744 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1746 New perf dashboard UI tries to fetch commits all the time
1747 https://bugs.webkit.org/show_bug.cgi?id=137592
1749 Reviewed by Andreas Kling.
1751 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1752 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1753 no reported commits as they are all going to fail.
1755 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1756 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1757 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1758 of commits sorted chronologically by time.
1760 * public/include/manifest.php:
1763 (App.CommitsViewerComponent.commitsChanged):
1765 * public/v2/data.js:
1766 (FetchCommitsForTimeRange):
1767 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1769 * public/v2/manifest.js:
1772 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1774 Another unreviewed build fix after r174477.
1776 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1778 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1780 * public/include/report-processor.php:
1782 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1784 Unreviewed build fix after r174477.
1786 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1787 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1789 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1790 This is necessary for baseline and target values manually added via admin pages.
1792 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1794 Add v2 UI for the perf dashboard
1795 https://bugs.webkit.org/show_bug.cgi?id=137537
1797 Rubber-stamped by Andreas Kling.
1800 * public/v2/app.css: Added.
1801 * public/v2/app.js: Added.
1802 * public/v2/chart-pane.css: Added.
1803 * public/v2/data.js: Added.
1804 * public/v2/index.html: Added.
1805 * public/v2/js: Added.
1806 * public/v2/js/d3: Added.
1807 * public/v2/js/d3/LICENSE: Added.
1808 * public/v2/js/d3/d3.js: Added.
1809 * public/v2/js/d3/d3.min.js: Added.
1810 * public/v2/js/ember-data.js: Added.
1811 * public/v2/js/ember.js: Added.
1812 * public/v2/js/handlebars.js: Added.
1813 * public/v2/js/jquery.min.js: Added.
1814 * public/v2/js/statistics.js: Added.
1815 * public/v2/manifest.js: Added.
1816 * public/v2/popup.js: Added.
1818 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1820 Remove superfluously duplicated code in public/api/report-commits.php.
1822 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1824 Perf dashboard should store commit logs
1825 https://bugs.webkit.org/show_bug.cgi?id=137510
1827 Reviewed by Darin Adler.
1829 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
1831 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
1832 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
1833 a subversion directory. The git version of this script will be added in a follow up patch.
1836 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
1837 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
1838 relationship via "build_commits" relations.
1840 In order to migrate an existing instance of this application, run the following SQL commands:
1844 INSERT INTO commits (commit_repository, commit_revision, commit_time)
1845 (SELECT DISTINCT ON (revision_repository, revision_value)
1846 revision_repository, revision_value, revision_time FROM build_revisions);
1848 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
1849 FROM commits, build_revisions
1850 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
1852 DROP TABLE build_revisions;
1857 The helper script to submit commit logs can be used as follows:
1859 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
1860 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
1862 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
1863 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
1864 "feeder-slave-password" as the builder name and the builder password respectively.
1866 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
1867 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
1870 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
1872 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
1873 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
1875 - Not specified - It returns every single commit for a given repository.
1876 - Matches "oldest" - It returns the commit with the oldest timestamp.
1877 - Matches "latest" - It returns the commit with the latest timestamp.
1878 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
1879 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
1880 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
1881 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
1882 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
1883 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
1885 (commit_from_revision):
1886 (fetch_commits_between):
1889 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
1890 See tests/api-report-commits.js for examples on how to use this API.
1892 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
1893 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
1894 to optimize this and other JSON APIs.
1896 * public/include/db.php:
1897 (Database::select_or_insert_row):
1898 (Database::update_or_insert_row): Added.
1899 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
1900 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
1902 (Database::select_first_row):
1903 (Database::select_last_row): Added.
1904 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
1905 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
1907 * public/include/report-processor.php:
1908 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
1909 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
1910 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
1913 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
1915 * tests/api-report-commits.js: Added.
1916 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
1919 * tools/pull-svn.py: Added. See above for how to use this script.
1921 (determine_first_revision_to_fetch):
1922 (fetch_revision_from_dasbhoard):
1923 (fetch_commit_and_resolve_author):
1926 (resolve_author_name_from_email):
1929 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
1931 Update Install.md for Mavericks and fix typos
1932 https://bugs.webkit.org/show_bug.cgi?id=137276
1934 Reviewed by Benjamin Poulain.
1936 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
1938 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
1940 Finally, init-database.sql is no longer located inside database directory.
1944 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1946 Report run id's in api/runs.php for the new dashboard UI
1947 https://bugs.webkit.org/show_bug.cgi?id=135813
1949 Reviewed by Andreas Kling.
1951 Include run_id in the generated JSON.
1953 * public/api/runs.php:
1954 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
1957 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1959 Merging platforms mixes baselines and targets into reported data
1960 https://bugs.webkit.org/show_bug.cgi?id=135260
1962 Reviewed by Andreas Kling.
1964 When merging two platforms, move test configurations of a different type (baseline, target)
1965 as well as of different metric (Time, Runs).
1967 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
1968 It's sufficient to detect one such test_runs object.
1970 * public/admin/platforms.php:
1973 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
1975 Merging platforms mixes baselines and targets into reported data
1976 https://bugs.webkit.org/show_bug.cgi?id=135260
1978 Reviewed by Geoffrey Garen.
1980 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
1981 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
1983 * public/admin/platforms.php:
1985 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
1987 Build fix after r171361.
1989 * public/js/helper-classes.js:
1990 (.this.formattedBuildTime):
1992 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
1994 Perf dashboard spends 2s processing JSON data during the page loads
1995 https://bugs.webkit.org/show_bug.cgi?id=135152
1997 Reviewed by Andreas Kling.
1999 In the Apple internal dashboard, we were spending as much as 2 seconds
2000 converting raw JSON data into proper JS objects while loading the dashboard.
2002 This caused the apparent unresponsiveness of the dashboard despite of the fact
2003 charts themselves updated almost instantaneously.
2005 * public/index.html:
2006 * public/js/helper-classes.js:
2007 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
2008 lazily as creating new Date objects and running string replace is expensive.
2009 (TestBuild.formattedTime):
2010 (TestBuild.formattedBuildTime):
2011 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
2012 (PerfTestRuns.addResult): Deleted.
2014 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
2016 Perf dashboard shouldn't show the full git hash
2017 https://bugs.webkit.org/show_bug.cgi?id=135083
2019 Reviewed by Benjamin Poulain.
2021 Detect Git/Mercurial hash by checking the length.
2023 If it's a hash, use the first 8 characters in the label
2024 while retaining the full length to be used in hyperlinks.
2026 * public/js/helper-classes.js:
2027 (.this.formattedRevisions):
2030 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
2032 Add an instruction on how to backup the database.
2033 https://bugs.webkit.org/show_bug.cgi?id=133391
2035 Rubber-stamped by Andreas Kling.
2039 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2041 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
2043 * public/js/helper-classes.js:
2044 (PerfTestRuns.smallerIsBetter):
2046 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2050 * public/common.css:
2052 * public/index.html:
2056 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2058 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
2059 https://bugs.webkit.org/show_bug.cgi?id=131157
2061 Reviewed by Andreas Kling.
2063 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
2064 This allows, for example, adding all metrics such as Arithmetic and Geometric for
2065 a given test suite without also adding its subtests.
2067 * public/index.html:
2071 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2073 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
2074 https://bugs.webkit.org/show_bug.cgi?id=131155
2076 Reviewed by Andreas Kling.
2078 The bug was caused by Chart.attach binding event listeners on plot container on each call.
2079 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
2080 click when attach() has been called even number of times, keeping the tooltip invisible.
2082 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
2083 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
2084 is called for the first time.
2086 * public/index.html:
2088 (Chart..bindPlotEventHandlers):
2090 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2092 WebKitPerfMonitor: Tooltips can be cut off at the top
2093 https://bugs.webkit.org/show_bug.cgi?id=130960
2095 Reviewed by Andreas Kling.
2097 * public/common.css:
2098 (#title): Removed the gradients, box shadows, and border from the header.
2099 (#title h1): Reduce the font size.
2100 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
2101 * public/index.html:
2102 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
2103 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
2104 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
2105 * public/js/helper-classes.js:
2106 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
2107 tooltip extending above y=0.
2109 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2111 WebKitPerfMonitor: Y-axis adjustment is too aggressive
2112 https://bugs.webkit.org/show_bug.cgi?id=130937
2114 Reviewed by Andreas Kling.
2116 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
2117 results. This had two major problems:
2118 1. Two standard deviations can be too small to show the confidence interval for results.
2119 2. Sometimes baseline and target can be more than two standards deviations away.
2121 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
2122 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
2123 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
2124 the margin on each side separately to reduce the empty space on either side.
2126 A more rigorous approach would involve computing least squared value of results with respect to intervals
2127 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
2129 * public/index.html:
2130 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
2131 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
2132 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
2133 We wouldn't see the difference between measured values versus baseline and target values otherwise.
2134 * public/js/helper-classes.js:
2135 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
2136 interval delta cannot be computed.
2137 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
2138 within the given interval.
2139 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
2140 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
2141 (PerfTestRuns..unscaledMeansForAllResults):
2142 (PerfTestRuns.min): Take the confidence interval delta into account.
2143 (PerfTestRuns.max): Ditto.
2144 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
2145 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
2147 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
2149 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
2151 Some CSS tweaks after r166477 and r166479,
2153 * public/index.html:
2155 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2157 WebKitPerfMonitor: Sometimes text inside panes overlap
2158 https://bugs.webkit.org/show_bug.cgi?id=130956
2160 Reviewed by Gyuyoung Kim.
2162 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
2163 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
2164 reduces the total height of the pane and fits more information per screen capita on the dashboard.
2166 * public/index.html: Updated and added a bunch of CSS rules for the new look.
2167 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
2168 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
2169 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
2170 of the build info shown in a chart pane and a tooltip.
2171 (Chart): Made .status a table.
2172 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
2173 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
2174 now that status.text no longer contains it.
2175 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
2177 * public/js/helper-classes.js:
2178 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
2179 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
2180 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
2181 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
2182 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
2183 capital letter; e.g. "MB" instead of "M B".
2185 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2187 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
2188 https://bugs.webkit.org/show_bug.cgi?id=130957
2190 Reviewed by Gyuyoung Kim.
2192 Moved the slider into the header. Also reduced the spacing between the header and platform names.
2193 This reclaims 50px × width of the screen real estate.
2195 * public/common.css:
2196 (#title): Reduced the space below the header from 20px to 10px.
2197 * public/index.html:
2198 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
2199 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
2200 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
2201 real estate between the header and the platform names.
2203 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2205 Update the install guidelines for perf.webkit.org
2206 https://bugs.webkit.org/show_bug.cgi?id=129895
2208 Reviewed by Ryosuke Niwa.
2210 The current install guideline for perf.webkit.org discourages the use of the installed
2211 Server application. I've actualized the documentation for Mavericks, and modified the
2212 guideline to include the instructions for Server.app also.
2216 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
2218 Update perf.webkit.org json example
2219 https://bugs.webkit.org/show_bug.cgi?id=129907
2221 Reviewed by Andreas Kling.
2223 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
2227 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
2229 Merge database-common.js and utility.js into run-tests.js.
2231 Reviewed by Matthew Hanson.
2233 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
2234 Also moved init-database.sql out of the database directory and removed the directory entirely.
2236 * database: Removed.
2237 * database/database-common.js: Removed.
2238 * database/utility.js: Removed.
2239 * init-database.sql: Moved from database/init-database.sql.
2241 (connect): Moved from database-common.js.
2242 (pathToDatabseSQL): Extracted from pathToLocalScript.
2243 (pathToTests): Moved from database-common.js.
2246 (SerializedTaskQueue): Ditto.
2248 (initializeDatabase):
2249 (TestEnvironment.it):
2250 (TestEnvironment.queryAndFetchAll):
2253 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2255 Remove the dependency on node.js from the production code.
2257 Reviewed by Ricky Mondello.
2259 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
2261 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
2262 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
2263 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
2264 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
2265 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
2267 Also removed the js files that are no longer used.
2269 * config.json: Moved from database/config.json.
2270 * database/aggregate.js: Removed. No longer used.
2271 * database/database-common.js: Removed unused functions, and updated the path to config.json.
2272 * database/process-jobs.js: Removed. No longer used.
2273 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2274 * database/schema.graffle: Removed. It's completely obsolete.
2275 * public/include/db.php: Updated the path to config.json.
2276 * public/include/evaluator.js: Removed.
2278 * public/include/report-processor.php:
2279 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2280 storing values into $expressions and calling evaluate_expressions_by_node.
2281 (TestRunsGenerator::aggregate_values): Added.
2282 (TestRunsGenerator::compute_caches): Directly compute the caches.
2284 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2286 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2288 * public/admin/platforms.php:
2289 * public/include/db.php:
2291 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2293 Zoomed y-axis view is ununsable when the last result is an outlier.
2295 Reviewed by Stephanie Lewis.
2297 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2298 the last result so that the graph looks sane if the last result was an outlier. However, always show
2299 the last result's mean even if it was an outlier.
2301 * public/index.html:
2302 * public/js/helper-classes.js:
2303 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2304 Also added the ability to cache the unscaled means to avoid recomputation.
2305 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2306 (PerfTestRuns.max): Ditto.
2307 (PerfTestRuns.sampleStandardDeviation): Ditto.
2308 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2310 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2314 * public/admin/tests.php:
2315 * public/js/helper-classes.js:
2317 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2319 Use two standard deviations instead as I mentioned in the mailing list.
2321 * public/index.html:
2323 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2325 The performance dashboard erroneously shows upward arrow for combined metrics.
2327 A single outlier can ruin the zoomed y-axis view.
2329 Rubber-stamped by Antti Koivisto.
2331 * public/index.html:
2332 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2333 from the latest results' mean.
2334 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2335 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2336 (Chart.toggleYAxis):
2337 * public/js/helper-classes.js:
2338 (PerfTestRuns.sampleStandardDeviation): Added.
2339 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2341 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2343 Don't include the confidence interval when computing the y-axis.
2345 Rubber-stamped by Simon Fraser.
2347 * public/js/helper-classes.js:
2351 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2353 Tiny CSS tweak for tooltips.
2355 * public/index.html:
2357 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2359 Remove the erroneously repeated code.
2361 * public/admin/test-configurations.php:
2363 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2365 <rdar://problem/15704893> perf dashboard should show baseline numbers
2367 Reviewed by Stephanie Lewis.
2369 * public/admin/bug-trackers.php:
2370 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2373 * public/admin/platforms.php:
2374 (merge_list): Ditto.
2376 * public/admin/test-configurations.php: Added.
2377 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2378 build_revisions as they're not meaningful for baseline / target numbers.
2379 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2380 one test run so that we don't accidentally delete a reported test run.
2381 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2382 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2383 and delete existing ones.
2385 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2386 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2387 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2389 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2390 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2391 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2392 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2393 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2395 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2397 * public/include/admin-header.php:
2398 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2399 have id and type sub columns, and each custom column could generate multiple rows.
2401 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2402 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2403 We then proceed to generate the second header row with sub column names.
2405 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2406 which case regular columns need rowspan set to the maximum number of rows.
2408 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2411 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2412 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2413 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2414 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2415 expanded to occupy all sub columns.
2417 * public/include/manifest.php:
2418 (ManifestGenerator::platforms): Don't add the metric more than once.
2420 * public/include/test-name-resolver.php:
2421 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2422 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2423 full metric name later.
2424 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2425 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2426 (TestNameResolver::full_name_for_test): Added.
2427 (TestNameResolver::full_name_for_metric): Added.
2428 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2430 * public/js/helper-classes.js:
2431 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2432 test runs created to set baseline and target points.
2434 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2436 Build fix after r57928. Removed a superfluous close parenthesis.
2438 * public/api/runs.php:
2440 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2442 Unreviewed build & typo fixes.
2444 * public/admin/platforms.php:
2445 * tests/admin-platforms.js:
2447 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2449 <rdar://problem/15704893> perf dashboard should show baseline numbers
2451 Rubber-stamped by Antti Koivisto.
2453 Organize some code into functions in runs.php.
2455 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2457 * public/api/runs.php:
2458 (fetch_runs_for_config): Extracted.
2459 (format_run): Ditto.
2461 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2463 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2465 * database/config.json:
2466 * public/admin/reprocess-report.php:
2467 * public/api/report.php:
2468 * public/api/runs.php:
2469 * public/include/json-header.php:
2471 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2473 Commit yet another forgotten change.
2475 Something went horribly wrong with my merge :(
2477 * database/init-database.sql:
2479 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2481 Commit one more forgotten change. Sorry for making a mess here.
2483 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2485 Commit the forgotten files.
2487 * public/admin/platforms.php: Added.
2488 * tests/admin-platforms.js: Added.
2490 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2492 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2494 Reviewed by Stephanie Lewis.
2496 Added /admin/platforms/ page to hide and merge platforms.
2498 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2499 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2500 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2501 each test configuration a distinct "test run" for each build.
2503 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2504 their test configurations into platform B.
2506 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2507 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2508 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2509 in platform B, in which case R should relate to T_B instead.
2511 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2512 new platform. We then migrate the test configurations of the remaining test runs.
2514 * database/init-database.sql: Added platform_hidden.
2516 * public/admin/platforms.php: Added.
2517 (merge_platforms): Added. Implements the algorithm described above.
2518 (merge_list): Added.
2520 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2521 is hidden since it doesn't do anything.
2523 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2524 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2525 missing it since unchecked checkbox doesn't set the value in $_POST.
2526 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2527 switch statement instead of repeated if's.
2528 (AdministrativePage::render_table): Emit "update-column" for update_field.
2530 * public/include/db.php: Disable warnings when we're not in the debug mode.
2532 * public/include/manifest.php:
2533 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2536 (TestEnvironment.postJSON):
2537 (TestEnvironment.httpGet):
2538 (TestEnvironment.httpPost): Added.
2539 (sendHttpRequest): Set the content type if specified.
2541 * tests/admin-platforms.js: Added tests.
2543 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2545 Extract the code to compute full test names from tests.php.
2547 Reviewed by Stephanie Lewis.
2549 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2550 and paves our way to re-use the code in other pages.
2552 * public/admin/tests.php:
2554 * public/include/db.php:
2555 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2556 tests.php and test-name-resolver.php.
2558 * public/include/test-name-resolver.php: Added.
2559 (TestNameResolver::__construct):
2560 (TestNameResolver::compute_full_name): Moved from tests.php.
2561 (TestNameResolver::map_metrics_to_tests): Ditto.
2562 (TestNameResolver::sort_tests_by_full_name): Ditto.
2563 (TestNameResolver::tests): Added.
2564 (TestNameResolver::test_id_for_full_name): Ditto.
2565 (TestNameResolver::metrics_for_test_id): Ditto.
2566 (TestNameResolver::child_metrics_for_test_id): Ditto.
2567 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2569 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2571 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2573 Reviewed by Stephanie Lewis.
2575 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2577 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2578 but that's sufficient to correct the wrongfully processed reports for now.
2580 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2581 We should eventually add a nice UI to find and reprocess reports.
2583 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2585 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2587 * public/include/report-processor.php: Copied from public/api/report.php.
2588 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2589 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2590 create a new report or authenticate the builder password (the password is never stored in the report).
2591 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2592 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2593 (ReportProcessor::store_report): Ditto.
2595 * tests/admin-reprocess-report.js: Added.
2597 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2599 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2601 Reviewed by Ricky Mondello.
2603 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2604 for the same build number as a single build by ignoring build time. This was necessary to associate
2605 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2606 we use to submit results computed its own "build time" when they're called.
2608 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2609 last week; new reports were wrongfully associated with old build numbers.
2611 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2612 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2613 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2615 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2616 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2617 (builder, build number, build time).
2619 * public/api/report.php:
2620 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2621 when no such build exists. This prevents a report from being associated with a very old build of the same
2624 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2625 a similar bug in the future sooner.
2627 * tests/api-report.js: Added three test cases.
2629 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2631 Merged the upstream changes to db.php
2632 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2634 * public/include/db.php:
2636 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2638 Update other scripts and tests per previous patch.
2640 * public/include/manifest.php:
2641 * tests/admin-regenerate-manifest.js:
2643 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2645 Remove metrics_unit.
2647 Reviewed by Ricky Mondello.
2649 This column is no longer used by the front-end code since r48360.
2651 * database/init-database.sql:
2652 * public/admin/tests.php:
2654 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2656 Unreviewed build fix.
2658 * public/api/report.php:
2660 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2662 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2664 Reviewed by Ricky Mondello.
2666 Support a new alternative format for aggregated results where we have raw values as well as
2667 the list aggregators so that instead of
2668 "metrics": {"Time": ["Arithmetic"]}
2670 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2672 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2673 dashboard and the generated results page, which doesn't know how to aggregate values.
2675 We need to keep the support for the old format because all other existing performance tests
2676 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2677 the old format during the transition.
2679 * public/api/report.php:
2680 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2681 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2683 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2685 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2687 Unreviewed; Tweak the CSS so that chart panes align vertically.
2689 * public/index.html:
2691 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2693 SafariPerfMonitor should support Combined metric.
2695 * public/js/helper-classes.js:
2696 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2697 value as well but assume it to be greater-is-better for now.
2699 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2701 Commit the forgotten init-database change to add iteration_relative_time.
2703 * database/init-database.sql:
2705 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2707 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2709 Reviewed by Ricky Mondello.
2711 Add the support for each value to have a relative time. This is necessary for frame rate history
2712 since a frame rate needs to be associated with a time it was sampled.
2714 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2716 * public/api/report.php:
2717 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2718 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2719 with relative time since taking the average of two frame rates for two subtests taken at two
2720 different times doesn't make any sense.
2721 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2722 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2723 Also exit early with an error if the number of elements in the array is not a pair.
2724 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2726 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2727 iteration_relative_time.
2729 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2731 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2733 Reviewed by Ricky Mondello.
2735 Support that. It's one line change.
2737 * public/api/report.php:
2738 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2739 to match the convention assumed elsewhere.
2740 * tests/api-report.js: Added a test case.
2742 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2744 SafariPerfMonitor shows popups for points outside of the visible region.
2746 Rubber-stamped by Simon Fraser.
2748 * public/index.html:
2749 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2750 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2751 may return an item underneath y-axis labels.
2753 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2755 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2757 * public/index.html:
2759 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2761 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2763 * public/index.html:
2765 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2767 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2768 <rdar://problem/13992271> Should scale Y axis to include error ranges
2770 Reviewed by Ricky Mondello.
2772 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2773 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2775 * database/config.json:
2776 * public/index.html:
2777 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2778 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2779 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2781 * public/js/helper-classes.js:
2782 (PerfTestResult.confidenceIntervalDelta):
2783 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2784 (PerfTestRuns.min): Take confidence interval delta into account.
2785 (PerfTestRuns.max): Ditto.
2786 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2788 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2790 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2792 * public/api/report.php:
2793 (ReportProcessor::recursively_ensure_tests):
2794 * tests/api-report.js: Added a test.
2796 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2798 Unreviewed build fixes.
2800 * public/api/report.php:
2801 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
2802 Also, tolerate reports without any revision information.
2804 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
2807 * tests/api-report.js: Added few test cases.
2809 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2811 Commit another change that was supposed to be committed in r50331.
2814 (TestEnvironment.this.postJSON):
2815 (TestEnvironment.this.httpGet):
2818 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
2820 Commit the remaining files.
2822 * public/admin/regenerate-manifest.php:
2823 * public/include/admin-header.php:
2824 * public/include/json-header.php:
2825 * public/include/manifest.php:
2827 (TestEnvironment.this.postJSON):
2828 (TestEnvironment.this.httpGet):
2831 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
2833 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
2835 Reviewed by Ricky Mondello.
2837 Added some tests for admin/regenerate-manifest.
2839 * public/admin/regenerate-manifest.php: Use require_once instead of require.
2840 * public/include/admin-header.php: Ditto.
2841 * public/include/json-header.php: Ditto.
2843 * public/include/manifest.php:
2844 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
2845 When there are no builders, simply return an empty array.
2848 (TestEnvironment.postJSON):
2849 (TestEnvironment.httpGet): Added.
2850 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
2852 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
2854 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
2856 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
2857 and run_iterations. Also fixed a typo in report.php found by new tests.
2859 * public/api/report.php:
2860 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
2861 * tests/api-report.js: Added more test cases.
2863 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
2865 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
2867 Reviewed by Ricky Mondello.
2869 Add a test runner script and some simple test cases.
2871 * database/config.json: Added the configuration for "testServer".
2872 * database/database-common.js:
2873 (pathToTests): Added.
2874 * run-tests.js: Added.
2877 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
2878 and if there are, asks the user if it’s okay to delete all of the data contained therein.
2879 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
2881 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
2882 in the current database using PostgreSQL's information_schema.
2883 (askYesOrNoQuestion):
2885 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
2887 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
2888 (TestEnvironment.assert): Exposes assert to tests.
2889 (TestEnvironment.console): Exposes console to tests.
2890 (TestEnvironment.describe): Adds a description.
2891 (TestEnvironment.it): Adds a test case.
2892 (TestEnvironment.postJSON):
2893 (TestEnvironment.queryAndFetchAll):
2894 (TestEnvironment.sha256):
2895 (TestEnvironment.notifyDone): Ends the current test case.
2899 (TestContext): An object created for each test case. Conceptually, this object is always on
2900 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
2901 this object via currentTestContext.
2902 (TestContext.description):
2904 (TestContext.logError):
2907 * tests/api-report.js: Added some basic tests for /api/report.php.
2909 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2911 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
2913 The problem was that we were detecting whether we're updating dashboard or not by checking
2914 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
2915 all configurations. Use separate 'dashboard' action to execute the code even when
2916 metric_configurations is empty.
2918 * public/admin/tests.php:
2920 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2922 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
2924 Reviewed by Ricky Mondello.
2926 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
2927 from ReportProcessor as a preparation to replace deprecated aggregate.js.
2929 * public/api/report.php:
2930 (ReportProcessor::exit_with_error): Moved.
2931 (ReportProcessor::process): Use the extracted TestRunsGenerator.
2932 (TestRunsGenerator): Added.
2933 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
2934 (TestRunsGenerator::add_aggregated_metric): Moved.
2935 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
2936 (TestRunsGenerator::aggregate): Moved. Made public.
2937 (TestRunsGenerator::aggregate_current_test_level): Moved.
2938 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
2939 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
2940 (TestRunsGenerator::compute_caches): Moved. Made public.
2941 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
2942 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
2943 (TestRunsGenerator::rollback_with_error): Moved.
2945 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2947 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
2949 Reviewed by Remy Demarest.
2951 Regenerate the manifest file when updating fields or adding new items that are included in
2954 * public/admin/bug-trackers.php:
2955 * public/admin/builders.php:
2956 * public/admin/regenerate-manifest.php:
2957 * public/admin/repositories.php:
2958 * public/admin/tests.php:
2959 * public/include/admin-header.php:
2960 (regenerate_manifest): Extracted from regenerate-manifest.php.
2962 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2964 Unreviewed build fix for memory test results.
2966 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
2967 aggregating at each level.
2969 * public/api/report.php:
2970 (ReportProcessor::recursively_ensure_tests):
2971 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
2972 (ReportProcessor::add_values_for_aggregation):
2973 (ReportProcessor::aggregate):
2974 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
2976 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
2978 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
2979 not the number of iteration groups. Also, don't set group number when the entire run belongs
2980 a single iteration group.
2982 * public/api/report.php:
2983 (ReportProcessor::commit):
2985 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2987 SafariPerfMonitor: Introduce iteration groups
2989 Reviewed by Remy Demarest.
2991 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
2992 the runtime environment variances to get more stable results. And it's desirable to keep track of
2993 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
2995 This patch introduces "iteration groups" to keep track of this extra information.
2997 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
2998 the outer array denotes iteration groups and each inner array contains iteration values for each group.
3001 * database/init-database.sql: Add iteration_group column.
3002 * public/api/report.php:
3003 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
3005 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
3006 contains the list of values indexed by the iteration order and group sizes. Store the group size so
3007 that we can restore the iteration groups before passing it to node.js and restore them later.
3009 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
3010 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
3012 Also check that each iteration group in each subtest are consistent with one another. To see why we need
3013 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
3014 that each iteration group in T1 and T2 have the same size:
3015 T1 = [[1, 2], [3, 4, 5]]
3016 T2 = [[6, 7], [8, 9, 10]]
3018 so that the aggregated result (the sum in this case) can have the same groups as in:
3019 T = [[7, 9], [11, 13, 15]]
3021 If some iteration groups in T1 and T2 had a different size as in:
3022 T1 = [[1, 2, 3], [4, 5]]
3023 T2 = [[6, 7], [8, 9, 10]]
3025 Then iteration groups of the aggregated T is ambiguous.
3027 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
3028 (ReportProcessor::commit): Store iteration_group values.
3030 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3032 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
3033 migrated to perf.webkit.org.
3035 * database/perf-webkit-migrator.js: Removed.
3037 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3039 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
3041 * public/index.html:
3044 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3046 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
3048 Reviewed by Ricky Mondello.
3050 It is often desirable to see charts of a given test for all platforms, or to be able to see
3051 charts of all subtests on a given platform when trying to triage perf. regressions.
3053 Support this use case by adding the ability to do so on the charts page.
3055 Also, we used to disable items on the test list based on the platform chosen. This turned out
3056 to be a bad UI because in many situations you want to be able to compare results of the same test
3057 on multiple platforms.
3059 In this new UI, we have three select elements, each of which selects the following:
3060 1. Top-level test - Test suite such as Dromaeo
3061 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
3062 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
3063 3. Platform - Mountain Lion, Qt, etc...
3065 A user can select "all" for metric and platform but we disallow doing both at once since adding
3066 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
3067 think of a use case where you want to look at that many charts at once. We can support this later
3068 if valid use cases come up.
3070 * public/index.html:
3071 (.showCharts.addOption): Extracted.
3072 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
3073 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
3074 metricList has onchange handler that enables/disables items on platformList.
3076 (init): Sort tests and test metrics here instead of doing that in showCharts.
3078 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
3080 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
3082 Reviewed by Remy Demarest and Ricky Mondello.
3084 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
3085 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
3086 templates to the manifest file instead. Each build now only contains the builder id.
3088 * public/api/runs.php: Removed the part of the query that joined builders table. This
3089 speeds up the query quite a bit.
3091 * public/include/manifest.php:
3092 (ManifestGenerator::generate): Generate builders field.
3093 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
3094 associative array that contains name and its build URL template.
3096 * public/index.html:
3097 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
3098 instead of a revision since this function is used for revisions and build page URLs now.
3099 (.buildLabelWithLinks): Include the linkified build number.
3101 * public/js/helper-classes.js:
3102 (TestBuild.builder): Added.
3103 (TestBuild.buildNumber): Added.
3104 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
3105 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
3107 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
3109 Tooltips interfere with user interactions
3111 Rubber-stamped by Simon Fraser.
3113 Disable tooltip on the dashboard page since graphs are too small to be useful there.
3114 Also, show graphs for only 10 days by default as opposed to 20.
3115 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
3117 * public/index.html:
3118 * public/js/helper-classes.js:
3120 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
3122 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
3123 to be compatible with webkit-perf.appspot.com.
3125 * public/admin/builders.php:
3126 * public/api/report.php:
3128 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
3132 Add a missing constraint on builds table. For a given builder, there should be exactly
3133 one build for a given build number.
3135 Also add report_committed_at to reports table to record the time at which a given report
3136 was processed and test_runs and run_iterations rows were committed into the database.
3138 * database/config.json:
3139 * public/api/report.php:
3141 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
3143 Unreviewed. Add more checks for empty SQL query results.
3145 * public/include/manifest.php:
3147 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3149 More build fixes on perf.webkit.org.
3151 * public/api/runs.php: Make PostgreSQL happier.
3152 * public/include/manifest.php: Don't assume we always have bug trackers.
3154 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3156 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
3157 and fix other miscellaneous UI bugs.
3159 Rubber-stamped by Simon Fraser.
3161 Removed the code to determine whether smaller value is better or not for a given test in index.html
3162 in the favor of using that of PerfTestRuns.
3164 * public/include/manifest.php: Fixed a typo.
3165 * public/index.html:
3167 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
3169 * public/js/helper-classes.js:
3170 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
3172 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
3173 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
3174 at roughly 2,000 units to avoid this.
3176 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
3177 The only thing we can avoid is innerHTML.
3179 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3181 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
3183 * public/include/evaluator.js:
3185 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3187 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
3189 Reviewed by Remy Demarest.
3191 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
3192 admin/bug-trackers.php and can be associated with multiple repositories.
3194 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
3195 to determine the set of bug trackers to show for a given set of blame lists.
3196 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
3197 a place to file bugs against the regression.
3199 * database/init-database.sql: Added bug_trackers and tracker_repositories.
3200 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
3202 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
3203 bug trackers, namely associated repositories.
3205 * public/include/admin-header.php: Added a link to bug-trackers.php
3206 * public/include/manifest.php:
3207 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
3208 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
3210 (ManifestGenerator::repositories):
3212 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
3213 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
3214 'repositories' where the latter contains the list of associated repository names.
3216 * public/index.html:
3217 (Chart): Takes bugTrackers as as argument.
3218 (Chart.showTooltipWithResults): Removed the hard-coded list.
3220 (init.addPlatformsToDashboard):
3221 (init.showCharts.createChartFromListPair):
3222 (init): Stores the list of bug trackers in the manifest to a local variable.
3224 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3226 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
3228 * public/include/evaluator.js:
3230 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3232 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
3234 Reviewed by Remy Demarest.
3236 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
3237 new row into the database.
3239 * public/admin/aggregators.php: Use AdministrativePage.
3240 * public/admin/builders.php: Ditto.
3241 * public/admin/repositories.php: Ditto.
3242 * public/include/admin-header.php:
3243 (AdministrativePage): Added.
3244 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
3245 to an associative array that describes the column.
3246 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
3247 - label: Human readable name of the column.
3248 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
3249 column exists only before we create password_hash column at the insertion time.
3251 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
3252 titlecase (e.g. new_bug is converted to New Bug).
3253 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
3254 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
3255 textarea for a given editing mode ('text', 'url', or 'string').
3256 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
3257 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
3259 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
3261 Build fix. Some systems don't support r+. Use proc_open instead.
3263 * public/api/report.php:
3265 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3267 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
3268 when computing the y-axis of data points to show tooltips at.
3270 * public/index.html:
3272 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3274 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
3277 * public/.htaccess: Removed.
3279 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
3283 * public/include/manifest.php: Build fix. db is on this.
3284 * public/js/statistics.js:
3285 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
3287 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
3289 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
3291 Reviewed by Anders Carlsson.
3293 Rewrote and merged populate-from-report.js into report.php.
3295 * database/config.json: Added a path to node.js.
3297 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
3298 Once we land this patch and update the administrative pages, we can remove this column.
3300 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
3301 that table is going away once we remove the node.js backend.
3303 * database/populate-from-report.js: Removed.
3304 * public/api/report.php: Added.
3306 (ReportProcessor.__construct):
3307 (ReportProcessor.process):
3309 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
3310 verified to be submitted by a known builder.
3312 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
3313 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
3314 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
3315 inside a transaction because there could be multiple reports for a single build, each containing results for
3318 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
3319 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
3320 add_values_to_commit, and add_values_for_aggregation.
3322 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
3323 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
3324 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
3327 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
3328 to be aggregated in ReportProcessor.aggregate.
3330 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
3332 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
3333 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
3334 given for each row (child metrics of M). This function extracts each column (iteration) via
3335 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
3336 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
3338 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
3339 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
3340 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
3342 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
3343 (ReportProcessor.evaluate_expressions_by_node): See above.
3345 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
3346 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
3347 results also need the said caches.
3349 (ReportProcessor.add_values_to_commit):
3351 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
3352 the transaction as needed if anything goes wrong.
3354 (ReportProcessor.rollback_with_error)
3356 * public/include/db.php:
3357 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
3358 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
3359 contiguously in a SQL statement.
3361 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
3362 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
3363 a column value of the choice.
3365 (Database.begin_transaction): Added.
3366 (Database.commit_transaction): Added.
3367 (Database.rollback_transaction): Added.
3369 * public/include/evaluator.js: Added.
3370 * public/include/json-header.php:
3371 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
3372 context under which the request failed.
3373 (successful_exit): Merge "additional details".
3374 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
3375 (merge_additional_details):
3377 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
3379 SafariPerfMonitor: Add more helper functions to db.php
3381 Reviewed by Remy Demarest.
3383 Added Database::insert_row and array_get to make common database operations easier.
3385 * public/admin/aggregators.php: Use Database::insert_row instead of
3386 execute_query_and_expect_one_row_to_be_affected.
3388 * public/admin/builders.php: Ditto.
3390 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
3391 inserting a row. With insert_row, we don't need that.
3393 * public/include/admin-header.php: Ditto.
3395 * public/include/db.php:
3396 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
3397 return the default value (defaults to NULL) if the key doesn't exist.
3399 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
3402 (Database::prepare_params): Added. Takes an associative array of column names and their values,
3403 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
3404 column names all in the same order.
3406 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
3407 the given prefix. Values are given in a form of an associative array where keys are unprefixed
3408 column names and values are corresponding values. When the row is successfully inserted, it returns
3409 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
3410 indicating the success of the insertion.
3412 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3414 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
3416 Reviewed by Conrad Shultz.
3418 Rewrote the manifest generator in PHP.
3420 * database/generate-manifest.js: Removed.
3421 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
3422 * public/include/db.php:
3423 (array_ensure_item_has_array): Added.
3424 * public/include/evaluator.js: Added.
3425 * public/include/json-header.php:
3426 * public/include/manifest.php: Added.
3428 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3430 Dates on overflow plot are overlapping
3432 Rubber-stamped by Simon Fraser.
3434 Don't show more than 5 days.
3436 * public/index.html:
3437 * public/js/helper-classes.js:
3438 (TestBuild.UTCtoPST):
3441 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3443 Show build time as well as commit time on the dashboard and tooltips.
3445 Rubber-stamped by Simon Fraser.
3447 Include both the maximum commit time and build time in buildLabelWithLinks.
3448 Also use ISO format to save the screen real estate.
3450 * public/index.html:
3451 (buildLabelWithLinks):
3452 * public/js/helper-classes.js:
3454 (TestBuild.buildTime):
3455 (TestBuild.formattedBuildTime):
3457 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
3459 Unreviewed; Convert metric.name to metric.unit in the front end.
3461 * public/js/helper-classes.js:
3463 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3465 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
3467 Rubber-stamped by Simon Fraser.
3469 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
3470 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
3471 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
3473 * public/index.html:
3474 (.buildLabelWithLinks): Extracted from TestBuild.label.
3475 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
3476 on Radar and WebKit Bugzilla.
3477 * public/js/helper-classes.js:
3478 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
3479 (PerfTestResult.isBetterThan): Added.
3480 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
3481 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
3482 to indicate progressions or regressions.
3483 (PerfTestResult.label):
3484 (TestBuild.formattedTime): Added.
3485 (TestBuild.platform): Added.
3486 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
3487 (TestBuild.smallerIsBetter): Added.
3488 (Tooltip.show): Take a raw markup instead of two results.
3490 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
3492 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
3494 Rubber-stamped by Tim Horton.
3496 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
3497 since each platform may have a different number of tests to be shown on the dashboard.
3499 * public/index.html:
3501 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3503 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
3505 * public/js/helper-classes.js:
3508 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3510 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
3512 Rubber-stamped by Tim Horton.
3514 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
3516 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
3517 the revision r1234 was the revision used in the previous build.
3519 * public/api/runs.php:
3520 (parse_revisions_array): Trim double quotations around repository names and revisions.
3521 * public/js/helper-classes.js:
3524 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3526 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
3528 Rubber-stamped by Tim Horton.
3530 * public/index.html:
3531 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
3532 on the dashboard page as it's way too noisy.
3534 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
3536 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
3537 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
3538 so that the tooltip for hover can be reused further.
3540 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
3541 and find the first point that lies on the right of the cursor position. We then compute the midpoint
3542 between this and the previous point and pick the closer of the two. It returns an item-like object
3543 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
3545 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
3547 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
3548 the first or "current" data points (as opposed to target or baseline data points).
3550 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
3551 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
3552 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
3554 * public/js/helper-classes.js:
3555 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
3556 work to the client via bindClick.
3558 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
3560 (Tooltip.bindClick): Added.
3562 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3564 Yet another build fix. metricId*s*.
3566 * public/admin/tests.php:
3568 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3570 Another build fix. Use the new payload format for the aggregate job.
3572 * public/admin/tests.php:
3574 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3578 * database/aggregate.js: Use variables that actually exist.
3579 * database/database-common.js:
3580 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
3581 function calls will find this configuration.
3583 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3585 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
3587 Reviewed by Ricky Mondello.
3589 Turned InstallManual into a proper markdown document and added ReadMe.md.
3591 * InstallManual: Removed.
3592 * InstallManual.md: Moved from InstallManual.
3595 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3597 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
3599 Reviewed by Ricky Mondello.
3601 This patch prepares the front end code to process baseline and target results properly.
3603 * public/index.html:
3604 (fetchTest.createRunAndResults): Extracted.
3605 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
3606 Deleted the comment about how sorting will be unnecessary once we start results in the server side
3607 since sorting by the maximum revision commit time turned out to be non-trivial in php.
3609 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3611 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
3613 Reviewed by Tim Horton.
3615 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
3616 These files are "dynamically linked" to our app.
3618 * public/index.html:
3619 * public/js/jquery-1.8.2.min.js: Removed.
3620 * public/js/jquery.colorhelpers.js: Added.
3621 * public/js/jquery.flot.categories.js: Added.
3622 * public/js/jquery.flot.crosshair.js: Added.
3623 * public/js/jquery.flot.errorbars.js: Added.
3624 * public/js/jquery.flot.fillbetween.js: Added.
3625 * public/js/jquery.flot.js: Added.
3626 * public/js/jquery.flot.min.js: Removed.
3627 * public/js/jquery.flot.navigate.js: Added.
3628 * public/js/jquery.flot.resize.js: Added.
3629 * public/js/jquery.flot.selection.js: Added.
3630 * public/js/jquery.flot.stack.js: Added.
3631 * public/js/jquery.flot.symbol.js: Added.
3632 * public/js/jquery.flot.threshold.js: Added.
3633 * public/js/jquery.flot.time.js: Added.
3634 * public/js/jquery.js: Added.
3636 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3638 Return NaN instead of throwing when there aren't enough samples.
3640 Reviewed by Sam Weinig.
3642 It's better to return NaN when we don't have enough samples so that we can treat it
3643 as if we don't have any confidence interval.
3645 * public/js/statistics.js:
3648 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3650 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
3652 * public/js/helper-classes.js:
3653 (URLState.parseIfNeeded):
3655 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3657 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
3659 Reviewed by Ricky Mondello.
3661 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
3663 * public/admin/aggregators.php: Use heredoc.
3664 * public/admin/builders.php:
3665 * public/admin/jobs.php:
3666 * public/admin/repositories.php:
3667 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
3668 This allows us to use update_field when updating test's url and metric's unit. Changed the action
3669 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
3670 Also removed a stray code to update unit and url simultaneously since it's never used.
3671 * public/include/admin-header.php:
3672 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
3673 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
3674 (update_field): Moved from repositories.php.
3676 * public/include/db.php:
3677 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
3679 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
3681 Build fixes. Treat mean, sum, and square sum as float, not int.
3683 Also use 95% confidence interval instead of 90% confidence interval.
3685 * public/api/runs.php:
3686 * public/js/helper-classes.js:
3687 (.this.confidenceIntervalDelta):
3689 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
3691 Add an administrative page to edit repository information.
3693 Reviewed by Ricky Mondello.