1 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
3 The delta value in the chart pane sometimes doens't show '+' for a positive delta
4 https://bugs.webkit.org/show_bug.cgi?id=141340
6 Reviewed by Andreas Kling.
8 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
9 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
12 (App.Pane.computeStatus):
13 (App.createChartData):
15 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
17 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
20 (App.PaneController._updateDetails):
22 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
24 Unreviewed. Commit the forgotten change.
26 * public/include/manifest.php:
28 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
30 New perf dashboard should have multiple dashboard pages
31 https://bugs.webkit.org/show_bug.cgi?id=141339
33 Reviewed by Chris Dumez.
35 Added the support for multiple dashboard pages. Also added the status of the latest data point.
36 e.g. "5% better than target"
38 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
39 Also hid the border lines around charts on the dashboard page for a cleaner look.
42 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
43 (App.IndexRoute.beforeModel): Added.
44 (App.DashboardRoute): Added.
45 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
46 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
47 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
48 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
49 (App.DashboardController): Renamed from App.IndexController.
50 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
51 and "defaultDashboard" as these are taken care of by newly added routers.
52 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
53 now done in actions.toggleEditMode.
54 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
55 an existing dashboard.
57 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
58 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
59 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
60 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
62 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
64 (App.PaneController._updateDetails): Updated per changes to computeStatus.
66 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
69 (TimeSeries.prototype.lastPoint): Added.
71 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
72 on the dashboard, and enumerate all predefined dashboards.
74 * public/v2/interactive-chart.js:
75 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
76 for the dashboard page.
78 * public/v2/manifest.js:
79 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
80 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
81 IDs are generated for each dashboard for forward compatibility.
83 (App.Manifest.dashboardByName): Added.
84 (App.Manifest.defaultDashboardName): Added.
85 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
87 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
89 Move commits viewer to the end of details view
90 https://bugs.webkit.org/show_bug.cgi?id=141315
92 Rubber-stamped by Andreas Kling.
94 Show the difference instead of the old value per kling's request.
97 (App.PaneController._updateDetails):
98 * public/v2/index.html:
100 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
102 Move commits viewer to the end of details view
103 https://bugs.webkit.org/show_bug.cgi?id=141315
105 Reviewed by Andreas Kling.
107 Improved the way list of commits are shown per kling's request.
110 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
112 * public/v2/chart-pane.css: Updated the style for the commits viewer.
114 * public/v2/commits-viewer.js:
115 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
116 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
118 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
119 moved the commits viewers out of the details tables so that they don't interleave revision data.
121 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
123 New perf dashboard should compare results to baseline and target
124 https://bugs.webkit.org/show_bug.cgi?id=141286
126 Reviewed by Chris Dumez.
128 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
129 Also use d3.format to format the selected value to show four significant figures.
132 (App.Pane.searchCommit):
133 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
134 to compute the status text without having to recreate them.
135 (App.createChartData): Added.
136 (App.PaneController._updateDetails): Use 3d.format on current and old values.
137 (App.PaneController._computeStatus): Added. Computes the status text.
138 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
139 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
140 format the values using chartData.formatter.
142 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
143 the baseline and in blue if it's better than the target.
146 (TimeSeries.prototype.findPointAfterTime): Added.
148 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
149 the bug that we were not showing the old value's unit.
151 * public/v2/interactive-chart.js:
152 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
153 the code to show the baseline and the target lines.
155 * public/v2/manifest.js:
156 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
158 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
160 Unreviewed build fix.
163 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
165 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
167 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
168 https://bugs.webkit.org/show_bug.cgi?id=141280
170 Reviewed by Chris Dumez.
172 Fixed the bug by passing in "since" as a query parameter to the charts page.
174 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
176 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
178 (App.IndexController): Changed the default number of days from one month to one week.
179 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
180 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
182 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
184 New perf dashboard erroneously clears zoom when poping history items
185 https://bugs.webkit.org/show_bug.cgi?id=141278
187 Reviewed by Chris Dumez.
189 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
191 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
192 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
195 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
196 shown in the main plot.
197 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
198 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
200 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
202 New perf dashboard shows null as the aggregator name if no aggregation is done
203 https://bugs.webkit.org/show_bug.cgi?id=141256
205 Reviewed by Chris Dumez.
207 Don't show the aggregator name if there isn't one.
209 * public/v2/manifest.js:
212 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
214 Unreviewed build fix after r179611.
216 * public/v2/interactive-chart.js:
218 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
220 Perf dashboard doesn’t show the right unit for Safari UI tests
221 https://bugs.webkit.org/show_bug.cgi?id=141238
223 Reviewed by Darin Adler.
225 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
226 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
227 between metrics and their units.
229 * public/js/helper-classes.js:
230 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
231 * public/v2/manifest.js:
232 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
233 * public/v2/interactive-chart.js:
234 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
235 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
237 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
239 Interactive chart component provides two duplicate API for highlighting points
240 https://bugs.webkit.org/show_bug.cgi?id=141234
242 Reviewed by Chris Dumez.
244 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
245 on the main charts page and markedPoints to show the two end points in the analysis task page.
247 This patch merges markedPoints into highlightedItems.
250 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
251 * public/v2/chart-pane.css:
252 * public/v2/index.html: Ditto.
253 * public/v2/interactive-chart.js:
254 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
255 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
256 items if highlightedItems was set before the initial layout.
257 (App.InteractiveChartComponent._relayoutDataAndAxes):
258 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
259 vertical lines, just set cx and cy as done for other "dots".
260 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
261 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
262 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
263 set the radius of highlight circles here.
265 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
267 Don’t use repository names as id’s.
268 https://bugs.webkit.org/show_bug.cgi?id=141226
270 Reviewed by Chris Dumez.
272 Not using repository names as their id's reduces the need to fetch the entire repositories table.
273 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
275 * Websites/perf.webkit.org/public/api/runs.php:
276 (parse_revisions_array): No longer uses $repository_id_to_name.
277 (main): No longer populates $repository_id_to_name.
279 * Websites/perf.webkit.org/public/api/triggerables.php:
280 (main): Don't resolve repository names.
282 * Websites/perf.webkit.org/public/include/manifest.php:
283 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
284 (ManifestGenerator::bug_trackers): Don't resolve repository names.
286 * Websites/perf.webkit.org/public/js/helper-classes.js:
287 (TestBuild): Renamed repositoryName to repositoryId.
288 (TestBuild.revision): Ditto.
289 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
290 since this is the text shown to human.
292 * Websites/perf.webkit.org/public/v2/app.js:
293 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
294 (App.PaneController._updateDetails): Ditto.
295 (App.AnalysisTaskController.updateRoots): Ditto.
297 * Websites/perf.webkit.org/public/v2/data.js:
298 (Measurement): Ditto.
299 (Measurement.prototype.commitTimeForRepository): Ditto.
300 (Measurement.prototype.formattedRevisions): Ditto.
302 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
303 select element's label and value respectively.
305 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
307 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
309 * public/api/runs.php:
311 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
313 /api/runs.php should have main function
314 https://bugs.webkit.org/show_bug.cgi?id=141220
316 Reviewed by Benjamin Poulain.
318 Wrapped the code inside main function for clarity.
320 * public/api/runs.php:
322 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
324 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
326 * tools/sync-with-buildbot.py:
327 (find_request_updates):
329 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
331 Perf dashboard always assigns the result of A/B testing with build request 1
332 https://bugs.webkit.org/show_bug.cgi?id=140382
334 Reviewed by Darin Adler.
336 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
337 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
339 Also fixed a typo as well as a bug that reports were never associated with builds.
341 * public/include/report-processor.php:
342 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
343 instead of the first non-null value.
344 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
345 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
347 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
349 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
351 * public/admin/tests.php:
353 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
355 Unreviewed build fix. Removed the stale code.
357 * public/admin/triggerables.php:
359 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
361 Perf dashboard should have the ability to post A/B testing builds
362 https://bugs.webkit.org/show_bug.cgi?id=140317
364 Rubber-stamped by Simon Fraser.
366 This patch adds the support for triggering A/B testing from the perf dashboard.
368 We add a few new tables to the database. "build_triggerables", which represents a set of builders
369 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
370 of repositories for which an arbitrary revision can be specified for A/B testing.
371 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
372 "roots" table which specifies the revision used in a given root set in each repository.
374 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
375 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
376 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
377 to build_requests table. Also made each test group's name unique in a given analysis task as it
378 would be confusing to have multiple test groups of the same name.
380 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
382 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
383 for which a specific revision can be set in an A/B testing on a given triggerable.
385 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
386 triggerable. Also updates the status' and the status urls of specified build requests when
387 buildRequestUpdates is provided in the raw POST data.
390 * public/api/runs.php:
391 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
392 results of an A/B testing.
394 * public/api/test-groups.php:
395 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
397 * public/api/triggerables.php: Added.
398 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
400 * public/include/admin-header.php:
402 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
403 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
404 and root sets used in those requests.D
405 (BuildRequestsFetcher::__construct):
406 (BuildRequestsFetcher::fetch_for_task):
407 (BuildRequestsFetcher::fetch_for_group):
408 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
409 (BuildRequestsFetcher::has_results):
410 (BuildRequestsFetcher::results):
411 (BuildRequestsFetcher::results_with_resolved_ids):
412 (BuildRequestsFetcher::results_internal):
413 (BuildRequestsFetcher::root_sets):
414 (BuildRequestsFetcher::fetch_roots_for_set):
416 * public/include/db.php:
417 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
418 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
419 table since it only has the primary key, id, column.
420 (Database::select_or_insert_row):
421 (Database::update_or_insert_row):
422 (Database::update_row): Added.
423 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
424 should be inserted when no row matches the specified criteria. This is used while updating
425 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
426 new build requests in that API.
427 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
428 This is used in public/api/triggerables.php when no analysis task is specified.
430 * public/include/json-header.php:
431 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
432 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
433 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
434 find the closest ancestor with a triggerable.
436 * public/include/report-processor.php:
437 (ReportProcessor::process):
438 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
439 if jobId or buildRequest is specified.
441 * public/include/test-name-resolver.php:
442 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
443 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
444 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
447 * public/include/test-path-resolver.php: Added.
448 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
449 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
450 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
451 in order to compute full test metric names.
452 (TestPathResolver::__construct):
453 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
454 the highest (a test without a parent).
455 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
456 the highest ancestor to the test itself.
457 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
459 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
461 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
462 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
463 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
464 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
466 * public/v2/analysis.js:
467 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
468 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
469 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
470 (App.TestGroup.create): Added. Creates a new A/B testing group.
471 (App.Triggerable): Added.
472 (App.TriggerableAdapter): Added.
473 (App.TriggerableAdapter.buildURL): Added.
474 (App.BuildRequest.testGroup): Renamed from group.
475 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
476 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
477 in this build request.
478 (App.BuildRequest.status): Added.
479 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
480 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
483 (App.AnalysisTaskController.testGroups): Added.
484 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
485 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
486 but an observer that updates "roots" property. Filter out the repositories that are not accepted
487 by the associated triggerable as they will be ignored.
488 (App.AnalysisTaskController.actions.createTestGroup): Added.
490 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
492 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
493 the status of those builds to the perf dashboard. A similar script can be written to support
494 other continuous builds systems.
495 (main): Fetches the list of pending builds as well as currently running or completed builds from
496 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
497 a single new build on each builder with no pending builds, and marks the set of open build requests
498 that have been scheduled to run on the buildbot but not found in the first step as stale.
499 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
502 "platform": "mac-mavericks",
503 "test": ["Parser", "html5-full-render.html"],
504 "builder": "Trunk Syrah Production Perf AB Tests",
506 "forcescheduler": "force-mac-mavericks-release-perf",
507 "webkit_revision": "$WebKit",
508 "jobid": "$buildRequest"
513 (find_request_updates): Return a list of build request status updates to make based on the pending
514 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
515 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
516 if the build request had not been completed. This is necessary because a failed build will not
517 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
518 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
519 of open requests the perf dashboard has.
520 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
521 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
522 or human canceling a build may trigger such a state.
523 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
524 replacing repository names with their revisions and buildRequest with the build request id.
525 (config_for_request): Finds a builder for the test and the platform of a build request.
526 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
527 (property_value_from_build): Returns the value of a specific property in a buildbot build.
528 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
530 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
532 Cache-control should be set only on api/runs
533 https://bugs.webkit.org/show_bug.cgi?id=140312
535 Reviewed by Andreas Kling.
537 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
538 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
539 just set cache-control there instead of json-header.php which is used by other JSON APIs.
541 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
543 * public/api/analysis-tasks.php:
544 * public/api/runs.php: Set the cache control headers.
545 * public/api/test-groups.php:
546 * public/include/db.php: Set the default timezone to UTC.
547 * public/include/json-header.php: Don't set the cache control headers.
549 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
551 api/report-commit should authenticate with a slave name and password
552 https://bugs.webkit.org/show_bug.cgi?id=140308
554 Reviewed by Benjamin Poulain.
556 Use a slave name and a password to authenticate new commit reports.
558 * public/api/report-commits.php:
560 * public/include/json-header.php:
561 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
562 a slave name and a password instead of a builder name and a password.
563 * tests/api-report-commits.js: Updated tests.
565 (main): Renamed variables.
566 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
568 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
570 Perf dashboard should support authentication via a slave password
571 https://bugs.webkit.org/show_bug.cgi?id=139837
573 Reviewed by Andreas Kling.
575 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
576 having to add multiple builders with the same password when a single build slave is shared among them.
578 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
580 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
582 * public/admin/build-slaves.php: Added.
584 * public/admin/builders.php: Added the support for updating passwords.
586 * public/include/admin-header.php:
587 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
588 being retrieved from $_POST.
589 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
590 the raw may not exist (e.g. new_password).
591 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
592 control here when this flag evaluates to TRUE.
594 * public/include/report-processor.php:
595 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
596 values are present in the report. In addition, try authenticating builderName with slavePassword if
597 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
598 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
599 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
601 (ReportProcessor::store_report): Store the slave ID with the report.
602 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
603 the matching build is different from what's being reported.
605 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
608 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
610 New perf dashboard should not duplicate author information in each commit
611 https://bugs.webkit.org/show_bug.cgi?id=139756
613 Reviewed by Darin Adler.
615 Instead of each commit having author name and email, make it reference a newly added committers table.
616 Also replace "email" by "account" since some repositories don't use emails as account names.
618 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
619 which only contains as many rows as there are accounts in each repository, instead of commits table
620 which contains every commit ever happened in each repository.
622 To migrate an existing database into match the new schema, run:
626 INSERT INTO committers (committer_repository, committer_name, committer_email)
627 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
628 FROM commits WHERE commit_author_email IS NOT NULL);
630 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
632 UPDATE commits SET commit_committer = committer_id FROM committers
633 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
635 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
636 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
640 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
641 reference to committers. Also added the missing drop table statements.
643 * public/api/commits.php:
644 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
645 an array here instead of doing it in format_commit.
646 (fetch_commits_between): Updated queries to JOIN commits with committers.
647 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
650 * public/api/report-commits.php:
651 (main): Store the reported committer information or update the existing entry if there is one.
653 * tests/admin-regenerate-manifest.js: Fixed tests.
655 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
657 * tools/pull-svn.py: Renamed email to account.
659 (fetch_commit_and_resolve_author):
661 (resolve_author_name_from_account):
662 (resolve_author_name_from_email): Deleted.
664 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
666 Unreviewed build fix.
668 * public/v2/index.html: Include js files we extracted in r177424.
670 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
672 Unreviewed. Adding the forgotten svnprop.
674 * tools/pull-svn.py: Added property svn:executable.
676 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
678 Split InteractiveChartComponent and CommitsViewerComponent into separate files
679 https://bugs.webkit.org/show_bug.cgi?id=139716
681 Rubber-stamped by Benjamin Poulain.
683 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
684 and interactive-chart.js respectively since app.js has gotten really large.
687 * public/v2/commits-viewer.js: Added.
688 * public/v2/interactive-chart.js: Added.
690 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
692 New perf dashboard's chart UI is buggy
693 https://bugs.webkit.org/show_bug.cgi?id=139214
695 Reviewed by Chris Dumez.
697 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
699 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
700 component. This is not how Ember.js components should interact to begin with. The component now exposes
701 selectedPoints and always updates selection instead of sharedSelection.
704 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
705 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
706 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
707 and end time should be completely determined by "since" and the present time.
708 (App.ChartsController._startTimeChanged): Ditto.
709 (App.ChartsController._scheduleQueryStringUpdate):
710 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
712 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
714 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
715 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
716 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
717 observes the changes to selectedPoints property as it gets updated by the main chart.
718 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
719 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
721 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
722 when domain arrays aren't identical. This was causing a subtle race with other logic.
723 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
724 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
725 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
726 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
727 see if those two points correspond to a range or a single data point. Rewrote all that logic by
728 directly observing selectedPoints and currentItem properties instead of taking points and relying on
729 an instance variable, which was a terrible API.
730 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
731 when the main plot has a selected range, we don't have to check this._hasRange anymore.
733 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
734 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
735 (App.InteractiveChartComponent._updateSelection):
736 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
737 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
738 selectedPoints property.
740 (App.AnalysisTaskController._fetchedRuns):
741 (App.AnalysisTaskController._rootChangedForTestSet):
743 * public/v2/index.html:
744 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
746 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
748 Unreviewed. Fixed syntax errors.
751 * public/api/commits.php:
753 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
755 The dashboard on new perf monitor should be configurable
756 https://bugs.webkit.org/show_bug.cgi?id=138994
758 Reviewed by Benjamin Poulain.
760 For now, make it configurable via config.json. We should eventually make it configurable via
761 an administrative page but this will do for now.
763 * config.json: Added the empty dashboard configuration.
765 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
768 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
769 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
770 Also obtain the default configuration from App.Manifest.
771 (App.IndexController._normalizeTable): Moved to App.Dashboard.
773 * public/v2/manifest.js:
774 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
775 (App.Repository.urlForRevisionRange): Ditto.
776 (App.Dashboard): Added.
777 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
778 (App.Dashboard.rows): Ditto.
779 (App.Dashboard.headerColumns): Ditto.
780 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
781 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
782 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
783 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
785 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
787 There should be a way to associate bugs with analysis tasks
788 https://bugs.webkit.org/show_bug.cgi?id=138977
790 Reviewed by Benjamin Poulain.
792 Updated associate-bug.php to match the new database schema.
794 * public/include/json-header.php:
795 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
796 already camel-cased in require_existence_of. This makes the function usable elsewhere.
798 * public/privileged-api/associate-bug.php:
799 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
800 Also verify that those values are integers using require_format.
802 * public/v2/analysis.js:
803 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
804 (App.Bug.label): Added.
805 (App.BugAdapter): Added.
806 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
807 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
809 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
810 containing the bug information.
813 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
814 (App.AnalysisTaskRoute):
815 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
816 (App.AnalysisTaskController._fetchedManifest): Added.
817 (App.AnalysisTaskController.actions.associateBug): Added.
819 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
822 (Measurement.prototype.associateBug): Deleted.
824 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
825 Added a table show the bug information. Also hide the chart until chartData is available.
827 * public/v2/manifest.js:
830 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
832 Fix misc bugs and typos in app.js
833 https://bugs.webkit.org/show_bug.cgi?id=138946
835 Reviewed by Benjamin Poulain.
838 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
839 (App.ChartsController.init):
840 (App.buildPopup): Renamed from App.BuildPopup.
841 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
842 remove() on the wrong object (an array as opposed to elements in the array).
843 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
844 _highlights is always an array and evalutes to true.
846 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
848 New perf dashboard should provide UI to create a new analysis task
849 https://bugs.webkit.org/show_bug.cgi?id=138910
851 Reviewed by Benjamin Poulain.
853 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
854 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
856 With this patch, we can create a new analysis task by selection a range of points and opening
857 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
858 in the chart hyperlinked to the analysis task.
860 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
862 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
863 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
865 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
866 and adds the associated bugs to each task in the array.
869 * public/api/runs.php: Reverted changes made in r175006.
870 (fetch_runs_for_config):
873 * public/api/test-groups.php:
874 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
876 * public/include/db.php:
877 (Database::select_first_or_last_row):
878 (Database::select_rows): Extracted from select_first_or_last_row.
880 * public/v2/analysis.js:
881 (App.AnalysisTask): Added "bugs" property.
882 (App.Bug): Added now that bugs are regular data store objects.
885 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
886 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
887 platform that are associated with a specific range of runs.
888 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
889 (App.PaneController.actions.associateBug): Deleted.
890 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
891 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
892 once we've created one.
893 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
894 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
895 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
896 (App.PaneController._updateBugs): Deleted.
897 (App.PaneController._updateMarkedPoints): Deleted.
898 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
899 the name is missing or when at most one point is selected.
901 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
902 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
903 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
904 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
905 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
906 clickable bars for analysis tasks.
907 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
908 bar for analysis tasks to place them at the right location.
909 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
911 * public/v2/chart-pane.css:
912 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
913 (.chart .rangeBar): Added.
916 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
918 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
919 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
920 task bars in the interactive chart component.
922 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
924 Fix typos in r176203.
927 (App.ChartsController.actions.addPaneByMetricAndPlatform):
928 (App.AnalysisTaskRoute):
930 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
932 Unreviewed. Updated the install instruction.
936 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
938 App.Manifest shouldn't use App.__container__.lookup
939 https://bugs.webkit.org/show_bug.cgi?id=138768
941 Reviewed by Andreas Kling.
943 Removed the hack to find the store object via App.__container__.lookup.
944 Pass around the store object instead.
947 (App.DashboardRow._createPane): Add "store" property to the pane.
948 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
949 (App.IndexController.gridChanged): Ditto.
950 (App.IndexController.actions.addRow): Ditto.
951 (App.IndexController.init): Ditto.
952 (App.Pane._fetch): Ditto.
953 (App.ChartsController._parsePaneList): Ditto.
954 (App.ChartsController._updateQueryString): Ditto.
955 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
956 (App.BuildPopup): Ditto.
957 (App.AnalysisTaskRoute.model): Ditto.
958 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
960 * public/v2/manifest.js:
961 (App.Manifest.fetch): Removed the code to find the store object.
963 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
965 Fix Ember.js warnings the new perf dashboard
966 https://bugs.webkit.org/show_bug.cgi?id=138531
968 Reviewed by Darin Adler.
970 Fixed various warnings.
973 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
975 (PrivilegedAPI._post): Removed the superfluous console.log.
976 (CommitLogs.fetchForTimeRange): Ditto.
977 * public/v2/index.html: Added tbody as required by the HTML specification.
979 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
981 Fix typos in r175768.
984 (App.AnalysisTaskViewModel.roots):
986 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
988 Introduce the concept of analysis task to perf dashboard
989 https://bugs.webkit.org/show_bug.cgi?id=138517
991 Reviewed by Andreas Kling.
993 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
994 a single platform and used to bisect regressions in the range.
996 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
998 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
999 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1000 test runs. Analysis tasks not associated with test runs are used for try new patches.
1001 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1002 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1003 build_requests - A build request represents a single pending build for A/B testing.
1005 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1009 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1010 the specified analysis task group as well as build requests associated with them.
1012 (fetch_test_groups_for_task):
1013 (fetch_build_requests_for_task):
1014 (fetch_build_requests_for_group):
1015 (format_test_group):
1016 (format_build_request):
1018 * public/include/json-header.php:
1019 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1022 * public/privileged-api/associate-bug.php:
1023 (main): Fixed a typo.
1025 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1028 (ensure_config_from_runs):
1030 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1032 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1034 (App.AnalysisTask.create):
1036 (App.TestGroupAdapter):
1037 (App.AnalysisTaskSerializer):
1038 (App.TestGroupSerializer):
1041 * public/v2/app.css: Added style rules for the analysis page.
1044 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1046 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1047 exactly one selected point as we can still create an analysis task.
1048 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1049 grammatical and also alert'ed the error message when there is one.
1050 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1051 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1052 once XHR request has completed.
1053 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1054 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1055 is selected in the details pane.
1057 (App.AnalysisRoute): Added.
1058 (App.AnalysisTaskRoute): Added.
1059 (App.AnalysisTaskViewModel): Added.
1060 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1061 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1062 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1063 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1064 the user selects an option for all roots in A or B configuration.
1065 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1067 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1069 * public/v2/data.js:
1070 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1071 point so that we can use it in App.AnalysisTaskViewModel.roots.
1072 (TimeSeries.prototype.findPointByMeasurementId): Added.
1073 (TimeSeries.prototype.seriesBetweenPoints): Added.
1075 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1076 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1077 when multiple points are selected. Finally, added a new template for the analysis task page.
1079 * public/v2/manifest.js:
1080 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1081 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1082 App.AnalysisTaskViewModel._taskUpdated.
1084 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1086 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1087 https://bugs.webkit.org/show_bug.cgi?id=138111
1089 Reviewed by Darin Adler.
1092 (App.PaneController.bugsChangeCount): Removed.
1093 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1094 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1095 Finds the list of current run's points that are associated with bugs.
1096 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1097 * public/v2/chart-pane.css:
1098 (.chart .marked): Renamed from .hasBugs.
1099 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1101 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1103 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1104 https://bugs.webkit.org/show_bug.cgi?id=138099
1106 Reviewed by Benjamin Poulain.
1108 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1109 _showDetails inverting the order of the current and old measurements.
1112 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1113 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1114 current (latest) measurement and the first point is the oldest measurement.
1115 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1117 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1119 Perf dashboard should provide a way to associate bugs with a test run
1120 https://bugs.webkit.org/show_bug.cgi?id=137857
1122 Reviewed by Andreas Kling.
1124 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1125 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1126 the Apache configuration.
1129 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1130 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1131 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1132 via the cookie and returns a token computed from those two values as well as the remote username.
1134 The font end code then POST's the request along with the returned token. The server side code verifies
1135 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1136 the token hasn't expired.
1139 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1140 have zero or exactly one bug associated with a test run.
1142 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1143 * public/api/runs.php:
1144 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1145 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1146 an associated bug if there is one.
1147 (format_run): Calls parse_bugs_array.
1149 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1150 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1151 have a valid JSON payload.
1152 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1153 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1154 the expiration time stored in the cookie.
1155 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1157 * public/include/manifest.php:
1158 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1159 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1161 * public/index.html:
1162 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1164 * public/privileged-api/associate-bug.php: Added.
1165 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1166 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1168 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1170 * public/v2/app.css:
1171 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1172 selected in a chart.
1175 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1176 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1177 they would overlap on each other if both of them are shown.
1178 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1179 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1180 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1181 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1182 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1183 showing the search pane.
1184 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1185 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1186 bugs in the selected range.
1188 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1189 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1190 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1191 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1192 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1193 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1194 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1195 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1197 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1198 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1199 to selectionChanged action instead of just finding the first and the last points.
1201 * public/v2/chart-pane.css: Updated the style.
1203 * public/v2/data.js:
1204 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1205 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1206 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1207 we haven't already obtained a CSRF token or if the token has already been expired.
1208 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1210 (Measurement.prototype.bugs): Added.
1211 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1212 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1214 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1217 * public/v2/manifest.js:
1218 (App.BugTracker.bugUrl):
1219 (App.BugTracker.newBugUrl): Added.
1220 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1221 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1222 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1223 (App.Manifest.bugTrackers): Added.
1224 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1225 their respective ids to make the ordering stable.
1227 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1229 Remove unused jobs table
1230 https://bugs.webkit.org/show_bug.cgi?id=137724
1232 Reviewed by Daniel Bates.
1234 Removed jobs table in the database as well as related code.
1236 * init-database.sql:
1237 * public/admin/jobs.php: Removed.
1238 * public/admin/tests.php:
1239 * public/include/admin-header.php:
1241 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1243 New perf dashboard should have an ability to search commits by a keyword
1244 https://bugs.webkit.org/show_bug.cgi?id=137675
1246 Reviewed by Geoffrey Garen.
1248 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1249 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1250 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1252 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1253 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1255 * public/api/commits.php:
1256 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1257 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1258 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1259 (format_commit): Renamed from format_commits. Now only formats one commit.
1261 * public/include/db.php:
1262 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1264 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1267 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1268 which is a hash table that contains highlighted items' measurements' ids as keys.
1269 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1270 the default commit repository.
1271 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1272 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1273 Added the code to initialize this._highlights.
1274 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1275 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1276 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1277 the existing lines for the old highlighted items.
1278 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1279 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1281 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1283 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1284 (CommitLogs): Added.
1285 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1286 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1287 (CommitLogs._cacheConsecutiveCommits): Ditto.
1288 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1289 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1290 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1292 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1293 for showingDetails since this property is no longer used.
1295 * public/v2/manifest.js:
1296 (App.Manifest.repositories): Added.
1297 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1298 the default repository to search.
1299 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1301 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1303 Unreviewed build fix after r174555.
1305 * public/include/manifest.php:
1306 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1307 * tests/admin-regenerate-manifest.js: Fixed the test case.
1309 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1311 New perf dashboard UI tries to fetch commits all the time
1312 https://bugs.webkit.org/show_bug.cgi?id=137592
1314 Reviewed by Andreas Kling.
1316 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1317 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1318 no reported commits as they are all going to fail.
1320 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1321 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1322 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1323 of commits sorted chronologically by time.
1325 * public/include/manifest.php:
1328 (App.CommitsViewerComponent.commitsChanged):
1330 * public/v2/data.js:
1331 (FetchCommitsForTimeRange):
1332 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1334 * public/v2/manifest.js:
1337 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1339 Another unreviewed build fix after r174477.
1341 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1343 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1345 * public/include/report-processor.php:
1347 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1349 Unreviewed build fix after r174477.
1351 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1352 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1354 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1355 This is necessary for baseline and target values manually added via admin pages.
1357 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1359 Add v2 UI for the perf dashboard
1360 https://bugs.webkit.org/show_bug.cgi?id=137537
1362 Rubber-stamped by Andreas Kling.
1365 * public/v2/app.css: Added.
1366 * public/v2/app.js: Added.
1367 * public/v2/chart-pane.css: Added.
1368 * public/v2/data.js: Added.
1369 * public/v2/index.html: Added.
1370 * public/v2/js: Added.
1371 * public/v2/js/d3: Added.
1372 * public/v2/js/d3/LICENSE: Added.
1373 * public/v2/js/d3/d3.js: Added.
1374 * public/v2/js/d3/d3.min.js: Added.
1375 * public/v2/js/ember-data.js: Added.
1376 * public/v2/js/ember.js: Added.
1377 * public/v2/js/handlebars.js: Added.
1378 * public/v2/js/jquery.min.js: Added.
1379 * public/v2/js/statistics.js: Added.
1380 * public/v2/manifest.js: Added.
1381 * public/v2/popup.js: Added.
1383 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1385 Remove superfluously duplicated code in public/api/report-commits.php.
1387 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1389 Perf dashboard should store commit logs
1390 https://bugs.webkit.org/show_bug.cgi?id=137510
1392 Reviewed by Darin Adler.
1394 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
1396 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
1397 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
1398 a subversion directory. The git version of this script will be added in a follow up patch.
1401 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
1402 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
1403 relationship via "build_commits" relations.
1405 In order to migrate an existing instance of this application, run the following SQL commands:
1409 INSERT INTO commits (commit_repository, commit_revision, commit_time)
1410 (SELECT DISTINCT ON (revision_repository, revision_value)
1411 revision_repository, revision_value, revision_time FROM build_revisions);
1413 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
1414 FROM commits, build_revisions
1415 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
1417 DROP TABLE build_revisions;
1422 The helper script to submit commit logs can be used as follows:
1424 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
1425 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
1427 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
1428 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
1429 "feeder-slave-password" as the builder name and the builder password respectively.
1431 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
1432 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
1435 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
1437 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
1438 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
1440 - Not specified - It returns every single commit for a given repository.
1441 - Matches "oldest" - It returns the commit with the oldest timestamp.
1442 - Matches "latest" - It returns the commit with the latest timestamp.
1443 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
1444 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
1445 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
1446 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
1447 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
1448 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
1450 (commit_from_revision):
1451 (fetch_commits_between):
1454 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
1455 See tests/api-report-commits.js for examples on how to use this API.
1457 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
1458 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
1459 to optimize this and other JSON APIs.
1461 * public/include/db.php:
1462 (Database::select_or_insert_row):
1463 (Database::update_or_insert_row): Added.
1464 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
1465 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
1467 (Database::select_first_row):
1468 (Database::select_last_row): Added.
1469 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
1470 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
1472 * public/include/report-processor.php:
1473 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
1474 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
1475 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
1478 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
1480 * tests/api-report-commits.js: Added.
1481 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
1484 * tools/pull-svn.py: Added. See above for how to use this script.
1486 (determine_first_revision_to_fetch):
1487 (fetch_revision_from_dasbhoard):
1488 (fetch_commit_and_resolve_author):
1491 (resolve_author_name_from_email):
1494 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
1496 Update Install.md for Mavericks and fix typos
1497 https://bugs.webkit.org/show_bug.cgi?id=137276
1499 Reviewed by Benjamin Poulain.
1501 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
1503 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
1505 Finally, init-database.sql is no longer located inside database directory.
1509 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1511 Report run id's in api/runs.php for the new dashboard UI
1512 https://bugs.webkit.org/show_bug.cgi?id=135813
1514 Reviewed by Andreas Kling.
1516 Include run_id in the generated JSON.
1518 * public/api/runs.php:
1519 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
1522 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1524 Merging platforms mixes baselines and targets into reported data
1525 https://bugs.webkit.org/show_bug.cgi?id=135260
1527 Reviewed by Andreas Kling.
1529 When merging two platforms, move test configurations of a different type (baseline, target)
1530 as well as of different metric (Time, Runs).
1532 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
1533 It's sufficient to detect one such test_runs object.
1535 * public/admin/platforms.php:
1538 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
1540 Merging platforms mixes baselines and targets into reported data
1541 https://bugs.webkit.org/show_bug.cgi?id=135260
1543 Reviewed by Geoffrey Garen.
1545 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
1546 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
1548 * public/admin/platforms.php:
1550 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
1552 Build fix after r171361.
1554 * public/js/helper-classes.js:
1555 (.this.formattedBuildTime):
1557 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
1559 Perf dashboard spends 2s processing JSON data during the page loads
1560 https://bugs.webkit.org/show_bug.cgi?id=135152
1562 Reviewed by Andreas Kling.
1564 In the Apple internal dashboard, we were spending as much as 2 seconds
1565 converting raw JSON data into proper JS objects while loading the dashboard.
1567 This caused the apparent unresponsiveness of the dashboard despite of the fact
1568 charts themselves updated almost instantaneously.
1570 * public/index.html:
1571 * public/js/helper-classes.js:
1572 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
1573 lazily as creating new Date objects and running string replace is expensive.
1574 (TestBuild.formattedTime):
1575 (TestBuild.formattedBuildTime):
1576 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
1577 (PerfTestRuns.addResult): Deleted.
1579 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
1581 Perf dashboard shouldn't show the full git hash
1582 https://bugs.webkit.org/show_bug.cgi?id=135083
1584 Reviewed by Benjamin Poulain.
1586 Detect Git/Mercurial hash by checking the length.
1588 If it's a hash, use the first 8 characters in the label
1589 while retaining the full length to be used in hyperlinks.
1591 * public/js/helper-classes.js:
1592 (.this.formattedRevisions):
1595 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
1597 Add an instruction on how to backup the database.
1598 https://bugs.webkit.org/show_bug.cgi?id=133391
1600 Rubber-stamped by Andreas Kling.
1604 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1606 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
1608 * public/js/helper-classes.js:
1609 (PerfTestRuns.smallerIsBetter):
1611 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1615 * public/common.css:
1617 * public/index.html:
1621 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1623 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
1624 https://bugs.webkit.org/show_bug.cgi?id=131157
1626 Reviewed by Andreas Kling.
1628 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
1629 This allows, for example, adding all metrics such as Arithmetic and Geometric for
1630 a given test suite without also adding its subtests.
1632 * public/index.html:
1636 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1638 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
1639 https://bugs.webkit.org/show_bug.cgi?id=131155
1641 Reviewed by Andreas Kling.
1643 The bug was caused by Chart.attach binding event listeners on plot container on each call.
1644 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
1645 click when attach() has been called even number of times, keeping the tooltip invisible.
1647 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
1648 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
1649 is called for the first time.
1651 * public/index.html:
1653 (Chart..bindPlotEventHandlers):
1655 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1657 WebKitPerfMonitor: Tooltips can be cut off at the top
1658 https://bugs.webkit.org/show_bug.cgi?id=130960
1660 Reviewed by Andreas Kling.
1662 * public/common.css:
1663 (#title): Removed the gradients, box shadows, and border from the header.
1664 (#title h1): Reduce the font size.
1665 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
1666 * public/index.html:
1667 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
1668 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
1669 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
1670 * public/js/helper-classes.js:
1671 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
1672 tooltip extending above y=0.
1674 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1676 WebKitPerfMonitor: Y-axis adjustment is too aggressive
1677 https://bugs.webkit.org/show_bug.cgi?id=130937
1679 Reviewed by Andreas Kling.
1681 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
1682 results. This had two major problems:
1683 1. Two standard deviations can be too small to show the confidence interval for results.
1684 2. Sometimes baseline and target can be more than two standards deviations away.
1686 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
1687 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
1688 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
1689 the margin on each side separately to reduce the empty space on either side.
1691 A more rigorous approach would involve computing least squared value of results with respect to intervals
1692 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
1694 * public/index.html:
1695 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
1696 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
1697 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
1698 We wouldn't see the difference between measured values versus baseline and target values otherwise.
1699 * public/js/helper-classes.js:
1700 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
1701 interval delta cannot be computed.
1702 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
1703 within the given interval.
1704 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
1705 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
1706 (PerfTestRuns..unscaledMeansForAllResults):
1707 (PerfTestRuns.min): Take the confidence interval delta into account.
1708 (PerfTestRuns.max): Ditto.
1709 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
1710 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
1712 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
1714 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
1716 Some CSS tweaks after r166477 and r166479,
1718 * public/index.html:
1720 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1722 WebKitPerfMonitor: Sometimes text inside panes overlap
1723 https://bugs.webkit.org/show_bug.cgi?id=130956
1725 Reviewed by Gyuyoung Kim.
1727 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
1728 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
1729 reduces the total height of the pane and fits more information per screen capita on the dashboard.
1731 * public/index.html: Updated and added a bunch of CSS rules for the new look.
1732 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
1733 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
1734 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
1735 of the build info shown in a chart pane and a tooltip.
1736 (Chart): Made .status a table.
1737 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
1738 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
1739 now that status.text no longer contains it.
1740 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
1742 * public/js/helper-classes.js:
1743 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
1744 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
1745 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
1746 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
1747 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
1748 capital letter; e.g. "MB" instead of "M B".
1750 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1752 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
1753 https://bugs.webkit.org/show_bug.cgi?id=130957
1755 Reviewed by Gyuyoung Kim.
1757 Moved the slider into the header. Also reduced the spacing between the header and platform names.
1758 This reclaims 50px × width of the screen real estate.
1760 * public/common.css:
1761 (#title): Reduced the space below the header from 20px to 10px.
1762 * public/index.html:
1763 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
1764 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
1765 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
1766 real estate between the header and the platform names.
1768 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
1770 Update the install guidelines for perf.webkit.org
1771 https://bugs.webkit.org/show_bug.cgi?id=129895
1773 Reviewed by Ryosuke Niwa.
1775 The current install guideline for perf.webkit.org discourages the use of the installed
1776 Server application. I've actualized the documentation for Mavericks, and modified the
1777 guideline to include the instructions for Server.app also.
1781 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
1783 Update perf.webkit.org json example
1784 https://bugs.webkit.org/show_bug.cgi?id=129907
1786 Reviewed by Andreas Kling.
1788 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
1792 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
1794 Merge database-common.js and utility.js into run-tests.js.
1796 Reviewed by Matthew Hanson.
1798 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
1799 Also moved init-database.sql out of the database directory and removed the directory entirely.
1801 * database: Removed.
1802 * database/database-common.js: Removed.
1803 * database/utility.js: Removed.
1804 * init-database.sql: Moved from database/init-database.sql.
1806 (connect): Moved from database-common.js.
1807 (pathToDatabseSQL): Extracted from pathToLocalScript.
1808 (pathToTests): Moved from database-common.js.
1811 (SerializedTaskQueue): Ditto.
1813 (initializeDatabase):
1814 (TestEnvironment.it):
1815 (TestEnvironment.queryAndFetchAll):
1818 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1820 Remove the dependency on node.js from the production code.
1822 Reviewed by Ricky Mondello.
1824 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
1826 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
1827 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
1828 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
1829 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
1830 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
1832 Also removed the js files that are no longer used.
1834 * config.json: Moved from database/config.json.
1835 * database/aggregate.js: Removed. No longer used.
1836 * database/database-common.js: Removed unused functions, and updated the path to config.json.
1837 * database/process-jobs.js: Removed. No longer used.
1838 * database/sample-data.sql: Removed. We have a much better corpus of data now.
1839 * database/schema.graffle: Removed. It's completely obsolete.
1840 * public/include/db.php: Updated the path to config.json.
1841 * public/include/evaluator.js: Removed.
1843 * public/include/report-processor.php:
1844 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
1845 storing values into $expressions and calling evaluate_expressions_by_node.
1846 (TestRunsGenerator::aggregate_values): Added.
1847 (TestRunsGenerator::compute_caches): Directly compute the caches.
1849 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1851 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
1853 * public/admin/platforms.php:
1854 * public/include/db.php:
1856 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1858 Zoomed y-axis view is ununsable when the last result is an outlier.
1860 Reviewed by Stephanie Lewis.
1862 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
1863 the last result so that the graph looks sane if the last result was an outlier. However, always show
1864 the last result's mean even if it was an outlier.
1866 * public/index.html:
1867 * public/js/helper-classes.js:
1868 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
1869 Also added the ability to cache the unscaled means to avoid recomputation.
1870 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
1871 (PerfTestRuns.max): Ditto.
1872 (PerfTestRuns.sampleStandardDeviation): Ditto.
1873 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
1875 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1879 * public/admin/tests.php:
1880 * public/js/helper-classes.js:
1882 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
1884 Use two standard deviations instead as I mentioned in the mailing list.
1886 * public/index.html:
1888 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1890 The performance dashboard erroneously shows upward arrow for combined metrics.
1892 A single outlier can ruin the zoomed y-axis view.
1894 Rubber-stamped by Antti Koivisto.
1896 * public/index.html:
1897 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
1898 from the latest results' mean.
1899 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
1900 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
1901 (Chart.toggleYAxis):
1902 * public/js/helper-classes.js:
1903 (PerfTestRuns.sampleStandardDeviation): Added.
1904 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
1906 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1908 Don't include the confidence interval when computing the y-axis.
1910 Rubber-stamped by Simon Fraser.
1912 * public/js/helper-classes.js:
1916 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1918 Tiny CSS tweak for tooltips.
1920 * public/index.html:
1922 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1924 Remove the erroneously repeated code.
1926 * public/admin/test-configurations.php:
1928 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1930 <rdar://problem/15704893> perf dashboard should show baseline numbers
1932 Reviewed by Stephanie Lewis.
1934 * public/admin/bug-trackers.php:
1935 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
1938 * public/admin/platforms.php:
1939 (merge_list): Ditto.
1941 * public/admin/test-configurations.php: Added.
1942 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
1943 build_revisions as they're not meaningful for baseline / target numbers.
1944 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
1945 one test run so that we don't accidentally delete a reported test run.
1946 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
1947 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
1948 and delete existing ones.
1950 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
1951 on each platform; there could be configurations of distinct types such as "current" and "baseline".
1952 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
1954 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
1955 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
1956 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
1957 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
1958 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
1960 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
1962 * public/include/admin-header.php:
1963 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
1964 have id and type sub columns, and each custom column could generate multiple rows.
1966 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
1967 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
1968 We then proceed to generate the second header row with sub column names.
1970 When generating the actual content, we first generate all custom columns as they may have multiple rows in
1971 which case regular columns need rowspan set to the maximum number of rows.
1973 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
1976 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
1977 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
1978 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
1979 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
1980 expanded to occupy all sub columns.
1982 * public/include/manifest.php:
1983 (ManifestGenerator::platforms): Don't add the metric more than once.
1985 * public/include/test-name-resolver.php:
1986 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
1987 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
1988 full metric name later.
1989 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
1990 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
1991 (TestNameResolver::full_name_for_test): Added.
1992 (TestNameResolver::full_name_for_metric): Added.
1993 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
1995 * public/js/helper-classes.js:
1996 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
1997 test runs created to set baseline and target points.
1999 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2001 Build fix after r57928. Removed a superfluous close parenthesis.
2003 * public/api/runs.php:
2005 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2007 Unreviewed build & typo fixes.
2009 * public/admin/platforms.php:
2010 * tests/admin-platforms.js:
2012 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2014 <rdar://problem/15704893> perf dashboard should show baseline numbers
2016 Rubber-stamped by Antti Koivisto.
2018 Organize some code into functions in runs.php.
2020 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2022 * public/api/runs.php:
2023 (fetch_runs_for_config): Extracted.
2024 (format_run): Ditto.
2026 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2028 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2030 * database/config.json:
2031 * public/admin/reprocess-report.php:
2032 * public/api/report.php:
2033 * public/api/runs.php:
2034 * public/include/json-header.php:
2036 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2038 Commit yet another forgotten change.
2040 Something went horribly wrong with my merge :(
2042 * database/init-database.sql:
2044 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2046 Commit one more forgotten change. Sorry for making a mess here.
2048 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2050 Commit the forgotten files.
2052 * public/admin/platforms.php: Added.
2053 * tests/admin-platforms.js: Added.
2055 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2057 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2059 Reviewed by Stephanie Lewis.
2061 Added /admin/platforms/ page to hide and merge platforms.
2063 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2064 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2065 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2066 each test configuration a distinct "test run" for each build.
2068 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2069 their test configurations into platform B.
2071 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2072 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2073 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2074 in platform B, in which case R should relate to T_B instead.
2076 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2077 new platform. We then migrate the test configurations of the remaining test runs.
2079 * database/init-database.sql: Added platform_hidden.
2081 * public/admin/platforms.php: Added.
2082 (merge_platforms): Added. Implements the algorithm described above.
2083 (merge_list): Added.
2085 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2086 is hidden since it doesn't do anything.
2088 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2089 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2090 missing it since unchecked checkbox doesn't set the value in $_POST.
2091 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2092 switch statement instead of repeated if's.
2093 (AdministrativePage::render_table): Emit "update-column" for update_field.
2095 * public/include/db.php: Disable warnings when we're not in the debug mode.
2097 * public/include/manifest.php:
2098 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2101 (TestEnvironment.postJSON):
2102 (TestEnvironment.httpGet):
2103 (TestEnvironment.httpPost): Added.
2104 (sendHttpRequest): Set the content type if specified.
2106 * tests/admin-platforms.js: Added tests.
2108 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2110 Extract the code to compute full test names from tests.php.
2112 Reviewed by Stephanie Lewis.
2114 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2115 and paves our way to re-use the code in other pages.
2117 * public/admin/tests.php:
2119 * public/include/db.php:
2120 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2121 tests.php and test-name-resolver.php.
2123 * public/include/test-name-resolver.php: Added.
2124 (TestNameResolver::__construct):
2125 (TestNameResolver::compute_full_name): Moved from tests.php.
2126 (TestNameResolver::map_metrics_to_tests): Ditto.
2127 (TestNameResolver::sort_tests_by_full_name): Ditto.
2128 (TestNameResolver::tests): Added.
2129 (TestNameResolver::test_id_for_full_name): Ditto.
2130 (TestNameResolver::metrics_for_test_id): Ditto.
2131 (TestNameResolver::child_metrics_for_test_id): Ditto.
2132 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2134 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2136 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2138 Reviewed by Stephanie Lewis.
2140 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2142 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2143 but that's sufficient to correct the wrongfully processed reports for now.
2145 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2146 We should eventually add a nice UI to find and reprocess reports.
2148 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2150 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2152 * public/include/report-processor.php: Copied from public/api/report.php.
2153 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2154 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2155 create a new report or authenticate the builder password (the password is never stored in the report).
2156 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2157 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2158 (ReportProcessor::store_report): Ditto.
2160 * tests/admin-reprocess-report.js: Added.
2162 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2164 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2166 Reviewed by Ricky Mondello.
2168 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2169 for the same build number as a single build by ignoring build time. This was necessary to associate
2170 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2171 we use to submit results computed its own "build time" when they're called.
2173 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2174 last week; new reports were wrongfully associated with old build numbers.
2176 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2177 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2178 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2180 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2181 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2182 (builder, build number, build time).
2184 * public/api/report.php:
2185 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2186 when no such build exists. This prevents a report from being associated with a very old build of the same
2189 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2190 a similar bug in the future sooner.
2192 * tests/api-report.js: Added three test cases.
2194 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2196 Merged the upstream changes to db.php
2197 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2199 * public/include/db.php:
2201 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2203 Update other scripts and tests per previous patch.
2205 * public/include/manifest.php:
2206 * tests/admin-regenerate-manifest.js:
2208 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2210 Remove metrics_unit.
2212 Reviewed by Ricky Mondello.
2214 This column is no longer used by the front-end code since r48360.
2216 * database/init-database.sql:
2217 * public/admin/tests.php:
2219 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2221 Unreviewed build fix.
2223 * public/api/report.php:
2225 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2227 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2229 Reviewed by Ricky Mondello.
2231 Support a new alternative format for aggregated results where we have raw values as well as
2232 the list aggregators so that instead of
2233 "metrics": {"Time": ["Arithmetic"]}
2235 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2237 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2238 dashboard and the generated results page, which doesn't know how to aggregate values.
2240 We need to keep the support for the old format because all other existing performance tests
2241 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2242 the old format during the transition.
2244 * public/api/report.php:
2245 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2246 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2248 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2250 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2252 Unreviewed; Tweak the CSS so that chart panes align vertically.
2254 * public/index.html:
2256 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2258 SafariPerfMonitor should support Combined metric.
2260 * public/js/helper-classes.js:
2261 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2262 value as well but assume it to be greater-is-better for now.
2264 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2266 Commit the forgotten init-database change to add iteration_relative_time.
2268 * database/init-database.sql:
2270 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2272 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2274 Reviewed by Ricky Mondello.
2276 Add the support for each value to have a relative time. This is necessary for frame rate history
2277 since a frame rate needs to be associated with a time it was sampled.
2279 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2281 * public/api/report.php:
2282 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2283 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2284 with relative time since taking the average of two frame rates for two subtests taken at two
2285 different times doesn't make any sense.
2286 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2287 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2288 Also exit early with an error if the number of elements in the array is not a pair.
2289 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2291 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2292 iteration_relative_time.
2294 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2296 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2298 Reviewed by Ricky Mondello.
2300 Support that. It's one line change.
2302 * public/api/report.php:
2303 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2304 to match the convention assumed elsewhere.
2305 * tests/api-report.js: Added a test case.
2307 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2309 SafariPerfMonitor shows popups for points outside of the visible region.
2311 Rubber-stamped by Simon Fraser.
2313 * public/index.html:
2314 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2315 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2316 may return an item underneath y-axis labels.
2318 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2320 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2322 * public/index.html:
2324 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2326 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2328 * public/index.html:
2330 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2332 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2333 <rdar://problem/13992271> Should scale Y axis to include error ranges
2335 Reviewed by Ricky Mondello.
2337 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2338 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2340 * database/config.json:
2341 * public/index.html:
2342 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2343 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2344 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2346 * public/js/helper-classes.js:
2347 (PerfTestResult.confidenceIntervalDelta):
2348 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2349 (PerfTestRuns.min): Take confidence interval delta into account.
2350 (PerfTestRuns.max): Ditto.
2351 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2353 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2355 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2357 * public/api/report.php:
2358 (ReportProcessor::recursively_ensure_tests):
2359 * tests/api-report.js: Added a test.
2361 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2363 Unreviewed build fixes.
2365 * public/api/report.php:
2366 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
2367 Also, tolerate reports without any revision information.
2369 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
2372 * tests/api-report.js: Added few test cases.
2374 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2376 Commit another change that was supposed to be committed in r50331.
2379 (TestEnvironment.this.postJSON):
2380 (TestEnvironment.this.httpGet):
2383 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
2385 Commit the remaining files.
2387 * public/admin/regenerate-manifest.php:
2388 * public/include/admin-header.php:
2389 * public/include/json-header.php:
2390 * public/include/manifest.php:
2392 (TestEnvironment.this.postJSON):
2393 (TestEnvironment.this.httpGet):
2396 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
2398 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
2400 Reviewed by Ricky Mondello.
2402 Added some tests for admin/regenerate-manifest.
2404 * public/admin/regenerate-manifest.php: Use require_once instead of require.
2405 * public/include/admin-header.php: Ditto.
2406 * public/include/json-header.php: Ditto.
2408 * public/include/manifest.php:
2409 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
2410 When there are no builders, simply return an empty array.
2413 (TestEnvironment.postJSON):
2414 (TestEnvironment.httpGet): Added.
2415 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
2417 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
2419 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
2421 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
2422 and run_iterations. Also fixed a typo in report.php found by new tests.
2424 * public/api/report.php:
2425 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
2426 * tests/api-report.js: Added more test cases.
2428 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
2430 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
2432 Reviewed by Ricky Mondello.
2434 Add a test runner script and some simple test cases.
2436 * database/config.json: Added the configuration for "testServer".
2437 * database/database-common.js:
2438 (pathToTests): Added.
2439 * run-tests.js: Added.
2442 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
2443 and if there are, asks the user if it’s okay to delete all of the data contained therein.
2444 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
2446 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
2447 in the current database using PostgreSQL's information_schema.
2448 (askYesOrNoQuestion):
2450 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
2452 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
2453 (TestEnvironment.assert): Exposes assert to tests.
2454 (TestEnvironment.console): Exposes console to tests.
2455 (TestEnvironment.describe): Adds a description.
2456 (TestEnvironment.it): Adds a test case.
2457 (TestEnvironment.postJSON):
2458 (TestEnvironment.queryAndFetchAll):
2459 (TestEnvironment.sha256):
2460 (TestEnvironment.notifyDone): Ends the current test case.
2464 (TestContext): An object created for each test case. Conceptually, this object is always on
2465 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
2466 this object via currentTestContext.
2467 (TestContext.description):
2469 (TestContext.logError):
2472 * tests/api-report.js: Added some basic tests for /api/report.php.
2474 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2476 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
2478 The problem was that we were detecting whether we're updating dashboard or not by checking
2479 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
2480 all configurations. Use separate 'dashboard' action to execute the code even when
2481 metric_configurations is empty.
2483 * public/admin/tests.php:
2485 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2487 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
2489 Reviewed by Ricky Mondello.
2491 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
2492 from ReportProcessor as a preparation to replace deprecated aggregate.js.
2494 * public/api/report.php:
2495 (ReportProcessor::exit_with_error): Moved.
2496 (ReportProcessor::process): Use the extracted TestRunsGenerator.
2497 (TestRunsGenerator): Added.
2498 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
2499 (TestRunsGenerator::add_aggregated_metric): Moved.
2500 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
2501 (TestRunsGenerator::aggregate): Moved. Made public.
2502 (TestRunsGenerator::aggregate_current_test_level): Moved.
2503 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
2504 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
2505 (TestRunsGenerator::compute_caches): Moved. Made public.
2506 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
2507 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
2508 (TestRunsGenerator::rollback_with_error): Moved.
2510 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2512 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
2514 Reviewed by Remy Demarest.
2516 Regenerate the manifest file when updating fields or adding new items that are included in
2519 * public/admin/bug-trackers.php:
2520 * public/admin/builders.php:
2521 * public/admin/regenerate-manifest.php:
2522 * public/admin/repositories.php:
2523 * public/admin/tests.php:
2524 * public/include/admin-header.php:
2525 (regenerate_manifest): Extracted from regenerate-manifest.php.
2527 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2529 Unreviewed build fix for memory test results.
2531 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
2532 aggregating at each level.
2534 * public/api/report.php:
2535 (ReportProcessor::recursively_ensure_tests):
2536 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
2537 (ReportProcessor::add_values_for_aggregation):
2538 (ReportProcessor::aggregate):
2539 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
2541 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
2543 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
2544 not the number of iteration groups. Also, don't set group number when the entire run belongs
2545 a single iteration group.
2547 * public/api/report.php:
2548 (ReportProcessor::commit):
2550 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2552 SafariPerfMonitor: Introduce iteration groups
2554 Reviewed by Remy Demarest.
2556 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
2557 the runtime environment variances to get more stable results. And it's desirable to keep track of
2558 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
2560 This patch introduces "iteration groups" to keep track of this extra information.
2562 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
2563 the outer array denotes iteration groups and each inner array contains iteration values for each group.
2566 * database/init-database.sql: Add iteration_group column.
2567 * public/api/report.php:
2568 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
2570 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
2571 contains the list of values indexed by the iteration order and group sizes. Store the group size so
2572 that we can restore the iteration groups before passing it to node.js and restore them later.
2574 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
2575 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
2577 Also check that each iteration group in each subtest are consistent with one another. To see why we need
2578 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
2579 that each iteration group in T1 and T2 have the same size:
2580 T1 = [[1, 2], [3, 4, 5]]
2581 T2 = [[6, 7], [8, 9, 10]]
2583 so that the aggregated result (the sum in this case) can have the same groups as in:
2584 T = [[7, 9], [11, 13, 15]]
2586 If some iteration groups in T1 and T2 had a different size as in:
2587 T1 = [[1, 2, 3], [4, 5]]
2588 T2 = [[6, 7], [8, 9, 10]]
2590 Then iteration groups of the aggregated T is ambiguous.
2592 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
2593 (ReportProcessor::commit): Store iteration_group values.
2595 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2597 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
2598 migrated to perf.webkit.org.
2600 * database/perf-webkit-migrator.js: Removed.
2602 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2604 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
2606 * public/index.html:
2609 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2611 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
2613 Reviewed by Ricky Mondello.
2615 It is often desirable to see charts of a given test for all platforms, or to be able to see
2616 charts of all subtests on a given platform when trying to triage perf. regressions.
2618 Support this use case by adding the ability to do so on the charts page.
2620 Also, we used to disable items on the test list based on the platform chosen. This turned out
2621 to be a bad UI because in many situations you want to be able to compare results of the same test
2622 on multiple platforms.
2624 In this new UI, we have three select elements, each of which selects the following:
2625 1. Top-level test - Test suite such as Dromaeo
2626 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
2627 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
2628 3. Platform - Mountain Lion, Qt, etc...
2630 A user can select "all" for metric and platform but we disallow doing both at once since adding
2631 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
2632 think of a use case where you want to look at that many charts at once. We can support this later
2633 if valid use cases come up.
2635 * public/index.html:
2636 (.showCharts.addOption): Extracted.
2637 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
2638 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
2639 metricList has onchange handler that enables/disables items on platformList.
2641 (init): Sort tests and test metrics here instead of doing that in showCharts.
2643 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
2645 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
2647 Reviewed by Remy Demarest and Ricky Mondello.
2649 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
2650 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
2651 templates to the manifest file instead. Each build now only contains the builder id.
2653 * public/api/runs.php: Removed the part of the query that joined builders table. This
2654 speeds up the query quite a bit.
2656 * public/include/manifest.php:
2657 (ManifestGenerator::generate): Generate builders field.
2658 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
2659 associative array that contains name and its build URL template.
2661 * public/index.html:
2662 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
2663 instead of a revision since this function is used for revisions and build page URLs now.
2664 (.buildLabelWithLinks): Include the linkified build number.
2666 * public/js/helper-classes.js:
2667 (TestBuild.builder): Added.
2668 (TestBuild.buildNumber): Added.
2669 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
2670 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
2672 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
2674 Tooltips interfere with user interactions
2676 Rubber-stamped by Simon Fraser.
2678 Disable tooltip on the dashboard page since graphs are too small to be useful there.
2679 Also, show graphs for only 10 days by default as opposed to 20.
2680 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
2682 * public/index.html:
2683 * public/js/helper-classes.js:
2685 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
2687 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
2688 to be compatible with webkit-perf.appspot.com.
2690 * public/admin/builders.php:
2691 * public/api/report.php:
2693 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
2697 Add a missing constraint on builds table. For a given builder, there should be exactly
2698 one build for a given build number.
2700 Also add report_committed_at to reports table to record the time at which a given report
2701 was processed and test_runs and run_iterations rows were committed into the database.
2703 * database/config.json:
2704 * public/api/report.php:
2706 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
2708 Unreviewed. Add more checks for empty SQL query results.
2710 * public/include/manifest.php:
2712 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2714 More build fixes on perf.webkit.org.
2716 * public/api/runs.php: Make PostgreSQL happier.
2717 * public/include/manifest.php: Don't assume we always have bug trackers.
2719 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2721 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
2722 and fix other miscellaneous UI bugs.
2724 Rubber-stamped by Simon Fraser.
2726 Removed the code to determine whether smaller value is better or not for a given test in index.html
2727 in the favor of using that of PerfTestRuns.
2729 * public/include/manifest.php: Fixed a typo.
2730 * public/index.html:
2732 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
2734 * public/js/helper-classes.js:
2735 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
2737 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
2738 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
2739 at roughly 2,000 units to avoid this.
2741 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
2742 The only thing we can avoid is innerHTML.
2744 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2746 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
2748 * public/include/evaluator.js:
2750 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2752 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
2754 Reviewed by Remy Demarest.
2756 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
2757 admin/bug-trackers.php and can be associated with multiple repositories.
2759 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
2760 to determine the set of bug trackers to show for a given set of blame lists.
2761 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
2762 a place to file bugs against the regression.
2764 * database/init-database.sql: Added bug_trackers and tracker_repositories.
2765 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
2767 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
2768 bug trackers, namely associated repositories.
2770 * public/include/admin-header.php: Added a link to bug-trackers.php
2771 * public/include/manifest.php:
2772 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
2773 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
2775 (ManifestGenerator::repositories):
2777 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
2778 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
2779 'repositories' where the latter contains the list of associated repository names.
2781 * public/index.html:
2782 (Chart): Takes bugTrackers as as argument.
2783 (Chart.showTooltipWithResults): Removed the hard-coded list.
2785 (init.addPlatformsToDashboard):
2786 (init.showCharts.createChartFromListPair):
2787 (init): Stores the list of bug trackers in the manifest to a local variable.
2789 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2791 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
2793 * public/include/evaluator.js:
2795 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2797 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
2799 Reviewed by Remy Demarest.
2801 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
2802 new row into the database.
2804 * public/admin/aggregators.php: Use AdministrativePage.
2805 * public/admin/builders.php: Ditto.
2806 * public/admin/repositories.php: Ditto.
2807 * public/include/admin-header.php:
2808 (AdministrativePage): Added.
2809 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
2810 to an associative array that describes the column.
2811 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
2812 - label: Human readable name of the column.
2813 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
2814 column exists only before we create password_hash column at the insertion time.
2816 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
2817 titlecase (e.g. new_bug is converted to New Bug).
2818 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
2819 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
2820 textarea for a given editing mode ('text', 'url', or 'string').
2821 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
2822 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
2824 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
2826 Build fix. Some systems don't support r+. Use proc_open instead.
2828 * public/api/report.php:
2830 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2832 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
2833 when computing the y-axis of data points to show tooltips at.
2835 * public/index.html:
2837 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2839 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
2842 * public/.htaccess: Removed.
2844 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
2848 * public/include/manifest.php: Build fix. db is on this.
2849 * public/js/statistics.js:
2850 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
2852 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
2854 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
2856 Reviewed by Anders Carlsson.
2858 Rewrote and merged populate-from-report.js into report.php.
2860 * database/config.json: Added a path to node.js.
2862 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
2863 Once we land this patch and update the administrative pages, we can remove this column.
2865 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
2866 that table is going away once we remove the node.js backend.
2868 * database/populate-from-report.js: Removed.
2869 * public/api/report.php: Added.
2871 (ReportProcessor.__construct):
2872 (ReportProcessor.process):
2874 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
2875 verified to be submitted by a known builder.
2877 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
2878 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
2879 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
2880 inside a transaction because there could be multiple reports for a single build, each containing results for
2883 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
2884 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
2885 add_values_to_commit, and add_values_for_aggregation.
2887 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
2888 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
2889 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
2892 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
2893 to be aggregated in ReportProcessor.aggregate.
2895 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
2897 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
2898 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
2899 given for each row (child metrics of M). This function extracts each column (iteration) via
2900 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
2901 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
2903 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
2904 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
2905 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
2907 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
2908 (ReportProcessor.evaluate_expressions_by_node): See above.
2910 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
2911 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
2912 results also need the said caches.
2914 (ReportProcessor.add_values_to_commit):
2916 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
2917 the transaction as needed if anything goes wrong.
2919 (ReportProcessor.rollback_with_error)
2921 * public/include/db.php:
2922 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
2923 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
2924 contiguously in a SQL statement.
2926 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
2927 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
2928 a column value of the choice.
2930 (Database.begin_transaction): Added.
2931 (Database.commit_transaction): Added.
2932 (Database.rollback_transaction): Added.
2934 * public/include/evaluator.js: Added.
2935 * public/include/json-header.php:
2936 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
2937 context under which the request failed.
2938 (successful_exit): Merge "additional details".
2939 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
2940 (merge_additional_details):
2942 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
2944 SafariPerfMonitor: Add more helper functions to db.php
2946 Reviewed by Remy Demarest.
2948 Added Database::insert_row and array_get to make common database operations easier.
2950 * public/admin/aggregators.php: Use Database::insert_row instead of
2951 execute_query_and_expect_one_row_to_be_affected.
2953 * public/admin/builders.php: Ditto.
2955 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
2956 inserting a row. With insert_row, we don't need that.
2958 * public/include/admin-header.php: Ditto.
2960 * public/include/db.php:
2961 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
2962 return the default value (defaults to NULL) if the key doesn't exist.
2964 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
2967 (Database::prepare_params): Added. Takes an associative array of column names and their values,
2968 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
2969 column names all in the same order.
2971 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
2972 the given prefix. Values are given in a form of an associative array where keys are unprefixed
2973 column names and values are corresponding values. When the row is successfully inserted, it returns
2974 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
2975 indicating the success of the insertion.
2977 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2979 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
2981 Reviewed by Conrad Shultz.
2983 Rewrote the manifest generator in PHP.
2985 * database/generate-manifest.js: Removed.
2986 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
2987 * public/include/db.php:
2988 (array_ensure_item_has_array): Added.
2989 * public/include/evaluator.js: Added.
2990 * public/include/json-header.php:
2991 * public/include/manifest.php: Added.
2993 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2995 Dates on overflow plot are overlapping
2997 Rubber-stamped by Simon Fraser.
2999 Don't show more than 5 days.
3001 * public/index.html:
3002 * public/js/helper-classes.js:
3003 (TestBuild.UTCtoPST):
3006 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3008 Show build time as well as commit time on the dashboard and tooltips.
3010 Rubber-stamped by Simon Fraser.
3012 Include both the maximum commit time and build time in buildLabelWithLinks.
3013 Also use ISO format to save the screen real estate.
3015 * public/index.html:
3016 (buildLabelWithLinks):
3017 * public/js/helper-classes.js:
3019 (TestBuild.buildTime):
3020 (TestBuild.formattedBuildTime):
3022 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
3024 Unreviewed; Convert metric.name to metric.unit in the front end.
3026 * public/js/helper-classes.js:
3028 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3030 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
3032 Rubber-stamped by Simon Fraser.
3034 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
3035 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
3036 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
3038 * public/index.html:
3039 (.buildLabelWithLinks): Extracted from TestBuild.label.
3040 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
3041 on Radar and WebKit Bugzilla.
3042 * public/js/helper-classes.js:
3043 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
3044 (PerfTestResult.isBetterThan): Added.
3045 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
3046 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
3047 to indicate progressions or regressions.
3048 (PerfTestResult.label):
3049 (TestBuild.formattedTime): Added.
3050 (TestBuild.platform): Added.
3051 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
3052 (TestBuild.smallerIsBetter): Added.
3053 (Tooltip.show): Take a raw markup instead of two results.
3055 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
3057 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
3059 Rubber-stamped by Tim Horton.
3061 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
3062 since each platform may have a different number of tests to be shown on the dashboard.
3064 * public/index.html:
3066 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3068 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
3070 * public/js/helper-classes.js:
3073 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3075 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
3077 Rubber-stamped by Tim Horton.
3079 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
3081 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
3082 the revision r1234 was the revision used in the previous build.
3084 * public/api/runs.php:
3085 (parse_revisions_array): Trim double quotations around repository names and revisions.
3086 * public/js/helper-classes.js:
3089 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3091 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
3093 Rubber-stamped by Tim Horton.
3095 * public/index.html:
3096 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
3097 on the dashboard page as it's way too noisy.
3099 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
3101 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
3102 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
3103 so that the tooltip for hover can be reused further.
3105 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
3106 and find the first point that lies on the right of the cursor position. We then compute the midpoint
3107 between this and the previous point and pick the closer of the two. It returns an item-like object
3108 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
3110 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
3112 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
3113 the first or "current" data points (as opposed to target or baseline data points).
3115 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
3116 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
3117 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
3119 * public/js/helper-classes.js:
3120 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
3121 work to the client via bindClick.
3123 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
3125 (Tooltip.bindClick): Added.
3127 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3129 Yet another build fix. metricId*s*.
3131 * public/admin/tests.php:
3133 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3135 Another build fix. Use the new payload format for the aggregate job.
3137 * public/admin/tests.php:
3139 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3143 * database/aggregate.js: Use variables that actually exist.
3144 * database/database-common.js:
3145 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
3146 function calls will find this configuration.
3148 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3150 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
3152 Reviewed by Ricky Mondello.
3154 Turned InstallManual into a proper markdown document and added ReadMe.md.
3156 * InstallManual: Removed.
3157 * InstallManual.md: Moved from InstallManual.
3160 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3162 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
3164 Reviewed by Ricky Mondello.
3166 This patch prepares the front end code to process baseline and target results properly.
3168 * public/index.html:
3169 (fetchTest.createRunAndResults): Extracted.
3170 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
3171 Deleted the comment about how sorting will be unnecessary once we start results in the server side
3172 since sorting by the maximum revision commit time turned out to be non-trivial in php.
3174 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3176 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
3178 Reviewed by Tim Horton.
3180 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
3181 These files are "dynamically linked" to our app.
3183 * public/index.html:
3184 * public/js/jquery-1.8.2.min.js: Removed.
3185 * public/js/jquery.colorhelpers.js: Added.
3186 * public/js/jquery.flot.categories.js: Added.
3187 * public/js/jquery.flot.crosshair.js: Added.
3188 * public/js/jquery.flot.errorbars.js: Added.
3189 * public/js/jquery.flot.fillbetween.js: Added.
3190 * public/js/jquery.flot.js: Added.
3191 * public/js/jquery.flot.min.js: Removed.
3192 * public/js/jquery.flot.navigate.js: Added.
3193 * public/js/jquery.flot.resize.js: Added.
3194 * public/js/jquery.flot.selection.js: Added.
3195 * public/js/jquery.flot.stack.js: Added.
3196 * public/js/jquery.flot.symbol.js: Added.
3197 * public/js/jquery.flot.threshold.js: Added.
3198 * public/js/jquery.flot.time.js: Added.
3199 * public/js/jquery.js: Added.
3201 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3203 Return NaN instead of throwing when there aren't enough samples.
3205 Reviewed by Sam Weinig.
3207 It's better to return NaN when we don't have enough samples so that we can treat it
3208 as if we don't have any confidence interval.
3210 * public/js/statistics.js:
3213 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3215 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
3217 * public/js/helper-classes.js:
3218 (URLState.parseIfNeeded):
3220 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
git://git.webkit.org / WebKit-https.git / blob