1 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
3 /api/runs.php should have main function
4 https://bugs.webkit.org/show_bug.cgi?id=141220
6 Reviewed by Benjamin Poulain.
8 Wrapped the code inside main function for clarity.
10 * public/api/runs.php:
12 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
14 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
16 * tools/sync-with-buildbot.py:
17 (find_request_updates):
19 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
21 Perf dashboard always assigns the result of A/B testing with build request 1
22 https://bugs.webkit.org/show_bug.cgi?id=140382
24 Reviewed by Darin Adler.
26 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
27 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
29 Also fixed a typo as well as a bug that reports were never associated with builds.
31 * public/include/report-processor.php:
32 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
33 instead of the first non-null value.
34 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
35 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
37 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
39 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
41 * public/admin/tests.php:
43 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
45 Unreviewed build fix. Removed the stale code.
47 * public/admin/triggerables.php:
49 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
51 Perf dashboard should have the ability to post A/B testing builds
52 https://bugs.webkit.org/show_bug.cgi?id=140317
54 Rubber-stamped by Simon Fraser.
56 This patch adds the support for triggering A/B testing from the perf dashboard.
58 We add a few new tables to the database. "build_triggerables", which represents a set of builders
59 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
60 of repositories for which an arbitrary revision can be specified for A/B testing.
61 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
62 "roots" table which specifies the revision used in a given root set in each repository.
64 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
65 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
66 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
67 to build_requests table. Also made each test group's name unique in a given analysis task as it
68 would be confusing to have multiple test groups of the same name.
70 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
72 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
73 for which a specific revision can be set in an A/B testing on a given triggerable.
75 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
76 triggerable. Also updates the status' and the status urls of specified build requests when
77 buildRequestUpdates is provided in the raw POST data.
80 * public/api/runs.php:
81 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
82 results of an A/B testing.
84 * public/api/test-groups.php:
85 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
87 * public/api/triggerables.php: Added.
88 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
90 * public/include/admin-header.php:
92 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
93 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
94 and root sets used in those requests.D
95 (BuildRequestsFetcher::__construct):
96 (BuildRequestsFetcher::fetch_for_task):
97 (BuildRequestsFetcher::fetch_for_group):
98 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
99 (BuildRequestsFetcher::has_results):
100 (BuildRequestsFetcher::results):
101 (BuildRequestsFetcher::results_with_resolved_ids):
102 (BuildRequestsFetcher::results_internal):
103 (BuildRequestsFetcher::root_sets):
104 (BuildRequestsFetcher::fetch_roots_for_set):
106 * public/include/db.php:
107 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
108 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
109 table since it only has the primary key, id, column.
110 (Database::select_or_insert_row):
111 (Database::update_or_insert_row):
112 (Database::update_row): Added.
113 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
114 should be inserted when no row matches the specified criteria. This is used while updating
115 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
116 new build requests in that API.
117 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
118 This is used in public/api/triggerables.php when no analysis task is specified.
120 * public/include/json-header.php:
121 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
122 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
123 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
124 find the closest ancestor with a triggerable.
126 * public/include/report-processor.php:
127 (ReportProcessor::process):
128 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
129 if jobId or buildRequest is specified.
131 * public/include/test-name-resolver.php:
132 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
133 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
134 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
137 * public/include/test-path-resolver.php: Added.
138 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
139 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
140 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
141 in order to compute full test metric names.
142 (TestPathResolver::__construct):
143 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
144 the highest (a test without a parent).
145 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
146 the highest ancestor to the test itself.
147 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
149 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
151 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
152 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
153 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
154 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
156 * public/v2/analysis.js:
157 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
158 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
159 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
160 (App.TestGroup.create): Added. Creates a new A/B testing group.
161 (App.Triggerable): Added.
162 (App.TriggerableAdapter): Added.
163 (App.TriggerableAdapter.buildURL): Added.
164 (App.BuildRequest.testGroup): Renamed from group.
165 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
166 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
167 in this build request.
168 (App.BuildRequest.status): Added.
169 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
170 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
173 (App.AnalysisTaskController.testGroups): Added.
174 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
175 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
176 but an observer that updates "roots" property. Filter out the repositories that are not accepted
177 by the associated triggerable as they will be ignored.
178 (App.AnalysisTaskController.actions.createTestGroup): Added.
180 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
182 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
183 the status of those builds to the perf dashboard. A similar script can be written to support
184 other continuous builds systems.
185 (main): Fetches the list of pending builds as well as currently running or completed builds from
186 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
187 a single new build on each builder with no pending builds, and marks the set of open build requests
188 that have been scheduled to run on the buildbot but not found in the first step as stale.
189 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
192 "platform": "mac-mavericks",
193 "test": ["Parser", "html5-full-render.html"],
194 "builder": "Trunk Syrah Production Perf AB Tests",
196 "forcescheduler": "force-mac-mavericks-release-perf",
197 "webkit_revision": "$WebKit",
198 "jobid": "$buildRequest"
203 (find_request_updates): Return a list of build request status updates to make based on the pending
204 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
205 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
206 if the build request had not been completed. This is necessary because a failed build will not
207 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
208 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
209 of open requests the perf dashboard has.
210 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
211 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
212 or human canceling a build may trigger such a state.
213 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
214 replacing repository names with their revisions and buildRequest with the build request id.
215 (config_for_request): Finds a builder for the test and the platform of a build request.
216 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
217 (property_value_from_build): Returns the value of a specific property in a buildbot build.
218 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
220 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
222 Cache-control should be set only on api/runs
223 https://bugs.webkit.org/show_bug.cgi?id=140312
225 Reviewed by Andreas Kling.
227 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
228 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
229 just set cache-control there instead of json-header.php which is used by other JSON APIs.
231 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
233 * public/api/analysis-tasks.php:
234 * public/api/runs.php: Set the cache control headers.
235 * public/api/test-groups.php:
236 * public/include/db.php: Set the default timezone to UTC.
237 * public/include/json-header.php: Don't set the cache control headers.
239 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
241 api/report-commit should authenticate with a slave name and password
242 https://bugs.webkit.org/show_bug.cgi?id=140308
244 Reviewed by Benjamin Poulain.
246 Use a slave name and a password to authenticate new commit reports.
248 * public/api/report-commits.php:
250 * public/include/json-header.php:
251 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
252 a slave name and a password instead of a builder name and a password.
253 * tests/api-report-commits.js: Updated tests.
255 (main): Renamed variables.
256 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
258 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
260 Perf dashboard should support authentication via a slave password
261 https://bugs.webkit.org/show_bug.cgi?id=139837
263 Reviewed by Andreas Kling.
265 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
266 having to add multiple builders with the same password when a single build slave is shared among them.
268 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
270 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
272 * public/admin/build-slaves.php: Added.
274 * public/admin/builders.php: Added the support for updating passwords.
276 * public/include/admin-header.php:
277 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
278 being retrieved from $_POST.
279 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
280 the raw may not exist (e.g. new_password).
281 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
282 control here when this flag evaluates to TRUE.
284 * public/include/report-processor.php:
285 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
286 values are present in the report. In addition, try authenticating builderName with slavePassword if
287 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
288 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
289 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
291 (ReportProcessor::store_report): Store the slave ID with the report.
292 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
293 the matching build is different from what's being reported.
295 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
298 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
300 New perf dashboard should not duplicate author information in each commit
301 https://bugs.webkit.org/show_bug.cgi?id=139756
303 Reviewed by Darin Adler.
305 Instead of each commit having author name and email, make it reference a newly added committers table.
306 Also replace "email" by "account" since some repositories don't use emails as account names.
308 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
309 which only contains as many rows as there are accounts in each repository, instead of commits table
310 which contains every commit ever happened in each repository.
312 To migrate an existing database into match the new schema, run:
316 INSERT INTO committers (committer_repository, committer_name, committer_email)
317 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
318 FROM commits WHERE commit_author_email IS NOT NULL);
320 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
322 UPDATE commits SET commit_committer = committer_id FROM committers
323 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
325 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
326 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
330 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
331 reference to committers. Also added the missing drop table statements.
333 * public/api/commits.php:
334 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
335 an array here instead of doing it in format_commit.
336 (fetch_commits_between): Updated queries to JOIN commits with committers.
337 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
340 * public/api/report-commits.php:
341 (main): Store the reported committer information or update the existing entry if there is one.
343 * tests/admin-regenerate-manifest.js: Fixed tests.
345 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
347 * tools/pull-svn.py: Renamed email to account.
349 (fetch_commit_and_resolve_author):
351 (resolve_author_name_from_account):
352 (resolve_author_name_from_email): Deleted.
354 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
356 Unreviewed build fix.
358 * public/v2/index.html: Include js files we extracted in r177424.
360 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
362 Unreviewed. Adding the forgotten svnprop.
364 * tools/pull-svn.py: Added property svn:executable.
366 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
368 Split InteractiveChartComponent and CommitsViewerComponent into separate files
369 https://bugs.webkit.org/show_bug.cgi?id=139716
371 Rubber-stamped by Benjamin Poulain.
373 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
374 and interactive-chart.js respectively since app.js has gotten really large.
377 * public/v2/commits-viewer.js: Added.
378 * public/v2/interactive-chart.js: Added.
380 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
382 New perf dashboard's chart UI is buggy
383 https://bugs.webkit.org/show_bug.cgi?id=139214
385 Reviewed by Chris Dumez.
387 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
389 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
390 component. This is not how Ember.js components should interact to begin with. The component now exposes
391 selectedPoints and always updates selection instead of sharedSelection.
394 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
395 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
396 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
397 and end time should be completely determined by "since" and the present time.
398 (App.ChartsController._startTimeChanged): Ditto.
399 (App.ChartsController._scheduleQueryStringUpdate):
400 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
402 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
404 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
405 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
406 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
407 observes the changes to selectedPoints property as it gets updated by the main chart.
408 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
409 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
411 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
412 when domain arrays aren't identical. This was causing a subtle race with other logic.
413 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
414 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
415 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
416 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
417 see if those two points correspond to a range or a single data point. Rewrote all that logic by
418 directly observing selectedPoints and currentItem properties instead of taking points and relying on
419 an instance variable, which was a terrible API.
420 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
421 when the main plot has a selected range, we don't have to check this._hasRange anymore.
423 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
424 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
425 (App.InteractiveChartComponent._updateSelection):
426 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
427 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
428 selectedPoints property.
430 (App.AnalysisTaskController._fetchedRuns):
431 (App.AnalysisTaskController._rootChangedForTestSet):
433 * public/v2/index.html:
434 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
436 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
438 Unreviewed. Fixed syntax errors.
441 * public/api/commits.php:
443 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
445 The dashboard on new perf monitor should be configurable
446 https://bugs.webkit.org/show_bug.cgi?id=138994
448 Reviewed by Benjamin Poulain.
450 For now, make it configurable via config.json. We should eventually make it configurable via
451 an administrative page but this will do for now.
453 * config.json: Added the empty dashboard configuration.
455 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
458 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
459 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
460 Also obtain the default configuration from App.Manifest.
461 (App.IndexController._normalizeTable): Moved to App.Dashboard.
463 * public/v2/manifest.js:
464 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
465 (App.Repository.urlForRevisionRange): Ditto.
466 (App.Dashboard): Added.
467 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
468 (App.Dashboard.rows): Ditto.
469 (App.Dashboard.headerColumns): Ditto.
470 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
471 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
472 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
473 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
475 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
477 There should be a way to associate bugs with analysis tasks
478 https://bugs.webkit.org/show_bug.cgi?id=138977
480 Reviewed by Benjamin Poulain.
482 Updated associate-bug.php to match the new database schema.
484 * public/include/json-header.php:
485 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
486 already camel-cased in require_existence_of. This makes the function usable elsewhere.
488 * public/privileged-api/associate-bug.php:
489 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
490 Also verify that those values are integers using require_format.
492 * public/v2/analysis.js:
493 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
494 (App.Bug.label): Added.
495 (App.BugAdapter): Added.
496 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
497 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
499 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
500 containing the bug information.
503 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
504 (App.AnalysisTaskRoute):
505 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
506 (App.AnalysisTaskController._fetchedManifest): Added.
507 (App.AnalysisTaskController.actions.associateBug): Added.
509 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
512 (Measurement.prototype.associateBug): Deleted.
514 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
515 Added a table show the bug information. Also hide the chart until chartData is available.
517 * public/v2/manifest.js:
520 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
522 Fix misc bugs and typos in app.js
523 https://bugs.webkit.org/show_bug.cgi?id=138946
525 Reviewed by Benjamin Poulain.
528 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
529 (App.ChartsController.init):
530 (App.buildPopup): Renamed from App.BuildPopup.
531 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
532 remove() on the wrong object (an array as opposed to elements in the array).
533 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
534 _highlights is always an array and evalutes to true.
536 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
538 New perf dashboard should provide UI to create a new analysis task
539 https://bugs.webkit.org/show_bug.cgi?id=138910
541 Reviewed by Benjamin Poulain.
543 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
544 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
546 With this patch, we can create a new analysis task by selection a range of points and opening
547 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
548 in the chart hyperlinked to the analysis task.
550 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
552 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
553 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
555 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
556 and adds the associated bugs to each task in the array.
559 * public/api/runs.php: Reverted changes made in r175006.
560 (fetch_runs_for_config):
563 * public/api/test-groups.php:
564 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
566 * public/include/db.php:
567 (Database::select_first_or_last_row):
568 (Database::select_rows): Extracted from select_first_or_last_row.
570 * public/v2/analysis.js:
571 (App.AnalysisTask): Added "bugs" property.
572 (App.Bug): Added now that bugs are regular data store objects.
575 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
576 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
577 platform that are associated with a specific range of runs.
578 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
579 (App.PaneController.actions.associateBug): Deleted.
580 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
581 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
582 once we've created one.
583 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
584 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
585 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
586 (App.PaneController._updateBugs): Deleted.
587 (App.PaneController._updateMarkedPoints): Deleted.
588 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
589 the name is missing or when at most one point is selected.
591 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
592 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
593 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
594 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
595 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
596 clickable bars for analysis tasks.
597 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
598 bar for analysis tasks to place them at the right location.
599 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
601 * public/v2/chart-pane.css:
602 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
603 (.chart .rangeBar): Added.
606 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
608 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
609 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
610 task bars in the interactive chart component.
612 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
614 Fix typos in r176203.
617 (App.ChartsController.actions.addPaneByMetricAndPlatform):
618 (App.AnalysisTaskRoute):
620 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
622 Unreviewed. Updated the install instruction.
626 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
628 App.Manifest shouldn't use App.__container__.lookup
629 https://bugs.webkit.org/show_bug.cgi?id=138768
631 Reviewed by Andreas Kling.
633 Removed the hack to find the store object via App.__container__.lookup.
634 Pass around the store object instead.
637 (App.DashboardRow._createPane): Add "store" property to the pane.
638 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
639 (App.IndexController.gridChanged): Ditto.
640 (App.IndexController.actions.addRow): Ditto.
641 (App.IndexController.init): Ditto.
642 (App.Pane._fetch): Ditto.
643 (App.ChartsController._parsePaneList): Ditto.
644 (App.ChartsController._updateQueryString): Ditto.
645 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
646 (App.BuildPopup): Ditto.
647 (App.AnalysisTaskRoute.model): Ditto.
648 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
650 * public/v2/manifest.js:
651 (App.Manifest.fetch): Removed the code to find the store object.
653 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
655 Fix Ember.js warnings the new perf dashboard
656 https://bugs.webkit.org/show_bug.cgi?id=138531
658 Reviewed by Darin Adler.
660 Fixed various warnings.
663 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
665 (PrivilegedAPI._post): Removed the superfluous console.log.
666 (CommitLogs.fetchForTimeRange): Ditto.
667 * public/v2/index.html: Added tbody as required by the HTML specification.
669 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
671 Fix typos in r175768.
674 (App.AnalysisTaskViewModel.roots):
676 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
678 Introduce the concept of analysis task to perf dashboard
679 https://bugs.webkit.org/show_bug.cgi?id=138517
681 Reviewed by Andreas Kling.
683 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
684 a single platform and used to bisect regressions in the range.
686 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
688 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
689 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
690 test runs. Analysis tasks not associated with test runs are used for try new patches.
691 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
692 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
693 build_requests - A build request represents a single pending build for A/B testing.
695 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
699 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
700 the specified analysis task group as well as build requests associated with them.
702 (fetch_test_groups_for_task):
703 (fetch_build_requests_for_task):
704 (fetch_build_requests_for_group):
706 (format_build_request):
708 * public/include/json-header.php:
709 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
712 * public/privileged-api/associate-bug.php:
713 (main): Fixed a typo.
715 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
718 (ensure_config_from_runs):
720 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
722 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
724 (App.AnalysisTask.create):
726 (App.TestGroupAdapter):
727 (App.AnalysisTaskSerializer):
728 (App.TestGroupSerializer):
731 * public/v2/app.css: Added style rules for the analysis page.
734 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
736 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
737 exactly one selected point as we can still create an analysis task.
738 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
739 grammatical and also alert'ed the error message when there is one.
740 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
741 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
742 once XHR request has completed.
743 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
744 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
745 is selected in the details pane.
747 (App.AnalysisRoute): Added.
748 (App.AnalysisTaskRoute): Added.
749 (App.AnalysisTaskViewModel): Added.
750 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
751 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
752 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
753 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
754 the user selects an option for all roots in A or B configuration.
755 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
757 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
760 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
761 point so that we can use it in App.AnalysisTaskViewModel.roots.
762 (TimeSeries.prototype.findPointByMeasurementId): Added.
763 (TimeSeries.prototype.seriesBetweenPoints): Added.
765 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
766 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
767 when multiple points are selected. Finally, added a new template for the analysis task page.
769 * public/v2/manifest.js:
770 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
771 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
772 App.AnalysisTaskViewModel._taskUpdated.
774 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
776 Remove App.PaneController.bugsChangeCount in the new perf dashboard
777 https://bugs.webkit.org/show_bug.cgi?id=138111
779 Reviewed by Darin Adler.
782 (App.PaneController.bugsChangeCount): Removed.
783 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
784 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
785 Finds the list of current run's points that are associated with bugs.
786 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
787 * public/v2/chart-pane.css:
788 (.chart .marked): Renamed from .hasBugs.
789 * public/v2/index.html: Specify chartPointRadius and markedPoints.
791 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
793 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
794 https://bugs.webkit.org/show_bug.cgi?id=138099
796 Reviewed by Benjamin Poulain.
798 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
799 _showDetails inverting the order of the current and old measurements.
802 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
803 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
804 current (latest) measurement and the first point is the oldest measurement.
805 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
807 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
809 Perf dashboard should provide a way to associate bugs with a test run
810 https://bugs.webkit.org/show_bug.cgi?id=137857
812 Reviewed by Andreas Kling.
814 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
815 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
816 the Apache configuration.
819 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
820 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
821 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
822 via the cookie and returns a token computed from those two values as well as the remote username.
824 The font end code then POST's the request along with the returned token. The server side code verifies
825 that the specified token can be generated from the salt and the expiration time set in the cookie, and
826 the token hasn't expired.
829 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
830 have zero or exactly one bug associated with a test run.
832 * public/admin/bug-trackers.php: Added the support for editing bug_url.
833 * public/api/runs.php:
834 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
835 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
836 an associated bug if there is one.
837 (format_run): Calls parse_bugs_array.
839 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
840 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
841 have a valid JSON payload.
842 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
843 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
844 the expiration time stored in the cookie.
845 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
847 * public/include/manifest.php:
848 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
849 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
852 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
854 * public/privileged-api/associate-bug.php: Added.
855 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
856 attack via ensure_privileged_api_data_and_token, which calls verify_token.
858 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
861 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
865 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
866 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
867 they would overlap on each other if both of them are shown.
868 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
869 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
870 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
871 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
872 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
873 showing the search pane.
874 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
875 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
876 bugs in the selected range.
878 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
879 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
880 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
881 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
882 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
883 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
884 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
885 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
887 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
888 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
889 to selectionChanged action instead of just finding the first and the last points.
891 * public/v2/chart-pane.css: Updated the style.
894 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
895 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
896 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
897 we haven't already obtained a CSRF token or if the token has already been expired.
898 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
900 (Measurement.prototype.bugs): Added.
901 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
902 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
904 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
907 * public/v2/manifest.js:
908 (App.BugTracker.bugUrl):
909 (App.BugTracker.newBugUrl): Added.
910 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
911 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
912 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
913 (App.Manifest.bugTrackers): Added.
914 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
915 their respective ids to make the ordering stable.
917 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
919 Remove unused jobs table
920 https://bugs.webkit.org/show_bug.cgi?id=137724
922 Reviewed by Daniel Bates.
924 Removed jobs table in the database as well as related code.
927 * public/admin/jobs.php: Removed.
928 * public/admin/tests.php:
929 * public/include/admin-header.php:
931 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
933 New perf dashboard should have an ability to search commits by a keyword
934 https://bugs.webkit.org/show_bug.cgi?id=137675
936 Reviewed by Geoffrey Garen.
938 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
939 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
940 This API change allows fetch_commits_between to generate results without processing Postgres query results.
942 In the front end side, we've added a search pane in pane controller, and the interactive chart component
943 now has a concept of highlighted items which is used to indicate commits found by the search pane.
945 * public/api/commits.php:
946 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
947 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
948 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
949 (format_commit): Renamed from format_commits. Now only formats one commit.
951 * public/include/db.php:
952 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
954 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
957 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
958 which is a hash table that contains highlighted items' measurements' ids as keys.
959 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
960 the default commit repository.
961 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
962 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
963 Added the code to initialize this._highlights.
964 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
965 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
966 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
967 the existing lines for the old highlighted items.
968 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
969 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
971 * public/v2/chart-pane.css: Added style for the search pane and the search button.
973 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
975 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
976 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
977 (CommitLogs._cacheConsecutiveCommits): Ditto.
978 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
979 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
980 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
982 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
983 for showingDetails since this property is no longer used.
985 * public/v2/manifest.js:
986 (App.Manifest.repositories): Added.
987 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
988 the default repository to search.
989 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
991 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
993 Unreviewed build fix after r174555.
995 * public/include/manifest.php:
996 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
997 * tests/admin-regenerate-manifest.js: Fixed the test case.
999 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1001 New perf dashboard UI tries to fetch commits all the time
1002 https://bugs.webkit.org/show_bug.cgi?id=137592
1004 Reviewed by Andreas Kling.
1006 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1007 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1008 no reported commits as they are all going to fail.
1010 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1011 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1012 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1013 of commits sorted chronologically by time.
1015 * public/include/manifest.php:
1018 (App.CommitsViewerComponent.commitsChanged):
1020 * public/v2/data.js:
1021 (FetchCommitsForTimeRange):
1022 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1024 * public/v2/manifest.js:
1027 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1029 Another unreviewed build fix after r174477.
1031 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1033 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1035 * public/include/report-processor.php:
1037 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1039 Unreviewed build fix after r174477.
1041 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1042 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1044 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1045 This is necessary for baseline and target values manually added via admin pages.
1047 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1049 Add v2 UI for the perf dashboard
1050 https://bugs.webkit.org/show_bug.cgi?id=137537
1052 Rubber-stamped by Andreas Kling.
1055 * public/v2/app.css: Added.
1056 * public/v2/app.js: Added.
1057 * public/v2/chart-pane.css: Added.
1058 * public/v2/data.js: Added.
1059 * public/v2/index.html: Added.
1060 * public/v2/js: Added.
1061 * public/v2/js/d3: Added.
1062 * public/v2/js/d3/LICENSE: Added.
1063 * public/v2/js/d3/d3.js: Added.
1064 * public/v2/js/d3/d3.min.js: Added.
1065 * public/v2/js/ember-data.js: Added.
1066 * public/v2/js/ember.js: Added.
1067 * public/v2/js/handlebars.js: Added.
1068 * public/v2/js/jquery.min.js: Added.
1069 * public/v2/js/statistics.js: Added.
1070 * public/v2/manifest.js: Added.
1071 * public/v2/popup.js: Added.
1073 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1075 Remove superfluously duplicated code in public/api/report-commits.php.
1077 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1079 Perf dashboard should store commit logs
1080 https://bugs.webkit.org/show_bug.cgi?id=137510
1082 Reviewed by Darin Adler.
1084 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
1086 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
1087 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
1088 a subversion directory. The git version of this script will be added in a follow up patch.
1091 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
1092 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
1093 relationship via "build_commits" relations.
1095 In order to migrate an existing instance of this application, run the following SQL commands:
1099 INSERT INTO commits (commit_repository, commit_revision, commit_time)
1100 (SELECT DISTINCT ON (revision_repository, revision_value)
1101 revision_repository, revision_value, revision_time FROM build_revisions);
1103 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
1104 FROM commits, build_revisions
1105 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
1107 DROP TABLE build_revisions;
1112 The helper script to submit commit logs can be used as follows:
1114 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
1115 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
1117 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
1118 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
1119 "feeder-slave-password" as the builder name and the builder password respectively.
1121 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
1122 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
1125 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
1127 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
1128 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
1130 - Not specified - It returns every single commit for a given repository.
1131 - Matches "oldest" - It returns the commit with the oldest timestamp.
1132 - Matches "latest" - It returns the commit with the latest timestamp.
1133 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
1134 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
1135 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
1136 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
1137 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
1138 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
1140 (commit_from_revision):
1141 (fetch_commits_between):
1144 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
1145 See tests/api-report-commits.js for examples on how to use this API.
1147 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
1148 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
1149 to optimize this and other JSON APIs.
1151 * public/include/db.php:
1152 (Database::select_or_insert_row):
1153 (Database::update_or_insert_row): Added.
1154 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
1155 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
1157 (Database::select_first_row):
1158 (Database::select_last_row): Added.
1159 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
1160 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
1162 * public/include/report-processor.php:
1163 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
1164 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
1165 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
1168 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
1170 * tests/api-report-commits.js: Added.
1171 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
1174 * tools/pull-svn.py: Added. See above for how to use this script.
1176 (determine_first_revision_to_fetch):
1177 (fetch_revision_from_dasbhoard):
1178 (fetch_commit_and_resolve_author):
1181 (resolve_author_name_from_email):
1184 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
1186 Update Install.md for Mavericks and fix typos
1187 https://bugs.webkit.org/show_bug.cgi?id=137276
1189 Reviewed by Benjamin Poulain.
1191 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
1193 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
1195 Finally, init-database.sql is no longer located inside database directory.
1199 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1201 Report run id's in api/runs.php for the new dashboard UI
1202 https://bugs.webkit.org/show_bug.cgi?id=135813
1204 Reviewed by Andreas Kling.
1206 Include run_id in the generated JSON.
1208 * public/api/runs.php:
1209 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
1212 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1214 Merging platforms mixes baselines and targets into reported data
1215 https://bugs.webkit.org/show_bug.cgi?id=135260
1217 Reviewed by Andreas Kling.
1219 When merging two platforms, move test configurations of a different type (baseline, target)
1220 as well as of different metric (Time, Runs).
1222 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
1223 It's sufficient to detect one such test_runs object.
1225 * public/admin/platforms.php:
1228 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
1230 Merging platforms mixes baselines and targets into reported data
1231 https://bugs.webkit.org/show_bug.cgi?id=135260
1233 Reviewed by Geoffrey Garen.
1235 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
1236 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
1238 * public/admin/platforms.php:
1240 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
1242 Build fix after r171361.
1244 * public/js/helper-classes.js:
1245 (.this.formattedBuildTime):
1247 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
1249 Perf dashboard spends 2s processing JSON data during the page loads
1250 https://bugs.webkit.org/show_bug.cgi?id=135152
1252 Reviewed by Andreas Kling.
1254 In the Apple internal dashboard, we were spending as much as 2 seconds
1255 converting raw JSON data into proper JS objects while loading the dashboard.
1257 This caused the apparent unresponsiveness of the dashboard despite of the fact
1258 charts themselves updated almost instantaneously.
1260 * public/index.html:
1261 * public/js/helper-classes.js:
1262 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
1263 lazily as creating new Date objects and running string replace is expensive.
1264 (TestBuild.formattedTime):
1265 (TestBuild.formattedBuildTime):
1266 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
1267 (PerfTestRuns.addResult): Deleted.
1269 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
1271 Perf dashboard shouldn't show the full git hash
1272 https://bugs.webkit.org/show_bug.cgi?id=135083
1274 Reviewed by Benjamin Poulain.
1276 Detect Git/Mercurial hash by checking the length.
1278 If it's a hash, use the first 8 characters in the label
1279 while retaining the full length to be used in hyperlinks.
1281 * public/js/helper-classes.js:
1282 (.this.formattedRevisions):
1285 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
1287 Add an instruction on how to backup the database.
1288 https://bugs.webkit.org/show_bug.cgi?id=133391
1290 Rubber-stamped by Andreas Kling.
1294 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1296 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
1298 * public/js/helper-classes.js:
1299 (PerfTestRuns.smallerIsBetter):
1301 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1305 * public/common.css:
1307 * public/index.html:
1311 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1313 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
1314 https://bugs.webkit.org/show_bug.cgi?id=131157
1316 Reviewed by Andreas Kling.
1318 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
1319 This allows, for example, adding all metrics such as Arithmetic and Geometric for
1320 a given test suite without also adding its subtests.
1322 * public/index.html:
1326 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1328 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
1329 https://bugs.webkit.org/show_bug.cgi?id=131155
1331 Reviewed by Andreas Kling.
1333 The bug was caused by Chart.attach binding event listeners on plot container on each call.
1334 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
1335 click when attach() has been called even number of times, keeping the tooltip invisible.
1337 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
1338 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
1339 is called for the first time.
1341 * public/index.html:
1343 (Chart..bindPlotEventHandlers):
1345 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1347 WebKitPerfMonitor: Tooltips can be cut off at the top
1348 https://bugs.webkit.org/show_bug.cgi?id=130960
1350 Reviewed by Andreas Kling.
1352 * public/common.css:
1353 (#title): Removed the gradients, box shadows, and border from the header.
1354 (#title h1): Reduce the font size.
1355 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
1356 * public/index.html:
1357 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
1358 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
1359 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
1360 * public/js/helper-classes.js:
1361 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
1362 tooltip extending above y=0.
1364 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1366 WebKitPerfMonitor: Y-axis adjustment is too aggressive
1367 https://bugs.webkit.org/show_bug.cgi?id=130937
1369 Reviewed by Andreas Kling.
1371 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
1372 results. This had two major problems:
1373 1. Two standard deviations can be too small to show the confidence interval for results.
1374 2. Sometimes baseline and target can be more than two standards deviations away.
1376 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
1377 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
1378 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
1379 the margin on each side separately to reduce the empty space on either side.
1381 A more rigorous approach would involve computing least squared value of results with respect to intervals
1382 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
1384 * public/index.html:
1385 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
1386 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
1387 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
1388 We wouldn't see the difference between measured values versus baseline and target values otherwise.
1389 * public/js/helper-classes.js:
1390 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
1391 interval delta cannot be computed.
1392 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
1393 within the given interval.
1394 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
1395 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
1396 (PerfTestRuns..unscaledMeansForAllResults):
1397 (PerfTestRuns.min): Take the confidence interval delta into account.
1398 (PerfTestRuns.max): Ditto.
1399 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
1400 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
1402 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
1404 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
1406 Some CSS tweaks after r166477 and r166479,
1408 * public/index.html:
1410 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1412 WebKitPerfMonitor: Sometimes text inside panes overlap
1413 https://bugs.webkit.org/show_bug.cgi?id=130956
1415 Reviewed by Gyuyoung Kim.
1417 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
1418 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
1419 reduces the total height of the pane and fits more information per screen capita on the dashboard.
1421 * public/index.html: Updated and added a bunch of CSS rules for the new look.
1422 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
1423 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
1424 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
1425 of the build info shown in a chart pane and a tooltip.
1426 (Chart): Made .status a table.
1427 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
1428 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
1429 now that status.text no longer contains it.
1430 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
1432 * public/js/helper-classes.js:
1433 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
1434 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
1435 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
1436 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
1437 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
1438 capital letter; e.g. "MB" instead of "M B".
1440 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1442 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
1443 https://bugs.webkit.org/show_bug.cgi?id=130957
1445 Reviewed by Gyuyoung Kim.
1447 Moved the slider into the header. Also reduced the spacing between the header and platform names.
1448 This reclaims 50px × width of the screen real estate.
1450 * public/common.css:
1451 (#title): Reduced the space below the header from 20px to 10px.
1452 * public/index.html:
1453 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
1454 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
1455 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
1456 real estate between the header and the platform names.
1458 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
1460 Update the install guidelines for perf.webkit.org
1461 https://bugs.webkit.org/show_bug.cgi?id=129895
1463 Reviewed by Ryosuke Niwa.
1465 The current install guideline for perf.webkit.org discourages the use of the installed
1466 Server application. I've actualized the documentation for Mavericks, and modified the
1467 guideline to include the instructions for Server.app also.
1471 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
1473 Update perf.webkit.org json example
1474 https://bugs.webkit.org/show_bug.cgi?id=129907
1476 Reviewed by Andreas Kling.
1478 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
1482 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
1484 Merge database-common.js and utility.js into run-tests.js.
1486 Reviewed by Matthew Hanson.
1488 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
1489 Also moved init-database.sql out of the database directory and removed the directory entirely.
1491 * database: Removed.
1492 * database/database-common.js: Removed.
1493 * database/utility.js: Removed.
1494 * init-database.sql: Moved from database/init-database.sql.
1496 (connect): Moved from database-common.js.
1497 (pathToDatabseSQL): Extracted from pathToLocalScript.
1498 (pathToTests): Moved from database-common.js.
1501 (SerializedTaskQueue): Ditto.
1503 (initializeDatabase):
1504 (TestEnvironment.it):
1505 (TestEnvironment.queryAndFetchAll):
1508 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1510 Remove the dependency on node.js from the production code.
1512 Reviewed by Ricky Mondello.
1514 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
1516 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
1517 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
1518 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
1519 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
1520 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
1522 Also removed the js files that are no longer used.
1524 * config.json: Moved from database/config.json.
1525 * database/aggregate.js: Removed. No longer used.
1526 * database/database-common.js: Removed unused functions, and updated the path to config.json.
1527 * database/process-jobs.js: Removed. No longer used.
1528 * database/sample-data.sql: Removed. We have a much better corpus of data now.
1529 * database/schema.graffle: Removed. It's completely obsolete.
1530 * public/include/db.php: Updated the path to config.json.
1531 * public/include/evaluator.js: Removed.
1533 * public/include/report-processor.php:
1534 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
1535 storing values into $expressions and calling evaluate_expressions_by_node.
1536 (TestRunsGenerator::aggregate_values): Added.
1537 (TestRunsGenerator::compute_caches): Directly compute the caches.
1539 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1541 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
1543 * public/admin/platforms.php:
1544 * public/include/db.php:
1546 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1548 Zoomed y-axis view is ununsable when the last result is an outlier.
1550 Reviewed by Stephanie Lewis.
1552 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
1553 the last result so that the graph looks sane if the last result was an outlier. However, always show
1554 the last result's mean even if it was an outlier.
1556 * public/index.html:
1557 * public/js/helper-classes.js:
1558 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
1559 Also added the ability to cache the unscaled means to avoid recomputation.
1560 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
1561 (PerfTestRuns.max): Ditto.
1562 (PerfTestRuns.sampleStandardDeviation): Ditto.
1563 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
1565 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1569 * public/admin/tests.php:
1570 * public/js/helper-classes.js:
1572 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
1574 Use two standard deviations instead as I mentioned in the mailing list.
1576 * public/index.html:
1578 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1580 The performance dashboard erroneously shows upward arrow for combined metrics.
1582 A single outlier can ruin the zoomed y-axis view.
1584 Rubber-stamped by Antti Koivisto.
1586 * public/index.html:
1587 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
1588 from the latest results' mean.
1589 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
1590 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
1591 (Chart.toggleYAxis):
1592 * public/js/helper-classes.js:
1593 (PerfTestRuns.sampleStandardDeviation): Added.
1594 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
1596 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1598 Don't include the confidence interval when computing the y-axis.
1600 Rubber-stamped by Simon Fraser.
1602 * public/js/helper-classes.js:
1606 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1608 Tiny CSS tweak for tooltips.
1610 * public/index.html:
1612 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1614 Remove the erroneously repeated code.
1616 * public/admin/test-configurations.php:
1618 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1620 <rdar://problem/15704893> perf dashboard should show baseline numbers
1622 Reviewed by Stephanie Lewis.
1624 * public/admin/bug-trackers.php:
1625 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
1628 * public/admin/platforms.php:
1629 (merge_list): Ditto.
1631 * public/admin/test-configurations.php: Added.
1632 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
1633 build_revisions as they're not meaningful for baseline / target numbers.
1634 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
1635 one test run so that we don't accidentally delete a reported test run.
1636 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
1637 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
1638 and delete existing ones.
1640 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
1641 on each platform; there could be configurations of distinct types such as "current" and "baseline".
1642 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
1644 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
1645 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
1646 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
1647 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
1648 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
1650 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
1652 * public/include/admin-header.php:
1653 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
1654 have id and type sub columns, and each custom column could generate multiple rows.
1656 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
1657 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
1658 We then proceed to generate the second header row with sub column names.
1660 When generating the actual content, we first generate all custom columns as they may have multiple rows in
1661 which case regular columns need rowspan set to the maximum number of rows.
1663 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
1666 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
1667 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
1668 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
1669 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
1670 expanded to occupy all sub columns.
1672 * public/include/manifest.php:
1673 (ManifestGenerator::platforms): Don't add the metric more than once.
1675 * public/include/test-name-resolver.php:
1676 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
1677 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
1678 full metric name later.
1679 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
1680 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
1681 (TestNameResolver::full_name_for_test): Added.
1682 (TestNameResolver::full_name_for_metric): Added.
1683 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
1685 * public/js/helper-classes.js:
1686 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
1687 test runs created to set baseline and target points.
1689 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1691 Build fix after r57928. Removed a superfluous close parenthesis.
1693 * public/api/runs.php:
1695 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1697 Unreviewed build & typo fixes.
1699 * public/admin/platforms.php:
1700 * tests/admin-platforms.js:
1702 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1704 <rdar://problem/15704893> perf dashboard should show baseline numbers
1706 Rubber-stamped by Antti Koivisto.
1708 Organize some code into functions in runs.php.
1710 Also added back $paths that was erroneously removed in r57925 from json-header.php.
1712 * public/api/runs.php:
1713 (fetch_runs_for_config): Extracted.
1714 (format_run): Ditto.
1716 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1718 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
1720 * database/config.json:
1721 * public/admin/reprocess-report.php:
1722 * public/api/report.php:
1723 * public/api/runs.php:
1724 * public/include/json-header.php:
1726 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1728 Commit yet another forgotten change.
1730 Something went horribly wrong with my merge :(
1732 * database/init-database.sql:
1734 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1736 Commit one more forgotten change. Sorry for making a mess here.
1738 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1740 Commit the forgotten files.
1742 * public/admin/platforms.php: Added.
1743 * tests/admin-platforms.js: Added.
1745 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1747 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
1749 Reviewed by Stephanie Lewis.
1751 Added /admin/platforms/ page to hide and merge platforms.
1753 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
1754 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
1755 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
1756 each test configuration a distinct "test run" for each build.
1758 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
1759 their test configurations into platform B.
1761 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
1762 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
1763 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
1764 in platform B, in which case R should relate to T_B instead.
1766 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
1767 new platform. We then migrate the test configurations of the remaining test runs.
1769 * database/init-database.sql: Added platform_hidden.
1771 * public/admin/platforms.php: Added.
1772 (merge_platforms): Added. Implements the algorithm described above.
1773 (merge_list): Added.
1775 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
1776 is hidden since it doesn't do anything.
1778 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
1779 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
1780 missing it since unchecked checkbox doesn't set the value in $_POST.
1781 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
1782 switch statement instead of repeated if's.
1783 (AdministrativePage::render_table): Emit "update-column" for update_field.
1785 * public/include/db.php: Disable warnings when we're not in the debug mode.
1787 * public/include/manifest.php:
1788 (ManifestGenerator::platforms): Skip platforms that have been hidden.
1791 (TestEnvironment.postJSON):
1792 (TestEnvironment.httpGet):
1793 (TestEnvironment.httpPost): Added.
1794 (sendHttpRequest): Set the content type if specified.
1796 * tests/admin-platforms.js: Added tests.
1798 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
1800 Extract the code to compute full test names from tests.php.
1802 Reviewed by Stephanie Lewis.
1804 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
1805 and paves our way to re-use the code in other pages.
1807 * public/admin/tests.php:
1809 * public/include/db.php:
1810 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
1811 tests.php and test-name-resolver.php.
1813 * public/include/test-name-resolver.php: Added.
1814 (TestNameResolver::__construct):
1815 (TestNameResolver::compute_full_name): Moved from tests.php.
1816 (TestNameResolver::map_metrics_to_tests): Ditto.
1817 (TestNameResolver::sort_tests_by_full_name): Ditto.
1818 (TestNameResolver::tests): Added.
1819 (TestNameResolver::test_id_for_full_name): Ditto.
1820 (TestNameResolver::metrics_for_test_id): Ditto.
1821 (TestNameResolver::child_metrics_for_test_id): Ditto.
1822 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
1824 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1826 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1828 Reviewed by Stephanie Lewis.
1830 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
1832 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
1833 but that's sufficient to correct the wrongfully processed reports for now.
1835 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
1836 We should eventually add a nice UI to find and reprocess reports.
1838 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
1840 * public/include/db.php: Added the forgotten call to prefixed_column_names.
1842 * public/include/report-processor.php: Copied from public/api/report.php.
1843 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
1844 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
1845 create a new report or authenticate the builder password (the password is never stored in the report).
1846 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
1847 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
1848 (ReportProcessor::store_report): Ditto.
1850 * tests/admin-reprocess-report.js: Added.
1852 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1854 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1856 Reviewed by Ricky Mondello.
1858 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
1859 for the same build number as a single build by ignoring build time. This was necessary to associate
1860 multiple reports by a single build - e.g. for different performance test suites - because the scripts
1861 we use to submit results computed its own "build time" when they're called.
1863 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
1864 last week; new reports were wrongfully associated with old build numbers.
1866 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
1867 to the same build. Instead, we create a new build object for those reports. Since the longest set of
1868 tests we have only take a couple of hours to run, 24 hours should be more than enough.
1870 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
1871 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
1872 (builder, build number, build time).
1874 * public/api/report.php:
1875 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
1876 when no such build exists. This prevents a report from being associated with a very old build of the same
1879 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
1880 a similar bug in the future sooner.
1882 * tests/api-report.js: Added three test cases.
1884 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1886 Merged the upstream changes to db.php
1887 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
1889 * public/include/db.php:
1891 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1893 Update other scripts and tests per previous patch.
1895 * public/include/manifest.php:
1896 * tests/admin-regenerate-manifest.js:
1898 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1900 Remove metrics_unit.
1902 Reviewed by Ricky Mondello.
1904 This column is no longer used by the front-end code since r48360.
1906 * database/init-database.sql:
1907 * public/admin/tests.php:
1909 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
1911 Unreviewed build fix.
1913 * public/api/report.php:
1915 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
1917 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
1919 Reviewed by Ricky Mondello.
1921 Support a new alternative format for aggregated results where we have raw values as well as
1922 the list aggregators so that instead of
1923 "metrics": {"Time": ["Arithmetic"]}
1925 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
1927 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
1928 dashboard and the generated results page, which doesn't know how to aggregate values.
1930 We need to keep the support for the old format because all other existing performance tests
1931 all rely on the old format. Even if we updated the tests, we need the dashboard to support
1932 the old format during the transition.
1934 * public/api/report.php:
1935 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
1936 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
1938 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
1940 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1942 Unreviewed; Tweak the CSS so that chart panes align vertically.
1944 * public/index.html:
1946 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1948 SafariPerfMonitor should support Combined metric.
1950 * public/js/helper-classes.js:
1951 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
1952 value as well but assume it to be greater-is-better for now.
1954 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1956 Commit the forgotten init-database change to add iteration_relative_time.
1958 * database/init-database.sql:
1960 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1962 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
1964 Reviewed by Ricky Mondello.
1966 Add the support for each value to have a relative time. This is necessary for frame rate history
1967 since a frame rate needs to be associated with a time it was sampled.
1969 * database/init-database.sql: Added iteration_relative_time to run_iterations.
1971 * public/api/report.php:
1972 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
1973 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
1974 with relative time since taking the average of two frame rates for two subtests taken at two
1975 different times doesn't make any sense.
1976 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
1977 etc..., use the second element since we assume values are of the form (relative time, frame rate).
1978 Also exit early with an error if the number of elements in the array is not a pair.
1979 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
1981 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
1982 iteration_relative_time.
1984 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
1986 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
1988 Reviewed by Ricky Mondello.
1990 Support that. It's one line change.
1992 * public/api/report.php:
1993 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
1994 to match the convention assumed elsewhere.
1995 * tests/api-report.js: Added a test case.
1997 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1999 SafariPerfMonitor shows popups for points outside of the visible region.
2001 Rubber-stamped by Simon Fraser.
2003 * public/index.html:
2004 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2005 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2006 may return an item underneath y-axis labels.
2008 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2010 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2012 * public/index.html:
2014 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2016 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2018 * public/index.html:
2020 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2022 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2023 <rdar://problem/13992271> Should scale Y axis to include error ranges
2025 Reviewed by Ricky Mondello.
2027 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2028 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2030 * database/config.json:
2031 * public/index.html:
2032 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2033 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2034 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2036 * public/js/helper-classes.js:
2037 (PerfTestResult.confidenceIntervalDelta):
2038 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2039 (PerfTestRuns.min): Take confidence interval delta into account.
2040 (PerfTestRuns.max): Ditto.
2041 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2043 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2045 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2047 * public/api/report.php:
2048 (ReportProcessor::recursively_ensure_tests):
2049 * tests/api-report.js: Added a test.
2051 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2053 Unreviewed build fixes.
2055 * public/api/report.php:
2056 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
2057 Also, tolerate reports without any revision information.
2059 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
2062 * tests/api-report.js: Added few test cases.
2064 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2066 Commit another change that was supposed to be committed in r50331.
2069 (TestEnvironment.this.postJSON):
2070 (TestEnvironment.this.httpGet):
2073 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
2075 Commit the remaining files.
2077 * public/admin/regenerate-manifest.php:
2078 * public/include/admin-header.php:
2079 * public/include/json-header.php:
2080 * public/include/manifest.php:
2082 (TestEnvironment.this.postJSON):
2083 (TestEnvironment.this.httpGet):
2086 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
2088 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
2090 Reviewed by Ricky Mondello.
2092 Added some tests for admin/regenerate-manifest.
2094 * public/admin/regenerate-manifest.php: Use require_once instead of require.
2095 * public/include/admin-header.php: Ditto.
2096 * public/include/json-header.php: Ditto.
2098 * public/include/manifest.php:
2099 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
2100 When there are no builders, simply return an empty array.
2103 (TestEnvironment.postJSON):
2104 (TestEnvironment.httpGet): Added.
2105 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
2107 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
2109 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
2111 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
2112 and run_iterations. Also fixed a typo in report.php found by new tests.
2114 * public/api/report.php:
2115 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
2116 * tests/api-report.js: Added more test cases.
2118 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
2120 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
2122 Reviewed by Ricky Mondello.
2124 Add a test runner script and some simple test cases.
2126 * database/config.json: Added the configuration for "testServer".
2127 * database/database-common.js:
2128 (pathToTests): Added.
2129 * run-tests.js: Added.
2132 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
2133 and if there are, asks the user if it’s okay to delete all of the data contained therein.
2134 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
2136 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
2137 in the current database using PostgreSQL's information_schema.
2138 (askYesOrNoQuestion):
2140 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
2142 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
2143 (TestEnvironment.assert): Exposes assert to tests.
2144 (TestEnvironment.console): Exposes console to tests.
2145 (TestEnvironment.describe): Adds a description.
2146 (TestEnvironment.it): Adds a test case.
2147 (TestEnvironment.postJSON):
2148 (TestEnvironment.queryAndFetchAll):
2149 (TestEnvironment.sha256):
2150 (TestEnvironment.notifyDone): Ends the current test case.
2154 (TestContext): An object created for each test case. Conceptually, this object is always on
2155 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
2156 this object via currentTestContext.
2157 (TestContext.description):
2159 (TestContext.logError):
2162 * tests/api-report.js: Added some basic tests for /api/report.php.
2164 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2166 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
2168 The problem was that we were detecting whether we're updating dashboard or not by checking
2169 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
2170 all configurations. Use separate 'dashboard' action to execute the code even when
2171 metric_configurations is empty.
2173 * public/admin/tests.php:
2175 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2177 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
2179 Reviewed by Ricky Mondello.
2181 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
2182 from ReportProcessor as a preparation to replace deprecated aggregate.js.
2184 * public/api/report.php:
2185 (ReportProcessor::exit_with_error): Moved.
2186 (ReportProcessor::process): Use the extracted TestRunsGenerator.
2187 (TestRunsGenerator): Added.
2188 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
2189 (TestRunsGenerator::add_aggregated_metric): Moved.
2190 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
2191 (TestRunsGenerator::aggregate): Moved. Made public.
2192 (TestRunsGenerator::aggregate_current_test_level): Moved.
2193 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
2194 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
2195 (TestRunsGenerator::compute_caches): Moved. Made public.
2196 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
2197 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
2198 (TestRunsGenerator::rollback_with_error): Moved.
2200 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2202 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
2204 Reviewed by Remy Demarest.
2206 Regenerate the manifest file when updating fields or adding new items that are included in
2209 * public/admin/bug-trackers.php:
2210 * public/admin/builders.php:
2211 * public/admin/regenerate-manifest.php:
2212 * public/admin/repositories.php:
2213 * public/admin/tests.php:
2214 * public/include/admin-header.php:
2215 (regenerate_manifest): Extracted from regenerate-manifest.php.
2217 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2219 Unreviewed build fix for memory test results.
2221 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
2222 aggregating at each level.
2224 * public/api/report.php:
2225 (ReportProcessor::recursively_ensure_tests):
2226 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
2227 (ReportProcessor::add_values_for_aggregation):
2228 (ReportProcessor::aggregate):
2229 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
2231 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
2233 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
2234 not the number of iteration groups. Also, don't set group number when the entire run belongs
2235 a single iteration group.
2237 * public/api/report.php:
2238 (ReportProcessor::commit):
2240 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2242 SafariPerfMonitor: Introduce iteration groups
2244 Reviewed by Remy Demarest.
2246 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
2247 the runtime environment variances to get more stable results. And it's desirable to keep track of
2248 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
2250 This patch introduces "iteration groups" to keep track of this extra information.
2252 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
2253 the outer array denotes iteration groups and each inner array contains iteration values for each group.
2256 * database/init-database.sql: Add iteration_group column.
2257 * public/api/report.php:
2258 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
2260 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
2261 contains the list of values indexed by the iteration order and group sizes. Store the group size so
2262 that we can restore the iteration groups before passing it to node.js and restore them later.
2264 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
2265 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
2267 Also check that each iteration group in each subtest are consistent with one another. To see why we need
2268 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
2269 that each iteration group in T1 and T2 have the same size:
2270 T1 = [[1, 2], [3, 4, 5]]
2271 T2 = [[6, 7], [8, 9, 10]]
2273 so that the aggregated result (the sum in this case) can have the same groups as in:
2274 T = [[7, 9], [11, 13, 15]]
2276 If some iteration groups in T1 and T2 had a different size as in:
2277 T1 = [[1, 2, 3], [4, 5]]
2278 T2 = [[6, 7], [8, 9, 10]]
2280 Then iteration groups of the aggregated T is ambiguous.
2282 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
2283 (ReportProcessor::commit): Store iteration_group values.
2285 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2287 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
2288 migrated to perf.webkit.org.
2290 * database/perf-webkit-migrator.js: Removed.
2292 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2294 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
2296 * public/index.html:
2299 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2301 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
2303 Reviewed by Ricky Mondello.
2305 It is often desirable to see charts of a given test for all platforms, or to be able to see
2306 charts of all subtests on a given platform when trying to triage perf. regressions.
2308 Support this use case by adding the ability to do so on the charts page.
2310 Also, we used to disable items on the test list based on the platform chosen. This turned out
2311 to be a bad UI because in many situations you want to be able to compare results of the same test
2312 on multiple platforms.
2314 In this new UI, we have three select elements, each of which selects the following:
2315 1. Top-level test - Test suite such as Dromaeo
2316 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
2317 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
2318 3. Platform - Mountain Lion, Qt, etc...
2320 A user can select "all" for metric and platform but we disallow doing both at once since adding
2321 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
2322 think of a use case where you want to look at that many charts at once. We can support this later
2323 if valid use cases come up.
2325 * public/index.html:
2326 (.showCharts.addOption): Extracted.
2327 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
2328 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
2329 metricList has onchange handler that enables/disables items on platformList.
2331 (init): Sort tests and test metrics here instead of doing that in showCharts.
2333 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
2335 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
2337 Reviewed by Remy Demarest and Ricky Mondello.
2339 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
2340 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
2341 templates to the manifest file instead. Each build now only contains the builder id.
2343 * public/api/runs.php: Removed the part of the query that joined builders table. This
2344 speeds up the query quite a bit.
2346 * public/include/manifest.php:
2347 (ManifestGenerator::generate): Generate builders field.
2348 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
2349 associative array that contains name and its build URL template.
2351 * public/index.html:
2352 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
2353 instead of a revision since this function is used for revisions and build page URLs now.
2354 (.buildLabelWithLinks): Include the linkified build number.
2356 * public/js/helper-classes.js:
2357 (TestBuild.builder): Added.
2358 (TestBuild.buildNumber): Added.
2359 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
2360 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
2362 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
2364 Tooltips interfere with user interactions
2366 Rubber-stamped by Simon Fraser.
2368 Disable tooltip on the dashboard page since graphs are too small to be useful there.
2369 Also, show graphs for only 10 days by default as opposed to 20.
2370 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
2372 * public/index.html:
2373 * public/js/helper-classes.js:
2375 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
2377 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
2378 to be compatible with webkit-perf.appspot.com.
2380 * public/admin/builders.php:
2381 * public/api/report.php:
2383 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
2387 Add a missing constraint on builds table. For a given builder, there should be exactly
2388 one build for a given build number.
2390 Also add report_committed_at to reports table to record the time at which a given report
2391 was processed and test_runs and run_iterations rows were committed into the database.
2393 * database/config.json:
2394 * public/api/report.php:
2396 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
2398 Unreviewed. Add more checks for empty SQL query results.
2400 * public/include/manifest.php:
2402 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2404 More build fixes on perf.webkit.org.
2406 * public/api/runs.php: Make PostgreSQL happier.
2407 * public/include/manifest.php: Don't assume we always have bug trackers.
2409 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2411 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
2412 and fix other miscellaneous UI bugs.
2414 Rubber-stamped by Simon Fraser.
2416 Removed the code to determine whether smaller value is better or not for a given test in index.html
2417 in the favor of using that of PerfTestRuns.
2419 * public/include/manifest.php: Fixed a typo.
2420 * public/index.html:
2422 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
2424 * public/js/helper-classes.js:
2425 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
2427 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
2428 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
2429 at roughly 2,000 units to avoid this.
2431 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
2432 The only thing we can avoid is innerHTML.
2434 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2436 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
2438 * public/include/evaluator.js:
2440 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2442 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
2444 Reviewed by Remy Demarest.
2446 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
2447 admin/bug-trackers.php and can be associated with multiple repositories.
2449 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
2450 to determine the set of bug trackers to show for a given set of blame lists.
2451 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
2452 a place to file bugs against the regression.
2454 * database/init-database.sql: Added bug_trackers and tracker_repositories.
2455 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
2457 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
2458 bug trackers, namely associated repositories.
2460 * public/include/admin-header.php: Added a link to bug-trackers.php
2461 * public/include/manifest.php:
2462 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
2463 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
2465 (ManifestGenerator::repositories):
2467 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
2468 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
2469 'repositories' where the latter contains the list of associated repository names.
2471 * public/index.html:
2472 (Chart): Takes bugTrackers as as argument.
2473 (Chart.showTooltipWithResults): Removed the hard-coded list.
2475 (init.addPlatformsToDashboard):
2476 (init.showCharts.createChartFromListPair):
2477 (init): Stores the list of bug trackers in the manifest to a local variable.
2479 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2481 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
2483 * public/include/evaluator.js:
2485 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2487 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
2489 Reviewed by Remy Demarest.
2491 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
2492 new row into the database.
2494 * public/admin/aggregators.php: Use AdministrativePage.
2495 * public/admin/builders.php: Ditto.
2496 * public/admin/repositories.php: Ditto.
2497 * public/include/admin-header.php:
2498 (AdministrativePage): Added.
2499 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
2500 to an associative array that describes the column.
2501 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
2502 - label: Human readable name of the column.
2503 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
2504 column exists only before we create password_hash column at the insertion time.
2506 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
2507 titlecase (e.g. new_bug is converted to New Bug).
2508 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
2509 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
2510 textarea for a given editing mode ('text', 'url', or 'string').
2511 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
2512 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
2514 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
2516 Build fix. Some systems don't support r+. Use proc_open instead.
2518 * public/api/report.php:
2520 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2522 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
2523 when computing the y-axis of data points to show tooltips at.
2525 * public/index.html:
2527 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2529 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
2532 * public/.htaccess: Removed.
2534 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
2538 * public/include/manifest.php: Build fix. db is on this.
2539 * public/js/statistics.js:
2540 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
2542 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
2544 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
2546 Reviewed by Anders Carlsson.
2548 Rewrote and merged populate-from-report.js into report.php.
2550 * database/config.json: Added a path to node.js.
2552 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
2553 Once we land this patch and update the administrative pages, we can remove this column.
2555 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
2556 that table is going away once we remove the node.js backend.
2558 * database/populate-from-report.js: Removed.
2559 * public/api/report.php: Added.
2561 (ReportProcessor.__construct):
2562 (ReportProcessor.process):
2564 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
2565 verified to be submitted by a known builder.
2567 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
2568 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
2569 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
2570 inside a transaction because there could be multiple reports for a single build, each containing results for
2573 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
2574 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
2575 add_values_to_commit, and add_values_for_aggregation.
2577 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
2578 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
2579 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
2582 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
2583 to be aggregated in ReportProcessor.aggregate.
2585 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
2587 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
2588 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
2589 given for each row (child metrics of M). This function extracts each column (iteration) via
2590 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
2591 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
2593 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
2594 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
2595 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
2597 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
2598 (ReportProcessor.evaluate_expressions_by_node): See above.
2600 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
2601 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
2602 results also need the said caches.
2604 (ReportProcessor.add_values_to_commit):
2606 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
2607 the transaction as needed if anything goes wrong.
2609 (ReportProcessor.rollback_with_error)
2611 * public/include/db.php:
2612 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
2613 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
2614 contiguously in a SQL statement.
2616 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
2617 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
2618 a column value of the choice.
2620 (Database.begin_transaction): Added.
2621 (Database.commit_transaction): Added.
2622 (Database.rollback_transaction): Added.
2624 * public/include/evaluator.js: Added.
2625 * public/include/json-header.php:
2626 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
2627 context under which the request failed.
2628 (successful_exit): Merge "additional details".
2629 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
2630 (merge_additional_details):
2632 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
2634 SafariPerfMonitor: Add more helper functions to db.php
2636 Reviewed by Remy Demarest.
2638 Added Database::insert_row and array_get to make common database operations easier.
2640 * public/admin/aggregators.php: Use Database::insert_row instead of
2641 execute_query_and_expect_one_row_to_be_affected.
2643 * public/admin/builders.php: Ditto.
2645 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
2646 inserting a row. With insert_row, we don't need that.
2648 * public/include/admin-header.php: Ditto.
2650 * public/include/db.php:
2651 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
2652 return the default value (defaults to NULL) if the key doesn't exist.
2654 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
2657 (Database::prepare_params): Added. Takes an associative array of column names and their values,
2658 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
2659 column names all in the same order.
2661 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
2662 the given prefix. Values are given in a form of an associative array where keys are unprefixed
2663 column names and values are corresponding values. When the row is successfully inserted, it returns
2664 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
2665 indicating the success of the insertion.
2667 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2669 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
2671 Reviewed by Conrad Shultz.
2673 Rewrote the manifest generator in PHP.
2675 * database/generate-manifest.js: Removed.
2676 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
2677 * public/include/db.php:
2678 (array_ensure_item_has_array): Added.
2679 * public/include/evaluator.js: Added.
2680 * public/include/json-header.php:
2681 * public/include/manifest.php: Added.
2683 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2685 Dates on overflow plot are overlapping
2687 Rubber-stamped by Simon Fraser.
2689 Don't show more than 5 days.
2691 * public/index.html:
2692 * public/js/helper-classes.js:
2693 (TestBuild.UTCtoPST):
2696 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2698 Show build time as well as commit time on the dashboard and tooltips.
2700 Rubber-stamped by Simon Fraser.
2702 Include both the maximum commit time and build time in buildLabelWithLinks.
2703 Also use ISO format to save the screen real estate.
2705 * public/index.html:
2706 (buildLabelWithLinks):
2707 * public/js/helper-classes.js:
2709 (TestBuild.buildTime):
2710 (TestBuild.formattedBuildTime):
2712 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
2714 Unreviewed; Convert metric.name to metric.unit in the front end.
2716 * public/js/helper-classes.js:
2718 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2720 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
2722 Rubber-stamped by Simon Fraser.
2724 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
2725 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
2726 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
2728 * public/index.html:
2729 (.buildLabelWithLinks): Extracted from TestBuild.label.
2730 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
2731 on Radar and WebKit Bugzilla.
2732 * public/js/helper-classes.js:
2733 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
2734 (PerfTestResult.isBetterThan): Added.
2735 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
2736 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
2737 to indicate progressions or regressions.
2738 (PerfTestResult.label):
2739 (TestBuild.formattedTime): Added.
2740 (TestBuild.platform): Added.
2741 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
2742 (TestBuild.smallerIsBetter): Added.
2743 (Tooltip.show): Take a raw markup instead of two results.
2745 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
2747 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
2749 Rubber-stamped by Tim Horton.
2751 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
2752 since each platform may have a different number of tests to be shown on the dashboard.
2754 * public/index.html:
2756 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2758 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
2760 * public/js/helper-classes.js:
2763 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2765 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
2767 Rubber-stamped by Tim Horton.
2769 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
2771 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
2772 the revision r1234 was the revision used in the previous build.
2774 * public/api/runs.php:
2775 (parse_revisions_array): Trim double quotations around repository names and revisions.
2776 * public/js/helper-classes.js:
2779 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2781 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
2783 Rubber-stamped by Tim Horton.
2785 * public/index.html:
2786 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
2787 on the dashboard page as it's way too noisy.
2789 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
2791 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
2792 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
2793 so that the tooltip for hover can be reused further.
2795 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
2796 and find the first point that lies on the right of the cursor position. We then compute the midpoint
2797 between this and the previous point and pick the closer of the two. It returns an item-like object
2798 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
2800 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
2802 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
2803 the first or "current" data points (as opposed to target or baseline data points).
2805 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
2806 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
2807 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
2809 * public/js/helper-classes.js:
2810 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
2811 work to the client via bindClick.
2813 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
2815 (Tooltip.bindClick): Added.
2817 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2819 Yet another build fix. metricId*s*.
2821 * public/admin/tests.php:
2823 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2825 Another build fix. Use the new payload format for the aggregate job.
2827 * public/admin/tests.php:
2829 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2833 * database/aggregate.js: Use variables that actually exist.
2834 * database/database-common.js:
2835 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
2836 function calls will find this configuration.
2838 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2840 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
2842 Reviewed by Ricky Mondello.
2844 Turned InstallManual into a proper markdown document and added ReadMe.md.
2846 * InstallManual: Removed.
2847 * InstallManual.md: Moved from InstallManual.
2850 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2852 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
2854 Reviewed by Ricky Mondello.
2856 This patch prepares the front end code to process baseline and target results properly.
2858 * public/index.html:
2859 (fetchTest.createRunAndResults): Extracted.
2860 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
2861 Deleted the comment about how sorting will be unnecessary once we start results in the server side
2862 since sorting by the maximum revision commit time turned out to be non-trivial in php.
2864 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2866 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
2868 Reviewed by Tim Horton.
2870 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
2871 These files are "dynamically linked" to our app.
2873 * public/index.html:
2874 * public/js/jquery-1.8.2.min.js: Removed.
2875 * public/js/jquery.colorhelpers.js: Added.
2876 * public/js/jquery.flot.categories.js: Added.
2877 * public/js/jquery.flot.crosshair.js: Added.
2878 * public/js/jquery.flot.errorbars.js: Added.
2879 * public/js/jquery.flot.fillbetween.js: Added.
2880 * public/js/jquery.flot.js: Added.
2881 * public/js/jquery.flot.min.js: Removed.
2882 * public/js/jquery.flot.navigate.js: Added.
2883 * public/js/jquery.flot.resize.js: Added.
2884 * public/js/jquery.flot.selection.js: Added.
2885 * public/js/jquery.flot.stack.js: Added.
2886 * public/js/jquery.flot.symbol.js: Added.
2887 * public/js/jquery.flot.threshold.js: Added.
2888 * public/js/jquery.flot.time.js: Added.
2889 * public/js/jquery.js: Added.
2891 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2893 Return NaN instead of throwing when there aren't enough samples.
2895 Reviewed by Sam Weinig.
2897 It's better to return NaN when we don't have enough samples so that we can treat it
2898 as if we don't have any confidence interval.
2900 * public/js/statistics.js:
2903 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2905 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
2907 * public/js/helper-classes.js:
2908 (URLState.parseIfNeeded):
2910 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2912 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
2914 Reviewed by Ricky Mondello.
2916 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
2918 * public/admin/aggregators.php: Use heredoc.
2919 * public/admin/builders.php:
2920 * public/admin/jobs.php:
2921 * public/admin/repositories.php:
2922 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
2923 This allows us to use update_field when updating test's url and metric's unit. Changed the action
2924 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
2925 Also removed a stray code to update unit and url simultaneously since it's never used.
2926 * public/include/admin-header.php:
2927 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
2928 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
2929 (update_field): Moved from repositories.php.
2931 * public/include/db.php:
2932 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
2934 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
2936 Build fixes. Treat mean, sum, and square sum as float, not int.
2938 Also use 95% confidence interval instead of 90% confidence interval.
2940 * public/api/runs.php:
2941 * public/js/helper-classes.js:
2942 (.this.confidenceIntervalDelta):
2944 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
2946 Add an administrative page to edit repository information.
2948 Reviewed by Ricky Mondello.
2950 * public/admin/repositories.php: Added.
2951 * public/include/admin-header.php:
2953 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
2955 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
2957 Reviewed by Ricky Mondello.
2959 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
2960 to aggregate results for those matrix in populate-from-report.js.
2962 * database/generate-manifest.js:
2963 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
2964 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
2965 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
2966 * database/populate-from-report.js:
2968 (getReport): No change even though the diff looks as if it moved.
2969 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
2970 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
2971 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
2972 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
2973 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
2975 (ensureMetricId): Take an aggregator id as an argument.
2976 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
2977 for all builds when the build id is not specified.
2978 * public/admin/tests.php:
2979 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
2980 of the same name with different aggregators.
2982 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
2984 Build fix. Don't pass in arguments to in the wrong order.
2986 * database/aggregate.js:
2988 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2990 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
2992 Reviewed by Ricky Mondello.
2994 Since the version of flot we use doesn't support showing graphs in the current locate or
2995 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
2996 treat them as in UTC). We don't want to use the current locate because other websites on
2997 webkit.org assume PST.
2999 Also append this information to build's label.
3001 * public/js/helper-classes.js:
3005 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3007 Store test URLs reported by builders.
3009 Reviewed by Ricky Mondello.
3011 * database/populate-from-report.js:
3012 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
3013 (ensureTestId): Store the URL.
3015 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
3017 Yet another build fix; don't blow up even if we didn't have any test configurations.
3019 * public/admin/tests.php:
3021 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3023 Build fix; don't instantiate Date when a timestamp wasn't provided.
3025 * database/populate-from-report.js:
3027 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
3029 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
3031 Reviewed by Tim Horton.
3033 Added an install manual.
3035 * InstallManual: Added.
3037 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
3039 Minor build fix. Don't unset builderPassword when it's not set.
3041 * public/api/report.php:
3043 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3045 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
3047 Reviewed by Ricky Mondello.
3049 * public/admin/admin.css: Make a very large payload scrollable.
3050 * public/admin/jobs.php: Format JSONs.
3052 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
3054 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
3056 Reviewed by Ricky Mondello.
3058 Add report.php and populate-from-report.js that process JSON files submitted by builders.
3060 * database/populate-from-report.js: Added.
3062 (getReport): Obtains the payload (the actual report) from "jobs" table.
3063 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
3064 and their results. This function recursively traverses tests and metrics and ensure their ids.
3066 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
3067 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
3068 is a "function" in mathematical sense).
3070 (ensureRepositoryIdsForAllRevisions):
3071 (getIdOrCreateBuildWithRevisions):
3072 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
3073 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
3074 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
3076 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
3077 test results all in a single transaction. This allows us to keep the database consistent in that either
3078 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
3079 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
3080 other parts of the application are concerned.
3081 (scheduleQueriesToInsertRun):
3082 * database/process-jobs.js: Add a call to populate-from-report.js.
3083 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
3084 * public/include/db.php: Support parameterized query.
3085 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
3086 a test result could confirm that the submission indeed succeeded.
3088 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3090 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
3092 * database/aggregate.js:
3093 * database/database-common.js:
3094 (selectColumnCreatingRowIfNeeded):
3095 (ensureRepositoryId):
3096 (ensureConfigurationIdFromList):
3097 * database/perf-webkit-migrator.js:
3100 (getOrCreateBuildId):
3102 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
3104 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
3106 Reviewed by Ricky Mondello.
3108 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
3109 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
3111 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
3114 (saveAggregatedResults):
3115 * database/database-common.js:
3116 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
3117 (getIdOrCreateRepository): Ditto.
3118 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
3119 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
3120 * database/perf-webkit-migrator.js:
3121 * database/utility.js: Added.
3122 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
3123 from being executed.
3124 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
3125 call the callback passed into start().
3126 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
3127 (TaskQueue.addTask):
3129 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
3130 (SerializedTaskQueue.executeNextTask):
3131 (SerializedTaskQueue.addTask):
3132 (SerializedTaskQueue.start):
3134 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3136 Revert erroneously committed changes.
3138 * database/config.json:
3140 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3142 aggregator.js should be able to accept multiple metric ids and a single build id.
3144 Reviewed by Ricky Mondello.
3146 Make aggregator.js accept multiple ids and generate results for single build when bots are
3147 reporting new results.
3149 * database/aggregate.js:
3150 (parseArgv): Added. Returns an object containing the parsed representation of argv,
3151 which currently contains metricIDs and buildIds.
3152 (main): Use parseArgv and processConfigurations
3153 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
3154 (processPlatform.processConfigurations): Extracted.
3156 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
3158 Add an administrative page for builders.
3160 Reviewed by Ricky Mondello.
3162 We need an administrative page to add and edit builder information.
3163 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
3165 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
3166 since we don't have plans to use those columns in near future. Also make builder_name unique
3167 as required by the rest of the app.
3168 * public/admin/builders.php: Added.
3169 * public/api/runs.php: Updated per the table rename.
3170 * public/include/admin-header.php: Added a link to builders.php.
3172 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
3174 Build fixes for r46982.
3176 * database/aggregate.js:
3177 (fetchConfigurations): Bind i so that it's not always metricIds.length.
3178 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
3179 (processBuild): Don't print "." until we've committed transactions. It's misleading.
3181 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
3183 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
3185 * public/admin/aggregators.php:
3186 * public/admin/footer.php: Removed.
3187 * public/admin/header.php: Removed.
3188 * public/admin/index.php:
3189 * public/admin/jobs.php:
3190 * public/admin/tests.php:
3191 * public/api/json-header.php: Removed.
3192 * public/api/runs.php:
3193 * public/db.php: Removed.
3194 * public/include: Added.
3195 * public/include/admin-footer.php: Copied from public/admin/footer.php.
3196 * public/include/admin-header.php: Copied from public/admin/header.php.
3197 * public/include/db.php: Copied from public/db.php.
3198 * public/include/json-header.php: Copied from public/api/json-header.php.
3200 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
3202 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
3204 Reviewed by Ricky Mondello.
3206 Added the initial implementation of value aggregation.
3207 Also added abilities to configure the dashboard page in tests.php.
3209 * database/aggregate.js: Added.
3210 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
3211 (TaskQueue.addTask):
3213 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
3214 (SerializedTaskQueue.addTask):
3215 (SerializedTaskQueue.start):
3218 (fetchConfigurations):
3219 (fetchBuildsForPlatform):
3221 (testsWithDifferentIterationCounts):
3222 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
3223 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
3224 (getOrInsertConfiguration):
3226 * database/database-common.js:
3227 (fetchTable): Log an error as an error.
3228 (getOrCreateId): Extracted from perf-webkit-migrator.
3229 (statistics): Added.
3230 * database/perf-webkit-migrator.js:
3231 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
3232 runs JSON since runs JSONs are generated on demand now.
3234 (getOrCreatePlatformId):
3235 (getOrCreateTestId):
3236 (getOrCreateConfigurationId):
3237 (getOrCreateRevisionId):
3238 (getOrCreateRepositoryId):
3239 (getOrCreateBuildId):
3240 * database/process-jobs.js:
3241 (processJob): Handle 'aggregate' type.
3243 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
3245 Fix the dashboard after adding test_metrics.
3247 Reviewed by Ricky Mondello.
3249 Rename test to metrics in various functions and sort tests on the charts page.
3250 Also representing whether a test appears or not by setting a flag on dashboard
3251 was bogus because test objects are shared by multiple platforms. Instead, store
3252 dashboard platform list as intended by the manifest JSON.
3254 * public/index.html:
3255 (PerfTestRuns): Renamed test to metric.
3257 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
3258 (fullName): Moved so that it appears above where it's called.
3259 * public/js/helper-classes.js:
3261 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
3263 Update tests.php to reflect recent changes in the database schema.
3265 Reviewed by Conrad Shultz.
3267 Made the following changes to tests.php:
3268 1. Disallow adding metrics to tests without subtests.
3269 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
3270 3. Linkified tests with subtests instead of showing all them at once.
3272 * public/admin/admin.css:
3273 (.action-field, .notice):
3275 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
3276 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
3277 (add_job): Extracted.
3278 * public/admin/tests.php: See above.
3279 (array_item_set_default): Added.
3280 (array_item_or_default): Renamed from get_value_with_default.
3281 (compute_full_name): Extracted.
3282 (sort_tests): Ditto.
3283 (map_metrics_to_tests): Ditto.
3285 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
3287 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
3289 Reviewed by Simon Fraser.
3291 Linkify the headers using metric.test.url when it's provided.
3293 * public/index.html:
3295 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
3297 Use parameterized pg_query_params in query_and_fetch_all
3299 Reviewed by Conrad Shultz.
3301 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
3303 * public/api/runs.php:
3305 (ctype_alnum_underscore): Added.
3307 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
3309 Update the migration tool to support test_metrics.
3311 Reviewed by Mark Rowe.
3313 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
3314 Also import run_iteration rows as runs JSON files now include individual values.
3316 * database/database-common.js:
3317 (addJob): Extracted.
3318 * database/perf-webkit-migrator.js:
3319 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
3320 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
3321 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
3324 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
3326 Build fix. Suppress "Undefined index" warning.
3328 * public/admin/tests.php:
3330 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
3332 Fix a commit error in r46756. api/ should obviously be added under public/
3335 * api/json-header.php: Removed.
3336 * api/runs.php: Removed.
3337 * public/api: Copied from api.
3339 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
3341 SafariPerfMonitor: Linkify revisions and revisions range
3342 <rdar://problem/12801010>
3344 Reviewed by Mark Rowe.
3346 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
3347 since it needs to know "url" and "blameUrl".
3349 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
3351 * public/index.html:
3352 * public/js/helper-classes.js:
3354 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
3355 (TestBuild.label): Add labels for all revisions.
3359 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
3361 Make the generation of "runs" JSON dynamic and support test_metrics.
3363 Reviewed by Mark Rowe.
3365 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
3367 Since there could be hundreds, if not thousands, of tests for each configuration and users
3368 aren't necessarily interested in looking at all test results, it's much more efficient to
3369 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
3370 when bots report new results (i.e. pushing).
3372 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
3375 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
3376 (exit_with_error): Added.
3377 (successful_exit): Added.
3378 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
3379 * database/generate-runs.js: Removed.
3380 * database/process-jobs.js: No longer supports "runs".
3381 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
3382 * public/db.php: Print "Nothing to see here." when it's accessed directly.
3384 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
3386 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
3388 Update tests.php and sample-data.sql per addition of test_metrics.
3390 Rubber-stamped by Timothy Hatcher.
3392 Remove a useless code from tests.php that used to update the unit and the url of a test
3393 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
3395 Also update the sample data to reflect the addition of test_metrics.
3397 * database/sample-data.sql:
3398 * public/admin/tests.php:
3400 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
3402 Share more code between admin pages.
3404 Reviewed by Timothy Hatcher.
3406 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
3407 between admin pages.
3409 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
3410 to check the nullity of global $db now.
3412 * public/admin/aggregators.php:
3413 * public/admin/header.php:
3415 (execute_query_and_expect_one_row_to_be_affected): Added.
3416 * public/admin/index.php:
3417 * public/admin/jobs.php:
3418 * public/admin/tests.php:
3420 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
3422 SafariPerfMonitor: Add admin page to edit aggregators
3423 <rdar://problem/12782687>
3425 Reviewed by Mark Rowe.
3427 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
3429 * public/admin/aggregators.php: Added.
3430 * public/admin/header.php:
3431 * public/admin/jobs.php: Removed an erroneous hidden input element.
3433 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
3435 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
3437 * database/init-database.sql:
3439 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
3441 SafariPerfMonitor: Allow multiple metrics per test
3442 <rdar://problem/12773506>
3444 Rubber-stamped by Mark Rowe.
3446 Introduce a new table test_metrics. This table represents metrics each test can have
3447 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
3450 Updated admin/tests.php and index.html accordingly.
3452 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
3454 * database/generate-manifest.js:
3455 (buildPlatformMapIfPossible):
3456 * database/generate-runs.js:
3458 * database/init-database.sql:
3459 * database/schema.graffle:
3460 * public/admin/admin.css:
3463 * public/admin/tests.php:
3464 * public/index.html:
3466 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
3468 SafariPerfMonitor: Improve the webkit-perf migration tool
3469 <rdar://problem/12760882>
3471 Reviewed by Mark Rowe.
3473 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
3474 and we don't want to pause the whole importation process until the user comes back to decide whether
3477 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
3478 down to make modifications.
3480 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
3481 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
3483 * database/init-database.sql:
3484 * database/perf-webkit-migrator.js:
3485 (migrateTestConfig):
3486 * database/schema.graffle:
3487 * public/admin/admin.css:
3489 * public/admin/tests.php:
3491 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
3493 Create a new performance dashboard
3494 <rdar://problem/12625582>
3496 Rubber-stamped by Mark Rowe.
3498 Add the initial implementation of the perf dashboard.
3501 * database/config.json: Added.
3502 * database/database-common.js: Added.
3507 (pathToLocalScript):
3509 * database/generate-manifest.js: Added.
3512 (buildPlatformMapIfPossible):
3513 (generateFileIfPossible):
3514 * database/perf-webkit-migrator.js: Added.
3515 * database/process-jobs.js: Added.
3516 * database/sample-data.sql: Added.
3517 * database/schema.graffle: Added.
3519 * public/admin: Added.
3520 * public/admin/README: Added.
3521 * public/admin/admin.css: Added.
3522 * public/admin/footer.php: Added.
3523 * public/admin/header.php: Added.
3524 * public/admin/index.php: Added.
3525 * public/admin/jobs.php: Added.
3526 * public/admin/tests.php: Added.
3527 * public/common.css: Added.
3528 * public/data: Added.
3529 * public/db.php: Added.
3530 * public/index.html: Added.
3532 * public/js/helper-classes.js: Added.
3533 * public/js/jquery-1.8.2.min.js: Added.
3534 * public/js/jquery.flot.min.js: Added.
3535 * public/js/jquery.flot.plugins.js: Added.
3536 * public/js/shared.js: Added.
3537 (fileNameFromPlatformAndTest):
3538 * public/js/statistics.js: Added.
git://git.webkit.org / WebKit-https.git / blob