1 2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
3 Add a page that cycles through v2 dashboards
4 https://bugs.webkit.org/show_bug.cgi?id=149907
6 Reviewed by Chris Dumez.
8 Add cycler.html that goes through each dashboard on v2 UI.
10 This allows the dashboards to be cycled through on a TV screen.
12 * public/cycler.html: Added.
13 (loadURLAt): Appends a new iframe to load the next URL (i is the index of the dashboard to be shown)
14 at the end of body. We don't immediately show the new iframe since it might take a while to load.
15 (showNewFrameIfLoaded): Remove the current iframe and show the next iframe if the next dashboard has
16 finished loading. We can't rely on DOMContentLoaded or load events because we use asynchronous XHR to
17 load each chart's data. Instead, wait until some chart becomes available or fails to load and none of
18 charts are still in progress to be shown.
20 2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
22 Allow custom revisions to be specified in A/B testing
23 https://bugs.webkit.org/show_bug.cgi?id=149905
25 Reviewed by Chris Dumez.
27 Allow custom revision number on each "repository" when creating a test group.
30 (form .analysis-group [name=customValue]): Added.
33 (App.AnalysisTaskController._createConfiguration): Added "Custom" as a revision option.
34 Also added point labels such as (point 3) on "None" for when some points are missing revision info.
35 (App.AnalysisTaskController._labelForPoints): Extracted from _createConfiguration.
36 (App.AnalysisTaskController.actions.createTestGroup): Respect the custom revision number when custom
37 revision option is selected.
39 * public/v2/index.html: Added a text field for specifying a custom revision number.
41 2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
43 Make the site name configurable in perf dashboard
44 https://bugs.webkit.org/show_bug.cgi?id=149894
46 Reviewed by Chris Dumez.
48 Added "siteTitle" as a new configuration key to specify the site name.
50 * public/include/db.php:
51 (config): Now takes the default value as an argument.
52 * public/include/manifest.php:
53 (ManifestGenerator::generate): Include siteTitle in the manifest.
54 * public/index.html: Update the title and the heading when the manifest is loaded.
55 * public/v2/index.html: Use App.Manifest.siteTitle as the heading. document.title needs to be updated manually.
56 * public/v2/manifest.js:
57 (App.MetricSerializer.normalizePayload): Update document.title and App.Manifest.siteTitle.
59 2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
61 Perf dashboard doesn't show analysis tasks anchored at outliers
62 https://bugs.webkit.org/show_bug.cgi?id=149870
64 Reviewed by Chris Dumez.
66 The bug was caused by the computation of start and end times of analysis tasks being dependent on
67 time series provided to the interactive chart component even though they are already filtered.
69 Since the interactive chart component shouldn't be messing with the underlying data models, moved
70 the code to compute start and end times to App.Pane, to where it belongs, and made the moved code use
71 the unfiltered time series newly exposed on ChartData.
73 Also fixed a bug in fetch-from-remote.php which resulted in Ember endlessly fetching same JSON files.
75 * public/admin/fetch-from-remote.php:
76 (.): Use the full request URI for HTTP requests and caching. Otherwise, we're going to mix up caches
77 and Ember can start hanging browsers (took me three hours to debug this).
80 (App.Pane._showOutlierChanged): Added. Resets chartData when showOutlier flag has been changed.
81 (App.Pane.fetchAnalyticRanges): The old code wasn't filtering analysis tasks by platforms and metrics
82 at all since it relied on the server-side REST API to do the filtering, which I haven't implemented yet.
83 Filter the results manually instead.
84 (App.Pane.ranges): Moved the logic to compute startTime and endTime here from InteractiveChartComponent.
85 (App.PaneController.toggleShowOutlier): Now that App.Pane responds to showOutlier changes, we don't
86 need to call a private method on it.
87 (App.AnalysisTaskController._chartDataChanged): When end points are not found, try showing outliers.
88 This will cause chartData to be modified so just exit early and wait for getting called again.
90 * public/v2/interactive-chart.js:
91 (App.InteractiveChartComponent._rangesChanged): The code to compute start and end time has been moved
94 * public/v2/manifest.js:
95 (App.Manifest._formatFetchedData): Added unfiltered time series as new properties as they are now used
96 to compute the end points of analysis tasks when their end points are outliers.
98 2015-10-07 Ryosuke Niwa <rniwa@webkit.org>
100 Unreviewed. Fix a typo in r190645.
102 * public/include/db.php:
104 2015-10-06 Ryosuke Niwa <rniwa@webkit.org>
106 V2 UI shouldn't sort dashboards lexicologically
107 https://bugs.webkit.org/show_bug.cgi?id=149856
109 Reviewed by Chris Dumez.
111 Don't sort the dashboards by name in App.Manifest.
114 (App.IndexRoute.beforeModel): Don't transition to "undefined" (string) dashboard.
115 * public/v2/manifest.js:
116 (App.Manifest.._fetchedManifest):
118 2015-10-06 Ryosuke Niwa <rniwa@webkit.org>
120 V2 UI fails to show the data for the very first point in charts
121 https://bugs.webkit.org/show_bug.cgi?id=149857
123 Reviewed by Chris Dumez.
125 The bug was caused by seriesBetweenPoints returning null for when point.seriesIndex is 0.
126 Explicitly check the type of this property instead.
129 (TimeSeries.prototype.seriesBetweenPoints):
131 2015-10-06 Ryosuke Niwa <rniwa@webkit.org>
133 Perf dashboard should have the capability to test local UI with production data
134 https://bugs.webkit.org/show_bug.cgi?id=149834
136 Reviewed by Chris Dumez.
138 Added tools/run-with-remote-server.py which runs a local httpd server and pulls data from a remote server.
140 * Install.md: Added the instruction on how to use the script. Also updated the remaining instructions
142 * config.json: Added remote server configurations.
143 * public/admin/fetch-from-remote.php: Added. This script fetches JSON from the remote server specified in
144 config.json and caches the results in the location specified as "cacheDirectory" in config.json.
147 * public/include/db.php:
148 (config_path): Extracted from generate_data_file.
149 (generate_data_file):
150 * tools/remote-server-relay.conf: Added. Apache 2.4 configuration file for a local http server launched by
151 run-with-remote-server.py.
152 * tools/run-with-remote-server.py: Added. Launches Apache with the right set of directives.
156 2015-07-13 Ryosuke Niwa <rniwa@webkit.org>
160 * public/js/helper-classes.js:
162 2015-06-27 Ryosuke Niwa <rniwa@webkit.org>
164 build-requests should use conform to JSON API format
165 https://bugs.webkit.org/show_bug.cgi?id=146375
167 Reviewed by Stephanie Lewis.
169 Instead of returning single dictionary that maps root set id to a dictionary of repository names
170 to revisions, timestamps, simply return root sets and roots "rows" or "objects" as defined in
171 JSON API (http://jsonapi.org/). This API change makes it easier to resolve the bug 146374 and
172 matches what we do in /api/test-groups.
174 Also add the support for /api/build-requests/?id=<id> to fetch the build request with <id>.
175 This is useful for debugging purposes.
177 * public/api/build-requests.php:
178 (main): Added the support for $_GET['id']. Also return "rootSets" and "roots".
179 (update_builds): Extracted from main.
181 * public/include/build-requests-fetcher.php:
182 (BuildRequestFetcher::fetch_request): Added. Used for /api/build-requests/?id=<id>.
183 (BuildRequestFetcher::results_internal): Always call fetch_roots_for_set_if_needed.
184 (BuildRequestFetcher::fetch_roots_for_set_if_needed): Renamed from fetch_roots_for_set.
185 Moved the logic to exit early when the root set had already been fetched here.
187 * public/v2/analysis.js:
188 (App.TestGroup._fetchTestResults): Fixed the bug that test groups without any successful results
191 * tools/pull-os-versions.py:
193 (setup_auth): Moved to util.py
195 * tools/sync-with-buildbot.py:
196 (main): Replaced a bunch of perf dashboard related options by --server-config-json.
197 (update_and_fetch_build_requests): No longer takes build_request_auth since that's now taken care
199 (organize_root_sets_by_id_and_repository_names): Added. Builds the old rootsSets directory based
200 on "roots" and "rootSets" dictionaries returned by /api/build-requests.
201 (config_for_request): Fixed a bug that the script blows up when the build request is missing
202 the repository specified in the configuration. This tolerance is necessary when a new repository
203 dependency is added but we want to run A/B tests for old builds without the dependency.
204 (fetch_json): No longer takes auth.
207 (setup_auth): Moved from pull-os-versions.py to be shared with sync-with-buildbot.py.
209 2015-06-23 Ryosuke Niwa <rniwa@webkit.org>
211 Build fix. A/B testing is broken when continuous builders report revisions out of order.
214 (App.AnalysisTaskController.Ember.Controller.extend.):
216 2015-06-22 Ryosuke Niwa <rniwa@webkit.org>
218 A/B testing results should be shown even if they were submitted to different platforms
219 https://bugs.webkit.org/show_bug.cgi?id=146219
221 Reviewed by Andreas Kling.
223 Fetch A/B testing results regardless of the platform to which results are submitted
224 by providing the platform ID to which the results were submitted for each test group.
226 * public/api/test-groups.php:
227 (main): Include the platform id in the test groups.
228 * public/v2/analysis.js:
229 (App.TestGroup._fetchTestResults): Fetch results from the platform associated with the group.
231 2015-06-19 Csaba Osztrogonác <ossy@webkit.org>
233 Remove unnecessary svn:executable flags
234 https://bugs.webkit.org/show_bug.cgi?id=146107
236 Reviewed by Alexey Proskuryakov.
238 * public/js/helper-classes.js: Removed property svn:executable.
239 * public/js/jquery.flot.plugins.js: Removed property svn:executable.
240 * public/v2/app.css: Removed property svn:executable.
241 * public/v2/app.js: Removed property svn:executable.
242 * public/v2/chart-pane.css: Removed property svn:executable.
243 * public/v2/data.js: Removed property svn:executable.
244 * public/v2/index.html: Removed property svn:executable.
245 * public/v2/js/d3/LICENSE: Removed property svn:executable.
246 * public/v2/js/d3/d3.js: Removed property svn:executable.
247 * public/v2/js/d3/d3.min.js: Removed property svn:executable.
248 * public/v2/js/ember-data.js: Removed property svn:executable.
249 * public/v2/js/ember.js: Removed property svn:executable.
250 * public/v2/js/handlebars.js: Removed property svn:executable.
251 * public/v2/js/jquery.min.js: Removed property svn:executable.
252 * public/v2/js/statistics.js: Removed property svn:executable.
253 * public/v2/manifest.js: Removed property svn:executable.
254 * public/v2/popup.js: Removed property svn:executable.
256 2015-06-17 Ryosuke Niwa <rniwa@webkit.org>
258 Reading the list of analysis tasks is extremely slow
259 https://bugs.webkit.org/show_bug.cgi?id=146086
261 Reviewed by Darin Adler.
263 The bug was caused by Ember data requesting manifest.js hundreds of times.
264 Fetch it ahead of time in each route instead.
267 (App.AnalysisRoute.model):
268 (App.AnalysisTaskRoute.model):
270 2015-06-17 Ryosuke Niwa <rniwa@webkit.org>
272 Update ReadMe.md and Install.md per database changes
273 https://bugs.webkit.org/show_bug.cgi?id=146076
275 Reviewed by Darin Adler.
282 2015-06-17 Ryosuke Niwa <rniwa@webkit.org>
284 Increase the popup dismissal time from 100ms to 500ms
285 https://bugs.webkit.org/show_bug.cgi?id=146077
287 Rubber-stamped by Andreas Kling.
289 * public/v2/popup.js:
290 (App.PopupView.scheduleHiding):
292 2015-06-16 Ryosuke Niwa <rniwa@webkit.org>
294 v2 UI should have buttons to breakdown a test
295 https://bugs.webkit.org/show_bug.cgi?id=146010
297 Reviewed by Chris Dumez.
299 Added buttons beneath each chart pane to add "alternative panes". By default, it shows every platform
300 as well as "Breakdown" to add all subtests' metrics.
302 Also removed the metric submenu from tests that had exactly one metric. When a test only measures Time
303 for example, we make the test itself clickable instead of showing a submenu that only contains one item.
306 (App.ChartsController.addAlternativePanes): Added.
307 (App.TestProxyForPopup.children): Calls _updateChildren and returns this._children.
308 (App.TestProxyForPopup.actionName): Added.
309 (App.TestProxyForPopup.actionArgument): Added.
310 (App.TestProxyForPopup._updateChildren): Extracted from children. Now also sets _actionName and
311 _actionArgument in the case there was exactly one metric so that showing submenu is unnecessary.
312 (App.PaneController.alternativePanes): Added. Returns the list of alternative panes. The platform list
313 excludes ones that don't have this metric (e.g. iOS doesn't have desktop PLT results) as well as ones
314 that are already present in the list of panes.
315 * public/v2/chart-pane.css: Added CSS rules for alternative pane buttons beneath the chart panes.
316 * public/v2/index.html:
317 * public/v2/manifest.js:
318 (App.Metric.childMetrics): Added.
320 2015-06-15 Ryosuke Niwa <rniwa@webkit.org>
322 Build fix after r185574.
325 (set get App.Pane.Ember.Object.extend.):
327 2015-06-15 Ryosuke Niwa <rniwa@webkit.org>
331 * tools/pull-os-versions.py:
334 2015-06-15 Ryosuke Niwa <rniwa@webkit.org>
336 Perf dashboard should be able to list iOS versions as well as OS X versions
337 https://bugs.webkit.org/show_bug.cgi?id=146003
339 Reviewed by Stephanie Lewis.
341 Generalized pull-osx.py so that it can run an arbitrary shell command to fetch OS versions based on
342 information specified in config.json.
344 * tools/pull-os-versions.py: Renamed from pull-osx.py.
345 (main): Use available_builds_from_command when 'customCommands' is specified.
346 (available_builds_from_command): Added. Executes a shell command to fetch a list of available builds.
347 (fetch_available_builds): Now takes the repository name.
349 2015-06-15 Ryosuke Niwa <rniwa@webkit.org>
351 Removed a superfluous console.log per Chris's comment.
355 2015-06-15 Ryosuke Niwa <rniwa@webkit.org>
357 Analysis task should show all possible revisions for A/B testing
358 https://bugs.webkit.org/show_bug.cgi?id=145996
360 Reviewed by Chris Dumez.
362 * public/api/commits.php:
363 (fetch_commits_between): When the time stamp is not available for commits, use revision numbers
364 to find revisions between two ranges. This is necessary for OS X and iOS versions since they don't
365 have a "commit time".
368 (App.AnalysisTaskController.updateRootConfigurations): Fetch commits between two end points.
369 (App.AnalysisTaskController._createConfiguration): Extracted from updateRootConfigurations. List
370 the fetched list of commits if available.
371 (App.AnalysisTaskController._serializeNumbersSkippingConsecutiveEntries): Added. Serializes an list
372 of numbers intelligently. For example, [1, 2, 4, 5] turns into "1-2, 4-5". Without this, some lists
373 of points shown in the A/B testing configurations become too long.
375 * public/v2/commits-viewer.js:
376 (App.CommitsViewerComponent.commitsChanged):
379 (CommitLogs.fetchCommits): Renamed from fetchForTimeRange.
381 2015-06-13 Ryosuke Niwa <rniwa@webkit.org>
383 Add a script to post new OS X builds to perf dashboard
384 https://bugs.webkit.org/show_bug.cgi?id=145955
386 Reviewed by Darin Adler.
388 Added a new script pull-osx.py and relaxed the restrictions on commits accepted by the dashboard API.
390 * public/api/report-commits.php:
391 (main): Allow more characters than [A-Za-z0-9] in revision. e.g. "10.10.3 14D136".
392 Also allow commits without the author, commit time, and commit message as OS versions do not have those.
394 * tools/pull-osx.py: Added.
395 (main): Fetch the list of builds from a website and submit them per submissionSize with submissionInterval.
396 Once all builds have been submitted, wait for a long time as specified by fetchInterval.
397 (setup_auth): Sets up basic or digest auth to access the dashboard.
398 (fetch_available_builds): Fetches and parses the XML document from an internal website.
399 (textContent): A helper function to get the text content out of a XML node.
400 (submit_commits): Submits commits to the perf dashboard.
405 * tools/util.py: Extracted submit_commits and text_content from pull-svn.py to be reused in pull-osx.py.
407 2015-06-13 Ryosuke Niwa <rniwa@webkit.org>
409 Perf dashboard's v2 UI shouldn't hide auto-detected outliers
410 https://bugs.webkit.org/show_bug.cgi?id=145940
412 Reviewed by Darin Adler.
414 Don't fallback to the default strategies for moving averages and envelope when one is not specified.
415 Also deleted the code to mark points outside the envelop as outliers.
419 2015-06-12 Ryosuke Niwa <rniwa@webkit.org>
421 Unreviewed build fix for merging platforms.
423 * public/admin/platforms.php:
425 2015-06-09 Ryosuke Niwa <rniwa@webkit.org>
427 Unreviewed build fix. Some builder names are really long.
431 2015-05-22 Ryosuke Niwa <rniwa@webkit.org>
433 Show results and status before revisions for A/B testing results
434 https://bugs.webkit.org/show_bug.cgi?id=145327
436 Reviewed by Chris Dumez.
438 Place the results and the status columns before the columns for revisions.
439 Also show the absolute difference as well as the relative difference between the averages of A and B.
442 (App.TestGroupPane._populate):
443 (App.TestGroupPane._computeStatisticalSignificance):
444 * public/v2/index.html:
446 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
448 Build fix after r184591.
450 * public/v2/manifest.js:
452 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
454 Build fix. Use POSIX timestamp instead of human readable string for the commit time.
456 * public/include/build-requests-fetcher.php:
458 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
460 UI to associate bugs with an analysis task is crappy
461 https://bugs.webkit.org/show_bug.cgi?id=145198
463 Reviewed by Andreas Kling.
465 Make the UI less crappy by linkifying bug numbers and adding an explicit button to disassociate
466 a bug and a separate select view with a text field to associate a new bug instead of implicitly
467 updating or deleting the existing record based on what the user had typed.
469 * init-database.sql: Removed the constraint that each bug tracker should appear exactly once for
470 a given analysis task since it's perfectly reasonable for a given task to be associated with
471 multiple WebKit bugs.
473 * public/privileged-api/associate-bug.php:
474 (main): Only remove the bug specified by newly added bugToDelete instead of implicitly deleting
475 one that matches the analysis task and the bug tracker when the bug number is falsey.
477 * public/v2/analysis.js:
478 (App.Bug.url): Added.
479 (App.BugAdapter.deleteRecord): Added. Uses the privileged API to delete the record.
484 (App.AnalysisTaskController.actions.addBug): Added.
485 (App.AnalysisTaskController.actions.deleteBug): Added.
486 (App.AnalysisTaskController.associateBug): Deleted.
488 * public/v2/index.html: Updated the templates.
490 * public/v2/manifest.js:
491 (App.BugTracker.urlFromBugNumber): Added.
493 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
495 A/B testing rootSets should provide commit times as well as revisions
496 https://bugs.webkit.org/show_bug.cgi?id=145207
498 Reviewed by Andreas Kling.
500 Some continuous build systems need the commit time as well as the revision number / hash so provide one
501 in the root sets but maintain the backwards compatibility with buildbots that use revision number directly.
503 * public/include/build-requests-fetcher.php:
504 (BuildRequestsFetcher::fetch_roots_for_set): Made the revision info an associative array that contains
505 the revision number as well as the commit time.
506 * tools/sync-with-buildbot.py:
507 (schedule_request): Removed "replacement" which was a superfluous copy of "roots". Use "revision" values
508 when the JSON configuration refers to "root". This is necessary in buildbot instances that require WebKit
509 revision to be specified on its own field instead of it being a JSON that contains "revision" and "time".
511 2015-05-19 Ryosuke Niwa <rniwa@webkit.org>
513 Build fix. Don't fall into an infinite loop when value (renamed from bytes) is zero.
515 * public/v2/manifest.js:
516 (App.Manifest.Ember.Controller.extend.):
517 (App.Manifest.Ember.Controller.extend):
519 2015-05-19 Ryosuke Niwa <rniwa@webkit.org>
521 Don't show unit (bytes) separaetly from SI suffixes (K, M, etc...)
522 https://bugs.webkit.org/show_bug.cgi?id=145181
524 Rubber-stamped by Chris Dumez.
526 Show 'MB' in each y-axis label instead of showing 'bytes' separately and suffixing each label with just 'M'
527 for clarity. This change also reduces the code complexity.
531 (App.AnalysisTaskController._chartDataChanged):
532 (App.TestGroupPane._createConfigurationSummary):
534 (RunsData.unitFromMetricName): Use 'B' instead of 'bytes' as the unit.
536 * public/v2/interactive-chart.js: Removed the support for showing units separately.
537 (App.InteractiveChartComponent._constructGraphIfPossible):
538 (App.InteractiveChartComponent._relayoutDataAndAxes)
540 * public/v2/manifest.js:
541 (App.Manifest._makeFormatter): Renamed from _formatBytes. Support more SI suffixes such as micro and mili.
542 Now takes the unit as the first argument. Adjust the base unit if it's 'ms'.
543 (App.Manifest._formatFetchedData): Removed unit and formatWithUnit now that all all formatters would
544 automatically include unit.
546 2015-05-18 Ryosuke Niwa <rniwa@webkit.org>
548 REGRESSION: v2 UI reports a higher memory usage
549 https://bugs.webkit.org/show_bug.cgi?id=145151
551 Reviewed by Chris Dumez.
553 The bug was caused by v2 UI using 1000 to divide the number of bytes instead of by 1024 as done in v1.
554 Fixed the bug by manually implementing the formatter as done in v1.
556 * public/v2/manifest.js:
557 (App.Manfiest._formatBytes): Added.
558 (App.Manifest._formatFetchedData): Use _formatByte instead of format('s').
560 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
562 Unreviewed build fix. Add "Duration" as a time metric.
564 * public/js/helper-classes.js:
566 (RunsData.unitFromMetricName):
568 2015-05-06 Ryosuke Niwa <rniwa@webkit.org>
570 Perf dashboard treats Speedometer and JetStream as smaller is better
571 https://bugs.webkit.org/show_bug.cgi?id=144711
573 Reviewed by Chris Dumez.
575 Added the support for "Score" metric.
577 * public/js/helper-classes.js:
580 (RunsData.unitFromMetricName):
581 (RunsData.isSmallerBetter):
583 2015-04-23 Ryosuke Niwa <rniwa@webkit.org>
585 Build fix after r183232.
587 * public/include/json-header.php:
589 2015-04-23 Ryosuke Niwa <rniwa@webkit.org>
591 Perf dashboard should automatically detect regressions
592 https://bugs.webkit.org/show_bug.cgi?id=141443
594 Reviewed by Anders Carlsson.
596 Added a node.js script detect-changes.js to detect potential regressions and progressions
597 on the graphs tracked on v2 dashboards.
599 * init-database.sql: Added analysis_strategies table and task_segmentation and task_test_range
600 columns to analysis_tasks to keep the segmentation and test range selection strategies used
601 to create an analysis task.
603 * public/api/analysis-tasks.php:
604 (format_task): Include task_segmentation and analysis_tasks in the results.
606 * public/include/json-header.php:
607 (remote_user_name): Returns null when the privileged API is authenticated as a slave instead
608 of a CSRF prevention token.
609 (should_authenticate_as_slave): Added.
610 (ensure_privileged_api_data_and_token_or_slave): Added. Authenticate as a slave if slaveName
611 and slavePassword are specified. Since detect-changes.js and other slaves are not susceptible
612 to a CSRF attack, we don't need to check a CSRF token.
614 * public/privileged-api/create-analysis-task.php:
615 (main): Use ensure_privileged_api_data_and_token_or_slave to let detect-changes.js create new
616 analysis task. Also add or find segmentation and test range selection strategies if specified.
618 * public/privileged-api/create-test-group.php:
619 (main): Use ensure_privileged_api_data_and_token_or_slave.
621 * public/privileged-api/generate-csrf-token.php:
624 (App.Pane._computeMovingAverageAndOutliers): _executeStrategy has been moved to Statistics.
626 * public/v2/data.js: Export Measurement, RunsData, TimeSeries. Used in detect-changes.js.
627 (Array.prototype.find): Added a polyfill to be used in node.js.
628 (RunsData.fetchRuns):
629 (RunsData.pathForFetchingRuns): Extracted from fetchRuns. Used in detect-changes.js.
630 (RunsData.createRunsDataInResponse): Extracted from App.Manifest._formatFetchedData to use it
631 in detect-changes.js.
632 (RunsData.unitFromMetricName): Ditto.
633 (RunsData.isSmallerBetter): Ditto.
634 (RunsData.prototype._timeSeriesByTimeInternal): Added secondaryTime to sort points when commit
636 (TimeSeries): When commit times are identical, order points based on build time. This is needed
637 for when we trigger two builds at two different OS versions with the same WebKit revision since
638 OS versions don't change the commit times.
639 (TimeSeries.prototype.findPointByIndex): Added.
640 (TimeSeries.prototype.rawValues): Added.
642 * public/v2/js/statistics.js:
643 (Statistics.TestRangeSelectionStrategies.[0]): Use the 99% two-sided probability as claimed in the
644 description of this strategy instead of the default probability. Also fixed a bug that debugging
645 code was referring to non-existent variables.
646 (Statistics.executeStrategy): Moved from App.Pane (app.js).
648 * public/v2/manifest.js:
649 (App.Manifest._formatFetchedData): Various code has been extracted into RunsData in data.js to be
650 used in detect-changes.js.
652 * tools/detect-changes.js: Added. The script fetches the manifest JSON, analyzes each graph in
653 the v2 dashboards, and creates an analysis task for the latest regression or progression detected.
654 It also schedules an A/B testing if possible and notifies another server; e.g. to send an email.
655 (main): Loads the settings JSON specified in the argument.
656 (fetchManifestAndAnalyzeData): The main loop that periodically wakes up to do the analysis.
657 (mapInOrder): Executes callback sequentially (i.e. blocking) on each item in the array.
658 (configurationsForTesting): Finds every (platform, metric) pair to analyze in the v2 dashbaords,
659 and computes various values for when statistically significant changes are detected later.
660 (analyzeConfiguration): Finds potential regressions and progression in the last X days where X
661 is the specified maximum number of days using the specified strategies. Sort the resultant ranges
662 in chronological order and create a new analysis task for the very last change we detected. We'll
663 eventually create an analysis task for all detected changes since we're repeating the analysis in
664 fetchManifestAndAnalyzeData after some time.
665 (computeRangesForTesting): Fetch measured values and compute ranges to test using the specified
666 segmentation and test range selection strategies. Once ranges are found, find overlapping analysis
667 tasks as they need to be filtered out in analyzeConfiguration to avoid creating multiple analysis
668 tasks for the same range (e.g. humans may create one before the script gets to do it).
669 (createAnalysisTaskAndNotify): Create a new analysis task for the specified range, trigger an A/B
670 testing if available, and notify another server with a HTML message as specified.
671 (findStrategyByLabel):
672 (changeTypeForRange): A change is a regression if values are getting larger in a smaller-is-better
673 test or values are getting smaller in a larger-is-better test and vice versa.
674 (summarizeRange): Create a human readable string that summarizes the change detected. e.g.
675 "Potential 3.2% regression detected between 2015-04-20 12:00 and 17:00".
679 (postNotification): Recursively replaces $title and $massage in the specified JSON template.
680 (instantiateNotificationTemplate):
683 2015-04-20 Ryosuke Niwa <rniwa@webkit.org>
685 Perf dashboard should have UI to set status on analysis tasks
686 https://bugs.webkit.org/show_bug.cgi?id=143977
688 Reviewed by Chris Dumez.
690 Added the UI to set the result of an analysis task to 'progression', 'regression', 'unchanged', and 'inconclusive'
691 as well as a boolean indicating whether creating the analysis task was the right thing to do or not.
692 The latter will be a useful metric once we start automatically creating analysis tasks.
694 * init-database.sql: Added two columns to analysis_tasks table.
695 * public/api/analysis-tasks.php: Include the added columns in the JSON.
696 * public/include/db.php:
697 (Database::to_database_boolean): Added.
698 * public/include/json-header.php:
699 (require_match_one_of_values): Added.
700 * public/privileged-api/update-analysis-task.php: Added. Updates 'result' and 'needed' values of an analysis task.
702 * public/v2/analysis.js:
703 (App.AnalysisTask.result): Added.
704 (App.AnalysisTask.needed): Added. We don't use DS.attr('boolean') here since that would coerce null into false
705 and we want to differentiate null from false in order to differentiate the null-ness of the value.
706 (App.AnalysisTask.saveStatus): Added.
707 (App.AnalysisTask.statusLabel): Use 'result' as the label if it's set and all build requests have been processed.
710 (App.AnalysisTaskController.analysisResultOptions): Added.
711 (App.AnalysisTaskController.shouldNotHaveBeenCreated): Added.
712 (App.AnalysisTaskController.needsFeedback): Added. Show the checkbox to indicate the analysis task should not have
713 been created if 'no change' is selected.
714 (App.AnalysisTaskController._updateChosenAnalysisResult): Added.
715 (App.AnalysisTaskController.actions.saveStatus): Added.
716 * public/v2/index.html: Extracted a partial template for updating the bug numbers. Also added the UI to update
717 'result' and 'needed' values of the analysis task.
719 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
721 Unreviewed build fix. Updated config.json after recent changes.
725 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
727 Make the analysis page more useful
728 https://bugs.webkit.org/show_bug.cgi?id=143617
730 Reviewed by Chris Dumez.
732 * public/api/analysis-tasks.php:
733 (fetch_and_push_bugs_to_tasks): Added total and finished numbers of build requests associated
734 with the fetched analysis tasks as buildRequestCount and finishedBuildRequestCount respectively.
735 * public/v2/analysis.js:
736 (App.AnalysisTask.formattedCreatedAt): Added.
737 (App.AnalysisTask._addLeadingZero): Added.
738 (App.AnalysisTask.buildRequestCount): Added.
739 (App.AnalysisTask.finishedBuildRequestCount): Added.
740 (App.AnalysisTask.statusLabel): Added. Status total and finished numbers of build requests.
741 (App.AnalysisTask.testGroups):
742 (App.AnalysisTask.triggerable):
743 (App.AnalysisTask.label):
745 * public/v2/app.css: Tweaked style rules for the analysis page.
748 (App.buildPopup): Sort the list of platforms by name.
749 (App.AnalysisRoute.model): Sort the list of analysis tasks by the order they are created.
750 (App.AnalysisTaskController._fetchedManifest): Added elementId to associate bug tracker names
751 such as "Bugzilla" with the corresponding text field.
753 * public/v2/index.html: Added a bunch of columns to the analysis page and also wrapped the table
754 showing A/B testing results in a div with overflow: scroll so that it always leaves enough space
755 for the accompanying graph.
757 2015-04-09 Ryosuke Niwa <rniwa@webkit.org>
759 Perf dashboard should automatically select ranges for A/B testing
760 https://bugs.webkit.org/show_bug.cgi?id=143580
762 Reviewed by Chris Dumez.
764 Added a new statistics option for picking a A/B test range selection strategy.
765 The selected ranges are shown in the graph using the same UI to show analysis tasks.
768 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Updated the query parameters for
769 charts page used by the dashboard since we've added a new parameter at the end.
770 (App.Pane.ranges): Added. Merges ranges created for analysis tasks and A/B testing.
771 (App.Pane.updateStatisticsTools): Clone and set the test range selection strategies.
772 (App.Pane._cloneStrategy): Copy isSegmentation.
773 (App.Pane._updateMovingAverageAndEnvelope): Set testRangeCandidates.
774 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Update the charts when a new text range
775 selection strategy is picked by the user.
776 (App.Pane._computeMovingAverageAndOutliers): Compute the test ranges using the chosen strategy.
777 Avoid going through isAnomalyArray when no anomaly detection strategy is enabled. Also changed
778 the return value from the moving average time series to a dictionary that contains the moving
779 average time series, a dictionary of anomalies, and an array of test ranges.
780 (App.ChartsController._parsePaneList): Parse the test range selection strategy configuration.
781 (App.ChartsController._serializePaneList): Ditto for serialization.
782 (App.ChartsController._scheduleQueryStringUpdate): Update the URL hash when the user picks a new
783 test range selection strategy.
785 * public/v2/chart-pane.css: Fixed a typo as well as added a CSS rule for test ranges markers.
787 * public/v2/index.html: Added UI for selecting a test range selection strategy.
789 * public/v2/interactive-chart.js:
790 (App.InteractiveChartComponent._rangesChanged): Pass down "status" to be used as a class name.
792 * public/v2/js/statistics.js:
793 (Statistics.MovingAverageStrategies): Added isSegmentation to segmentation strategies.
794 (Statistics.TestRangeSelectionStrategies): Added.
796 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
798 The results of A/B testing should state statistical significance
799 https://bugs.webkit.org/show_bug.cgi?id=143552
801 Reviewed by Chris Dumez.
803 Added statistical comparisons between results for each configuration on analysis task page using
804 Welch's t-test. The probability as well as t-statistics and the degrees of freedoms are reported.
807 (App.TestGroupPane._populate): Report the list of statistical comparison between every pair of
808 root configurations in the results. e.g. if we've got A, B, C configurations then compare A/B, A/C
810 (App.TestGroupPane._computeStatisticalSignificance): Compute the statistical significance using
811 Welch's t-test. Report the probability by which two samples do not come from the same distribution.
812 (App.TestGroupPane._createConfigurationSummary): Include the array of results for this configuration.
813 Also renamed "items" to "requests" for clarity.
815 * public/v2/index.html: Added the template for showing statistical comparisons.
817 * public/v2/js/statistics.js: Renamed tDistributionQuantiles to tDistributionByOneSidedProbability
818 for clarity. Also factored out the functions to convert from one-sided probability to two-sided
819 probability and vice versa.
820 (Statistics.supportedConfidenceIntervalProbabilities):
821 (Statistics.confidenceIntervalDelta):
822 (Statistics.probabilityRangeForWelchsT): Added. Computes the lower bound and the upper bound for
823 the probability that two values are sampled from distinct distributions using Welch's t-test.
824 (Statistics.computeWelchsT): This function now takes two-sided probability like all other functions.
825 (.tDistributionByOneSidedProbability): Renamed from tDistributionQuantiles.
826 (.oneSidedToTwoSidedProbability): Extracted.
827 (.twoSidedToOneSidedProbability): Extracted.
828 (Statistics.MovingAverageStrategies): Converted the one-sided probability to the two-sided probability
829 now that computeWelchsT takes two-sided probability.
831 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
833 Unreviewed fix after r182496 for when the cached runs JSON doesn't exist.
837 (App.Pane.refetchRuns):
839 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
841 Perf dashboard should have a way of marking outliers
842 https://bugs.webkit.org/show_bug.cgi?id=143466
844 Reviewed by Chris Dumez.
846 Address kling's in-person comment to notify users when the new run status is saved in the database.
849 (App.PaneController._selectedItemIsMarkedOutlierDidChange)
850 * public/v2/chart-pane.css: Fixed a typo.
852 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
854 Perf dashboard should have a way of marking outliers
855 https://bugs.webkit.org/show_bug.cgi?id=143466
857 Reviewed by Chris Dumez.
859 Added UI to mark a data point as an outlier as well as a button to toggle the visibility of outliers.
860 Added a new privileged API /privileged-api/update-run-status to store this boolean flag.
862 * init-database.sql: Added run_marked_outlier column to test_runs table.
864 * public/admin/tests.php:
866 * public/api/runs.php:
867 (main): Only emit Cache-Control and Expires headers in v1 UI.
868 (RunsGenerator::format_run): Emit markedOutlier.
870 * public/include/admin-header.php:
872 * public/include/db.php:
873 (Database::is_true): Made it static.
875 * public/include/manifest.php:
876 (Manifest::platforms):
878 * public/index.html: Call into /api/runs/ with ?cache=true.
880 * public/privileged-api/update-run-status.php: Added.
881 (main): Updates the newly added column in test_runs table.
885 (App.Pane.refetchRuns): Extracted from App.Pane._fetch.
886 (App.Pane._didFetchRuns): Renamed from _updateChartData.
887 (App.Pane._setNewChartData): Added. Pick the right time series based based on the value of showOutlier.
888 Cloning chartData is necessary when toggling the outlier visibility or using statistics tools because
889 the interactive chart component only observes changes to chartData and not individual properties of it.
890 (App.Pane._highlightPointsMarkedAsOutlier): Added. Highlight points marked as outliers.
891 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Call to _setNewChartData replaced the code to
892 clone chartData here.
894 (App.PaneController.actions.toggleShowOutlier): Toggle the visibility of points marked as outliers by
895 invoking App.Pane._setNewChartData.
896 (App.PaneController._detailsChanged): Don't hide the analysis pane when details changed since keep
897 opening the pane for marking points as outliers would be annoying.
898 (App.PaneController._updateCanAnalyze): Update 'cannotMarkOutlier' as well as 'cannotAnalyze'.
899 (App.PaneController.selectedMeasurement): Added.
900 (App.PaneController.showOutlierTitle): Added.
901 (App.PaneController._selectedItemIsMarkedOutlierDidChange): Added. Call out to setMarkedOutlier to
902 mark the selected point as an outlier via the newly added privileged API.
904 * public/v2/chart-pane.css: Updated styles.
907 (PrivilegedAPI._post): Report the semantic errors.
908 (Measurement.prototype.markedOutlier): Added.
909 (Measurement.prototype.setMarkedOutlier): Added. Uses PrivilegedAPI to update the database.
910 (RunsData.prototype.timeSeriesByCommitTime): Added a new argument, includeOutliers, to indicate
911 whether the time series should include measurements marked as outliers or not.
912 (RunsData.prototype.timeSeriesByBuildTime): Ditto.
913 (RunsData.prototype._timeSeriesByTimeInternal): Extracted from timeSeriesByCommitTime and
914 timeSeriesByBuildTime to share code. Now ignores measurements marked as outliers if needed.
916 * public/v2/index.html: Added an icon for showing and hiding outliers. Also added a checkbox to
917 mark individual points as outliers.
919 * public/v2/interactive-chart.js:
920 (App.InteractiveChartComponent._selectClosestPointToMouseAsCurrentItem): Re-enable the distance
921 heuristics that takes vertical closeness into account. This heuristics is more useful when marking
922 some points as outliers. This heuristics was disabled because the behavior was unpredictable but
923 with the arrow key navigation support, this is no longer an issue.
925 * public/v2/manifest.js:
926 (App.Manifest._formatFetchedData): Added showOutlier to the chart data. This function dynamically
927 updates the time series in this chart data in order to include or exclude outliers.
929 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
931 Perf dashboard should be able to trigger A/B testing jobs for iOS
932 https://bugs.webkit.org/show_bug.cgi?id=143398
934 Reviewed by Chris Dumez.
936 Fix various bugs in the perf dashboard so that it can schedule A/B testing jobs for iOS.
938 Also generalized sync-with-buildbot.py slightly to meet the requirements of iOS builders.
940 * public/api/triggerables.php:
941 (main): Avoid spitting a warning when $id_to_triggerable doesn't contain the triggerable.
942 * public/v2/analysis.js:
943 (App.AnalysisTask.triggerable): Log an error when failed to fetch triggerables for debugging purposes.
945 (App.AnalysisTaskController.updateRootConfigurations): Show 'None' when a revision is missing from
946 some of the data points. This will happen when we modify the list of projects we build for iOS.
947 (App.AnalysisTaskController.actions.createTestGroup): Gracefully fail by showing alerts when an user
948 attempts to create an invalid test group; when there is already another test group of the same or when
949 only either configuration specifies the revision for some repository.
950 (App.AnalysisTaskController._updateRootsBySelectedPoints): Fixed a typo: sets[i] -> set.
951 * public/v2/index.html: Don't show the form to create a new test group if it's not available.
952 * tools/sync-with-buildbot.py:
953 (find_request_updates):
954 (schedule_request): iOS builders take a JSON that contains the list of roots. Generate this JSON when
955 a dictionary of the form {rootsExcluding: ["WebKit"]} is specified. Also replaced the way we refer to
956 a revision from $-based text replacements to an explicit dictionary of the form {root: "WebKit"}.
957 (request_id_from_build): Don't hard code the parameter name here. Retrieve the name from the config.
959 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
961 Add time series segmentation algorithms as moving averages
962 https://bugs.webkit.org/show_bug.cgi?id=143362
964 Reviewed by Chris Dumez.
966 This patch implements two preliminary time series segmentation algorithms as moving averages.
968 Recursive t-test: Compute Welch's t-statistic at each point in a given segment of the time series.
969 If Welch's t-test implicates a statistically significance difference, then split the segment into two
970 sub segments with the maximum t-statistic (i.e. the point at which if split would yield the highest
971 probability that two segments do not share the same "underlying" mean in classical / frequentist sense).
972 We repeat this process recursively. See [1] for the evaluation of this particular algorithm.
974 Schwarz criterion: Use Schwarz or Bayesian information criterion to heuristically find the optimal
975 segmentation. Intuitively, the problem of finding the best segmentation comes down to minimizing the
976 residual sum of squares in each segment as in linear regressions. That is, for a given segment with
977 values y_1 through y_n with mean y_avg, we want to minimize the sum of (y_i - y_avg)^2 over i = 1
978 through i = n. However, we also don't want to split every data point into a separate segment so we need
979 to account the "cost" of introducing new segments. We use a cost function that's loosely based on two
980 models discussed in [2] for simplicity. We will tune this cost function further in the future.
982 The problem of finding the best segmentation then reduces to a search problem. Unfortunately, our problem
983 space is exponential with respect to the size of the time series since we could split at each data point.
984 We workaround this problem by first splitting the time series into a manageable smaller grids, and only
985 considering segmentation of a fixed size (i.e. the number of segments is constant). Since time series
986 tend to contain a lot more data points than segments, this strategy finds the optimal solution without
987 exploring much of the problem space.
989 Finding the optimal segmentation of a fixed size is, itself, another search problem that is equivalent to
990 finding the shortest path of a fixed length in DAG. Here, we use dynamic programming with a matrix of size
991 n by n where n is the length of the time series (grid). Each entry in this matrix at (i, k) stores
992 the minimum cost of segmenting data points 1 through i using k segments. We start our search at i = 1.
993 Clearly C(1, 0) = 0 (note the actual code uses 0-based index). In i-th iteration, we compute the cost
994 S(i, j) of each segment starting at i and ending at another point j after i and update C(j, k + 1) by
995 min( C(j, k + 1), C(i, k) + S(i, j) ) for all values of j above i.
997 [1] Kensuke Fukuda, H. Eugene Stanley, and Luis A. Nunes Amaral, "Heuristic segmentation of
998 a nonstationary time series", Physical Review E 69, 021108 (2004)
1000 [2] Marc Lavielle, Gilles Teyssi`ere, "Detection of Multiple Change–Points in Multivariate Time Series"
1001 Lithuanian Mathematical Journal, vol 46, 2006
1003 * public/v2/index.html: Show the optional description for the chosen moving average strategy.
1004 * public/v2/js/statistics.js:
1005 (Statistics.testWelchsT):
1006 (Statistics.computeWelchsT): Extracted from testWelchsT. Generalized to take the offset and the length
1007 of each value array between which Welch's t-statistic is computed. This generalization helps the
1008 Schwarz criterion segmentation algorithm avoid splitting values array O(n^2) times.
1009 (.sampleMeanAndVarianceForValues): Ditto for the generalization.
1010 (.recursivelySplitIntoTwoSegmentsAtMaxTIfSignificantlyDifferent): Added. Implements recursive t-test.
1011 (.splitIntoSegmentsUntilGoodEnough): Added. Implements Schwarz criterion.
1012 (.findOptimalSegmentation): Added. Implements the algorithm to find the optimal segmentation of a fixed
1014 (.SampleVarianceUpperTriangularMatrix): Added. Stores S(i, j) used by findOptimalSegmentation.
1015 (.SampleVarianceUpperTriangularMatrix.prototype.costBetween): Added.
1017 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
1019 REGRESSION: Perf dashboard sometimes fails to update zooming level
1020 https://bugs.webkit.org/show_bug.cgi?id=143359
1022 Reviewed by Darin Adler.
1024 The bug was caused by various bugs that ended up in an exception.
1027 (App.Pane._handleFetchErrors): Removed superfluous console.log.
1028 (App.Pane.computeStatus): Fixed the bug in r182185 that previousPoint could be null.
1029 (App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
1030 * public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
1031 to # when Ember.js fails to attach event listeners on time.
1032 * public/v2/interactive-chart.js:
1033 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
1034 the containing element's size is 0.
1035 (App.InteractiveChartComponent._updateBrush): Ditto.
1037 2015-04-02 Ryosuke Niwa <rniwa@webkit.org>
1039 Perf dashboard should have UI to test out anomaly detection strategies
1040 https://bugs.webkit.org/show_bug.cgi?id=143290
1042 Reviewed by Benjamin Poulain.
1044 Added the UI to select anomaly detection strategies. The detected anomalies are highlighted in the graph.
1046 Implemented the Western Electric Rules 1 through 4 in http://en.wikipedia.org/wiki/Western_Electric_rules
1047 as well as Welch's t-test that compares the last five points to the prior twenty points.
1049 The latter is what Mozilla uses (or at least did in the past) to detect performance regressions on their
1050 performance tests although they compare medians instead of means.
1052 All of these strategies don't quite work for us since our data points are too noisy but this is a good start.
1055 (App.Pane.updateStatisticsTools): Clone anomaly detection strategies.
1056 (App.Pane._updateMovingAverageAndEnvelope): Highlight anomalies detected by the enabled strategies.
1057 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Observe changes to anomaly detection strategies.
1058 (App.Pane._computeMovingAverageAndOutliers): Detect anomalies by each strategy and aggregate results.
1059 Only report the first data point when multiple consecutive data points are detected as anomalies.
1060 * public/v2/chart-pane.css: Updated styles.
1061 * public/v2/index.html: Added the pane for selecting anomaly detection strategies.
1062 * public/v2/js/statistics.js:
1063 (Statistics.testWelchsT): Added. Implements Welch's t-test.
1064 (.sampleMeanAndVarianceForValues): Added.
1065 (.createWesternElectricRule): Added.
1066 (.countValuesOnSameSide): Added.
1067 (Statistics.AnomalyDetectionStrategy): Added.
1069 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
1071 REGRESSION: Searching commits can highlight wrong data points
1072 https://bugs.webkit.org/show_bug.cgi?id=143272
1074 Reviewed by Antti Koivisto.
1076 The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
1077 return commit times with only second precision. This resulted in the frontend code to match a commit
1078 with the data point that included the next commit when the millisecond component of commit's timestamp
1079 wasn't identically 0.
1081 This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
1082 was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
1083 so miliseconds component was only preserved in /api/commits.
1085 Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
1086 it returns time in milisecond precision.
1088 * public/api/commits.php:
1089 (fetch_commits_between): Use Database::to_js_time for format commit times.
1090 (format_commit): Ditto.
1091 * public/include/db.php:
1092 (Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
1093 * public/v2/data.js:
1094 (CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
1096 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
1098 Perf dashboard should show relative change in values
1099 https://bugs.webkit.org/show_bug.cgi?id=143252
1101 Reviewed by Antti Koivisto.
1103 When a range of values are selected, show the percentage difference between the start and the end
1104 in addition to the absolute value difference. When a single point is selected, show the relative
1105 difference with respect to the previous point. Use two significant figures and always show plus sign
1106 when the difference is positive.
1108 * public/v2/app.js: Compute and format the relative difference.
1109 * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
1110 * public/v2/index.html: Show the relative difference.
1112 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
1114 REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
1115 https://bugs.webkit.org/show_bug.cgi?id=143254
1117 Reviewed by Antti Koivisto.
1119 The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
1120 or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
1121 so that the interactive chart component will observe a change to 'chartData'.
1124 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
1126 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
1128 Unreviewed build fixes.
1130 * public/include/manifest.php:
1131 (Manifest::generate): These should be {} instead of [] when they're empty.
1132 * public/v2/data.js:
1133 (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
1134 * public/v2/manifest.js:
1135 (App.Metric.fullName): Fixed the typo.
1136 * tests/admin-regenerate-manifest.js: Fixed the test.
1138 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
1140 Commit the erroneously reverted change.
1142 * public/api/runs.php:
1143 (RunsGenerator::results):
1145 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
1147 Loading the perf dashboard takes multiple seconds
1148 https://bugs.webkit.org/show_bug.cgi?id=141860
1150 Reviewed by Andreas Kling.
1152 This patch introduces the caches of JSON files returned by /api/ in /data/ directory. It also records
1153 the last time test_runs rows associated with the requested platforms and metrics are inserted, updated,
1154 or removed in the caches as well as the manifest JSON files ("last modified time"). Because the manifest
1155 is regenerated each time a new test result is reported, the front end can compare last modified time in
1156 the manifest file with that in a /api/runs JSON cache to detect the stale-ness.
1158 More concretely, the front end first optimistically fetches the JSON in /data/. If the cache doesn't exit
1159 or the last modified time in the cache doesn't match with that in the manifest file, it would fetch it
1160 again via /api/runs. In the case the cache did exist, we render the charts based on the cache meanwhile.
1161 This dramatically reduces the perceived latency for the page load since charts are drawn immediately using
1162 the cache and we would only re-render the charts as new up-to-date JSON comes in.
1164 This patch also changes the format of runs JSONs by pushing the exiting properties into 'configurations'
1165 and adding 'lastModified' and 'elapsedTime' at the top level.
1167 * init-database.sql: Added config_runs_last_modified to test_configurations table as well as a trigger to
1168 auto-update this column upon changes to test_runs table.
1170 * public/admin/test-configurations.php:
1171 (add_run): Regenerate the manifest file to invalidate the /api/runs JSON cache.
1172 (delete_run): Ditto.
1174 * public/api/runs.php:
1175 (main): Fetch all columns of test_configurations table including config_runs_last_modified. Also generate
1176 the cache in /data/ directory.
1177 (RunsGenerator::__construct): Compute the last modified time for this (platform, metric) pair.
1178 (RunsGenerator::results): Put the old content in 'configurations' property and include 'lastModified' and
1179 'elapsedTime' properties. 'elapsedTime' is added for debugging purposes.
1180 (RunsGenerator::add_runs):
1181 (RunsGenerator::parse_revisions_array):
1183 * public/include/db.php:
1184 (CONFIG_DIR): Added.
1185 (generate_data_file): Added based on ManifestGenerator::store.
1186 (Database::to_js_time): Extracted from RunsGenerator::add_runs to share code.
1188 * public/include/json-header.php:
1189 (echo_success): Renamed from success_json. Return the serialized JSON instead of echo'ing it so that we can
1190 generate caches in /api/runs/.
1191 (exit_with_success):
1193 * public/include/manifest.php:
1194 (ManifestGenerator::generate): Added 'elapsedTime' property for the time taken to generate the manifest.
1195 It seems like we're generating it in 200-300ms for now so that's good.
1196 (ManifestGenerator::store): Uses generate_data_file.
1197 (ManifestGenerator::platforms): Added 'lastModified' array to each platform entry. This array contains the
1198 last modified time for each (platform, metric) pair.
1200 * public/index.html:
1201 (fetchTest): Updated per the format change in runs JSON.
1204 (App.Pane._fetch): Fetch the cached JSON first. Refetch the uncached version if instructed as such.
1205 (App.Pane._updateChartData): Extracted from App.Pane._fetch.
1206 (App.Pane._handleFetchErrors): Ditto.
1208 * public/v2/data.js:
1209 (RunsData.fetchRuns): Takes the fourth argument indicating whether we should fetch the cached version or not.
1210 The cached JSON is located in /data/ with the same filename. When fetching a cached JSON results in 404,
1211 fulfill the promise with null as the result instead of rejecting it. The only client of this function which
1212 sets useCache to true is App.Manifest.fetchRunsWithPlatformAndMetric, and it handles this special case.
1214 * public/v2/manifest.js:
1215 (App.DateArrayTransform): Added. Handles the array of last modified dates in platform objects.
1216 (App.Platform.lastModifiedTimeForMetric): Added. Returns the last modified date in the manifest JSON.
1217 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes "useCache" like RunsData.fetchRuns. Set shouldRefetch
1218 to true if response is null (the cache didn't exit) or the cache is out-of-date.
1219 (App.Manifest._formatFetchedData): Extracted from App.Manifest.fetchRunsWithPlatformAndMetric.
1222 (initializeDatabase): Avoid splitting function definitions in the middle.
1224 * tests/api-report.js: Added tests to verify that reporting new test results updates the last modified time
1225 in test_configurations.
1227 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
1229 REGRESSION(r180333): Analysis tasks can't be associated with bugs
1230 https://bugs.webkit.org/show_bug.cgi?id=141858
1232 Reviewed by Andreas Kling.
1234 Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
1235 of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
1237 * public/v2/chart-pane.css:
1238 * public/v2/index.html:
1240 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
1242 Selecting revisions for A/B testing is hard
1243 https://bugs.webkit.org/show_bug.cgi?id=141824
1245 Reviewed by Andreas Kling.
1247 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
1248 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
1249 select A/B testing points manually.
1251 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
1252 sets to 'options' for clarity.
1254 * public/v2/app.css: Reorganized style rules.
1257 (App.AnalysisTaskController):
1258 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
1259 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
1260 a property, which sets 'overviewDomain' property as well as other properties.
1261 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
1262 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
1263 in the overview chart.
1265 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
1266 individual build requests / test results are shown or not.
1268 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
1269 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
1271 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
1273 Unreviewed test fixes after r179037, r179591, and r179763.
1275 * tests/admin-regenerate-manifest.js:
1276 * tests/admin-reprocess-report.js:
1278 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
1280 Relationship between A/B testing results are unclear
1281 https://bugs.webkit.org/show_bug.cgi?id=141810
1283 Reviewed by Andreas Kling.
1285 Show a "reference chart" indicating which two points have been tested in each test group pane.
1287 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
1288 and the domain used in this chart to show charts in each test group.
1290 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
1292 * public/v2/analysis.js:
1293 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
1294 since this is the results of A/B testing results, not the data for charts shown next to them.
1296 * public/v2/app.css: Added CSS rules for reference charts.
1299 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
1300 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
1301 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
1302 identically matches root sets. If one of configuration used a set of revisions for which no measurement
1303 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
1304 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
1305 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
1306 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
1308 * public/v2/data.js:
1309 (Measurement.prototype.revisionForRepository): Added.
1310 (Measurement.prototype.commitTimeForRepository): Cleanup.
1311 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
1313 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
1314 by including the build number in the title attribute instead of in the markup.
1316 * public/v2/interactive-chart.js:
1317 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
1318 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
1319 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
1321 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
1323 Analysis task pages are unusable
1324 https://bugs.webkit.org/show_bug.cgi?id=141786
1326 Reviewed by Andreas Kling.
1328 This patch makes following improvements to analysis task pages:
1329 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
1330 compute the data for the details pane from PaneController.
1331 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
1332 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
1333 This change required the creation of App.TestGroupPane as well as its methods.
1334 4. Show a box plot for each root set configuration as well as each build request. This change required
1335 App.BoxPlotComponent.
1336 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
1338 * public/api/build-requests.php:
1339 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
1341 * public/api/test-groups.php:
1342 (main): Include root sets and roots in the response.
1343 (format_test_group):
1345 * public/include/build-requests-fetcher.php:
1346 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
1347 (BuildRequestsFetcher::root_sets): Added.
1348 (BuildRequestsFetcher::roots): Added.
1349 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
1350 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
1351 tools/sync-with-buildbot.py can't convert repository names to their ids.
1353 * public/v2/analysis.js:
1355 (App.RootSet): Added.
1356 (App.RootSet.revisionForRepository): Added.
1357 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
1358 response at /api/test-groups will include them.
1359 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
1360 _createConfigurationSummary.
1361 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
1362 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
1364 * public/v2/app.css: Updated style rules for analysis task pages.
1367 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
1368 (App.Pane._updateDetails): Moved from App.PaneController.
1370 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
1372 (App.AnalysisTaskController): Added 'details'.
1373 (App.AnalysisTaskController._taskUpdated):
1374 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
1375 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
1376 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
1378 (App.TestGroupPane): Added.
1379 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
1380 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
1381 of all repositories appearing in root sets and builds associated with A/B testing results.
1382 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
1383 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
1384 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
1385 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
1386 is a union of revisions in the root set and the first build request in the group. We null-out revision info
1387 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
1388 by the values in the group as well as 95% percentile confidence interval.
1390 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
1391 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
1392 the mean and the confidence interval.
1393 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
1394 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
1395 calls _updateBars to update the rects.
1397 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
1399 * public/v2/data.js:
1400 (Measurement.prototype.formattedRevisions):
1401 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
1402 called in _createConfigurationSummary.
1404 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
1405 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
1406 Also made the fetching of chartData no longer block showing of test groups.
1408 * public/v2/interactive-chart.js:
1409 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
1410 (App.InteractiveChartComponent._domainChanged): Ditto.
1411 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
1413 * public/v2/js/statistics.js:
1414 (Statistics.min): Added.
1415 (Statistics.max): Added.
1417 * public/v2/manifest.js:
1418 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
1420 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
1422 Build URL on new perf dashboard doesn't resolve $builderName
1423 https://bugs.webkit.org/show_bug.cgi?id=141583
1425 Reviewed by Darin Adler.
1427 Support $builderName in the build URL template.
1429 * public/js/helper-classes.js:
1430 (TestBuild.buildUrl): Replaced $builderName with the builder name.
1432 * public/v2/manifest.js:
1433 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
1434 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
1436 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
1438 Unreviewed build fix after r179591.
1440 * public/api/commits.php:
1442 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
1444 The status of a A/B testing request always eventually becomes "Failed"
1445 https://bugs.webkit.org/show_bug.cgi?id=141523
1447 Reviewed by Andreas Kling.
1449 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
1450 'failedIfNotCompleted' was sent by the buildbot sync'er.
1452 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
1454 * public/api/build-requests.php:
1457 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
1459 Unreviewed, remove empty directories.
1461 * public/data: Removed.
1463 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
1465 Perf dashboard should show the results of A/B testing
1466 https://bugs.webkit.org/show_bug.cgi?id=141500
1468 Reviewed by Chris Dumez.
1470 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
1471 analysis task page to fetch results for each test group.
1473 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
1474 can use the formatter.
1476 * public/api/runs.php:
1477 (fetch_runs_for_config_and_test_group): Added.
1478 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
1479 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
1480 use RunsGenerator to format results.
1481 (RunsGenerator): Added.
1482 (RunsGenerator::__construct): Added.
1483 (RunsGenerator::add_runs): Added.
1484 (RunsGenerator::format_run): Moved.
1485 (RunsGenerator::parse_revisions_array): Moved.
1487 * public/v2/analysis.js:
1488 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
1489 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
1490 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
1491 configuration associated with this build request such as "A" and "B".
1492 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
1493 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
1494 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
1498 (App.Pane._fetch): Set chartData directly here.
1499 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
1500 now that it's done in App.Pane._fetch.
1501 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
1503 * public/v2/data.js:
1504 (Measurement.prototype.buildId): Added.
1505 (TimeSeries.prototype.findPointByBuild): Added.
1507 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
1508 url is not an Ember routed path.
1510 * public/v2/manifest.js:
1511 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
1512 App.createChartData here so that App.BuildRequest can use the formatter
1514 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
1516 v2 UI should adjust the number of ticks on dashboards based on screen size
1517 https://bugs.webkit.org/show_bug.cgi?id=141502
1519 Reviewed by Chris Dumez.
1521 * public/v2/interactive-chart.js:
1522 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
1525 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
1527 New perf dashboard shows too much space around interesting data points
1528 https://bugs.webkit.org/show_bug.cgi?id=141487
1530 Reviewed by Chris Dumez.
1532 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
1533 show the current time series excluding points in the series outside the moving average envelope.
1536 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
1537 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
1538 time series if the point lies outside the moving average envelope. Don't expose the moving average or
1539 the envelope computed for this purpose if they're not set by the user.
1541 * public/v2/data.js:
1542 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
1543 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
1545 * public/v2/interactive-chart.js:
1546 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
1547 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
1548 to deal with showFullYAxis here.
1549 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
1550 argument instead of directly inspecting showFullYAxis.
1552 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1554 New perf dashboard shouldn't always show outliners
1555 https://bugs.webkit.org/show_bug.cgi?id=141445
1557 Reviewed by Chris Dumez.
1559 Use the simple moving average with an average difference envelope to compute the y-axis range to show
1560 to avoid expanding it spuriously to show one off outlier.
1563 (App.Pane): Don't show the full y-axis range by default.
1564 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
1565 one is not specified by the user but without showing them in the charts.
1566 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
1567 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
1569 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
1570 (App.ChartsController._serializePaneList): Ditto.
1572 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
1574 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
1576 * public/v2/interactive-chart.js:
1577 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
1578 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
1579 if they are not specified by the user (i.e. only used to adjust y-axis range).
1580 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
1581 x-axis domain remained the same. Without this change, the charts would never redraw.
1582 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
1583 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
1584 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
1586 * public/v2/js/statistics.js:
1587 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
1589 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1591 Unreviewed build fix.
1594 (set get App.Pane.Ember.Object.extend):
1596 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1598 New perf dashboard should have the ability to overlay moving average with an envelope
1599 https://bugs.webkit.org/show_bug.cgi?id=141438
1601 Reviewed by Andreas Kling.
1603 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
1605 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
1606 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
1607 n, backward window size, and m, forward window size, as an argument.
1609 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
1610 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
1612 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
1613 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
1616 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
1617 between each x_i and x̄_i.
1619 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
1620 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
1621 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
1622 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
1625 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
1626 The configuration of the currently chosen strategies is saved in the query string for convenience.
1628 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
1630 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
1633 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
1634 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
1635 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
1636 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
1637 from the query string via ChartsController.
1638 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
1639 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
1640 (App.Pane._executeStrategy): Added.
1641 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
1643 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
1644 selections, and added two new arguments for the moving average and the enveloping configurations.
1645 (App.ChartsController._serializePaneList): Ditto.
1646 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
1647 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
1648 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
1649 (App.PaneController.actions.toggleStatPane): Added.
1651 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
1652 current (as opposed to baseline and target) time series for when it's the most foreground graph without
1653 moving average and its envelope overlapping on top of it.
1655 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
1657 * public/v2/interactive-chart.js:
1658 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
1659 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
1660 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
1661 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
1662 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
1663 but don't bother removing individual paths and circles. Added the code to show the moving average time
1664 series when there is one. Also add "foreground" class on SVG elements for the current time series when
1665 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
1666 series when "foreground" is not set.
1667 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
1668 account when computing the y-axis range.
1669 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
1671 * public/v2/js/statistics.js:
1672 (Statistics.MovingAverageStrategies): Added.
1673 (Statistics.EnvelopingStrategies): Added.
1675 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1677 The delta value in the chart pane sometimes doens't show '+' for a positive delta
1678 https://bugs.webkit.org/show_bug.cgi?id=141340
1680 Reviewed by Andreas Kling.
1682 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
1683 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
1686 (App.Pane.computeStatus):
1687 (App.createChartData):
1689 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1691 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
1694 (App.PaneController._updateDetails):
1696 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1698 Unreviewed. Commit the forgotten change.
1700 * public/include/manifest.php:
1702 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1704 New perf dashboard should have multiple dashboard pages
1705 https://bugs.webkit.org/show_bug.cgi?id=141339
1707 Reviewed by Chris Dumez.
1709 Added the support for multiple dashboard pages. Also added the status of the latest data point.
1710 e.g. "5% better than target"
1712 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
1713 Also hid the border lines around charts on the dashboard page for a cleaner look.
1716 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
1717 (App.IndexRoute.beforeModel): Added.
1718 (App.DashboardRoute): Added.
1719 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
1720 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
1721 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
1722 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
1723 (App.DashboardController): Renamed from App.IndexController.
1724 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
1725 and "defaultDashboard" as these are taken care of by newly added routers.
1726 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
1727 now done in actions.toggleEditMode.
1728 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
1729 an existing dashboard.
1731 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
1732 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
1733 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
1734 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
1736 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
1738 (App.PaneController._updateDetails): Updated per changes to computeStatus.
1740 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
1742 * public/v2/data.js:
1743 (TimeSeries.prototype.lastPoint): Added.
1745 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
1746 on the dashboard, and enumerate all predefined dashboards.
1748 * public/v2/interactive-chart.js:
1749 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
1750 for the dashboard page.
1752 * public/v2/manifest.js:
1753 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
1754 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
1755 IDs are generated for each dashboard for forward compatibility.
1757 (App.Manifest.dashboardByName): Added.
1758 (App.Manifest.defaultDashboardName): Added.
1759 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
1761 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1763 Move commits viewer to the end of details view
1764 https://bugs.webkit.org/show_bug.cgi?id=141315
1766 Rubber-stamped by Andreas Kling.
1768 Show the difference instead of the old value per kling's request.
1771 (App.PaneController._updateDetails):
1772 * public/v2/index.html:
1774 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1776 Move commits viewer to the end of details view
1777 https://bugs.webkit.org/show_bug.cgi?id=141315
1779 Reviewed by Andreas Kling.
1781 Improved the way list of commits are shown per kling's request.
1784 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
1786 * public/v2/chart-pane.css: Updated the style for the commits viewer.
1788 * public/v2/commits-viewer.js:
1789 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
1790 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
1792 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
1793 moved the commits viewers out of the details tables so that they don't interleave revision data.
1795 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1797 New perf dashboard should compare results to baseline and target
1798 https://bugs.webkit.org/show_bug.cgi?id=141286
1800 Reviewed by Chris Dumez.
1802 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
1803 Also use d3.format to format the selected value to show four significant figures.
1806 (App.Pane.searchCommit):
1807 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
1808 to compute the status text without having to recreate them.
1809 (App.createChartData): Added.
1810 (App.PaneController._updateDetails): Use 3d.format on current and old values.
1811 (App.PaneController._computeStatus): Added. Computes the status text.
1812 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
1813 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
1814 format the values using chartData.formatter.
1816 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
1817 the baseline and in blue if it's better than the target.
1819 * public/v2/data.js:
1820 (TimeSeries.prototype.findPointAfterTime): Added.
1822 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
1823 the bug that we were not showing the old value's unit.
1825 * public/v2/interactive-chart.js:
1826 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
1827 the code to show the baseline and the target lines.
1829 * public/v2/manifest.js:
1830 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
1832 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1834 Unreviewed build fix.
1837 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
1839 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1841 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
1842 https://bugs.webkit.org/show_bug.cgi?id=141280
1844 Reviewed by Chris Dumez.
1846 Fixed the bug by passing in "since" as a query parameter to the charts page.
1848 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
1850 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
1852 (App.IndexController): Changed the default number of days from one month to one week.
1853 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
1854 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
1856 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1858 New perf dashboard erroneously clears zoom when poping history items
1859 https://bugs.webkit.org/show_bug.cgi?id=141278
1861 Reviewed by Chris Dumez.
1863 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
1865 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
1866 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
1869 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
1870 shown in the main plot.
1871 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
1872 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
1874 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1876 New perf dashboard shows null as the aggregator name if no aggregation is done
1877 https://bugs.webkit.org/show_bug.cgi?id=141256
1879 Reviewed by Chris Dumez.
1881 Don't show the aggregator name if there isn't one.
1883 * public/v2/manifest.js:
1886 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1888 Unreviewed build fix after r179611.
1890 * public/v2/interactive-chart.js:
1892 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1894 Perf dashboard doesn’t show the right unit for Safari UI tests
1895 https://bugs.webkit.org/show_bug.cgi?id=141238
1897 Reviewed by Darin Adler.
1899 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
1900 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
1901 between metrics and their units.
1903 * public/js/helper-classes.js:
1904 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
1905 * public/v2/manifest.js:
1906 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
1907 * public/v2/interactive-chart.js:
1908 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
1909 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
1911 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1913 Interactive chart component provides two duplicate API for highlighting points
1914 https://bugs.webkit.org/show_bug.cgi?id=141234
1916 Reviewed by Chris Dumez.
1918 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
1919 on the main charts page and markedPoints to show the two end points in the analysis task page.
1921 This patch merges markedPoints into highlightedItems.
1924 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
1925 * public/v2/chart-pane.css:
1926 * public/v2/index.html: Ditto.
1927 * public/v2/interactive-chart.js:
1928 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
1929 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
1930 items if highlightedItems was set before the initial layout.
1931 (App.InteractiveChartComponent._relayoutDataAndAxes):
1932 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
1933 vertical lines, just set cx and cy as done for other "dots".
1934 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
1935 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
1936 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
1937 set the radius of highlight circles here.
1939 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1941 Don’t use repository names as id’s.
1942 https://bugs.webkit.org/show_bug.cgi?id=141226
1944 Reviewed by Chris Dumez.
1946 Not using repository names as their id's reduces the need to fetch the entire repositories table.
1947 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
1949 * Websites/perf.webkit.org/public/api/runs.php:
1950 (parse_revisions_array): No longer uses $repository_id_to_name.
1951 (main): No longer populates $repository_id_to_name.
1953 * Websites/perf.webkit.org/public/api/triggerables.php:
1954 (main): Don't resolve repository names.
1956 * Websites/perf.webkit.org/public/include/manifest.php:
1957 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
1958 (ManifestGenerator::bug_trackers): Don't resolve repository names.
1960 * Websites/perf.webkit.org/public/js/helper-classes.js:
1961 (TestBuild): Renamed repositoryName to repositoryId.
1962 (TestBuild.revision): Ditto.
1963 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
1964 since this is the text shown to human.
1966 * Websites/perf.webkit.org/public/v2/app.js:
1967 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
1968 (App.PaneController._updateDetails): Ditto.
1969 (App.AnalysisTaskController.updateRoots): Ditto.
1971 * Websites/perf.webkit.org/public/v2/data.js:
1972 (Measurement): Ditto.
1973 (Measurement.prototype.commitTimeForRepository): Ditto.
1974 (Measurement.prototype.formattedRevisions): Ditto.
1976 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
1977 select element's label and value respectively.
1979 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1981 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
1983 * public/api/runs.php:
1985 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1987 /api/runs.php should have main function
1988 https://bugs.webkit.org/show_bug.cgi?id=141220
1990 Reviewed by Benjamin Poulain.
1992 Wrapped the code inside main function for clarity.
1994 * public/api/runs.php:
1996 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
1998 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
2000 * tools/sync-with-buildbot.py:
2001 (find_request_updates):
2003 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
2005 Perf dashboard always assigns the result of A/B testing with build request 1
2006 https://bugs.webkit.org/show_bug.cgi?id=140382
2008 Reviewed by Darin Adler.
2010 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
2011 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
2013 Also fixed a typo as well as a bug that reports were never associated with builds.
2015 * public/include/report-processor.php:
2016 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
2017 instead of the first non-null value.
2018 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
2019 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
2021 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
2023 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
2025 * public/admin/tests.php:
2027 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
2029 Unreviewed build fix. Removed the stale code.
2031 * public/admin/triggerables.php:
2033 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
2035 Perf dashboard should have the ability to post A/B testing builds
2036 https://bugs.webkit.org/show_bug.cgi?id=140317
2038 Rubber-stamped by Simon Fraser.
2040 This patch adds the support for triggering A/B testing from the perf dashboard.
2042 We add a few new tables to the database. "build_triggerables", which represents a set of builders
2043 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
2044 of repositories for which an arbitrary revision can be specified for A/B testing.
2045 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
2046 "roots" table which specifies the revision used in a given root set in each repository.
2048 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
2049 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
2050 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
2051 to build_requests table. Also made each test group's name unique in a given analysis task as it
2052 would be confusing to have multiple test groups of the same name.
2054 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
2056 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
2057 for which a specific revision can be set in an A/B testing on a given triggerable.
2059 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
2060 triggerable. Also updates the status' and the status urls of specified build requests when
2061 buildRequestUpdates is provided in the raw POST data.
2064 * public/api/runs.php:
2065 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
2066 results of an A/B testing.
2068 * public/api/test-groups.php:
2069 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
2071 * public/api/triggerables.php: Added.
2072 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
2074 * public/include/admin-header.php:
2076 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
2077 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
2078 and root sets used in those requests.D
2079 (BuildRequestsFetcher::__construct):
2080 (BuildRequestsFetcher::fetch_for_task):
2081 (BuildRequestsFetcher::fetch_for_group):
2082 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
2083 (BuildRequestsFetcher::has_results):
2084 (BuildRequestsFetcher::results):
2085 (BuildRequestsFetcher::results_with_resolved_ids):
2086 (BuildRequestsFetcher::results_internal):
2087 (BuildRequestsFetcher::root_sets):
2088 (BuildRequestsFetcher::fetch_roots_for_set):
2090 * public/include/db.php:
2091 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
2092 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
2093 table since it only has the primary key, id, column.
2094 (Database::select_or_insert_row):
2095 (Database::update_or_insert_row):
2096 (Database::update_row): Added.
2097 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
2098 should be inserted when no row matches the specified criteria. This is used while updating
2099 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
2100 new build requests in that API.
2101 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
2102 This is used in public/api/triggerables.php when no analysis task is specified.
2104 * public/include/json-header.php:
2105 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
2106 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
2107 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
2108 find the closest ancestor with a triggerable.
2110 * public/include/report-processor.php:
2111 (ReportProcessor::process):
2112 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
2113 if jobId or buildRequest is specified.
2115 * public/include/test-name-resolver.php:
2116 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
2117 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
2118 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
2121 * public/include/test-path-resolver.php: Added.
2122 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
2123 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
2124 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
2125 in order to compute full test metric names.
2126 (TestPathResolver::__construct):
2127 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
2128 the highest (a test without a parent).
2129 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
2130 the highest ancestor to the test itself.
2131 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
2133 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
2135 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
2136 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
2137 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
2138 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
2140 * public/v2/analysis.js:
2141 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
2142 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
2143 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
2144 (App.TestGroup.create): Added. Creates a new A/B testing group.
2145 (App.Triggerable): Added.
2146 (App.TriggerableAdapter): Added.
2147 (App.TriggerableAdapter.buildURL): Added.
2148 (App.BuildRequest.testGroup): Renamed from group.
2149 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
2150 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
2151 in this build request.
2152 (App.BuildRequest.status): Added.
2153 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
2154 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
2157 (App.AnalysisTaskController.testGroups): Added.
2158 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
2159 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
2160 but an observer that updates "roots" property. Filter out the repositories that are not accepted
2161 by the associated triggerable as they will be ignored.
2162 (App.AnalysisTaskController.actions.createTestGroup): Added.
2164 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
2166 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
2167 the status of those builds to the perf dashboard. A similar script can be written to support
2168 other continuous builds systems.
2169 (main): Fetches the list of pending builds as well as currently running or completed builds from
2170 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
2171 a single new build on each builder with no pending builds, and marks the set of open build requests
2172 that have been scheduled to run on the buildbot but not found in the first step as stale.
2173 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
2176 "platform": "mac-mavericks",
2177 "test": ["Parser", "html5-full-render.html"],
2178 "builder": "Trunk Syrah Production Perf AB Tests",
2180 "forcescheduler": "force-mac-mavericks-release-perf",
2181 "webkit_revision": "$WebKit",
2182 "jobid": "$buildRequest"
2187 (find_request_updates): Return a list of build request status updates to make based on the pending
2188 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
2189 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
2190 if the build request had not been completed. This is necessary because a failed build will not
2191 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
2192 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
2193 of open requests the perf dashboard has.
2194 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
2195 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
2196 or human canceling a build may trigger such a state.
2197 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
2198 replacing repository names with their revisions and buildRequest with the build request id.
2199 (config_for_request): Finds a builder for the test and the platform of a build request.
2200 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
2201 (property_value_from_build): Returns the value of a specific property in a buildbot build.
2202 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
2204 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
2206 Cache-control should be set only on api/runs
2207 https://bugs.webkit.org/show_bug.cgi?id=140312
2209 Reviewed by Andreas Kling.
2211 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
2212 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
2213 just set cache-control there instead of json-header.php which is used by other JSON APIs.
2215 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
2217 * public/api/analysis-tasks.php:
2218 * public/api/runs.php: Set the cache control headers.
2219 * public/api/test-groups.php:
2220 * public/include/db.php: Set the default timezone to UTC.
2221 * public/include/json-header.php: Don't set the cache control headers.
2223 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
2225 api/report-commit should authenticate with a slave name and password
2226 https://bugs.webkit.org/show_bug.cgi?id=140308
2228 Reviewed by Benjamin Poulain.
2230 Use a slave name and a password to authenticate new commit reports.
2232 * public/api/report-commits.php:
2234 * public/include/json-header.php:
2235 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
2236 a slave name and a password instead of a builder name and a password.
2237 * tests/api-report-commits.js: Updated tests.
2238 * tools/pull-svn.py:
2239 (main): Renamed variables.
2240 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
2242 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
2244 Perf dashboard should support authentication via a slave password
2245 https://bugs.webkit.org/show_bug.cgi?id=139837
2247 Reviewed by Andreas Kling.
2249 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
2250 having to add multiple builders with the same password when a single build slave is shared among them.
2252 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
2254 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
2256 * public/admin/build-slaves.php: Added.
2258 * public/admin/builders.php: Added the support for updating passwords.
2260 * public/include/admin-header.php:
2261 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
2262 being retrieved from $_POST.
2263 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
2264 the raw may not exist (e.g. new_password).
2265 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
2266 control here when this flag evaluates to TRUE.
2268 * public/include/report-processor.php:
2269 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
2270 values are present in the report. In addition, try authenticating builderName with slavePassword if
2271 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
2272 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
2273 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
2275 (ReportProcessor::store_report): Store the slave ID with the report.
2276 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
2277 the matching build is different from what's being reported.
2279 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
2282 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
2284 New perf dashboard should not duplicate author information in each commit
2285 https://bugs.webkit.org/show_bug.cgi?id=139756
2287 Reviewed by Darin Adler.
2289 Instead of each commit having author name and email, make it reference a newly added committers table.
2290 Also replace "email" by "account" since some repositories don't use emails as account names.
2292 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
2293 which only contains as many rows as there are accounts in each repository, instead of commits table
2294 which contains every commit ever happened in each repository.
2296 To migrate an existing database into match the new schema, run:
2300 INSERT INTO committers (committer_repository, committer_name, committer_email)
2301 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
2302 FROM commits WHERE commit_author_email IS NOT NULL);
2304 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
2306 UPDATE commits SET commit_committer = committer_id FROM committers
2307 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
2309 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
2310 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
2314 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
2315 reference to committers. Also added the missing drop table statements.
2317 * public/api/commits.php:
2318 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
2319 an array here instead of doing it in format_commit.
2320 (fetch_commits_between): Updated queries to JOIN commits with committers.
2321 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
2322 is now done in main.
2324 * public/api/report-commits.php:
2325 (main): Store the reported committer information or update the existing entry if there is one.
2327 * tests/admin-regenerate-manifest.js: Fixed tests.
2329 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
2331 * tools/pull-svn.py: Renamed email to account.
2333 (fetch_commit_and_resolve_author):
2335 (resolve_author_name_from_account):
2336 (resolve_author_name_from_email): Deleted.
2338 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
2340 Unreviewed build fix.
2342 * public/v2/index.html: Include js files we extracted in r177424.
2344 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
2346 Unreviewed. Adding the forgotten svnprop.
2348 * tools/pull-svn.py: Added property svn:executable.
2350 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
2352 Split InteractiveChartComponent and CommitsViewerComponent into separate files
2353 https://bugs.webkit.org/show_bug.cgi?id=139716
2355 Rubber-stamped by Benjamin Poulain.
2357 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
2358 and interactive-chart.js respectively since app.js has gotten really large.
2361 * public/v2/commits-viewer.js: Added.
2362 * public/v2/interactive-chart.js: Added.
2364 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
2366 New perf dashboard's chart UI is buggy
2367 https://bugs.webkit.org/show_bug.cgi?id=139214
2369 Reviewed by Chris Dumez.
2371 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
2373 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
2374 component. This is not how Ember.js components should interact to begin with. The component now exposes
2375 selectedPoints and always updates selection instead of sharedSelection.
2378 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
2379 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
2380 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
2381 and end time should be completely determined by "since" and the present time.
2382 (App.ChartsController._startTimeChanged): Ditto.
2383 (App.ChartsController._scheduleQueryStringUpdate):
2384 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
2386 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
2388 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
2389 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
2390 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
2391 observes the changes to selectedPoints property as it gets updated by the main chart.
2392 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
2393 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
2395 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
2396 when domain arrays aren't identical. This was causing a subtle race with other logic.
2397 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
2398 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
2399 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
2400 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
2401 see if those two points correspond to a range or a single data point. Rewrote all that logic by
2402 directly observing selectedPoints and currentItem properties instead of taking points and relying on
2403 an instance variable, which was a terrible API.
2404 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
2405 when the main plot has a selected range, we don't have to check this._hasRange anymore.
2407 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
2408 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
2409 (App.InteractiveChartComponent._updateSelection):
2410 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
2411 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
2412 selectedPoints property.
2414 (App.AnalysisTaskController._fetchedRuns):
2415 (App.AnalysisTaskController._rootChangedForTestSet):
2417 * public/v2/index.html:
2418 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
2420 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
2422 Unreviewed. Fixed syntax errors.
2424 * init-database.sql:
2425 * public/api/commits.php:
2427 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
2429 The dashboard on new perf monitor should be configurable
2430 https://bugs.webkit.org/show_bug.cgi?id=138994
2432 Reviewed by Benjamin Poulain.
2434 For now, make it configurable via config.json. We should eventually make it configurable via
2435 an administrative page but this will do for now.
2437 * config.json: Added the empty dashboard configuration.
2439 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
2442 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
2443 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
2444 Also obtain the default configuration from App.Manifest.
2445 (App.IndexController._normalizeTable): Moved to App.Dashboard.
2447 * public/v2/manifest.js:
2448 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
2449 (App.Repository.urlForRevisionRange): Ditto.
2450 (App.Dashboard): Added.
2451 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
2452 (App.Dashboard.rows): Ditto.
2453 (App.Dashboard.headerColumns): Ditto.
2454 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
2455 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
2456 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
2457 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
2459 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
2461 There should be a way to associate bugs with analysis tasks
2462 https://bugs.webkit.org/show_bug.cgi?id=138977
2464 Reviewed by Benjamin Poulain.
2466 Updated associate-bug.php to match the new database schema.
2468 * public/include/json-header.php:
2469 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
2470 already camel-cased in require_existence_of. This makes the function usable elsewhere.
2472 * public/privileged-api/associate-bug.php:
2473 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
2474 Also verify that those values are integers using require_format.
2476 * public/v2/analysis.js:
2477 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
2478 (App.Bug.label): Added.
2479 (App.BugAdapter): Added.
2480 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
2481 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
2483 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
2484 containing the bug information.
2487 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
2488 (App.AnalysisTaskRoute):
2489 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
2490 (App.AnalysisTaskController._fetchedManifest): Added.
2491 (App.AnalysisTaskController.actions.associateBug): Added.
2493 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
2495 * public/v2/data.js:
2496 (Measurement.prototype.associateBug): Deleted.
2498 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
2499 Added a table show the bug information. Also hide the chart until chartData is available.
2501 * public/v2/manifest.js:
2504 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
2506 Fix misc bugs and typos in app.js
2507 https://bugs.webkit.org/show_bug.cgi?id=138946
2509 Reviewed by Benjamin Poulain.
2512 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
2513 (App.ChartsController.init):
2514 (App.buildPopup): Renamed from App.BuildPopup.
2515 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
2516 remove() on the wrong object (an array as opposed to elements in the array).
2517 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
2518 _highlights is always an array and evalutes to true.
2520 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
2522 New perf dashboard should provide UI to create a new analysis task
2523 https://bugs.webkit.org/show_bug.cgi?id=138910
2525 Reviewed by Benjamin Poulain.
2527 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
2528 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
2530 With this patch, we can create a new analysis task by selection a range of points and opening
2531 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
2532 in the chart hyperlinked to the analysis task.
2534 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
2536 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
2537 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
2539 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
2540 and adds the associated bugs to each task in the array.
2543 * public/api/runs.php: Reverted changes made in r175006.
2544 (fetch_runs_for_config):
2547 * public/api/test-groups.php:
2548 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
2550 * public/include/db.php:
2551 (Database::select_first_or_last_row):
2552 (Database::select_rows): Extracted from select_first_or_last_row.
2554 * public/v2/analysis.js:
2555 (App.AnalysisTask): Added "bugs" property.
2556 (App.Bug): Added now that bugs are regular data store objects.
2559 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
2560 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
2561 platform that are associated with a specific range of runs.
2562 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
2563 (App.PaneController.actions.associateBug): Deleted.
2564 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
2565 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
2566 once we've created one.
2567 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
2568 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
2569 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
2570 (App.PaneController._updateBugs): Deleted.
2571 (App.PaneController._updateMarkedPoints): Deleted.
2572 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
2573 the name is missing or when at most one point is selected.
2575 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
2576 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
2577 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
2578 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
2579 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
2580 clickable bars for analysis tasks.
2581 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
2582 bar for analysis tasks to place them at the right location.
2583 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
2585 * public/v2/chart-pane.css:
2586 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
2587 (.chart .rangeBar): Added.
2589 * public/v2/data.js:
2590 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
2592 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
2593 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
2594 task bars in the interactive chart component.
2596 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
2598 Fix typos in r176203.
2601 (App.ChartsController.actions.addPaneByMetricAndPlatform):
2602 (App.AnalysisTaskRoute):
2604 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
2606 Unreviewed. Updated the install instruction.
2610 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
2612 App.Manifest shouldn't use App.__container__.lookup
2613 https://bugs.webkit.org/show_bug.cgi?id=138768
2615 Reviewed by Andreas Kling.
2617 Removed the hack to find the store object via App.__container__.lookup.
2618 Pass around the store object instead.
2621 (App.DashboardRow._createPane): Add "store" property to the pane.
2622 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
2623 (App.IndexController.gridChanged): Ditto.
2624 (App.IndexController.actions.addRow): Ditto.
2625 (App.IndexController.init): Ditto.
2626 (App.Pane._fetch): Ditto.
2627 (App.ChartsController._parsePaneList): Ditto.
2628 (App.ChartsController._updateQueryString): Ditto.
2629 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
2630 (App.BuildPopup): Ditto.
2631 (App.AnalysisTaskRoute.model): Ditto.
2632 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
2634 * public/v2/manifest.js:
2635 (App.Manifest.fetch): Removed the code to find the store object.
2637 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
2639 Fix Ember.js warnings the new perf dashboard
2640 https://bugs.webkit.org/show_bug.cgi?id=138531
2642 Reviewed by Darin Adler.
2644 Fixed various warnings.
2647 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
2648 * public/v2/data.js:
2649 (PrivilegedAPI._post): Removed the superfluous console.log.
2650 (CommitLogs.fetchForTimeRange): Ditto.
2651 * public/v2/index.html: Added tbody as required by the HTML specification.
2653 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
2655 Fix typos in r175768.
2658 (App.AnalysisTaskViewModel.roots):
2660 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
2662 Introduce the concept of analysis task to perf dashboard
2663 https://bugs.webkit.org/show_bug.cgi?id=138517
2665 Reviewed by Andreas Kling.
2667 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
2668 a single platform and used to bisect regressions in the range.
2670 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
2672 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
2673 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
2674 test runs. Analysis tasks not associated with test runs are used for try new patches.
2675 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
2676 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
2677 build_requests - A build request represents a single pending build for A/B testing.
2679 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
2683 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
2684 the specified analysis task group as well as build requests associated with them.
2686 (fetch_test_groups_for_task):
2687 (fetch_build_requests_for_task):
2688 (fetch_build_requests_for_group):
2689 (format_test_group):
2690 (format_build_request):
2692 * public/include/json-header.php:
2693 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
2696 * public/privileged-api/associate-bug.php:
2697 (main): Fixed a typo.
2699 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
2702 (ensure_config_from_runs):
2704 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
2706 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
2708 (App.AnalysisTask.create):
2710 (App.TestGroupAdapter):
2711 (App.AnalysisTaskSerializer):
2712 (App.TestGroupSerializer):
2715 * public/v2/app.css: Added style rules for the analysis page.
2718 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
2720 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
2721 exactly one selected point as we can still create an analysis task.
2722 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
2723 grammatical and also alert'ed the error message when there is one.
2724 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
2725 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
2726 once XHR request has completed.
2727 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
2728 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
2729 is selected in the details pane.
2731 (App.AnalysisRoute): Added.
2732 (App.AnalysisTaskRoute): Added.
2733 (App.AnalysisTaskViewModel): Added.
2734 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
2735 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
2736 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
2737 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
2738 the user selects an option for all roots in A or B configuration.
2739 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
2741 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
2743 * public/v2/data.js:
2744 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
2745 point so that we can use it in App.AnalysisTaskViewModel.roots.
2746 (TimeSeries.prototype.findPointByMeasurementId): Added.
2747 (TimeSeries.prototype.seriesBetweenPoints): Added.
2749 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
2750 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
2751 when multiple points are selected. Finally, added a new template for the analysis task page.
2753 * public/v2/manifest.js:
2754 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
2755 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
2756 App.AnalysisTaskViewModel._taskUpdated.
2758 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
2760 Remove App.PaneController.bugsChangeCount in the new perf dashboard
2761 https://bugs.webkit.org/show_bug.cgi?id=138111
2763 Reviewed by Darin Adler.
2766 (App.PaneController.bugsChangeCount): Removed.
2767 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
2768 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
2769 Finds the list of current run's points that are associated with bugs.
2770 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
2771 * public/v2/chart-pane.css:
2772 (.chart .marked): Renamed from .hasBugs.
2773 * public/v2/index.html: Specify chartPointRadius and markedPoints.
2775 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
2777 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
2778 https://bugs.webkit.org/show_bug.cgi?id=138099
2780 Reviewed by Benjamin Poulain.
2782 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
2783 _showDetails inverting the order of the current and old measurements.
2786 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
2787 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
2788 current (latest) measurement and the first point is the oldest measurement.
2789 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
2791 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
2793 Perf dashboard should provide a way to associate bugs with a test run
2794 https://bugs.webkit.org/show_bug.cgi?id=137857
2796 Reviewed by Andreas Kling.
2798 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
2799 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
2800 the Apache configuration.
2803 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
2804 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
2805 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
2806 via the cookie and returns a token computed from those two values as well as the remote username.
2808 The font end code then POST's the request along with the returned token. The server side code verifies
2809 that the specified token can be generated from the salt and the expiration time set in the cookie, and
2810 the token hasn't expired.
2813 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
2814 have zero or exactly one bug associated with a test run.
2816 * public/admin/bug-trackers.php: Added the support for editing bug_url.
2817 * public/api/runs.php:
2818 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
2819 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
2820 an associated bug if there is one.
2821 (format_run): Calls parse_bugs_array.
2823 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
2824 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
2825 have a valid JSON payload.
2826 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
2827 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
2828 the expiration time stored in the cookie.
2829 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
2831 * public/include/manifest.php:
2832 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
2833 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
2835 * public/index.html:
2836 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
2838 * public/privileged-api/associate-bug.php: Added.
2839 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
2840 attack via ensure_privileged_api_data_and_token, which calls verify_token.
2842 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
2844 * public/v2/app.css:
2845 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
2846 selected in a chart.
2849 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
2850 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
2851 they would overlap on each other if both of them are shown.
2852 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
2853 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
2854 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
2855 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
2856 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
2857 showing the search pane.
2858 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
2859 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
2860 bugs in the selected range.
2862 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
2863 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
2864 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
2865 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
2866 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
2867 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
2868 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
2869 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
2871 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
2872 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
2873 to selectionChanged action instead of just finding the first and the last points.
2875 * public/v2/chart-pane.css: Updated the style.
2877 * public/v2/data.js:
2878 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
2879 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
2880 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
2881 we haven't already obtained a CSRF token or if the token has already been expired.
2882 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
2884 (Measurement.prototype.bugs): Added.
2885 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
2886 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
2888 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
2891 * public/v2/manifest.js:
2892 (App.BugTracker.bugUrl):
2893 (App.BugTracker.newBugUrl): Added.
2894 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
2895 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
2896 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
2897 (App.Manifest.bugTrackers): Added.
2898 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
2899 their respective ids to make the ordering stable.
2901 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
2903 Remove unused jobs table
2904 https://bugs.webkit.org/show_bug.cgi?id=137724
2906 Reviewed by Daniel Bates.
2908 Removed jobs table in the database as well as related code.
2910 * init-database.sql:
2911 * public/admin/jobs.php: Removed.
2912 * public/admin/tests.php:
2913 * public/include/admin-header.php:
2915 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2917 New perf dashboard should have an ability to search commits by a keyword
2918 https://bugs.webkit.org/show_bug.cgi?id=137675
2920 Reviewed by Geoffrey Garen.
2922 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
2923 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
2924 This API change allows fetch_commits_between to generate results without processing Postgres query results.
2926 In the front end side, we've added a search pane in pane controller, and the interactive chart component
2927 now has a concept of highlighted items which is used to indicate commits found by the search pane.
2929 * public/api/commits.php:
2930 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
2931 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
2932 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
2933 (format_commit): Renamed from format_commits. Now only formats one commit.
2935 * public/include/db.php:
2936 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
2938 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
2941 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
2942 which is a hash table that contains highlighted items' measurements' ids as keys.
2943 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
2944 the default commit repository.
2945 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
2946 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
2947 Added the code to initialize this._highlights.
2948 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
2949 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
2950 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
2951 the existing lines for the old highlighted items.
2952 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
2953 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
2955 * public/v2/chart-pane.css: Added style for the search pane and the search button.
2957 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
2958 (CommitLogs): Added.
2959 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
2960 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
2961 (CommitLogs._cacheConsecutiveCommits): Ditto.
2962 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
2963 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
2964 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
2966 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
2967 for showingDetails since this property is no longer used.
2969 * public/v2/manifest.js:
2970 (App.Manifest.repositories): Added.
2971 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
2972 the default repository to search.
2973 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
2975 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2977 Unreviewed build fix after r174555.
2979 * public/include/manifest.php:
2980 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
2981 * tests/admin-regenerate-manifest.js: Fixed the test case.
2983 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
2985 New perf dashboard UI tries to fetch commits all the time
2986 https://bugs.webkit.org/show_bug.cgi?id=137592
2988 Reviewed by Andreas Kling.
2990 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
2991 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
2992 no reported commits as they are all going to fail.
2994 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
2995 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
2996 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
2997 of commits sorted chronologically by time.
2999 * public/include/manifest.php:
3002 (App.CommitsViewerComponent.commitsChanged):
3004 * public/v2/data.js:
3005 (FetchCommitsForTimeRange):
3006 (FetchCommitsForTimeRange._cachedCommitsByRepository):
3008 * public/v2/manifest.js:
3011 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
3013 Another unreviewed build fix after r174477.
3015 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
3017 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
3019 * public/include/report-processor.php:
3021 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
3023 Unreviewed build fix after r174477.
3025 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
3026 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
3028 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
3029 This is necessary for baseline and target values manually added via admin pages.
3031 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
3033 Add v2 UI for the perf dashboard
3034 https://bugs.webkit.org/show_bug.cgi?id=137537
3036 Rubber-stamped by Andreas Kling.
3039 * public/v2/app.css: Added.
3040 * public/v2/app.js: Added.
3041 * public/v2/chart-pane.css: Added.
3042 * public/v2/data.js: Added.
3043 * public/v2/index.html: Added.
3044 * public/v2/js: Added.
3045 * public/v2/js/d3: Added.
3046 * public/v2/js/d3/LICENSE: Added.
3047 * public/v2/js/d3/d3.js: Added.
3048 * public/v2/js/d3/d3.min.js: Added.
3049 * public/v2/js/ember-data.js: Added.
3050 * public/v2/js/ember.js: Added.
3051 * public/v2/js/handlebars.js: Added.
3052 * public/v2/js/jquery.min.js: Added.
3053 * public/v2/js/statistics.js: Added.
3054 * public/v2/manifest.js: Added.
3055 * public/v2/popup.js: Added.
3057 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
3059 Remove superfluously duplicated code in public/api/report-commits.php.
3061 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
3063 Perf dashboard should store commit logs
3064 https://bugs.webkit.org/show_bug.cgi?id=137510
3066 Reviewed by Darin Adler.
3068 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
3070 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
3071 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
3072 a subversion directory. The git version of this script will be added in a follow up patch.
3075 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
3076 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
3077 relationship via "build_commits" relations.
3079 In order to migrate an existing instance of this application, run the following SQL commands:
3083 INSERT INTO commits (commit_repository, commit_revision, commit_time)
3084 (SELECT DISTINCT ON (revision_repository, revision_value)
3085 revision_repository, revision_value, revision_time FROM build_revisions);
3087 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
3088 FROM commits, build_revisions
3089 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
3091 DROP TABLE build_revisions;
3096 The helper script to submit commit logs can be used as follows:
3098 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
3099 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
3101 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
3102 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
3103 "feeder-slave-password" as the builder name and the builder password respectively.
3105 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
3106 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
3109 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
3111 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
3112 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
3114 - Not specified - It returns every single commit for a given repository.
3115 - Matches "oldest" - It returns the commit with the oldest timestamp.
3116 - Matches "latest" - It returns the commit with the latest timestamp.
3117 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
3118 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
3119 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
3120 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
3121 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
3122 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
3124 (commit_from_revision):
3125 (fetch_commits_between):
3128 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
3129 See tests/api-report-commits.js for examples on how to use this API.
3131 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
3132 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
3133 to optimize this and other JSON APIs.
3135 * public/include/db.php:
3136 (Database::select_or_insert_row):
3137 (Database::update_or_insert_row): Added.
3138 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
3139 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
3141 (Database::select_first_row):
3142 (Database::select_last_row): Added.
3143 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
3144 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
3146 * public/include/report-processor.php:
3147 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
3148 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
3149 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
3152 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
3154 * tests/api-report-commits.js: Added.
3155 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.