1 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
6 (set get App.Pane.Ember.Object.extend):
8 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
10 New perf dashboard should have the ability to overlay moving average with an envelope
11 https://bugs.webkit.org/show_bug.cgi?id=141438
13 Reviewed by Andreas Kling.
15 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
17 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
18 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
19 n, backward window size, and m, forward window size, as an argument.
21 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
22 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
24 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
25 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
28 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
29 between each x_i and x̄_i.
31 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
32 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
33 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
34 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
37 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
38 The configuration of the currently chosen strategies is saved in the query string for convenience.
40 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
42 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
45 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
46 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
47 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
48 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
49 from the query string via ChartsController.
50 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
51 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
52 (App.Pane._executeStrategy): Added.
53 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
55 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
56 selections, and added two new arguments for the moving average and the enveloping configurations.
57 (App.ChartsController._serializePaneList): Ditto.
58 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
59 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
60 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
61 (App.PaneController.actions.toggleStatPane): Added.
63 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
64 current (as opposed to baseline and target) time series for when it's the most foreground graph without
65 moving average and its envelope overlapping on top of it.
67 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
69 * public/v2/interactive-chart.js:
70 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
71 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
72 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
73 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
74 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
75 but don't bother removing individual paths and circles. Added the code to show the moving average time
76 series when there is one. Also add "foreground" class on SVG elements for the current time series when
77 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
78 series when "foreground" is not set.
79 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
80 account when computing the y-axis range.
81 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
83 * public/v2/js/statistics.js:
84 (Statistics.MovingAverageStrategies): Added.
85 (Statistics.EnvelopingStrategies): Added.
87 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
89 The delta value in the chart pane sometimes doens't show '+' for a positive delta
90 https://bugs.webkit.org/show_bug.cgi?id=141340
92 Reviewed by Andreas Kling.
94 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
95 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
98 (App.Pane.computeStatus):
99 (App.createChartData):
101 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
103 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
106 (App.PaneController._updateDetails):
108 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
110 Unreviewed. Commit the forgotten change.
112 * public/include/manifest.php:
114 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
116 New perf dashboard should have multiple dashboard pages
117 https://bugs.webkit.org/show_bug.cgi?id=141339
119 Reviewed by Chris Dumez.
121 Added the support for multiple dashboard pages. Also added the status of the latest data point.
122 e.g. "5% better than target"
124 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
125 Also hid the border lines around charts on the dashboard page for a cleaner look.
128 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
129 (App.IndexRoute.beforeModel): Added.
130 (App.DashboardRoute): Added.
131 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
132 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
133 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
134 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
135 (App.DashboardController): Renamed from App.IndexController.
136 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
137 and "defaultDashboard" as these are taken care of by newly added routers.
138 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
139 now done in actions.toggleEditMode.
140 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
141 an existing dashboard.
143 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
144 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
145 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
146 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
148 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
150 (App.PaneController._updateDetails): Updated per changes to computeStatus.
152 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
155 (TimeSeries.prototype.lastPoint): Added.
157 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
158 on the dashboard, and enumerate all predefined dashboards.
160 * public/v2/interactive-chart.js:
161 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
162 for the dashboard page.
164 * public/v2/manifest.js:
165 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
166 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
167 IDs are generated for each dashboard for forward compatibility.
169 (App.Manifest.dashboardByName): Added.
170 (App.Manifest.defaultDashboardName): Added.
171 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
173 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
175 Move commits viewer to the end of details view
176 https://bugs.webkit.org/show_bug.cgi?id=141315
178 Rubber-stamped by Andreas Kling.
180 Show the difference instead of the old value per kling's request.
183 (App.PaneController._updateDetails):
184 * public/v2/index.html:
186 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
188 Move commits viewer to the end of details view
189 https://bugs.webkit.org/show_bug.cgi?id=141315
191 Reviewed by Andreas Kling.
193 Improved the way list of commits are shown per kling's request.
196 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
198 * public/v2/chart-pane.css: Updated the style for the commits viewer.
200 * public/v2/commits-viewer.js:
201 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
202 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
204 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
205 moved the commits viewers out of the details tables so that they don't interleave revision data.
207 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
209 New perf dashboard should compare results to baseline and target
210 https://bugs.webkit.org/show_bug.cgi?id=141286
212 Reviewed by Chris Dumez.
214 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
215 Also use d3.format to format the selected value to show four significant figures.
218 (App.Pane.searchCommit):
219 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
220 to compute the status text without having to recreate them.
221 (App.createChartData): Added.
222 (App.PaneController._updateDetails): Use 3d.format on current and old values.
223 (App.PaneController._computeStatus): Added. Computes the status text.
224 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
225 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
226 format the values using chartData.formatter.
228 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
229 the baseline and in blue if it's better than the target.
232 (TimeSeries.prototype.findPointAfterTime): Added.
234 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
235 the bug that we were not showing the old value's unit.
237 * public/v2/interactive-chart.js:
238 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
239 the code to show the baseline and the target lines.
241 * public/v2/manifest.js:
242 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
244 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
246 Unreviewed build fix.
249 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
251 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
253 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
254 https://bugs.webkit.org/show_bug.cgi?id=141280
256 Reviewed by Chris Dumez.
258 Fixed the bug by passing in "since" as a query parameter to the charts page.
260 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
262 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
264 (App.IndexController): Changed the default number of days from one month to one week.
265 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
266 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
268 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
270 New perf dashboard erroneously clears zoom when poping history items
271 https://bugs.webkit.org/show_bug.cgi?id=141278
273 Reviewed by Chris Dumez.
275 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
277 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
278 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
281 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
282 shown in the main plot.
283 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
284 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
286 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
288 New perf dashboard shows null as the aggregator name if no aggregation is done
289 https://bugs.webkit.org/show_bug.cgi?id=141256
291 Reviewed by Chris Dumez.
293 Don't show the aggregator name if there isn't one.
295 * public/v2/manifest.js:
298 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
300 Unreviewed build fix after r179611.
302 * public/v2/interactive-chart.js:
304 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
306 Perf dashboard doesn’t show the right unit for Safari UI tests
307 https://bugs.webkit.org/show_bug.cgi?id=141238
309 Reviewed by Darin Adler.
311 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
312 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
313 between metrics and their units.
315 * public/js/helper-classes.js:
316 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
317 * public/v2/manifest.js:
318 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
319 * public/v2/interactive-chart.js:
320 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
321 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
323 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
325 Interactive chart component provides two duplicate API for highlighting points
326 https://bugs.webkit.org/show_bug.cgi?id=141234
328 Reviewed by Chris Dumez.
330 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
331 on the main charts page and markedPoints to show the two end points in the analysis task page.
333 This patch merges markedPoints into highlightedItems.
336 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
337 * public/v2/chart-pane.css:
338 * public/v2/index.html: Ditto.
339 * public/v2/interactive-chart.js:
340 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
341 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
342 items if highlightedItems was set before the initial layout.
343 (App.InteractiveChartComponent._relayoutDataAndAxes):
344 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
345 vertical lines, just set cx and cy as done for other "dots".
346 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
347 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
348 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
349 set the radius of highlight circles here.
351 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
353 Don’t use repository names as id’s.
354 https://bugs.webkit.org/show_bug.cgi?id=141226
356 Reviewed by Chris Dumez.
358 Not using repository names as their id's reduces the need to fetch the entire repositories table.
359 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
361 * Websites/perf.webkit.org/public/api/runs.php:
362 (parse_revisions_array): No longer uses $repository_id_to_name.
363 (main): No longer populates $repository_id_to_name.
365 * Websites/perf.webkit.org/public/api/triggerables.php:
366 (main): Don't resolve repository names.
368 * Websites/perf.webkit.org/public/include/manifest.php:
369 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
370 (ManifestGenerator::bug_trackers): Don't resolve repository names.
372 * Websites/perf.webkit.org/public/js/helper-classes.js:
373 (TestBuild): Renamed repositoryName to repositoryId.
374 (TestBuild.revision): Ditto.
375 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
376 since this is the text shown to human.
378 * Websites/perf.webkit.org/public/v2/app.js:
379 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
380 (App.PaneController._updateDetails): Ditto.
381 (App.AnalysisTaskController.updateRoots): Ditto.
383 * Websites/perf.webkit.org/public/v2/data.js:
384 (Measurement): Ditto.
385 (Measurement.prototype.commitTimeForRepository): Ditto.
386 (Measurement.prototype.formattedRevisions): Ditto.
388 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
389 select element's label and value respectively.
391 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
393 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
395 * public/api/runs.php:
397 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
399 /api/runs.php should have main function
400 https://bugs.webkit.org/show_bug.cgi?id=141220
402 Reviewed by Benjamin Poulain.
404 Wrapped the code inside main function for clarity.
406 * public/api/runs.php:
408 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
410 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
412 * tools/sync-with-buildbot.py:
413 (find_request_updates):
415 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
417 Perf dashboard always assigns the result of A/B testing with build request 1
418 https://bugs.webkit.org/show_bug.cgi?id=140382
420 Reviewed by Darin Adler.
422 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
423 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
425 Also fixed a typo as well as a bug that reports were never associated with builds.
427 * public/include/report-processor.php:
428 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
429 instead of the first non-null value.
430 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
431 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
433 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
435 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
437 * public/admin/tests.php:
439 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
441 Unreviewed build fix. Removed the stale code.
443 * public/admin/triggerables.php:
445 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
447 Perf dashboard should have the ability to post A/B testing builds
448 https://bugs.webkit.org/show_bug.cgi?id=140317
450 Rubber-stamped by Simon Fraser.
452 This patch adds the support for triggering A/B testing from the perf dashboard.
454 We add a few new tables to the database. "build_triggerables", which represents a set of builders
455 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
456 of repositories for which an arbitrary revision can be specified for A/B testing.
457 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
458 "roots" table which specifies the revision used in a given root set in each repository.
460 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
461 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
462 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
463 to build_requests table. Also made each test group's name unique in a given analysis task as it
464 would be confusing to have multiple test groups of the same name.
466 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
468 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
469 for which a specific revision can be set in an A/B testing on a given triggerable.
471 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
472 triggerable. Also updates the status' and the status urls of specified build requests when
473 buildRequestUpdates is provided in the raw POST data.
476 * public/api/runs.php:
477 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
478 results of an A/B testing.
480 * public/api/test-groups.php:
481 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
483 * public/api/triggerables.php: Added.
484 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
486 * public/include/admin-header.php:
488 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
489 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
490 and root sets used in those requests.D
491 (BuildRequestsFetcher::__construct):
492 (BuildRequestsFetcher::fetch_for_task):
493 (BuildRequestsFetcher::fetch_for_group):
494 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
495 (BuildRequestsFetcher::has_results):
496 (BuildRequestsFetcher::results):
497 (BuildRequestsFetcher::results_with_resolved_ids):
498 (BuildRequestsFetcher::results_internal):
499 (BuildRequestsFetcher::root_sets):
500 (BuildRequestsFetcher::fetch_roots_for_set):
502 * public/include/db.php:
503 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
504 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
505 table since it only has the primary key, id, column.
506 (Database::select_or_insert_row):
507 (Database::update_or_insert_row):
508 (Database::update_row): Added.
509 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
510 should be inserted when no row matches the specified criteria. This is used while updating
511 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
512 new build requests in that API.
513 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
514 This is used in public/api/triggerables.php when no analysis task is specified.
516 * public/include/json-header.php:
517 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
518 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
519 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
520 find the closest ancestor with a triggerable.
522 * public/include/report-processor.php:
523 (ReportProcessor::process):
524 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
525 if jobId or buildRequest is specified.
527 * public/include/test-name-resolver.php:
528 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
529 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
530 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
533 * public/include/test-path-resolver.php: Added.
534 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
535 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
536 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
537 in order to compute full test metric names.
538 (TestPathResolver::__construct):
539 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
540 the highest (a test without a parent).
541 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
542 the highest ancestor to the test itself.
543 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
545 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
547 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
548 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
549 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
550 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
552 * public/v2/analysis.js:
553 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
554 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
555 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
556 (App.TestGroup.create): Added. Creates a new A/B testing group.
557 (App.Triggerable): Added.
558 (App.TriggerableAdapter): Added.
559 (App.TriggerableAdapter.buildURL): Added.
560 (App.BuildRequest.testGroup): Renamed from group.
561 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
562 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
563 in this build request.
564 (App.BuildRequest.status): Added.
565 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
566 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
569 (App.AnalysisTaskController.testGroups): Added.
570 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
571 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
572 but an observer that updates "roots" property. Filter out the repositories that are not accepted
573 by the associated triggerable as they will be ignored.
574 (App.AnalysisTaskController.actions.createTestGroup): Added.
576 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
578 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
579 the status of those builds to the perf dashboard. A similar script can be written to support
580 other continuous builds systems.
581 (main): Fetches the list of pending builds as well as currently running or completed builds from
582 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
583 a single new build on each builder with no pending builds, and marks the set of open build requests
584 that have been scheduled to run on the buildbot but not found in the first step as stale.
585 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
588 "platform": "mac-mavericks",
589 "test": ["Parser", "html5-full-render.html"],
590 "builder": "Trunk Syrah Production Perf AB Tests",
592 "forcescheduler": "force-mac-mavericks-release-perf",
593 "webkit_revision": "$WebKit",
594 "jobid": "$buildRequest"
599 (find_request_updates): Return a list of build request status updates to make based on the pending
600 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
601 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
602 if the build request had not been completed. This is necessary because a failed build will not
603 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
604 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
605 of open requests the perf dashboard has.
606 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
607 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
608 or human canceling a build may trigger such a state.
609 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
610 replacing repository names with their revisions and buildRequest with the build request id.
611 (config_for_request): Finds a builder for the test and the platform of a build request.
612 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
613 (property_value_from_build): Returns the value of a specific property in a buildbot build.
614 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
616 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
618 Cache-control should be set only on api/runs
619 https://bugs.webkit.org/show_bug.cgi?id=140312
621 Reviewed by Andreas Kling.
623 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
624 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
625 just set cache-control there instead of json-header.php which is used by other JSON APIs.
627 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
629 * public/api/analysis-tasks.php:
630 * public/api/runs.php: Set the cache control headers.
631 * public/api/test-groups.php:
632 * public/include/db.php: Set the default timezone to UTC.
633 * public/include/json-header.php: Don't set the cache control headers.
635 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
637 api/report-commit should authenticate with a slave name and password
638 https://bugs.webkit.org/show_bug.cgi?id=140308
640 Reviewed by Benjamin Poulain.
642 Use a slave name and a password to authenticate new commit reports.
644 * public/api/report-commits.php:
646 * public/include/json-header.php:
647 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
648 a slave name and a password instead of a builder name and a password.
649 * tests/api-report-commits.js: Updated tests.
651 (main): Renamed variables.
652 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
654 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
656 Perf dashboard should support authentication via a slave password
657 https://bugs.webkit.org/show_bug.cgi?id=139837
659 Reviewed by Andreas Kling.
661 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
662 having to add multiple builders with the same password when a single build slave is shared among them.
664 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
666 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
668 * public/admin/build-slaves.php: Added.
670 * public/admin/builders.php: Added the support for updating passwords.
672 * public/include/admin-header.php:
673 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
674 being retrieved from $_POST.
675 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
676 the raw may not exist (e.g. new_password).
677 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
678 control here when this flag evaluates to TRUE.
680 * public/include/report-processor.php:
681 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
682 values are present in the report. In addition, try authenticating builderName with slavePassword if
683 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
684 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
685 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
687 (ReportProcessor::store_report): Store the slave ID with the report.
688 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
689 the matching build is different from what's being reported.
691 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
694 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
696 New perf dashboard should not duplicate author information in each commit
697 https://bugs.webkit.org/show_bug.cgi?id=139756
699 Reviewed by Darin Adler.
701 Instead of each commit having author name and email, make it reference a newly added committers table.
702 Also replace "email" by "account" since some repositories don't use emails as account names.
704 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
705 which only contains as many rows as there are accounts in each repository, instead of commits table
706 which contains every commit ever happened in each repository.
708 To migrate an existing database into match the new schema, run:
712 INSERT INTO committers (committer_repository, committer_name, committer_email)
713 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
714 FROM commits WHERE commit_author_email IS NOT NULL);
716 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
718 UPDATE commits SET commit_committer = committer_id FROM committers
719 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
721 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
722 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
726 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
727 reference to committers. Also added the missing drop table statements.
729 * public/api/commits.php:
730 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
731 an array here instead of doing it in format_commit.
732 (fetch_commits_between): Updated queries to JOIN commits with committers.
733 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
736 * public/api/report-commits.php:
737 (main): Store the reported committer information or update the existing entry if there is one.
739 * tests/admin-regenerate-manifest.js: Fixed tests.
741 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
743 * tools/pull-svn.py: Renamed email to account.
745 (fetch_commit_and_resolve_author):
747 (resolve_author_name_from_account):
748 (resolve_author_name_from_email): Deleted.
750 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
752 Unreviewed build fix.
754 * public/v2/index.html: Include js files we extracted in r177424.
756 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
758 Unreviewed. Adding the forgotten svnprop.
760 * tools/pull-svn.py: Added property svn:executable.
762 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
764 Split InteractiveChartComponent and CommitsViewerComponent into separate files
765 https://bugs.webkit.org/show_bug.cgi?id=139716
767 Rubber-stamped by Benjamin Poulain.
769 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
770 and interactive-chart.js respectively since app.js has gotten really large.
773 * public/v2/commits-viewer.js: Added.
774 * public/v2/interactive-chart.js: Added.
776 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
778 New perf dashboard's chart UI is buggy
779 https://bugs.webkit.org/show_bug.cgi?id=139214
781 Reviewed by Chris Dumez.
783 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
785 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
786 component. This is not how Ember.js components should interact to begin with. The component now exposes
787 selectedPoints and always updates selection instead of sharedSelection.
790 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
791 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
792 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
793 and end time should be completely determined by "since" and the present time.
794 (App.ChartsController._startTimeChanged): Ditto.
795 (App.ChartsController._scheduleQueryStringUpdate):
796 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
798 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
800 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
801 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
802 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
803 observes the changes to selectedPoints property as it gets updated by the main chart.
804 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
805 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
807 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
808 when domain arrays aren't identical. This was causing a subtle race with other logic.
809 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
810 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
811 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
812 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
813 see if those two points correspond to a range or a single data point. Rewrote all that logic by
814 directly observing selectedPoints and currentItem properties instead of taking points and relying on
815 an instance variable, which was a terrible API.
816 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
817 when the main plot has a selected range, we don't have to check this._hasRange anymore.
819 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
820 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
821 (App.InteractiveChartComponent._updateSelection):
822 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
823 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
824 selectedPoints property.
826 (App.AnalysisTaskController._fetchedRuns):
827 (App.AnalysisTaskController._rootChangedForTestSet):
829 * public/v2/index.html:
830 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
832 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
834 Unreviewed. Fixed syntax errors.
837 * public/api/commits.php:
839 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
841 The dashboard on new perf monitor should be configurable
842 https://bugs.webkit.org/show_bug.cgi?id=138994
844 Reviewed by Benjamin Poulain.
846 For now, make it configurable via config.json. We should eventually make it configurable via
847 an administrative page but this will do for now.
849 * config.json: Added the empty dashboard configuration.
851 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
854 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
855 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
856 Also obtain the default configuration from App.Manifest.
857 (App.IndexController._normalizeTable): Moved to App.Dashboard.
859 * public/v2/manifest.js:
860 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
861 (App.Repository.urlForRevisionRange): Ditto.
862 (App.Dashboard): Added.
863 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
864 (App.Dashboard.rows): Ditto.
865 (App.Dashboard.headerColumns): Ditto.
866 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
867 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
868 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
869 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
871 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
873 There should be a way to associate bugs with analysis tasks
874 https://bugs.webkit.org/show_bug.cgi?id=138977
876 Reviewed by Benjamin Poulain.
878 Updated associate-bug.php to match the new database schema.
880 * public/include/json-header.php:
881 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
882 already camel-cased in require_existence_of. This makes the function usable elsewhere.
884 * public/privileged-api/associate-bug.php:
885 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
886 Also verify that those values are integers using require_format.
888 * public/v2/analysis.js:
889 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
890 (App.Bug.label): Added.
891 (App.BugAdapter): Added.
892 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
893 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
895 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
896 containing the bug information.
899 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
900 (App.AnalysisTaskRoute):
901 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
902 (App.AnalysisTaskController._fetchedManifest): Added.
903 (App.AnalysisTaskController.actions.associateBug): Added.
905 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
908 (Measurement.prototype.associateBug): Deleted.
910 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
911 Added a table show the bug information. Also hide the chart until chartData is available.
913 * public/v2/manifest.js:
916 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
918 Fix misc bugs and typos in app.js
919 https://bugs.webkit.org/show_bug.cgi?id=138946
921 Reviewed by Benjamin Poulain.
924 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
925 (App.ChartsController.init):
926 (App.buildPopup): Renamed from App.BuildPopup.
927 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
928 remove() on the wrong object (an array as opposed to elements in the array).
929 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
930 _highlights is always an array and evalutes to true.
932 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
934 New perf dashboard should provide UI to create a new analysis task
935 https://bugs.webkit.org/show_bug.cgi?id=138910
937 Reviewed by Benjamin Poulain.
939 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
940 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
942 With this patch, we can create a new analysis task by selection a range of points and opening
943 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
944 in the chart hyperlinked to the analysis task.
946 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
948 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
949 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
951 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
952 and adds the associated bugs to each task in the array.
955 * public/api/runs.php: Reverted changes made in r175006.
956 (fetch_runs_for_config):
959 * public/api/test-groups.php:
960 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
962 * public/include/db.php:
963 (Database::select_first_or_last_row):
964 (Database::select_rows): Extracted from select_first_or_last_row.
966 * public/v2/analysis.js:
967 (App.AnalysisTask): Added "bugs" property.
968 (App.Bug): Added now that bugs are regular data store objects.
971 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
972 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
973 platform that are associated with a specific range of runs.
974 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
975 (App.PaneController.actions.associateBug): Deleted.
976 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
977 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
978 once we've created one.
979 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
980 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
981 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
982 (App.PaneController._updateBugs): Deleted.
983 (App.PaneController._updateMarkedPoints): Deleted.
984 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
985 the name is missing or when at most one point is selected.
987 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
988 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
989 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
990 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
991 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
992 clickable bars for analysis tasks.
993 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
994 bar for analysis tasks to place them at the right location.
995 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
997 * public/v2/chart-pane.css:
998 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
999 (.chart .rangeBar): Added.
1001 * public/v2/data.js:
1002 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1004 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1005 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1006 task bars in the interactive chart component.
1008 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1010 Fix typos in r176203.
1013 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1014 (App.AnalysisTaskRoute):
1016 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1018 Unreviewed. Updated the install instruction.
1022 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1024 App.Manifest shouldn't use App.__container__.lookup
1025 https://bugs.webkit.org/show_bug.cgi?id=138768
1027 Reviewed by Andreas Kling.
1029 Removed the hack to find the store object via App.__container__.lookup.
1030 Pass around the store object instead.
1033 (App.DashboardRow._createPane): Add "store" property to the pane.
1034 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1035 (App.IndexController.gridChanged): Ditto.
1036 (App.IndexController.actions.addRow): Ditto.
1037 (App.IndexController.init): Ditto.
1038 (App.Pane._fetch): Ditto.
1039 (App.ChartsController._parsePaneList): Ditto.
1040 (App.ChartsController._updateQueryString): Ditto.
1041 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1042 (App.BuildPopup): Ditto.
1043 (App.AnalysisTaskRoute.model): Ditto.
1044 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1046 * public/v2/manifest.js:
1047 (App.Manifest.fetch): Removed the code to find the store object.
1049 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1051 Fix Ember.js warnings the new perf dashboard
1052 https://bugs.webkit.org/show_bug.cgi?id=138531
1054 Reviewed by Darin Adler.
1056 Fixed various warnings.
1059 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1060 * public/v2/data.js:
1061 (PrivilegedAPI._post): Removed the superfluous console.log.
1062 (CommitLogs.fetchForTimeRange): Ditto.
1063 * public/v2/index.html: Added tbody as required by the HTML specification.
1065 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1067 Fix typos in r175768.
1070 (App.AnalysisTaskViewModel.roots):
1072 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1074 Introduce the concept of analysis task to perf dashboard
1075 https://bugs.webkit.org/show_bug.cgi?id=138517
1077 Reviewed by Andreas Kling.
1079 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1080 a single platform and used to bisect regressions in the range.
1082 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1084 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1085 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1086 test runs. Analysis tasks not associated with test runs are used for try new patches.
1087 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1088 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1089 build_requests - A build request represents a single pending build for A/B testing.
1091 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1095 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1096 the specified analysis task group as well as build requests associated with them.
1098 (fetch_test_groups_for_task):
1099 (fetch_build_requests_for_task):
1100 (fetch_build_requests_for_group):
1101 (format_test_group):
1102 (format_build_request):
1104 * public/include/json-header.php:
1105 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1108 * public/privileged-api/associate-bug.php:
1109 (main): Fixed a typo.
1111 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1114 (ensure_config_from_runs):
1116 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1118 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1120 (App.AnalysisTask.create):
1122 (App.TestGroupAdapter):
1123 (App.AnalysisTaskSerializer):
1124 (App.TestGroupSerializer):
1127 * public/v2/app.css: Added style rules for the analysis page.
1130 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1132 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1133 exactly one selected point as we can still create an analysis task.
1134 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1135 grammatical and also alert'ed the error message when there is one.
1136 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1137 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1138 once XHR request has completed.
1139 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1140 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1141 is selected in the details pane.
1143 (App.AnalysisRoute): Added.
1144 (App.AnalysisTaskRoute): Added.
1145 (App.AnalysisTaskViewModel): Added.
1146 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1147 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1148 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1149 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1150 the user selects an option for all roots in A or B configuration.
1151 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1153 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1155 * public/v2/data.js:
1156 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1157 point so that we can use it in App.AnalysisTaskViewModel.roots.
1158 (TimeSeries.prototype.findPointByMeasurementId): Added.
1159 (TimeSeries.prototype.seriesBetweenPoints): Added.
1161 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1162 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1163 when multiple points are selected. Finally, added a new template for the analysis task page.
1165 * public/v2/manifest.js:
1166 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1167 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1168 App.AnalysisTaskViewModel._taskUpdated.
1170 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1172 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1173 https://bugs.webkit.org/show_bug.cgi?id=138111
1175 Reviewed by Darin Adler.
1178 (App.PaneController.bugsChangeCount): Removed.
1179 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1180 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1181 Finds the list of current run's points that are associated with bugs.
1182 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1183 * public/v2/chart-pane.css:
1184 (.chart .marked): Renamed from .hasBugs.
1185 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1187 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1189 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1190 https://bugs.webkit.org/show_bug.cgi?id=138099
1192 Reviewed by Benjamin Poulain.
1194 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1195 _showDetails inverting the order of the current and old measurements.
1198 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1199 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1200 current (latest) measurement and the first point is the oldest measurement.
1201 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1203 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1205 Perf dashboard should provide a way to associate bugs with a test run
1206 https://bugs.webkit.org/show_bug.cgi?id=137857
1208 Reviewed by Andreas Kling.
1210 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1211 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1212 the Apache configuration.
1215 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1216 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1217 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1218 via the cookie and returns a token computed from those two values as well as the remote username.
1220 The font end code then POST's the request along with the returned token. The server side code verifies
1221 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1222 the token hasn't expired.
1225 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1226 have zero or exactly one bug associated with a test run.
1228 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1229 * public/api/runs.php:
1230 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1231 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1232 an associated bug if there is one.
1233 (format_run): Calls parse_bugs_array.
1235 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1236 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1237 have a valid JSON payload.
1238 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1239 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1240 the expiration time stored in the cookie.
1241 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1243 * public/include/manifest.php:
1244 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1245 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1247 * public/index.html:
1248 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1250 * public/privileged-api/associate-bug.php: Added.
1251 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1252 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1254 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1256 * public/v2/app.css:
1257 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1258 selected in a chart.
1261 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1262 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1263 they would overlap on each other if both of them are shown.
1264 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1265 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1266 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1267 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1268 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1269 showing the search pane.
1270 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1271 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1272 bugs in the selected range.
1274 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1275 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1276 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1277 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1278 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1279 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1280 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1281 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1283 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1284 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1285 to selectionChanged action instead of just finding the first and the last points.
1287 * public/v2/chart-pane.css: Updated the style.
1289 * public/v2/data.js:
1290 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1291 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1292 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1293 we haven't already obtained a CSRF token or if the token has already been expired.
1294 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1296 (Measurement.prototype.bugs): Added.
1297 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1298 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1300 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1303 * public/v2/manifest.js:
1304 (App.BugTracker.bugUrl):
1305 (App.BugTracker.newBugUrl): Added.
1306 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1307 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1308 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1309 (App.Manifest.bugTrackers): Added.
1310 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1311 their respective ids to make the ordering stable.
1313 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1315 Remove unused jobs table
1316 https://bugs.webkit.org/show_bug.cgi?id=137724
1318 Reviewed by Daniel Bates.
1320 Removed jobs table in the database as well as related code.
1322 * init-database.sql:
1323 * public/admin/jobs.php: Removed.
1324 * public/admin/tests.php:
1325 * public/include/admin-header.php:
1327 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1329 New perf dashboard should have an ability to search commits by a keyword
1330 https://bugs.webkit.org/show_bug.cgi?id=137675
1332 Reviewed by Geoffrey Garen.
1334 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1335 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1336 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1338 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1339 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1341 * public/api/commits.php:
1342 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1343 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1344 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1345 (format_commit): Renamed from format_commits. Now only formats one commit.
1347 * public/include/db.php:
1348 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1350 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1353 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1354 which is a hash table that contains highlighted items' measurements' ids as keys.
1355 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1356 the default commit repository.
1357 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1358 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1359 Added the code to initialize this._highlights.
1360 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1361 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1362 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1363 the existing lines for the old highlighted items.
1364 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1365 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1367 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1369 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1370 (CommitLogs): Added.
1371 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1372 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1373 (CommitLogs._cacheConsecutiveCommits): Ditto.
1374 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1375 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1376 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1378 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1379 for showingDetails since this property is no longer used.
1381 * public/v2/manifest.js:
1382 (App.Manifest.repositories): Added.
1383 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1384 the default repository to search.
1385 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1387 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1389 Unreviewed build fix after r174555.
1391 * public/include/manifest.php:
1392 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1393 * tests/admin-regenerate-manifest.js: Fixed the test case.
1395 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1397 New perf dashboard UI tries to fetch commits all the time
1398 https://bugs.webkit.org/show_bug.cgi?id=137592
1400 Reviewed by Andreas Kling.
1402 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1403 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1404 no reported commits as they are all going to fail.
1406 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1407 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1408 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1409 of commits sorted chronologically by time.
1411 * public/include/manifest.php:
1414 (App.CommitsViewerComponent.commitsChanged):
1416 * public/v2/data.js:
1417 (FetchCommitsForTimeRange):
1418 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1420 * public/v2/manifest.js:
1423 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1425 Another unreviewed build fix after r174477.
1427 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1429 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1431 * public/include/report-processor.php:
1433 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1435 Unreviewed build fix after r174477.
1437 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1438 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1440 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1441 This is necessary for baseline and target values manually added via admin pages.
1443 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1445 Add v2 UI for the perf dashboard
1446 https://bugs.webkit.org/show_bug.cgi?id=137537
1448 Rubber-stamped by Andreas Kling.
1451 * public/v2/app.css: Added.
1452 * public/v2/app.js: Added.
1453 * public/v2/chart-pane.css: Added.
1454 * public/v2/data.js: Added.
1455 * public/v2/index.html: Added.
1456 * public/v2/js: Added.
1457 * public/v2/js/d3: Added.
1458 * public/v2/js/d3/LICENSE: Added.
1459 * public/v2/js/d3/d3.js: Added.
1460 * public/v2/js/d3/d3.min.js: Added.
1461 * public/v2/js/ember-data.js: Added.
1462 * public/v2/js/ember.js: Added.
1463 * public/v2/js/handlebars.js: Added.
1464 * public/v2/js/jquery.min.js: Added.
1465 * public/v2/js/statistics.js: Added.
1466 * public/v2/manifest.js: Added.
1467 * public/v2/popup.js: Added.
1469 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1471 Remove superfluously duplicated code in public/api/report-commits.php.
1473 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1475 Perf dashboard should store commit logs
1476 https://bugs.webkit.org/show_bug.cgi?id=137510
1478 Reviewed by Darin Adler.
1480 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
1482 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
1483 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
1484 a subversion directory. The git version of this script will be added in a follow up patch.
1487 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
1488 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
1489 relationship via "build_commits" relations.
1491 In order to migrate an existing instance of this application, run the following SQL commands:
1495 INSERT INTO commits (commit_repository, commit_revision, commit_time)
1496 (SELECT DISTINCT ON (revision_repository, revision_value)
1497 revision_repository, revision_value, revision_time FROM build_revisions);
1499 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
1500 FROM commits, build_revisions
1501 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
1503 DROP TABLE build_revisions;
1508 The helper script to submit commit logs can be used as follows:
1510 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
1511 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
1513 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
1514 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
1515 "feeder-slave-password" as the builder name and the builder password respectively.
1517 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
1518 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
1521 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
1523 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
1524 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
1526 - Not specified - It returns every single commit for a given repository.
1527 - Matches "oldest" - It returns the commit with the oldest timestamp.
1528 - Matches "latest" - It returns the commit with the latest timestamp.
1529 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
1530 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
1531 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
1532 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
1533 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
1534 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
1536 (commit_from_revision):
1537 (fetch_commits_between):
1540 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
1541 See tests/api-report-commits.js for examples on how to use this API.
1543 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
1544 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
1545 to optimize this and other JSON APIs.
1547 * public/include/db.php:
1548 (Database::select_or_insert_row):
1549 (Database::update_or_insert_row): Added.
1550 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
1551 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
1553 (Database::select_first_row):
1554 (Database::select_last_row): Added.
1555 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
1556 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
1558 * public/include/report-processor.php:
1559 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
1560 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
1561 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
1564 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
1566 * tests/api-report-commits.js: Added.
1567 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
1570 * tools/pull-svn.py: Added. See above for how to use this script.
1572 (determine_first_revision_to_fetch):
1573 (fetch_revision_from_dasbhoard):
1574 (fetch_commit_and_resolve_author):
1577 (resolve_author_name_from_email):
1580 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
1582 Update Install.md for Mavericks and fix typos
1583 https://bugs.webkit.org/show_bug.cgi?id=137276
1585 Reviewed by Benjamin Poulain.
1587 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
1589 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
1591 Finally, init-database.sql is no longer located inside database directory.
1595 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1597 Report run id's in api/runs.php for the new dashboard UI
1598 https://bugs.webkit.org/show_bug.cgi?id=135813
1600 Reviewed by Andreas Kling.
1602 Include run_id in the generated JSON.
1604 * public/api/runs.php:
1605 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
1608 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1610 Merging platforms mixes baselines and targets into reported data
1611 https://bugs.webkit.org/show_bug.cgi?id=135260
1613 Reviewed by Andreas Kling.
1615 When merging two platforms, move test configurations of a different type (baseline, target)
1616 as well as of different metric (Time, Runs).
1618 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
1619 It's sufficient to detect one such test_runs object.
1621 * public/admin/platforms.php:
1624 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
1626 Merging platforms mixes baselines and targets into reported data
1627 https://bugs.webkit.org/show_bug.cgi?id=135260
1629 Reviewed by Geoffrey Garen.
1631 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
1632 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
1634 * public/admin/platforms.php:
1636 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
1638 Build fix after r171361.
1640 * public/js/helper-classes.js:
1641 (.this.formattedBuildTime):
1643 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
1645 Perf dashboard spends 2s processing JSON data during the page loads
1646 https://bugs.webkit.org/show_bug.cgi?id=135152
1648 Reviewed by Andreas Kling.
1650 In the Apple internal dashboard, we were spending as much as 2 seconds
1651 converting raw JSON data into proper JS objects while loading the dashboard.
1653 This caused the apparent unresponsiveness of the dashboard despite of the fact
1654 charts themselves updated almost instantaneously.
1656 * public/index.html:
1657 * public/js/helper-classes.js:
1658 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
1659 lazily as creating new Date objects and running string replace is expensive.
1660 (TestBuild.formattedTime):
1661 (TestBuild.formattedBuildTime):
1662 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
1663 (PerfTestRuns.addResult): Deleted.
1665 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
1667 Perf dashboard shouldn't show the full git hash
1668 https://bugs.webkit.org/show_bug.cgi?id=135083
1670 Reviewed by Benjamin Poulain.
1672 Detect Git/Mercurial hash by checking the length.
1674 If it's a hash, use the first 8 characters in the label
1675 while retaining the full length to be used in hyperlinks.
1677 * public/js/helper-classes.js:
1678 (.this.formattedRevisions):
1681 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
1683 Add an instruction on how to backup the database.
1684 https://bugs.webkit.org/show_bug.cgi?id=133391
1686 Rubber-stamped by Andreas Kling.
1690 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1692 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
1694 * public/js/helper-classes.js:
1695 (PerfTestRuns.smallerIsBetter):
1697 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1701 * public/common.css:
1703 * public/index.html:
1707 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1709 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
1710 https://bugs.webkit.org/show_bug.cgi?id=131157
1712 Reviewed by Andreas Kling.
1714 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
1715 This allows, for example, adding all metrics such as Arithmetic and Geometric for
1716 a given test suite without also adding its subtests.
1718 * public/index.html:
1722 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1724 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
1725 https://bugs.webkit.org/show_bug.cgi?id=131155
1727 Reviewed by Andreas Kling.
1729 The bug was caused by Chart.attach binding event listeners on plot container on each call.
1730 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
1731 click when attach() has been called even number of times, keeping the tooltip invisible.
1733 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
1734 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
1735 is called for the first time.
1737 * public/index.html:
1739 (Chart..bindPlotEventHandlers):
1741 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1743 WebKitPerfMonitor: Tooltips can be cut off at the top
1744 https://bugs.webkit.org/show_bug.cgi?id=130960
1746 Reviewed by Andreas Kling.
1748 * public/common.css:
1749 (#title): Removed the gradients, box shadows, and border from the header.
1750 (#title h1): Reduce the font size.
1751 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
1752 * public/index.html:
1753 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
1754 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
1755 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
1756 * public/js/helper-classes.js:
1757 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
1758 tooltip extending above y=0.
1760 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1762 WebKitPerfMonitor: Y-axis adjustment is too aggressive
1763 https://bugs.webkit.org/show_bug.cgi?id=130937
1765 Reviewed by Andreas Kling.
1767 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
1768 results. This had two major problems:
1769 1. Two standard deviations can be too small to show the confidence interval for results.
1770 2. Sometimes baseline and target can be more than two standards deviations away.
1772 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
1773 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
1774 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
1775 the margin on each side separately to reduce the empty space on either side.
1777 A more rigorous approach would involve computing least squared value of results with respect to intervals
1778 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
1780 * public/index.html:
1781 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
1782 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
1783 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
1784 We wouldn't see the difference between measured values versus baseline and target values otherwise.
1785 * public/js/helper-classes.js:
1786 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
1787 interval delta cannot be computed.
1788 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
1789 within the given interval.
1790 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
1791 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
1792 (PerfTestRuns..unscaledMeansForAllResults):
1793 (PerfTestRuns.min): Take the confidence interval delta into account.
1794 (PerfTestRuns.max): Ditto.
1795 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
1796 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
1798 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
1800 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
1802 Some CSS tweaks after r166477 and r166479,
1804 * public/index.html:
1806 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1808 WebKitPerfMonitor: Sometimes text inside panes overlap
1809 https://bugs.webkit.org/show_bug.cgi?id=130956
1811 Reviewed by Gyuyoung Kim.
1813 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
1814 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
1815 reduces the total height of the pane and fits more information per screen capita on the dashboard.
1817 * public/index.html: Updated and added a bunch of CSS rules for the new look.
1818 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
1819 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
1820 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
1821 of the build info shown in a chart pane and a tooltip.
1822 (Chart): Made .status a table.
1823 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
1824 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
1825 now that status.text no longer contains it.
1826 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
1828 * public/js/helper-classes.js:
1829 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
1830 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
1831 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
1832 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
1833 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
1834 capital letter; e.g. "MB" instead of "M B".
1836 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1838 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
1839 https://bugs.webkit.org/show_bug.cgi?id=130957
1841 Reviewed by Gyuyoung Kim.
1843 Moved the slider into the header. Also reduced the spacing between the header and platform names.
1844 This reclaims 50px × width of the screen real estate.
1846 * public/common.css:
1847 (#title): Reduced the space below the header from 20px to 10px.
1848 * public/index.html:
1849 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
1850 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
1851 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
1852 real estate between the header and the platform names.
1854 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
1856 Update the install guidelines for perf.webkit.org
1857 https://bugs.webkit.org/show_bug.cgi?id=129895
1859 Reviewed by Ryosuke Niwa.
1861 The current install guideline for perf.webkit.org discourages the use of the installed
1862 Server application. I've actualized the documentation for Mavericks, and modified the
1863 guideline to include the instructions for Server.app also.
1867 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
1869 Update perf.webkit.org json example
1870 https://bugs.webkit.org/show_bug.cgi?id=129907
1872 Reviewed by Andreas Kling.
1874 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
1878 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
1880 Merge database-common.js and utility.js into run-tests.js.
1882 Reviewed by Matthew Hanson.
1884 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
1885 Also moved init-database.sql out of the database directory and removed the directory entirely.
1887 * database: Removed.
1888 * database/database-common.js: Removed.
1889 * database/utility.js: Removed.
1890 * init-database.sql: Moved from database/init-database.sql.
1892 (connect): Moved from database-common.js.
1893 (pathToDatabseSQL): Extracted from pathToLocalScript.
1894 (pathToTests): Moved from database-common.js.
1897 (SerializedTaskQueue): Ditto.
1899 (initializeDatabase):
1900 (TestEnvironment.it):
1901 (TestEnvironment.queryAndFetchAll):
1904 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1906 Remove the dependency on node.js from the production code.
1908 Reviewed by Ricky Mondello.
1910 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
1912 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
1913 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
1914 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
1915 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
1916 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
1918 Also removed the js files that are no longer used.
1920 * config.json: Moved from database/config.json.
1921 * database/aggregate.js: Removed. No longer used.
1922 * database/database-common.js: Removed unused functions, and updated the path to config.json.
1923 * database/process-jobs.js: Removed. No longer used.
1924 * database/sample-data.sql: Removed. We have a much better corpus of data now.
1925 * database/schema.graffle: Removed. It's completely obsolete.
1926 * public/include/db.php: Updated the path to config.json.
1927 * public/include/evaluator.js: Removed.
1929 * public/include/report-processor.php:
1930 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
1931 storing values into $expressions and calling evaluate_expressions_by_node.
1932 (TestRunsGenerator::aggregate_values): Added.
1933 (TestRunsGenerator::compute_caches): Directly compute the caches.
1935 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1937 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
1939 * public/admin/platforms.php:
1940 * public/include/db.php:
1942 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1944 Zoomed y-axis view is ununsable when the last result is an outlier.
1946 Reviewed by Stephanie Lewis.
1948 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
1949 the last result so that the graph looks sane if the last result was an outlier. However, always show
1950 the last result's mean even if it was an outlier.
1952 * public/index.html:
1953 * public/js/helper-classes.js:
1954 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
1955 Also added the ability to cache the unscaled means to avoid recomputation.
1956 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
1957 (PerfTestRuns.max): Ditto.
1958 (PerfTestRuns.sampleStandardDeviation): Ditto.
1959 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
1961 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1965 * public/admin/tests.php:
1966 * public/js/helper-classes.js:
1968 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
1970 Use two standard deviations instead as I mentioned in the mailing list.
1972 * public/index.html:
1974 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1976 The performance dashboard erroneously shows upward arrow for combined metrics.
1978 A single outlier can ruin the zoomed y-axis view.
1980 Rubber-stamped by Antti Koivisto.
1982 * public/index.html:
1983 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
1984 from the latest results' mean.
1985 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
1986 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
1987 (Chart.toggleYAxis):
1988 * public/js/helper-classes.js:
1989 (PerfTestRuns.sampleStandardDeviation): Added.
1990 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
1992 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1994 Don't include the confidence interval when computing the y-axis.
1996 Rubber-stamped by Simon Fraser.
1998 * public/js/helper-classes.js:
2002 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2004 Tiny CSS tweak for tooltips.
2006 * public/index.html:
2008 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2010 Remove the erroneously repeated code.
2012 * public/admin/test-configurations.php:
2014 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2016 <rdar://problem/15704893> perf dashboard should show baseline numbers
2018 Reviewed by Stephanie Lewis.
2020 * public/admin/bug-trackers.php:
2021 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2024 * public/admin/platforms.php:
2025 (merge_list): Ditto.
2027 * public/admin/test-configurations.php: Added.
2028 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2029 build_revisions as they're not meaningful for baseline / target numbers.
2030 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2031 one test run so that we don't accidentally delete a reported test run.
2032 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2033 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2034 and delete existing ones.
2036 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2037 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2038 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2040 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2041 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2042 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2043 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2044 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2046 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2048 * public/include/admin-header.php:
2049 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2050 have id and type sub columns, and each custom column could generate multiple rows.
2052 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2053 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2054 We then proceed to generate the second header row with sub column names.
2056 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2057 which case regular columns need rowspan set to the maximum number of rows.
2059 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2062 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2063 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2064 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2065 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2066 expanded to occupy all sub columns.
2068 * public/include/manifest.php:
2069 (ManifestGenerator::platforms): Don't add the metric more than once.
2071 * public/include/test-name-resolver.php:
2072 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2073 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2074 full metric name later.
2075 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2076 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2077 (TestNameResolver::full_name_for_test): Added.
2078 (TestNameResolver::full_name_for_metric): Added.
2079 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2081 * public/js/helper-classes.js:
2082 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2083 test runs created to set baseline and target points.
2085 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2087 Build fix after r57928. Removed a superfluous close parenthesis.
2089 * public/api/runs.php:
2091 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2093 Unreviewed build & typo fixes.
2095 * public/admin/platforms.php:
2096 * tests/admin-platforms.js:
2098 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2100 <rdar://problem/15704893> perf dashboard should show baseline numbers
2102 Rubber-stamped by Antti Koivisto.
2104 Organize some code into functions in runs.php.
2106 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2108 * public/api/runs.php:
2109 (fetch_runs_for_config): Extracted.
2110 (format_run): Ditto.
2112 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2114 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2116 * database/config.json:
2117 * public/admin/reprocess-report.php:
2118 * public/api/report.php:
2119 * public/api/runs.php:
2120 * public/include/json-header.php:
2122 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2124 Commit yet another forgotten change.
2126 Something went horribly wrong with my merge :(
2128 * database/init-database.sql:
2130 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2132 Commit one more forgotten change. Sorry for making a mess here.
2134 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2136 Commit the forgotten files.
2138 * public/admin/platforms.php: Added.
2139 * tests/admin-platforms.js: Added.
2141 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2143 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2145 Reviewed by Stephanie Lewis.
2147 Added /admin/platforms/ page to hide and merge platforms.
2149 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2150 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2151 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2152 each test configuration a distinct "test run" for each build.
2154 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2155 their test configurations into platform B.
2157 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2158 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2159 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2160 in platform B, in which case R should relate to T_B instead.
2162 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2163 new platform. We then migrate the test configurations of the remaining test runs.
2165 * database/init-database.sql: Added platform_hidden.
2167 * public/admin/platforms.php: Added.
2168 (merge_platforms): Added. Implements the algorithm described above.
2169 (merge_list): Added.
2171 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2172 is hidden since it doesn't do anything.
2174 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2175 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2176 missing it since unchecked checkbox doesn't set the value in $_POST.
2177 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2178 switch statement instead of repeated if's.
2179 (AdministrativePage::render_table): Emit "update-column" for update_field.
2181 * public/include/db.php: Disable warnings when we're not in the debug mode.
2183 * public/include/manifest.php:
2184 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2187 (TestEnvironment.postJSON):
2188 (TestEnvironment.httpGet):
2189 (TestEnvironment.httpPost): Added.
2190 (sendHttpRequest): Set the content type if specified.
2192 * tests/admin-platforms.js: Added tests.
2194 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2196 Extract the code to compute full test names from tests.php.
2198 Reviewed by Stephanie Lewis.
2200 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2201 and paves our way to re-use the code in other pages.
2203 * public/admin/tests.php:
2205 * public/include/db.php:
2206 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2207 tests.php and test-name-resolver.php.
2209 * public/include/test-name-resolver.php: Added.
2210 (TestNameResolver::__construct):
2211 (TestNameResolver::compute_full_name): Moved from tests.php.
2212 (TestNameResolver::map_metrics_to_tests): Ditto.
2213 (TestNameResolver::sort_tests_by_full_name): Ditto.
2214 (TestNameResolver::tests): Added.
2215 (TestNameResolver::test_id_for_full_name): Ditto.
2216 (TestNameResolver::metrics_for_test_id): Ditto.
2217 (TestNameResolver::child_metrics_for_test_id): Ditto.
2218 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2220 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2222 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2224 Reviewed by Stephanie Lewis.
2226 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2228 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2229 but that's sufficient to correct the wrongfully processed reports for now.
2231 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2232 We should eventually add a nice UI to find and reprocess reports.
2234 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2236 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2238 * public/include/report-processor.php: Copied from public/api/report.php.
2239 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2240 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2241 create a new report or authenticate the builder password (the password is never stored in the report).
2242 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2243 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2244 (ReportProcessor::store_report): Ditto.
2246 * tests/admin-reprocess-report.js: Added.
2248 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2250 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2252 Reviewed by Ricky Mondello.
2254 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2255 for the same build number as a single build by ignoring build time. This was necessary to associate
2256 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2257 we use to submit results computed its own "build time" when they're called.
2259 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2260 last week; new reports were wrongfully associated with old build numbers.
2262 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2263 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2264 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2266 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2267 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2268 (builder, build number, build time).
2270 * public/api/report.php:
2271 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2272 when no such build exists. This prevents a report from being associated with a very old build of the same
2275 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2276 a similar bug in the future sooner.
2278 * tests/api-report.js: Added three test cases.
2280 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2282 Merged the upstream changes to db.php
2283 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2285 * public/include/db.php:
2287 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2289 Update other scripts and tests per previous patch.
2291 * public/include/manifest.php:
2292 * tests/admin-regenerate-manifest.js:
2294 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2296 Remove metrics_unit.
2298 Reviewed by Ricky Mondello.
2300 This column is no longer used by the front-end code since r48360.
2302 * database/init-database.sql:
2303 * public/admin/tests.php:
2305 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2307 Unreviewed build fix.
2309 * public/api/report.php:
2311 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2313 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2315 Reviewed by Ricky Mondello.
2317 Support a new alternative format for aggregated results where we have raw values as well as
2318 the list aggregators so that instead of
2319 "metrics": {"Time": ["Arithmetic"]}
2321 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2323 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2324 dashboard and the generated results page, which doesn't know how to aggregate values.
2326 We need to keep the support for the old format because all other existing performance tests
2327 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2328 the old format during the transition.
2330 * public/api/report.php:
2331 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2332 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2334 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2336 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2338 Unreviewed; Tweak the CSS so that chart panes align vertically.
2340 * public/index.html:
2342 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2344 SafariPerfMonitor should support Combined metric.
2346 * public/js/helper-classes.js:
2347 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2348 value as well but assume it to be greater-is-better for now.
2350 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2352 Commit the forgotten init-database change to add iteration_relative_time.
2354 * database/init-database.sql:
2356 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2358 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2360 Reviewed by Ricky Mondello.
2362 Add the support for each value to have a relative time. This is necessary for frame rate history
2363 since a frame rate needs to be associated with a time it was sampled.
2365 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2367 * public/api/report.php:
2368 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2369 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2370 with relative time since taking the average of two frame rates for two subtests taken at two
2371 different times doesn't make any sense.
2372 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2373 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2374 Also exit early with an error if the number of elements in the array is not a pair.
2375 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2377 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2378 iteration_relative_time.
2380 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2382 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2384 Reviewed by Ricky Mondello.
2386 Support that. It's one line change.
2388 * public/api/report.php:
2389 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2390 to match the convention assumed elsewhere.
2391 * tests/api-report.js: Added a test case.
2393 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2395 SafariPerfMonitor shows popups for points outside of the visible region.
2397 Rubber-stamped by Simon Fraser.
2399 * public/index.html:
2400 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2401 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2402 may return an item underneath y-axis labels.
2404 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2406 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2408 * public/index.html:
2410 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2412 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2414 * public/index.html:
2416 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2418 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2419 <rdar://problem/13992271> Should scale Y axis to include error ranges
2421 Reviewed by Ricky Mondello.
2423 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2424 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2426 * database/config.json:
2427 * public/index.html:
2428 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2429 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2430 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2432 * public/js/helper-classes.js:
2433 (PerfTestResult.confidenceIntervalDelta):
2434 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2435 (PerfTestRuns.min): Take confidence interval delta into account.
2436 (PerfTestRuns.max): Ditto.
2437 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2439 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2441 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2443 * public/api/report.php:
2444 (ReportProcessor::recursively_ensure_tests):
2445 * tests/api-report.js: Added a test.
2447 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2449 Unreviewed build fixes.
2451 * public/api/report.php:
2452 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
2453 Also, tolerate reports without any revision information.
2455 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
2458 * tests/api-report.js: Added few test cases.
2460 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2462 Commit another change that was supposed to be committed in r50331.
2465 (TestEnvironment.this.postJSON):
2466 (TestEnvironment.this.httpGet):
2469 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
2471 Commit the remaining files.
2473 * public/admin/regenerate-manifest.php:
2474 * public/include/admin-header.php:
2475 * public/include/json-header.php:
2476 * public/include/manifest.php:
2478 (TestEnvironment.this.postJSON):
2479 (TestEnvironment.this.httpGet):
2482 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
2484 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
2486 Reviewed by Ricky Mondello.
2488 Added some tests for admin/regenerate-manifest.
2490 * public/admin/regenerate-manifest.php: Use require_once instead of require.
2491 * public/include/admin-header.php: Ditto.
2492 * public/include/json-header.php: Ditto.
2494 * public/include/manifest.php:
2495 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
2496 When there are no builders, simply return an empty array.
2499 (TestEnvironment.postJSON):
2500 (TestEnvironment.httpGet): Added.
2501 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
2503 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
2505 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
2507 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
2508 and run_iterations. Also fixed a typo in report.php found by new tests.
2510 * public/api/report.php:
2511 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
2512 * tests/api-report.js: Added more test cases.
2514 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
2516 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
2518 Reviewed by Ricky Mondello.
2520 Add a test runner script and some simple test cases.
2522 * database/config.json: Added the configuration for "testServer".
2523 * database/database-common.js:
2524 (pathToTests): Added.
2525 * run-tests.js: Added.
2528 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
2529 and if there are, asks the user if it’s okay to delete all of the data contained therein.
2530 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
2532 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
2533 in the current database using PostgreSQL's information_schema.
2534 (askYesOrNoQuestion):
2536 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
2538 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
2539 (TestEnvironment.assert): Exposes assert to tests.
2540 (TestEnvironment.console): Exposes console to tests.
2541 (TestEnvironment.describe): Adds a description.
2542 (TestEnvironment.it): Adds a test case.
2543 (TestEnvironment.postJSON):
2544 (TestEnvironment.queryAndFetchAll):
2545 (TestEnvironment.sha256):
2546 (TestEnvironment.notifyDone): Ends the current test case.
2550 (TestContext): An object created for each test case. Conceptually, this object is always on
2551 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
2552 this object via currentTestContext.
2553 (TestContext.description):
2555 (TestContext.logError):
2558 * tests/api-report.js: Added some basic tests for /api/report.php.
2560 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2562 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
2564 The problem was that we were detecting whether we're updating dashboard or not by checking
2565 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
2566 all configurations. Use separate 'dashboard' action to execute the code even when
2567 metric_configurations is empty.
2569 * public/admin/tests.php:
2571 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2573 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
2575 Reviewed by Ricky Mondello.
2577 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
2578 from ReportProcessor as a preparation to replace deprecated aggregate.js.
2580 * public/api/report.php:
2581 (ReportProcessor::exit_with_error): Moved.
2582 (ReportProcessor::process): Use the extracted TestRunsGenerator.
2583 (TestRunsGenerator): Added.
2584 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
2585 (TestRunsGenerator::add_aggregated_metric): Moved.
2586 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
2587 (TestRunsGenerator::aggregate): Moved. Made public.
2588 (TestRunsGenerator::aggregate_current_test_level): Moved.
2589 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
2590 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
2591 (TestRunsGenerator::compute_caches): Moved. Made public.
2592 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
2593 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
2594 (TestRunsGenerator::rollback_with_error): Moved.
2596 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2598 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
2600 Reviewed by Remy Demarest.
2602 Regenerate the manifest file when updating fields or adding new items that are included in
2605 * public/admin/bug-trackers.php:
2606 * public/admin/builders.php:
2607 * public/admin/regenerate-manifest.php:
2608 * public/admin/repositories.php:
2609 * public/admin/tests.php:
2610 * public/include/admin-header.php:
2611 (regenerate_manifest): Extracted from regenerate-manifest.php.
2613 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2615 Unreviewed build fix for memory test results.
2617 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
2618 aggregating at each level.
2620 * public/api/report.php:
2621 (ReportProcessor::recursively_ensure_tests):
2622 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
2623 (ReportProcessor::add_values_for_aggregation):
2624 (ReportProcessor::aggregate):
2625 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
2627 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
2629 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
2630 not the number of iteration groups. Also, don't set group number when the entire run belongs
2631 a single iteration group.
2633 * public/api/report.php:
2634 (ReportProcessor::commit):
2636 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2638 SafariPerfMonitor: Introduce iteration groups
2640 Reviewed by Remy Demarest.
2642 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
2643 the runtime environment variances to get more stable results. And it's desirable to keep track of
2644 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
2646 This patch introduces "iteration groups" to keep track of this extra information.
2648 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
2649 the outer array denotes iteration groups and each inner array contains iteration values for each group.
2652 * database/init-database.sql: Add iteration_group column.
2653 * public/api/report.php:
2654 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
2656 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
2657 contains the list of values indexed by the iteration order and group sizes. Store the group size so
2658 that we can restore the iteration groups before passing it to node.js and restore them later.
2660 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
2661 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
2663 Also check that each iteration group in each subtest are consistent with one another. To see why we need
2664 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
2665 that each iteration group in T1 and T2 have the same size:
2666 T1 = [[1, 2], [3, 4, 5]]
2667 T2 = [[6, 7], [8, 9, 10]]
2669 so that the aggregated result (the sum in this case) can have the same groups as in:
2670 T = [[7, 9], [11, 13, 15]]
2672 If some iteration groups in T1 and T2 had a different size as in:
2673 T1 = [[1, 2, 3], [4, 5]]
2674 T2 = [[6, 7], [8, 9, 10]]
2676 Then iteration groups of the aggregated T is ambiguous.
2678 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
2679 (ReportProcessor::commit): Store iteration_group values.
2681 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2683 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
2684 migrated to perf.webkit.org.
2686 * database/perf-webkit-migrator.js: Removed.
2688 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2690 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
2692 * public/index.html:
2695 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2697 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
2699 Reviewed by Ricky Mondello.
2701 It is often desirable to see charts of a given test for all platforms, or to be able to see
2702 charts of all subtests on a given platform when trying to triage perf. regressions.
2704 Support this use case by adding the ability to do so on the charts page.
2706 Also, we used to disable items on the test list based on the platform chosen. This turned out
2707 to be a bad UI because in many situations you want to be able to compare results of the same test
2708 on multiple platforms.
2710 In this new UI, we have three select elements, each of which selects the following:
2711 1. Top-level test - Test suite such as Dromaeo
2712 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
2713 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
2714 3. Platform - Mountain Lion, Qt, etc...
2716 A user can select "all" for metric and platform but we disallow doing both at once since adding
2717 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
2718 think of a use case where you want to look at that many charts at once. We can support this later
2719 if valid use cases come up.
2721 * public/index.html:
2722 (.showCharts.addOption): Extracted.
2723 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
2724 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
2725 metricList has onchange handler that enables/disables items on platformList.
2727 (init): Sort tests and test metrics here instead of doing that in showCharts.
2729 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
2731 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
2733 Reviewed by Remy Demarest and Ricky Mondello.
2735 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
2736 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
2737 templates to the manifest file instead. Each build now only contains the builder id.
2739 * public/api/runs.php: Removed the part of the query that joined builders table. This
2740 speeds up the query quite a bit.
2742 * public/include/manifest.php:
2743 (ManifestGenerator::generate): Generate builders field.
2744 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
2745 associative array that contains name and its build URL template.
2747 * public/index.html:
2748 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
2749 instead of a revision since this function is used for revisions and build page URLs now.
2750 (.buildLabelWithLinks): Include the linkified build number.
2752 * public/js/helper-classes.js:
2753 (TestBuild.builder): Added.
2754 (TestBuild.buildNumber): Added.
2755 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
2756 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
2758 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
2760 Tooltips interfere with user interactions
2762 Rubber-stamped by Simon Fraser.
2764 Disable tooltip on the dashboard page since graphs are too small to be useful there.
2765 Also, show graphs for only 10 days by default as opposed to 20.
2766 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
2768 * public/index.html:
2769 * public/js/helper-classes.js:
2771 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
2773 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
2774 to be compatible with webkit-perf.appspot.com.
2776 * public/admin/builders.php:
2777 * public/api/report.php:
2779 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
2783 Add a missing constraint on builds table. For a given builder, there should be exactly
2784 one build for a given build number.
2786 Also add report_committed_at to reports table to record the time at which a given report
2787 was processed and test_runs and run_iterations rows were committed into the database.
2789 * database/config.json:
2790 * public/api/report.php:
2792 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
2794 Unreviewed. Add more checks for empty SQL query results.
2796 * public/include/manifest.php:
2798 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2800 More build fixes on perf.webkit.org.
2802 * public/api/runs.php: Make PostgreSQL happier.
2803 * public/include/manifest.php: Don't assume we always have bug trackers.
2805 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2807 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
2808 and fix other miscellaneous UI bugs.
2810 Rubber-stamped by Simon Fraser.
2812 Removed the code to determine whether smaller value is better or not for a given test in index.html
2813 in the favor of using that of PerfTestRuns.
2815 * public/include/manifest.php: Fixed a typo.
2816 * public/index.html:
2818 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
2820 * public/js/helper-classes.js:
2821 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
2823 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
2824 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
2825 at roughly 2,000 units to avoid this.
2827 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
2828 The only thing we can avoid is innerHTML.
2830 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2832 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
2834 * public/include/evaluator.js:
2836 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2838 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
2840 Reviewed by Remy Demarest.
2842 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
2843 admin/bug-trackers.php and can be associated with multiple repositories.
2845 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
2846 to determine the set of bug trackers to show for a given set of blame lists.
2847 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
2848 a place to file bugs against the regression.
2850 * database/init-database.sql: Added bug_trackers and tracker_repositories.
2851 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
2853 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
2854 bug trackers, namely associated repositories.
2856 * public/include/admin-header.php: Added a link to bug-trackers.php
2857 * public/include/manifest.php:
2858 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
2859 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
2861 (ManifestGenerator::repositories):
2863 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
2864 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
2865 'repositories' where the latter contains the list of associated repository names.
2867 * public/index.html:
2868 (Chart): Takes bugTrackers as as argument.
2869 (Chart.showTooltipWithResults): Removed the hard-coded list.
2871 (init.addPlatformsToDashboard):
2872 (init.showCharts.createChartFromListPair):
2873 (init): Stores the list of bug trackers in the manifest to a local variable.
2875 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2877 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
2879 * public/include/evaluator.js:
2881 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2883 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
2885 Reviewed by Remy Demarest.
2887 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
2888 new row into the database.
2890 * public/admin/aggregators.php: Use AdministrativePage.
2891 * public/admin/builders.php: Ditto.
2892 * public/admin/repositories.php: Ditto.
2893 * public/include/admin-header.php:
2894 (AdministrativePage): Added.
2895 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
2896 to an associative array that describes the column.
2897 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
2898 - label: Human readable name of the column.
2899 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
2900 column exists only before we create password_hash column at the insertion time.
2902 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
2903 titlecase (e.g. new_bug is converted to New Bug).
2904 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
2905 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
2906 textarea for a given editing mode ('text', 'url', or 'string').
2907 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
2908 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
2910 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
2912 Build fix. Some systems don't support r+. Use proc_open instead.
2914 * public/api/report.php:
2916 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2918 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
2919 when computing the y-axis of data points to show tooltips at.
2921 * public/index.html:
2923 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2925 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
2928 * public/.htaccess: Removed.
2930 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
2934 * public/include/manifest.php: Build fix. db is on this.
2935 * public/js/statistics.js:
2936 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
2938 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
2940 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
2942 Reviewed by Anders Carlsson.
2944 Rewrote and merged populate-from-report.js into report.php.
2946 * database/config.json: Added a path to node.js.
2948 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
2949 Once we land this patch and update the administrative pages, we can remove this column.
2951 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
2952 that table is going away once we remove the node.js backend.
2954 * database/populate-from-report.js: Removed.
2955 * public/api/report.php: Added.
2957 (ReportProcessor.__construct):
2958 (ReportProcessor.process):
2960 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
2961 verified to be submitted by a known builder.
2963 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
2964 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
2965 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
2966 inside a transaction because there could be multiple reports for a single build, each containing results for
2969 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
2970 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
2971 add_values_to_commit, and add_values_for_aggregation.
2973 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
2974 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
2975 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
2978 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
2979 to be aggregated in ReportProcessor.aggregate.
2981 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
2983 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
2984 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
2985 given for each row (child metrics of M). This function extracts each column (iteration) via
2986 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
2987 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
2989 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
2990 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
2991 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
2993 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
2994 (ReportProcessor.evaluate_expressions_by_node): See above.
2996 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
2997 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
2998 results also need the said caches.
3000 (ReportProcessor.add_values_to_commit):
3002 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
3003 the transaction as needed if anything goes wrong.
3005 (ReportProcessor.rollback_with_error)
3007 * public/include/db.php:
3008 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
3009 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
3010 contiguously in a SQL statement.
3012 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
3013 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
3014 a column value of the choice.
3016 (Database.begin_transaction): Added.
3017 (Database.commit_transaction): Added.
3018 (Database.rollback_transaction): Added.
3020 * public/include/evaluator.js: Added.
3021 * public/include/json-header.php:
3022 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
3023 context under which the request failed.
3024 (successful_exit): Merge "additional details".
3025 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
3026 (merge_additional_details):
3028 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
3030 SafariPerfMonitor: Add more helper functions to db.php
3032 Reviewed by Remy Demarest.
3034 Added Database::insert_row and array_get to make common database operations easier.
3036 * public/admin/aggregators.php: Use Database::insert_row instead of
3037 execute_query_and_expect_one_row_to_be_affected.
3039 * public/admin/builders.php: Ditto.
3041 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
3042 inserting a row. With insert_row, we don't need that.
3044 * public/include/admin-header.php: Ditto.
3046 * public/include/db.php:
3047 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
3048 return the default value (defaults to NULL) if the key doesn't exist.
3050 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
3053 (Database::prepare_params): Added. Takes an associative array of column names and their values,
3054 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
3055 column names all in the same order.
3057 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
3058 the given prefix. Values are given in a form of an associative array where keys are unprefixed
3059 column names and values are corresponding values. When the row is successfully inserted, it returns
3060 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
3061 indicating the success of the insertion.
3063 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3065 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
3067 Reviewed by Conrad Shultz.
3069 Rewrote the manifest generator in PHP.
3071 * database/generate-manifest.js: Removed.
3072 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
3073 * public/include/db.php:
3074 (array_ensure_item_has_array): Added.
3075 * public/include/evaluator.js: Added.
3076 * public/include/json-header.php:
3077 * public/include/manifest.php: Added.
3079 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3081 Dates on overflow plot are overlapping
3083 Rubber-stamped by Simon Fraser.
3085 Don't show more than 5 days.
3087 * public/index.html:
3088 * public/js/helper-classes.js:
3089 (TestBuild.UTCtoPST):
3092 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3094 Show build time as well as commit time on the dashboard and tooltips.
3096 Rubber-stamped by Simon Fraser.
3098 Include both the maximum commit time and build time in buildLabelWithLinks.
3099 Also use ISO format to save the screen real estate.
3101 * public/index.html:
3102 (buildLabelWithLinks):
3103 * public/js/helper-classes.js:
3105 (TestBuild.buildTime):
3106 (TestBuild.formattedBuildTime):
3108 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
3110 Unreviewed; Convert metric.name to metric.unit in the front end.
3112 * public/js/helper-classes.js:
3114 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3116 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
3118 Rubber-stamped by Simon Fraser.
3120 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
3121 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
3122 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
3124 * public/index.html:
3125 (.buildLabelWithLinks): Extracted from TestBuild.label.
3126 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
3127 on Radar and WebKit Bugzilla.
3128 * public/js/helper-classes.js:
3129 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
3130 (PerfTestResult.isBetterThan): Added.
3131 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
3132 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
3133 to indicate progressions or regressions.
3134 (PerfTestResult.label):
3135 (TestBuild.formattedTime): Added.
3136 (TestBuild.platform): Added.
3137 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
3138 (TestBuild.smallerIsBetter): Added.
3139 (Tooltip.show): Take a raw markup instead of two results.
3141 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
3143 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
3145 Rubber-stamped by Tim Horton.
3147 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
3148 since each platform may have a different number of tests to be shown on the dashboard.
3150 * public/index.html:
3152 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3154 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
3156 * public/js/helper-classes.js:
3159 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3161 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
3163 Rubber-stamped by Tim Horton.
3165 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
3167 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
3168 the revision r1234 was the revision used in the previous build.
3170 * public/api/runs.php:
3171 (parse_revisions_array): Trim double quotations around repository names and revisions.
3172 * public/js/helper-classes.js:
3175 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3177 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
3179 Rubber-stamped by Tim Horton.
3181 * public/index.html:
3182 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
3183 on the dashboard page as it's way too noisy.
3185 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
3187 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
3188 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
3189 so that the tooltip for hover can be reused further.
3191 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
3192 and find the first point that lies on the right of the cursor position. We then compute the midpoint
3193 between this and the previous point and pick the closer of the two. It returns an item-like object
3194 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
3196 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
3198 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
3199 the first or "current" data points (as opposed to target or baseline data points).
3201 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
3202 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
3203 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
3205 * public/js/helper-classes.js:
3206 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this