1 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
3 Build fix. Use POSIX timestamp instead of human readable string for the commit time.
5 * public/include/build-requests-fetcher.php:
7 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
9 UI to associate bugs with an analysis task is crappy
10 https://bugs.webkit.org/show_bug.cgi?id=145198
12 Reviewed by Andreas Kling.
14 Make the UI less crappy by linkifying bug numbers and adding an explicit button to disassociate
15 a bug and a separate select view with a text field to associate a new bug instead of implicitly
16 updating or deleting the existing record based on what the user had typed.
18 * init-database.sql: Removed the constraint that each bug tracker should appear exactly once for
19 a given analysis task since it's perfectly reasonable for a given task to be associated with
22 * public/privileged-api/associate-bug.php:
23 (main): Only remove the bug specified by newly added bugToDelete instead of implicitly deleting
24 one that matches the analysis task and the bug tracker when the bug number is falsey.
26 * public/v2/analysis.js:
28 (App.BugAdapter.deleteRecord): Added. Uses the privileged API to delete the record.
33 (App.AnalysisTaskController.actions.addBug): Added.
34 (App.AnalysisTaskController.actions.deleteBug): Added.
35 (App.AnalysisTaskController.associateBug): Deleted.
37 * public/v2/index.html: Updated the templates.
39 * public/v2/manifest.js:
40 (App.BugTracker.urlFromBugNumber): Added.
42 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
44 A/B testing rootSets should provide commit times as well as revisions
45 https://bugs.webkit.org/show_bug.cgi?id=145207
47 Reviewed by Andreas Kling.
49 Some continuous build systems need the commit time as well as the revision number / hash so provide one
50 in the root sets but maintain the backwards compatibility with buildbots that use revision number directly.
52 * public/include/build-requests-fetcher.php:
53 (BuildRequestsFetcher::fetch_roots_for_set): Made the revision info an associative array that contains
54 the revision number as well as the commit time.
55 * tools/sync-with-buildbot.py:
56 (schedule_request): Removed "replacement" which was a superfluous copy of "roots". Use "revision" values
57 when the JSON configuration refers to "root". This is necessary in buildbot instances that require WebKit
58 revision to be specified on its own field instead of it being a JSON that contains "revision" and "time".
60 2015-05-19 Ryosuke Niwa <rniwa@webkit.org>
62 Build fix. Don't fall into an infinite loop when value (renamed from bytes) is zero.
64 * public/v2/manifest.js:
65 (App.Manifest.Ember.Controller.extend.):
66 (App.Manifest.Ember.Controller.extend):
68 2015-05-19 Ryosuke Niwa <rniwa@webkit.org>
70 Don't show unit (bytes) separaetly from SI suffixes (K, M, etc...)
71 https://bugs.webkit.org/show_bug.cgi?id=145181
73 Rubber-stamped by Chris Dumez.
75 Show 'MB' in each y-axis label instead of showing 'bytes' separately and suffixing each label with just 'M'
76 for clarity. This change also reduces the code complexity.
80 (App.AnalysisTaskController._chartDataChanged):
81 (App.TestGroupPane._createConfigurationSummary):
83 (RunsData.unitFromMetricName): Use 'B' instead of 'bytes' as the unit.
85 * public/v2/interactive-chart.js: Removed the support for showing units separately.
86 (App.InteractiveChartComponent._constructGraphIfPossible):
87 (App.InteractiveChartComponent._relayoutDataAndAxes)
89 * public/v2/manifest.js:
90 (App.Manifest._makeFormatter): Renamed from _formatBytes. Support more SI suffixes such as micro and mili.
91 Now takes the unit as the first argument. Adjust the base unit if it's 'ms'.
92 (App.Manifest._formatFetchedData): Removed unit and formatWithUnit now that all all formatters would
93 automatically include unit.
95 2015-05-18 Ryosuke Niwa <rniwa@webkit.org>
97 REGRESSION: v2 UI reports a higher memory usage
98 https://bugs.webkit.org/show_bug.cgi?id=145151
100 Reviewed by Chris Dumez.
102 The bug was caused by v2 UI using 1000 to divide the number of bytes instead of by 1024 as done in v1.
103 Fixed the bug by manually implementing the formatter as done in v1.
105 * public/v2/manifest.js:
106 (App.Manfiest._formatBytes): Added.
107 (App.Manifest._formatFetchedData): Use _formatByte instead of format('s').
109 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
111 Unreviewed build fix. Add "Duration" as a time metric.
113 * public/js/helper-classes.js:
115 (RunsData.unitFromMetricName):
117 2015-05-06 Ryosuke Niwa <rniwa@webkit.org>
119 Perf dashboard treats Speedometer and JetStream as smaller is better
120 https://bugs.webkit.org/show_bug.cgi?id=144711
122 Reviewed by Chris Dumez.
124 Added the support for "Score" metric.
126 * public/js/helper-classes.js:
129 (RunsData.unitFromMetricName):
130 (RunsData.isSmallerBetter):
132 2015-04-23 Ryosuke Niwa <rniwa@webkit.org>
134 Build fix after r183232.
136 * public/include/json-header.php:
138 2015-04-23 Ryosuke Niwa <rniwa@webkit.org>
140 Perf dashboard should automatically detect regressions
141 https://bugs.webkit.org/show_bug.cgi?id=141443
143 Reviewed by Anders Carlsson.
145 Added a node.js script detect-changes.js to detect potential regressions and progressions
146 on the graphs tracked on v2 dashboards.
148 * init-database.sql: Added analysis_strategies table and task_segmentation and task_test_range
149 columns to analysis_tasks to keep the segmentation and test range selection strategies used
150 to create an analysis task.
152 * public/api/analysis-tasks.php:
153 (format_task): Include task_segmentation and analysis_tasks in the results.
155 * public/include/json-header.php:
156 (remote_user_name): Returns null when the privileged API is authenticated as a slave instead
157 of a CSRF prevention token.
158 (should_authenticate_as_slave): Added.
159 (ensure_privileged_api_data_and_token_or_slave): Added. Authenticate as a slave if slaveName
160 and slavePassword are specified. Since detect-changes.js and other slaves are not susceptible
161 to a CSRF attack, we don't need to check a CSRF token.
163 * public/privileged-api/create-analysis-task.php:
164 (main): Use ensure_privileged_api_data_and_token_or_slave to let detect-changes.js create new
165 analysis task. Also add or find segmentation and test range selection strategies if specified.
167 * public/privileged-api/create-test-group.php:
168 (main): Use ensure_privileged_api_data_and_token_or_slave.
170 * public/privileged-api/generate-csrf-token.php:
173 (App.Pane._computeMovingAverageAndOutliers): _executeStrategy has been moved to Statistics.
175 * public/v2/data.js: Export Measurement, RunsData, TimeSeries. Used in detect-changes.js.
176 (Array.prototype.find): Added a polyfill to be used in node.js.
177 (RunsData.fetchRuns):
178 (RunsData.pathForFetchingRuns): Extracted from fetchRuns. Used in detect-changes.js.
179 (RunsData.createRunsDataInResponse): Extracted from App.Manifest._formatFetchedData to use it
180 in detect-changes.js.
181 (RunsData.unitFromMetricName): Ditto.
182 (RunsData.isSmallerBetter): Ditto.
183 (RunsData.prototype._timeSeriesByTimeInternal): Added secondaryTime to sort points when commit
185 (TimeSeries): When commit times are identical, order points based on build time. This is needed
186 for when we trigger two builds at two different OS versions with the same WebKit revision since
187 OS versions don't change the commit times.
188 (TimeSeries.prototype.findPointByIndex): Added.
189 (TimeSeries.prototype.rawValues): Added.
191 * public/v2/js/statistics.js:
192 (Statistics.TestRangeSelectionStrategies.[0]): Use the 99% two-sided probability as claimed in the
193 description of this strategy instead of the default probability. Also fixed a bug that debugging
194 code was referring to non-existent variables.
195 (Statistics.executeStrategy): Moved from App.Pane (app.js).
197 * public/v2/manifest.js:
198 (App.Manifest._formatFetchedData): Various code has been extracted into RunsData in data.js to be
199 used in detect-changes.js.
201 * tools/detect-changes.js: Added. The script fetches the manifest JSON, analyzes each graph in
202 the v2 dashboards, and creates an analysis task for the latest regression or progression detected.
203 It also schedules an A/B testing if possible and notifies another server; e.g. to send an email.
204 (main): Loads the settings JSON specified in the argument.
205 (fetchManifestAndAnalyzeData): The main loop that periodically wakes up to do the analysis.
206 (mapInOrder): Executes callback sequentially (i.e. blocking) on each item in the array.
207 (configurationsForTesting): Finds every (platform, metric) pair to analyze in the v2 dashbaords,
208 and computes various values for when statistically significant changes are detected later.
209 (analyzeConfiguration): Finds potential regressions and progression in the last X days where X
210 is the specified maximum number of days using the specified strategies. Sort the resultant ranges
211 in chronological order and create a new analysis task for the very last change we detected. We'll
212 eventually create an analysis task for all detected changes since we're repeating the analysis in
213 fetchManifestAndAnalyzeData after some time.
214 (computeRangesForTesting): Fetch measured values and compute ranges to test using the specified
215 segmentation and test range selection strategies. Once ranges are found, find overlapping analysis
216 tasks as they need to be filtered out in analyzeConfiguration to avoid creating multiple analysis
217 tasks for the same range (e.g. humans may create one before the script gets to do it).
218 (createAnalysisTaskAndNotify): Create a new analysis task for the specified range, trigger an A/B
219 testing if available, and notify another server with a HTML message as specified.
220 (findStrategyByLabel):
221 (changeTypeForRange): A change is a regression if values are getting larger in a smaller-is-better
222 test or values are getting smaller in a larger-is-better test and vice versa.
223 (summarizeRange): Create a human readable string that summarizes the change detected. e.g.
224 "Potential 3.2% regression detected between 2015-04-20 12:00 and 17:00".
228 (postNotification): Recursively replaces $title and $massage in the specified JSON template.
229 (instantiateNotificationTemplate):
232 2015-04-20 Ryosuke Niwa <rniwa@webkit.org>
234 Perf dashboard should have UI to set status on analysis tasks
235 https://bugs.webkit.org/show_bug.cgi?id=143977
237 Reviewed by Chris Dumez.
239 Added the UI to set the result of an analysis task to 'progression', 'regression', 'unchanged', and 'inconclusive'
240 as well as a boolean indicating whether creating the analysis task was the right thing to do or not.
241 The latter will be a useful metric once we start automatically creating analysis tasks.
243 * init-database.sql: Added two columns to analysis_tasks table.
244 * public/api/analysis-tasks.php: Include the added columns in the JSON.
245 * public/include/db.php:
246 (Database::to_database_boolean): Added.
247 * public/include/json-header.php:
248 (require_match_one_of_values): Added.
249 * public/privileged-api/update-analysis-task.php: Added. Updates 'result' and 'needed' values of an analysis task.
251 * public/v2/analysis.js:
252 (App.AnalysisTask.result): Added.
253 (App.AnalysisTask.needed): Added. We don't use DS.attr('boolean') here since that would coerce null into false
254 and we want to differentiate null from false in order to differentiate the null-ness of the value.
255 (App.AnalysisTask.saveStatus): Added.
256 (App.AnalysisTask.statusLabel): Use 'result' as the label if it's set and all build requests have been processed.
259 (App.AnalysisTaskController.analysisResultOptions): Added.
260 (App.AnalysisTaskController.shouldNotHaveBeenCreated): Added.
261 (App.AnalysisTaskController.needsFeedback): Added. Show the checkbox to indicate the analysis task should not have
262 been created if 'no change' is selected.
263 (App.AnalysisTaskController._updateChosenAnalysisResult): Added.
264 (App.AnalysisTaskController.actions.saveStatus): Added.
265 * public/v2/index.html: Extracted a partial template for updating the bug numbers. Also added the UI to update
266 'result' and 'needed' values of the analysis task.
268 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
270 Unreviewed build fix. Updated config.json after recent changes.
274 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
276 Make the analysis page more useful
277 https://bugs.webkit.org/show_bug.cgi?id=143617
279 Reviewed by Chris Dumez.
281 * public/api/analysis-tasks.php:
282 (fetch_and_push_bugs_to_tasks): Added total and finished numbers of build requests associated
283 with the fetched analysis tasks as buildRequestCount and finishedBuildRequestCount respectively.
284 * public/v2/analysis.js:
285 (App.AnalysisTask.formattedCreatedAt): Added.
286 (App.AnalysisTask._addLeadingZero): Added.
287 (App.AnalysisTask.buildRequestCount): Added.
288 (App.AnalysisTask.finishedBuildRequestCount): Added.
289 (App.AnalysisTask.statusLabel): Added. Status total and finished numbers of build requests.
290 (App.AnalysisTask.testGroups):
291 (App.AnalysisTask.triggerable):
292 (App.AnalysisTask.label):
294 * public/v2/app.css: Tweaked style rules for the analysis page.
297 (App.buildPopup): Sort the list of platforms by name.
298 (App.AnalysisRoute.model): Sort the list of analysis tasks by the order they are created.
299 (App.AnalysisTaskController._fetchedManifest): Added elementId to associate bug tracker names
300 such as "Bugzilla" with the corresponding text field.
302 * public/v2/index.html: Added a bunch of columns to the analysis page and also wrapped the table
303 showing A/B testing results in a div with overflow: scroll so that it always leaves enough space
304 for the accompanying graph.
306 2015-04-09 Ryosuke Niwa <rniwa@webkit.org>
308 Perf dashboard should automatically select ranges for A/B testing
309 https://bugs.webkit.org/show_bug.cgi?id=143580
311 Reviewed by Chris Dumez.
313 Added a new statistics option for picking a A/B test range selection strategy.
314 The selected ranges are shown in the graph using the same UI to show analysis tasks.
317 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Updated the query parameters for
318 charts page used by the dashboard since we've added a new parameter at the end.
319 (App.Pane.ranges): Added. Merges ranges created for analysis tasks and A/B testing.
320 (App.Pane.updateStatisticsTools): Clone and set the test range selection strategies.
321 (App.Pane._cloneStrategy): Copy isSegmentation.
322 (App.Pane._updateMovingAverageAndEnvelope): Set testRangeCandidates.
323 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Update the charts when a new text range
324 selection strategy is picked by the user.
325 (App.Pane._computeMovingAverageAndOutliers): Compute the test ranges using the chosen strategy.
326 Avoid going through isAnomalyArray when no anomaly detection strategy is enabled. Also changed
327 the return value from the moving average time series to a dictionary that contains the moving
328 average time series, a dictionary of anomalies, and an array of test ranges.
329 (App.ChartsController._parsePaneList): Parse the test range selection strategy configuration.
330 (App.ChartsController._serializePaneList): Ditto for serialization.
331 (App.ChartsController._scheduleQueryStringUpdate): Update the URL hash when the user picks a new
332 test range selection strategy.
334 * public/v2/chart-pane.css: Fixed a typo as well as added a CSS rule for test ranges markers.
336 * public/v2/index.html: Added UI for selecting a test range selection strategy.
338 * public/v2/interactive-chart.js:
339 (App.InteractiveChartComponent._rangesChanged): Pass down "status" to be used as a class name.
341 * public/v2/js/statistics.js:
342 (Statistics.MovingAverageStrategies): Added isSegmentation to segmentation strategies.
343 (Statistics.TestRangeSelectionStrategies): Added.
345 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
347 The results of A/B testing should state statistical significance
348 https://bugs.webkit.org/show_bug.cgi?id=143552
350 Reviewed by Chris Dumez.
352 Added statistical comparisons between results for each configuration on analysis task page using
353 Welch's t-test. The probability as well as t-statistics and the degrees of freedoms are reported.
356 (App.TestGroupPane._populate): Report the list of statistical comparison between every pair of
357 root configurations in the results. e.g. if we've got A, B, C configurations then compare A/B, A/C
359 (App.TestGroupPane._computeStatisticalSignificance): Compute the statistical significance using
360 Welch's t-test. Report the probability by which two samples do not come from the same distribution.
361 (App.TestGroupPane._createConfigurationSummary): Include the array of results for this configuration.
362 Also renamed "items" to "requests" for clarity.
364 * public/v2/index.html: Added the template for showing statistical comparisons.
366 * public/v2/js/statistics.js: Renamed tDistributionQuantiles to tDistributionByOneSidedProbability
367 for clarity. Also factored out the functions to convert from one-sided probability to two-sided
368 probability and vice versa.
369 (Statistics.supportedConfidenceIntervalProbabilities):
370 (Statistics.confidenceIntervalDelta):
371 (Statistics.probabilityRangeForWelchsT): Added. Computes the lower bound and the upper bound for
372 the probability that two values are sampled from distinct distributions using Welch's t-test.
373 (Statistics.computeWelchsT): This function now takes two-sided probability like all other functions.
374 (.tDistributionByOneSidedProbability): Renamed from tDistributionQuantiles.
375 (.oneSidedToTwoSidedProbability): Extracted.
376 (.twoSidedToOneSidedProbability): Extracted.
377 (Statistics.MovingAverageStrategies): Converted the one-sided probability to the two-sided probability
378 now that computeWelchsT takes two-sided probability.
380 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
382 Unreviewed fix after r182496 for when the cached runs JSON doesn't exist.
386 (App.Pane.refetchRuns):
388 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
390 Perf dashboard should have a way of marking outliers
391 https://bugs.webkit.org/show_bug.cgi?id=143466
393 Reviewed by Chris Dumez.
395 Address kling's in-person comment to notify users when the new run status is saved in the database.
398 (App.PaneController._selectedItemIsMarkedOutlierDidChange)
399 * public/v2/chart-pane.css: Fixed a typo.
401 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
403 Perf dashboard should have a way of marking outliers
404 https://bugs.webkit.org/show_bug.cgi?id=143466
406 Reviewed by Chris Dumez.
408 Added UI to mark a data point as an outlier as well as a button to toggle the visibility of outliers.
409 Added a new privileged API /privileged-api/update-run-status to store this boolean flag.
411 * init-database.sql: Added run_marked_outlier column to test_runs table.
413 * public/admin/tests.php:
415 * public/api/runs.php:
416 (main): Only emit Cache-Control and Expires headers in v1 UI.
417 (RunsGenerator::format_run): Emit markedOutlier.
419 * public/include/admin-header.php:
421 * public/include/db.php:
422 (Database::is_true): Made it static.
424 * public/include/manifest.php:
425 (Manifest::platforms):
427 * public/index.html: Call into /api/runs/ with ?cache=true.
429 * public/privileged-api/update-run-status.php: Added.
430 (main): Updates the newly added column in test_runs table.
434 (App.Pane.refetchRuns): Extracted from App.Pane._fetch.
435 (App.Pane._didFetchRuns): Renamed from _updateChartData.
436 (App.Pane._setNewChartData): Added. Pick the right time series based based on the value of showOutlier.
437 Cloning chartData is necessary when toggling the outlier visibility or using statistics tools because
438 the interactive chart component only observes changes to chartData and not individual properties of it.
439 (App.Pane._highlightPointsMarkedAsOutlier): Added. Highlight points marked as outliers.
440 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Call to _setNewChartData replaced the code to
441 clone chartData here.
443 (App.PaneController.actions.toggleShowOutlier): Toggle the visibility of points marked as outliers by
444 invoking App.Pane._setNewChartData.
445 (App.PaneController._detailsChanged): Don't hide the analysis pane when details changed since keep
446 opening the pane for marking points as outliers would be annoying.
447 (App.PaneController._updateCanAnalyze): Update 'cannotMarkOutlier' as well as 'cannotAnalyze'.
448 (App.PaneController.selectedMeasurement): Added.
449 (App.PaneController.showOutlierTitle): Added.
450 (App.PaneController._selectedItemIsMarkedOutlierDidChange): Added. Call out to setMarkedOutlier to
451 mark the selected point as an outlier via the newly added privileged API.
453 * public/v2/chart-pane.css: Updated styles.
456 (PrivilegedAPI._post): Report the semantic errors.
457 (Measurement.prototype.markedOutlier): Added.
458 (Measurement.prototype.setMarkedOutlier): Added. Uses PrivilegedAPI to update the database.
459 (RunsData.prototype.timeSeriesByCommitTime): Added a new argument, includeOutliers, to indicate
460 whether the time series should include measurements marked as outliers or not.
461 (RunsData.prototype.timeSeriesByBuildTime): Ditto.
462 (RunsData.prototype._timeSeriesByTimeInternal): Extracted from timeSeriesByCommitTime and
463 timeSeriesByBuildTime to share code. Now ignores measurements marked as outliers if needed.
465 * public/v2/index.html: Added an icon for showing and hiding outliers. Also added a checkbox to
466 mark individual points as outliers.
468 * public/v2/interactive-chart.js:
469 (App.InteractiveChartComponent._selectClosestPointToMouseAsCurrentItem): Re-enable the distance
470 heuristics that takes vertical closeness into account. This heuristics is more useful when marking
471 some points as outliers. This heuristics was disabled because the behavior was unpredictable but
472 with the arrow key navigation support, this is no longer an issue.
474 * public/v2/manifest.js:
475 (App.Manifest._formatFetchedData): Added showOutlier to the chart data. This function dynamically
476 updates the time series in this chart data in order to include or exclude outliers.
478 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
480 Perf dashboard should be able to trigger A/B testing jobs for iOS
481 https://bugs.webkit.org/show_bug.cgi?id=143398
483 Reviewed by Chris Dumez.
485 Fix various bugs in the perf dashboard so that it can schedule A/B testing jobs for iOS.
487 Also generalized sync-with-buildbot.py slightly to meet the requirements of iOS builders.
489 * public/api/triggerables.php:
490 (main): Avoid spitting a warning when $id_to_triggerable doesn't contain the triggerable.
491 * public/v2/analysis.js:
492 (App.AnalysisTask.triggerable): Log an error when failed to fetch triggerables for debugging purposes.
494 (App.AnalysisTaskController.updateRootConfigurations): Show 'None' when a revision is missing from
495 some of the data points. This will happen when we modify the list of projects we build for iOS.
496 (App.AnalysisTaskController.actions.createTestGroup): Gracefully fail by showing alerts when an user
497 attempts to create an invalid test group; when there is already another test group of the same or when
498 only either configuration specifies the revision for some repository.
499 (App.AnalysisTaskController._updateRootsBySelectedPoints): Fixed a typo: sets[i] -> set.
500 * public/v2/index.html: Don't show the form to create a new test group if it's not available.
501 * tools/sync-with-buildbot.py:
502 (find_request_updates):
503 (schedule_request): iOS builders take a JSON that contains the list of roots. Generate this JSON when
504 a dictionary of the form {rootsExcluding: ["WebKit"]} is specified. Also replaced the way we refer to
505 a revision from $-based text replacements to an explicit dictionary of the form {root: "WebKit"}.
506 (request_id_from_build): Don't hard code the parameter name here. Retrieve the name from the config.
508 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
510 Add time series segmentation algorithms as moving averages
511 https://bugs.webkit.org/show_bug.cgi?id=143362
513 Reviewed by Chris Dumez.
515 This patch implements two preliminary time series segmentation algorithms as moving averages.
517 Recursive t-test: Compute Welch's t-statistic at each point in a given segment of the time series.
518 If Welch's t-test implicates a statistically significance difference, then split the segment into two
519 sub segments with the maximum t-statistic (i.e. the point at which if split would yield the highest
520 probability that two segments do not share the same "underlying" mean in classical / frequentist sense).
521 We repeat this process recursively. See [1] for the evaluation of this particular algorithm.
523 Schwarz criterion: Use Schwarz or Bayesian information criterion to heuristically find the optimal
524 segmentation. Intuitively, the problem of finding the best segmentation comes down to minimizing the
525 residual sum of squares in each segment as in linear regressions. That is, for a given segment with
526 values y_1 through y_n with mean y_avg, we want to minimize the sum of (y_i - y_avg)^2 over i = 1
527 through i = n. However, we also don't want to split every data point into a separate segment so we need
528 to account the "cost" of introducing new segments. We use a cost function that's loosely based on two
529 models discussed in [2] for simplicity. We will tune this cost function further in the future.
531 The problem of finding the best segmentation then reduces to a search problem. Unfortunately, our problem
532 space is exponential with respect to the size of the time series since we could split at each data point.
533 We workaround this problem by first splitting the time series into a manageable smaller grids, and only
534 considering segmentation of a fixed size (i.e. the number of segments is constant). Since time series
535 tend to contain a lot more data points than segments, this strategy finds the optimal solution without
536 exploring much of the problem space.
538 Finding the optimal segmentation of a fixed size is, itself, another search problem that is equivalent to
539 finding the shortest path of a fixed length in DAG. Here, we use dynamic programming with a matrix of size
540 n by n where n is the length of the time series (grid). Each entry in this matrix at (i, k) stores
541 the minimum cost of segmenting data points 1 through i using k segments. We start our search at i = 1.
542 Clearly C(1, 0) = 0 (note the actual code uses 0-based index). In i-th iteration, we compute the cost
543 S(i, j) of each segment starting at i and ending at another point j after i and update C(j, k + 1) by
544 min( C(j, k + 1), C(i, k) + S(i, j) ) for all values of j above i.
546 [1] Kensuke Fukuda, H. Eugene Stanley, and Luis A. Nunes Amaral, "Heuristic segmentation of
547 a nonstationary time series", Physical Review E 69, 021108 (2004)
549 [2] Marc Lavielle, Gilles Teyssi`ere, "Detection of Multiple Change–Points in Multivariate Time Series"
550 Lithuanian Mathematical Journal, vol 46, 2006
552 * public/v2/index.html: Show the optional description for the chosen moving average strategy.
553 * public/v2/js/statistics.js:
554 (Statistics.testWelchsT):
555 (Statistics.computeWelchsT): Extracted from testWelchsT. Generalized to take the offset and the length
556 of each value array between which Welch's t-statistic is computed. This generalization helps the
557 Schwarz criterion segmentation algorithm avoid splitting values array O(n^2) times.
558 (.sampleMeanAndVarianceForValues): Ditto for the generalization.
559 (.recursivelySplitIntoTwoSegmentsAtMaxTIfSignificantlyDifferent): Added. Implements recursive t-test.
560 (.splitIntoSegmentsUntilGoodEnough): Added. Implements Schwarz criterion.
561 (.findOptimalSegmentation): Added. Implements the algorithm to find the optimal segmentation of a fixed
563 (.SampleVarianceUpperTriangularMatrix): Added. Stores S(i, j) used by findOptimalSegmentation.
564 (.SampleVarianceUpperTriangularMatrix.prototype.costBetween): Added.
566 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
568 REGRESSION: Perf dashboard sometimes fails to update zooming level
569 https://bugs.webkit.org/show_bug.cgi?id=143359
571 Reviewed by Darin Adler.
573 The bug was caused by various bugs that ended up in an exception.
576 (App.Pane._handleFetchErrors): Removed superfluous console.log.
577 (App.Pane.computeStatus): Fixed the bug in r182185 that previousPoint could be null.
578 (App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
579 * public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
580 to # when Ember.js fails to attach event listeners on time.
581 * public/v2/interactive-chart.js:
582 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
583 the containing element's size is 0.
584 (App.InteractiveChartComponent._updateBrush): Ditto.
586 2015-04-02 Ryosuke Niwa <rniwa@webkit.org>
588 Perf dashboard should have UI to test out anomaly detection strategies
589 https://bugs.webkit.org/show_bug.cgi?id=143290
591 Reviewed by Benjamin Poulain.
593 Added the UI to select anomaly detection strategies. The detected anomalies are highlighted in the graph.
595 Implemented the Western Electric Rules 1 through 4 in http://en.wikipedia.org/wiki/Western_Electric_rules
596 as well as Welch's t-test that compares the last five points to the prior twenty points.
598 The latter is what Mozilla uses (or at least did in the past) to detect performance regressions on their
599 performance tests although they compare medians instead of means.
601 All of these strategies don't quite work for us since our data points are too noisy but this is a good start.
604 (App.Pane.updateStatisticsTools): Clone anomaly detection strategies.
605 (App.Pane._updateMovingAverageAndEnvelope): Highlight anomalies detected by the enabled strategies.
606 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Observe changes to anomaly detection strategies.
607 (App.Pane._computeMovingAverageAndOutliers): Detect anomalies by each strategy and aggregate results.
608 Only report the first data point when multiple consecutive data points are detected as anomalies.
609 * public/v2/chart-pane.css: Updated styles.
610 * public/v2/index.html: Added the pane for selecting anomaly detection strategies.
611 * public/v2/js/statistics.js:
612 (Statistics.testWelchsT): Added. Implements Welch's t-test.
613 (.sampleMeanAndVarianceForValues): Added.
614 (.createWesternElectricRule): Added.
615 (.countValuesOnSameSide): Added.
616 (Statistics.AnomalyDetectionStrategy): Added.
618 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
620 REGRESSION: Searching commits can highlight wrong data points
621 https://bugs.webkit.org/show_bug.cgi?id=143272
623 Reviewed by Antti Koivisto.
625 The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
626 return commit times with only second precision. This resulted in the frontend code to match a commit
627 with the data point that included the next commit when the millisecond component of commit's timestamp
628 wasn't identically 0.
630 This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
631 was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
632 so miliseconds component was only preserved in /api/commits.
634 Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
635 it returns time in milisecond precision.
637 * public/api/commits.php:
638 (fetch_commits_between): Use Database::to_js_time for format commit times.
639 (format_commit): Ditto.
640 * public/include/db.php:
641 (Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
643 (CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
645 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
647 Perf dashboard should show relative change in values
648 https://bugs.webkit.org/show_bug.cgi?id=143252
650 Reviewed by Antti Koivisto.
652 When a range of values are selected, show the percentage difference between the start and the end
653 in addition to the absolute value difference. When a single point is selected, show the relative
654 difference with respect to the previous point. Use two significant figures and always show plus sign
655 when the difference is positive.
657 * public/v2/app.js: Compute and format the relative difference.
658 * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
659 * public/v2/index.html: Show the relative difference.
661 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
663 REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
664 https://bugs.webkit.org/show_bug.cgi?id=143254
666 Reviewed by Antti Koivisto.
668 The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
669 or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
670 so that the interactive chart component will observe a change to 'chartData'.
673 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
675 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
677 Unreviewed build fixes.
679 * public/include/manifest.php:
680 (Manifest::generate): These should be {} instead of [] when they're empty.
682 (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
683 * public/v2/manifest.js:
684 (App.Metric.fullName): Fixed the typo.
685 * tests/admin-regenerate-manifest.js: Fixed the test.
687 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
689 Commit the erroneously reverted change.
691 * public/api/runs.php:
692 (RunsGenerator::results):
694 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
696 Loading the perf dashboard takes multiple seconds
697 https://bugs.webkit.org/show_bug.cgi?id=141860
699 Reviewed by Andreas Kling.
701 This patch introduces the caches of JSON files returned by /api/ in /data/ directory. It also records
702 the last time test_runs rows associated with the requested platforms and metrics are inserted, updated,
703 or removed in the caches as well as the manifest JSON files ("last modified time"). Because the manifest
704 is regenerated each time a new test result is reported, the front end can compare last modified time in
705 the manifest file with that in a /api/runs JSON cache to detect the stale-ness.
707 More concretely, the front end first optimistically fetches the JSON in /data/. If the cache doesn't exit
708 or the last modified time in the cache doesn't match with that in the manifest file, it would fetch it
709 again via /api/runs. In the case the cache did exist, we render the charts based on the cache meanwhile.
710 This dramatically reduces the perceived latency for the page load since charts are drawn immediately using
711 the cache and we would only re-render the charts as new up-to-date JSON comes in.
713 This patch also changes the format of runs JSONs by pushing the exiting properties into 'configurations'
714 and adding 'lastModified' and 'elapsedTime' at the top level.
716 * init-database.sql: Added config_runs_last_modified to test_configurations table as well as a trigger to
717 auto-update this column upon changes to test_runs table.
719 * public/admin/test-configurations.php:
720 (add_run): Regenerate the manifest file to invalidate the /api/runs JSON cache.
723 * public/api/runs.php:
724 (main): Fetch all columns of test_configurations table including config_runs_last_modified. Also generate
725 the cache in /data/ directory.
726 (RunsGenerator::__construct): Compute the last modified time for this (platform, metric) pair.
727 (RunsGenerator::results): Put the old content in 'configurations' property and include 'lastModified' and
728 'elapsedTime' properties. 'elapsedTime' is added for debugging purposes.
729 (RunsGenerator::add_runs):
730 (RunsGenerator::parse_revisions_array):
732 * public/include/db.php:
734 (generate_data_file): Added based on ManifestGenerator::store.
735 (Database::to_js_time): Extracted from RunsGenerator::add_runs to share code.
737 * public/include/json-header.php:
738 (echo_success): Renamed from success_json. Return the serialized JSON instead of echo'ing it so that we can
739 generate caches in /api/runs/.
742 * public/include/manifest.php:
743 (ManifestGenerator::generate): Added 'elapsedTime' property for the time taken to generate the manifest.
744 It seems like we're generating it in 200-300ms for now so that's good.
745 (ManifestGenerator::store): Uses generate_data_file.
746 (ManifestGenerator::platforms): Added 'lastModified' array to each platform entry. This array contains the
747 last modified time for each (platform, metric) pair.
750 (fetchTest): Updated per the format change in runs JSON.
753 (App.Pane._fetch): Fetch the cached JSON first. Refetch the uncached version if instructed as such.
754 (App.Pane._updateChartData): Extracted from App.Pane._fetch.
755 (App.Pane._handleFetchErrors): Ditto.
758 (RunsData.fetchRuns): Takes the fourth argument indicating whether we should fetch the cached version or not.
759 The cached JSON is located in /data/ with the same filename. When fetching a cached JSON results in 404,
760 fulfill the promise with null as the result instead of rejecting it. The only client of this function which
761 sets useCache to true is App.Manifest.fetchRunsWithPlatformAndMetric, and it handles this special case.
763 * public/v2/manifest.js:
764 (App.DateArrayTransform): Added. Handles the array of last modified dates in platform objects.
765 (App.Platform.lastModifiedTimeForMetric): Added. Returns the last modified date in the manifest JSON.
766 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes "useCache" like RunsData.fetchRuns. Set shouldRefetch
767 to true if response is null (the cache didn't exit) or the cache is out-of-date.
768 (App.Manifest._formatFetchedData): Extracted from App.Manifest.fetchRunsWithPlatformAndMetric.
771 (initializeDatabase): Avoid splitting function definitions in the middle.
773 * tests/api-report.js: Added tests to verify that reporting new test results updates the last modified time
774 in test_configurations.
776 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
778 REGRESSION(r180333): Analysis tasks can't be associated with bugs
779 https://bugs.webkit.org/show_bug.cgi?id=141858
781 Reviewed by Andreas Kling.
783 Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
784 of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
786 * public/v2/chart-pane.css:
787 * public/v2/index.html:
789 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
791 Selecting revisions for A/B testing is hard
792 https://bugs.webkit.org/show_bug.cgi?id=141824
794 Reviewed by Andreas Kling.
796 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
797 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
798 select A/B testing points manually.
800 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
801 sets to 'options' for clarity.
803 * public/v2/app.css: Reorganized style rules.
806 (App.AnalysisTaskController):
807 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
808 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
809 a property, which sets 'overviewDomain' property as well as other properties.
810 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
811 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
812 in the overview chart.
814 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
815 individual build requests / test results are shown or not.
817 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
818 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
820 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
822 Unreviewed test fixes after r179037, r179591, and r179763.
824 * tests/admin-regenerate-manifest.js:
825 * tests/admin-reprocess-report.js:
827 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
829 Relationship between A/B testing results are unclear
830 https://bugs.webkit.org/show_bug.cgi?id=141810
832 Reviewed by Andreas Kling.
834 Show a "reference chart" indicating which two points have been tested in each test group pane.
836 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
837 and the domain used in this chart to show charts in each test group.
839 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
841 * public/v2/analysis.js:
842 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
843 since this is the results of A/B testing results, not the data for charts shown next to them.
845 * public/v2/app.css: Added CSS rules for reference charts.
848 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
849 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
850 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
851 identically matches root sets. If one of configuration used a set of revisions for which no measurement
852 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
853 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
854 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
855 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
858 (Measurement.prototype.revisionForRepository): Added.
859 (Measurement.prototype.commitTimeForRepository): Cleanup.
860 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
862 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
863 by including the build number in the title attribute instead of in the markup.
865 * public/v2/interactive-chart.js:
866 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
867 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
868 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
870 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
872 Analysis task pages are unusable
873 https://bugs.webkit.org/show_bug.cgi?id=141786
875 Reviewed by Andreas Kling.
877 This patch makes following improvements to analysis task pages:
878 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
879 compute the data for the details pane from PaneController.
880 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
881 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
882 This change required the creation of App.TestGroupPane as well as its methods.
883 4. Show a box plot for each root set configuration as well as each build request. This change required
884 App.BoxPlotComponent.
885 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
887 * public/api/build-requests.php:
888 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
890 * public/api/test-groups.php:
891 (main): Include root sets and roots in the response.
894 * public/include/build-requests-fetcher.php:
895 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
896 (BuildRequestsFetcher::root_sets): Added.
897 (BuildRequestsFetcher::roots): Added.
898 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
899 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
900 tools/sync-with-buildbot.py can't convert repository names to their ids.
902 * public/v2/analysis.js:
904 (App.RootSet): Added.
905 (App.RootSet.revisionForRepository): Added.
906 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
907 response at /api/test-groups will include them.
908 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
909 _createConfigurationSummary.
910 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
911 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
913 * public/v2/app.css: Updated style rules for analysis task pages.
916 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
917 (App.Pane._updateDetails): Moved from App.PaneController.
919 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
921 (App.AnalysisTaskController): Added 'details'.
922 (App.AnalysisTaskController._taskUpdated):
923 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
924 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
925 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
927 (App.TestGroupPane): Added.
928 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
929 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
930 of all repositories appearing in root sets and builds associated with A/B testing results.
931 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
932 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
933 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
934 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
935 is a union of revisions in the root set and the first build request in the group. We null-out revision info
936 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
937 by the values in the group as well as 95% percentile confidence interval.
939 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
940 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
941 the mean and the confidence interval.
942 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
943 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
944 calls _updateBars to update the rects.
946 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
949 (Measurement.prototype.formattedRevisions):
950 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
951 called in _createConfigurationSummary.
953 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
954 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
955 Also made the fetching of chartData no longer block showing of test groups.
957 * public/v2/interactive-chart.js:
958 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
959 (App.InteractiveChartComponent._domainChanged): Ditto.
960 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
962 * public/v2/js/statistics.js:
963 (Statistics.min): Added.
964 (Statistics.max): Added.
966 * public/v2/manifest.js:
967 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
969 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
971 Build URL on new perf dashboard doesn't resolve $builderName
972 https://bugs.webkit.org/show_bug.cgi?id=141583
974 Reviewed by Darin Adler.
976 Support $builderName in the build URL template.
978 * public/js/helper-classes.js:
979 (TestBuild.buildUrl): Replaced $builderName with the builder name.
981 * public/v2/manifest.js:
982 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
983 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
985 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
987 Unreviewed build fix after r179591.
989 * public/api/commits.php:
991 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
993 The status of a A/B testing request always eventually becomes "Failed"
994 https://bugs.webkit.org/show_bug.cgi?id=141523
996 Reviewed by Andreas Kling.
998 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
999 'failedIfNotCompleted' was sent by the buildbot sync'er.
1001 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
1003 * public/api/build-requests.php:
1006 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
1008 Unreviewed, remove empty directories.
1010 * public/data: Removed.
1012 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
1014 Perf dashboard should show the results of A/B testing
1015 https://bugs.webkit.org/show_bug.cgi?id=141500
1017 Reviewed by Chris Dumez.
1019 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
1020 analysis task page to fetch results for each test group.
1022 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
1023 can use the formatter.
1025 * public/api/runs.php:
1026 (fetch_runs_for_config_and_test_group): Added.
1027 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
1028 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
1029 use RunsGenerator to format results.
1030 (RunsGenerator): Added.
1031 (RunsGenerator::__construct): Added.
1032 (RunsGenerator::add_runs): Added.
1033 (RunsGenerator::format_run): Moved.
1034 (RunsGenerator::parse_revisions_array): Moved.
1036 * public/v2/analysis.js:
1037 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
1038 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
1039 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
1040 configuration associated with this build request such as "A" and "B".
1041 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
1042 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
1043 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
1047 (App.Pane._fetch): Set chartData directly here.
1048 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
1049 now that it's done in App.Pane._fetch.
1050 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
1052 * public/v2/data.js:
1053 (Measurement.prototype.buildId): Added.
1054 (TimeSeries.prototype.findPointByBuild): Added.
1056 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
1057 url is not an Ember routed path.
1059 * public/v2/manifest.js:
1060 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
1061 App.createChartData here so that App.BuildRequest can use the formatter
1063 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
1065 v2 UI should adjust the number of ticks on dashboards based on screen size
1066 https://bugs.webkit.org/show_bug.cgi?id=141502
1068 Reviewed by Chris Dumez.
1070 * public/v2/interactive-chart.js:
1071 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
1074 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
1076 New perf dashboard shows too much space around interesting data points
1077 https://bugs.webkit.org/show_bug.cgi?id=141487
1079 Reviewed by Chris Dumez.
1081 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
1082 show the current time series excluding points in the series outside the moving average envelope.
1085 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
1086 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
1087 time series if the point lies outside the moving average envelope. Don't expose the moving average or
1088 the envelope computed for this purpose if they're not set by the user.
1090 * public/v2/data.js:
1091 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
1092 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
1094 * public/v2/interactive-chart.js:
1095 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
1096 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
1097 to deal with showFullYAxis here.
1098 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
1099 argument instead of directly inspecting showFullYAxis.
1101 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1103 New perf dashboard shouldn't always show outliners
1104 https://bugs.webkit.org/show_bug.cgi?id=141445
1106 Reviewed by Chris Dumez.
1108 Use the simple moving average with an average difference envelope to compute the y-axis range to show
1109 to avoid expanding it spuriously to show one off outlier.
1112 (App.Pane): Don't show the full y-axis range by default.
1113 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
1114 one is not specified by the user but without showing them in the charts.
1115 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
1116 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
1118 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
1119 (App.ChartsController._serializePaneList): Ditto.
1121 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
1123 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
1125 * public/v2/interactive-chart.js:
1126 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
1127 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
1128 if they are not specified by the user (i.e. only used to adjust y-axis range).
1129 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
1130 x-axis domain remained the same. Without this change, the charts would never redraw.
1131 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
1132 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
1133 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
1135 * public/v2/js/statistics.js:
1136 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
1138 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1140 Unreviewed build fix.
1143 (set get App.Pane.Ember.Object.extend):
1145 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1147 New perf dashboard should have the ability to overlay moving average with an envelope
1148 https://bugs.webkit.org/show_bug.cgi?id=141438
1150 Reviewed by Andreas Kling.
1152 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
1154 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
1155 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
1156 n, backward window size, and m, forward window size, as an argument.
1158 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
1159 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
1161 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
1162 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
1165 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
1166 between each x_i and x̄_i.
1168 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
1169 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
1170 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
1171 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
1174 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
1175 The configuration of the currently chosen strategies is saved in the query string for convenience.
1177 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
1179 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
1182 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
1183 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
1184 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
1185 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
1186 from the query string via ChartsController.
1187 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
1188 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
1189 (App.Pane._executeStrategy): Added.
1190 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
1192 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
1193 selections, and added two new arguments for the moving average and the enveloping configurations.
1194 (App.ChartsController._serializePaneList): Ditto.
1195 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
1196 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
1197 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
1198 (App.PaneController.actions.toggleStatPane): Added.
1200 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
1201 current (as opposed to baseline and target) time series for when it's the most foreground graph without
1202 moving average and its envelope overlapping on top of it.
1204 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
1206 * public/v2/interactive-chart.js:
1207 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
1208 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
1209 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
1210 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
1211 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
1212 but don't bother removing individual paths and circles. Added the code to show the moving average time
1213 series when there is one. Also add "foreground" class on SVG elements for the current time series when
1214 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
1215 series when "foreground" is not set.
1216 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
1217 account when computing the y-axis range.
1218 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
1220 * public/v2/js/statistics.js:
1221 (Statistics.MovingAverageStrategies): Added.
1222 (Statistics.EnvelopingStrategies): Added.
1224 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1226 The delta value in the chart pane sometimes doens't show '+' for a positive delta
1227 https://bugs.webkit.org/show_bug.cgi?id=141340
1229 Reviewed by Andreas Kling.
1231 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
1232 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
1235 (App.Pane.computeStatus):
1236 (App.createChartData):
1238 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1240 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
1243 (App.PaneController._updateDetails):
1245 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1247 Unreviewed. Commit the forgotten change.
1249 * public/include/manifest.php:
1251 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1253 New perf dashboard should have multiple dashboard pages
1254 https://bugs.webkit.org/show_bug.cgi?id=141339
1256 Reviewed by Chris Dumez.
1258 Added the support for multiple dashboard pages. Also added the status of the latest data point.
1259 e.g. "5% better than target"
1261 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
1262 Also hid the border lines around charts on the dashboard page for a cleaner look.
1265 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
1266 (App.IndexRoute.beforeModel): Added.
1267 (App.DashboardRoute): Added.
1268 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
1269 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
1270 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
1271 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
1272 (App.DashboardController): Renamed from App.IndexController.
1273 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
1274 and "defaultDashboard" as these are taken care of by newly added routers.
1275 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
1276 now done in actions.toggleEditMode.
1277 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
1278 an existing dashboard.
1280 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
1281 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
1282 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
1283 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
1285 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
1287 (App.PaneController._updateDetails): Updated per changes to computeStatus.
1289 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
1291 * public/v2/data.js:
1292 (TimeSeries.prototype.lastPoint): Added.
1294 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
1295 on the dashboard, and enumerate all predefined dashboards.
1297 * public/v2/interactive-chart.js:
1298 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
1299 for the dashboard page.
1301 * public/v2/manifest.js:
1302 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
1303 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
1304 IDs are generated for each dashboard for forward compatibility.
1306 (App.Manifest.dashboardByName): Added.
1307 (App.Manifest.defaultDashboardName): Added.
1308 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
1310 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1312 Move commits viewer to the end of details view
1313 https://bugs.webkit.org/show_bug.cgi?id=141315
1315 Rubber-stamped by Andreas Kling.
1317 Show the difference instead of the old value per kling's request.
1320 (App.PaneController._updateDetails):
1321 * public/v2/index.html:
1323 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1325 Move commits viewer to the end of details view
1326 https://bugs.webkit.org/show_bug.cgi?id=141315
1328 Reviewed by Andreas Kling.
1330 Improved the way list of commits are shown per kling's request.
1333 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
1335 * public/v2/chart-pane.css: Updated the style for the commits viewer.
1337 * public/v2/commits-viewer.js:
1338 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
1339 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
1341 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
1342 moved the commits viewers out of the details tables so that they don't interleave revision data.
1344 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1346 New perf dashboard should compare results to baseline and target
1347 https://bugs.webkit.org/show_bug.cgi?id=141286
1349 Reviewed by Chris Dumez.
1351 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
1352 Also use d3.format to format the selected value to show four significant figures.
1355 (App.Pane.searchCommit):
1356 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
1357 to compute the status text without having to recreate them.
1358 (App.createChartData): Added.
1359 (App.PaneController._updateDetails): Use 3d.format on current and old values.
1360 (App.PaneController._computeStatus): Added. Computes the status text.
1361 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
1362 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
1363 format the values using chartData.formatter.
1365 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
1366 the baseline and in blue if it's better than the target.
1368 * public/v2/data.js:
1369 (TimeSeries.prototype.findPointAfterTime): Added.
1371 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
1372 the bug that we were not showing the old value's unit.
1374 * public/v2/interactive-chart.js:
1375 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
1376 the code to show the baseline and the target lines.
1378 * public/v2/manifest.js:
1379 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
1381 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1383 Unreviewed build fix.
1386 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
1388 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1390 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
1391 https://bugs.webkit.org/show_bug.cgi?id=141280
1393 Reviewed by Chris Dumez.
1395 Fixed the bug by passing in "since" as a query parameter to the charts page.
1397 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
1399 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
1401 (App.IndexController): Changed the default number of days from one month to one week.
1402 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
1403 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
1405 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1407 New perf dashboard erroneously clears zoom when poping history items
1408 https://bugs.webkit.org/show_bug.cgi?id=141278
1410 Reviewed by Chris Dumez.
1412 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
1414 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
1415 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
1418 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
1419 shown in the main plot.
1420 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
1421 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
1423 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1425 New perf dashboard shows null as the aggregator name if no aggregation is done
1426 https://bugs.webkit.org/show_bug.cgi?id=141256
1428 Reviewed by Chris Dumez.
1430 Don't show the aggregator name if there isn't one.
1432 * public/v2/manifest.js:
1435 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1437 Unreviewed build fix after r179611.
1439 * public/v2/interactive-chart.js:
1441 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1443 Perf dashboard doesn’t show the right unit for Safari UI tests
1444 https://bugs.webkit.org/show_bug.cgi?id=141238
1446 Reviewed by Darin Adler.
1448 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
1449 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
1450 between metrics and their units.
1452 * public/js/helper-classes.js:
1453 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
1454 * public/v2/manifest.js:
1455 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
1456 * public/v2/interactive-chart.js:
1457 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
1458 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
1460 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1462 Interactive chart component provides two duplicate API for highlighting points
1463 https://bugs.webkit.org/show_bug.cgi?id=141234
1465 Reviewed by Chris Dumez.
1467 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
1468 on the main charts page and markedPoints to show the two end points in the analysis task page.
1470 This patch merges markedPoints into highlightedItems.
1473 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
1474 * public/v2/chart-pane.css:
1475 * public/v2/index.html: Ditto.
1476 * public/v2/interactive-chart.js:
1477 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
1478 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
1479 items if highlightedItems was set before the initial layout.
1480 (App.InteractiveChartComponent._relayoutDataAndAxes):
1481 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
1482 vertical lines, just set cx and cy as done for other "dots".
1483 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
1484 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
1485 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
1486 set the radius of highlight circles here.
1488 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1490 Don’t use repository names as id’s.
1491 https://bugs.webkit.org/show_bug.cgi?id=141226
1493 Reviewed by Chris Dumez.
1495 Not using repository names as their id's reduces the need to fetch the entire repositories table.
1496 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
1498 * Websites/perf.webkit.org/public/api/runs.php:
1499 (parse_revisions_array): No longer uses $repository_id_to_name.
1500 (main): No longer populates $repository_id_to_name.
1502 * Websites/perf.webkit.org/public/api/triggerables.php:
1503 (main): Don't resolve repository names.
1505 * Websites/perf.webkit.org/public/include/manifest.php:
1506 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
1507 (ManifestGenerator::bug_trackers): Don't resolve repository names.
1509 * Websites/perf.webkit.org/public/js/helper-classes.js:
1510 (TestBuild): Renamed repositoryName to repositoryId.
1511 (TestBuild.revision): Ditto.
1512 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
1513 since this is the text shown to human.
1515 * Websites/perf.webkit.org/public/v2/app.js:
1516 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
1517 (App.PaneController._updateDetails): Ditto.
1518 (App.AnalysisTaskController.updateRoots): Ditto.
1520 * Websites/perf.webkit.org/public/v2/data.js:
1521 (Measurement): Ditto.
1522 (Measurement.prototype.commitTimeForRepository): Ditto.
1523 (Measurement.prototype.formattedRevisions): Ditto.
1525 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
1526 select element's label and value respectively.
1528 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1530 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
1532 * public/api/runs.php:
1534 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1536 /api/runs.php should have main function
1537 https://bugs.webkit.org/show_bug.cgi?id=141220
1539 Reviewed by Benjamin Poulain.
1541 Wrapped the code inside main function for clarity.
1543 * public/api/runs.php:
1545 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
1547 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
1549 * tools/sync-with-buildbot.py:
1550 (find_request_updates):
1552 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1554 Perf dashboard always assigns the result of A/B testing with build request 1
1555 https://bugs.webkit.org/show_bug.cgi?id=140382
1557 Reviewed by Darin Adler.
1559 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
1560 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
1562 Also fixed a typo as well as a bug that reports were never associated with builds.
1564 * public/include/report-processor.php:
1565 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
1566 instead of the first non-null value.
1567 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
1568 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
1570 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1572 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
1574 * public/admin/tests.php:
1576 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
1578 Unreviewed build fix. Removed the stale code.
1580 * public/admin/triggerables.php:
1582 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1584 Perf dashboard should have the ability to post A/B testing builds
1585 https://bugs.webkit.org/show_bug.cgi?id=140317
1587 Rubber-stamped by Simon Fraser.
1589 This patch adds the support for triggering A/B testing from the perf dashboard.
1591 We add a few new tables to the database. "build_triggerables", which represents a set of builders
1592 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
1593 of repositories for which an arbitrary revision can be specified for A/B testing.
1594 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
1595 "roots" table which specifies the revision used in a given root set in each repository.
1597 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
1598 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
1599 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
1600 to build_requests table. Also made each test group's name unique in a given analysis task as it
1601 would be confusing to have multiple test groups of the same name.
1603 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
1605 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
1606 for which a specific revision can be set in an A/B testing on a given triggerable.
1608 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
1609 triggerable. Also updates the status' and the status urls of specified build requests when
1610 buildRequestUpdates is provided in the raw POST data.
1613 * public/api/runs.php:
1614 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
1615 results of an A/B testing.
1617 * public/api/test-groups.php:
1618 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
1620 * public/api/triggerables.php: Added.
1621 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
1623 * public/include/admin-header.php:
1625 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
1626 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
1627 and root sets used in those requests.D
1628 (BuildRequestsFetcher::__construct):
1629 (BuildRequestsFetcher::fetch_for_task):
1630 (BuildRequestsFetcher::fetch_for_group):
1631 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
1632 (BuildRequestsFetcher::has_results):
1633 (BuildRequestsFetcher::results):
1634 (BuildRequestsFetcher::results_with_resolved_ids):
1635 (BuildRequestsFetcher::results_internal):
1636 (BuildRequestsFetcher::root_sets):
1637 (BuildRequestsFetcher::fetch_roots_for_set):
1639 * public/include/db.php:
1640 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
1641 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
1642 table since it only has the primary key, id, column.
1643 (Database::select_or_insert_row):
1644 (Database::update_or_insert_row):
1645 (Database::update_row): Added.
1646 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
1647 should be inserted when no row matches the specified criteria. This is used while updating
1648 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
1649 new build requests in that API.
1650 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
1651 This is used in public/api/triggerables.php when no analysis task is specified.
1653 * public/include/json-header.php:
1654 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
1655 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
1656 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
1657 find the closest ancestor with a triggerable.
1659 * public/include/report-processor.php:
1660 (ReportProcessor::process):
1661 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
1662 if jobId or buildRequest is specified.
1664 * public/include/test-name-resolver.php:
1665 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
1666 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
1667 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
1670 * public/include/test-path-resolver.php: Added.
1671 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
1672 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
1673 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
1674 in order to compute full test metric names.
1675 (TestPathResolver::__construct):
1676 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
1677 the highest (a test without a parent).
1678 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
1679 the highest ancestor to the test itself.
1680 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
1682 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
1684 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
1685 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
1686 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
1687 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
1689 * public/v2/analysis.js:
1690 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
1691 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
1692 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
1693 (App.TestGroup.create): Added. Creates a new A/B testing group.
1694 (App.Triggerable): Added.
1695 (App.TriggerableAdapter): Added.
1696 (App.TriggerableAdapter.buildURL): Added.
1697 (App.BuildRequest.testGroup): Renamed from group.
1698 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
1699 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
1700 in this build request.
1701 (App.BuildRequest.status): Added.
1702 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
1703 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
1706 (App.AnalysisTaskController.testGroups): Added.
1707 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
1708 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
1709 but an observer that updates "roots" property. Filter out the repositories that are not accepted
1710 by the associated triggerable as they will be ignored.
1711 (App.AnalysisTaskController.actions.createTestGroup): Added.
1713 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
1715 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
1716 the status of those builds to the perf dashboard. A similar script can be written to support
1717 other continuous builds systems.
1718 (main): Fetches the list of pending builds as well as currently running or completed builds from
1719 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
1720 a single new build on each builder with no pending builds, and marks the set of open build requests
1721 that have been scheduled to run on the buildbot but not found in the first step as stale.
1722 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
1725 "platform": "mac-mavericks",
1726 "test": ["Parser", "html5-full-render.html"],
1727 "builder": "Trunk Syrah Production Perf AB Tests",
1729 "forcescheduler": "force-mac-mavericks-release-perf",
1730 "webkit_revision": "$WebKit",
1731 "jobid": "$buildRequest"
1736 (find_request_updates): Return a list of build request status updates to make based on the pending
1737 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
1738 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
1739 if the build request had not been completed. This is necessary because a failed build will not
1740 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
1741 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
1742 of open requests the perf dashboard has.
1743 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
1744 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
1745 or human canceling a build may trigger such a state.
1746 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
1747 replacing repository names with their revisions and buildRequest with the build request id.
1748 (config_for_request): Finds a builder for the test and the platform of a build request.
1749 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
1750 (property_value_from_build): Returns the value of a specific property in a buildbot build.
1751 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
1753 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1755 Cache-control should be set only on api/runs
1756 https://bugs.webkit.org/show_bug.cgi?id=140312
1758 Reviewed by Andreas Kling.
1760 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
1761 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
1762 just set cache-control there instead of json-header.php which is used by other JSON APIs.
1764 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
1766 * public/api/analysis-tasks.php:
1767 * public/api/runs.php: Set the cache control headers.
1768 * public/api/test-groups.php:
1769 * public/include/db.php: Set the default timezone to UTC.
1770 * public/include/json-header.php: Don't set the cache control headers.
1772 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1774 api/report-commit should authenticate with a slave name and password
1775 https://bugs.webkit.org/show_bug.cgi?id=140308
1777 Reviewed by Benjamin Poulain.
1779 Use a slave name and a password to authenticate new commit reports.
1781 * public/api/report-commits.php:
1783 * public/include/json-header.php:
1784 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
1785 a slave name and a password instead of a builder name and a password.
1786 * tests/api-report-commits.js: Updated tests.
1787 * tools/pull-svn.py:
1788 (main): Renamed variables.
1789 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
1791 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
1793 Perf dashboard should support authentication via a slave password
1794 https://bugs.webkit.org/show_bug.cgi?id=139837
1796 Reviewed by Andreas Kling.
1798 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
1799 having to add multiple builders with the same password when a single build slave is shared among them.
1801 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
1803 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
1805 * public/admin/build-slaves.php: Added.
1807 * public/admin/builders.php: Added the support for updating passwords.
1809 * public/include/admin-header.php:
1810 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
1811 being retrieved from $_POST.
1812 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
1813 the raw may not exist (e.g. new_password).
1814 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
1815 control here when this flag evaluates to TRUE.
1817 * public/include/report-processor.php:
1818 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
1819 values are present in the report. In addition, try authenticating builderName with slavePassword if
1820 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
1821 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
1822 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
1824 (ReportProcessor::store_report): Store the slave ID with the report.
1825 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
1826 the matching build is different from what's being reported.
1828 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
1831 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
1833 New perf dashboard should not duplicate author information in each commit
1834 https://bugs.webkit.org/show_bug.cgi?id=139756
1836 Reviewed by Darin Adler.
1838 Instead of each commit having author name and email, make it reference a newly added committers table.
1839 Also replace "email" by "account" since some repositories don't use emails as account names.
1841 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
1842 which only contains as many rows as there are accounts in each repository, instead of commits table
1843 which contains every commit ever happened in each repository.
1845 To migrate an existing database into match the new schema, run:
1849 INSERT INTO committers (committer_repository, committer_name, committer_email)
1850 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
1851 FROM commits WHERE commit_author_email IS NOT NULL);
1853 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
1855 UPDATE commits SET commit_committer = committer_id FROM committers
1856 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
1858 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
1859 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
1863 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
1864 reference to committers. Also added the missing drop table statements.
1866 * public/api/commits.php:
1867 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
1868 an array here instead of doing it in format_commit.
1869 (fetch_commits_between): Updated queries to JOIN commits with committers.
1870 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
1871 is now done in main.
1873 * public/api/report-commits.php:
1874 (main): Store the reported committer information or update the existing entry if there is one.
1876 * tests/admin-regenerate-manifest.js: Fixed tests.
1878 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
1880 * tools/pull-svn.py: Renamed email to account.
1882 (fetch_commit_and_resolve_author):
1884 (resolve_author_name_from_account):
1885 (resolve_author_name_from_email): Deleted.
1887 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
1889 Unreviewed build fix.
1891 * public/v2/index.html: Include js files we extracted in r177424.
1893 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1895 Unreviewed. Adding the forgotten svnprop.
1897 * tools/pull-svn.py: Added property svn:executable.
1899 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1901 Split InteractiveChartComponent and CommitsViewerComponent into separate files
1902 https://bugs.webkit.org/show_bug.cgi?id=139716
1904 Rubber-stamped by Benjamin Poulain.
1906 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
1907 and interactive-chart.js respectively since app.js has gotten really large.
1910 * public/v2/commits-viewer.js: Added.
1911 * public/v2/interactive-chart.js: Added.
1913 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
1915 New perf dashboard's chart UI is buggy
1916 https://bugs.webkit.org/show_bug.cgi?id=139214
1918 Reviewed by Chris Dumez.
1920 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
1922 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
1923 component. This is not how Ember.js components should interact to begin with. The component now exposes
1924 selectedPoints and always updates selection instead of sharedSelection.
1927 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
1928 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
1929 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
1930 and end time should be completely determined by "since" and the present time.
1931 (App.ChartsController._startTimeChanged): Ditto.
1932 (App.ChartsController._scheduleQueryStringUpdate):
1933 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
1935 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
1937 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
1938 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
1939 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
1940 observes the changes to selectedPoints property as it gets updated by the main chart.
1941 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
1942 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
1944 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
1945 when domain arrays aren't identical. This was causing a subtle race with other logic.
1946 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
1947 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
1948 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
1949 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
1950 see if those two points correspond to a range or a single data point. Rewrote all that logic by
1951 directly observing selectedPoints and currentItem properties instead of taking points and relying on
1952 an instance variable, which was a terrible API.
1953 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
1954 when the main plot has a selected range, we don't have to check this._hasRange anymore.
1956 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
1957 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
1958 (App.InteractiveChartComponent._updateSelection):
1959 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
1960 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
1961 selectedPoints property.
1963 (App.AnalysisTaskController._fetchedRuns):
1964 (App.AnalysisTaskController._rootChangedForTestSet):
1966 * public/v2/index.html:
1967 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
1969 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1971 Unreviewed. Fixed syntax errors.
1973 * init-database.sql:
1974 * public/api/commits.php:
1976 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1978 The dashboard on new perf monitor should be configurable
1979 https://bugs.webkit.org/show_bug.cgi?id=138994
1981 Reviewed by Benjamin Poulain.
1983 For now, make it configurable via config.json. We should eventually make it configurable via
1984 an administrative page but this will do for now.
1986 * config.json: Added the empty dashboard configuration.
1988 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1991 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1992 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1993 Also obtain the default configuration from App.Manifest.
1994 (App.IndexController._normalizeTable): Moved to App.Dashboard.
1996 * public/v2/manifest.js:
1997 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
1998 (App.Repository.urlForRevisionRange): Ditto.
1999 (App.Dashboard): Added.
2000 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
2001 (App.Dashboard.rows): Ditto.
2002 (App.Dashboard.headerColumns): Ditto.
2003 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
2004 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
2005 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
2006 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
2008 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
2010 There should be a way to associate bugs with analysis tasks
2011 https://bugs.webkit.org/show_bug.cgi?id=138977
2013 Reviewed by Benjamin Poulain.
2015 Updated associate-bug.php to match the new database schema.
2017 * public/include/json-header.php:
2018 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
2019 already camel-cased in require_existence_of. This makes the function usable elsewhere.
2021 * public/privileged-api/associate-bug.php:
2022 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
2023 Also verify that those values are integers using require_format.
2025 * public/v2/analysis.js:
2026 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
2027 (App.Bug.label): Added.
2028 (App.BugAdapter): Added.
2029 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
2030 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
2032 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
2033 containing the bug information.
2036 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
2037 (App.AnalysisTaskRoute):
2038 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
2039 (App.AnalysisTaskController._fetchedManifest): Added.
2040 (App.AnalysisTaskController.actions.associateBug): Added.
2042 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
2044 * public/v2/data.js:
2045 (Measurement.prototype.associateBug): Deleted.
2047 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
2048 Added a table show the bug information. Also hide the chart until chartData is available.
2050 * public/v2/manifest.js:
2053 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
2055 Fix misc bugs and typos in app.js
2056 https://bugs.webkit.org/show_bug.cgi?id=138946
2058 Reviewed by Benjamin Poulain.
2061 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
2062 (App.ChartsController.init):
2063 (App.buildPopup): Renamed from App.BuildPopup.
2064 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
2065 remove() on the wrong object (an array as opposed to elements in the array).
2066 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
2067 _highlights is always an array and evalutes to true.
2069 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
2071 New perf dashboard should provide UI to create a new analysis task
2072 https://bugs.webkit.org/show_bug.cgi?id=138910
2074 Reviewed by Benjamin Poulain.
2076 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
2077 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
2079 With this patch, we can create a new analysis task by selection a range of points and opening
2080 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
2081 in the chart hyperlinked to the analysis task.
2083 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
2085 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
2086 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
2088 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
2089 and adds the associated bugs to each task in the array.
2092 * public/api/runs.php: Reverted changes made in r175006.
2093 (fetch_runs_for_config):
2096 * public/api/test-groups.php:
2097 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
2099 * public/include/db.php:
2100 (Database::select_first_or_last_row):
2101 (Database::select_rows): Extracted from select_first_or_last_row.
2103 * public/v2/analysis.js:
2104 (App.AnalysisTask): Added "bugs" property.
2105 (App.Bug): Added now that bugs are regular data store objects.
2108 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
2109 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
2110 platform that are associated with a specific range of runs.
2111 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
2112 (App.PaneController.actions.associateBug): Deleted.
2113 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
2114 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
2115 once we've created one.
2116 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
2117 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
2118 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
2119 (App.PaneController._updateBugs): Deleted.
2120 (App.PaneController._updateMarkedPoints): Deleted.
2121 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
2122 the name is missing or when at most one point is selected.
2124 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
2125 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
2126 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
2127 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
2128 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
2129 clickable bars for analysis tasks.
2130 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
2131 bar for analysis tasks to place them at the right location.
2132 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
2134 * public/v2/chart-pane.css:
2135 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
2136 (.chart .rangeBar): Added.
2138 * public/v2/data.js:
2139 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
2141 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
2142 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
2143 task bars in the interactive chart component.
2145 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
2147 Fix typos in r176203.
2150 (App.ChartsController.actions.addPaneByMetricAndPlatform):
2151 (App.AnalysisTaskRoute):
2153 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
2155 Unreviewed. Updated the install instruction.
2159 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
2161 App.Manifest shouldn't use App.__container__.lookup
2162 https://bugs.webkit.org/show_bug.cgi?id=138768
2164 Reviewed by Andreas Kling.
2166 Removed the hack to find the store object via App.__container__.lookup.
2167 Pass around the store object instead.
2170 (App.DashboardRow._createPane): Add "store" property to the pane.
2171 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
2172 (App.IndexController.gridChanged): Ditto.
2173 (App.IndexController.actions.addRow): Ditto.
2174 (App.IndexController.init): Ditto.
2175 (App.Pane._fetch): Ditto.
2176 (App.ChartsController._parsePaneList): Ditto.
2177 (App.ChartsController._updateQueryString): Ditto.
2178 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
2179 (App.BuildPopup): Ditto.
2180 (App.AnalysisTaskRoute.model): Ditto.
2181 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
2183 * public/v2/manifest.js:
2184 (App.Manifest.fetch): Removed the code to find the store object.
2186 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
2188 Fix Ember.js warnings the new perf dashboard
2189 https://bugs.webkit.org/show_bug.cgi?id=138531
2191 Reviewed by Darin Adler.
2193 Fixed various warnings.
2196 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
2197 * public/v2/data.js:
2198 (PrivilegedAPI._post): Removed the superfluous console.log.
2199 (CommitLogs.fetchForTimeRange): Ditto.
2200 * public/v2/index.html: Added tbody as required by the HTML specification.
2202 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
2204 Fix typos in r175768.
2207 (App.AnalysisTaskViewModel.roots):
2209 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
2211 Introduce the concept of analysis task to perf dashboard
2212 https://bugs.webkit.org/show_bug.cgi?id=138517
2214 Reviewed by Andreas Kling.
2216 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
2217 a single platform and used to bisect regressions in the range.
2219 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
2221 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
2222 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
2223 test runs. Analysis tasks not associated with test runs are used for try new patches.
2224 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
2225 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
2226 build_requests - A build request represents a single pending build for A/B testing.
2228 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
2232 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
2233 the specified analysis task group as well as build requests associated with them.
2235 (fetch_test_groups_for_task):
2236 (fetch_build_requests_for_task):
2237 (fetch_build_requests_for_group):
2238 (format_test_group):
2239 (format_build_request):
2241 * public/include/json-header.php:
2242 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
2245 * public/privileged-api/associate-bug.php:
2246 (main): Fixed a typo.
2248 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
2251 (ensure_config_from_runs):
2253 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
2255 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
2257 (App.AnalysisTask.create):
2259 (App.TestGroupAdapter):
2260 (App.AnalysisTaskSerializer):
2261 (App.TestGroupSerializer):
2264 * public/v2/app.css: Added style rules for the analysis page.
2267 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
2269 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
2270 exactly one selected point as we can still create an analysis task.
2271 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
2272 grammatical and also alert'ed the error message when there is one.
2273 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
2274 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
2275 once XHR request has completed.
2276 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
2277 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
2278 is selected in the details pane.
2280 (App.AnalysisRoute): Added.
2281 (App.AnalysisTaskRoute): Added.
2282 (App.AnalysisTaskViewModel): Added.
2283 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
2284 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
2285 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
2286 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
2287 the user selects an option for all roots in A or B configuration.
2288 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
2290 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
2292 * public/v2/data.js:
2293 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
2294 point so that we can use it in App.AnalysisTaskViewModel.roots.
2295 (TimeSeries.prototype.findPointByMeasurementId): Added.
2296 (TimeSeries.prototype.seriesBetweenPoints): Added.
2298 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
2299 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
2300 when multiple points are selected. Finally, added a new template for the analysis task page.
2302 * public/v2/manifest.js:
2303 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
2304 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
2305 App.AnalysisTaskViewModel._taskUpdated.
2307 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
2309 Remove App.PaneController.bugsChangeCount in the new perf dashboard
2310 https://bugs.webkit.org/show_bug.cgi?id=138111
2312 Reviewed by Darin Adler.
2315 (App.PaneController.bugsChangeCount): Removed.
2316 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
2317 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
2318 Finds the list of current run's points that are associated with bugs.
2319 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
2320 * public/v2/chart-pane.css:
2321 (.chart .marked): Renamed from .hasBugs.
2322 * public/v2/index.html: Specify chartPointRadius and markedPoints.
2324 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
2326 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
2327 https://bugs.webkit.org/show_bug.cgi?id=138099
2329 Reviewed by Benjamin Poulain.
2331 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
2332 _showDetails inverting the order of the current and old measurements.
2335 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
2336 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
2337 current (latest) measurement and the first point is the oldest measurement.
2338 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
2340 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
2342 Perf dashboard should provide a way to associate bugs with a test run
2343 https://bugs.webkit.org/show_bug.cgi?id=137857
2345 Reviewed by Andreas Kling.
2347 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
2348 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
2349 the Apache configuration.
2352 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
2353 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
2354 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
2355 via the cookie and returns a token computed from those two values as well as the remote username.
2357 The font end code then POST's the request along with the returned token. The server side code verifies
2358 that the specified token can be generated from the salt and the expiration time set in the cookie, and
2359 the token hasn't expired.
2362 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
2363 have zero or exactly one bug associated with a test run.
2365 * public/admin/bug-trackers.php: Added the support for editing bug_url.
2366 * public/api/runs.php:
2367 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
2368 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
2369 an associated bug if there is one.
2370 (format_run): Calls parse_bugs_array.
2372 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
2373 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
2374 have a valid JSON payload.
2375 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
2376 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
2377 the expiration time stored in the cookie.
2378 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
2380 * public/include/manifest.php:
2381 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
2382 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
2384 * public/index.html:
2385 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
2387 * public/privileged-api/associate-bug.php: Added.
2388 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
2389 attack via ensure_privileged_api_data_and_token, which calls verify_token.
2391 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
2393 * public/v2/app.css:
2394 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
2395 selected in a chart.
2398 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
2399 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
2400 they would overlap on each other if both of them are shown.
2401 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
2402 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
2403 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
2404 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
2405 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
2406 showing the search pane.
2407 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
2408 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
2409 bugs in the selected range.
2411 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
2412 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
2413 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
2414 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
2415 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
2416 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
2417 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
2418 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
2420 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
2421 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
2422 to selectionChanged action instead of just finding the first and the last points.
2424 * public/v2/chart-pane.css: Updated the style.
2426 * public/v2/data.js:
2427 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
2428 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
2429 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
2430 we haven't already obtained a CSRF token or if the token has already been expired.
2431 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
2433 (Measurement.prototype.bugs): Added.
2434 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
2435 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
2437 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
2440 * public/v2/manifest.js:
2441 (App.BugTracker.bugUrl):
2442 (App.BugTracker.newBugUrl): Added.
2443 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
2444 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
2445 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
2446 (App.Manifest.bugTrackers): Added.
2447 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
2448 their respective ids to make the ordering stable.
2450 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
2452 Remove unused jobs table
2453 https://bugs.webkit.org/show_bug.cgi?id=137724
2455 Reviewed by Daniel Bates.
2457 Removed jobs table in the database as well as related code.
2459 * init-database.sql:
2460 * public/admin/jobs.php: Removed.
2461 * public/admin/tests.php:
2462 * public/include/admin-header.php:
2464 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2466 New perf dashboard should have an ability to search commits by a keyword
2467 https://bugs.webkit.org/show_bug.cgi?id=137675
2469 Reviewed by Geoffrey Garen.
2471 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
2472 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
2473 This API change allows fetch_commits_between to generate results without processing Postgres query results.
2475 In the front end side, we've added a search pane in pane controller, and the interactive chart component
2476 now has a concept of highlighted items which is used to indicate commits found by the search pane.
2478 * public/api/commits.php:
2479 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
2480 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
2481 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
2482 (format_commit): Renamed from format_commits. Now only formats one commit.
2484 * public/include/db.php:
2485 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
2487 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
2490 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
2491 which is a hash table that contains highlighted items' measurements' ids as keys.
2492 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
2493 the default commit repository.
2494 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
2495 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
2496 Added the code to initialize this._highlights.
2497 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
2498 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
2499 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
2500 the existing lines for the old highlighted items.
2501 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
2502 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
2504 * public/v2/chart-pane.css: Added style for the search pane and the search button.
2506 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
2507 (CommitLogs): Added.
2508 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
2509 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
2510 (CommitLogs._cacheConsecutiveCommits): Ditto.
2511 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
2512 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
2513 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
2515 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
2516 for showingDetails since this property is no longer used.
2518 * public/v2/manifest.js:
2519 (App.Manifest.repositories): Added.
2520 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
2521 the default repository to search.
2522 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
2524 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2526 Unreviewed build fix after r174555.
2528 * public/include/manifest.php:
2529 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
2530 * tests/admin-regenerate-manifest.js: Fixed the test case.
2532 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
2534 New perf dashboard UI tries to fetch commits all the time
2535 https://bugs.webkit.org/show_bug.cgi?id=137592
2537 Reviewed by Andreas Kling.
2539 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
2540 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
2541 no reported commits as they are all going to fail.
2543 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
2544 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
2545 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
2546 of commits sorted chronologically by time.
2548 * public/include/manifest.php:
2551 (App.CommitsViewerComponent.commitsChanged):
2553 * public/v2/data.js:
2554 (FetchCommitsForTimeRange):
2555 (FetchCommitsForTimeRange._cachedCommitsByRepository):
2557 * public/v2/manifest.js:
2560 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2562 Another unreviewed build fix after r174477.
2564 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
2566 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
2568 * public/include/report-processor.php:
2570 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2572 Unreviewed build fix after r174477.
2574 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
2575 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
2577 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
2578 This is necessary for baseline and target values manually added via admin pages.
2580 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2582 Add v2 UI for the perf dashboard
2583 https://bugs.webkit.org/show_bug.cgi?id=137537
2585 Rubber-stamped by Andreas Kling.
2588 * public/v2/app.css: Added.
2589 * public/v2/app.js: Added.
2590 * public/v2/chart-pane.css: Added.
2591 * public/v2/data.js: Added.
2592 * public/v2/index.html: Added.
2593 * public/v2/js: Added.
2594 * public/v2/js/d3: Added.
2595 * public/v2/js/d3/LICENSE: Added.
2596 * public/v2/js/d3/d3.js: Added.
2597 * public/v2/js/d3/d3.min.js: Added.
2598 * public/v2/js/ember-data.js: Added.
2599 * public/v2/js/ember.js: Added.
2600 * public/v2/js/handlebars.js: Added.
2601 * public/v2/js/jquery.min.js: Added.
2602 * public/v2/js/statistics.js: Added.
2603 * public/v2/manifest.js: Added.
2604 * public/v2/popup.js: Added.
2606 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2608 Remove superfluously duplicated code in public/api/report-commits.php.
2610 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2612 Perf dashboard should store commit logs
2613 https://bugs.webkit.org/show_bug.cgi?id=137510
2615 Reviewed by Darin Adler.
2617 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
2619 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
2620 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
2621 a subversion directory. The git version of this script will be added in a follow up patch.
2624 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
2625 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
2626 relationship via "build_commits" relations.
2628 In order to migrate an existing instance of this application, run the following SQL commands:
2632 INSERT INTO commits (commit_repository, commit_revision, commit_time)
2633 (SELECT DISTINCT ON (revision_repository, revision_value)
2634 revision_repository, revision_value, revision_time FROM build_revisions);
2636 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
2637 FROM commits, build_revisions
2638 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
2640 DROP TABLE build_revisions;
2645 The helper script to submit commit logs can be used as follows:
2647 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
2648 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
2650 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
2651 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
2652 "feeder-slave-password" as the builder name and the builder password respectively.
2654 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
2655 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
2658 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
2660 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
2661 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
2663 - Not specified - It returns every single commit for a given repository.
2664 - Matches "oldest" - It returns the commit with the oldest timestamp.
2665 - Matches "latest" - It returns the commit with the latest timestamp.
2666 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
2667 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
2668 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
2669 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
2670 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
2671 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
2673 (commit_from_revision):
2674 (fetch_commits_between):
2677 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
2678 See tests/api-report-commits.js for examples on how to use this API.
2680 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
2681 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
2682 to optimize this and other JSON APIs.
2684 * public/include/db.php:
2685 (Database::select_or_insert_row):
2686 (Database::update_or_insert_row): Added.
2687 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
2688 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
2690 (Database::select_first_row):
2691 (Database::select_last_row): Added.
2692 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
2693 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
2695 * public/include/report-processor.php:
2696 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
2697 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
2698 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
2701 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
2703 * tests/api-report-commits.js: Added.
2704 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
2707 * tools/pull-svn.py: Added. See above for how to use this script.
2709 (determine_first_revision_to_fetch):
2710 (fetch_revision_from_dasbhoard):
2711 (fetch_commit_and_resolve_author):
2714 (resolve_author_name_from_email):
2717 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
2719 Update Install.md for Mavericks and fix typos
2720 https://bugs.webkit.org/show_bug.cgi?id=137276
2722 Reviewed by Benjamin Poulain.
2724 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
2726 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
2728 Finally, init-database.sql is no longer located inside database directory.
2732 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2734 Report run id's in api/runs.php for the new dashboard UI
2735 https://bugs.webkit.org/show_bug.cgi?id=135813
2737 Reviewed by Andreas Kling.
2739 Include run_id in the generated JSON.
2741 * public/api/runs.php:
2742 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
2745 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2747 Merging platforms mixes baselines and targets into reported data
2748 https://bugs.webkit.org/show_bug.cgi?id=135260
2750 Reviewed by Andreas Kling.
2752 When merging two platforms, move test configurations of a different type (baseline, target)
2753 as well as of different metric (Time, Runs).
2755 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
2756 It's sufficient to detect one such test_runs object.
2758 * public/admin/platforms.php:
2761 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
2763 Merging platforms mixes baselines and targets into reported data
2764 https://bugs.webkit.org/show_bug.cgi?id=135260
2766 Reviewed by Geoffrey Garen.
2768 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
2769 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
2771 * public/admin/platforms.php:
2773 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
2775 Build fix after r171361.
2777 * public/js/helper-classes.js:
2778 (.this.formattedBuildTime):
2780 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
2782 Perf dashboard spends 2s processing JSON data during the page loads
2783 https://bugs.webkit.org/show_bug.cgi?id=135152
2785 Reviewed by Andreas Kling.
2787 In the Apple internal dashboard, we were spending as much as 2 seconds
2788 converting raw JSON data into proper JS objects while loading the dashboard.
2790 This caused the apparent unresponsiveness of the dashboard despite of the fact
2791 charts themselves updated almost instantaneously.
2793 * public/index.html:
2794 * public/js/helper-classes.js:
2795 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
2796 lazily as creating new Date objects and running string replace is expensive.
2797 (TestBuild.formattedTime):
2798 (TestBuild.formattedBuildTime):
2799 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
2800 (PerfTestRuns.addResult): Deleted.
2802 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
2804 Perf dashboard shouldn't show the full git hash
2805 https://bugs.webkit.org/show_bug.cgi?id=135083
2807 Reviewed by Benjamin Poulain.
2809 Detect Git/Mercurial hash by checking the length.
2811 If it's a hash, use the first 8 characters in the label
2812 while retaining the full length to be used in hyperlinks.
2814 * public/js/helper-classes.js:
2815 (.this.formattedRevisions):
2818 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
2820 Add an instruction on how to backup the database.
2821 https://bugs.webkit.org/show_bug.cgi?id=133391
2823 Rubber-stamped by Andreas Kling.
2827 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2829 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
2831 * public/js/helper-classes.js:
2832 (PerfTestRuns.smallerIsBetter):
2834 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2838 * public/common.css:
2840 * public/index.html:
2844 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2846 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
2847 https://bugs.webkit.org/show_bug.cgi?id=131157
2849 Reviewed by Andreas Kling.
2851 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
2852 This allows, for example, adding all metrics such as Arithmetic and Geometric for
2853 a given test suite without also adding its subtests.
2855 * public/index.html:
2859 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2861 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
2862 https://bugs.webkit.org/show_bug.cgi?id=131155
2864 Reviewed by Andreas Kling.
2866 The bug was caused by Chart.attach binding event listeners on plot container on each call.
2867 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
2868 click when attach() has been called even number of times, keeping the tooltip invisible.
2870 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
2871 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
2872 is called for the first time.
2874 * public/index.html:
2876 (Chart..bindPlotEventHandlers):
2878 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2880 WebKitPerfMonitor: Tooltips can be cut off at the top
2881 https://bugs.webkit.org/show_bug.cgi?id=130960
2883 Reviewed by Andreas Kling.
2885 * public/common.css:
2886 (#title): Removed the gradients, box shadows, and border from the header.
2887 (#title h1): Reduce the font size.
2888 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
2889 * public/index.html:
2890 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
2891 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
2892 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
2893 * public/js/helper-classes.js:
2894 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
2895 tooltip extending above y=0.
2897 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2899 WebKitPerfMonitor: Y-axis adjustment is too aggressive
2900 https://bugs.webkit.org/show_bug.cgi?id=130937
2902 Reviewed by Andreas Kling.
2904 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
2905 results. This had two major problems:
2906 1. Two standard deviations can be too small to show the confidence interval for results.
2907 2. Sometimes baseline and target can be more than two standards deviations away.
2909 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
2910 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
2911 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
2912 the margin on each side separately to reduce the empty space on either side.
2914 A more rigorous approach would involve computing least squared value of results with respect to intervals
2915 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
2917 * public/index.html:
2918 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
2919 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
2920 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
2921 We wouldn't see the difference between measured values versus baseline and target values otherwise.
2922 * public/js/helper-classes.js:
2923 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
2924 interval delta cannot be computed.
2925 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
2926 within the given interval.
2927 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
2928 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
2929 (PerfTestRuns..unscaledMeansForAllResults):
2930 (PerfTestRuns.min): Take the confidence interval delta into account.
2931 (PerfTestRuns.max): Ditto.
2932 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
2933 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
2935 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
2937 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
2939 Some CSS tweaks after r166477 and r166479,
2941 * public/index.html:
2943 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2945 WebKitPerfMonitor: Sometimes text inside panes overlap
2946 https://bugs.webkit.org/show_bug.cgi?id=130956
2948 Reviewed by Gyuyoung Kim.
2950 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
2951 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
2952 reduces the total height of the pane and fits more information per screen capita on the dashboard.
2954 * public/index.html: Updated and added a bunch of CSS rules for the new look.
2955 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
2956 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
2957 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
2958 of the build info shown in a chart pane and a tooltip.
2959 (Chart): Made .status a table.
2960 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
2961 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
2962 now that status.text no longer contains it.
2963 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
2965 * public/js/helper-classes.js:
2966 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
2967 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
2968 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
2969 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
2970 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
2971 capital letter; e.g. "MB" instead of "M B".
2973 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2975 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
2976 https://bugs.webkit.org/show_bug.cgi?id=130957
2978 Reviewed by Gyuyoung Kim.
2980 Moved the slider into the header. Also reduced the spacing between the header and platform names.
2981 This reclaims 50px × width of the screen real estate.
2983 * public/common.css:
2984 (#title): Reduced the space below the header from 20px to 10px.
2985 * public/index.html:
2986 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
2987 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
2988 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
2989 real estate between the header and the platform names.
2991 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2993 Update the install guidelines for perf.webkit.org
2994 https://bugs.webkit.org/show_bug.cgi?id=129895
2996 Reviewed by Ryosuke Niwa.
2998 The current install guideline for perf.webkit.org discourages the use of the installed
2999 Server application. I've actualized the documentation for Mavericks, and modified the
3000 guideline to include the instructions for Server.app also.
3004 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
3006 Update perf.webkit.org json example
3007 https://bugs.webkit.org/show_bug.cgi?id=129907
3009 Reviewed by Andreas Kling.
3011 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
3015 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
3017 Merge database-common.js and utility.js into run-tests.js.
3019 Reviewed by Matthew Hanson.
3021 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
3022 Also moved init-database.sql out of the database directory and removed the directory entirely.
3024 * database: Removed.
3025 * database/database-common.js: Removed.
3026 * database/utility.js: Removed.
3027 * init-database.sql: Moved from database/init-database.sql.
3029 (connect): Moved from database-common.js.
3030 (pathToDatabseSQL): Extracted from pathToLocalScript.
3031 (pathToTests): Moved from database-common.js.
3034 (SerializedTaskQueue): Ditto.
3036 (initializeDatabase):
3037 (TestEnvironment.it):
3038 (TestEnvironment.queryAndFetchAll):
3041 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
3043 Remove the dependency on node.js from the production code.
3045 Reviewed by Ricky Mondello.
3047 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
3049 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
3050 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
3051 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
3052 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
3053 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
3055 Also removed the js files that are no longer used.
3057 * config.json: Moved from database/config.json.
3058 * database/aggregate.js: Removed. No longer used.
3059 * database/database-common.js: Removed unused functions, and updated the path to config.json.
3060 * database/process-jobs.js: Removed. No longer used.
3061 * database/sample-data.sql: Removed. We have a much better corpus of data now.
3062 * database/schema.graffle: Removed. It's completely obsolete.
3063 * public/include/db.php: Updated the path to config.json.
3064 * public/include/evaluator.js: Removed.
3066 * public/include/report-processor.php:
3067 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
3068 storing values into $expressions and calling evaluate_expressions_by_node.
3069 (TestRunsGenerator::aggregate_values): Added.
3070 (TestRunsGenerator::compute_caches): Directly compute the caches.
3072 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
3074 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
3076 * public/admin/platforms.php:
3077 * public/include/db.php:
3079 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
3081 Zoomed y-axis view is ununsable when the last result is an outlier.
3083 Reviewed by Stephanie Lewis.
3085 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
3086 the last result so that the graph looks sane if the last result was an outlier. However, always show
3087 the last result's mean even if it was an outlier.
3089 * public/index.html:
3090 * public/js/helper-classes.js:
3091 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
3092 Also added the ability to cache the unscaled means to avoid recomputation.
3093 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
3094 (PerfTestRuns.max): Ditto.
3095 (PerfTestRuns.sampleStandardDeviation): Ditto.
3096 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
3098 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
3102 * public/admin/tests.php:
3103 * public/js/helper-classes.js:
3105 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
3107 Use two standard deviations instead as I mentioned in the mailing list.
3109 * public/index.html:
3111 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
3113 The performance dashboard erroneously shows upward arrow for combined metrics.
3115 A single outlier can ruin the zoomed y-axis view.
3117 Rubber-stamped by Antti Koivisto.
3119 * public/index.html:
3120 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
3121 from the latest results' mean.
3122 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
3123 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
3124 (Chart.toggleYAxis):
3125 * public/js/helper-classes.js:
3126 (PerfTestRuns.sampleStandardDeviation): Added.
3127 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
3129 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
3131 Don't include the confidence interval when computing the y-axis.
3133 Rubber-stamped by Simon Fraser.
3135 * public/js/helper-classes.js:
3139 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
3141 Tiny CSS tweak for tooltips.
3143 * public/index.html:
3145 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
3147 Remove the erroneously repeated code.
3149 * public/admin/test-configurations.php:
3151 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
3153 <rdar://problem/15704893> perf dashboard should show baseline numbers
3155 Reviewed by Stephanie Lewis.
3157 * public/admin/bug-trackers.php:
3158 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
3161 * public/admin/platforms.php:
3162 (merge_list): Ditto.