1 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
3 Report run id's in api/runs.php for the new dashboard UI
4 https://bugs.webkit.org/show_bug.cgi?id=135813
6 Reviewed by Andreas Kling.
8 Include run_id in the generated JSON.
10 * public/api/runs.php:
11 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
14 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
16 Merging platforms mixes baselines and targets into reported data
17 https://bugs.webkit.org/show_bug.cgi?id=135260
19 Reviewed by Andreas Kling.
21 When merging two platforms, move test configurations of a different type (baseline, target)
22 as well as of different metric (Time, Runs).
24 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
25 It's sufficient to detect one such test_runs object.
27 * public/admin/platforms.php:
30 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
32 Merging platforms mixes baselines and targets into reported data
33 https://bugs.webkit.org/show_bug.cgi?id=135260
35 Reviewed by Geoffrey Garen.
37 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
38 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
40 * public/admin/platforms.php:
42 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
44 Build fix after r171361.
46 * public/js/helper-classes.js:
47 (.this.formattedBuildTime):
49 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
51 Perf dashboard spends 2s processing JSON data during the page loads
52 https://bugs.webkit.org/show_bug.cgi?id=135152
54 Reviewed by Andreas Kling.
56 In the Apple internal dashboard, we were spending as much as 2 seconds
57 converting raw JSON data into proper JS objects while loading the dashboard.
59 This caused the apparent unresponsiveness of the dashboard despite of the fact
60 charts themselves updated almost instantaneously.
63 * public/js/helper-classes.js:
64 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
65 lazily as creating new Date objects and running string replace is expensive.
66 (TestBuild.formattedTime):
67 (TestBuild.formattedBuildTime):
68 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
69 (PerfTestRuns.addResult): Deleted.
71 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
73 Perf dashboard shouldn't show the full git hash
74 https://bugs.webkit.org/show_bug.cgi?id=135083
76 Reviewed by Benjamin Poulain.
78 Detect Git/Mercurial hash by checking the length.
80 If it's a hash, use the first 8 characters in the label
81 while retaining the full length to be used in hyperlinks.
83 * public/js/helper-classes.js:
84 (.this.formattedRevisions):
87 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
89 Add an instruction on how to backup the database.
90 https://bugs.webkit.org/show_bug.cgi?id=133391
92 Rubber-stamped by Andreas Kling.
96 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
98 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
100 * public/js/helper-classes.js:
101 (PerfTestRuns.smallerIsBetter):
103 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
113 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
115 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
116 https://bugs.webkit.org/show_bug.cgi?id=131157
118 Reviewed by Andreas Kling.
120 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
121 This allows, for example, adding all metrics such as Arithmetic and Geometric for
122 a given test suite without also adding its subtests.
128 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
130 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
131 https://bugs.webkit.org/show_bug.cgi?id=131155
133 Reviewed by Andreas Kling.
135 The bug was caused by Chart.attach binding event listeners on plot container on each call.
136 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
137 click when attach() has been called even number of times, keeping the tooltip invisible.
139 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
140 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
141 is called for the first time.
145 (Chart..bindPlotEventHandlers):
147 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
149 WebKitPerfMonitor: Tooltips can be cut off at the top
150 https://bugs.webkit.org/show_bug.cgi?id=130960
152 Reviewed by Andreas Kling.
155 (#title): Removed the gradients, box shadows, and border from the header.
156 (#title h1): Reduce the font size.
157 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
159 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
160 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
161 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
162 * public/js/helper-classes.js:
163 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
164 tooltip extending above y=0.
166 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
168 WebKitPerfMonitor: Y-axis adjustment is too aggressive
169 https://bugs.webkit.org/show_bug.cgi?id=130937
171 Reviewed by Andreas Kling.
173 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
174 results. This had two major problems:
175 1. Two standard deviations can be too small to show the confidence interval for results.
176 2. Sometimes baseline and target can be more than two standards deviations away.
178 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
179 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
180 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
181 the margin on each side separately to reduce the empty space on either side.
183 A more rigorous approach would involve computing least squared value of results with respect to intervals
184 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
187 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
188 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
189 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
190 We wouldn't see the difference between measured values versus baseline and target values otherwise.
191 * public/js/helper-classes.js:
192 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
193 interval delta cannot be computed.
194 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
195 within the given interval.
196 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
197 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
198 (PerfTestRuns..unscaledMeansForAllResults):
199 (PerfTestRuns.min): Take the confidence interval delta into account.
200 (PerfTestRuns.max): Ditto.
201 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
202 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
204 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
206 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
208 Some CSS tweaks after r166477 and r166479,
212 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
214 WebKitPerfMonitor: Sometimes text inside panes overlap
215 https://bugs.webkit.org/show_bug.cgi?id=130956
217 Reviewed by Gyuyoung Kim.
219 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
220 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
221 reduces the total height of the pane and fits more information per screen capita on the dashboard.
223 * public/index.html: Updated and added a bunch of CSS rules for the new look.
224 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
225 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
226 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
227 of the build info shown in a chart pane and a tooltip.
228 (Chart): Made .status a table.
229 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
230 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
231 now that status.text no longer contains it.
232 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
234 * public/js/helper-classes.js:
235 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
236 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
237 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
238 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
239 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
240 capital letter; e.g. "MB" instead of "M B".
242 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
244 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
245 https://bugs.webkit.org/show_bug.cgi?id=130957
247 Reviewed by Gyuyoung Kim.
249 Moved the slider into the header. Also reduced the spacing between the header and platform names.
250 This reclaims 50px × width of the screen real estate.
253 (#title): Reduced the space below the header from 20px to 10px.
255 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
256 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
257 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
258 real estate between the header and the platform names.
260 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
262 Update the install guidelines for perf.webkit.org
263 https://bugs.webkit.org/show_bug.cgi?id=129895
265 Reviewed by Ryosuke Niwa.
267 The current install guideline for perf.webkit.org discourages the use of the installed
268 Server application. I've actualized the documentation for Mavericks, and modified the
269 guideline to include the instructions for Server.app also.
273 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
275 Update perf.webkit.org json example
276 https://bugs.webkit.org/show_bug.cgi?id=129907
278 Reviewed by Andreas Kling.
280 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
284 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
286 Merge database-common.js and utility.js into run-tests.js.
288 Reviewed by Matthew Hanson.
290 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
291 Also moved init-database.sql out of the database directory and removed the directory entirely.
294 * database/database-common.js: Removed.
295 * database/utility.js: Removed.
296 * init-database.sql: Moved from database/init-database.sql.
298 (connect): Moved from database-common.js.
299 (pathToDatabseSQL): Extracted from pathToLocalScript.
300 (pathToTests): Moved from database-common.js.
303 (SerializedTaskQueue): Ditto.
305 (initializeDatabase):
306 (TestEnvironment.it):
307 (TestEnvironment.queryAndFetchAll):
310 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
312 Remove the dependency on node.js from the production code.
314 Reviewed by Ricky Mondello.
316 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
318 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
319 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
320 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
321 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
322 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
324 Also removed the js files that are no longer used.
326 * config.json: Moved from database/config.json.
327 * database/aggregate.js: Removed. No longer used.
328 * database/database-common.js: Removed unused functions, and updated the path to config.json.
329 * database/process-jobs.js: Removed. No longer used.
330 * database/sample-data.sql: Removed. We have a much better corpus of data now.
331 * database/schema.graffle: Removed. It's completely obsolete.
332 * public/include/db.php: Updated the path to config.json.
333 * public/include/evaluator.js: Removed.
335 * public/include/report-processor.php:
336 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
337 storing values into $expressions and calling evaluate_expressions_by_node.
338 (TestRunsGenerator::aggregate_values): Added.
339 (TestRunsGenerator::compute_caches): Directly compute the caches.
341 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
343 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
345 * public/admin/platforms.php:
346 * public/include/db.php:
348 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
350 Zoomed y-axis view is ununsable when the last result is an outlier.
352 Reviewed by Stephanie Lewis.
354 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
355 the last result so that the graph looks sane if the last result was an outlier. However, always show
356 the last result's mean even if it was an outlier.
359 * public/js/helper-classes.js:
360 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
361 Also added the ability to cache the unscaled means to avoid recomputation.
362 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
363 (PerfTestRuns.max): Ditto.
364 (PerfTestRuns.sampleStandardDeviation): Ditto.
365 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
367 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
371 * public/admin/tests.php:
372 * public/js/helper-classes.js:
374 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
376 Use two standard deviations instead as I mentioned in the mailing list.
380 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
382 The performance dashboard erroneously shows upward arrow for combined metrics.
384 A single outlier can ruin the zoomed y-axis view.
386 Rubber-stamped by Antti Koivisto.
389 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
390 from the latest results' mean.
391 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
392 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
394 * public/js/helper-classes.js:
395 (PerfTestRuns.sampleStandardDeviation): Added.
396 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
398 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
400 Don't include the confidence interval when computing the y-axis.
402 Rubber-stamped by Simon Fraser.
404 * public/js/helper-classes.js:
408 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
410 Tiny CSS tweak for tooltips.
414 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
416 Remove the erroneously repeated code.
418 * public/admin/test-configurations.php:
420 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
422 <rdar://problem/15704893> perf dashboard should show baseline numbers
424 Reviewed by Stephanie Lewis.
426 * public/admin/bug-trackers.php:
427 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
430 * public/admin/platforms.php:
433 * public/admin/test-configurations.php: Added.
434 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
435 build_revisions as they're not meaningful for baseline / target numbers.
436 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
437 one test run so that we don't accidentally delete a reported test run.
438 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
439 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
440 and delete existing ones.
442 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
443 on each platform; there could be configurations of distinct types such as "current" and "baseline".
444 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
446 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
447 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
448 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
449 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
450 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
452 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
454 * public/include/admin-header.php:
455 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
456 have id and type sub columns, and each custom column could generate multiple rows.
458 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
459 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
460 We then proceed to generate the second header row with sub column names.
462 When generating the actual content, we first generate all custom columns as they may have multiple rows in
463 which case regular columns need rowspan set to the maximum number of rows.
465 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
468 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
469 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
470 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
471 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
472 expanded to occupy all sub columns.
474 * public/include/manifest.php:
475 (ManifestGenerator::platforms): Don't add the metric more than once.
477 * public/include/test-name-resolver.php:
478 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
479 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
480 full metric name later.
481 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
482 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
483 (TestNameResolver::full_name_for_test): Added.
484 (TestNameResolver::full_name_for_metric): Added.
485 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
487 * public/js/helper-classes.js:
488 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
489 test runs created to set baseline and target points.
491 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
493 Build fix after r57928. Removed a superfluous close parenthesis.
495 * public/api/runs.php:
497 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
499 Unreviewed build & typo fixes.
501 * public/admin/platforms.php:
502 * tests/admin-platforms.js:
504 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
506 <rdar://problem/15704893> perf dashboard should show baseline numbers
508 Rubber-stamped by Antti Koivisto.
510 Organize some code into functions in runs.php.
512 Also added back $paths that was erroneously removed in r57925 from json-header.php.
514 * public/api/runs.php:
515 (fetch_runs_for_config): Extracted.
518 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
520 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
522 * database/config.json:
523 * public/admin/reprocess-report.php:
524 * public/api/report.php:
525 * public/api/runs.php:
526 * public/include/json-header.php:
528 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
530 Commit yet another forgotten change.
532 Something went horribly wrong with my merge :(
534 * database/init-database.sql:
536 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
538 Commit one more forgotten change. Sorry for making a mess here.
540 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
542 Commit the forgotten files.
544 * public/admin/platforms.php: Added.
545 * tests/admin-platforms.js: Added.
547 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
549 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
551 Reviewed by Stephanie Lewis.
553 Added /admin/platforms/ page to hide and merge platforms.
555 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
556 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
557 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
558 each test configuration a distinct "test run" for each build.
560 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
561 their test configurations into platform B.
563 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
564 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
565 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
566 in platform B, in which case R should relate to T_B instead.
568 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
569 new platform. We then migrate the test configurations of the remaining test runs.
571 * database/init-database.sql: Added platform_hidden.
573 * public/admin/platforms.php: Added.
574 (merge_platforms): Added. Implements the algorithm described above.
577 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
578 is hidden since it doesn't do anything.
580 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
581 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
582 missing it since unchecked checkbox doesn't set the value in $_POST.
583 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
584 switch statement instead of repeated if's.
585 (AdministrativePage::render_table): Emit "update-column" for update_field.
587 * public/include/db.php: Disable warnings when we're not in the debug mode.
589 * public/include/manifest.php:
590 (ManifestGenerator::platforms): Skip platforms that have been hidden.
593 (TestEnvironment.postJSON):
594 (TestEnvironment.httpGet):
595 (TestEnvironment.httpPost): Added.
596 (sendHttpRequest): Set the content type if specified.
598 * tests/admin-platforms.js: Added tests.
600 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
602 Extract the code to compute full test names from tests.php.
604 Reviewed by Stephanie Lewis.
606 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
607 and paves our way to re-use the code in other pages.
609 * public/admin/tests.php:
611 * public/include/db.php:
612 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
613 tests.php and test-name-resolver.php.
615 * public/include/test-name-resolver.php: Added.
616 (TestNameResolver::__construct):
617 (TestNameResolver::compute_full_name): Moved from tests.php.
618 (TestNameResolver::map_metrics_to_tests): Ditto.
619 (TestNameResolver::sort_tests_by_full_name): Ditto.
620 (TestNameResolver::tests): Added.
621 (TestNameResolver::test_id_for_full_name): Ditto.
622 (TestNameResolver::metrics_for_test_id): Ditto.
623 (TestNameResolver::child_metrics_for_test_id): Ditto.
624 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
626 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
628 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
630 Reviewed by Stephanie Lewis.
632 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
634 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
635 but that's sufficient to correct the wrongfully processed reports for now.
637 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
638 We should eventually add a nice UI to find and reprocess reports.
640 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
642 * public/include/db.php: Added the forgotten call to prefixed_column_names.
644 * public/include/report-processor.php: Copied from public/api/report.php.
645 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
646 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
647 create a new report or authenticate the builder password (the password is never stored in the report).
648 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
649 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
650 (ReportProcessor::store_report): Ditto.
652 * tests/admin-reprocess-report.js: Added.
654 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
656 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
658 Reviewed by Ricky Mondello.
660 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
661 for the same build number as a single build by ignoring build time. This was necessary to associate
662 multiple reports by a single build - e.g. for different performance test suites - because the scripts
663 we use to submit results computed its own "build time" when they're called.
665 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
666 last week; new reports were wrongfully associated with old build numbers.
668 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
669 to the same build. Instead, we create a new build object for those reports. Since the longest set of
670 tests we have only take a couple of hours to run, 24 hours should be more than enough.
672 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
673 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
674 (builder, build number, build time).
676 * public/api/report.php:
677 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
678 when no such build exists. This prevents a report from being associated with a very old build of the same
681 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
682 a similar bug in the future sooner.
684 * tests/api-report.js: Added three test cases.
686 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
688 Merged the upstream changes to db.php
689 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
691 * public/include/db.php:
693 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
695 Update other scripts and tests per previous patch.
697 * public/include/manifest.php:
698 * tests/admin-regenerate-manifest.js:
700 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
704 Reviewed by Ricky Mondello.
706 This column is no longer used by the front-end code since r48360.
708 * database/init-database.sql:
709 * public/admin/tests.php:
711 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
713 Unreviewed build fix.
715 * public/api/report.php:
717 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
719 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
721 Reviewed by Ricky Mondello.
723 Support a new alternative format for aggregated results where we have raw values as well as
724 the list aggregators so that instead of
725 "metrics": {"Time": ["Arithmetic"]}
727 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
729 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
730 dashboard and the generated results page, which doesn't know how to aggregate values.
732 We need to keep the support for the old format because all other existing performance tests
733 all rely on the old format. Even if we updated the tests, we need the dashboard to support
734 the old format during the transition.
736 * public/api/report.php:
737 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
738 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
740 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
742 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
744 Unreviewed; Tweak the CSS so that chart panes align vertically.
748 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
750 SafariPerfMonitor should support Combined metric.
752 * public/js/helper-classes.js:
753 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
754 value as well but assume it to be greater-is-better for now.
756 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
758 Commit the forgotten init-database change to add iteration_relative_time.
760 * database/init-database.sql:
762 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
764 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
766 Reviewed by Ricky Mondello.
768 Add the support for each value to have a relative time. This is necessary for frame rate history
769 since a frame rate needs to be associated with a time it was sampled.
771 * database/init-database.sql: Added iteration_relative_time to run_iterations.
773 * public/api/report.php:
774 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
775 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
776 with relative time since taking the average of two frame rates for two subtests taken at two
777 different times doesn't make any sense.
778 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
779 etc..., use the second element since we assume values are of the form (relative time, frame rate).
780 Also exit early with an error if the number of elements in the array is not a pair.
781 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
783 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
784 iteration_relative_time.
786 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
788 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
790 Reviewed by Ricky Mondello.
792 Support that. It's one line change.
794 * public/api/report.php:
795 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
796 to match the convention assumed elsewhere.
797 * tests/api-report.js: Added a test case.
799 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
801 SafariPerfMonitor shows popups for points outside of the visible region.
803 Rubber-stamped by Simon Fraser.
806 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
807 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
808 may return an item underneath y-axis labels.
810 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
812 Tweak the CSS a little to avoid the test name overlapping with the summary table.
816 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
818 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
822 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
824 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
825 <rdar://problem/13992271> Should scale Y axis to include error ranges
827 Reviewed by Ricky Mondello.
829 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
830 the main graph doesn't go outside the graph even when the y-axis is adjusted.
832 * database/config.json:
834 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
835 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
836 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
838 * public/js/helper-classes.js:
839 (PerfTestResult.confidenceIntervalDelta):
840 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
841 (PerfTestRuns.min): Take confidence interval delta into account.
842 (PerfTestRuns.max): Ditto.
843 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
845 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
847 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
849 * public/api/report.php:
850 (ReportProcessor::recursively_ensure_tests):
851 * tests/api-report.js: Added a test.
853 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
855 Unreviewed build fixes.
857 * public/api/report.php:
858 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
859 Also, tolerate reports without any revision information.
861 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
864 * tests/api-report.js: Added few test cases.
866 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
868 Commit another change that was supposed to be committed in r50331.
871 (TestEnvironment.this.postJSON):
872 (TestEnvironment.this.httpGet):
875 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
877 Commit the remaining files.
879 * public/admin/regenerate-manifest.php:
880 * public/include/admin-header.php:
881 * public/include/json-header.php:
882 * public/include/manifest.php:
884 (TestEnvironment.this.postJSON):
885 (TestEnvironment.this.httpGet):
888 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
890 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
892 Reviewed by Ricky Mondello.
894 Added some tests for admin/regenerate-manifest.
896 * public/admin/regenerate-manifest.php: Use require_once instead of require.
897 * public/include/admin-header.php: Ditto.
898 * public/include/json-header.php: Ditto.
900 * public/include/manifest.php:
901 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
902 When there are no builders, simply return an empty array.
905 (TestEnvironment.postJSON):
906 (TestEnvironment.httpGet): Added.
907 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
909 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
911 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
913 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
914 and run_iterations. Also fixed a typo in report.php found by new tests.
916 * public/api/report.php:
917 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
918 * tests/api-report.js: Added more test cases.
920 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
922 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
924 Reviewed by Ricky Mondello.
926 Add a test runner script and some simple test cases.
928 * database/config.json: Added the configuration for "testServer".
929 * database/database-common.js:
930 (pathToTests): Added.
931 * run-tests.js: Added.
934 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
935 and if there are, asks the user if it’s okay to delete all of the data contained therein.
936 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
938 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
939 in the current database using PostgreSQL's information_schema.
940 (askYesOrNoQuestion):
942 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
944 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
945 (TestEnvironment.assert): Exposes assert to tests.
946 (TestEnvironment.console): Exposes console to tests.
947 (TestEnvironment.describe): Adds a description.
948 (TestEnvironment.it): Adds a test case.
949 (TestEnvironment.postJSON):
950 (TestEnvironment.queryAndFetchAll):
951 (TestEnvironment.sha256):
952 (TestEnvironment.notifyDone): Ends the current test case.
956 (TestContext): An object created for each test case. Conceptually, this object is always on
957 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
958 this object via currentTestContext.
959 (TestContext.description):
961 (TestContext.logError):
964 * tests/api-report.js: Added some basic tests for /api/report.php.
966 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
968 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
970 The problem was that we were detecting whether we're updating dashboard or not by checking
971 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
972 all configurations. Use separate 'dashboard' action to execute the code even when
973 metric_configurations is empty.
975 * public/admin/tests.php:
977 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
979 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
981 Reviewed by Ricky Mondello.
983 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
984 from ReportProcessor as a preparation to replace deprecated aggregate.js.
986 * public/api/report.php:
987 (ReportProcessor::exit_with_error): Moved.
988 (ReportProcessor::process): Use the extracted TestRunsGenerator.
989 (TestRunsGenerator): Added.
990 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
991 (TestRunsGenerator::add_aggregated_metric): Moved.
992 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
993 (TestRunsGenerator::aggregate): Moved. Made public.
994 (TestRunsGenerator::aggregate_current_test_level): Moved.
995 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
996 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
997 (TestRunsGenerator::compute_caches): Moved. Made public.
998 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
999 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
1000 (TestRunsGenerator::rollback_with_error): Moved.
1002 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1004 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
1006 Reviewed by Remy Demarest.
1008 Regenerate the manifest file when updating fields or adding new items that are included in
1011 * public/admin/bug-trackers.php:
1012 * public/admin/builders.php:
1013 * public/admin/regenerate-manifest.php:
1014 * public/admin/repositories.php:
1015 * public/admin/tests.php:
1016 * public/include/admin-header.php:
1017 (regenerate_manifest): Extracted from regenerate-manifest.php.
1019 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1021 Unreviewed build fix for memory test results.
1023 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
1024 aggregating at each level.
1026 * public/api/report.php:
1027 (ReportProcessor::recursively_ensure_tests):
1028 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
1029 (ReportProcessor::add_values_for_aggregation):
1030 (ReportProcessor::aggregate):
1031 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
1033 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1035 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
1036 not the number of iteration groups. Also, don't set group number when the entire run belongs
1037 a single iteration group.
1039 * public/api/report.php:
1040 (ReportProcessor::commit):
1042 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1044 SafariPerfMonitor: Introduce iteration groups
1046 Reviewed by Remy Demarest.
1048 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
1049 the runtime environment variances to get more stable results. And it's desirable to keep track of
1050 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
1052 This patch introduces "iteration groups" to keep track of this extra information.
1054 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
1055 the outer array denotes iteration groups and each inner array contains iteration values for each group.
1058 * database/init-database.sql: Add iteration_group column.
1059 * public/api/report.php:
1060 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
1062 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
1063 contains the list of values indexed by the iteration order and group sizes. Store the group size so
1064 that we can restore the iteration groups before passing it to node.js and restore them later.
1066 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
1067 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
1069 Also check that each iteration group in each subtest are consistent with one another. To see why we need
1070 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
1071 that each iteration group in T1 and T2 have the same size:
1072 T1 = [[1, 2], [3, 4, 5]]
1073 T2 = [[6, 7], [8, 9, 10]]
1075 so that the aggregated result (the sum in this case) can have the same groups as in:
1076 T = [[7, 9], [11, 13, 15]]
1078 If some iteration groups in T1 and T2 had a different size as in:
1079 T1 = [[1, 2, 3], [4, 5]]
1080 T2 = [[6, 7], [8, 9, 10]]
1082 Then iteration groups of the aggregated T is ambiguous.
1084 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
1085 (ReportProcessor::commit): Store iteration_group values.
1087 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1089 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
1090 migrated to perf.webkit.org.
1092 * database/perf-webkit-migrator.js: Removed.
1094 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1096 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
1098 * public/index.html:
1101 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1103 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
1105 Reviewed by Ricky Mondello.
1107 It is often desirable to see charts of a given test for all platforms, or to be able to see
1108 charts of all subtests on a given platform when trying to triage perf. regressions.
1110 Support this use case by adding the ability to do so on the charts page.
1112 Also, we used to disable items on the test list based on the platform chosen. This turned out
1113 to be a bad UI because in many situations you want to be able to compare results of the same test
1114 on multiple platforms.
1116 In this new UI, we have three select elements, each of which selects the following:
1117 1. Top-level test - Test suite such as Dromaeo
1118 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
1119 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
1120 3. Platform - Mountain Lion, Qt, etc...
1122 A user can select "all" for metric and platform but we disallow doing both at once since adding
1123 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
1124 think of a use case where you want to look at that many charts at once. We can support this later
1125 if valid use cases come up.
1127 * public/index.html:
1128 (.showCharts.addOption): Extracted.
1129 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
1130 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
1131 metricList has onchange handler that enables/disables items on platformList.
1133 (init): Sort tests and test metrics here instead of doing that in showCharts.
1135 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
1137 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
1139 Reviewed by Remy Demarest and Ricky Mondello.
1141 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
1142 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
1143 templates to the manifest file instead. Each build now only contains the builder id.
1145 * public/api/runs.php: Removed the part of the query that joined builders table. This
1146 speeds up the query quite a bit.
1148 * public/include/manifest.php:
1149 (ManifestGenerator::generate): Generate builders field.
1150 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
1151 associative array that contains name and its build URL template.
1153 * public/index.html:
1154 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
1155 instead of a revision since this function is used for revisions and build page URLs now.
1156 (.buildLabelWithLinks): Include the linkified build number.
1158 * public/js/helper-classes.js:
1159 (TestBuild.builder): Added.
1160 (TestBuild.buildNumber): Added.
1161 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
1162 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
1164 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
1166 Tooltips interfere with user interactions
1168 Rubber-stamped by Simon Fraser.
1170 Disable tooltip on the dashboard page since graphs are too small to be useful there.
1171 Also, show graphs for only 10 days by default as opposed to 20.
1172 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
1174 * public/index.html:
1175 * public/js/helper-classes.js:
1177 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
1179 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
1180 to be compatible with webkit-perf.appspot.com.
1182 * public/admin/builders.php:
1183 * public/api/report.php:
1185 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
1189 Add a missing constraint on builds table. For a given builder, there should be exactly
1190 one build for a given build number.
1192 Also add report_committed_at to reports table to record the time at which a given report
1193 was processed and test_runs and run_iterations rows were committed into the database.
1195 * database/config.json:
1196 * public/api/report.php:
1198 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
1200 Unreviewed. Add more checks for empty SQL query results.
1202 * public/include/manifest.php:
1204 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1206 More build fixes on perf.webkit.org.
1208 * public/api/runs.php: Make PostgreSQL happier.
1209 * public/include/manifest.php: Don't assume we always have bug trackers.
1211 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1213 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
1214 and fix other miscellaneous UI bugs.
1216 Rubber-stamped by Simon Fraser.
1218 Removed the code to determine whether smaller value is better or not for a given test in index.html
1219 in the favor of using that of PerfTestRuns.
1221 * public/include/manifest.php: Fixed a typo.
1222 * public/index.html:
1224 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
1226 * public/js/helper-classes.js:
1227 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
1229 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
1230 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
1231 at roughly 2,000 units to avoid this.
1233 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
1234 The only thing we can avoid is innerHTML.
1236 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1238 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
1240 * public/include/evaluator.js:
1242 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1244 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
1246 Reviewed by Remy Demarest.
1248 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
1249 admin/bug-trackers.php and can be associated with multiple repositories.
1251 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
1252 to determine the set of bug trackers to show for a given set of blame lists.
1253 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
1254 a place to file bugs against the regression.
1256 * database/init-database.sql: Added bug_trackers and tracker_repositories.
1257 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
1259 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
1260 bug trackers, namely associated repositories.
1262 * public/include/admin-header.php: Added a link to bug-trackers.php
1263 * public/include/manifest.php:
1264 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
1265 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
1267 (ManifestGenerator::repositories):
1269 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
1270 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
1271 'repositories' where the latter contains the list of associated repository names.
1273 * public/index.html:
1274 (Chart): Takes bugTrackers as as argument.
1275 (Chart.showTooltipWithResults): Removed the hard-coded list.
1277 (init.addPlatformsToDashboard):
1278 (init.showCharts.createChartFromListPair):
1279 (init): Stores the list of bug trackers in the manifest to a local variable.
1281 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1283 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
1285 * public/include/evaluator.js:
1287 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1289 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
1291 Reviewed by Remy Demarest.
1293 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
1294 new row into the database.
1296 * public/admin/aggregators.php: Use AdministrativePage.
1297 * public/admin/builders.php: Ditto.
1298 * public/admin/repositories.php: Ditto.
1299 * public/include/admin-header.php:
1300 (AdministrativePage): Added.
1301 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
1302 to an associative array that describes the column.
1303 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
1304 - label: Human readable name of the column.
1305 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
1306 column exists only before we create password_hash column at the insertion time.
1308 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
1309 titlecase (e.g. new_bug is converted to New Bug).
1310 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
1311 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
1312 textarea for a given editing mode ('text', 'url', or 'string').
1313 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
1314 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
1316 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
1318 Build fix. Some systems don't support r+. Use proc_open instead.
1320 * public/api/report.php:
1322 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1324 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
1325 when computing the y-axis of data points to show tooltips at.
1327 * public/index.html:
1329 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1331 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
1334 * public/.htaccess: Removed.
1336 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
1340 * public/include/manifest.php: Build fix. db is on this.
1341 * public/js/statistics.js:
1342 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
1344 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
1346 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
1348 Reviewed by Anders Carlsson.
1350 Rewrote and merged populate-from-report.js into report.php.
1352 * database/config.json: Added a path to node.js.
1354 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
1355 Once we land this patch and update the administrative pages, we can remove this column.
1357 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
1358 that table is going away once we remove the node.js backend.
1360 * database/populate-from-report.js: Removed.
1361 * public/api/report.php: Added.
1363 (ReportProcessor.__construct):
1364 (ReportProcessor.process):
1366 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
1367 verified to be submitted by a known builder.
1369 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
1370 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
1371 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
1372 inside a transaction because there could be multiple reports for a single build, each containing results for
1375 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
1376 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
1377 add_values_to_commit, and add_values_for_aggregation.
1379 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
1380 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
1381 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
1384 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
1385 to be aggregated in ReportProcessor.aggregate.
1387 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
1389 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
1390 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
1391 given for each row (child metrics of M). This function extracts each column (iteration) via
1392 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
1393 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
1395 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
1396 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
1397 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
1399 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
1400 (ReportProcessor.evaluate_expressions_by_node): See above.
1402 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
1403 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
1404 results also need the said caches.
1406 (ReportProcessor.add_values_to_commit):
1408 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
1409 the transaction as needed if anything goes wrong.
1411 (ReportProcessor.rollback_with_error)
1413 * public/include/db.php:
1414 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
1415 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
1416 contiguously in a SQL statement.
1418 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
1419 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
1420 a column value of the choice.
1422 (Database.begin_transaction): Added.
1423 (Database.commit_transaction): Added.
1424 (Database.rollback_transaction): Added.
1426 * public/include/evaluator.js: Added.
1427 * public/include/json-header.php:
1428 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
1429 context under which the request failed.
1430 (successful_exit): Merge "additional details".
1431 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
1432 (merge_additional_details):
1434 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
1436 SafariPerfMonitor: Add more helper functions to db.php
1438 Reviewed by Remy Demarest.
1440 Added Database::insert_row and array_get to make common database operations easier.
1442 * public/admin/aggregators.php: Use Database::insert_row instead of
1443 execute_query_and_expect_one_row_to_be_affected.
1445 * public/admin/builders.php: Ditto.
1447 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
1448 inserting a row. With insert_row, we don't need that.
1450 * public/include/admin-header.php: Ditto.
1452 * public/include/db.php:
1453 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
1454 return the default value (defaults to NULL) if the key doesn't exist.
1456 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
1459 (Database::prepare_params): Added. Takes an associative array of column names and their values,
1460 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
1461 column names all in the same order.
1463 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
1464 the given prefix. Values are given in a form of an associative array where keys are unprefixed
1465 column names and values are corresponding values. When the row is successfully inserted, it returns
1466 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
1467 indicating the success of the insertion.
1469 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1471 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
1473 Reviewed by Conrad Shultz.
1475 Rewrote the manifest generator in PHP.
1477 * database/generate-manifest.js: Removed.
1478 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
1479 * public/include/db.php:
1480 (array_ensure_item_has_array): Added.
1481 * public/include/evaluator.js: Added.
1482 * public/include/json-header.php:
1483 * public/include/manifest.php: Added.
1485 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1487 Dates on overflow plot are overlapping
1489 Rubber-stamped by Simon Fraser.
1491 Don't show more than 5 days.
1493 * public/index.html:
1494 * public/js/helper-classes.js:
1495 (TestBuild.UTCtoPST):
1498 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1500 Show build time as well as commit time on the dashboard and tooltips.
1502 Rubber-stamped by Simon Fraser.
1504 Include both the maximum commit time and build time in buildLabelWithLinks.
1505 Also use ISO format to save the screen real estate.
1507 * public/index.html:
1508 (buildLabelWithLinks):
1509 * public/js/helper-classes.js:
1511 (TestBuild.buildTime):
1512 (TestBuild.formattedBuildTime):
1514 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
1516 Unreviewed; Convert metric.name to metric.unit in the front end.
1518 * public/js/helper-classes.js:
1520 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1522 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
1524 Rubber-stamped by Simon Fraser.
1526 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
1527 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
1528 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
1530 * public/index.html:
1531 (.buildLabelWithLinks): Extracted from TestBuild.label.
1532 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
1533 on Radar and WebKit Bugzilla.
1534 * public/js/helper-classes.js:
1535 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
1536 (PerfTestResult.isBetterThan): Added.
1537 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
1538 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
1539 to indicate progressions or regressions.
1540 (PerfTestResult.label):
1541 (TestBuild.formattedTime): Added.
1542 (TestBuild.platform): Added.
1543 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
1544 (TestBuild.smallerIsBetter): Added.
1545 (Tooltip.show): Take a raw markup instead of two results.
1547 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
1549 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
1551 Rubber-stamped by Tim Horton.
1553 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
1554 since each platform may have a different number of tests to be shown on the dashboard.
1556 * public/index.html:
1558 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1560 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
1562 * public/js/helper-classes.js:
1565 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1567 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
1569 Rubber-stamped by Tim Horton.
1571 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
1573 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
1574 the revision r1234 was the revision used in the previous build.
1576 * public/api/runs.php:
1577 (parse_revisions_array): Trim double quotations around repository names and revisions.
1578 * public/js/helper-classes.js:
1581 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1583 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
1585 Rubber-stamped by Tim Horton.
1587 * public/index.html:
1588 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
1589 on the dashboard page as it's way too noisy.
1591 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
1593 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
1594 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
1595 so that the tooltip for hover can be reused further.
1597 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
1598 and find the first point that lies on the right of the cursor position. We then compute the midpoint
1599 between this and the previous point and pick the closer of the two. It returns an item-like object
1600 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
1602 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
1604 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
1605 the first or "current" data points (as opposed to target or baseline data points).
1607 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
1608 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
1609 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
1611 * public/js/helper-classes.js:
1612 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
1613 work to the client via bindClick.
1615 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
1617 (Tooltip.bindClick): Added.
1619 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1621 Yet another build fix. metricId*s*.
1623 * public/admin/tests.php:
1625 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1627 Another build fix. Use the new payload format for the aggregate job.
1629 * public/admin/tests.php:
1631 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1635 * database/aggregate.js: Use variables that actually exist.
1636 * database/database-common.js:
1637 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
1638 function calls will find this configuration.
1640 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1642 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
1644 Reviewed by Ricky Mondello.
1646 Turned InstallManual into a proper markdown document and added ReadMe.md.
1648 * InstallManual: Removed.
1649 * InstallManual.md: Moved from InstallManual.
1652 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1654 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
1656 Reviewed by Ricky Mondello.
1658 This patch prepares the front end code to process baseline and target results properly.
1660 * public/index.html:
1661 (fetchTest.createRunAndResults): Extracted.
1662 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
1663 Deleted the comment about how sorting will be unnecessary once we start results in the server side
1664 since sorting by the maximum revision commit time turned out to be non-trivial in php.
1666 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1668 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
1670 Reviewed by Tim Horton.
1672 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
1673 These files are "dynamically linked" to our app.
1675 * public/index.html:
1676 * public/js/jquery-1.8.2.min.js: Removed.
1677 * public/js/jquery.colorhelpers.js: Added.
1678 * public/js/jquery.flot.categories.js: Added.
1679 * public/js/jquery.flot.crosshair.js: Added.
1680 * public/js/jquery.flot.errorbars.js: Added.
1681 * public/js/jquery.flot.fillbetween.js: Added.
1682 * public/js/jquery.flot.js: Added.
1683 * public/js/jquery.flot.min.js: Removed.
1684 * public/js/jquery.flot.navigate.js: Added.
1685 * public/js/jquery.flot.resize.js: Added.
1686 * public/js/jquery.flot.selection.js: Added.
1687 * public/js/jquery.flot.stack.js: Added.
1688 * public/js/jquery.flot.symbol.js: Added.
1689 * public/js/jquery.flot.threshold.js: Added.
1690 * public/js/jquery.flot.time.js: Added.
1691 * public/js/jquery.js: Added.
1693 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1695 Return NaN instead of throwing when there aren't enough samples.
1697 Reviewed by Sam Weinig.
1699 It's better to return NaN when we don't have enough samples so that we can treat it
1700 as if we don't have any confidence interval.
1702 * public/js/statistics.js:
1705 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1707 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
1709 * public/js/helper-classes.js:
1710 (URLState.parseIfNeeded):
1712 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1714 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
1716 Reviewed by Ricky Mondello.
1718 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
1720 * public/admin/aggregators.php: Use heredoc.
1721 * public/admin/builders.php:
1722 * public/admin/jobs.php:
1723 * public/admin/repositories.php:
1724 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
1725 This allows us to use update_field when updating test's url and metric's unit. Changed the action
1726 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
1727 Also removed a stray code to update unit and url simultaneously since it's never used.
1728 * public/include/admin-header.php:
1729 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
1730 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
1731 (update_field): Moved from repositories.php.
1733 * public/include/db.php:
1734 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
1736 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
1738 Build fixes. Treat mean, sum, and square sum as float, not int.
1740 Also use 95% confidence interval instead of 90% confidence interval.
1742 * public/api/runs.php:
1743 * public/js/helper-classes.js:
1744 (.this.confidenceIntervalDelta):
1746 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
1748 Add an administrative page to edit repository information.
1750 Reviewed by Ricky Mondello.
1752 * public/admin/repositories.php: Added.
1753 * public/include/admin-header.php:
1755 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
1757 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
1759 Reviewed by Ricky Mondello.
1761 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
1762 to aggregate results for those matrix in populate-from-report.js.
1764 * database/generate-manifest.js:
1765 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
1766 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
1767 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
1768 * database/populate-from-report.js:
1770 (getReport): No change even though the diff looks as if it moved.
1771 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
1772 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
1773 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
1774 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
1775 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
1777 (ensureMetricId): Take an aggregator id as an argument.
1778 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
1779 for all builds when the build id is not specified.
1780 * public/admin/tests.php:
1781 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
1782 of the same name with different aggregators.
1784 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
1786 Build fix. Don't pass in arguments to in the wrong order.
1788 * database/aggregate.js:
1790 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1792 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
1794 Reviewed by Ricky Mondello.
1796 Since the version of flot we use doesn't support showing graphs in the current locate or
1797 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
1798 treat them as in UTC). We don't want to use the current locate because other websites on
1799 webkit.org assume PST.
1801 Also append this information to build's label.
1803 * public/js/helper-classes.js:
1807 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1809 Store test URLs reported by builders.
1811 Reviewed by Ricky Mondello.
1813 * database/populate-from-report.js:
1814 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
1815 (ensureTestId): Store the URL.
1817 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
1819 Yet another build fix; don't blow up even if we didn't have any test configurations.
1821 * public/admin/tests.php:
1823 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1825 Build fix; don't instantiate Date when a timestamp wasn't provided.
1827 * database/populate-from-report.js:
1829 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
1831 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
1833 Reviewed by Tim Horton.
1835 Added an install manual.
1837 * InstallManual: Added.
1839 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
1841 Minor build fix. Don't unset builderPassword when it's not set.
1843 * public/api/report.php:
1845 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1847 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
1849 Reviewed by Ricky Mondello.
1851 * public/admin/admin.css: Make a very large payload scrollable.
1852 * public/admin/jobs.php: Format JSONs.
1854 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
1856 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
1858 Reviewed by Ricky Mondello.
1860 Add report.php and populate-from-report.js that process JSON files submitted by builders.
1862 * database/populate-from-report.js: Added.
1864 (getReport): Obtains the payload (the actual report) from "jobs" table.
1865 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
1866 and their results. This function recursively traverses tests and metrics and ensure their ids.
1868 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
1869 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
1870 is a "function" in mathematical sense).
1872 (ensureRepositoryIdsForAllRevisions):
1873 (getIdOrCreateBuildWithRevisions):
1874 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
1875 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
1876 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
1878 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
1879 test results all in a single transaction. This allows us to keep the database consistent in that either
1880 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
1881 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
1882 other parts of the application are concerned.
1883 (scheduleQueriesToInsertRun):
1884 * database/process-jobs.js: Add a call to populate-from-report.js.
1885 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
1886 * public/include/db.php: Support parameterized query.
1887 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
1888 a test result could confirm that the submission indeed succeeded.
1890 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1892 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
1894 * database/aggregate.js:
1895 * database/database-common.js:
1896 (selectColumnCreatingRowIfNeeded):
1897 (ensureRepositoryId):
1898 (ensureConfigurationIdFromList):
1899 * database/perf-webkit-migrator.js:
1902 (getOrCreateBuildId):
1904 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
1906 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
1908 Reviewed by Ricky Mondello.
1910 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
1911 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
1913 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
1916 (saveAggregatedResults):
1917 * database/database-common.js:
1918 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
1919 (getIdOrCreateRepository): Ditto.
1920 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
1921 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
1922 * database/perf-webkit-migrator.js:
1923 * database/utility.js: Added.
1924 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
1925 from being executed.
1926 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
1927 call the callback passed into start().
1928 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
1929 (TaskQueue.addTask):
1931 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
1932 (SerializedTaskQueue.executeNextTask):
1933 (SerializedTaskQueue.addTask):
1934 (SerializedTaskQueue.start):
1936 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1938 Revert erroneously committed changes.
1940 * database/config.json:
1942 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1944 aggregator.js should be able to accept multiple metric ids and a single build id.
1946 Reviewed by Ricky Mondello.
1948 Make aggregator.js accept multiple ids and generate results for single build when bots are
1949 reporting new results.
1951 * database/aggregate.js:
1952 (parseArgv): Added. Returns an object containing the parsed representation of argv,
1953 which currently contains metricIDs and buildIds.
1954 (main): Use parseArgv and processConfigurations
1955 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
1956 (processPlatform.processConfigurations): Extracted.
1958 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
1960 Add an administrative page for builders.
1962 Reviewed by Ricky Mondello.
1964 We need an administrative page to add and edit builder information.
1965 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
1967 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
1968 since we don't have plans to use those columns in near future. Also make builder_name unique
1969 as required by the rest of the app.
1970 * public/admin/builders.php: Added.
1971 * public/api/runs.php: Updated per the table rename.
1972 * public/include/admin-header.php: Added a link to builders.php.
1974 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
1976 Build fixes for r46982.
1978 * database/aggregate.js:
1979 (fetchConfigurations): Bind i so that it's not always metricIds.length.
1980 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
1981 (processBuild): Don't print "." until we've committed transactions. It's misleading.
1983 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
1985 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
1987 * public/admin/aggregators.php:
1988 * public/admin/footer.php: Removed.
1989 * public/admin/header.php: Removed.
1990 * public/admin/index.php:
1991 * public/admin/jobs.php:
1992 * public/admin/tests.php:
1993 * public/api/json-header.php: Removed.
1994 * public/api/runs.php:
1995 * public/db.php: Removed.
1996 * public/include: Added.
1997 * public/include/admin-footer.php: Copied from public/admin/footer.php.
1998 * public/include/admin-header.php: Copied from public/admin/header.php.
1999 * public/include/db.php: Copied from public/db.php.
2000 * public/include/json-header.php: Copied from public/api/json-header.php.
2002 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2004 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
2006 Reviewed by Ricky Mondello.
2008 Added the initial implementation of value aggregation.
2009 Also added abilities to configure the dashboard page in tests.php.
2011 * database/aggregate.js: Added.
2012 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
2013 (TaskQueue.addTask):
2015 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
2016 (SerializedTaskQueue.addTask):
2017 (SerializedTaskQueue.start):
2020 (fetchConfigurations):
2021 (fetchBuildsForPlatform):
2023 (testsWithDifferentIterationCounts):
2024 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
2025 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
2026 (getOrInsertConfiguration):
2028 * database/database-common.js:
2029 (fetchTable): Log an error as an error.
2030 (getOrCreateId): Extracted from perf-webkit-migrator.
2031 (statistics): Added.
2032 * database/perf-webkit-migrator.js:
2033 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
2034 runs JSON since runs JSONs are generated on demand now.
2036 (getOrCreatePlatformId):
2037 (getOrCreateTestId):
2038 (getOrCreateConfigurationId):
2039 (getOrCreateRevisionId):
2040 (getOrCreateRepositoryId):
2041 (getOrCreateBuildId):
2042 * database/process-jobs.js:
2043 (processJob): Handle 'aggregate' type.
2045 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
2047 Fix the dashboard after adding test_metrics.
2049 Reviewed by Ricky Mondello.
2051 Rename test to metrics in various functions and sort tests on the charts page.
2052 Also representing whether a test appears or not by setting a flag on dashboard
2053 was bogus because test objects are shared by multiple platforms. Instead, store
2054 dashboard platform list as intended by the manifest JSON.
2056 * public/index.html:
2057 (PerfTestRuns): Renamed test to metric.
2059 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
2060 (fullName): Moved so that it appears above where it's called.
2061 * public/js/helper-classes.js:
2063 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
2065 Update tests.php to reflect recent changes in the database schema.
2067 Reviewed by Conrad Shultz.
2069 Made the following changes to tests.php:
2070 1. Disallow adding metrics to tests without subtests.
2071 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
2072 3. Linkified tests with subtests instead of showing all them at once.
2074 * public/admin/admin.css:
2075 (.action-field, .notice):
2077 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
2078 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
2079 (add_job): Extracted.
2080 * public/admin/tests.php: See above.
2081 (array_item_set_default): Added.
2082 (array_item_or_default): Renamed from get_value_with_default.
2083 (compute_full_name): Extracted.
2084 (sort_tests): Ditto.
2085 (map_metrics_to_tests): Ditto.
2087 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
2089 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
2091 Reviewed by Simon Fraser.
2093 Linkify the headers using metric.test.url when it's provided.
2095 * public/index.html:
2097 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2099 Use parameterized pg_query_params in query_and_fetch_all
2101 Reviewed by Conrad Shultz.
2103 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
2105 * public/api/runs.php:
2107 (ctype_alnum_underscore): Added.
2109 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
2111 Update the migration tool to support test_metrics.
2113 Reviewed by Mark Rowe.
2115 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
2116 Also import run_iteration rows as runs JSON files now include individual values.
2118 * database/database-common.js:
2119 (addJob): Extracted.
2120 * database/perf-webkit-migrator.js:
2121 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
2122 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
2123 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
2126 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2128 Build fix. Suppress "Undefined index" warning.
2130 * public/admin/tests.php:
2132 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2134 Fix a commit error in r46756. api/ should obviously be added under public/
2137 * api/json-header.php: Removed.
2138 * api/runs.php: Removed.
2139 * public/api: Copied from api.
2141 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2143 SafariPerfMonitor: Linkify revisions and revisions range
2144 <rdar://problem/12801010>
2146 Reviewed by Mark Rowe.
2148 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
2149 since it needs to know "url" and "blameUrl".
2151 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
2153 * public/index.html:
2154 * public/js/helper-classes.js:
2156 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
2157 (TestBuild.label): Add labels for all revisions.
2161 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2163 Make the generation of "runs" JSON dynamic and support test_metrics.
2165 Reviewed by Mark Rowe.
2167 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
2169 Since there could be hundreds, if not thousands, of tests for each configuration and users
2170 aren't necessarily interested in looking at all test results, it's much more efficient to
2171 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
2172 when bots report new results (i.e. pushing).
2174 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
2177 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
2178 (exit_with_error): Added.
2179 (successful_exit): Added.
2180 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
2181 * database/generate-runs.js: Removed.
2182 * database/process-jobs.js: No longer supports "runs".
2183 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
2184 * public/db.php: Print "Nothing to see here." when it's accessed directly.
2186 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
2188 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2190 Update tests.php and sample-data.sql per addition of test_metrics.
2192 Rubber-stamped by Timothy Hatcher.
2194 Remove a useless code from tests.php that used to update the unit and the url of a test
2195 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
2197 Also update the sample data to reflect the addition of test_metrics.
2199 * database/sample-data.sql:
2200 * public/admin/tests.php:
2202 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
2204 Share more code between admin pages.
2206 Reviewed by Timothy Hatcher.
2208 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
2209 between admin pages.
2211 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
2212 to check the nullity of global $db now.
2214 * public/admin/aggregators.php:
2215 * public/admin/header.php:
2217 (execute_query_and_expect_one_row_to_be_affected): Added.
2218 * public/admin/index.php:
2219 * public/admin/jobs.php:
2220 * public/admin/tests.php:
2222 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
2224 SafariPerfMonitor: Add admin page to edit aggregators
2225 <rdar://problem/12782687>
2227 Reviewed by Mark Rowe.
2229 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
2231 * public/admin/aggregators.php: Added.
2232 * public/admin/header.php:
2233 * public/admin/jobs.php: Removed an erroneous hidden input element.
2235 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2237 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
2239 * database/init-database.sql:
2241 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2243 SafariPerfMonitor: Allow multiple metrics per test
2244 <rdar://problem/12773506>
2246 Rubber-stamped by Mark Rowe.
2248 Introduce a new table test_metrics. This table represents metrics each test can have
2249 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
2252 Updated admin/tests.php and index.html accordingly.
2254 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
2256 * database/generate-manifest.js:
2257 (buildPlatformMapIfPossible):
2258 * database/generate-runs.js:
2260 * database/init-database.sql:
2261 * database/schema.graffle:
2262 * public/admin/admin.css:
2265 * public/admin/tests.php:
2266 * public/index.html:
2268 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
2270 SafariPerfMonitor: Improve the webkit-perf migration tool
2271 <rdar://problem/12760882>
2273 Reviewed by Mark Rowe.
2275 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
2276 and we don't want to pause the whole importation process until the user comes back to decide whether
2279 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
2280 down to make modifications.
2282 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
2283 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
2285 * database/init-database.sql:
2286 * database/perf-webkit-migrator.js:
2287 (migrateTestConfig):
2288 * database/schema.graffle:
2289 * public/admin/admin.css:
2291 * public/admin/tests.php:
2293 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
2295 Create a new performance dashboard
2296 <rdar://problem/12625582>
2298 Rubber-stamped by Mark Rowe.
2300 Add the initial implementation of the perf dashboard.
2303 * database/config.json: Added.
2304 * database/database-common.js: Added.
2309 (pathToLocalScript):
2311 * database/generate-manifest.js: Added.
2314 (buildPlatformMapIfPossible):
2315 (generateFileIfPossible):
2316 * database/perf-webkit-migrator.js: Added.
2317 * database/process-jobs.js: Added.
2318 * database/sample-data.sql: Added.
2319 * database/schema.graffle: Added.
2321 * public/admin: Added.
2322 * public/admin/README: Added.
2323 * public/admin/admin.css: Added.
2324 * public/admin/footer.php: Added.
2325 * public/admin/header.php: Added.
2326 * public/admin/index.php: Added.
2327 * public/admin/jobs.php: Added.
2328 * public/admin/tests.php: Added.
2329 * public/common.css: Added.
2330 * public/data: Added.
2331 * public/db.php: Added.
2332 * public/index.html: Added.
2334 * public/js/helper-classes.js: Added.
2335 * public/js/jquery-1.8.2.min.js: Added.
2336 * public/js/jquery.flot.min.js: Added.
2337 * public/js/jquery.flot.plugins.js: Added.
2338 * public/js/shared.js: Added.
2339 (fileNameFromPlatformAndTest):
2340 * public/js/statistics.js: Added.