1 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
3 Unreviewed build fix. Updated config.json after recent changes.
7 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
9 Make the analysis page more useful
10 https://bugs.webkit.org/show_bug.cgi?id=143617
12 Reviewed by Chris Dumez.
14 * public/api/analysis-tasks.php:
15 (fetch_and_push_bugs_to_tasks): Added total and finished numbers of build requests associated
16 with the fetched analysis tasks as buildRequestCount and finishedBuildRequestCount respectively.
17 * public/v2/analysis.js:
18 (App.AnalysisTask.formattedCreatedAt): Added.
19 (App.AnalysisTask._addLeadingZero): Added.
20 (App.AnalysisTask.buildRequestCount): Added.
21 (App.AnalysisTask.finishedBuildRequestCount): Added.
22 (App.AnalysisTask.statusLabel): Added. Status total and finished numbers of build requests.
23 (App.AnalysisTask.testGroups):
24 (App.AnalysisTask.triggerable):
25 (App.AnalysisTask.label):
27 * public/v2/app.css: Tweaked style rules for the analysis page.
30 (App.buildPopup): Sort the list of platforms by name.
31 (App.AnalysisRoute.model): Sort the list of analysis tasks by the order they are created.
32 (App.AnalysisTaskController._fetchedManifest): Added elementId to associate bug tracker names
33 such as "Bugzilla" with the corresponding text field.
35 * public/v2/index.html: Added a bunch of columns to the analysis page and also wrapped the table
36 showing A/B testing results in a div with overflow: scroll so that it always leaves enough space
37 for the accompanying graph.
39 2015-04-09 Ryosuke Niwa <rniwa@webkit.org>
41 Perf dashboard should automatically select ranges for A/B testing
42 https://bugs.webkit.org/show_bug.cgi?id=143580
44 Reviewed by Chris Dumez.
46 Added a new statistics option for picking a A/B test range selection strategy.
47 The selected ranges are shown in the graph using the same UI to show analysis tasks.
50 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Updated the query parameters for
51 charts page used by the dashboard since we've added a new parameter at the end.
52 (App.Pane.ranges): Added. Merges ranges created for analysis tasks and A/B testing.
53 (App.Pane.updateStatisticsTools): Clone and set the test range selection strategies.
54 (App.Pane._cloneStrategy): Copy isSegmentation.
55 (App.Pane._updateMovingAverageAndEnvelope): Set testRangeCandidates.
56 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Update the charts when a new text range
57 selection strategy is picked by the user.
58 (App.Pane._computeMovingAverageAndOutliers): Compute the test ranges using the chosen strategy.
59 Avoid going through isAnomalyArray when no anomaly detection strategy is enabled. Also changed
60 the return value from the moving average time series to a dictionary that contains the moving
61 average time series, a dictionary of anomalies, and an array of test ranges.
62 (App.ChartsController._parsePaneList): Parse the test range selection strategy configuration.
63 (App.ChartsController._serializePaneList): Ditto for serialization.
64 (App.ChartsController._scheduleQueryStringUpdate): Update the URL hash when the user picks a new
65 test range selection strategy.
67 * public/v2/chart-pane.css: Fixed a typo as well as added a CSS rule for test ranges markers.
69 * public/v2/index.html: Added UI for selecting a test range selection strategy.
71 * public/v2/interactive-chart.js:
72 (App.InteractiveChartComponent._rangesChanged): Pass down "status" to be used as a class name.
74 * public/v2/js/statistics.js:
75 (Statistics.MovingAverageStrategies): Added isSegmentation to segmentation strategies.
76 (Statistics.TestRangeSelectionStrategies): Added.
78 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
80 The results of A/B testing should state statistical significance
81 https://bugs.webkit.org/show_bug.cgi?id=143552
83 Reviewed by Chris Dumez.
85 Added statistical comparisons between results for each configuration on analysis task page using
86 Welch's t-test. The probability as well as t-statistics and the degrees of freedoms are reported.
89 (App.TestGroupPane._populate): Report the list of statistical comparison between every pair of
90 root configurations in the results. e.g. if we've got A, B, C configurations then compare A/B, A/C
92 (App.TestGroupPane._computeStatisticalSignificance): Compute the statistical significance using
93 Welch's t-test. Report the probability by which two samples do not come from the same distribution.
94 (App.TestGroupPane._createConfigurationSummary): Include the array of results for this configuration.
95 Also renamed "items" to "requests" for clarity.
97 * public/v2/index.html: Added the template for showing statistical comparisons.
99 * public/v2/js/statistics.js: Renamed tDistributionQuantiles to tDistributionByOneSidedProbability
100 for clarity. Also factored out the functions to convert from one-sided probability to two-sided
101 probability and vice versa.
102 (Statistics.supportedConfidenceIntervalProbabilities):
103 (Statistics.confidenceIntervalDelta):
104 (Statistics.probabilityRangeForWelchsT): Added. Computes the lower bound and the upper bound for
105 the probability that two values are sampled from distinct distributions using Welch's t-test.
106 (Statistics.computeWelchsT): This function now takes two-sided probability like all other functions.
107 (.tDistributionByOneSidedProbability): Renamed from tDistributionQuantiles.
108 (.oneSidedToTwoSidedProbability): Extracted.
109 (.twoSidedToOneSidedProbability): Extracted.
110 (Statistics.MovingAverageStrategies): Converted the one-sided probability to the two-sided probability
111 now that computeWelchsT takes two-sided probability.
113 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
115 Unreviewed fix after r182496 for when the cached runs JSON doesn't exist.
119 (App.Pane.refetchRuns):
121 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
123 Perf dashboard should have a way of marking outliers
124 https://bugs.webkit.org/show_bug.cgi?id=143466
126 Reviewed by Chris Dumez.
128 Address kling's in-person comment to notify users when the new run status is saved in the database.
131 (App.PaneController._selectedItemIsMarkedOutlierDidChange)
132 * public/v2/chart-pane.css: Fixed a typo.
134 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
136 Perf dashboard should have a way of marking outliers
137 https://bugs.webkit.org/show_bug.cgi?id=143466
139 Reviewed by Chris Dumez.
141 Added UI to mark a data point as an outlier as well as a button to toggle the visibility of outliers.
142 Added a new privileged API /privileged-api/update-run-status to store this boolean flag.
144 * init-database.sql: Added run_marked_outlier column to test_runs table.
146 * public/admin/tests.php:
148 * public/api/runs.php:
149 (main): Only emit Cache-Control and Expires headers in v1 UI.
150 (RunsGenerator::format_run): Emit markedOutlier.
152 * public/include/admin-header.php:
154 * public/include/db.php:
155 (Database::is_true): Made it static.
157 * public/include/manifest.php:
158 (Manifest::platforms):
160 * public/index.html: Call into /api/runs/ with ?cache=true.
162 * public/privileged-api/update-run-status.php: Added.
163 (main): Updates the newly added column in test_runs table.
167 (App.Pane.refetchRuns): Extracted from App.Pane._fetch.
168 (App.Pane._didFetchRuns): Renamed from _updateChartData.
169 (App.Pane._setNewChartData): Added. Pick the right time series based based on the value of showOutlier.
170 Cloning chartData is necessary when toggling the outlier visibility or using statistics tools because
171 the interactive chart component only observes changes to chartData and not individual properties of it.
172 (App.Pane._highlightPointsMarkedAsOutlier): Added. Highlight points marked as outliers.
173 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Call to _setNewChartData replaced the code to
174 clone chartData here.
176 (App.PaneController.actions.toggleShowOutlier): Toggle the visibility of points marked as outliers by
177 invoking App.Pane._setNewChartData.
178 (App.PaneController._detailsChanged): Don't hide the analysis pane when details changed since keep
179 opening the pane for marking points as outliers would be annoying.
180 (App.PaneController._updateCanAnalyze): Update 'cannotMarkOutlier' as well as 'cannotAnalyze'.
181 (App.PaneController.selectedMeasurement): Added.
182 (App.PaneController.showOutlierTitle): Added.
183 (App.PaneController._selectedItemIsMarkedOutlierDidChange): Added. Call out to setMarkedOutlier to
184 mark the selected point as an outlier via the newly added privileged API.
186 * public/v2/chart-pane.css: Updated styles.
189 (PrivilegedAPI._post): Report the semantic errors.
190 (Measurement.prototype.markedOutlier): Added.
191 (Measurement.prototype.setMarkedOutlier): Added. Uses PrivilegedAPI to update the database.
192 (RunsData.prototype.timeSeriesByCommitTime): Added a new argument, includeOutliers, to indicate
193 whether the time series should include measurements marked as outliers or not.
194 (RunsData.prototype.timeSeriesByBuildTime): Ditto.
195 (RunsData.prototype._timeSeriesByTimeInternal): Extracted from timeSeriesByCommitTime and
196 timeSeriesByBuildTime to share code. Now ignores measurements marked as outliers if needed.
198 * public/v2/index.html: Added an icon for showing and hiding outliers. Also added a checkbox to
199 mark individual points as outliers.
201 * public/v2/interactive-chart.js:
202 (App.InteractiveChartComponent._selectClosestPointToMouseAsCurrentItem): Re-enable the distance
203 heuristics that takes vertical closeness into account. This heuristics is more useful when marking
204 some points as outliers. This heuristics was disabled because the behavior was unpredictable but
205 with the arrow key navigation support, this is no longer an issue.
207 * public/v2/manifest.js:
208 (App.Manifest._formatFetchedData): Added showOutlier to the chart data. This function dynamically
209 updates the time series in this chart data in order to include or exclude outliers.
211 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
213 Perf dashboard should be able to trigger A/B testing jobs for iOS
214 https://bugs.webkit.org/show_bug.cgi?id=143398
216 Reviewed by Chris Dumez.
218 Fix various bugs in the perf dashboard so that it can schedule A/B testing jobs for iOS.
220 Also generalized sync-with-buildbot.py slightly to meet the requirements of iOS builders.
222 * public/api/triggerables.php:
223 (main): Avoid spitting a warning when $id_to_triggerable doesn't contain the triggerable.
224 * public/v2/analysis.js:
225 (App.AnalysisTask.triggerable): Log an error when failed to fetch triggerables for debugging purposes.
227 (App.AnalysisTaskController.updateRootConfigurations): Show 'None' when a revision is missing from
228 some of the data points. This will happen when we modify the list of projects we build for iOS.
229 (App.AnalysisTaskController.actions.createTestGroup): Gracefully fail by showing alerts when an user
230 attempts to create an invalid test group; when there is already another test group of the same or when
231 only either configuration specifies the revision for some repository.
232 (App.AnalysisTaskController._updateRootsBySelectedPoints): Fixed a typo: sets[i] -> set.
233 * public/v2/index.html: Don't show the form to create a new test group if it's not available.
234 * tools/sync-with-buildbot.py:
235 (find_request_updates):
236 (schedule_request): iOS builders take a JSON that contains the list of roots. Generate this JSON when
237 a dictionary of the form {rootsExcluding: ["WebKit"]} is specified. Also replaced the way we refer to
238 a revision from $-based text replacements to an explicit dictionary of the form {root: "WebKit"}.
239 (request_id_from_build): Don't hard code the parameter name here. Retrieve the name from the config.
241 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
243 Add time series segmentation algorithms as moving averages
244 https://bugs.webkit.org/show_bug.cgi?id=143362
246 Reviewed by Chris Dumez.
248 This patch implements two preliminary time series segmentation algorithms as moving averages.
250 Recursive t-test: Compute Welch's t-statistic at each point in a given segment of the time series.
251 If Welch's t-test implicates a statistically significance difference, then split the segment into two
252 sub segments with the maximum t-statistic (i.e. the point at which if split would yield the highest
253 probability that two segments do not share the same "underlying" mean in classical / frequentist sense).
254 We repeat this process recursively. See [1] for the evaluation of this particular algorithm.
256 Schwarz criterion: Use Schwarz or Bayesian information criterion to heuristically find the optimal
257 segmentation. Intuitively, the problem of finding the best segmentation comes down to minimizing the
258 residual sum of squares in each segment as in linear regressions. That is, for a given segment with
259 values y_1 through y_n with mean y_avg, we want to minimize the sum of (y_i - y_avg)^2 over i = 1
260 through i = n. However, we also don't want to split every data point into a separate segment so we need
261 to account the "cost" of introducing new segments. We use a cost function that's loosely based on two
262 models discussed in [2] for simplicity. We will tune this cost function further in the future.
264 The problem of finding the best segmentation then reduces to a search problem. Unfortunately, our problem
265 space is exponential with respect to the size of the time series since we could split at each data point.
266 We workaround this problem by first splitting the time series into a manageable smaller grids, and only
267 considering segmentation of a fixed size (i.e. the number of segments is constant). Since time series
268 tend to contain a lot more data points than segments, this strategy finds the optimal solution without
269 exploring much of the problem space.
271 Finding the optimal segmentation of a fixed size is, itself, another search problem that is equivalent to
272 finding the shortest path of a fixed length in DAG. Here, we use dynamic programming with a matrix of size
273 n by n where n is the length of the time series (grid). Each entry in this matrix at (i, k) stores
274 the minimum cost of segmenting data points 1 through i using k segments. We start our search at i = 1.
275 Clearly C(1, 0) = 0 (note the actual code uses 0-based index). In i-th iteration, we compute the cost
276 S(i, j) of each segment starting at i and ending at another point j after i and update C(j, k + 1) by
277 min( C(j, k + 1), C(i, k) + S(i, j) ) for all values of j above i.
279 [1] Kensuke Fukuda, H. Eugene Stanley, and Luis A. Nunes Amaral, "Heuristic segmentation of
280 a nonstationary time series", Physical Review E 69, 021108 (2004)
282 [2] Marc Lavielle, Gilles Teyssi`ere, "Detection of Multiple Change–Points in Multivariate Time Series"
283 Lithuanian Mathematical Journal, vol 46, 2006
285 * public/v2/index.html: Show the optional description for the chosen moving average strategy.
286 * public/v2/js/statistics.js:
287 (Statistics.testWelchsT):
288 (Statistics.computeWelchsT): Extracted from testWelchsT. Generalized to take the offset and the length
289 of each value array between which Welch's t-statistic is computed. This generalization helps the
290 Schwarz criterion segmentation algorithm avoid splitting values array O(n^2) times.
291 (.sampleMeanAndVarianceForValues): Ditto for the generalization.
292 (.recursivelySplitIntoTwoSegmentsAtMaxTIfSignificantlyDifferent): Added. Implements recursive t-test.
293 (.splitIntoSegmentsUntilGoodEnough): Added. Implements Schwarz criterion.
294 (.findOptimalSegmentation): Added. Implements the algorithm to find the optimal segmentation of a fixed
296 (.SampleVarianceUpperTriangularMatrix): Added. Stores S(i, j) used by findOptimalSegmentation.
297 (.SampleVarianceUpperTriangularMatrix.prototype.costBetween): Added.
299 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
301 REGRESSION: Perf dashboard sometimes fails to update zooming level
302 https://bugs.webkit.org/show_bug.cgi?id=143359
304 Reviewed by Darin Adler.
306 The bug was caused by various bugs that ended up in an exception.
309 (App.Pane._handleFetchErrors): Removed superfluous console.log.
310 (App.Pane.computeStatus): Fixed the bug in r182185 that previousPoint could be null.
311 (App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
312 * public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
313 to # when Ember.js fails to attach event listeners on time.
314 * public/v2/interactive-chart.js:
315 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
316 the containing element's size is 0.
317 (App.InteractiveChartComponent._updateBrush): Ditto.
319 2015-04-02 Ryosuke Niwa <rniwa@webkit.org>
321 Perf dashboard should have UI to test out anomaly detection strategies
322 https://bugs.webkit.org/show_bug.cgi?id=143290
324 Reviewed by Benjamin Poulain.
326 Added the UI to select anomaly detection strategies. The detected anomalies are highlighted in the graph.
328 Implemented the Western Electric Rules 1 through 4 in http://en.wikipedia.org/wiki/Western_Electric_rules
329 as well as Welch's t-test that compares the last five points to the prior twenty points.
331 The latter is what Mozilla uses (or at least did in the past) to detect performance regressions on their
332 performance tests although they compare medians instead of means.
334 All of these strategies don't quite work for us since our data points are too noisy but this is a good start.
337 (App.Pane.updateStatisticsTools): Clone anomaly detection strategies.
338 (App.Pane._updateMovingAverageAndEnvelope): Highlight anomalies detected by the enabled strategies.
339 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Observe changes to anomaly detection strategies.
340 (App.Pane._computeMovingAverageAndOutliers): Detect anomalies by each strategy and aggregate results.
341 Only report the first data point when multiple consecutive data points are detected as anomalies.
342 * public/v2/chart-pane.css: Updated styles.
343 * public/v2/index.html: Added the pane for selecting anomaly detection strategies.
344 * public/v2/js/statistics.js:
345 (Statistics.testWelchsT): Added. Implements Welch's t-test.
346 (.sampleMeanAndVarianceForValues): Added.
347 (.createWesternElectricRule): Added.
348 (.countValuesOnSameSide): Added.
349 (Statistics.AnomalyDetectionStrategy): Added.
351 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
353 REGRESSION: Searching commits can highlight wrong data points
354 https://bugs.webkit.org/show_bug.cgi?id=143272
356 Reviewed by Antti Koivisto.
358 The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
359 return commit times with only second precision. This resulted in the frontend code to match a commit
360 with the data point that included the next commit when the millisecond component of commit's timestamp
361 wasn't identically 0.
363 This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
364 was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
365 so miliseconds component was only preserved in /api/commits.
367 Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
368 it returns time in milisecond precision.
370 * public/api/commits.php:
371 (fetch_commits_between): Use Database::to_js_time for format commit times.
372 (format_commit): Ditto.
373 * public/include/db.php:
374 (Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
376 (CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
378 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
380 Perf dashboard should show relative change in values
381 https://bugs.webkit.org/show_bug.cgi?id=143252
383 Reviewed by Antti Koivisto.
385 When a range of values are selected, show the percentage difference between the start and the end
386 in addition to the absolute value difference. When a single point is selected, show the relative
387 difference with respect to the previous point. Use two significant figures and always show plus sign
388 when the difference is positive.
390 * public/v2/app.js: Compute and format the relative difference.
391 * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
392 * public/v2/index.html: Show the relative difference.
394 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
396 REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
397 https://bugs.webkit.org/show_bug.cgi?id=143254
399 Reviewed by Antti Koivisto.
401 The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
402 or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
403 so that the interactive chart component will observe a change to 'chartData'.
406 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
408 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
410 Unreviewed build fixes.
412 * public/include/manifest.php:
413 (Manifest::generate): These should be {} instead of [] when they're empty.
415 (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
416 * public/v2/manifest.js:
417 (App.Metric.fullName): Fixed the typo.
418 * tests/admin-regenerate-manifest.js: Fixed the test.
420 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
422 Commit the erroneously reverted change.
424 * public/api/runs.php:
425 (RunsGenerator::results):
427 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
429 Loading the perf dashboard takes multiple seconds
430 https://bugs.webkit.org/show_bug.cgi?id=141860
432 Reviewed by Andreas Kling.
434 This patch introduces the caches of JSON files returned by /api/ in /data/ directory. It also records
435 the last time test_runs rows associated with the requested platforms and metrics are inserted, updated,
436 or removed in the caches as well as the manifest JSON files ("last modified time"). Because the manifest
437 is regenerated each time a new test result is reported, the front end can compare last modified time in
438 the manifest file with that in a /api/runs JSON cache to detect the stale-ness.
440 More concretely, the front end first optimistically fetches the JSON in /data/. If the cache doesn't exit
441 or the last modified time in the cache doesn't match with that in the manifest file, it would fetch it
442 again via /api/runs. In the case the cache did exist, we render the charts based on the cache meanwhile.
443 This dramatically reduces the perceived latency for the page load since charts are drawn immediately using
444 the cache and we would only re-render the charts as new up-to-date JSON comes in.
446 This patch also changes the format of runs JSONs by pushing the exiting properties into 'configurations'
447 and adding 'lastModified' and 'elapsedTime' at the top level.
449 * init-database.sql: Added config_runs_last_modified to test_configurations table as well as a trigger to
450 auto-update this column upon changes to test_runs table.
452 * public/admin/test-configurations.php:
453 (add_run): Regenerate the manifest file to invalidate the /api/runs JSON cache.
456 * public/api/runs.php:
457 (main): Fetch all columns of test_configurations table including config_runs_last_modified. Also generate
458 the cache in /data/ directory.
459 (RunsGenerator::__construct): Compute the last modified time for this (platform, metric) pair.
460 (RunsGenerator::results): Put the old content in 'configurations' property and include 'lastModified' and
461 'elapsedTime' properties. 'elapsedTime' is added for debugging purposes.
462 (RunsGenerator::add_runs):
463 (RunsGenerator::parse_revisions_array):
465 * public/include/db.php:
467 (generate_data_file): Added based on ManifestGenerator::store.
468 (Database::to_js_time): Extracted from RunsGenerator::add_runs to share code.
470 * public/include/json-header.php:
471 (echo_success): Renamed from success_json. Return the serialized JSON instead of echo'ing it so that we can
472 generate caches in /api/runs/.
475 * public/include/manifest.php:
476 (ManifestGenerator::generate): Added 'elapsedTime' property for the time taken to generate the manifest.
477 It seems like we're generating it in 200-300ms for now so that's good.
478 (ManifestGenerator::store): Uses generate_data_file.
479 (ManifestGenerator::platforms): Added 'lastModified' array to each platform entry. This array contains the
480 last modified time for each (platform, metric) pair.
483 (fetchTest): Updated per the format change in runs JSON.
486 (App.Pane._fetch): Fetch the cached JSON first. Refetch the uncached version if instructed as such.
487 (App.Pane._updateChartData): Extracted from App.Pane._fetch.
488 (App.Pane._handleFetchErrors): Ditto.
491 (RunsData.fetchRuns): Takes the fourth argument indicating whether we should fetch the cached version or not.
492 The cached JSON is located in /data/ with the same filename. When fetching a cached JSON results in 404,
493 fulfill the promise with null as the result instead of rejecting it. The only client of this function which
494 sets useCache to true is App.Manifest.fetchRunsWithPlatformAndMetric, and it handles this special case.
496 * public/v2/manifest.js:
497 (App.DateArrayTransform): Added. Handles the array of last modified dates in platform objects.
498 (App.Platform.lastModifiedTimeForMetric): Added. Returns the last modified date in the manifest JSON.
499 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes "useCache" like RunsData.fetchRuns. Set shouldRefetch
500 to true if response is null (the cache didn't exit) or the cache is out-of-date.
501 (App.Manifest._formatFetchedData): Extracted from App.Manifest.fetchRunsWithPlatformAndMetric.
504 (initializeDatabase): Avoid splitting function definitions in the middle.
506 * tests/api-report.js: Added tests to verify that reporting new test results updates the last modified time
507 in test_configurations.
509 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
511 REGRESSION(r180333): Analysis tasks can't be associated with bugs
512 https://bugs.webkit.org/show_bug.cgi?id=141858
514 Reviewed by Andreas Kling.
516 Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
517 of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
519 * public/v2/chart-pane.css:
520 * public/v2/index.html:
522 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
524 Selecting revisions for A/B testing is hard
525 https://bugs.webkit.org/show_bug.cgi?id=141824
527 Reviewed by Andreas Kling.
529 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
530 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
531 select A/B testing points manually.
533 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
534 sets to 'options' for clarity.
536 * public/v2/app.css: Reorganized style rules.
539 (App.AnalysisTaskController):
540 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
541 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
542 a property, which sets 'overviewDomain' property as well as other properties.
543 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
544 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
545 in the overview chart.
547 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
548 individual build requests / test results are shown or not.
550 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
551 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
553 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
555 Unreviewed test fixes after r179037, r179591, and r179763.
557 * tests/admin-regenerate-manifest.js:
558 * tests/admin-reprocess-report.js:
560 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
562 Relationship between A/B testing results are unclear
563 https://bugs.webkit.org/show_bug.cgi?id=141810
565 Reviewed by Andreas Kling.
567 Show a "reference chart" indicating which two points have been tested in each test group pane.
569 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
570 and the domain used in this chart to show charts in each test group.
572 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
574 * public/v2/analysis.js:
575 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
576 since this is the results of A/B testing results, not the data for charts shown next to them.
578 * public/v2/app.css: Added CSS rules for reference charts.
581 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
582 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
583 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
584 identically matches root sets. If one of configuration used a set of revisions for which no measurement
585 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
586 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
587 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
588 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
591 (Measurement.prototype.revisionForRepository): Added.
592 (Measurement.prototype.commitTimeForRepository): Cleanup.
593 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
595 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
596 by including the build number in the title attribute instead of in the markup.
598 * public/v2/interactive-chart.js:
599 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
600 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
601 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
603 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
605 Analysis task pages are unusable
606 https://bugs.webkit.org/show_bug.cgi?id=141786
608 Reviewed by Andreas Kling.
610 This patch makes following improvements to analysis task pages:
611 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
612 compute the data for the details pane from PaneController.
613 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
614 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
615 This change required the creation of App.TestGroupPane as well as its methods.
616 4. Show a box plot for each root set configuration as well as each build request. This change required
617 App.BoxPlotComponent.
618 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
620 * public/api/build-requests.php:
621 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
623 * public/api/test-groups.php:
624 (main): Include root sets and roots in the response.
627 * public/include/build-requests-fetcher.php:
628 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
629 (BuildRequestsFetcher::root_sets): Added.
630 (BuildRequestsFetcher::roots): Added.
631 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
632 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
633 tools/sync-with-buildbot.py can't convert repository names to their ids.
635 * public/v2/analysis.js:
637 (App.RootSet): Added.
638 (App.RootSet.revisionForRepository): Added.
639 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
640 response at /api/test-groups will include them.
641 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
642 _createConfigurationSummary.
643 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
644 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
646 * public/v2/app.css: Updated style rules for analysis task pages.
649 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
650 (App.Pane._updateDetails): Moved from App.PaneController.
652 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
654 (App.AnalysisTaskController): Added 'details'.
655 (App.AnalysisTaskController._taskUpdated):
656 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
657 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
658 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
660 (App.TestGroupPane): Added.
661 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
662 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
663 of all repositories appearing in root sets and builds associated with A/B testing results.
664 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
665 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
666 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
667 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
668 is a union of revisions in the root set and the first build request in the group. We null-out revision info
669 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
670 by the values in the group as well as 95% percentile confidence interval.
672 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
673 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
674 the mean and the confidence interval.
675 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
676 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
677 calls _updateBars to update the rects.
679 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
682 (Measurement.prototype.formattedRevisions):
683 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
684 called in _createConfigurationSummary.
686 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
687 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
688 Also made the fetching of chartData no longer block showing of test groups.
690 * public/v2/interactive-chart.js:
691 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
692 (App.InteractiveChartComponent._domainChanged): Ditto.
693 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
695 * public/v2/js/statistics.js:
696 (Statistics.min): Added.
697 (Statistics.max): Added.
699 * public/v2/manifest.js:
700 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
702 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
704 Build URL on new perf dashboard doesn't resolve $builderName
705 https://bugs.webkit.org/show_bug.cgi?id=141583
707 Reviewed by Darin Adler.
709 Support $builderName in the build URL template.
711 * public/js/helper-classes.js:
712 (TestBuild.buildUrl): Replaced $builderName with the builder name.
714 * public/v2/manifest.js:
715 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
716 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
718 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
720 Unreviewed build fix after r179591.
722 * public/api/commits.php:
724 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
726 The status of a A/B testing request always eventually becomes "Failed"
727 https://bugs.webkit.org/show_bug.cgi?id=141523
729 Reviewed by Andreas Kling.
731 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
732 'failedIfNotCompleted' was sent by the buildbot sync'er.
734 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
736 * public/api/build-requests.php:
739 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
741 Unreviewed, remove empty directories.
743 * public/data: Removed.
745 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
747 Perf dashboard should show the results of A/B testing
748 https://bugs.webkit.org/show_bug.cgi?id=141500
750 Reviewed by Chris Dumez.
752 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
753 analysis task page to fetch results for each test group.
755 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
756 can use the formatter.
758 * public/api/runs.php:
759 (fetch_runs_for_config_and_test_group): Added.
760 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
761 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
762 use RunsGenerator to format results.
763 (RunsGenerator): Added.
764 (RunsGenerator::__construct): Added.
765 (RunsGenerator::add_runs): Added.
766 (RunsGenerator::format_run): Moved.
767 (RunsGenerator::parse_revisions_array): Moved.
769 * public/v2/analysis.js:
770 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
771 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
772 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
773 configuration associated with this build request such as "A" and "B".
774 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
775 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
776 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
780 (App.Pane._fetch): Set chartData directly here.
781 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
782 now that it's done in App.Pane._fetch.
783 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
786 (Measurement.prototype.buildId): Added.
787 (TimeSeries.prototype.findPointByBuild): Added.
789 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
790 url is not an Ember routed path.
792 * public/v2/manifest.js:
793 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
794 App.createChartData here so that App.BuildRequest can use the formatter
796 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
798 v2 UI should adjust the number of ticks on dashboards based on screen size
799 https://bugs.webkit.org/show_bug.cgi?id=141502
801 Reviewed by Chris Dumez.
803 * public/v2/interactive-chart.js:
804 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
807 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
809 New perf dashboard shows too much space around interesting data points
810 https://bugs.webkit.org/show_bug.cgi?id=141487
812 Reviewed by Chris Dumez.
814 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
815 show the current time series excluding points in the series outside the moving average envelope.
818 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
819 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
820 time series if the point lies outside the moving average envelope. Don't expose the moving average or
821 the envelope computed for this purpose if they're not set by the user.
824 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
825 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
827 * public/v2/interactive-chart.js:
828 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
829 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
830 to deal with showFullYAxis here.
831 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
832 argument instead of directly inspecting showFullYAxis.
834 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
836 New perf dashboard shouldn't always show outliners
837 https://bugs.webkit.org/show_bug.cgi?id=141445
839 Reviewed by Chris Dumez.
841 Use the simple moving average with an average difference envelope to compute the y-axis range to show
842 to avoid expanding it spuriously to show one off outlier.
845 (App.Pane): Don't show the full y-axis range by default.
846 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
847 one is not specified by the user but without showing them in the charts.
848 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
849 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
851 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
852 (App.ChartsController._serializePaneList): Ditto.
854 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
856 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
858 * public/v2/interactive-chart.js:
859 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
860 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
861 if they are not specified by the user (i.e. only used to adjust y-axis range).
862 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
863 x-axis domain remained the same. Without this change, the charts would never redraw.
864 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
865 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
866 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
868 * public/v2/js/statistics.js:
869 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
871 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
873 Unreviewed build fix.
876 (set get App.Pane.Ember.Object.extend):
878 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
880 New perf dashboard should have the ability to overlay moving average with an envelope
881 https://bugs.webkit.org/show_bug.cgi?id=141438
883 Reviewed by Andreas Kling.
885 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
887 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
888 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
889 n, backward window size, and m, forward window size, as an argument.
891 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
892 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
894 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
895 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
898 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
899 between each x_i and x̄_i.
901 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
902 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
903 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
904 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
907 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
908 The configuration of the currently chosen strategies is saved in the query string for convenience.
910 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
912 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
915 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
916 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
917 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
918 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
919 from the query string via ChartsController.
920 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
921 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
922 (App.Pane._executeStrategy): Added.
923 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
925 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
926 selections, and added two new arguments for the moving average and the enveloping configurations.
927 (App.ChartsController._serializePaneList): Ditto.
928 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
929 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
930 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
931 (App.PaneController.actions.toggleStatPane): Added.
933 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
934 current (as opposed to baseline and target) time series for when it's the most foreground graph without
935 moving average and its envelope overlapping on top of it.
937 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
939 * public/v2/interactive-chart.js:
940 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
941 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
942 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
943 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
944 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
945 but don't bother removing individual paths and circles. Added the code to show the moving average time
946 series when there is one. Also add "foreground" class on SVG elements for the current time series when
947 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
948 series when "foreground" is not set.
949 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
950 account when computing the y-axis range.
951 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
953 * public/v2/js/statistics.js:
954 (Statistics.MovingAverageStrategies): Added.
955 (Statistics.EnvelopingStrategies): Added.
957 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
959 The delta value in the chart pane sometimes doens't show '+' for a positive delta
960 https://bugs.webkit.org/show_bug.cgi?id=141340
962 Reviewed by Andreas Kling.
964 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
965 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
968 (App.Pane.computeStatus):
969 (App.createChartData):
971 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
973 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
976 (App.PaneController._updateDetails):
978 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
980 Unreviewed. Commit the forgotten change.
982 * public/include/manifest.php:
984 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
986 New perf dashboard should have multiple dashboard pages
987 https://bugs.webkit.org/show_bug.cgi?id=141339
989 Reviewed by Chris Dumez.
991 Added the support for multiple dashboard pages. Also added the status of the latest data point.
992 e.g. "5% better than target"
994 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
995 Also hid the border lines around charts on the dashboard page for a cleaner look.
998 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
999 (App.IndexRoute.beforeModel): Added.
1000 (App.DashboardRoute): Added.
1001 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
1002 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
1003 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
1004 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
1005 (App.DashboardController): Renamed from App.IndexController.
1006 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
1007 and "defaultDashboard" as these are taken care of by newly added routers.
1008 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
1009 now done in actions.toggleEditMode.
1010 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
1011 an existing dashboard.
1013 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
1014 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
1015 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
1016 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
1018 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
1020 (App.PaneController._updateDetails): Updated per changes to computeStatus.
1022 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
1024 * public/v2/data.js:
1025 (TimeSeries.prototype.lastPoint): Added.
1027 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
1028 on the dashboard, and enumerate all predefined dashboards.
1030 * public/v2/interactive-chart.js:
1031 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
1032 for the dashboard page.
1034 * public/v2/manifest.js:
1035 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
1036 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
1037 IDs are generated for each dashboard for forward compatibility.
1039 (App.Manifest.dashboardByName): Added.
1040 (App.Manifest.defaultDashboardName): Added.
1041 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
1043 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1045 Move commits viewer to the end of details view
1046 https://bugs.webkit.org/show_bug.cgi?id=141315
1048 Rubber-stamped by Andreas Kling.
1050 Show the difference instead of the old value per kling's request.
1053 (App.PaneController._updateDetails):
1054 * public/v2/index.html:
1056 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1058 Move commits viewer to the end of details view
1059 https://bugs.webkit.org/show_bug.cgi?id=141315
1061 Reviewed by Andreas Kling.
1063 Improved the way list of commits are shown per kling's request.
1066 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
1068 * public/v2/chart-pane.css: Updated the style for the commits viewer.
1070 * public/v2/commits-viewer.js:
1071 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
1072 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
1074 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
1075 moved the commits viewers out of the details tables so that they don't interleave revision data.
1077 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1079 New perf dashboard should compare results to baseline and target
1080 https://bugs.webkit.org/show_bug.cgi?id=141286
1082 Reviewed by Chris Dumez.
1084 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
1085 Also use d3.format to format the selected value to show four significant figures.
1088 (App.Pane.searchCommit):
1089 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
1090 to compute the status text without having to recreate them.
1091 (App.createChartData): Added.
1092 (App.PaneController._updateDetails): Use 3d.format on current and old values.
1093 (App.PaneController._computeStatus): Added. Computes the status text.
1094 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
1095 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
1096 format the values using chartData.formatter.
1098 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
1099 the baseline and in blue if it's better than the target.
1101 * public/v2/data.js:
1102 (TimeSeries.prototype.findPointAfterTime): Added.
1104 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
1105 the bug that we were not showing the old value's unit.
1107 * public/v2/interactive-chart.js:
1108 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
1109 the code to show the baseline and the target lines.
1111 * public/v2/manifest.js:
1112 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
1114 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1116 Unreviewed build fix.
1119 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
1121 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1123 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
1124 https://bugs.webkit.org/show_bug.cgi?id=141280
1126 Reviewed by Chris Dumez.
1128 Fixed the bug by passing in "since" as a query parameter to the charts page.
1130 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
1132 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
1134 (App.IndexController): Changed the default number of days from one month to one week.
1135 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
1136 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
1138 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1140 New perf dashboard erroneously clears zoom when poping history items
1141 https://bugs.webkit.org/show_bug.cgi?id=141278
1143 Reviewed by Chris Dumez.
1145 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
1147 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
1148 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
1151 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
1152 shown in the main plot.
1153 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
1154 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
1156 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1158 New perf dashboard shows null as the aggregator name if no aggregation is done
1159 https://bugs.webkit.org/show_bug.cgi?id=141256
1161 Reviewed by Chris Dumez.
1163 Don't show the aggregator name if there isn't one.
1165 * public/v2/manifest.js:
1168 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1170 Unreviewed build fix after r179611.
1172 * public/v2/interactive-chart.js:
1174 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1176 Perf dashboard doesn’t show the right unit for Safari UI tests
1177 https://bugs.webkit.org/show_bug.cgi?id=141238
1179 Reviewed by Darin Adler.
1181 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
1182 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
1183 between metrics and their units.
1185 * public/js/helper-classes.js:
1186 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
1187 * public/v2/manifest.js:
1188 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
1189 * public/v2/interactive-chart.js:
1190 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
1191 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
1193 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1195 Interactive chart component provides two duplicate API for highlighting points
1196 https://bugs.webkit.org/show_bug.cgi?id=141234
1198 Reviewed by Chris Dumez.
1200 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
1201 on the main charts page and markedPoints to show the two end points in the analysis task page.
1203 This patch merges markedPoints into highlightedItems.
1206 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
1207 * public/v2/chart-pane.css:
1208 * public/v2/index.html: Ditto.
1209 * public/v2/interactive-chart.js:
1210 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
1211 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
1212 items if highlightedItems was set before the initial layout.
1213 (App.InteractiveChartComponent._relayoutDataAndAxes):
1214 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
1215 vertical lines, just set cx and cy as done for other "dots".
1216 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
1217 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
1218 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
1219 set the radius of highlight circles here.
1221 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1223 Don’t use repository names as id’s.
1224 https://bugs.webkit.org/show_bug.cgi?id=141226
1226 Reviewed by Chris Dumez.
1228 Not using repository names as their id's reduces the need to fetch the entire repositories table.
1229 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
1231 * Websites/perf.webkit.org/public/api/runs.php:
1232 (parse_revisions_array): No longer uses $repository_id_to_name.
1233 (main): No longer populates $repository_id_to_name.
1235 * Websites/perf.webkit.org/public/api/triggerables.php:
1236 (main): Don't resolve repository names.
1238 * Websites/perf.webkit.org/public/include/manifest.php:
1239 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
1240 (ManifestGenerator::bug_trackers): Don't resolve repository names.
1242 * Websites/perf.webkit.org/public/js/helper-classes.js:
1243 (TestBuild): Renamed repositoryName to repositoryId.
1244 (TestBuild.revision): Ditto.
1245 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
1246 since this is the text shown to human.
1248 * Websites/perf.webkit.org/public/v2/app.js:
1249 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
1250 (App.PaneController._updateDetails): Ditto.
1251 (App.AnalysisTaskController.updateRoots): Ditto.
1253 * Websites/perf.webkit.org/public/v2/data.js:
1254 (Measurement): Ditto.
1255 (Measurement.prototype.commitTimeForRepository): Ditto.
1256 (Measurement.prototype.formattedRevisions): Ditto.
1258 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
1259 select element's label and value respectively.
1261 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1263 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
1265 * public/api/runs.php:
1267 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1269 /api/runs.php should have main function
1270 https://bugs.webkit.org/show_bug.cgi?id=141220
1272 Reviewed by Benjamin Poulain.
1274 Wrapped the code inside main function for clarity.
1276 * public/api/runs.php:
1278 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
1280 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
1282 * tools/sync-with-buildbot.py:
1283 (find_request_updates):
1285 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1287 Perf dashboard always assigns the result of A/B testing with build request 1
1288 https://bugs.webkit.org/show_bug.cgi?id=140382
1290 Reviewed by Darin Adler.
1292 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
1293 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
1295 Also fixed a typo as well as a bug that reports were never associated with builds.
1297 * public/include/report-processor.php:
1298 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
1299 instead of the first non-null value.
1300 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
1301 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
1303 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1305 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
1307 * public/admin/tests.php:
1309 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
1311 Unreviewed build fix. Removed the stale code.
1313 * public/admin/triggerables.php:
1315 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1317 Perf dashboard should have the ability to post A/B testing builds
1318 https://bugs.webkit.org/show_bug.cgi?id=140317
1320 Rubber-stamped by Simon Fraser.
1322 This patch adds the support for triggering A/B testing from the perf dashboard.
1324 We add a few new tables to the database. "build_triggerables", which represents a set of builders
1325 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
1326 of repositories for which an arbitrary revision can be specified for A/B testing.
1327 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
1328 "roots" table which specifies the revision used in a given root set in each repository.
1330 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
1331 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
1332 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
1333 to build_requests table. Also made each test group's name unique in a given analysis task as it
1334 would be confusing to have multiple test groups of the same name.
1336 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
1338 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
1339 for which a specific revision can be set in an A/B testing on a given triggerable.
1341 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
1342 triggerable. Also updates the status' and the status urls of specified build requests when
1343 buildRequestUpdates is provided in the raw POST data.
1346 * public/api/runs.php:
1347 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
1348 results of an A/B testing.
1350 * public/api/test-groups.php:
1351 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
1353 * public/api/triggerables.php: Added.
1354 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
1356 * public/include/admin-header.php:
1358 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
1359 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
1360 and root sets used in those requests.D
1361 (BuildRequestsFetcher::__construct):
1362 (BuildRequestsFetcher::fetch_for_task):
1363 (BuildRequestsFetcher::fetch_for_group):
1364 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
1365 (BuildRequestsFetcher::has_results):
1366 (BuildRequestsFetcher::results):
1367 (BuildRequestsFetcher::results_with_resolved_ids):
1368 (BuildRequestsFetcher::results_internal):
1369 (BuildRequestsFetcher::root_sets):
1370 (BuildRequestsFetcher::fetch_roots_for_set):
1372 * public/include/db.php:
1373 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
1374 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
1375 table since it only has the primary key, id, column.
1376 (Database::select_or_insert_row):
1377 (Database::update_or_insert_row):
1378 (Database::update_row): Added.
1379 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
1380 should be inserted when no row matches the specified criteria. This is used while updating
1381 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
1382 new build requests in that API.
1383 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
1384 This is used in public/api/triggerables.php when no analysis task is specified.
1386 * public/include/json-header.php:
1387 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
1388 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
1389 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
1390 find the closest ancestor with a triggerable.
1392 * public/include/report-processor.php:
1393 (ReportProcessor::process):
1394 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
1395 if jobId or buildRequest is specified.
1397 * public/include/test-name-resolver.php:
1398 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
1399 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
1400 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
1403 * public/include/test-path-resolver.php: Added.
1404 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
1405 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
1406 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
1407 in order to compute full test metric names.
1408 (TestPathResolver::__construct):
1409 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
1410 the highest (a test without a parent).
1411 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
1412 the highest ancestor to the test itself.
1413 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
1415 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
1417 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
1418 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
1419 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
1420 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
1422 * public/v2/analysis.js:
1423 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
1424 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
1425 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
1426 (App.TestGroup.create): Added. Creates a new A/B testing group.
1427 (App.Triggerable): Added.
1428 (App.TriggerableAdapter): Added.
1429 (App.TriggerableAdapter.buildURL): Added.
1430 (App.BuildRequest.testGroup): Renamed from group.
1431 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
1432 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
1433 in this build request.
1434 (App.BuildRequest.status): Added.
1435 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
1436 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
1439 (App.AnalysisTaskController.testGroups): Added.
1440 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
1441 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
1442 but an observer that updates "roots" property. Filter out the repositories that are not accepted
1443 by the associated triggerable as they will be ignored.
1444 (App.AnalysisTaskController.actions.createTestGroup): Added.
1446 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
1448 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
1449 the status of those builds to the perf dashboard. A similar script can be written to support
1450 other continuous builds systems.
1451 (main): Fetches the list of pending builds as well as currently running or completed builds from
1452 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
1453 a single new build on each builder with no pending builds, and marks the set of open build requests
1454 that have been scheduled to run on the buildbot but not found in the first step as stale.
1455 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
1458 "platform": "mac-mavericks",
1459 "test": ["Parser", "html5-full-render.html"],
1460 "builder": "Trunk Syrah Production Perf AB Tests",
1462 "forcescheduler": "force-mac-mavericks-release-perf",
1463 "webkit_revision": "$WebKit",
1464 "jobid": "$buildRequest"
1469 (find_request_updates): Return a list of build request status updates to make based on the pending
1470 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
1471 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
1472 if the build request had not been completed. This is necessary because a failed build will not
1473 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
1474 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
1475 of open requests the perf dashboard has.
1476 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
1477 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
1478 or human canceling a build may trigger such a state.
1479 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
1480 replacing repository names with their revisions and buildRequest with the build request id.
1481 (config_for_request): Finds a builder for the test and the platform of a build request.
1482 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
1483 (property_value_from_build): Returns the value of a specific property in a buildbot build.
1484 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
1486 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1488 Cache-control should be set only on api/runs
1489 https://bugs.webkit.org/show_bug.cgi?id=140312
1491 Reviewed by Andreas Kling.
1493 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
1494 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
1495 just set cache-control there instead of json-header.php which is used by other JSON APIs.
1497 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
1499 * public/api/analysis-tasks.php:
1500 * public/api/runs.php: Set the cache control headers.
1501 * public/api/test-groups.php:
1502 * public/include/db.php: Set the default timezone to UTC.
1503 * public/include/json-header.php: Don't set the cache control headers.
1505 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1507 api/report-commit should authenticate with a slave name and password
1508 https://bugs.webkit.org/show_bug.cgi?id=140308
1510 Reviewed by Benjamin Poulain.
1512 Use a slave name and a password to authenticate new commit reports.
1514 * public/api/report-commits.php:
1516 * public/include/json-header.php:
1517 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
1518 a slave name and a password instead of a builder name and a password.
1519 * tests/api-report-commits.js: Updated tests.
1520 * tools/pull-svn.py:
1521 (main): Renamed variables.
1522 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
1524 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
1526 Perf dashboard should support authentication via a slave password
1527 https://bugs.webkit.org/show_bug.cgi?id=139837
1529 Reviewed by Andreas Kling.
1531 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
1532 having to add multiple builders with the same password when a single build slave is shared among them.
1534 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
1536 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
1538 * public/admin/build-slaves.php: Added.
1540 * public/admin/builders.php: Added the support for updating passwords.
1542 * public/include/admin-header.php:
1543 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
1544 being retrieved from $_POST.
1545 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
1546 the raw may not exist (e.g. new_password).
1547 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
1548 control here when this flag evaluates to TRUE.
1550 * public/include/report-processor.php:
1551 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
1552 values are present in the report. In addition, try authenticating builderName with slavePassword if
1553 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
1554 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
1555 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
1557 (ReportProcessor::store_report): Store the slave ID with the report.
1558 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
1559 the matching build is different from what's being reported.
1561 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
1564 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
1566 New perf dashboard should not duplicate author information in each commit
1567 https://bugs.webkit.org/show_bug.cgi?id=139756
1569 Reviewed by Darin Adler.
1571 Instead of each commit having author name and email, make it reference a newly added committers table.
1572 Also replace "email" by "account" since some repositories don't use emails as account names.
1574 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
1575 which only contains as many rows as there are accounts in each repository, instead of commits table
1576 which contains every commit ever happened in each repository.
1578 To migrate an existing database into match the new schema, run:
1582 INSERT INTO committers (committer_repository, committer_name, committer_email)
1583 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
1584 FROM commits WHERE commit_author_email IS NOT NULL);
1586 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
1588 UPDATE commits SET commit_committer = committer_id FROM committers
1589 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
1591 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
1592 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
1596 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
1597 reference to committers. Also added the missing drop table statements.
1599 * public/api/commits.php:
1600 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
1601 an array here instead of doing it in format_commit.
1602 (fetch_commits_between): Updated queries to JOIN commits with committers.
1603 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
1604 is now done in main.
1606 * public/api/report-commits.php:
1607 (main): Store the reported committer information or update the existing entry if there is one.
1609 * tests/admin-regenerate-manifest.js: Fixed tests.
1611 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
1613 * tools/pull-svn.py: Renamed email to account.
1615 (fetch_commit_and_resolve_author):
1617 (resolve_author_name_from_account):
1618 (resolve_author_name_from_email): Deleted.
1620 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
1622 Unreviewed build fix.
1624 * public/v2/index.html: Include js files we extracted in r177424.
1626 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1628 Unreviewed. Adding the forgotten svnprop.
1630 * tools/pull-svn.py: Added property svn:executable.
1632 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1634 Split InteractiveChartComponent and CommitsViewerComponent into separate files
1635 https://bugs.webkit.org/show_bug.cgi?id=139716
1637 Rubber-stamped by Benjamin Poulain.
1639 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
1640 and interactive-chart.js respectively since app.js has gotten really large.
1643 * public/v2/commits-viewer.js: Added.
1644 * public/v2/interactive-chart.js: Added.
1646 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
1648 New perf dashboard's chart UI is buggy
1649 https://bugs.webkit.org/show_bug.cgi?id=139214
1651 Reviewed by Chris Dumez.
1653 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
1655 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
1656 component. This is not how Ember.js components should interact to begin with. The component now exposes
1657 selectedPoints and always updates selection instead of sharedSelection.
1660 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
1661 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
1662 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
1663 and end time should be completely determined by "since" and the present time.
1664 (App.ChartsController._startTimeChanged): Ditto.
1665 (App.ChartsController._scheduleQueryStringUpdate):
1666 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
1668 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
1670 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
1671 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
1672 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
1673 observes the changes to selectedPoints property as it gets updated by the main chart.
1674 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
1675 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
1677 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
1678 when domain arrays aren't identical. This was causing a subtle race with other logic.
1679 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
1680 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
1681 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
1682 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
1683 see if those two points correspond to a range or a single data point. Rewrote all that logic by
1684 directly observing selectedPoints and currentItem properties instead of taking points and relying on
1685 an instance variable, which was a terrible API.
1686 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
1687 when the main plot has a selected range, we don't have to check this._hasRange anymore.
1689 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
1690 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
1691 (App.InteractiveChartComponent._updateSelection):
1692 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
1693 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
1694 selectedPoints property.
1696 (App.AnalysisTaskController._fetchedRuns):
1697 (App.AnalysisTaskController._rootChangedForTestSet):
1699 * public/v2/index.html:
1700 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
1702 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1704 Unreviewed. Fixed syntax errors.
1706 * init-database.sql:
1707 * public/api/commits.php:
1709 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1711 The dashboard on new perf monitor should be configurable
1712 https://bugs.webkit.org/show_bug.cgi?id=138994
1714 Reviewed by Benjamin Poulain.
1716 For now, make it configurable via config.json. We should eventually make it configurable via
1717 an administrative page but this will do for now.
1719 * config.json: Added the empty dashboard configuration.
1721 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1724 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1725 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1726 Also obtain the default configuration from App.Manifest.
1727 (App.IndexController._normalizeTable): Moved to App.Dashboard.
1729 * public/v2/manifest.js:
1730 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
1731 (App.Repository.urlForRevisionRange): Ditto.
1732 (App.Dashboard): Added.
1733 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
1734 (App.Dashboard.rows): Ditto.
1735 (App.Dashboard.headerColumns): Ditto.
1736 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
1737 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
1738 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
1739 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
1741 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1743 There should be a way to associate bugs with analysis tasks
1744 https://bugs.webkit.org/show_bug.cgi?id=138977
1746 Reviewed by Benjamin Poulain.
1748 Updated associate-bug.php to match the new database schema.
1750 * public/include/json-header.php:
1751 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
1752 already camel-cased in require_existence_of. This makes the function usable elsewhere.
1754 * public/privileged-api/associate-bug.php:
1755 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
1756 Also verify that those values are integers using require_format.
1758 * public/v2/analysis.js:
1759 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
1760 (App.Bug.label): Added.
1761 (App.BugAdapter): Added.
1762 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
1763 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
1765 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
1766 containing the bug information.
1769 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
1770 (App.AnalysisTaskRoute):
1771 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
1772 (App.AnalysisTaskController._fetchedManifest): Added.
1773 (App.AnalysisTaskController.actions.associateBug): Added.
1775 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
1777 * public/v2/data.js:
1778 (Measurement.prototype.associateBug): Deleted.
1780 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
1781 Added a table show the bug information. Also hide the chart until chartData is available.
1783 * public/v2/manifest.js:
1786 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1788 Fix misc bugs and typos in app.js
1789 https://bugs.webkit.org/show_bug.cgi?id=138946
1791 Reviewed by Benjamin Poulain.
1794 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1795 (App.ChartsController.init):
1796 (App.buildPopup): Renamed from App.BuildPopup.
1797 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1798 remove() on the wrong object (an array as opposed to elements in the array).
1799 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1800 _highlights is always an array and evalutes to true.
1802 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1804 New perf dashboard should provide UI to create a new analysis task
1805 https://bugs.webkit.org/show_bug.cgi?id=138910
1807 Reviewed by Benjamin Poulain.
1809 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1810 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1812 With this patch, we can create a new analysis task by selection a range of points and opening
1813 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1814 in the chart hyperlinked to the analysis task.
1816 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1818 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1819 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1821 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1822 and adds the associated bugs to each task in the array.
1825 * public/api/runs.php: Reverted changes made in r175006.
1826 (fetch_runs_for_config):
1829 * public/api/test-groups.php:
1830 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1832 * public/include/db.php:
1833 (Database::select_first_or_last_row):
1834 (Database::select_rows): Extracted from select_first_or_last_row.
1836 * public/v2/analysis.js:
1837 (App.AnalysisTask): Added "bugs" property.
1838 (App.Bug): Added now that bugs are regular data store objects.
1841 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1842 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1843 platform that are associated with a specific range of runs.
1844 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1845 (App.PaneController.actions.associateBug): Deleted.
1846 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1847 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1848 once we've created one.
1849 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1850 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1851 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1852 (App.PaneController._updateBugs): Deleted.
1853 (App.PaneController._updateMarkedPoints): Deleted.
1854 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1855 the name is missing or when at most one point is selected.
1857 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1858 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1859 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1860 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1861 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1862 clickable bars for analysis tasks.
1863 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1864 bar for analysis tasks to place them at the right location.
1865 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1867 * public/v2/chart-pane.css:
1868 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1869 (.chart .rangeBar): Added.
1871 * public/v2/data.js:
1872 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1874 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1875 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1876 task bars in the interactive chart component.
1878 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1880 Fix typos in r176203.
1883 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1884 (App.AnalysisTaskRoute):
1886 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1888 Unreviewed. Updated the install instruction.
1892 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1894 App.Manifest shouldn't use App.__container__.lookup
1895 https://bugs.webkit.org/show_bug.cgi?id=138768
1897 Reviewed by Andreas Kling.
1899 Removed the hack to find the store object via App.__container__.lookup.
1900 Pass around the store object instead.
1903 (App.DashboardRow._createPane): Add "store" property to the pane.
1904 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1905 (App.IndexController.gridChanged): Ditto.
1906 (App.IndexController.actions.addRow): Ditto.
1907 (App.IndexController.init): Ditto.
1908 (App.Pane._fetch): Ditto.
1909 (App.ChartsController._parsePaneList): Ditto.
1910 (App.ChartsController._updateQueryString): Ditto.
1911 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1912 (App.BuildPopup): Ditto.
1913 (App.AnalysisTaskRoute.model): Ditto.
1914 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1916 * public/v2/manifest.js:
1917 (App.Manifest.fetch): Removed the code to find the store object.
1919 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1921 Fix Ember.js warnings the new perf dashboard
1922 https://bugs.webkit.org/show_bug.cgi?id=138531
1924 Reviewed by Darin Adler.
1926 Fixed various warnings.
1929 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1930 * public/v2/data.js:
1931 (PrivilegedAPI._post): Removed the superfluous console.log.
1932 (CommitLogs.fetchForTimeRange): Ditto.
1933 * public/v2/index.html: Added tbody as required by the HTML specification.
1935 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1937 Fix typos in r175768.
1940 (App.AnalysisTaskViewModel.roots):
1942 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1944 Introduce the concept of analysis task to perf dashboard
1945 https://bugs.webkit.org/show_bug.cgi?id=138517
1947 Reviewed by Andreas Kling.
1949 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1950 a single platform and used to bisect regressions in the range.
1952 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1954 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1955 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1956 test runs. Analysis tasks not associated with test runs are used for try new patches.
1957 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1958 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1959 build_requests - A build request represents a single pending build for A/B testing.
1961 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1965 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1966 the specified analysis task group as well as build requests associated with them.
1968 (fetch_test_groups_for_task):
1969 (fetch_build_requests_for_task):
1970 (fetch_build_requests_for_group):
1971 (format_test_group):
1972 (format_build_request):
1974 * public/include/json-header.php:
1975 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1978 * public/privileged-api/associate-bug.php:
1979 (main): Fixed a typo.
1981 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1984 (ensure_config_from_runs):
1986 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1988 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1990 (App.AnalysisTask.create):
1992 (App.TestGroupAdapter):
1993 (App.AnalysisTaskSerializer):
1994 (App.TestGroupSerializer):
1997 * public/v2/app.css: Added style rules for the analysis page.
2000 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
2002 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
2003 exactly one selected point as we can still create an analysis task.
2004 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
2005 grammatical and also alert'ed the error message when there is one.
2006 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
2007 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
2008 once XHR request has completed.
2009 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
2010 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
2011 is selected in the details pane.
2013 (App.AnalysisRoute): Added.
2014 (App.AnalysisTaskRoute): Added.
2015 (App.AnalysisTaskViewModel): Added.
2016 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
2017 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
2018 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
2019 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
2020 the user selects an option for all roots in A or B configuration.
2021 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
2023 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
2025 * public/v2/data.js:
2026 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
2027 point so that we can use it in App.AnalysisTaskViewModel.roots.
2028 (TimeSeries.prototype.findPointByMeasurementId): Added.
2029 (TimeSeries.prototype.seriesBetweenPoints): Added.
2031 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
2032 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
2033 when multiple points are selected. Finally, added a new template for the analysis task page.
2035 * public/v2/manifest.js:
2036 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
2037 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
2038 App.AnalysisTaskViewModel._taskUpdated.
2040 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
2042 Remove App.PaneController.bugsChangeCount in the new perf dashboard
2043 https://bugs.webkit.org/show_bug.cgi?id=138111
2045 Reviewed by Darin Adler.
2048 (App.PaneController.bugsChangeCount): Removed.
2049 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
2050 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
2051 Finds the list of current run's points that are associated with bugs.
2052 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
2053 * public/v2/chart-pane.css:
2054 (.chart .marked): Renamed from .hasBugs.
2055 * public/v2/index.html: Specify chartPointRadius and markedPoints.
2057 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
2059 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
2060 https://bugs.webkit.org/show_bug.cgi?id=138099
2062 Reviewed by Benjamin Poulain.
2064 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
2065 _showDetails inverting the order of the current and old measurements.
2068 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
2069 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
2070 current (latest) measurement and the first point is the oldest measurement.
2071 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
2073 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
2075 Perf dashboard should provide a way to associate bugs with a test run
2076 https://bugs.webkit.org/show_bug.cgi?id=137857
2078 Reviewed by Andreas Kling.
2080 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
2081 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
2082 the Apache configuration.
2085 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
2086 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
2087 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
2088 via the cookie and returns a token computed from those two values as well as the remote username.
2090 The font end code then POST's the request along with the returned token. The server side code verifies
2091 that the specified token can be generated from the salt and the expiration time set in the cookie, and
2092 the token hasn't expired.
2095 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
2096 have zero or exactly one bug associated with a test run.
2098 * public/admin/bug-trackers.php: Added the support for editing bug_url.
2099 * public/api/runs.php:
2100 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
2101 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
2102 an associated bug if there is one.
2103 (format_run): Calls parse_bugs_array.
2105 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
2106 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
2107 have a valid JSON payload.
2108 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
2109 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
2110 the expiration time stored in the cookie.
2111 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
2113 * public/include/manifest.php:
2114 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
2115 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
2117 * public/index.html:
2118 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
2120 * public/privileged-api/associate-bug.php: Added.
2121 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
2122 attack via ensure_privileged_api_data_and_token, which calls verify_token.
2124 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
2126 * public/v2/app.css:
2127 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
2128 selected in a chart.
2131 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
2132 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
2133 they would overlap on each other if both of them are shown.
2134 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
2135 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
2136 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
2137 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
2138 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
2139 showing the search pane.
2140 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
2141 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
2142 bugs in the selected range.
2144 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
2145 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
2146 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
2147 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
2148 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
2149 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
2150 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
2151 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
2153 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
2154 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
2155 to selectionChanged action instead of just finding the first and the last points.
2157 * public/v2/chart-pane.css: Updated the style.
2159 * public/v2/data.js:
2160 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
2161 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
2162 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
2163 we haven't already obtained a CSRF token or if the token has already been expired.
2164 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
2166 (Measurement.prototype.bugs): Added.
2167 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
2168 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
2170 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
2173 * public/v2/manifest.js:
2174 (App.BugTracker.bugUrl):
2175 (App.BugTracker.newBugUrl): Added.
2176 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
2177 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
2178 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
2179 (App.Manifest.bugTrackers): Added.
2180 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
2181 their respective ids to make the ordering stable.
2183 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
2185 Remove unused jobs table
2186 https://bugs.webkit.org/show_bug.cgi?id=137724
2188 Reviewed by Daniel Bates.
2190 Removed jobs table in the database as well as related code.
2192 * init-database.sql:
2193 * public/admin/jobs.php: Removed.
2194 * public/admin/tests.php:
2195 * public/include/admin-header.php:
2197 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2199 New perf dashboard should have an ability to search commits by a keyword
2200 https://bugs.webkit.org/show_bug.cgi?id=137675
2202 Reviewed by Geoffrey Garen.
2204 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
2205 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
2206 This API change allows fetch_commits_between to generate results without processing Postgres query results.
2208 In the front end side, we've added a search pane in pane controller, and the interactive chart component
2209 now has a concept of highlighted items which is used to indicate commits found by the search pane.
2211 * public/api/commits.php:
2212 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
2213 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
2214 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
2215 (format_commit): Renamed from format_commits. Now only formats one commit.
2217 * public/include/db.php:
2218 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
2220 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
2223 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
2224 which is a hash table that contains highlighted items' measurements' ids as keys.
2225 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
2226 the default commit repository.
2227 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
2228 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
2229 Added the code to initialize this._highlights.
2230 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
2231 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
2232 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
2233 the existing lines for the old highlighted items.
2234 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
2235 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
2237 * public/v2/chart-pane.css: Added style for the search pane and the search button.
2239 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
2240 (CommitLogs): Added.
2241 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
2242 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
2243 (CommitLogs._cacheConsecutiveCommits): Ditto.
2244 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
2245 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
2246 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
2248 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
2249 for showingDetails since this property is no longer used.
2251 * public/v2/manifest.js:
2252 (App.Manifest.repositories): Added.
2253 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
2254 the default repository to search.
2255 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
2257 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2259 Unreviewed build fix after r174555.
2261 * public/include/manifest.php:
2262 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
2263 * tests/admin-regenerate-manifest.js: Fixed the test case.
2265 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
2267 New perf dashboard UI tries to fetch commits all the time
2268 https://bugs.webkit.org/show_bug.cgi?id=137592
2270 Reviewed by Andreas Kling.
2272 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
2273 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
2274 no reported commits as they are all going to fail.
2276 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
2277 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
2278 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
2279 of commits sorted chronologically by time.
2281 * public/include/manifest.php:
2284 (App.CommitsViewerComponent.commitsChanged):
2286 * public/v2/data.js:
2287 (FetchCommitsForTimeRange):
2288 (FetchCommitsForTimeRange._cachedCommitsByRepository):
2290 * public/v2/manifest.js:
2293 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2295 Another unreviewed build fix after r174477.
2297 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
2299 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
2301 * public/include/report-processor.php:
2303 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2305 Unreviewed build fix after r174477.
2307 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
2308 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
2310 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
2311 This is necessary for baseline and target values manually added via admin pages.
2313 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2315 Add v2 UI for the perf dashboard
2316 https://bugs.webkit.org/show_bug.cgi?id=137537
2318 Rubber-stamped by Andreas Kling.
2321 * public/v2/app.css: Added.
2322 * public/v2/app.js: Added.
2323 * public/v2/chart-pane.css: Added.
2324 * public/v2/data.js: Added.
2325 * public/v2/index.html: Added.
2326 * public/v2/js: Added.
2327 * public/v2/js/d3: Added.
2328 * public/v2/js/d3/LICENSE: Added.
2329 * public/v2/js/d3/d3.js: Added.
2330 * public/v2/js/d3/d3.min.js: Added.
2331 * public/v2/js/ember-data.js: Added.
2332 * public/v2/js/ember.js: Added.
2333 * public/v2/js/handlebars.js: Added.
2334 * public/v2/js/jquery.min.js: Added.
2335 * public/v2/js/statistics.js: Added.
2336 * public/v2/manifest.js: Added.
2337 * public/v2/popup.js: Added.
2339 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2341 Remove superfluously duplicated code in public/api/report-commits.php.
2343 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2345 Perf dashboard should store commit logs
2346 https://bugs.webkit.org/show_bug.cgi?id=137510
2348 Reviewed by Darin Adler.
2350 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
2352 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
2353 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
2354 a subversion directory. The git version of this script will be added in a follow up patch.
2357 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
2358 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
2359 relationship via "build_commits" relations.
2361 In order to migrate an existing instance of this application, run the following SQL commands:
2365 INSERT INTO commits (commit_repository, commit_revision, commit_time)
2366 (SELECT DISTINCT ON (revision_repository, revision_value)
2367 revision_repository, revision_value, revision_time FROM build_revisions);
2369 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
2370 FROM commits, build_revisions
2371 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
2373 DROP TABLE build_revisions;
2378 The helper script to submit commit logs can be used as follows:
2380 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
2381 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
2383 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
2384 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
2385 "feeder-slave-password" as the builder name and the builder password respectively.
2387 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
2388 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
2391 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
2393 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
2394 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
2396 - Not specified - It returns every single commit for a given repository.
2397 - Matches "oldest" - It returns the commit with the oldest timestamp.
2398 - Matches "latest" - It returns the commit with the latest timestamp.
2399 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
2400 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
2401 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
2402 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
2403 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
2404 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
2406 (commit_from_revision):
2407 (fetch_commits_between):
2410 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
2411 See tests/api-report-commits.js for examples on how to use this API.
2413 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
2414 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
2415 to optimize this and other JSON APIs.
2417 * public/include/db.php:
2418 (Database::select_or_insert_row):
2419 (Database::update_or_insert_row): Added.
2420 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
2421 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
2423 (Database::select_first_row):
2424 (Database::select_last_row): Added.
2425 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
2426 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
2428 * public/include/report-processor.php:
2429 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
2430 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
2431 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
2434 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
2436 * tests/api-report-commits.js: Added.
2437 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
2440 * tools/pull-svn.py: Added. See above for how to use this script.
2442 (determine_first_revision_to_fetch):
2443 (fetch_revision_from_dasbhoard):
2444 (fetch_commit_and_resolve_author):
2447 (resolve_author_name_from_email):
2450 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
2452 Update Install.md for Mavericks and fix typos
2453 https://bugs.webkit.org/show_bug.cgi?id=137276
2455 Reviewed by Benjamin Poulain.
2457 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
2459 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
2461 Finally, init-database.sql is no longer located inside database directory.
2465 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2467 Report run id's in api/runs.php for the new dashboard UI
2468 https://bugs.webkit.org/show_bug.cgi?id=135813
2470 Reviewed by Andreas Kling.
2472 Include run_id in the generated JSON.
2474 * public/api/runs.php:
2475 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
2478 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2480 Merging platforms mixes baselines and targets into reported data
2481 https://bugs.webkit.org/show_bug.cgi?id=135260
2483 Reviewed by Andreas Kling.
2485 When merging two platforms, move test configurations of a different type (baseline, target)
2486 as well as of different metric (Time, Runs).
2488 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
2489 It's sufficient to detect one such test_runs object.
2491 * public/admin/platforms.php:
2494 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
2496 Merging platforms mixes baselines and targets into reported data
2497 https://bugs.webkit.org/show_bug.cgi?id=135260
2499 Reviewed by Geoffrey Garen.
2501 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
2502 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
2504 * public/admin/platforms.php:
2506 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
2508 Build fix after r171361.
2510 * public/js/helper-classes.js:
2511 (.this.formattedBuildTime):
2513 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
2515 Perf dashboard spends 2s processing JSON data during the page loads
2516 https://bugs.webkit.org/show_bug.cgi?id=135152
2518 Reviewed by Andreas Kling.
2520 In the Apple internal dashboard, we were spending as much as 2 seconds
2521 converting raw JSON data into proper JS objects while loading the dashboard.
2523 This caused the apparent unresponsiveness of the dashboard despite of the fact
2524 charts themselves updated almost instantaneously.
2526 * public/index.html:
2527 * public/js/helper-classes.js:
2528 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
2529 lazily as creating new Date objects and running string replace is expensive.
2530 (TestBuild.formattedTime):
2531 (TestBuild.formattedBuildTime):
2532 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
2533 (PerfTestRuns.addResult): Deleted.
2535 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
2537 Perf dashboard shouldn't show the full git hash
2538 https://bugs.webkit.org/show_bug.cgi?id=135083
2540 Reviewed by Benjamin Poulain.
2542 Detect Git/Mercurial hash by checking the length.
2544 If it's a hash, use the first 8 characters in the label
2545 while retaining the full length to be used in hyperlinks.
2547 * public/js/helper-classes.js:
2548 (.this.formattedRevisions):
2551 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
2553 Add an instruction on how to backup the database.
2554 https://bugs.webkit.org/show_bug.cgi?id=133391
2556 Rubber-stamped by Andreas Kling.
2560 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2562 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
2564 * public/js/helper-classes.js:
2565 (PerfTestRuns.smallerIsBetter):
2567 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2571 * public/common.css:
2573 * public/index.html:
2577 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2579 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
2580 https://bugs.webkit.org/show_bug.cgi?id=131157
2582 Reviewed by Andreas Kling.
2584 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
2585 This allows, for example, adding all metrics such as Arithmetic and Geometric for
2586 a given test suite without also adding its subtests.
2588 * public/index.html:
2592 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2594 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
2595 https://bugs.webkit.org/show_bug.cgi?id=131155
2597 Reviewed by Andreas Kling.
2599 The bug was caused by Chart.attach binding event listeners on plot container on each call.
2600 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
2601 click when attach() has been called even number of times, keeping the tooltip invisible.
2603 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
2604 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
2605 is called for the first time.
2607 * public/index.html:
2609 (Chart..bindPlotEventHandlers):
2611 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2613 WebKitPerfMonitor: Tooltips can be cut off at the top
2614 https://bugs.webkit.org/show_bug.cgi?id=130960
2616 Reviewed by Andreas Kling.
2618 * public/common.css:
2619 (#title): Removed the gradients, box shadows, and border from the header.
2620 (#title h1): Reduce the font size.
2621 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
2622 * public/index.html:
2623 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
2624 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
2625 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
2626 * public/js/helper-classes.js:
2627 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
2628 tooltip extending above y=0.
2630 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2632 WebKitPerfMonitor: Y-axis adjustment is too aggressive
2633 https://bugs.webkit.org/show_bug.cgi?id=130937
2635 Reviewed by Andreas Kling.
2637 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
2638 results. This had two major problems:
2639 1. Two standard deviations can be too small to show the confidence interval for results.
2640 2. Sometimes baseline and target can be more than two standards deviations away.
2642 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
2643 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
2644 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
2645 the margin on each side separately to reduce the empty space on either side.
2647 A more rigorous approach would involve computing least squared value of results with respect to intervals
2648 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
2650 * public/index.html:
2651 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
2652 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
2653 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
2654 We wouldn't see the difference between measured values versus baseline and target values otherwise.
2655 * public/js/helper-classes.js:
2656 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
2657 interval delta cannot be computed.
2658 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
2659 within the given interval.
2660 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
2661 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
2662 (PerfTestRuns..unscaledMeansForAllResults):
2663 (PerfTestRuns.min): Take the confidence interval delta into account.
2664 (PerfTestRuns.max): Ditto.
2665 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
2666 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
2668 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
2670 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
2672 Some CSS tweaks after r166477 and r166479,
2674 * public/index.html:
2676 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2678 WebKitPerfMonitor: Sometimes text inside panes overlap
2679 https://bugs.webkit.org/show_bug.cgi?id=130956
2681 Reviewed by Gyuyoung Kim.
2683 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
2684 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
2685 reduces the total height of the pane and fits more information per screen capita on the dashboard.
2687 * public/index.html: Updated and added a bunch of CSS rules for the new look.
2688 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
2689 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
2690 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
2691 of the build info shown in a chart pane and a tooltip.
2692 (Chart): Made .status a table.
2693 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
2694 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
2695 now that status.text no longer contains it.
2696 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
2698 * public/js/helper-classes.js:
2699 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
2700 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
2701 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
2702 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
2703 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
2704 capital letter; e.g. "MB" instead of "M B".
2706 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2708 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
2709 https://bugs.webkit.org/show_bug.cgi?id=130957
2711 Reviewed by Gyuyoung Kim.
2713 Moved the slider into the header. Also reduced the spacing between the header and platform names.
2714 This reclaims 50px × width of the screen real estate.
2716 * public/common.css:
2717 (#title): Reduced the space below the header from 20px to 10px.
2718 * public/index.html:
2719 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
2720 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
2721 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
2722 real estate between the header and the platform names.
2724 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2726 Update the install guidelines for perf.webkit.org
2727 https://bugs.webkit.org/show_bug.cgi?id=129895
2729 Reviewed by Ryosuke Niwa.
2731 The current install guideline for perf.webkit.org discourages the use of the installed
2732 Server application. I've actualized the documentation for Mavericks, and modified the
2733 guideline to include the instructions for Server.app also.
2737 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
2739 Update perf.webkit.org json example
2740 https://bugs.webkit.org/show_bug.cgi?id=129907
2742 Reviewed by Andreas Kling.
2744 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
2748 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
2750 Merge database-common.js and utility.js into run-tests.js.
2752 Reviewed by Matthew Hanson.
2754 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
2755 Also moved init-database.sql out of the database directory and removed the directory entirely.
2757 * database: Removed.
2758 * database/database-common.js: Removed.
2759 * database/utility.js: Removed.
2760 * init-database.sql: Moved from database/init-database.sql.
2762 (connect): Moved from database-common.js.
2763 (pathToDatabseSQL): Extracted from pathToLocalScript.
2764 (pathToTests): Moved from database-common.js.
2767 (SerializedTaskQueue): Ditto.
2769 (initializeDatabase):
2770 (TestEnvironment.it):
2771 (TestEnvironment.queryAndFetchAll):
2774 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2776 Remove the dependency on node.js from the production code.
2778 Reviewed by Ricky Mondello.
2780 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
2782 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
2783 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
2784 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
2785 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
2786 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
2788 Also removed the js files that are no longer used.
2790 * config.json: Moved from database/config.json.
2791 * database/aggregate.js: Removed. No longer used.
2792 * database/database-common.js: Removed unused functions, and updated the path to config.json.
2793 * database/process-jobs.js: Removed. No longer used.
2794 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2795 * database/schema.graffle: Removed. It's completely obsolete.
2796 * public/include/db.php: Updated the path to config.json.
2797 * public/include/evaluator.js: Removed.
2799 * public/include/report-processor.php:
2800 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2801 storing values into $expressions and calling evaluate_expressions_by_node.
2802 (TestRunsGenerator::aggregate_values): Added.
2803 (TestRunsGenerator::compute_caches): Directly compute the caches.
2805 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2807 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2809 * public/admin/platforms.php:
2810 * public/include/db.php:
2812 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2814 Zoomed y-axis view is ununsable when the last result is an outlier.
2816 Reviewed by Stephanie Lewis.
2818 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2819 the last result so that the graph looks sane if the last result was an outlier. However, always show
2820 the last result's mean even if it was an outlier.
2822 * public/index.html:
2823 * public/js/helper-classes.js:
2824 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2825 Also added the ability to cache the unscaled means to avoid recomputation.
2826 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2827 (PerfTestRuns.max): Ditto.
2828 (PerfTestRuns.sampleStandardDeviation): Ditto.
2829 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2831 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2835 * public/admin/tests.php:
2836 * public/js/helper-classes.js:
2838 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2840 Use two standard deviations instead as I mentioned in the mailing list.
2842 * public/index.html:
2844 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2846 The performance dashboard erroneously shows upward arrow for combined metrics.
2848 A single outlier can ruin the zoomed y-axis view.
2850 Rubber-stamped by Antti Koivisto.
2852 * public/index.html:
2853 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2854 from the latest results' mean.
2855 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2856 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2857 (Chart.toggleYAxis):
2858 * public/js/helper-classes.js:
2859 (PerfTestRuns.sampleStandardDeviation): Added.
2860 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2862 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2864 Don't include the confidence interval when computing the y-axis.
2866 Rubber-stamped by Simon Fraser.
2868 * public/js/helper-classes.js:
2872 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2874 Tiny CSS tweak for tooltips.
2876 * public/index.html:
2878 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2880 Remove the erroneously repeated code.
2882 * public/admin/test-configurations.php:
2884 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2886 <rdar://problem/15704893> perf dashboard should show baseline numbers
2888 Reviewed by Stephanie Lewis.
2890 * public/admin/bug-trackers.php:
2891 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2894 * public/admin/platforms.php:
2895 (merge_list): Ditto.
2897 * public/admin/test-configurations.php: Added.
2898 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2899 build_revisions as they're not meaningful for baseline / target numbers.
2900 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2901 one test run so that we don't accidentally delete a reported test run.
2902 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2903 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2904 and delete existing ones.
2906 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2907 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2908 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2910 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2911 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2912 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2913 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2914 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2916 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2918 * public/include/admin-header.php:
2919 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2920 have id and type sub columns, and each custom column could generate multiple rows.
2922 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2923 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2924 We then proceed to generate the second header row with sub column names.
2926 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2927 which case regular columns need rowspan set to the maximum number of rows.
2929 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2932 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2933 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2934 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2935 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2936 expanded to occupy all sub columns.
2938 * public/include/manifest.php:
2939 (ManifestGenerator::platforms): Don't add the metric more than once.
2941 * public/include/test-name-resolver.php:
2942 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2943 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2944 full metric name later.
2945 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2946 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2947 (TestNameResolver::full_name_for_test): Added.
2948 (TestNameResolver::full_name_for_metric): Added.
2949 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2951 * public/js/helper-classes.js:
2952 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2953 test runs created to set baseline and target points.
2955 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2957 Build fix after r57928. Removed a superfluous close parenthesis.
2959 * public/api/runs.php:
2961 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2963 Unreviewed build & typo fixes.
2965 * public/admin/platforms.php:
2966 * tests/admin-platforms.js:
2968 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2970 <rdar://problem/15704893> perf dashboard should show baseline numbers
2972 Rubber-stamped by Antti Koivisto.
2974 Organize some code into functions in runs.php.
2976 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2978 * public/api/runs.php:
2979 (fetch_runs_for_config): Extracted.
2980 (format_run): Ditto.
2982 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2984 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2986 * database/config.json:
2987 * public/admin/reprocess-report.php:
2988 * public/api/report.php:
2989 * public/api/runs.php:
2990 * public/include/json-header.php:
2992 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2994 Commit yet another forgotten change.
2996 Something went horribly wrong with my merge :(
2998 * database/init-database.sql:
3000 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
3002 Commit one more forgotten change. Sorry for making a mess here.
3004 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
3006 Commit the forgotten files.
3008 * public/admin/platforms.php: Added.
3009 * tests/admin-platforms.js: Added.
3011 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
3013 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
3015 Reviewed by Stephanie Lewis.
3017 Added /admin/platforms/ page to hide and merge platforms.
3019 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
3020 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
3021 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
3022 each test configuration a distinct "test run" for each build.
3024 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
3025 their test configurations into platform B.
3027 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
3028 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
3029 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
3030 in platform B, in which case R should relate to T_B instead.
3032 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
3033 new platform. We then migrate the test configurations of the remaining test runs.
3035 * database/init-database.sql: Added platform_hidden.
3037 * public/admin/platforms.php: Added.
3038 (merge_platforms): Added. Implements the algorithm described above.
3039 (merge_list): Added.
3041 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
3042 is hidden since it doesn't do anything.
3044 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
3045 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
3046 missing it since unchecked checkbox doesn't set the value in $_POST.
3047 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
3048 switch statement instead of repeated if's.
3049 (AdministrativePage::render_table): Emit "update-column" for update_field.
3051 * public/include/db.php: Disable warnings when we're not in the debug mode.
3053 * public/include/manifest.php:
3054 (ManifestGenerator::platforms): Skip platforms that have been hidden.
3057 (TestEnvironment.postJSON):
3058 (TestEnvironment.httpGet):
3059 (TestEnvironment.httpPost): Added.
3060 (sendHttpRequest): Set the content type if specified.
3062 * tests/admin-platforms.js: Added tests.
3064 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
3066 Extract the code to compute full test names from tests.php.
3068 Reviewed by Stephanie Lewis.
3070 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
3071 and paves our way to re-use the code in other pages.
3073 * public/admin/tests.php:
3075 * public/include/db.php:
3076 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
3077 tests.php and test-name-resolver.php.
3079 * public/include/test-name-resolver.php: Added.
3080 (TestNameResolver::__construct):
3081 (TestNameResolver::compute_full_name): Moved from tests.php.
3082 (TestNameResolver::map_metrics_to_tests): Ditto.
3083 (TestNameResolver::sort_tests_by_full_name): Ditto.
3084 (TestNameResolver::tests): Added.
3085 (TestNameResolver::test_id_for_full_name): Ditto.
3086 (TestNameResolver::metrics_for_test_id): Ditto.
3087 (TestNameResolver::child_metrics_for_test_id): Ditto.
3088 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
3090 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
3092 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
3094 Reviewed by Stephanie Lewis.
3096 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
3098 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
3099 but that's sufficient to correct the wrongfully processed reports for now.
3101 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
3102 We should eventually add a nice UI to find and reprocess reports.
3104 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
3106 * public/include/db.php: Added the forgotten call to prefixed_column_names.
3108 * public/include/report-processor.php: Copied from public/api/report.php.
3109 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
3110 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
3111 create a new report or authenticate the builder password (the password is never stored in the report).
3112 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
3113 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
3114 (ReportProcessor::store_report): Ditto.
3116 * tests/admin-reprocess-report.js: Added.
3118 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
3120 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
3122 Reviewed by Ricky Mondello.
3124 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
3125 for the same build number as a single build by ignoring build time. This was necessary to associate
3126 multiple reports by a single build - e.g. for different performance test suites - because the scripts
3127 we use to submit results computed its own "build time" when they're called.
3129 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
3130 last week; new reports were wrongfully associated with old build numbers.
3132 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
3133 to the same build. Instead, we create a new build object for those reports. Since the longest set of
3134 tests we have only take a couple of hours to run, 24 hours should be more than enough.
3136 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
3137 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
3138 (builder, build number, build time).
3140 * public/api/report.php:
3141 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
3142 when no such build exists. This prevents a report from being associated with a very old build of the same
3145 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
3146 a similar bug in the future sooner.
3148 * tests/api-report.js: Added three test cases.
3150 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
3152 Merged the upstream changes to db.php
3153 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
3155 * public/include/db.php:
3157 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
3159 Update other scripts and tests per previous patch.