1 2015-04-02 Ryosuke Niwa <rniwa@webkit.org>
3 Perf dashboard should have UI to test out anomaly detection strategies
4 https://bugs.webkit.org/show_bug.cgi?id=143290
6 Reviewed by Benjamin Poulain.
8 Added the UI to select anomaly detection strategies. The detected anomalies are highlighted in the graph.
10 Implemented the Western Electric Rules 1 through 4 in http://en.wikipedia.org/wiki/Western_Electric_rules
11 as well as Welch's t-test that compares the last five points to the prior twenty points.
13 The latter is what Mozilla uses (or at least did in the past) to detect performance regressions on their
14 performance tests although they compare medians instead of means.
16 All of these strategies don't quite work for us since our data points are too noisy but this is a good start.
19 (App.Pane.updateStatisticsTools): Clone anomaly detection strategies.
20 (App.Pane._updateMovingAverageAndEnvelope): Highlight anomalies detected by the enabled strategies.
21 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Observe changes to anomaly detection strategies.
22 (App.Pane._computeMovingAverageAndOutliers): Detect anomalies by each strategy and aggregate results.
23 Only report the first data point when multiple consecutive data points are detected as anomalies.
24 * public/v2/chart-pane.css: Updated styles.
25 * public/v2/index.html: Added the pane for selecting anomaly detection strategies.
26 * public/v2/js/statistics.js:
27 (Statistics.testWelchsT): Added. Implements Welch's t-test.
28 (.sampleMeanAndVarianceForValues): Added.
29 (.createWesternElectricRule): Added.
30 (.countValuesOnSameSide): Added.
31 (Statistics.AnomalyDetectionStrategy): Added.
33 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
35 REGRESSION: Searching commits can highlight wrong data points
36 https://bugs.webkit.org/show_bug.cgi?id=143272
38 Reviewed by Antti Koivisto.
40 The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
41 return commit times with only second precision. This resulted in the frontend code to match a commit
42 with the data point that included the next commit when the millisecond component of commit's timestamp
45 This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
46 was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
47 so miliseconds component was only preserved in /api/commits.
49 Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
50 it returns time in milisecond precision.
52 * public/api/commits.php:
53 (fetch_commits_between): Use Database::to_js_time for format commit times.
54 (format_commit): Ditto.
55 * public/include/db.php:
56 (Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
58 (CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
60 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
62 Perf dashboard should show relative change in values
63 https://bugs.webkit.org/show_bug.cgi?id=143252
65 Reviewed by Antti Koivisto.
67 When a range of values are selected, show the percentage difference between the start and the end
68 in addition to the absolute value difference. When a single point is selected, show the relative
69 difference with respect to the previous point. Use two significant figures and always show plus sign
70 when the difference is positive.
72 * public/v2/app.js: Compute and format the relative difference.
73 * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
74 * public/v2/index.html: Show the relative difference.
76 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
78 REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
79 https://bugs.webkit.org/show_bug.cgi?id=143254
81 Reviewed by Antti Koivisto.
83 The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
84 or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
85 so that the interactive chart component will observe a change to 'chartData'.
88 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
90 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
92 Unreviewed build fixes.
94 * public/include/manifest.php:
95 (Manifest::generate): These should be {} instead of [] when they're empty.
97 (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
98 * public/v2/manifest.js:
99 (App.Metric.fullName): Fixed the typo.
100 * tests/admin-regenerate-manifest.js: Fixed the test.
102 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
104 Commit the erroneously reverted change.
106 * public/api/runs.php:
107 (RunsGenerator::results):
109 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
111 Loading the perf dashboard takes multiple seconds
112 https://bugs.webkit.org/show_bug.cgi?id=141860
114 Reviewed by Andreas Kling.
116 This patch introduces the caches of JSON files returned by /api/ in /data/ directory. It also records
117 the last time test_runs rows associated with the requested platforms and metrics are inserted, updated,
118 or removed in the caches as well as the manifest JSON files ("last modified time"). Because the manifest
119 is regenerated each time a new test result is reported, the front end can compare last modified time in
120 the manifest file with that in a /api/runs JSON cache to detect the stale-ness.
122 More concretely, the front end first optimistically fetches the JSON in /data/. If the cache doesn't exit
123 or the last modified time in the cache doesn't match with that in the manifest file, it would fetch it
124 again via /api/runs. In the case the cache did exist, we render the charts based on the cache meanwhile.
125 This dramatically reduces the perceived latency for the page load since charts are drawn immediately using
126 the cache and we would only re-render the charts as new up-to-date JSON comes in.
128 This patch also changes the format of runs JSONs by pushing the exiting properties into 'configurations'
129 and adding 'lastModified' and 'elapsedTime' at the top level.
131 * init-database.sql: Added config_runs_last_modified to test_configurations table as well as a trigger to
132 auto-update this column upon changes to test_runs table.
134 * public/admin/test-configurations.php:
135 (add_run): Regenerate the manifest file to invalidate the /api/runs JSON cache.
138 * public/api/runs.php:
139 (main): Fetch all columns of test_configurations table including config_runs_last_modified. Also generate
140 the cache in /data/ directory.
141 (RunsGenerator::__construct): Compute the last modified time for this (platform, metric) pair.
142 (RunsGenerator::results): Put the old content in 'configurations' property and include 'lastModified' and
143 'elapsedTime' properties. 'elapsedTime' is added for debugging purposes.
144 (RunsGenerator::add_runs):
145 (RunsGenerator::parse_revisions_array):
147 * public/include/db.php:
149 (generate_data_file): Added based on ManifestGenerator::store.
150 (Database::to_js_time): Extracted from RunsGenerator::add_runs to share code.
152 * public/include/json-header.php:
153 (echo_success): Renamed from success_json. Return the serialized JSON instead of echo'ing it so that we can
154 generate caches in /api/runs/.
157 * public/include/manifest.php:
158 (ManifestGenerator::generate): Added 'elapsedTime' property for the time taken to generate the manifest.
159 It seems like we're generating it in 200-300ms for now so that's good.
160 (ManifestGenerator::store): Uses generate_data_file.
161 (ManifestGenerator::platforms): Added 'lastModified' array to each platform entry. This array contains the
162 last modified time for each (platform, metric) pair.
165 (fetchTest): Updated per the format change in runs JSON.
168 (App.Pane._fetch): Fetch the cached JSON first. Refetch the uncached version if instructed as such.
169 (App.Pane._updateChartData): Extracted from App.Pane._fetch.
170 (App.Pane._handleFetchErrors): Ditto.
173 (RunsData.fetchRuns): Takes the fourth argument indicating whether we should fetch the cached version or not.
174 The cached JSON is located in /data/ with the same filename. When fetching a cached JSON results in 404,
175 fulfill the promise with null as the result instead of rejecting it. The only client of this function which
176 sets useCache to true is App.Manifest.fetchRunsWithPlatformAndMetric, and it handles this special case.
178 * public/v2/manifest.js:
179 (App.DateArrayTransform): Added. Handles the array of last modified dates in platform objects.
180 (App.Platform.lastModifiedTimeForMetric): Added. Returns the last modified date in the manifest JSON.
181 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes "useCache" like RunsData.fetchRuns. Set shouldRefetch
182 to true if response is null (the cache didn't exit) or the cache is out-of-date.
183 (App.Manifest._formatFetchedData): Extracted from App.Manifest.fetchRunsWithPlatformAndMetric.
186 (initializeDatabase): Avoid splitting function definitions in the middle.
188 * tests/api-report.js: Added tests to verify that reporting new test results updates the last modified time
189 in test_configurations.
191 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
193 REGRESSION(r180333): Analysis tasks can't be associated with bugs
194 https://bugs.webkit.org/show_bug.cgi?id=141858
196 Reviewed by Andreas Kling.
198 Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
199 of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
201 * public/v2/chart-pane.css:
202 * public/v2/index.html:
204 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
206 Selecting revisions for A/B testing is hard
207 https://bugs.webkit.org/show_bug.cgi?id=141824
209 Reviewed by Andreas Kling.
211 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
212 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
213 select A/B testing points manually.
215 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
216 sets to 'options' for clarity.
218 * public/v2/app.css: Reorganized style rules.
221 (App.AnalysisTaskController):
222 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
223 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
224 a property, which sets 'overviewDomain' property as well as other properties.
225 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
226 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
227 in the overview chart.
229 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
230 individual build requests / test results are shown or not.
232 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
233 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
235 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
237 Unreviewed test fixes after r179037, r179591, and r179763.
239 * tests/admin-regenerate-manifest.js:
240 * tests/admin-reprocess-report.js:
242 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
244 Relationship between A/B testing results are unclear
245 https://bugs.webkit.org/show_bug.cgi?id=141810
247 Reviewed by Andreas Kling.
249 Show a "reference chart" indicating which two points have been tested in each test group pane.
251 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
252 and the domain used in this chart to show charts in each test group.
254 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
256 * public/v2/analysis.js:
257 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
258 since this is the results of A/B testing results, not the data for charts shown next to them.
260 * public/v2/app.css: Added CSS rules for reference charts.
263 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
264 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
265 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
266 identically matches root sets. If one of configuration used a set of revisions for which no measurement
267 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
268 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
269 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
270 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
273 (Measurement.prototype.revisionForRepository): Added.
274 (Measurement.prototype.commitTimeForRepository): Cleanup.
275 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
277 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
278 by including the build number in the title attribute instead of in the markup.
280 * public/v2/interactive-chart.js:
281 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
282 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
283 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
285 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
287 Analysis task pages are unusable
288 https://bugs.webkit.org/show_bug.cgi?id=141786
290 Reviewed by Andreas Kling.
292 This patch makes following improvements to analysis task pages:
293 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
294 compute the data for the details pane from PaneController.
295 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
296 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
297 This change required the creation of App.TestGroupPane as well as its methods.
298 4. Show a box plot for each root set configuration as well as each build request. This change required
299 App.BoxPlotComponent.
300 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
302 * public/api/build-requests.php:
303 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
305 * public/api/test-groups.php:
306 (main): Include root sets and roots in the response.
309 * public/include/build-requests-fetcher.php:
310 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
311 (BuildRequestsFetcher::root_sets): Added.
312 (BuildRequestsFetcher::roots): Added.
313 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
314 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
315 tools/sync-with-buildbot.py can't convert repository names to their ids.
317 * public/v2/analysis.js:
319 (App.RootSet): Added.
320 (App.RootSet.revisionForRepository): Added.
321 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
322 response at /api/test-groups will include them.
323 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
324 _createConfigurationSummary.
325 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
326 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
328 * public/v2/app.css: Updated style rules for analysis task pages.
331 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
332 (App.Pane._updateDetails): Moved from App.PaneController.
334 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
336 (App.AnalysisTaskController): Added 'details'.
337 (App.AnalysisTaskController._taskUpdated):
338 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
339 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
340 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
342 (App.TestGroupPane): Added.
343 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
344 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
345 of all repositories appearing in root sets and builds associated with A/B testing results.
346 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
347 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
348 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
349 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
350 is a union of revisions in the root set and the first build request in the group. We null-out revision info
351 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
352 by the values in the group as well as 95% percentile confidence interval.
354 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
355 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
356 the mean and the confidence interval.
357 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
358 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
359 calls _updateBars to update the rects.
361 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
364 (Measurement.prototype.formattedRevisions):
365 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
366 called in _createConfigurationSummary.
368 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
369 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
370 Also made the fetching of chartData no longer block showing of test groups.
372 * public/v2/interactive-chart.js:
373 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
374 (App.InteractiveChartComponent._domainChanged): Ditto.
375 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
377 * public/v2/js/statistics.js:
378 (Statistics.min): Added.
379 (Statistics.max): Added.
381 * public/v2/manifest.js:
382 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
384 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
386 Build URL on new perf dashboard doesn't resolve $builderName
387 https://bugs.webkit.org/show_bug.cgi?id=141583
389 Reviewed by Darin Adler.
391 Support $builderName in the build URL template.
393 * public/js/helper-classes.js:
394 (TestBuild.buildUrl): Replaced $builderName with the builder name.
396 * public/v2/manifest.js:
397 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
398 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
400 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
402 Unreviewed build fix after r179591.
404 * public/api/commits.php:
406 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
408 The status of a A/B testing request always eventually becomes "Failed"
409 https://bugs.webkit.org/show_bug.cgi?id=141523
411 Reviewed by Andreas Kling.
413 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
414 'failedIfNotCompleted' was sent by the buildbot sync'er.
416 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
418 * public/api/build-requests.php:
421 2015-02-13 Csaba OsztrogonĂ¡c <ossy@webkit.org>
423 Unreviewed, remove empty directories.
425 * public/data: Removed.
427 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
429 Perf dashboard should show the results of A/B testing
430 https://bugs.webkit.org/show_bug.cgi?id=141500
432 Reviewed by Chris Dumez.
434 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
435 analysis task page to fetch results for each test group.
437 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
438 can use the formatter.
440 * public/api/runs.php:
441 (fetch_runs_for_config_and_test_group): Added.
442 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
443 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
444 use RunsGenerator to format results.
445 (RunsGenerator): Added.
446 (RunsGenerator::__construct): Added.
447 (RunsGenerator::add_runs): Added.
448 (RunsGenerator::format_run): Moved.
449 (RunsGenerator::parse_revisions_array): Moved.
451 * public/v2/analysis.js:
452 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
453 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
454 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
455 configuration associated with this build request such as "A" and "B".
456 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
457 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
458 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
462 (App.Pane._fetch): Set chartData directly here.
463 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
464 now that it's done in App.Pane._fetch.
465 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
468 (Measurement.prototype.buildId): Added.
469 (TimeSeries.prototype.findPointByBuild): Added.
471 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
472 url is not an Ember routed path.
474 * public/v2/manifest.js:
475 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
476 App.createChartData here so that App.BuildRequest can use the formatter
478 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
480 v2 UI should adjust the number of ticks on dashboards based on screen size
481 https://bugs.webkit.org/show_bug.cgi?id=141502
483 Reviewed by Chris Dumez.
485 * public/v2/interactive-chart.js:
486 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
489 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
491 New perf dashboard shows too much space around interesting data points
492 https://bugs.webkit.org/show_bug.cgi?id=141487
494 Reviewed by Chris Dumez.
496 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
497 show the current time series excluding points in the series outside the moving average envelope.
500 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
501 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
502 time series if the point lies outside the moving average envelope. Don't expose the moving average or
503 the envelope computed for this purpose if they're not set by the user.
506 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
507 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
509 * public/v2/interactive-chart.js:
510 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
511 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
512 to deal with showFullYAxis here.
513 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
514 argument instead of directly inspecting showFullYAxis.
516 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
518 New perf dashboard shouldn't always show outliners
519 https://bugs.webkit.org/show_bug.cgi?id=141445
521 Reviewed by Chris Dumez.
523 Use the simple moving average with an average difference envelope to compute the y-axis range to show
524 to avoid expanding it spuriously to show one off outlier.
527 (App.Pane): Don't show the full y-axis range by default.
528 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
529 one is not specified by the user but without showing them in the charts.
530 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
531 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
533 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
534 (App.ChartsController._serializePaneList): Ditto.
536 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
538 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
540 * public/v2/interactive-chart.js:
541 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
542 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
543 if they are not specified by the user (i.e. only used to adjust y-axis range).
544 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
545 x-axis domain remained the same. Without this change, the charts would never redraw.
546 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
547 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
548 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
550 * public/v2/js/statistics.js:
551 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
553 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
555 Unreviewed build fix.
558 (set get App.Pane.Ember.Object.extend):
560 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
562 New perf dashboard should have the ability to overlay moving average with an envelope
563 https://bugs.webkit.org/show_bug.cgi?id=141438
565 Reviewed by Andreas Kling.
567 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
569 Simple Moving Average - The moving average x̀„_i of x_i is computed as the arithmetic mean of values
570 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
571 n, backward window size, and m, forward window size, as an argument.
573 Cumulative Moving Average - x̀„_i is computed as the arithmetic mean of all values x_0 though x_i.
574 That is, x̀„_1 = x_1 and x̀„_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
576 Exponential Moving Average - x̀„_i is computed as the weighted average of x_i and x̀„_(i - 1) with α as
577 an argument specifying x_i's weight. To be precise, x̀„_1 = x_1 and x̀„_i = α * x_i + (α - 1) x̀„_(i-1).
580 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
581 between each x_i and x̀„_i.
583 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
584 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
585 the average of (x_i - x̀„_i)^2 as the "sample variance" instead of the conventional (x_i - x̀„)^2 where
586 x̀„ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
589 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
590 The configuration of the currently chosen strategies is saved in the query string for convenience.
592 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
594 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
597 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
598 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
599 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
600 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
601 from the query string via ChartsController.
602 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
603 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
604 (App.Pane._executeStrategy): Added.
605 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
607 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
608 selections, and added two new arguments for the moving average and the enveloping configurations.
609 (App.ChartsController._serializePaneList): Ditto.
610 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
611 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
612 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
613 (App.PaneController.actions.toggleStatPane): Added.
615 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
616 current (as opposed to baseline and target) time series for when it's the most foreground graph without
617 moving average and its envelope overlapping on top of it.
619 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
621 * public/v2/interactive-chart.js:
622 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
623 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
624 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
625 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
626 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
627 but don't bother removing individual paths and circles. Added the code to show the moving average time
628 series when there is one. Also add "foreground" class on SVG elements for the current time series when
629 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
630 series when "foreground" is not set.
631 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
632 account when computing the y-axis range.
633 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
635 * public/v2/js/statistics.js:
636 (Statistics.MovingAverageStrategies): Added.
637 (Statistics.EnvelopingStrategies): Added.
639 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
641 The delta value in the chart pane sometimes doens't show '+' for a positive delta
642 https://bugs.webkit.org/show_bug.cgi?id=141340
644 Reviewed by Andreas Kling.
646 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
647 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
650 (App.Pane.computeStatus):
651 (App.createChartData):
653 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
655 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
658 (App.PaneController._updateDetails):
660 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
662 Unreviewed. Commit the forgotten change.
664 * public/include/manifest.php:
666 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
668 New perf dashboard should have multiple dashboard pages
669 https://bugs.webkit.org/show_bug.cgi?id=141339
671 Reviewed by Chris Dumez.
673 Added the support for multiple dashboard pages. Also added the status of the latest data point.
674 e.g. "5% better than target"
676 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
677 Also hid the border lines around charts on the dashboard page for a cleaner look.
680 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
681 (App.IndexRoute.beforeModel): Added.
682 (App.DashboardRoute): Added.
683 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
684 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
685 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
686 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
687 (App.DashboardController): Renamed from App.IndexController.
688 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
689 and "defaultDashboard" as these are taken care of by newly added routers.
690 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
691 now done in actions.toggleEditMode.
692 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
693 an existing dashboard.
695 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
696 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
697 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
698 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
700 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
702 (App.PaneController._updateDetails): Updated per changes to computeStatus.
704 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
707 (TimeSeries.prototype.lastPoint): Added.
709 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
710 on the dashboard, and enumerate all predefined dashboards.
712 * public/v2/interactive-chart.js:
713 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
714 for the dashboard page.
716 * public/v2/manifest.js:
717 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
718 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
719 IDs are generated for each dashboard for forward compatibility.
721 (App.Manifest.dashboardByName): Added.
722 (App.Manifest.defaultDashboardName): Added.
723 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
725 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
727 Move commits viewer to the end of details view
728 https://bugs.webkit.org/show_bug.cgi?id=141315
730 Rubber-stamped by Andreas Kling.
732 Show the difference instead of the old value per kling's request.
735 (App.PaneController._updateDetails):
736 * public/v2/index.html:
738 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
740 Move commits viewer to the end of details view
741 https://bugs.webkit.org/show_bug.cgi?id=141315
743 Reviewed by Andreas Kling.
745 Improved the way list of commits are shown per kling's request.
748 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
750 * public/v2/chart-pane.css: Updated the style for the commits viewer.
752 * public/v2/commits-viewer.js:
753 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
754 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
756 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
757 moved the commits viewers out of the details tables so that they don't interleave revision data.
759 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
761 New perf dashboard should compare results to baseline and target
762 https://bugs.webkit.org/show_bug.cgi?id=141286
764 Reviewed by Chris Dumez.
766 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
767 Also use d3.format to format the selected value to show four significant figures.
770 (App.Pane.searchCommit):
771 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
772 to compute the status text without having to recreate them.
773 (App.createChartData): Added.
774 (App.PaneController._updateDetails): Use 3d.format on current and old values.
775 (App.PaneController._computeStatus): Added. Computes the status text.
776 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
777 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
778 format the values using chartData.formatter.
780 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
781 the baseline and in blue if it's better than the target.
784 (TimeSeries.prototype.findPointAfterTime): Added.
786 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
787 the bug that we were not showing the old value's unit.
789 * public/v2/interactive-chart.js:
790 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
791 the code to show the baseline and the target lines.
793 * public/v2/manifest.js:
794 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
796 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
798 Unreviewed build fix.
801 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
803 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
805 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
806 https://bugs.webkit.org/show_bug.cgi?id=141280
808 Reviewed by Chris Dumez.
810 Fixed the bug by passing in "since" as a query parameter to the charts page.
812 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
814 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
816 (App.IndexController): Changed the default number of days from one month to one week.
817 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
818 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
820 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
822 New perf dashboard erroneously clears zoom when poping history items
823 https://bugs.webkit.org/show_bug.cgi?id=141278
825 Reviewed by Chris Dumez.
827 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
829 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
830 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
833 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
834 shown in the main plot.
835 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
836 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
838 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
840 New perf dashboard shows null as the aggregator name if no aggregation is done
841 https://bugs.webkit.org/show_bug.cgi?id=141256
843 Reviewed by Chris Dumez.
845 Don't show the aggregator name if there isn't one.
847 * public/v2/manifest.js:
850 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
852 Unreviewed build fix after r179611.
854 * public/v2/interactive-chart.js:
856 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
858 Perf dashboard doesn’t show the right unit for Safari UI tests
859 https://bugs.webkit.org/show_bug.cgi?id=141238
861 Reviewed by Darin Adler.
863 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
864 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
865 between metrics and their units.
867 * public/js/helper-classes.js:
868 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
869 * public/v2/manifest.js:
870 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
871 * public/v2/interactive-chart.js:
872 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
873 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
875 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
877 Interactive chart component provides two duplicate API for highlighting points
878 https://bugs.webkit.org/show_bug.cgi?id=141234
880 Reviewed by Chris Dumez.
882 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
883 on the main charts page and markedPoints to show the two end points in the analysis task page.
885 This patch merges markedPoints into highlightedItems.
888 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
889 * public/v2/chart-pane.css:
890 * public/v2/index.html: Ditto.
891 * public/v2/interactive-chart.js:
892 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
893 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
894 items if highlightedItems was set before the initial layout.
895 (App.InteractiveChartComponent._relayoutDataAndAxes):
896 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
897 vertical lines, just set cx and cy as done for other "dots".
898 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
899 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
900 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
901 set the radius of highlight circles here.
903 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
905 Don’t use repository names as id’s.
906 https://bugs.webkit.org/show_bug.cgi?id=141226
908 Reviewed by Chris Dumez.
910 Not using repository names as their id's reduces the need to fetch the entire repositories table.
911 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
913 * Websites/perf.webkit.org/public/api/runs.php:
914 (parse_revisions_array): No longer uses $repository_id_to_name.
915 (main): No longer populates $repository_id_to_name.
917 * Websites/perf.webkit.org/public/api/triggerables.php:
918 (main): Don't resolve repository names.
920 * Websites/perf.webkit.org/public/include/manifest.php:
921 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
922 (ManifestGenerator::bug_trackers): Don't resolve repository names.
924 * Websites/perf.webkit.org/public/js/helper-classes.js:
925 (TestBuild): Renamed repositoryName to repositoryId.
926 (TestBuild.revision): Ditto.
927 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
928 since this is the text shown to human.
930 * Websites/perf.webkit.org/public/v2/app.js:
931 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
932 (App.PaneController._updateDetails): Ditto.
933 (App.AnalysisTaskController.updateRoots): Ditto.
935 * Websites/perf.webkit.org/public/v2/data.js:
936 (Measurement): Ditto.
937 (Measurement.prototype.commitTimeForRepository): Ditto.
938 (Measurement.prototype.formattedRevisions): Ditto.
940 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
941 select element's label and value respectively.
943 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
945 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
947 * public/api/runs.php:
949 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
951 /api/runs.php should have main function
952 https://bugs.webkit.org/show_bug.cgi?id=141220
954 Reviewed by Benjamin Poulain.
956 Wrapped the code inside main function for clarity.
958 * public/api/runs.php:
960 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
962 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
964 * tools/sync-with-buildbot.py:
965 (find_request_updates):
967 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
969 Perf dashboard always assigns the result of A/B testing with build request 1
970 https://bugs.webkit.org/show_bug.cgi?id=140382
972 Reviewed by Darin Adler.
974 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
975 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
977 Also fixed a typo as well as a bug that reports were never associated with builds.
979 * public/include/report-processor.php:
980 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
981 instead of the first non-null value.
982 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
983 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
985 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
987 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
989 * public/admin/tests.php:
991 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
993 Unreviewed build fix. Removed the stale code.
995 * public/admin/triggerables.php:
997 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
999 Perf dashboard should have the ability to post A/B testing builds
1000 https://bugs.webkit.org/show_bug.cgi?id=140317
1002 Rubber-stamped by Simon Fraser.
1004 This patch adds the support for triggering A/B testing from the perf dashboard.
1006 We add a few new tables to the database. "build_triggerables", which represents a set of builders
1007 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
1008 of repositories for which an arbitrary revision can be specified for A/B testing.
1009 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
1010 "roots" table which specifies the revision used in a given root set in each repository.
1012 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
1013 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
1014 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
1015 to build_requests table. Also made each test group's name unique in a given analysis task as it
1016 would be confusing to have multiple test groups of the same name.
1018 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
1020 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
1021 for which a specific revision can be set in an A/B testing on a given triggerable.
1023 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
1024 triggerable. Also updates the status' and the status urls of specified build requests when
1025 buildRequestUpdates is provided in the raw POST data.
1028 * public/api/runs.php:
1029 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
1030 results of an A/B testing.
1032 * public/api/test-groups.php:
1033 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
1035 * public/api/triggerables.php: Added.
1036 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
1038 * public/include/admin-header.php:
1040 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
1041 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
1042 and root sets used in those requests.D
1043 (BuildRequestsFetcher::__construct):
1044 (BuildRequestsFetcher::fetch_for_task):
1045 (BuildRequestsFetcher::fetch_for_group):
1046 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
1047 (BuildRequestsFetcher::has_results):
1048 (BuildRequestsFetcher::results):
1049 (BuildRequestsFetcher::results_with_resolved_ids):
1050 (BuildRequestsFetcher::results_internal):
1051 (BuildRequestsFetcher::root_sets):
1052 (BuildRequestsFetcher::fetch_roots_for_set):
1054 * public/include/db.php:
1055 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
1056 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
1057 table since it only has the primary key, id, column.
1058 (Database::select_or_insert_row):
1059 (Database::update_or_insert_row):
1060 (Database::update_row): Added.
1061 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
1062 should be inserted when no row matches the specified criteria. This is used while updating
1063 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
1064 new build requests in that API.
1065 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
1066 This is used in public/api/triggerables.php when no analysis task is specified.
1068 * public/include/json-header.php:
1069 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
1070 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
1071 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
1072 find the closest ancestor with a triggerable.
1074 * public/include/report-processor.php:
1075 (ReportProcessor::process):
1076 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
1077 if jobId or buildRequest is specified.
1079 * public/include/test-name-resolver.php:
1080 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
1081 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
1082 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
1085 * public/include/test-path-resolver.php: Added.
1086 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
1087 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
1088 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
1089 in order to compute full test metric names.
1090 (TestPathResolver::__construct):
1091 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
1092 the highest (a test without a parent).
1093 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
1094 the highest ancestor to the test itself.
1095 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
1097 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
1099 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
1100 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
1101 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
1102 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
1104 * public/v2/analysis.js:
1105 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
1106 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
1107 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
1108 (App.TestGroup.create): Added. Creates a new A/B testing group.
1109 (App.Triggerable): Added.
1110 (App.TriggerableAdapter): Added.
1111 (App.TriggerableAdapter.buildURL): Added.
1112 (App.BuildRequest.testGroup): Renamed from group.
1113 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
1114 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
1115 in this build request.
1116 (App.BuildRequest.status): Added.
1117 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
1118 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
1121 (App.AnalysisTaskController.testGroups): Added.
1122 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
1123 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
1124 but an observer that updates "roots" property. Filter out the repositories that are not accepted
1125 by the associated triggerable as they will be ignored.
1126 (App.AnalysisTaskController.actions.createTestGroup): Added.
1128 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
1130 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
1131 the status of those builds to the perf dashboard. A similar script can be written to support
1132 other continuous builds systems.
1133 (main): Fetches the list of pending builds as well as currently running or completed builds from
1134 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
1135 a single new build on each builder with no pending builds, and marks the set of open build requests
1136 that have been scheduled to run on the buildbot but not found in the first step as stale.
1137 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
1140 "platform": "mac-mavericks",
1141 "test": ["Parser", "html5-full-render.html"],
1142 "builder": "Trunk Syrah Production Perf AB Tests",
1144 "forcescheduler": "force-mac-mavericks-release-perf",
1145 "webkit_revision": "$WebKit",
1146 "jobid": "$buildRequest"
1151 (find_request_updates): Return a list of build request status updates to make based on the pending
1152 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
1153 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
1154 if the build request had not been completed. This is necessary because a failed build will not
1155 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
1156 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
1157 of open requests the perf dashboard has.
1158 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
1159 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
1160 or human canceling a build may trigger such a state.
1161 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
1162 replacing repository names with their revisions and buildRequest with the build request id.
1163 (config_for_request): Finds a builder for the test and the platform of a build request.
1164 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
1165 (property_value_from_build): Returns the value of a specific property in a buildbot build.
1166 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
1168 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1170 Cache-control should be set only on api/runs
1171 https://bugs.webkit.org/show_bug.cgi?id=140312
1173 Reviewed by Andreas Kling.
1175 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
1176 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
1177 just set cache-control there instead of json-header.php which is used by other JSON APIs.
1179 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
1181 * public/api/analysis-tasks.php:
1182 * public/api/runs.php: Set the cache control headers.
1183 * public/api/test-groups.php:
1184 * public/include/db.php: Set the default timezone to UTC.
1185 * public/include/json-header.php: Don't set the cache control headers.
1187 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1189 api/report-commit should authenticate with a slave name and password
1190 https://bugs.webkit.org/show_bug.cgi?id=140308
1192 Reviewed by Benjamin Poulain.
1194 Use a slave name and a password to authenticate new commit reports.
1196 * public/api/report-commits.php:
1198 * public/include/json-header.php:
1199 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
1200 a slave name and a password instead of a builder name and a password.
1201 * tests/api-report-commits.js: Updated tests.
1202 * tools/pull-svn.py:
1203 (main): Renamed variables.
1204 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
1206 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
1208 Perf dashboard should support authentication via a slave password
1209 https://bugs.webkit.org/show_bug.cgi?id=139837
1211 Reviewed by Andreas Kling.
1213 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
1214 having to add multiple builders with the same password when a single build slave is shared among them.
1216 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
1218 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
1220 * public/admin/build-slaves.php: Added.
1222 * public/admin/builders.php: Added the support for updating passwords.
1224 * public/include/admin-header.php:
1225 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
1226 being retrieved from $_POST.
1227 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
1228 the raw may not exist (e.g. new_password).
1229 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
1230 control here when this flag evaluates to TRUE.
1232 * public/include/report-processor.php:
1233 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
1234 values are present in the report. In addition, try authenticating builderName with slavePassword if
1235 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
1236 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
1237 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
1239 (ReportProcessor::store_report): Store the slave ID with the report.
1240 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
1241 the matching build is different from what's being reported.
1243 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
1246 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
1248 New perf dashboard should not duplicate author information in each commit
1249 https://bugs.webkit.org/show_bug.cgi?id=139756
1251 Reviewed by Darin Adler.
1253 Instead of each commit having author name and email, make it reference a newly added committers table.
1254 Also replace "email" by "account" since some repositories don't use emails as account names.
1256 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
1257 which only contains as many rows as there are accounts in each repository, instead of commits table
1258 which contains every commit ever happened in each repository.
1260 To migrate an existing database into match the new schema, run:
1264 INSERT INTO committers (committer_repository, committer_name, committer_email)
1265 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
1266 FROM commits WHERE commit_author_email IS NOT NULL);
1268 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
1270 UPDATE commits SET commit_committer = committer_id FROM committers
1271 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
1273 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
1274 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
1278 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
1279 reference to committers. Also added the missing drop table statements.
1281 * public/api/commits.php:
1282 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
1283 an array here instead of doing it in format_commit.
1284 (fetch_commits_between): Updated queries to JOIN commits with committers.
1285 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
1286 is now done in main.
1288 * public/api/report-commits.php:
1289 (main): Store the reported committer information or update the existing entry if there is one.
1291 * tests/admin-regenerate-manifest.js: Fixed tests.
1293 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
1295 * tools/pull-svn.py: Renamed email to account.
1297 (fetch_commit_and_resolve_author):
1299 (resolve_author_name_from_account):
1300 (resolve_author_name_from_email): Deleted.
1302 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
1304 Unreviewed build fix.
1306 * public/v2/index.html: Include js files we extracted in r177424.
1308 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1310 Unreviewed. Adding the forgotten svnprop.
1312 * tools/pull-svn.py: Added property svn:executable.
1314 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1316 Split InteractiveChartComponent and CommitsViewerComponent into separate files
1317 https://bugs.webkit.org/show_bug.cgi?id=139716
1319 Rubber-stamped by Benjamin Poulain.
1321 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
1322 and interactive-chart.js respectively since app.js has gotten really large.
1325 * public/v2/commits-viewer.js: Added.
1326 * public/v2/interactive-chart.js: Added.
1328 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
1330 New perf dashboard's chart UI is buggy
1331 https://bugs.webkit.org/show_bug.cgi?id=139214
1333 Reviewed by Chris Dumez.
1335 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
1337 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
1338 component. This is not how Ember.js components should interact to begin with. The component now exposes
1339 selectedPoints and always updates selection instead of sharedSelection.
1342 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
1343 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
1344 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
1345 and end time should be completely determined by "since" and the present time.
1346 (App.ChartsController._startTimeChanged): Ditto.
1347 (App.ChartsController._scheduleQueryStringUpdate):
1348 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
1350 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
1352 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
1353 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
1354 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
1355 observes the changes to selectedPoints property as it gets updated by the main chart.
1356 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
1357 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
1359 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
1360 when domain arrays aren't identical. This was causing a subtle race with other logic.
1361 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
1362 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
1363 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
1364 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
1365 see if those two points correspond to a range or a single data point. Rewrote all that logic by
1366 directly observing selectedPoints and currentItem properties instead of taking points and relying on
1367 an instance variable, which was a terrible API.
1368 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
1369 when the main plot has a selected range, we don't have to check this._hasRange anymore.
1371 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
1372 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
1373 (App.InteractiveChartComponent._updateSelection):
1374 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
1375 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
1376 selectedPoints property.
1378 (App.AnalysisTaskController._fetchedRuns):
1379 (App.AnalysisTaskController._rootChangedForTestSet):
1381 * public/v2/index.html:
1382 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
1384 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1386 Unreviewed. Fixed syntax errors.
1388 * init-database.sql:
1389 * public/api/commits.php:
1391 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1393 The dashboard on new perf monitor should be configurable
1394 https://bugs.webkit.org/show_bug.cgi?id=138994
1396 Reviewed by Benjamin Poulain.
1398 For now, make it configurable via config.json. We should eventually make it configurable via
1399 an administrative page but this will do for now.
1401 * config.json: Added the empty dashboard configuration.
1403 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1406 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1407 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1408 Also obtain the default configuration from App.Manifest.
1409 (App.IndexController._normalizeTable): Moved to App.Dashboard.
1411 * public/v2/manifest.js:
1412 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
1413 (App.Repository.urlForRevisionRange): Ditto.
1414 (App.Dashboard): Added.
1415 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
1416 (App.Dashboard.rows): Ditto.
1417 (App.Dashboard.headerColumns): Ditto.
1418 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
1419 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
1420 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
1421 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
1423 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1425 There should be a way to associate bugs with analysis tasks
1426 https://bugs.webkit.org/show_bug.cgi?id=138977
1428 Reviewed by Benjamin Poulain.
1430 Updated associate-bug.php to match the new database schema.
1432 * public/include/json-header.php:
1433 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
1434 already camel-cased in require_existence_of. This makes the function usable elsewhere.
1436 * public/privileged-api/associate-bug.php:
1437 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
1438 Also verify that those values are integers using require_format.
1440 * public/v2/analysis.js:
1441 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
1442 (App.Bug.label): Added.
1443 (App.BugAdapter): Added.
1444 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
1445 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
1447 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
1448 containing the bug information.
1451 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
1452 (App.AnalysisTaskRoute):
1453 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
1454 (App.AnalysisTaskController._fetchedManifest): Added.
1455 (App.AnalysisTaskController.actions.associateBug): Added.
1457 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
1459 * public/v2/data.js:
1460 (Measurement.prototype.associateBug): Deleted.
1462 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
1463 Added a table show the bug information. Also hide the chart until chartData is available.
1465 * public/v2/manifest.js:
1468 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1470 Fix misc bugs and typos in app.js
1471 https://bugs.webkit.org/show_bug.cgi?id=138946
1473 Reviewed by Benjamin Poulain.
1476 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1477 (App.ChartsController.init):
1478 (App.buildPopup): Renamed from App.BuildPopup.
1479 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1480 remove() on the wrong object (an array as opposed to elements in the array).
1481 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1482 _highlights is always an array and evalutes to true.
1484 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1486 New perf dashboard should provide UI to create a new analysis task
1487 https://bugs.webkit.org/show_bug.cgi?id=138910
1489 Reviewed by Benjamin Poulain.
1491 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1492 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1494 With this patch, we can create a new analysis task by selection a range of points and opening
1495 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1496 in the chart hyperlinked to the analysis task.
1498 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1500 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1501 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1503 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1504 and adds the associated bugs to each task in the array.
1507 * public/api/runs.php: Reverted changes made in r175006.
1508 (fetch_runs_for_config):
1511 * public/api/test-groups.php:
1512 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1514 * public/include/db.php:
1515 (Database::select_first_or_last_row):
1516 (Database::select_rows): Extracted from select_first_or_last_row.
1518 * public/v2/analysis.js:
1519 (App.AnalysisTask): Added "bugs" property.
1520 (App.Bug): Added now that bugs are regular data store objects.
1523 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1524 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1525 platform that are associated with a specific range of runs.
1526 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1527 (App.PaneController.actions.associateBug): Deleted.
1528 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1529 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1530 once we've created one.
1531 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1532 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1533 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1534 (App.PaneController._updateBugs): Deleted.
1535 (App.PaneController._updateMarkedPoints): Deleted.
1536 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1537 the name is missing or when at most one point is selected.
1539 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1540 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1541 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1542 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1543 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1544 clickable bars for analysis tasks.
1545 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1546 bar for analysis tasks to place them at the right location.
1547 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1549 * public/v2/chart-pane.css:
1550 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1551 (.chart .rangeBar): Added.
1553 * public/v2/data.js:
1554 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1556 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1557 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1558 task bars in the interactive chart component.
1560 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1562 Fix typos in r176203.
1565 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1566 (App.AnalysisTaskRoute):
1568 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1570 Unreviewed. Updated the install instruction.
1574 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1576 App.Manifest shouldn't use App.__container__.lookup
1577 https://bugs.webkit.org/show_bug.cgi?id=138768
1579 Reviewed by Andreas Kling.
1581 Removed the hack to find the store object via App.__container__.lookup.
1582 Pass around the store object instead.
1585 (App.DashboardRow._createPane): Add "store" property to the pane.
1586 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1587 (App.IndexController.gridChanged): Ditto.
1588 (App.IndexController.actions.addRow): Ditto.
1589 (App.IndexController.init): Ditto.
1590 (App.Pane._fetch): Ditto.
1591 (App.ChartsController._parsePaneList): Ditto.
1592 (App.ChartsController._updateQueryString): Ditto.
1593 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1594 (App.BuildPopup): Ditto.
1595 (App.AnalysisTaskRoute.model): Ditto.
1596 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1598 * public/v2/manifest.js:
1599 (App.Manifest.fetch): Removed the code to find the store object.
1601 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1603 Fix Ember.js warnings the new perf dashboard
1604 https://bugs.webkit.org/show_bug.cgi?id=138531
1606 Reviewed by Darin Adler.
1608 Fixed various warnings.
1611 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1612 * public/v2/data.js:
1613 (PrivilegedAPI._post): Removed the superfluous console.log.
1614 (CommitLogs.fetchForTimeRange): Ditto.
1615 * public/v2/index.html: Added tbody as required by the HTML specification.
1617 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1619 Fix typos in r175768.
1622 (App.AnalysisTaskViewModel.roots):
1624 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1626 Introduce the concept of analysis task to perf dashboard
1627 https://bugs.webkit.org/show_bug.cgi?id=138517
1629 Reviewed by Andreas Kling.
1631 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1632 a single platform and used to bisect regressions in the range.
1634 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1636 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1637 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1638 test runs. Analysis tasks not associated with test runs are used for try new patches.
1639 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1640 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1641 build_requests - A build request represents a single pending build for A/B testing.
1643 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1647 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1648 the specified analysis task group as well as build requests associated with them.
1650 (fetch_test_groups_for_task):
1651 (fetch_build_requests_for_task):
1652 (fetch_build_requests_for_group):
1653 (format_test_group):
1654 (format_build_request):
1656 * public/include/json-header.php:
1657 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1660 * public/privileged-api/associate-bug.php:
1661 (main): Fixed a typo.
1663 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1666 (ensure_config_from_runs):
1668 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1670 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1672 (App.AnalysisTask.create):
1674 (App.TestGroupAdapter):
1675 (App.AnalysisTaskSerializer):
1676 (App.TestGroupSerializer):
1679 * public/v2/app.css: Added style rules for the analysis page.
1682 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1684 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1685 exactly one selected point as we can still create an analysis task.
1686 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1687 grammatical and also alert'ed the error message when there is one.
1688 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1689 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1690 once XHR request has completed.
1691 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1692 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1693 is selected in the details pane.
1695 (App.AnalysisRoute): Added.
1696 (App.AnalysisTaskRoute): Added.
1697 (App.AnalysisTaskViewModel): Added.
1698 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1699 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1700 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1701 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1702 the user selects an option for all roots in A or B configuration.
1703 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1705 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1707 * public/v2/data.js:
1708 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1709 point so that we can use it in App.AnalysisTaskViewModel.roots.
1710 (TimeSeries.prototype.findPointByMeasurementId): Added.
1711 (TimeSeries.prototype.seriesBetweenPoints): Added.
1713 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1714 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1715 when multiple points are selected. Finally, added a new template for the analysis task page.
1717 * public/v2/manifest.js:
1718 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1719 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1720 App.AnalysisTaskViewModel._taskUpdated.
1722 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1724 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1725 https://bugs.webkit.org/show_bug.cgi?id=138111
1727 Reviewed by Darin Adler.
1730 (App.PaneController.bugsChangeCount): Removed.
1731 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1732 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1733 Finds the list of current run's points that are associated with bugs.
1734 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1735 * public/v2/chart-pane.css:
1736 (.chart .marked): Renamed from .hasBugs.
1737 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1739 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1741 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1742 https://bugs.webkit.org/show_bug.cgi?id=138099
1744 Reviewed by Benjamin Poulain.
1746 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1747 _showDetails inverting the order of the current and old measurements.
1750 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1751 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1752 current (latest) measurement and the first point is the oldest measurement.
1753 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1755 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1757 Perf dashboard should provide a way to associate bugs with a test run
1758 https://bugs.webkit.org/show_bug.cgi?id=137857
1760 Reviewed by Andreas Kling.
1762 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1763 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1764 the Apache configuration.
1767 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1768 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1769 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1770 via the cookie and returns a token computed from those two values as well as the remote username.
1772 The font end code then POST's the request along with the returned token. The server side code verifies
1773 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1774 the token hasn't expired.
1777 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1778 have zero or exactly one bug associated with a test run.
1780 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1781 * public/api/runs.php:
1782 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1783 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1784 an associated bug if there is one.
1785 (format_run): Calls parse_bugs_array.
1787 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1788 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1789 have a valid JSON payload.
1790 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1791 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1792 the expiration time stored in the cookie.
1793 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1795 * public/include/manifest.php:
1796 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1797 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1799 * public/index.html:
1800 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1802 * public/privileged-api/associate-bug.php: Added.
1803 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1804 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1806 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1808 * public/v2/app.css:
1809 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1810 selected in a chart.
1813 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1814 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1815 they would overlap on each other if both of them are shown.
1816 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1817 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1818 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1819 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1820 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1821 showing the search pane.
1822 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1823 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1824 bugs in the selected range.
1826 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1827 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1828 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1829 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1830 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1831 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1832 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1833 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1835 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1836 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1837 to selectionChanged action instead of just finding the first and the last points.
1839 * public/v2/chart-pane.css: Updated the style.
1841 * public/v2/data.js:
1842 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1843 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1844 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1845 we haven't already obtained a CSRF token or if the token has already been expired.
1846 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1848 (Measurement.prototype.bugs): Added.
1849 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1850 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1852 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1855 * public/v2/manifest.js:
1856 (App.BugTracker.bugUrl):
1857 (App.BugTracker.newBugUrl): Added.
1858 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1859 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1860 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1861 (App.Manifest.bugTrackers): Added.
1862 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1863 their respective ids to make the ordering stable.
1865 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1867 Remove unused jobs table
1868 https://bugs.webkit.org/show_bug.cgi?id=137724
1870 Reviewed by Daniel Bates.
1872 Removed jobs table in the database as well as related code.
1874 * init-database.sql:
1875 * public/admin/jobs.php: Removed.
1876 * public/admin/tests.php:
1877 * public/include/admin-header.php:
1879 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1881 New perf dashboard should have an ability to search commits by a keyword
1882 https://bugs.webkit.org/show_bug.cgi?id=137675
1884 Reviewed by Geoffrey Garen.
1886 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1887 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1888 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1890 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1891 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1893 * public/api/commits.php:
1894 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1895 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1896 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1897 (format_commit): Renamed from format_commits. Now only formats one commit.
1899 * public/include/db.php:
1900 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1902 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1905 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1906 which is a hash table that contains highlighted items' measurements' ids as keys.
1907 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1908 the default commit repository.
1909 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1910 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1911 Added the code to initialize this._highlights.
1912 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1913 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1914 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1915 the existing lines for the old highlighted items.
1916 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1917 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1919 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1921 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1922 (CommitLogs): Added.
1923 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1924 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1925 (CommitLogs._cacheConsecutiveCommits): Ditto.
1926 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1927 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1928 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1930 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1931 for showingDetails since this property is no longer used.
1933 * public/v2/manifest.js:
1934 (App.Manifest.repositories): Added.
1935 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1936 the default repository to search.
1937 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1939 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1941 Unreviewed build fix after r174555.
1943 * public/include/manifest.php:
1944 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1945 * tests/admin-regenerate-manifest.js: Fixed the test case.
1947 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1949 New perf dashboard UI tries to fetch commits all the time
1950 https://bugs.webkit.org/show_bug.cgi?id=137592
1952 Reviewed by Andreas Kling.
1954 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1955 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1956 no reported commits as they are all going to fail.
1958 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1959 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1960 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1961 of commits sorted chronologically by time.
1963 * public/include/manifest.php:
1966 (App.CommitsViewerComponent.commitsChanged):
1968 * public/v2/data.js:
1969 (FetchCommitsForTimeRange):
1970 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1972 * public/v2/manifest.js:
1975 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1977 Another unreviewed build fix after r174477.
1979 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1981 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1983 * public/include/report-processor.php:
1985 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1987 Unreviewed build fix after r174477.
1989 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1990 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1992 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1993 This is necessary for baseline and target values manually added via admin pages.
1995 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1997 Add v2 UI for the perf dashboard
1998 https://bugs.webkit.org/show_bug.cgi?id=137537
2000 Rubber-stamped by Andreas Kling.
2003 * public/v2/app.css: Added.
2004 * public/v2/app.js: Added.
2005 * public/v2/chart-pane.css: Added.
2006 * public/v2/data.js: Added.
2007 * public/v2/index.html: Added.
2008 * public/v2/js: Added.
2009 * public/v2/js/d3: Added.
2010 * public/v2/js/d3/LICENSE: Added.
2011 * public/v2/js/d3/d3.js: Added.
2012 * public/v2/js/d3/d3.min.js: Added.
2013 * public/v2/js/ember-data.js: Added.
2014 * public/v2/js/ember.js: Added.
2015 * public/v2/js/handlebars.js: Added.
2016 * public/v2/js/jquery.min.js: Added.
2017 * public/v2/js/statistics.js: Added.
2018 * public/v2/manifest.js: Added.
2019 * public/v2/popup.js: Added.
2021 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2023 Remove superfluously duplicated code in public/api/report-commits.php.
2025 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2027 Perf dashboard should store commit logs
2028 https://bugs.webkit.org/show_bug.cgi?id=137510
2030 Reviewed by Darin Adler.
2032 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
2034 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
2035 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
2036 a subversion directory. The git version of this script will be added in a follow up patch.
2039 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
2040 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
2041 relationship via "build_commits" relations.
2043 In order to migrate an existing instance of this application, run the following SQL commands:
2047 INSERT INTO commits (commit_repository, commit_revision, commit_time)
2048 (SELECT DISTINCT ON (revision_repository, revision_value)
2049 revision_repository, revision_value, revision_time FROM build_revisions);
2051 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
2052 FROM commits, build_revisions
2053 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
2055 DROP TABLE build_revisions;
2060 The helper script to submit commit logs can be used as follows:
2062 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
2063 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
2065 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
2066 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
2067 "feeder-slave-password" as the builder name and the builder password respectively.
2069 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
2070 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
2073 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
2075 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
2076 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
2078 - Not specified - It returns every single commit for a given repository.
2079 - Matches "oldest" - It returns the commit with the oldest timestamp.
2080 - Matches "latest" - It returns the commit with the latest timestamp.
2081 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
2082 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
2083 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
2084 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
2085 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
2086 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
2088 (commit_from_revision):
2089 (fetch_commits_between):
2092 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
2093 See tests/api-report-commits.js for examples on how to use this API.
2095 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
2096 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
2097 to optimize this and other JSON APIs.
2099 * public/include/db.php:
2100 (Database::select_or_insert_row):
2101 (Database::update_or_insert_row): Added.
2102 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
2103 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
2105 (Database::select_first_row):
2106 (Database::select_last_row): Added.
2107 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
2108 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
2110 * public/include/report-processor.php:
2111 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
2112 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
2113 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
2116 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
2118 * tests/api-report-commits.js: Added.
2119 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
2122 * tools/pull-svn.py: Added. See above for how to use this script.
2124 (determine_first_revision_to_fetch):
2125 (fetch_revision_from_dasbhoard):
2126 (fetch_commit_and_resolve_author):
2129 (resolve_author_name_from_email):
2132 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
2134 Update Install.md for Mavericks and fix typos
2135 https://bugs.webkit.org/show_bug.cgi?id=137276
2137 Reviewed by Benjamin Poulain.
2139 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
2141 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
2143 Finally, init-database.sql is no longer located inside database directory.
2147 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2149 Report run id's in api/runs.php for the new dashboard UI
2150 https://bugs.webkit.org/show_bug.cgi?id=135813
2152 Reviewed by Andreas Kling.
2154 Include run_id in the generated JSON.
2156 * public/api/runs.php:
2157 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
2160 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2162 Merging platforms mixes baselines and targets into reported data
2163 https://bugs.webkit.org/show_bug.cgi?id=135260
2165 Reviewed by Andreas Kling.
2167 When merging two platforms, move test configurations of a different type (baseline, target)
2168 as well as of different metric (Time, Runs).
2170 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
2171 It's sufficient to detect one such test_runs object.
2173 * public/admin/platforms.php:
2176 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
2178 Merging platforms mixes baselines and targets into reported data
2179 https://bugs.webkit.org/show_bug.cgi?id=135260
2181 Reviewed by Geoffrey Garen.
2183 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
2184 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
2186 * public/admin/platforms.php:
2188 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
2190 Build fix after r171361.
2192 * public/js/helper-classes.js:
2193 (.this.formattedBuildTime):
2195 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
2197 Perf dashboard spends 2s processing JSON data during the page loads
2198 https://bugs.webkit.org/show_bug.cgi?id=135152
2200 Reviewed by Andreas Kling.
2202 In the Apple internal dashboard, we were spending as much as 2 seconds
2203 converting raw JSON data into proper JS objects while loading the dashboard.
2205 This caused the apparent unresponsiveness of the dashboard despite of the fact
2206 charts themselves updated almost instantaneously.
2208 * public/index.html:
2209 * public/js/helper-classes.js:
2210 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
2211 lazily as creating new Date objects and running string replace is expensive.
2212 (TestBuild.formattedTime):
2213 (TestBuild.formattedBuildTime):
2214 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
2215 (PerfTestRuns.addResult): Deleted.
2217 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
2219 Perf dashboard shouldn't show the full git hash
2220 https://bugs.webkit.org/show_bug.cgi?id=135083
2222 Reviewed by Benjamin Poulain.
2224 Detect Git/Mercurial hash by checking the length.
2226 If it's a hash, use the first 8 characters in the label
2227 while retaining the full length to be used in hyperlinks.
2229 * public/js/helper-classes.js:
2230 (.this.formattedRevisions):
2233 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
2235 Add an instruction on how to backup the database.
2236 https://bugs.webkit.org/show_bug.cgi?id=133391
2238 Rubber-stamped by Andreas Kling.
2242 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2244 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
2246 * public/js/helper-classes.js:
2247 (PerfTestRuns.smallerIsBetter):
2249 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2253 * public/common.css:
2255 * public/index.html:
2259 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2261 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
2262 https://bugs.webkit.org/show_bug.cgi?id=131157
2264 Reviewed by Andreas Kling.
2266 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
2267 This allows, for example, adding all metrics such as Arithmetic and Geometric for
2268 a given test suite without also adding its subtests.
2270 * public/index.html:
2274 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2276 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
2277 https://bugs.webkit.org/show_bug.cgi?id=131155
2279 Reviewed by Andreas Kling.
2281 The bug was caused by Chart.attach binding event listeners on plot container on each call.
2282 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
2283 click when attach() has been called even number of times, keeping the tooltip invisible.
2285 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
2286 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
2287 is called for the first time.
2289 * public/index.html:
2291 (Chart..bindPlotEventHandlers):
2293 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2295 WebKitPerfMonitor: Tooltips can be cut off at the top
2296 https://bugs.webkit.org/show_bug.cgi?id=130960
2298 Reviewed by Andreas Kling.
2300 * public/common.css:
2301 (#title): Removed the gradients, box shadows, and border from the header.
2302 (#title h1): Reduce the font size.
2303 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
2304 * public/index.html:
2305 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
2306 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
2307 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
2308 * public/js/helper-classes.js:
2309 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
2310 tooltip extending above y=0.
2312 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2314 WebKitPerfMonitor: Y-axis adjustment is too aggressive
2315 https://bugs.webkit.org/show_bug.cgi?id=130937
2317 Reviewed by Andreas Kling.
2319 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
2320 results. This had two major problems:
2321 1. Two standard deviations can be too small to show the confidence interval for results.
2322 2. Sometimes baseline and target can be more than two standards deviations away.
2324 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
2325 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
2326 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
2327 the margin on each side separately to reduce the empty space on either side.
2329 A more rigorous approach would involve computing least squared value of results with respect to intervals
2330 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
2332 * public/index.html:
2333 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
2334 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
2335 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
2336 We wouldn't see the difference between measured values versus baseline and target values otherwise.
2337 * public/js/helper-classes.js:
2338 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
2339 interval delta cannot be computed.
2340 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
2341 within the given interval.
2342 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
2343 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
2344 (PerfTestRuns..unscaledMeansForAllResults):
2345 (PerfTestRuns.min): Take the confidence interval delta into account.
2346 (PerfTestRuns.max): Ditto.
2347 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
2348 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
2350 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
2352 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
2354 Some CSS tweaks after r166477 and r166479,
2356 * public/index.html:
2358 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2360 WebKitPerfMonitor: Sometimes text inside panes overlap
2361 https://bugs.webkit.org/show_bug.cgi?id=130956
2363 Reviewed by Gyuyoung Kim.
2365 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
2366 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
2367 reduces the total height of the pane and fits more information per screen capita on the dashboard.
2369 * public/index.html: Updated and added a bunch of CSS rules for the new look.
2370 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
2371 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
2372 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
2373 of the build info shown in a chart pane and a tooltip.
2374 (Chart): Made .status a table.
2375 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
2376 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
2377 now that status.text no longer contains it.
2378 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
2380 * public/js/helper-classes.js:
2381 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
2382 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
2383 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
2384 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
2385 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
2386 capital letter; e.g. "MB" instead of "M B".
2388 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2390 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
2391 https://bugs.webkit.org/show_bug.cgi?id=130957
2393 Reviewed by Gyuyoung Kim.
2395 Moved the slider into the header. Also reduced the spacing between the header and platform names.
2396 This reclaims 50px Ă— width of the screen real estate.
2398 * public/common.css:
2399 (#title): Reduced the space below the header from 20px to 10px.
2400 * public/index.html:
2401 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
2402 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
2403 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
2404 real estate between the header and the platform names.
2406 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2408 Update the install guidelines for perf.webkit.org
2409 https://bugs.webkit.org/show_bug.cgi?id=129895
2411 Reviewed by Ryosuke Niwa.
2413 The current install guideline for perf.webkit.org discourages the use of the installed
2414 Server application. I've actualized the documentation for Mavericks, and modified the
2415 guideline to include the instructions for Server.app also.
2419 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
2421 Update perf.webkit.org json example
2422 https://bugs.webkit.org/show_bug.cgi?id=129907
2424 Reviewed by Andreas Kling.
2426 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
2430 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
2432 Merge database-common.js and utility.js into run-tests.js.
2434 Reviewed by Matthew Hanson.
2436 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
2437 Also moved init-database.sql out of the database directory and removed the directory entirely.
2439 * database: Removed.
2440 * database/database-common.js: Removed.
2441 * database/utility.js: Removed.
2442 * init-database.sql: Moved from database/init-database.sql.
2444 (connect): Moved from database-common.js.
2445 (pathToDatabseSQL): Extracted from pathToLocalScript.
2446 (pathToTests): Moved from database-common.js.
2449 (SerializedTaskQueue): Ditto.
2451 (initializeDatabase):
2452 (TestEnvironment.it):
2453 (TestEnvironment.queryAndFetchAll):
2456 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2458 Remove the dependency on node.js from the production code.
2460 Reviewed by Ricky Mondello.
2462 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
2464 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
2465 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
2466 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
2467 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
2468 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
2470 Also removed the js files that are no longer used.
2472 * config.json: Moved from database/config.json.
2473 * database/aggregate.js: Removed. No longer used.
2474 * database/database-common.js: Removed unused functions, and updated the path to config.json.
2475 * database/process-jobs.js: Removed. No longer used.
2476 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2477 * database/schema.graffle: Removed. It's completely obsolete.
2478 * public/include/db.php: Updated the path to config.json.
2479 * public/include/evaluator.js: Removed.
2481 * public/include/report-processor.php:
2482 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2483 storing values into $expressions and calling evaluate_expressions_by_node.
2484 (TestRunsGenerator::aggregate_values): Added.
2485 (TestRunsGenerator::compute_caches): Directly compute the caches.
2487 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2489 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2491 * public/admin/platforms.php:
2492 * public/include/db.php:
2494 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2496 Zoomed y-axis view is ununsable when the last result is an outlier.
2498 Reviewed by Stephanie Lewis.
2500 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2501 the last result so that the graph looks sane if the last result was an outlier. However, always show
2502 the last result's mean even if it was an outlier.
2504 * public/index.html:
2505 * public/js/helper-classes.js:
2506 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2507 Also added the ability to cache the unscaled means to avoid recomputation.
2508 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2509 (PerfTestRuns.max): Ditto.
2510 (PerfTestRuns.sampleStandardDeviation): Ditto.
2511 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2513 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2517 * public/admin/tests.php:
2518 * public/js/helper-classes.js:
2520 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2522 Use two standard deviations instead as I mentioned in the mailing list.
2524 * public/index.html:
2526 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2528 The performance dashboard erroneously shows upward arrow for combined metrics.
2530 A single outlier can ruin the zoomed y-axis view.
2532 Rubber-stamped by Antti Koivisto.
2534 * public/index.html:
2535 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2536 from the latest results' mean.
2537 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2538 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2539 (Chart.toggleYAxis):
2540 * public/js/helper-classes.js:
2541 (PerfTestRuns.sampleStandardDeviation): Added.
2542 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2544 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2546 Don't include the confidence interval when computing the y-axis.
2548 Rubber-stamped by Simon Fraser.
2550 * public/js/helper-classes.js:
2554 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2556 Tiny CSS tweak for tooltips.
2558 * public/index.html:
2560 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2562 Remove the erroneously repeated code.
2564 * public/admin/test-configurations.php:
2566 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2568 <rdar://problem/15704893> perf dashboard should show baseline numbers
2570 Reviewed by Stephanie Lewis.
2572 * public/admin/bug-trackers.php:
2573 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2576 * public/admin/platforms.php:
2577 (merge_list): Ditto.
2579 * public/admin/test-configurations.php: Added.
2580 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2581 build_revisions as they're not meaningful for baseline / target numbers.
2582 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2583 one test run so that we don't accidentally delete a reported test run.
2584 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2585 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2586 and delete existing ones.
2588 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2589 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2590 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2592 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2593 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2594 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2595 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2596 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2598 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2600 * public/include/admin-header.php:
2601 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2602 have id and type sub columns, and each custom column could generate multiple rows.
2604 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2605 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2606 We then proceed to generate the second header row with sub column names.
2608 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2609 which case regular columns need rowspan set to the maximum number of rows.
2611 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2614 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2615 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2616 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2617 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2618 expanded to occupy all sub columns.
2620 * public/include/manifest.php:
2621 (ManifestGenerator::platforms): Don't add the metric more than once.
2623 * public/include/test-name-resolver.php:
2624 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2625 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2626 full metric name later.
2627 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2628 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2629 (TestNameResolver::full_name_for_test): Added.
2630 (TestNameResolver::full_name_for_metric): Added.
2631 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2633 * public/js/helper-classes.js:
2634 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2635 test runs created to set baseline and target points.
2637 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2639 Build fix after r57928. Removed a superfluous close parenthesis.
2641 * public/api/runs.php:
2643 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2645 Unreviewed build & typo fixes.
2647 * public/admin/platforms.php:
2648 * tests/admin-platforms.js:
2650 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2652 <rdar://problem/15704893> perf dashboard should show baseline numbers
2654 Rubber-stamped by Antti Koivisto.
2656 Organize some code into functions in runs.php.
2658 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2660 * public/api/runs.php:
2661 (fetch_runs_for_config): Extracted.
2662 (format_run): Ditto.
2664 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2666 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2668 * database/config.json:
2669 * public/admin/reprocess-report.php:
2670 * public/api/report.php:
2671 * public/api/runs.php:
2672 * public/include/json-header.php:
2674 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2676 Commit yet another forgotten change.
2678 Something went horribly wrong with my merge :(
2680 * database/init-database.sql:
2682 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2684 Commit one more forgotten change. Sorry for making a mess here.
2686 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2688 Commit the forgotten files.
2690 * public/admin/platforms.php: Added.
2691 * tests/admin-platforms.js: Added.
2693 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2695 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2697 Reviewed by Stephanie Lewis.
2699 Added /admin/platforms/ page to hide and merge platforms.
2701 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2702 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2703 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2704 each test configuration a distinct "test run" for each build.
2706 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2707 their test configurations into platform B.
2709 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2710 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2711 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2712 in platform B, in which case R should relate to T_B instead.
2714 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2715 new platform. We then migrate the test configurations of the remaining test runs.
2717 * database/init-database.sql: Added platform_hidden.
2719 * public/admin/platforms.php: Added.
2720 (merge_platforms): Added. Implements the algorithm described above.
2721 (merge_list): Added.
2723 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2724 is hidden since it doesn't do anything.
2726 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2727 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2728 missing it since unchecked checkbox doesn't set the value in $_POST.
2729 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2730 switch statement instead of repeated if's.
2731 (AdministrativePage::render_table): Emit "update-column" for update_field.
2733 * public/include/db.php: Disable warnings when we're not in the debug mode.
2735 * public/include/manifest.php:
2736 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2739 (TestEnvironment.postJSON):
2740 (TestEnvironment.httpGet):
2741 (TestEnvironment.httpPost): Added.
2742 (sendHttpRequest): Set the content type if specified.
2744 * tests/admin-platforms.js: Added tests.
2746 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2748 Extract the code to compute full test names from tests.php.
2750 Reviewed by Stephanie Lewis.
2752 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2753 and paves our way to re-use the code in other pages.
2755 * public/admin/tests.php:
2757 * public/include/db.php:
2758 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2759 tests.php and test-name-resolver.php.
2761 * public/include/test-name-resolver.php: Added.
2762 (TestNameResolver::__construct):
2763 (TestNameResolver::compute_full_name): Moved from tests.php.
2764 (TestNameResolver::map_metrics_to_tests): Ditto.
2765 (TestNameResolver::sort_tests_by_full_name): Ditto.
2766 (TestNameResolver::tests): Added.
2767 (TestNameResolver::test_id_for_full_name): Ditto.
2768 (TestNameResolver::metrics_for_test_id): Ditto.
2769 (TestNameResolver::child_metrics_for_test_id): Ditto.
2770 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2772 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2774 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2776 Reviewed by Stephanie Lewis.
2778 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2780 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2781 but that's sufficient to correct the wrongfully processed reports for now.
2783 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2784 We should eventually add a nice UI to find and reprocess reports.
2786 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2788 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2790 * public/include/report-processor.php: Copied from public/api/report.php.
2791 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2792 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2793 create a new report or authenticate the builder password (the password is never stored in the report).
2794 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2795 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2796 (ReportProcessor::store_report): Ditto.
2798 * tests/admin-reprocess-report.js: Added.
2800 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2802 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2804 Reviewed by Ricky Mondello.
2806 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2807 for the same build number as a single build by ignoring build time. This was necessary to associate
2808 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2809 we use to submit results computed its own "build time" when they're called.
2811 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2812 last week; new reports were wrongfully associated with old build numbers.
2814 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2815 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2816 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2818 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2819 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2820 (builder, build number, build time).
2822 * public/api/report.php:
2823 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2824 when no such build exists. This prevents a report from being associated with a very old build of the same
2827 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2828 a similar bug in the future sooner.
2830 * tests/api-report.js: Added three test cases.
2832 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2834 Merged the upstream changes to db.php
2835 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2837 * public/include/db.php:
2839 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2841 Update other scripts and tests per previous patch.
2843 * public/include/manifest.php:
2844 * tests/admin-regenerate-manifest.js:
2846 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2848 Remove metrics_unit.
2850 Reviewed by Ricky Mondello.
2852 This column is no longer used by the front-end code since r48360.
2854 * database/init-database.sql:
2855 * public/admin/tests.php:
2857 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2859 Unreviewed build fix.
2861 * public/api/report.php:
2863 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2865 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2867 Reviewed by Ricky Mondello.
2869 Support a new alternative format for aggregated results where we have raw values as well as
2870 the list aggregators so that instead of
2871 "metrics": {"Time": ["Arithmetic"]}
2873 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2875 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2876 dashboard and the generated results page, which doesn't know how to aggregate values.
2878 We need to keep the support for the old format because all other existing performance tests
2879 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2880 the old format during the transition.
2882 * public/api/report.php:
2883 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2884 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2886 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2888 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2890 Unreviewed; Tweak the CSS so that chart panes align vertically.
2892 * public/index.html:
2894 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2896 SafariPerfMonitor should support Combined metric.
2898 * public/js/helper-classes.js:
2899 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2900 value as well but assume it to be greater-is-better for now.
2902 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2904 Commit the forgotten init-database change to add iteration_relative_time.
2906 * database/init-database.sql:
2908 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2910 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2912 Reviewed by Ricky Mondello.
2914 Add the support for each value to have a relative time. This is necessary for frame rate history
2915 since a frame rate needs to be associated with a time it was sampled.
2917 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2919 * public/api/report.php:
2920 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2921 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2922 with relative time since taking the average of two frame rates for two subtests taken at two
2923 different times doesn't make any sense.
2924 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2925 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2926 Also exit early with an error if the number of elements in the array is not a pair.
2927 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2929 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2930 iteration_relative_time.
2932 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2934 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2936 Reviewed by Ricky Mondello.
2938 Support that. It's one line change.
2940 * public/api/report.php:
2941 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2942 to match the convention assumed elsewhere.
2943 * tests/api-report.js: Added a test case.
2945 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2947 SafariPerfMonitor shows popups for points outside of the visible region.
2949 Rubber-stamped by Simon Fraser.
2951 * public/index.html:
2952 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2953 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2954 may return an item underneath y-axis labels.
2956 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2958 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2960 * public/index.html:
2962 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2964 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2966 * public/index.html:
2968 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2970 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2971 <rdar://problem/13992271> Should scale Y axis to include error ranges
2973 Reviewed by Ricky Mondello.
2975 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2976 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2978 * database/config.json:
2979 * public/index.html:
2980 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2981 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2982 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2984 * public/js/helper-classes.js:
2985 (PerfTestResult.confidenceIntervalDelta):
2986 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2987 (PerfTestRuns.min): Take confidence interval delta into account.
2988 (PerfTestRuns.max): Ditto.
2989 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2991 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2993 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2995 * public/api/report.php:
2996 (ReportProcessor::recursively_ensure_tests):
2997 * tests/api-report.js: Added a test.
2999 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
3001 Unreviewed build fixes.
3003 * public/api/report.php:
3004 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
3005 Also, tolerate reports without any revision information.
3007 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
3010 * tests/api-report.js: Added few test cases.
3012 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
3014 Commit another change that was supposed to be committed in r50331.
3017 (TestEnvironment.this.postJSON):
3018 (TestEnvironment.this.httpGet):
3021 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
3023 Commit the remaining files.
3025 * public/admin/regenerate-manifest.php:
3026 * public/include/admin-header.php:
3027 * public/include/json-header.php:
3028 * public/include/manifest.php:
3030 (TestEnvironment.this.postJSON):
3031 (TestEnvironment.this.httpGet):
3034 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
3036 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
3038 Reviewed by Ricky Mondello.
3040 Added some tests for admin/regenerate-manifest.
3042 * public/admin/regenerate-manifest.php: Use require_once instead of require.
3043 * public/include/admin-header.php: Ditto.
3044 * public/include/json-header.php: Ditto.
3046 * public/include/manifest.php:
3047 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
3048 When there are no builders, simply return an empty array.
3051 (TestEnvironment.postJSON):
3052 (TestEnvironment.httpGet): Added.
3053 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
3055 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
3057 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
3059 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
3060 and run_iterations. Also fixed a typo in report.php found by new tests.
3062 * public/api/report.php:
3063 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
3064 * tests/api-report.js: Added more test cases.
3066 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
3068 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
3070 Reviewed by Ricky Mondello.
3072 Add a test runner script and some simple test cases.
3074 * database/config.json: Added the configuration for "testServer".
3075 * database/database-common.js:
3076 (pathToTests): Added.
3077 * run-tests.js: Added.
3080 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
3081 and if there are, asks the user if it’s okay to delete all of the data contained therein.
3082 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
3084 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
3085 in the current database using PostgreSQL's information_schema.
3086 (askYesOrNoQuestion):
3088 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
3090 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
3091 (TestEnvironment.assert): Exposes assert to tests.
3092 (TestEnvironment.console): Exposes console to tests.
3093 (TestEnvironment.describe): Adds a description.
3094 (TestEnvironment.it): Adds a test case.
3095 (TestEnvironment.postJSON):
3096 (TestEnvironment.queryAndFetchAll):
3097 (TestEnvironment.sha256):
3098 (TestEnvironment.notifyDone): Ends the current test case.
3102 (TestContext): An object created for each test case. Conceptually, this object is always on
3103 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
3104 this object via currentTestContext.
3105 (TestContext.description):
3107 (TestContext.logError):
3110 * tests/api-report.js: Added some basic tests for /api/report.php.
3112 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3114 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
3116 The problem was that we were detecting whether we're updating dashboard or not by checking
3117 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
3118 all configurations. Use separate 'dashboard' action to execute the code even when
3119 metric_configurations is empty.
3121 * public/admin/tests.php:
3123 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3125 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
3127 Reviewed by Ricky Mondello.
3129 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
3130 from ReportProcessor as a preparation to replace deprecated aggregate.js.
3132 * public/api/report.php:
3133 (ReportProcessor::exit_with_error): Moved.
3134 (ReportProcessor::process): Use the extracted TestRunsGenerator.
3135 (TestRunsGenerator): Added.
3136 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
3137 (TestRunsGenerator::add_aggregated_metric): Moved.
3138 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
3139 (TestRunsGenerator::aggregate): Moved. Made public.
3140 (TestRunsGenerator::aggregate_current_test_level): Moved.
3141 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
3142 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
3143 (TestRunsGenerator::compute_caches): Moved. Made public.
3144 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
3145 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
3146 (TestRunsGenerator::rollback_with_error): Moved.
3148 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3150 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
3152 Reviewed by Remy Demarest.
3154 Regenerate the manifest file when updating fields or adding new items that are included in
3157 * public/admin/bug-trackers.php:
3158 * public/admin/builders.php:
3159 * public/admin/regenerate-manifest.php:
3160 * public/admin/repositories.php:
3161 * public/admin/tests.php:
3162 * public/include/admin-header.php:
3163 (regenerate_manifest): Extracted from regenerate-manifest.php.
3165 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3167 Unreviewed build fix for memory test results.
3169 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
3170 aggregating at each level.
3172 * public/api/report.php:
3173 (ReportProcessor::recursively_ensure_tests):
3174 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
3175 (ReportProcessor::add_values_for_aggregation):
3176 (ReportProcessor::aggregate):
3177 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
3179 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
3181 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
3182 not the number of iteration groups. Also, don't set group number when the entire run belongs
3183 a single iteration group.
3185 * public/api/report.php:
3186 (ReportProcessor::commit):
3188 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3190 SafariPerfMonitor: Introduce iteration groups
3192 Reviewed by Remy