1 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
3 Build fix after r184591.
5 * public/v2/manifest.js:
7 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
9 Build fix. Use POSIX timestamp instead of human readable string for the commit time.
11 * public/include/build-requests-fetcher.php:
13 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
15 UI to associate bugs with an analysis task is crappy
16 https://bugs.webkit.org/show_bug.cgi?id=145198
18 Reviewed by Andreas Kling.
20 Make the UI less crappy by linkifying bug numbers and adding an explicit button to disassociate
21 a bug and a separate select view with a text field to associate a new bug instead of implicitly
22 updating or deleting the existing record based on what the user had typed.
24 * init-database.sql: Removed the constraint that each bug tracker should appear exactly once for
25 a given analysis task since it's perfectly reasonable for a given task to be associated with
28 * public/privileged-api/associate-bug.php:
29 (main): Only remove the bug specified by newly added bugToDelete instead of implicitly deleting
30 one that matches the analysis task and the bug tracker when the bug number is falsey.
32 * public/v2/analysis.js:
34 (App.BugAdapter.deleteRecord): Added. Uses the privileged API to delete the record.
39 (App.AnalysisTaskController.actions.addBug): Added.
40 (App.AnalysisTaskController.actions.deleteBug): Added.
41 (App.AnalysisTaskController.associateBug): Deleted.
43 * public/v2/index.html: Updated the templates.
45 * public/v2/manifest.js:
46 (App.BugTracker.urlFromBugNumber): Added.
48 2015-05-20 Ryosuke Niwa <rniwa@webkit.org>
50 A/B testing rootSets should provide commit times as well as revisions
51 https://bugs.webkit.org/show_bug.cgi?id=145207
53 Reviewed by Andreas Kling.
55 Some continuous build systems need the commit time as well as the revision number / hash so provide one
56 in the root sets but maintain the backwards compatibility with buildbots that use revision number directly.
58 * public/include/build-requests-fetcher.php:
59 (BuildRequestsFetcher::fetch_roots_for_set): Made the revision info an associative array that contains
60 the revision number as well as the commit time.
61 * tools/sync-with-buildbot.py:
62 (schedule_request): Removed "replacement" which was a superfluous copy of "roots". Use "revision" values
63 when the JSON configuration refers to "root". This is necessary in buildbot instances that require WebKit
64 revision to be specified on its own field instead of it being a JSON that contains "revision" and "time".
66 2015-05-19 Ryosuke Niwa <rniwa@webkit.org>
68 Build fix. Don't fall into an infinite loop when value (renamed from bytes) is zero.
70 * public/v2/manifest.js:
71 (App.Manifest.Ember.Controller.extend.):
72 (App.Manifest.Ember.Controller.extend):
74 2015-05-19 Ryosuke Niwa <rniwa@webkit.org>
76 Don't show unit (bytes) separaetly from SI suffixes (K, M, etc...)
77 https://bugs.webkit.org/show_bug.cgi?id=145181
79 Rubber-stamped by Chris Dumez.
81 Show 'MB' in each y-axis label instead of showing 'bytes' separately and suffixing each label with just 'M'
82 for clarity. This change also reduces the code complexity.
86 (App.AnalysisTaskController._chartDataChanged):
87 (App.TestGroupPane._createConfigurationSummary):
89 (RunsData.unitFromMetricName): Use 'B' instead of 'bytes' as the unit.
91 * public/v2/interactive-chart.js: Removed the support for showing units separately.
92 (App.InteractiveChartComponent._constructGraphIfPossible):
93 (App.InteractiveChartComponent._relayoutDataAndAxes)
95 * public/v2/manifest.js:
96 (App.Manifest._makeFormatter): Renamed from _formatBytes. Support more SI suffixes such as micro and mili.
97 Now takes the unit as the first argument. Adjust the base unit if it's 'ms'.
98 (App.Manifest._formatFetchedData): Removed unit and formatWithUnit now that all all formatters would
99 automatically include unit.
101 2015-05-18 Ryosuke Niwa <rniwa@webkit.org>
103 REGRESSION: v2 UI reports a higher memory usage
104 https://bugs.webkit.org/show_bug.cgi?id=145151
106 Reviewed by Chris Dumez.
108 The bug was caused by v2 UI using 1000 to divide the number of bytes instead of by 1024 as done in v1.
109 Fixed the bug by manually implementing the formatter as done in v1.
111 * public/v2/manifest.js:
112 (App.Manfiest._formatBytes): Added.
113 (App.Manifest._formatFetchedData): Use _formatByte instead of format('s').
115 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
117 Unreviewed build fix. Add "Duration" as a time metric.
119 * public/js/helper-classes.js:
121 (RunsData.unitFromMetricName):
123 2015-05-06 Ryosuke Niwa <rniwa@webkit.org>
125 Perf dashboard treats Speedometer and JetStream as smaller is better
126 https://bugs.webkit.org/show_bug.cgi?id=144711
128 Reviewed by Chris Dumez.
130 Added the support for "Score" metric.
132 * public/js/helper-classes.js:
135 (RunsData.unitFromMetricName):
136 (RunsData.isSmallerBetter):
138 2015-04-23 Ryosuke Niwa <rniwa@webkit.org>
140 Build fix after r183232.
142 * public/include/json-header.php:
144 2015-04-23 Ryosuke Niwa <rniwa@webkit.org>
146 Perf dashboard should automatically detect regressions
147 https://bugs.webkit.org/show_bug.cgi?id=141443
149 Reviewed by Anders Carlsson.
151 Added a node.js script detect-changes.js to detect potential regressions and progressions
152 on the graphs tracked on v2 dashboards.
154 * init-database.sql: Added analysis_strategies table and task_segmentation and task_test_range
155 columns to analysis_tasks to keep the segmentation and test range selection strategies used
156 to create an analysis task.
158 * public/api/analysis-tasks.php:
159 (format_task): Include task_segmentation and analysis_tasks in the results.
161 * public/include/json-header.php:
162 (remote_user_name): Returns null when the privileged API is authenticated as a slave instead
163 of a CSRF prevention token.
164 (should_authenticate_as_slave): Added.
165 (ensure_privileged_api_data_and_token_or_slave): Added. Authenticate as a slave if slaveName
166 and slavePassword are specified. Since detect-changes.js and other slaves are not susceptible
167 to a CSRF attack, we don't need to check a CSRF token.
169 * public/privileged-api/create-analysis-task.php:
170 (main): Use ensure_privileged_api_data_and_token_or_slave to let detect-changes.js create new
171 analysis task. Also add or find segmentation and test range selection strategies if specified.
173 * public/privileged-api/create-test-group.php:
174 (main): Use ensure_privileged_api_data_and_token_or_slave.
176 * public/privileged-api/generate-csrf-token.php:
179 (App.Pane._computeMovingAverageAndOutliers): _executeStrategy has been moved to Statistics.
181 * public/v2/data.js: Export Measurement, RunsData, TimeSeries. Used in detect-changes.js.
182 (Array.prototype.find): Added a polyfill to be used in node.js.
183 (RunsData.fetchRuns):
184 (RunsData.pathForFetchingRuns): Extracted from fetchRuns. Used in detect-changes.js.
185 (RunsData.createRunsDataInResponse): Extracted from App.Manifest._formatFetchedData to use it
186 in detect-changes.js.
187 (RunsData.unitFromMetricName): Ditto.
188 (RunsData.isSmallerBetter): Ditto.
189 (RunsData.prototype._timeSeriesByTimeInternal): Added secondaryTime to sort points when commit
191 (TimeSeries): When commit times are identical, order points based on build time. This is needed
192 for when we trigger two builds at two different OS versions with the same WebKit revision since
193 OS versions don't change the commit times.
194 (TimeSeries.prototype.findPointByIndex): Added.
195 (TimeSeries.prototype.rawValues): Added.
197 * public/v2/js/statistics.js:
198 (Statistics.TestRangeSelectionStrategies.[0]): Use the 99% two-sided probability as claimed in the
199 description of this strategy instead of the default probability. Also fixed a bug that debugging
200 code was referring to non-existent variables.
201 (Statistics.executeStrategy): Moved from App.Pane (app.js).
203 * public/v2/manifest.js:
204 (App.Manifest._formatFetchedData): Various code has been extracted into RunsData in data.js to be
205 used in detect-changes.js.
207 * tools/detect-changes.js: Added. The script fetches the manifest JSON, analyzes each graph in
208 the v2 dashboards, and creates an analysis task for the latest regression or progression detected.
209 It also schedules an A/B testing if possible and notifies another server; e.g. to send an email.
210 (main): Loads the settings JSON specified in the argument.
211 (fetchManifestAndAnalyzeData): The main loop that periodically wakes up to do the analysis.
212 (mapInOrder): Executes callback sequentially (i.e. blocking) on each item in the array.
213 (configurationsForTesting): Finds every (platform, metric) pair to analyze in the v2 dashbaords,
214 and computes various values for when statistically significant changes are detected later.
215 (analyzeConfiguration): Finds potential regressions and progression in the last X days where X
216 is the specified maximum number of days using the specified strategies. Sort the resultant ranges
217 in chronological order and create a new analysis task for the very last change we detected. We'll
218 eventually create an analysis task for all detected changes since we're repeating the analysis in
219 fetchManifestAndAnalyzeData after some time.
220 (computeRangesForTesting): Fetch measured values and compute ranges to test using the specified
221 segmentation and test range selection strategies. Once ranges are found, find overlapping analysis
222 tasks as they need to be filtered out in analyzeConfiguration to avoid creating multiple analysis
223 tasks for the same range (e.g. humans may create one before the script gets to do it).
224 (createAnalysisTaskAndNotify): Create a new analysis task for the specified range, trigger an A/B
225 testing if available, and notify another server with a HTML message as specified.
226 (findStrategyByLabel):
227 (changeTypeForRange): A change is a regression if values are getting larger in a smaller-is-better
228 test or values are getting smaller in a larger-is-better test and vice versa.
229 (summarizeRange): Create a human readable string that summarizes the change detected. e.g.
230 "Potential 3.2% regression detected between 2015-04-20 12:00 and 17:00".
234 (postNotification): Recursively replaces $title and $massage in the specified JSON template.
235 (instantiateNotificationTemplate):
238 2015-04-20 Ryosuke Niwa <rniwa@webkit.org>
240 Perf dashboard should have UI to set status on analysis tasks
241 https://bugs.webkit.org/show_bug.cgi?id=143977
243 Reviewed by Chris Dumez.
245 Added the UI to set the result of an analysis task to 'progression', 'regression', 'unchanged', and 'inconclusive'
246 as well as a boolean indicating whether creating the analysis task was the right thing to do or not.
247 The latter will be a useful metric once we start automatically creating analysis tasks.
249 * init-database.sql: Added two columns to analysis_tasks table.
250 * public/api/analysis-tasks.php: Include the added columns in the JSON.
251 * public/include/db.php:
252 (Database::to_database_boolean): Added.
253 * public/include/json-header.php:
254 (require_match_one_of_values): Added.
255 * public/privileged-api/update-analysis-task.php: Added. Updates 'result' and 'needed' values of an analysis task.
257 * public/v2/analysis.js:
258 (App.AnalysisTask.result): Added.
259 (App.AnalysisTask.needed): Added. We don't use DS.attr('boolean') here since that would coerce null into false
260 and we want to differentiate null from false in order to differentiate the null-ness of the value.
261 (App.AnalysisTask.saveStatus): Added.
262 (App.AnalysisTask.statusLabel): Use 'result' as the label if it's set and all build requests have been processed.
265 (App.AnalysisTaskController.analysisResultOptions): Added.
266 (App.AnalysisTaskController.shouldNotHaveBeenCreated): Added.
267 (App.AnalysisTaskController.needsFeedback): Added. Show the checkbox to indicate the analysis task should not have
268 been created if 'no change' is selected.
269 (App.AnalysisTaskController._updateChosenAnalysisResult): Added.
270 (App.AnalysisTaskController.actions.saveStatus): Added.
271 * public/v2/index.html: Extracted a partial template for updating the bug numbers. Also added the UI to update
272 'result' and 'needed' values of the analysis task.
274 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
276 Unreviewed build fix. Updated config.json after recent changes.
280 2015-04-10 Ryosuke Niwa <rniwa@webkit.org>
282 Make the analysis page more useful
283 https://bugs.webkit.org/show_bug.cgi?id=143617
285 Reviewed by Chris Dumez.
287 * public/api/analysis-tasks.php:
288 (fetch_and_push_bugs_to_tasks): Added total and finished numbers of build requests associated
289 with the fetched analysis tasks as buildRequestCount and finishedBuildRequestCount respectively.
290 * public/v2/analysis.js:
291 (App.AnalysisTask.formattedCreatedAt): Added.
292 (App.AnalysisTask._addLeadingZero): Added.
293 (App.AnalysisTask.buildRequestCount): Added.
294 (App.AnalysisTask.finishedBuildRequestCount): Added.
295 (App.AnalysisTask.statusLabel): Added. Status total and finished numbers of build requests.
296 (App.AnalysisTask.testGroups):
297 (App.AnalysisTask.triggerable):
298 (App.AnalysisTask.label):
300 * public/v2/app.css: Tweaked style rules for the analysis page.
303 (App.buildPopup): Sort the list of platforms by name.
304 (App.AnalysisRoute.model): Sort the list of analysis tasks by the order they are created.
305 (App.AnalysisTaskController._fetchedManifest): Added elementId to associate bug tracker names
306 such as "Bugzilla" with the corresponding text field.
308 * public/v2/index.html: Added a bunch of columns to the analysis page and also wrapped the table
309 showing A/B testing results in a div with overflow: scroll so that it always leaves enough space
310 for the accompanying graph.
312 2015-04-09 Ryosuke Niwa <rniwa@webkit.org>
314 Perf dashboard should automatically select ranges for A/B testing
315 https://bugs.webkit.org/show_bug.cgi?id=143580
317 Reviewed by Chris Dumez.
319 Added a new statistics option for picking a A/B test range selection strategy.
320 The selected ranges are shown in the graph using the same UI to show analysis tasks.
323 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Updated the query parameters for
324 charts page used by the dashboard since we've added a new parameter at the end.
325 (App.Pane.ranges): Added. Merges ranges created for analysis tasks and A/B testing.
326 (App.Pane.updateStatisticsTools): Clone and set the test range selection strategies.
327 (App.Pane._cloneStrategy): Copy isSegmentation.
328 (App.Pane._updateMovingAverageAndEnvelope): Set testRangeCandidates.
329 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Update the charts when a new text range
330 selection strategy is picked by the user.
331 (App.Pane._computeMovingAverageAndOutliers): Compute the test ranges using the chosen strategy.
332 Avoid going through isAnomalyArray when no anomaly detection strategy is enabled. Also changed
333 the return value from the moving average time series to a dictionary that contains the moving
334 average time series, a dictionary of anomalies, and an array of test ranges.
335 (App.ChartsController._parsePaneList): Parse the test range selection strategy configuration.
336 (App.ChartsController._serializePaneList): Ditto for serialization.
337 (App.ChartsController._scheduleQueryStringUpdate): Update the URL hash when the user picks a new
338 test range selection strategy.
340 * public/v2/chart-pane.css: Fixed a typo as well as added a CSS rule for test ranges markers.
342 * public/v2/index.html: Added UI for selecting a test range selection strategy.
344 * public/v2/interactive-chart.js:
345 (App.InteractiveChartComponent._rangesChanged): Pass down "status" to be used as a class name.
347 * public/v2/js/statistics.js:
348 (Statistics.MovingAverageStrategies): Added isSegmentation to segmentation strategies.
349 (Statistics.TestRangeSelectionStrategies): Added.
351 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
353 The results of A/B testing should state statistical significance
354 https://bugs.webkit.org/show_bug.cgi?id=143552
356 Reviewed by Chris Dumez.
358 Added statistical comparisons between results for each configuration on analysis task page using
359 Welch's t-test. The probability as well as t-statistics and the degrees of freedoms are reported.
362 (App.TestGroupPane._populate): Report the list of statistical comparison between every pair of
363 root configurations in the results. e.g. if we've got A, B, C configurations then compare A/B, A/C
365 (App.TestGroupPane._computeStatisticalSignificance): Compute the statistical significance using
366 Welch's t-test. Report the probability by which two samples do not come from the same distribution.
367 (App.TestGroupPane._createConfigurationSummary): Include the array of results for this configuration.
368 Also renamed "items" to "requests" for clarity.
370 * public/v2/index.html: Added the template for showing statistical comparisons.
372 * public/v2/js/statistics.js: Renamed tDistributionQuantiles to tDistributionByOneSidedProbability
373 for clarity. Also factored out the functions to convert from one-sided probability to two-sided
374 probability and vice versa.
375 (Statistics.supportedConfidenceIntervalProbabilities):
376 (Statistics.confidenceIntervalDelta):
377 (Statistics.probabilityRangeForWelchsT): Added. Computes the lower bound and the upper bound for
378 the probability that two values are sampled from distinct distributions using Welch's t-test.
379 (Statistics.computeWelchsT): This function now takes two-sided probability like all other functions.
380 (.tDistributionByOneSidedProbability): Renamed from tDistributionQuantiles.
381 (.oneSidedToTwoSidedProbability): Extracted.
382 (.twoSidedToOneSidedProbability): Extracted.
383 (Statistics.MovingAverageStrategies): Converted the one-sided probability to the two-sided probability
384 now that computeWelchsT takes two-sided probability.
386 2015-04-08 Ryosuke Niwa <rniwa@webkit.org>
388 Unreviewed fix after r182496 for when the cached runs JSON doesn't exist.
392 (App.Pane.refetchRuns):
394 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
396 Perf dashboard should have a way of marking outliers
397 https://bugs.webkit.org/show_bug.cgi?id=143466
399 Reviewed by Chris Dumez.
401 Address kling's in-person comment to notify users when the new run status is saved in the database.
404 (App.PaneController._selectedItemIsMarkedOutlierDidChange)
405 * public/v2/chart-pane.css: Fixed a typo.
407 2015-04-07 Ryosuke Niwa <rniwa@webkit.org>
409 Perf dashboard should have a way of marking outliers
410 https://bugs.webkit.org/show_bug.cgi?id=143466
412 Reviewed by Chris Dumez.
414 Added UI to mark a data point as an outlier as well as a button to toggle the visibility of outliers.
415 Added a new privileged API /privileged-api/update-run-status to store this boolean flag.
417 * init-database.sql: Added run_marked_outlier column to test_runs table.
419 * public/admin/tests.php:
421 * public/api/runs.php:
422 (main): Only emit Cache-Control and Expires headers in v1 UI.
423 (RunsGenerator::format_run): Emit markedOutlier.
425 * public/include/admin-header.php:
427 * public/include/db.php:
428 (Database::is_true): Made it static.
430 * public/include/manifest.php:
431 (Manifest::platforms):
433 * public/index.html: Call into /api/runs/ with ?cache=true.
435 * public/privileged-api/update-run-status.php: Added.
436 (main): Updates the newly added column in test_runs table.
440 (App.Pane.refetchRuns): Extracted from App.Pane._fetch.
441 (App.Pane._didFetchRuns): Renamed from _updateChartData.
442 (App.Pane._setNewChartData): Added. Pick the right time series based based on the value of showOutlier.
443 Cloning chartData is necessary when toggling the outlier visibility or using statistics tools because
444 the interactive chart component only observes changes to chartData and not individual properties of it.
445 (App.Pane._highlightPointsMarkedAsOutlier): Added. Highlight points marked as outliers.
446 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Call to _setNewChartData replaced the code to
447 clone chartData here.
449 (App.PaneController.actions.toggleShowOutlier): Toggle the visibility of points marked as outliers by
450 invoking App.Pane._setNewChartData.
451 (App.PaneController._detailsChanged): Don't hide the analysis pane when details changed since keep
452 opening the pane for marking points as outliers would be annoying.
453 (App.PaneController._updateCanAnalyze): Update 'cannotMarkOutlier' as well as 'cannotAnalyze'.
454 (App.PaneController.selectedMeasurement): Added.
455 (App.PaneController.showOutlierTitle): Added.
456 (App.PaneController._selectedItemIsMarkedOutlierDidChange): Added. Call out to setMarkedOutlier to
457 mark the selected point as an outlier via the newly added privileged API.
459 * public/v2/chart-pane.css: Updated styles.
462 (PrivilegedAPI._post): Report the semantic errors.
463 (Measurement.prototype.markedOutlier): Added.
464 (Measurement.prototype.setMarkedOutlier): Added. Uses PrivilegedAPI to update the database.
465 (RunsData.prototype.timeSeriesByCommitTime): Added a new argument, includeOutliers, to indicate
466 whether the time series should include measurements marked as outliers or not.
467 (RunsData.prototype.timeSeriesByBuildTime): Ditto.
468 (RunsData.prototype._timeSeriesByTimeInternal): Extracted from timeSeriesByCommitTime and
469 timeSeriesByBuildTime to share code. Now ignores measurements marked as outliers if needed.
471 * public/v2/index.html: Added an icon for showing and hiding outliers. Also added a checkbox to
472 mark individual points as outliers.
474 * public/v2/interactive-chart.js:
475 (App.InteractiveChartComponent._selectClosestPointToMouseAsCurrentItem): Re-enable the distance
476 heuristics that takes vertical closeness into account. This heuristics is more useful when marking
477 some points as outliers. This heuristics was disabled because the behavior was unpredictable but
478 with the arrow key navigation support, this is no longer an issue.
480 * public/v2/manifest.js:
481 (App.Manifest._formatFetchedData): Added showOutlier to the chart data. This function dynamically
482 updates the time series in this chart data in order to include or exclude outliers.
484 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
486 Perf dashboard should be able to trigger A/B testing jobs for iOS
487 https://bugs.webkit.org/show_bug.cgi?id=143398
489 Reviewed by Chris Dumez.
491 Fix various bugs in the perf dashboard so that it can schedule A/B testing jobs for iOS.
493 Also generalized sync-with-buildbot.py slightly to meet the requirements of iOS builders.
495 * public/api/triggerables.php:
496 (main): Avoid spitting a warning when $id_to_triggerable doesn't contain the triggerable.
497 * public/v2/analysis.js:
498 (App.AnalysisTask.triggerable): Log an error when failed to fetch triggerables for debugging purposes.
500 (App.AnalysisTaskController.updateRootConfigurations): Show 'None' when a revision is missing from
501 some of the data points. This will happen when we modify the list of projects we build for iOS.
502 (App.AnalysisTaskController.actions.createTestGroup): Gracefully fail by showing alerts when an user
503 attempts to create an invalid test group; when there is already another test group of the same or when
504 only either configuration specifies the revision for some repository.
505 (App.AnalysisTaskController._updateRootsBySelectedPoints): Fixed a typo: sets[i] -> set.
506 * public/v2/index.html: Don't show the form to create a new test group if it's not available.
507 * tools/sync-with-buildbot.py:
508 (find_request_updates):
509 (schedule_request): iOS builders take a JSON that contains the list of roots. Generate this JSON when
510 a dictionary of the form {rootsExcluding: ["WebKit"]} is specified. Also replaced the way we refer to
511 a revision from $-based text replacements to an explicit dictionary of the form {root: "WebKit"}.
512 (request_id_from_build): Don't hard code the parameter name here. Retrieve the name from the config.
514 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
516 Add time series segmentation algorithms as moving averages
517 https://bugs.webkit.org/show_bug.cgi?id=143362
519 Reviewed by Chris Dumez.
521 This patch implements two preliminary time series segmentation algorithms as moving averages.
523 Recursive t-test: Compute Welch's t-statistic at each point in a given segment of the time series.
524 If Welch's t-test implicates a statistically significance difference, then split the segment into two
525 sub segments with the maximum t-statistic (i.e. the point at which if split would yield the highest
526 probability that two segments do not share the same "underlying" mean in classical / frequentist sense).
527 We repeat this process recursively. See [1] for the evaluation of this particular algorithm.
529 Schwarz criterion: Use Schwarz or Bayesian information criterion to heuristically find the optimal
530 segmentation. Intuitively, the problem of finding the best segmentation comes down to minimizing the
531 residual sum of squares in each segment as in linear regressions. That is, for a given segment with
532 values y_1 through y_n with mean y_avg, we want to minimize the sum of (y_i - y_avg)^2 over i = 1
533 through i = n. However, we also don't want to split every data point into a separate segment so we need
534 to account the "cost" of introducing new segments. We use a cost function that's loosely based on two
535 models discussed in [2] for simplicity. We will tune this cost function further in the future.
537 The problem of finding the best segmentation then reduces to a search problem. Unfortunately, our problem
538 space is exponential with respect to the size of the time series since we could split at each data point.
539 We workaround this problem by first splitting the time series into a manageable smaller grids, and only
540 considering segmentation of a fixed size (i.e. the number of segments is constant). Since time series
541 tend to contain a lot more data points than segments, this strategy finds the optimal solution without
542 exploring much of the problem space.
544 Finding the optimal segmentation of a fixed size is, itself, another search problem that is equivalent to
545 finding the shortest path of a fixed length in DAG. Here, we use dynamic programming with a matrix of size
546 n by n where n is the length of the time series (grid). Each entry in this matrix at (i, k) stores
547 the minimum cost of segmenting data points 1 through i using k segments. We start our search at i = 1.
548 Clearly C(1, 0) = 0 (note the actual code uses 0-based index). In i-th iteration, we compute the cost
549 S(i, j) of each segment starting at i and ending at another point j after i and update C(j, k + 1) by
550 min( C(j, k + 1), C(i, k) + S(i, j) ) for all values of j above i.
552 [1] Kensuke Fukuda, H. Eugene Stanley, and Luis A. Nunes Amaral, "Heuristic segmentation of
553 a nonstationary time series", Physical Review E 69, 021108 (2004)
555 [2] Marc Lavielle, Gilles Teyssi`ere, "Detection of Multiple Change–Points in Multivariate Time Series"
556 Lithuanian Mathematical Journal, vol 46, 2006
558 * public/v2/index.html: Show the optional description for the chosen moving average strategy.
559 * public/v2/js/statistics.js:
560 (Statistics.testWelchsT):
561 (Statistics.computeWelchsT): Extracted from testWelchsT. Generalized to take the offset and the length
562 of each value array between which Welch's t-statistic is computed. This generalization helps the
563 Schwarz criterion segmentation algorithm avoid splitting values array O(n^2) times.
564 (.sampleMeanAndVarianceForValues): Ditto for the generalization.
565 (.recursivelySplitIntoTwoSegmentsAtMaxTIfSignificantlyDifferent): Added. Implements recursive t-test.
566 (.splitIntoSegmentsUntilGoodEnough): Added. Implements Schwarz criterion.
567 (.findOptimalSegmentation): Added. Implements the algorithm to find the optimal segmentation of a fixed
569 (.SampleVarianceUpperTriangularMatrix): Added. Stores S(i, j) used by findOptimalSegmentation.
570 (.SampleVarianceUpperTriangularMatrix.prototype.costBetween): Added.
572 2015-04-03 Ryosuke Niwa <rniwa@webkit.org>
574 REGRESSION: Perf dashboard sometimes fails to update zooming level
575 https://bugs.webkit.org/show_bug.cgi?id=143359
577 Reviewed by Darin Adler.
579 The bug was caused by various bugs that ended up in an exception.
582 (App.Pane._handleFetchErrors): Removed superfluous console.log.
583 (App.Pane.computeStatus): Fixed the bug in r182185 that previousPoint could be null.
584 (App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
585 * public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
586 to # when Ember.js fails to attach event listeners on time.
587 * public/v2/interactive-chart.js:
588 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
589 the containing element's size is 0.
590 (App.InteractiveChartComponent._updateBrush): Ditto.
592 2015-04-02 Ryosuke Niwa <rniwa@webkit.org>
594 Perf dashboard should have UI to test out anomaly detection strategies
595 https://bugs.webkit.org/show_bug.cgi?id=143290
597 Reviewed by Benjamin Poulain.
599 Added the UI to select anomaly detection strategies. The detected anomalies are highlighted in the graph.
601 Implemented the Western Electric Rules 1 through 4 in http://en.wikipedia.org/wiki/Western_Electric_rules
602 as well as Welch's t-test that compares the last five points to the prior twenty points.
604 The latter is what Mozilla uses (or at least did in the past) to detect performance regressions on their
605 performance tests although they compare medians instead of means.
607 All of these strategies don't quite work for us since our data points are too noisy but this is a good start.
610 (App.Pane.updateStatisticsTools): Clone anomaly detection strategies.
611 (App.Pane._updateMovingAverageAndEnvelope): Highlight anomalies detected by the enabled strategies.
612 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Observe changes to anomaly detection strategies.
613 (App.Pane._computeMovingAverageAndOutliers): Detect anomalies by each strategy and aggregate results.
614 Only report the first data point when multiple consecutive data points are detected as anomalies.
615 * public/v2/chart-pane.css: Updated styles.
616 * public/v2/index.html: Added the pane for selecting anomaly detection strategies.
617 * public/v2/js/statistics.js:
618 (Statistics.testWelchsT): Added. Implements Welch's t-test.
619 (.sampleMeanAndVarianceForValues): Added.
620 (.createWesternElectricRule): Added.
621 (.countValuesOnSameSide): Added.
622 (Statistics.AnomalyDetectionStrategy): Added.
624 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
626 REGRESSION: Searching commits can highlight wrong data points
627 https://bugs.webkit.org/show_bug.cgi?id=143272
629 Reviewed by Antti Koivisto.
631 The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
632 return commit times with only second precision. This resulted in the frontend code to match a commit
633 with the data point that included the next commit when the millisecond component of commit's timestamp
634 wasn't identically 0.
636 This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
637 was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
638 so miliseconds component was only preserved in /api/commits.
640 Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
641 it returns time in milisecond precision.
643 * public/api/commits.php:
644 (fetch_commits_between): Use Database::to_js_time for format commit times.
645 (format_commit): Ditto.
646 * public/include/db.php:
647 (Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
649 (CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
651 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
653 Perf dashboard should show relative change in values
654 https://bugs.webkit.org/show_bug.cgi?id=143252
656 Reviewed by Antti Koivisto.
658 When a range of values are selected, show the percentage difference between the start and the end
659 in addition to the absolute value difference. When a single point is selected, show the relative
660 difference with respect to the previous point. Use two significant figures and always show plus sign
661 when the difference is positive.
663 * public/v2/app.js: Compute and format the relative difference.
664 * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
665 * public/v2/index.html: Show the relative difference.
667 2015-03-31 Ryosuke Niwa <rniwa@webkit.org>
669 REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
670 https://bugs.webkit.org/show_bug.cgi?id=143254
672 Reviewed by Antti Koivisto.
674 The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
675 or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
676 so that the interactive chart component will observe a change to 'chartData'.
679 (App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
681 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
683 Unreviewed build fixes.
685 * public/include/manifest.php:
686 (Manifest::generate): These should be {} instead of [] when they're empty.
688 (Measurement.prototype.formattedRevisions): Don't assume previousRevisions[repositoryId] exits.
689 * public/v2/manifest.js:
690 (App.Metric.fullName): Fixed the typo.
691 * tests/admin-regenerate-manifest.js: Fixed the test.
693 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
695 Commit the erroneously reverted change.
697 * public/api/runs.php:
698 (RunsGenerator::results):
700 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
702 Loading the perf dashboard takes multiple seconds
703 https://bugs.webkit.org/show_bug.cgi?id=141860
705 Reviewed by Andreas Kling.
707 This patch introduces the caches of JSON files returned by /api/ in /data/ directory. It also records
708 the last time test_runs rows associated with the requested platforms and metrics are inserted, updated,
709 or removed in the caches as well as the manifest JSON files ("last modified time"). Because the manifest
710 is regenerated each time a new test result is reported, the front end can compare last modified time in
711 the manifest file with that in a /api/runs JSON cache to detect the stale-ness.
713 More concretely, the front end first optimistically fetches the JSON in /data/. If the cache doesn't exit
714 or the last modified time in the cache doesn't match with that in the manifest file, it would fetch it
715 again via /api/runs. In the case the cache did exist, we render the charts based on the cache meanwhile.
716 This dramatically reduces the perceived latency for the page load since charts are drawn immediately using
717 the cache and we would only re-render the charts as new up-to-date JSON comes in.
719 This patch also changes the format of runs JSONs by pushing the exiting properties into 'configurations'
720 and adding 'lastModified' and 'elapsedTime' at the top level.
722 * init-database.sql: Added config_runs_last_modified to test_configurations table as well as a trigger to
723 auto-update this column upon changes to test_runs table.
725 * public/admin/test-configurations.php:
726 (add_run): Regenerate the manifest file to invalidate the /api/runs JSON cache.
729 * public/api/runs.php:
730 (main): Fetch all columns of test_configurations table including config_runs_last_modified. Also generate
731 the cache in /data/ directory.
732 (RunsGenerator::__construct): Compute the last modified time for this (platform, metric) pair.
733 (RunsGenerator::results): Put the old content in 'configurations' property and include 'lastModified' and
734 'elapsedTime' properties. 'elapsedTime' is added for debugging purposes.
735 (RunsGenerator::add_runs):
736 (RunsGenerator::parse_revisions_array):
738 * public/include/db.php:
740 (generate_data_file): Added based on ManifestGenerator::store.
741 (Database::to_js_time): Extracted from RunsGenerator::add_runs to share code.
743 * public/include/json-header.php:
744 (echo_success): Renamed from success_json. Return the serialized JSON instead of echo'ing it so that we can
745 generate caches in /api/runs/.
748 * public/include/manifest.php:
749 (ManifestGenerator::generate): Added 'elapsedTime' property for the time taken to generate the manifest.
750 It seems like we're generating it in 200-300ms for now so that's good.
751 (ManifestGenerator::store): Uses generate_data_file.
752 (ManifestGenerator::platforms): Added 'lastModified' array to each platform entry. This array contains the
753 last modified time for each (platform, metric) pair.
756 (fetchTest): Updated per the format change in runs JSON.
759 (App.Pane._fetch): Fetch the cached JSON first. Refetch the uncached version if instructed as such.
760 (App.Pane._updateChartData): Extracted from App.Pane._fetch.
761 (App.Pane._handleFetchErrors): Ditto.
764 (RunsData.fetchRuns): Takes the fourth argument indicating whether we should fetch the cached version or not.
765 The cached JSON is located in /data/ with the same filename. When fetching a cached JSON results in 404,
766 fulfill the promise with null as the result instead of rejecting it. The only client of this function which
767 sets useCache to true is App.Manifest.fetchRunsWithPlatformAndMetric, and it handles this special case.
769 * public/v2/manifest.js:
770 (App.DateArrayTransform): Added. Handles the array of last modified dates in platform objects.
771 (App.Platform.lastModifiedTimeForMetric): Added. Returns the last modified date in the manifest JSON.
772 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes "useCache" like RunsData.fetchRuns. Set shouldRefetch
773 to true if response is null (the cache didn't exit) or the cache is out-of-date.
774 (App.Manifest._formatFetchedData): Extracted from App.Manifest.fetchRunsWithPlatformAndMetric.
777 (initializeDatabase): Avoid splitting function definitions in the middle.
779 * tests/api-report.js: Added tests to verify that reporting new test results updates the last modified time
780 in test_configurations.
782 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
784 REGRESSION(r180333): Analysis tasks can't be associated with bugs
785 https://bugs.webkit.org/show_bug.cgi?id=141858
787 Reviewed by Andreas Kling.
789 Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
790 of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
792 * public/v2/chart-pane.css:
793 * public/v2/index.html:
795 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
797 Selecting revisions for A/B testing is hard
798 https://bugs.webkit.org/show_bug.cgi?id=141824
800 Reviewed by Andreas Kling.
802 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
803 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
804 select A/B testing points manually.
806 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
807 sets to 'options' for clarity.
809 * public/v2/app.css: Reorganized style rules.
812 (App.AnalysisTaskController):
813 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
814 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
815 a property, which sets 'overviewDomain' property as well as other properties.
816 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
817 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
818 in the overview chart.
820 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
821 individual build requests / test results are shown or not.
823 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
824 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
826 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
828 Unreviewed test fixes after r179037, r179591, and r179763.
830 * tests/admin-regenerate-manifest.js:
831 * tests/admin-reprocess-report.js:
833 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
835 Relationship between A/B testing results are unclear
836 https://bugs.webkit.org/show_bug.cgi?id=141810
838 Reviewed by Andreas Kling.
840 Show a "reference chart" indicating which two points have been tested in each test group pane.
842 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
843 and the domain used in this chart to show charts in each test group.
845 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
847 * public/v2/analysis.js:
848 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
849 since this is the results of A/B testing results, not the data for charts shown next to them.
851 * public/v2/app.css: Added CSS rules for reference charts.
854 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
855 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
856 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
857 identically matches root sets. If one of configuration used a set of revisions for which no measurement
858 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
859 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
860 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
861 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
864 (Measurement.prototype.revisionForRepository): Added.
865 (Measurement.prototype.commitTimeForRepository): Cleanup.
866 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
868 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
869 by including the build number in the title attribute instead of in the markup.
871 * public/v2/interactive-chart.js:
872 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
873 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
874 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
876 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
878 Analysis task pages are unusable
879 https://bugs.webkit.org/show_bug.cgi?id=141786
881 Reviewed by Andreas Kling.
883 This patch makes following improvements to analysis task pages:
884 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
885 compute the data for the details pane from PaneController.
886 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
887 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
888 This change required the creation of App.TestGroupPane as well as its methods.
889 4. Show a box plot for each root set configuration as well as each build request. This change required
890 App.BoxPlotComponent.
891 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
893 * public/api/build-requests.php:
894 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
896 * public/api/test-groups.php:
897 (main): Include root sets and roots in the response.
900 * public/include/build-requests-fetcher.php:
901 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
902 (BuildRequestsFetcher::root_sets): Added.
903 (BuildRequestsFetcher::roots): Added.
904 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
905 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
906 tools/sync-with-buildbot.py can't convert repository names to their ids.
908 * public/v2/analysis.js:
910 (App.RootSet): Added.
911 (App.RootSet.revisionForRepository): Added.
912 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
913 response at /api/test-groups will include them.
914 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
915 _createConfigurationSummary.
916 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
917 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
919 * public/v2/app.css: Updated style rules for analysis task pages.
922 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
923 (App.Pane._updateDetails): Moved from App.PaneController.
925 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
927 (App.AnalysisTaskController): Added 'details'.
928 (App.AnalysisTaskController._taskUpdated):
929 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
930 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
931 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
933 (App.TestGroupPane): Added.
934 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
935 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
936 of all repositories appearing in root sets and builds associated with A/B testing results.
937 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
938 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
939 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
940 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
941 is a union of revisions in the root set and the first build request in the group. We null-out revision info
942 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
943 by the values in the group as well as 95% percentile confidence interval.
945 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
946 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
947 the mean and the confidence interval.
948 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
949 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
950 calls _updateBars to update the rects.
952 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
955 (Measurement.prototype.formattedRevisions):
956 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
957 called in _createConfigurationSummary.
959 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
960 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
961 Also made the fetching of chartData no longer block showing of test groups.
963 * public/v2/interactive-chart.js:
964 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
965 (App.InteractiveChartComponent._domainChanged): Ditto.
966 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
968 * public/v2/js/statistics.js:
969 (Statistics.min): Added.
970 (Statistics.max): Added.
972 * public/v2/manifest.js:
973 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
975 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
977 Build URL on new perf dashboard doesn't resolve $builderName
978 https://bugs.webkit.org/show_bug.cgi?id=141583
980 Reviewed by Darin Adler.
982 Support $builderName in the build URL template.
984 * public/js/helper-classes.js:
985 (TestBuild.buildUrl): Replaced $builderName with the builder name.
987 * public/v2/manifest.js:
988 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
989 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
991 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
993 Unreviewed build fix after r179591.
995 * public/api/commits.php:
997 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
999 The status of a A/B testing request always eventually becomes "Failed"
1000 https://bugs.webkit.org/show_bug.cgi?id=141523
1002 Reviewed by Andreas Kling.
1004 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
1005 'failedIfNotCompleted' was sent by the buildbot sync'er.
1007 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
1009 * public/api/build-requests.php:
1012 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
1014 Unreviewed, remove empty directories.
1016 * public/data: Removed.
1018 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
1020 Perf dashboard should show the results of A/B testing
1021 https://bugs.webkit.org/show_bug.cgi?id=141500
1023 Reviewed by Chris Dumez.
1025 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
1026 analysis task page to fetch results for each test group.
1028 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
1029 can use the formatter.
1031 * public/api/runs.php:
1032 (fetch_runs_for_config_and_test_group): Added.
1033 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
1034 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
1035 use RunsGenerator to format results.
1036 (RunsGenerator): Added.
1037 (RunsGenerator::__construct): Added.
1038 (RunsGenerator::add_runs): Added.
1039 (RunsGenerator::format_run): Moved.
1040 (RunsGenerator::parse_revisions_array): Moved.
1042 * public/v2/analysis.js:
1043 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
1044 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
1045 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
1046 configuration associated with this build request such as "A" and "B".
1047 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
1048 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
1049 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
1053 (App.Pane._fetch): Set chartData directly here.
1054 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
1055 now that it's done in App.Pane._fetch.
1056 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
1058 * public/v2/data.js:
1059 (Measurement.prototype.buildId): Added.
1060 (TimeSeries.prototype.findPointByBuild): Added.
1062 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
1063 url is not an Ember routed path.
1065 * public/v2/manifest.js:
1066 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
1067 App.createChartData here so that App.BuildRequest can use the formatter
1069 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
1071 v2 UI should adjust the number of ticks on dashboards based on screen size
1072 https://bugs.webkit.org/show_bug.cgi?id=141502
1074 Reviewed by Chris Dumez.
1076 * public/v2/interactive-chart.js:
1077 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
1080 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
1082 New perf dashboard shows too much space around interesting data points
1083 https://bugs.webkit.org/show_bug.cgi?id=141487
1085 Reviewed by Chris Dumez.
1087 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
1088 show the current time series excluding points in the series outside the moving average envelope.
1091 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
1092 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
1093 time series if the point lies outside the moving average envelope. Don't expose the moving average or
1094 the envelope computed for this purpose if they're not set by the user.
1096 * public/v2/data.js:
1097 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
1098 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
1100 * public/v2/interactive-chart.js:
1101 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
1102 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
1103 to deal with showFullYAxis here.
1104 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
1105 argument instead of directly inspecting showFullYAxis.
1107 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1109 New perf dashboard shouldn't always show outliners
1110 https://bugs.webkit.org/show_bug.cgi?id=141445
1112 Reviewed by Chris Dumez.
1114 Use the simple moving average with an average difference envelope to compute the y-axis range to show
1115 to avoid expanding it spuriously to show one off outlier.
1118 (App.Pane): Don't show the full y-axis range by default.
1119 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
1120 one is not specified by the user but without showing them in the charts.
1121 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
1122 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
1124 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
1125 (App.ChartsController._serializePaneList): Ditto.
1127 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
1129 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
1131 * public/v2/interactive-chart.js:
1132 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
1133 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
1134 if they are not specified by the user (i.e. only used to adjust y-axis range).
1135 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
1136 x-axis domain remained the same. Without this change, the charts would never redraw.
1137 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
1138 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
1139 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
1141 * public/v2/js/statistics.js:
1142 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
1144 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1146 Unreviewed build fix.
1149 (set get App.Pane.Ember.Object.extend):
1151 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
1153 New perf dashboard should have the ability to overlay moving average with an envelope
1154 https://bugs.webkit.org/show_bug.cgi?id=141438
1156 Reviewed by Andreas Kling.
1158 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
1160 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
1161 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
1162 n, backward window size, and m, forward window size, as an argument.
1164 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
1165 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
1167 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
1168 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
1171 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
1172 between each x_i and x̄_i.
1174 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
1175 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
1176 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
1177 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
1180 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
1181 The configuration of the currently chosen strategies is saved in the query string for convenience.
1183 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
1185 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
1188 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
1189 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
1190 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
1191 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
1192 from the query string via ChartsController.
1193 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
1194 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
1195 (App.Pane._executeStrategy): Added.
1196 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
1198 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
1199 selections, and added two new arguments for the moving average and the enveloping configurations.
1200 (App.ChartsController._serializePaneList): Ditto.
1201 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
1202 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
1203 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
1204 (App.PaneController.actions.toggleStatPane): Added.
1206 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
1207 current (as opposed to baseline and target) time series for when it's the most foreground graph without
1208 moving average and its envelope overlapping on top of it.
1210 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
1212 * public/v2/interactive-chart.js:
1213 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
1214 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
1215 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
1216 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
1217 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
1218 but don't bother removing individual paths and circles. Added the code to show the moving average time
1219 series when there is one. Also add "foreground" class on SVG elements for the current time series when
1220 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
1221 series when "foreground" is not set.
1222 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
1223 account when computing the y-axis range.
1224 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
1226 * public/v2/js/statistics.js:
1227 (Statistics.MovingAverageStrategies): Added.
1228 (Statistics.EnvelopingStrategies): Added.
1230 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1232 The delta value in the chart pane sometimes doens't show '+' for a positive delta
1233 https://bugs.webkit.org/show_bug.cgi?id=141340
1235 Reviewed by Andreas Kling.
1237 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
1238 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
1241 (App.Pane.computeStatus):
1242 (App.createChartData):
1244 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1246 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
1249 (App.PaneController._updateDetails):
1251 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1253 Unreviewed. Commit the forgotten change.
1255 * public/include/manifest.php:
1257 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
1259 New perf dashboard should have multiple dashboard pages
1260 https://bugs.webkit.org/show_bug.cgi?id=141339
1262 Reviewed by Chris Dumez.
1264 Added the support for multiple dashboard pages. Also added the status of the latest data point.
1265 e.g. "5% better than target"
1267 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
1268 Also hid the border lines around charts on the dashboard page for a cleaner look.
1271 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
1272 (App.IndexRoute.beforeModel): Added.
1273 (App.DashboardRoute): Added.
1274 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
1275 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
1276 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
1277 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
1278 (App.DashboardController): Renamed from App.IndexController.
1279 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
1280 and "defaultDashboard" as these are taken care of by newly added routers.
1281 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
1282 now done in actions.toggleEditMode.
1283 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
1284 an existing dashboard.
1286 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
1287 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
1288 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
1289 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
1291 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
1293 (App.PaneController._updateDetails): Updated per changes to computeStatus.
1295 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
1297 * public/v2/data.js:
1298 (TimeSeries.prototype.lastPoint): Added.
1300 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
1301 on the dashboard, and enumerate all predefined dashboards.
1303 * public/v2/interactive-chart.js:
1304 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
1305 for the dashboard page.
1307 * public/v2/manifest.js:
1308 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
1309 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
1310 IDs are generated for each dashboard for forward compatibility.
1312 (App.Manifest.dashboardByName): Added.
1313 (App.Manifest.defaultDashboardName): Added.
1314 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
1316 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1318 Move commits viewer to the end of details view
1319 https://bugs.webkit.org/show_bug.cgi?id=141315
1321 Rubber-stamped by Andreas Kling.
1323 Show the difference instead of the old value per kling's request.
1326 (App.PaneController._updateDetails):
1327 * public/v2/index.html:
1329 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1331 Move commits viewer to the end of details view
1332 https://bugs.webkit.org/show_bug.cgi?id=141315
1334 Reviewed by Andreas Kling.
1336 Improved the way list of commits are shown per kling's request.
1339 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
1341 * public/v2/chart-pane.css: Updated the style for the commits viewer.
1343 * public/v2/commits-viewer.js:
1344 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
1345 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
1347 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
1348 moved the commits viewers out of the details tables so that they don't interleave revision data.
1350 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1352 New perf dashboard should compare results to baseline and target
1353 https://bugs.webkit.org/show_bug.cgi?id=141286
1355 Reviewed by Chris Dumez.
1357 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
1358 Also use d3.format to format the selected value to show four significant figures.
1361 (App.Pane.searchCommit):
1362 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
1363 to compute the status text without having to recreate them.
1364 (App.createChartData): Added.
1365 (App.PaneController._updateDetails): Use 3d.format on current and old values.
1366 (App.PaneController._computeStatus): Added. Computes the status text.
1367 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
1368 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
1369 format the values using chartData.formatter.
1371 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
1372 the baseline and in blue if it's better than the target.
1374 * public/v2/data.js:
1375 (TimeSeries.prototype.findPointAfterTime): Added.
1377 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
1378 the bug that we were not showing the old value's unit.
1380 * public/v2/interactive-chart.js:
1381 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
1382 the code to show the baseline and the target lines.
1384 * public/v2/manifest.js:
1385 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
1387 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
1389 Unreviewed build fix.
1392 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
1394 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1396 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
1397 https://bugs.webkit.org/show_bug.cgi?id=141280
1399 Reviewed by Chris Dumez.
1401 Fixed the bug by passing in "since" as a query parameter to the charts page.
1403 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
1405 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
1407 (App.IndexController): Changed the default number of days from one month to one week.
1408 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
1409 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
1411 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1413 New perf dashboard erroneously clears zoom when poping history items
1414 https://bugs.webkit.org/show_bug.cgi?id=141278
1416 Reviewed by Chris Dumez.
1418 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
1420 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
1421 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
1424 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
1425 shown in the main plot.
1426 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
1427 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
1429 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1431 New perf dashboard shows null as the aggregator name if no aggregation is done
1432 https://bugs.webkit.org/show_bug.cgi?id=141256
1434 Reviewed by Chris Dumez.
1436 Don't show the aggregator name if there isn't one.
1438 * public/v2/manifest.js:
1441 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1443 Unreviewed build fix after r179611.
1445 * public/v2/interactive-chart.js:
1447 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1449 Perf dashboard doesn’t show the right unit for Safari UI tests
1450 https://bugs.webkit.org/show_bug.cgi?id=141238
1452 Reviewed by Darin Adler.
1454 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
1455 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
1456 between metrics and their units.
1458 * public/js/helper-classes.js:
1459 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
1460 * public/v2/manifest.js:
1461 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
1462 * public/v2/interactive-chart.js:
1463 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
1464 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
1466 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
1468 Interactive chart component provides two duplicate API for highlighting points
1469 https://bugs.webkit.org/show_bug.cgi?id=141234
1471 Reviewed by Chris Dumez.
1473 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
1474 on the main charts page and markedPoints to show the two end points in the analysis task page.
1476 This patch merges markedPoints into highlightedItems.
1479 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
1480 * public/v2/chart-pane.css:
1481 * public/v2/index.html: Ditto.
1482 * public/v2/interactive-chart.js:
1483 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
1484 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
1485 items if highlightedItems was set before the initial layout.
1486 (App.InteractiveChartComponent._relayoutDataAndAxes):
1487 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
1488 vertical lines, just set cx and cy as done for other "dots".
1489 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
1490 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
1491 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
1492 set the radius of highlight circles here.
1494 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1496 Don’t use repository names as id’s.
1497 https://bugs.webkit.org/show_bug.cgi?id=141226
1499 Reviewed by Chris Dumez.
1501 Not using repository names as their id's reduces the need to fetch the entire repositories table.
1502 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
1504 * Websites/perf.webkit.org/public/api/runs.php:
1505 (parse_revisions_array): No longer uses $repository_id_to_name.
1506 (main): No longer populates $repository_id_to_name.
1508 * Websites/perf.webkit.org/public/api/triggerables.php:
1509 (main): Don't resolve repository names.
1511 * Websites/perf.webkit.org/public/include/manifest.php:
1512 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
1513 (ManifestGenerator::bug_trackers): Don't resolve repository names.
1515 * Websites/perf.webkit.org/public/js/helper-classes.js:
1516 (TestBuild): Renamed repositoryName to repositoryId.
1517 (TestBuild.revision): Ditto.
1518 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
1519 since this is the text shown to human.
1521 * Websites/perf.webkit.org/public/v2/app.js:
1522 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
1523 (App.PaneController._updateDetails): Ditto.
1524 (App.AnalysisTaskController.updateRoots): Ditto.
1526 * Websites/perf.webkit.org/public/v2/data.js:
1527 (Measurement): Ditto.
1528 (Measurement.prototype.commitTimeForRepository): Ditto.
1529 (Measurement.prototype.formattedRevisions): Ditto.
1531 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
1532 select element's label and value respectively.
1534 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1536 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
1538 * public/api/runs.php:
1540 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
1542 /api/runs.php should have main function
1543 https://bugs.webkit.org/show_bug.cgi?id=141220
1545 Reviewed by Benjamin Poulain.
1547 Wrapped the code inside main function for clarity.
1549 * public/api/runs.php:
1551 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
1553 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
1555 * tools/sync-with-buildbot.py:
1556 (find_request_updates):
1558 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1560 Perf dashboard always assigns the result of A/B testing with build request 1
1561 https://bugs.webkit.org/show_bug.cgi?id=140382
1563 Reviewed by Darin Adler.
1565 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
1566 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
1568 Also fixed a typo as well as a bug that reports were never associated with builds.
1570 * public/include/report-processor.php:
1571 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
1572 instead of the first non-null value.
1573 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
1574 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
1576 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
1578 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
1580 * public/admin/tests.php:
1582 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
1584 Unreviewed build fix. Removed the stale code.
1586 * public/admin/triggerables.php:
1588 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1590 Perf dashboard should have the ability to post A/B testing builds
1591 https://bugs.webkit.org/show_bug.cgi?id=140317
1593 Rubber-stamped by Simon Fraser.
1595 This patch adds the support for triggering A/B testing from the perf dashboard.
1597 We add a few new tables to the database. "build_triggerables", which represents a set of builders
1598 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
1599 of repositories for which an arbitrary revision can be specified for A/B testing.
1600 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
1601 "roots" table which specifies the revision used in a given root set in each repository.
1603 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
1604 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
1605 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
1606 to build_requests table. Also made each test group's name unique in a given analysis task as it
1607 would be confusing to have multiple test groups of the same name.
1609 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
1611 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
1612 for which a specific revision can be set in an A/B testing on a given triggerable.
1614 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
1615 triggerable. Also updates the status' and the status urls of specified build requests when
1616 buildRequestUpdates is provided in the raw POST data.
1619 * public/api/runs.php:
1620 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
1621 results of an A/B testing.
1623 * public/api/test-groups.php:
1624 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
1626 * public/api/triggerables.php: Added.
1627 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
1629 * public/include/admin-header.php:
1631 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
1632 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
1633 and root sets used in those requests.D
1634 (BuildRequestsFetcher::__construct):
1635 (BuildRequestsFetcher::fetch_for_task):
1636 (BuildRequestsFetcher::fetch_for_group):
1637 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
1638 (BuildRequestsFetcher::has_results):
1639 (BuildRequestsFetcher::results):
1640 (BuildRequestsFetcher::results_with_resolved_ids):
1641 (BuildRequestsFetcher::results_internal):
1642 (BuildRequestsFetcher::root_sets):
1643 (BuildRequestsFetcher::fetch_roots_for_set):
1645 * public/include/db.php:
1646 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
1647 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
1648 table since it only has the primary key, id, column.
1649 (Database::select_or_insert_row):
1650 (Database::update_or_insert_row):
1651 (Database::update_row): Added.
1652 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
1653 should be inserted when no row matches the specified criteria. This is used while updating
1654 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
1655 new build requests in that API.
1656 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
1657 This is used in public/api/triggerables.php when no analysis task is specified.
1659 * public/include/json-header.php:
1660 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
1661 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
1662 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
1663 find the closest ancestor with a triggerable.
1665 * public/include/report-processor.php:
1666 (ReportProcessor::process):
1667 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
1668 if jobId or buildRequest is specified.
1670 * public/include/test-name-resolver.php:
1671 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
1672 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
1673 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
1676 * public/include/test-path-resolver.php: Added.
1677 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
1678 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
1679 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
1680 in order to compute full test metric names.
1681 (TestPathResolver::__construct):
1682 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
1683 the highest (a test without a parent).
1684 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
1685 the highest ancestor to the test itself.
1686 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
1688 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
1690 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
1691 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
1692 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
1693 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
1695 * public/v2/analysis.js:
1696 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
1697 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
1698 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
1699 (App.TestGroup.create): Added. Creates a new A/B testing group.
1700 (App.Triggerable): Added.
1701 (App.TriggerableAdapter): Added.
1702 (App.TriggerableAdapter.buildURL): Added.
1703 (App.BuildRequest.testGroup): Renamed from group.
1704 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
1705 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
1706 in this build request.
1707 (App.BuildRequest.status): Added.
1708 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
1709 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
1712 (App.AnalysisTaskController.testGroups): Added.
1713 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
1714 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
1715 but an observer that updates "roots" property. Filter out the repositories that are not accepted
1716 by the associated triggerable as they will be ignored.
1717 (App.AnalysisTaskController.actions.createTestGroup): Added.
1719 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
1721 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
1722 the status of those builds to the perf dashboard. A similar script can be written to support
1723 other continuous builds systems.
1724 (main): Fetches the list of pending builds as well as currently running or completed builds from
1725 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
1726 a single new build on each builder with no pending builds, and marks the set of open build requests
1727 that have been scheduled to run on the buildbot but not found in the first step as stale.
1728 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
1731 "platform": "mac-mavericks",
1732 "test": ["Parser", "html5-full-render.html"],
1733 "builder": "Trunk Syrah Production Perf AB Tests",
1735 "forcescheduler": "force-mac-mavericks-release-perf",
1736 "webkit_revision": "$WebKit",
1737 "jobid": "$buildRequest"
1742 (find_request_updates): Return a list of build request status updates to make based on the pending
1743 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
1744 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
1745 if the build request had not been completed. This is necessary because a failed build will not
1746 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
1747 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
1748 of open requests the perf dashboard has.
1749 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
1750 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
1751 or human canceling a build may trigger such a state.
1752 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
1753 replacing repository names with their revisions and buildRequest with the build request id.
1754 (config_for_request): Finds a builder for the test and the platform of a build request.
1755 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
1756 (property_value_from_build): Returns the value of a specific property in a buildbot build.
1757 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
1759 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1761 Cache-control should be set only on api/runs
1762 https://bugs.webkit.org/show_bug.cgi?id=140312
1764 Reviewed by Andreas Kling.
1766 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
1767 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
1768 just set cache-control there instead of json-header.php which is used by other JSON APIs.
1770 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
1772 * public/api/analysis-tasks.php:
1773 * public/api/runs.php: Set the cache control headers.
1774 * public/api/test-groups.php:
1775 * public/include/db.php: Set the default timezone to UTC.
1776 * public/include/json-header.php: Don't set the cache control headers.
1778 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1780 api/report-commit should authenticate with a slave name and password
1781 https://bugs.webkit.org/show_bug.cgi?id=140308
1783 Reviewed by Benjamin Poulain.
1785 Use a slave name and a password to authenticate new commit reports.
1787 * public/api/report-commits.php:
1789 * public/include/json-header.php:
1790 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
1791 a slave name and a password instead of a builder name and a password.
1792 * tests/api-report-commits.js: Updated tests.
1793 * tools/pull-svn.py:
1794 (main): Renamed variables.
1795 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
1797 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
1799 Perf dashboard should support authentication via a slave password
1800 https://bugs.webkit.org/show_bug.cgi?id=139837
1802 Reviewed by Andreas Kling.
1804 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
1805 having to add multiple builders with the same password when a single build slave is shared among them.
1807 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
1809 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
1811 * public/admin/build-slaves.php: Added.
1813 * public/admin/builders.php: Added the support for updating passwords.
1815 * public/include/admin-header.php:
1816 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
1817 being retrieved from $_POST.
1818 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
1819 the raw may not exist (e.g. new_password).
1820 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
1821 control here when this flag evaluates to TRUE.
1823 * public/include/report-processor.php:
1824 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
1825 values are present in the report. In addition, try authenticating builderName with slavePassword if
1826 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
1827 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
1828 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
1830 (ReportProcessor::store_report): Store the slave ID with the report.
1831 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
1832 the matching build is different from what's being reported.
1834 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
1837 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
1839 New perf dashboard should not duplicate author information in each commit
1840 https://bugs.webkit.org/show_bug.cgi?id=139756
1842 Reviewed by Darin Adler.
1844 Instead of each commit having author name and email, make it reference a newly added committers table.
1845 Also replace "email" by "account" since some repositories don't use emails as account names.
1847 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
1848 which only contains as many rows as there are accounts in each repository, instead of commits table
1849 which contains every commit ever happened in each repository.
1851 To migrate an existing database into match the new schema, run:
1855 INSERT INTO committers (committer_repository, committer_name, committer_email)
1856 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
1857 FROM commits WHERE commit_author_email IS NOT NULL);
1859 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
1861 UPDATE commits SET commit_committer = committer_id FROM committers
1862 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
1864 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
1865 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
1869 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
1870 reference to committers. Also added the missing drop table statements.
1872 * public/api/commits.php:
1873 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
1874 an array here instead of doing it in format_commit.
1875 (fetch_commits_between): Updated queries to JOIN commits with committers.
1876 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
1877 is now done in main.
1879 * public/api/report-commits.php:
1880 (main): Store the reported committer information or update the existing entry if there is one.
1882 * tests/admin-regenerate-manifest.js: Fixed tests.
1884 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
1886 * tools/pull-svn.py: Renamed email to account.
1888 (fetch_commit_and_resolve_author):
1890 (resolve_author_name_from_account):
1891 (resolve_author_name_from_email): Deleted.
1893 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
1895 Unreviewed build fix.
1897 * public/v2/index.html: Include js files we extracted in r177424.
1899 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1901 Unreviewed. Adding the forgotten svnprop.
1903 * tools/pull-svn.py: Added property svn:executable.
1905 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1907 Split InteractiveChartComponent and CommitsViewerComponent into separate files
1908 https://bugs.webkit.org/show_bug.cgi?id=139716
1910 Rubber-stamped by Benjamin Poulain.
1912 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
1913 and interactive-chart.js respectively since app.js has gotten really large.
1916 * public/v2/commits-viewer.js: Added.
1917 * public/v2/interactive-chart.js: Added.
1919 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
1921 New perf dashboard's chart UI is buggy
1922 https://bugs.webkit.org/show_bug.cgi?id=139214
1924 Reviewed by Chris Dumez.
1926 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
1928 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
1929 component. This is not how Ember.js components should interact to begin with. The component now exposes
1930 selectedPoints and always updates selection instead of sharedSelection.
1933 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
1934 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
1935 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
1936 and end time should be completely determined by "since" and the present time.
1937 (App.ChartsController._startTimeChanged): Ditto.
1938 (App.ChartsController._scheduleQueryStringUpdate):
1939 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
1941 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
1943 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
1944 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
1945 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
1946 observes the changes to selectedPoints property as it gets updated by the main chart.
1947 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
1948 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
1950 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
1951 when domain arrays aren't identical. This was causing a subtle race with other logic.
1952 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
1953 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
1954 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
1955 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
1956 see if those two points correspond to a range or a single data point. Rewrote all that logic by
1957 directly observing selectedPoints and currentItem properties instead of taking points and relying on
1958 an instance variable, which was a terrible API.
1959 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
1960 when the main plot has a selected range, we don't have to check this._hasRange anymore.
1962 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
1963 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
1964 (App.InteractiveChartComponent._updateSelection):
1965 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
1966 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
1967 selectedPoints property.
1969 (App.AnalysisTaskController._fetchedRuns):
1970 (App.AnalysisTaskController._rootChangedForTestSet):
1972 * public/v2/index.html:
1973 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
1975 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1977 Unreviewed. Fixed syntax errors.
1979 * init-database.sql:
1980 * public/api/commits.php:
1982 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1984 The dashboard on new perf monitor should be configurable
1985 https://bugs.webkit.org/show_bug.cgi?id=138994
1987 Reviewed by Benjamin Poulain.
1989 For now, make it configurable via config.json. We should eventually make it configurable via
1990 an administrative page but this will do for now.
1992 * config.json: Added the empty dashboard configuration.
1994 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1997 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1998 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1999 Also obtain the default configuration from App.Manifest.
2000 (App.IndexController._normalizeTable): Moved to App.Dashboard.
2002 * public/v2/manifest.js:
2003 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
2004 (App.Repository.urlForRevisionRange): Ditto.
2005 (App.Dashboard): Added.
2006 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
2007 (App.Dashboard.rows): Ditto.
2008 (App.Dashboard.headerColumns): Ditto.
2009 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
2010 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
2011 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
2012 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
2014 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
2016 There should be a way to associate bugs with analysis tasks
2017 https://bugs.webkit.org/show_bug.cgi?id=138977
2019 Reviewed by Benjamin Poulain.
2021 Updated associate-bug.php to match the new database schema.
2023 * public/include/json-header.php:
2024 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
2025 already camel-cased in require_existence_of. This makes the function usable elsewhere.
2027 * public/privileged-api/associate-bug.php:
2028 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
2029 Also verify that those values are integers using require_format.
2031 * public/v2/analysis.js:
2032 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
2033 (App.Bug.label): Added.
2034 (App.BugAdapter): Added.
2035 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
2036 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
2038 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
2039 containing the bug information.
2042 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
2043 (App.AnalysisTaskRoute):
2044 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
2045 (App.AnalysisTaskController._fetchedManifest): Added.
2046 (App.AnalysisTaskController.actions.associateBug): Added.
2048 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
2050 * public/v2/data.js:
2051 (Measurement.prototype.associateBug): Deleted.
2053 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
2054 Added a table show the bug information. Also hide the chart until chartData is available.
2056 * public/v2/manifest.js:
2059 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
2061 Fix misc bugs and typos in app.js
2062 https://bugs.webkit.org/show_bug.cgi?id=138946
2064 Reviewed by Benjamin Poulain.
2067 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
2068 (App.ChartsController.init):
2069 (App.buildPopup): Renamed from App.BuildPopup.
2070 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
2071 remove() on the wrong object (an array as opposed to elements in the array).
2072 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
2073 _highlights is always an array and evalutes to true.
2075 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
2077 New perf dashboard should provide UI to create a new analysis task
2078 https://bugs.webkit.org/show_bug.cgi?id=138910
2080 Reviewed by Benjamin Poulain.
2082 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
2083 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
2085 With this patch, we can create a new analysis task by selection a range of points and opening
2086 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
2087 in the chart hyperlinked to the analysis task.
2089 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
2091 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
2092 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
2094 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
2095 and adds the associated bugs to each task in the array.
2098 * public/api/runs.php: Reverted changes made in r175006.
2099 (fetch_runs_for_config):
2102 * public/api/test-groups.php:
2103 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
2105 * public/include/db.php:
2106 (Database::select_first_or_last_row):
2107 (Database::select_rows): Extracted from select_first_or_last_row.
2109 * public/v2/analysis.js:
2110 (App.AnalysisTask): Added "bugs" property.
2111 (App.Bug): Added now that bugs are regular data store objects.
2114 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
2115 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
2116 platform that are associated with a specific range of runs.
2117 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
2118 (App.PaneController.actions.associateBug): Deleted.
2119 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
2120 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
2121 once we've created one.
2122 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
2123 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
2124 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
2125 (App.PaneController._updateBugs): Deleted.
2126 (App.PaneController._updateMarkedPoints): Deleted.
2127 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
2128 the name is missing or when at most one point is selected.
2130 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
2131 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
2132 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
2133 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
2134 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
2135 clickable bars for analysis tasks.
2136 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
2137 bar for analysis tasks to place them at the right location.
2138 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
2140 * public/v2/chart-pane.css:
2141 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
2142 (.chart .rangeBar): Added.
2144 * public/v2/data.js:
2145 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
2147 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
2148 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
2149 task bars in the interactive chart component.
2151 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
2153 Fix typos in r176203.
2156 (App.ChartsController.actions.addPaneByMetricAndPlatform):
2157 (App.AnalysisTaskRoute):
2159 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
2161 Unreviewed. Updated the install instruction.
2165 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
2167 App.Manifest shouldn't use App.__container__.lookup
2168 https://bugs.webkit.org/show_bug.cgi?id=138768
2170 Reviewed by Andreas Kling.
2172 Removed the hack to find the store object via App.__container__.lookup.
2173 Pass around the store object instead.
2176 (App.DashboardRow._createPane): Add "store" property to the pane.
2177 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
2178 (App.IndexController.gridChanged): Ditto.
2179 (App.IndexController.actions.addRow): Ditto.
2180 (App.IndexController.init): Ditto.
2181 (App.Pane._fetch): Ditto.
2182 (App.ChartsController._parsePaneList): Ditto.
2183 (App.ChartsController._updateQueryString): Ditto.
2184 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
2185 (App.BuildPopup): Ditto.
2186 (App.AnalysisTaskRoute.model): Ditto.
2187 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
2189 * public/v2/manifest.js:
2190 (App.Manifest.fetch): Removed the code to find the store object.
2192 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
2194 Fix Ember.js warnings the new perf dashboard
2195 https://bugs.webkit.org/show_bug.cgi?id=138531
2197 Reviewed by Darin Adler.
2199 Fixed various warnings.
2202 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
2203 * public/v2/data.js:
2204 (PrivilegedAPI._post): Removed the superfluous console.log.
2205 (CommitLogs.fetchForTimeRange): Ditto.
2206 * public/v2/index.html: Added tbody as required by the HTML specification.
2208 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
2210 Fix typos in r175768.
2213 (App.AnalysisTaskViewModel.roots):
2215 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
2217 Introduce the concept of analysis task to perf dashboard
2218 https://bugs.webkit.org/show_bug.cgi?id=138517
2220 Reviewed by Andreas Kling.
2222 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
2223 a single platform and used to bisect regressions in the range.
2225 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
2227 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
2228 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
2229 test runs. Analysis tasks not associated with test runs are used for try new patches.
2230 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
2231 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
2232 build_requests - A build request represents a single pending build for A/B testing.
2234 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
2238 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
2239 the specified analysis task group as well as build requests associated with them.
2241 (fetch_test_groups_for_task):
2242 (fetch_build_requests_for_task):
2243 (fetch_build_requests_for_group):
2244 (format_test_group):
2245 (format_build_request):
2247 * public/include/json-header.php:
2248 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
2251 * public/privileged-api/associate-bug.php:
2252 (main): Fixed a typo.
2254 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
2257 (ensure_config_from_runs):
2259 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
2261 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
2263 (App.AnalysisTask.create):
2265 (App.TestGroupAdapter):
2266 (App.AnalysisTaskSerializer):
2267 (App.TestGroupSerializer):
2270 * public/v2/app.css: Added style rules for the analysis page.
2273 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
2275 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
2276 exactly one selected point as we can still create an analysis task.
2277 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
2278 grammatical and also alert'ed the error message when there is one.
2279 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
2280 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
2281 once XHR request has completed.
2282 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
2283 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
2284 is selected in the details pane.
2286 (App.AnalysisRoute): Added.
2287 (App.AnalysisTaskRoute): Added.
2288 (App.AnalysisTaskViewModel): Added.
2289 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
2290 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
2291 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
2292 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
2293 the user selects an option for all roots in A or B configuration.
2294 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
2296 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
2298 * public/v2/data.js:
2299 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
2300 point so that we can use it in App.AnalysisTaskViewModel.roots.
2301 (TimeSeries.prototype.findPointByMeasurementId): Added.
2302 (TimeSeries.prototype.seriesBetweenPoints): Added.
2304 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
2305 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
2306 when multiple points are selected. Finally, added a new template for the analysis task page.
2308 * public/v2/manifest.js:
2309 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
2310 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
2311 App.AnalysisTaskViewModel._taskUpdated.
2313 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
2315 Remove App.PaneController.bugsChangeCount in the new perf dashboard
2316 https://bugs.webkit.org/show_bug.cgi?id=138111
2318 Reviewed by Darin Adler.
2321 (App.PaneController.bugsChangeCount): Removed.
2322 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
2323 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
2324 Finds the list of current run's points that are associated with bugs.
2325 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
2326 * public/v2/chart-pane.css:
2327 (.chart .marked): Renamed from .hasBugs.
2328 * public/v2/index.html: Specify chartPointRadius and markedPoints.
2330 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
2332 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
2333 https://bugs.webkit.org/show_bug.cgi?id=138099
2335 Reviewed by Benjamin Poulain.
2337 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
2338 _showDetails inverting the order of the current and old measurements.
2341 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
2342 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
2343 current (latest) measurement and the first point is the oldest measurement.
2344 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
2346 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
2348 Perf dashboard should provide a way to associate bugs with a test run
2349 https://bugs.webkit.org/show_bug.cgi?id=137857
2351 Reviewed by Andreas Kling.
2353 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
2354 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
2355 the Apache configuration.
2358 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
2359 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
2360 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
2361 via the cookie and returns a token computed from those two values as well as the remote username.
2363 The font end code then POST's the request along with the returned token. The server side code verifies
2364 that the specified token can be generated from the salt and the expiration time set in the cookie, and
2365 the token hasn't expired.
2368 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
2369 have zero or exactly one bug associated with a test run.
2371 * public/admin/bug-trackers.php: Added the support for editing bug_url.
2372 * public/api/runs.php:
2373 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
2374 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
2375 an associated bug if there is one.
2376 (format_run): Calls parse_bugs_array.
2378 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
2379 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
2380 have a valid JSON payload.
2381 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
2382 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
2383 the expiration time stored in the cookie.
2384 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
2386 * public/include/manifest.php:
2387 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
2388 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
2390 * public/index.html:
2391 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
2393 * public/privileged-api/associate-bug.php: Added.
2394 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
2395 attack via ensure_privileged_api_data_and_token, which calls verify_token.
2397 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
2399 * public/v2/app.css:
2400 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
2401 selected in a chart.
2404 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
2405 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
2406 they would overlap on each other if both of them are shown.
2407 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
2408 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
2409 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
2410 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
2411 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
2412 showing the search pane.
2413 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
2414 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
2415 bugs in the selected range.
2417 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
2418 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
2419 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
2420 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
2421 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
2422 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
2423 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
2424 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
2426 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
2427 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
2428 to selectionChanged action instead of just finding the first and the last points.
2430 * public/v2/chart-pane.css: Updated the style.
2432 * public/v2/data.js:
2433 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
2434 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
2435 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
2436 we haven't already obtained a CSRF token or if the token has already been expired.
2437 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
2439 (Measurement.prototype.bugs): Added.
2440 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
2441 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
2443 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
2446 * public/v2/manifest.js:
2447 (App.BugTracker.bugUrl):
2448 (App.BugTracker.newBugUrl): Added.
2449 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
2450 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
2451 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
2452 (App.Manifest.bugTrackers): Added.
2453 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
2454 their respective ids to make the ordering stable.
2456 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
2458 Remove unused jobs table
2459 https://bugs.webkit.org/show_bug.cgi?id=137724
2461 Reviewed by Daniel Bates.
2463 Removed jobs table in the database as well as related code.
2465 * init-database.sql:
2466 * public/admin/jobs.php: Removed.
2467 * public/admin/tests.php:
2468 * public/include/admin-header.php:
2470 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2472 New perf dashboard should have an ability to search commits by a keyword
2473 https://bugs.webkit.org/show_bug.cgi?id=137675
2475 Reviewed by Geoffrey Garen.
2477 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
2478 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
2479 This API change allows fetch_commits_between to generate results without processing Postgres query results.
2481 In the front end side, we've added a search pane in pane controller, and the interactive chart component
2482 now has a concept of highlighted items which is used to indicate commits found by the search pane.
2484 * public/api/commits.php:
2485 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
2486 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
2487 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
2488 (format_commit): Renamed from format_commits. Now only formats one commit.
2490 * public/include/db.php:
2491 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
2493 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
2496 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
2497 which is a hash table that contains highlighted items' measurements' ids as keys.
2498 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
2499 the default commit repository.
2500 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
2501 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
2502 Added the code to initialize this._highlights.
2503 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
2504 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
2505 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
2506 the existing lines for the old highlighted items.
2507 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
2508 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
2510 * public/v2/chart-pane.css: Added style for the search pane and the search button.
2512 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
2513 (CommitLogs): Added.
2514 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
2515 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
2516 (CommitLogs._cacheConsecutiveCommits): Ditto.
2517 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
2518 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
2519 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
2521 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
2522 for showingDetails since this property is no longer used.
2524 * public/v2/manifest.js:
2525 (App.Manifest.repositories): Added.
2526 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
2527 the default repository to search.
2528 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
2530 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
2532 Unreviewed build fix after r174555.
2534 * public/include/manifest.php:
2535 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
2536 * tests/admin-regenerate-manifest.js: Fixed the test case.
2538 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
2540 New perf dashboard UI tries to fetch commits all the time
2541 https://bugs.webkit.org/show_bug.cgi?id=137592
2543 Reviewed by Andreas Kling.
2545 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
2546 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
2547 no reported commits as they are all going to fail.
2549 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
2550 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
2551 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
2552 of commits sorted chronologically by time.
2554 * public/include/manifest.php:
2557 (App.CommitsViewerComponent.commitsChanged):
2559 * public/v2/data.js:
2560 (FetchCommitsForTimeRange):
2561 (FetchCommitsForTimeRange._cachedCommitsByRepository):
2563 * public/v2/manifest.js:
2566 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2568 Another unreviewed build fix after r174477.
2570 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
2572 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
2574 * public/include/report-processor.php:
2576 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2578 Unreviewed build fix after r174477.
2580 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
2581 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
2583 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
2584 This is necessary for baseline and target values manually added via admin pages.
2586 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2588 Add v2 UI for the perf dashboard
2589 https://bugs.webkit.org/show_bug.cgi?id=137537
2591 Rubber-stamped by Andreas Kling.
2594 * public/v2/app.css: Added.
2595 * public/v2/app.js: Added.
2596 * public/v2/chart-pane.css: Added.
2597 * public/v2/data.js: Added.
2598 * public/v2/index.html: Added.
2599 * public/v2/js: Added.
2600 * public/v2/js/d3: Added.
2601 * public/v2/js/d3/LICENSE: Added.
2602 * public/v2/js/d3/d3.js: Added.
2603 * public/v2/js/d3/d3.min.js: Added.
2604 * public/v2/js/ember-data.js: Added.
2605 * public/v2/js/ember.js: Added.
2606 * public/v2/js/handlebars.js: Added.
2607 * public/v2/js/jquery.min.js: Added.
2608 * public/v2/js/statistics.js: Added.
2609 * public/v2/manifest.js: Added.
2610 * public/v2/popup.js: Added.
2612 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2614 Remove superfluously duplicated code in public/api/report-commits.php.
2616 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
2618 Perf dashboard should store commit logs
2619 https://bugs.webkit.org/show_bug.cgi?id=137510
2621 Reviewed by Darin Adler.
2623 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
2625 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
2626 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
2627 a subversion directory. The git version of this script will be added in a follow up patch.
2630 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
2631 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
2632 relationship via "build_commits" relations.
2634 In order to migrate an existing instance of this application, run the following SQL commands:
2638 INSERT INTO commits (commit_repository, commit_revision, commit_time)
2639 (SELECT DISTINCT ON (revision_repository, revision_value)
2640 revision_repository, revision_value, revision_time FROM build_revisions);
2642 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
2643 FROM commits, build_revisions
2644 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
2646 DROP TABLE build_revisions;
2651 The helper script to submit commit logs can be used as follows:
2653 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
2654 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
2656 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
2657 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
2658 "feeder-slave-password" as the builder name and the builder password respectively.
2660 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
2661 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
2664 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
2666 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
2667 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
2669 - Not specified - It returns every single commit for a given repository.
2670 - Matches "oldest" - It returns the commit with the oldest timestamp.
2671 - Matches "latest" - It returns the commit with the latest timestamp.
2672 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
2673 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
2674 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
2675 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
2676 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
2677 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
2679 (commit_from_revision):
2680 (fetch_commits_between):
2683 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
2684 See tests/api-report-commits.js for examples on how to use this API.
2686 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
2687 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
2688 to optimize this and other JSON APIs.
2690 * public/include/db.php:
2691 (Database::select_or_insert_row):
2692 (Database::update_or_insert_row): Added.
2693 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
2694 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
2696 (Database::select_first_row):
2697 (Database::select_last_row): Added.
2698 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
2699 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
2701 * public/include/report-processor.php:
2702 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
2703 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
2704 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
2707 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
2709 * tests/api-report-commits.js: Added.
2710 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
2713 * tools/pull-svn.py: Added. See above for how to use this script.
2715 (determine_first_revision_to_fetch):
2716 (fetch_revision_from_dasbhoard):
2717 (fetch_commit_and_resolve_author):
2720 (resolve_author_name_from_email):
2723 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
2725 Update Install.md for Mavericks and fix typos
2726 https://bugs.webkit.org/show_bug.cgi?id=137276
2728 Reviewed by Benjamin Poulain.
2730 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
2732 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
2734 Finally, init-database.sql is no longer located inside database directory.
2738 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2740 Report run id's in api/runs.php for the new dashboard UI
2741 https://bugs.webkit.org/show_bug.cgi?id=135813
2743 Reviewed by Andreas Kling.
2745 Include run_id in the generated JSON.
2747 * public/api/runs.php:
2748 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
2751 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2753 Merging platforms mixes baselines and targets into reported data
2754 https://bugs.webkit.org/show_bug.cgi?id=135260
2756 Reviewed by Andreas Kling.
2758 When merging two platforms, move test configurations of a different type (baseline, target)
2759 as well as of different metric (Time, Runs).
2761 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
2762 It's sufficient to detect one such test_runs object.
2764 * public/admin/platforms.php:
2767 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
2769 Merging platforms mixes baselines and targets into reported data
2770 https://bugs.webkit.org/show_bug.cgi?id=135260
2772 Reviewed by Geoffrey Garen.
2774 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
2775 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
2777 * public/admin/platforms.php:
2779 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
2781 Build fix after r171361.
2783 * public/js/helper-classes.js:
2784 (.this.formattedBuildTime):
2786 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
2788 Perf dashboard spends 2s processing JSON data during the page loads
2789 https://bugs.webkit.org/show_bug.cgi?id=135152
2791 Reviewed by Andreas Kling.
2793 In the Apple internal dashboard, we were spending as much as 2 seconds
2794 converting raw JSON data into proper JS objects while loading the dashboard.
2796 This caused the apparent unresponsiveness of the dashboard despite of the fact
2797 charts themselves updated almost instantaneously.
2799 * public/index.html:
2800 * public/js/helper-classes.js:
2801 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
2802 lazily as creating new Date objects and running string replace is expensive.
2803 (TestBuild.formattedTime):
2804 (TestBuild.formattedBuildTime):
2805 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
2806 (PerfTestRuns.addResult): Deleted.
2808 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
2810 Perf dashboard shouldn't show the full git hash
2811 https://bugs.webkit.org/show_bug.cgi?id=135083
2813 Reviewed by Benjamin Poulain.
2815 Detect Git/Mercurial hash by checking the length.
2817 If it's a hash, use the first 8 characters in the label
2818 while retaining the full length to be used in hyperlinks.
2820 * public/js/helper-classes.js:
2821 (.this.formattedRevisions):
2824 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
2826 Add an instruction on how to backup the database.
2827 https://bugs.webkit.org/show_bug.cgi?id=133391
2829 Rubber-stamped by Andreas Kling.
2833 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2835 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
2837 * public/js/helper-classes.js:
2838 (PerfTestRuns.smallerIsBetter):
2840 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2844 * public/common.css:
2846 * public/index.html:
2850 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2852 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
2853 https://bugs.webkit.org/show_bug.cgi?id=131157
2855 Reviewed by Andreas Kling.
2857 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
2858 This allows, for example, adding all metrics such as Arithmetic and Geometric for
2859 a given test suite without also adding its subtests.
2861 * public/index.html:
2865 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2867 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
2868 https://bugs.webkit.org/show_bug.cgi?id=131155
2870 Reviewed by Andreas Kling.
2872 The bug was caused by Chart.attach binding event listeners on plot container on each call.
2873 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
2874 click when attach() has been called even number of times, keeping the tooltip invisible.
2876 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
2877 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
2878 is called for the first time.
2880 * public/index.html:
2882 (Chart..bindPlotEventHandlers):
2884 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2886 WebKitPerfMonitor: Tooltips can be cut off at the top
2887 https://bugs.webkit.org/show_bug.cgi?id=130960
2889 Reviewed by Andreas Kling.
2891 * public/common.css:
2892 (#title): Removed the gradients, box shadows, and border from the header.
2893 (#title h1): Reduce the font size.
2894 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
2895 * public/index.html:
2896 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
2897 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
2898 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
2899 * public/js/helper-classes.js:
2900 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
2901 tooltip extending above y=0.
2903 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2905 WebKitPerfMonitor: Y-axis adjustment is too aggressive
2906 https://bugs.webkit.org/show_bug.cgi?id=130937
2908 Reviewed by Andreas Kling.
2910 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
2911 results. This had two major problems:
2912 1. Two standard deviations can be too small to show the confidence interval for results.
2913 2. Sometimes baseline and target can be more than two standards deviations away.
2915 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
2916 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
2917 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
2918 the margin on each side separately to reduce the empty space on either side.
2920 A more rigorous approach would involve computing least squared value of results with respect to intervals
2921 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
2923 * public/index.html:
2924 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
2925 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
2926 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
2927 We wouldn't see the difference between measured values versus baseline and target values otherwise.
2928 * public/js/helper-classes.js:
2929 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
2930 interval delta cannot be computed.
2931 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
2932 within the given interval.
2933 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
2934 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
2935 (PerfTestRuns..unscaledMeansForAllResults):
2936 (PerfTestRuns.min): Take the confidence interval delta into account.
2937 (PerfTestRuns.max): Ditto.
2938 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
2939 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
2941 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
2943 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
2945 Some CSS tweaks after r166477 and r166479,
2947 * public/index.html:
2949 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2951 WebKitPerfMonitor: Sometimes text inside panes overlap
2952 https://bugs.webkit.org/show_bug.cgi?id=130956
2954 Reviewed by Gyuyoung Kim.
2956 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
2957 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
2958 reduces the total height of the pane and fits more information per screen capita on the dashboard.
2960 * public/index.html: Updated and added a bunch of CSS rules for the new look.
2961 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
2962 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
2963 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
2964 of the build info shown in a chart pane and a tooltip.
2965 (Chart): Made .status a table.
2966 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
2967 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
2968 now that status.text no longer contains it.
2969 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
2971 * public/js/helper-classes.js:
2972 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
2973 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
2974 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
2975 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
2976 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
2977 capital letter; e.g. "MB" instead of "M B".
2979 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2981 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
2982 https://bugs.webkit.org/show_bug.cgi?id=130957
2984 Reviewed by Gyuyoung Kim.
2986 Moved the slider into the header. Also reduced the spacing between the header and platform names.
2987 This reclaims 50px × width of the screen real estate.
2989 * public/common.css:
2990 (#title): Reduced the space below the header from 20px to 10px.
2991 * public/index.html:
2992 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
2993 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
2994 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
2995 real estate between the header and the platform names.
2997 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2999 Update the install guidelines for perf.webkit.org
3000 https://bugs.webkit.org/show_bug.cgi?id=129895
3002 Reviewed by Ryosuke Niwa.
3004 The current install guideline for perf.webkit.org discourages the use of the installed
3005 Server application. I've actualized the documentation for Mavericks, and modified the
3006 guideline to include the instructions for Server.app also.
3010 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
3012 Update perf.webkit.org json example
3013 https://bugs.webkit.org/show_bug.cgi?id=129907
3015 Reviewed by Andreas Kling.
3017 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
3021 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
3023 Merge database-common.js and utility.js into run-tests.js.
3025 Reviewed by Matthew Hanson.
3027 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
3028 Also moved init-database.sql out of the database directory and removed the directory entirely.
3030 * database: Removed.
3031 * database/database-common.js: Removed.
3032 * database/utility.js: Removed.
3033 * init-database.sql: Moved from database/init-database.sql.
3035 (connect): Moved from database-common.js.
3036 (pathToDatabseSQL): Extracted from pathToLocalScript.
3037 (pathToTests): Moved from database-common.js.
3040 (SerializedTaskQueue): Ditto.
3042 (initializeDatabase):
3043 (TestEnvironment.it):
3044 (TestEnvironment.queryAndFetchAll):
3047 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
3049 Remove the dependency on node.js from the production code.
3051 Reviewed by Ricky Mondello.
3053 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
3055 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
3056 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
3057 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
3058 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
3059 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
3061 Also removed the js files that are no longer used.
3063 * config.json: Moved from database/config.json.
3064 * database/aggregate.js: Removed. No longer used.
3065 * database/database-common.js: Removed unused functions, and updated the path to config.json.
3066 * database/process-jobs.js: Removed. No longer used.
3067 * database/sample-data.sql: Removed. We have a much better corpus of data now.
3068 * database/schema.graffle: Removed. It's completely obsolete.
3069 * public/include/db.php: Updated the path to config.json.
3070 * public/include/evaluator.js: Removed.
3072 * public/include/report-processor.php:
3073 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
3074 storing values into $expressions and calling evaluate_expressions_by_node.
3075 (TestRunsGenerator::aggregate_values): Added.
3076 (TestRunsGenerator::compute_caches): Directly compute the caches.
3078 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
3080 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
3082 * public/admin/platforms.php:
3083 * public/include/db.php:
3085 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
3087 Zoomed y-axis view is ununsable when the last result is an outlier.
3089 Reviewed by Stephanie Lewis.
3091 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
3092 the last result so that the graph looks sane if the last result was an outlier. However, always show
3093 the last result's mean even if it was an outlier.
3095 * public/index.html:
3096 * public/js/helper-classes.js:
3097 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
3098 Also added the ability to cache the unscaled means to avoid recomputation.
3099 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
3100 (PerfTestRuns.max): Ditto.
3101 (PerfTestRuns.sampleStandardDeviation): Ditto.
3102 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
3104 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
3108 * public/admin/tests.php:
3109 * public/js/helper-classes.js:
3111 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
3113 Use two standard deviations instead as I mentioned in the mailing list.
3115 * public/index.html:
3117 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
3119 The performance dashboard erroneously shows upward arrow for combined metrics.
3121 A single outlier can ruin the zoomed y-axis view.
3123 Rubber-stamped by Antti Koivisto.
3125 * public/index.html:
3126 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
3127 from the latest results' mean.
3128 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
3129 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
3130 (Chart.toggleYAxis):
3131 * public/js/helper-classes.js:
3132 (PerfTestRuns.sampleStandardDeviation): Added.
3133 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
3135 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
3137 Don't include the confidence interval when computing the y-axis.
3139 Rubber-stamped by Simon Fraser.
3141 * public/js/helper-classes.js:
3145 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
3147 Tiny CSS tweak for tooltips.
3149 * public/index.html:
3151 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
3153 Remove the erroneously repeated code.
3155 * public/admin/test-configurations.php:
3157 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
3159 <rdar://problem/15704893> perf dashboard should show baseline numbers
3161 Reviewed by Stephanie Lewis.
3163 * public/admin/bug-trackers.php: