1 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
3 Loading the perf dashboard takes multiple seconds
4 https://bugs.webkit.org/show_bug.cgi?id=141860
6 Reviewed by Andreas Kling.
8 This patch introduces the caches of JSON files returned by /api/ in /data/ directory. It also records
9 the last time test_runs rows associated with the requested platforms and metrics are inserted, updated,
10 or removed in the caches as well as the manifest JSON files ("last modified time"). Because the manifest
11 is regenerated each time a new test result is reported, the front end can compare last modified time in
12 the manifest file with that in a /api/runs JSON cache to detect the stale-ness.
14 More concretely, the front end first optimistically fetches the JSON in /data/. If the cache doesn't exit
15 or the last modified time in the cache doesn't match with that in the manifest file, it would fetch it
16 again via /api/runs. In the case the cache did exist, we render the charts based on the cache meanwhile.
17 This dramatically reduces the perceived latency for the page load since charts are drawn immediately using
18 the cache and we would only re-render the charts as new up-to-date JSON comes in.
20 This patch also changes the format of runs JSONs by pushing the exiting properties into 'configurations'
21 and adding 'lastModified' and 'elapsedTime' at the top level.
23 * init-database.sql: Added config_runs_last_modified to test_configurations table as well as a trigger to
24 auto-update this column upon changes to test_runs table.
26 * public/admin/test-configurations.php:
27 (add_run): Regenerate the manifest file to invalidate the /api/runs JSON cache.
30 * public/api/runs.php:
31 (main): Fetch all columns of test_configurations table including config_runs_last_modified. Also generate
32 the cache in /data/ directory.
33 (RunsGenerator::__construct): Compute the last modified time for this (platform, metric) pair.
34 (RunsGenerator::results): Put the old content in 'configurations' property and include 'lastModified' and
35 'elapsedTime' properties. 'elapsedTime' is added for debugging purposes.
36 (RunsGenerator::add_runs):
37 (RunsGenerator::parse_revisions_array):
39 * public/include/db.php:
41 (generate_data_file): Added based on ManifestGenerator::store.
42 (Database::to_js_time): Extracted from RunsGenerator::add_runs to share code.
44 * public/include/json-header.php:
45 (echo_success): Renamed from success_json. Return the serialized JSON instead of echo'ing it so that we can
46 generate caches in /api/runs/.
49 * public/include/manifest.php:
50 (ManifestGenerator::generate): Added 'elapsedTime' property for the time taken to generate the manifest.
51 It seems like we're generating it in 200-300ms for now so that's good.
52 (ManifestGenerator::store): Uses generate_data_file.
53 (ManifestGenerator::platforms): Added 'lastModified' array to each platform entry. This array contains the
54 last modified time for each (platform, metric) pair.
57 (fetchTest): Updated per the format change in runs JSON.
60 (App.Pane._fetch): Fetch the cached JSON first. Refetch the uncached version if instructed as such.
61 (App.Pane._updateChartData): Extracted from App.Pane._fetch.
62 (App.Pane._handleFetchErrors): Ditto.
65 (RunsData.fetchRuns): Takes the fourth argument indicating whether we should fetch the cached version or not.
66 The cached JSON is located in /data/ with the same filename. When fetching a cached JSON results in 404,
67 fulfill the promise with null as the result instead of rejecting it. The only client of this function which
68 sets useCache to true is App.Manifest.fetchRunsWithPlatformAndMetric, and it handles this special case.
70 * public/v2/manifest.js:
71 (App.DateArrayTransform): Added. Handles the array of last modified dates in platform objects.
72 (App.Platform.lastModifiedTimeForMetric): Added. Returns the last modified date in the manifest JSON.
73 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes "useCache" like RunsData.fetchRuns. Set shouldRefetch
74 to true if response is null (the cache didn't exit) or the cache is out-of-date.
75 (App.Manifest._formatFetchedData): Extracted from App.Manifest.fetchRunsWithPlatformAndMetric.
78 (initializeDatabase): Avoid splitting function definitions in the middle.
80 * tests/api-report.js: Added tests to verify that reporting new test results updates the last modified time
81 in test_configurations.
83 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
85 REGRESSION(r180333): Analysis tasks can't be associated with bugs
86 https://bugs.webkit.org/show_bug.cgi?id=141858
88 Reviewed by Andreas Kling.
90 Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
91 of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
93 * public/v2/chart-pane.css:
94 * public/v2/index.html:
96 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
98 Selecting revisions for A/B testing is hard
99 https://bugs.webkit.org/show_bug.cgi?id=141824
101 Reviewed by Andreas Kling.
103 Update the revisions used in A/B testing based on the selection in the overview chart. This allows users to
104 intuitively select revisions based on points shown in the chart. Removed the old select elements used to
105 select A/B testing points manually.
107 Also renamed 'testSets' to 'configurations', 'roots' to 'rootConfigurations', and 'revisions' in each root's
108 sets to 'options' for clarity.
110 * public/v2/app.css: Reorganized style rules.
113 (App.AnalysisTaskController):
114 (App.AnalysisTaskController._taskUpdated): Merged updateTestGroupPanes.
115 (App.AnalysisTaskController._chartDataChanged): Renamed from paneDomain. It's now an observer instead of
116 a property, which sets 'overviewDomain' property as well as other properties.
117 (App.AnalysisTaskController.updateRootConfigurations): Renamed from updateRoots.
118 (App.AnalysisTaskController._updateRootsBySelectedPoints): Added. Select roots based on the selected points
119 in the overview chart.
121 * public/v2/chart-pane.css: Added arrows next to the configuration names (e.g. 'A') to indicate whether
122 individual build requests / test results are shown or not.
124 * public/v2/index.html: Removed the select element per configuration column. Also moved the select element
125 for the number of runs as it doesn't belong in the same table as the one that lists repositories and roots.
127 2015-02-20 Ryosuke Niwa <rniwa@webkit.org>
129 Unreviewed test fixes after r179037, r179591, and r179763.
131 * tests/admin-regenerate-manifest.js:
132 * tests/admin-reprocess-report.js:
134 2015-02-19 Ryosuke Niwa <rniwa@webkit.org>
136 Relationship between A/B testing results are unclear
137 https://bugs.webkit.org/show_bug.cgi?id=141810
139 Reviewed by Andreas Kling.
141 Show a "reference chart" indicating which two points have been tested in each test group pane.
143 Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
144 and the domain used in this chart to show charts in each test group.
146 Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.
148 * public/v2/analysis.js:
149 (App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
150 since this is the results of A/B testing results, not the data for charts shown next to them.
152 * public/v2/app.css: Added CSS rules for reference charts.
155 (App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
156 (App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
157 (App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
158 identically matches root sets. If one of configuration used a set of revisions for which no measurement
159 was made in the original chart, don't show the reference chart as that would be misleading / confusing.
160 (App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
161 (App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
162 In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".
165 (Measurement.prototype.revisionForRepository): Added.
166 (Measurement.prototype.commitTimeForRepository): Cleanup.
167 (TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.
169 * public/v2/index.html: Added the reference chart. Streamlined the status label for each build request
170 by including the build number in the title attribute instead of in the markup.
172 * public/v2/interactive-chart.js:
173 (App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
174 (App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
175 (App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.
177 2015-02-18 Ryosuke Niwa <rniwa@webkit.org>
179 Analysis task pages are unusable
180 https://bugs.webkit.org/show_bug.cgi?id=141786
182 Reviewed by Andreas Kling.
184 This patch makes following improvements to analysis task pages:
185 1. Making the main chart interactive. This change required the use of App.Pane as well as moving the code to
186 compute the data for the details pane from PaneController.
187 2. Moving the form to add a new test group to the top of test groups instead of the bottom of them.
188 3. Grouping the build requests in each test group by root sets instead of the order by which they were ran.
189 This change required the creation of App.TestGroupPane as well as its methods.
190 4. Show a box plot for each root set configuration as well as each build request. This change required
191 App.BoxPlotComponent.
192 5. Show revisions of each repository (e.g. WebKit) for each root set and build request.
194 * public/api/build-requests.php:
195 (main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.
197 * public/api/test-groups.php:
198 (main): Include root sets and roots in the response.
201 * public/include/build-requests-fetcher.php:
202 (BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
203 (BuildRequestsFetcher::root_sets): Added.
204 (BuildRequestsFetcher::roots): Added.
205 (BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
206 true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
207 tools/sync-with-buildbot.py can't convert repository names to their ids.
209 * public/v2/analysis.js:
211 (App.RootSet): Added.
212 (App.RootSet.revisionForRepository): Added.
213 (App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
214 response at /api/test-groups will include them.
215 (App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
216 _createConfigurationSummary.
217 (App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
218 (App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.
220 * public/v2/app.css: Updated style rules for analysis task pages.
223 (App.Pane): This class is now used in analysis task pages to make the main chart interactive.
224 (App.Pane._updateDetails): Moved from App.PaneController.
226 (App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.
228 (App.AnalysisTaskController): Added 'details'.
229 (App.AnalysisTaskController._taskUpdated):
230 (App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
231 (App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
232 (App.AnalysisTaskController.actions.toggleShowRequestList): Added.
234 (App.TestGroupPane): Added.
235 (App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
236 (App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
237 of all repositories appearing in root sets and builds associated with A/B testing results.
238 (App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
239 (App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
240 use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
241 build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
242 is a union of revisions in the root set and the first build request in the group. We null-out revision info
243 for a build request if it is identical to the one in the summary. The range of values is expanded as needed
244 by the values in the group as well as 95% percentile confidence interval.
246 (App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
247 (App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
248 the mean and the confidence interval.
249 (App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
250 (App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
251 calls _updateBars to update the rects.
253 * public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.
256 (Measurement.prototype.formattedRevisions):
257 (Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
258 called in _createConfigurationSummary.
260 * public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test
261 group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
262 Also made the fetching of chartData no longer block showing of test groups.
264 * public/v2/interactive-chart.js:
265 (App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
266 (App.InteractiveChartComponent._domainChanged): Ditto.
267 (App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.
269 * public/v2/js/statistics.js:
270 (Statistics.min): Added.
271 (Statistics.max): Added.
273 * public/v2/manifest.js:
274 (App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.
276 2015-02-14 Ryosuke Niwa <rniwa@webkit.org>
278 Build URL on new perf dashboard doesn't resolve $builderName
279 https://bugs.webkit.org/show_bug.cgi?id=141583
281 Reviewed by Darin Adler.
283 Support $builderName in the build URL template.
285 * public/js/helper-classes.js:
286 (TestBuild.buildUrl): Replaced $builderName with the builder name.
288 * public/v2/manifest.js:
289 (App.Metric.fullName): Fixed the typo. We need &ni, not &in.
290 (App.BuilderurlFromBuildNumber): Replaced $builderName with the builder name.
292 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
294 Unreviewed build fix after r179591.
296 * public/api/commits.php:
298 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
300 The status of a A/B testing request always eventually becomes "Failed"
301 https://bugs.webkit.org/show_bug.cgi?id=141523
303 Reviewed by Andreas Kling.
305 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
306 'failedIfNotCompleted' was sent by the buildbot sync'er.
308 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
310 * public/api/build-requests.php:
313 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
315 Unreviewed, remove empty directories.
317 * public/data: Removed.
319 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
321 Perf dashboard should show the results of A/B testing
322 https://bugs.webkit.org/show_bug.cgi?id=141500
324 Reviewed by Chris Dumez.
326 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
327 analysis task page to fetch results for each test group.
329 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
330 can use the formatter.
332 * public/api/runs.php:
333 (fetch_runs_for_config_and_test_group): Added.
334 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
335 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
336 use RunsGenerator to format results.
337 (RunsGenerator): Added.
338 (RunsGenerator::__construct): Added.
339 (RunsGenerator::add_runs): Added.
340 (RunsGenerator::format_run): Moved.
341 (RunsGenerator::parse_revisions_array): Moved.
343 * public/v2/analysis.js:
344 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
345 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
346 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
347 configuration associated with this build request such as "A" and "B".
348 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
349 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
350 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
354 (App.Pane._fetch): Set chartData directly here.
355 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
356 now that it's done in App.Pane._fetch.
357 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
360 (Measurement.prototype.buildId): Added.
361 (TimeSeries.prototype.findPointByBuild): Added.
363 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
364 url is not an Ember routed path.
366 * public/v2/manifest.js:
367 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
368 App.createChartData here so that App.BuildRequest can use the formatter
370 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
372 v2 UI should adjust the number of ticks on dashboards based on screen size
373 https://bugs.webkit.org/show_bug.cgi?id=141502
375 Reviewed by Chris Dumez.
377 * public/v2/interactive-chart.js:
378 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
381 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
383 New perf dashboard shows too much space around interesting data points
384 https://bugs.webkit.org/show_bug.cgi?id=141487
386 Reviewed by Chris Dumez.
388 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
389 show the current time series excluding points in the series outside the moving average envelope.
392 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
393 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
394 time series if the point lies outside the moving average envelope. Don't expose the moving average or
395 the envelope computed for this purpose if they're not set by the user.
398 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
399 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
401 * public/v2/interactive-chart.js:
402 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
403 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
404 to deal with showFullYAxis here.
405 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
406 argument instead of directly inspecting showFullYAxis.
408 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
410 New perf dashboard shouldn't always show outliners
411 https://bugs.webkit.org/show_bug.cgi?id=141445
413 Reviewed by Chris Dumez.
415 Use the simple moving average with an average difference envelope to compute the y-axis range to show
416 to avoid expanding it spuriously to show one off outlier.
419 (App.Pane): Don't show the full y-axis range by default.
420 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
421 one is not specified by the user but without showing them in the charts.
422 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
423 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
425 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
426 (App.ChartsController._serializePaneList): Ditto.
428 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
430 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
432 * public/v2/interactive-chart.js:
433 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
434 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
435 if they are not specified by the user (i.e. only used to adjust y-axis range).
436 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
437 x-axis domain remained the same. Without this change, the charts would never redraw.
438 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
439 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
440 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
442 * public/v2/js/statistics.js:
443 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
445 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
447 Unreviewed build fix.
450 (set get App.Pane.Ember.Object.extend):
452 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
454 New perf dashboard should have the ability to overlay moving average with an envelope
455 https://bugs.webkit.org/show_bug.cgi?id=141438
457 Reviewed by Andreas Kling.
459 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
461 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
462 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
463 n, backward window size, and m, forward window size, as an argument.
465 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
466 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
468 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
469 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
472 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
473 between each x_i and x̄_i.
475 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
476 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
477 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
478 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
481 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
482 The configuration of the currently chosen strategies is saved in the query string for convenience.
484 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
486 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
489 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
490 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
491 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
492 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
493 from the query string via ChartsController.
494 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
495 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
496 (App.Pane._executeStrategy): Added.
497 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
499 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
500 selections, and added two new arguments for the moving average and the enveloping configurations.
501 (App.ChartsController._serializePaneList): Ditto.
502 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
503 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
504 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
505 (App.PaneController.actions.toggleStatPane): Added.
507 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
508 current (as opposed to baseline and target) time series for when it's the most foreground graph without
509 moving average and its envelope overlapping on top of it.
511 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
513 * public/v2/interactive-chart.js:
514 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
515 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
516 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
517 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
518 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
519 but don't bother removing individual paths and circles. Added the code to show the moving average time
520 series when there is one. Also add "foreground" class on SVG elements for the current time series when
521 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
522 series when "foreground" is not set.
523 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
524 account when computing the y-axis range.
525 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
527 * public/v2/js/statistics.js:
528 (Statistics.MovingAverageStrategies): Added.
529 (Statistics.EnvelopingStrategies): Added.
531 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
533 The delta value in the chart pane sometimes doens't show '+' for a positive delta
534 https://bugs.webkit.org/show_bug.cgi?id=141340
536 Reviewed by Andreas Kling.
538 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
539 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
542 (App.Pane.computeStatus):
543 (App.createChartData):
545 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
547 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
550 (App.PaneController._updateDetails):
552 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
554 Unreviewed. Commit the forgotten change.
556 * public/include/manifest.php:
558 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
560 New perf dashboard should have multiple dashboard pages
561 https://bugs.webkit.org/show_bug.cgi?id=141339
563 Reviewed by Chris Dumez.
565 Added the support for multiple dashboard pages. Also added the status of the latest data point.
566 e.g. "5% better than target"
568 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
569 Also hid the border lines around charts on the dashboard page for a cleaner look.
572 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
573 (App.IndexRoute.beforeModel): Added.
574 (App.DashboardRoute): Added.
575 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
576 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
577 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
578 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
579 (App.DashboardController): Renamed from App.IndexController.
580 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
581 and "defaultDashboard" as these are taken care of by newly added routers.
582 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
583 now done in actions.toggleEditMode.
584 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
585 an existing dashboard.
587 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
588 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
589 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
590 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
592 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
594 (App.PaneController._updateDetails): Updated per changes to computeStatus.
596 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
599 (TimeSeries.prototype.lastPoint): Added.
601 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
602 on the dashboard, and enumerate all predefined dashboards.
604 * public/v2/interactive-chart.js:
605 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
606 for the dashboard page.
608 * public/v2/manifest.js:
609 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
610 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
611 IDs are generated for each dashboard for forward compatibility.
613 (App.Manifest.dashboardByName): Added.
614 (App.Manifest.defaultDashboardName): Added.
615 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
617 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
619 Move commits viewer to the end of details view
620 https://bugs.webkit.org/show_bug.cgi?id=141315
622 Rubber-stamped by Andreas Kling.
624 Show the difference instead of the old value per kling's request.
627 (App.PaneController._updateDetails):
628 * public/v2/index.html:
630 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
632 Move commits viewer to the end of details view
633 https://bugs.webkit.org/show_bug.cgi?id=141315
635 Reviewed by Andreas Kling.
637 Improved the way list of commits are shown per kling's request.
640 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
642 * public/v2/chart-pane.css: Updated the style for the commits viewer.
644 * public/v2/commits-viewer.js:
645 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
646 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
648 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
649 moved the commits viewers out of the details tables so that they don't interleave revision data.
651 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
653 New perf dashboard should compare results to baseline and target
654 https://bugs.webkit.org/show_bug.cgi?id=141286
656 Reviewed by Chris Dumez.
658 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
659 Also use d3.format to format the selected value to show four significant figures.
662 (App.Pane.searchCommit):
663 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
664 to compute the status text without having to recreate them.
665 (App.createChartData): Added.
666 (App.PaneController._updateDetails): Use 3d.format on current and old values.
667 (App.PaneController._computeStatus): Added. Computes the status text.
668 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
669 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
670 format the values using chartData.formatter.
672 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
673 the baseline and in blue if it's better than the target.
676 (TimeSeries.prototype.findPointAfterTime): Added.
678 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
679 the bug that we were not showing the old value's unit.
681 * public/v2/interactive-chart.js:
682 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
683 the code to show the baseline and the target lines.
685 * public/v2/manifest.js:
686 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
688 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
690 Unreviewed build fix.
693 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
695 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
697 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
698 https://bugs.webkit.org/show_bug.cgi?id=141280
700 Reviewed by Chris Dumez.
702 Fixed the bug by passing in "since" as a query parameter to the charts page.
704 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
706 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
708 (App.IndexController): Changed the default number of days from one month to one week.
709 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
710 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
712 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
714 New perf dashboard erroneously clears zoom when poping history items
715 https://bugs.webkit.org/show_bug.cgi?id=141278
717 Reviewed by Chris Dumez.
719 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
721 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
722 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
725 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
726 shown in the main plot.
727 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
728 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
730 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
732 New perf dashboard shows null as the aggregator name if no aggregation is done
733 https://bugs.webkit.org/show_bug.cgi?id=141256
735 Reviewed by Chris Dumez.
737 Don't show the aggregator name if there isn't one.
739 * public/v2/manifest.js:
742 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
744 Unreviewed build fix after r179611.
746 * public/v2/interactive-chart.js:
748 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
750 Perf dashboard doesn’t show the right unit for Safari UI tests
751 https://bugs.webkit.org/show_bug.cgi?id=141238
753 Reviewed by Darin Adler.
755 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
756 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
757 between metrics and their units.
759 * public/js/helper-classes.js:
760 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
761 * public/v2/manifest.js:
762 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
763 * public/v2/interactive-chart.js:
764 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
765 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
767 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
769 Interactive chart component provides two duplicate API for highlighting points
770 https://bugs.webkit.org/show_bug.cgi?id=141234
772 Reviewed by Chris Dumez.
774 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
775 on the main charts page and markedPoints to show the two end points in the analysis task page.
777 This patch merges markedPoints into highlightedItems.
780 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
781 * public/v2/chart-pane.css:
782 * public/v2/index.html: Ditto.
783 * public/v2/interactive-chart.js:
784 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
785 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
786 items if highlightedItems was set before the initial layout.
787 (App.InteractiveChartComponent._relayoutDataAndAxes):
788 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
789 vertical lines, just set cx and cy as done for other "dots".
790 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
791 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
792 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
793 set the radius of highlight circles here.
795 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
797 Don’t use repository names as id’s.
798 https://bugs.webkit.org/show_bug.cgi?id=141226
800 Reviewed by Chris Dumez.
802 Not using repository names as their id's reduces the need to fetch the entire repositories table.
803 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
805 * Websites/perf.webkit.org/public/api/runs.php:
806 (parse_revisions_array): No longer uses $repository_id_to_name.
807 (main): No longer populates $repository_id_to_name.
809 * Websites/perf.webkit.org/public/api/triggerables.php:
810 (main): Don't resolve repository names.
812 * Websites/perf.webkit.org/public/include/manifest.php:
813 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
814 (ManifestGenerator::bug_trackers): Don't resolve repository names.
816 * Websites/perf.webkit.org/public/js/helper-classes.js:
817 (TestBuild): Renamed repositoryName to repositoryId.
818 (TestBuild.revision): Ditto.
819 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
820 since this is the text shown to human.
822 * Websites/perf.webkit.org/public/v2/app.js:
823 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
824 (App.PaneController._updateDetails): Ditto.
825 (App.AnalysisTaskController.updateRoots): Ditto.
827 * Websites/perf.webkit.org/public/v2/data.js:
828 (Measurement): Ditto.
829 (Measurement.prototype.commitTimeForRepository): Ditto.
830 (Measurement.prototype.formattedRevisions): Ditto.
832 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
833 select element's label and value respectively.
835 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
837 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
839 * public/api/runs.php:
841 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
843 /api/runs.php should have main function
844 https://bugs.webkit.org/show_bug.cgi?id=141220
846 Reviewed by Benjamin Poulain.
848 Wrapped the code inside main function for clarity.
850 * public/api/runs.php:
852 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
854 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
856 * tools/sync-with-buildbot.py:
857 (find_request_updates):
859 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
861 Perf dashboard always assigns the result of A/B testing with build request 1
862 https://bugs.webkit.org/show_bug.cgi?id=140382
864 Reviewed by Darin Adler.
866 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
867 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
869 Also fixed a typo as well as a bug that reports were never associated with builds.
871 * public/include/report-processor.php:
872 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
873 instead of the first non-null value.
874 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
875 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
877 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
879 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
881 * public/admin/tests.php:
883 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
885 Unreviewed build fix. Removed the stale code.
887 * public/admin/triggerables.php:
889 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
891 Perf dashboard should have the ability to post A/B testing builds
892 https://bugs.webkit.org/show_bug.cgi?id=140317
894 Rubber-stamped by Simon Fraser.
896 This patch adds the support for triggering A/B testing from the perf dashboard.
898 We add a few new tables to the database. "build_triggerables", which represents a set of builders
899 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
900 of repositories for which an arbitrary revision can be specified for A/B testing.
901 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
902 "roots" table which specifies the revision used in a given root set in each repository.
904 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
905 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
906 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
907 to build_requests table. Also made each test group's name unique in a given analysis task as it
908 would be confusing to have multiple test groups of the same name.
910 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
912 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
913 for which a specific revision can be set in an A/B testing on a given triggerable.
915 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
916 triggerable. Also updates the status' and the status urls of specified build requests when
917 buildRequestUpdates is provided in the raw POST data.
920 * public/api/runs.php:
921 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
922 results of an A/B testing.
924 * public/api/test-groups.php:
925 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
927 * public/api/triggerables.php: Added.
928 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
930 * public/include/admin-header.php:
932 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
933 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
934 and root sets used in those requests.D
935 (BuildRequestsFetcher::__construct):
936 (BuildRequestsFetcher::fetch_for_task):
937 (BuildRequestsFetcher::fetch_for_group):
938 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
939 (BuildRequestsFetcher::has_results):
940 (BuildRequestsFetcher::results):
941 (BuildRequestsFetcher::results_with_resolved_ids):
942 (BuildRequestsFetcher::results_internal):
943 (BuildRequestsFetcher::root_sets):
944 (BuildRequestsFetcher::fetch_roots_for_set):
946 * public/include/db.php:
947 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
948 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
949 table since it only has the primary key, id, column.
950 (Database::select_or_insert_row):
951 (Database::update_or_insert_row):
952 (Database::update_row): Added.
953 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
954 should be inserted when no row matches the specified criteria. This is used while updating
955 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
956 new build requests in that API.
957 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
958 This is used in public/api/triggerables.php when no analysis task is specified.
960 * public/include/json-header.php:
961 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
962 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
963 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
964 find the closest ancestor with a triggerable.
966 * public/include/report-processor.php:
967 (ReportProcessor::process):
968 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
969 if jobId or buildRequest is specified.
971 * public/include/test-name-resolver.php:
972 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
973 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
974 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
977 * public/include/test-path-resolver.php: Added.
978 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
979 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
980 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
981 in order to compute full test metric names.
982 (TestPathResolver::__construct):
983 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
984 the highest (a test without a parent).
985 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
986 the highest ancestor to the test itself.
987 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
989 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
991 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
992 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
993 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
994 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
996 * public/v2/analysis.js:
997 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
998 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
999 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
1000 (App.TestGroup.create): Added. Creates a new A/B testing group.
1001 (App.Triggerable): Added.
1002 (App.TriggerableAdapter): Added.
1003 (App.TriggerableAdapter.buildURL): Added.
1004 (App.BuildRequest.testGroup): Renamed from group.
1005 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
1006 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
1007 in this build request.
1008 (App.BuildRequest.status): Added.
1009 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
1010 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
1013 (App.AnalysisTaskController.testGroups): Added.
1014 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
1015 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
1016 but an observer that updates "roots" property. Filter out the repositories that are not accepted
1017 by the associated triggerable as they will be ignored.
1018 (App.AnalysisTaskController.actions.createTestGroup): Added.
1020 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
1022 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
1023 the status of those builds to the perf dashboard. A similar script can be written to support
1024 other continuous builds systems.
1025 (main): Fetches the list of pending builds as well as currently running or completed builds from
1026 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
1027 a single new build on each builder with no pending builds, and marks the set of open build requests
1028 that have been scheduled to run on the buildbot but not found in the first step as stale.
1029 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
1032 "platform": "mac-mavericks",
1033 "test": ["Parser", "html5-full-render.html"],
1034 "builder": "Trunk Syrah Production Perf AB Tests",
1036 "forcescheduler": "force-mac-mavericks-release-perf",
1037 "webkit_revision": "$WebKit",
1038 "jobid": "$buildRequest"
1043 (find_request_updates): Return a list of build request status updates to make based on the pending
1044 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
1045 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
1046 if the build request had not been completed. This is necessary because a failed build will not
1047 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
1048 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
1049 of open requests the perf dashboard has.
1050 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
1051 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
1052 or human canceling a build may trigger such a state.
1053 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
1054 replacing repository names with their revisions and buildRequest with the build request id.
1055 (config_for_request): Finds a builder for the test and the platform of a build request.
1056 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
1057 (property_value_from_build): Returns the value of a specific property in a buildbot build.
1058 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
1060 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1062 Cache-control should be set only on api/runs
1063 https://bugs.webkit.org/show_bug.cgi?id=140312
1065 Reviewed by Andreas Kling.
1067 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
1068 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
1069 just set cache-control there instead of json-header.php which is used by other JSON APIs.
1071 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
1073 * public/api/analysis-tasks.php:
1074 * public/api/runs.php: Set the cache control headers.
1075 * public/api/test-groups.php:
1076 * public/include/db.php: Set the default timezone to UTC.
1077 * public/include/json-header.php: Don't set the cache control headers.
1079 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
1081 api/report-commit should authenticate with a slave name and password
1082 https://bugs.webkit.org/show_bug.cgi?id=140308
1084 Reviewed by Benjamin Poulain.
1086 Use a slave name and a password to authenticate new commit reports.
1088 * public/api/report-commits.php:
1090 * public/include/json-header.php:
1091 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
1092 a slave name and a password instead of a builder name and a password.
1093 * tests/api-report-commits.js: Updated tests.
1094 * tools/pull-svn.py:
1095 (main): Renamed variables.
1096 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
1098 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
1100 Perf dashboard should support authentication via a slave password
1101 https://bugs.webkit.org/show_bug.cgi?id=139837
1103 Reviewed by Andreas Kling.
1105 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
1106 having to add multiple builders with the same password when a single build slave is shared among them.
1108 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
1110 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
1112 * public/admin/build-slaves.php: Added.
1114 * public/admin/builders.php: Added the support for updating passwords.
1116 * public/include/admin-header.php:
1117 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
1118 being retrieved from $_POST.
1119 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
1120 the raw may not exist (e.g. new_password).
1121 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
1122 control here when this flag evaluates to TRUE.
1124 * public/include/report-processor.php:
1125 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
1126 values are present in the report. In addition, try authenticating builderName with slavePassword if
1127 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
1128 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
1129 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
1131 (ReportProcessor::store_report): Store the slave ID with the report.
1132 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
1133 the matching build is different from what's being reported.
1135 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
1138 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
1140 New perf dashboard should not duplicate author information in each commit
1141 https://bugs.webkit.org/show_bug.cgi?id=139756
1143 Reviewed by Darin Adler.
1145 Instead of each commit having author name and email, make it reference a newly added committers table.
1146 Also replace "email" by "account" since some repositories don't use emails as account names.
1148 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
1149 which only contains as many rows as there are accounts in each repository, instead of commits table
1150 which contains every commit ever happened in each repository.
1152 To migrate an existing database into match the new schema, run:
1156 INSERT INTO committers (committer_repository, committer_name, committer_email)
1157 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
1158 FROM commits WHERE commit_author_email IS NOT NULL);
1160 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
1162 UPDATE commits SET commit_committer = committer_id FROM committers
1163 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
1165 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
1166 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
1170 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
1171 reference to committers. Also added the missing drop table statements.
1173 * public/api/commits.php:
1174 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
1175 an array here instead of doing it in format_commit.
1176 (fetch_commits_between): Updated queries to JOIN commits with committers.
1177 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
1178 is now done in main.
1180 * public/api/report-commits.php:
1181 (main): Store the reported committer information or update the existing entry if there is one.
1183 * tests/admin-regenerate-manifest.js: Fixed tests.
1185 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
1187 * tools/pull-svn.py: Renamed email to account.
1189 (fetch_commit_and_resolve_author):
1191 (resolve_author_name_from_account):
1192 (resolve_author_name_from_email): Deleted.
1194 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
1196 Unreviewed build fix.
1198 * public/v2/index.html: Include js files we extracted in r177424.
1200 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1202 Unreviewed. Adding the forgotten svnprop.
1204 * tools/pull-svn.py: Added property svn:executable.
1206 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
1208 Split InteractiveChartComponent and CommitsViewerComponent into separate files
1209 https://bugs.webkit.org/show_bug.cgi?id=139716
1211 Rubber-stamped by Benjamin Poulain.
1213 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
1214 and interactive-chart.js respectively since app.js has gotten really large.
1217 * public/v2/commits-viewer.js: Added.
1218 * public/v2/interactive-chart.js: Added.
1220 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
1222 New perf dashboard's chart UI is buggy
1223 https://bugs.webkit.org/show_bug.cgi?id=139214
1225 Reviewed by Chris Dumez.
1227 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
1229 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
1230 component. This is not how Ember.js components should interact to begin with. The component now exposes
1231 selectedPoints and always updates selection instead of sharedSelection.
1234 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
1235 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
1236 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
1237 and end time should be completely determined by "since" and the present time.
1238 (App.ChartsController._startTimeChanged): Ditto.
1239 (App.ChartsController._scheduleQueryStringUpdate):
1240 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
1242 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
1244 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
1245 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
1246 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
1247 observes the changes to selectedPoints property as it gets updated by the main chart.
1248 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
1249 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
1251 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
1252 when domain arrays aren't identical. This was causing a subtle race with other logic.
1253 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
1254 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
1255 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
1256 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
1257 see if those two points correspond to a range or a single data point. Rewrote all that logic by
1258 directly observing selectedPoints and currentItem properties instead of taking points and relying on
1259 an instance variable, which was a terrible API.
1260 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
1261 when the main plot has a selected range, we don't have to check this._hasRange anymore.
1263 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
1264 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
1265 (App.InteractiveChartComponent._updateSelection):
1266 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
1267 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
1268 selectedPoints property.
1270 (App.AnalysisTaskController._fetchedRuns):
1271 (App.AnalysisTaskController._rootChangedForTestSet):
1273 * public/v2/index.html:
1274 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
1276 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1278 Unreviewed. Fixed syntax errors.
1280 * init-database.sql:
1281 * public/api/commits.php:
1283 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1285 The dashboard on new perf monitor should be configurable
1286 https://bugs.webkit.org/show_bug.cgi?id=138994
1288 Reviewed by Benjamin Poulain.
1290 For now, make it configurable via config.json. We should eventually make it configurable via
1291 an administrative page but this will do for now.
1293 * config.json: Added the empty dashboard configuration.
1295 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1298 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1299 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1300 Also obtain the default configuration from App.Manifest.
1301 (App.IndexController._normalizeTable): Moved to App.Dashboard.
1303 * public/v2/manifest.js:
1304 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
1305 (App.Repository.urlForRevisionRange): Ditto.
1306 (App.Dashboard): Added.
1307 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
1308 (App.Dashboard.rows): Ditto.
1309 (App.Dashboard.headerColumns): Ditto.
1310 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
1311 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
1312 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
1313 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
1315 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1317 There should be a way to associate bugs with analysis tasks
1318 https://bugs.webkit.org/show_bug.cgi?id=138977
1320 Reviewed by Benjamin Poulain.
1322 Updated associate-bug.php to match the new database schema.
1324 * public/include/json-header.php:
1325 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
1326 already camel-cased in require_existence_of. This makes the function usable elsewhere.
1328 * public/privileged-api/associate-bug.php:
1329 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
1330 Also verify that those values are integers using require_format.
1332 * public/v2/analysis.js:
1333 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
1334 (App.Bug.label): Added.
1335 (App.BugAdapter): Added.
1336 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
1337 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
1339 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
1340 containing the bug information.
1343 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
1344 (App.AnalysisTaskRoute):
1345 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
1346 (App.AnalysisTaskController._fetchedManifest): Added.
1347 (App.AnalysisTaskController.actions.associateBug): Added.
1349 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
1351 * public/v2/data.js:
1352 (Measurement.prototype.associateBug): Deleted.
1354 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
1355 Added a table show the bug information. Also hide the chart until chartData is available.
1357 * public/v2/manifest.js:
1360 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1362 Fix misc bugs and typos in app.js
1363 https://bugs.webkit.org/show_bug.cgi?id=138946
1365 Reviewed by Benjamin Poulain.
1368 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1369 (App.ChartsController.init):
1370 (App.buildPopup): Renamed from App.BuildPopup.
1371 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1372 remove() on the wrong object (an array as opposed to elements in the array).
1373 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1374 _highlights is always an array and evalutes to true.
1376 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1378 New perf dashboard should provide UI to create a new analysis task
1379 https://bugs.webkit.org/show_bug.cgi?id=138910
1381 Reviewed by Benjamin Poulain.
1383 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1384 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1386 With this patch, we can create a new analysis task by selection a range of points and opening
1387 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1388 in the chart hyperlinked to the analysis task.
1390 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1392 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1393 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1395 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1396 and adds the associated bugs to each task in the array.
1399 * public/api/runs.php: Reverted changes made in r175006.
1400 (fetch_runs_for_config):
1403 * public/api/test-groups.php:
1404 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1406 * public/include/db.php:
1407 (Database::select_first_or_last_row):
1408 (Database::select_rows): Extracted from select_first_or_last_row.
1410 * public/v2/analysis.js:
1411 (App.AnalysisTask): Added "bugs" property.
1412 (App.Bug): Added now that bugs are regular data store objects.
1415 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1416 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1417 platform that are associated with a specific range of runs.
1418 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1419 (App.PaneController.actions.associateBug): Deleted.
1420 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1421 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1422 once we've created one.
1423 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1424 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1425 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1426 (App.PaneController._updateBugs): Deleted.
1427 (App.PaneController._updateMarkedPoints): Deleted.
1428 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1429 the name is missing or when at most one point is selected.
1431 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1432 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1433 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1434 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1435 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1436 clickable bars for analysis tasks.
1437 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1438 bar for analysis tasks to place them at the right location.
1439 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1441 * public/v2/chart-pane.css:
1442 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1443 (.chart .rangeBar): Added.
1445 * public/v2/data.js:
1446 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1448 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1449 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1450 task bars in the interactive chart component.
1452 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1454 Fix typos in r176203.
1457 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1458 (App.AnalysisTaskRoute):
1460 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1462 Unreviewed. Updated the install instruction.
1466 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1468 App.Manifest shouldn't use App.__container__.lookup
1469 https://bugs.webkit.org/show_bug.cgi?id=138768
1471 Reviewed by Andreas Kling.
1473 Removed the hack to find the store object via App.__container__.lookup.
1474 Pass around the store object instead.
1477 (App.DashboardRow._createPane): Add "store" property to the pane.
1478 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1479 (App.IndexController.gridChanged): Ditto.
1480 (App.IndexController.actions.addRow): Ditto.
1481 (App.IndexController.init): Ditto.
1482 (App.Pane._fetch): Ditto.
1483 (App.ChartsController._parsePaneList): Ditto.
1484 (App.ChartsController._updateQueryString): Ditto.
1485 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1486 (App.BuildPopup): Ditto.
1487 (App.AnalysisTaskRoute.model): Ditto.
1488 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1490 * public/v2/manifest.js:
1491 (App.Manifest.fetch): Removed the code to find the store object.
1493 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1495 Fix Ember.js warnings the new perf dashboard
1496 https://bugs.webkit.org/show_bug.cgi?id=138531
1498 Reviewed by Darin Adler.
1500 Fixed various warnings.
1503 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1504 * public/v2/data.js:
1505 (PrivilegedAPI._post): Removed the superfluous console.log.
1506 (CommitLogs.fetchForTimeRange): Ditto.
1507 * public/v2/index.html: Added tbody as required by the HTML specification.
1509 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1511 Fix typos in r175768.
1514 (App.AnalysisTaskViewModel.roots):
1516 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1518 Introduce the concept of analysis task to perf dashboard
1519 https://bugs.webkit.org/show_bug.cgi?id=138517
1521 Reviewed by Andreas Kling.
1523 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1524 a single platform and used to bisect regressions in the range.
1526 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1528 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1529 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1530 test runs. Analysis tasks not associated with test runs are used for try new patches.
1531 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1532 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1533 build_requests - A build request represents a single pending build for A/B testing.
1535 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1539 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1540 the specified analysis task group as well as build requests associated with them.
1542 (fetch_test_groups_for_task):
1543 (fetch_build_requests_for_task):
1544 (fetch_build_requests_for_group):
1545 (format_test_group):
1546 (format_build_request):
1548 * public/include/json-header.php:
1549 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1552 * public/privileged-api/associate-bug.php:
1553 (main): Fixed a typo.
1555 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1558 (ensure_config_from_runs):
1560 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1562 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1564 (App.AnalysisTask.create):
1566 (App.TestGroupAdapter):
1567 (App.AnalysisTaskSerializer):
1568 (App.TestGroupSerializer):
1571 * public/v2/app.css: Added style rules for the analysis page.
1574 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1576 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1577 exactly one selected point as we can still create an analysis task.
1578 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1579 grammatical and also alert'ed the error message when there is one.
1580 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1581 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1582 once XHR request has completed.
1583 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1584 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1585 is selected in the details pane.
1587 (App.AnalysisRoute): Added.
1588 (App.AnalysisTaskRoute): Added.
1589 (App.AnalysisTaskViewModel): Added.
1590 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1591 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1592 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1593 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1594 the user selects an option for all roots in A or B configuration.
1595 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1597 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1599 * public/v2/data.js:
1600 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1601 point so that we can use it in App.AnalysisTaskViewModel.roots.
1602 (TimeSeries.prototype.findPointByMeasurementId): Added.
1603 (TimeSeries.prototype.seriesBetweenPoints): Added.
1605 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1606 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1607 when multiple points are selected. Finally, added a new template for the analysis task page.
1609 * public/v2/manifest.js:
1610 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1611 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1612 App.AnalysisTaskViewModel._taskUpdated.
1614 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1616 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1617 https://bugs.webkit.org/show_bug.cgi?id=138111
1619 Reviewed by Darin Adler.
1622 (App.PaneController.bugsChangeCount): Removed.
1623 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1624 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1625 Finds the list of current run's points that are associated with bugs.
1626 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1627 * public/v2/chart-pane.css:
1628 (.chart .marked): Renamed from .hasBugs.
1629 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1631 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1633 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1634 https://bugs.webkit.org/show_bug.cgi?id=138099
1636 Reviewed by Benjamin Poulain.
1638 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1639 _showDetails inverting the order of the current and old measurements.
1642 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1643 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1644 current (latest) measurement and the first point is the oldest measurement.
1645 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1647 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1649 Perf dashboard should provide a way to associate bugs with a test run
1650 https://bugs.webkit.org/show_bug.cgi?id=137857
1652 Reviewed by Andreas Kling.
1654 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1655 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1656 the Apache configuration.
1659 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1660 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1661 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1662 via the cookie and returns a token computed from those two values as well as the remote username.
1664 The font end code then POST's the request along with the returned token. The server side code verifies
1665 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1666 the token hasn't expired.
1669 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1670 have zero or exactly one bug associated with a test run.
1672 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1673 * public/api/runs.php:
1674 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1675 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1676 an associated bug if there is one.
1677 (format_run): Calls parse_bugs_array.
1679 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1680 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1681 have a valid JSON payload.
1682 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1683 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1684 the expiration time stored in the cookie.
1685 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1687 * public/include/manifest.php:
1688 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1689 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1691 * public/index.html:
1692 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1694 * public/privileged-api/associate-bug.php: Added.
1695 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1696 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1698 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1700 * public/v2/app.css:
1701 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1702 selected in a chart.
1705 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1706 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1707 they would overlap on each other if both of them are shown.
1708 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1709 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1710 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1711 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1712 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1713 showing the search pane.
1714 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1715 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1716 bugs in the selected range.
1718 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1719 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1720 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1721 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1722 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1723 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1724 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1725 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1727 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1728 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1729 to selectionChanged action instead of just finding the first and the last points.
1731 * public/v2/chart-pane.css: Updated the style.
1733 * public/v2/data.js:
1734 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1735 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1736 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1737 we haven't already obtained a CSRF token or if the token has already been expired.
1738 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1740 (Measurement.prototype.bugs): Added.
1741 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1742 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1744 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1747 * public/v2/manifest.js:
1748 (App.BugTracker.bugUrl):
1749 (App.BugTracker.newBugUrl): Added.
1750 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1751 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1752 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1753 (App.Manifest.bugTrackers): Added.
1754 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1755 their respective ids to make the ordering stable.
1757 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1759 Remove unused jobs table
1760 https://bugs.webkit.org/show_bug.cgi?id=137724
1762 Reviewed by Daniel Bates.
1764 Removed jobs table in the database as well as related code.
1766 * init-database.sql:
1767 * public/admin/jobs.php: Removed.
1768 * public/admin/tests.php:
1769 * public/include/admin-header.php:
1771 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1773 New perf dashboard should have an ability to search commits by a keyword
1774 https://bugs.webkit.org/show_bug.cgi?id=137675
1776 Reviewed by Geoffrey Garen.
1778 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1779 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1780 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1782 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1783 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1785 * public/api/commits.php:
1786 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1787 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1788 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1789 (format_commit): Renamed from format_commits. Now only formats one commit.
1791 * public/include/db.php:
1792 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1794 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1797 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1798 which is a hash table that contains highlighted items' measurements' ids as keys.
1799 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1800 the default commit repository.
1801 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1802 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1803 Added the code to initialize this._highlights.
1804 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1805 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1806 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1807 the existing lines for the old highlighted items.
1808 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1809 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1811 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1813 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1814 (CommitLogs): Added.
1815 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1816 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1817 (CommitLogs._cacheConsecutiveCommits): Ditto.
1818 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1819 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1820 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1822 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1823 for showingDetails since this property is no longer used.
1825 * public/v2/manifest.js:
1826 (App.Manifest.repositories): Added.
1827 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1828 the default repository to search.
1829 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1831 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1833 Unreviewed build fix after r174555.
1835 * public/include/manifest.php:
1836 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1837 * tests/admin-regenerate-manifest.js: Fixed the test case.
1839 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1841 New perf dashboard UI tries to fetch commits all the time
1842 https://bugs.webkit.org/show_bug.cgi?id=137592
1844 Reviewed by Andreas Kling.
1846 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1847 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1848 no reported commits as they are all going to fail.
1850 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1851 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1852 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1853 of commits sorted chronologically by time.
1855 * public/include/manifest.php:
1858 (App.CommitsViewerComponent.commitsChanged):
1860 * public/v2/data.js:
1861 (FetchCommitsForTimeRange):
1862 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1864 * public/v2/manifest.js:
1867 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1869 Another unreviewed build fix after r174477.
1871 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1873 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1875 * public/include/report-processor.php:
1877 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1879 Unreviewed build fix after r174477.
1881 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1882 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1884 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1885 This is necessary for baseline and target values manually added via admin pages.
1887 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1889 Add v2 UI for the perf dashboard
1890 https://bugs.webkit.org/show_bug.cgi?id=137537
1892 Rubber-stamped by Andreas Kling.
1895 * public/v2/app.css: Added.
1896 * public/v2/app.js: Added.
1897 * public/v2/chart-pane.css: Added.
1898 * public/v2/data.js: Added.
1899 * public/v2/index.html: Added.
1900 * public/v2/js: Added.
1901 * public/v2/js/d3: Added.
1902 * public/v2/js/d3/LICENSE: Added.
1903 * public/v2/js/d3/d3.js: Added.
1904 * public/v2/js/d3/d3.min.js: Added.
1905 * public/v2/js/ember-data.js: Added.
1906 * public/v2/js/ember.js: Added.
1907 * public/v2/js/handlebars.js: Added.
1908 * public/v2/js/jquery.min.js: Added.
1909 * public/v2/js/statistics.js: Added.
1910 * public/v2/manifest.js: Added.
1911 * public/v2/popup.js: Added.
1913 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1915 Remove superfluously duplicated code in public/api/report-commits.php.
1917 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1919 Perf dashboard should store commit logs
1920 https://bugs.webkit.org/show_bug.cgi?id=137510
1922 Reviewed by Darin Adler.
1924 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
1926 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
1927 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
1928 a subversion directory. The git version of this script will be added in a follow up patch.
1931 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
1932 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
1933 relationship via "build_commits" relations.
1935 In order to migrate an existing instance of this application, run the following SQL commands:
1939 INSERT INTO commits (commit_repository, commit_revision, commit_time)
1940 (SELECT DISTINCT ON (revision_repository, revision_value)
1941 revision_repository, revision_value, revision_time FROM build_revisions);
1943 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
1944 FROM commits, build_revisions
1945 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
1947 DROP TABLE build_revisions;
1952 The helper script to submit commit logs can be used as follows:
1954 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
1955 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
1957 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
1958 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
1959 "feeder-slave-password" as the builder name and the builder password respectively.
1961 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
1962 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
1965 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
1967 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
1968 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
1970 - Not specified - It returns every single commit for a given repository.
1971 - Matches "oldest" - It returns the commit with the oldest timestamp.
1972 - Matches "latest" - It returns the commit with the latest timestamp.
1973 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
1974 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
1975 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
1976 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
1977 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
1978 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
1980 (commit_from_revision):
1981 (fetch_commits_between):
1984 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
1985 See tests/api-report-commits.js for examples on how to use this API.
1987 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
1988 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
1989 to optimize this and other JSON APIs.
1991 * public/include/db.php:
1992 (Database::select_or_insert_row):
1993 (Database::update_or_insert_row): Added.
1994 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
1995 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
1997 (Database::select_first_row):
1998 (Database::select_last_row): Added.
1999 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
2000 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
2002 * public/include/report-processor.php:
2003 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
2004 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
2005 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
2008 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
2010 * tests/api-report-commits.js: Added.
2011 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
2014 * tools/pull-svn.py: Added. See above for how to use this script.
2016 (determine_first_revision_to_fetch):
2017 (fetch_revision_from_dasbhoard):
2018 (fetch_commit_and_resolve_author):
2021 (resolve_author_name_from_email):
2024 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
2026 Update Install.md for Mavericks and fix typos
2027 https://bugs.webkit.org/show_bug.cgi?id=137276
2029 Reviewed by Benjamin Poulain.
2031 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
2033 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
2035 Finally, init-database.sql is no longer located inside database directory.
2039 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2041 Report run id's in api/runs.php for the new dashboard UI
2042 https://bugs.webkit.org/show_bug.cgi?id=135813
2044 Reviewed by Andreas Kling.
2046 Include run_id in the generated JSON.
2048 * public/api/runs.php:
2049 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
2052 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
2054 Merging platforms mixes baselines and targets into reported data
2055 https://bugs.webkit.org/show_bug.cgi?id=135260
2057 Reviewed by Andreas Kling.
2059 When merging two platforms, move test configurations of a different type (baseline, target)
2060 as well as of different metric (Time, Runs).
2062 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
2063 It's sufficient to detect one such test_runs object.
2065 * public/admin/platforms.php:
2068 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
2070 Merging platforms mixes baselines and targets into reported data
2071 https://bugs.webkit.org/show_bug.cgi?id=135260
2073 Reviewed by Geoffrey Garen.
2075 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
2076 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
2078 * public/admin/platforms.php:
2080 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
2082 Build fix after r171361.
2084 * public/js/helper-classes.js:
2085 (.this.formattedBuildTime):
2087 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
2089 Perf dashboard spends 2s processing JSON data during the page loads
2090 https://bugs.webkit.org/show_bug.cgi?id=135152
2092 Reviewed by Andreas Kling.
2094 In the Apple internal dashboard, we were spending as much as 2 seconds
2095 converting raw JSON data into proper JS objects while loading the dashboard.
2097 This caused the apparent unresponsiveness of the dashboard despite of the fact
2098 charts themselves updated almost instantaneously.
2100 * public/index.html:
2101 * public/js/helper-classes.js:
2102 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
2103 lazily as creating new Date objects and running string replace is expensive.
2104 (TestBuild.formattedTime):
2105 (TestBuild.formattedBuildTime):
2106 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
2107 (PerfTestRuns.addResult): Deleted.
2109 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
2111 Perf dashboard shouldn't show the full git hash
2112 https://bugs.webkit.org/show_bug.cgi?id=135083
2114 Reviewed by Benjamin Poulain.
2116 Detect Git/Mercurial hash by checking the length.
2118 If it's a hash, use the first 8 characters in the label
2119 while retaining the full length to be used in hyperlinks.
2121 * public/js/helper-classes.js:
2122 (.this.formattedRevisions):
2125 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
2127 Add an instruction on how to backup the database.
2128 https://bugs.webkit.org/show_bug.cgi?id=133391
2130 Rubber-stamped by Andreas Kling.
2134 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2136 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
2138 * public/js/helper-classes.js:
2139 (PerfTestRuns.smallerIsBetter):
2141 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
2145 * public/common.css:
2147 * public/index.html:
2151 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2153 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
2154 https://bugs.webkit.org/show_bug.cgi?id=131157
2156 Reviewed by Andreas Kling.
2158 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
2159 This allows, for example, adding all metrics such as Arithmetic and Geometric for
2160 a given test suite without also adding its subtests.
2162 * public/index.html:
2166 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2168 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
2169 https://bugs.webkit.org/show_bug.cgi?id=131155
2171 Reviewed by Andreas Kling.
2173 The bug was caused by Chart.attach binding event listeners on plot container on each call.
2174 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
2175 click when attach() has been called even number of times, keeping the tooltip invisible.
2177 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
2178 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
2179 is called for the first time.
2181 * public/index.html:
2183 (Chart..bindPlotEventHandlers):
2185 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2187 WebKitPerfMonitor: Tooltips can be cut off at the top
2188 https://bugs.webkit.org/show_bug.cgi?id=130960
2190 Reviewed by Andreas Kling.
2192 * public/common.css:
2193 (#title): Removed the gradients, box shadows, and border from the header.
2194 (#title h1): Reduce the font size.
2195 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
2196 * public/index.html:
2197 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
2198 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
2199 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
2200 * public/js/helper-classes.js:
2201 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
2202 tooltip extending above y=0.
2204 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
2206 WebKitPerfMonitor: Y-axis adjustment is too aggressive
2207 https://bugs.webkit.org/show_bug.cgi?id=130937
2209 Reviewed by Andreas Kling.
2211 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
2212 results. This had two major problems:
2213 1. Two standard deviations can be too small to show the confidence interval for results.
2214 2. Sometimes baseline and target can be more than two standards deviations away.
2216 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
2217 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
2218 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
2219 the margin on each side separately to reduce the empty space on either side.
2221 A more rigorous approach would involve computing least squared value of results with respect to intervals
2222 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
2224 * public/index.html:
2225 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
2226 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
2227 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
2228 We wouldn't see the difference between measured values versus baseline and target values otherwise.
2229 * public/js/helper-classes.js:
2230 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
2231 interval delta cannot be computed.
2232 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
2233 within the given interval.
2234 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
2235 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
2236 (PerfTestRuns..unscaledMeansForAllResults):
2237 (PerfTestRuns.min): Take the confidence interval delta into account.
2238 (PerfTestRuns.max): Ditto.
2239 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
2240 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
2242 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
2244 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
2246 Some CSS tweaks after r166477 and r166479,
2248 * public/index.html:
2250 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2252 WebKitPerfMonitor: Sometimes text inside panes overlap
2253 https://bugs.webkit.org/show_bug.cgi?id=130956
2255 Reviewed by Gyuyoung Kim.
2257 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
2258 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
2259 reduces the total height of the pane and fits more information per screen capita on the dashboard.
2261 * public/index.html: Updated and added a bunch of CSS rules for the new look.
2262 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
2263 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
2264 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
2265 of the build info shown in a chart pane and a tooltip.
2266 (Chart): Made .status a table.
2267 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
2268 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
2269 now that status.text no longer contains it.
2270 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
2272 * public/js/helper-classes.js:
2273 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
2274 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
2275 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
2276 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
2277 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
2278 capital letter; e.g. "MB" instead of "M B".
2280 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
2282 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
2283 https://bugs.webkit.org/show_bug.cgi?id=130957
2285 Reviewed by Gyuyoung Kim.
2287 Moved the slider into the header. Also reduced the spacing between the header and platform names.
2288 This reclaims 50px × width of the screen real estate.
2290 * public/common.css:
2291 (#title): Reduced the space below the header from 20px to 10px.
2292 * public/index.html:
2293 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
2294 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
2295 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
2296 real estate between the header and the platform names.
2298 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2300 Update the install guidelines for perf.webkit.org
2301 https://bugs.webkit.org/show_bug.cgi?id=129895
2303 Reviewed by Ryosuke Niwa.
2305 The current install guideline for perf.webkit.org discourages the use of the installed
2306 Server application. I've actualized the documentation for Mavericks, and modified the
2307 guideline to include the instructions for Server.app also.
2311 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
2313 Update perf.webkit.org json example
2314 https://bugs.webkit.org/show_bug.cgi?id=129907
2316 Reviewed by Andreas Kling.
2318 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
2322 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
2324 Merge database-common.js and utility.js into run-tests.js.
2326 Reviewed by Matthew Hanson.
2328 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
2329 Also moved init-database.sql out of the database directory and removed the directory entirely.
2331 * database: Removed.
2332 * database/database-common.js: Removed.
2333 * database/utility.js: Removed.
2334 * init-database.sql: Moved from database/init-database.sql.
2336 (connect): Moved from database-common.js.
2337 (pathToDatabseSQL): Extracted from pathToLocalScript.
2338 (pathToTests): Moved from database-common.js.
2341 (SerializedTaskQueue): Ditto.
2343 (initializeDatabase):
2344 (TestEnvironment.it):
2345 (TestEnvironment.queryAndFetchAll):
2348 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2350 Remove the dependency on node.js from the production code.
2352 Reviewed by Ricky Mondello.
2354 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
2356 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
2357 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
2358 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
2359 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
2360 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
2362 Also removed the js files that are no longer used.
2364 * config.json: Moved from database/config.json.
2365 * database/aggregate.js: Removed. No longer used.
2366 * database/database-common.js: Removed unused functions, and updated the path to config.json.
2367 * database/process-jobs.js: Removed. No longer used.
2368 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2369 * database/schema.graffle: Removed. It's completely obsolete.
2370 * public/include/db.php: Updated the path to config.json.
2371 * public/include/evaluator.js: Removed.
2373 * public/include/report-processor.php:
2374 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2375 storing values into $expressions and calling evaluate_expressions_by_node.
2376 (TestRunsGenerator::aggregate_values): Added.
2377 (TestRunsGenerator::compute_caches): Directly compute the caches.
2379 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2381 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2383 * public/admin/platforms.php:
2384 * public/include/db.php:
2386 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2388 Zoomed y-axis view is ununsable when the last result is an outlier.
2390 Reviewed by Stephanie Lewis.
2392 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2393 the last result so that the graph looks sane if the last result was an outlier. However, always show
2394 the last result's mean even if it was an outlier.
2396 * public/index.html:
2397 * public/js/helper-classes.js:
2398 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2399 Also added the ability to cache the unscaled means to avoid recomputation.
2400 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2401 (PerfTestRuns.max): Ditto.
2402 (PerfTestRuns.sampleStandardDeviation): Ditto.
2403 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2405 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2409 * public/admin/tests.php:
2410 * public/js/helper-classes.js:
2412 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2414 Use two standard deviations instead as I mentioned in the mailing list.
2416 * public/index.html:
2418 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2420 The performance dashboard erroneously shows upward arrow for combined metrics.
2422 A single outlier can ruin the zoomed y-axis view.
2424 Rubber-stamped by Antti Koivisto.
2426 * public/index.html:
2427 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2428 from the latest results' mean.
2429 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2430 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2431 (Chart.toggleYAxis):
2432 * public/js/helper-classes.js:
2433 (PerfTestRuns.sampleStandardDeviation): Added.
2434 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2436 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2438 Don't include the confidence interval when computing the y-axis.
2440 Rubber-stamped by Simon Fraser.
2442 * public/js/helper-classes.js:
2446 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2448 Tiny CSS tweak for tooltips.
2450 * public/index.html:
2452 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2454 Remove the erroneously repeated code.
2456 * public/admin/test-configurations.php:
2458 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2460 <rdar://problem/15704893> perf dashboard should show baseline numbers
2462 Reviewed by Stephanie Lewis.
2464 * public/admin/bug-trackers.php:
2465 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2468 * public/admin/platforms.php:
2469 (merge_list): Ditto.
2471 * public/admin/test-configurations.php: Added.
2472 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2473 build_revisions as they're not meaningful for baseline / target numbers.
2474 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2475 one test run so that we don't accidentally delete a reported test run.
2476 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2477 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2478 and delete existing ones.
2480 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2481 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2482 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2484 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2485 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2486 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2487 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2488 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2490 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2492 * public/include/admin-header.php:
2493 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2494 have id and type sub columns, and each custom column could generate multiple rows.
2496 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2497 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2498 We then proceed to generate the second header row with sub column names.
2500 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2501 which case regular columns need rowspan set to the maximum number of rows.
2503 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2506 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2507 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2508 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2509 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2510 expanded to occupy all sub columns.
2512 * public/include/manifest.php:
2513 (ManifestGenerator::platforms): Don't add the metric more than once.
2515 * public/include/test-name-resolver.php:
2516 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2517 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2518 full metric name later.
2519 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2520 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2521 (TestNameResolver::full_name_for_test): Added.
2522 (TestNameResolver::full_name_for_metric): Added.
2523 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2525 * public/js/helper-classes.js:
2526 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2527 test runs created to set baseline and target points.
2529 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2531 Build fix after r57928. Removed a superfluous close parenthesis.
2533 * public/api/runs.php:
2535 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2537 Unreviewed build & typo fixes.
2539 * public/admin/platforms.php:
2540 * tests/admin-platforms.js:
2542 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2544 <rdar://problem/15704893> perf dashboard should show baseline numbers
2546 Rubber-stamped by Antti Koivisto.
2548 Organize some code into functions in runs.php.
2550 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2552 * public/api/runs.php:
2553 (fetch_runs_for_config): Extracted.
2554 (format_run): Ditto.
2556 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2558 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2560 * database/config.json:
2561 * public/admin/reprocess-report.php:
2562 * public/api/report.php:
2563 * public/api/runs.php:
2564 * public/include/json-header.php:
2566 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2568 Commit yet another forgotten change.
2570 Something went horribly wrong with my merge :(
2572 * database/init-database.sql:
2574 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2576 Commit one more forgotten change. Sorry for making a mess here.
2578 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2580 Commit the forgotten files.
2582 * public/admin/platforms.php: Added.
2583 * tests/admin-platforms.js: Added.
2585 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2587 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2589 Reviewed by Stephanie Lewis.
2591 Added /admin/platforms/ page to hide and merge platforms.
2593 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2594 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2595 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2596 each test configuration a distinct "test run" for each build.
2598 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2599 their test configurations into platform B.
2601 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2602 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2603 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2604 in platform B, in which case R should relate to T_B instead.
2606 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2607 new platform. We then migrate the test configurations of the remaining test runs.
2609 * database/init-database.sql: Added platform_hidden.
2611 * public/admin/platforms.php: Added.
2612 (merge_platforms): Added. Implements the algorithm described above.
2613 (merge_list): Added.
2615 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2616 is hidden since it doesn't do anything.
2618 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2619 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2620 missing it since unchecked checkbox doesn't set the value in $_POST.
2621 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2622 switch statement instead of repeated if's.
2623 (AdministrativePage::render_table): Emit "update-column" for update_field.
2625 * public/include/db.php: Disable warnings when we're not in the debug mode.
2627 * public/include/manifest.php:
2628 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2631 (TestEnvironment.postJSON):
2632 (TestEnvironment.httpGet):
2633 (TestEnvironment.httpPost): Added.
2634 (sendHttpRequest): Set the content type if specified.
2636 * tests/admin-platforms.js: Added tests.
2638 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2640 Extract the code to compute full test names from tests.php.
2642 Reviewed by Stephanie Lewis.
2644 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2645 and paves our way to re-use the code in other pages.
2647 * public/admin/tests.php:
2649 * public/include/db.php:
2650 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2651 tests.php and test-name-resolver.php.
2653 * public/include/test-name-resolver.php: Added.
2654 (TestNameResolver::__construct):
2655 (TestNameResolver::compute_full_name): Moved from tests.php.
2656 (TestNameResolver::map_metrics_to_tests): Ditto.
2657 (TestNameResolver::sort_tests_by_full_name): Ditto.
2658 (TestNameResolver::tests): Added.
2659 (TestNameResolver::test_id_for_full_name): Ditto.
2660 (TestNameResolver::metrics_for_test_id): Ditto.
2661 (TestNameResolver::child_metrics_for_test_id): Ditto.
2662 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2664 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2666 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2668 Reviewed by Stephanie Lewis.
2670 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2672 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2673 but that's sufficient to correct the wrongfully processed reports for now.
2675 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2676 We should eventually add a nice UI to find and reprocess reports.
2678 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2680 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2682 * public/include/report-processor.php: Copied from public/api/report.php.
2683 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2684 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2685 create a new report or authenticate the builder password (the password is never stored in the report).
2686 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2687 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2688 (ReportProcessor::store_report): Ditto.
2690 * tests/admin-reprocess-report.js: Added.
2692 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2694 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2696 Reviewed by Ricky Mondello.
2698 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2699 for the same build number as a single build by ignoring build time. This was necessary to associate
2700 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2701 we use to submit results computed its own "build time" when they're called.
2703 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2704 last week; new reports were wrongfully associated with old build numbers.
2706 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2707 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2708 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2710 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2711 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2712 (builder, build number, build time).
2714 * public/api/report.php:
2715 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2716 when no such build exists. This prevents a report from being associated with a very old build of the same
2719 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2720 a similar bug in the future sooner.
2722 * tests/api-report.js: Added three test cases.
2724 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2726 Merged the upstream changes to db.php
2727 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2729 * public/include/db.php:
2731 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2733 Update other scripts and tests per previous patch.
2735 * public/include/manifest.php:
2736 * tests/admin-regenerate-manifest.js:
2738 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2740 Remove metrics_unit.
2742 Reviewed by Ricky Mondello.
2744 This column is no longer used by the front-end code since r48360.
2746 * database/init-database.sql:
2747 * public/admin/tests.php:
2749 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2751 Unreviewed build fix.
2753 * public/api/report.php:
2755 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2757 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2759 Reviewed by Ricky Mondello.
2761 Support a new alternative format for aggregated results where we have raw values as well as
2762 the list aggregators so that instead of
2763 "metrics": {"Time": ["Arithmetic"]}
2765 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2767 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2768 dashboard and the generated results page, which doesn't know how to aggregate values.
2770 We need to keep the support for the old format because all other existing performance tests
2771 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2772 the old format during the transition.
2774 * public/api/report.php:
2775 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2776 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2778 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2780 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2782 Unreviewed; Tweak the CSS so that chart panes align vertically.
2784 * public/index.html:
2786 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2788 SafariPerfMonitor should support Combined metric.
2790 * public/js/helper-classes.js:
2791 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2792 value as well but assume it to be greater-is-better for now.
2794 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2796 Commit the forgotten init-database change to add iteration_relative_time.
2798 * database/init-database.sql:
2800 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2802 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2804 Reviewed by Ricky Mondello.
2806 Add the support for each value to have a relative time. This is necessary for frame rate history
2807 since a frame rate needs to be associated with a time it was sampled.
2809 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2811 * public/api/report.php:
2812 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2813 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2814 with relative time since taking the average of two frame rates for two subtests taken at two
2815 different times doesn't make any sense.
2816 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2817 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2818 Also exit early with an error if the number of elements in the array is not a pair.
2819 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2821 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2822 iteration_relative_time.
2824 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2826 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2828 Reviewed by Ricky Mondello.
2830 Support that. It's one line change.
2832 * public/api/report.php:
2833 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2834 to match the convention assumed elsewhere.
2835 * tests/api-report.js: Added a test case.
2837 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2839 SafariPerfMonitor shows popups for points outside of the visible region.
2841 Rubber-stamped by Simon Fraser.
2843 * public/index.html:
2844 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2845 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2846 may return an item underneath y-axis labels.
2848 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2850 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2852 * public/index.html:
2854 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2856 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2858 * public/index.html:
2860 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2862 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2863 <rdar://problem/13992271> Should scale Y axis to include error ranges
2865 Reviewed by Ricky Mondello.
2867 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2868 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2870 * database/config.json:
2871 * public/index.html:
2872 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2873 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2874 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2876 * public/js/helper-classes.js:
2877 (PerfTestResult.confidenceIntervalDelta):
2878 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2879 (PerfTestRuns.min): Take confidence interval delta into account.
2880 (PerfTestRuns.max): Ditto.
2881 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2883 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2885 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2887 * public/api/report.php:
2888 (ReportProcessor::recursively_ensure_tests):
2889 * tests/api-report.js: Added a test.
2891 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2893 Unreviewed build fixes.
2895 * public/api/report.php:
2896 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
2897 Also, tolerate reports without any revision information.
2899 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
2902 * tests/api-report.js: Added few test cases.
2904 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2906 Commit another change that was supposed to be committed in r50331.
2909 (TestEnvironment.this.postJSON):
2910 (TestEnvironment.this.httpGet):
2913 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
2915 Commit the remaining files.
2917 * public/admin/regenerate-manifest.php:
2918 * public/include/admin-header.php:
2919 * public/include/json-header.php:
2920 * public/include/manifest.php:
2922 (TestEnvironment.this.postJSON):
2923 (TestEnvironment.this.httpGet):
2926 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
2928 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
2930 Reviewed by Ricky Mondello.
2932 Added some tests for admin/regenerate-manifest.
2934 * public/admin/regenerate-manifest.php: Use require_once instead of require.
2935 * public/include/admin-header.php: Ditto.
2936 * public/include/json-header.php: Ditto.
2938 * public/include/manifest.php:
2939 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
2940 When there are no builders, simply return an empty array.
2943 (TestEnvironment.postJSON):
2944 (TestEnvironment.httpGet): Added.
2945 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
2947 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
2949 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
2951 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
2952 and run_iterations. Also fixed a typo in report.php found by new tests.
2954 * public/api/report.php:
2955 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
2956 * tests/api-report.js: Added more test cases.
2958 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
2960 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
2962 Reviewed by Ricky Mondello.
2964 Add a test runner script and some simple test cases.
2966 * database/config.json: Added the configuration for "testServer".
2967 * database/database-common.js:
2968 (pathToTests): Added.
2969 * run-tests.js: Added.
2972 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
2973 and if there are, asks the user if it’s okay to delete all of the data contained therein.
2974 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
2976 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
2977 in the current database using PostgreSQL's information_schema.
2978 (askYesOrNoQuestion):
2980 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
2982 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
2983 (TestEnvironment.assert): Exposes assert to tests.
2984 (TestEnvironment.console): Exposes console to tests.
2985 (TestEnvironment.describe): Adds a description.
2986 (TestEnvironment.it): Adds a test case.
2987 (TestEnvironment.postJSON):
2988 (TestEnvironment.queryAndFetchAll):
2989 (TestEnvironment.sha256):
2990 (TestEnvironment.notifyDone): Ends the current test case.
2994 (TestContext): An object created for each test case. Conceptually, this object is always on
2995 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
2996 this object via currentTestContext.
2997 (TestContext.description):
2999 (TestContext.logError):
3002 * tests/api-report.js: Added some basic tests for /api/report.php.
3004 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3006 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
3008 The problem was that we were detecting whether we're updating dashboard or not by checking
3009 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
3010 all configurations. Use separate 'dashboard' action to execute the code even when
3011 metric_configurations is empty.
3013 * public/admin/tests.php:
3015 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3017 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
3019 Reviewed by Ricky Mondello.
3021 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
3022 from ReportProcessor as a preparation to replace deprecated aggregate.js.
3024 * public/api/report.php:
3025 (ReportProcessor::exit_with_error): Moved.
3026 (ReportProcessor::process): Use the extracted TestRunsGenerator.
3027 (TestRunsGenerator): Added.
3028 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
3029 (TestRunsGenerator::add_aggregated_metric): Moved.
3030 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
3031 (TestRunsGenerator::aggregate): Moved. Made public.
3032 (TestRunsGenerator::aggregate_current_test_level): Moved.
3033 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
3034 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
3035 (TestRunsGenerator::compute_caches): Moved. Made public.
3036 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
3037 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
3038 (TestRunsGenerator::rollback_with_error): Moved.
3040 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3042 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
3044 Reviewed by Remy Demarest.
3046 Regenerate the manifest file when updating fields or adding new items that are included in
3049 * public/admin/bug-trackers.php:
3050 * public/admin/builders.php:
3051 * public/admin/regenerate-manifest.php:
3052 * public/admin/repositories.php:
3053 * public/admin/tests.php:
3054 * public/include/admin-header.php:
3055 (regenerate_manifest): Extracted from regenerate-manifest.php.
3057 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
3059 Unreviewed build fix for memory test results.
3061 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
3062 aggregating at each level.
3064 * public/api/report.php:
3065 (ReportProcessor::recursively_ensure_tests):
3066 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
3067 (ReportProcessor::add_values_for_aggregation):
3068 (ReportProcessor::aggregate):
3069 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
3071 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
3073 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
3074 not the number of iteration groups. Also, don't set group number when the entire run belongs
3075 a single iteration group.
3077 * public/api/report.php:
3078 (ReportProcessor::commit):
3080 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3082 SafariPerfMonitor: Introduce iteration groups
3084 Reviewed by Remy Demarest.
3086 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
3087 the runtime environment variances to get more stable results. And it's desirable to keep track of
3088 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
3090 This patch introduces "iteration groups" to keep track of this extra information.
3092 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
3093 the outer array denotes iteration groups and each inner array contains iteration values for each group.
3096 * database/init-database.sql: Add iteration_group column.
3097 * public/api/report.php:
3098 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
3100 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
3101 contains the list of values indexed by the iteration order and group sizes. Store the group size so
3102 that we can restore the iteration groups before passing it to node.js and restore them later.
3104 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
3105 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
3107 Also check that each iteration group in each subtest are consistent with one another. To see why we need
3108 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
3109 that each iteration group in T1 and T2 have the same size:
3110 T1 = [[1, 2], [3, 4, 5]]
3111 T2 = [[6, 7], [8, 9, 10]]
3113 so that the aggregated result (the sum in this case) can have the same groups as in:
3114 T = [[7, 9], [11, 13, 15]]
3116 If some iteration groups in T1 and T2 had a different size as in:
3117 T1 = [[1, 2, 3], [4, 5]]
3118 T2 = [[6, 7], [8, 9, 10]]
3120 Then iteration groups of the aggregated T is ambiguous.
3122 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
3123 (ReportProcessor::commit): Store iteration_group values.
3125 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3127 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
3128 migrated to perf.webkit.org.
3130 * database/perf-webkit-migrator.js: Removed.
3132 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3134 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
3136 * public/index.html:
3139 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
3141 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
3143 Reviewed by Ricky Mondello.
3145 It is often desirable to see charts of a given test for all platforms, or to be able to see
3146 charts of all subtests on a given platform when trying to triage perf. regressions.
3148 Support this use case by adding the ability to do so on the charts page.
3150 Also, we used to disable items on the test list based on the platform chosen. This turned out
3151 to be a bad UI because in many situations you want to be able to compare results of the same test
3152 on multiple platforms.
3154 In this new UI, we have three select elements, each of which selects the following:
3155 1. Top-level test - Test suite such as Dromaeo
3156 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
3157 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
3158 3. Platform - Mountain Lion, Qt, etc...
3160 A user can select "all" for metric and platform but we disallow doing both at once since adding
3161 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
3162 think of a use case where you want to look at that many charts at once. We can support this later
3163 if valid use cases come up.
3165 * public/index.html:
3166 (.showCharts.addOption): Extracted.
3167 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
3168 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
3169 metricList has onchange handler that enables/disables items on platformList.
3171 (init): Sort tests and test metrics here instead of doing that in showCharts.
3173 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
3175 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
3177 Reviewed by Remy Demarest and Ricky Mondello.
3179 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
3180 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
3181 templates to the manifest file instead. Each build now only contains the builder id.
3183 * public/api/runs.php: Removed the part of the query that joined builders table. This
3184 speeds up the query quite a bit.
3186 * public/include/manifest.php:
3187 (ManifestGenerator::generate): Generate builders field.
3188 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an