1 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
3 Split InteractiveChartComponent and CommitsViewerComponent into separate files
4 https://bugs.webkit.org/show_bug.cgi?id=139716
6 Rubber-stamped by Benjamin Poulain.
8 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
9 and interactive-chart.js respectively since app.js has gotten really large.
12 * public/v2/commits-viewer.js: Added.
13 * public/v2/interactive-chart.js: Added.
15 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
17 New perf dashboard's chart UI is buggy
18 https://bugs.webkit.org/show_bug.cgi?id=139214
20 Reviewed by Chris Dumez.
22 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
24 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
25 component. This is not how Ember.js components should interact to begin with. The component now exposes
26 selectedPoints and always updates selection instead of sharedSelection.
29 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
30 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
31 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
32 and end time should be completely determined by "since" and the present time.
33 (App.ChartsController._startTimeChanged): Ditto.
34 (App.ChartsController._scheduleQueryStringUpdate):
35 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
37 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
39 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
40 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
41 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
42 observes the changes to selectedPoints property as it gets updated by the main chart.
43 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
44 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
46 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
47 when domain arrays aren't identical. This was causing a subtle race with other logic.
48 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
49 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
50 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
51 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
52 see if those two points correspond to a range or a single data point. Rewrote all that logic by
53 directly observing selectedPoints and currentItem properties instead of taking points and relying on
54 an instance variable, which was a terrible API.
55 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
56 when the main plot has a selected range, we don't have to check this._hasRange anymore.
58 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
59 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
60 (App.InteractiveChartComponent._updateSelection):
61 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
62 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
63 selectedPoints property.
65 (App.AnalysisTaskController._fetchedRuns):
66 (App.AnalysisTaskController._rootChangedForTestSet):
68 * public/v2/index.html:
69 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
71 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
73 Unreviewed. Fixed syntax errors.
76 * public/api/commits.php:
78 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
80 The dashboard on new perf monitor should be configurable
81 https://bugs.webkit.org/show_bug.cgi?id=138994
83 Reviewed by Benjamin Poulain.
85 For now, make it configurable via config.json. We should eventually make it configurable via
86 an administrative page but this will do for now.
88 * config.json: Added the empty dashboard configuration.
90 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
93 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
94 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
95 Also obtain the default configuration from App.Manifest.
96 (App.IndexController._normalizeTable): Moved to App.Dashboard.
98 * public/v2/manifest.js:
99 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
100 (App.Repository.urlForRevisionRange): Ditto.
101 (App.Dashboard): Added.
102 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
103 (App.Dashboard.rows): Ditto.
104 (App.Dashboard.headerColumns): Ditto.
105 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
106 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
107 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
108 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
110 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
112 There should be a way to associate bugs with analysis tasks
113 https://bugs.webkit.org/show_bug.cgi?id=138977
115 Reviewed by Benjamin Poulain.
117 Updated associate-bug.php to match the new database schema.
119 * public/include/json-header.php:
120 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
121 already camel-cased in require_existence_of. This makes the function usable elsewhere.
123 * public/privileged-api/associate-bug.php:
124 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
125 Also verify that those values are integers using require_format.
127 * public/v2/analysis.js:
128 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
129 (App.Bug.label): Added.
130 (App.BugAdapter): Added.
131 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
132 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
134 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
135 containing the bug information.
138 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
139 (App.AnalysisTaskRoute):
140 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
141 (App.AnalysisTaskController._fetchedManifest): Added.
142 (App.AnalysisTaskController.actions.associateBug): Added.
144 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
147 (Measurement.prototype.associateBug): Deleted.
149 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
150 Added a table show the bug information. Also hide the chart until chartData is available.
152 * public/v2/manifest.js:
155 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
157 Fix misc bugs and typos in app.js
158 https://bugs.webkit.org/show_bug.cgi?id=138946
160 Reviewed by Benjamin Poulain.
163 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
164 (App.ChartsController.init):
165 (App.buildPopup): Renamed from App.BuildPopup.
166 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
167 remove() on the wrong object (an array as opposed to elements in the array).
168 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
169 _highlights is always an array and evalutes to true.
171 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
173 New perf dashboard should provide UI to create a new analysis task
174 https://bugs.webkit.org/show_bug.cgi?id=138910
176 Reviewed by Benjamin Poulain.
178 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
179 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
181 With this patch, we can create a new analysis task by selection a range of points and opening
182 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
183 in the chart hyperlinked to the analysis task.
185 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
187 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
188 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
190 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
191 and adds the associated bugs to each task in the array.
194 * public/api/runs.php: Reverted changes made in r175006.
195 (fetch_runs_for_config):
198 * public/api/test-groups.php:
199 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
201 * public/include/db.php:
202 (Database::select_first_or_last_row):
203 (Database::select_rows): Extracted from select_first_or_last_row.
205 * public/v2/analysis.js:
206 (App.AnalysisTask): Added "bugs" property.
207 (App.Bug): Added now that bugs are regular data store objects.
210 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
211 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
212 platform that are associated with a specific range of runs.
213 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
214 (App.PaneController.actions.associateBug): Deleted.
215 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
216 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
217 once we've created one.
218 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
219 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
220 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
221 (App.PaneController._updateBugs): Deleted.
222 (App.PaneController._updateMarkedPoints): Deleted.
223 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
224 the name is missing or when at most one point is selected.
226 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
227 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
228 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
229 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
230 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
231 clickable bars for analysis tasks.
232 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
233 bar for analysis tasks to place them at the right location.
234 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
236 * public/v2/chart-pane.css:
237 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
238 (.chart .rangeBar): Added.
241 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
243 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
244 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
245 task bars in the interactive chart component.
247 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
249 Fix typos in r176203.
252 (App.ChartsController.actions.addPaneByMetricAndPlatform):
253 (App.AnalysisTaskRoute):
255 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
257 Unreviewed. Updated the install instruction.
261 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
263 App.Manifest shouldn't use App.__container__.lookup
264 https://bugs.webkit.org/show_bug.cgi?id=138768
266 Reviewed by Andreas Kling.
268 Removed the hack to find the store object via App.__container__.lookup.
269 Pass around the store object instead.
272 (App.DashboardRow._createPane): Add "store" property to the pane.
273 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
274 (App.IndexController.gridChanged): Ditto.
275 (App.IndexController.actions.addRow): Ditto.
276 (App.IndexController.init): Ditto.
277 (App.Pane._fetch): Ditto.
278 (App.ChartsController._parsePaneList): Ditto.
279 (App.ChartsController._updateQueryString): Ditto.
280 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
281 (App.BuildPopup): Ditto.
282 (App.AnalysisTaskRoute.model): Ditto.
283 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
285 * public/v2/manifest.js:
286 (App.Manifest.fetch): Removed the code to find the store object.
288 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
290 Fix Ember.js warnings the new perf dashboard
291 https://bugs.webkit.org/show_bug.cgi?id=138531
293 Reviewed by Darin Adler.
295 Fixed various warnings.
298 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
300 (PrivilegedAPI._post): Removed the superfluous console.log.
301 (CommitLogs.fetchForTimeRange): Ditto.
302 * public/v2/index.html: Added tbody as required by the HTML specification.
304 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
306 Fix typos in r175768.
309 (App.AnalysisTaskViewModel.roots):
311 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
313 Introduce the concept of analysis task to perf dashboard
314 https://bugs.webkit.org/show_bug.cgi?id=138517
316 Reviewed by Andreas Kling.
318 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
319 a single platform and used to bisect regressions in the range.
321 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
323 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
324 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
325 test runs. Analysis tasks not associated with test runs are used for try new patches.
326 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
327 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
328 build_requests - A build request represents a single pending build for A/B testing.
330 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
334 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
335 the specified analysis task group as well as build requests associated with them.
337 (fetch_test_groups_for_task):
338 (fetch_build_requests_for_task):
339 (fetch_build_requests_for_group):
341 (format_build_request):
343 * public/include/json-header.php:
344 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
347 * public/privileged-api/associate-bug.php:
348 (main): Fixed a typo.
350 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
353 (ensure_config_from_runs):
355 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
357 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
359 (App.AnalysisTask.create):
361 (App.TestGroupAdapter):
362 (App.AnalysisTaskSerializer):
363 (App.TestGroupSerializer):
366 * public/v2/app.css: Added style rules for the analysis page.
369 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
371 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
372 exactly one selected point as we can still create an analysis task.
373 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
374 grammatical and also alert'ed the error message when there is one.
375 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
376 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
377 once XHR request has completed.
378 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
379 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
380 is selected in the details pane.
382 (App.AnalysisRoute): Added.
383 (App.AnalysisTaskRoute): Added.
384 (App.AnalysisTaskViewModel): Added.
385 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
386 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
387 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
388 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
389 the user selects an option for all roots in A or B configuration.
390 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
392 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
395 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
396 point so that we can use it in App.AnalysisTaskViewModel.roots.
397 (TimeSeries.prototype.findPointByMeasurementId): Added.
398 (TimeSeries.prototype.seriesBetweenPoints): Added.
400 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
401 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
402 when multiple points are selected. Finally, added a new template for the analysis task page.
404 * public/v2/manifest.js:
405 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
406 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
407 App.AnalysisTaskViewModel._taskUpdated.
409 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
411 Remove App.PaneController.bugsChangeCount in the new perf dashboard
412 https://bugs.webkit.org/show_bug.cgi?id=138111
414 Reviewed by Darin Adler.
417 (App.PaneController.bugsChangeCount): Removed.
418 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
419 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
420 Finds the list of current run's points that are associated with bugs.
421 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
422 * public/v2/chart-pane.css:
423 (.chart .marked): Renamed from .hasBugs.
424 * public/v2/index.html: Specify chartPointRadius and markedPoints.
426 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
428 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
429 https://bugs.webkit.org/show_bug.cgi?id=138099
431 Reviewed by Benjamin Poulain.
433 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
434 _showDetails inverting the order of the current and old measurements.
437 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
438 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
439 current (latest) measurement and the first point is the oldest measurement.
440 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
442 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
444 Perf dashboard should provide a way to associate bugs with a test run
445 https://bugs.webkit.org/show_bug.cgi?id=137857
447 Reviewed by Andreas Kling.
449 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
450 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
451 the Apache configuration.
454 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
455 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
456 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
457 via the cookie and returns a token computed from those two values as well as the remote username.
459 The font end code then POST's the request along with the returned token. The server side code verifies
460 that the specified token can be generated from the salt and the expiration time set in the cookie, and
461 the token hasn't expired.
464 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
465 have zero or exactly one bug associated with a test run.
467 * public/admin/bug-trackers.php: Added the support for editing bug_url.
468 * public/api/runs.php:
469 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
470 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
471 an associated bug if there is one.
472 (format_run): Calls parse_bugs_array.
474 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
475 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
476 have a valid JSON payload.
477 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
478 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
479 the expiration time stored in the cookie.
480 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
482 * public/include/manifest.php:
483 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
484 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
487 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
489 * public/privileged-api/associate-bug.php: Added.
490 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
491 attack via ensure_privileged_api_data_and_token, which calls verify_token.
493 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
496 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
500 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
501 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
502 they would overlap on each other if both of them are shown.
503 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
504 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
505 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
506 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
507 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
508 showing the search pane.
509 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
510 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
511 bugs in the selected range.
513 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
514 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
515 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
516 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
517 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
518 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
519 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
520 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
522 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
523 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
524 to selectionChanged action instead of just finding the first and the last points.
526 * public/v2/chart-pane.css: Updated the style.
529 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
530 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
531 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
532 we haven't already obtained a CSRF token or if the token has already been expired.
533 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
535 (Measurement.prototype.bugs): Added.
536 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
537 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
539 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
542 * public/v2/manifest.js:
543 (App.BugTracker.bugUrl):
544 (App.BugTracker.newBugUrl): Added.
545 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
546 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
547 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
548 (App.Manifest.bugTrackers): Added.
549 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
550 their respective ids to make the ordering stable.
552 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
554 Remove unused jobs table
555 https://bugs.webkit.org/show_bug.cgi?id=137724
557 Reviewed by Daniel Bates.
559 Removed jobs table in the database as well as related code.
562 * public/admin/jobs.php: Removed.
563 * public/admin/tests.php:
564 * public/include/admin-header.php:
566 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
568 New perf dashboard should have an ability to search commits by a keyword
569 https://bugs.webkit.org/show_bug.cgi?id=137675
571 Reviewed by Geoffrey Garen.
573 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
574 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
575 This API change allows fetch_commits_between to generate results without processing Postgres query results.
577 In the front end side, we've added a search pane in pane controller, and the interactive chart component
578 now has a concept of highlighted items which is used to indicate commits found by the search pane.
580 * public/api/commits.php:
581 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
582 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
583 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
584 (format_commit): Renamed from format_commits. Now only formats one commit.
586 * public/include/db.php:
587 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
589 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
592 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
593 which is a hash table that contains highlighted items' measurements' ids as keys.
594 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
595 the default commit repository.
596 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
597 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
598 Added the code to initialize this._highlights.
599 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
600 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
601 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
602 the existing lines for the old highlighted items.
603 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
604 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
606 * public/v2/chart-pane.css: Added style for the search pane and the search button.
608 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
610 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
611 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
612 (CommitLogs._cacheConsecutiveCommits): Ditto.
613 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
614 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
615 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
617 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
618 for showingDetails since this property is no longer used.
620 * public/v2/manifest.js:
621 (App.Manifest.repositories): Added.
622 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
623 the default repository to search.
624 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
626 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
628 Unreviewed build fix after r174555.
630 * public/include/manifest.php:
631 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
632 * tests/admin-regenerate-manifest.js: Fixed the test case.
634 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
636 New perf dashboard UI tries to fetch commits all the time
637 https://bugs.webkit.org/show_bug.cgi?id=137592
639 Reviewed by Andreas Kling.
641 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
642 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
643 no reported commits as they are all going to fail.
645 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
646 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
647 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
648 of commits sorted chronologically by time.
650 * public/include/manifest.php:
653 (App.CommitsViewerComponent.commitsChanged):
656 (FetchCommitsForTimeRange):
657 (FetchCommitsForTimeRange._cachedCommitsByRepository):
659 * public/v2/manifest.js:
662 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
664 Another unreviewed build fix after r174477.
666 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
668 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
670 * public/include/report-processor.php:
672 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
674 Unreviewed build fix after r174477.
676 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
677 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
679 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
680 This is necessary for baseline and target values manually added via admin pages.
682 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
684 Add v2 UI for the perf dashboard
685 https://bugs.webkit.org/show_bug.cgi?id=137537
687 Rubber-stamped by Andreas Kling.
690 * public/v2/app.css: Added.
691 * public/v2/app.js: Added.
692 * public/v2/chart-pane.css: Added.
693 * public/v2/data.js: Added.
694 * public/v2/index.html: Added.
695 * public/v2/js: Added.
696 * public/v2/js/d3: Added.
697 * public/v2/js/d3/LICENSE: Added.
698 * public/v2/js/d3/d3.js: Added.
699 * public/v2/js/d3/d3.min.js: Added.
700 * public/v2/js/ember-data.js: Added.
701 * public/v2/js/ember.js: Added.
702 * public/v2/js/handlebars.js: Added.
703 * public/v2/js/jquery.min.js: Added.
704 * public/v2/js/statistics.js: Added.
705 * public/v2/manifest.js: Added.
706 * public/v2/popup.js: Added.
708 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
710 Remove superfluously duplicated code in public/api/report-commits.php.
712 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
714 Perf dashboard should store commit logs
715 https://bugs.webkit.org/show_bug.cgi?id=137510
717 Reviewed by Darin Adler.
719 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
721 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
722 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
723 a subversion directory. The git version of this script will be added in a follow up patch.
726 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
727 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
728 relationship via "build_commits" relations.
730 In order to migrate an existing instance of this application, run the following SQL commands:
734 INSERT INTO commits (commit_repository, commit_revision, commit_time)
735 (SELECT DISTINCT ON (revision_repository, revision_value)
736 revision_repository, revision_value, revision_time FROM build_revisions);
738 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
739 FROM commits, build_revisions
740 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
742 DROP TABLE build_revisions;
747 The helper script to submit commit logs can be used as follows:
749 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
750 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
752 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
753 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
754 "feeder-slave-password" as the builder name and the builder password respectively.
756 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
757 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
760 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
762 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
763 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
765 - Not specified - It returns every single commit for a given repository.
766 - Matches "oldest" - It returns the commit with the oldest timestamp.
767 - Matches "latest" - It returns the commit with the latest timestamp.
768 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
769 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
770 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
771 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
772 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
773 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
775 (commit_from_revision):
776 (fetch_commits_between):
779 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
780 See tests/api-report-commits.js for examples on how to use this API.
782 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
783 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
784 to optimize this and other JSON APIs.
786 * public/include/db.php:
787 (Database::select_or_insert_row):
788 (Database::update_or_insert_row): Added.
789 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
790 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
792 (Database::select_first_row):
793 (Database::select_last_row): Added.
794 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
795 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
797 * public/include/report-processor.php:
798 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
799 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
800 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
803 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
805 * tests/api-report-commits.js: Added.
806 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
809 * tools/pull-svn.py: Added. See above for how to use this script.
811 (determine_first_revision_to_fetch):
812 (fetch_revision_from_dasbhoard):
813 (fetch_commit_and_resolve_author):
816 (resolve_author_name_from_email):
819 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
821 Update Install.md for Mavericks and fix typos
822 https://bugs.webkit.org/show_bug.cgi?id=137276
824 Reviewed by Benjamin Poulain.
826 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
828 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
830 Finally, init-database.sql is no longer located inside database directory.
834 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
836 Report run id's in api/runs.php for the new dashboard UI
837 https://bugs.webkit.org/show_bug.cgi?id=135813
839 Reviewed by Andreas Kling.
841 Include run_id in the generated JSON.
843 * public/api/runs.php:
844 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
847 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
849 Merging platforms mixes baselines and targets into reported data
850 https://bugs.webkit.org/show_bug.cgi?id=135260
852 Reviewed by Andreas Kling.
854 When merging two platforms, move test configurations of a different type (baseline, target)
855 as well as of different metric (Time, Runs).
857 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
858 It's sufficient to detect one such test_runs object.
860 * public/admin/platforms.php:
863 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
865 Merging platforms mixes baselines and targets into reported data
866 https://bugs.webkit.org/show_bug.cgi?id=135260
868 Reviewed by Geoffrey Garen.
870 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
871 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
873 * public/admin/platforms.php:
875 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
877 Build fix after r171361.
879 * public/js/helper-classes.js:
880 (.this.formattedBuildTime):
882 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
884 Perf dashboard spends 2s processing JSON data during the page loads
885 https://bugs.webkit.org/show_bug.cgi?id=135152
887 Reviewed by Andreas Kling.
889 In the Apple internal dashboard, we were spending as much as 2 seconds
890 converting raw JSON data into proper JS objects while loading the dashboard.
892 This caused the apparent unresponsiveness of the dashboard despite of the fact
893 charts themselves updated almost instantaneously.
896 * public/js/helper-classes.js:
897 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
898 lazily as creating new Date objects and running string replace is expensive.
899 (TestBuild.formattedTime):
900 (TestBuild.formattedBuildTime):
901 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
902 (PerfTestRuns.addResult): Deleted.
904 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
906 Perf dashboard shouldn't show the full git hash
907 https://bugs.webkit.org/show_bug.cgi?id=135083
909 Reviewed by Benjamin Poulain.
911 Detect Git/Mercurial hash by checking the length.
913 If it's a hash, use the first 8 characters in the label
914 while retaining the full length to be used in hyperlinks.
916 * public/js/helper-classes.js:
917 (.this.formattedRevisions):
920 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
922 Add an instruction on how to backup the database.
923 https://bugs.webkit.org/show_bug.cgi?id=133391
925 Rubber-stamped by Andreas Kling.
929 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
931 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
933 * public/js/helper-classes.js:
934 (PerfTestRuns.smallerIsBetter):
936 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
946 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
948 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
949 https://bugs.webkit.org/show_bug.cgi?id=131157
951 Reviewed by Andreas Kling.
953 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
954 This allows, for example, adding all metrics such as Arithmetic and Geometric for
955 a given test suite without also adding its subtests.
961 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
963 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
964 https://bugs.webkit.org/show_bug.cgi?id=131155
966 Reviewed by Andreas Kling.
968 The bug was caused by Chart.attach binding event listeners on plot container on each call.
969 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
970 click when attach() has been called even number of times, keeping the tooltip invisible.
972 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
973 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
974 is called for the first time.
978 (Chart..bindPlotEventHandlers):
980 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
982 WebKitPerfMonitor: Tooltips can be cut off at the top
983 https://bugs.webkit.org/show_bug.cgi?id=130960
985 Reviewed by Andreas Kling.
988 (#title): Removed the gradients, box shadows, and border from the header.
989 (#title h1): Reduce the font size.
990 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
992 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
993 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
994 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
995 * public/js/helper-classes.js:
996 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
997 tooltip extending above y=0.
999 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1001 WebKitPerfMonitor: Y-axis adjustment is too aggressive
1002 https://bugs.webkit.org/show_bug.cgi?id=130937
1004 Reviewed by Andreas Kling.
1006 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
1007 results. This had two major problems:
1008 1. Two standard deviations can be too small to show the confidence interval for results.
1009 2. Sometimes baseline and target can be more than two standards deviations away.
1011 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
1012 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
1013 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
1014 the margin on each side separately to reduce the empty space on either side.
1016 A more rigorous approach would involve computing least squared value of results with respect to intervals
1017 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
1019 * public/index.html:
1020 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
1021 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
1022 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
1023 We wouldn't see the difference between measured values versus baseline and target values otherwise.
1024 * public/js/helper-classes.js:
1025 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
1026 interval delta cannot be computed.
1027 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
1028 within the given interval.
1029 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
1030 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
1031 (PerfTestRuns..unscaledMeansForAllResults):
1032 (PerfTestRuns.min): Take the confidence interval delta into account.
1033 (PerfTestRuns.max): Ditto.
1034 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
1035 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
1037 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
1039 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
1041 Some CSS tweaks after r166477 and r166479,
1043 * public/index.html:
1045 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1047 WebKitPerfMonitor: Sometimes text inside panes overlap
1048 https://bugs.webkit.org/show_bug.cgi?id=130956
1050 Reviewed by Gyuyoung Kim.
1052 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
1053 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
1054 reduces the total height of the pane and fits more information per screen capita on the dashboard.
1056 * public/index.html: Updated and added a bunch of CSS rules for the new look.
1057 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
1058 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
1059 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
1060 of the build info shown in a chart pane and a tooltip.
1061 (Chart): Made .status a table.
1062 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
1063 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
1064 now that status.text no longer contains it.
1065 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
1067 * public/js/helper-classes.js:
1068 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
1069 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
1070 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
1071 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
1072 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
1073 capital letter; e.g. "MB" instead of "M B".
1075 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1077 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
1078 https://bugs.webkit.org/show_bug.cgi?id=130957
1080 Reviewed by Gyuyoung Kim.
1082 Moved the slider into the header. Also reduced the spacing between the header and platform names.
1083 This reclaims 50px × width of the screen real estate.
1085 * public/common.css:
1086 (#title): Reduced the space below the header from 20px to 10px.
1087 * public/index.html:
1088 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
1089 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
1090 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
1091 real estate between the header and the platform names.
1093 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
1095 Update the install guidelines for perf.webkit.org
1096 https://bugs.webkit.org/show_bug.cgi?id=129895
1098 Reviewed by Ryosuke Niwa.
1100 The current install guideline for perf.webkit.org discourages the use of the installed
1101 Server application. I've actualized the documentation for Mavericks, and modified the
1102 guideline to include the instructions for Server.app also.
1106 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
1108 Update perf.webkit.org json example
1109 https://bugs.webkit.org/show_bug.cgi?id=129907
1111 Reviewed by Andreas Kling.
1113 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
1117 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
1119 Merge database-common.js and utility.js into run-tests.js.
1121 Reviewed by Matthew Hanson.
1123 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
1124 Also moved init-database.sql out of the database directory and removed the directory entirely.
1126 * database: Removed.
1127 * database/database-common.js: Removed.
1128 * database/utility.js: Removed.
1129 * init-database.sql: Moved from database/init-database.sql.
1131 (connect): Moved from database-common.js.
1132 (pathToDatabseSQL): Extracted from pathToLocalScript.
1133 (pathToTests): Moved from database-common.js.
1136 (SerializedTaskQueue): Ditto.
1138 (initializeDatabase):
1139 (TestEnvironment.it):
1140 (TestEnvironment.queryAndFetchAll):
1143 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1145 Remove the dependency on node.js from the production code.
1147 Reviewed by Ricky Mondello.
1149 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
1151 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
1152 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
1153 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
1154 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
1155 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
1157 Also removed the js files that are no longer used.
1159 * config.json: Moved from database/config.json.
1160 * database/aggregate.js: Removed. No longer used.
1161 * database/database-common.js: Removed unused functions, and updated the path to config.json.
1162 * database/process-jobs.js: Removed. No longer used.
1163 * database/sample-data.sql: Removed. We have a much better corpus of data now.
1164 * database/schema.graffle: Removed. It's completely obsolete.
1165 * public/include/db.php: Updated the path to config.json.
1166 * public/include/evaluator.js: Removed.
1168 * public/include/report-processor.php:
1169 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
1170 storing values into $expressions and calling evaluate_expressions_by_node.
1171 (TestRunsGenerator::aggregate_values): Added.
1172 (TestRunsGenerator::compute_caches): Directly compute the caches.
1174 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1176 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
1178 * public/admin/platforms.php:
1179 * public/include/db.php:
1181 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1183 Zoomed y-axis view is ununsable when the last result is an outlier.
1185 Reviewed by Stephanie Lewis.
1187 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
1188 the last result so that the graph looks sane if the last result was an outlier. However, always show
1189 the last result's mean even if it was an outlier.
1191 * public/index.html:
1192 * public/js/helper-classes.js:
1193 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
1194 Also added the ability to cache the unscaled means to avoid recomputation.
1195 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
1196 (PerfTestRuns.max): Ditto.
1197 (PerfTestRuns.sampleStandardDeviation): Ditto.
1198 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
1200 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1204 * public/admin/tests.php:
1205 * public/js/helper-classes.js:
1207 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
1209 Use two standard deviations instead as I mentioned in the mailing list.
1211 * public/index.html:
1213 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1215 The performance dashboard erroneously shows upward arrow for combined metrics.
1217 A single outlier can ruin the zoomed y-axis view.
1219 Rubber-stamped by Antti Koivisto.
1221 * public/index.html:
1222 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
1223 from the latest results' mean.
1224 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
1225 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
1226 (Chart.toggleYAxis):
1227 * public/js/helper-classes.js:
1228 (PerfTestRuns.sampleStandardDeviation): Added.
1229 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
1231 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1233 Don't include the confidence interval when computing the y-axis.
1235 Rubber-stamped by Simon Fraser.
1237 * public/js/helper-classes.js:
1241 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1243 Tiny CSS tweak for tooltips.
1245 * public/index.html:
1247 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1249 Remove the erroneously repeated code.
1251 * public/admin/test-configurations.php:
1253 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1255 <rdar://problem/15704893> perf dashboard should show baseline numbers
1257 Reviewed by Stephanie Lewis.
1259 * public/admin/bug-trackers.php:
1260 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
1263 * public/admin/platforms.php:
1264 (merge_list): Ditto.
1266 * public/admin/test-configurations.php: Added.
1267 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
1268 build_revisions as they're not meaningful for baseline / target numbers.
1269 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
1270 one test run so that we don't accidentally delete a reported test run.
1271 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
1272 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
1273 and delete existing ones.
1275 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
1276 on each platform; there could be configurations of distinct types such as "current" and "baseline".
1277 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
1279 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
1280 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
1281 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
1282 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
1283 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
1285 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
1287 * public/include/admin-header.php:
1288 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
1289 have id and type sub columns, and each custom column could generate multiple rows.
1291 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
1292 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
1293 We then proceed to generate the second header row with sub column names.
1295 When generating the actual content, we first generate all custom columns as they may have multiple rows in
1296 which case regular columns need rowspan set to the maximum number of rows.
1298 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
1301 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
1302 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
1303 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
1304 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
1305 expanded to occupy all sub columns.
1307 * public/include/manifest.php:
1308 (ManifestGenerator::platforms): Don't add the metric more than once.
1310 * public/include/test-name-resolver.php:
1311 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
1312 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
1313 full metric name later.
1314 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
1315 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
1316 (TestNameResolver::full_name_for_test): Added.
1317 (TestNameResolver::full_name_for_metric): Added.
1318 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
1320 * public/js/helper-classes.js:
1321 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
1322 test runs created to set baseline and target points.
1324 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1326 Build fix after r57928. Removed a superfluous close parenthesis.
1328 * public/api/runs.php:
1330 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1332 Unreviewed build & typo fixes.
1334 * public/admin/platforms.php:
1335 * tests/admin-platforms.js:
1337 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1339 <rdar://problem/15704893> perf dashboard should show baseline numbers
1341 Rubber-stamped by Antti Koivisto.
1343 Organize some code into functions in runs.php.
1345 Also added back $paths that was erroneously removed in r57925 from json-header.php.
1347 * public/api/runs.php:
1348 (fetch_runs_for_config): Extracted.
1349 (format_run): Ditto.
1351 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1353 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
1355 * database/config.json:
1356 * public/admin/reprocess-report.php:
1357 * public/api/report.php:
1358 * public/api/runs.php:
1359 * public/include/json-header.php:
1361 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1363 Commit yet another forgotten change.
1365 Something went horribly wrong with my merge :(
1367 * database/init-database.sql:
1369 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1371 Commit one more forgotten change. Sorry for making a mess here.
1373 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1375 Commit the forgotten files.
1377 * public/admin/platforms.php: Added.
1378 * tests/admin-platforms.js: Added.
1380 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1382 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
1384 Reviewed by Stephanie Lewis.
1386 Added /admin/platforms/ page to hide and merge platforms.
1388 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
1389 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
1390 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
1391 each test configuration a distinct "test run" for each build.
1393 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
1394 their test configurations into platform B.
1396 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
1397 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
1398 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
1399 in platform B, in which case R should relate to T_B instead.
1401 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
1402 new platform. We then migrate the test configurations of the remaining test runs.
1404 * database/init-database.sql: Added platform_hidden.
1406 * public/admin/platforms.php: Added.
1407 (merge_platforms): Added. Implements the algorithm described above.
1408 (merge_list): Added.
1410 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
1411 is hidden since it doesn't do anything.
1413 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
1414 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
1415 missing it since unchecked checkbox doesn't set the value in $_POST.
1416 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
1417 switch statement instead of repeated if's.
1418 (AdministrativePage::render_table): Emit "update-column" for update_field.
1420 * public/include/db.php: Disable warnings when we're not in the debug mode.
1422 * public/include/manifest.php:
1423 (ManifestGenerator::platforms): Skip platforms that have been hidden.
1426 (TestEnvironment.postJSON):
1427 (TestEnvironment.httpGet):
1428 (TestEnvironment.httpPost): Added.
1429 (sendHttpRequest): Set the content type if specified.
1431 * tests/admin-platforms.js: Added tests.
1433 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
1435 Extract the code to compute full test names from tests.php.
1437 Reviewed by Stephanie Lewis.
1439 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
1440 and paves our way to re-use the code in other pages.
1442 * public/admin/tests.php:
1444 * public/include/db.php:
1445 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
1446 tests.php and test-name-resolver.php.
1448 * public/include/test-name-resolver.php: Added.
1449 (TestNameResolver::__construct):
1450 (TestNameResolver::compute_full_name): Moved from tests.php.
1451 (TestNameResolver::map_metrics_to_tests): Ditto.
1452 (TestNameResolver::sort_tests_by_full_name): Ditto.
1453 (TestNameResolver::tests): Added.
1454 (TestNameResolver::test_id_for_full_name): Ditto.
1455 (TestNameResolver::metrics_for_test_id): Ditto.
1456 (TestNameResolver::child_metrics_for_test_id): Ditto.
1457 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
1459 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1461 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1463 Reviewed by Stephanie Lewis.
1465 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
1467 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
1468 but that's sufficient to correct the wrongfully processed reports for now.
1470 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
1471 We should eventually add a nice UI to find and reprocess reports.
1473 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
1475 * public/include/db.php: Added the forgotten call to prefixed_column_names.
1477 * public/include/report-processor.php: Copied from public/api/report.php.
1478 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
1479 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
1480 create a new report or authenticate the builder password (the password is never stored in the report).
1481 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
1482 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
1483 (ReportProcessor::store_report): Ditto.
1485 * tests/admin-reprocess-report.js: Added.
1487 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1489 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1491 Reviewed by Ricky Mondello.
1493 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
1494 for the same build number as a single build by ignoring build time. This was necessary to associate
1495 multiple reports by a single build - e.g. for different performance test suites - because the scripts
1496 we use to submit results computed its own "build time" when they're called.
1498 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
1499 last week; new reports were wrongfully associated with old build numbers.
1501 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
1502 to the same build. Instead, we create a new build object for those reports. Since the longest set of
1503 tests we have only take a couple of hours to run, 24 hours should be more than enough.
1505 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
1506 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
1507 (builder, build number, build time).
1509 * public/api/report.php:
1510 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
1511 when no such build exists. This prevents a report from being associated with a very old build of the same
1514 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
1515 a similar bug in the future sooner.
1517 * tests/api-report.js: Added three test cases.
1519 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1521 Merged the upstream changes to db.php
1522 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
1524 * public/include/db.php:
1526 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1528 Update other scripts and tests per previous patch.
1530 * public/include/manifest.php:
1531 * tests/admin-regenerate-manifest.js:
1533 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1535 Remove metrics_unit.
1537 Reviewed by Ricky Mondello.
1539 This column is no longer used by the front-end code since r48360.
1541 * database/init-database.sql:
1542 * public/admin/tests.php:
1544 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
1546 Unreviewed build fix.
1548 * public/api/report.php:
1550 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
1552 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
1554 Reviewed by Ricky Mondello.
1556 Support a new alternative format for aggregated results where we have raw values as well as
1557 the list aggregators so that instead of
1558 "metrics": {"Time": ["Arithmetic"]}
1560 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
1562 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
1563 dashboard and the generated results page, which doesn't know how to aggregate values.
1565 We need to keep the support for the old format because all other existing performance tests
1566 all rely on the old format. Even if we updated the tests, we need the dashboard to support
1567 the old format during the transition.
1569 * public/api/report.php:
1570 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
1571 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
1573 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
1575 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1577 Unreviewed; Tweak the CSS so that chart panes align vertically.
1579 * public/index.html:
1581 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1583 SafariPerfMonitor should support Combined metric.
1585 * public/js/helper-classes.js:
1586 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
1587 value as well but assume it to be greater-is-better for now.
1589 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1591 Commit the forgotten init-database change to add iteration_relative_time.
1593 * database/init-database.sql:
1595 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1597 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
1599 Reviewed by Ricky Mondello.
1601 Add the support for each value to have a relative time. This is necessary for frame rate history
1602 since a frame rate needs to be associated with a time it was sampled.
1604 * database/init-database.sql: Added iteration_relative_time to run_iterations.
1606 * public/api/report.php:
1607 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
1608 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
1609 with relative time since taking the average of two frame rates for two subtests taken at two
1610 different times doesn't make any sense.
1611 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
1612 etc..., use the second element since we assume values are of the form (relative time, frame rate).
1613 Also exit early with an error if the number of elements in the array is not a pair.
1614 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
1616 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
1617 iteration_relative_time.
1619 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
1621 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
1623 Reviewed by Ricky Mondello.
1625 Support that. It's one line change.
1627 * public/api/report.php:
1628 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
1629 to match the convention assumed elsewhere.
1630 * tests/api-report.js: Added a test case.
1632 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1634 SafariPerfMonitor shows popups for points outside of the visible region.
1636 Rubber-stamped by Simon Fraser.
1638 * public/index.html:
1639 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
1640 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
1641 may return an item underneath y-axis labels.
1643 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1645 Tweak the CSS a little to avoid the test name overlapping with the summary table.
1647 * public/index.html:
1649 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1651 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
1653 * public/index.html:
1655 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1657 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
1658 <rdar://problem/13992271> Should scale Y axis to include error ranges
1660 Reviewed by Ricky Mondello.
1662 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
1663 the main graph doesn't go outside the graph even when the y-axis is adjusted.
1665 * database/config.json:
1666 * public/index.html:
1667 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
1668 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
1669 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
1671 * public/js/helper-classes.js:
1672 (PerfTestResult.confidenceIntervalDelta):
1673 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
1674 (PerfTestRuns.min): Take confidence interval delta into account.
1675 (PerfTestRuns.max): Ditto.
1676 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
1678 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1680 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
1682 * public/api/report.php:
1683 (ReportProcessor::recursively_ensure_tests):
1684 * tests/api-report.js: Added a test.
1686 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1688 Unreviewed build fixes.
1690 * public/api/report.php:
1691 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
1692 Also, tolerate reports without any revision information.
1694 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
1697 * tests/api-report.js: Added few test cases.
1699 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1701 Commit another change that was supposed to be committed in r50331.
1704 (TestEnvironment.this.postJSON):
1705 (TestEnvironment.this.httpGet):
1708 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
1710 Commit the remaining files.
1712 * public/admin/regenerate-manifest.php:
1713 * public/include/admin-header.php:
1714 * public/include/json-header.php:
1715 * public/include/manifest.php:
1717 (TestEnvironment.this.postJSON):
1718 (TestEnvironment.this.httpGet):
1721 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
1723 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
1725 Reviewed by Ricky Mondello.
1727 Added some tests for admin/regenerate-manifest.
1729 * public/admin/regenerate-manifest.php: Use require_once instead of require.
1730 * public/include/admin-header.php: Ditto.
1731 * public/include/json-header.php: Ditto.
1733 * public/include/manifest.php:
1734 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
1735 When there are no builders, simply return an empty array.
1738 (TestEnvironment.postJSON):
1739 (TestEnvironment.httpGet): Added.
1740 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
1742 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
1744 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
1746 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
1747 and run_iterations. Also fixed a typo in report.php found by new tests.
1749 * public/api/report.php:
1750 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
1751 * tests/api-report.js: Added more test cases.
1753 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
1755 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
1757 Reviewed by Ricky Mondello.
1759 Add a test runner script and some simple test cases.
1761 * database/config.json: Added the configuration for "testServer".
1762 * database/database-common.js:
1763 (pathToTests): Added.
1764 * run-tests.js: Added.
1767 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
1768 and if there are, asks the user if it’s okay to delete all of the data contained therein.
1769 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
1771 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
1772 in the current database using PostgreSQL's information_schema.
1773 (askYesOrNoQuestion):
1775 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
1777 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
1778 (TestEnvironment.assert): Exposes assert to tests.
1779 (TestEnvironment.console): Exposes console to tests.
1780 (TestEnvironment.describe): Adds a description.
1781 (TestEnvironment.it): Adds a test case.
1782 (TestEnvironment.postJSON):
1783 (TestEnvironment.queryAndFetchAll):
1784 (TestEnvironment.sha256):
1785 (TestEnvironment.notifyDone): Ends the current test case.
1789 (TestContext): An object created for each test case. Conceptually, this object is always on
1790 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
1791 this object via currentTestContext.
1792 (TestContext.description):
1794 (TestContext.logError):
1797 * tests/api-report.js: Added some basic tests for /api/report.php.
1799 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1801 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
1803 The problem was that we were detecting whether we're updating dashboard or not by checking
1804 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
1805 all configurations. Use separate 'dashboard' action to execute the code even when
1806 metric_configurations is empty.
1808 * public/admin/tests.php:
1810 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1812 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
1814 Reviewed by Ricky Mondello.
1816 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
1817 from ReportProcessor as a preparation to replace deprecated aggregate.js.
1819 * public/api/report.php:
1820 (ReportProcessor::exit_with_error): Moved.
1821 (ReportProcessor::process): Use the extracted TestRunsGenerator.
1822 (TestRunsGenerator): Added.
1823 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
1824 (TestRunsGenerator::add_aggregated_metric): Moved.
1825 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
1826 (TestRunsGenerator::aggregate): Moved. Made public.
1827 (TestRunsGenerator::aggregate_current_test_level): Moved.
1828 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
1829 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
1830 (TestRunsGenerator::compute_caches): Moved. Made public.
1831 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
1832 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
1833 (TestRunsGenerator::rollback_with_error): Moved.
1835 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1837 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
1839 Reviewed by Remy Demarest.
1841 Regenerate the manifest file when updating fields or adding new items that are included in
1844 * public/admin/bug-trackers.php:
1845 * public/admin/builders.php:
1846 * public/admin/regenerate-manifest.php:
1847 * public/admin/repositories.php:
1848 * public/admin/tests.php:
1849 * public/include/admin-header.php:
1850 (regenerate_manifest): Extracted from regenerate-manifest.php.
1852 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1854 Unreviewed build fix for memory test results.
1856 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
1857 aggregating at each level.
1859 * public/api/report.php:
1860 (ReportProcessor::recursively_ensure_tests):
1861 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
1862 (ReportProcessor::add_values_for_aggregation):
1863 (ReportProcessor::aggregate):
1864 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
1866 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1868 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
1869 not the number of iteration groups. Also, don't set group number when the entire run belongs
1870 a single iteration group.
1872 * public/api/report.php:
1873 (ReportProcessor::commit):
1875 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1877 SafariPerfMonitor: Introduce iteration groups
1879 Reviewed by Remy Demarest.
1881 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
1882 the runtime environment variances to get more stable results. And it's desirable to keep track of
1883 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
1885 This patch introduces "iteration groups" to keep track of this extra information.
1887 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
1888 the outer array denotes iteration groups and each inner array contains iteration values for each group.
1891 * database/init-database.sql: Add iteration_group column.
1892 * public/api/report.php:
1893 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
1895 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
1896 contains the list of values indexed by the iteration order and group sizes. Store the group size so
1897 that we can restore the iteration groups before passing it to node.js and restore them later.
1899 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
1900 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
1902 Also check that each iteration group in each subtest are consistent with one another. To see why we need
1903 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
1904 that each iteration group in T1 and T2 have the same size:
1905 T1 = [[1, 2], [3, 4, 5]]
1906 T2 = [[6, 7], [8, 9, 10]]
1908 so that the aggregated result (the sum in this case) can have the same groups as in:
1909 T = [[7, 9], [11, 13, 15]]
1911 If some iteration groups in T1 and T2 had a different size as in:
1912 T1 = [[1, 2, 3], [4, 5]]
1913 T2 = [[6, 7], [8, 9, 10]]
1915 Then iteration groups of the aggregated T is ambiguous.
1917 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
1918 (ReportProcessor::commit): Store iteration_group values.
1920 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1922 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
1923 migrated to perf.webkit.org.
1925 * database/perf-webkit-migrator.js: Removed.
1927 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1929 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
1931 * public/index.html:
1934 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1936 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
1938 Reviewed by Ricky Mondello.
1940 It is often desirable to see charts of a given test for all platforms, or to be able to see
1941 charts of all subtests on a given platform when trying to triage perf. regressions.
1943 Support this use case by adding the ability to do so on the charts page.
1945 Also, we used to disable items on the test list based on the platform chosen. This turned out
1946 to be a bad UI because in many situations you want to be able to compare results of the same test
1947 on multiple platforms.
1949 In this new UI, we have three select elements, each of which selects the following:
1950 1. Top-level test - Test suite such as Dromaeo
1951 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
1952 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
1953 3. Platform - Mountain Lion, Qt, etc...
1955 A user can select "all" for metric and platform but we disallow doing both at once since adding
1956 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
1957 think of a use case where you want to look at that many charts at once. We can support this later
1958 if valid use cases come up.
1960 * public/index.html:
1961 (.showCharts.addOption): Extracted.
1962 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
1963 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
1964 metricList has onchange handler that enables/disables items on platformList.
1966 (init): Sort tests and test metrics here instead of doing that in showCharts.
1968 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
1970 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
1972 Reviewed by Remy Demarest and Ricky Mondello.
1974 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
1975 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
1976 templates to the manifest file instead. Each build now only contains the builder id.
1978 * public/api/runs.php: Removed the part of the query that joined builders table. This
1979 speeds up the query quite a bit.
1981 * public/include/manifest.php:
1982 (ManifestGenerator::generate): Generate builders field.
1983 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
1984 associative array that contains name and its build URL template.
1986 * public/index.html:
1987 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
1988 instead of a revision since this function is used for revisions and build page URLs now.
1989 (.buildLabelWithLinks): Include the linkified build number.
1991 * public/js/helper-classes.js:
1992 (TestBuild.builder): Added.
1993 (TestBuild.buildNumber): Added.
1994 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
1995 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
1997 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
1999 Tooltips interfere with user interactions
2001 Rubber-stamped by Simon Fraser.
2003 Disable tooltip on the dashboard page since graphs are too small to be useful there.
2004 Also, show graphs for only 10 days by default as opposed to 20.
2005 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
2007 * public/index.html:
2008 * public/js/helper-classes.js:
2010 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
2012 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
2013 to be compatible with webkit-perf.appspot.com.
2015 * public/admin/builders.php:
2016 * public/api/report.php:
2018 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
2022 Add a missing constraint on builds table. For a given builder, there should be exactly
2023 one build for a given build number.
2025 Also add report_committed_at to reports table to record the time at which a given report
2026 was processed and test_runs and run_iterations rows were committed into the database.
2028 * database/config.json:
2029 * public/api/report.php:
2031 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
2033 Unreviewed. Add more checks for empty SQL query results.
2035 * public/include/manifest.php:
2037 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2039 More build fixes on perf.webkit.org.
2041 * public/api/runs.php: Make PostgreSQL happier.
2042 * public/include/manifest.php: Don't assume we always have bug trackers.
2044 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2046 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
2047 and fix other miscellaneous UI bugs.
2049 Rubber-stamped by Simon Fraser.
2051 Removed the code to determine whether smaller value is better or not for a given test in index.html
2052 in the favor of using that of PerfTestRuns.
2054 * public/include/manifest.php: Fixed a typo.
2055 * public/index.html:
2057 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
2059 * public/js/helper-classes.js:
2060 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
2062 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
2063 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
2064 at roughly 2,000 units to avoid this.
2066 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
2067 The only thing we can avoid is innerHTML.
2069 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2071 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
2073 * public/include/evaluator.js:
2075 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2077 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
2079 Reviewed by Remy Demarest.
2081 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
2082 admin/bug-trackers.php and can be associated with multiple repositories.
2084 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
2085 to determine the set of bug trackers to show for a given set of blame lists.
2086 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
2087 a place to file bugs against the regression.
2089 * database/init-database.sql: Added bug_trackers and tracker_repositories.
2090 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
2092 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
2093 bug trackers, namely associated repositories.
2095 * public/include/admin-header.php: Added a link to bug-trackers.php
2096 * public/include/manifest.php:
2097 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
2098 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
2100 (ManifestGenerator::repositories):
2102 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
2103 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
2104 'repositories' where the latter contains the list of associated repository names.
2106 * public/index.html:
2107 (Chart): Takes bugTrackers as as argument.
2108 (Chart.showTooltipWithResults): Removed the hard-coded list.
2110 (init.addPlatformsToDashboard):
2111 (init.showCharts.createChartFromListPair):
2112 (init): Stores the list of bug trackers in the manifest to a local variable.
2114 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2116 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
2118 * public/include/evaluator.js:
2120 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2122 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
2124 Reviewed by Remy Demarest.
2126 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
2127 new row into the database.
2129 * public/admin/aggregators.php: Use AdministrativePage.
2130 * public/admin/builders.php: Ditto.
2131 * public/admin/repositories.php: Ditto.
2132 * public/include/admin-header.php:
2133 (AdministrativePage): Added.
2134 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
2135 to an associative array that describes the column.
2136 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
2137 - label: Human readable name of the column.
2138 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
2139 column exists only before we create password_hash column at the insertion time.
2141 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
2142 titlecase (e.g. new_bug is converted to New Bug).
2143 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
2144 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
2145 textarea for a given editing mode ('text', 'url', or 'string').
2146 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
2147 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
2149 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
2151 Build fix. Some systems don't support r+. Use proc_open instead.
2153 * public/api/report.php:
2155 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2157 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
2158 when computing the y-axis of data points to show tooltips at.
2160 * public/index.html:
2162 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2164 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
2167 * public/.htaccess: Removed.
2169 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
2173 * public/include/manifest.php: Build fix. db is on this.
2174 * public/js/statistics.js:
2175 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
2177 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
2179 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
2181 Reviewed by Anders Carlsson.
2183 Rewrote and merged populate-from-report.js into report.php.
2185 * database/config.json: Added a path to node.js.
2187 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
2188 Once we land this patch and update the administrative pages, we can remove this column.
2190 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
2191 that table is going away once we remove the node.js backend.
2193 * database/populate-from-report.js: Removed.
2194 * public/api/report.php: Added.
2196 (ReportProcessor.__construct):
2197 (ReportProcessor.process):
2199 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
2200 verified to be submitted by a known builder.
2202 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
2203 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
2204 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
2205 inside a transaction because there could be multiple reports for a single build, each containing results for
2208 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
2209 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
2210 add_values_to_commit, and add_values_for_aggregation.
2212 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
2213 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
2214 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
2217 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
2218 to be aggregated in ReportProcessor.aggregate.
2220 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
2222 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
2223 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
2224 given for each row (child metrics of M). This function extracts each column (iteration) via
2225 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
2226 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
2228 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
2229 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
2230 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
2232 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
2233 (ReportProcessor.evaluate_expressions_by_node): See above.
2235 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
2236 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
2237 results also need the said caches.
2239 (ReportProcessor.add_values_to_commit):
2241 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
2242 the transaction as needed if anything goes wrong.
2244 (ReportProcessor.rollback_with_error)
2246 * public/include/db.php:
2247 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
2248 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
2249 contiguously in a SQL statement.
2251 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
2252 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
2253 a column value of the choice.
2255 (Database.begin_transaction): Added.
2256 (Database.commit_transaction): Added.
2257 (Database.rollback_transaction): Added.
2259 * public/include/evaluator.js: Added.
2260 * public/include/json-header.php:
2261 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
2262 context under which the request failed.
2263 (successful_exit): Merge "additional details".
2264 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
2265 (merge_additional_details):
2267 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
2269 SafariPerfMonitor: Add more helper functions to db.php
2271 Reviewed by Remy Demarest.
2273 Added Database::insert_row and array_get to make common database operations easier.
2275 * public/admin/aggregators.php: Use Database::insert_row instead of
2276 execute_query_and_expect_one_row_to_be_affected.
2278 * public/admin/builders.php: Ditto.
2280 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
2281 inserting a row. With insert_row, we don't need that.
2283 * public/include/admin-header.php: Ditto.
2285 * public/include/db.php:
2286 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
2287 return the default value (defaults to NULL) if the key doesn't exist.
2289 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
2292 (Database::prepare_params): Added. Takes an associative array of column names and their values,
2293 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
2294 column names all in the same order.
2296 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
2297 the given prefix. Values are given in a form of an associative array where keys are unprefixed
2298 column names and values are corresponding values. When the row is successfully inserted, it returns
2299 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
2300 indicating the success of the insertion.
2302 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2304 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
2306 Reviewed by Conrad Shultz.
2308 Rewrote the manifest generator in PHP.
2310 * database/generate-manifest.js: Removed.
2311 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
2312 * public/include/db.php:
2313 (array_ensure_item_has_array): Added.
2314 * public/include/evaluator.js: Added.
2315 * public/include/json-header.php:
2316 * public/include/manifest.php: Added.
2318 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2320 Dates on overflow plot are overlapping
2322 Rubber-stamped by Simon Fraser.
2324 Don't show more than 5 days.
2326 * public/index.html:
2327 * public/js/helper-classes.js:
2328 (TestBuild.UTCtoPST):
2331 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2333 Show build time as well as commit time on the dashboard and tooltips.
2335 Rubber-stamped by Simon Fraser.
2337 Include both the maximum commit time and build time in buildLabelWithLinks.
2338 Also use ISO format to save the screen real estate.
2340 * public/index.html:
2341 (buildLabelWithLinks):
2342 * public/js/helper-classes.js:
2344 (TestBuild.buildTime):
2345 (TestBuild.formattedBuildTime):
2347 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
2349 Unreviewed; Convert metric.name to metric.unit in the front end.
2351 * public/js/helper-classes.js:
2353 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2355 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
2357 Rubber-stamped by Simon Fraser.
2359 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
2360 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
2361 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
2363 * public/index.html:
2364 (.buildLabelWithLinks): Extracted from TestBuild.label.
2365 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
2366 on Radar and WebKit Bugzilla.
2367 * public/js/helper-classes.js:
2368 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
2369 (PerfTestResult.isBetterThan): Added.
2370 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
2371 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
2372 to indicate progressions or regressions.
2373 (PerfTestResult.label):
2374 (TestBuild.formattedTime): Added.
2375 (TestBuild.platform): Added.
2376 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
2377 (TestBuild.smallerIsBetter): Added.
2378 (Tooltip.show): Take a raw markup instead of two results.
2380 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
2382 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
2384 Rubber-stamped by Tim Horton.
2386 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
2387 since each platform may have a different number of tests to be shown on the dashboard.
2389 * public/index.html:
2391 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2393 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
2395 * public/js/helper-classes.js:
2398 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2400 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
2402 Rubber-stamped by Tim Horton.
2404 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
2406 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
2407 the revision r1234 was the revision used in the previous build.
2409 * public/api/runs.php:
2410 (parse_revisions_array): Trim double quotations around repository names and revisions.
2411 * public/js/helper-classes.js:
2414 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2416 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
2418 Rubber-stamped by Tim Horton.
2420 * public/index.html:
2421 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
2422 on the dashboard page as it's way too noisy.
2424 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
2426 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
2427 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
2428 so that the tooltip for hover can be reused further.
2430 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
2431 and find the first point that lies on the right of the cursor position. We then compute the midpoint
2432 between this and the previous point and pick the closer of the two. It returns an item-like object
2433 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
2435 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
2437 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
2438 the first or "current" data points (as opposed to target or baseline data points).
2440 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
2441 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
2442 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
2444 * public/js/helper-classes.js:
2445 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
2446 work to the client via bindClick.
2448 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
2450 (Tooltip.bindClick): Added.
2452 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2454 Yet another build fix. metricId*s*.
2456 * public/admin/tests.php:
2458 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2460 Another build fix. Use the new payload format for the aggregate job.
2462 * public/admin/tests.php:
2464 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2468 * database/aggregate.js: Use variables that actually exist.
2469 * database/database-common.js:
2470 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
2471 function calls will find this configuration.
2473 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2475 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
2477 Reviewed by Ricky Mondello.
2479 Turned InstallManual into a proper markdown document and added ReadMe.md.
2481 * InstallManual: Removed.
2482 * InstallManual.md: Moved from InstallManual.
2485 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2487 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
2489 Reviewed by Ricky Mondello.
2491 This patch prepares the front end code to process baseline and target results properly.
2493 * public/index.html:
2494 (fetchTest.createRunAndResults): Extracted.
2495 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
2496 Deleted the comment about how sorting will be unnecessary once we start results in the server side
2497 since sorting by the maximum revision commit time turned out to be non-trivial in php.
2499 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2501 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
2503 Reviewed by Tim Horton.
2505 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
2506 These files are "dynamically linked" to our app.
2508 * public/index.html:
2509 * public/js/jquery-1.8.2.min.js: Removed.
2510 * public/js/jquery.colorhelpers.js: Added.
2511 * public/js/jquery.flot.categories.js: Added.
2512 * public/js/jquery.flot.crosshair.js: Added.
2513 * public/js/jquery.flot.errorbars.js: Added.
2514 * public/js/jquery.flot.fillbetween.js: Added.
2515 * public/js/jquery.flot.js: Added.
2516 * public/js/jquery.flot.min.js: Removed.
2517 * public/js/jquery.flot.navigate.js: Added.
2518 * public/js/jquery.flot.resize.js: Added.
2519 * public/js/jquery.flot.selection.js: Added.
2520 * public/js/jquery.flot.stack.js: Added.
2521 * public/js/jquery.flot.symbol.js: Added.
2522 * public/js/jquery.flot.threshold.js: Added.
2523 * public/js/jquery.flot.time.js: Added.
2524 * public/js/jquery.js: Added.
2526 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2528 Return NaN instead of throwing when there aren't enough samples.
2530 Reviewed by Sam Weinig.
2532 It's better to return NaN when we don't have enough samples so that we can treat it
2533 as if we don't have any confidence interval.
2535 * public/js/statistics.js:
2538 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2540 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
2542 * public/js/helper-classes.js:
2543 (URLState.parseIfNeeded):
2545 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2547 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
2549 Reviewed by Ricky Mondello.
2551 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
2553 * public/admin/aggregators.php: Use heredoc.
2554 * public/admin/builders.php:
2555 * public/admin/jobs.php:
2556 * public/admin/repositories.php:
2557 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
2558 This allows us to use update_field when updating test's url and metric's unit. Changed the action
2559 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
2560 Also removed a stray code to update unit and url simultaneously since it's never used.
2561 * public/include/admin-header.php:
2562 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
2563 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
2564 (update_field): Moved from repositories.php.
2566 * public/include/db.php:
2567 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
2569 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
2571 Build fixes. Treat mean, sum, and square sum as float, not int.
2573 Also use 95% confidence interval instead of 90% confidence interval.
2575 * public/api/runs.php:
2576 * public/js/helper-classes.js:
2577 (.this.confidenceIntervalDelta):
2579 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
2581 Add an administrative page to edit repository information.
2583 Reviewed by Ricky Mondello.
2585 * public/admin/repositories.php: Added.
2586 * public/include/admin-header.php:
2588 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
2590 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
2592 Reviewed by Ricky Mondello.
2594 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
2595 to aggregate results for those matrix in populate-from-report.js.
2597 * database/generate-manifest.js:
2598 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
2599 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
2600 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
2601 * database/populate-from-report.js:
2603 (getReport): No change even though the diff looks as if it moved.
2604 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
2605 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
2606 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
2607 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
2608 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
2610 (ensureMetricId): Take an aggregator id as an argument.
2611 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
2612 for all builds when the build id is not specified.
2613 * public/admin/tests.php:
2614 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
2615 of the same name with different aggregators.
2617 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
2619 Build fix. Don't pass in arguments to in the wrong order.
2621 * database/aggregate.js:
2623 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2625 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
2627 Reviewed by Ricky Mondello.
2629 Since the version of flot we use doesn't support showing graphs in the current locate or
2630 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
2631 treat them as in UTC). We don't want to use the current locate because other websites on
2632 webkit.org assume PST.
2634 Also append this information to build's label.
2636 * public/js/helper-classes.js:
2640 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2642 Store test URLs reported by builders.
2644 Reviewed by Ricky Mondello.
2646 * database/populate-from-report.js:
2647 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
2648 (ensureTestId): Store the URL.
2650 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
2652 Yet another build fix; don't blow up even if we didn't have any test configurations.
2654 * public/admin/tests.php:
2656 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2658 Build fix; don't instantiate Date when a timestamp wasn't provided.
2660 * database/populate-from-report.js:
2662 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
2664 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
2666 Reviewed by Tim Horton.
2668 Added an install manual.
2670 * InstallManual: Added.
2672 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
2674 Minor build fix. Don't unset builderPassword when it's not set.
2676 * public/api/report.php:
2678 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2680 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
2682 Reviewed by Ricky Mondello.
2684 * public/admin/admin.css: Make a very large payload scrollable.
2685 * public/admin/jobs.php: Format JSONs.
2687 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
2689 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
2691 Reviewed by Ricky Mondello.
2693 Add report.php and populate-from-report.js that process JSON files submitted by builders.
2695 * database/populate-from-report.js: Added.
2697 (getReport): Obtains the payload (the actual report) from "jobs" table.
2698 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
2699 and their results. This function recursively traverses tests and metrics and ensure their ids.
2701 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
2702 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
2703 is a "function" in mathematical sense).
2705 (ensureRepositoryIdsForAllRevisions):
2706 (getIdOrCreateBuildWithRevisions):
2707 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
2708 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
2709 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
2711 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
2712 test results all in a single transaction. This allows us to keep the database consistent in that either
2713 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
2714 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
2715 other parts of the application are concerned.
2716 (scheduleQueriesToInsertRun):
2717 * database/process-jobs.js: Add a call to populate-from-report.js.
2718 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
2719 * public/include/db.php: Support parameterized query.
2720 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
2721 a test result could confirm that the submission indeed succeeded.
2723 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2725 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
2727 * database/aggregate.js:
2728 * database/database-common.js:
2729 (selectColumnCreatingRowIfNeeded):
2730 (ensureRepositoryId):
2731 (ensureConfigurationIdFromList):
2732 * database/perf-webkit-migrator.js:
2735 (getOrCreateBuildId):
2737 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2739 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
2741 Reviewed by Ricky Mondello.
2743 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
2744 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
2746 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
2749 (saveAggregatedResults):
2750 * database/database-common.js:
2751 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
2752 (getIdOrCreateRepository): Ditto.
2753 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
2754 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
2755 * database/perf-webkit-migrator.js:
2756 * database/utility.js: Added.
2757 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
2758 from being executed.
2759 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
2760 call the callback passed into start().
2761 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
2762 (TaskQueue.addTask):
2764 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
2765 (SerializedTaskQueue.executeNextTask):
2766 (SerializedTaskQueue.addTask):
2767 (SerializedTaskQueue.start):
2769 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2771 Revert erroneously committed changes.
2773 * database/config.json:
2775 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2777 aggregator.js should be able to accept multiple metric ids and a single build id.
2779 Reviewed by Ricky Mondello.
2781 Make aggregator.js accept multiple ids and generate results for single build when bots are
2782 reporting new results.
2784 * database/aggregate.js:
2785 (parseArgv): Added. Returns an object containing the parsed representation of argv,
2786 which currently contains metricIDs and buildIds.
2787 (main): Use parseArgv and processConfigurations
2788 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
2789 (processPlatform.processConfigurations): Extracted.
2791 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2793 Add an administrative page for builders.
2795 Reviewed by Ricky Mondello.
2797 We need an administrative page to add and edit builder information.
2798 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
2800 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
2801 since we don't have plans to use those columns in near future. Also make builder_name unique
2802 as required by the rest of the app.
2803 * public/admin/builders.php: Added.
2804 * public/api/runs.php: Updated per the table rename.
2805 * public/include/admin-header.php: Added a link to builders.php.
2807 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
2809 Build fixes for r46982.
2811 * database/aggregate.js:
2812 (fetchConfigurations): Bind i so that it's not always metricIds.length.
2813 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
2814 (processBuild): Don't print "." until we've committed transactions. It's misleading.
2816 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2818 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
2820 * public/admin/aggregators.php:
2821 * public/admin/footer.php: Removed.
2822 * public/admin/header.php: Removed.
2823 * public/admin/index.php:
2824 * public/admin/jobs.php:
2825 * public/admin/tests.php:
2826 * public/api/json-header.php: Removed.
2827 * public/api/runs.php:
2828 * public/db.php: Removed.
2829 * public/include: Added.
2830 * public/include/admin-footer.php: Copied from public/admin/footer.php.
2831 * public/include/admin-header.php: Copied from public/admin/header.php.
2832 * public/include/db.php: Copied from public/db.php.
2833 * public/include/json-header.php: Copied from public/api/json-header.php.
2835 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2837 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
2839 Reviewed by Ricky Mondello.
2841 Added the initial implementation of value aggregation.
2842 Also added abilities to configure the dashboard page in tests.php.
2844 * database/aggregate.js: Added.
2845 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
2846 (TaskQueue.addTask):
2848 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
2849 (SerializedTaskQueue.addTask):
2850 (SerializedTaskQueue.start):
2853 (fetchConfigurations):
2854 (fetchBuildsForPlatform):
2856 (testsWithDifferentIterationCounts):
2857 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
2858 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
2859 (getOrInsertConfiguration):
2861 * database/database-common.js:
2862 (fetchTable): Log an error as an error.
2863 (getOrCreateId): Extracted from perf-webkit-migrator.
2864 (statistics): Added.
2865 * database/perf-webkit-migrator.js:
2866 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
2867 runs JSON since runs JSONs are generated on demand now.
2869 (getOrCreatePlatformId):
2870 (getOrCreateTestId):
2871 (getOrCreateConfigurationId):
2872 (getOrCreateRevisionId):
2873 (getOrCreateRepositoryId):
2874 (getOrCreateBuildId):
2875 * database/process-jobs.js:
2876 (processJob): Handle 'aggregate' type.
2878 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
2880 Fix the dashboard after adding test_metrics.
2882 Reviewed by Ricky Mondello.
2884 Rename test to metrics in various functions and sort tests on the charts page.
2885 Also representing whether a test appears or not by setting a flag on dashboard
2886 was bogus because test objects are shared by multiple platforms. Instead, store
2887 dashboard platform list as intended by the manifest JSON.
2889 * public/index.html:
2890 (PerfTestRuns): Renamed test to metric.
2892 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
2893 (fullName): Moved so that it appears above where it's called.
2894 * public/js/helper-classes.js:
2896 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
2898 Update tests.php to reflect recent changes in the database schema.
2900 Reviewed by Conrad Shultz.
2902 Made the following changes to tests.php:
2903 1. Disallow adding metrics to tests without subtests.
2904 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
2905 3. Linkified tests with subtests instead of showing all them at once.
2907 * public/admin/admin.css:
2908 (.action-field, .notice):
2910 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
2911 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
2912 (add_job): Extracted.
2913 * public/admin/tests.php: See above.
2914 (array_item_set_default): Added.
2915 (array_item_or_default): Renamed from get_value_with_default.
2916 (compute_full_name): Extracted.
2917 (sort_tests): Ditto.
2918 (map_metrics_to_tests): Ditto.
2920 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
2922 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
2924 Reviewed by Simon Fraser.
2926 Linkify the headers using metric.test.url when it's provided.
2928 * public/index.html:
2930 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2932 Use parameterized pg_query_params in query_and_fetch_all
2934 Reviewed by Conrad Shultz.
2936 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
2938 * public/api/runs.php:
2940 (ctype_alnum_underscore): Added.
2942 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
2944 Update the migration tool to support test_metrics.
2946 Reviewed by Mark Rowe.
2948 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
2949 Also import run_iteration rows as runs JSON files now include individual values.
2951 * database/database-common.js:
2952 (addJob): Extracted.
2953 * database/perf-webkit-migrator.js:
2954 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
2955 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
2956 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
2959 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2961 Build fix. Suppress "Undefined index" warning.
2963 * public/admin/tests.php:
2965 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2967 Fix a commit error in r46756. api/ should obviously be added under public/
2970 * api/json-header.php: Removed.
2971 * api/runs.php: Removed.
2972 * public/api: Copied from api.
2974 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2976 SafariPerfMonitor: Linkify revisions and revisions range
2977 <rdar://problem/12801010>
2979 Reviewed by Mark Rowe.
2981 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
2982 since it needs to know "url" and "blameUrl".
2984 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
2986 * public/index.html:
2987 * public/js/helper-classes.js:
2989 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
2990 (TestBuild.label): Add labels for all revisions.
2994 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2996 Make the generation of "runs" JSON dynamic and support test_metrics.
2998 Reviewed by Mark Rowe.
3000 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
3002 Since there could be hundreds, if not thousands, of tests for each configuration and users
3003 aren't necessarily interested in looking at all test results, it's much more efficient to
3004 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
3005 when bots report new results (i.e. pushing).
3007 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
3010 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
3011 (exit_with_error): Added.
3012 (successful_exit): Added.
3013 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
3014 * database/generate-runs.js: Removed.
3015 * database/process-jobs.js: No longer supports "runs".
3016 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
3017 * public/db.php: Print "Nothing to see here." when it's accessed directly.
3019 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
3021 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
3023 Update tests.php and sample-data.sql per addition of test_metrics.
3025 Rubber-stamped by Timothy Hatcher.
3027 Remove a useless code from tests.php that used to update the unit and the url of a test
3028 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
3030 Also update the sample data to reflect the addition of test_metrics.
3032 * database/sample-data.sql:
3033 * public/admin/tests.php:
3035 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
3037 Share more code between admin pages.
3039 Reviewed by Timothy Hatcher.
3041 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
3042 between admin pages.
3044 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
3045 to check the nullity of global $db now.
3047 * public/admin/aggregators.php:
3048 * public/admin/header.php:
3050 (execute_query_and_expect_one_row_to_be_affected): Added.
3051 * public/admin/index.php:
3052 * public/admin/jobs.php:
3053 * public/admin/tests.php:
3055 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
3057 SafariPerfMonitor: Add admin page to edit aggregators
3058 <rdar://problem/12782687>
3060 Reviewed by Mark Rowe.
3062 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
3064 * public/admin/aggregators.php: Added.
3065 * public/admin/header.php:
3066 * public/admin/jobs.php: Removed an erroneous hidden input element.
3068 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
3070 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
3072 * database/init-database.sql:
3074 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
3076 SafariPerfMonitor: Allow multiple metrics per test
3077 <rdar://problem/12773506>
3079 Rubber-stamped by Mark Rowe.
3081 Introduce a new table test_metrics. This table represents metrics each test can have
3082 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
3085 Updated admin/tests.php and index.html accordingly.
3087 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
3089 * database/generate-manifest.js:
3090 (buildPlatformMapIfPossible):
3091 * database/generate-runs.js:
3093 * database/init-database.sql:
3094 * database/schema.graffle:
3095 * public/admin/admin.css:
3098 * public/admin/tests.php:
3099 * public/index.html:
3101 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
3103 SafariPerfMonitor: Improve the webkit-perf migration tool
3104 <rdar://problem/12760882>
3106 Reviewed by Mark Rowe.
3108 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
3109 and we don't want to pause the whole importation process until the user comes back to decide whether
3112 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
3113 down to make modifications.
3115 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
3116 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
3118 * database/init-database.sql:
3119 * database/perf-webkit-migrator.js:
3120 (migrateTestConfig):
3121 * database/schema.graffle:
3122 * public/admin/admin.css:
3124 * public/admin/tests.php:
3126 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
3128 Create a new performance dashboard
3129 <rdar://problem/12625582>
3131 Rubber-stamped by Mark Rowe.
3133 Add the initial implementation of the perf dashboard.
3136 * database/config.json: Added.
3137 * database/database-common.js: Added.
3142 (pathToLocalScript):
3144 * database/generate-manifest.js: Added.
3147 (buildPlatformMapIfPossible):
3148 (generateFileIfPossible):
3149 * database/perf-webkit-migrator.js: Added.
3150 * database/process-jobs.js: Added.
3151 * database/sample-data.sql: Added.
3152 * database/schema.graffle: Added.
3154 * public/admin: Added.
3155 * public/admin/README: Added.
3156 * public/admin/admin.css: Added.
3157 * public/admin/footer.php: Added.
3158 * public/admin/header.php: Added.
3159 * public/admin/index.php: Added.
3160 * public/admin/jobs.php: Added.
3161 * public/admin/tests.php: Added.
3162 * public/common.css: Added.
3163 * public/data: Added.
3164 * public/db.php: Added.
3165 * public/index.html: Added.
3167 * public/js/helper-classes.js: Added.
3168 * public/js/jquery-1.8.2.min.js: Added.
3169 * public/js/jquery.flot.min.js: Added.
3170 * public/js/jquery.flot.plugins.js: Added.
3171 * public/js/shared.js: Added.
3172 (fileNameFromPlatformAndTest):
3173 * public/js/statistics.js: Added.