1 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
3 Merge database-common.js and utility.js into run-tests.js.
5 Reviewed by Matthew Hanson.
7 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
8 Also moved init-database.sql out of the database directory and removed the directory entirely.
11 * database/database-common.js: Removed.
12 * database/utility.js: Removed.
13 * init-database.sql: Moved from database/init-database.sql.
15 (connect): Moved from database-common.js.
16 (pathToDatabseSQL): Extracted from pathToLocalScript.
17 (pathToTests): Moved from database-common.js.
20 (SerializedTaskQueue): Ditto.
24 (TestEnvironment.queryAndFetchAll):
27 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
29 Remove the dependency on node.js from the production code.
31 Reviewed by Ricky Mondello.
33 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
35 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
36 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
37 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
38 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
39 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
41 Also removed the js files that are no longer used.
43 * config.json: Moved from database/config.json.
44 * database/aggregate.js: Removed. No longer used.
45 * database/database-common.js: Removed unused functions, and updated the path to config.json.
46 * database/process-jobs.js: Removed. No longer used.
47 * database/sample-data.sql: Removed. We have a much better corpus of data now.
48 * database/schema.graffle: Removed. It's completely obsolete.
49 * public/include/db.php: Updated the path to config.json.
50 * public/include/evaluator.js: Removed.
52 * public/include/report-processor.php:
53 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
54 storing values into $expressions and calling evaluate_expressions_by_node.
55 (TestRunsGenerator::aggregate_values): Added.
56 (TestRunsGenerator::compute_caches): Directly compute the caches.
58 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
60 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
62 * public/admin/platforms.php:
63 * public/include/db.php:
65 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
67 Zoomed y-axis view is ununsable when the last result is an outlier.
69 Reviewed by Stephanie Lewis.
71 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
72 the last result so that the graph looks sane if the last result was an outlier. However, always show
73 the last result's mean even if it was an outlier.
76 * public/js/helper-classes.js:
77 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
78 Also added the ability to cache the unscaled means to avoid recomputation.
79 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
80 (PerfTestRuns.max): Ditto.
81 (PerfTestRuns.sampleStandardDeviation): Ditto.
82 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
84 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
88 * public/admin/tests.php:
89 * public/js/helper-classes.js:
91 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
93 Use two standard deviations instead as I mentioned in the mailing list.
97 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
99 The performance dashboard erroneously shows upward arrow for combined metrics.
101 A single outlier can ruin the zoomed y-axis view.
103 Rubber-stamped by Antti Koivisto.
106 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
107 from the latest results' mean.
108 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
109 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
111 * public/js/helper-classes.js:
112 (PerfTestRuns.sampleStandardDeviation): Added.
113 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
115 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
117 Don't include the confidence interval when computing the y-axis.
119 Rubber-stamped by Simon Fraser.
121 * public/js/helper-classes.js:
125 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
127 Tiny CSS tweak for tooltips.
131 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
133 Remove the erroneously repeated code.
135 * public/admin/test-configurations.php:
137 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
139 <rdar://problem/15704893> perf dashboard should show baseline numbers
141 Reviewed by Stephanie Lewis.
143 * public/admin/bug-trackers.php:
144 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
147 * public/admin/platforms.php:
150 * public/admin/test-configurations.php: Added.
151 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
152 build_revisions as they're not meaningful for baseline / target numbers.
153 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
154 one test run so that we don't accidentally delete a reported test run.
155 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
156 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
157 and delete existing ones.
159 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
160 on each platform; there could be configurations of distinct types such as "current" and "baseline".
161 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
163 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
164 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
165 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
166 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
167 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
169 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
171 * public/include/admin-header.php:
172 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
173 have id and type sub columns, and each custom column could generate multiple rows.
175 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
176 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
177 We then proceed to generate the second header row with sub column names.
179 When generating the actual content, we first generate all custom columns as they may have multiple rows in
180 which case regular columns need rowspan set to the maximum number of rows.
182 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
185 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
186 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
187 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
188 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
189 expanded to occupy all sub columns.
191 * public/include/manifest.php:
192 (ManifestGenerator::platforms): Don't add the metric more than once.
194 * public/include/test-name-resolver.php:
195 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
196 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
197 full metric name later.
198 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
199 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
200 (TestNameResolver::full_name_for_test): Added.
201 (TestNameResolver::full_name_for_metric): Added.
202 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
204 * public/js/helper-classes.js:
205 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
206 test runs created to set baseline and target points.
208 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
210 Build fix after r57928. Removed a superfluous close parenthesis.
212 * public/api/runs.php:
214 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
216 Unreviewed build & typo fixes.
218 * public/admin/platforms.php:
219 * tests/admin-platforms.js:
221 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
223 <rdar://problem/15704893> perf dashboard should show baseline numbers
225 Rubber-stamped by Antti Koivisto.
227 Organize some code into functions in runs.php.
229 Also added back $paths that was erroneously removed in r57925 from json-header.php.
231 * public/api/runs.php:
232 (fetch_runs_for_config): Extracted.
235 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
237 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
239 * database/config.json:
240 * public/admin/reprocess-report.php:
241 * public/api/report.php:
242 * public/api/runs.php:
243 * public/include/json-header.php:
245 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
247 Commit yet another forgotten change.
249 Something went horribly wrong with my merge :(
251 * database/init-database.sql:
253 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
255 Commit one more forgotten change. Sorry for making a mess here.
257 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
259 Commit the forgotten files.
261 * public/admin/platforms.php: Added.
262 * tests/admin-platforms.js: Added.
264 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
266 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
268 Reviewed by Stephanie Lewis.
270 Added /admin/platforms/ page to hide and merge platforms.
272 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
273 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
274 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
275 each test configuration a distinct "test run" for each build.
277 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
278 their test configurations into platform B.
280 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
281 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
282 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
283 in platform B, in which case R should relate to T_B instead.
285 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
286 new platform. We then migrate the test configurations of the remaining test runs.
288 * database/init-database.sql: Added platform_hidden.
290 * public/admin/platforms.php: Added.
291 (merge_platforms): Added. Implements the algorithm described above.
294 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
295 is hidden since it doesn't do anything.
297 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
298 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
299 missing it since unchecked checkbox doesn't set the value in $_POST.
300 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
301 switch statement instead of repeated if's.
302 (AdministrativePage::render_table): Emit "update-column" for update_field.
304 * public/include/db.php: Disable warnings when we're not in the debug mode.
306 * public/include/manifest.php:
307 (ManifestGenerator::platforms): Skip platforms that have been hidden.
310 (TestEnvironment.postJSON):
311 (TestEnvironment.httpGet):
312 (TestEnvironment.httpPost): Added.
313 (sendHttpRequest): Set the content type if specified.
315 * tests/admin-platforms.js: Added tests.
317 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
319 Extract the code to compute full test names from tests.php.
321 Reviewed by Stephanie Lewis.
323 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
324 and paves our way to re-use the code in other pages.
326 * public/admin/tests.php:
328 * public/include/db.php:
329 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
330 tests.php and test-name-resolver.php.
332 * public/include/test-name-resolver.php: Added.
333 (TestNameResolver::__construct):
334 (TestNameResolver::compute_full_name): Moved from tests.php.
335 (TestNameResolver::map_metrics_to_tests): Ditto.
336 (TestNameResolver::sort_tests_by_full_name): Ditto.
337 (TestNameResolver::tests): Added.
338 (TestNameResolver::test_id_for_full_name): Ditto.
339 (TestNameResolver::metrics_for_test_id): Ditto.
340 (TestNameResolver::child_metrics_for_test_id): Ditto.
341 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
343 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
345 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
347 Reviewed by Stephanie Lewis.
349 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
351 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
352 but that's sufficient to correct the wrongfully processed reports for now.
354 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
355 We should eventually add a nice UI to find and reprocess reports.
357 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
359 * public/include/db.php: Added the forgotten call to prefixed_column_names.
361 * public/include/report-processor.php: Copied from public/api/report.php.
362 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
363 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
364 create a new report or authenticate the builder password (the password is never stored in the report).
365 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
366 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
367 (ReportProcessor::store_report): Ditto.
369 * tests/admin-reprocess-report.js: Added.
371 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
373 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
375 Reviewed by Ricky Mondello.
377 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
378 for the same build number as a single build by ignoring build time. This was necessary to associate
379 multiple reports by a single build - e.g. for different performance test suites - because the scripts
380 we use to submit results computed its own "build time" when they're called.
382 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
383 last week; new reports were wrongfully associated with old build numbers.
385 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
386 to the same build. Instead, we create a new build object for those reports. Since the longest set of
387 tests we have only take a couple of hours to run, 24 hours should be more than enough.
389 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
390 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
391 (builder, build number, build time).
393 * public/api/report.php:
394 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
395 when no such build exists. This prevents a report from being associated with a very old build of the same
398 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
399 a similar bug in the future sooner.
401 * tests/api-report.js: Added three test cases.
403 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
405 Merged the upstream changes to db.php
406 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
408 * public/include/db.php:
410 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
412 Update other scripts and tests per previous patch.
414 * public/include/manifest.php:
415 * tests/admin-regenerate-manifest.js:
417 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
421 Reviewed by Ricky Mondello.
423 This column is no longer used by the front-end code since r48360.
425 * database/init-database.sql:
426 * public/admin/tests.php:
428 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
430 Unreviewed build fix.
432 * public/api/report.php:
434 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
436 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
438 Reviewed by Ricky Mondello.
440 Support a new alternative format for aggregated results where we have raw values as well as
441 the list aggregators so that instead of
442 "metrics": {"Time": ["Arithmetic"]}
444 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
446 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
447 dashboard and the generated results page, which doesn't know how to aggregate values.
449 We need to keep the support for the old format because all other existing performance tests
450 all rely on the old format. Even if we updated the tests, we need the dashboard to support
451 the old format during the transition.
453 * public/api/report.php:
454 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
455 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
457 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
459 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
461 Unreviewed; Tweak the CSS so that chart panes align vertically.
465 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
467 SafariPerfMonitor should support Combined metric.
469 * public/js/helper-classes.js:
470 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
471 value as well but assume it to be greater-is-better for now.
473 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
475 Commit the forgotten init-database change to add iteration_relative_time.
477 * database/init-database.sql:
479 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
481 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
483 Reviewed by Ricky Mondello.
485 Add the support for each value to have a relative time. This is necessary for frame rate history
486 since a frame rate needs to be associated with a time it was sampled.
488 * database/init-database.sql: Added iteration_relative_time to run_iterations.
490 * public/api/report.php:
491 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
492 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
493 with relative time since taking the average of two frame rates for two subtests taken at two
494 different times doesn't make any sense.
495 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
496 etc..., use the second element since we assume values are of the form (relative time, frame rate).
497 Also exit early with an error if the number of elements in the array is not a pair.
498 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
500 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
501 iteration_relative_time.
503 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
505 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
507 Reviewed by Ricky Mondello.
509 Support that. It's one line change.
511 * public/api/report.php:
512 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
513 to match the convention assumed elsewhere.
514 * tests/api-report.js: Added a test case.
516 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
518 SafariPerfMonitor shows popups for points outside of the visible region.
520 Rubber-stamped by Simon Fraser.
523 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
524 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
525 may return an item underneath y-axis labels.
527 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
529 Tweak the CSS a little to avoid the test name overlapping with the summary table.
533 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
535 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
539 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
541 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
542 <rdar://problem/13992271> Should scale Y axis to include error ranges
544 Reviewed by Ricky Mondello.
546 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
547 the main graph doesn't go outside the graph even when the y-axis is adjusted.
549 * database/config.json:
551 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
552 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
553 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
555 * public/js/helper-classes.js:
556 (PerfTestResult.confidenceIntervalDelta):
557 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
558 (PerfTestRuns.min): Take confidence interval delta into account.
559 (PerfTestRuns.max): Ditto.
560 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
562 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
564 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
566 * public/api/report.php:
567 (ReportProcessor::recursively_ensure_tests):
568 * tests/api-report.js: Added a test.
570 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
572 Unreviewed build fixes.
574 * public/api/report.php:
575 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
576 Also, tolerate reports without any revision information.
578 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
581 * tests/api-report.js: Added few test cases.
583 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
585 Commit another change that was supposed to be committed in r50331.
588 (TestEnvironment.this.postJSON):
589 (TestEnvironment.this.httpGet):
592 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
594 Commit the remaining files.
596 * public/admin/regenerate-manifest.php:
597 * public/include/admin-header.php:
598 * public/include/json-header.php:
599 * public/include/manifest.php:
601 (TestEnvironment.this.postJSON):
602 (TestEnvironment.this.httpGet):
605 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
607 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
609 Reviewed by Ricky Mondello.
611 Added some tests for admin/regenerate-manifest.
613 * public/admin/regenerate-manifest.php: Use require_once instead of require.
614 * public/include/admin-header.php: Ditto.
615 * public/include/json-header.php: Ditto.
617 * public/include/manifest.php:
618 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
619 When there are no builders, simply return an empty array.
622 (TestEnvironment.postJSON):
623 (TestEnvironment.httpGet): Added.
624 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
626 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
628 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
630 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
631 and run_iterations. Also fixed a typo in report.php found by new tests.
633 * public/api/report.php:
634 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
635 * tests/api-report.js: Added more test cases.
637 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
639 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
641 Reviewed by Ricky Mondello.
643 Add a test runner script and some simple test cases.
645 * database/config.json: Added the configuration for "testServer".
646 * database/database-common.js:
647 (pathToTests): Added.
648 * run-tests.js: Added.
651 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
652 and if there are, asks the user if it’s okay to delete all of the data contained therein.
653 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
655 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
656 in the current database using PostgreSQL's information_schema.
657 (askYesOrNoQuestion):
659 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
661 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
662 (TestEnvironment.assert): Exposes assert to tests.
663 (TestEnvironment.console): Exposes console to tests.
664 (TestEnvironment.describe): Adds a description.
665 (TestEnvironment.it): Adds a test case.
666 (TestEnvironment.postJSON):
667 (TestEnvironment.queryAndFetchAll):
668 (TestEnvironment.sha256):
669 (TestEnvironment.notifyDone): Ends the current test case.
673 (TestContext): An object created for each test case. Conceptually, this object is always on
674 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
675 this object via currentTestContext.
676 (TestContext.description):
678 (TestContext.logError):
681 * tests/api-report.js: Added some basic tests for /api/report.php.
683 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
685 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
687 The problem was that we were detecting whether we're updating dashboard or not by checking
688 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
689 all configurations. Use separate 'dashboard' action to execute the code even when
690 metric_configurations is empty.
692 * public/admin/tests.php:
694 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
696 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
698 Reviewed by Ricky Mondello.
700 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
701 from ReportProcessor as a preparation to replace deprecated aggregate.js.
703 * public/api/report.php:
704 (ReportProcessor::exit_with_error): Moved.
705 (ReportProcessor::process): Use the extracted TestRunsGenerator.
706 (TestRunsGenerator): Added.
707 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
708 (TestRunsGenerator::add_aggregated_metric): Moved.
709 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
710 (TestRunsGenerator::aggregate): Moved. Made public.
711 (TestRunsGenerator::aggregate_current_test_level): Moved.
712 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
713 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
714 (TestRunsGenerator::compute_caches): Moved. Made public.
715 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
716 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
717 (TestRunsGenerator::rollback_with_error): Moved.
719 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
721 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
723 Reviewed by Remy Demarest.
725 Regenerate the manifest file when updating fields or adding new items that are included in
728 * public/admin/bug-trackers.php:
729 * public/admin/builders.php:
730 * public/admin/regenerate-manifest.php:
731 * public/admin/repositories.php:
732 * public/admin/tests.php:
733 * public/include/admin-header.php:
734 (regenerate_manifest): Extracted from regenerate-manifest.php.
736 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
738 Unreviewed build fix for memory test results.
740 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
741 aggregating at each level.
743 * public/api/report.php:
744 (ReportProcessor::recursively_ensure_tests):
745 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
746 (ReportProcessor::add_values_for_aggregation):
747 (ReportProcessor::aggregate):
748 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
750 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
752 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
753 not the number of iteration groups. Also, don't set group number when the entire run belongs
754 a single iteration group.
756 * public/api/report.php:
757 (ReportProcessor::commit):
759 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
761 SafariPerfMonitor: Introduce iteration groups
763 Reviewed by Remy Demarest.
765 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
766 the runtime environment variances to get more stable results. And it's desirable to keep track of
767 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
769 This patch introduces "iteration groups" to keep track of this extra information.
771 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
772 the outer array denotes iteration groups and each inner array contains iteration values for each group.
775 * database/init-database.sql: Add iteration_group column.
776 * public/api/report.php:
777 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
779 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
780 contains the list of values indexed by the iteration order and group sizes. Store the group size so
781 that we can restore the iteration groups before passing it to node.js and restore them later.
783 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
784 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
786 Also check that each iteration group in each subtest are consistent with one another. To see why we need
787 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
788 that each iteration group in T1 and T2 have the same size:
789 T1 = [[1, 2], [3, 4, 5]]
790 T2 = [[6, 7], [8, 9, 10]]
792 so that the aggregated result (the sum in this case) can have the same groups as in:
793 T = [[7, 9], [11, 13, 15]]
795 If some iteration groups in T1 and T2 had a different size as in:
796 T1 = [[1, 2, 3], [4, 5]]
797 T2 = [[6, 7], [8, 9, 10]]
799 Then iteration groups of the aggregated T is ambiguous.
801 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
802 (ReportProcessor::commit): Store iteration_group values.
804 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
806 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
807 migrated to perf.webkit.org.
809 * database/perf-webkit-migrator.js: Removed.
811 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
813 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
818 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
820 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
822 Reviewed by Ricky Mondello.
824 It is often desirable to see charts of a given test for all platforms, or to be able to see
825 charts of all subtests on a given platform when trying to triage perf. regressions.
827 Support this use case by adding the ability to do so on the charts page.
829 Also, we used to disable items on the test list based on the platform chosen. This turned out
830 to be a bad UI because in many situations you want to be able to compare results of the same test
831 on multiple platforms.
833 In this new UI, we have three select elements, each of which selects the following:
834 1. Top-level test - Test suite such as Dromaeo
835 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
836 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
837 3. Platform - Mountain Lion, Qt, etc...
839 A user can select "all" for metric and platform but we disallow doing both at once since adding
840 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
841 think of a use case where you want to look at that many charts at once. We can support this later
842 if valid use cases come up.
845 (.showCharts.addOption): Extracted.
846 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
847 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
848 metricList has onchange handler that enables/disables items on platformList.
850 (init): Sort tests and test metrics here instead of doing that in showCharts.
852 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
854 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
856 Reviewed by Remy Demarest and Ricky Mondello.
858 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
859 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
860 templates to the manifest file instead. Each build now only contains the builder id.
862 * public/api/runs.php: Removed the part of the query that joined builders table. This
863 speeds up the query quite a bit.
865 * public/include/manifest.php:
866 (ManifestGenerator::generate): Generate builders field.
867 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
868 associative array that contains name and its build URL template.
871 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
872 instead of a revision since this function is used for revisions and build page URLs now.
873 (.buildLabelWithLinks): Include the linkified build number.
875 * public/js/helper-classes.js:
876 (TestBuild.builder): Added.
877 (TestBuild.buildNumber): Added.
878 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
879 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
881 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
883 Tooltips interfere with user interactions
885 Rubber-stamped by Simon Fraser.
887 Disable tooltip on the dashboard page since graphs are too small to be useful there.
888 Also, show graphs for only 10 days by default as opposed to 20.
889 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
892 * public/js/helper-classes.js:
894 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
896 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
897 to be compatible with webkit-perf.appspot.com.
899 * public/admin/builders.php:
900 * public/api/report.php:
902 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
906 Add a missing constraint on builds table. For a given builder, there should be exactly
907 one build for a given build number.
909 Also add report_committed_at to reports table to record the time at which a given report
910 was processed and test_runs and run_iterations rows were committed into the database.
912 * database/config.json:
913 * public/api/report.php:
915 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
917 Unreviewed. Add more checks for empty SQL query results.
919 * public/include/manifest.php:
921 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
923 More build fixes on perf.webkit.org.
925 * public/api/runs.php: Make PostgreSQL happier.
926 * public/include/manifest.php: Don't assume we always have bug trackers.
928 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
930 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
931 and fix other miscellaneous UI bugs.
933 Rubber-stamped by Simon Fraser.
935 Removed the code to determine whether smaller value is better or not for a given test in index.html
936 in the favor of using that of PerfTestRuns.
938 * public/include/manifest.php: Fixed a typo.
941 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
943 * public/js/helper-classes.js:
944 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
946 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
947 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
948 at roughly 2,000 units to avoid this.
950 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
951 The only thing we can avoid is innerHTML.
953 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
955 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
957 * public/include/evaluator.js:
959 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
961 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
963 Reviewed by Remy Demarest.
965 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
966 admin/bug-trackers.php and can be associated with multiple repositories.
968 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
969 to determine the set of bug trackers to show for a given set of blame lists.
970 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
971 a place to file bugs against the regression.
973 * database/init-database.sql: Added bug_trackers and tracker_repositories.
974 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
976 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
977 bug trackers, namely associated repositories.
979 * public/include/admin-header.php: Added a link to bug-trackers.php
980 * public/include/manifest.php:
981 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
982 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
984 (ManifestGenerator::repositories):
986 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
987 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
988 'repositories' where the latter contains the list of associated repository names.
991 (Chart): Takes bugTrackers as as argument.
992 (Chart.showTooltipWithResults): Removed the hard-coded list.
994 (init.addPlatformsToDashboard):
995 (init.showCharts.createChartFromListPair):
996 (init): Stores the list of bug trackers in the manifest to a local variable.
998 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1000 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
1002 * public/include/evaluator.js:
1004 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1006 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
1008 Reviewed by Remy Demarest.
1010 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
1011 new row into the database.
1013 * public/admin/aggregators.php: Use AdministrativePage.
1014 * public/admin/builders.php: Ditto.
1015 * public/admin/repositories.php: Ditto.
1016 * public/include/admin-header.php:
1017 (AdministrativePage): Added.
1018 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
1019 to an associative array that describes the column.
1020 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
1021 - label: Human readable name of the column.
1022 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
1023 column exists only before we create password_hash column at the insertion time.
1025 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
1026 titlecase (e.g. new_bug is converted to New Bug).
1027 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
1028 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
1029 textarea for a given editing mode ('text', 'url', or 'string').
1030 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
1031 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
1033 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
1035 Build fix. Some systems don't support r+. Use proc_open instead.
1037 * public/api/report.php:
1039 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1041 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
1042 when computing the y-axis of data points to show tooltips at.
1044 * public/index.html:
1046 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1048 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
1051 * public/.htaccess: Removed.
1053 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
1057 * public/include/manifest.php: Build fix. db is on this.
1058 * public/js/statistics.js:
1059 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
1061 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
1063 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
1065 Reviewed by Anders Carlsson.
1067 Rewrote and merged populate-from-report.js into report.php.
1069 * database/config.json: Added a path to node.js.
1071 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
1072 Once we land this patch and update the administrative pages, we can remove this column.
1074 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
1075 that table is going away once we remove the node.js backend.
1077 * database/populate-from-report.js: Removed.
1078 * public/api/report.php: Added.
1080 (ReportProcessor.__construct):
1081 (ReportProcessor.process):
1083 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
1084 verified to be submitted by a known builder.
1086 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
1087 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
1088 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
1089 inside a transaction because there could be multiple reports for a single build, each containing results for
1092 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
1093 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
1094 add_values_to_commit, and add_values_for_aggregation.
1096 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
1097 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
1098 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
1101 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
1102 to be aggregated in ReportProcessor.aggregate.
1104 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
1106 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
1107 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
1108 given for each row (child metrics of M). This function extracts each column (iteration) via
1109 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
1110 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
1112 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
1113 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
1114 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
1116 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
1117 (ReportProcessor.evaluate_expressions_by_node): See above.
1119 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
1120 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
1121 results also need the said caches.
1123 (ReportProcessor.add_values_to_commit):
1125 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
1126 the transaction as needed if anything goes wrong.
1128 (ReportProcessor.rollback_with_error)
1130 * public/include/db.php:
1131 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
1132 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
1133 contiguously in a SQL statement.
1135 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
1136 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
1137 a column value of the choice.
1139 (Database.begin_transaction): Added.
1140 (Database.commit_transaction): Added.
1141 (Database.rollback_transaction): Added.
1143 * public/include/evaluator.js: Added.
1144 * public/include/json-header.php:
1145 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
1146 context under which the request failed.
1147 (successful_exit): Merge "additional details".
1148 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
1149 (merge_additional_details):
1151 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
1153 SafariPerfMonitor: Add more helper functions to db.php
1155 Reviewed by Remy Demarest.
1157 Added Database::insert_row and array_get to make common database operations easier.
1159 * public/admin/aggregators.php: Use Database::insert_row instead of
1160 execute_query_and_expect_one_row_to_be_affected.
1162 * public/admin/builders.php: Ditto.
1164 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
1165 inserting a row. With insert_row, we don't need that.
1167 * public/include/admin-header.php: Ditto.
1169 * public/include/db.php:
1170 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
1171 return the default value (defaults to NULL) if the key doesn't exist.
1173 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
1176 (Database::prepare_params): Added. Takes an associative array of column names and their values,
1177 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
1178 column names all in the same order.
1180 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
1181 the given prefix. Values are given in a form of an associative array where keys are unprefixed
1182 column names and values are corresponding values. When the row is successfully inserted, it returns
1183 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
1184 indicating the success of the insertion.
1186 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1188 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
1190 Reviewed by Conrad Shultz.
1192 Rewrote the manifest generator in PHP.
1194 * database/generate-manifest.js: Removed.
1195 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
1196 * public/include/db.php:
1197 (array_ensure_item_has_array): Added.
1198 * public/include/evaluator.js: Added.
1199 * public/include/json-header.php:
1200 * public/include/manifest.php: Added.
1202 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1204 Dates on overflow plot are overlapping
1206 Rubber-stamped by Simon Fraser.
1208 Don't show more than 5 days.
1210 * public/index.html:
1211 * public/js/helper-classes.js:
1212 (TestBuild.UTCtoPST):
1215 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1217 Show build time as well as commit time on the dashboard and tooltips.
1219 Rubber-stamped by Simon Fraser.
1221 Include both the maximum commit time and build time in buildLabelWithLinks.
1222 Also use ISO format to save the screen real estate.
1224 * public/index.html:
1225 (buildLabelWithLinks):
1226 * public/js/helper-classes.js:
1228 (TestBuild.buildTime):
1229 (TestBuild.formattedBuildTime):
1231 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
1233 Unreviewed; Convert metric.name to metric.unit in the front end.
1235 * public/js/helper-classes.js:
1237 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1239 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
1241 Rubber-stamped by Simon Fraser.
1243 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
1244 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
1245 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
1247 * public/index.html:
1248 (.buildLabelWithLinks): Extracted from TestBuild.label.
1249 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
1250 on Radar and WebKit Bugzilla.
1251 * public/js/helper-classes.js:
1252 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
1253 (PerfTestResult.isBetterThan): Added.
1254 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
1255 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
1256 to indicate progressions or regressions.
1257 (PerfTestResult.label):
1258 (TestBuild.formattedTime): Added.
1259 (TestBuild.platform): Added.
1260 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
1261 (TestBuild.smallerIsBetter): Added.
1262 (Tooltip.show): Take a raw markup instead of two results.
1264 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
1266 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
1268 Rubber-stamped by Tim Horton.
1270 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
1271 since each platform may have a different number of tests to be shown on the dashboard.
1273 * public/index.html:
1275 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1277 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
1279 * public/js/helper-classes.js:
1282 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1284 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
1286 Rubber-stamped by Tim Horton.
1288 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
1290 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
1291 the revision r1234 was the revision used in the previous build.
1293 * public/api/runs.php:
1294 (parse_revisions_array): Trim double quotations around repository names and revisions.
1295 * public/js/helper-classes.js:
1298 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1300 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
1302 Rubber-stamped by Tim Horton.
1304 * public/index.html:
1305 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
1306 on the dashboard page as it's way too noisy.
1308 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
1310 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
1311 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
1312 so that the tooltip for hover can be reused further.
1314 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
1315 and find the first point that lies on the right of the cursor position. We then compute the midpoint
1316 between this and the previous point and pick the closer of the two. It returns an item-like object
1317 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
1319 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
1321 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
1322 the first or "current" data points (as opposed to target or baseline data points).
1324 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
1325 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
1326 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
1328 * public/js/helper-classes.js:
1329 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
1330 work to the client via bindClick.
1332 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
1334 (Tooltip.bindClick): Added.
1336 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1338 Yet another build fix. metricId*s*.
1340 * public/admin/tests.php:
1342 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1344 Another build fix. Use the new payload format for the aggregate job.
1346 * public/admin/tests.php:
1348 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1352 * database/aggregate.js: Use variables that actually exist.
1353 * database/database-common.js:
1354 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
1355 function calls will find this configuration.
1357 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1359 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
1361 Reviewed by Ricky Mondello.
1363 Turned InstallManual into a proper markdown document and added ReadMe.md.
1365 * InstallManual: Removed.
1366 * InstallManual.md: Moved from InstallManual.
1369 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1371 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
1373 Reviewed by Ricky Mondello.
1375 This patch prepares the front end code to process baseline and target results properly.
1377 * public/index.html:
1378 (fetchTest.createRunAndResults): Extracted.
1379 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
1380 Deleted the comment about how sorting will be unnecessary once we start results in the server side
1381 since sorting by the maximum revision commit time turned out to be non-trivial in php.
1383 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1385 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
1387 Reviewed by Tim Horton.
1389 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
1390 These files are "dynamically linked" to our app.
1392 * public/index.html:
1393 * public/js/jquery-1.8.2.min.js: Removed.
1394 * public/js/jquery.colorhelpers.js: Added.
1395 * public/js/jquery.flot.categories.js: Added.
1396 * public/js/jquery.flot.crosshair.js: Added.
1397 * public/js/jquery.flot.errorbars.js: Added.
1398 * public/js/jquery.flot.fillbetween.js: Added.
1399 * public/js/jquery.flot.js: Added.
1400 * public/js/jquery.flot.min.js: Removed.
1401 * public/js/jquery.flot.navigate.js: Added.
1402 * public/js/jquery.flot.resize.js: Added.
1403 * public/js/jquery.flot.selection.js: Added.
1404 * public/js/jquery.flot.stack.js: Added.
1405 * public/js/jquery.flot.symbol.js: Added.
1406 * public/js/jquery.flot.threshold.js: Added.
1407 * public/js/jquery.flot.time.js: Added.
1408 * public/js/jquery.js: Added.
1410 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1412 Return NaN instead of throwing when there aren't enough samples.
1414 Reviewed by Sam Weinig.
1416 It's better to return NaN when we don't have enough samples so that we can treat it
1417 as if we don't have any confidence interval.
1419 * public/js/statistics.js:
1422 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1424 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
1426 * public/js/helper-classes.js:
1427 (URLState.parseIfNeeded):
1429 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1431 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
1433 Reviewed by Ricky Mondello.
1435 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
1437 * public/admin/aggregators.php: Use heredoc.
1438 * public/admin/builders.php:
1439 * public/admin/jobs.php:
1440 * public/admin/repositories.php:
1441 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
1442 This allows us to use update_field when updating test's url and metric's unit. Changed the action
1443 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
1444 Also removed a stray code to update unit and url simultaneously since it's never used.
1445 * public/include/admin-header.php:
1446 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
1447 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
1448 (update_field): Moved from repositories.php.
1450 * public/include/db.php:
1451 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
1453 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
1455 Build fixes. Treat mean, sum, and square sum as float, not int.
1457 Also use 95% confidence interval instead of 90% confidence interval.
1459 * public/api/runs.php:
1460 * public/js/helper-classes.js:
1461 (.this.confidenceIntervalDelta):
1463 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
1465 Add an administrative page to edit repository information.
1467 Reviewed by Ricky Mondello.
1469 * public/admin/repositories.php: Added.
1470 * public/include/admin-header.php:
1472 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
1474 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
1476 Reviewed by Ricky Mondello.
1478 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
1479 to aggregate results for those matrix in populate-from-report.js.
1481 * database/generate-manifest.js:
1482 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
1483 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
1484 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
1485 * database/populate-from-report.js:
1487 (getReport): No change even though the diff looks as if it moved.
1488 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
1489 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
1490 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
1491 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
1492 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
1494 (ensureMetricId): Take an aggregator id as an argument.
1495 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
1496 for all builds when the build id is not specified.
1497 * public/admin/tests.php:
1498 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
1499 of the same name with different aggregators.
1501 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
1503 Build fix. Don't pass in arguments to in the wrong order.
1505 * database/aggregate.js:
1507 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1509 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
1511 Reviewed by Ricky Mondello.
1513 Since the version of flot we use doesn't support showing graphs in the current locate or
1514 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
1515 treat them as in UTC). We don't want to use the current locate because other websites on
1516 webkit.org assume PST.
1518 Also append this information to build's label.
1520 * public/js/helper-classes.js:
1524 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1526 Store test URLs reported by builders.
1528 Reviewed by Ricky Mondello.
1530 * database/populate-from-report.js:
1531 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
1532 (ensureTestId): Store the URL.
1534 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
1536 Yet another build fix; don't blow up even if we didn't have any test configurations.
1538 * public/admin/tests.php:
1540 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1542 Build fix; don't instantiate Date when a timestamp wasn't provided.
1544 * database/populate-from-report.js:
1546 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
1548 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
1550 Reviewed by Tim Horton.
1552 Added an install manual.
1554 * InstallManual: Added.
1556 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
1558 Minor build fix. Don't unset builderPassword when it's not set.
1560 * public/api/report.php:
1562 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1564 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
1566 Reviewed by Ricky Mondello.
1568 * public/admin/admin.css: Make a very large payload scrollable.
1569 * public/admin/jobs.php: Format JSONs.
1571 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
1573 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
1575 Reviewed by Ricky Mondello.
1577 Add report.php and populate-from-report.js that process JSON files submitted by builders.
1579 * database/populate-from-report.js: Added.
1581 (getReport): Obtains the payload (the actual report) from "jobs" table.
1582 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
1583 and their results. This function recursively traverses tests and metrics and ensure their ids.
1585 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
1586 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
1587 is a "function" in mathematical sense).
1589 (ensureRepositoryIdsForAllRevisions):
1590 (getIdOrCreateBuildWithRevisions):
1591 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
1592 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
1593 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
1595 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
1596 test results all in a single transaction. This allows us to keep the database consistent in that either
1597 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
1598 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
1599 other parts of the application are concerned.
1600 (scheduleQueriesToInsertRun):
1601 * database/process-jobs.js: Add a call to populate-from-report.js.
1602 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
1603 * public/include/db.php: Support parameterized query.
1604 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
1605 a test result could confirm that the submission indeed succeeded.
1607 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1609 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
1611 * database/aggregate.js:
1612 * database/database-common.js:
1613 (selectColumnCreatingRowIfNeeded):
1614 (ensureRepositoryId):
1615 (ensureConfigurationIdFromList):
1616 * database/perf-webkit-migrator.js:
1619 (getOrCreateBuildId):
1621 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
1623 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
1625 Reviewed by Ricky Mondello.
1627 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
1628 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
1630 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
1633 (saveAggregatedResults):
1634 * database/database-common.js:
1635 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
1636 (getIdOrCreateRepository): Ditto.
1637 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
1638 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
1639 * database/perf-webkit-migrator.js:
1640 * database/utility.js: Added.
1641 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
1642 from being executed.
1643 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
1644 call the callback passed into start().
1645 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
1646 (TaskQueue.addTask):
1648 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
1649 (SerializedTaskQueue.executeNextTask):
1650 (SerializedTaskQueue.addTask):
1651 (SerializedTaskQueue.start):
1653 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1655 Revert erroneously committed changes.
1657 * database/config.json:
1659 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1661 aggregator.js should be able to accept multiple metric ids and a single build id.
1663 Reviewed by Ricky Mondello.
1665 Make aggregator.js accept multiple ids and generate results for single build when bots are
1666 reporting new results.
1668 * database/aggregate.js:
1669 (parseArgv): Added. Returns an object containing the parsed representation of argv,
1670 which currently contains metricIDs and buildIds.
1671 (main): Use parseArgv and processConfigurations
1672 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
1673 (processPlatform.processConfigurations): Extracted.
1675 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
1677 Add an administrative page for builders.
1679 Reviewed by Ricky Mondello.
1681 We need an administrative page to add and edit builder information.
1682 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
1684 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
1685 since we don't have plans to use those columns in near future. Also make builder_name unique
1686 as required by the rest of the app.
1687 * public/admin/builders.php: Added.
1688 * public/api/runs.php: Updated per the table rename.
1689 * public/include/admin-header.php: Added a link to builders.php.
1691 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
1693 Build fixes for r46982.
1695 * database/aggregate.js:
1696 (fetchConfigurations): Bind i so that it's not always metricIds.length.
1697 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
1698 (processBuild): Don't print "." until we've committed transactions. It's misleading.
1700 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
1702 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
1704 * public/admin/aggregators.php:
1705 * public/admin/footer.php: Removed.
1706 * public/admin/header.php: Removed.
1707 * public/admin/index.php:
1708 * public/admin/jobs.php:
1709 * public/admin/tests.php:
1710 * public/api/json-header.php: Removed.
1711 * public/api/runs.php:
1712 * public/db.php: Removed.
1713 * public/include: Added.
1714 * public/include/admin-footer.php: Copied from public/admin/footer.php.
1715 * public/include/admin-header.php: Copied from public/admin/header.php.
1716 * public/include/db.php: Copied from public/db.php.
1717 * public/include/json-header.php: Copied from public/api/json-header.php.
1719 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
1721 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
1723 Reviewed by Ricky Mondello.
1725 Added the initial implementation of value aggregation.
1726 Also added abilities to configure the dashboard page in tests.php.
1728 * database/aggregate.js: Added.
1729 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
1730 (TaskQueue.addTask):
1732 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
1733 (SerializedTaskQueue.addTask):
1734 (SerializedTaskQueue.start):
1737 (fetchConfigurations):
1738 (fetchBuildsForPlatform):
1740 (testsWithDifferentIterationCounts):
1741 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
1742 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
1743 (getOrInsertConfiguration):
1745 * database/database-common.js:
1746 (fetchTable): Log an error as an error.
1747 (getOrCreateId): Extracted from perf-webkit-migrator.
1748 (statistics): Added.
1749 * database/perf-webkit-migrator.js:
1750 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
1751 runs JSON since runs JSONs are generated on demand now.
1753 (getOrCreatePlatformId):
1754 (getOrCreateTestId):
1755 (getOrCreateConfigurationId):
1756 (getOrCreateRevisionId):
1757 (getOrCreateRepositoryId):
1758 (getOrCreateBuildId):
1759 * database/process-jobs.js:
1760 (processJob): Handle 'aggregate' type.
1762 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
1764 Fix the dashboard after adding test_metrics.
1766 Reviewed by Ricky Mondello.
1768 Rename test to metrics in various functions and sort tests on the charts page.
1769 Also representing whether a test appears or not by setting a flag on dashboard
1770 was bogus because test objects are shared by multiple platforms. Instead, store
1771 dashboard platform list as intended by the manifest JSON.
1773 * public/index.html:
1774 (PerfTestRuns): Renamed test to metric.
1776 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
1777 (fullName): Moved so that it appears above where it's called.
1778 * public/js/helper-classes.js:
1780 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
1782 Update tests.php to reflect recent changes in the database schema.
1784 Reviewed by Conrad Shultz.
1786 Made the following changes to tests.php:
1787 1. Disallow adding metrics to tests without subtests.
1788 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
1789 3. Linkified tests with subtests instead of showing all them at once.
1791 * public/admin/admin.css:
1792 (.action-field, .notice):
1794 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
1795 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
1796 (add_job): Extracted.
1797 * public/admin/tests.php: See above.
1798 (array_item_set_default): Added.
1799 (array_item_or_default): Renamed from get_value_with_default.
1800 (compute_full_name): Extracted.
1801 (sort_tests): Ditto.
1802 (map_metrics_to_tests): Ditto.
1804 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
1806 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
1808 Reviewed by Simon Fraser.
1810 Linkify the headers using metric.test.url when it's provided.
1812 * public/index.html:
1814 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1816 Use parameterized pg_query_params in query_and_fetch_all
1818 Reviewed by Conrad Shultz.
1820 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
1822 * public/api/runs.php:
1824 (ctype_alnum_underscore): Added.
1826 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
1828 Update the migration tool to support test_metrics.
1830 Reviewed by Mark Rowe.
1832 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
1833 Also import run_iteration rows as runs JSON files now include individual values.
1835 * database/database-common.js:
1836 (addJob): Extracted.
1837 * database/perf-webkit-migrator.js:
1838 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
1839 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
1840 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
1843 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1845 Build fix. Suppress "Undefined index" warning.
1847 * public/admin/tests.php:
1849 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1851 Fix a commit error in r46756. api/ should obviously be added under public/
1854 * api/json-header.php: Removed.
1855 * api/runs.php: Removed.
1856 * public/api: Copied from api.
1858 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1860 SafariPerfMonitor: Linkify revisions and revisions range
1861 <rdar://problem/12801010>
1863 Reviewed by Mark Rowe.
1865 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
1866 since it needs to know "url" and "blameUrl".
1868 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
1870 * public/index.html:
1871 * public/js/helper-classes.js:
1873 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
1874 (TestBuild.label): Add labels for all revisions.
1878 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1880 Make the generation of "runs" JSON dynamic and support test_metrics.
1882 Reviewed by Mark Rowe.
1884 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
1886 Since there could be hundreds, if not thousands, of tests for each configuration and users
1887 aren't necessarily interested in looking at all test results, it's much more efficient to
1888 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
1889 when bots report new results (i.e. pushing).
1891 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
1894 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
1895 (exit_with_error): Added.
1896 (successful_exit): Added.
1897 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
1898 * database/generate-runs.js: Removed.
1899 * database/process-jobs.js: No longer supports "runs".
1900 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
1901 * public/db.php: Print "Nothing to see here." when it's accessed directly.
1903 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
1905 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1907 Update tests.php and sample-data.sql per addition of test_metrics.
1909 Rubber-stamped by Timothy Hatcher.
1911 Remove a useless code from tests.php that used to update the unit and the url of a test
1912 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
1914 Also update the sample data to reflect the addition of test_metrics.
1916 * database/sample-data.sql:
1917 * public/admin/tests.php:
1919 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
1921 Share more code between admin pages.
1923 Reviewed by Timothy Hatcher.
1925 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
1926 between admin pages.
1928 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
1929 to check the nullity of global $db now.
1931 * public/admin/aggregators.php:
1932 * public/admin/header.php:
1934 (execute_query_and_expect_one_row_to_be_affected): Added.
1935 * public/admin/index.php:
1936 * public/admin/jobs.php:
1937 * public/admin/tests.php:
1939 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
1941 SafariPerfMonitor: Add admin page to edit aggregators
1942 <rdar://problem/12782687>
1944 Reviewed by Mark Rowe.
1946 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
1948 * public/admin/aggregators.php: Added.
1949 * public/admin/header.php:
1950 * public/admin/jobs.php: Removed an erroneous hidden input element.
1952 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
1954 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
1956 * database/init-database.sql:
1958 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
1960 SafariPerfMonitor: Allow multiple metrics per test
1961 <rdar://problem/12773506>
1963 Rubber-stamped by Mark Rowe.
1965 Introduce a new table test_metrics. This table represents metrics each test can have
1966 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
1969 Updated admin/tests.php and index.html accordingly.
1971 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
1973 * database/generate-manifest.js:
1974 (buildPlatformMapIfPossible):
1975 * database/generate-runs.js:
1977 * database/init-database.sql:
1978 * database/schema.graffle:
1979 * public/admin/admin.css:
1982 * public/admin/tests.php:
1983 * public/index.html:
1985 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
1987 SafariPerfMonitor: Improve the webkit-perf migration tool
1988 <rdar://problem/12760882>
1990 Reviewed by Mark Rowe.
1992 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
1993 and we don't want to pause the whole importation process until the user comes back to decide whether
1996 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
1997 down to make modifications.
1999 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
2000 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
2002 * database/init-database.sql:
2003 * database/perf-webkit-migrator.js:
2004 (migrateTestConfig):
2005 * database/schema.graffle:
2006 * public/admin/admin.css:
2008 * public/admin/tests.php:
2010 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
2012 Create a new performance dashboard
2013 <rdar://problem/12625582>
2015 Rubber-stamped by Mark Rowe.
2017 Add the initial implementation of the perf dashboard.
2020 * database/config.json: Added.
2021 * database/database-common.js: Added.
2026 (pathToLocalScript):
2028 * database/generate-manifest.js: Added.
2031 (buildPlatformMapIfPossible):
2032 (generateFileIfPossible):
2033 * database/perf-webkit-migrator.js: Added.
2034 * database/process-jobs.js: Added.
2035 * database/sample-data.sql: Added.
2036 * database/schema.graffle: Added.
2038 * public/admin: Added.
2039 * public/admin/README: Added.
2040 * public/admin/admin.css: Added.
2041 * public/admin/footer.php: Added.
2042 * public/admin/header.php: Added.
2043 * public/admin/index.php: Added.
2044 * public/admin/jobs.php: Added.
2045 * public/admin/tests.php: Added.
2046 * public/common.css: Added.
2047 * public/data: Added.
2048 * public/db.php: Added.
2049 * public/index.html: Added.
2051 * public/js/helper-classes.js: Added.
2052 * public/js/jquery-1.8.2.min.js: Added.
2053 * public/js/jquery.flot.min.js: Added.
2054 * public/js/jquery.flot.plugins.js: Added.
2055 * public/js/shared.js: Added.
2056 (fileNameFromPlatformAndTest):
2057 * public/js/statistics.js: Added.