1 2011-04-14 Tony Chang <tony@chromium.org>
3 Reviewed by Adam Roben.
5 make PrettyPatch.rb aware of checksums in png files
6 https://bugs.webkit.org/show_bug.cgi?id=58387
8 Patch v2 with nil checks in the case of file adds and deletes.
10 * PrettyPatch/PrettyPatch.rb:
12 2011-04-13 Simon Fraser <simon.fraser@apple.com>
14 Revert http://trac.webkit.org/changeset/83750 because it broke PrettyPatch.
15 https://bugs.webkit.org/show_bug.cgi?id=58510
17 * PrettyPatch/PrettyPatch.rb:
19 2011-04-12 Tony Chang <tony@chromium.org>
21 Reviewed by Adam Roben.
23 make PrettyPatch.rb aware of checksums in png files
24 https://bugs.webkit.org/show_bug.cgi?id=58387
26 * PrettyPatch/PrettyPatch.rb:
28 2011-04-12 Adam Barth <abarth@webkit.org>
30 Reviewed by Eric Seidel.
32 Review tool should work well on iPad
33 https://bugs.webkit.org/show_bug.cgi?id=58351
35 On the iPad, the toolbar ends up at some random position in the middle
36 of the page because of how position:fixed interacts with scrolling on
37 the iPad. I feel a bit dirty using a user agent detect, but I'm not
38 sure if there's a better way to detect whether the user agent has this
43 2011-03-15 David Levin <levin@chromium.org>
45 Reviewed by Adam Barth.
47 Links from code reviews to trac are incorrect for files in Source/WebKit.
48 https://bugs.webkit.org/show_bug.cgi?id=56404
50 * PrettyPatch/PrettyPatch.rb: Remove WebKit from the list of top level
51 directories since it is now under Source.
53 2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
55 Reviewed by Adam Roben.
57 Formatted Diff for attachment 23920 is mangled
58 https://bugs.webkit.org/show_bug.cgi?id=21222
60 The mangled diff files mentioned in the bug were using Mac line
61 ending and this was causing problems for String#each_line. Now we
62 normalize the line endings in patch data before processing it.
64 * PrettyPatch/PrettyPatch.rb:
66 2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
68 Reviewed by Adam Roben.
70 PrettyPatch displays last two lines of a git-format-patch diff strangely
71 https://bugs.webkit.org/show_bug.cgi?id=29317
73 If the diff section has full range information, we parse only enough to cover the
74 range. This avoids incorrectly showing trailing lines (like git signature) as part
77 * PrettyPatch/PrettyPatch.rb:
79 2011-03-10 Adam Roben <aroben@apple.com>
81 Don't search for intra-line diffs in really long lines
83 Doing so can lead to hangs (or at least really slow execution).
85 Fixes <http://webkit.org/b/56109> run-webkit-tests sometimes times out on Windows XP Debug
86 (Tests) after fast/text/large-text-composed-char-dos.html fails (due to PrettyPatch
89 Reviewed by David Kilzer.
91 * PrettyPatch/PrettyPatch.rb:
92 (PrettyPatch.MAXIMUM_INTRALINE_DIFF_LINE_LENGTH): Added this new constant.
93 (PrettyPatch.DiffSection.initialize): Don't bother looking for intra-line diffs in lines
94 longer than the maximum length.
96 2011-02-25 Ojan Vafai <ojan@chromium.org>
98 Reviewed by Adam Barth.
100 [codereviewtool] fix expand links on git diffs
101 https://bugs.webkit.org/show_bug.cgi?id=55208
103 In git diffs, we don't have a "revision" span at the end
107 2011-02-23 Ojan Vafai <ojan@chromium.org>
109 Reviewed by Tony Chang.
111 autocomplete=off prevents refilling form fields on back/forward navigation
112 https://bugs.webkit.org/show_bug.cgi?id=47463
114 I haven't actually run this patch due to the difficulty of getting
115 a bugzilla instance running. It's simple enough code that I'm not too worried
118 * committers-autocomplete.js:
120 2011-02-21 Ojan Vafai <ojan@chromium.org>
122 Reviewed by Adam Barth.
124 [codereviewtool] focus first visible node if no node is focused
125 https://bugs.webkit.org/show_bug.cgi?id=54935
127 Now hitting j/k/n/p will focus the first/last visible node
128 if no other node is focused. Also tweaked the scroll into view
129 logic a bit to avoid scrolling in this case.
133 2011-02-21 Ojan Vafai <ojan@chromium.org>
135 Reviewed by Adam Barth.
137 [codereviewtool] remove patch fuzzing
138 https://bugs.webkit.org/show_bug.cgi?id=54940
140 This code is buggy and not as necessary now that we
141 include svn revision numbers in uploaded patches.
145 2011-02-21 Ojan Vafai <ojan@chromium.org>
147 Reviewed by Adam Barth.
149 [codereviewtool] focus comment on accept
150 https://bugs.webkit.org/show_bug.cgi?id=54930
154 2011-02-20 Ojan Vafai <ojan@chromium.org>
156 Reviewed by Adam Barth.
158 [codereviewtool] avoid overriding ctrl/cmd + r
159 https://bugs.webkit.org/show_bug.cgi?id=54852
163 2011-02-16 Ojan Vafai <ojan@chromium.org>
165 Reviewed by Adam Barth.
167 keyboard support for extending/shrinking comment context
168 https://bugs.webkit.org/show_bug.cgi?id=54612
170 ctrl+shift+up/down will extend/shrink the comment context when
171 a comment is focused or when one is being edited.
173 Also, switch over to using keydown instead of keypress events.
174 This lets us share code for handling escape and other key events.
175 Also, keypress is evil and should die.
179 2011-02-20 Ojan Vafai <ojan@chromium.org>
181 Recommit accidental revert.
182 r79180 accidentally revereted r79178.
185 2011-02-20 Ojan Vafai <ojan@chromium.org>
187 Reviewed by Adam Barth.
189 [codereviewtool] add more help information
190 https://bugs.webkit.org/show_bug.cgi?id=54847
194 2011-02-20 Ojan Vafai <ojan@chromium.org>
196 Reviewed by Adam Barth.
198 [codereviewtool] use 'r' to focus the review select element
199 https://bugs.webkit.org/show_bug.cgi?id=54845
201 This allows for quick keyboard access to the toolbar items.
202 Hit r to get to the review select element. Then you can
203 tab to the cq/preview/publish elements.
207 2011-02-20 Ojan Vafai <ojan@chromium.org>
209 Reviewed by Adam Barth.
211 [codereviewtool] don't let lines/diffblocks be mouse focusable
212 https://bugs.webkit.org/show_bug.cgi?id=54851
214 Unfortunately, this will only work once https://bugs.webkit.org/show_bug.cgi?id=54727
215 is committed. In the interim, it won't break anything.
219 2011-02-20 Ojan Vafai <ojan@chromium.org>
221 Reviewed by Adam Barth.
223 [codereviewtool] use keydown instead of keypress
224 https://bugs.webkit.org/show_bug.cgi?id=54849
226 There is no functional change. This is just a cleanup
227 to make future patches (e.g. https://bugs.webkit.org/show_bug.cgi?id=54612)
232 2011-02-20 Ojan Vafai <ojan@chromium.org>
234 Reviewed by Adam Barth.
236 [codereviewtool] fix layout nit
237 https://bugs.webkit.org/show_bug.cgi?id=54848
239 There is occasionally an off-by-one in the 50% width
240 calculation. This ensures that the add lines always
241 line up with the shared context lines.
243 * PrettyPatch/PrettyPatch.rb:
245 2011-02-20 Ojan Vafai <ojan@chromium.org>
247 Reviewed by Adam Barth.
249 [codereviewtool] make escape hide the preview form
250 https://bugs.webkit.org/show_bug.cgi?id=54844
254 2011-02-20 Ojan Vafai <ojan@chromium.org>
256 Reviewed by Adam Barth.
258 [codereviewtool] make enter work when an individual line is focused
259 https://bugs.webkit.org/show_bug.cgi?id=54843
263 2011-02-17 Ojan Vafai <ojan@chromium.org>
265 Reviewed by Adam Barth.
267 use shift+j/k to focus next/previous line
268 https://bugs.webkit.org/show_bug.cgi?id=54723
270 Tested on a large Hyatt change to confirm it performed fine.
271 (https://bugs.webkit.org/attachment.cgi?id=82533&action=review)
275 2011-02-17 Ojan Vafai <ojan@chromium.org>
277 Reviewed by Adam Barth.
279 fix escape handling in code review tool
280 https://bugs.webkit.org/show_bug.cgi?id=54722
282 This broke with http://trac.webkit.org/changeset/78948.
283 Apparently jquery events get a wrapped object that
284 does not expose keyIdentifier.
288 2011-02-17 Ojan Vafai <ojan@chromium.org>
290 Reviewed by Adam Barth.
292 create comments when hitting enter with a focused diff
293 https://bugs.webkit.org/show_bug.cgi?id=54719
297 2011-02-17 Ojan Vafai <ojan@chromium.org>
299 Reviewed by Adam Barth.
301 use actual browser focus in the code review tool
302 https://bugs.webkit.org/show_bug.cgi?id=54726
304 This makes keyboard handling play better with focusable element
305 (i.e. links/textareas/buttons). Also, in theory, this makes
306 the review tool more amenable to screen readers (I think).
308 * PrettyPatch/PrettyPatch.rb:
311 2011-02-17 Ojan Vafai <ojan@chromium.org>
313 Reviewed by Antonio Gomes.
315 make event handling work in Gecko
316 https://bugs.webkit.org/show_bug.cgi?id=54702
318 Gecko doesn't support the global event property. It's an IE-ism.
322 2011-02-14 Ojan Vafai <ojan@chromium.org>
324 Reviewed by Adam Barth.
326 allow for modifying comments without the mouse
327 https://bugs.webkit.org/show_bug.cgi?id=54433
329 Use n/p to navigate the comments.
330 Enter to begin editing a comment.
331 Escape to finish editing a comment.
335 2011-02-14 Ojan Vafai <ojan@chromium.org>
337 Reviewed by Adam Barth.
339 improve line selection in the code review tool
340 https://bugs.webkit.org/show_bug.cgi?id=54430
342 -shift+click now extends the comment context
343 -selecting outside of a diff section no longer clears the selected lines.
344 Instead it just restricts the selected lines to that diff section.
348 2011-02-10 Ojan Vafai <ojan@chromium.org>
350 Reviewed by Adam Barth.
352 remove extra space from expansion lines
353 https://bugs.webkit.org/show_bug.cgi?id=54266
357 2011-02-09 Ojan Vafai <ojan@chromium.org>
359 Reviewed by Adam Barth.
361 only erase draft comments after publish is successful
362 https://bugs.webkit.org/show_bug.cgi?id=54163
364 If there is a conflict or 500, then draft comments will survive.
365 One drawback here is that the form post is now to the iframe,
366 so to break out of the iframe we redirect to the bug page, which
367 loses the information of who the email was sent to.
369 Once WebKit supports seamless iframes we should be able to avoid
374 2011-02-09 Ojan Vafai <ojan@chromium.org>
376 Reviewed by Adam Barth.
378 save overall comments when saving drafts in the review tool
379 https://bugs.webkit.org/show_bug.cgi?id=54165
381 -save overall comments in localstorage as well
382 -save all draft comments as you type
383 -give a *subtle* indicator of saved state
385 The latter should also make it super easy if someone wanted to do
386 the work to store draft comments in appengine/s3/bugzilla/etc.
388 * PrettyPatch/PrettyPatch.rb:
389 * code-review-test.html:
392 2011-02-08 Ojan Vafai <ojan@chromium.org>
394 Reviewed by Adam Barth.
396 fix toolbar anchoring in the code review tool
397 https://bugs.webkit.org/show_bug.cgi?id=54058
399 Avoid the anchoring cycle of doom when on the cusp
400 of whether the toolbar needs to be anchored and
401 speculatively avoid the Firefox crash when resizing.
403 * PrettyPatch/PrettyPatch.rb:
406 2011-02-07 Ojan Vafai <ojan@chromium.org>
408 Reviewed by Adam Barth.
410 bring back diff context lines into the review tool
411 https://bugs.webkit.org/show_bug.cgi?id=53974
415 2011-02-01 Ojan Vafai <ojan@chromium.org>
417 Reviewed by Adam Roben.
419 include svn revisions in git diffs for the code review tool to use
420 https://bugs.webkit.org/show_bug.cgi?id=53569
422 * PrettyPatch/PrettyPatch.rb:
424 2011-02-01 Ojan Vafai <ojan@chromium.org>
426 Reviewed by Adam Barth.
428 make draft comments focusable
429 https://bugs.webkit.org/show_bug.cgi?id=53554
431 Makes frozen draft comments focusable. The ones that are currently being edited are not.
432 I'm on the fence whether they should be, but this seems good enough for now.
436 2011-02-01 Ojan Vafai <ojan@chromium.org>
438 Reviewed by Adam Barth.
440 avoid jitter when loading the comments to a patch
441 https://bugs.webkit.org/show_bug.cgi?id=53570
445 2011-02-01 Ojan Vafai <ojan@chromium.org>
447 Reviewed by Mihai Parparita.
449 [codereviewtool] extra space at the beginning of lines in side-by-side view
450 https://bugs.webkit.org/show_bug.cgi?id=53550
452 The newline between the spans turns into user-visible space in side-by-side mode.
454 * PrettyPatch/PrettyPatch.rb:
456 2011-02-01 Ojan Vafai <ojan@chromium.org>
458 Increment version number to cache-bust code-review.js.
460 * PrettyPatch/PrettyPatch.rb:
462 2011-01-31 Ojan Vafai <ojan@chromium.org>
464 Reviewed by Adam Barth.
466 Store draft comments in localStorage
467 https://bugs.webkit.org/show_bug.cgi?id=52866
470 * code-review-test.html
472 2011-01-20 Ojan Vafai <ojan@chromium.org>
474 Fix the review tool for image diffs. We would get a javascript error
475 because image diffs don't have line numbers.
479 2011-01-20 Ojan Vafai <ojan@chromium.org>
481 Reviewed by Oliver Hunt.
483 Could review tool include style failure info?
484 https://bugs.webkit.org/show_bug.cgi?id=49049
486 This does not handle patches that have old paths (e.g. without the Source prefix).
487 Although that would be fairly straightforward to workaround.
491 2011-01-20 Ojan Vafai <ojan@chromium.org>
493 Reviewed by Adam Barth.
495 handle cases where PrettyPatch.rb doesn't linkify filenames
496 https://bugs.webkit.org/show_bug.cgi?id=52834
500 2011-01-20 Ojan Vafai <ojan@chromium.org>
502 Reviewed by Adam Barth.
504 fix goofup in http://trac.webkit.org/changeset/76082
505 https://bugs.webkit.org/show_bug.cgi?id=52830
507 We were showing the revision number of the patch at the bottom
508 of the diff and expanding from the bottom of the diff would fail.
510 Also, removed an unused variable and scoped queries appropriatly
511 to the file_diff they should have been operating on.
513 * PrettyPatch/PrettyPatch.rb:
516 2011-01-19 Ojan Vafai <ojan@chromium.org>
518 Reviewed by Adam Barth.
520 [reviewtool] Add a link for annotated trac page on review page
521 https://bugs.webkit.org/show_bug.cgi?id=52747
523 -add line numbers to all trac links to the first line in the file diff
524 -add annotate/review log links
525 -make file-diff links other than the file name only show when you mouseover the filediff
526 -fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents
528 * PrettyPatch/PrettyPatch.rb:
531 2011-01-14 Ojan Vafai <ojan@chromium.org>
533 Reviewed by Adam Barth.
535 make line selection have a extend only from where you start the selection in the code review tool
536 https://bugs.webkit.org/show_bug.cgi?id=52485
540 2011-01-18 Ojan Vafai <ojan@chromium.org>
542 Reviewed by Eric Seidel.
544 make file expansion use the file at the svn revision the diff was created at
545 https://bugs.webkit.org/show_bug.cgi?id=52650
547 This only works for patches created with SVN for now since the git
548 diff does not include SVN revision numbers in it.
550 * PrettyPatch/PrettyPatch.rb:
553 2011-01-15 Adam Barth <abarth@webkit.org>
555 Rubber-stamped by Eric Seidel.
557 Move WebKit2 into Source
558 https://bugs.webkit.org/show_bug.cgi?id=52438
560 Remove WebKit2 from the list of top-level source directories.
562 * PrettyPatch/PrettyPatch.rb:
564 2011-01-14 Ojan Vafai <ojan@chromium.org>
566 Reviewed by Adam Barth.
568 fix expanded lines in the code review tool
569 https://bugs.webkit.org/show_bug.cgi?id=52498
571 Fixes them to work now that we have wrapper divs.
572 Also fixes the long-standing bug that the line numbers
573 were incorrect sometimes.
577 2011-01-14 Ojan Vafai <ojan@chromium.org>
579 Reviewed by Adam Barth.
581 put remove lines to the left of add lines in sidebyside view
582 https://bugs.webkit.org/show_bug.cgi?id=52458
584 Also, sneaking in a fix to make long lines with no whitespace wrap.
586 * PrettyPatch/PrettyPatch.rb:
589 2011-01-14 Ojan Vafai <ojan@chromium.org>
591 Fix bad merge in r75816.
595 2011-01-14 Ojan Vafai <ojan@chromium.org>
597 Reviewed by Adam Barth.
599 improve line selection with fast drags
600 https://bugs.webkit.org/show_bug.cgi?id=52477
604 2011-01-14 Ojan Vafai <ojan@chromium.org>
606 Reviewed by Adam Barth.
608 tweak line selection in code review tool
609 https://bugs.webkit.org/show_bug.cgi?id=52462
611 -Improve handling of data-comment-base-line code to deal with
612 lines that have multiple values.
613 -Make it so that if you click on the line immediately above
614 a line that has a comment it will add a new comment instead of
615 adding lines to the following comment. If the last selected line
616 overlaps existing comment lines though they will still get
617 added to the existing comment.
621 2011-01-14 Ojan Vafai <ojan@chromium.org>
623 Reviewed by Adam Roben.
625 fix bugs going back and forth between unified and sidebyside
626 https://bugs.webkit.org/show_bug.cgi?id=52470
628 Now that we're appending DOM nodes directly, we only want to
629 get the first ".text" element in the subtree. In the cases
630 where there are multiple, their contents are the same.
632 Also, when making side-by-side expansion lines, we need to
633 clone the contents so we have a second copy to append to the DOM.
637 2011-01-13 Ojan Vafai <ojan@chromium.org>
639 Reviewed by Adam Barth.
641 simplify keyboard handling in code review tool
642 https://bugs.webkit.org/show_bug.cgi?id=52407
644 Now that we have DiffBlock containers, the only things that are
645 focusable are previousComment nodes and DiffBlock containers
646 that contain add/remove lines.
648 Also, this means we show the focus border around the entire diff
649 instead of just the first line.
653 2011-01-13 Ojan Vafai <ojan@chromium.org>
655 Reviewed by Adam Barth.
657 add container divs for diff blocks
658 https://bugs.webkit.org/show_bug.cgi?id=52400
660 This will help simplify a lot of code in code-review.js
661 and make side-by-side diffs better (i.e. put removed lines
662 to the left of corresponding added lines).
664 Also, allow for running the JS from a local file. Now you can modify code-review.js
665 to point to a local file and then run:
666 ruby prettify.rb < foo.diff > foo.html
668 foo.html will load a dummy code review matching foo.diff.
691 * PrettyPatch/PrettyPatch.rb:
694 2011-01-12 Ojan Vafai <ojan@chromium.org>
696 Reviewed by Mihai Parparita.
698 fix assorted bugs with expansion lines
699 https://bugs.webkit.org/show_bug.cgi?id=52326
701 -Clicking "all" would collapse whitespace in the expanded lines.
702 -Converted the remaining line creation code to using the DOM.
704 * PrettyPatch/PrettyPatch.rb:
707 2011-01-12 Ojan Vafai <ojan@chromium.org>
709 Reviewed by Adam Barth.
711 review tool formatted diff doesn't match the uploaded diff
712 https://bugs.webkit.org/show_bug.cgi?id=51960
714 PrettyPatch works just fine if there is no newline at the end of the file.
718 2011-01-12 Ojan Vafai <ojan@chromium.org>
720 Reviewed by Adam Barth.
722 Bugzilla: Add keyboard shortcuts to jump to next change
723 https://bugs.webkit.org/show_bug.cgi?id=52305
725 Comments and diff blocks go in the same queue. If you have a
726 comment focused, then j/k will focus the next/prev diff block
727 with respect to that comment.
729 * PrettyPatch/PrettyPatch.rb:
732 2011-01-12 Ojan Vafai <ojan@chromium.org>
734 Reviewed by Adam Barth.
736 show shared lines on both sides in code review tool
737 https://bugs.webkit.org/show_bug.cgi?id=52308
739 We were appending the same DOM node twice. Instead, make
740 the from column a clone of the original node.
744 2011-01-12 Ojan Vafai <ojan@chromium.org>
746 Reviewed by Adam Barth.
748 fix wrapping bug in expansion lines in the code review tool
749 https://bugs.webkit.org/show_bug.cgi?id=52270
751 * PrettyPatch/PrettyPatch.rb:
754 2011-01-11 Ojan Vafai <ojan@chromium.org>
756 Reviewed by Adam Barth.
758 fix difflink centering to be vertical, not horizontal
759 https://bugs.webkit.org/show_bug.cgi?id=52263
761 * PrettyPatch/PrettyPatch.rb:
764 2011-01-11 Ojan Vafai <ojan@chromium.org>
766 Reviewed by Adam Barth.
768 remember diffstate for review tool
769 https://bugs.webkit.org/show_bug.cgi?id=52253
771 If you use the global sidebyside/unified links, store the diff type
772 in localstorage. Then, onload, use that diff type. That way, people
773 who prefer one diff type or the other can always get that by default.
777 2011-01-11 Ojan Vafai <ojan@chromium.org>
779 Reviewed by Adam Barth.
781 allow sidebysideifying individual files in the code review tool
782 https://bugs.webkit.org/show_bug.cgi?id=52226
786 2011-01-11 Ojan Vafai <ojan@chromium.org>
788 Reviewed by Mihai Parparita.
790 fix exception when adding a comment to a side-by-side diff
791 https://bugs.webkit.org/show_bug.cgi?id=52240
793 prev() and next() won't get the previous and next lines in
794 side-by-side mode. Instead do a query to find them.
798 2011-01-11 Ojan Vafai <ojan@chromium.org>
800 Reviewed by Mihai Parparita.
802 maintain word diffs when converting to side-by-side and back
803 https://bugs.webkit.org/show_bug.cgi?id=52244
805 Using textContent would lose the spans use to make the word-diff highlighting.
806 Just move the span element itself.
810 2011-01-11 Ojan Vafai <ojan@chromium.org>
812 Reviewed by Adam Barth.
814 fix layout error with comments in code review tool
815 https://bugs.webkit.org/show_bug.cgi?id=52230
817 * PrettyPatch/PrettyPatch.rb:
819 2011-01-10 Ojan Vafai <ojan@chromium.org>
821 Reviewed by Adam Barth.
823 convert back to unified from sidebyside diff
824 https://bugs.webkit.org/show_bug.cgi?id=52180
826 Remove url fragment stuff. Having it be per-filediff is too complicated.
828 * PrettyPatch/PrettyPatch.rb:
831 2011-01-07 Adam Barth <abarth@webkit.org>
833 Rubber-stamped by Eric Seidel.
835 Move WebCore to Source
836 https://bugs.webkit.org/show_bug.cgi?id=52050
838 Remove reference to old directory.
840 * PrettyPatch/PrettyPatch.rb:
842 2011-01-06 Ojan Vafai <ojan@chromium.org>
844 Reviewed by Adam Barth.
846 side-by-side diffs in the code review tool
847 https://bugs.webkit.org/show_bug.cgi?id=52019
849 Support for conversion from the formatted diff to a side-by-side diff.
850 Maintains comments and new comments can be added.
852 The main architectural change is that Line elements are no longer necessarily
853 siblings. Each physical line is now in a LineContainer and LineContainers are
854 siblings. Each Line corresponds to a Line in the unified diff and has an id (e.g. line12).
855 A Line can be a LineContainer or a child of a LineContainer.
857 In this way, converting to side-by-side and, in the future, back to unified is non-lossy.
859 * PrettyPatch/PrettyPatch.rb:
862 2011-01-06 Ojan Vafai <ojan@chromium.org>
864 Fix line context when replying to comments.
868 2011-01-05 Ojan Vafai <ojan@chromium.org>
870 Reviewed by Adam Barth.
872 change the way we do comment highlighting in the code review tool
873 https://bugs.webkit.org/show_bug.cgi?id=51971
875 Store a space-separated list of base line IDs on each line that has
876 comments associated with that line. This allows for overlapping comments,
877 but more importantly, makes adding side-by-side diff support easier.
881 2011-01-05 Ojan Vafai <ojan@chromium.org>
883 Reviewed by Adam Barth.
885 minor code cleanup for code review tool
886 https://bugs.webkit.org/show_bug.cgi?id=51962
888 Consolidates some queries to using shared functions.
892 2011-01-05 Ojan Vafai <ojan@chromium.org>
894 Reviewed by Adam Barth.
896 assorted cleanups to prepare for side-by-side diffing
897 https://bugs.webkit.org/show_bug.cgi?id=51961
899 Mostly, use selector queries instead of assuming comments are next siblings.
903 2011-01-05 Ojan Vafai <ojan@chromium.org>
905 Reviewed by Adam Barth.
907 fix message container selector for code review tool
908 https://bugs.webkit.org/show_bug.cgi?id=51959
912 2011-01-04 Ojan Vafai <ojan@chromium.org>
914 Increment version number to avoid getting the cached JS file.
916 * PrettyPatch/PrettyPatch.rb:
918 2010-12-15 Ojan Vafai <ojan@chromium.org>
920 Reviewed by Adam Barth.
922 anchor the toolbar to the bottom of the diff if the diff doesn't take a full screen of height
923 https://bugs.webkit.org/show_bug.cgi?id=51162
925 * PrettyPatch/PrettyPatch.rb:
928 2011-01-01 Adam Barth <abarth@webkit.org>
930 Reviewed by Eric Seidel.
932 Move JavaScriptCore to Source
933 https://bugs.webkit.org/show_bug.cgi?id=51604
935 * PrettyPatch/PrettyPatch.rb:
936 - Remove reference to JavaScriptCore as a source directory.
938 2011-01-01 Adam Barth <abarth@webkit.org>
940 Reviewed by Eric Seidel.
942 Move Sources to Source
943 https://bugs.webkit.org/show_bug.cgi?id=51794
945 * PrettyPatch/PrettyPatch.rb:
947 2010-12-31 Adam Barth <abarth@webkit.org>
949 Rubber-stamped by Eric Seidel.
951 Move PageLoadTests to PerformanceTests/PageLoad
952 https://bugs.webkit.org/show_bug.cgi?id=51771
954 Update list of top-level open-source directories.
956 * PrettyPatch/PrettyPatch.rb:
958 2010-12-31 Adam Barth <abarth@webkit.org>
960 Rubber-stamped by Eric Seidel.
962 Move SunSpider into PerformanceTests
963 https://bugs.webkit.org/show_bug.cgi?id=51769
965 Update list of top-level open-source directories.
967 * PrettyPatch/PrettyPatch.rb:
969 2010-12-26 Adam Barth <abarth@webkit.org>
971 Reviewed by Eric Seidel.
973 Move autotools into Sources
974 https://bugs.webkit.org/show_bug.cgi?id=51630
976 * PrettyPatch/PrettyPatch.rb:
977 - Remove reference to non-existant autotools directory.
979 2010-12-26 Adam Barth <abarth@webkit.org>
981 Reviewed by Eric Seidel.
983 Move cmake into Sources
984 https://bugs.webkit.org/show_bug.cgi?id=51631
986 * PrettyPatch/PrettyPatch.rb:
988 2010-12-23 Adam Barth <abarth@webkit.org>
990 Rubber-stamped by Eric Seidel.
992 Move JavaScriptGlue into Sources
993 https://bugs.webkit.org/show_bug.cgi?id=51583
995 PrettyPatch keeps a list of the top-level directories that exist in
998 * PrettyPatch/PrettyPatch.rb:
1000 2010-12-20 Adam Barth <abarth@webkit.org>
1002 One more tweak caused by moving the web sites around. I had this
1003 change in my patch originally, but I missed it because I had to use
1004 server-side svn move commands to move the bulk of the web site files.
1006 * PrettyPatch/PrettyPatch.rb:
1008 2010-12-18 Adam Barth <abarth@webkit.org>
1010 Reviewed by Sam Weinig.
1012 Move WebKitExamplePlugins to Examples
1013 https://bugs.webkit.org/show_bug.cgi?id=51291
1015 * PrettyPatch/PrettyPatch.rb:
1017 2010-12-17 Dan Bernstein <mitz@apple.com>
1019 Reviewed by Simon Fraser.
1021 Rename WebKitTools to Tools
1022 https://bugs.webkit.org/show_bug.cgi?id=49861
1024 * PrettyPatch/PrettyPatch.rb:
1025 * committers-autocomplete.js:
1027 2010-12-17 Ojan Vafai <ojan@chromium.org>
1029 Increment psuedo-version number to avoid pulling cached version.
1031 * PrettyPatch/PrettyPatch.rb:
1033 2010-12-17 Ojan Vafai <ojan@chromium.org>
1035 Speculative fix for the code review tool in Firefox.
1036 Fixes a JS error and makes the status bubble mostly work
1037 if postMessage is not supported.
1039 * PrettyPatch/PrettyPatch.rb:
1042 2010-12-15 Ojan Vafai <ojan@chromium.org>
1044 Reviewed by Adam Barth.
1046 size status bubble to it's contents on the code review page
1047 https://bugs.webkit.org/show_bug.cgi?id=51142
1049 * PrettyPatch/PrettyPatch.rb:
1052 2010-12-15 Ojan Vafai <ojan@chromium.org>
1054 Reviewed by Adam Barth.
1056 fix goofups from r74142 and r74130
1057 https://bugs.webkit.org/show_bug.cgi?id=51146
1059 Accidentally shrank the inline comment boxes and made
1060 the toolbar not show up when there were image diffs.
1062 * PrettyPatch/PrettyPatch.rb:
1065 2010-12-14 Ojan Vafai <ojan@chromium.org>
1067 Reviewed by Adam Barth.
1069 add ability to view for file context to the review tool
1070 https://bugs.webkit.org/show_bug.cgi?id=51057
1072 At the beginning/end of each file diff and between each
1073 hunk add links to expand the context. For now it grabs the
1074 tip of tree version of the file and tries to apply the diff
1075 to that file. If it can't apply, then it gives up as we
1076 wouldn't want to show the wrong lines of context.
1078 In the future, we can consider adding the upload svn revision
1079 to the diff itself, then we could fallback to the file at that
1080 revision if tip of tree doesn't apply.
1082 * PrettyPatch/PrettyPatch.rb:
1085 2010-12-08 Ojan Vafai <ojan@chromium.org>
1087 Reviewed by Adam Barth.
1089 [reviewtool] should always show overall comments text box
1090 https://bugs.webkit.org/show_bug.cgi?id=45870
1092 * PrettyPatch/PrettyPatch.rb:
1095 2010-12-04 Patrick Gansterer <paroga@webkit.org>
1097 Reviewed by Adam Barth.
1099 Increase size of status bubbles
1100 https://bugs.webkit.org/show_bug.cgi?id=50496
1102 The current available space isn't enough to display all
1103 pending results including position in the queue.
1105 * PrettyPatch/PrettyPatch.rb:
1107 2010-12-04 Patrick Gansterer <paroga@webkit.org>
1109 Reviewed by Adam Barth.
1111 Increase size of status bubbles
1112 https://bugs.webkit.org/show_bug.cgi?id=50496
1114 The current available space isn't enough to display all
1115 pending results including position in the queue.
1117 * template/en/custom/attachment/edit.html.tmpl:
1118 * template/en/custom/attachment/list.html.tmpl:
1119 * template/en/custom/attachment/reviewform.html.tmpl:
1121 2010-11-08 Adam Barth <abarth@webkit.org>
1123 Update help text to match behavior change.
1127 2010-11-08 Adam Barth <abarth@webkit.org>
1129 Reviewed by Eric Seidel.
1131 Restore normal meaning of double-click on patch review page?
1132 https://bugs.webkit.org/show_bug.cgi?id=47641
1134 After this patch, you need to click on the line numbers to add a
1137 * PrettyPatch/PrettyPatch.rb:
1140 2010-10-09 Adam Barth <abarth@webkit.org>
1142 Reviewed by Alexey Proskuryakov.
1144 Exception in committers-autocomplete in Firefox
1145 https://bugs.webkit.org/show_bug.cgi?id=47456
1147 Remove dependency on a WebKit-only quirk. IMHO, this quirk is bad for
1148 the long-term health of the web, but that's a discussion for another
1151 * committers-autocomplete.js:
1153 2010-10-08 Adam Barth <abarth@webkit.org>
1155 Reviewed by Oliver Hunt.
1157 Bugmail for new attachments should link to the reviewtool
1158 https://bugs.webkit.org/show_bug.cgi?id=47440
1160 As requested by olliej himself. This patch was constructed by pure
1161 reason. I have no way to actually run this code.
1163 * Bugzilla/BugMail.pm:
1165 2010-09-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1167 Reviewed by Csaba Osztrogonác.
1169 Convert verbatim unicode values in comitter names to characters
1171 * committers-autocomplete.js:
1173 2010-09-24 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1175 Reviewed by Csaba Osztrogonác.
1177 Support Unicode-strings in committers-autocomplete script
1179 * committers-autocomplete.js:
1181 2010-09-22 Adam Barth <abarth@webkit.org>
1183 Reviewed by John Sullivan.
1185 New review-page design doesn't include name of reviewer
1186 https://bugs.webkit.org/show_bug.cgi?id=46271
1188 * PrettyPatch/PrettyPatch.rb:
1191 2010-09-22 Adam Barth <abarth@webkit.org>
1195 * PrettyPatch/PrettyPatch.rb:
1197 2010-09-22 Adam Barth <abarth@webkit.org>
1199 Reviewed by Eric Seidel.
1201 Add link to bug to review page
1202 https://bugs.webkit.org/show_bug.cgi?id=46192
1204 To make room for the link, I moved the help text to the top of the page
1205 and tweaked the language to help folks discover that you can select
1206 context using the line numbers.
1208 Also, move more text to sans-serif since that fits in better with the
1211 * PrettyPatch/PrettyPatch.rb:
1214 2010-09-21 Adam Barth <abarth@webkit.org>
1218 [reviewtool] Publish button doesn't work
1219 https://bugs.webkit.org/show_bug.cgi?id=46168
1221 Darin's recent patch had a runtime error. Sadly, we don't have any
1222 testing for this code.
1226 2010-09-20 Darin Adler <darin@apple.com>
1228 Reviewed by Adam Barth.
1230 Add Preview button and link to bug to patch review bar
1231 https://bugs.webkit.org/show_bug.cgi?id=46153
1233 * PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
1234 * code-review.js: Added Preview button and link to bug.
1236 2010-09-19 Adam Barth <abarth@webkit.org>
1238 Reviewed by Eric Seidel.
1240 [reviewtool] Publish button should actually publish the review comments
1241 https://bugs.webkit.org/show_bug.cgi?id=46074
1243 Instead of showing the confirmation lightbox, the Publish button now
1244 publishes the comments directly. If there's demand for a "Preview"
1245 button, we can find a way to add that feature.
1249 2010-09-19 Adam Barth <abarth@webkit.org>
1251 Reviewed by Eric Seidel.
1253 Move reviewtool to action=review
1254 https://bugs.webkit.org/show_bug.cgi?id=46071
1256 This patch removes the old Review Patch screen and moves the new
1257 reviewtool from Pretty Diff to Review Patch.
1262 2010-09-19 Adam Barth <abarth@webkit.org>
1264 Review tool UI tweak. This patch lengthens the status bubbles so all
1265 the bubble fit (even when they have numbers inside).
1267 * PrettyPatch/PrettyPatch.rb:
1269 2010-09-19 Dan Bernstein <mitz@apple.com>
1271 Reviewed by Anders Carlsson.
1275 * code-review.js: Changed the label of the OK button from Ok to OK.
1277 2010-09-15 Adam Barth <abarth@webkit.org>
1281 Only show the review-in-context link if there are contextual comments.
1285 2010-09-15 Adam Barth <abarth@webkit.org>
1287 Reviewed by Eric Seidel.
1289 [reviewtool] Show the status bubbles on the toolbar
1290 https://bugs.webkit.org/show_bug.cgi?id=45861
1292 * PrettyPatch/PrettyPatch.rb:
1295 2010-09-15 Adam Barth <abarth@webkit.org>
1297 Reviewed by Eric Seidel.
1299 [reviewtool] Allow setting review and commit-queue flags from main review screen
1300 https://bugs.webkit.org/show_bug.cgi?id=45860
1302 This patch adds drop down menus for adjusting the review and
1303 commit-queue flags from the main review screen. These controls don't
1304 appear immediately because we need to read the state of the flags off
1307 It's a slight sadness that bugzilla doesn't have a clean way of
1308 identifying which select control is associated with a given flag. The
1309 flags seem to have some sort of id, but it's unclear to me how to map
1310 that id back to a notion of "review" or "commit-queue". Instead, we
1311 look for some magic strings in the title. I'm sure this will come back
1312 to bit us at some point, but I'm not sure what to do that's better.
1313 (The webkitpy solution to this problem is to assume that the flags are
1314 in a given order, but this seems better.)
1316 * PrettyPatch/PrettyPatch.rb:
1317 - Bump version number to bust throuh caches.
1320 2010-09-15 Adam Barth <abarth@webkit.org>
1322 Reviewed by Eric Seidel.
1324 [reviewtool] Comments should quote previous comments on the same line
1325 https://bugs.webkit.org/show_bug.cgi?id=45847
1327 Now when you reply to a previous comment, the tool will quote the
1328 previous comment in the bugs.webkit.org post. This makes it eaiser for
1329 folks following along in email to understand the discussion.
1331 While I was editing this code, I also cleaned up some of the whitespace
1332 handling in comments.
1336 2010-09-15 Adam Barth <abarth@webkit.org>
1338 Minor UI tweak to the review tool. We want to display newlines in
1339 previous and frozen comments instead of collapsing them.
1341 * PrettyPatch/PrettyPatch.rb:
1343 2010-09-14 Adam Barth <abarth@webkit.org>
1345 Reviewed by Eric Seidel.
1347 bugs.webkit.org should autocomplete WebKit Committers and Reviewers
1348 https://bugs.webkit.org/show_bug.cgi?id=45799
1350 This patch implements an autocomplete dropdown that helps users type
1351 the names of WebKit committers and reviewers. The script grabs the
1352 data from SVN now that wms set up CORS for http://svn.webkit.org.
1353 Security technology for the win.
1355 This script is based on (well, essentially copied from) the popular
1356 autocomplete extension:
1358 https://chrome.google.com/extensions/detail/olaabhcgdogcbcoiolomlcodkngnemfb
1360 I asked Ojan, and said he was fine licensing the code under the BSD
1361 license. I'm not sure how the patch interacts with the extension, but
1362 we can retire the extension if they interact poorly.
1364 * committers-autocomplete.js: Added.
1365 * template/en/default/global/footer.html.tmpl:
1366 - Add the script to every page on bugs.webkit.org
1368 2010-09-14 Adam Barth <abarth@webkit.org>
1370 Add a license block to the reviewtool. I should have added this from
1371 the start. According to the SVN log, I'm the only one to have ever
1376 2010-09-07 Adam Barth <abarth@webkit.org>
1378 Minor tweaks to the reviewtool UI.
1380 Rename Cancel to Discard to make it more clear what the button does.
1381 Also, move the style declaration for the focus ring later in the sheet
1384 * PrettyPatch/PrettyPatch.rb:
1387 2010-09-06 Adam Barth <abarth@webkit.org>
1389 Small UI tweak to the reviewtool. Make the Ok/Cancel buttons a bit
1392 * PrettyPatch/PrettyPatch.rb:
1394 2010-09-06 Adam Barth <abarth@webkit.org>
1396 Reviewed by Eric Seidel.
1398 [reviewtool] Add a quick animation for opening/closing comment boxes
1399 https://bugs.webkit.org/show_bug.cgi?id=45278
1401 The 200ms animation slides in and out the line-by-line comment box.
1405 2010-09-06 Adam Barth <abarth@webkit.org>
1407 Reviewed by Eric Seidel.
1409 [reviewtool] Add a field for overall comments
1410 https://bugs.webkit.org/show_bug.cgi?id=45273
1412 This patch does a couple logically separate things that could be
1413 separated into smaller patches:
1415 1) This patch adds an "overall comments" field where you can enter
1416 overall comments about the patch. These comments appear at the top
1417 of the bugzilla posting. Currently, these aren't redisplayed when
1418 viewing the patch, but I plan to add that in a future patch.
1420 2) This patch renames some of the CSS classes to more consistently
1421 follow the camelCase style that PrettyPatch uses.
1423 3) This patch moves the "prepare comments" button to the left of the
1424 toolbar and renames is to "publish comments". This makes more sense
1425 when you scroll to the bottom of the page and enter in some overall
1428 4) When you attempt to add a comment to a line that already has a
1429 "frozen" comment, we now unfreeze the comment instead of doing
1430 nothing. The old behavior was kind of frustrating if you didn't
1431 know that you could unfreeze a comment by clicking on it.
1433 * PrettyPatch/PrettyPatch.rb:
1437 2010-09-06 Adam Barth <abarth@webkit.org>
1439 [reviewtool] Tweak the ok button to cancel the comment if the comment
1440 is empty. Previously we would get into a bad state where a line had a
1441 comment but there was no longer any way to access it.
1445 2010-09-06 Adam Barth <abarth@webkit.org>
1447 Reviewed by Eric Seidel.
1449 [reviewtool] Add an "ok" button that collapses review comments
1450 https://bugs.webkit.org/show_bug.cgi?id=45255
1452 Many folks (including myself) are too trigger-happy with the "delete"
1453 button that we end up deleting perfectly good review comments. This
1454 patch adds an "ok" button to absorb these clicks (and renames "delete"
1455 to "cancel"). When you click the ok button, the comment becomes
1456 non-editable and the box shrinks to fit the text. You can click the
1457 text to get back to the editable version.
1461 2010-08-31 Adam Barth <abarth@webkit.org>
1463 Reviewed by Eric Seidel.
1465 [reviewtool] Make it easy to scroll through review comments
1466 https://bugs.webkit.org/show_bug.cgi?id=45002
1468 This patch lets you scroll through review comments using "n" (for next)
1469 and "p" (for previous). It also attributes comments to their authors.
1471 * PrettyPatch/PrettyPatch.rb:
1474 2010-08-31 Adam Barth <abarth@webkit.org>
1476 Reviewed by Eric Seidel.
1478 [reviewtool] Show previous comments inline in diff
1479 https://bugs.webkit.org/show_bug.cgi?id=44977
1481 This patch adds basic support for showing previous comments inline in
1482 the diff. We crawl the bugs.webkit.org comments about this attachment
1483 and extract comments related to specific lines. We then show the
1484 comments inline in the diff.
1486 This part of the tool needs a bunch of polish, but this at least is a
1487 starting point for further work.
1489 * PrettyPatch/PrettyPatch.rb:
1492 2010-08-31 Adam Barth <abarth@webkit.org>
1494 Reviewed by Eric Seidel.
1496 [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers
1497 https://bugs.webkit.org/show_bug.cgi?id=44936
1499 * PrettyPatch/PrettyPatch.rb:
1500 - Add a version number to bust through bugs.webkit.org's aggressive
1504 2010-08-30 Adam Barth <abarth@webkit.org>
1506 Reviewed by Eric Seidel.
1508 [review tool] Let reviewer select how much context to show in snippet
1509 https://bugs.webkit.org/show_bug.cgi?id=44905
1511 We now highlight the context for a comment in yellow on the left (where
1512 the line numbers are). Clicking a line number expands or contracts the
1513 amount of context, as appropriate. Informal user testing indicates
1514 that we might want to support drag as well.
1516 This patch also changes the "open a comment box here" action to
1517 double-click to avoid issues with mis-clicks.
1519 * PrettyPatch/PrettyPatch.rb:
1522 2010-08-29 Adam Barth <abarth@webkit.org>
1524 Attempt to make Sam's life easier by not opening a comment text field
1525 if there's a selection. This should make it easier to copy/paste text
1526 out of the diff without accidentally opening comment boxes.
1530 2010-08-29 Adam Barth <abarth@webkit.org>
1532 Turns out we're supposed to use find instead of children here.
1536 2010-08-29 Adam Barth <abarth@webkit.org>
1538 Reviewed by Eric Seidel.
1540 Awesomify pretty-diff based review tool
1541 https://bugs.webkit.org/show_bug.cgi?id=44835
1543 This patch replaces the existing inline comment feature with a new
1544 implementation. Hopefully the new implementation is more awesome.
1545 It's not 100% done yet, but I'd like to get this version out there to
1548 Unlike the previous version this version works with the "Formatted
1549 Diff" link instead of the "Review Patch" link. Hopefully that will
1550 avoid interfering with folks who like the old style review.
1552 * PrettyPatch/PrettyPatch.rb:
1553 * code-review.js: Added.
1554 * prototype.js: Removed.
1556 2010-08-19 Tony Chang <tony@chromium.org>
1558 Reviewed by Adam Barth.
1560 webkit-patch barfed on upload with a new image test result
1561 https://bugs.webkit.org/show_bug.cgi?id=39097
1563 * PrettyPatch/PrettyPatch.rb: don't use full path to git
1565 2010-08-19 Tony Chang <tony@chromium.org>
1567 Unreviewed, setting svn:eol-style native on ChangeLog.
1569 2010-08-19 Tony Chang <tony@chromium.org>
1571 Unreviewed. Just removing \r's from ChangeLog.
1573 2010-08-02 Adam Roben <aroben@apple.com>
1575 Tell the patch prettifier about some (not so) new directories
1577 * PrettyPatch/PrettyPatch.rb: Added WebKit2, autotools, and cmake
1580 2010-07-27 Joseph Pecoraro <joepeck@webkit.org>
1582 Reviewed by David Kilzer.
1584 Provide a Helpful Link for Web Inspector Bugs in Bugzilla
1585 https://bugs.webkit.org/show_bug.cgi?id=43065
1587 * template/en/custom/global/choose-product.html.tmpl: Added. Explicitly added a link for the Web Inspector.
1589 2010-06-09 Julie Parent <jparent@chromium.org>
1591 Reviewed by David Kilzer.
1593 Bugzilla: Don't send mail for cancel/deny/granted for in-rietveld.
1595 https://bugs.webkit.org/show_bug.cgi?id=40345
1599 2010-05-17 Julie Parent <jparent@chromium.org>
1601 Reviewed by Ojan Vafai.
1603 Rietveld review page should dedicate more space to Rietveld, less to high level comments form.
1605 https://bugs.webkit.org/show_bug.cgi?id=39244
1607 * template/en/custom/attachment/reviewform.html.tmpl:
1608 Delete a random BR amongst the hidden elements that was causing extra whitespace.
1609 * template/en/custom/attachment/rietveldreview.html.tmpl:
1610 Increase size of Rietveld frame to 80%, from 60%.
1612 2010-05-14 Julie Parent <jparent@chromium.org>
1614 Reviewed by Ojan Vafai.
1616 Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +.
1618 https://bugs.webkit.org/show_bug.cgi?id=39141
1620 * template/en/custom/attachment/list.html.tmpl:
1622 2010-05-13 Julie Parent <jparent@chromium.org>
1624 Reviewed by David Kilzer.
1626 Bugzilla: Don't send mail if the only change is to the in-rietveld flag.
1628 https://bugs.webkit.org/show_bug.cgi?id=39090
1630 * Bugzilla/BugMail.pm:
1632 2010-05-12 Julie Parent <jparent@chromium.org>
1634 Reviewed by Ojan Vafai.
1636 Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI.
1637 https://bugs.webkit.org/show_bug.cgi?id=39024
1639 * template/en/custom/attachment/list.html.tmpl:
1640 Removes this flag entirely from the UI, not needed on this page.
1641 * template/en/custom/flag/list.html.tmpl: Added.
1642 Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section.
1643 Hides the flag rather than removing it completely, so tools can still interact with it.
1645 2010-05-12 Julie Parent <jparent@chromium.org>
1647 Reviewed by David Kilzer.
1649 Adds support for Rietveld reviews. When there is an associated
1650 Rietveld id for a patch, adds a link to do a Rietveld review instead.
1652 https://bugs.webkit.org/show_bug.cgi?id=38143
1655 Added support for handling action=rietveldreview.
1656 * template/en/custom/attachment/list.html.tmpl:
1657 Adds a link to use rietveld review iff the in_rietveld flag is set.
1658 * template/en/custom/attachment/reviewform.html.tmpl:
1659 Detects if we are in rietveld review mode due to query string paramter,
1660 and customizes the review form slightly:
1661 - Changes text describing comment field.
1662 - Comment field does not include quoted patch.
1663 - Submit button fetches from Rietveld instead of just submitting.
1664 * template/en/custom/attachment/rietveldreview.html.tmpl: Added.
1665 New template for rietveldreview mode. Hosts the rietveld frame in the
1666 top and the regular comments form in the bottom.
1667 Uses postMessage to communicate with Rietveld frame.
1669 2010-05-08 Chris Jerdonek <cjerdonek@webkit.org>
1671 Reviewed by Maciej Stachowiak.
1673 Allow long comment lines to wrap to the window width instead
1674 of to 80 characters.
1676 https://bugs.webkit.org/show_bug.cgi?id=37792
1678 * Bugzilla/Constants.pm:
1679 - Introduced a new constant COMMENT_COLS_WRAP to replace COMMENT_COLS
1680 inside the wrap_comment() subroutine. The new constant effectively
1681 disables text wrapping by increasing the value used in wrap_comment()
1682 from 80 characters to a very large value (8000).
1684 - Replaced COMMENT_COLS with COMMENT_COLS_WRAP inside wrap_comment().
1685 * skins/custom/global.css:
1687 - Eliminate the width styling on comments to allow long lines
1688 to wrap at the window width.
1689 (.bz_comment_text > span.quote):
1690 - Inherit the "white-space" property. This prevents long quoted
1691 lines in comments from causing non-quoted lines to extend beyond
1694 2010-04-22 Adam Barth <abarth@webkit.org>
1696 Reviewed by Darin Adler.
1698 The new review tools shouldn't clear the comment box automatically
1699 https://bugs.webkit.org/show_bug.cgi?id=38004
1701 Instead, we now have a button for doing that explicitly. If people
1702 like this tool, we can look at fancier solutions.
1704 Also, tried to make the tool work on the edit page as well as the review page.
1706 * PrettyPatch/PrettyPatch.rb:
1708 2010-04-22 Adam Barth <abarth@webkit.org>
1710 Unreviewed. Turns out we need to do more escaping because Ruby was
1711 explanding our newlines, creating a syntax error.
1713 * PrettyPatch/PrettyPatch.rb:
1715 2010-04-22 Adam Barth <abarth@webkit.org>
1717 Reviewed by Darin Adler.
1719 Hack up PrettyDiff to allow line-by-line comments
1720 https://bugs.webkit.org/show_bug.cgi?id=37886
1722 Admittedly a bit of a hack, this is a basic line-by-line editor we can
1723 play with thanks to Andrew Scherkus. It's meant to integrate with the
1724 "review" page at bugs.webkit.org.
1726 I changed a few things from Andrew's original version:
1727 1) Trigger text boxes on single click to make iPhone/iPad reviewing
1729 2) Clear the main text box on load.
1730 3) Reference a version of prototype.js on bugs.webkit.org.
1732 * PrettyPatch/PrettyPatch.rb:
1733 * prototype.js: Added.
1735 2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1737 Reviewed by Maciej Stachowiak.
1739 Don't reset the assignee back to default on component change
1741 https://bugs.webkit.org/show_bug.cgi?id=35236
1743 There's a risk of reseting a valid assignee for example when
1744 triaging a bug. All components in WebKit have the default
1745 assignee set to webkit-unassigned@webkit.org so this should
1746 not cause problems for people relying on this functionality.
1748 * template/en/custom/bug/edit.html.tmpl:
1750 2010-01-22 Janusz Lewandowski <lew21@xtreeme.org>
1752 Reviewed by Maciej Stachowiak.
1754 run-webkit-tests fails on Ruby 1.9
1755 https://bugs.webkit.org/show_bug.cgi?id=33554
1756 inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors.
1758 * PrettyPatch/PrettyPatch.rb:
1760 2010-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1762 Reviewed by Adam Barth.
1764 Adjust height of status-bubbles to prevent them being cut.
1766 * template/en/custom/attachment/edit.html.tmpl:
1767 * template/en/custom/attachment/list.html.tmpl:
1768 * template/en/custom/attachment/reviewform.html.tmpl:
1770 2010-01-08 David Kilzer <ddkilzer@apple.com>
1772 <http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button
1774 Reviewed by Adam Barth.
1776 This button was broken during a previous Bugzilla upgrade after
1777 changes were made to the names of objects exposed on templates.
1779 * template/en/custom/attachment/reviewform.html.tmpl: Changed
1780 attachid to attachment.id and ispatch to attachment.ispatch.
1781 Also tweaked the format to use 4 table columns instead of 5.
1783 2010-01-08 David Kilzer <ddkilzer@apple.com>
1785 Included UNCONFIRMED bugs by default in advanced search query
1787 Rubber-stamped by Alexey Proskuryakov.
1789 * data/params: Prepended 'bug_status=UNCONFIRMED&' to
1790 'defaultquery' parameter.
1792 2010-01-08 David Kilzer <ddkilzer@apple.com>
1794 FIX: Make patch status appear on reviewform.html.tmpl
1796 * template/en/custom/attachment/reviewform.html.tmpl: Check
1797 attachment.ispatch (not just ispatch) when deciding whether
1798 to display patch status. Also update layout a bit.
1800 2010-01-08 David Kilzer <ddkilzer@apple.com>
1802 Update data/params parameters
1804 * data/params: Updated 'timezone' to turn off DST. Updated
1805 'usebugaliases' and 'usevotes' to turn them off.
1807 2010-01-08 Adam Barth <abarth@webkit.org>
1809 Reviewed by Darin Adler.
1811 Show patch status in bugs.webkit.org
1812 https://bugs.webkit.org/show_bug.cgi?id=33368
1814 This patch adds an iframe to the show_bug page and the edit attachment
1815 page that displays whether the attachment passed the various bots.
1817 * template/en/custom/attachment/edit.html.tmpl:
1818 * template/en/custom/attachment/list.html.tmpl:
1819 * template/en/custom/attachment/reviewform.html.tmpl:
1821 2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
1823 Reviewed by David Kilzer.
1825 Bugzilla should show images in git patches
1826 https://bugs.webkit.org/show_bug.cgi?id=31395
1828 Attempt to go r51748 again using --directory option of git-apply.
1830 * PrettyPatch/PrettyPatch.rb:
1832 2009-12-06 Shinichiro Hamaji <hamaji@chromium.org>
1834 Unreviewed. Revert r51748.
1836 Bugzilla should show images in git patches
1837 https://bugs.webkit.org/show_bug.cgi?id=31395
1839 * PrettyPatch/PrettyPatch.rb:
1841 2009-12-06 Shinichiro Hamaji <hamaji@chromium.org>
1843 Reviewed by David Kilzer.
1845 Bugzilla should show images in git patches
1846 https://bugs.webkit.org/show_bug.cgi?id=31395
1848 Show images in git patches using git-apply.
1850 * PrettyPatch/PrettyPatch.rb:
1852 2009-10-23 Eric Seidel <eric@webkit.org>
1854 Reviewed by Adam Roben.
1856 PrettyPatch should show images even when they have the wrong mime type
1857 https://bugs.webkit.org/show_bug.cgi?id=29506
1859 * PrettyPatch/PrettyPatch.rb:
1861 2009-10-17 Alexey Proskuryakov <ap@apple.com>
1863 Reviewed by Eric Carlson.
1865 https://bugs.webkit.org/show_bug.cgi?id=30470
1866 Make marking a bug as duplicate easier
1868 * js/field.js: (setResolutionToDuplicate): Focus the edit field, too.
1870 2009-10-16 Alexey Proskuryakov <ap@apple.com>
1872 Reviewed by Mark Rowe.
1874 https://bugs.webkit.org/show_bug.cgi?id=30470
1875 Make marking a bug as duplicate easier
1877 * js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user
1880 2009-09-09 David Kilzer <ddkilzer@apple.com>
1882 Update data/params parameters
1884 * data/params: Updated 'attachment_base' parameter for secure
1885 attachments. Updated 'mybugstemplate' parameter to search for
1886 bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to
1889 2009-08-11 David Kilzer <ddkilzer@apple.com>
1891 Updated data/params parameter
1893 * data/params: Updated 'loginnetmask' parameter to allow users
1894 to choose whether their cookies are restricted to a single IP
1897 2009-07-07 David Kilzer <ddkilzer@apple.com>
1899 Updated BugsSite with local changes on server
1901 The new files were created by checksetup.pl during the upgrade
1902 to Bugzilla 3.2.3. The rest are self-explanatory.
1904 * data: Added "bugzilla-update.xml" to svn:ignore.
1905 * data/attachments: Added "groups.*" to svn:ignore.
1906 * data/params: Updated for a few changed parameters.
1908 * lib/.htaccess: Added.
1909 * skins/contrib/Dusk/IE-fixes.css: Added.
1910 * skins/contrib/Dusk/admin.css: Added.
1911 * skins/contrib/Dusk/create_attachment.css: Added.
1912 * skins/contrib/Dusk/dependency-tree.css: Added.
1913 * skins/contrib/Dusk/duplicates.css: Added.
1914 * skins/contrib/Dusk/editusers.css: Added.
1915 * skins/contrib/Dusk/help.css: Added.
1916 * skins/contrib/Dusk/index.css: Added.
1917 * skins/contrib/Dusk/panel.css: Added.
1918 * skins/contrib/Dusk/params.css: Added.
1919 * skins/contrib/Dusk/release-notes.css: Added.
1920 * skins/contrib/Dusk/show_bug.css: Added.
1921 * skins/contrib/Dusk/show_multiple.css: Added.
1922 * skins/contrib/Dusk/summarize-time.css: Added.
1923 * skins/contrib/Dusk/voting.css: Added.
1924 * skins/contrib/Dusk/yui: Added.
1925 * skins/contrib/Dusk/yui/calendar.css: Added.
1926 * skins/custom/IE-fixes.css: Added.
1927 * skins/custom/admin.css: Added.
1928 * skins/custom/buglist.css: Added.
1929 * skins/custom/create_attachment.css: Added.
1930 * skins/custom/dependency-tree.css: Added.
1931 * skins/custom/duplicates.css: Added.
1932 * skins/custom/editusers.css: Added.
1933 * skins/custom/help.css: Added.
1934 * skins/custom/panel.css: Added.
1935 * skins/custom/params.css: Added.
1936 * skins/custom/release-notes.css: Added.
1937 * skins/custom/show_bug.css: Added.
1938 * skins/custom/show_multiple.css: Added.
1939 * skins/custom/summarize-time.css: Added.
1940 * skins/custom/voting.css: Added.
1941 * skins/custom/yui: Added.
1942 * skins/custom/yui/calendar.css: Added.
1944 2009-07-03 David Kilzer <ddkilzer@apple.com>
1946 Bug 26958: Change edit link to review link in request messages
1948 <https://bugs.webkit.org/show_bug.cgi?id=26958>
1950 Reviewed by Dan Bernstein.
1952 * template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl.
1953 Changed link from "action=edit" to "action=review".
1955 2009-07-03 David Kilzer <ddkilzer@apple.com>
1957 Bug 26950: Make the summary and alias fields support click-to-edit
1958 <https://bugs.webkit.org/show_bug.cgi?id=26950>
1960 Reviewed by Maciej Stachowiak.
1962 Original patch by Maciej Stachowiak.
1965 (hideEditableField): Updated to add click event listeners to the
1966 alias and short description elements to make them easier to
1967 edit. Renamed field_id parameter to field2_id (short
1968 description id) and added a field1_id parameter (alias id).
1969 (showEditableField): If a third parameter is passed in the
1970 ContainerInputArray parameter, use it to find the element to
1971 focus. Otherwise, fall back to the original behavior of
1972 focusing the first input field.
1973 (hideAliasAndSummary): Changed to pass the id for the alias
1974 element to hideEditableField().
1976 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1978 Config file for contrib/recode.pl when upgrading bugs.webkit.org
1980 Current as of midday on Wednesday, July 1, 2009.
1982 * contrib/recode-overrides.txt: Added.
1984 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1986 Workaround for WebKit Bug 9630 when running contrib/recode.pl
1988 A number of WebKit nightly builds included Bug 9630 which caused
1989 non-breaking space characters (0xA0) to be submitted within the
1990 content of textarea elements.
1992 * contrib/recode.pl: To work around these 0xA0 characters, try
1993 an encoding of cp1252 and use it if it works.
1995 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1997 Don't print "Failed to guess" warning if an override is available
1999 * contrib/recode.pl: Check that %overrides does NOT contain a
2000 key matching the current digest before printing out the warning
2001 about a failed charset guess.
2003 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
2005 Added --[no-]truncate switch to contrib/recode.pl
2007 * contrib/recode.pl: Added --[no-]truncate switch to make
2008 debugging of failed charset guessing easier. Often times the
2009 illegal character was truncated in the output.
2011 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
2013 Changed Perl scripts to use #!/usr/bin/env perl
2015 perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl
2017 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
2019 Replace Bugzilla favicon with webkit.org favicon
2021 * favicon.ico: Removed.
2022 * images/favicon.ico: Replaced. Copied from favicon.ico.
2024 2009-07-02 David Kilzer <ddkilzer@webkit.org>
2026 Merged BugsSite to Bugzilla-3.2.3
2028 Updated to the latest-and-greatest stable version.
2030 2009-07-02 David Kilzer <ddkilzer@webkit.org>
2032 Merged BugsSite to Bugzilla-3.0.3
2034 Nothing to see here. Move along.
2036 2009-06-09 Eric Seidel <eric@webkit.org>
2038 Reviewed by Adam Roben.
2040 Add support for displaying added png files in PrettyPatch diffs
2041 https://bugs.webkit.org/show_bug.cgi?id=26210
2043 Currently this is SVN only (git-send-bugzilla patches exclude binary data)
2044 and only works for PNG files but could easily be made to work for other images as needed.
2046 * PrettyPatch/PrettyPatch.rb:
2048 2009-05-19 Eric Seidel <eric@webkit.org>
2050 Reviewed by Adam Roben.
2052 Make PrettyPatch understand quoted filenames in git diffs.
2053 https://bugs.webkit.org/show_bug.cgi?id=25881
2055 * PrettyPatch/PrettyPatch.rb:
2057 2009-05-15 Simon Fraser <simon.fraser@apple.com>
2059 Carrying forwards Darin Adler's rubber stamp
2061 Make the comment field wider too.
2063 * skins/custom/global.css:
2065 2009-05-14 Simon Fraser <simon.fraser@apple.com>
2067 Reviewed by Darin Adler
2069 Make the URL, Summary and Keyword fields wider to mitigate the
2070 effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make
2071 things generally better.
2073 * skins/custom/global.css:
2074 * template/en/custom/bug/edit.html.tmpl:
2076 2008-11-10 Darin Adler <darin@apple.com>
2078 - fix more of https://bugs.webkit.org/show_bug.cgi?id=21400
2079 "Edit" links for patches in comments, review queue, review emails
2080 should be replaced by "Review Patch" links
2082 * globals.pl: Fix cases that are automatically generated, such as links
2083 in comments in bugs.
2085 * template/en/custom/attachment/created.html.tmpl: Fix the link on the
2086 "I just created an attachment" page.
2088 * template/en/custom/request/queue.html.tmpl: Fix the link in the queue
2091 2008-11-10 Darin Adler <darin@apple.com>
2093 * template/en/default/request/queue.html.tmpl: Use review links instead
2094 of edit links in the review queue.
2096 2008-11-10 Darin Adler <darin@apple.com>
2098 * template/en/custom/request/email.txt.tmpl: Send review links instead
2099 of edit links when flags are set on a bug.
2101 2008-10-27 Darin Adler <darin@apple.com>
2103 * template/en/custom/attachment/reviewform.html.tmpl: Leave out the
2104 comment if it's untouched.
2106 2008-10-23 Adam Roben <aroben@apple.com>
2108 Fix Bug 21401: Comments field on "Review Patch" page should be
2109 initially filled with quoted patch
2111 <https://bugs.webkit.org/show_bug.cgi?id=21401>
2113 Reviewed by Dave Hyatt.
2116 (edit): Retrieve the attachment data from the database instead of just
2117 its length. When the attachment is a patch, create a quotedpatch
2118 template variable that contains the patch data with each line
2119 prepended with "> ".
2120 * template/en/custom/attachment/reviewform.html.tmpl:
2121 - Changed the comments field to have a monospace font
2122 - Added an "Enter comments below:" caption above the comments field
2123 to make it clearer that this is where comments should go, now that
2124 the comments field is not initially empty
2125 - Fill the comments field with the quoted patch
2127 2008-10-14 Adam Roben <aroben@apple.com>
2129 Fix Bug 21602: Bugzilla times out trying to display formatted diff for
2132 https://bugs.webkit.org/show_bug.cgi?id=21602
2134 Reviewed by Dave Kilzer.
2136 * PrettyPatch/PrettyPatch.rb:
2137 (PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added.
2138 (PrettyPatch.FileDiff.initialize): If any of the lines in the diff
2139 are a binary file marker, mark this FileDiff as binary and stop trying
2140 to process the lines.
2141 (PrettyDiff.FileDiff.to_html): If we're binary, just print a string
2144 2008-10-02 Adam Roben <aroben@apple.com>
2146 * template/en/custom/attachment/reviewform.html.tmpl: Fix typo.
2148 2008-10-02 Adam Roben <aroben@apple.com>
2150 * template/en/custom/attachment/review.html.tmpl: Fix URLs
2152 2008-10-02 Adam Roben <aroben@apple.com>
2154 Fix Bug 21315: bugs.webkit.org should have a nicer patch review
2157 https://bugs.webkit.org/show_bug.cgi?id=21315
2159 Reviewed by Tim Hatcher.
2162 (top level): Added support for the "review" and "reviewform" actions.
2163 (sub edit): Accept the template name as a parameter. If no name is
2164 give, use "edit" as before.
2165 * template/en/custom/attachment/list.html.tmpl: Added a "Review Patch"
2166 link for all patch attachments.
2167 * template/en/custom/attachment/review.html.tmpl: Added. Simple
2168 <frameset> page to show the patch on the top and a comment form on the
2170 * template/en/custom/attachment/reviewform.html.tmpl: Added. Simple
2171 comment form for reviewing patches.
2173 2008-10-02 Adam Roben <aroben@apple.com>
2175 Remove references to some backup files I created when implementing
2176 PrettyPatch in Bugzilla
2178 Reviewed by Tim Hatcher.
2180 * attachment-aroben.cgi: Removed.
2181 * template/en/default/attachment/edit-aroben.html.tmpl: Removed.
2183 * template/en/custom/attachment/edit.html.tmpl: Removed an erroneous
2184 reference to attachment-aroben.cgi. attachment.cgi will work just
2187 2008-06-25 David Kilzer <ddkilzer@apple.com>
2189 Make PrettyPatch handle diffs with no Index or diff headers
2191 Part of Bug 19290: More patches not handled by PrettyPatch.rb
2192 <https://bugs.webkit.org/show_bug.cgi?id=19290>
2196 * PrettyPatch/PrettyPatch.rb:
2197 (PrettyPatch.DIFF_HEADER_FORMATS): Added regular expression to
2198 match on "+++ " lines for patches with no "Index" or "diff" header.
2199 (PrettyPatch.FileDiff.initialize): Look for filename on "+++ " line
2200 when the first line of a patch has no "Index" or "diff" header.
2201 (PrettyPatch.FileDiff.parse): Added haveSeenDiffHeader state
2202 variable to determine when no "Index" or "diff" header has been
2203 found, but a new patch has started with a "--- " line.
2205 2008-06-08 Dan Bernstein <mitz@apple.com>
2207 Reviewed by Adam Roben.
2209 - update trac URL in PrettyPatch
2211 * PrettyPatch/PrettyPatch.rb:
2213 2008-05-29 Adam Roben <aroben@apple.com>
2215 Update PrettyPatch directory list
2217 * PrettyPatch/PrettyPatch.rb:
2219 2008-05-28 Adam Roben <aroben@apple.com>
2221 Make PrettyPatch able to handle diffs taken from outside the WebKit
2224 Part of Bug 19290: More patches not handled by PrettyPatch.rb
2225 <https://bugs.webkit.org/show_bug.cgi?id=19290>
2227 Reviewed by David Kilzer.
2229 * PrettyPatch/PrettyPatch.rb:
2230 (PrettyPatch.find_url_and_path): Added. Searches the file path from
2231 the bottom up looking for a directory that exists in the source tree.
2232 (PrettyPatch.linkifyFilename): Changed to call find_url_and_path.
2234 2008-05-28 Adam Roben <aroben@apple.com>
2236 Print exceptions from PrettyPatch to stdout
2238 This will make it much easier to debug problems with PrettyPatch,
2239 since we'll be able to see the exceptions in the browser.
2241 Reviewed by Sam Weinig.
2243 * PrettyPatch/prettify.rb: Added a --html-exceptions option, which
2244 will print exceptions to stdout as HTML.
2245 * attachment.cgi: Changed to pass --html-exceptions to prettify.rb.
2247 2008-04-26 David Kilzer <ddkilzer@apple.com>
2249 Removed temp files and added appropriate svn:ignore properties.
2251 Rubber-stamped by Mark Rowe.
2253 * data: Added svn:ignore property for "versioncache" and "versioncache.*" files.
2255 * data/template: Added svn:ignore property for "template" subdirectory.
2256 * data/template/template: Removed precompiled template subdirectory.
2258 * data/versioncache: Removed.
2259 * data/versioncache.*: Removed backup versioncache files.
2261 * data/webdot: Added svn:ignore property for "*.dot" files.
2262 * data/webdot/*.dot: Removed cached webdot files.
2264 2008-04-08 Adam Roben <aroben@apple.com>
2266 Combine :equal operations with the following operation if they are
2267 fewer than 3 characters long
2269 This keeps us from showing lots of small changes on long lines, just
2270 because some letters happened to be the same.
2273 http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/diffviewer/diffutils.py?r=1264#147
2275 * PrettyPatch/PrettyPatch.rb:
2276 (PrettyPatch::DiffSection.initialize): Remove :equal operations fewer
2277 than 3 characters long. The characters from the removed operations
2278 become part of the subsequent operation.
2279 (PrettyPatch::CodeLine.text_as_html): Don't wrap 0-length strings in
2280 <ins>/<del> tags. Also removed the @fromLineNumber.nil? and
2281 @toLineNumber.nil? checks as they are no longer reliable now that
2282 we're removing operations.
2284 2008-04-08 Adam Roben <aroben@apple.com>
2286 Change PrettyPatch to use DiffBuilder for intra-line diffs
2288 This gives us much prettier intra-line diffs, largely because it can
2289 distinguish multiple changes on the same line. e.g., if a line changes
2292 const int myConstant = 0;
2296 static const unsigned myConstant;
2298 You will see that "static " was inserted, "int" changed to "unsigned",
2299 and " = 0" was deleted.
2301 This seems to have also gotten rid of some spurious instances of
2302 "<ins></ins>" and "<del></del>" at the end of a line.
2304 * PrettyPatch/PrettyPatch.rb:
2305 (PrettyPatch::DiffSection.initialize): Use DiffBuilder instead of
2306 setChangeExtentFromLine (which had been copied from Trac's diffing
2308 (PrettyPatch::CodeLine):
2309 - Removed the changeExtent attribute
2310 - Added the operations attribute
2311 - Removed the setChangeExtentFromLine method
2312 (PrettyPatch::CodeLine.text_as_html): Uses @operations to determine
2313 what text to wrap in <ins> and <del> tags.
2314 * PrettyPatch/diff.rb: Deleted a bunch of code we don't use.
2315 (HTMLDiff::DiffBuilder.initialize): Moved code here from the old build
2316 method, but left out the calls to perform_operation, since we build
2317 the diff HTML outside of this class.
2318 (HTMLDiff::DiffBuilder.split_inputs_to_words): Removed calls to
2319 convert_html_to_list_of_words, since we're not diffing HTML.
2321 2008-04-08 Adam Roben <aroben@apple.com>
2326 http://instiki.rubyforge.org/svn/instiki/trunk/lib/diff.rb
2329 * PrettyPatch/diff.rb: Added.
2331 2008-03-04 Adam Roben <aroben@apple.com>
2333 * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to
2334 be omitted from the hunk header.