1 2011-02-21 Ojan Vafai <ojan@chromium.org>
3 Reviewed by Adam Barth.
5 [codereviewtool] focus comment on accept
6 https://bugs.webkit.org/show_bug.cgi?id=54930
10 2011-02-20 Ojan Vafai <ojan@chromium.org>
12 Reviewed by Adam Barth.
14 [codereviewtool] avoid overriding ctrl/cmd + r
15 https://bugs.webkit.org/show_bug.cgi?id=54852
19 2011-02-16 Ojan Vafai <ojan@chromium.org>
21 Reviewed by Adam Barth.
23 keyboard support for extending/shrinking comment context
24 https://bugs.webkit.org/show_bug.cgi?id=54612
26 ctrl+shift+up/down will extend/shrink the comment context when
27 a comment is focused or when one is being edited.
29 Also, switch over to using keydown instead of keypress events.
30 This lets us share code for handling escape and other key events.
31 Also, keypress is evil and should die.
35 2011-02-20 Ojan Vafai <ojan@chromium.org>
37 Recommit accidental revert.
38 r79180 accidentally revereted r79178.
41 2011-02-20 Ojan Vafai <ojan@chromium.org>
43 Reviewed by Adam Barth.
45 [codereviewtool] add more help information
46 https://bugs.webkit.org/show_bug.cgi?id=54847
50 2011-02-20 Ojan Vafai <ojan@chromium.org>
52 Reviewed by Adam Barth.
54 [codereviewtool] use 'r' to focus the review select element
55 https://bugs.webkit.org/show_bug.cgi?id=54845
57 This allows for quick keyboard access to the toolbar items.
58 Hit r to get to the review select element. Then you can
59 tab to the cq/preview/publish elements.
63 2011-02-20 Ojan Vafai <ojan@chromium.org>
65 Reviewed by Adam Barth.
67 [codereviewtool] don't let lines/diffblocks be mouse focusable
68 https://bugs.webkit.org/show_bug.cgi?id=54851
70 Unfortunately, this will only work once https://bugs.webkit.org/show_bug.cgi?id=54727
71 is committed. In the interim, it won't break anything.
75 2011-02-20 Ojan Vafai <ojan@chromium.org>
77 Reviewed by Adam Barth.
79 [codereviewtool] use keydown instead of keypress
80 https://bugs.webkit.org/show_bug.cgi?id=54849
82 There is no functional change. This is just a cleanup
83 to make future patches (e.g. https://bugs.webkit.org/show_bug.cgi?id=54612)
88 2011-02-20 Ojan Vafai <ojan@chromium.org>
90 Reviewed by Adam Barth.
92 [codereviewtool] fix layout nit
93 https://bugs.webkit.org/show_bug.cgi?id=54848
95 There is occasionally an off-by-one in the 50% width
96 calculation. This ensures that the add lines always
97 line up with the shared context lines.
99 * PrettyPatch/PrettyPatch.rb:
101 2011-02-20 Ojan Vafai <ojan@chromium.org>
103 Reviewed by Adam Barth.
105 [codereviewtool] make escape hide the preview form
106 https://bugs.webkit.org/show_bug.cgi?id=54844
110 2011-02-20 Ojan Vafai <ojan@chromium.org>
112 Reviewed by Adam Barth.
114 [codereviewtool] make enter work when an individual line is focused
115 https://bugs.webkit.org/show_bug.cgi?id=54843
119 2011-02-17 Ojan Vafai <ojan@chromium.org>
121 Reviewed by Adam Barth.
123 use shift+j/k to focus next/previous line
124 https://bugs.webkit.org/show_bug.cgi?id=54723
126 Tested on a large Hyatt change to confirm it performed fine.
127 (https://bugs.webkit.org/attachment.cgi?id=82533&action=review)
131 2011-02-17 Ojan Vafai <ojan@chromium.org>
133 Reviewed by Adam Barth.
135 fix escape handling in code review tool
136 https://bugs.webkit.org/show_bug.cgi?id=54722
138 This broke with http://trac.webkit.org/changeset/78948.
139 Apparently jquery events get a wrapped object that
140 does not expose keyIdentifier.
144 2011-02-17 Ojan Vafai <ojan@chromium.org>
146 Reviewed by Adam Barth.
148 create comments when hitting enter with a focused diff
149 https://bugs.webkit.org/show_bug.cgi?id=54719
153 2011-02-17 Ojan Vafai <ojan@chromium.org>
155 Reviewed by Adam Barth.
157 use actual browser focus in the code review tool
158 https://bugs.webkit.org/show_bug.cgi?id=54726
160 This makes keyboard handling play better with focusable element
161 (i.e. links/textareas/buttons). Also, in theory, this makes
162 the review tool more amenable to screen readers (I think).
164 * PrettyPatch/PrettyPatch.rb:
167 2011-02-17 Ojan Vafai <ojan@chromium.org>
169 Reviewed by Antonio Gomes.
171 make event handling work in Gecko
172 https://bugs.webkit.org/show_bug.cgi?id=54702
174 Gecko doesn't support the global event property. It's an IE-ism.
178 2011-02-14 Ojan Vafai <ojan@chromium.org>
180 Reviewed by Adam Barth.
182 allow for modifying comments without the mouse
183 https://bugs.webkit.org/show_bug.cgi?id=54433
185 Use n/p to navigate the comments.
186 Enter to begin editing a comment.
187 Escape to finish editing a comment.
191 2011-02-14 Ojan Vafai <ojan@chromium.org>
193 Reviewed by Adam Barth.
195 improve line selection in the code review tool
196 https://bugs.webkit.org/show_bug.cgi?id=54430
198 -shift+click now extends the comment context
199 -selecting outside of a diff section no longer clears the selected lines.
200 Instead it just restricts the selected lines to that diff section.
204 2011-02-10 Ojan Vafai <ojan@chromium.org>
206 Reviewed by Adam Barth.
208 remove extra space from expansion lines
209 https://bugs.webkit.org/show_bug.cgi?id=54266
213 2011-02-09 Ojan Vafai <ojan@chromium.org>
215 Reviewed by Adam Barth.
217 only erase draft comments after publish is successful
218 https://bugs.webkit.org/show_bug.cgi?id=54163
220 If there is a conflict or 500, then draft comments will survive.
221 One drawback here is that the form post is now to the iframe,
222 so to break out of the iframe we redirect to the bug page, which
223 loses the information of who the email was sent to.
225 Once WebKit supports seamless iframes we should be able to avoid
230 2011-02-09 Ojan Vafai <ojan@chromium.org>
232 Reviewed by Adam Barth.
234 save overall comments when saving drafts in the review tool
235 https://bugs.webkit.org/show_bug.cgi?id=54165
237 -save overall comments in localstorage as well
238 -save all draft comments as you type
239 -give a *subtle* indicator of saved state
241 The latter should also make it super easy if someone wanted to do
242 the work to store draft comments in appengine/s3/bugzilla/etc.
244 * PrettyPatch/PrettyPatch.rb:
245 * code-review-test.html:
248 2011-02-08 Ojan Vafai <ojan@chromium.org>
250 Reviewed by Adam Barth.
252 fix toolbar anchoring in the code review tool
253 https://bugs.webkit.org/show_bug.cgi?id=54058
255 Avoid the anchoring cycle of doom when on the cusp
256 of whether the toolbar needs to be anchored and
257 speculatively avoid the Firefox crash when resizing.
259 * PrettyPatch/PrettyPatch.rb:
262 2011-02-07 Ojan Vafai <ojan@chromium.org>
264 Reviewed by Adam Barth.
266 bring back diff context lines into the review tool
267 https://bugs.webkit.org/show_bug.cgi?id=53974
271 2011-02-01 Ojan Vafai <ojan@chromium.org>
273 Reviewed by Adam Roben.
275 include svn revisions in git diffs for the code review tool to use
276 https://bugs.webkit.org/show_bug.cgi?id=53569
278 * PrettyPatch/PrettyPatch.rb:
280 2011-02-01 Ojan Vafai <ojan@chromium.org>
282 Reviewed by Adam Barth.
284 make draft comments focusable
285 https://bugs.webkit.org/show_bug.cgi?id=53554
287 Makes frozen draft comments focusable. The ones that are currently being edited are not.
288 I'm on the fence whether they should be, but this seems good enough for now.
292 2011-02-01 Ojan Vafai <ojan@chromium.org>
294 Reviewed by Adam Barth.
296 avoid jitter when loading the comments to a patch
297 https://bugs.webkit.org/show_bug.cgi?id=53570
301 2011-02-01 Ojan Vafai <ojan@chromium.org>
303 Reviewed by Mihai Parparita.
305 [codereviewtool] extra space at the beginning of lines in side-by-side view
306 https://bugs.webkit.org/show_bug.cgi?id=53550
308 The newline between the spans turns into user-visible space in side-by-side mode.
310 * PrettyPatch/PrettyPatch.rb:
312 2011-02-01 Ojan Vafai <ojan@chromium.org>
314 Increment version number to cache-bust code-review.js.
316 * PrettyPatch/PrettyPatch.rb:
318 2011-01-31 Ojan Vafai <ojan@chromium.org>
320 Reviewed by Adam Barth.
322 Store draft comments in localStorage
323 https://bugs.webkit.org/show_bug.cgi?id=52866
326 * code-review-test.html
328 2011-01-20 Ojan Vafai <ojan@chromium.org>
330 Fix the review tool for image diffs. We would get a javascript error
331 because image diffs don't have line numbers.
335 2011-01-20 Ojan Vafai <ojan@chromium.org>
337 Reviewed by Oliver Hunt.
339 Could review tool include style failure info?
340 https://bugs.webkit.org/show_bug.cgi?id=49049
342 This does not handle patches that have old paths (e.g. without the Source prefix).
343 Although that would be fairly straightforward to workaround.
347 2011-01-20 Ojan Vafai <ojan@chromium.org>
349 Reviewed by Adam Barth.
351 handle cases where PrettyPatch.rb doesn't linkify filenames
352 https://bugs.webkit.org/show_bug.cgi?id=52834
356 2011-01-20 Ojan Vafai <ojan@chromium.org>
358 Reviewed by Adam Barth.
360 fix goofup in http://trac.webkit.org/changeset/76082
361 https://bugs.webkit.org/show_bug.cgi?id=52830
363 We were showing the revision number of the patch at the bottom
364 of the diff and expanding from the bottom of the diff would fail.
366 Also, removed an unused variable and scoped queries appropriatly
367 to the file_diff they should have been operating on.
369 * PrettyPatch/PrettyPatch.rb:
372 2011-01-19 Ojan Vafai <ojan@chromium.org>
374 Reviewed by Adam Barth.
376 [reviewtool] Add a link for annotated trac page on review page
377 https://bugs.webkit.org/show_bug.cgi?id=52747
379 -add line numbers to all trac links to the first line in the file diff
380 -add annotate/review log links
381 -make file-diff links other than the file name only show when you mouseover the filediff
382 -fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents
384 * PrettyPatch/PrettyPatch.rb:
387 2011-01-14 Ojan Vafai <ojan@chromium.org>
389 Reviewed by Adam Barth.
391 make line selection have a extend only from where you start the selection in the code review tool
392 https://bugs.webkit.org/show_bug.cgi?id=52485
396 2011-01-18 Ojan Vafai <ojan@chromium.org>
398 Reviewed by Eric Seidel.
400 make file expansion use the file at the svn revision the diff was created at
401 https://bugs.webkit.org/show_bug.cgi?id=52650
403 This only works for patches created with SVN for now since the git
404 diff does not include SVN revision numbers in it.
406 * PrettyPatch/PrettyPatch.rb:
409 2011-01-15 Adam Barth <abarth@webkit.org>
411 Rubber-stamped by Eric Seidel.
413 Move WebKit2 into Source
414 https://bugs.webkit.org/show_bug.cgi?id=52438
416 Remove WebKit2 from the list of top-level source directories.
418 * PrettyPatch/PrettyPatch.rb:
420 2011-01-14 Ojan Vafai <ojan@chromium.org>
422 Reviewed by Adam Barth.
424 fix expanded lines in the code review tool
425 https://bugs.webkit.org/show_bug.cgi?id=52498
427 Fixes them to work now that we have wrapper divs.
428 Also fixes the long-standing bug that the line numbers
429 were incorrect sometimes.
433 2011-01-14 Ojan Vafai <ojan@chromium.org>
435 Reviewed by Adam Barth.
437 put remove lines to the left of add lines in sidebyside view
438 https://bugs.webkit.org/show_bug.cgi?id=52458
440 Also, sneaking in a fix to make long lines with no whitespace wrap.
442 * PrettyPatch/PrettyPatch.rb:
445 2011-01-14 Ojan Vafai <ojan@chromium.org>
447 Fix bad merge in r75816.
451 2011-01-14 Ojan Vafai <ojan@chromium.org>
453 Reviewed by Adam Barth.
455 improve line selection with fast drags
456 https://bugs.webkit.org/show_bug.cgi?id=52477
460 2011-01-14 Ojan Vafai <ojan@chromium.org>
462 Reviewed by Adam Barth.
464 tweak line selection in code review tool
465 https://bugs.webkit.org/show_bug.cgi?id=52462
467 -Improve handling of data-comment-base-line code to deal with
468 lines that have multiple values.
469 -Make it so that if you click on the line immediately above
470 a line that has a comment it will add a new comment instead of
471 adding lines to the following comment. If the last selected line
472 overlaps existing comment lines though they will still get
473 added to the existing comment.
477 2011-01-14 Ojan Vafai <ojan@chromium.org>
479 Reviewed by Adam Roben.
481 fix bugs going back and forth between unified and sidebyside
482 https://bugs.webkit.org/show_bug.cgi?id=52470
484 Now that we're appending DOM nodes directly, we only want to
485 get the first ".text" element in the subtree. In the cases
486 where there are multiple, their contents are the same.
488 Also, when making side-by-side expansion lines, we need to
489 clone the contents so we have a second copy to append to the DOM.
493 2011-01-13 Ojan Vafai <ojan@chromium.org>
495 Reviewed by Adam Barth.
497 simplify keyboard handling in code review tool
498 https://bugs.webkit.org/show_bug.cgi?id=52407
500 Now that we have DiffBlock containers, the only things that are
501 focusable are previousComment nodes and DiffBlock containers
502 that contain add/remove lines.
504 Also, this means we show the focus border around the entire diff
505 instead of just the first line.
509 2011-01-13 Ojan Vafai <ojan@chromium.org>
511 Reviewed by Adam Barth.
513 add container divs for diff blocks
514 https://bugs.webkit.org/show_bug.cgi?id=52400
516 This will help simplify a lot of code in code-review.js
517 and make side-by-side diffs better (i.e. put removed lines
518 to the left of corresponding added lines).
520 Also, allow for running the JS from a local file. Now you can modify code-review.js
521 to point to a local file and then run:
522 ruby prettify.rb < foo.diff > foo.html
524 foo.html will load a dummy code review matching foo.diff.
547 * PrettyPatch/PrettyPatch.rb:
550 2011-01-12 Ojan Vafai <ojan@chromium.org>
552 Reviewed by Mihai Parparita.
554 fix assorted bugs with expansion lines
555 https://bugs.webkit.org/show_bug.cgi?id=52326
557 -Clicking "all" would collapse whitespace in the expanded lines.
558 -Converted the remaining line creation code to using the DOM.
560 * PrettyPatch/PrettyPatch.rb:
563 2011-01-12 Ojan Vafai <ojan@chromium.org>
565 Reviewed by Adam Barth.
567 review tool formatted diff doesn't match the uploaded diff
568 https://bugs.webkit.org/show_bug.cgi?id=51960
570 PrettyPatch works just fine if there is no newline at the end of the file.
574 2011-01-12 Ojan Vafai <ojan@chromium.org>
576 Reviewed by Adam Barth.
578 Bugzilla: Add keyboard shortcuts to jump to next change
579 https://bugs.webkit.org/show_bug.cgi?id=52305
581 Comments and diff blocks go in the same queue. If you have a
582 comment focused, then j/k will focus the next/prev diff block
583 with respect to that comment.
585 * PrettyPatch/PrettyPatch.rb:
588 2011-01-12 Ojan Vafai <ojan@chromium.org>
590 Reviewed by Adam Barth.
592 show shared lines on both sides in code review tool
593 https://bugs.webkit.org/show_bug.cgi?id=52308
595 We were appending the same DOM node twice. Instead, make
596 the from column a clone of the original node.
600 2011-01-12 Ojan Vafai <ojan@chromium.org>
602 Reviewed by Adam Barth.
604 fix wrapping bug in expansion lines in the code review tool
605 https://bugs.webkit.org/show_bug.cgi?id=52270
607 * PrettyPatch/PrettyPatch.rb:
610 2011-01-11 Ojan Vafai <ojan@chromium.org>
612 Reviewed by Adam Barth.
614 fix difflink centering to be vertical, not horizontal
615 https://bugs.webkit.org/show_bug.cgi?id=52263
617 * PrettyPatch/PrettyPatch.rb:
620 2011-01-11 Ojan Vafai <ojan@chromium.org>
622 Reviewed by Adam Barth.
624 remember diffstate for review tool
625 https://bugs.webkit.org/show_bug.cgi?id=52253
627 If you use the global sidebyside/unified links, store the diff type
628 in localstorage. Then, onload, use that diff type. That way, people
629 who prefer one diff type or the other can always get that by default.
633 2011-01-11 Ojan Vafai <ojan@chromium.org>
635 Reviewed by Adam Barth.
637 allow sidebysideifying individual files in the code review tool
638 https://bugs.webkit.org/show_bug.cgi?id=52226
642 2011-01-11 Ojan Vafai <ojan@chromium.org>
644 Reviewed by Mihai Parparita.
646 fix exception when adding a comment to a side-by-side diff
647 https://bugs.webkit.org/show_bug.cgi?id=52240
649 prev() and next() won't get the previous and next lines in
650 side-by-side mode. Instead do a query to find them.
654 2011-01-11 Ojan Vafai <ojan@chromium.org>
656 Reviewed by Mihai Parparita.
658 maintain word diffs when converting to side-by-side and back
659 https://bugs.webkit.org/show_bug.cgi?id=52244
661 Using textContent would lose the spans use to make the word-diff highlighting.
662 Just move the span element itself.
666 2011-01-11 Ojan Vafai <ojan@chromium.org>
668 Reviewed by Adam Barth.
670 fix layout error with comments in code review tool
671 https://bugs.webkit.org/show_bug.cgi?id=52230
673 * PrettyPatch/PrettyPatch.rb:
675 2011-01-10 Ojan Vafai <ojan@chromium.org>
677 Reviewed by Adam Barth.
679 convert back to unified from sidebyside diff
680 https://bugs.webkit.org/show_bug.cgi?id=52180
682 Remove url fragment stuff. Having it be per-filediff is too complicated.
684 * PrettyPatch/PrettyPatch.rb:
687 2011-01-07 Adam Barth <abarth@webkit.org>
689 Rubber-stamped by Eric Seidel.
691 Move WebCore to Source
692 https://bugs.webkit.org/show_bug.cgi?id=52050
694 Remove reference to old directory.
696 * PrettyPatch/PrettyPatch.rb:
698 2011-01-06 Ojan Vafai <ojan@chromium.org>
700 Reviewed by Adam Barth.
702 side-by-side diffs in the code review tool
703 https://bugs.webkit.org/show_bug.cgi?id=52019
705 Support for conversion from the formatted diff to a side-by-side diff.
706 Maintains comments and new comments can be added.
708 The main architectural change is that Line elements are no longer necessarily
709 siblings. Each physical line is now in a LineContainer and LineContainers are
710 siblings. Each Line corresponds to a Line in the unified diff and has an id (e.g. line12).
711 A Line can be a LineContainer or a child of a LineContainer.
713 In this way, converting to side-by-side and, in the future, back to unified is non-lossy.
715 * PrettyPatch/PrettyPatch.rb:
718 2011-01-06 Ojan Vafai <ojan@chromium.org>
720 Fix line context when replying to comments.
724 2011-01-05 Ojan Vafai <ojan@chromium.org>
726 Reviewed by Adam Barth.
728 change the way we do comment highlighting in the code review tool
729 https://bugs.webkit.org/show_bug.cgi?id=51971
731 Store a space-separated list of base line IDs on each line that has
732 comments associated with that line. This allows for overlapping comments,
733 but more importantly, makes adding side-by-side diff support easier.
737 2011-01-05 Ojan Vafai <ojan@chromium.org>
739 Reviewed by Adam Barth.
741 minor code cleanup for code review tool
742 https://bugs.webkit.org/show_bug.cgi?id=51962
744 Consolidates some queries to using shared functions.
748 2011-01-05 Ojan Vafai <ojan@chromium.org>
750 Reviewed by Adam Barth.
752 assorted cleanups to prepare for side-by-side diffing
753 https://bugs.webkit.org/show_bug.cgi?id=51961
755 Mostly, use selector queries instead of assuming comments are next siblings.
759 2011-01-05 Ojan Vafai <ojan@chromium.org>
761 Reviewed by Adam Barth.
763 fix message container selector for code review tool
764 https://bugs.webkit.org/show_bug.cgi?id=51959
768 2011-01-04 Ojan Vafai <ojan@chromium.org>
770 Increment version number to avoid getting the cached JS file.
772 * PrettyPatch/PrettyPatch.rb:
774 2010-12-15 Ojan Vafai <ojan@chromium.org>
776 Reviewed by Adam Barth.
778 anchor the toolbar to the bottom of the diff if the diff doesn't take a full screen of height
779 https://bugs.webkit.org/show_bug.cgi?id=51162
781 * PrettyPatch/PrettyPatch.rb:
784 2011-01-01 Adam Barth <abarth@webkit.org>
786 Reviewed by Eric Seidel.
788 Move JavaScriptCore to Source
789 https://bugs.webkit.org/show_bug.cgi?id=51604
791 * PrettyPatch/PrettyPatch.rb:
792 - Remove reference to JavaScriptCore as a source directory.
794 2011-01-01 Adam Barth <abarth@webkit.org>
796 Reviewed by Eric Seidel.
798 Move Sources to Source
799 https://bugs.webkit.org/show_bug.cgi?id=51794
801 * PrettyPatch/PrettyPatch.rb:
803 2010-12-31 Adam Barth <abarth@webkit.org>
805 Rubber-stamped by Eric Seidel.
807 Move PageLoadTests to PerformanceTests/PageLoad
808 https://bugs.webkit.org/show_bug.cgi?id=51771
810 Update list of top-level open-source directories.
812 * PrettyPatch/PrettyPatch.rb:
814 2010-12-31 Adam Barth <abarth@webkit.org>
816 Rubber-stamped by Eric Seidel.
818 Move SunSpider into PerformanceTests
819 https://bugs.webkit.org/show_bug.cgi?id=51769
821 Update list of top-level open-source directories.
823 * PrettyPatch/PrettyPatch.rb:
825 2010-12-26 Adam Barth <abarth@webkit.org>
827 Reviewed by Eric Seidel.
829 Move autotools into Sources
830 https://bugs.webkit.org/show_bug.cgi?id=51630
832 * PrettyPatch/PrettyPatch.rb:
833 - Remove reference to non-existant autotools directory.
835 2010-12-26 Adam Barth <abarth@webkit.org>
837 Reviewed by Eric Seidel.
839 Move cmake into Sources
840 https://bugs.webkit.org/show_bug.cgi?id=51631
842 * PrettyPatch/PrettyPatch.rb:
844 2010-12-23 Adam Barth <abarth@webkit.org>
846 Rubber-stamped by Eric Seidel.
848 Move JavaScriptGlue into Sources
849 https://bugs.webkit.org/show_bug.cgi?id=51583
851 PrettyPatch keeps a list of the top-level directories that exist in
854 * PrettyPatch/PrettyPatch.rb:
856 2010-12-20 Adam Barth <abarth@webkit.org>
858 One more tweak caused by moving the web sites around. I had this
859 change in my patch originally, but I missed it because I had to use
860 server-side svn move commands to move the bulk of the web site files.
862 * PrettyPatch/PrettyPatch.rb:
864 2010-12-18 Adam Barth <abarth@webkit.org>
866 Reviewed by Sam Weinig.
868 Move WebKitExamplePlugins to Examples
869 https://bugs.webkit.org/show_bug.cgi?id=51291
871 * PrettyPatch/PrettyPatch.rb:
873 2010-12-17 Dan Bernstein <mitz@apple.com>
875 Reviewed by Simon Fraser.
877 Rename WebKitTools to Tools
878 https://bugs.webkit.org/show_bug.cgi?id=49861
880 * PrettyPatch/PrettyPatch.rb:
881 * committers-autocomplete.js:
883 2010-12-17 Ojan Vafai <ojan@chromium.org>
885 Increment psuedo-version number to avoid pulling cached version.
887 * PrettyPatch/PrettyPatch.rb:
889 2010-12-17 Ojan Vafai <ojan@chromium.org>
891 Speculative fix for the code review tool in Firefox.
892 Fixes a JS error and makes the status bubble mostly work
893 if postMessage is not supported.
895 * PrettyPatch/PrettyPatch.rb:
898 2010-12-15 Ojan Vafai <ojan@chromium.org>
900 Reviewed by Adam Barth.
902 size status bubble to it's contents on the code review page
903 https://bugs.webkit.org/show_bug.cgi?id=51142
905 * PrettyPatch/PrettyPatch.rb:
908 2010-12-15 Ojan Vafai <ojan@chromium.org>
910 Reviewed by Adam Barth.
912 fix goofups from r74142 and r74130
913 https://bugs.webkit.org/show_bug.cgi?id=51146
915 Accidentally shrank the inline comment boxes and made
916 the toolbar not show up when there were image diffs.
918 * PrettyPatch/PrettyPatch.rb:
921 2010-12-14 Ojan Vafai <ojan@chromium.org>
923 Reviewed by Adam Barth.
925 add ability to view for file context to the review tool
926 https://bugs.webkit.org/show_bug.cgi?id=51057
928 At the beginning/end of each file diff and between each
929 hunk add links to expand the context. For now it grabs the
930 tip of tree version of the file and tries to apply the diff
931 to that file. If it can't apply, then it gives up as we
932 wouldn't want to show the wrong lines of context.
934 In the future, we can consider adding the upload svn revision
935 to the diff itself, then we could fallback to the file at that
936 revision if tip of tree doesn't apply.
938 * PrettyPatch/PrettyPatch.rb:
941 2010-12-08 Ojan Vafai <ojan@chromium.org>
943 Reviewed by Adam Barth.
945 [reviewtool] should always show overall comments text box
946 https://bugs.webkit.org/show_bug.cgi?id=45870
948 * PrettyPatch/PrettyPatch.rb:
951 2010-12-04 Patrick Gansterer <paroga@webkit.org>
953 Reviewed by Adam Barth.
955 Increase size of status bubbles
956 https://bugs.webkit.org/show_bug.cgi?id=50496
958 The current available space isn't enough to display all
959 pending results including position in the queue.
961 * PrettyPatch/PrettyPatch.rb:
963 2010-12-04 Patrick Gansterer <paroga@webkit.org>
965 Reviewed by Adam Barth.
967 Increase size of status bubbles
968 https://bugs.webkit.org/show_bug.cgi?id=50496
970 The current available space isn't enough to display all
971 pending results including position in the queue.
973 * template/en/custom/attachment/edit.html.tmpl:
974 * template/en/custom/attachment/list.html.tmpl:
975 * template/en/custom/attachment/reviewform.html.tmpl:
977 2010-11-08 Adam Barth <abarth@webkit.org>
979 Update help text to match behavior change.
983 2010-11-08 Adam Barth <abarth@webkit.org>
985 Reviewed by Eric Seidel.
987 Restore normal meaning of double-click on patch review page?
988 https://bugs.webkit.org/show_bug.cgi?id=47641
990 After this patch, you need to click on the line numbers to add a
993 * PrettyPatch/PrettyPatch.rb:
996 2010-10-09 Adam Barth <abarth@webkit.org>
998 Reviewed by Alexey Proskuryakov.
1000 Exception in committers-autocomplete in Firefox
1001 https://bugs.webkit.org/show_bug.cgi?id=47456
1003 Remove dependency on a WebKit-only quirk. IMHO, this quirk is bad for
1004 the long-term health of the web, but that's a discussion for another
1007 * committers-autocomplete.js:
1009 2010-10-08 Adam Barth <abarth@webkit.org>
1011 Reviewed by Oliver Hunt.
1013 Bugmail for new attachments should link to the reviewtool
1014 https://bugs.webkit.org/show_bug.cgi?id=47440
1016 As requested by olliej himself. This patch was constructed by pure
1017 reason. I have no way to actually run this code.
1019 * Bugzilla/BugMail.pm:
1021 2010-09-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1023 Reviewed by Csaba Osztrogonác.
1025 Convert verbatim unicode values in comitter names to characters
1027 * committers-autocomplete.js:
1029 2010-09-24 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1031 Reviewed by Csaba Osztrogonác.
1033 Support Unicode-strings in committers-autocomplete script
1035 * committers-autocomplete.js:
1037 2010-09-22 Adam Barth <abarth@webkit.org>
1039 Reviewed by John Sullivan.
1041 New review-page design doesn't include name of reviewer
1042 https://bugs.webkit.org/show_bug.cgi?id=46271
1044 * PrettyPatch/PrettyPatch.rb:
1047 2010-09-22 Adam Barth <abarth@webkit.org>
1051 * PrettyPatch/PrettyPatch.rb:
1053 2010-09-22 Adam Barth <abarth@webkit.org>
1055 Reviewed by Eric Seidel.
1057 Add link to bug to review page
1058 https://bugs.webkit.org/show_bug.cgi?id=46192
1060 To make room for the link, I moved the help text to the top of the page
1061 and tweaked the language to help folks discover that you can select
1062 context using the line numbers.
1064 Also, move more text to sans-serif since that fits in better with the
1067 * PrettyPatch/PrettyPatch.rb:
1070 2010-09-21 Adam Barth <abarth@webkit.org>
1074 [reviewtool] Publish button doesn't work
1075 https://bugs.webkit.org/show_bug.cgi?id=46168
1077 Darin's recent patch had a runtime error. Sadly, we don't have any
1078 testing for this code.
1082 2010-09-20 Darin Adler <darin@apple.com>
1084 Reviewed by Adam Barth.
1086 Add Preview button and link to bug to patch review bar
1087 https://bugs.webkit.org/show_bug.cgi?id=46153
1089 * PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
1090 * code-review.js: Added Preview button and link to bug.
1092 2010-09-19 Adam Barth <abarth@webkit.org>
1094 Reviewed by Eric Seidel.
1096 [reviewtool] Publish button should actually publish the review comments
1097 https://bugs.webkit.org/show_bug.cgi?id=46074
1099 Instead of showing the confirmation lightbox, the Publish button now
1100 publishes the comments directly. If there's demand for a "Preview"
1101 button, we can find a way to add that feature.
1105 2010-09-19 Adam Barth <abarth@webkit.org>
1107 Reviewed by Eric Seidel.
1109 Move reviewtool to action=review
1110 https://bugs.webkit.org/show_bug.cgi?id=46071
1112 This patch removes the old Review Patch screen and moves the new
1113 reviewtool from Pretty Diff to Review Patch.
1118 2010-09-19 Adam Barth <abarth@webkit.org>
1120 Review tool UI tweak. This patch lengthens the status bubbles so all
1121 the bubble fit (even when they have numbers inside).
1123 * PrettyPatch/PrettyPatch.rb:
1125 2010-09-19 Dan Bernstein <mitz@apple.com>
1127 Reviewed by Anders Carlsson.
1131 * code-review.js: Changed the label of the OK button from Ok to OK.
1133 2010-09-15 Adam Barth <abarth@webkit.org>
1137 Only show the review-in-context link if there are contextual comments.
1141 2010-09-15 Adam Barth <abarth@webkit.org>
1143 Reviewed by Eric Seidel.
1145 [reviewtool] Show the status bubbles on the toolbar
1146 https://bugs.webkit.org/show_bug.cgi?id=45861
1148 * PrettyPatch/PrettyPatch.rb:
1151 2010-09-15 Adam Barth <abarth@webkit.org>
1153 Reviewed by Eric Seidel.
1155 [reviewtool] Allow setting review and commit-queue flags from main review screen
1156 https://bugs.webkit.org/show_bug.cgi?id=45860
1158 This patch adds drop down menus for adjusting the review and
1159 commit-queue flags from the main review screen. These controls don't
1160 appear immediately because we need to read the state of the flags off
1163 It's a slight sadness that bugzilla doesn't have a clean way of
1164 identifying which select control is associated with a given flag. The
1165 flags seem to have some sort of id, but it's unclear to me how to map
1166 that id back to a notion of "review" or "commit-queue". Instead, we
1167 look for some magic strings in the title. I'm sure this will come back
1168 to bit us at some point, but I'm not sure what to do that's better.
1169 (The webkitpy solution to this problem is to assume that the flags are
1170 in a given order, but this seems better.)
1172 * PrettyPatch/PrettyPatch.rb:
1173 - Bump version number to bust throuh caches.
1176 2010-09-15 Adam Barth <abarth@webkit.org>
1178 Reviewed by Eric Seidel.
1180 [reviewtool] Comments should quote previous comments on the same line
1181 https://bugs.webkit.org/show_bug.cgi?id=45847
1183 Now when you reply to a previous comment, the tool will quote the
1184 previous comment in the bugs.webkit.org post. This makes it eaiser for
1185 folks following along in email to understand the discussion.
1187 While I was editing this code, I also cleaned up some of the whitespace
1188 handling in comments.
1192 2010-09-15 Adam Barth <abarth@webkit.org>
1194 Minor UI tweak to the review tool. We want to display newlines in
1195 previous and frozen comments instead of collapsing them.
1197 * PrettyPatch/PrettyPatch.rb:
1199 2010-09-14 Adam Barth <abarth@webkit.org>
1201 Reviewed by Eric Seidel.
1203 bugs.webkit.org should autocomplete WebKit Committers and Reviewers
1204 https://bugs.webkit.org/show_bug.cgi?id=45799
1206 This patch implements an autocomplete dropdown that helps users type
1207 the names of WebKit committers and reviewers. The script grabs the
1208 data from SVN now that wms set up CORS for http://svn.webkit.org.
1209 Security technology for the win.
1211 This script is based on (well, essentially copied from) the popular
1212 autocomplete extension:
1214 https://chrome.google.com/extensions/detail/olaabhcgdogcbcoiolomlcodkngnemfb
1216 I asked Ojan, and said he was fine licensing the code under the BSD
1217 license. I'm not sure how the patch interacts with the extension, but
1218 we can retire the extension if they interact poorly.
1220 * committers-autocomplete.js: Added.
1221 * template/en/default/global/footer.html.tmpl:
1222 - Add the script to every page on bugs.webkit.org
1224 2010-09-14 Adam Barth <abarth@webkit.org>
1226 Add a license block to the reviewtool. I should have added this from
1227 the start. According to the SVN log, I'm the only one to have ever
1232 2010-09-07 Adam Barth <abarth@webkit.org>
1234 Minor tweaks to the reviewtool UI.
1236 Rename Cancel to Discard to make it more clear what the button does.
1237 Also, move the style declaration for the focus ring later in the sheet
1240 * PrettyPatch/PrettyPatch.rb:
1243 2010-09-06 Adam Barth <abarth@webkit.org>
1245 Small UI tweak to the reviewtool. Make the Ok/Cancel buttons a bit
1248 * PrettyPatch/PrettyPatch.rb:
1250 2010-09-06 Adam Barth <abarth@webkit.org>
1252 Reviewed by Eric Seidel.
1254 [reviewtool] Add a quick animation for opening/closing comment boxes
1255 https://bugs.webkit.org/show_bug.cgi?id=45278
1257 The 200ms animation slides in and out the line-by-line comment box.
1261 2010-09-06 Adam Barth <abarth@webkit.org>
1263 Reviewed by Eric Seidel.
1265 [reviewtool] Add a field for overall comments
1266 https://bugs.webkit.org/show_bug.cgi?id=45273
1268 This patch does a couple logically separate things that could be
1269 separated into smaller patches:
1271 1) This patch adds an "overall comments" field where you can enter
1272 overall comments about the patch. These comments appear at the top
1273 of the bugzilla posting. Currently, these aren't redisplayed when
1274 viewing the patch, but I plan to add that in a future patch.
1276 2) This patch renames some of the CSS classes to more consistently
1277 follow the camelCase style that PrettyPatch uses.
1279 3) This patch moves the "prepare comments" button to the left of the
1280 toolbar and renames is to "publish comments". This makes more sense
1281 when you scroll to the bottom of the page and enter in some overall
1284 4) When you attempt to add a comment to a line that already has a
1285 "frozen" comment, we now unfreeze the comment instead of doing
1286 nothing. The old behavior was kind of frustrating if you didn't
1287 know that you could unfreeze a comment by clicking on it.
1289 * PrettyPatch/PrettyPatch.rb:
1293 2010-09-06 Adam Barth <abarth@webkit.org>
1295 [reviewtool] Tweak the ok button to cancel the comment if the comment
1296 is empty. Previously we would get into a bad state where a line had a
1297 comment but there was no longer any way to access it.
1301 2010-09-06 Adam Barth <abarth@webkit.org>
1303 Reviewed by Eric Seidel.
1305 [reviewtool] Add an "ok" button that collapses review comments
1306 https://bugs.webkit.org/show_bug.cgi?id=45255
1308 Many folks (including myself) are too trigger-happy with the "delete"
1309 button that we end up deleting perfectly good review comments. This
1310 patch adds an "ok" button to absorb these clicks (and renames "delete"
1311 to "cancel"). When you click the ok button, the comment becomes
1312 non-editable and the box shrinks to fit the text. You can click the
1313 text to get back to the editable version.
1317 2010-08-31 Adam Barth <abarth@webkit.org>
1319 Reviewed by Eric Seidel.
1321 [reviewtool] Make it easy to scroll through review comments
1322 https://bugs.webkit.org/show_bug.cgi?id=45002
1324 This patch lets you scroll through review comments using "n" (for next)
1325 and "p" (for previous). It also attributes comments to their authors.
1327 * PrettyPatch/PrettyPatch.rb:
1330 2010-08-31 Adam Barth <abarth@webkit.org>
1332 Reviewed by Eric Seidel.
1334 [reviewtool] Show previous comments inline in diff
1335 https://bugs.webkit.org/show_bug.cgi?id=44977
1337 This patch adds basic support for showing previous comments inline in
1338 the diff. We crawl the bugs.webkit.org comments about this attachment
1339 and extract comments related to specific lines. We then show the
1340 comments inline in the diff.
1342 This part of the tool needs a bunch of polish, but this at least is a
1343 starting point for further work.
1345 * PrettyPatch/PrettyPatch.rb:
1348 2010-08-31 Adam Barth <abarth@webkit.org>
1350 Reviewed by Eric Seidel.
1352 [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers
1353 https://bugs.webkit.org/show_bug.cgi?id=44936
1355 * PrettyPatch/PrettyPatch.rb:
1356 - Add a version number to bust through bugs.webkit.org's aggressive
1360 2010-08-30 Adam Barth <abarth@webkit.org>
1362 Reviewed by Eric Seidel.
1364 [review tool] Let reviewer select how much context to show in snippet
1365 https://bugs.webkit.org/show_bug.cgi?id=44905
1367 We now highlight the context for a comment in yellow on the left (where
1368 the line numbers are). Clicking a line number expands or contracts the
1369 amount of context, as appropriate. Informal user testing indicates
1370 that we might want to support drag as well.
1372 This patch also changes the "open a comment box here" action to
1373 double-click to avoid issues with mis-clicks.
1375 * PrettyPatch/PrettyPatch.rb:
1378 2010-08-29 Adam Barth <abarth@webkit.org>
1380 Attempt to make Sam's life easier by not opening a comment text field
1381 if there's a selection. This should make it easier to copy/paste text
1382 out of the diff without accidentally opening comment boxes.
1386 2010-08-29 Adam Barth <abarth@webkit.org>
1388 Turns out we're supposed to use find instead of children here.
1392 2010-08-29 Adam Barth <abarth@webkit.org>
1394 Reviewed by Eric Seidel.
1396 Awesomify pretty-diff based review tool
1397 https://bugs.webkit.org/show_bug.cgi?id=44835
1399 This patch replaces the existing inline comment feature with a new
1400 implementation. Hopefully the new implementation is more awesome.
1401 It's not 100% done yet, but I'd like to get this version out there to
1404 Unlike the previous version this version works with the "Formatted
1405 Diff" link instead of the "Review Patch" link. Hopefully that will
1406 avoid interfering with folks who like the old style review.
1408 * PrettyPatch/PrettyPatch.rb:
1409 * code-review.js: Added.
1410 * prototype.js: Removed.
1412 2010-08-19 Tony Chang <tony@chromium.org>
1414 Reviewed by Adam Barth.
1416 webkit-patch barfed on upload with a new image test result
1417 https://bugs.webkit.org/show_bug.cgi?id=39097
1419 * PrettyPatch/PrettyPatch.rb: don't use full path to git
1421 2010-08-19 Tony Chang <tony@chromium.org>
1423 Unreviewed, setting svn:eol-style native on ChangeLog.
1425 2010-08-19 Tony Chang <tony@chromium.org>
1427 Unreviewed. Just removing \r's from ChangeLog.
1429 2010-08-02 Adam Roben <aroben@apple.com>
1431 Tell the patch prettifier about some (not so) new directories
1433 * PrettyPatch/PrettyPatch.rb: Added WebKit2, autotools, and cmake
1436 2010-07-27 Joseph Pecoraro <joepeck@webkit.org>
1438 Reviewed by David Kilzer.
1440 Provide a Helpful Link for Web Inspector Bugs in Bugzilla
1441 https://bugs.webkit.org/show_bug.cgi?id=43065
1443 * template/en/custom/global/choose-product.html.tmpl: Added. Explicitly added a link for the Web Inspector.
1445 2010-06-09 Julie Parent <jparent@chromium.org>
1447 Reviewed by David Kilzer.
1449 Bugzilla: Don't send mail for cancel/deny/granted for in-rietveld.
1451 https://bugs.webkit.org/show_bug.cgi?id=40345
1455 2010-05-17 Julie Parent <jparent@chromium.org>
1457 Reviewed by Ojan Vafai.
1459 Rietveld review page should dedicate more space to Rietveld, less to high level comments form.
1461 https://bugs.webkit.org/show_bug.cgi?id=39244
1463 * template/en/custom/attachment/reviewform.html.tmpl:
1464 Delete a random BR amongst the hidden elements that was causing extra whitespace.
1465 * template/en/custom/attachment/rietveldreview.html.tmpl:
1466 Increase size of Rietveld frame to 80%, from 60%.
1468 2010-05-14 Julie Parent <jparent@chromium.org>
1470 Reviewed by Ojan Vafai.
1472 Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +.
1474 https://bugs.webkit.org/show_bug.cgi?id=39141
1476 * template/en/custom/attachment/list.html.tmpl:
1478 2010-05-13 Julie Parent <jparent@chromium.org>
1480 Reviewed by David Kilzer.
1482 Bugzilla: Don't send mail if the only change is to the in-rietveld flag.
1484 https://bugs.webkit.org/show_bug.cgi?id=39090
1486 * Bugzilla/BugMail.pm:
1488 2010-05-12 Julie Parent <jparent@chromium.org>
1490 Reviewed by Ojan Vafai.
1492 Hide the in-rietveld flag in the UI. It is only used only by tooling and shouldn't clutter the UI.
1493 https://bugs.webkit.org/show_bug.cgi?id=39024
1495 * template/en/custom/attachment/list.html.tmpl:
1496 Removes this flag entirely from the UI, not needed on this page.
1497 * template/en/custom/flag/list.html.tmpl: Added.
1498 Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section.
1499 Hides the flag rather than removing it completely, so tools can still interact with it.
1501 2010-05-12 Julie Parent <jparent@chromium.org>
1503 Reviewed by David Kilzer.
1505 Adds support for Rietveld reviews. When there is an associated
1506 Rietveld id for a patch, adds a link to do a Rietveld review instead.
1508 https://bugs.webkit.org/show_bug.cgi?id=38143
1511 Added support for handling action=rietveldreview.
1512 * template/en/custom/attachment/list.html.tmpl:
1513 Adds a link to use rietveld review iff the in_rietveld flag is set.
1514 * template/en/custom/attachment/reviewform.html.tmpl:
1515 Detects if we are in rietveld review mode due to query string paramter,
1516 and customizes the review form slightly:
1517 - Changes text describing comment field.
1518 - Comment field does not include quoted patch.
1519 - Submit button fetches from Rietveld instead of just submitting.
1520 * template/en/custom/attachment/rietveldreview.html.tmpl: Added.
1521 New template for rietveldreview mode. Hosts the rietveld frame in the
1522 top and the regular comments form in the bottom.
1523 Uses postMessage to communicate with Rietveld frame.
1525 2010-05-08 Chris Jerdonek <cjerdonek@webkit.org>
1527 Reviewed by Maciej Stachowiak.
1529 Allow long comment lines to wrap to the window width instead
1530 of to 80 characters.
1532 https://bugs.webkit.org/show_bug.cgi?id=37792
1534 * Bugzilla/Constants.pm:
1535 - Introduced a new constant COMMENT_COLS_WRAP to replace COMMENT_COLS
1536 inside the wrap_comment() subroutine. The new constant effectively
1537 disables text wrapping by increasing the value used in wrap_comment()
1538 from 80 characters to a very large value (8000).
1540 - Replaced COMMENT_COLS with COMMENT_COLS_WRAP inside wrap_comment().
1541 * skins/custom/global.css:
1543 - Eliminate the width styling on comments to allow long lines
1544 to wrap at the window width.
1545 (.bz_comment_text > span.quote):
1546 - Inherit the "white-space" property. This prevents long quoted
1547 lines in comments from causing non-quoted lines to extend beyond
1550 2010-04-22 Adam Barth <abarth@webkit.org>
1552 Reviewed by Darin Adler.
1554 The new review tools shouldn't clear the comment box automatically
1555 https://bugs.webkit.org/show_bug.cgi?id=38004
1557 Instead, we now have a button for doing that explicitly. If people
1558 like this tool, we can look at fancier solutions.
1560 Also, tried to make the tool work on the edit page as well as the review page.
1562 * PrettyPatch/PrettyPatch.rb:
1564 2010-04-22 Adam Barth <abarth@webkit.org>
1566 Unreviewed. Turns out we need to do more escaping because Ruby was
1567 explanding our newlines, creating a syntax error.
1569 * PrettyPatch/PrettyPatch.rb:
1571 2010-04-22 Adam Barth <abarth@webkit.org>
1573 Reviewed by Darin Adler.
1575 Hack up PrettyDiff to allow line-by-line comments
1576 https://bugs.webkit.org/show_bug.cgi?id=37886
1578 Admittedly a bit of a hack, this is a basic line-by-line editor we can
1579 play with thanks to Andrew Scherkus. It's meant to integrate with the
1580 "review" page at bugs.webkit.org.
1582 I changed a few things from Andrew's original version:
1583 1) Trigger text boxes on single click to make iPhone/iPad reviewing
1585 2) Clear the main text box on load.
1586 3) Reference a version of prototype.js on bugs.webkit.org.
1588 * PrettyPatch/PrettyPatch.rb:
1589 * prototype.js: Added.
1591 2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1593 Reviewed by Maciej Stachowiak.
1595 Don't reset the assignee back to default on component change
1597 https://bugs.webkit.org/show_bug.cgi?id=35236
1599 There's a risk of reseting a valid assignee for example when
1600 triaging a bug. All components in WebKit have the default
1601 assignee set to webkit-unassigned@webkit.org so this should
1602 not cause problems for people relying on this functionality.
1604 * template/en/custom/bug/edit.html.tmpl:
1606 2010-01-22 Janusz Lewandowski <lew21@xtreeme.org>
1608 Reviewed by Maciej Stachowiak.
1610 run-webkit-tests fails on Ruby 1.9
1611 https://bugs.webkit.org/show_bug.cgi?id=33554
1612 inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors.
1614 * PrettyPatch/PrettyPatch.rb:
1616 2010-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1618 Reviewed by Adam Barth.
1620 Adjust height of status-bubbles to prevent them being cut.
1622 * template/en/custom/attachment/edit.html.tmpl:
1623 * template/en/custom/attachment/list.html.tmpl:
1624 * template/en/custom/attachment/reviewform.html.tmpl:
1626 2010-01-08 David Kilzer <ddkilzer@apple.com>
1628 <http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button
1630 Reviewed by Adam Barth.
1632 This button was broken during a previous Bugzilla upgrade after
1633 changes were made to the names of objects exposed on templates.
1635 * template/en/custom/attachment/reviewform.html.tmpl: Changed
1636 attachid to attachment.id and ispatch to attachment.ispatch.
1637 Also tweaked the format to use 4 table columns instead of 5.
1639 2010-01-08 David Kilzer <ddkilzer@apple.com>
1641 Included UNCONFIRMED bugs by default in advanced search query
1643 Rubber-stamped by Alexey Proskuryakov.
1645 * data/params: Prepended 'bug_status=UNCONFIRMED&' to
1646 'defaultquery' parameter.
1648 2010-01-08 David Kilzer <ddkilzer@apple.com>
1650 FIX: Make patch status appear on reviewform.html.tmpl
1652 * template/en/custom/attachment/reviewform.html.tmpl: Check
1653 attachment.ispatch (not just ispatch) when deciding whether
1654 to display patch status. Also update layout a bit.
1656 2010-01-08 David Kilzer <ddkilzer@apple.com>
1658 Update data/params parameters
1660 * data/params: Updated 'timezone' to turn off DST. Updated
1661 'usebugaliases' and 'usevotes' to turn them off.
1663 2010-01-08 Adam Barth <abarth@webkit.org>
1665 Reviewed by Darin Adler.
1667 Show patch status in bugs.webkit.org
1668 https://bugs.webkit.org/show_bug.cgi?id=33368
1670 This patch adds an iframe to the show_bug page and the edit attachment
1671 page that displays whether the attachment passed the various bots.
1673 * template/en/custom/attachment/edit.html.tmpl:
1674 * template/en/custom/attachment/list.html.tmpl:
1675 * template/en/custom/attachment/reviewform.html.tmpl:
1677 2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>
1679 Reviewed by David Kilzer.
1681 Bugzilla should show images in git patches
1682 https://bugs.webkit.org/show_bug.cgi?id=31395
1684 Attempt to go r51748 again using --directory option of git-apply.
1686 * PrettyPatch/PrettyPatch.rb:
1688 2009-12-06 Shinichiro Hamaji <hamaji@chromium.org>
1690 Unreviewed. Revert r51748.
1692 Bugzilla should show images in git patches
1693 https://bugs.webkit.org/show_bug.cgi?id=31395
1695 * PrettyPatch/PrettyPatch.rb:
1697 2009-12-06 Shinichiro Hamaji <hamaji@chromium.org>
1699 Reviewed by David Kilzer.
1701 Bugzilla should show images in git patches
1702 https://bugs.webkit.org/show_bug.cgi?id=31395
1704 Show images in git patches using git-apply.
1706 * PrettyPatch/PrettyPatch.rb:
1708 2009-10-23 Eric Seidel <eric@webkit.org>
1710 Reviewed by Adam Roben.
1712 PrettyPatch should show images even when they have the wrong mime type
1713 https://bugs.webkit.org/show_bug.cgi?id=29506
1715 * PrettyPatch/PrettyPatch.rb:
1717 2009-10-17 Alexey Proskuryakov <ap@apple.com>
1719 Reviewed by Eric Carlson.
1721 https://bugs.webkit.org/show_bug.cgi?id=30470
1722 Make marking a bug as duplicate easier
1724 * js/field.js: (setResolutionToDuplicate): Focus the edit field, too.
1726 2009-10-16 Alexey Proskuryakov <ap@apple.com>
1728 Reviewed by Mark Rowe.
1730 https://bugs.webkit.org/show_bug.cgi?id=30470
1731 Make marking a bug as duplicate easier
1733 * js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user
1736 2009-09-09 David Kilzer <ddkilzer@apple.com>
1738 Update data/params parameters
1740 * data/params: Updated 'attachment_base' parameter for secure
1741 attachments. Updated 'mybugstemplate' parameter to search for
1742 bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to
1745 2009-08-11 David Kilzer <ddkilzer@apple.com>
1747 Updated data/params parameter
1749 * data/params: Updated 'loginnetmask' parameter to allow users
1750 to choose whether their cookies are restricted to a single IP
1753 2009-07-07 David Kilzer <ddkilzer@apple.com>
1755 Updated BugsSite with local changes on server
1757 The new files were created by checksetup.pl during the upgrade
1758 to Bugzilla 3.2.3. The rest are self-explanatory.
1760 * data: Added "bugzilla-update.xml" to svn:ignore.
1761 * data/attachments: Added "groups.*" to svn:ignore.
1762 * data/params: Updated for a few changed parameters.
1764 * lib/.htaccess: Added.
1765 * skins/contrib/Dusk/IE-fixes.css: Added.
1766 * skins/contrib/Dusk/admin.css: Added.
1767 * skins/contrib/Dusk/create_attachment.css: Added.
1768 * skins/contrib/Dusk/dependency-tree.css: Added.
1769 * skins/contrib/Dusk/duplicates.css: Added.
1770 * skins/contrib/Dusk/editusers.css: Added.
1771 * skins/contrib/Dusk/help.css: Added.
1772 * skins/contrib/Dusk/index.css: Added.
1773 * skins/contrib/Dusk/panel.css: Added.
1774 * skins/contrib/Dusk/params.css: Added.
1775 * skins/contrib/Dusk/release-notes.css: Added.
1776 * skins/contrib/Dusk/show_bug.css: Added.
1777 * skins/contrib/Dusk/show_multiple.css: Added.
1778 * skins/contrib/Dusk/summarize-time.css: Added.
1779 * skins/contrib/Dusk/voting.css: Added.
1780 * skins/contrib/Dusk/yui: Added.
1781 * skins/contrib/Dusk/yui/calendar.css: Added.
1782 * skins/custom/IE-fixes.css: Added.
1783 * skins/custom/admin.css: Added.
1784 * skins/custom/buglist.css: Added.
1785 * skins/custom/create_attachment.css: Added.
1786 * skins/custom/dependency-tree.css: Added.
1787 * skins/custom/duplicates.css: Added.
1788 * skins/custom/editusers.css: Added.
1789 * skins/custom/help.css: Added.
1790 * skins/custom/panel.css: Added.
1791 * skins/custom/params.css: Added.
1792 * skins/custom/release-notes.css: Added.
1793 * skins/custom/show_bug.css: Added.
1794 * skins/custom/show_multiple.css: Added.
1795 * skins/custom/summarize-time.css: Added.
1796 * skins/custom/voting.css: Added.
1797 * skins/custom/yui: Added.
1798 * skins/custom/yui/calendar.css: Added.
1800 2009-07-03 David Kilzer <ddkilzer@apple.com>
1802 Bug 26958: Change edit link to review link in request messages
1804 <https://bugs.webkit.org/show_bug.cgi?id=26958>
1806 Reviewed by Dan Bernstein.
1808 * template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl.
1809 Changed link from "action=edit" to "action=review".
1811 2009-07-03 David Kilzer <ddkilzer@apple.com>
1813 Bug 26950: Make the summary and alias fields support click-to-edit
1814 <https://bugs.webkit.org/show_bug.cgi?id=26950>
1816 Reviewed by Maciej Stachowiak.
1818 Original patch by Maciej Stachowiak.
1821 (hideEditableField): Updated to add click event listeners to the
1822 alias and short description elements to make them easier to
1823 edit. Renamed field_id parameter to field2_id (short
1824 description id) and added a field1_id parameter (alias id).
1825 (showEditableField): If a third parameter is passed in the
1826 ContainerInputArray parameter, use it to find the element to
1827 focus. Otherwise, fall back to the original behavior of
1828 focusing the first input field.
1829 (hideAliasAndSummary): Changed to pass the id for the alias
1830 element to hideEditableField().
1832 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1834 Config file for contrib/recode.pl when upgrading bugs.webkit.org
1836 Current as of midday on Wednesday, July 1, 2009.
1838 * contrib/recode-overrides.txt: Added.
1840 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1842 Workaround for WebKit Bug 9630 when running contrib/recode.pl
1844 A number of WebKit nightly builds included Bug 9630 which caused
1845 non-breaking space characters (0xA0) to be submitted within the
1846 content of textarea elements.
1848 * contrib/recode.pl: To work around these 0xA0 characters, try
1849 an encoding of cp1252 and use it if it works.
1851 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1853 Don't print "Failed to guess" warning if an override is available
1855 * contrib/recode.pl: Check that %overrides does NOT contain a
1856 key matching the current digest before printing out the warning
1857 about a failed charset guess.
1859 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1861 Added --[no-]truncate switch to contrib/recode.pl
1863 * contrib/recode.pl: Added --[no-]truncate switch to make
1864 debugging of failed charset guessing easier. Often times the
1865 illegal character was truncated in the output.
1867 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1869 Changed Perl scripts to use #!/usr/bin/env perl
1871 perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl
1873 2009-07-02 David D. Kilzer <ddkilzer@apple.com>
1875 Replace Bugzilla favicon with webkit.org favicon
1877 * favicon.ico: Removed.
1878 * images/favicon.ico: Replaced. Copied from favicon.ico.
1880 2009-07-02 David Kilzer <ddkilzer@webkit.org>
1882 Merged BugsSite to Bugzilla-3.2.3
1884 Updated to the latest-and-greatest stable version.
1886 2009-07-02 David Kilzer <ddkilzer@webkit.org>
1888 Merged BugsSite to Bugzilla-3.0.3
1890 Nothing to see here. Move along.
1892 2009-06-09 Eric Seidel <eric@webkit.org>
1894 Reviewed by Adam Roben.
1896 Add support for displaying added png files in PrettyPatch diffs
1897 https://bugs.webkit.org/show_bug.cgi?id=26210
1899 Currently this is SVN only (git-send-bugzilla patches exclude binary data)
1900 and only works for PNG files but could easily be made to work for other images as needed.
1902 * PrettyPatch/PrettyPatch.rb:
1904 2009-05-19 Eric Seidel <eric@webkit.org>
1906 Reviewed by Adam Roben.
1908 Make PrettyPatch understand quoted filenames in git diffs.
1909 https://bugs.webkit.org/show_bug.cgi?id=25881
1911 * PrettyPatch/PrettyPatch.rb:
1913 2009-05-15 Simon Fraser <simon.fraser@apple.com>
1915 Carrying forwards Darin Adler's rubber stamp
1917 Make the comment field wider too.
1919 * skins/custom/global.css:
1921 2009-05-14 Simon Fraser <simon.fraser@apple.com>
1923 Reviewed by Darin Adler
1925 Make the URL, Summary and Keyword fields wider to mitigate the
1926 effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make
1927 things generally better.
1929 * skins/custom/global.css:
1930 * template/en/custom/bug/edit.html.tmpl:
1932 2008-11-10 Darin Adler <darin@apple.com>
1934 - fix more of https://bugs.webkit.org/show_bug.cgi?id=21400
1935 "Edit" links for patches in comments, review queue, review emails
1936 should be replaced by "Review Patch" links
1938 * globals.pl: Fix cases that are automatically generated, such as links
1939 in comments in bugs.
1941 * template/en/custom/attachment/created.html.tmpl: Fix the link on the
1942 "I just created an attachment" page.
1944 * template/en/custom/request/queue.html.tmpl: Fix the link in the queue
1947 2008-11-10 Darin Adler <darin@apple.com>
1949 * template/en/default/request/queue.html.tmpl: Use review links instead
1950 of edit links in the review queue.
1952 2008-11-10 Darin Adler <darin@apple.com>
1954 * template/en/custom/request/email.txt.tmpl: Send review links instead
1955 of edit links when flags are set on a bug.
1957 2008-10-27 Darin Adler <darin@apple.com>
1959 * template/en/custom/attachment/reviewform.html.tmpl: Leave out the
1960 comment if it's untouched.
1962 2008-10-23 Adam Roben <aroben@apple.com>
1964 Fix Bug 21401: Comments field on "Review Patch" page should be
1965 initially filled with quoted patch
1967 <https://bugs.webkit.org/show_bug.cgi?id=21401>
1969 Reviewed by Dave Hyatt.
1972 (edit): Retrieve the attachment data from the database instead of just
1973 its length. When the attachment is a patch, create a quotedpatch
1974 template variable that contains the patch data with each line
1975 prepended with "> ".
1976 * template/en/custom/attachment/reviewform.html.tmpl:
1977 - Changed the comments field to have a monospace font
1978 - Added an "Enter comments below:" caption above the comments field
1979 to make it clearer that this is where comments should go, now that
1980 the comments field is not initially empty
1981 - Fill the comments field with the quoted patch
1983 2008-10-14 Adam Roben <aroben@apple.com>
1985 Fix Bug 21602: Bugzilla times out trying to display formatted diff for
1988 https://bugs.webkit.org/show_bug.cgi?id=21602
1990 Reviewed by Dave Kilzer.
1992 * PrettyPatch/PrettyPatch.rb:
1993 (PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added.
1994 (PrettyPatch.FileDiff.initialize): If any of the lines in the diff
1995 are a binary file marker, mark this FileDiff as binary and stop trying
1996 to process the lines.
1997 (PrettyDiff.FileDiff.to_html): If we're binary, just print a string
2000 2008-10-02 Adam Roben <aroben@apple.com>
2002 * template/en/custom/attachment/reviewform.html.tmpl: Fix typo.
2004 2008-10-02 Adam Roben <aroben@apple.com>
2006 * template/en/custom/attachment/review.html.tmpl: Fix URLs
2008 2008-10-02 Adam Roben <aroben@apple.com>
2010 Fix Bug 21315: bugs.webkit.org should have a nicer patch review
2013 https://bugs.webkit.org/show_bug.cgi?id=21315
2015 Reviewed by Tim Hatcher.
2018 (top level): Added support for the "review" and "reviewform" actions.
2019 (sub edit): Accept the template name as a parameter. If no name is
2020 give, use "edit" as before.
2021 * template/en/custom/attachment/list.html.tmpl: Added a "Review Patch"
2022 link for all patch attachments.
2023 * template/en/custom/attachment/review.html.tmpl: Added. Simple
2024 <frameset> page to show the patch on the top and a comment form on the
2026 * template/en/custom/attachment/reviewform.html.tmpl: Added. Simple
2027 comment form for reviewing patches.
2029 2008-10-02 Adam Roben <aroben@apple.com>
2031 Remove references to some backup files I created when implementing
2032 PrettyPatch in Bugzilla
2034 Reviewed by Tim Hatcher.
2036 * attachment-aroben.cgi: Removed.
2037 * template/en/default/attachment/edit-aroben.html.tmpl: Removed.
2039 * template/en/custom/attachment/edit.html.tmpl: Removed an erroneous
2040 reference to attachment-aroben.cgi. attachment.cgi will work just
2043 2008-06-25 David Kilzer <ddkilzer@apple.com>
2045 Make PrettyPatch handle diffs with no Index or diff headers
2047 Part of Bug 19290: More patches not handled by PrettyPatch.rb
2048 <https://bugs.webkit.org/show_bug.cgi?id=19290>
2052 * PrettyPatch/PrettyPatch.rb:
2053 (PrettyPatch.DIFF_HEADER_FORMATS): Added regular expression to
2054 match on "+++ " lines for patches with no "Index" or "diff" header.
2055 (PrettyPatch.FileDiff.initialize): Look for filename on "+++ " line
2056 when the first line of a patch has no "Index" or "diff" header.
2057 (PrettyPatch.FileDiff.parse): Added haveSeenDiffHeader state
2058 variable to determine when no "Index" or "diff" header has been
2059 found, but a new patch has started with a "--- " line.
2061 2008-06-08 Dan Bernstein <mitz@apple.com>
2063 Reviewed by Adam Roben.
2065 - update trac URL in PrettyPatch
2067 * PrettyPatch/PrettyPatch.rb:
2069 2008-05-29 Adam Roben <aroben@apple.com>
2071 Update PrettyPatch directory list
2073 * PrettyPatch/PrettyPatch.rb:
2075 2008-05-28 Adam Roben <aroben@apple.com>
2077 Make PrettyPatch able to handle diffs taken from outside the WebKit
2080 Part of Bug 19290: More patches not handled by PrettyPatch.rb
2081 <https://bugs.webkit.org/show_bug.cgi?id=19290>
2083 Reviewed by David Kilzer.
2085 * PrettyPatch/PrettyPatch.rb:
2086 (PrettyPatch.find_url_and_path): Added. Searches the file path from
2087 the bottom up looking for a directory that exists in the source tree.
2088 (PrettyPatch.linkifyFilename): Changed to call find_url_and_path.
2090 2008-05-28 Adam Roben <aroben@apple.com>
2092 Print exceptions from PrettyPatch to stdout
2094 This will make it much easier to debug problems with PrettyPatch,
2095 since we'll be able to see the exceptions in the browser.
2097 Reviewed by Sam Weinig.
2099 * PrettyPatch/prettify.rb: Added a --html-exceptions option, which
2100 will print exceptions to stdout as HTML.
2101 * attachment.cgi: Changed to pass --html-exceptions to prettify.rb.
2103 2008-04-26 David Kilzer <ddkilzer@apple.com>
2105 Removed temp files and added appropriate svn:ignore properties.
2107 Rubber-stamped by Mark Rowe.
2109 * data: Added svn:ignore property for "versioncache" and "versioncache.*" files.
2111 * data/template: Added svn:ignore property for "template" subdirectory.
2112 * data/template/template: Removed precompiled template subdirectory.
2114 * data/versioncache: Removed.
2115 * data/versioncache.*: Removed backup versioncache files.
2117 * data/webdot: Added svn:ignore property for "*.dot" files.
2118 * data/webdot/*.dot: Removed cached webdot files.
2120 2008-04-08 Adam Roben <aroben@apple.com>
2122 Combine :equal operations with the following operation if they are
2123 fewer than 3 characters long
2125 This keeps us from showing lots of small changes on long lines, just
2126 because some letters happened to be the same.
2129 http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/diffviewer/diffutils.py?r=1264#147
2131 * PrettyPatch/PrettyPatch.rb:
2132 (PrettyPatch::DiffSection.initialize): Remove :equal operations fewer
2133 than 3 characters long. The characters from the removed operations
2134 become part of the subsequent operation.
2135 (PrettyPatch::CodeLine.text_as_html): Don't wrap 0-length strings in
2136 <ins>/<del> tags. Also removed the @fromLineNumber.nil? and
2137 @toLineNumber.nil? checks as they are no longer reliable now that
2138 we're removing operations.
2140 2008-04-08 Adam Roben <aroben@apple.com>
2142 Change PrettyPatch to use DiffBuilder for intra-line diffs
2144 This gives us much prettier intra-line diffs, largely because it can
2145 distinguish multiple changes on the same line. e.g., if a line changes
2148 const int myConstant = 0;
2152 static const unsigned myConstant;
2154 You will see that "static " was inserted, "int" changed to "unsigned",
2155 and " = 0" was deleted.
2157 This seems to have also gotten rid of some spurious instances of
2158 "<ins></ins>" and "<del></del>" at the end of a line.
2160 * PrettyPatch/PrettyPatch.rb:
2161 (PrettyPatch::DiffSection.initialize): Use DiffBuilder instead of
2162 setChangeExtentFromLine (which had been copied from Trac's diffing
2164 (PrettyPatch::CodeLine):
2165 - Removed the changeExtent attribute
2166 - Added the operations attribute
2167 - Removed the setChangeExtentFromLine method
2168 (PrettyPatch::CodeLine.text_as_html): Uses @operations to determine
2169 what text to wrap in <ins> and <del> tags.
2170 * PrettyPatch/diff.rb: Deleted a bunch of code we don't use.
2171 (HTMLDiff::DiffBuilder.initialize): Moved code here from the old build
2172 method, but left out the calls to perform_operation, since we build
2173 the diff HTML outside of this class.
2174 (HTMLDiff::DiffBuilder.split_inputs_to_words): Removed calls to
2175 convert_html_to_list_of_words, since we're not diffing HTML.
2177 2008-04-08 Adam Roben <aroben@apple.com>
2182 http://instiki.rubyforge.org/svn/instiki/trunk/lib/diff.rb
2185 * PrettyPatch/diff.rb: Added.
2187 2008-03-04 Adam Roben <aroben@apple.com>
2189 * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to
2190 be omitted from the hunk header.