https://bugs.webkit.org/show_bug.cgi?id=51117
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2
3         Reviewed by Stephanie Lewis.
4
5         https://bugs.webkit.org/show_bug.cgi?id=51117
6         Add a new leopard test bot
7         really really commit to trunk this time.
8
9         * BuildSlaveSupport/build.webkit.org-config/config.json:
10
11 2010-12-15  Sam Weinig  <sam@webkit.org>
12
13         Reviewed by Anders Carlsson.
14
15         WebKit2: Can't add files to an <input type=file>
16         https://bugs.webkit.org/show_bug.cgi?id=51087
17
18         * MiniBrowser/mac/BrowserWindowController.m:
19         (runOpenPanel):
20         (-[BrowserWindowController awakeFromNib]):
21         Add simple implementation of runOpenPanel callback.
22
23         * MiniBrowser/win/BrowserView.cpp:
24         (BrowserView::create):
25         * WebKitTestRunner/TestController.cpp:
26         (WTR::createOtherPage):
27         (WTR::TestController::initialize):
28         Stub out runOpenPanel callback. 
29
30 2010-12-14  Eric Seidel  <eric@webkit.org>
31
32         Reviewed by Adam Barth.
33
34         commit-queue should upload failure diffs when tests flake
35         https://bugs.webkit.org/show_bug.cgi?id=51051
36
37         To make this testable I needed to pipe FileSystem down onto tool.
38         We've wanted it there for a long time anyway.
39
40         This patch is kinda a big hack.  But we don't have a nice
41         way to read results.html files.  I think this will need further
42         revision before this code actually feels clean.
43
44         As part of testing this change, I had to make MockBugzilla.create_bug
45         actually return an id (like it should) which required updating
46         a few other unit test results (for the better).
47
48         The results_matching_keys change in layouttestresults/rebasline
49         was an alternate path which I decided not to use in the end, but
50         I left the change as it seemed an improvement.
51
52         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
53         * Scripts/webkitpy/common/net/layouttestresults.py:
54         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
55         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
56         * Scripts/webkitpy/tool/commands/queues.py:
57         * Scripts/webkitpy/tool/commands/rebaseline.py:
58         * Scripts/webkitpy/tool/main.py:
59         * Scripts/webkitpy/tool/mocktool.py:
60
61 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
62
63         Reviewed by James Robinson.
64
65         new-run-webkit-tests ignores trailing EOL differences in text tests
66         https://bugs.webkit.org/show_bug.cgi?id=36983
67
68         Changed the handling of new-line characters within new-run-webkit-tests
69         to match old-run-webkit-tests.  Differences in leading and trailing empty
70         lines in text expectation files are no longer ignored.
71
72         * Scripts/webkitpy/layout_tests/port/base.py:
73         * Scripts/webkitpy/layout_tests/port/test.py:
74         Added unit tests.  Removed old duplicate unit test entries.
75         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
76
77 2010-12-15  Ojan Vafai  <ojan@chromium.org>
78
79         Reviewed by Adam Barth.
80
81         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
82         https://bugs.webkit.org/show_bug.cgi?id=51125
83
84         * QueueStatusServer/templates/statusbubble.html:
85
86 2010-12-15  Darin Adler  <darin@apple.com>
87
88         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
89
90 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
91
92         Unreviewed, rolling out r74117.
93         http://trac.webkit.org/changeset/74117
94         https://bugs.webkit.org/show_bug.cgi?id=51113
95
96         This broke the GTK1 build. (Requested by mrobinson on
97         #webkit).
98
99         * Scripts/webkitdirs.pm:
100
101 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
102
103         Reviewed by Martin Robinson.
104
105         Change generate-forwarding-headers.pl for GTK port usage 
106         (https://bugs.webkit.org/show_bug.cgi?id=37369)
107
108         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
109
110 2010-12-14  Kent Tamura  <tkent@chromium.org>
111
112         Reviewed by Jian Li.
113
114         [DRT/Chromium] Remove another unnecessary error message
115         https://bugs.webkit.org/show_bug.cgi?id=51083
116
117         * DumpRenderTree/chromium/WebViewHost.cpp:
118         (WebViewHost::didInvalidateRect):
119
120 2010-12-14  Lucas Forschler  <lforschler@apple.com>
121
122         Reviewed by Stephanie Lewis.
123
124         Add a new Leopard Debug Test WK2 Bot
125
126         * BuildSlaveSupport/build.webkit.org-config/config.json:
127
128 2010-12-14  Ojan Vafai  <ojan@chromium.org>
129
130         Fix python unittests after http://trac.webkit.org/changeset/74070.
131
132         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
133
134 2010-12-14  Kent Tamura  <tkent@chromium.org>
135
136         Reviewed by Jian Li.
137
138         [DRT/Chromium] Remove a unnecessary error message
139         https://bugs.webkit.org/show_bug.cgi?id=51069
140
141         * DumpRenderTree/chromium/WebViewHost.cpp:
142         (WebViewHost::paintInvalidatedRegion):
143
144 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
145
146         Reviewed by Ojan Vafai.
147
148         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
149         https://bugs.webkit.org/show_bug.cgi?id=48926
150
151         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
152         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
153
154 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
155
156         Reviewed by Eric Seidel.
157
158         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
159         https://bugs.webkit.org/show_bug.cgi?id=50231
160
161         Guard CONFIG+=link_pkgconfig with !symbian.
162
163         * DumpRenderTree/qt/DumpRenderTree.pro:
164         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
165         * WebKitTestRunner/qt/WebKitTestRunner.pro:
166
167 2010-12-14  Philippe Normand  <pnormand@igalia.com>
168
169         Reviewed by Ojan Vafai.
170
171         [new-run-webkit-tests] expectations parsing is slow
172         https://bugs.webkit.org/show_bug.cgi?id=50635
173
174         Avoid expensive iteration of all the tests when checking if a test
175         file is to be skipped or not.
176
177         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
178         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
179         * Scripts/webkitpy/layout_tests/port/test.py:
180
181 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
182
183         Reviewed by Xan Lopez.
184
185         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
186         https://bugs.webkit.org/show_bug.cgi?id=27048
187
188         Add support in DRT for checking whether an accessibility UI
189         element is focusable and/or focused. Implemented for GTK.
190
191         * DumpRenderTree/AccessibilityUIElement.cpp:
192         (getIsFocusedCallback): New.
193         (getIsFocusableCallback): New.
194         (AccessibilityUIElement::getJSClass): Add the new available
195         callbacks for isFocused and isFocusable.
196         * DumpRenderTree/AccessibilityUIElement.h:
197         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
198         (AccessibilityUIElement::isFocused): New, implemented by checking
199         whether the related AtkState value is in the object's state set.
200         (AccessibilityUIElement::isFocusable): Ditto.
201         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
202         (AccessibilityUIElement::isFocused): New, dummy implementation.
203         (AccessibilityUIElement::isFocusable): Ditto.
204         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
205         (AccessibilityUIElement::isFocused): Ditto.
206         (AccessibilityUIElement::isFocusable): Ditto.
207
208 2010-12-14  Eric Seidel  <eric@webkit.org>
209
210         Reviewed by Ojan Vafai.
211
212         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
213         https://bugs.webkit.org/show_bug.cgi?id=50715
214
215         This patch makes webkit-patch print the following:
216
217         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
218         Install a 64-bit git for better performance, see:
219         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
220
221         I wrote this mostly because I have approximately 8 machines that I use
222         and making sure each one is using a good Git install seemed folly.
223         webkit-patch makes a lot of git calls, so using a fast git can shave
224         several seconds in every invocation.  See the webkit-dev thread for more info.
225
226         This message will print twice during 'webkit-patch upload',
227         once from webkit-patch and once from check-webkit-style.
228
229         Unfortunately there is no good way to test this due to how machine-dependent
230         the code is.  I considered writing a test for the log message, but it seemed not worth it.
231
232         * Scripts/webkitpy/common/checkout/scm.py:
233
234 2010-12-13  Eric Seidel  <eric@webkit.org>
235
236         Reviewed by Adam Barth.
237
238         FlakyTestReporter doesn't understand bots running from multiple email addresses
239         https://bugs.webkit.org/show_bug.cgi?id=50960
240
241         This explains at least one of the dupes of:
242         https://bugs.webkit.org/show_bug.cgi?id=50863
243         that we saw filed by the commit-queue this morning.
244         I think the other one was explained by my previous fix to result counting code.
245
246         Since this is really hard to test with a unit test, instead I
247         create a new (possibly useful in the future) command
248         which given a layout test path will return you
249         the one bug which our tools would assume it the flaky test bug.
250         If some other script wants to use bug-for-test we'll
251         need to extend it with some options like --create-if-missing or similar.
252
253         * Scripts/webkitpy/common/net/bugzilla/bug.py:
254         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
255         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
256         * Scripts/webkitpy/tool/commands/__init__.py:
257         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
258
259 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
260
261         Reviewed by James Robinson.
262
263         Add option to build-webkit to not build WebKit2
264         https://bugs.webkit.org/show_bug.cgi?id=50988
265         
266         Add support for a --no-webkit2 option to build-webkit. It seems to save
267         ~1 minute from clean builds and ~10 seconds from no-op builds.
268
269         * Scripts/build-webkit:
270
271 2010-12-13  Lucas Forschler  <lforschler@apple.com>
272
273         Reviewed by Dave Kilzer.
274
275         Update iexploder from 1.3.2 to 1.7.2
276         Move 1.3.2 into its own subdir
277         Add 1.7.2 into its own subdir
278         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
279
280         * Scripts/run-iexploder-tests:
281         * Scripts/update-iexploder-cssproperties:
282         * iExploder/CHANGELOG.txt: Removed.
283         * iExploder/LICENSE.txt: Removed.
284         * iExploder/README.txt: Removed.
285         * iExploder/htdocs: Removed.
286         * iExploder/iexploder-1.3.2: Added.
287         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
288         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
289         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
290         * iExploder/iexploder-1.3.2/htdocs: Added.
291         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
292         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
293         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
294         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
295         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
296         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
297         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
298         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
299         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
300         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
301         * iExploder/iexploder-1.3.2/tools: Added.
302         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
303         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
304         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
305         * iExploder/iexploder-1.7.2: Added.
306         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
307         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
308         * iExploder/iexploder-1.7.2/README.txt: Added.
309         * iExploder/iexploder-1.7.2/output: Added.
310         * iExploder/iexploder-1.7.2/src: Added.
311         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
312         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
313         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
314         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
315         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
316         * iExploder/iexploder-1.7.2/src/css-properties: Added.
317         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
318         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
319         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
320         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
321         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
322         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
323         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
324         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
325         * iExploder/iexploder-1.7.2/src/css-values: Added.
326         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
327         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
328         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
329         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
330         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
331         * iExploder/iexploder-1.7.2/src/headers: Added.
332         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
333         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
334         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
335         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
336         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
337         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
338         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
339         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
340         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
341         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
342         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
343         * iExploder/iexploder-1.7.2/src/html-tags: Added.
344         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
345         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
346         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
347         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
348         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
349         * iExploder/iexploder-1.7.2/src/html-values: Added.
350         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
351         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
352         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
353         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
354         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
355         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
356         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
357         * iExploder/iexploder-1.7.2/src/index.html: Added.
358         * iExploder/iexploder-1.7.2/src/media: Added.
359         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
360         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
361         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
362         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
363         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
364         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
365         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
366         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
367         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
368         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
369         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
370         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
371         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
372         * iExploder/iexploder-1.7.2/src/mime-types: Added.
373         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
374         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
375         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
376         * iExploder/iexploder-1.7.2/src/protocols: Added.
377         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
378         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
379         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
380         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
381         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
382         * iExploder/iexploder-1.7.2/src/version.rb: Added.
383         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
384         * iExploder/iexploder-1.7.2/testcases: Added.
385         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
386         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
387         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
388         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
389         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
390         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
391         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
392         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
393         * iExploder/iexploder-1.7.2/tools: Added.
394         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
395         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
396         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
397         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
398         * iExploder/tools: Removed.
399
400 2010-12-13  Sam Weinig  <sam@webkit.org>
401
402         Reviewed by Anders Carlsson.
403
404         Remove associated page concept from WKView constructor
405         https://bugs.webkit.org/show_bug.cgi?id=50983
406
407         Step 1: Remove associate page constructors from WKView and make
408         all views use the shared namespace for the context.
409
410         * TestWebKitAPI/PlatformWebView.h:
411         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
412         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
413         * WebKitTestRunner/PlatformWebView.h:
414         * WebKitTestRunner/TestController.cpp:
415         (WTR::createOtherPage):
416         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
417         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
418         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
419
420 2010-12-13  Sam Weinig  <sam@webkit.org>
421
422         Reviewed by Anders Carlsson.
423
424         Change the WebKit2 public API so there is no explicit WKPageNamespace object
425         https://bugs.webkit.org/show_bug.cgi?id=50898
426
427         * MiniBrowser/mac/AppDelegate.h:
428         * MiniBrowser/mac/AppDelegate.m:
429         * MiniBrowser/mac/BrowserWindowController.h:
430         * MiniBrowser/mac/BrowserWindowController.m:
431         * MiniBrowser/win/BrowserView.cpp:
432         Convert MiniBrowser to not use PageNamespaces.
433
434         * TestWebKitAPI/PlatformWebView.h:
435         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
436         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
437         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
438         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
439         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
440         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
441         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
442         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
443         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
444         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
445         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
446         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
447         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
448         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
449         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
450         Convert TestWebKitAPI to not use PageNamespaces.
451
452         * WebKitTestRunner/PlatformWebView.h:
453         * WebKitTestRunner/TestController.cpp:
454         * WebKitTestRunner/TestController.h:
455         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
456         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
457         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
458         Convert WebKitTestRunner to not use PageNamespaces.
459
460 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
461
462         Reviewed by Eric Seidel.
463
464         webkit-patch rollout should be able to do multi-revision rollouts
465         https://bugs.webkit.org/show_bug.cgi?id=33336
466
467         Make it possible to pass more than one revision to webkit-patch.
468
469         * Scripts/webkitpy/common/checkout/api.py:
470         * Scripts/webkitpy/common/checkout/changelog.py:
471         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
472         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
473         * Scripts/webkitpy/tool/commands/download.py:
474         * Scripts/webkitpy/tool/commands/download_unittest.py:
475         * Scripts/webkitpy/tool/mocktool.py:
476         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
477         * Scripts/webkitpy/tool/steps/revertrevision.py:
478
479 2010-12-13  Eric Seidel  <eric@webkit.org>
480
481         Unreviewed.
482
483         Teach webkit-patch how to search bugzilla
484         https://bugs.webkit.org/show_bug.cgi?id=50500
485
486         webkit-patch bug-search fails when there is only one result.
487         Turns out we needed a bit more logic in our result count parsing code.
488
489         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
490         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
491
492 2010-12-13  Antti Koivisto  <antti@apple.com>
493
494         Reviewed by Alexey Proskuryakov.
495
496         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
497         https://bugs.webkit.org/show_bug.cgi?id=50758
498
499         * DumpRenderTree/LayoutTestController.cpp:
500         (setSerializeHTTPLoadsCallback):
501         (LayoutTestController::staticFunctions):
502         * DumpRenderTree/LayoutTestController.h:
503         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
504         (LayoutTestController::setSerializeHTTPLoads):
505         * DumpRenderTree/mac/DumpRenderTree.mm:
506         (resetDefaultsToConsistentValues):
507         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
508         (LayoutTestController::setSerializeHTTPLoads):
509         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
510         (LayoutTestController::setSerializeHTTPLoads):
511
512 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
513
514         Reviewed by Ojan Vafai.
515
516         Remove "use-drt" option from test step command line, since the option was removed in r73748.
517         https://bugs.webkit.org/show_bug.cgi?id=50936
518
519         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
520
521 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
522
523         Reviewed by Csaba Osztrogonác.
524
525         Add revlink to BuildBot status
526         https://bugs.webkit.org/show_bug.cgi?id=50914
527
528         This adds a hyperlink to trac changeset on the revision numbers. 
529
530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
531
532 2010-12-13  Andras Becsi  <abecsi@webkit.org>
533
534         Reviewed by Csaba Osztrogonác.
535
536         [Qt][WK2] Fix build if WebKitTools are not available
537         https://bugs.webkit.org/show_bug.cgi?id=50242
538
539         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
540         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
541         * MiniBrowser/DerivedSources.pro: Added.
542
543 2010-12-13  Eric Seidel  <eric@webkit.org>
544
545         Reviewed by Adam Barth.
546
547         EWS Queues should remove orpahned pyc files before starting
548         https://bugs.webkit.org/show_bug.cgi?id=50904
549
550         A previous check added a platform.py which caused
551         EWS bots on some platforms to hit an import exception.
552         The platform.py file was removed in a subsequent commit, but
553         the EWS bots in question stayed stuck.  This change will
554         fix those bots once restarted (and prevent this in the future).
555
556         I also went ahead and unified start-queue and start-commit-queue
557         since they were nearly identical.  I also added bot_id support
558         to both force all EWSes to have bot ids as well as get rid of the one
559         remaining reason why I had my own copies of these scripts.
560         Hopefully this will be enough to get all the other bot admins
561         (ahem, Adam, ahem) to move to using these checked in copies as well.
562
563         * EWSTools/start-commit-queue.sh: Removed.
564         * EWSTools/start-queue.sh:
565
566 2010-10-28  MORITA Hajime  <morrita@google.com>
567
568         Reviewed by Ojan Vafai.
569
570         spellcheck does not check pasted text
571         https://bugs.webkit.org/show_bug.cgi?id=40092
572
573         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
574         to control the setting.
575
576         * DumpRenderTree/LayoutTestController.cpp:
577         (setAsynchronousSpellCheckingEnabledCallback):
578         (LayoutTestController::staticFunctions):
579         * DumpRenderTree/LayoutTestController.h:
580         * DumpRenderTree/chromium/LayoutTestController.h:
581         * DumpRenderTree/chromium/LayoutTestController.cpp:
582         (LayoutTestController::LayoutTestController):
583         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
584         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
585         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
586         * DumpRenderTree/mac/DumpRenderTree.mm:
587         (resetDefaultsToConsistentValues):
588         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
589         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
590         * DumpRenderTree/qt/LayoutTestControllerQt.h:
591         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
592         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
593         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
594         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
595         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
596         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
597
598 2010-12-12  Sam Weinig  <sam@webkit.org>
599
600         Reviewed by Anders Carlsson.
601
602         Fix failing API test. It turns out that a pop-state event
603         is sent before every fragment navigation, so we have to test
604         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
605
606         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
607         (TestWebKitAPI::didSameDocumentNavigationForFrame):
608
609 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
610
611         Reviewed by Eric Seidel.
612
613         [GTK] Add new-run-webkit-tests support to gtk
614         https://bugs.webkit.org/show_bug.cgi?id=50681
615
616         Adding the basic support to run the new-run-webkit-tests.
617
618         * Scripts/webkitpy/layout_tests/port/gtk.py:
619
620 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
621
622         Reviewed by Kenneth Rohde Christiansen.
623
624         [Qt] Mock DeviceOrientation client for DRT
625         https://bugs.webkit.org/show_bug.cgi?id=47490
626
627         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
628         (WebCore::DumpRenderTree::DumpRenderTree):
629         (WebCore::DumpRenderTree::~DumpRenderTree):
630         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
631         (LayoutTestController::setMockDeviceOrientation):
632
633 2010-12-11  Philippe Normand  <pnormand@igalia.com>
634
635         Reviewed by Gustavo Noronha Silva.
636
637         [GTK] launcher: disable the Mozilla-style fullscreen API
638         https://bugs.webkit.org/show_bug.cgi?id=50874
639
640         Disabling the fullscreen API until its implementation for GTK is
641         mature enough. The webview setting for it is already FALSE by
642         default.
643
644         * GtkLauncher/main.c:
645         (createWindow):
646
647 2010-12-10  Eric Seidel  <eric@webkit.org>
648
649         Reviewed by Adam Barth.
650
651         commit-queue flaky test messages show cryptic version information for mac os x
652         https://bugs.webkit.org/show_bug.cgi?id=50864
653
654         Turns out platform.platform() returns kernel version information
655         which isn't helpful, and just plain confusing on Mac
656         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
657
658         So I've updated PlatformInfo.display_name() to special case
659         mac.  I also found a bad use of sys.platform in the process
660         and fixed that.  (sys.platform always returns 'darwin' on mac).
661
662         * Scripts/webkitpy/common/system/platforminfo.py:
663         * Scripts/webkitpy/common/system/user.py:
664         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
665         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
666         * Scripts/webkitpy/tool/commands/queues_unittest.py:
667
668 2010-12-10  Eric Seidel  <eric@webkit.org>
669
670         Unreviewed.
671
672         Exception seen while reporting flaky test with commit-queue.
673         Just a missing include.
674
675         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
676         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
677
678 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
679
680         Reviewed by Eric Seidel.
681
682         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
683         https://bugs.webkit.org/show_bug.cgi?id=50796
684
685         Also updating the test code to use JSONResultsGeneratorBase and
686         to improve test coverage for incremental cases.
687
688         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
689         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
690
691 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
692
693         Reviewed by Darin Adler.
694
695         prepare-ChangeLog --help doesn't mention --bug shorthand -b
696         https://bugs.webkit.org/show_bug.cgi?id=50835
697
698         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
699
700 2010-12-10  Eric Seidel  <eric@webkit.org>
701
702         Reviewed by Adam Barth.
703
704         Bugs created by the commit-queue should all block on a master bug
705         https://bugs.webkit.org/show_bug.cgi?id=50857
706
707         This makes all bugs created by the commit-queue block on:
708         https://bugs.webkit.org/show_bug.cgi?id=50856
709
710         In the process of testing this, I found that the existing
711         create_bug code was wrong.  I also found that existing
712         unit tests for create-rollout used invalid values
713         for options.blocks.  I fixed both issues and tested.
714
715         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
716         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
717         * Scripts/webkitpy/tool/commands/commandtest.py:
718         * Scripts/webkitpy/tool/commands/download_unittest.py:
719         * Scripts/webkitpy/tool/commands/upload_unittest.py:
720         * Scripts/webkitpy/tool/mocktool.py:
721         * Scripts/webkitpy/tool/steps/options.py:
722
723 2010-12-10  Eric Seidel  <eric@webkit.org>
724
725         Reviewed by Adam Barth.
726
727         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
728         https://bugs.webkit.org/show_bug.cgi?id=50853
729
730         I also discovered when doing this that the code was posting
731         the comment on the wrong bug, but that's fixed here too.
732
733         * Scripts/webkitpy/common/net/bugzilla/bug.py:
734         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
735         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
736         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
737         * Scripts/webkitpy/tool/commands/queues_unittest.py:
738         * Scripts/webkitpy/tool/mocktool.py:
739
740 2010-12-10  Anders Carlsson  <andersca@apple.com>
741
742         Reviewed by John Sullivan.
743
744         Make WKContextGetStatistics gather global statistics
745         https://bugs.webkit.org/show_bug.cgi?id=50850
746
747         Remove the code that gets the statistics and fills in the per context
748         statistics information for now.
749
750         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
751         (-[BrowserStatisticsWindowController refreshStatistics:]):
752
753 2010-12-10  Eric Seidel  <eric@webkit.org>
754
755         Unreviewed.
756
757         commit-queue should report port/platform information when commenting on flaky test bugs
758         https://bugs.webkit.org/show_bug.cgi?id=50839
759
760         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
761         which was only used by new run webkit tests (and clearly not unit tested).
762
763         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
764         * Scripts/webkitpy/tool/main.py:
765         * Scripts/webkitpy/tool/mocktool.py:
766
767 2010-12-10  Eric Seidel  <eric@webkit.org>
768
769         Reviewed by Tony Chang.
770
771         commit-queue should report port/platform information when commenting on flaky test bugs
772         https://bugs.webkit.org/show_bug.cgi?id=50839
773
774         This was a suggestion from Tony Chang this morning.
775         I added a platform.py class so I could easily mock the platform call,
776         but that may not be the final solution for this mocking.
777         We'll try it and see.
778
779         * Scripts/webkitpy/common/system/platform.py: Added.
780         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
781         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
782         * Scripts/webkitpy/tool/commands/queues_unittest.py:
783         * Scripts/webkitpy/tool/main.py:
784         * Scripts/webkitpy/tool/mocktool.py:
785
786 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
787
788         Reviewed by Joseph Pecoraro.
789
790         Bug 43455 - [Qt]: Implement Application Cache Quotas
791         https://bugs.webkit.org/show_bug.cgi?id=43455
792
793         Introduce functions to allow new appcache layout test origin-quota.html
794         to work correctly under Qt.
795
796         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
797         (WebCore::DumpRenderTree::DumpRenderTree):
798         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
799         * DumpRenderTree/qt/DumpRenderTreeQt.h:
800
801         Introduce functions to allow new appcache layout test origin-quota.html
802         to be successful under qt. Changes required because LayoutTestControllerQt
803         does not inherit from LayoutController.
804
805         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
806         (LayoutTestController::reset):
807         (LayoutTestController::clearAllApplicationCaches):
808         (LayoutTestController::setApplicationCacheOriginQuota):
809         * DumpRenderTree/qt/LayoutTestControllerQt.h:
810         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
811         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
812
813 2010-12-10  Eric Seidel  <eric@webkit.org>
814
815         Reviewed by Adam Barth.
816
817         Move buildbot.py into its own module so we can split it out into one-file-per-class
818         https://bugs.webkit.org/show_bug.cgi?id=50806
819
820         We're adding more buildbot logic these days, so it makes sense
821         to give buildbot its own module.
822
823         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
824         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
825         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
826         * Scripts/webkitpy/common/net/failuremap.py:
827         * Scripts/webkitpy/common/net/regressionwindow.py:
828         * Scripts/webkitpy/tool/commands/rebaseline.py:
829
830 2010-12-10  Tony Chang  <tony@chromium.org>
831
832         Reviewed by Eric Seidel.
833
834         Use FileSystem::remove when cleaning up http lock files
835         https://bugs.webkit.org/show_bug.cgi?id=50830
836
837         * Scripts/webkitpy/layout_tests/port/http_lock.py:
838
839 2010-12-10  Joone Hur  <joone@kldp.org>
840
841         Reviewed by Martin Robinson.
842
843         [GTK] DRT needs layoutTestController.setCacheModel
844         https://bugs.webkit.org/show_bug.cgi?id=50705
845         
846         webkit_set_cache_mode() is called to set the cache model.
847         
848         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
849         (LayoutTestController::setCacheModel): Set the cache model. 
850
851 2010-12-10  Tony Chang  <tony@chromium.org>
852
853         Reviewed by Ojan Vafai.
854
855         [chromium] remove --use-drt and add --use-test-shell
856         https://bugs.webkit.org/show_bug.cgi?id=50701
857
858         * Scripts/webkitpy/common/config/ports.py:
859         * Scripts/webkitpy/common/config/ports_unittest.py:
860         * Scripts/webkitpy/layout_tests/port/chromium.py:
861         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
862         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
863         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
864         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
865         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
866         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
867         * Scripts/webkitpy/layout_tests/port/webkit.py:
868         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
869         * Scripts/webkitpy/style/checkers/test_expectations.py:
870         * Scripts/webkitpy/tool/commands/queries.py:
871
872 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
873
874         Reviewed by Steve Block.
875
876         [Chromium] Implement mocks for client-based geolocation
877         https://bugs.webkit.org/show_bug.cgi?id=46895
878
879         * DumpRenderTree/chromium/LayoutTestController.cpp:
880         (LayoutTestController::setGeolocationPermission):
881         (LayoutTestController::setMockGeolocationPosition):
882         (LayoutTestController::setMockGeolocationError):
883         * DumpRenderTree/chromium/LayoutTestController.h:
884         * DumpRenderTree/chromium/WebViewHost.cpp:
885         (WebViewHost::geolocationClient):
886         (WebViewHost::geolocationClientMock):
887         (WebViewHost::reset):
888         * DumpRenderTree/chromium/WebViewHost.h:
889
890 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
891
892         Reviewed by Martin Robinson.
893
894         [GTK] Add hasSpellingMarker support to the DRT
895         https://bugs.webkit.org/show_bug.cgi?id=50739
896
897         Implemented the hasSpellingMarker to support spelling tests.
898
899         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
900         (LayoutTestController::hasSpellingMarker):
901
902 2010-12-10  Eric Seidel  <eric@webkit.org>
903
904         Reviewed by Ojan Vafai.
905
906         webkit-patch: not possible to use build-and-test with local commits
907         https://bugs.webkit.org/show_bug.cgi?id=33378
908
909         Make --no-clean not even check if we have local commits.
910         It's unclear to me why the code was originally written this way.
911         I was unable to dig up a reason from svn history.
912
913         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
914         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
915
916 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
917
918         Reviewed by Martin Robinson.
919
920         [GTK] AX: implement isEnabled in DRT
921         https://bugs.webkit.org/show_bug.cgi?id=50814
922
923         Implement AccessibilityUIElement::isEnabled() for GTK.
924
925         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
926         (checkElementState): New function to refactor common code.
927         (AccessibilityUIElement::isEnabled): Implement this by checking
928         the current state of the AtkObject.
929         (AccessibilityUIElement::isSelected): Use the new
930         checkElementState function.
931
932 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
933
934         Reviewed by Kenneth Rohde Christiansen.
935
936         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
937         https://bugs.webkit.org/show_bug.cgi?id=50750
938
939         * MiniBrowser/qt/BrowserView.cpp:
940         (BrowserView::BrowserView):
941         * MiniBrowser/qt/BrowserView.h:
942         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
943         (WTR::WebView::WebView):
944
945 2010-12-10  Joone Hur  <joone@kldp.org>
946
947         Reviewed by Xan Lopez.
948
949         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
950         https://bugs.webkit.org/show_bug.cgi?id=50808
951
952         Unskipping the following test cases:
953         userscripts/mixed-case-stylesheet.html
954         userscripts/simple-stylesheet.html
955         userscripts/user-style-all-frames.html
956
957         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
958         (LayoutTestController::addUserStyleSheet):
959
960 2010-12-10  Joone Hur  <joone@kldp.org>
961
962         Reviewed by Eric Seidel.
963
964         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
965         https://bugs.webkit.org/show_bug.cgi?id=50783
966
967         This patch allows to unskip the following test cases:
968         printing/page-rule-selection.html
969         printing/page-format-data.html
970
971         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
972         (LayoutTestController::pageProperty): Added.
973         (LayoutTestController::isPageBoxVisible): Ditto.
974         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
975         (LayoutTestController::addUserStyleSheet): Ditto.
976
977 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
978
979         Reviewed by Kenneth Rohde Christiansen.
980
981         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
982
983         A menu allows to switch QNAM back to the same thread.
984
985         * QtTestBrowser/launcherwindow.cpp:
986         (LauncherWindow::initializeView):
987         (LauncherWindow::createChrome):
988         (LauncherWindow::toggleThreadedQnam):
989         * QtTestBrowser/launcherwindow.h:
990         (WindowOptions::WindowOptions):
991         * QtTestBrowser/webpage.cpp:
992         (WebPage::WebPage):
993         (WebPage::setQnamThreaded):
994         * QtTestBrowser/webpage.h:
995         (QnamThread::QnamThread):
996         (QnamThread::~QnamThread):
997         (QnamThread::networkAccessManager):
998         (QnamThread::run):
999
1000 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1001
1002         Reviewed by Xan Lopez.
1003
1004         [Gtk] style="font-family: courier" makes text disappear
1005         https://bugs.webkit.org/show_bug.cgi?id=47452
1006
1007         Add a test that verifies that fonts without valid charmaps are
1008         never selected.
1009
1010         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1011         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1012         that has no valid charmap.
1013         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1014         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1015         settings which may disable selection of bitmap fonts.
1016
1017 2010-12-10  Eric Seidel  <eric@webkit.org>
1018
1019         Unreviewed.
1020
1021         The commit-queue should file bugs about flaky tests it encounters
1022         https://bugs.webkit.org/show_bug.cgi?id=50803
1023
1024         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1025         Now it's tested.
1026
1027         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1028         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1029
1030 2010-12-10  Eric Seidel  <eric@webkit.org>
1031
1032         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1033
1034         The commit-queue should file bugs about flaky tests it encounters
1035         https://bugs.webkit.org/show_bug.cgi?id=50803
1036
1037         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1038
1039 2010-12-09  Eric Seidel  <eric@webkit.org>
1040
1041         Reviewed by Adam Barth.
1042
1043         The commit-queue should file bugs about flaky tests it encounters
1044         https://bugs.webkit.org/show_bug.cgi?id=50803
1045
1046         This change got a bit big.  I also added a new config.urls file
1047         because I needed to share the view_source_url code with committervalidator.py.
1048
1049         This adds a new class FlakyTestReporter which holds all the logic about
1050         reporting flaky tests to bugzilla.
1051
1052         Right now this code knows how to look up bugs for flaky tests.
1053         If it can't find a bug filed from the commit-queue, it will open a new
1054         one, ccing the relevant people and adding information about the failure.
1055
1056         It is not yet smart enough to chase down duplicate chains, or to include
1057         the actual failure diff.  But those can be added in later iterations.
1058
1059         * Scripts/webkitpy/common/checkout/api.py:
1060         * Scripts/webkitpy/common/checkout/changelog.py:
1061         * Scripts/webkitpy/common/checkout/commitinfo.py:
1062         * Scripts/webkitpy/common/config/committervalidator.py:
1063         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1064         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1065         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1066         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1067         * Scripts/webkitpy/tool/bot/irc_command.py:
1068         * Scripts/webkitpy/tool/bot/sheriff.py:
1069         * Scripts/webkitpy/tool/commands/download.py:
1070         * Scripts/webkitpy/tool/commands/queues.py:
1071         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1072         * Scripts/webkitpy/tool/comments.py:
1073         * Scripts/webkitpy/tool/mocktool.py:
1074         * Scripts/webkitpy/tool/steps/commit.py:
1075
1076 2010-12-09  Eric Seidel  <eric@webkit.org>
1077
1078         Reviewed by Adam Barth.
1079
1080         Teach webkit-patch how to search bugzilla
1081         https://bugs.webkit.org/show_bug.cgi?id=50500
1082
1083         This is a step towards teaching webkitpy how to file
1084         new bugs for flaky tests and update them when new flakes occur.
1085
1086         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1087         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1088         * Scripts/webkitpy/tool/commands/__init__.py:
1089         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1090
1091 2010-12-09  Adam Barth  <abarth@webkit.org>
1092
1093         Reviewed by Ojan Vafai.
1094
1095         commit-queue errors out due to local commits
1096         https://bugs.webkit.org/show_bug.cgi?id=50766
1097
1098         We seem to be tripping over having local commits in the working copy a
1099         lot recently.  I don't quite fully understand what the issue is, but
1100         this patch attempts to solve the problem by adding an explicit clean
1101         step before processing a patch.  Previously, we did the cleaning as
1102         part of the apply-attachment step, so this might not actually fix the
1103         problem.
1104
1105         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1106         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1107         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1108
1109 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1110
1111         Reviewed by Ojan Vafai.
1112
1113         Make new-run-webkit-tests --lint-test-files log slightly better
1114         messages and return -1 if lint fails. Remove the
1115         'suppress_errors' keyword param to the TestExpectationsFile
1116         class, and clean up logging and exception raising for error
1117         handling. Also add more unit tests and clean up the unit test code a bit.
1118
1119         https://bugs.webkit.org/show_bug.cgi?id=50205
1120
1121         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1122         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1123         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1124         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1125         * Scripts/webkitpy/layout_tests/port/chromium.py:
1126         * Scripts/webkitpy/style/checkers/test_expectations.py:
1127         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1128
1129 2010-12-09  Tony Chang  <tony@chromium.org>
1130
1131         Unreviewed, fix for windows code.  We were catching the wrong
1132         exception in Windows.
1133
1134         * Scripts/webkitpy/common/system/filesystem.py:
1135
1136 2010-12-09  Antonio Gomes  <agomes@rim.com>
1137
1138         Reviewed by Martin Robinson.
1139
1140         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1141         https://bugs.webkit.org/show_bug.cgi?id=48429
1142
1143         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1144
1145         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1146         (LayoutTestController::workerThreadCount):
1147
1148 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1149
1150         Reviewed by Martin Robinson.
1151
1152         [GTK] Support the Mozilla-style Fullscreen Javascript API
1153         https://bugs.webkit.org/show_bug.cgi?id=50572
1154
1155         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1156         make DRT update the Chrome when the WebView settings have been
1157         reset to consistent values.
1158
1159         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1160         (resetDefaultsToConsistentValues):
1161         * GtkLauncher/main.c:
1162         (create_window):
1163         * Scripts/build-webkit:
1164
1165 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1166
1167         Reviewed by Tor Arne Vestbø
1168
1169         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1170         https://bugs.webkit.org/show_bug.cgi?id=50742
1171
1172         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1173
1174         * Scripts/webkitdirs.pm:
1175
1176 2010-12-09  Joone Hur  <joone@kldp.org>
1177
1178          Reviewed by Martin Robinson.
1179
1180          [GTK] Support for viewport meta tag
1181          https://bugs.webkit.org/show_bug.cgi?id=45443
1182
1183          Add support for testing the viewport properties for WebKitGtk.
1184
1185          * DumpRenderTree/LayoutTestController.cpp:
1186          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1187          (LayoutTestController::staticFunctions):
1188          * DumpRenderTree/LayoutTestController.h:
1189          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1190          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1191          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1192          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1193          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1194          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1195          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1196          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1197          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1198          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1199
1200 2010-12-08  William Siegrist <wsiegrist@apple.com>
1201
1202         Reviewed by Eric Seidel.
1203
1204         Migrate buildbot.py from xmlrpc to json.
1205         https://bugs.webkit.org/show_bug.cgi?id=50647
1206
1207         * Scripts/webkitpy/common/net/buildbot.py:
1208
1209 2010-12-08  Tony Chang  <tony@chromium.org>
1210
1211         Reviewed by Eric Seidel.
1212
1213         make starting the websocket server more reliable on windows
1214         https://bugs.webkit.org/show_bug.cgi?id=50712
1215
1216         * Scripts/webkitpy/common/system/filesystem.py:
1217         (remove): Substitute method for os.remove to retry on error on Windows
1218         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1219         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1220
1221 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1222
1223         Reviewed by Adam Roben.
1224
1225         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1226         https://bugs.webkit.org/show_bug.cgi?id=50656
1227
1228         * MiniBrowser/mac/BrowserWindowController.m:
1229         (-[BrowserWindowController awakeFromNib]):
1230         Indicate that exceededDatabaseQuota is not implemented.
1231         * MiniBrowser/win/BrowserView.cpp:
1232         (BrowserView::create):
1233         Ditto.
1234         * WebKitTestRunner/TestController.cpp:
1235         (WTR::createOtherPage):
1236         Ditto.
1237         (WTR::TestController::initialize):
1238         Ditto.
1239
1240 2010-12-08  Antonio Gomes  <agomes@rim.com>
1241
1242         Reviewed by Martin Robinson.
1243
1244         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1245         https://bugs.webkit.org/show_bug.cgi?id=48429
1246
1247         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1248         * webkit_gc_collect_javascript_objects;
1249         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1250         * webkit_gc_count_javascript_objects;
1251         * webkit_web_frame_layout.
1252
1253         These were all only used by GTK+ DRT.
1254
1255         * DumpRenderTree/gtk/EventSender.cpp:
1256         (dispatchEvent):
1257         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1258         (GCController::collect):
1259         (GCController::collectOnAlternateThread):
1260         (GCController::getJSObjectCount):
1261
1262 2010-12-07  Tony Chang  <tony@chromium.org>
1263
1264         Reviewed by Ojan Vafai.
1265
1266         [chromium] force NRWT to use DRT
1267         https://bugs.webkit.org/show_bug.cgi?id=50359
1268
1269         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1270
1271 2010-12-06  Sam Weinig  <sam@webkit.org>
1272
1273         Reviewed by Anders Carlsson.
1274
1275         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1276         https://bugs.webkit.org/show_bug.cgi?id=50584
1277
1278         * MiniBrowser/mac/BrowserWindowController.m:
1279         (didSameDocumentNavigationForFrame):
1280         (-[BrowserWindowController awakeFromNib]):
1281         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1282         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1283         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1284         (TestWebKitAPI::TEST):
1285         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1286         (WTR::InjectedBundlePage::InjectedBundlePage):
1287         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1288         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1289         * WebKitTestRunner/TestController.cpp:
1290         (WTR::TestController::initialize):
1291
1292 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1293
1294         Reviewed by Ojan Vafai.
1295
1296         Make TestResultsServer return 404 for non-existing results files.
1297         https://bugs.webkit.org/show_bug.cgi?id=50581
1298
1299         * TestResultServer/handlers/testfilehandler.py:
1300
1301 2010-12-06  Tony Chang  <tony@chromium.org>
1302
1303         Reviewed by Ojan Vafai.
1304
1305         [chromium] fix an assert hit in DRT
1306         https://bugs.webkit.org/show_bug.cgi?id=50575
1307
1308         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1309         semantics.
1310
1311         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1312         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1313         WTF::RefCountedBase::ref()).
1314
1315         * DumpRenderTree/chromium/TestWebWorker.h:
1316         (TestWebWorker::TestWebWorker):
1317
1318 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1319
1320         Reviewed by Eric Seidel.
1321
1322         make webkit-patch command work when the git branch is not synced to the remote svn branch
1323         https://bugs.webkit.org/show_bug.cgi?id=50424
1324
1325         * Scripts/webkitpy/common/checkout/scm.py:
1326         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1327
1328 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1329
1330         Reviewed by Andreas Kling.
1331
1332         [WINCE] Add build system
1333         https://bugs.webkit.org/show_bug.cgi?id=50522
1334
1335         * CMakeListsWinCE.txt: Added.
1336
1337 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1338
1339         Reviewed by Tony Chang.
1340
1341         Allow the Chromium port to have Leopard-specific baselines
1342         https://bugs.webkit.org/show_bug.cgi?id=50506
1343
1344         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1345
1346 2010-12-03  Tony Chang  <tony@chromium.org>
1347
1348         Reviewed by Kent Tamura.
1349
1350         [chromium] fix 2 bugs with inspector tests in DRT
1351         https://bugs.webkit.org/show_bug.cgi?id=50492
1352
1353         Tasks can outlive the tasklist (even when canceled) so this was
1354         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1355         when a task is canceled.
1356
1357         Also fix an assert when closing devtool windows by copying some
1358         logic from test_shell.
1359
1360         * DumpRenderTree/chromium/Task.cpp:
1361         (WebTask::~WebTask):
1362         (TaskList::revokeAll):
1363         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1364             the tasklist (since the task can outlive the tasklist).
1365         * DumpRenderTree/chromium/TestShell.h:
1366         (TestShell::devToolsWebView):
1367         * DumpRenderTree/chromium/WebViewHost.cpp:
1368         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1369             a window if the window has devtools loaded.  This avoids an
1370             ASSERT and matches test_shell.
1371
1372 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1373
1374         Reviewed by Martin Robinson.
1375
1376         [GTK] Fix GtkLauncher.c style, use webkit style
1377         https://bugs.webkit.org/show_bug.cgi?id=50542
1378
1379         * GtkLauncher/main.c:
1380         (activateUriEntryCb):
1381         (updateTitle):
1382         (linkHoverCb):
1383         (notifyTitleCb):
1384         (notifyLoadStatusCb):
1385         (notifyProgressCb):
1386         (destroyCb):
1387         (goBackCb):
1388         (goForwardCb):
1389         (create_webViewCb):
1390         (webViewReadyCb):
1391         (closeWebViewCb):
1392         (createBrowser):
1393         (createStatusbar):
1394         (createToolbar):
1395         (createWindow):
1396         (main):
1397
1398 2010-12-04  Antonio Gomes  <agomes@rim.com>
1399
1400         Reviewed by Martin Robinson.
1401
1402         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1403         https://bugs.webkit.org/show_bug.cgi?id=48429
1404
1405         Moved more private method declared with WEBKIT_API to
1406         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1407
1408         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1409         (resetDefaultsToConsistentValues):
1410         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1411         (LayoutTestController::addOriginAccessWhitelistEntry):
1412         (LayoutTestController::execCommand):
1413         (LayoutTestController::isCommandEnabled):
1414
1415 2010-12-04  Antonio Gomes  <agomes@rim.com>
1416
1417         Reviewed by Andreas Kling.
1418
1419         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1420
1421         Method was removed by http://trac.webkit.org/changeset/71604
1422
1423         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1424
1425 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1426
1427         Reviewed by Xan Lopez.
1428
1429         [GTK] Fix compilation warnings reported by clang
1430         https://bugs.webkit.org/show_bug.cgi?id=50252
1431
1432         * GtkLauncher/main.c:
1433         (create_window): The create_statusbar function does not have
1434         parameters.
1435
1436 2010-12-05  Robert Hogan  <robert@webkit.org>
1437
1438         Reviewed by Andreas Kling.
1439
1440         [Qt] Zero-sized font does not yet work
1441
1442         Fix fast/text/font-size-zero.html
1443
1444         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1445
1446         https://bugs.webkit.org/show_bug.cgi?id=49759
1447
1448         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1449         (WebCore::WebPage::WebPage):
1450
1451 2010-12-04  Sam Weinig  <sam@webkit.org>
1452
1453         Reviewed by Jon Honeycutt.
1454
1455         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1456         https://bugs.webkit.org/show_bug.cgi?id=50511
1457
1458         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1459         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1460
1461         * MiniBrowser/mac/BrowserWindowController.m:
1462         (didChangeLocationWithinPageForFrame):
1463         (-[BrowserWindowController awakeFromNib]):
1464         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
1465         * TestWebKitAPI/PlatformUtilities.cpp:
1466         (TestWebKitAPI::Util::toWK):
1467         * TestWebKitAPI/PlatformUtilities.h:
1468         (TestWebKitAPI::Util::adoptWK):
1469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1470         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
1471         (TestWebKitAPI::nullJavaScriptCallback):
1472         (TestWebKitAPI::didFinishLoadForFrame):
1473         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
1474         (TestWebKitAPI::TEST):
1475         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
1476         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1477         * TestWebKitAPI/win/copy-resources.cmd:
1478         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1479         (WTR::InjectedBundlePage::InjectedBundlePage):
1480         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1481         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1482         * WebKitTestRunner/TestController.cpp:
1483         (WTR::TestController::initialize):
1484
1485 2010-11-08  Antonio Gomes  <agomes@rim.com>
1486
1487         Reviewed by Martin Robinson.
1488
1489         [Gtk] Populate DumpRenderTreeSupportGtk
1490         https://bugs.webkit.org/show_bug.cgi?id=48429
1491
1492         Made the previous calls to webkit_web_frame* functions defined as private
1493         APIs in webkitprivate.h go through DRTSupportGtk.
1494
1495         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1496         (AccessibilityController::focusedElement):
1497         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1498         (dumpFramesAsText):
1499         (resetDefaultsToConsistentValues):
1500         (dump):
1501         (webViewDocumentLoadFinished):
1502         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1503         (LayoutTestController::counterValueForElementById):
1504         (LayoutTestController::pageNumberForElementById):
1505         (LayoutTestController::numberOfPages):
1506         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1507         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1508         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1509         (LayoutTestController::numberOfActiveAnimations):
1510         (LayoutTestController::suspendAnimations):
1511         (LayoutTestController::resumeAnimations):
1512         (LayoutTestController::markerTextForListItem):
1513
1514 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1515
1516         Reviewed by Tony Chang.
1517
1518         Rebaseline server: use pretty text diff output
1519         https://bugs.webkit.org/show_bug.cgi?id=50484
1520         
1521         Serve *-pretty-diff.html for text diff output.
1522
1523         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1524         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1525         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1526         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1527
1528 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1529
1530         Unreviewed, rolling out r73302.
1531         http://trac.webkit.org/changeset/73302
1532         https://bugs.webkit.org/show_bug.cgi?id=50499
1533
1534         Causes crashes in debug LayoutTests (Requested by xan_ on
1535         #webkit).
1536
1537         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1538         (AccessibilityUIElement::AccessibilityUIElement):
1539         (AccessibilityUIElement::parentElementCallback):
1540         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1541         * DumpRenderTree/chromium/CppBoundClass.cpp:
1542         * DumpRenderTree/chromium/CppBoundClass.h:
1543
1544 2010-12-03  Sam Weinig  <sam@webkit.org>
1545
1546         Reviewed by Maciej Stachowiak.
1547
1548         Enable <a ping> for Mac/Windows/WebKit2 builds
1549         <rdar://problem/8504473>
1550         https://bugs.webkit.org/show_bug.cgi?id=50488
1551
1552         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1553         (TestWebKitAPI::TEST): Test that the default value of
1554         WKPreferencesGetHyperlinkAuditingEnabled is true.
1555
1556 2010-12-03  Chris Guillory  <chris.guillory@google.com>
1557
1558         Reviewed by Chris Fleizach.
1559
1560         Include the FrameView widget of a RenderWidget in the accessibility tree.
1561         https://bugs.webkit.org/show_bug.cgi?id=49106
1562
1563         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1564         (AccessibilityUIElement::AccessibilityUIElement):
1565         (AccessibilityUIElement::parentElementCallback):
1566         (AccessibilityUIElement::isEqualCallback):
1567         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1568         * DumpRenderTree/chromium/CppBoundClass.cpp:
1569         (CppBoundClass::getFromCppVariant):
1570         * DumpRenderTree/chromium/CppBoundClass.h:
1571
1572 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1573
1574         Reviewed by Tony Chang.
1575
1576         Rebaseline server: organize tests by state, add dry run mode
1577         https://bugs.webkit.org/show_bug.cgi?id=50473
1578         
1579         Group tests in the menu by state, so that it's easier to see after
1580         processing the queue which failed.
1581         
1582         Add support for the --dry-run flag so that it's easier to test changes
1583         such as this (stubs out filesystem and SCM operations).
1584
1585         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1586         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1587         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1588
1589 2010-12-03  Brady Eidson  <beidson@apple.com>
1590
1591         Reviewed by Anders Carlsson.
1592
1593         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
1594         WebKit2 Authentication Support
1595
1596         Keep these builds working:
1597         * MiniBrowser/mac/BrowserWindowController.m:
1598         (-[BrowserWindowController awakeFromNib]):
1599
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::TestController::initialize):
1602
1603 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
1604
1605         Reviewed by Tony Chang.
1606
1607         Rebaseline server: move existing baselines
1608         https://bugs.webkit.org/show_bug.cgi?id=50421
1609         
1610         Implement moving of existing baselines: move all files that are about
1611         to be overwriten by update baselines.
1612         
1613         Also fix a typo in the UI JS.
1614
1615         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1616         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1617         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1618
1619 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1620
1621         Unreviewed, rolling out r73211.
1622         http://trac.webkit.org/changeset/73211
1623         https://bugs.webkit.org/show_bug.cgi?id=50450
1624
1625         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
1626         yutak on #webkit).
1627
1628         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1629
1630 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1631
1632         Unreviewed, rolling out r73222.
1633         http://trac.webkit.org/changeset/73222
1634         https://bugs.webkit.org/show_bug.cgi?id=50449
1635
1636         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1637         (Requested by yutak on #webkit).
1638
1639         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1640         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1641         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1642         * Scripts/webkitpy/layout_tests/port/base.py:
1643         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1644         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1645
1646 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1647
1648         Unreviewed, rolling out r73228.
1649         http://trac.webkit.org/changeset/73228
1650         https://bugs.webkit.org/show_bug.cgi?id=50448
1651
1652         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1653         (Requested by yutak on #webkit).
1654
1655         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1656         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1657         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1658         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1659         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1660
1661 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1662
1663         Unreviewed, rolling out r73231.
1664         http://trac.webkit.org/changeset/73231
1665         https://bugs.webkit.org/show_bug.cgi?id=50443
1666
1667         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
1668         (Requested by yutak on #webkit).
1669
1670         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1671         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1672         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1673         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1674
1675 2010-12-03  David Levin  <levin@chromium.org>
1676
1677         Reviewed by Shinichiro Hamaji.
1678
1679         check-webkit-style: false positive reported for #if macro
1680         https://bugs.webkit.org/show_bug.cgi?id=48242
1681
1682         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
1683           all preprocessor commands.
1684         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
1685
1686 2010-12-02  Eric Seidel  <eric@webkit.org>
1687
1688         Reviewed by Adam Barth.
1689
1690         Update the EWSTools scripts to use modern-style git repos
1691         https://bugs.webkit.org/show_bug.cgi?id=50402
1692
1693         * EWSTools/create-webkit-git:
1694         * EWSTools/start-commit-queue.sh:
1695         * EWSTools/start-queue.sh:
1696
1697 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1698
1699         Fix Chromium Linux plugin tests by not logging
1700         unconditionally from the event handling code.
1701
1702         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1703         (handleEventX11):
1704
1705 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1706
1707         Reviewed by Tony Chang.
1708
1709         nrwt multiprocessing - move logic back into run_webkit_tests
1710
1711         This change moves a bunch of logic that I had put into
1712         message_broker back into run_webkit_tests, in a slightly
1713         different format. WorkerMessageBroker needed to become less aware of
1714         the logic the TestRunner class uses, and more generic.
1715         Eventually the MessageBroker will only do generic messaging and
1716         thread/process-pooling, and (almost) all of the
1717         run-webkit-tests-specific logic will be moved to
1718         run_webkit_tests.py and dump_render_tree_thread.py.
1719         
1720         The biggest changes are that the Broker can now start a single
1721         worker, but the responsibility for starting all of them is pushed
1722         back to the TestRunner (Manager), and the logic for checking if
1723         the threads are done or wedged is moved back to TestRunner. We
1724         also remove WorkerMessageBroker.cleanup (not needed) and
1725         cancel_workers (they have to be cancelled individually).
1726         
1727         The  message_broker is now encapsulated inside
1728         TestRunner._run_tests(); it only needs to exist while actually
1729         running the tests.
1730
1731         Also, delete a bunch of tests in message_broker_unittest that no
1732         longer make much sense.
1733
1734         This patch depends on bug 50372.
1735
1736         https://bugs.webkit.org/show_bug.cgi?id=50374
1737
1738         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1739         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1740         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1741         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1742         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1743
1744 2010-12-02  Hayato Ito  <hayato@chromium.org>
1745
1746         Reviewed by Eric Seidel.
1747
1748         Refactor test_types's compare_output() method so that it takes a
1749         TestInput object.
1750
1751         compare_output() will need additional information included in a TestInput
1752         object to support reftests. This change is a pre-requirement of that.
1753
1754         https://bugs.webkit.org/show_bug.cgi?id=50362
1755
1756         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1757         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1758         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1759         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1760         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1761
1762 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1763
1764         Reviewed by Anders Carlsson.
1765
1766         Add the ability to run script on 'new' and 'paint' in the test plugin
1767         https://bugs.webkit.org/show_bug.cgi?id=50425
1768         
1769         Add "onnew" and "onpaintevent" attributes to the test plugin,
1770         so that tests can run JS at these times.
1771
1772         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1773         (pluginAllocate):
1774         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1775         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1776         (NPP_New):
1777         (NPP_Destroy):
1778         (handleEventCarbon):
1779         (handleEventCocoa):
1780         (NPP_HandleEvent):
1781
1782 2010-12-02  Sam Weinig  <sam@webkit.org>
1783
1784         Fix Qt build.
1785
1786         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1787         (WTR::PlatformWebView::PlatformWebView):
1788
1789 2010-12-02  Sam Weinig  <sam@webkit.org>
1790
1791         Reviewed by Anders Carlsson.
1792
1793         WebKit2 Preferences should be held off the PageGroup, not the Context
1794         https://bugs.webkit.org/show_bug.cgi?id=50414
1795
1796         Update for API changes.
1797
1798         * WebKitTestRunner/PlatformWebView.h:
1799         * WebKitTestRunner/TestController.cpp:
1800         (WTR::createOtherPage):
1801         (WTR::TestController::initialize):
1802         (WTR::TestController::resetStateToConsistentValues):
1803         * WebKitTestRunner/TestController.h:
1804         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1805         (WTR::PlatformWebView::PlatformWebView):
1806         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1807         (WTR::PlatformWebView::PlatformWebView):
1808
1809 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1810
1811         Reviewed by Tony Chang.
1812
1813         new-run-webkit-tests: minor cleanup for multiprocessing work
1814
1815         This change:
1816         * moves worker naming into TestShellThread, eliminating a
1817           parameter to the constructor and putting the responsibility in
1818           the correct place.
1819         * eliminates the _WorkerState() class in message_broker, because
1820           it turns out that state really needs to be in run_webkit_tests
1821         * renames the Broker classes to be module-private.
1822         * fixes a bunch of minor commenting and whitespace issues to
1823           make subsequent patches a bit clearer.
1824         * Adds a Port hook for default_worker_model() so that we can
1825           accomodate the potential for different worker models on
1826           different ports.
1827         * merge in the fix from 50420 for the brokenness introduced in
1828           bug 50367.
1829
1830         This patch depends on bug 50367.
1831
1832         https://bugs.webkit.org/show_bug.cgi?id=50372
1833
1834         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1835         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1836         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1837         * Scripts/webkitpy/layout_tests/port/base.py:
1838         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1839         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1840
1841 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1842
1843         Reviewed by Tony Chang.
1844
1845         This change is a bunch of cleanup / refactoring of the file
1846         below. It moves a bunch of free functions to methods on the
1847         TestShellThread class, and restructures other methods to be
1848         closer to the structure we'll need for the multiprocessing
1849         rewrite.
1850
1851         It also makes the logic of --run-singly a *lot* easier to follow
1852         by nestling all of the separate-thread logic into a single
1853         routine.
1854
1855         There should be no semantic changes in this patch, just cleanup.
1856
1857         https://bugs.webkit.org/show_bug.cgi?id=50367
1858
1859         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1860
1861 2010-12-02  Tony Chang  <tony@chromium.org>
1862
1863         Unreviewed, rolling out r73164.
1864         http://trac.webkit.org/changeset/73164
1865         https://bugs.webkit.org/show_bug.cgi?id=50359
1866
1867         broke debugger tests on win
1868
1869         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1870
1871 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
1872
1873         Reviewed by Tony Chang.
1874
1875         Rebaseline server: add updating of baselines
1876         https://bugs.webkit.org/show_bug.cgi?id=50305
1877         
1878         Implements updating of baselines, where we copy -actual.* files over
1879         the current -expected.* files. To do this, we need a
1880         _get_actual_result_files method to get test results files and a
1881         _rebaseline_test method to actually do the file copy and SCM operation.
1882         _rebaseline_test logs output into a buffer, this is useful for both
1883         showing result in the UI and for unit tests.
1884         
1885         To make passing around of the various test environment properties
1886         (results directory, filesystem, SCM, etc) easier, add a TestConfig
1887         class for them.
1888         
1889         Moving of existing baselines is not implemented yet, this patch is big
1890         enough as it is.
1891
1892         * Scripts/webkitpy/common/system/filesystem.py:
1893         * Scripts/webkitpy/common/system/filesystem_mock.py:
1894         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1895         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1896         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1897         * Scripts/webkitpy/tool/mocktool.py:
1898
1899 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
1900
1901         Unreviewed build fix after vcproj updates.
1902
1903         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
1904         that WIN_CAIRO is defined for this build.
1905         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
1906         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
1907         (these were previously 'Debug_Cairo' and 'Release_Cairo'
1908
1909 2010-12-02  Sam Weinig  <sam@webkit.org>
1910
1911         Reviewed by Anders Carlsson.
1912
1913         WebKit2 needs API to turn on popup blocking
1914         https://bugs.webkit.org/show_bug.cgi?id=50407
1915
1916         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1917         (TestWebKitAPI::TEST):
1918         * WebKitTestRunner/TestController.cpp:
1919         (WTR::TestController::resetStateToConsistentValues):
1920
1921 2010-12-01  Tony Chang  <tony@chromium.org>
1922
1923         Reviewed by Ojan Vafai.
1924
1925         [chromium] force NRWT to use DRT
1926         https://bugs.webkit.org/show_bug.cgi?id=50359
1927
1928         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1929
1930 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
1931
1932         Reviewed by Xan Lopez.
1933
1934         [GTK] DumpRenderTree has two copies of JavaScriptCore
1935         https://bugs.webkit.org/show_bug.cgi?id=49877
1936
1937         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
1938         LDADD list for DumpRenderTree.
1939
1940 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
1941
1942         Unreviewed: Added myself to list of Committers.
1943
1944         * Scripts/webkitpy/common/config/committers.py:
1945
1946 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
1947
1948         Reviewed by Adam Barth.
1949
1950         build-webkit --chromium always updates DEPS and re-generates project files
1951         https://bugs.webkit.org/show_bug.cgi?id=50340
1952         
1953         Make build-webkit --chromium invoke update-webkit-chromium only when
1954         --update-chromium is passed in, so that we don't add 20 seconds to all
1955         builds.
1956         
1957         Making all invocations update was added with r61883, with the goal of
1958         making EWS bots always update. The bots will switch to using this flag
1959         (as will all other webkit-patch build steps) so nothing should change
1960         for them.
1961
1962         * Scripts/webkitdirs.pm:
1963         * Scripts/webkitpy/common/config/ports.py:
1964         * Scripts/webkitpy/common/config/ports_unittest.py:
1965
1966 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
1967
1968         Reviewed by Tony Chang.
1969
1970         new-run-webkit-tests: add a --dry-run / -n flag
1971         https://bugs.webkit.org/show_bug.cgi?id=50045
1972
1973         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1974         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1975
1976 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
1977
1978         Reviewed by Adam Roben.
1979
1980         WinCairo build should not use link-time code generation (LTCG)
1981         https://bugs.webkit.org/show_bug.cgi?id=50353
1982
1983         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1984         * DumpRenderTree/win/DumpRenderTree.vcproj:
1985         * DumpRenderTree/win/ImageDiff.vcproj:
1986         * FindSafari/FindSafari.vcproj:
1987         * MiniBrowser/MiniBrowser.vcproj:
1988         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1989         * WebKitAPITest/WebKitAPITest.vcproj:
1990         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1991         * WebKitTestRunner/win/InjectedBundle.vcproj:
1992         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1993         * WinLauncher/WinLauncher.vcproj:
1994         * record-memory-win/record-memory-win.vcproj:
1995
1996 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
1997
1998         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
1999         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2000         adding the file to the sources list was not enough to force the rebuild.
2001
2002         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2003         Remove an empty line at the end of this file to force a rebuild.
2004
2005 2010-12-01  Sam Weinig  <sam@webkit.org>
2006
2007         Fix windows build.
2008
2009         * MiniBrowser/win/BrowserView.cpp:
2010         (BrowserView::create):
2011
2012 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2013
2014         Add missing file to the TestNetscapePlugin sources list after r73057.
2015
2016         * GNUmakefile.am: Add missing file.
2017
2018 2010-12-01  Sam Weinig  <sam@webkit.org>
2019
2020         Reviewed by Anders Carlsson.
2021
2022         Add PageGrouping to WebKit2 API
2023         https://bugs.webkit.org/show_bug.cgi?id=50332
2024
2025         - Update testing harnesses to deal with new PageGroup API.
2026
2027         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2028         (WKBundleInitialize):
2029         * TestWebKitAPI/InjectedBundleController.cpp:
2030         (TestWebKitAPI::InjectedBundleController::initialize):
2031         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2032         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2033         * TestWebKitAPI/InjectedBundleController.h:
2034         * TestWebKitAPI/InjectedBundleTest.h:
2035         (TestWebKitAPI::InjectedBundleTest::initialize):
2036         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2037         * TestWebKitAPI/PlatformUtilities.cpp:
2038         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2039         * TestWebKitAPI/PlatformUtilities.h:
2040         * TestWebKitAPI/PlatformWebView.h:
2041         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2042         (TestWebKitAPI::TEST):
2043         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2044         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2045         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2046         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2047         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2048         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2049         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2050         (WTR::InjectedBundle::didInitializePageGroup):
2051         (WTR::InjectedBundle::initialize):
2052         (WTR::InjectedBundle::beginTesting):
2053         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2054         (WTR::InjectedBundle::pageGroup):
2055         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2056         (WTR::LayoutTestController::addUserScript):
2057         (WTR::LayoutTestController::addUserStyleSheet):
2058         (WTR::LayoutTestController::setXSSAuditorEnabled):
2059         * WebKitTestRunner/TestController.cpp:
2060         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2061         (WTR::PlatformWebView::PlatformWebView):
2062
2063 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2064
2065         Reviewed by Adam Roben.
2066
2067         vcproj changes can't be applied cleanly by the Windows EWS bot
2068         https://bugs.webkit.org/show_bug.cgi?id=50328
2069
2070         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2071         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2072         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2073         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2074         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2075         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2076         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2077         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2078         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2079         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2080         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2081         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2082         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2083         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2084         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2085         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2086         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2087         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2088         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2089         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2090         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2091         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2092         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2093         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2094         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2095         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2096         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2097         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2098         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2099         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2100         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2101         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2102         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2103         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2104         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2105         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2106         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2107         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2108         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2109         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2110         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2111         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2112         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2113         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2114         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2115
2116 2010-12-01  Anders Carlsson  <andersca@apple.com>
2117
2118         Reviewed by Darin Adler.
2119
2120         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2121         https://bugs.webkit.org/show_bug.cgi?id=50336
2122
2123         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2124         Add new test.
2125
2126         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2127         (PluginTest::NPP_New):
2128         Add default implementation/
2129
2130         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2131         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2132         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2133         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2134         Get the user agent.
2135
2136         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2137         (NPP_New):
2138         Call PluginTest::NPP_New.
2139
2140         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2141         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2142         Add new files.
2143
2144         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2145         (webkit_test_plugin_new_instance):
2146         Call PluginTest::NPP_New.
2147
2148 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2149
2150         [wx] Build fixes after recent trunk changes.
2151
2152         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2153         (LayoutTestController::findString):
2154         * wx/build/settings.py:
2155
2156 2010-12-01  Dan Bernstein  <mitz@apple.com>
2157
2158         Reviewed by Darin Adler.
2159
2160         WebKitTestRunner needs layoutTestController.findString
2161         https://bugs.webkit.org/show_bug.cgi?id=50238
2162
2163         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2164         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2165         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2166         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2167
2168 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2169
2170         Try using svn:eol-style native on a vcproj file.
2171
2172         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2173
2174 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2175
2176         Reviewed by Adam Roben.
2177
2178         [WINCE] Add WinCELauncher
2179         https://bugs.webkit.org/show_bug.cgi?id=50217
2180
2181         * WinCELauncher/main.cpp: Added.
2182
2183 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2184
2185         Reviewed by Kenneth Rohde Christiansen.
2186
2187         [Qt] Implement layoutTestController.findString
2188         https://bugs.webkit.org/show_bug.cgi?id=50236
2189
2190         Add the missing function to the LayoutTestController.
2191
2192         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2193         (LayoutTestController::findString):
2194         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2195
2196 2010-11-30  Tony Chang  <tony@chromium.org>
2197
2198         Reviewed by Adam Barth.
2199
2200         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2201         https://bugs.webkit.org/show_bug.cgi?id=49036
2202
2203         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2204             for CppVariants.
2205         (LayoutTestController::cppVariantToBool):
2206         (LayoutTestController::cppVariantToInt32):
2207         (LayoutTestController::setDatabaseQuota):
2208         (LayoutTestController::evaluateInWebInspector):
2209         (LayoutTestController::setMockGeolocationError):
2210
2211 2010-11-30  Eric Seidel  <eric@webkit.org>
2212
2213         Reviewed by Tony Chang.
2214
2215         update-webkit should call git fetch before git svn rebase
2216         https://bugs.webkit.org/show_bug.cgi?id=50273
2217
2218         After discussion on webkit-dev, we've decided to move the "default"
2219         git setup to pulling updates from git.webkit.org in preference
2220         to rebuilding the local svn index using git svn fetch every time.
2221
2222         This change should have no effect on people using the "old" git setup
2223         and should dramatically increase the speed of updates for those using
2224         the "new" git setup along with update-webkit.  I'm about to move the
2225         EWS and other queues over to this setup once this lands.
2226
2227         * Scripts/update-webkit:
2228
2229 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2230
2231         Reviewed by Xan Lopez.
2232
2233         GTK: AX: implement press in DRT
2234         https://bugs.webkit.org/show_bug.cgi?id=36146
2235
2236         Implement AccessibilityUIElement::press() for GTK.
2237
2238         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2239         (AccessibilityUIElement::press): Implemented.
2240
2241 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2242
2243         Reviewed by Tony Chang.
2244
2245         config.webkit_base_dir returns a path with a trailing slash
2246         https://bugs.webkit.org/show_bug.cgi?id=50197
2247         
2248         config.webkit_base_dir() should return a path without a trailing slash,
2249         like all the other methods that return paths.
2250         
2251         Undoes MockFileSytem changes by r72640, since they're no longer
2252         necessary for GetBaselinesTest to pass.
2253
2254         * Scripts/webkitpy/common/system/filesystem_mock.py:
2255         * Scripts/webkitpy/layout_tests/port/base.py:
2256         * Scripts/webkitpy/layout_tests/port/config.py:
2257         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2258
2259 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2260
2261         Reviewed by Tony Chang.
2262
2263         Rebaseline server: baseline display tweaks
2264         https://bugs.webkit.org/show_bug.cgi?id=50207
2265         
2266         Determine which baselines were used when running the tests and highlight
2267         them in the UI. Sort platform names alphabetically.
2268         
2269         Also makes the server URL be launched in the user's browser
2270         automatically.
2271
2272         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2273         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2274         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2275         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2276         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2277
2278 2010-11-30  Dan Bernstein  <mitz@apple.com>
2279
2280         Reviewed by Anders Carlsson.
2281
2282         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2283         https://bugs.webkit.org/show_bug.cgi?id=50238
2284
2285         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2286         (WTR::LayoutTestController::findString): Added.
2287         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2288
2289 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2290
2291         Reviewed by Adam Roben.
2292
2293         All projects on Windows should use cmd files for build events
2294         https://bugs.webkit.org/show_bug.cgi?id=50213
2295
2296         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2297         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2298         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2299         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2300         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2301         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2302         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2303         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2304         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2305         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2306         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2307         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2308         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2309         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2310         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2311         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2312         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2313         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2314         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2315         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2316         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2317         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2318         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2319         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2320         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2321         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2322         * WinLauncher/WinLauncherCommon.vsprops:
2323         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2324         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2325
2326 2010-11-29  Dan Bernstein  <mitz@apple.com>
2327
2328         GTK DumpRenderTree build fix after r72887.
2329
2330         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2331         (LayoutTestController::findString):
2332
2333 2010-11-29  Dan Bernstein  <mitz@apple.com>
2334
2335         Windows DumpRenderTree build fix after r72887.
2336
2337         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2338         (LayoutTestController::findString): Added empty implementation.
2339
2340 2010-11-29  Dan Bernstein  <mitz@apple.com>
2341
2342         Reviewed by Darin Adler.
2343
2344         DumpRenderTree changes for testing the text search API.
2345         https://bugs.webkit.org/show_bug.cgi?id=50038
2346
2347         * DumpRenderTree/LayoutTestController.cpp:
2348         (findStringCallback):
2349         (LayoutTestController::staticFunctions):
2350         * DumpRenderTree/LayoutTestController.h:
2351         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2352         (LayoutTestController::findString):
2353         * MiniBrowser/mac/BrowserWindowController.m:
2354         (-[BrowserWindowController find:]):
2355
2356 2010-11-29  Johnny Ding  <jnd@chromium.org>
2357
2358         Unreviewed: Add myself to the list of Committers.
2359
2360         * Scripts/webkitpy/common/config/committers.py:
2361
2362 2010-11-29  Mark Rowe  <mrowe@apple.com>
2363
2364         Reviewed by Adele Peterson.
2365
2366         <rdar://problem/8694997> DumpRenderTree fails to build.
2367
2368         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2369
2370 2010-11-29  Mark Rowe  <mrowe@apple.com>
2371
2372         Reviewed by Adele Peterson.
2373
2374         <rdar://problem/8694997> DumpRenderTree fails to build.
2375
2376         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2377         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2378         * DumpRenderTree/mac/PerlSupport/Makefile:
2379
2380 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2381
2382         Reviewed by Martin Robinson.
2383
2384         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2385         https://bugs.webkit.org/show_bug.cgi?id=50154
2386
2387         Added missing checks to allAttributes().
2388
2389         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2390         (AccessibilityUIElement::allAttributes): Added missing checks.
2391
2392 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2393
2394         Reviewed by Kenneth Rohde Christiansen.
2395
2396         [Qt] Allow pre-generation for package builds for WebKit2
2397         https://bugs.webkit.org/show_bug.cgi?id=50139
2398
2399         Use a build variable for the generated directory path and set the
2400         value based on CONFIG just like for WebKit1.
2401
2402         For non-package builds use a relative base path for the
2403         genrated directory just like for WebKit1.
2404
2405         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2406         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2407
2408 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2409
2410         Reviewed by Kenneth Rohde Christiansen.
2411
2412         [Qt] Move some build logic from Qt to platform independent code
2413         https://bugs.webkit.org/show_bug.cgi?id=50134
2414
2415         Create target directories inside generate-forwarding-headers.pl.
2416
2417         * Scripts/generate-forwarding-headers.pl:
2418
2419 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2420
2421         Reviewed by Martin Robinson.
2422
2423         [GTK] Windowless plugins gets broken key input
2424         https://bugs.webkit.org/show_bug.cgi?id=49927
2425
2426         Convert the XEvent::keycode to ASCII before printing it. Not
2427         doing this was causing false positive in 
2428         plugins/keyboard-events.html.
2429
2430         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2431         (keycode_to_char):
2432         (webkit_test_plugin_handle_event):
2433
2434 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2435
2436         Reviewed by Antonio Gomes.
2437
2438         [Qt] Html autofocus not working with QGraphicsWebView
2439         https://bugs.webkit.org/show_bug.cgi?id=43169
2440
2441         Tell the scene to set the webview item as the currently
2442         focused item. This makes the input field with autofocus get
2443         focus as it should.
2444
2445         * QtTestBrowser/webview.cpp:
2446         (WebViewGraphicsBased::WebViewGraphicsBased):
2447
2448 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2449
2450         Reviewed by Tony Chang.
2451
2452         nrwt - clean up create_driver interface and print out the
2453         command line used for DumpRenderTree/TestShell.
2454
2455         This patch adds a driver_cmd_line() call to the Port class in
2456         order to retrive the command line to print it out (as part of
2457         --print config).
2458
2459         In addition, this patch cleans up the Port.create_driver()
2460         signature and the Driver constructor interface to take a worker
2461         number and no longer require the image_path argument (Chromium's
2462         drivers now synthesize the image_path from the worker number
2463         internally).
2464
2465         https://bugs.webkit.org/show_bug.cgi?id=49934
2466
2467         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2468         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2469         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2470         * Scripts/webkitpy/layout_tests/port/base.py:
2471         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2472         * Scripts/webkitpy/layout_tests/port/chromium.py:
2473         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2474         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2475         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2476         * Scripts/webkitpy/layout_tests/port/test.py:
2477         * Scripts/webkitpy/layout_tests/port/webkit.py:
2478         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2479         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2480
2481 2010-11-24  Ojan Vafai  <ojan@chromium.org>
2482
2483         Reviewed by Tony Chang.
2484
2485         [chromium] improve memory usage for test results server and store fewer runs
2486         https://bugs.webkit.org/show_bug.cgi?id=50035
2487
2488         Store fewer runs and don't pass full files around when we only need bools.
2489         Greatly improves error rates on test-results.appspot.com.
2490
2491         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2492         * TestResultServer/handlers/testfilehandler.py:
2493         * TestResultServer/model/dashboardfile.py:
2494         * TestResultServer/model/jsonresults.py:
2495
2496 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2497
2498         Reviewed by Tony Chang.
2499
2500         This patch implements the first part of the manager side of the
2501         Broker objects - it handles creating threads, waiting for them
2502         to complete, and running a single-threaded loop as well.
2503
2504         https://bugs.webkit.org/show_bug.cgi?id=49779
2505
2506         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2507         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2508         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2509         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2510
2511 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
2512
2513         Reviewed by David Levin.
2514
2515         DRT should not generate pixel output for text/plain tests
2516         https://bugs.webkit.org/show_bug.cgi?id=50002
2517         
2518         Modify Mac, Windows and GTK DRT implementations to disable pixel output
2519         when encountering a text/plain response (the Chromium one already does
2520         this, and none of the other ports special-case text/plain output in
2521         the first place).
2522
2523         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2524         (dump):
2525         * DumpRenderTree/mac/DumpRenderTree.mm:
2526         (dump):
2527         * DumpRenderTree/win/DumpRenderTree.cpp:
2528         (dump):
2529
2530 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2531
2532         Unreviewed.
2533
2534         Add my other email address to committers.py.
2535
2536         * Scripts/webkitpy/common/config/committers.py:
2537
2538 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2539
2540         Reviewed by Csaba Osztrogonác.
2541
2542         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
2543         https://bugs.webkit.org/show_bug.cgi?id=49975
2544
2545         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
2546         to enable the script to define it 0 in case of a minimal build.
2547
2548 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2549
2550         Reviewed by Xan Lopez.
2551
2552         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
2553         https://bugs.webkit.org/show_bug.cgi?id=49143
2554
2555         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2556         (createWebView): Call the new connectEditingCallbacks function.
2557         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
2558         (dumpNodePath):
2559         (dumpRange):
2560         (insertActionString):
2561         (selectionAffinityString):
2562         (shouldBeginEditing):
2563         (shouldEndEditing):
2564         (shouldInsertNode):
2565         (shouldInsertText):
2566         (shouldDeleteRange):
2567         (shouldShowDeleteInterfaceForElement):
2568         (shouldChangeSelectedRange):
2569         (shouldApplyStyle):
2570         (editingBegan):
2571         (userChangedContents):
2572         (editingEnded):
2573         (selectionChanged):
2574         (connectEditingCallbacks):
2575         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
2576         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
2577
2578 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
2579
2580         Reviewed by Andreas Kling.
2581
2582         [Qt] Make QtTestBrowser remember the selected user agent
2583         https://bugs.webkit.org/show_bug.cgi?id=50021
2584
2585         Set user agent for a new page by using the old page's
2586
2587         * QtTestBrowser/mainwindow.cpp:
2588         (MainWindow::setPage):
2589
2590 2010-11-24 Patrick Gansterer <paroga@webkit.org>
2591
2592         Reviewed by Csaba Osztrogonác.
2593
2594         Remove Bakefile build system files
2595         https://bugs.webkit.org/show_bug.cgi?id=49983
2596
2597         r53757 only removed the content, but not the files.
2598         This patch removes that empty files.
2599
2600         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2601         * wx/browser/browser.bkl: Removed.
2602         * wx/build-wxwebkit: Removed.
2603
2604 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
2605
2606         Reviewed by Tony Chang.
2607
2608         This patch cleans up the logic used to shard tests into groups a
2609         bit and adds the --worker-model flag to NRWT. The flag is only
2610         used at the moment to control whether to run single-threaded or
2611         not, but eventually will also allow toggling between threads and
2612         processes.
2613
2614         Also add a minor cleanup with _test_is_slow(), which just
2615         eliminates some repetition and gives slightly better encapsulation.
2616
2617         https://bugs.webkit.org/show_bug.cgi?id=49773
2618
2619         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2620         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2621
2622 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
2623
2624         Reviewed by Tony Chang.
2625
2626         Rebaseline server: list current baselines and platforms
2627         https://bugs.webkit.org/show_bug.cgi?id=49991
2628         
2629         List existing baselines (with Trac links) for tests.
2630         
2631         Add dropdowns for choosing with platform baselines to target (and what
2632         to do with existing ones).
2633
2634         Also fix MockFileSystem.join to behave more like os.path.join (unit
2635         test was ending up with two consecutive slashes in a layout test
2636         path).        
2637
2638         * Scripts/webkitpy/common/system/filesystem_mock.py:
2639         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2640         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2641         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2642         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2643         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2644         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2645         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
2646
2647 2010-11-23  Ojan Vafai  <ojan@chromium.org>
2648
2649         Reviewed by Tony Chang.
2650
2651         remove timeout argument to urlopen
2652         https://bugs.webkit.org/show_bug.cgi?id=49995
2653
2654         Apparently the version of python we have on the bots doesn't accept a timeout argument.
2655
2656         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2657
2658 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2659
2660         Unreviewed, rolling out r72628.
2661         http://trac.webkit.org/changeset/72628
2662         https://bugs.webkit.org/show_bug.cgi?id=49994
2663
2664         This patch is causing layout-test failtures on GTK Linux
2665         64-bit Debug (Requested by ctguil on #webkit).
2666
2667         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2668         (AccessibilityUIElement::AccessibilityUIElement):
2669         (AccessibilityUIElement::parentElementCallback):
2670         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2671         * DumpRenderTree/chromium/CppBoundClass.cpp:
2672         * DumpRenderTree/chromium/CppBoundClass.h:
2673
2674 2010-11-22  Ojan Vafai  <ojan@chromium.org>
2675
2676         Reviewed by Tony Chang.
2677
2678         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
2679         https://bugs.webkit.org/show_bug.cgi?id=49944
2680
2681         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2682
2683 2010-11-23  Chris Guillory  <chris.guillory@google.com>
2684
2685         Reviewed by Dimitri Glazkov.
2686
2687         Include the FrameView widget of a RenderWidget in the accessibility tree.
2688         https://bugs.webkit.org/show_bug.cgi?id=49106
2689
2690         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2691         (AccessibilityUIElement::AccessibilityUIElement):
2692         (AccessibilityUIElement::parentElementCallback):
2693         (AccessibilityUIElement::isEqualCallback):
2694         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2695         * DumpRenderTree/chromium/CppBoundClass.cpp:
2696         (CppBoundClass::getFromCppVariant):
2697         * DumpRenderTree/chromium/CppBoundClass.h:
2698
2699 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
2700
2701         Reviewed by Kenneth Rohde Christiansen.
2702
2703         [EFL] Add tiled backing store to EWebLauncher
2704         https://bugs.webkit.org/show_bug.cgi?id=45777
2705
2706         Allow EWebLauncher to choose between single and tiled backing store
2707
2708         * EWebLauncher/main.c:
2709         (on_key_down):
2710         (browserCreate):
2711         (main):
2712
2713 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2714
2715         Reviewed by Tor Arne Vestbø.
2716
2717         [Qt] Review the setUserPermission & friends API
2718         https://bugs.webkit.org/show_bug.cgi?id=46810
2719
2720         Renamed requestPermissionFromUser to featurePermissionRequested
2721         and cancelRequestsForPermission to featurePermissionRequestCanceled.
2722
2723         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2724         (WebCore::WebPage::WebPage):
2725         * QtTestBrowser/webpage.cpp:
2726         (WebPage::WebPage):
2727         (WebPage::featurePermissionRequestCanceled):
2728         * QtTestBrowser/webpage.h:
2729
2730 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2731
2732         Reviewed by Tor Arne Vestbø.
2733
2734         [Qt] Review the setUserPermission & friends API
2735         https://bugs.webkit.org/show_bug.cgi?id=46810
2736
2737         Rename setUserPermission to setFeaturePermission
2738
2739         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2740         (WebCore::WebPage::requestPermission):
2741         (WebCore::WebPage::permissionSet):
2742         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2743         (LayoutTestController::grantDesktopNotificationPermission):
2744         * QtTestBrowser/webpage.cpp:
2745         (WebPage::requestPermission):
2746
2747 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2748
2749         Reviewed by Tor Arne Vestbø.
2750
2751         [Qt] Review the setUserPermission & friends API
2752         https://bugs.webkit.org/show_bug.cgi?id=46810
2753
2754         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
2755         and GeolocationPermissionDomain to Geolocation.
2756
2757         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2758         (WebCore::WebPage::WebPage):
2759         (WebCore::WebPage::requestPermission):
2760         (WebCore::WebPage::cancelPermission):
2761         (WebCore::WebPage::permissionSet):
2762         (WebCore::DumpRenderTree::geolocationPermissionSet):
2763         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2764         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2765         (LayoutTestController::grantDesktopNotificationPermission):
2766         * QtTestBrowser/webpage.cpp:
2767         (WebPage::WebPage):
2768         (WebPage::requestPermission):
2769         (WebPage::cancelRequestsForPermission):
2770         * QtTestBrowser/webpage.h:
2771
2772 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2773
2774         Reviewed by Tor Arne Vestbø.
2775
2776         [Qt] Review the setUserPermission & friends API
2777         https://bugs.webkit.org/show_bug.cgi?id=46810
2778
2779         Add a ByUser suffix to PermissionGranted/Denied. In the future
2780         we can add PermissionGrantedByDefault.
2781
2782
2783         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2784         (WebCore::WebPage::requestPermission):
2785         (WebCore::WebPage::permissionSet):
2786         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2787         (LayoutTestController::grantDesktopNotificationPermission):
2788         * QtTestBrowser/webpage.cpp:
2789         (WebPage::requestPermission):
2790
2791 2010-11-18  Satish Sampath  <satish@chromium.org>
2792
2793         Reviewed by Jeremy Orlow.
2794
2795         For speech input event, send an event object containing all the recognition results and metadata.
2796         https://bugs.webkit.org/show_bug.cgi?id=49736
2797
2798         Updated DRT by renaming the mock result method on all platforms to the new signature.
2799
2800         * DumpRenderTree/LayoutTestController.cpp:
2801         (addMockSpeechInputResultCallback):
2802         (LayoutTestController::staticFunctions):
2803         * DumpRenderTree/LayoutTestController.h:
2804         * DumpRenderTree/chromium/LayoutTestController.cpp:
2805         (LayoutTestController::LayoutTestController):
2806         (LayoutTestController::addMockSpeechInputResult):
2807         * DumpRenderTree/chromium/LayoutTestController.h:
2808         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2809         (LayoutTestController::addMockSpeechInputResult):
2810         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2811         (LayoutTestController::addMockSpeechInputResult):
2812         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2813         (LayoutTestController::addMockSpeechInputResult):
2814         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2815         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2816         (LayoutTestController::addMockSpeechInputResult):
2817         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2818         (LayoutTestController::addMockSpeechInputResult):
2819
2820 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
2821
2822         Reviewed by Tony Chang.
2823
2824         Fix some spacing issues with log messages with
2825         new-run-webkit-tests --verbose.
2826
2827         https://bugs.webkit.org/show_bug.cgi?id=49936
2828
2829         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2830
2831 2010-11-22  Ojan Vafai  <ojan@chromium.org>
2832
2833         Reviewed by Adam Barth.
2834
2835         update scm to work with different remote branches
2836         https://bugs.webkit.org/show_bug.cgi?id=49949
2837
2838         This works if there are multiple svn tracking branches
2839         and/or if the tracking branch is refs/remots/origin/master
2840         instead of refs/remotes/trunk which is the direction we're trying
2841         to head since that makes fetches faster.
2842
2843         * Scripts/webkitpy/common/checkout/scm.py:
2844         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2845
2846 2010-11-22  Hayato Ito  <hayato@chromium.org>
2847
2848         Reviewed by Shinichiro Hamaji.
2849
2850         Ignore reference files which will be used by reftests when collecting
2851         test cases.
2852         https://bugs.webkit.org/show_bug.cgi?id=49835
2853
2854         * Scripts/webkitpy/layout_tests/port/test_files.py:
2855         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2856
2857 2010-11-22  Adam Roben  <aroben@apple.com>
2858
2859         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
2860
2861         Apple's Windows build allows placing header files and import libraries for WebKit's
2862         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
2863         $WebKitLibrariesDir environment variable. This is both required for production builds and
2864         convenient for Apple-internal developer builds. Apple's production builds also require that
2865         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
2866         builds, the files are copied into that directory tree by the
2867         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
2868         copying is done by
2869         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
2870
2871         This .vsprops copying is problematic in one very important case: when a developer updates
2872         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
2873         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
2874         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
2875         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
2876         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
2877         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
2878
2879         To fix this, we now use normal relative paths to access the .vsprops files in the source
2880         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
2881         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
2882         unset, so the normal relative paths are used to read the .vsprops files out of the source
2883         tree directly. In production builds, this environment variable is set to a fake directory
2884         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
2885         is resolved.
2886         
2887         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
2888
2889         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2890
2891         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
2892         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
2893         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
2894         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
2895         FeatureDefines.vsprops becomes:
2896
2897         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2898
2899         which resolves to:
2900
2901         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
2902
2903         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
2904         actually exist since they are matched by an equal number of ".." path components.)
2905
2906         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
2907         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
2908
2909         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
2910         updated
2911
2912         Reviewed by Dave Hyatt.
2913
2914         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2915         * DumpRenderTree/win/DumpRenderTree.vcproj:
2916         * DumpRenderTree/win/ImageDiff.vcproj:
2917         * FindSafari/FindSafari.vcproj:
2918         * MiniBrowser/MiniBrowser.vcproj:
2919         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2920         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2921         * WebKitAPITest/WebKitAPITest.vcproj:
2922         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2923         * WebKitTestRunner/win/InjectedBundle.vcproj:
2924         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2925         * WinLauncher/WinLauncher.vcproj:
2926         * record-memory-win/record-memory-win.vcproj:
2927         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
2928         files.
2929
2930 2010-11-22  Adam Roben  <aroben@apple.com>
2931
2932         Make it possible to run tests on Windows without Visual Studio or VC++
2933         Express installed
2934
2935         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
2936         are not installed. But this function doesn't need to be called when we
2937         already have a build available and are just trying to run the tests.
2938
2939         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
2940         because Visual Studio/VC++ Express aren't installed
2941
2942         Reviewed by Dave Hyatt.
2943
2944         * Scripts/webkitdirs.pm:
2945         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
2946         it is not needed by this function. Also added a FIXME.
2947
2948         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
2949         relying on determineConfigurationForVisualStudio doing it.
2950
2951 2010-11-19  Hayato Ito  <hayato@chromium.org>
2952
2953         Reviewed by Shinichiro Hamaji.
2954
2955         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
2956
2957         https://bugs.webkit.org/show_bug.cgi?id=49812
2958
2959         * Scripts/webkitpy/layout_tests/driver_test.py:
2960         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2961         * Scripts/webkitpy/layout_tests/port/base.py:
2962         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2963         * Scripts/webkitpy/layout_tests/port/chromium.py:
2964         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2965         * Scripts/webkitpy/layout_tests/port/test.py:
2966         * Scripts/webkitpy/layout_tests/port/webkit.py:
2967         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2968         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2969
2970 2010-11-22  Hayato Ito  <hayato@chromium.org>
2971
2972         Reviewed by Tony Chang.
2973
2974         [NRWT] Retry a few times in reading a png image to avoid a race condition.
2975
2976         https://bugs.webkit.org/show_bug.cgi?id=49924
2977
2978         * Scripts/webkitpy/layout_tests/port/chromium.py:
2979
2980 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
2981
2982         Reviewed by Kenneth Rohde Christiansen.
2983
2984         Fix EWebLauncher zoom discretization
2985         https://bugs.webkit.org/show_bug.cgi?id=49810
2986
2987         * EWebLauncher/main.c:
2988         (nearest_zoom_level_get):
2989         (zoom_level_set):
2990         (on_load_finished):
2991         (on_key_down):
2992
2993 2010-11-21  Sam Weinig  <sam@webkit.org>
2994
2995         Rubber-stamped by Dan Bernstein.
2996
2997         Fix ~300 WebKit2 tests by enabling developer extras preference.
2998
2999         * WebKitTestRunner/TestController.cpp:
3000         (WTR::TestController::resetStateToConsistentValues):
3001
3002 2010-11-21  Sam Weinig  <sam@webkit.org>
3003
3004         Reviewed by Dan Bernstein.
3005
3006         Textareas should be resizable by default
3007         https://bugs.webkit.org/show_bug.cgi?id=49892
3008
3009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3010         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3011         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3012         Add preferences test.
3013
3014 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3015
3016         Reviewed by Tony Chang.
3017
3018         Rebaseline server: checksum-only differences and prefetching
3019         https://bugs.webkit.org/show_bug.cgi?id=49841
3020         
3021         Add support for image test results where the only difference is in the
3022         checksum.
3023         
3024         Add prefetching of the image results from the next test.
3025         
3026         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3027         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3028         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3029
3030 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3031
3032         Reviewed by Tony Chang.
3033
3034         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3035
3036         Add the 'worker number' and 'worker name' concepts to the 
3037         TestShellThread objects, and move test_types and test_args from
3038         the TestRunner to the TestShellThread.
3039
3040         https://bugs.webkit.org/show_bug.cgi?id=49768
3041
3042         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3043         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3044
3045 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3046
3047         Reviewed by Ojan Vafai.
3048
3049         Do some minor cleanup and bug fixing.
3050
3051         https://bugs.webkit.org/show_bug.cgi?id=49777
3052
3053         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3054         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3055
3056 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3057
3058         Reviewed by Ojan Vafai.
3059
3060         nrwt - config.build_directory() is busted
3061
3062         Fixes a typo that was causing us to usually return the top level
3063         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3064         bug was hidden by test stubs that were too simplistic :(.
3065
3066         https://bugs.webkit.org/show_bug.cgi?id=49815
3067
3068         * Scripts/webkitpy/common/system/executive_mock.py:
3069         * Scripts/webkitpy/layout_tests/port/config.py:
3070         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3071
3072 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3073
3074         Reviewed by Adam Roben.
3075
3076         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3077         https://bugs.webkit.org/show_bug.cgi?id=49819
3078
3079         * DumpRenderTree/DumpRenderTree.sln:
3080         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3081         * DumpRenderTree/win/DumpRenderTree.vcproj:
3082         * DumpRenderTree/win/ImageDiff.vcproj:
3083         * FindSafari/FindSafari.vcproj:
3084         * MiniBrowser/MiniBrowser.vcproj:
3085         * TestWebKitAPI/win/TestWebKitAPI.sln:
3086         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3087         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3088         * WebKitAPITest/WebKitAPITest.vcproj:
3089         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3090         * WebKitTestRunner/win/InjectedBundle.vcproj:
3091         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3092         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3093         * WinLauncher/WinLauncher.vcproj:
3094         * record-memory-win/record-memory-win.vcproj:
3095
3096 2010-11-19  Adam Roben  <aroben@apple.com>
3097
3098         Add some more Windows slaves
3099
3100         This is probably more than we will be using in the immediate future,
3101         but having some extra slave names makes experimenting with different
3102         configurations easier.
3103
3104         Reviewed by Jon Honeycutt.
3105
3106         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3107         Windows slaves and distributed them among the three different Test
3108         builders.
3109
3110 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3111
3112         Reviewed by Ojan Vafai.
3113
3114         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3115         https://bugs.webkit.org/show_bug.cgi?id=49702
3116
3117         Re-landing r72357 with a test fix.
3118
3119         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3120         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3121         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3122
3123 2010-11-19  Avi Drissman  <avi@google.com>
3124
3125         Reviewed by Antonio Gomes.
3126
3127         Complete support for Unix editing mode
3128         https://bugs.webkit.org/show_bug.cgi?id=49757
3129
3130         * DumpRenderTree/LayoutTestController.cpp:
3131         (setEditingBehaviorCallback):
3132         * DumpRenderTree/chromium/LayoutTestController.cpp:
3133         (LayoutTestController::setEditingBehavior):
3134
3135 2010-11-19  Adam Roben  <aroben@apple.com>
3136
3137         Fix run-javascriptcore-tests when there's a space in the path to
3138         testapi
3139
3140         Reviewed by Sam Weinig.
3141
3142         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3143         system() to force it to interpret spaces in the path correctly.
3144
3145 2010-11-19  Adam Roben  <aroben@apple.com>
3146
3147         Update scripts for .exe name changes after r72327
3148
3149         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3150
3151         Reviewed by Sam Weinig.
3152
3153         * Scripts/run-javascriptcore-tests:
3154         (testapiPath):
3155
3156         * Scripts/sunspider-compare-results:
3157         (pathToBuiltJSC):
3158
3159         * Scripts/webkitdirs.pm:
3160         (jscPath):
3161         (safariPath):
3162
3163 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3164
3165         Reviewed by Darin Adler.
3166
3167         Normalize Cairo/CFLite project/solution configuration names
3168         https://bugs.webkit.org/show_bug.cgi?id=49818
3169
3170         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3171         * DumpRenderTree/win/DumpRenderTree.vcproj:
3172         * DumpRenderTree/win/ImageDiff.vcproj:
3173         * MiniBrowser/MiniBrowser.vcproj:
3174         * TestWebKitAPI/win/TestWebKitAPI.sln:
3175         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3176         * WebKitAPITest/WebKitAPITest.vcproj:
3177         * WebKitTestRunner/win/InjectedBundle.vcproj:
3178         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3179         * WinLauncher/WinLauncher.vcproj:
3180         * Scripts/webkitdirs.pm: Updated cairo build configs.
3181
3182 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3183
3184         Reviewed by Adam Roben.
3185
3186         Windows vcproj configuration names should be normalized across projects
3187         https://bugs.webkit.org/show_bug.cgi?id=49776
3188
3189         * DumpRenderTree/DumpRenderTree.sln:
3190         * FindSafari/FindSafari.vcproj:
3191         * TestWebKitAPI/win/TestWebKitAPI.sln:
3192         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3193         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3194         * WebKitAPITest/WebKitAPITest.vcproj:
3195         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3196         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3197         * WebKitTestRunner/WebKitTestRunner.sln:
3198         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3199         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3200         * record-memory-win/record-memory-win.vcproj:
3201
3202 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3203
3204         Build fix - as per DRT-mac, always enabled developer extras,
3205         in win/qt/gtk DRT.
3206
3207         This is necessary to enable rich exception messages to be generated
3208         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3209
3210         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3211         (shouldEnableDeveloperExtras):
3212         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3213         (WebCore::shouldEnableDeveloperExtras):
3214         * DumpRenderTree/win/DumpRenderTree.cpp:
3215         (shouldEnableDeveloperExtras):
3216
3217 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3218
3219         Unreviewed, rolling out r72357.
3220         http://trac.webkit.org/changeset/72357
3221         https://bugs.webkit.org/show_bug.cgi?id=49784
3222
3223         It broke test-webkitpy tests since the patch didn't have the
3224         corresponding test update (Requested by kinuko on #webkit).
3225
3226         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3227         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3228
3229 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3230
3231         Reviewed by Tony Chang.
3232
3233         Rebaseline server: add rebaseline queue
3234         https://bugs.webkit.org/show_bug.cgi?id=49763
3235         
3236         Add a UI queue (a multi-item <select>) where tests to be baselined
3237         can be enqueued (also supports basic removal). A queue is used instead
3238         of immediately doing rebaselines since SCM operations can take a while.
3239         It's better to go through lots of tests quickly to mark them as
3240         needing rebaselining and then batch the SCM operations.
3241         
3242         Also adds a simple log where results can be displayed.
3243
3244         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3245         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3246         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3247         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3248         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3249         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3250
3251 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3252
3253         Reviewed by Oliver Hunt.
3254
3255         Bug 49708 - Stop recompiling functions to regenerate exception info.
3256
3257         Instead only hold info as necessary – keep divot info is the inspector
3258         is enabled, line number info is debugging or profiling, and handler
3259         info for functions with try/catch.
3260
3261         * DumpRenderTree/mac/DumpRenderTree.mm:
3262         (shouldEnableDeveloperExtras):
3263             - always enable the developer tools from DRT, to ensure we
3264               produce rich error messages on JavaScript exceptions.
3265
3266 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3267
3268         Reviewed by Ojan Vafai.
3269
3270         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3271         https://bugs.webkit.org/show_bug.cgi?id=49702
3272
3273         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3274         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3275
3276 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3277
3278         Reviewed by Tony Chang.
3279
3280         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3281
3282         Create the first version of the 'message_broker' package. This
3283         class will encapsulate all of the threading/multiprocessing and
3284         message-sending details for the communication between the
3285         'manager' object and the 'worker' objects. For the moment, it
3286         just holds some routines and tests for logging thread stacks.
3287
3288         There should be no functional changes in this patch, just moving stuff
3289         around.
3290
3291         https://bugs.webkit.org/show_bug.cgi?id=49707
3292
3293         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3294         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3295         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3296         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3297         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3298         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3299
3300 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3301
3302         Reviewed by Adam Roben.
3303
3304         Remove leftover Windows Debug_Internal configurations
3305         https://bugs.webkit.org/show_bug.cgi?id=49758
3306
3307         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3308         * DumpRenderTree/win/DumpRenderTree.vcproj:
3309         * DumpRenderTree/win/ImageDiff.vcproj:
3310         * MiniBrowser/MiniBrowser.vcproj:
3311         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3312         * WebKitAPITest/WebKitAPITest.vcproj:
3313         * WebKitTestRunner/win/InjectedBundle.vcproj:
3314         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3315         * WinLauncher/WinLauncher.vcproj:
3316
3317 2010-11-18  Adam Roben  <aroben@apple.com>
3318
3319         Add three new Windows XP build slaves
3320
3321         Reviewed by Steve Falkenburg.
3322
3323         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3324         new slaves, and added them to the Windows XP Debug (Tests) builder.
3325
3326 2010-11-18  Daniel Bates  <dbates@rim.com>
3327
3328         Reviewed by Adam Roben.
3329
3330         update-webkit-support-libs should fall back to existing
3331         WebKitSupportLibrary version if there is no internet connectivity
3332         https://bugs.webkit.org/show_bug.cgi?id=49503
3333
3334         Fall back to existing support libraries (if present) when there is
3335         no internet connection.
3336
3337         Currently, update-webkit-support-libs dies with an "out-of-date"
3338         error when there is no internet connection because it cannot
3339         retrieve versioning information from developer.apple.com. Because
3340         update-webkit-support-libs fails, build-webkit fails. Instead,
3341         if there is no internet connection and the support libraries are
3342         present then we should warn the user and exit() with success so
3343         that build-webkit can work without an internet connection.
3344
3345         * Scripts/update-webkit-support-libs:
3346
3347 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3348
3349         Reviewed by Adam Roben.
3350
3351         Debug_Internal Windows configuration is unnecessary, should be removed
3352         https://bugs.webkit.org/show_bug.cgi?id=49753
3353
3354         * DumpRenderTree/win/DumpRenderTree.cpp:
3355         * MiniBrowser/win/stdafx.h:
3356         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3357         * WebKitTestRunner/win/TestControllerWin.cpp:
3358
3359 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3360
3361         Reviewed by Adam Roben.
3362
3363         Clean up vcproj errors
3364         https://bugs.webkit.org/show_bug.cgi?id=49741
3365
3366         * MiniBrowser/MiniBrowser.vcproj:
3367         * WebKitAPITest/WebKitAPITest.vcproj:
3368         * WebKitTestRunner/win/InjectedBundle.vcproj:
3369         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3370
3371 2010-11-18  Hayato Ito  <hayato@chromium.org>
3372
3373         Reviewed by Shinichiro Hamaji.
3374
3375         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
3376         which is caused by r72249.
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=49751
3379
3380         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3381
3382 2010-11-18  Adam Roben  <aroben@apple.com>
3383
3384         Implement layoutTestController.waitForPolicyDelegate on Windows
3385
3386         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
3387
3388         Reviewed by Simon Fraser.
3389
3390         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3391         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
3392         code from LayoutTestControllerMac.mm.
3393
3394 2010-11-18  Hayato Ito  <hayato@chromium.org>
3395
3396         Reviewed by Shinichiro Hamaji.
3397
3398         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
3399
3400         https://bugs.webkit.org/show_bug.cgi?id=49740
3401
3402         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3403
3404 2010-11-18  Tony Chang  <tony@chromium.org>
3405
3406         Reviewed by Adam Barth.
3407
3408         run platform/chromium/plugins/refcount-leaks.html on all platforms
3409         https://bugs.webkit.org/show_bug.cgi?id=49485
3410
3411         Add PluginObject.testObjectCount which returns the number of allocated
3412         TestObjects. Add PluginObject.testCreateTestObject which allocates
3413         and returns a TestObject.
3414
3415         Add TestObject.refCount which returns the number of refs on the
3416         TestObject.
3417
3418         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3419         (pluginGetProperty):
3420         (pluginInvoke):
3421         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3422         (getTestObjectCount):
3423         (testAllocate):
3424         (testDeallocate):
3425         (testGetProperty):
3426         (testScriptObjectInvoke): Release a ref to a plugin object that was
3427             previously leaked.
3428         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
3429
3430 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3431
3432         Reviewed by Adam Roben.
3433
3434         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
3435         https://bugs.webkit.org/show_bug.cgi?id=49711
3436
3437         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
3438         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
3439         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
3440         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3441         * record-memory-win/record-memory-win-common.vsprops: Added.
3442         * record-memory-win/record-memory-win.vcproj:
3443
3444 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
3445
3446         Reviewed by Csaba Osztrogonác.
3447
3448         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
3449
3450         * MiniBrowser/qt/BrowserWindow.cpp:
3451         (BrowserWindow::updateUserAgentList):
3452
3453 2010-11-17  Adam Roben  <aroben@apple.com>
3454
3455         Don't trigger Windows builds when chromium-win test results change
3456
3457         Reviewed by Mark Rowe.
3458
3459         * Scripts/webkitpy/common/config/build.py:
3460         (_should_file_trigger_build): Changed the regular expression used to
3461         search for directory names to only consider full directory names,
3462         rather than matching directory names where the string we care about is
3463         a suffix of the name.
3464
3465         * Scripts/webkitpy/common/config/build_unittest.py:
3466         (ShouldBuildTest): Added a test.
3467
3468 2010-11-17  Hayato Ito  <hayato@chromium.org>
3469
3470         Reviewed by Shinichiro Hamaji.
3471
3472         Remove a uri member from TestInput class.
3473
3474         https://bugs.webkit.org/show_bug.cgi?id=49691
3475
3476         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3477         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3478
3479 2010-11-17  Adam Roben  <aroben@apple.com>
3480
3481         Move FindSafari's settings into a vsprops file
3482
3483         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
3484
3485         Reviewed by Steve Falkenburg.
3486
3487         * FindSafari/FindSafari.vcproj:
3488         * FindSafari/FindSafariCommon.vsprops: Added.
3489
3490 2010-11-17  Adam Roben  <aroben@apple.com>
3491
3492         Use a minimum font size of 0 in DRT on Windows
3493
3494         This is the Windows equivalent of r72164.
3495
3496         Rubber-stamped by Dave Hyatt.
3497
3498         * DumpRenderTree/win/DumpRenderTree.cpp:
3499         (resetDefaultsToConsistentValues):
3500
3501 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
3502
3503         Reviewed by Andreas Kling.
3504
3505         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
3506         https://bugs.webkit.org/show_bug.cgi?id=49639
3507
3508         * Scripts/webkitpy/common/checkout/scm.py:
3509
3510 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
3511
3512         Reviewed by Tony Chang.
3513
3514         Rebaseline server: add loupe for image diffs
3515         https://bugs.webkit.org/show_bug.cgi?id=49692
3516         
3517         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
3518         enlarged area of the expected, actual and diff images side by side.
3519
3520         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3521         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
3522         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3523         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3524
3525 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3526
3527         Reviewed by Adam Roben.
3528
3529         WebKitLauncherWin should use vsprops for shared build settings
3530         https://bugs.webkit.org/show_bug.cgi?id=49696
3531
3532         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3533         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
3534
3535 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3536
3537         Reviewed by Adam Roben.
3538
3539         WinLauncher should use vsprops for shared build settings
3540         https://bugs.webkit.org/show_bug.cgi?id=49695
3541
3542         * WinLauncher/WinLauncher.cpp:
3543         (_tWinMain):
3544         (PrintView):
3545         (WndProc):
3546         (MyEditProc):
3547         * WinLauncher/WinLauncher.vcproj:
3548         * WinLauncher/WinLauncherCommon.vsprops: Added.
3549
3550 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3551
3552         Delete unused file unintentionally added in last change.
3553
3554         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
3555
3556 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3557
3558         Reviewed by Adam Roben.
3559
3560         DumpRenderTree on Windows should use a vsprops file for shared project settings
3561         https://bugs.webkit.org/show_bug.cgi?id=49690
3562
3563         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3564         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
3565         * DumpRenderTree/win/DumpRenderTree.vcproj:
3566         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
3567         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
3568         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
3569         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
3570         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
3571         * DumpRenderTree/win/ImageDiff.vcproj:
3572         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
3573
3574 2010-11-17  Hayato Ito  <hayato@chromium.org>
3575
3576         Refactor TestTypeBase.compare_output().
3577
3578         Introduce a TestOutput class and update compare_output() of each test
3579         types so that they can take both actual and expected TestOutput objects.
3580
3581         https://bugs.webkit.org/show_bug.cgi?id=49431
3582