<http://webkit.org/b/48224> build-webkit: add support for --meter-tag switch
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-26  David Kilzer  <ddkilzer@apple.com>
2
3         <http://webkit.org/b/48224> build-webkit: add support for --meter-tag switch
4
5         Reviewed by Csaba Osztrogonác.
6
7         * Scripts/build-webkit: Added support for --meter-tag switch.
8         It should have been added with r60820.
9
10 2010-10-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
11
12         Reviewed by Dumitru Daniliuc.
13
14         check-webkit-style fails on operator+=, operator-=, ... methods
15         https://bugs.webkit.org/show_bug.cgi?id=48258
16
17         * Scripts/webkitpy/style/checkers/cpp.py: Added exceptions
18         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit-tests
19
20 2010-10-26  Ojan Vafai  <ojan@chromium.org>
21
22         Reviewed by Tony Chang.
23
24         remove DEFER support from new-run-webkit-tests
25         https://bugs.webkit.org/show_bug.cgi?id=48387
26
27         DEFER was needed when we were trying to ship Chrome beta.
28         Now it's just extra complication.
29
30         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
31         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
32         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
33         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
34         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
35         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
36
37 2010-10-26  Eric Seidel  <eric@webkit.org>
38
39         Unreviewed.  Adding import with_statement to fix python 2.5.
40
41         Teach webkit-patch how to read credentials from the environment
42         https://bugs.webkit.org/show_bug.cgi?id=48275
43
44         * Scripts/webkitpy/common/net/credentials_unittest.py:
45          - import with_statement to fix python 2.5.
46
47 2010-10-26  Alexey Proskuryakov  <ap@apple.com>
48
49         Reviewed by Sam Weinig.
50
51         https://bugs.webkit.org/show_bug.cgi?id=48375
52         <rdar://problem/8392724> Need delegate calls in PageLoaderClient to indicate if we have
53         loaded insecure content
54
55         Updated for WebKit2 changes.
56
57         * MiniBrowser/mac/BrowserWindowController.m:
58         (didDisplayInsecureContentForFrame):
59         (didRunInsecureContentForFrame):
60         (-[BrowserWindowController awakeFromNib]):
61         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
62         (WTR::InjectedBundlePage::InjectedBundlePage):
63         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
64         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
65         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
66         * WebKitTestRunner/TestController.cpp:
67         (WTR::TestController::initialize):
68
69 2010-10-26  Adam Roben  <aroben@apple.com>
70
71         Clear up confusion between "3D rendering" and "accelerated compositing"
72
73         WebKit has no software-based 3D rendering implementation, so 3D
74         rendering can only be enabled when accelerated compositing is. But DRT
75         was falsely reporting that 3D rendering was available on machines that
76         don't support accelerated compositing, leading to much confusion.
77
78         Reviewed by Darin Adler.
79
80         Fixes <http://webkit.org/b/48370> REGRESSION (r70540): Many
81         transforms/3d tests are failing on the XP bots
82
83         * DumpRenderTree/win/DumpRenderTree.cpp:
84         (main): When ENABLE(3D_RENDERING) is turned on, only report that 3D
85         rendering is available when acclerated compositing is also available.
86
87         * Scripts/old-run-webkit-tests: Skip tests that use the
88         -webkit-transform-3d media query when 3D rendering is disabled,
89         rather than when accelerated compositing is disabled.
90
91 2010-10-26  Eric Seidel  <eric@webkit.org>
92
93         Reviewed by Ojan Vafai.
94
95         Remove rietveld code now that it's unused
96         https://bugs.webkit.org/show_bug.cgi?id=48359
97
98         Was cool that we added this support, but now that it's
99         not used it makes little sense to keep it around.
100         We can always restore this code from SVN if we need it.
101
102         * Scripts/webkitpy/common/config/__init__.py:
103         * Scripts/webkitpy/common/net/bugzilla.py:
104         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
105         * Scripts/webkitpy/common/net/rietveld.py: Removed.
106         * Scripts/webkitpy/common/net/rietveld_unittest.py: Removed.
107         * Scripts/webkitpy/thirdparty/__init__.py:
108         * Scripts/webkitpy/tool/commands/download.py:
109         * Scripts/webkitpy/tool/commands/download_unittest.py:
110         * Scripts/webkitpy/tool/commands/queues.py:
111         * Scripts/webkitpy/tool/commands/queues_unittest.py:
112         * Scripts/webkitpy/tool/main.py:
113         * Scripts/webkitpy/tool/mocktool.py:
114         * Scripts/webkitpy/tool/steps/__init__.py:
115         * Scripts/webkitpy/tool/steps/postcodereview.py: Removed.
116
117 2010-10-26  Anders Carlsson  <andersca@apple.com>
118
119         Reviewed by Sam Weinig.
120
121         pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client
122         https://bugs.webkit.org/show_bug.cgi?id=48366
123         <rdar://problem/8595202>
124
125         * MiniBrowser/mac/BrowserWindowController.m:
126         (-[BrowserWindowController awakeFromNib]):
127         * WebKitTestRunner/TestController.cpp:
128         (WTR::createOtherPage):
129         (WTR::TestController::initialize):
130
131 2010-10-26  Eric Seidel  <eric@webkit.org>
132
133         Reviewed by Tony Chang.
134
135         Teach webkit-patch how to read credentials from the environment
136         https://bugs.webkit.org/show_bug.cgi?id=48275
137
138         This makes it possible for svn users to have their bugzilla credentials
139         stored in their environment instead of typing them every time.
140
141         We need this for making it easy to run the win-ews bot (which currently
142         uses svn instead of git).
143
144         * Scripts/webkitpy/common/net/credentials.py:
145         * Scripts/webkitpy/common/net/credentials_unittest.py:
146
147 2010-10-26  Kenichi Ishibashi  <bashi@google.com>
148
149         Reviewed by Kent Tamura.
150
151         Input Method inserts conversion candidates unexpectedly
152         https://bugs.webkit.org/show_bug.cgi?id=46868
153
154         Adds setComposition() to TextInputController to make DRT emulate
155         an input method behavior.
156
157         * DumpRenderTree/chromium/TextInputController.cpp:
158         (TextInputController::TextInputController):
159         (TextInputController::setComposition): Added.
160         * DumpRenderTree/chromium/TextInputController.h:
161
162 2010-10-26  Simon Fraser  <simon.fraser@apple.com>
163
164         Reviewed by Sam Weinig.
165
166         Support layoutTestController.layerTreeAsText in WebKitTestRunner
167         https://bugs.webkit.org/show_bug.cgi?id=42145
168         
169         Implement layerTreeAsText() in WebKitTestRunner.
170
171         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
172         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
173         (WTR::LayoutTestController::layerTreeAsText):
174         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
175
176 2010-10-26  Adam Barth  <abarth@webkit.org>
177
178         Reviewed by Eric Seidel.
179
180         webkit-patch rollout produces incorrect patch when using svn move
181         https://bugs.webkit.org/show_bug.cgi?id=48244
182
183         We need to flush our caches when we modify the working copy.
184
185         * Scripts/webkitpy/tool/steps/revertrevision.py:
186
187 2010-10-26  Eric Seidel  <eric@webkit.org>
188
189         Reviewed by Adam Barth.
190
191         commit-queue flaky test message can list the same author more than once
192         https://bugs.webkit.org/show_bug.cgi?id=48268
193
194         tonikitoo reported to me over IRC this morning that he's seen
195         the commit-queue report flaky tests with author lists like:
196         "adam, adam and adam", suggesting we're not uniquing authors
197         before writing the message.
198
199         I fixed the uniquing and added a bunch more unit testing.
200
201         * Scripts/webkitpy/tool/commands/queues.py:
202         * Scripts/webkitpy/tool/commands/queues_unittest.py:
203         * Scripts/webkitpy/tool/mocktool.py:
204
205 2010-10-26  Adam Roben  <aroben@apple.com>
206
207         Pull in the FeatureDefines*.vsprops files when building DRT
208
209         This ensures that various ENABLE() macros will get set correctly.
210         (Prior to r70320 we were picking up the ENABLE(3D_RENDERING) flag
211         through wtf/Platform.h.)
212
213         Fixes <http://webkit.org/b/48343> REGRESSION (r70320): DumpRenderTree
214         says 3D_RENDERING is disabled even when it is enabled
215
216         Reviewed by Ada Chan.
217
218         * DumpRenderTree/win/DumpRenderTree.vcproj: Added
219         FeaturesDefines*.vsprops to all configurations.
220
221         * DumpRenderTree/win/DumpRenderTreeWin.h: Touched to force a rebuild.
222
223 2010-10-26  Søren Gjesse  <sgjesse@chromium.org>
224
225         Reviewed by Dimitri Glazkov.
226
227         Added options --multiple-loads and --js-flags to chromium DumpRenderTree. The option --multiple-loads=X
228         is used to have DumpRenderTree load each test it runs X times. To be able to have more fine-grained control
229         of how the JavaScript engine behaves for each load the flag --js-flags can specify a list of flag-sets like this
230
231           --js-flags="--xxx,--noxxx --yyy,--noyyy"
232
233         First load will run with --xxx, the second with --yyy and the third without any (the 'no' prefix is handled by
234         V8 to turn off the flag).
235
236         The changes to the Python test runner will be in a separate change.
237
238
239         * DumpRenderTree/chromium/DumpRenderTree.cpp:
240         (runTest):
241         (main):
242         * DumpRenderTree/chromium/TestShell.cpp:
243         (TestShell::TestShell):
244         (TestShell::runFileTest):
245         (TestShell::testFinished):
246         * DumpRenderTree/chromium/TestShell.h:
247         (TestShell::loadCount):
248         (TestShell::setLoadCount):
249         (TestShell::javaScriptFlagsForLoad):
250         (TestShell::setJavaScriptFlags):
251         (TestShell::setDumpWhenFinished):
252
253 2010-10-26  Adam Roben  <aroben@apple.com>
254
255         Skip more tests that depend on accelerated compositing when accelerated
256         compositing is disabled
257
258         Fixes <http://webkit.org/b/48329> Some tests fail when accelerated
259         compositing is disabled
260
261         Reviewed by John Sullivan.
262
263         * Scripts/old-run-webkit-tests: Added more tests to skip when
264         accelerated compositing is disable. The tests all have output that
265         changes depending on whether accelerated compositing is enabled.
266
267 2010-10-25  Eric Seidel  <eric@webkit.org>
268
269         Reviewed by Adam Barth.
270
271         webkit-patch should clean up svn locks when passed --force-clean
272         https://bugs.webkit.org/show_bug.cgi?id=48269
273
274         * Scripts/webkitpy/common/checkout/scm.py:
275
276 2010-10-25  Anders Carlsson  <andersca@apple.com>
277
278         Reviewed by Adam Roben.
279
280         Add a pageDidScroll BundleUIClient callback
281         https://bugs.webkit.org/show_bug.cgi?id=48260
282         <rdar://problem/8531159>
283
284         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
285         (WTR::InjectedBundlePage::InjectedBundlePage):
286
287 2010-10-25  Johnny Ding  <jnd@chromium.org>
288
289         Reviewed by Tony Chang.
290
291         Dump the gesture status of frame in frame load callbacks in DumpRenderTree
292         by adding a new method dumpUserGestureInFrameLoadCallbacks.
293         Now only dump the gesture status in "DidStartProvisionalLoad" callback.
294         https://bugs.webkit.org/show_bug.cgi?id=47849
295
296         * DumpRenderTree/LayoutTestController.cpp:
297         (LayoutTestController::LayoutTestController):
298         (dumpUserGestureInFrameLoadCallbacksCallback):
299         (LayoutTestController::staticFunctions):
300         * DumpRenderTree/LayoutTestController.h:
301         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
302         (LayoutTestController::setDumpUserGestureInFrameLoadCallbacks):
303         * DumpRenderTree/chromium/LayoutTestController.cpp:
304         (LayoutTestController::LayoutTestController):
305         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
306         (LayoutTestController::reset):
307         * DumpRenderTree/chromium/LayoutTestController.h:
308         (LayoutTestController::shouldDumpUserGestureInFrameLoadCallbacks):
309         (LayoutTestController::setShouldDumpUserGestureInFrameLoadCallbacks):
310         * DumpRenderTree/chromium/TestShell.h:
311         (TestShell::shouldDumpUserGestureInFrameLoadCallbacks):
312         * DumpRenderTree/chromium/WebViewHost.cpp:
313         (WebViewHost::didStartProvisionalLoad):
314         (WebViewHost::printFrameUserGestureStatus):
315         * DumpRenderTree/chromium/WebViewHost.h:
316         * DumpRenderTree/mac/FrameLoadDelegate.mm:
317         (-[WebFrame _drt_printFrameUserGestureStatus]):
318         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
319         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
320         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
321         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
322         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
323         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
324         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
325         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
326         (LayoutTestController::reset):
327         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
328         * DumpRenderTree/qt/LayoutTestControllerQt.h:
329
330 2010-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
331
332         Unreviewed, rolling out r70442.
333         http://trac.webkit.org/changeset/70442
334         https://bugs.webkit.org/show_bug.cgi?id=48248
335
336         http locking doesn't work on Windows (Requested by Ossy on
337         #webkit).
338
339         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
340         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
341
342 2010-10-25  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
343
344         Reviewed by Ojan Vafai.
345
346         Make http locking default in NRWT.
347         https://bugs.webkit.org/show_bug.cgi?id=48053
348
349         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
350         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
351
352 2010-10-25  David Kilzer  <ddkilzer@apple.com>
353
354         <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
355         (Re-landing r70413 after Qt minimal buildfix: r70440.)
356
357         Reviewed by Kenneth Rohde Christiansen.
358
359         * Scripts/build-webkit: Added support for --progress-tag switch.
360         It should have been added with r57051.
361
362 2010-10-24  Adam Barth  <abarth@webkit.org>
363
364         Reviewed by David Kilzer.
365
366         webkit-patch upload fails when the patch removes a file
367         https://bugs.webkit.org/show_bug.cgi?id=48187
368
369         We need to use "--" to separate file names from the rest of the
370         command.
371
372         * Scripts/webkitpy/common/checkout/scm.py:
373
374 2010-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
375
376         Unreviewed, rolling out r70413.
377         http://trac.webkit.org/changeset/70413
378         https://bugs.webkit.org/show_bug.cgi?id=48210
379
380         It broke Qt minimal build (Requested by Ossy on #webkit).
381
382         * Scripts/build-webkit:
383
384 2010-10-24  Yi Shen  <yi.4.shen@nokia.com>
385
386         Reviewed by Andreas Kling.
387
388         [Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu
389         https://bugs.webkit.org/show_bug.cgi?id=48141
390
391         * QtTestBrowser/launcherwindow.cpp:
392         (LauncherWindow::init):
393         (LauncherWindow::initializeView):
394         (LauncherWindow::toggleWebView):
395
396 2010-10-24  Daniel Bates  <dbates@rim.com>
397
398         Reviewed by David Kilzer.
399
400         Fix Perl uninitialized warnings in VCSUtils::svnStatus()
401         and VCSUtils::removeEOL().
402         https://bugs.webkit.org/show_bug.cgi?id=48196
403
404         VCSUtils::svnStatus() concatenates the output of svn status with
405         a new line character and svn status may return no output (say for
406         a file that has not been added, deleted, or modified). We should
407         only concatenate the output of svn status if there is some.
408
409         Also, VCSUtils::removeEOL() should ensure that its argument
410         is initialized before performing a string substitution.
411
412         * Scripts/VCSUtils.pm:
413           - Modified removeEOL() to return "" if its argument is undefined.
414           - Exported removeEOL() so that it can be tested. 
415         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Added.
416
417 2010-10-24  David Kilzer  <ddkilzer@apple.com>
418
419         <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
420
421         Reviewed by Kenneth Rohde Christiansen.
422
423         * Scripts/build-webkit: Added support for --progress-tag switch.
424         It should have been added with r57051.
425
426 2010-10-24  David Kilzer  <ddkilzer@apple.com>
427
428         <http://webkit.org/b/48184> build-webkit: reformat support variables for better maintainability
429
430         Reviewed by Daniel Bates.
431
432         * Scripts/build-webkit: Alphabetized the @features array based
433         on the name of the feature.  Reformatted the list of support
434         variables so that they match the order of @features, and so that
435         each has its own line.  This makes it easy to add new variables
436         in the correct order.
437
438 2010-10-23  Eric Seidel  <eric@webkit.org>
439
440         Reviewed by Adam Barth.
441
442         EWS never removes invalid patch ids
443         https://bugs.webkit.org/show_bug.cgi?id=48173
444
445         This is just sticking another finger in the dam.
446         However this adds more unit testing which will help
447         us make sure we're always releasing patches once we
448         redesign the release_patch API and call these from
449         a more central place.
450
451         * Scripts/webkitpy/tool/commands/queues.py:
452         * Scripts/webkitpy/tool/commands/queues_unittest.py:
453         * Scripts/webkitpy/tool/mocktool.py:
454          - Added the ability to request invalid patches.
455            Log a warning message to make sure we don't ever have
456            tests use invalid patch fetches by mistake.
457
458 2010-10-23  Dan Bernstein  <mitz@apple.com>
459
460         Build fix. Add stub implementations for required NSDraggingInfo methods.
461
462         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
463         (-[DumpRenderTreeDraggingInfo draggingFormation]):
464         (-[DumpRenderTreeDraggingInfo setDraggingFormation:]):
465         (-[DumpRenderTreeDraggingInfo animatesToDestination]):
466         (-[DumpRenderTreeDraggingInfo setAnimatesToDestination:]):
467         (-[DumpRenderTreeDraggingInfo numberOfValidItemsForDrop]):
468         (-[DumpRenderTreeDraggingInfo setNumberOfValidItemsForDrop:]):
469         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
470
471 2010-10-23  David Kilzer  <ddkilzer@apple.com>
472
473         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
474
475         Reviewed by Sam Weinig.
476
477         The only method defined in WebHTMLRepresentationInternal.h is
478         also defined in WebHTMLRepresentation.h, so use that instead.
479
480         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Removed.
481         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Switched to use
482         WebHTMLRepresentation.h.
483
484 2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
485
486         Unreviewed, rolling out r70367.
487         http://trac.webkit.org/changeset/70367
488         https://bugs.webkit.org/show_bug.cgi?id=48176
489
490         It made 8-10 tests crash on Qt bot (Requested by Ossy on
491         #webkit).
492
493         * DumpRenderTree/LayoutTestController.cpp:
494         (setCustomPolicyDelegateCallback):
495         * DumpRenderTree/LayoutTestController.h:
496         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
497         (LayoutTestController::setCustomPolicyDelegate):
498         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
499         (LayoutTestController::setCustomPolicyDelegate):
500         * DumpRenderTree/mac/PolicyDelegate.h:
501         * DumpRenderTree/mac/PolicyDelegate.mm:
502         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
503         (-[PolicyDelegate setPermissive:]):
504         (-[PolicyDelegate setControllerToNotifyDone:]):
505         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
506         (LayoutTestController::setCustomPolicyDelegate):
507         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
508         (LayoutTestController::setCustomPolicyDelegate):
509
510 2010-10-22  Eric Seidel  <eric@webkit.org>
511
512         Reviewed by Adam Barth.
513
514         EWS never releases patches which fail to apply
515         https://bugs.webkit.org/show_bug.cgi?id=48171
516
517         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
518         * Scripts/webkitpy/tool/commands/queues.py:
519
520 2010-10-22  Eric Seidel  <eric@webkit.org>
521
522         Unreviewed.
523
524         Make the EWS queues restart themselves more often.
525         This matches the commit-queue.
526
527         * EWSTools/start-queue.sh:
528
529 2010-10-22  Eric Seidel  <eric@webkit.org>
530
531         Reviewed by Adam Barth.
532
533         commit-queue should not pass --quiet to subcommands now that the parent command does the reporting
534         https://bugs.webkit.org/show_bug.cgi?id=48165
535
536         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
537         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
538         * Scripts/webkitpy/tool/commands/queues_unittest.py:
539
540 2010-10-22  Mario Sanchez Prada  <msanchez@igalia.com>
541
542         Adding myself as a committer.
543
544         * Scripts/webkitpy/common/config/committers.py:
545
546 2010-10-20  Anders Carlsson  <andersca@apple.com>
547
548         Reviewed by Adam Barth and Darin Adler.
549
550         Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
551         https://bugs.webkit.org/show_bug.cgi?id=48014
552         <rdar://problem/8202716>
553         
554         * DumpRenderTree/LayoutTestController.cpp:
555         (setCustomPolicyDelegateCallback):
556         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
557
558         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
559         (LayoutTestController::setCustomPolicyDelegate):
560         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
561
562         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
563         (LayoutTestController::setCustomPolicyDelegate):
564         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
565
566         * DumpRenderTree/mac/PolicyDelegate.h:
567         * DumpRenderTree/mac/PolicyDelegate.mm:
568         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
569         If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second.
570
571         (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]):
572         Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond.
573         
574         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
575         (LayoutTestController::setCustomPolicyDelegate):
576         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
577
578         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
579         (LayoutTestController::setCustomPolicyDelegate):
580         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
581
582 2010-10-22  Sam Weinig  <sam@webkit.org>
583
584         Reviewed by Anders Carlsson.
585
586         Rename the InjectedBundle for TestWebKitAPI to InjectedBundleTestWebKitAPI.bundle
587
588         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
590         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
591         (TestWebKitAPI::Util::createInjectedBundlePath):
592
593 2010-10-22  Dirk Pranke  <dpranke@chromium.org>
594
595         Reviewed by Eric Seidel.
596
597         test-webkitpy fails when passed -v (or any other option)
598
599         Fix port/base_unittest to pass an explicit list of arguments
600         rather than accidentally picking up sys.argv.
601
602         https://bugs.webkit.org/show_bug.cgi?id=48071
603
604         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
605
606 2010-10-22  Brian Weinstein  <bweinstein@apple.com>
607
608         Windows build fix. Update the createNewPage callback to account for the new
609         arguments.
610
611         * MiniBrowser/win/BrowserView.cpp:
612         (createNewPage):
613
614 2010-10-22  Sam Weinig  <sam@webkit.org>
615
616         Reviewed by Anders Carlsson.
617
618         WebKit2 needs to pass the current event modifier flags when requesting a new window
619         https://bugs.webkit.org/show_bug.cgi?id=48140
620
621         * MiniBrowser/mac/BrowserWindowController.m:
622         (createNewPage):
623         * WebKitTestRunner/TestController.cpp:
624         (WTR::createOtherPage):
625         Update for new signature for the WKPageCreateNewPageCallback.
626
627 2010-10-22  Eric Seidel  <eric@webkit.org>
628
629         Unreviewed.  Just adding a test case.
630
631         The style-queue was not recognizing new patches.  It turns
632         out I had fixed this in an earlier change, but just not
633         deployed to queues.webkit.org.  As part of investigating why it
634         was broken, I wrote a test for my previous change which I'm now landing.
635
636         * QueueStatusServer/model/queues_unittest.py:
637
638 2010-10-22  Eric Seidel  <eric@webkit.org>
639
640         Reviewed by Adam Barth.
641
642         EWS does not need to process obsolete patches
643         https://bugs.webkit.org/show_bug.cgi?id=48093
644
645         This was an easy change, but to test it I had to pipe
646         real Attachment objects into the queue testing system.
647         Doing so revealed a whole bunch of bugs in our unit tests,
648         which I fixed as part of this patch.
649
650         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
651          - This is the actual code change.  This will not reduce the
652            backlog in the EWS queues much, but it will make rejections
653            much quicker for obsolete patches or closed bugs.
654         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
655          - Test my new code.
656          - Used a real attachment object and got rid of MockPatch
657          - Shared code between the mac-ews and cr-mac-ews tests.
658         * Scripts/webkitpy/tool/commands/queues_unittest.py:
659          - Can't use MockPatch anymore.
660          - Removing MockPatch found more bugs here!
661         * Scripts/webkitpy/tool/commands/queuestest.py:
662         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
663         * Scripts/webkitpy/tool/mocktool.py:
664          - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
665            is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.
666
667 2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
668
669         Unreviewed, rolling out r70301.
670         http://trac.webkit.org/changeset/70301
671         https://bugs.webkit.org/show_bug.cgi?id=48126
672
673         "Lang attribute layout tests failing" (Requested by satish on
674         #webkit).
675
676         * DumpRenderTree/LayoutTestController.cpp:
677         (setMockSpeechInputResultCallback):
678         * DumpRenderTree/LayoutTestController.h:
679         * DumpRenderTree/chromium/LayoutTestController.cpp:
680         (LayoutTestController::setMockSpeechInputResult):
681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
682         (LayoutTestController::setMockSpeechInputResult):
683         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
684         (LayoutTestController::setMockSpeechInputResult):
685         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
686         (LayoutTestController::setMockSpeechInputResult):
687         * DumpRenderTree/qt/LayoutTestControllerQt.h:
688         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
689         (LayoutTestController::setMockSpeechInputResult):
690         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
691         (LayoutTestController::setMockSpeechInputResult):
692
693 2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
694
695         Reviewed by Jeremy Orlow.
696
697         Added a second parameter to setMockSpeechInputResult for
698         the language used in speech input.
699         https://bugs.webkit.org/show_bug.cgi?id=47089
700
701         * DumpRenderTree/LayoutTestController.cpp:
702         (setMockSpeechInputResultCallback):
703         * DumpRenderTree/LayoutTestController.h:
704         * DumpRenderTree/chromium/LayoutTestController.cpp:
705         (LayoutTestController::setMockSpeechInputResult):
706         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
707         (LayoutTestController::setMockSpeechInputResult):
708         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
709         (LayoutTestController::setMockSpeechInputResult):
710         * DumpRenderTree/qt/LayoutTestControllerQt.h:
711         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
712         (LayoutTestController::setMockSpeechInputResult):
713         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
714         (LayoutTestController::setMockSpeechInputResult):
715         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
716         (LayoutTestController::setMockSpeechInputResult):
717
718 2010-10-21  MORITA Hajime  <morrita@google.com>
719
720         Reviewed by Kent Tamura.
721
722         [Win][DRT] should have LayoutTestController.hasSpellingMarker()
723         https://bugs.webkit.org/show_bug.cgi?id=47885
724
725         - Implemented LayoutTestController.hasSpellingMarker(),
726         - Added fake spellcheck implementation.
727
728         * DumpRenderTree/win/DumpRenderTree.cpp:
729         (main):
730         * DumpRenderTree/win/EditingDelegate.cpp:
731         (indexOfFirstWordCharacter):
732         (wordLength):
733         (EditingDelegate::checkSpellingOfString):
734         * DumpRenderTree/win/EditingDelegate.h:
735         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
736         (LayoutTestController::hasSpellingMarker):
737
738 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
739
740         Unreviewed. Re-enable test that was mistakenly disabled by r67974.
741
742         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
743
744 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
745
746         Unreviewed fix for rebaseline-chromium-webkit-tests.
747
748         Port.diff_image no longer has a tolerance parameter. Also, use
749         get_option('tolerance') which is safer if the options object doesn't
750         define a tolerance attribute (it doesn't for the one used in
751         rebaseline_chromium_webkit_tests).
752
753         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
754         * Scripts/webkitpy/layout_tests/port/webkit.py:
755         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
756
757 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
758
759         Reviewed by Ojan Vafai.
760
761         Add support for --tolerance in NRWT
762         https://bugs.webkit.org/show_bug.cgi?id=47959
763         
764         Add support for the --tolerance flag in NRWT. The Port.diff_image
765         signature shouldn't need a tolerance parameter (it's not set per test),
766         just have ports that use it (currently only WebKitPort) read it from 
767         the options object.
768
769         * Scripts/webkitpy/layout_tests/port/chromium.py:
770         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
771         * Scripts/webkitpy/layout_tests/port/test.py:
772         * Scripts/webkitpy/layout_tests/port/webkit.py:
773         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
774         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
775
776 2010-10-21  Eric Seidel  <eric@webkit.org>
777
778         Reviewed by Adam Barth.
779
780         Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
781         https://bugs.webkit.org/show_bug.cgi?id=48088
782
783         This is a first-pass.  Works, but we'll eventually
784         turn this on by default, refine the suggestion algorithm
785         and possibly move it to a different place in the upload step order.
786
787         * Scripts/webkitpy/common/checkout/api.py:
788         * Scripts/webkitpy/tool/commands/download_unittest.py:
789         * Scripts/webkitpy/tool/commands/upload.py:
790         * Scripts/webkitpy/tool/commands/upload_unittest.py:
791         * Scripts/webkitpy/tool/mocktool.py:
792         * Scripts/webkitpy/tool/steps/__init__.py:
793         * Scripts/webkitpy/tool/steps/options.py:
794
795 2010-10-21  Mario Sanchez Prada  <msanchez@igalia.com>
796
797         Reviewed by Chris Fleizach.
798
799         [GTK] Segfault while testing accessibility/iframe-bastardization.html
800         https://bugs.webkit.org/show_bug.cgi?id=30123
801
802         Check m_element before actually using it to get the parent.
803
804         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
805         (AccessibilityUIElement::parentElement): Add an extra check to
806         make sure m_element points to a valid value before actually using
807         it to get the parent. Also, assert ATK_IS_OBJECT(m_element).
808
809 2010-10-21  Anders Carlsson  <andersca@apple.com>
810
811         Reviewed by Adam Roben.
812
813         Crash evaluating JavaScript string that throws an exception
814         https://bugs.webkit.org/show_bug.cgi?id=48092
815         <rdar://problem/8487657>
816
817         Add a test that evaluates a JavaScript string that throws an exception and check that 
818         the callback is called.
819
820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
821         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added.
822         (TestWebKitAPI::didRunJavaScript):
823         (TestWebKitAPI::WebKit2_EvaluateJavaScript):
824         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
825
826 2010-10-21  Adam Roben  <aroben@apple.com>
827
828         Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
829         called
830
831         Test for <http://webkit.org/b/48086> <rdar://problem/8482944>
832         Silverlight doesn't repaint in WebKit2
833
834         Reviewed by Anders Carlsson.
835
836         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
837         (PluginTest::NPN_InvalidateRect): Added. Calls through to the browser.
838         (executeScript): Added. Asks the browser to evaluate the script.
839
840         (PluginTest::waitUntilDone):
841         (PluginTest::notifyDone):
842         Added. Calls through to layoutTestController.
843
844         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added
845         * NPN_InvalidateRect and waitUntilDone/notifyDone.
846
847         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added.
848         (TemporaryWindowMover::moveSucceeded):
849         (TemporaryWindowMover::TemporaryWindowMover):
850         (TemporaryWindowMover::~TemporaryWindowMover):
851         This class moves a window on-screen and shows it, then moves it back and hides it.
852
853         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
854         Initialize our members.
855         (NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow):
856         Delete our window mover if it hasn't been deleted already.
857         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the
858         plugin HWND and move the test harness window on screen.
859         (NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint
860         when we get a WM_PAINT message.
861         (NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell
862         LayoutTestController we're done.
863         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate
864         ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect,
865         then check that our HWND's invalid region is the rect that we
866         invalidated.
867
868         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
869         * Added NPNInvalidateRectInvalidatesWindow.
870
871 2010-10-21  Daniel Bates  <dbates@rim.com>
872
873         Add Git-support to do-file-rename
874         https://bugs.webkit.org/show_bug.cgi?id=48015
875
876         Fix tools. Export function scmMoveOrRenameFile so that it can be called from
877         do-file-rename and do-webcore-rename. I inadvertently left this out of the patch.
878
879         * Scripts/VCSUtils.pm:
880
881 2010-10-21  Eric Seidel  <eric@webkit.org>
882
883         Reviewed by Adam Barth.
884
885         mac-ews is not properly releasing patches
886         https://bugs.webkit.org/show_bug.cgi?id=48076
887
888         mac-ews overrides process_work_item, so it was not calling
889         release_work_item like the default process_work_item would.
890         To fix this I made all the status-reporting methods just
891         release the patch.  I expect we'll iterate on this design further.
892
893         * Scripts/webkitpy/common/net/statusserver.py:
894         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
895         * Scripts/webkitpy/tool/commands/queues.py:
896         * Scripts/webkitpy/tool/commands/queues_unittest.py:
897
898 2010-10-18  Martin Robinson  <mrobinson@igalia.com>
899
900         Reviewed by Gustavo Noronha Silva.
901
902         [GTK] mathml flaky tests after adding SystemFonts to the theme
903         https://bugs.webkit.org/show_bug.cgi?id=47727
904
905         The Fontconfig setup in the GTK+ now specifically checks for and
906         loads the STIX fonts for MathML tests.
907
908         * DumpRenderTree/gtk/DumpRenderTree.cpp:
909         (initializeFonts): Add hooks for loading the STIX fonts specifically.
910
911 2010-10-20  Adam Roben  <aroben@apple.com>
912
913         Test that the UI client gets notified when WKView receives a WM_CLOSE
914         message
915
916         Test for <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing
917         Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't
918         close its parent window
919
920         Reviewed by Jon Honeycutt.
921
922         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added.
923         (TestWebKitAPI::close): Record that this function was called.
924         (TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView,
925         send it a WM_CLOSE message, and test that the UI client's close
926         callback got called. Note that this will hang if the bug is
927         reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI
928         able to handle hangs.
929
930         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
931
932 2010-10-20  Adam Roben  <aroben@apple.com>
933
934         Make prepare-ChangeLog much faster when using git
935
936         This change also seems to make it detect renames better in some cases.
937
938         Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using
939         git
940
941         Reviewed by David Kilzer.
942
943         * Scripts/prepare-ChangeLog:
944         (statusCommand):
945         (createPatchCommand):
946         Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames
947         and copies. The two "-C"s were making it read many more files than were
948         necessary.
949
950 2010-10-21  Sam Weinig  <sam@webkit.org>
951
952         Reviewed by Adam Roben.
953
954         Null frame passed when running alert from UserScript run at document start
955         <rdar://problem/8573809>
956         https://bugs.webkit.org/show_bug.cgi?id=48036
957
958         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
959         * TestWebKitAPI/InjectedBundleController.cpp:
960         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
961         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
962         * TestWebKitAPI/InjectedBundleController.h:
963         * TestWebKitAPI/InjectedBundleTest.h:
964         (TestWebKitAPI::InjectedBundleTest::initialize):
965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
966         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added.
967         (TestWebKitAPI::runJavaScriptAlert):
968         (TestWebKitAPI::TEST):
969         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added.
970         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest):
971         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
972         Add test for invoking an alert during a UserScript run at document start.
973
974 2010-10-21  Andreas Kling  <kling@webkit.org>
975
976         Reviewed by Adam Roben.
977
978         TestNetscapePlugIn: Actually call NPP_SetWindow on Unix
979
980         We were just returning NPERR_NO_ERROR previously.
981
982         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
983         (webkit_test_plugin_set_window):
984
985 2010-10-21  David Kilzer  <ddkilzer@apple.com>
986
987         <http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h
988
989         Reviewed by Adam Roben.
990
991         * DumpRenderTree/config.h: Moved macros to here...
992         * DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here.
993         Addresses a FIXME comment from r28419.
994
995 2010-10-21  David Kilzer  <ddkilzer@apple.com>
996
997         <http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types
998
999         Reviewed by Adam Roben.
1000
1001         Fixes the following warnings:
1002
1003             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'.
1004             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'.
1005             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'.
1006             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'.
1007             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'.
1008             5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj.
1009
1010         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1011         Removed explicit file type for *.cpp files above to make them
1012         match other C++ source files.  This exposed the fact that
1013         DumpRenderTreeMac.h was not safe to include in C++ source, which
1014         caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail
1015         to build.
1016         * DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order.
1017         * DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include
1018         in C++ source files.  Included CoreFoundation/CoreFoundation.h
1019         to make sure all CF types were defined.  Removed CFStringRef
1020         typedef.
1021
1022 2010-10-21  Adam Roben  <aroben@apple.com>
1023
1024         Attempt to fix plugins/pass-different-npp-struct.html on GTK.
1025
1026         See <http://webkit.org/b/47690>.
1027
1028         * GNUmakefile.am: Added PassDifferentNPPStruct.cpp.
1029
1030 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1031
1032         Reviewed by Csaba Osztrogonác.
1033
1034         [NRWT] Set ImageDiff path on Qt port
1035         https://bugs.webkit.org/show_bug.cgi?id=48052
1036
1037         * Scripts/webkitpy/layout_tests/port/qt.py:
1038
1039 2010-10-21  Adam Barth  <abarth@webkit.org>
1040
1041         Reviewed by Eric Seidel.
1042
1043         Don't CC authors of flaky tests
1044         https://bugs.webkit.org/show_bug.cgi?id=48038
1045
1046         Some authors found this too annoying.  We'll look for another way to
1047         close the flaky test loop.
1048
1049         * Scripts/webkitpy/tool/commands/queues.py:
1050         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1051
1052 2010-10-21  Eric Seidel  <eric@webkit.org>
1053
1054         Reviewed by Adam Barth.
1055
1056         commit-queue should run run-webkit-tests with --no-new-test-results
1057         https://bugs.webkit.org/show_bug.cgi?id=47998
1058
1059         * Scripts/webkitpy/tool/steps/runtests.py:
1060         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1061
1062 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1063
1064         Reviewed by Ojan Vafai.
1065
1066         [NRWT] Get child process number from an environment variable
1067         https://bugs.webkit.org/show_bug.cgi?id=47981
1068
1069         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1070
1071 2010-10-20  David Kilzer  <ddkilzer@apple.com>
1072
1073         <http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files
1074
1075         Reviewed by Darin Adler.
1076
1077         The script parses an Xcode project file and makes sure the file
1078         extension matches the explicit file type set for all source
1079         files.  Note that the majority of source files will have their
1080         type set by Xcode, so the script doesn't check them since there
1081         is no need to second-guess Xcode.
1082
1083         * Scripts/check-Xcode-source-file-types: Added.  Code borrowed
1084         heavily from sort-Xcode-project-file.
1085
1086 2010-10-20  Adam Roben  <aroben@apple.com>
1087         
1088         Windows build fix
1089
1090         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include.
1091
1092 2010-10-20  Adam Roben  <aroben@apple.com>
1093
1094         Qt test fix
1095
1096         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added
1097         PassDifferentNPPStruct.cpp.
1098
1099 2010-10-20  Sam Weinig  <sam@webkit.org>
1100
1101         Reviewed by Adam Roben.
1102
1103         Add ability to test injected bundle API using TestWebKitAPI
1104         https://bugs.webkit.org/show_bug.cgi?id=48027
1105
1106         * TestWebKitAPI/InjectedBundleController.cpp: Added.
1107         * TestWebKitAPI/InjectedBundleController.h: Added.
1108         Shared main object for bundle functionality.
1109
1110         * TestWebKitAPI/InjectedBundleMain.cpp: Added.
1111         Bundle entry point.
1112
1113         * TestWebKitAPI/InjectedBundleTest.h: Added.
1114         Base class for which the bundle portion of a test derives from. 
1115
1116         * TestWebKitAPI/PlatformUtilities.h:
1117         * TestWebKitAPI/PlatformUtilities.cpp: Added.
1118         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1119         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1120         (TestWebKitAPI::Util::createInjectedBundlePath):
1121         (TestWebKitAPI::Util::createURLForResource):
1122         (TestWebKitAPI::Util::URLForNonExistentResource):
1123         Add helper to create a context with the shared injected bundle,
1124         and send the initial message to set up the test.
1125
1126         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added.
1127         * TestWebKitAPI/InjectedBundle-Info.plist: Added.
1128         Add mac configuration files.
1129
1130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1131         Add the new files.
1132
1133         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added.
1134         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added.
1135         Add a simple initial bundle test.
1136
1137 2010-10-20  Eric Seidel  <eric@webkit.org>
1138
1139         Unreviewed.  Fixing /release-patch url used by the EWS bots.
1140
1141         EWS should test patches with r+
1142         https://bugs.webkit.org/show_bug.cgi?id=35460
1143
1144         * Scripts/webkitpy/common/net/statusserver.py:
1145          - I changed the URL during development, and 404s are
1146          intentionally silenced during release_patch.
1147
1148 2010-10-14  Adam Roben  <aroben@apple.com>
1149
1150         Test that passing a different NPP struct back to the browser doesn't
1151         cause an assertion failure
1152
1153         Test for <http://webkit.org/b/47690> <rdar://problem/8553020>
1154         Assertion failure in NetscapePlugin::fromNPP when using Shockwave in
1155         WebKit2
1156
1157         Reviewed by John Sullivan.
1158
1159         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp.
1160         (PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our
1161         members.
1162         (PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the
1163         browser than the one it gave us in NPP_New and see if it works.
1164
1165         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1166         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1167         Added PassDifferentNPPStruct.
1168
1169 2010-10-19  Adam Roben  <aroben@apple.com>
1170
1171         Gently nudge old-run-webkit-tests toward working with Win32 Perl
1172
1173         This makes old-run-webkit-tests able to build DRT and find all the
1174         tests to run. It even invokes DRT and passes it the list of tests. But
1175         DRT ends up hung blocking on I/O.
1176
1177         Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly
1178         working with Win32 Perl
1179
1180         Reviewed by David Kilzer.
1181
1182         * Scripts/old-run-webkit-tests:
1183           - Use File::Spec instead of manually concatenating paths
1184           - Use dirname instead of manually stripping off the base name
1185           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
1186           - Explicitly invoke Perl when running Perl scripts
1187           - Quote paths when using them in regular expressions to allow them
1188             to include characters that have special meanings in regular
1189             expressions
1190
1191         * Scripts/run-webkit-tests: Use File::Spec instead of manually
1192         concatenating paths.
1193
1194         * Scripts/webkitdirs.pm:
1195           - Remove the unused $windowsTmpPath variable
1196           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
1197           - Only pass paths to cygpath when using Cygwin Perl
1198           - Only use pdevenv when using Cygwin Perl, for now
1199
1200 2010-10-20  Daniel Bates  <dbates@rim.com>
1201
1202         Reviewed by Martin Robinson.
1203
1204         Add Git-support to do-file-rename
1205         https://bugs.webkit.org/show_bug.cgi?id=48015
1206
1207         Also, abstracts the SCM move/rename functionality in do-file-rename and
1208         do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile().
1209
1210         Currently, do-file-rename is hard coded to assume the SCM is Subversion.
1211         Instead, we should abstract the rename logic to be SCM-independent. This
1212         will allow us to add Git support as well move such functionality into
1213         our SCM library VCSUtils, where it can be shared by do-webcore-rename.
1214
1215         * Scripts/VCSUtils.pm:
1216           - Added function scmMoveOrRenameFile.
1217         * Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile().
1218         * Scripts/do-webcore-rename: Ditto.
1219
1220 2010-10-20  Adam Roben  <aroben@apple.com>
1221
1222         Fix old-run-webkit-tests when there's a space in the path to DRT
1223
1224         Reviewed by Jon Honeycutt.
1225
1226         * Scripts/old-run-webkit-tests: Quote the path to DRT before executing
1227         it.
1228
1229 2010-10-20  Kenneth Russell  <kbr@google.com>
1230
1231         Reviewed by Dimitri Glazkov.
1232
1233         Regression in chromium_gpu_unittests after r70175
1234         https://bugs.webkit.org/show_bug.cgi?id=48008
1235
1236         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1237
1238 2010-10-20  Kenneth Russell  <kbr@google.com>
1239
1240         Reviewed by James Robinson.
1241
1242         chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
1243         https://bugs.webkit.org/show_bug.cgi?id=48005
1244
1245         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1246
1247 2010-10-20  Adam Barth  <abarth@webkit.org>
1248
1249         Reviewed by Eric Seidel.
1250
1251         webkit-patch doesn't get along with git rm
1252         https://bugs.webkit.org/show_bug.cgi?id=47940
1253
1254         Turns out we need to pass "--" to tell git this is a path.
1255
1256         * Scripts/webkitpy/common/checkout/scm.py:
1257
1258 2010-10-20  Robert Hogan  <robert@webkit.org>
1259
1260         Reviewed by Antonio Gomes.
1261
1262         [Qt] Fix layoutTestController.getJsObjectCount
1263
1264         Qt Bridge doesn't know size_t so pass result as unsigned int.
1265
1266         Unskip fast/dom/gc-10.html
1267
1268         https://bugs.webkit.org/show_bug.cgi?id=47931
1269
1270         * DumpRenderTree/qt/GCControllerQt.cpp:
1271         (GCController::getJSObjectCount):
1272         * DumpRenderTree/qt/GCControllerQt.h:
1273
1274 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1275
1276         Unreviewed, rolling out r70149.
1277         http://trac.webkit.org/changeset/70149
1278         https://bugs.webkit.org/show_bug.cgi?id=47989
1279
1280         "Build breaks in mac and win" (Requested by satish on
1281         #webkit).
1282
1283         * DumpRenderTree/LayoutTestController.cpp:
1284         (setMockSpeechInputResultCallback):
1285         * DumpRenderTree/LayoutTestController.h:
1286         * DumpRenderTree/chromium/LayoutTestController.cpp:
1287         (LayoutTestController::setMockSpeechInputResult):
1288         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1289         (LayoutTestController::setMockSpeechInputResult):
1290
1291 2010-10-19  Adam Roben  <aroben@apple.com>
1292
1293         Teach update-webkit-support-libs about the new versioning of
1294         WebKitSupportLibrary
1295
1296         Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
1297         check version numbers instead of modification times
1298
1299         Reviewed by Sam Weinig.
1300
1301         * Scripts/update-webkit-support-libs: Fetch the expected version
1302         number from developer.apple.com, then compare with the version number
1303         of the extracted library and of the zipped library to see if anything
1304         needs to be done. Removed code that tracked the modified timestamp of
1305         the library, as it is no longer needed.
1306
1307 2010-10-19  Eric Seidel  <eric@webkit.org>
1308
1309         Reviewed by Adam Barth.
1310
1311         EWS should test patches with r+
1312         https://bugs.webkit.org/show_bug.cgi?id=35460
1313
1314         * QueueStatusServer/handlers/submittoews.py:
1315         * QueueStatusServer/model/queues.py:
1316         * Scripts/webkitpy/tool/bot/patchcollection.py: Removed.
1317         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed.
1318         * Scripts/webkitpy/tool/commands/queues.py:
1319
1320 2010-10-19  Eric Seidel  <eric@webkit.org>
1321
1322         Reviewed by Adam Barth.
1323
1324         Teach feeder-queue how to feed the EWS bots
1325         https://bugs.webkit.org/show_bug.cgi?id=47943
1326
1327         queues.webkit.org already knew how to accept EWS submissions
1328         via /submit-to-ews.  This teaches the feeder queue how to post
1329         to that page with any new r? patches it sees.
1330
1331         * QueueStatusServer/model/activeworkitems_unitest.py: Added.
1332          - More unit testing is always a good thing.
1333         * Scripts/webkitpy/common/net/bugzilla.py:
1334         * Scripts/webkitpy/common/net/statusserver.py:
1335         * Scripts/webkitpy/tool/bot/feeders.py:
1336         * Scripts/webkitpy/tool/commands/queues.py:
1337         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1338         * Scripts/webkitpy/tool/mocktool.py:
1339
1340 2010-10-19  Eric Seidel  <eric@webkit.org>
1341
1342         Unreviewed, just fixing test-webkitpy.  I'm really on a roll today.
1343
1344         commit-queue gets stuck when release-patch returns 404
1345         https://bugs.webkit.org/show_bug.cgi?id=47935
1346
1347         Fix test-webkitpy and unittest NetworkTransaction.
1348
1349         * Scripts/webkitpy/common/net/networktransaction.py:
1350         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1351
1352 2010-10-19  Eric Seidel  <eric@webkit.org>
1353
1354         Unreviewed.
1355
1356         commit-queue gets stuck when release-patch returns 404
1357         https://bugs.webkit.org/show_bug.cgi?id=47935
1358
1359         Turns out ClientForm gets upset if passed an int() instead of a string type.
1360         Yay for untestable code.
1361
1362         * Scripts/webkitpy/common/net/statusserver.py:
1363
1364 2010-10-19  Eric Seidel  <eric@webkit.org>
1365
1366         Unreviewed.  Will get Adam's commentary after his meeting
1367         for now this gets the commit-cluster back running.
1368
1369         commit-queue gets stuck when release-patch returns 404
1370         https://bugs.webkit.org/show_bug.cgi?id=47935
1371
1372         I taught NetworkTransaction the basics of 404 handling.
1373         We'll want to go back and teach it how to handle urllib2 404's too
1374         and then deploy it to the places that want it.
1375
1376         * QueueStatusServer/handlers/releasepatch.py:
1377         * Scripts/webkitpy/common/net/buildbot.py:
1378         * Scripts/webkitpy/common/net/networktransaction.py:
1379         * Scripts/webkitpy/common/net/statusserver.py:
1380
1381 2010-10-19  Eric Seidel  <eric@webkit.org>
1382
1383         Unreviewed.  Fixing typos in my previous commit.
1384
1385         Make patch release explicit and not a magic part of "retry" status
1386         https://bugs.webkit.org/show_bug.cgi?id=47909
1387
1388         All of these typos again due to our inability to unit
1389         test much of this code.  I added one unit test where
1390         possible.  activeworkitems_unittest.py will be in a separate patch.
1391
1392         * QueueStatusServer/handlers/releasepatch.py:
1393         * QueueStatusServer/main.py:
1394         * QueueStatusServer/model/activeworkitems.py:
1395         * QueueStatusServer/model/workitems.py:
1396         * QueueStatusServer/model/workitems_unittest.py:
1397         * QueueStatusServer/templates/releasepatch.html:
1398         * Scripts/webkitpy/common/net/statusserver.py:
1399
1400 2010-10-19  Tony Chang  <tony@chromium.org>
1401
1402         Reviewed by Kent Tamura.
1403
1404         [chromium] Use webkit's TestNetscapePlugIn in DRT mac
1405         https://bugs.webkit.org/show_bug.cgi?id=47850
1406
1407         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
1408             because we're going to name our plugin WebKitTestNetscapePlugIn
1409             temporarily until the chromium forked plugin goes away.
1410
1411 2010-10-19  Eric Seidel  <eric@webkit.org>
1412
1413         Reviewed by Adam Barth.
1414
1415         Make patch release explicit and not a magic part of "retry" status
1416         https://bugs.webkit.org/show_bug.cgi?id=47909
1417
1418         This moves us another step closer to running r+ patches on the EWS bots.
1419         Currently all bots just spam /update-work-items with their list of current
1420         work items.  queues.webkit.org uses that data for display.  As part of making
1421         the EWS run r+ patches, we're moving the official list of patches-to-process
1422         into the server, and feeding them out to bots one at a time.  We need to be
1423         able to remove patches from the queues one at a time instead of just spamming
1424         /update-work-items with a new complete list.  That's what this patch adds.
1425
1426         * QueueStatusServer/handlers/nextpatch.py:
1427         * QueueStatusServer/handlers/queuestatus.py:
1428         * QueueStatusServer/handlers/releasepatch.py: Added.
1429         * QueueStatusServer/handlers/statusbubble_unittest.py:
1430          - Fix a typo causing test failure.  This was not caught by the bots
1431            because they don't have AppEngineLauncher installed and thus don't run
1432            the QueueStatusServer tests.
1433         * QueueStatusServer/handlers/updatestatus.py:
1434         * QueueStatusServer/model/activeworkitems.py:
1435         * QueueStatusServer/templates/releasepatch.html: Added.
1436         * Scripts/webkitpy/common/net/statusserver.py:
1437         * Scripts/webkitpy/tool/commands/queues.py:
1438         * Scripts/webkitpy/tool/mocktool.py:
1439
1440 2010-10-19  Eric Seidel  <eric@webkit.org>
1441
1442         Reviewed by Adam Barth.
1443
1444         cr-mac bubble has caused status bubbles to wrap
1445         https://bugs.webkit.org/show_bug.cgi?id=47928
1446
1447         We now have too many EWSes to fit in the bugs.webkit.org
1448         status-bubble iframe when more than a couple EWS builds are pending.
1449         To fix this I've reduced the space taken up by queue position,
1450         and also moved cr-mac to the end of the list (since it's going to be
1451         triple-digits for a while).
1452
1453         * QueueStatusServer/model/queues.py:
1454         * QueueStatusServer/templates/statusbubble.html:
1455
1456 2010-10-19  Kenneth Russell  <kbr@google.com>
1457
1458         Reviewed by David Levin.
1459
1460         chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
1461         https://bugs.webkit.org/show_bug.cgi?id=47874
1462
1463         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1464         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1465
1466 2010-10-19  Tony Chang  <tony@chromium.org>
1467
1468         Reviewed by Kent Tamura.
1469
1470         [chromium] DumpRenderTree shouldn't put '.' in include path
1471         https://bugs.webkit.org/show_bug.cgi?id=47877
1472
1473         Fix include paths.
1474
1475         * DumpRenderTree/chromium/AccessibilityController.cpp:
1476         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1477         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1478         * DumpRenderTree/chromium/CppBoundClass.cpp:
1479         * DumpRenderTree/chromium/CppVariant.cpp:
1480         * DumpRenderTree/chromium/CppVariant.h:
1481         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1482         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1483         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1484         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1485         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1486         * DumpRenderTree/chromium/EventSender.cpp:
1487         * DumpRenderTree/chromium/EventSender.h:
1488         * DumpRenderTree/chromium/LayoutTestController.cpp:
1489         * DumpRenderTree/chromium/LayoutTestController.h:
1490         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1491         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1492         * DumpRenderTree/chromium/NotificationPresenter.h:
1493         * DumpRenderTree/chromium/PlainTextController.cpp:
1494         * DumpRenderTree/chromium/Task.cpp:
1495         * DumpRenderTree/chromium/TestNavigationController.h:
1496         * DumpRenderTree/chromium/TestShell.cpp:
1497         * DumpRenderTree/chromium/TestWebWorker.h:
1498         * DumpRenderTree/chromium/TextInputController.cpp:
1499         * DumpRenderTree/chromium/WebPreferences.cpp:
1500         * DumpRenderTree/chromium/WebPreferences.h:
1501         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
1502         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
1503         * DumpRenderTree/chromium/WebViewHost.cpp:
1504         * DumpRenderTree/chromium/WebViewHost.h:
1505
1506 2010-10-19  Sam Weinig  <sam@webkit.org>
1507
1508         Reviewed by Dan Bernstein.
1509
1510         Need to include WKErrorRef in the WKPageDidFail... functions
1511         https://bugs.webkit.org/show_bug.cgi?id=47871
1512
1513         Update tools for new parameter in failure callbacks.
1514
1515         * MiniBrowser/mac/BrowserWindowController.m:
1516         (didFailProvisionalLoadWithErrorForFrame):
1517         (didFailLoadWithErrorForFrame):
1518         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1519         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1520         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1521         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1522         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1523         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1525
1526 2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>
1527
1528         Reviewed by Antti Koivisto.
1529
1530         [Qt] WebKit2 MacOS build fix
1531         https://bugs.webkit.org/show_bug.cgi?id=47897
1532
1533         Qt WebKit2 MacOS build fix.
1534
1535         * WebKitTestRunner/PlatformWebView.h:
1536         * WebKitTestRunner/qt/TestControllerQt.cpp:
1537
1538 2010-10-19  Adam Barth  <abarth@webkit.org>
1539
1540         Reviewed by Eric Seidel.
1541
1542         webkit-patch stats the filesystem too many times
1543         https://bugs.webkit.org/show_bug.cgi?id=47883
1544
1545         This patch attempts to cache the list of changed files more agressively
1546         and to use that list to compute the diff instead of stating the file
1547         system again.
1548
1549         * Scripts/webkitpy/common/checkout/api.py:
1550         * Scripts/webkitpy/common/checkout/scm.py:
1551         * Scripts/webkitpy/tool/mocktool.py:
1552         * Scripts/webkitpy/tool/steps/abstractstep.py:
1553         * Scripts/webkitpy/tool/steps/editchangelog.py:
1554         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1555
1556 2010-10-19  David Kilzer  <ddkilzer@apple.com>
1557
1558         <http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
1559
1560         Reviewed by Darin Adler.
1561
1562         * Scripts/sort-Xcode-project-file:
1563         - Don't print an error message about missing arguments when
1564           -h|--help is used.
1565         - Allow Xcode project files to be specified as Project.xcodeproj
1566           instead of Project.xcodeproj/project.pbxproj.
1567
1568 2010-10-18  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1569
1570         Reviewed by Andreas Kling.
1571
1572         [Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
1573         https://bugs.webkit.org/show_bug.cgi?id=47809
1574
1575         Connecting a call to load from the loadFinished signal can cause
1576         re-entrance crashes in WebCore. This patch uses a timer to do so,
1577         also giving some time to subsequent frames to finish loading.
1578
1579         * QtTestBrowser/urlloader.cpp:
1580         (UrlLoader::UrlLoader):
1581         (UrlLoader::loadNext):
1582         (UrlLoader::checkIfFinished):
1583         (UrlLoader::frameLoadStarted):
1584         (UrlLoader::frameLoadFinished):
1585         * QtTestBrowser/urlloader.h:
1586
1587 2010-10-19  Sergio Villar Senín  <svillar@igalia.com>
1588
1589         Reviewed by Xan Lopez.
1590
1591         [GTK] http/history tests are failing
1592         https://bugs.webkit.org/show_bug.cgi?id=36173
1593
1594         Clear the history each time a test is run. Return the actual
1595         history item count when calling
1596         LayoutTestController::webHistoryItemCount
1597
1598         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1599         (resetDefaultsToConsistentValues):
1600         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1601         (LayoutTestController::webHistoryItemCount):
1602
1603 2010-10-18  Eric Seidel  <eric@webkit.org>
1604
1605         Reviewed by Adam Barth.
1606
1607         Add Chromium Mac EWS to the list of queues at queues.webkit.org
1608         https://bugs.webkit.org/show_bug.cgi?id=47878
1609
1610         * QueueStatusServer/model/queues.py:
1611
1612 2010-10-18  Eric Seidel  <eric@webkit.org>
1613
1614         Reviewed by Adam Barth.
1615
1616         queues.webkit.org/next_patch is always 404
1617         https://bugs.webkit.org/show_bug.cgi?id=47881
1618
1619         With the addition of the Queue class, I changed most of the
1620         code to lookup WorkItems using get_or_insert with a key_name
1621         instead of WorkItems.all().filter(queue_name=).
1622         Because the new get_or_insert code uses an explicit key_name
1623         (which is obviously different from the previously autogenerated
1624         ones), there were new WorkItem records created for each queue.
1625         However, some parts of the code still use WorkItems.all().filter,
1626         thus some parts were getting the new record and some parts the old record.
1627
1628         The same basic bug was occurring with ActiveWorkItems, because I
1629         changed the key_name for that class as well.
1630
1631         To fix this I've moved more of the code over to using Queue.*work_items.
1632         I've also enabled the datastore_admin (new in GAE 1.3.8) so that
1633         we can go delete the old WorkItems records.
1634         I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
1635
1636         * QueueStatusServer/app.yaml:
1637         * QueueStatusServer/handlers/queuestatus.py:
1638         * QueueStatusServer/handlers/recentstatus.py:
1639         * QueueStatusServer/handlers/updatestatus.py:
1640         * QueueStatusServer/handlers/updateworkitems.py:
1641
1642 2010-10-18  Eric Seidel  <eric@webkit.org>
1643
1644         Reviewed by Adam Barth.
1645
1646         Correct a bunch of typos in QueueStatusServer
1647         https://bugs.webkit.org/show_bug.cgi?id=47880
1648
1649         These are all due to our complete lack of unit testing in QueueStatusServer.
1650         I added a couple unit tests to cover a few of these fixes, but most of these
1651         are still only caught by actually running the application.
1652
1653         * QueueStatusServer/handlers/nextpatch.py:
1654         * QueueStatusServer/handlers/statusbubble.py:
1655         * QueueStatusServer/handlers/statusbubble_unittest.py: Added.
1656         * QueueStatusServer/handlers/updateworkitems.py:
1657         * QueueStatusServer/model/attachment.py:
1658         * QueueStatusServer/model/queuepropertymixin.py:
1659         * QueueStatusServer/model/queuepropertymixin_unittest.py:
1660         * QueueStatusServer/model/workitems.py:
1661         * QueueStatusServer/model/workitems_unittest.py: Added.
1662
1663 2010-10-18  Adam Barth  <abarth@webkit.org>
1664
1665         Disable this test because it's failing on the bots and the authors
1666         aren't around to fix it.
1667
1668         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1669
1670 2010-10-18  Adam Barth  <abarth@webkit.org>
1671
1672         Reviewed by Eric Seidel.
1673
1674         CC authors of flaky tests when the commit-queue hits a flaky test
1675         https://bugs.webkit.org/show_bug.cgi?id=47872
1676
1677         * Scripts/webkitpy/common/checkout/api.py:
1678         * Scripts/webkitpy/common/net/layouttestresults.py:
1679         * Scripts/webkitpy/tool/commands/queues.py:
1680         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1681         * Scripts/webkitpy/tool/mocktool.py:
1682
1683 2010-10-18  Eric Seidel  <eric@webkit.org>
1684
1685         Reviewed by Adam Barth.
1686
1687         Make it possible to run a chromium-mac-ews builder
1688         https://bugs.webkit.org/show_bug.cgi?id=47876
1689
1690         Since we can't run Mac OS X in a VM, we need to only run committer patches.
1691         There was a multiple inheritance problem which was holding this patch back,
1692         but I decided to just ignore the problem and go with a functional hack for now.
1693
1694         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1695         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1696
1697 2010-10-18  Kenneth Russell  <kbr@google.com>
1698
1699         Reviewed by Tony Chang.
1700
1701         Regression in run_webkit_tests_unittest from r70017
1702         https://bugs.webkit.org/show_bug.cgi?id=47875
1703
1704         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1705
1706 2010-10-18  Adam Barth  <abarth@webkit.org>
1707
1708         Reviewed by Eric Seidel.
1709
1710         Implement webkit-patch suggest-reviewers
1711         https://bugs.webkit.org/show_bug.cgi?id=47866
1712
1713         * Scripts/webkitpy/common/checkout/api.py:
1714             - The main logic.  We look at the last five changes to each
1715               modified (non-ChangeLog) file and collect up the reviewers of
1716               those changes as well as the authors of those changes who are
1717               reviewers.
1718         * Scripts/webkitpy/common/checkout/api_unittest.py:
1719             - Test the logic with some fun mocks.
1720         * Scripts/webkitpy/common/checkout/scm.py:
1721             - Fix a bug when you have local git commits.
1722         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1723             - Test that the bug is fixed.
1724         * Scripts/webkitpy/tool/commands/queries.py:
1725             - Add the query.
1726
1727 2010-10-18  Kenneth Russell  <kbr@google.com>
1728
1729         Reviewed by Eric Seidel.
1730
1731         new-run-webkit-tests produces corrupt PNG baselines on Windows
1732         https://bugs.webkit.org/show_bug.cgi?id=47867
1733
1734         * Scripts/webkitpy/layout_tests/port/base.py:
1735
1736 2010-10-18  Eric Seidel  <eric@webkit.org>
1737
1738         Reviewed by Adam Barth.
1739
1740         Make it possible to submit patches to the EWS bots
1741         https://bugs.webkit.org/show_bug.cgi?id=47869
1742
1743         * QueueStatusServer/handlers/nextpatch.py:
1744          - Move more logic into Queue, so that it can be shared with SubmitToEWS.
1745         * QueueStatusServer/handlers/queuestatus.py:
1746          - Fix two typos from a previous commit.
1747         * QueueStatusServer/handlers/submittoews.py: Added.
1748         * QueueStatusServer/handlers/updatestatus.py:
1749          - Use the new is_retry_request method to share this (hacky) code with SubmitToEWS
1750         * QueueStatusServer/main.py:
1751          - Add /submit-to-ews
1752         * QueueStatusServer/model/queuepropertymixin.py:
1753          - Fix circular imports caused by adding Queue.work_items()
1754         * QueueStatusServer/model/queues.py:
1755          - Add work_items() and active_work_items()
1756         * QueueStatusServer/model/queuestatus.py:
1757         * QueueStatusServer/model/workitems.py:
1758          - Add transaction-safe add/remove methods.
1759         * QueueStatusServer/templates/submittoews.html: Added.
1760
1761 2010-10-18  Eric Seidel  <eric@webkit.org>
1762
1763         Reviewed by Adam Barth.
1764
1765         Deploy Queue class in more places throughout QueueStatusServer
1766         https://bugs.webkit.org/show_bug.cgi?id=47855
1767
1768         I also caught two typos from the previous change.  Unfortunately
1769         I don't yet know how to unittest request handlers yet.
1770
1771         * QueueStatusServer/handlers/dashboard.py:
1772         * QueueStatusServer/handlers/statusbubble.py:
1773         * QueueStatusServer/handlers/updateworkitems.py:
1774         * QueueStatusServer/model/activeworkitems.py:
1775         * QueueStatusServer/model/attachment.py:
1776         * QueueStatusServer/model/queuepropertymixin.py: Added.
1777         * QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
1778         * QueueStatusServer/model/queuestatus.py:
1779         * QueueStatusServer/model/workitems.py:
1780
1781 2010-10-18  Adam Barth  <abarth@webkit.org>
1782
1783         Reviewed by Eric Seidel.
1784
1785         scm.py should be able tell us what revisions made changes to a given file
1786         https://bugs.webkit.org/show_bug.cgi?id=47863
1787
1788         Look again, your SCM.py can now log files.
1789
1790         * Scripts/webkitpy/common/checkout/scm.py:
1791         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1792
1793 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1794
1795         Reviewed by Eric Siedel.
1796
1797         new-run-webkit-tests: clean up the options-parsing code in the port
1798         classes.
1799         
1800         This change modifies the Port interface to have a get_option() and
1801         set_option_default() method for accessing the options argument
1802         passed to the constructor. If the constructor is not passed an
1803         options argument, we default to a MockOptions() argument from
1804         mocktool, which has the same semantics we want.
1805
1806         Note that there is a disadvantage to port.get_option('foo') over
1807         port._options.foo, which is that you lose some of the checking
1808         for whether 'foo' is set (typos result in the default value, not
1809         an exception being raised. This is desired in this case, since the
1810         Port class is not allowed to assume that options does have any
1811         particular values set, and so this change ensures that all of
1812         the subclasses are following the same, intended, logic.
1813
1814         Arguably this is the wrong semantics to have, and the Port
1815         classes should be able to assume a default set of
1816         attributes/arguments, but that change will need to wait for a
1817         different CL where we can modify new-run-webkit-tests to pull a
1818         list of arguments from the port factory routines.
1819
1820         Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
1821
1822         https://bugs.webkit.org/show_bug.cgi?id=47510
1823
1824         * Scripts/webkitpy/layout_tests/port/base.py:
1825         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1826         * Scripts/webkitpy/layout_tests/port/chromium.py:
1827         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1828         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1829         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1830         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1831         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1832         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1833         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1834         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1835         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1836         * Scripts/webkitpy/layout_tests/port/test.py:
1837         * Scripts/webkitpy/layout_tests/port/webkit.py:
1838         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1839         * Scripts/webkitpy/tool/mocktool_unittest.py: Added.
1840
1841 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1842
1843         Reviewed by Eric Seidel.
1844
1845         Re-submit a revised version of r69638 - enabling new-run-webkit-tests
1846         under cygwin. The initial version had a bug in base:uri_to_test_name
1847         that was causing tests to fail. This version corrects that bug, but
1848         also makes the code safer by calling cygpath more reliably, and
1849         leaving a long-running cygpath process open.
1850
1851         This patch also corrects a couple of minor bugs in http_lock_unittest,
1852         chromium_unittest, and dedpulicate_tests_unittest that showed up
1853         while testing this.
1854
1855         https://bugs.webkit.org/show_bug.cgi?id=47220
1856
1857         * Scripts/webkitpy/common/system/path.py:
1858         * Scripts/webkitpy/common/system/path_unittest.py:
1859         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1860         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1861         * Scripts/webkitpy/layout_tests/port/base.py:
1862         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1863         * Scripts/webkitpy/layout_tests/port/chromium.py:
1864         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1865         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1866         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1867
1868 2010-10-18  Eric Seidel  <eric@webkit.org>
1869
1870         Reviewed by Adam Barth.
1871
1872         Add Queue class and add minimal unittesting of QueueStatusServer code
1873         https://bugs.webkit.org/show_bug.cgi?id=47847
1874
1875         * QueueStatusServer/handlers/dashboard.py:
1876         * QueueStatusServer/handlers/queuestatus.py:
1877         * QueueStatusServer/handlers/recentstatus.py:
1878         * QueueStatusServer/handlers/statusbubble.py:
1879         * QueueStatusServer/handlers/updateworkitems.py:
1880         * QueueStatusServer/model/attachment.py:
1881         * QueueStatusServer/model/queues.py:
1882         * QueueStatusServer/model/queues_unittest.py: Added.
1883         * QueueStatusServer/model/svnrevision.py:
1884         * Scripts/test-webkitpy:
1885         * Scripts/webkitpy/test/main.py:
1886
1887 2010-10-18  Anders Carlsson  <andersca@apple.com>
1888
1889         Fix build.
1890
1891         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1892         (handleEventCarbon):
1893
1894 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
1895
1896         Reviewed by Eric Seidel.
1897
1898         Switch to using the new Carbon NPAPI event declarations, and remove
1899         the old ones.
1900
1901         https://bugs.webkit.org/show_bug.cgi?id=40784
1902
1903         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1904         (handleEventCarbon):
1905
1906 2010-10-18  David Levin  <levin@chromium.org>
1907
1908         Reviewed by Adam Barth.
1909
1910         check-webkit-style should treat the GObject binding directory like other GTK directories.
1911         https://bugs.webkit.org/show_bug.cgi?id=47796
1912
1913         * Scripts/webkitpy/style/checker.py: Added the GObject binding directory
1914         with the other gtk directories (and fixed typo).
1915
1916 2010-10-18  David Levin  <levin@chromium.org>
1917
1918         Reviewed by Oliver Hunt.
1919
1920         check-webkit-style needs to ignore underscores in opcode names and vm_throw
1921         https://bugs.webkit.org/show_bug.cgi?id=47789
1922
1923         * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
1924         * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
1925         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
1926
1927 2010-10-18  MORITA Hajime  <morrita@google.com>
1928
1929         Reviewed by Kent Tamura.
1930
1931         TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
1932         https://bugs.webkit.org/show_bug.cgi?id=47659
1933         
1934         Moved hasSpellingMarkers() from TextInputController to
1935         LayoutTestController.  Currently the implementation is available
1936         only for Mac and for Chromium.
1937
1938         * DumpRenderTree/LayoutTestController.cpp:
1939         (hasSpellingMarkerCallback):
1940         (LayoutTestController::staticFunctions):
1941         * DumpRenderTree/LayoutTestController.h:
1942         * DumpRenderTree/chromium/LayoutTestController.cpp:
1943         (LayoutTestController::LayoutTestController):
1944         (LayoutTestController::hasSpellingMarker):
1945         * DumpRenderTree/chromium/LayoutTestController.h:
1946         * DumpRenderTree/chromium/TextInputController.cpp:
1947         (TextInputController::TextInputController):
1948         (TextInputController::makeAttributedString):
1949         * DumpRenderTree/chromium/TextInputController.h:
1950         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1951         (LayoutTestController::hasSpellingMarker):
1952         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1953         (LayoutTestController::hasSpellingMarker):
1954         * DumpRenderTree/mac/TextInputController.m:
1955         (+[TextInputController isSelectorExcludedFromWebScript:]):
1956         (+[TextInputController webScriptNameForSelector:]):
1957         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1958         (LayoutTestController::hasSpellingMarker):
1959         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1960         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1961         (LayoutTestController::hasSpellingMarker):
1962         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1963         (LayoutTestController::hasSpellingMarker):
1964
1965 2010-10-18  Adam Barth  <abarth@webkit.org>
1966
1967         Reviewed by David Levin.
1968
1969         commit-queue's flaky test notice is very Pythony
1970         https://bugs.webkit.org/show_bug.cgi?id=47790
1971
1972         This patch make the list of tests delimted by \n instead of just
1973         converting the array to a string.
1974
1975         * Scripts/webkitpy/tool/commands/queues.py:
1976         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1977
1978 2010-10-14  Antonio Gomes  <agomes@rim.com>
1979
1980         Reviewed by Martin Robinson and Xan Lopez.
1981
1982         [Gtk]: DRT does not support frame flattening testing
1983         https://bugs.webkit.org/show_bug.cgi?id=38650
1984
1985         Implement DRT's support for toggling on/off frame flattening
1986         support.
1987
1988         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1989         (resetDefaultsToConsistentValues):
1990         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1991         (LayoutTestController::setFrameFlatteningEnabled):
1992
1993 2010-10-15  Dirk Pranke  <dpranke@chromium.org>
1994
1995         Reviewed by Eric Siedel.
1996
1997         mocktool.MockOptions is inheriting from Mock, which has the side
1998         effect of defaulting any attribute to another MockObject. So,
1999         MockOptions().foo would always evaluate to true. This was
2000         covering over bugs in the unit tests, and is probably the wrong
2001         default behavior for anything attempting to mock out the options
2002         argument returned from optparse.parse_args().
2003
2004         This patch changes the default behavior. The new MockOptions()
2005         class takes an optional list of keyword parameters to set; this
2006         patch doesn't use that feature but the fix for bug 47510 will.
2007
2008         Also, this patch just fills in the default values necessary to
2009         get all of the tests to pass; I didn't stare at each test by
2010         hand to determine the "right" values. We can either fix that in
2011         subsequent patches or let me know if we want to do that now (and
2012         give me some guidance on what those values might want to be).
2013
2014         https://bugs.webkit.org/show_bug.cgi?id=47709
2015
2016         * Scripts/webkitpy/tool/commands/commandtest.py:
2017         * Scripts/webkitpy/tool/commands/download_unittest.py:
2018         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2019         * Scripts/webkitpy/tool/mocktool.py:
2020         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2021         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2022
2023 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
2024
2025         Fix the build; need to add new slot to PageUIClient callbacks.
2026
2027         * MiniBrowser/mac/BrowserWindowController.m:
2028         (-[BrowserWindowController awakeFromNib]):
2029         * WebKitTestRunner/TestController.cpp:
2030         (WTR::createOtherPage):
2031         (WTR::TestController::initialize):
2032
2033 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
2034
2035         Add Matt Delaney to committers.py.
2036
2037         * Scripts/webkitpy/common/config/committers.py:
2038
2039 2010-10-15  Tony Chang  <tony@chromium.org>
2040
2041         Reviewed by Kent Tamura.
2042
2043         [chromium] compile TestNetscapePlugIn on Chromium mac
2044         https://bugs.webkit.org/show_bug.cgi?id=47633
2045
2046         * DumpRenderTree/DumpRenderTree.gypi: files to compile
2047         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
2048         (NP_GetEntryPoints):
2049         (NPP_New):
2050         (NPP_Destroy):
2051         (NPP_HandleEvent):
2052         (NPP_GetValue):
2053         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
2054         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
2055         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
2056
2057 2010-10-15  Leandro Pereira  <leandro@profusion.mobi>
2058
2059         Reviewed by Gustavo Noronha Silva.
2060
2061         build-webkit: Should die when make fails when build a CMake project
2062         https://bugs.webkit.org/show_bug.cgi?id=47726
2063
2064         * Scripts/webkitdirs.pm: If make fails, die immediately.
2065
2066 2010-10-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2067
2068         Unreviewed, rolling out r69809.
2069         http://trac.webkit.org/changeset/69809
2070         https://bugs.webkit.org/show_bug.cgi?id=47725
2071
2072         Broke chromium mac compile (Requested by japhet on #webkit).
2073
2074         * DumpRenderTree/DumpRenderTree.gypi:
2075         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2076         (NP_GetEntryPoints):
2077         (NPP_New):
2078         (NPP_Destroy):
2079         (NPP_HandleEvent):
2080         (NPP_GetValue):
2081         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
2082         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2083         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
2084
2085 2010-10-15  Adam Barth  <abarth@webkit.org>
2086
2087         Reviewed by Adam Barth.
2088
2089         test-webkitpy fails on Linux
2090         https://bugs.webkit.org/show_bug.cgi?id=47713
2091
2092         The old code failed on Linux because the MacPort tries to read
2093         something out of platform that doesn't make sense on Linux.
2094
2095         * Scripts/webkitpy/tool/mocktool.py:
2096
2097 2010-10-14  Balazs Kelemen  <kbalazs@webkit.org>
2098
2099         Reviewed by Kenneth Rohde Christiansen.
2100
2101         [Qt] WTR is sloooow
2102         https://bugs.webkit.org/show_bug.cgi?id=47695
2103
2104         * WebKitTestRunner/qt/TestControllerQt.cpp:
2105         Change the timer interval of RunUntilConditionLoop from
2106         50 milliseconds to 1 to avoid wasting time after the 
2107         test had been finished.
2108
2109 2010-10-14  Eric Seidel  <eric@webkit.org>
2110
2111         Unreviewed, just fixing an exception seen on the commit-queue.
2112
2113         I should have unit tested this function before.
2114
2115         * Scripts/webkitpy/tool/commands/queues.py:
2116         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2117
2118 2010-10-14  Eric Seidel  <eric@webkit.org>
2119
2120         Reviewed by Adam Barth.
2121
2122         commit-queue should not fail patches due to flaky tests
2123         https://bugs.webkit.org/show_bug.cgi?id=47647
2124
2125         This patch makes it so that the *same* flaky test has to fail
2126         twice in a row to have a false negative from a flaky test.
2127
2128         If different flaky tests fail (or if a test fails and then passes
2129         in a second run) then we will warn in the bug that we encountered
2130         a flaky test.
2131
2132         This patch grew to include moving port off of steps onto tool
2133         (which Adam wrote and then I integrated), as well as removing the
2134         use of tool from CommitQueueTask.
2135
2136         * Scripts/webkitpy/common/config/ports.py:
2137          - Added a layout_test_results_path method.  This covers old-run-webkit-tests
2138            but doesn't cover NRWT.  This is probably not the long term solution, but
2139            putting this knowledge on port makes more sense than in LayoutTestResults.
2140         * Scripts/webkitpy/common/net/buildbot.py:
2141          - LayoutTestResults shouldn't know how to fetch from the network, make
2142            the Build code do that instead.
2143         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2144          - Code style fix.
2145         * Scripts/webkitpy/common/net/layouttestresults.py:
2146          - Remove code for reading from the network.
2147         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2148          - Test the new entrypoint.
2149         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2150          - Make the delegate interface explicit.
2151          - Remove the _tool member, since using the delegate for
2152            everything is cleaner.
2153          - Teach the testing logic how to deal with flaky tests.
2154         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2155          - Update to match the CommitQueueTask changes.
2156         * Scripts/webkitpy/tool/commands/queues.py:
2157          - Use the new CommitQueueTaskDelegate interface.
2158         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2159          - Fix the SecondThoughtsCommitQueue test which was broken.
2160          - Add a new test to make sure the flaky test reporting works.
2161         * Scripts/webkitpy/tool/main.py:
2162          - Store the port on the tool object.
2163         * Scripts/webkitpy/tool/mocktool.py:
2164          - Add a port() accessor to MockTool
2165         * Scripts/webkitpy/tool/steps/abstractstep.py:
2166          - Move port() off of Step and onto Tool.
2167         * Scripts/webkitpy/tool/steps/build.py:
2168         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2169         * Scripts/webkitpy/tool/steps/runtests.py:
2170         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2171          - Two tests with the same name!  only the latter was being run.
2172         * Scripts/webkitpy/tool/steps/update.py:
2173
2174 2010-10-14  Dirk Pranke  <dpranke@chromium.org>
2175
2176         Reviewed by Eric Seidel.
2177
2178         new-run-webkit-tests will now handle missing Ruby installs (or
2179         missing PrettyPatch scripts) more cleanly - previously this
2180         would be detected when we actually tried to create the diff, and
2181         the error message was obscure. Now we'll log a warning up front
2182         and otherwise be silent.
2183
2184         This change also refactors some global variables to be class or
2185         instance variables to be slightly more testable and more
2186         modular. There are no cases where we create lots of port objects
2187         and can't afford to test for configurations repeatedly, so
2188         there's no performance concern here.
2189
2190         https://bugs.webkit.org/show_bug.cgi?id=47466
2191
2192         * Scripts/webkitpy/layout_tests/port/base.py:
2193         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2194         * Scripts/webkitpy/layout_tests/port/chromium.py:
2195
2196 2010-10-08  Martin Robinson  <mrobinson@igalia.com>
2197
2198         Reviewed by Xan Lopez.
2199
2200         [GTK] Form controls do not respect GTK+ font size
2201         https://bugs.webkit.org/show_bug.cgi?id=47134
2202
2203         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2204         (initializeGtkFontSettings): Initialize the font control size when running
2205         DumpRenderTree to a standard value.
2206
2207 2010-10-14  Tony Chang  <tony@chromium.org>
2208
2209         Reviewed by Kent Tamura.
2210
2211         [chromium] compile TestNetscapePlugIn on Chromium mac
2212         https://bugs.webkit.org/show_bug.cgi?id=47633
2213
2214         * DumpRenderTree/DumpRenderTree.gypi: files to compile
2215         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
2216         (NP_GetEntryPoints):
2217         (NPP_New):
2218         (NPP_Destroy):
2219         (NPP_HandleEvent):
2220         (NPP_GetValue):
2221         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
2222         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
2223         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
2224
2225 2010-10-14  Victor Wang  <victorw@chromium.org>
2226
2227         Reviewed by Nate Chapin.
2228
2229         [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
2230
2231         https://bugs.webkit.org/show_bug.cgi?id=47686
2232
2233         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2234
2235 2010-10-14  Eric Seidel  <eric@webkit.org>
2236
2237         Reviewed by Adam Barth.
2238
2239         test-webkitpy spews Delegate terminated queue messages
2240         https://bugs.webkit.org/show_bug.cgi?id=47678
2241
2242         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2243
2244 2010-10-14  Adam Roben  <aroben@apple.com>
2245
2246         Test that pressing the Alt key generates a WM_SYSCOMMAND message
2247
2248         Test for <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
2249         the Alt key when MiniBrowser's WKView is focused doesn't send focus to
2250         the menu bar
2251
2252         Reviewed by Steve Falkenburg.
2253
2254         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
2255         TestWebKitAPI/win to the include path so that WindowMessageObserver
2256         can be found.
2257
2258         * TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
2259         Windows-specific members.
2260         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
2261         Added this simple setter.
2262
2263         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
2264         (TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
2265         Initialize our lone data member.
2266         (TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
2267         Simple getter.
2268         (TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
2269         when a WM_SYSCOMMAND message is received.
2270         (TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
2271         WM_SYSKEYUP message is not handled.
2272         (TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
2273         pressing the Alt key and check that a WM_SYSCOMMAND message got sent
2274         to the WKView's parent window.
2275
2276         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2277         (TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
2278         member function so it could access PlatformWebView::wndProc. Use
2279         PlatformWebView::wndProc as the WNDPROC.
2280         (TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
2281         data member and pass the this pointer to CreateWindowEx so we can
2282         store it on the HWND.
2283         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
2284         constants from here to the top of the file.
2285         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
2286         the same messages that Notepad receives when you press the Alt key.
2287         (TestWebKitAPI::PlatformWebView::wndProc): Added.
2288           - When WM_CREATE is received, we set the PlatformWebView instance
2289             pointer as a property on the HWND so we can access it later.
2290           - For other messages, we try to get the PlatformWebView instance
2291             pointer from the HWND property.
2292           - When WM_NCDESTROY is received (which is the last message we will
2293             receive), we remove the PlatformWebView instance property.
2294           - Pass messages to the parent window's message observer, if there is
2295             one.
2296           - Pass all messages through to ::DefWindowProcW.
2297
2298         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
2299         and AltKeyGeneratesWMSysCommand.
2300
2301         * TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
2302         used to observe messages sent to one or more windows.
2303
2304 2010-10-01  Martin Robinson  <mrobinson@igalia.com>
2305
2306         Reviewed by Holger Freyther.
2307
2308         [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
2309         https://bugs.webkit.org/show_bug.cgi?id=47033
2310
2311         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2312         (initializeGtkFontSettings): Added this method which initializes XSettings
2313         font settings to consistent values before running a test. For the one test
2314         in which we need subpixel aliasing turned on, do that.
2315         (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
2316         (runTest): Pass the testURL to initializeFonts.
2317
2318 2010-10-14  Adam Barth  <abarth@webkit.org>
2319
2320         Reviewed by Eric Seidel.
2321
2322         ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
2323         https://bugs.webkit.org/show_bug.cgi?id=47655
2324
2325         * Scripts/webkitpy/common/config/ports.py:
2326         * Scripts/webkitpy/common/config/ports_unittest.py:
2327
2328 2010-10-13  Eric Seidel  <eric@webkit.org>
2329
2330         Reviewed by Adam Barth.
2331
2332         beat diff_parser with the ugly stick
2333         https://bugs.webkit.org/show_bug.cgi?id=47626
2334
2335         * Scripts/webkitpy/common/checkout/diff_parser.py:
2336         * Scripts/webkitpy/style/patchreader.py:
2337         * Scripts/webkitpy/style/patchreader_unittest.py:
2338
2339 2010-10-13  Eric Seidel  <eric@webkit.org>
2340
2341         Reviewed by Adam Barth.
2342
2343         Break LayoutTestResults out into its own file
2344         https://bugs.webkit.org/show_bug.cgi?id=47637
2345
2346         * Scripts/webkitpy/common/net/buildbot.py:
2347         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2348         * Scripts/webkitpy/common/net/layouttestresults.py: Added.
2349         * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
2350
2351 2010-10-13  Adam Barth  <abarth@webkit.org>
2352
2353         Unreviewed.
2354
2355         Chromium port can't run JavaScriptCore tests
2356         https://bugs.webkit.org/show_bug.cgi?id=47654
2357
2358         This lets webkit-patch build-and-test work on Chromium.
2359
2360         * Scripts/webkitpy/common/config/ports.py:
2361         * Scripts/webkitpy/tool/steps/runtests.py:
2362
2363 2010-10-13  Adam Barth  <abarth@webkit.org>
2364
2365         Reviewed by Eric Seidel.
2366
2367         Make --port a global option and pass the port information to the commit-queue subprocess
2368         https://bugs.webkit.org/show_bug.cgi?id=47650
2369
2370         This patch paves the way to run the commit-queue on a non-Mac port.
2371
2372         * Scripts/webkitpy/tool/commands/queues.py:
2373         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2374         * Scripts/webkitpy/tool/commands/queuestest.py:
2375         * Scripts/webkitpy/tool/main.py:
2376         * Scripts/webkitpy/tool/steps/options.py:
2377         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2378         * Scripts/webkitpy/tool/steps/runtests.py:
2379         * Scripts/webkitpy/tool/steps/update.py:
2380
2381 2010-10-13  Adam Barth  <abarth@webkit.org>
2382
2383         Reviewed by Eric Seidel.
2384
2385         Introduce the ChromiumXVFBPort for running commit-queue on EC2
2386         https://bugs.webkit.org/show_bug.cgi?id=47653
2387
2388         I'm not entirely sure this is the best way to do this, but we need to
2389         run the tests under XVFB on EC2 because the EC2 instances don't have a
2390         real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
2391         that way.  The idea is that XVFB is like a platform for the Chromium
2392         port, but we don't have a real notion of platform separate from port.
2393
2394         * Scripts/webkitpy/common/config/ports.py:
2395
2396 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
2397
2398         Reviewed by Martin Robinson.
2399
2400         [GTK] Add HTTP caching support
2401         https://bugs.webkit.org/show_bug.cgi?id=44261
2402
2403         Add include paths for the new soup HTTP cache code.
2404
2405         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
2406
2407 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
2408
2409         Reviewed by Antonio Gomes.
2410
2411         [Qt] QtTestBrowser shows two Url input fields
2412         https://bugs.webkit.org/show_bug.cgi?id=47613
2413
2414         * QtTestBrowser/mainwindow.cpp:
2415         (MainWindow::MainWindow):
2416         (MainWindow::buildUI):
2417
2418 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
2419
2420         Reviewed by Tony Chang.
2421
2422         [gdb] Add pretty-print supports for UString, Identifier and JSString
2423         https://bugs.webkit.org/show_bug.cgi?id=47601
2424
2425         * gdb/webkit.py:
2426
2427 2010-10-13  Adam Barth  <abarth@webkit.org>
2428
2429         Reviewed by Eric Seidel.
2430
2431         Add list of Ubuntu packages needed by the EWS bots
2432         https://bugs.webkit.org/show_bug.cgi?id=47628
2433
2434         I've been copy/pasting this list between bots, but it's better to have
2435         this checked in.
2436
2437         * EWSTools/ubuntu-ews-packages: Added.
2438
2439 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
2440
2441         Reviewed by Csaba Osztrogonác.
2442
2443         [EFL] Adds a build slave.
2444         https://bugs.webkit.org/show_bug.cgi?id=47290
2445
2446         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2447         entry for a release build of the EFL port.
2448         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2449         flag to build the EFL port.
2450
2451 2010-10-13  Adam Barth  <abarth@webkit.org>
2452
2453         Reviewed by Csaba Osztrogonác.
2454
2455         webkit-patch build shouldn't need --build to actually build!
2456         https://bugs.webkit.org/show_bug.cgi?id=47438
2457
2458         Yeah, requiring --build for the build command is really dumb.  We did
2459         this originally because the build step is usually optional in other
2460         commands.  We don't have a good way of reversing the default for an
2461         option in one command.  This approach is slightly hacky since --build
2462         still shows up as an option on the help page, but at least it makes
2463         progress.  Passing --build is harmless, so the EWS bots shouldn't
2464         explode because of this change.
2465
2466         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2467         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2468         * Scripts/webkitpy/tool/commands/download.py:
2469         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2470         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2471
2472 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2473
2474         Unreviewed, rolling out r69638.
2475         http://trac.webkit.org/changeset/69638
2476         https://bugs.webkit.org/show_bug.cgi?id=47595
2477
2478         "Broke win and chromium-win bots" (Requested by dglazkov on
2479         #webkit).
2480
2481         * Scripts/webkitpy/common/system/path.py:
2482         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2483         * Scripts/webkitpy/layout_tests/port/base.py:
2484         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2485         * Scripts/webkitpy/layout_tests/port/chromium.py:
2486         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2487
2488 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
2489
2490         Reviewed by Steve Block.
2491
2492         First step towards client-based Geolocation in Chromium. Build
2493         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
2494         https://bugs.webkit.org/show_bug.cgi?id=47586
2495
2496         * DumpRenderTree/chromium/WebViewHost.cpp:
2497         * DumpRenderTree/chromium/WebViewHost.h:
2498
2499 2010-10-13  Adam Roben  <aroben@apple.com>
2500
2501         Test that pressing the spacebar in a text field does not scroll the
2502         document
2503
2504         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
2505         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
2506         insert a space, scrolls the page instead
2507
2508         Reviewed by Sam Weinig.
2509
2510         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
2511
2512         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
2513
2514         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2515         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2516         * TestWebKitAPI/win/copy-resources.cmd:
2517         Added new files.
2518
2519         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
2520         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
2521         We use this to track what the result of calling into JavaScript was.
2522         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
2523         finishes loading.
2524         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
2525         event is not handled.
2526         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
2527         executing and whether the result matched our expectation.
2528         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
2529         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
2530         complete, and returns whether we got back the expected result.
2531         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
2532         spacebar inside a text field does not scroll the document and that
2533         pressing it outside the text field does scroll the document.
2534
2535         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
2536
2537         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2538         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
2539
2540         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2541         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
2542         code from DRT's EventSendingController.
2543
2544         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2545         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
2546
2547         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2548         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
2549         same messages that get sent when you press spacebar in Notepad.
2550
2551 2010-10-13  Adam Roben  <aroben@apple.com>
2552
2553         Fix a couple of issues with the TestWebKitAPI build
2554
2555         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
2556         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
2557         Fixed a typo.
2558
2559         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
2560         to set our output and intermediate directories so that we don't spew
2561         files into the source tree.
2562
2563 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
2564
2565         Reviewed by Csaba Osztrogonác.
2566
2567         WTR should accept relative paths
2568         https://bugs.webkit.org/show_bug.cgi?id=47486
2569
2570         * WebKitTestRunner/StringFunctions.h:
2571         * WebKitTestRunner/TestInvocation.cpp:
2572         (WTR::createWKURL): Moved from StringFunctions.h since it is
2573         used only here. Extend relative paths to absolute.
2574
2575 2010-10-12  Adam Roben  <aroben@apple.com>
2576
2577         Make TestWebKitAPI work on Windows
2578
2579         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
2580
2581         Reviewed by Sam Weinig.
2582
2583         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
2584
2585         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
2586         run on Windows.
2587         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
2588         on unsupported platforms.
2589         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
2590         die on other platforms. Extracted some formerly-Mac-specific code to
2591         be cross-platform and made it handle any style of line-endings.
2592
2593         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
2594         Links against CFLite.
2595
2596         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
2597         Contains most properties for the project.
2598
2599         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
2600         Added. Links against CoreFoundation.
2601
2602         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
2603         section and moved the cross-platform section after the
2604         platform-specific parts.
2605
2606         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2607         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
2608         done.
2609         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
2610         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
2611         resource path.
2612         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
2613         WKURL.
2614
2615         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2616         (TestWebKitAPI::registerWindowClass):
2617         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2618         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2619         (TestWebKitAPI::PlatformWebView::page):
2620         This was mostly copied from WebKitTestRunner's PlatformWebView.
2621
2622         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
2623         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
2624         build-api-tests script.
2625
2626         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
2627         TestWebKitAPI.exe.
2628
2629         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
2630         through to copy-resources.cmd.
2631
2632         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
2633         or deletes resources from TestWebKitAPI.resources.
2634
2635         * TestWebKitAPI/win/main.cpp: Added.
2636         (main): Calls through to TestsController.
2637
2638 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2639
2640         Reviewed by Kenneth Rohde Christiansen.
2641
2642         [EFL] Support viewport configuration and add new arguments for WebKit EFL
2643         https://bugs.webkit.org/show_bug.cgi?id=47084
2644
2645         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
2646         needs to be modified according to the changes.
2647
2648         * EWebLauncher/main.c:
2649         (on_viewport_changed):
2650
2651 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
2652
2653         Reviewed by Eric Seidel.
2654
2655         This patch enables new-run-webkit-tests (in particular the
2656         chromium-win port) to run under Cygwin as well as Win32. Mostly
2657         this just required some conversions from cygwin paths to Win32
2658         paths when we spawn off Win32 binaries like test_shell.
2659
2660         https://bugs.webkit.org/show_bug.cgi?id=47220
2661
2662         * Scripts/webkitpy/common/system/path.py:
2663         - Expose the cygpath() function for path conversion
2664
2665         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2666         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2667         - shift filename->uri conversion in the TestInfo objects to the
2668           dump_render_tree thread
2669
2670         * Scripts/webkitpy/layout_tests/port/base.py:
2671         * Scripts/webkitpy/layout_tests/port/chromium.py:
2672         - use cygpath()
2673
2674 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
2675
2676         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
2677
2678         * Scripts/webkitpy/common/config/committers.py:
2679
2680 2010-10-12  Sam Weinig  <sam@webkit.org>
2681
2682         Reviewed by Dan Bernstein.
2683
2684         When a provisional load fails, the provisional URL returned
2685         from WKFrameCopyProvisionalURL should be empty
2686         <rdar://problem/8540878>
2687         https://bugs.webkit.org/show_bug.cgi?id=47546
2688
2689         Add test.
2690
2691         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2692         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2693
2694 2010-10-12  Anders Carlsson  <andersca@apple.com>
2695
2696         Reviewed by Sam Weinig.
2697
2698         Start fleshing out find page overlays
2699         https://bugs.webkit.org/show_bug.cgi?id=47559
2700
2701         * MiniBrowser/mac/BrowserWindowController.m:
2702         (-[BrowserWindowController find:]):
2703         Pass kWKFindOptionsShowOverlay to WKPageFindString.
2704
2705 2010-10-12  Robert Hogan  <robert@webkit.org>
2706
2707         Reviewed by Antonio Gomes.
2708
2709         [Qt] editing/input/emacs-ctrl-o.html
2710
2711         ctrl-o is bound to a sequence of commands on Mac, namely:
2712         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
2713         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
2714         result we only issue one command, so don't generate the change in caret
2715         position that results in the extra editing delegate messages.
2716
2717         So for the sake of not managing suspicious-looking differences, just
2718         make DRT issue the appropriate edit commands to pass the test.
2719
2720         https://bugs.webkit.org/show_bug.cgi?id=47548
2721
2722         * DumpRenderTree/qt/EventSenderQt.cpp:
2723         (EventSender::keyDown):
2724
2725 2010-10-12  Anders Carlsson  <andersca@apple.com>
2726
2727         Reviewed by Sam Weinig.
2728
2729         Add a simple Find UI to MiniBrowser
2730         https://bugs.webkit.org/show_bug.cgi?id=47553
2731
2732         * MiniBrowser/mac/BrowserWindow.xib:
2733         Add Find panel.
2734
2735         * MiniBrowser/mac/BrowserWindowController.h:
2736         * MiniBrowser/mac/BrowserWindowController.m:
2737         (-[BrowserWindowController performFindPanelAction:]):
2738         Show the find panel.
2739
2740         (-[BrowserWindowController find:]):
2741         Tell the WKPageRef to find the given string.
2742
2743 2010-10-12  Tony Chang  <tony@chromium.org>
2744
2745         Unreviewed, fixing DRT compile on Windows after r69586.
2746
2747         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2748
2749 2010-10-12  Tony Chang  <tony@chromium.org>
2750
2751         Unreviewed, trying to fix NRWT on Windows.
2752
2753         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2754
2755 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
2756
2757         Reviewed by Kenneth Rohde Christiansen.
2758
2759         [Qt][WTR] Checking the path of the injected bundle is bogus
2760         https://bugs.webkit.org/show_bug.cgi?id=47541
2761
2762         * WebKitTestRunner/qt/TestControllerQt.cpp:
2763         (WTR::isExistingLibrary): Added (static helper).
2764         Extend the path with the appropriate suffix(es) on the
2765         platform and check that the file exists.
2766         (WTR::TestController::initializeInjectedBundlePath):
2767         There were two bugs with the path checking:
2768             - the condition should have been inverted
2769             - QLibrary::fileName does not give back the filename
2770               with the library suffix so we cannot check
2771               that existance of the file this way.
2772
2773 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2774
2775         Reviewed by Tony Chang.
2776
2777         Implement http locking in NRWT.
2778         https://bugs.webkit.org/show_bug.cgi?id=47072
2779
2780         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2781         * Scripts/webkitpy/layout_tests/port/base.py:
2782         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
2783         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
2784         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2785
2786 2010-10-12  Mark Rowe  <mrowe@apple.com>
2787
2788         Fix the 32-bit WebKit2 build.
2789
2790         * MiniBrowser/mac/BrowserWindowController.m:
2791         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
2792         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
2793
2794 2010-10-11  Tony Chang  <tony@chromium.org>
2795
2796         Reviewed by Adam Barth.
2797
2798         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
2799         https://bugs.webkit.org/show_bug.cgi?id=47513
2800
2801         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
2802         which doesn't actually work.
2803
2804         * Scripts/webkitpy/common/config/committers.py:
2805
2806 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
2807
2808         Reviewed by Dmitry Titov.
2809
2810         Added support for showModalDialog on chromium port.
2811
2812         Implement showModalDialog for Layout tests for chromium port
2813         https://bugs.webkit.org/show_bug.cgi?id=46759
2814
2815         * DumpRenderTree/chromium/WebViewHost.cpp:
2816         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
2817         (WebViewHost::runModal):  Start a nested message loop and remember that.
2818         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
2819         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
2820
2821 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
2822
2823         Reviewed by Gustavo Noronha Silva.
2824
2825         [GTK] Cleanup font selection code for the Freetype backend
2826         https://bugs.webkit.org/show_bug.cgi?id=47503
2827
2828         Update DRT to set values for the cursive and fantasy font families, so
2829         that we can generate consistent results for tests that use these families.
2830         Add some missing information to fonts.conf.
2831
2832         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2833         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
2834         family names.
2835         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
2836         to our default serif font. Eventually we may want to import or require some "real"
2837         fonts, but this should at least ensure consistent rendering during test runs. Also
2838         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
2839         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
2840         in some incorrect baselines for the synthetic oblique test.
2841
2842 2010-10-11  Adam Barth  <abarth@webkit.org>
2843
2844         Unreviewed.
2845
2846         Fix sheriffbot not to crash when there are failing tests.  It turns out
2847         Python sets don't support the + operator.  We need to use union
2848         instead.  There's a more elegant way to do this in Python 2.6, but we
2849         need this code to work in 2.5.
2850
2851         * Scripts/webkitpy/common/net/failuremap.py:
2852         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2853
2854 2010-10-10  Robert Hogan  <robert@webkit.org>
2855
2856         Unreviewed, fix failing test from r69468.
2857
2858         [Qt] Put all DRT-created pages in a page group
2859
2860         Fix on r69468.
2861
2862         Because we don't delete closed pages immediately in DRT we need
2863         to remove them from the page group explicitly instead.
2864
2865         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
2866
2867         https://bugs.webkit.org/show_bug.cgi?id=47469
2868
2869         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2870         (WebCore::DumpRenderTree::windowCloseRequested):
2871
2872 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
2873
2874         Reviewed by Adam Barth.
2875
2876         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
2877         EFL-EWS bot is up and running.
2878         https://bugs.webkit.org/show_bug.cgi?id=47277
2879
2880         * QueueStatusServer/handlers/statusbubble.py:
2881
2882 2010-10-10  Robert Hogan  <robert@webkit.org>
2883
2884         Reviewed by Antonio Gomes.
2885
2886         [Qt] Put all DRT-created pages in a page group
2887
2888         https://bugs.webkit.org/show_bug.cgi?id=47469
2889
2890         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2891         (WebCore::DumpRenderTree::DumpRenderTree):
2892         (WebCore::DumpRenderTree::createWindow):
2893
2894 2010-10-09  Sam Weinig  <sam@webkit.org>
2895
2896         Reviewed by Dan Bernstein.
2897
2898         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
2899         <rdar://problem/8173667>
2900         https://bugs.webkit.org/show_bug.cgi?id=47461
2901
2902         * TestWebKitAPI/PlatformUtilities.h:
2903         * TestWebKitAPI/Test.h:
2904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2905         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
2906         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2907         (TestWebKitAPI::TEST):
2908         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2909         (TestWebKitAPI::Util::URLForNonExistentResource):
2910         Adds a test for the frame load state after a failed provisional load. I wanted to test
2911         the frame load state after a committed load failed, but I don't believe that is possible
2912         to do without hooking up the http server to serve a long loading page.
2913
2914 2010-10-09  Sam Weinig  <sam@webkit.org>
2915
2916         Reviewed by Dan Bernstein.
2917
2918         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
2919         <rdar://problem/8447690>
2920         https://bugs.webkit.org/show_bug.cgi?id=47459
2921
2922         * MiniBrowser/mac/BrowserWindowController.m:
2923         (runBeforeUnloadConfirmPanel):
2924         (-[BrowserWindowController awakeFromNib]):
2925         * WebKitTestRunner/TestController.cpp:
2926         (WTR::createOtherPage):
2927         (WTR::TestController::initialize):
2928
2929 2010-10-09  Sam Weinig  <sam@webkit.org>
2930
2931         Reviewed by Dan Bernstein.
2932
2933         Need implementation of ChromeClient windowRect related functions.
2934         <rdar://problem/8469476>
2935         https://bugs.webkit.org/show_bug.cgi?id=47386
2936
2937         * MiniBrowser/mac/BrowserWindowController.m:
2938         (getWindowFrame):
2939         (setWindowFrame):
2940         (-[BrowserWindowController awakeFromNib]):
2941         * WebKitTestRunner/PlatformWebView.h:
2942         * WebKitTestRunner/TestController.cpp:
2943         (WTR::TestController::initialize):
2944         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2945         (WTR::PlatformWebView::windowFrame):
2946         (WTR::PlatformWebView::setWindowFrame):
2947         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2948         (WTR::PlatformWebView::windowFrame):
2949         (WTR::PlatformWebView::setWindowFrame):
2950         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2951         (WTR::PlatformWebView::windowFrame):
2952         (WTR::PlatformWebView::setWindowFrame):
2953
2954 2010-10-08  Adam Barth  <abarth@webkit.org>
2955
2956         Unreviewed (Eric is on vacation in this change is trivial).
2957
2958         Add a "clean" command to webkit-patch to clean the working directory
2959         https://bugs.webkit.org/show_bug.cgi?id=47436
2960
2961         This command is useful when using SVN because "svn revert" leaves
2962         unversioned files behind.
2963
2964         * Scripts/webkitpy/tool/commands/download.py:
2965
2966 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2967
2968         Unreviewed build fix.
2969
2970         [Qt] Add missing limits.h include since the Qt version currently
2971         ran on the bot does need that.
2972
2973         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2974
2975 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2976
2977         Reviewed by Csaba Osztrogonác.
2978
2979         [Qt] Turn on building WTR
2980         https://bugs.webkit.org/show_bug.cgi?id=47349
2981
2982         * Scripts/webkitdirs.pm:
2983
2984 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2985
2986         Reviewed by Andreas Kling.
2987
2988         [Qt] TestController needs its platform dependent methods
2989         https://bugs.webkit.org/show_bug.cgi?id=47413
2990
2991         * WebKitTestRunner/qt/TestControllerQt.cpp:
2992         (WTR::TestController::initializeInjectedBundlePath):
2993         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
2994         set then use that otherwise use the path where the bundle
2995         lives in a normal trunk build.
2996         (WTR::TestController::initializeTestPluginDirectory):
2997         Set the bundle's value. It is not used currently.
2998         (WTR::TestController::platformInitializeContext):
2999         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3000
3001 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3002
3003         Reviewed by Kenneth Rohde Christiansen.
3004
3005         WTR: Prevent sending the Done message twice on test timeout.
3006         https://bugs.webkit.org/show_bug.cgi?id=47410
3007
3008         When InjectedBundle::done() calls stopLoading, this may trigger
3009         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
3010         InjectedBundle::done() itself later in the stack.
3011         This would output the timeout failure message twice and confuse
3012         the run-webkit-tests script.
3013
3014         This patch adds a third state, Stopping, which prevents WebCore
3015         errors to trigger done() when testing is over.
3016
3017         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3018         (WTR::InjectedBundle::done):
3019         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3020
3021 2010-10-08  Andras Becsi  <abecsi@webkit.org>
3022
3023         Reviewed by Kenneth Rohde Christiansen.
3024
3025         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
3026         Original code by Simon Hausmann.
3027         https://bugs.webkit.org/show_bug.cgi?id=47402
3028
3029         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
3030         (WTR::activateFonts):
3031
3032 2010-10-08  Andras Becsi  <abecsi@webkit.org>
3033
3034         Reviewed by Csaba Osztrogonác.
3035
3036         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
3037         https://bugs.webkit.org/show_bug.cgi?id=47401
3038
3039         * Scripts/build-webkittestrunner:
3040         * Scripts/old-run-webkit-tests:
3041
3042 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3043
3044         Reviewed by Kenneth Rohde Christiansen.
3045
3046         [Qt] WTR first compile: fix compile issues.
3047         https://bugs.webkit.org/show_bug.cgi?id=47343
3048
3049         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
3050         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3051         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3052         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3053         * WebKitTestRunner/TestController.cpp:
3054         * WebKitTestRunner/TestInvocation.cpp:
3055
3056 2010-10-07  Antonio Gomes  <agomes@rim.com>
3057
3058         Reviewed by Simon Fraser.
3059
3060         [Mac] [DRT] implement setSpatialNavigationEnabled
3061         https://bugs.webkit.org/show_bug.cgi?id=47291
3062
3063         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
3064         so it can track regression on the existing implementation and future improvements
3065         we are making.
3066
3067         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3068         (LayoutTestController::setSpatialNavigationEnabled):
3069
3070 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
3071
3072         Reviewed by Adam Barth.
3073
3074         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
3075         hook in the Port infrastructure to generate URIs for the files
3076         in its summary HTML report; however, that method is supposed to only
3077         be used for test files (and should really be renamed), so this would
3078         crash.
3079
3080         This change adds a new "path" module to the system package with a
3081         routine called abspath_to_uri() that handles converting paths to
3082         file: URIs independently of anything in the layout_tests package,
3083         and changes the code to use this. At some point in the near future
3084         the layout_tests/port/* code should use this as well.
3085
3086         This change also deletes a bunch of unused code and fixes some
3087         comments in rebaseline_chromium_webkit_tests.py.
3088
3089         https://bugs.webkit.org/show_bug.cgi?id=47319
3090
3091         * Scripts/webkitpy/common/system/path.py: Added.
3092         * Scripts/webkitpy/common/system/path_unittest.py: Added.
3093         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3094         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3095
3096 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
3097
3098         Reviewed by Gustavo Noronha Silva.
3099
3100         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
3101         https://bugs.webkit.org/show_bug.cgi?id=46216
3102
3103         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
3104
3105         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3106         (initializeFonts): Also initialize the DevaVu Sans font.
3107
3108 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
3109
3110         Reviewed by Tony Chang.
3111
3112         [chromium] Minor naming cleanup in WebDragData, part 2
3113         https://bugs.webkit.org/show_bug.cgi?id=47227
3114
3115         Update DRT to use the renamed methods.
3116
3117         * DumpRenderTree/chromium/EventSender.cpp:
3118         (EventSender::beginDragWithFiles):
3119         * DumpRenderTree/chromium/WebViewHost.cpp:
3120         (addDRTFakeFileToDataObject):
3121
3122 2010-10-07  Anders Carlsson  <andersca@apple.com>
3123
3124         Reviewed by Sam Weinig.
3125
3126         Add a WKPageFindClient, hook up WKPageCountStringMatches
3127         https://bugs.webkit.org/show_bug.cgi?id=47373
3128
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         Remove hard coded paths.
3131
3132         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3133         (TestWebKitAPI::TEST):
3134         Fix expected result.
3135
3136         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
3137         (TestWebKitAPI::didFinishLoadForFrame):
3138         (TestWebKitAPI::didCountStringMatches):
3139         (TestWebKitAPI::TEST):
3140         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
3141         Add test for WKPageCountStringMatches.
3142
3143 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
3144
3145         Reviewed by Chris Fleizach.
3146
3147         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
3148         https://bugs.webkit.org/show_bug.cgi?id=46216
3149
3150         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
3151         for DejaVu Serif when there is no bold version available. This is necessary to
3152         properly test the property in layout tests.
3153
3154 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
3155
3156         Reviewed by Kenneth Rohde Christiansen.
3157
3158         [Qt] Add WTR's InjectedBundle build files.
3159         https://bugs.webkit.org/show_bug.cgi?id=47333
3160
3161         * Scripts/webkitdirs.pm:
3162         * WebKitTestRunner/DerivedSources.pro: Added.
3163         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
3164         * WebKitTestRunner/WebKitTestRunner.pro: Added.
3165         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
3166         Content merged in ../DerivedSources.pro
3167
3168 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3169
3170         Unreviewed, rolling out r69315.
3171         http://trac.webkit.org/changeset/69315
3172         https://bugs.webkit.org/show_bug.cgi?id=47363
3173
3174         Forgot to add the new files (Requested by kbalazs on #webkit).
3175
3176         * Scripts/webkitdirs.pm:
3177         * WebKitTestRunner/qt/DerivedSources.pro: Added.
3178
3179 2010-10-07  Sam Weinig  <sam@webkit.org>
3180
3181         Reviewed by Anders Carlsson.
3182
3183         Change API tester to ask the executable for the list of all
3184         tests instead of relying on the directory structure.
3185         https://bugs.webkit.org/show_bug.cgi?id=47359
3186
3187         * Scripts/run-test-webkit-api: Added.
3188         * Scripts/webkitdirs.pm:
3189         Add additional script to just launch the api tester with the correct settings.
3190
3191         * Scripts/run-api-tests:
3192         Change to use the new --dump-tests options to build the list of tests and change
3193         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
3194
3195         * TestWebKitAPI/Test.h:
3196         (TestWebKitAPI::Test::Register::Register):
3197         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3198         (TestWebKitAPI::TEST):
3199         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3200         (TestWebKitAPI::TEST):
3201         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3202         (TestWebKitAPI::TEST):
3203         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3204         (TestWebKitAPI::TEST):
3205         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3206         (TestWebKitAPI::TEST):
3207         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3208         (TestWebKitAPI::TEST):
3209         Give each test a suite name in addition to the test name.
3210
3211         * TestWebKitAPI/TestsController.cpp:
3212         (TestWebKitAPI::TestsController::dumpTestNames):
3213         (TestWebKitAPI::TestsController::runTestNamed):
3214         * TestWebKitAPI/TestsController.h:
3215         * TestWebKitAPI/mac/main.mm:
3216         (main):
3217         Add option to print all registered tests.
3218
3219 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
3220
3221         Reviewed by Kenneth Rohde Christiansen.
3222
3223         [Qt] Add WTR's InjectedBundle build files.
3224         https://bugs.webkit.org/show_bug.cgi?id=47333
3225
3226         * Scripts/webkitdirs.pm:
3227         * WebKitTestRunner/DerivedSources.pro: Added.
3228         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
3229         * WebKitTestRunner/WebKitTestRunner.pro: Added.
3230         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
3231         Content merged in ../DerivedSources.pro
3232
3233 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
3234
3235         Unreviewed. Do a renaming that was recommended by the reviewer
3236         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
3237
3238         * WebKitTestRunner/qt/TestControllerQt.cpp:
3239         (WTR::RunUntilConditionLoop::start):
3240         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
3241         (WTR::TestController::runUntil):
3242
3243 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
3244
3245         Reviewed by Kenneth Rohde Christiansen.
3246
3247         [Qt] Watchdog timer implementation for WTR
3248         https://bugs.webkit.org/show_bug.cgi?id=47337
3249
3250         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
3251         the definition of the timer type to a typedef.
3252         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
3253         Timer implementation with QTimer and a helper QObject class.
3254         (WTR::WatchdogTimerHelper::instance):
3255         (WTR::WatchdogTimerHelper::timerFired):
3256         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
3257         (WTR::LayoutTestController::platformInitialize):
3258         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
3259         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3260
3261 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
3262
3263         Unreviewed buildfix for 69297 again
3264
3265         * WebKitTestRunner/TestController.cpp:
3266         (WTR::blankURL):
3267
3268 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
3269
3270         Unreviewed trivial build fix for r69297
3271
3272         * WebKitTestRunner/TestController.cpp:
3273         (WTR::blankURL):
3274
3275 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
3276
3277         Reviewed by Kenneth Rohde Christiansen.
3278
3279         WebKitTestRunner should be portable
3280         https://bugs.webkit.org/show_bug.cgi?id=45393
3281
3282         Use only the WebKit API for working with urls.
3283         * WebKitTestRunner/StringFunctions.h:
3284         (WTR::createWKURL):
3285         * WebKitTestRunner/TestController.cpp:
3286         (WTR::blankURL):
3287         (WTR::TestController::resetStateToConsistentValues):
3288         (WTR::TestController::didFinishLoadForFrame):
3289
3290 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3291
3292         Reviewed by Xan Lopez.
3293
3294         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
3295         https://bugs.webkit.org/show_bug.cgi?id=47332
3296
3297         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3298         (createBitmapContextFromWebView):
3299
3300 2010-10-06  Chris Guillory  <chris.guillory@google.com>
3301
3302         Reviewed by Chris Fleizach.
3303
3304         Remove unused accessibility functions from webkit.
3305         https://bugs.webkit.org/attachment.cgi?bugid=46707
3306
3307         * DumpRenderTree/chromium/WebViewHost.cpp:
3308         (WebViewHost::postAccessibilityNotification):
3309         * DumpRenderTree/chromium/WebViewHost.h:
3310
3311 2010-10-06  Lucas Forschler  <lforschler@apple.com>
3312
3313         Reviewed by Adam Roben.
3314
3315         Fix the sunspider-compare-results to actually use the passed in value for $root.
3316
3317         * Scripts/sunspider-compare-results:
3318
3319 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
3320
3321         Reviewed by Kenneth Rohde Christiansen.
3322
3323         [Qt] Runloop implementation for WTR
3324         https://bugs.webkit.org/show_bug.cgi?id=47280
3325
3326         * WebKitTestRunner/qt/TestControllerQt.cpp:
3327         Implemented TestController::runUntil by a timerEvent
3328         and a QEventLoop. We step into the event loop from runUntil.
3329         While we are waiting in the loop a timerEvent is periodically
3330         checking the value of the condition. Once the condition has
3331         becoming true the timerEvent wakes us up.
3332         (WTR::RunUntilLoop::start):
3333         (WTR::RunUntilLoop::RunUntilLoop):
3334         (WTR::RunUntilLoop::run):
3335         (WTR::RunUntilLoop::timerEvent):
3336         (WTR::TestController::platformInitialize):
3337         (WTR::TestController::runUntil):
3338         * WebKitTestRunner/qt/main.cpp:
3339         Start the main event loop first and creating the TestController later.
3340         (Launcher::Launcher):
3341         (Launcher::~Launcher):
3342         (Launcher::launch): Creating the TestController.
3343         (main): Setting up a timer for calling Launcher::launch from
3344         the main event loop.
3345
3346 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
3347
3348         Reviewed by Kenneth Russell.
3349
3350         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
3351         enable 'accelerated-composting' instead of 'accelerated-compositing'.
3352
3353         https://bugs.webkit.org/show_bug.cgi?id=47312
3354
3355         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3356         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3357
3358 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
3359
3360         Reviewed by Kenneth Rohde Christiansen.
3361
3362         [Qt] PlatformWebView implementation for WebKitTestRunner
3363         https://bugs.webkit.org/show_bug.cgi?id=47276
3364
3365         The implementation follows the way how
3366         we use the API in MiniBrowser.
3367         * WebKitTestRunner/PlatformWebView.h:
3368         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3369         (WTR::WebView::wkView):
3370         (WTR::WebView::~WebView):
3371         (WTR::WebView::WebView):
3372         (WTR::PlatformWebView::PlatformWebView):
3373         (WTR::PlatformWebView::~PlatformWebView):
3374         (WTR::PlatformWebView::resizeTo):
3375         (WTR::PlatformWebView::page):
3376         (WTR::PlatformWebView::focus):
3377         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3378
3379 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
3380
3381         Reviewed by Kenneth Rohde Christiansen.
3382
3383         [Qt] Add WebKitTestRunner's build files
3384         https://bugs.webkit.org/show_bug.cgi?id=44155
3385
3386         Parts was taken by Zoltan Horvath's patch.
3387
3388         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
3389         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
3390         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
3391         PlatformWKView and PlatformWindow (void* for now).
3392         Buildfix the case when __APPLE__ is not defined.
3393         * WebKitTestRunner/qt/DerivedSources.pro: Added.
3394         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
3395         Empty stub implementation.
3396         (WTR::registerWindowClass):
3397         (WTR::PlatformWebView::PlatformWebView):
3398         (WTR::PlatformWebView::~PlatformWebView):
3399         (WTR::PlatformWebView::resizeTo):
3400         (WTR::PlatformWebView::page):
3401         (WTR::PlatformWebView::focus):
3402         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
3403         Empty stub implementation.
3404         (WTR::registerWindowClass):
3405         (WTR::TestController::runUntil):
3406         (WTR::TestController::platformInitialize):
3407         (WTR::TestController::initializeInjectedBundlePath):
3408         (WTR::TestController::initializeTestPluginDirectory):
3409         (WTR::TestController::platformInitializeContext):
3410         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
3411         * WebKitTestRunner/qt/main.cpp: Added.
3412         (main):
3413
3414 2010-10-06  Tony Chang  <tony@chromium.org>
3415
3416         Unreviewed, rolling out r69202.
3417         http://trac.webkit.org/changeset/69202
3418         https://bugs.webkit.org/show_bug.cgi?id=46937
3419
3420         Broke compile of test_shell
3421
3422         * DumpRenderTree/chromium/EventSender.cpp:
3423         (EventSender::beginDragWithFiles):
3424         * DumpRenderTree/chromium/WebViewHost.cpp:
3425         (addDRTFakeFileToDataObject):
3426
3427 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
3428
3429         Reviewed by Tony Chang.
3430
3431         [chromium] Minor naming cleanup in WebDragData, part 2
3432         https://bugs.webkit.org/show_bug.cgi?id=46937
3433
3434         Update DRT to use the renamed methods.
3435
3436         * DumpRenderTree/chromium/EventSender.cpp:
3437         (EventSender::beginDragWithFiles):
3438         * DumpRenderTree/chromium/WebViewHost.cpp:
3439         (addDRTFakeFileToDataObject):
3440
3441 2010-10-06  David Kilzer  <ddkilzer@apple.com>
3442
3443         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
3444
3445         Reviewed by Adam Roben.
3446
3447         This is the first step in making webarchive tests work on
3448         Windows.
3449
3450         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
3451         new files to the project.
3452         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
3453         to WebArchiveDumpSupport.mm.
3454         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
3455         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
3456         (serializeWebArchiveToXML):
3457
3458 2010-10-05  Daniel Bates  <dbates@rim.com>
3459
3460         Reviewed by David Kilzer.
3461
3462         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
3463         https://bugs.webkit.org/show_bug.cgi?id=46058
3464
3465         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
3466         structure so as to support returning additional information
3467         about a change log diff.
3468
3469         Currently, VCSUtils::fixChangeLogPatch() returns a string that
3470         represents the change log diff. Towards supporting the return
3471         of additional information, such as whether the change log diff
3472         inserts an entry at the top of the ChangeLog file, we need to
3473         make VCSUtils::fixChangeLogPatch() return a reference to hash
3474         structure.
3475
3476         * Scripts/VCSUtils.pm:
3477           - Modified fixChangeLogPatch() to return a reference to a
3478             hash structure.
3479           - Added documentation to fixChangeLogPatch().
3480           - Modified call site in mergeChangeLogs() as necessary.
3481         * Scripts/svn-apply:
3482           - Modified call site in patch() as necessary.
3483         * Scripts/svn-create-patch:
3484           - Modified call site in generateDiff() as necessary.
3485         * Scripts/svn-unapply:
3486           - Modified call site in patch() as necessary.
3487         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3488           - Modified the unit tests as necessary.
3489
3490 2010-10-05  Tony Chang  <tony@chromium.org>
3491
3492         Reviewed by Darin Adler.
3493
3494         fix the link to the expected image on windows
3495         https://bugs.webkit.org/show_bug.cgi?id=47228
3496
3497         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
3498             windows, the file must be opened in binary mode when writing
3499             binary data.
3500
3501 2010-10-05  Adam Barth  <abarth@webkit.org>
3502
3503         Update expected result of unittest to match Tony's change below.
3504
3505         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3506
3507 2010-10-05  Tony Chang  <tony@chromium.org>
3508
3509         Reviewed by Ojan Vafai (over the shoulder).
3510
3511         Paper over errors in image_diff so we don't crash the whole test run.
3512
3513         * Scripts/webkitpy/layout_tests/port/chromium.py:
3514
3515 2010-10-05  Tony Chang  <tony@chromium.org>
3516
3517         Unreviewed, make shutil.rmtree more resiliant to errors
3518         since windows was raising WindowsError: The process cannot access the file because it
3519         is being used by another process.
3520
3521         * Scripts/webkitpy/layout_tests/port/chromium.py:
3522
3523 2010-10-05  Tony Chang  <tony@chromium.org>
3524
3525         Reviewed by Ojan Vafai.
3526
3527         [chromium] fix image diffing in NRWT
3528         https://bugs.webkit.org/show_bug.cgi?id=47128
3529
3530         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
3531             NamedTemporaryFile since it doesn't work on Windows.
3532         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3533
3534 2010-10-05  Kenneth Russell  <kbr@google.com>
3535
3536         Reviewed by Tony Chang.
3537
3538         [chromium] Implement layerTreeAsText in DumpRenderTree
3539         https://bugs.webkit.org/show_bug.cgi?id=47216
3540
3541         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
3542         make it callable from DumpRenderTree.
3543
3544         No new tests; verified with existing compositor layout tests.
3545
3546         * DumpRenderTree/chromium/LayoutTestController.cpp:
3547         (LayoutTestController::LayoutTestController):
3548         (LayoutTestController::layerTreeAsText):
3549         * DumpRenderTree/chromium/LayoutTestController.h:
3550
3551 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
3552
3553         Unreviewed build correction.
3554
3555         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
3556         property sheet so proper libraries are linked.
3557
3558 2010-10-05  Robert Hogan  <robert@webkit.org>
3559
3560         Reviewed by Andreas Kling.
3561
3562         [Qt] Fix url conversion in QWebHistory
3563
3564         Converting from KURL to WFT::String to QUrl does not
3565         permit proper percent encoding later.
3566
3567         https://bugs.webkit.org/show_bug.cgi?id=47048
3568
3569         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3570         (WebCore::dumpHistoryItem):
3571
3572 2010-10-05  Anders Carlsson  <andersca@apple.com>
3573
3574         Reviewed by Sam Weinig.
3575
3576         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
3577         https://bugs.webkit.org/show_bug.cgi?id=47188
3578         <rdar://problem/8514104>