Holger Hans Peter Freyther <holger.freyther@trolltech.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
2
3         Reviewed by Lars Knoll <lars@trolltech.com>.
4
5         Reworked the JavaScriptCore Qt bindings:
6         
7         * Update JS DRT controller for Qt JS binding changes.
8         There were two functions that needed some changes
9         so that the layout tests would work, so this makes
10         a few tests pass again.
11         
12         * Bump the timeout for layout tests up to 11s.
13         At least some tests have an internal timeout of
14         10 seconds, so make the waitUntilDone approach
15         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
16         is one of these - now the failure message is more
17         accurate.
18         
19
20         * DumpRenderTree/qt/jsobjects.cpp:
21         (LayoutTestController::waitUntilDone):
22         * DumpRenderTree/qt/jsobjects.h:
23
24 2008-01-22  Anders Carlsson  <andersca@apple.com>
25
26         Reviewed by Darin and Adam.
27
28         <rdar://problem/5688975>
29         div element on microsoft site has wrong left offset.
30         
31         Add new method for testing the return vale of NPN_GetProperty.
32         
33         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
34         (pluginInvoke):
35
36 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
37
38         Reviewed by Adam Roben.
39
40         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
41
42         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
43
44 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
45
46         Reviewed by Alp Toker.
47
48         http://bugs.webkit.org/show_bug.cgi?id=16955
49         Get errors when cross-compile webkit-gtk
50
51         * GNUmakefile.am: Removed ICU_CFLAGS 
52
53 2008-01-21  Darin Adler  <darin@apple.com>
54
55         Reviewed by Mitz and Adam.
56
57         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
58         sorting speed by doing all sort criteria in a single pass instead of three sorts.
59
60 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
61
62         Reviewed by Holger.
63
64         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
65         
66         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
67         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
68         and make the return value depend on whether we successfully determined a focusable
69         node or not.
70         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
71         if we could not handle the focus chain ourselves.
72         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
73         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
74         used to control the situation of stepping out of the focus chain inside the page.
75         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
76         The layout tests expect this to be disabled but for the user it seems sensible to have it
77         on by default, hence the default in qwebsettings.cpp
78         
79
80         * DumpRenderTree/qt/DumpRenderTree.cpp:
81         (WebCore::WebPage::WebPage):
82
83 2008-01-19  Mark Rowe  <mrowe@apple.com>
84
85         Reviewed by Alp Toker.
86
87         Allow the --http flag to run-webkit-tests to override
88         the default behaviour of disabling HTTP tests for Qt,
89         Gtk and Wx.
90
91         * Scripts/run-webkit-tests:
92
93 2008-01-19  David Kilzer  <ddkilzer@apple.com>
94
95         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
96
97         Reviewed by Darin.
98
99         We now touch a check-for-global-initializers.timestamp file in
100         the TARGET_TEMP_DIR directory to determine when new object files
101         have been compiled and thus need to be checked.  If the timestamp
102         file doesn't exist, all object files will be checked.
103
104         Previously the modification time of the "executable" (the
105         framework binary, e.g., WebKit.framework/WebKit) was used, but
106         since this was the last file modified at the end of the compile
107         phase, no object files would ever get checked!
108
109         Also added JSCustomSQLTransactionCallback.o to the list of files
110         since it has static initializers in Debug builds of WebCore.
111
112         * Scripts/check-for-global-initializers:
113
114 2008-01-18  Adam Roben  <aroben@apple.com>
115
116         Build fix
117
118         * Scripts/build-webkit:
119
120 2008-01-18  Beth Dakin  <bdakin@apple.com>
121
122         Reviewed by Oliver.
123
124         Update build-webkit to account for foreign-object being disabled by 
125         default.
126
127         * Scripts/build-webkit:
128
129 2008-01-18  Adam Roben  <aroben@apple.com>
130
131         Updated for method renames
132
133         Reviewed by Adele.
134
135         * DumpRenderTree/mac/FrameLoadDelegate.mm:
136         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
138         (LayoutTestController::setMainFrameIsFirstResponder):
139         (LayoutTestController::setWindowIsKey):
140         * DumpRenderTree/mac/UIDelegate.mm:
141         (-[UIDelegate webViewFocus:]):
142         * DumpRenderTree/win/FrameLoadDelegate.cpp:
143         (FrameLoadDelegate::didCommitLoadForFrame):
144
145 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
146
147         Reviewed by Adam Roben.
148
149         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
150         between DRT and TestNetscapePlugin.
151
152         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
153         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
154
155 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
156
157         Reviewed by Holger.
158
159         Fix fast/dom/Window/window-resize.html
160         
161         In DRT connect the page's geometryChangeRequest signal to a slot that
162         sets the geometry of the view widget.
163         
164
165         * DumpRenderTree/qt/DumpRenderTree.cpp:
166         (WebCore::WebPage::setViewGeometry):
167         (WebCore::WebPage::WebPage):
168
169 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
170
171         Build fix.
172
173         * Drosera/DroseraWin.make:
174
175 2008-01-17  Darin Adler  <darin@apple.com>
176
177         * Scripts/run-webkit-tests: Fixed a bug number.
178
179 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
180
181         Reviewed by Adam Roben.
182
183         http://bugs.webkit.org/show_bug.cgi?id=16908
184         run-webkit-tests complains about missing FindSafari.exe
185
186         * Scripts/webkitdirs.pm: Append _debug as appropriate.
187
188 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
189
190         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
191         
192         Rubber-stamped by Jon Honeycutt.
193
194         * DumpRenderTree/win/DumpRenderTree.vcproj:
195
196 2008-01-16  Alp Toker  <alp@atoker.com>
197
198         Reviewed by Mark Rowe.
199
200         http://bugs.webkit.org/show_bug.cgi?id=16218
201         [GTK] API: Should this entry point be called go_back rather than go_backward?
202
203         Track back/forward API changes in the tools.
204
205         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
206         (BackForwardItem::invoke):
207         * GtkLauncher/main.c:
208         (go_back_cb):
209
210 2008-01-16  Adam Roben  <aroben@apple.com>
211
212         Windows build fix after r29488
213
214         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
215         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
216         expects to find the plugin.
217
218 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
219
220         Reviewed by Sam Weinig.
221         
222         Fixed the waitUntilDone watchdog timer -- the old code never added the
223         timer to the run loop, so it didn't do anything.
224
225         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
226         (LayoutTestController::setWaitToDump):
227         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
228         (LayoutTestController::setWaitToDump):
229
230 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
231
232         Use shared vsprops for most vcproj properties.
233         
234         Reviewed by Darin.
235
236         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
237         * DumpRenderTree/win/DumpRenderTree.vcproj:
238         * DumpRenderTree/win/ImageDiff.vcproj:
239         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
240         * FindSafari/FindSafari.vcproj:
241
242 2008-01-14  Stephanie  <slewis@apple.com>
243
244        Reviewed by NOBODY.
245   
246        revert accidental character.
247
248        * Scripts/run-webkit-tests:
249
250 2008-01-14  Stephanie  <slewis@apple.com>
251
252         RS=Oliver
253
254         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
255
256         * Scripts/run-webkit-tests:
257
258 2008-01-14  Darin Adler  <darin@apple.com>
259
260         * Scripts/do-webcore-rename: Queue up another rename.
261
262 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
263
264         Reviewed by Darin.
265
266         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
267         the tests were ran.
268         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
269
270         * Scripts/run-webkit-tests:
271
272 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
273
274         Reviewed by Darin.
275
276         * Randomize tests array to spot test cases where the results depends on the order
277         the tests are ran.
278         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
279
280         * Scripts/run-webkit-tests:
281
282 2008-01-14  Darin Adler  <darin@apple.com>
283
284         * Scripts/run-webkit-tests: More ignore list tweaking.
285
286 2008-01-14  Darin Adler  <darin@apple.com>
287
288         * Scripts/run-webkit-tests: Add another leak to the ignore list.
289
290 2008-01-14  Dan Bernstein  <mitz@apple.com>
291
292         Reviewed by Adam Roben.
293
294         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
295           build bots
296
297         * DumpRenderTree/win/DumpRenderTree.cpp:
298         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
299
300 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
301
302         Share common files across projects.
303         
304         Unify vsprops files
305         Debug:          common.vsprops, debug.vsprops
306         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
307         Release:        common.vsprops, release.vsprops
308         
309         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
310         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
311
312         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
313
314         Reviewed by Adam Roben.
315
316         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
317         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
318         * Drosera/win/Drosera.vcproj/VERSION: Removed.
319         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
320         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
321         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
322         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
323         * DumpRenderTree/win/DumpRenderTree.vcproj:
324         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
325         * DumpRenderTree/win/debug.vsprops: Removed.
326         * DumpRenderTree/win/debug_internal.vsprops: Removed.
327         * DumpRenderTree/win/release.vsprops: Removed.
328
329 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
330
331         Reviewed by Maciej.
332
333         - http://bugs.webkit.org/show_bug.cgi?id=16314
334           Script to launch Drosera
335
336         * Scripts/gdb-drosera: Added.
337         * Scripts/run-drosera: Added.
338         * Scripts/run-drosera-nightly.cmd: Added.
339         * Scripts/webkitdirs.pm: Added runDrosera function.
340
341 2008-01-13  Dan Bernstein  <mitz@apple.com>
342
343         - fix breakage due to last-minute change
344
345         * DumpRenderTree/win/DumpRenderTree.cpp:
346         (runTest): Declare the loop variable.
347
348 2008-01-13  Dan Bernstein  <mitz@apple.com>
349
350         Reviewed by Adam Roben.
351
352         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
353
354         * DumpRenderTree/win/DumpRenderTree.cpp:
355         (DumpRenderTreeWndProc):
356         (initialize):
357         (dumpBackForwardList):
358         (dumpBackForwardListForAllWindows):
359         (dump):
360         (resetWebViewToConsistentStateBeforeTesting): Factored out of
361         runTest().
362         (runTest):
363         (allWindows): Added. Returns a vector of all open windows.
364         (windowToWebViewMap): Added. Returns a map from open windows to their
365         WebViews.
366         (createWebViewAndOffscreenWindow): Factored out of main() to be
367         reusable for creating extra windows.
368         (main):
369         * DumpRenderTree/win/DumpRenderTreeWin.h:
370         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
371         (LayoutTestController::windowCount): Implemented.
372         * DumpRenderTree/win/UIDelegate.cpp:
373         (UIDelegate::createWebViewWithRequest): Implemented.
374         (UIDelegate::webViewClose): Implemented.
375         * DumpRenderTree/win/UIDelegate.h:
376
377 2008-01-12  Alp Toker  <alp@atoker.com>
378
379         Reviewed by Mark Rowe.
380
381         Hide non-public symbols in GTK+/autotools release builds.
382
383         * GNUmakefile.am:
384
385 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
386
387         Reviewed by Ap.
388
389         * Make launching of the WebKit httpd work on GNU/Debian/Linux
390         
391         The configuration of Apache2 and installation does not depend on
392         the kernel but on the distribution policy. Make launching of httpd
393         work for Debian derived distributions.
394
395         * Scripts/run-webkit-httpd:
396         * Scripts/run-webkit-tests:
397         * Scripts/webkitdirs.pm:
398
399 2008-01-12  Mark Rowe  <mrowe@apple.com>
400
401         Reviewed by Maciej Stachowiak.
402
403         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
404
405         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
406         match the callers expectations that it can take ownership of the string.
407
408 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
409
410         Reviewed by Adam Roben.
411
412         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
413
414         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
415         as these are only posted because the test window is not a normal visible one, and
416         they confuse drag&drop machinery.
417
418 2008-01-11  Adam Roben  <aroben@apple.com>
419
420         Fix a crash when pathToLocalResource fails and a leak
421
422         Reviewed by Darin.
423
424         * DumpRenderTree/LayoutTestController.cpp:
425         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
426         sure not to pass null to JSValueMakeString.
427         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
428         (LayoutTestController::pathToLocalResource): Print an error message if
429         the conversion fails so it's clear what happened.
430
431 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
432
433         Reviewed by John Sullivan.
434
435         * DumpRenderTree/mac/GCControllerMac.mm:
436         (GCController::collectOnAlternateThread): Updated for name change.
437
438 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
439
440         wx build fix. Don't build dftables any longer since it's now a Perl
441         script.
442
443         * wx/build-wxwebkit:
444
445 2008-01-10  Sam Weinig  <sam@webkit.org>
446
447         Reviewed by Anders Carlsson.
448
449         Make DRT track open windows instead of allocated windows so that
450         we can avoid ASSERTION due to late deallocs out of our control.
451
452         * DumpRenderTree/mac/DumpRenderTree.mm:
453         (dumpBackForwardListForAllWindows):
454         (runTest):
455         * DumpRenderTree/mac/DumpRenderTreeMac.h:
456         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
457         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
458         (+[DumpRenderTreeWindow openWindows]):
459         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
460         (-[DumpRenderTreeWindow close]):
461         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
462         (LayoutTestController::windowCount):
463
464 2008-01-10  Ada Chan  <adachan@apple.com>
465
466         Meta key is not the same as Alt key on windows.
467
468         Reviewed by Darin.
469
470         * DumpRenderTree/win/EventSender.cpp:
471         (keyDownCallback):
472
473 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
474
475         Reviewed by Darin, Sam and Adam.
476
477         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
478         link in gmail message displays JavaScript alert falsely complaining
479         about pop-up blocking.
480         - Added the ability to enable the pop-up blocker via the
481         LayoutTestController.
482
483         * DumpRenderTree/LayoutTestController.cpp:
484         (setPopupBlockingEnabledCallback):
485         (LayoutTestController::staticFunctions):
486         * DumpRenderTree/LayoutTestController.h:
487         * DumpRenderTree/mac/DumpRenderTree.mm:
488         (setDefaultsToConsistentValuesForTesting):
489         (resetWebViewToConsistentStateBeforeTesting):
490         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
491         (LayoutTestController::setPopupBlockingEnabled):
492
493 2008-01-10  Lars Knoll  <lars@trolltech.com>
494
495         Reviewed by Simon.
496
497         rename QWebPageHistory to QWebHistory.
498         
499
500         * DumpRenderTree/qt/jsobjects.cpp:
501
502 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
503
504         Reviewed by Darin.
505         
506         - add some more renames, adjust some
507
508         * Scripts/do-webcore-rename:
509
510 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
511
512         Reviewed by Oliver.
513
514         Enable SVG Fonts support by default.
515
516         * Scripts/build-webkit:
517
518 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
519
520         Reviewed by Adam.
521
522         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
523         DRT doesn't handle platform specific pixel test results correctly.
524
525         <test>-expected.txt files and <test>-expected.png files may now live
526         in different directories (ie. a cross-platform <test>-expected.txt file
527         and a platform-specific <test>-expected.png file).
528
529         * Scripts/run-webkit-tests:
530
531 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
532
533         Reviewed by Darin.
534
535         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
536         DRT did not correctly handle printing the '\0' char.  Now it does.
537
538         * DumpRenderTree/win/DumpRenderTree.cpp:
539         (dumpFramesAsText):
540         (dump):
541
542 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
543
544         Reviewed by Lars.
545
546         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
547         
548
549         * DumpRenderTree/qt/main.cpp:
550         * DumpRenderTree/qt/testplugin.cpp:
551         * DumpRenderTree/qt/testplugin.h:
552
553 2008-01-05  Mark Rowe  <mrowe@apple.com>
554
555         Reviewed by Alp Toker.
556
557         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
558
559         * DumpRenderTree/gtk/DumpRenderTree.cpp:
560         (processWork): Process pending work.
561         (webViewLoadFinished): Schedule processing of pending work.
562         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
563
564 2008-01-05  Darin Adler  <darin@apple.com>
565
566         * Scripts/do-webcore-rename: Some more renaming plans.
567
568 2008-01-04  Alice Liu  <alice.liu@apple.com>
569
570         Reviewed by Alexey and Darin.
571
572         Adding "home" and "end" to DRT's keydown since
573         DOM key events can't handle keyIdentifiers at this point. 
574
575         * DumpRenderTree/mac/EventSendingController.mm:
576         (-[EventSendingController keyDown:withModifiers:]):
577         * DumpRenderTree/win/EventSender.cpp:
578         (keyDownCallback):
579
580 2008-01-04  Lars Knoll  <lars@trolltech.com>
581
582         Reviewed by Simon.
583
584         fix DRT after the changes to QWebPage.
585         
586         The great thing is that we actually don't have
587         any regressions from the QWebPage change :)
588         
589
590         * DumpRenderTree/qt/DumpRenderTree.cpp:
591         (WebCore::DumpRenderTree::DumpRenderTree):
592
593 2008-01-04  Lars Knoll  <lars@trolltech.com>
594
595         Reviewed by Simon.
596
597         make QWebPage a QObject and get things to compile.
598         
599         Nothing works currently though.
600         
601
602         * DumpRenderTree/qt/DumpRenderTree.cpp:
603         (WebCore::DumpRenderTree::DumpRenderTree):
604
605 2008-01-04  Lars Knoll  <lars@trolltech.com>
606
607         Reviewed by Simon.
608
609         take a QString as identifier in QWebFrame::addToJSWindowObject.
610
611         * DumpRenderTree/qt/DumpRenderTree.cpp:
612         (WebCore::DumpRenderTree::initJSObjects):
613
614 2008-01-04  Alp Toker  <alp@atoker.com>
615
616         GTK+ DRT build fix for breakage introduced in r29149.
617
618         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
619         (LayoutTestController::execCommand):
620
621 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
622
623         Reviewed by Darin.
624
625         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
626
627         Added layoutTestController.execCommand to access editor commands that are not available
628         via document.execCommand.
629
630         * DumpRenderTree/LayoutTestController.cpp:
631         (execCommandCallback):
632         (LayoutTestController::staticFunctions):
633         * DumpRenderTree/LayoutTestController.h:
634         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
635         (LayoutTestController::execCommand):
636         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
637         (LayoutTestController::queueLoad):
638         (LayoutTestController::execCommand):
639
640 2008-01-03  Alice Liu  <alice.liu@apple.com>
641
642         Reviewed by Darin, Mitz.
643
644         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
645
646         the clickcount should not increase if the last click was at a different location.  it's a new click.
647
648         * DumpRenderTree/mac/DumpRenderTree.mm:
649         (runTest):
650         * DumpRenderTree/mac/EventSendingController.h:
651         * DumpRenderTree/mac/EventSendingController.mm:
652         (-[EventSendingController mouseDown]):
653         (-[EventSendingController mouseUp]):
654
655 2008-01-03  Darin Adler  <darin@apple.com>
656
657         Reviewed by Adam.
658
659         * Scripts/update-webkit: Make this work a little better for the people at Apple
660         who have a directory named Internal.
661
662 2008-01-03  Adam Roben  <aroben@apple.com>
663
664         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
665
666         Rubberstamped by Mark.
667
668         * Scripts/update-webkit-auxiliary-libs:
669
670 2008-01-03  Adam Roben  <aroben@apple.com>
671
672         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
673
674         http://bugs.webkit.org/show_bug.cgi?id=15663
675
676         Added a fuzz factor into the Last-Modified comparison for downloading
677         WebKitAuxiliaryLibrary.zip.
678
679         The zip file is served from a set of mirrors who give Last-Modified
680         times that are off by 1-3 seconds from each other. This was causing
681         the build bots to redownload WebKitAuxiliaryLibrary for every build,
682         which would then cause all of WebCore to rebuild each time.
683
684         Reviewed by Mark.
685
686         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
687         at least 30 seconds newer than the old one -- otherwise we assume that
688         the difference in time is due to the mirrors being slightly offset
689         from each other.
690         (sub lastModifiedToUnixTime): Added.
691
692 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
693
694         Windows build fix.
695
696         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
697
698 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
699
700         Reviewed by Lars.
701
702         Moved QWebPage::open to QWebFrame::load and added setHtml.
703         
704
705         * DumpRenderTree/qt/DumpRenderTree.cpp:
706         (WebCore::DumpRenderTree::open):
707
708 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
709
710         Reviewed by Lars.
711
712         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
713         
714
715         * DumpRenderTree/qt/DumpRenderTree.cpp:
716         (WebCore::DumpRenderTree::DumpRenderTree):
717
718 2008-01-02  Sam Weinig  <sam@webkit.org>
719
720         * Scripts/do-webcore-rename: Yet more renaming ideas.
721
722 2008-01-02  Darin Adler  <darin@apple.com>
723
724         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
725
726 2008-01-02  Alice Liu  <alice.liu@apple.com>
727
728         Reviewed by Sam Weinig.
729
730         fixing assertion hit with editing/selection/move-begin-end.html
731
732         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
733         * DumpRenderTree/win/DumpRenderTree.vcproj:
734         * DumpRenderTree/win/EventSender.cpp:
735         (keyDownCallback):
736         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
737
738 2008-01-02  Darin Adler  <darin@apple.com>
739
740         * Scripts/do-webcore-rename: Some more name change plans.
741
742 2008-01-02  Alice Liu  <alice.liu@apple.com>
743
744         Reviewed by Maciej.
745
746         Added handling for page up and page down in EventSender
747
748         * DumpRenderTree/mac/EventSendingController.mm:
749         (-[EventSendingController keyDown:withModifiers:]):
750         * DumpRenderTree/win/EventSender.cpp:
751         (keyDownCallback):
752
753 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
754
755         Reviewed by Darin.
756
757         Fix fast/events/arrow-keys-on-body.html for real.
758
759         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
760
761 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
762
763         Reviewed by Darin.
764
765         http://bugs.webkit.org/show_bug.cgi?id=16674
766         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
767
768         * Scripts/run-launcher:
769
770 2007-12-31  Darin Adler  <darin@apple.com>
771
772         Suggested by Antti.
773
774         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
775         we get it installed on the build bots.
776
777 2007-12-30  Eric Seidel  <eric@webkit.org>
778
779         Reviewed by Sam.
780
781         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
782
783 2007-12-29  Darin Adler  <darin@apple.com>
784
785         Reviewed by Oliver.
786
787         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
788           leak bot shows createCStringFromNPVariant result leaking
789
790         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
791         (pluginInvoke): Added a missing free.
792
793 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
794
795         Reviewed by Alp Toker.
796
797         http://bugs.webkit.org/show_bug.cgi?id=16390
798         Use autotools or GNU make as the build system for the GTK port
799
800         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
801         * GNUmakefile.am: Added.
802
803 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
804
805         Reviewed by Oliver.
806
807         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
808
809         * DumpRenderTree/win/EventSender.cpp:
810         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
811         of 1, even though WebKit currently ignores it.
812
813 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
814
815         wx buildbot fix. Update libpng dl script to the latest version.
816
817         * wx/install-unix-extras:
818
819 2007-12-22  Antti Koivisto  <antti@apple.com>
820
821         Fix a typo.
822
823         * Scripts/webkitdirs.pm:
824
825 2007-12-21  Sam Weinig  <sam@webkit.org>
826
827         Reviewed by Mark Rowe.
828
829         - Disable the back/forward cache using the new WebPreferences API
830           instead of through the BackForwardList.  This makes us match what
831           we do on Windows.
832
833         * DumpRenderTree/mac/DumpRenderTree.mm:
834         (createWebViewAndOffscreenWindow):
835         (setDefaultsToConsistentValuesForTesting):
836
837 2007-12-21  Dan Bernstein  <mitz@apple.com>
838
839         Reviewed by Mark Rowe.
840
841         - disable the back/forward cache in Windows DumpRenderTree. It is
842           already disabled in Mac DumpRenderTree.
843
844         * DumpRenderTree/win/DumpRenderTree.cpp:
845         (initializePreferences):
846
847 2007-12-13  Antti Koivisto  <antti@apple.com>
848
849         Reviewed by Darin and Steve.
850         
851         - check for QuickTime SDK on Windows.
852         - build media support on Windows by default
853
854         * Scripts/build-webkit:
855         * Scripts/webkitdirs.pm:
856
857 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
858
859         Build script fix for buildbot.
860
861         * wx/build-wxwebkit:
862
863 2007-12-20  Eric Seidel  <eric@webkit.org>
864
865         Reviewed by mjs.
866
867         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
868
869 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
870
871         Reviewed by Steve.
872
873         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
874         WebKit.
875
876         - Drosera and Safari need to use the same ProgIDs in order for
877         CoCreateInstance to work properly.  The most robust way to do this is
878         for WebKit to dynamically publish those ProgIDs.
879
880         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
881         (DebuggerClient::createWebViewWithRequest):
882         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
883         statics.
884         (Drosera::initUI):
885         (Drosera::attach):
886         (Drosera::attemptToCreateServerConnection):
887         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
888         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
889         make use of the published ProgIDs.
890         (ServerConnection::attemptToCreateServerConnection):
891
892 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
893
894         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
895         - Build bot and leak fix.
896
897         * DumpRenderTree/LayoutTestController.cpp:
898         (pathToLocalResourceCallback):
899
900 2007-12-19  David Kilzer  <ddkilzer@apple.com>
901
902         Make svn-apply/svn-unapply work with patches from git-format-patch.
903
904         Reviewed by Darin.
905
906         * Scripts/svn-apply:
907         (patch): If 'Index:' can't be found in the text passed in, print it
908         out with a warning and return early.
909         * Scripts/svn-unapply:
910         (patch): Ditto.
911
912 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
913
914         Reviewed by Alp Toker.
915
916         Build related fixes.
917
918         * wx/build-wxwebkit:
919         - Check to make sure the user is running a supported wx port
920         - More robust checks for Cygwin
921         - Only run install-unix-extras on Mac, it's not the right solution
922           for Linux distros.
923         - Remove outdated Linux instructions after successful build
924         - Clean Bakefile-generated files during a clean operation
925
926 2007-12-18  Darin Adler  <darin@apple.com>
927
928         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
929
930 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
931
932         Add script to run Drosera as part of the nightly.
933         
934         Reviewed by Kevin M.
935
936         * Scripts/run-drosera.cmd: Added.
937
938 2007-12-18  Darin Adler  <darin@apple.com>
939
940         * Scripts/do-webcore-rename: Remove a stray K.
941
942 2007-12-18  Darin Adler  <darin@apple.com>
943
944         * Scripts/do-webcore-rename: Plan more renaming.
945
946 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
947
948         Reviewed by Alp Toker.
949
950         http://bugs.webkit.org/show_bug.cgi?id=16042
951         [GTK] Eliminate webkit_init()
952
953         Moving webkit initialization to WebView class init.
954
955         * DumpRenderTree/gtk/DumpRenderTree.cpp:
956         (main):
957         * GtkLauncher/main.c:
958         (main):
959
960 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
961
962         Reviewed by Alp Toker.
963
964         http://bugs.webkit.org/show_bug.cgi?id=13542
965         gdklauncher doesnt change URL in adress GTKEntry.
966
967         * GtkLauncher/main.c:
968         (load_commit_cb): added
969         (title_change_cb):
970         (create_browser):
971
972 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
973
974         Reviewed by Adam Roben.
975
976         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
977
978         * FindSafari/FindSafari.cpp:
979         (_tmain):
980
981 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
982
983         Reviewed by Adam Roben.
984
985         http://bugs.webkit.org/show_bug.cgi?id=16315
986         FindSafari needs a path-only option.
987
988         * FindSafari/FindSafari.cpp:
989         (_tmain):
990
991 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
992
993         Reviewed by Darin.
994
995         http://bugs.webkit.org/show_bug.cgi?id=16462
996         REGRESSION: access keys broken on Windows
997
998         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
999         if Alt is pressed.
1000
1001 2007-12-15  Sam Weinig  <sam@webkit.org>
1002
1003         Reviewed by Mark Rowe.
1004
1005         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1006         the case when wstring.find doesn't find anything.
1007
1008         * DumpRenderTree/win/DumpRenderTree.cpp:
1009         (urlSuitableForTestResult):
1010
1011 2007-12-15  Alp Toker  <alp@atoker.com>
1012
1013         GTK+ DRT build fix for GLib < 2.14.
1014
1015         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1016         (LayoutTestController::setWaitToDump):
1017
1018 2007-12-05  Mark Rowe  <mrowe@apple.com>
1019
1020         Reviewed by Alp Toker.
1021
1022         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1023         many layout tests from hanging while waiting on user responses to dialogs.
1024
1025         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1026         (invalidateAnyPreviousWaitToDumpWatchdog):
1027         (webViewScriptAlert):
1028         (webViewScriptPrompt):
1029         (webViewScriptConfirm):
1030         (main):
1031         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1032         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1033         (waitToDumpWatchdogFired):
1034         (LayoutTestController::setWaitToDump):
1035
1036 2007-12-05  Mark Rowe  <mrowe@apple.com>
1037
1038         Reviewed by Alp Toker.
1039
1040         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1041
1042         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1043         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1044         (dump):
1045         (runTest):
1046         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1047         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1048         work queue is empty.
1049         (webViewWindowObjectCleared): Set up window.layoutTestController.
1050         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1051         (main): Hook up the new signals.
1052         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1053         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1054         dumping multiple times.
1055         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1056         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1057
1058 2007-12-14  Anders Carlsson  <andersca@apple.com>
1059
1060         Reviewed by Brady.
1061
1062         Assert that a web frame that's loading a resource always has either a data source or 
1063         a provisional data source.
1064         
1065         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1066         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1067
1068 2007-12-14  Darin Adler  <darin@apple.com>
1069
1070         - fix mistake causing nearly all tests to fail on Windows
1071
1072         * DumpRenderTree/win/UIDelegate.cpp:
1073         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1074         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1075
1076         * DumpRenderTree/mac/UIDelegate.mm:
1077         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1078         than passing the entire message.
1079
1080 2007-12-14  Darin Adler  <darin@apple.com>
1081
1082         - fix Tiger build
1083
1084         * DumpRenderTree/mac/UIDelegate.mm:
1085         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1086         new-to-Leopard methods.
1087
1088 2007-12-14  Darin Adler  <darin@apple.com>
1089
1090         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1091         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1092         delegate methods here.
1093
1094 2007-12-14  Anders Carlsson  <andersca@apple.com>
1095
1096         Reviewed by Darin and Geoff.
1097
1098         <rdar://problem/5619295> 
1099         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1100         
1101         Add property getting methods to the plug-in.
1102         
1103         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1104         (pluginInvoke):
1105
1106 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1107
1108         Reviewed by Darin.
1109
1110         - Layout test fix for mac. When dumped to the console local file paths
1111         now only show the name of the resource not the whole path.  This is to
1112         make the results machine and OS independent.
1113
1114         * DumpRenderTree/mac/UIDelegate.mm:
1115         (-[UIDelegate webView:addMessageToConsole:]):
1116
1117 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1118
1119         Reviewed by Adam.
1120
1121         - Layout tests fix.  We need a way to remove machine-dependent
1122         information from paths in layout test results. The UIDelegate now does
1123         this.
1124
1125         * DumpRenderTree/DumpRenderTree.h:
1126         * DumpRenderTree/win/DumpRenderTree.cpp:
1127         (urlSuitableForTestResult):
1128         * DumpRenderTree/win/DumpRenderTreeWin.h:
1129         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1130         * DumpRenderTree/win/UIDelegate.cpp:
1131         (UIDelegate::webViewAddMessageToConsole):
1132
1133 2007-12-13  Alp Toker  <alp@atoker.com>
1134
1135         Build fix for DRT breakage introduced in r28690.
1136
1137         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1138         (LayoutTestController::pathToLocalResource):
1139
1140 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1141
1142         Reviewed by Alice and Sam.
1143
1144         - <rdar://5621435> Need a way to specify local resources (being loaded
1145         from HTTP tests) on Windows.
1146         - Implemented pathToLocalResource which exposes the functionality of
1147         converting a given unix path to the correct location on Windows.
1148
1149         * DumpRenderTree/LayoutTestController.cpp:
1150         (pathToLocalResourceCallback):
1151         (LayoutTestController::staticFunctions):
1152         * DumpRenderTree/LayoutTestController.h:
1153         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1154         (LayoutTestController::pathToLocalResource):
1155         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1156         (LayoutTestController::pathToLocalResource):
1157
1158 2007-12-12  Anders Carlsson  <andersca@apple.com>
1159
1160         Reviewed by Sam.
1161
1162         <rdar://problem/5132003>
1163         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1164
1165         * DumpRenderTree/win/DumpRenderTree.cpp:
1166         (main):
1167         Set the resource load delegate.
1168         
1169         * DumpRenderTree/win/DumpRenderTree.vcproj:
1170         
1171         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1172         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1173
1174 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1175
1176         Reviewed by Adam Roben.
1177
1178         Fix conversion from double to LPARAM in dispatchMessage().
1179
1180         * DumpRenderTree/win/EventSender.cpp:
1181         (dispatchMessageCallback):
1182
1183 2007-12-11  Dan Bernstein  <mitz@apple.com>
1184
1185         Reviewed by Mark Rowe and Sam Weinig too!
1186
1187         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1188           fonts DumpRenderTree registers.
1189
1190         * DumpRenderTree/win/DumpRenderTree.cpp:
1191         (initialize):
1192
1193 2007-12-11  Brady Eidson  <beidson@apple.com>
1194
1195         Reviewed by Anders
1196
1197         Make DumpRenderTree on mac use its own path for Databases testing
1198
1199         * DumpRenderTree/mac/DumpRenderTree.mm:
1200         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1201           for future DRT-only use, then use it to construct the Databases path and set that default
1202
1203 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1204
1205         Reviewed by Darin.
1206
1207         <rdar://problem/5535636>
1208         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1209
1210         http://bugs.webkit.org/show_bug.cgi?id=13916
1211         JavaScript detects Tab as a character input on a textfield validation
1212
1213         * DumpRenderTree/mac/EventSendingController.mm:
1214         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1215         Dispatch a keyup to better match what happens when a key is physically pressed.
1216
1217         * DumpRenderTree/win/EventSender.cpp:
1218         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1219         returning from keyDown().
1220         (getConstantCallback): Fixed a couple copy/paste mistakes.
1221
1222 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1223
1224         Reviewed by Oliver.
1225
1226         - <rdar://5599845> Drosera: Does not show loal files in the file list
1227         on the left side.
1228
1229         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1230         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1231         so the open source community can build.
1232
1233 2007-12-10  Brady Eidson  <beidson@apple.com>
1234
1235         Rubberstamped by Sam Weinig
1236
1237         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1238
1239         * DumpRenderTree/mac/UIDelegate.mm:
1240         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1241         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1242
1243 2007-12-08  Oliver Hunt  <oliver@apple.com>
1244
1245         Reviewed by Sam W.
1246
1247         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1248         
1249         Fixes <rdar://problem/5620249> Must disable SVG animation
1250         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1251         
1252         In order to allow finer grained control over the set of SVG features
1253         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1254         distinct flags:
1255         ENABLE_SVG_ANIMATION
1256         ENABLE_SVG_FILTERS
1257         ENABLE_SVG_FONTS
1258         ENABLE_SVG_AS_IMAGE
1259         ENABLE_SVG_USE
1260         
1261         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1262         
1263         Script handles all the new build flags, and allows --svg-experimental
1264         to automatically enable all features.
1265
1266         * Scripts/build-webkit:
1267
1268 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1269
1270         Fix version parsing.
1271
1272         Rubber-stamped by Oliver.
1273
1274         * Drosera/win/Drosera.vcproj/auto-version.sh:
1275
1276 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1277
1278         Build modifications for Drosera.
1279
1280         Reviewed by Adam.
1281
1282         * Drosera/DroseraWin.make: Added.
1283         * Drosera/win/Drosera.vcproj/Drosera.rc:
1284         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1285         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1286         * Drosera/win/Drosera.vcproj/VERSION: Added.
1287         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1288
1289 2007-12-06  Adam Roben  <aroben@apple.com>
1290
1291         Explicitly turn on the Mac font ascent hack on Windows
1292
1293         This keeps our font metrics matching those from Mac.
1294
1295         Reviewed by Hyatt.
1296
1297         * DumpRenderTree/win/DumpRenderTree.cpp:
1298         (main):
1299
1300 2007-12-06  Anders Carlsson  <andersca@apple.com>
1301
1302         Rename main.c to main.cpp here too.
1303         
1304         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1305
1306 2007-12-06  Sam Weinig  <sam@webkit.org>
1307
1308         Rubber stamped by Geoff.
1309
1310         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1311
1312 2007-12-06  Darin Adler  <darin@apple.com>
1313
1314         * Scripts/do-webcore-rename: Some more renaming plans.
1315
1316 2007-12-06  Anders Carlsson  <andersca@apple.com>
1317
1318         Restore implementation of testGetIntIdentifier that was accidentally
1319         removed somehow (possibly when I made PluginObject be a cpp file).
1320         
1321         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1322         (pluginInvoke):
1323
1324 2007-12-05  Anders Carlsson  <andersca@apple.com>
1325
1326         Make the entry points extern "C".
1327         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1328         
1329 2007-12-05  Anders Carlsson  <andersca@apple.com>
1330
1331         C++ warning fixes.
1332         
1333         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1334         (NPP_New):
1335         (NPP_Destroy):
1336         (NPP_SetWindow):
1337         (NPP_NewStream):
1338         (NPP_HandleEvent):
1339         (NPP_URLNotify):
1340         (NPP_GetValue):
1341
1342 2007-12-05  Anders Carlsson  <andersca@apple.com>
1343
1344         Add the .cpp files to the TestNetscapePlugIn target.
1345
1346         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1347
1348 2007-12-05  Anders Carlsson  <andersca@apple.com>
1349
1350         Reviewed by Geoff.
1351         
1352         Rename the TestNetscapePlugIn .c files to be .cpp.
1353
1354         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1355         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1356         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1357         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1358         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1359         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1360         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1361         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1362
1363 2007-12-05  Adam Roben  <aroben@apple.com>
1364
1365         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1366
1367         This fixes several regression tests.
1368
1369         Reviewed by Alice.
1370
1371         * DumpRenderTree/win/EventSender.cpp:
1372         (keyDownCallback): Virtual keycodes for ASCII characters are always
1373         uppercase, so we need to check the case of the original character
1374         passed in to eventSender.keyDown.
1375
1376 2007-12-05  Adam Roben  <aroben@apple.com>
1377
1378         Learn from Tim's mistakes
1379
1380         * DumpRenderTree/win/DumpRenderTree.cpp:
1381         (runTest): Reset the authorAndUserStylesEnabled preference for each
1382         test.
1383
1384 2007-12-05  Alp Toker  <alp@atoker.com>
1385
1386         Reviewed by Mark Rowe.
1387
1388         Initialize GTK+ and WebKit so the tests can run.
1389
1390         Reorganize the headers a little.
1391
1392         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1393         (main):
1394
1395 2007-12-04  Anders Carlsson  <andersca@apple.com>
1396
1397         Remove IWebScriptScope include.
1398         
1399         * Drosera/win/DebuggerDocumentPlatform.cpp:
1400
1401 2007-12-04  Sam Weinig  <sam@webkit.org>
1402
1403         Rubber stamped by Mark Rowe.
1404
1405         Define CF as platform for mac and revert r28409
1406
1407         * DumpRenderTree/DumpRenderTree.h:
1408         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1409
1410 2007-12-04  Sam Weinig  <sam@webkit.org>
1411
1412         Define CF as platform for windows.
1413
1414         Reviewed by Adam Roben.
1415
1416         * DumpRenderTree/win/DumpRenderTreeWin.h:
1417
1418 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1419
1420         Reviewed by Adam and Darin.
1421
1422         - Removed a needless BSTR cleanup.
1423
1424         * Drosera/win/DebuggerDocumentPlatform.cpp:
1425         (DebuggerDocument::getPlatformCurrentFunctionStack):
1426
1427 2007-11-27  Adam Roben  <aroben@apple.com>
1428
1429         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1430
1431         Reviewed by Maciej.
1432
1433         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1434         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1435
1436 2007-12-04  Alp Toker  <alp@atoker.com>
1437
1438         Prospective Win DRT build fix.
1439
1440         * DumpRenderTree/DumpRenderTree.h:
1441
1442 2007-12-04  Alp Toker  <alp@atoker.com>
1443
1444         Fix a clobbered copyright header.
1445
1446         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1447
1448 2007-12-04  Xan Lopez  <xan@gnome.org>
1449
1450         Reviewed by Alp Toker.
1451
1452         http://bugs.webkit.org/show_bug.cgi?id=15561
1453         GTK port needs DumpRenderTree implementation
1454
1455         Start work on the GTK+ DRT.
1456
1457         This does not work yet, and there are a few lingering style issues
1458         (nothing major) but this patch has been stuck in the bug tracker for
1459         too long already.
1460
1461         * DumpRenderTree/DumpRenderTree.h:
1462         * DumpRenderTree/gtk: Added.
1463         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1464         (autocorrectURL):
1465         (shouldLogFrameLoadDelegates):
1466         (dumpFrameScrollPosition):
1467         (displayWebView):
1468         (appendString):
1469         (dumpFramesAsText):
1470         (dumpRenderTreeAsText):
1471         (dump):
1472         (runTest):
1473         (main):
1474         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1475         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1476         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1477         (GCController::collect):
1478         (GCController::collectOnAlternateThread):
1479         (GCController::getJSObjectCount):
1480         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1481         (LayoutTestController::~LayoutTestController):
1482         (LayoutTestController::addDisallowedURL):
1483         (LayoutTestController::clearBackForwardList):
1484         (LayoutTestController::copyDecodedHostName):
1485         (LayoutTestController::copyEncodedHostName):
1486         (LayoutTestController::display):
1487         (LayoutTestController::keepWebHistory):
1488         (LayoutTestController::notifyDone):
1489         (LayoutTestController::queueBackNavigation):
1490         (LayoutTestController::queueForwardNavigation):
1491         (LayoutTestController::queueLoad):
1492         (LayoutTestController::queueReload):
1493         (LayoutTestController::queueScript):
1494         (LayoutTestController::setAcceptsEditing):
1495         (LayoutTestController::setCustomPolicyDelegate):
1496         (LayoutTestController::setMainFrameIsFirstResponder):
1497         (LayoutTestController::setTabKeyCyclesThroughElements):
1498         (LayoutTestController::setUseDashboardCompatibilityMode):
1499         (LayoutTestController::setUserStyleSheetEnabled):
1500         (LayoutTestController::setUserStyleSheetLocation):
1501         (LayoutTestController::setWindowIsKey):
1502         (LayoutTestController::setWaitToDump):
1503         (LayoutTestController::windowCount):
1504         (LayoutTestController::setPrivateBrowsingEnabled):
1505         (LayoutTestController::setAuthorAndUserStylesEnabled):
1506         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1507         (JSStringCopyUTF8CString):
1508         (LoadItem::invoke):
1509         (ReloadItem::invoke):
1510         (ScriptItem::invoke):
1511         (BackForwardItem::invoke):
1512
1513 2007-12-03  Sam Weinig  <sam@webkit.org>
1514
1515         Move JavaScriptCore thread testing code to pthread specific directory
1516         and remove the dependance on CoreFoundation by using WTF::HashSet.
1517
1518         Reviewed by Geoff and Oliver.
1519
1520         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1521         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1522         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1523         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1524         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1525         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1526         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1527         * DumpRenderTree/pthreads: Added.
1528         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1529         (javaScriptThreads):
1530         (runJavaScriptThread):
1531         (startJavaScriptThreads):
1532         (stopJavaScriptThreads):
1533
1534 2007-12-03  Andrew Bonventre  <andybons@google.com>
1535
1536         Reviewed by Darin Adler.
1537
1538         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1539         Symbol lookup menu broken in debugger view
1540
1541         * Drosera/debugger.js: Fixed javascript error where document property
1542         should have been used instead of contentDocument in switchFunction that
1543         was breaking the select symbol dropdown menu.  This is because
1544         window.frames will return a Window object and not a frame object like
1545         the author was originally expecting.
1546
1547 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1548
1549         Reviewed by Adam.
1550
1551         - <rdar://5618942> Drosera: Console window does not process everything
1552         correctly.
1553         - <rdar://5619005> Drosera: could be sped up by moving the 
1554         WebScriptScope stuff into the WebScriptCallFrame.
1555         - Now the console can correctly process objects and does not receive
1556         notifications from JavaScriptCore about the JavaScript in Drosera's
1557         own process.
1558
1559         * Drosera/win/DebuggerDocumentPlatform.cpp:
1560         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1561         (DebuggerDocument::platformValueForScopeVariableNamed):
1562
1563 2007-12-03  Stephanie  <slewis@apple.com>
1564
1565         Reviewed by Darin.
1566
1567         Check to see if we are building a debug root
1568
1569         * Scripts/check-for-global-initializers: 
1570
1571 2007-12-03  Dan Bernstein  <mitz@apple.com>
1572
1573         Reviewed by Darin Adler.
1574
1575         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1576
1577         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1578         (pluginInvoke):
1579
1580 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1581
1582         Reviewed by Oliver.
1583
1584         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1585         in a more fine-grained manner than eventSender.keyDown().
1586
1587         * DumpRenderTree/win/EventSender.cpp:
1588         (getConstantCallback):
1589         (dispatchMessageCallback):
1590
1591 2007-12-02  Darin Adler  <darin@apple.com>
1592
1593         * Scripts/do-webcore-rename: More planned renaming.
1594
1595 2007-12-02  Sam Weinig  <sam@webkit.org>
1596
1597         Rubber stamped by Anders.
1598
1599         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1600         more uniform results cross platform.
1601
1602         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1603         (-[NSURL _drt_descriptionSuitableForTestResult]):
1604
1605 2007-12-02  Sam Weinig  <sam@webkit.org>
1606
1607         Rubber stamped by Niko.
1608
1609         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1610
1611         * DumpRenderTree/win/DumpRenderTree.cpp:
1612         * DumpRenderTree/win/DumpRenderTree.vcproj:
1613         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1614         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1615         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1616         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1617
1618 2007-12-01  Alp Toker  <alp@atoker.com>
1619
1620         Reviewed by Adam Roben.
1621
1622         Make use of the newly introduced webkit.h convenience header.
1623
1624         * GtkLauncher/main.c:
1625
1626 2007-12-01  Adam Treat  <treat@kde.org>
1627
1628         Reviewed by Simon.
1629
1630         * Check to see if the directory exists and exit if not.
1631
1632         * DumpRenderTree/qt/main.cpp:
1633         (main):
1634
1635 2007-12-01  Adam Treat  <treat@kde.org>
1636
1637         Reviewed by Simon.
1638
1639         * Don't hide symbols when in Debug mode
1640         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1641
1642
1643         * DumpRenderTree/qt/main.cpp:
1644         (messageHandler):
1645
1646 2007-11-30  Alp Toker  <alp@atoker.com>
1647
1648         Reviewed by Adam Roben.
1649
1650         http://bugs.webkit.org/show_bug.cgi?id=15691
1651         [GTK] Public API does not follow GTK+ conventions
1652
1653         Refactor the WebKit/GTK+ public API. Changes:
1654           WebKitPage -> WebKitWebView
1655           WebKitFrame -> WebKitWebFrame
1656
1657         Public API source and header names have been updated to mirror the API
1658         changes.
1659
1660         The API is now kept in WebKit/gtk/WebView to match other ports in the
1661         same class such as Mac and Win.
1662
1663         * GtkLauncher/main.c:
1664         (activate_uri_entry_cb):
1665         (link_hover_cb):
1666         (title_change_cb):
1667         (progress_change_cb):
1668         (go_back_cb):
1669         (go_forward_cb):
1670         (create_browser):
1671         (main):
1672
1673 2007-11-30  Adam Roben  <aroben@apple.com>
1674
1675         Hopefully the final build fix
1676
1677         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1678         pull in WTF's assertion/logging functions.
1679
1680 2007-11-30  Adam Roben  <aroben@apple.com>
1681
1682         Another build fix
1683
1684         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1685         WebKit.lib.
1686
1687 2007-11-30  Adam Roben  <aroben@apple.com>
1688
1689         Debug build fix
1690
1691         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1692         configuration.
1693         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1694         projects.
1695         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1696         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1697         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1698
1699 2007-11-30  Sam Weinig  <sam@webkit.org>
1700
1701         Reviewed by Adam Roben.
1702
1703         Fix drawSelectionRect to actually draw the selection rect.
1704
1705         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1706         (drawSelectionRect):
1707
1708 2007-11-30  Darin Adler  <darin@apple.com>
1709
1710         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1711
1712 2007-11-30  Darin Adler  <darin@apple.com>
1713
1714         * Scripts/do-webcore-rename: Get ready for some future renaming.
1715
1716 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1717
1718         Reviewed by Adam.
1719
1720         - Removed some unnecessary functions and changed an unused return type. 
1721
1722         * Drosera/win/DebuggerClient.cpp:
1723         (registerConsoleClass):
1724         * Drosera/win/DebuggerClient.h:
1725         * Drosera/win/Drosera.cpp:
1726         (registerDroseraClass):
1727
1728 2007-11-28  Alp Toker  <alp@atoker.com>
1729
1730         Reviewed by Timothy Hatcher.
1731
1732         http://bugs.webkit.org/show_bug.cgi?id=16174
1733         [GTK] Use "URI" not "URL" in public API
1734
1735         Replace use of the term "URL" with "URI" in public headers,
1736         documentation and some internal code to match GLib/GTK+ convention.
1737
1738         This is now mentioned in the API guidelines:
1739           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1740
1741         * GtkLauncher/main.c:
1742         (activate_uri_entry_cb):
1743         (title_change_cb):
1744         (create_toolbar):
1745         (main):
1746
1747 2007-11-29  Anders Carlsson  <andersca@apple.com>
1748
1749         Reviewed by Sam.
1750
1751         <rdar://problem/5230478>
1752         FrameLoadDelegate callbacks are not dumped in DRT.
1753         
1754         * DumpRenderTree/win/DumpRenderTree.cpp:
1755         (shouldLogFrameLoadDelegates):
1756         (runTest):
1757         (main):
1758         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1759         (BSTRtoString):
1760         (descriptionSuitableForTestResult):
1761         (FrameLoadDelegate::QueryInterface):
1762         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1763         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1764         (FrameLoadDelegate::didCommitLoadForFrame):
1765         (FrameLoadDelegate::didFinishLoadForFrame):
1766         (FrameLoadDelegate::willCloseFrame):
1767         (FrameLoadDelegate::didClearWindowObject):
1768         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1769         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1770         * DumpRenderTree/win/FrameLoaderDelegate.h:
1771         (FrameLoadDelegate::windowScriptObjectAvailable):
1772         (FrameLoadDelegate::didFirstLayoutInFrame):
1773
1774 2007-11-29  Sam Weinig  <sam@webkit.org>
1775
1776         Reviewed by Anders.
1777
1778         Add database quota UIDelegates methods to DRT UIDelegate.
1779
1780         * DumpRenderTree/mac/UIDelegate.mm:
1781         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1782         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1783
1784 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1785
1786         Reviewed by Sam.
1787
1788         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1789         dying and vice versa.
1790         - This fix will allow Drosera and Safari to reconnect if either of them
1791         closes correctly, but does not fix the case where one of them dies
1792         silently.
1793
1794         * Drosera/win/ServerConnection.cpp:
1795         (ServerConnection::attemptToCreateServerConnection): Added a safety
1796         check, because it's possilbe to try to connect to a server that's dying.
1797         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1798         the server has died.
1799         * Drosera/win/ServerConnection.h: Added the new function and removed
1800         an unnecessary member.
1801
1802 2007-11-29  Anders Carlsson  <andersca@apple.com>
1803
1804         * DumpRenderTree/win/DumpRenderTree.vcproj:
1805         Add shlwapi.lib to all configurations.
1806
1807 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1808
1809         - Build fix.  Added additional includes for VS Express to the Release
1810         project.
1811
1812         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1813
1814 2007-11-29  Anders Carlsson  <andersca@apple.com>
1815
1816         Reviewed by Adam.
1817
1818         <rdar://problem/5132005>
1819         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1820         
1821         * DumpRenderTree/win/DumpRenderTree.vcproj:
1822         Add shlwapi.lib
1823         
1824         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1825         (LayoutTestController::setUserStyleSheetEnabled):
1826         Implement this.
1827         
1828         (appendComponentToPath):
1829         New method which wraps the Win32 API PathAppend.
1830         
1831         (followShortcuts):
1832         New method which checks if a file points to a shortcut and
1833         follows the shortcut.
1834         
1835         (resolveCygwinPath):
1836         New method that takes a cygwin unix-style path and returns the Win32 path.
1837         
1838         (cfStringRefToWString):
1839         
1840         (LayoutTestController::setUserStyleSheetLocation):
1841         Implement this.
1842
1843 2007-11-29  Alice Liu  <alice.liu@apple.com>
1844
1845         Reviewed by Adam.
1846
1847         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1848
1849         * DumpRenderTree/win/EventSender.cpp:
1850         (keyDownCallback):
1851         uppercase letters were being sent as lowercase letters without the shift key down.
1852
1853 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1854
1855         - Windows build fix. VS express needs some love.
1856
1857         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1858
1859 2007-11-28  Darin Adler  <darin@apple.com>
1860
1861         Reviewed by Adam Roben.
1862
1863         * DumpRenderTree/mac/EventSendingController.mm:
1864         (-[EventSendingController keyDown:withModifiers:]):
1865         Send capital letters through as lowercase letters with the shift key down
1866         rather than sending them as if they were highly unusual "capital letter keys".
1867
1868         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1869         where you need to update results and more tests are failing than before.
1870
1871 2007-11-28  Anders Carlsson  <andersca@apple.com>
1872
1873         Reviewed by Darin.
1874
1875         <rdar://problem/5132001>
1876         contextClick is not implemented in DRT on Windows.
1877         
1878         * DumpRenderTree/win/EventSender.cpp:
1879         (contextClickCallback):
1880         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1881         by a WM_RBUTTONUP message.
1882         
1883         * DumpRenderTree/win/UIDelegate.cpp:
1884         (UIDelegate::hasCustomMenuImplementation):
1885         (UIDelegate::trackCustomPopupMenu):
1886         * DumpRenderTree/win/UIDelegate.h:
1887         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1888         menu from being shown (and causing the DRT to hang).
1889
1890 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1891
1892         Reviewed by Darin.
1893
1894         Fix DumpRenderTree ObjC bug comparing strings.
1895
1896         * DumpRenderTree/mac/ObjCController.m:
1897         (-[ObjCController identityIsEqual::]): Compare strings with string
1898         equality instead of identiy equality.
1899
1900 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1901
1902         Reviewed by Sam.
1903
1904         Reset the authorAndUserStylesEnabled preference
1905         back to YES for each test. Fixes the broken tests.
1906
1907         * DumpRenderTree/mac/DumpRenderTree.mm:
1908         (resetWebViewToConsistentStateBeforeTesting):
1909
1910 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1911
1912         Reviewed by Adam.
1913
1914         - Drosera now displays the console window, although it cannot currently
1915         process JavaScript.
1916
1917         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1918         (registerConsoleClass): Implemented.
1919         (consoleWndProc): Implemented.
1920         (DebuggerClient::onSize): Implemented.
1921         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1922         new window.
1923         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1924         creating and maintaining a new window.
1925         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1926         lines of code to more appropriate places.
1927         (Drosera::handleCommand):
1928         (Drosera::initUI):
1929         (Drosera::onSize):
1930         (Drosera::attach):
1931
1932 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1933
1934         Reviewed by Dave Hyatt.
1935
1936         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1937         
1938         Add support for disabling author and user styles for testing.
1939
1940         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1941         * DumpRenderTree/LayoutTestController.cpp:
1942         (setAuthorAndUserStylesEnabledCallback):
1943         (LayoutTestController::staticFunctions):
1944         * DumpRenderTree/LayoutTestController.h:
1945         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1946         (LayoutTestController::setAuthorAndUserStylesEnabled):
1947         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1948         (LayoutTestController::setAuthorAndUserStylesEnabled):
1949
1950 2007-11-26  Dan Bernstein  <mitz@apple.com>
1951
1952         - Tiger build fix.
1953
1954         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1955
1956 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1957
1958         Reviewed by Maciej.
1959
1960         - Implemented displaying variables for Drosera on Win.
1961
1962         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1963         that retrieve variables to not hold onto the return value since it's
1964         not returned.  Also changed to use the new signatures of the retrieval
1965         functions.
1966         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1967         (DebuggerDocument::platformValueForScopeVariableNamed):
1968         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1969         (droseraWndProc):
1970
1971 2007-11-26  Sam Weinig  <sam@webkit.org>
1972
1973         Cleanup names of painting and repainting functions.
1974
1975         Reviewed by Adam Roben.
1976
1977         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1978         (drawSelectionRect): was drawSelectionRectIntoContext.
1979         (dumpWebViewAsPixelsAndCompareWithExpected):
1980         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1981         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1982         (paintWebView): was drawWebViewIntoContext.
1983         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1984
1985 2007-11-26  Sam Weinig  <sam@webkit.org>
1986
1987         Reviewed by Dan Bernstein.
1988
1989         - Leopard build fix
1990
1991         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1992
1993 2007-11-26  Sam Weinig  <sam@webkit.org>
1994
1995         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1996         Use shared PixelDumpSupport for Mac DRT
1997
1998         Reviewed by Adam Roben.
1999
2000         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2001         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2002         * DumpRenderTree/cg/ImageDiffCG.cpp:
2003         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2004         (drawSelectionRectIntoContext):
2005         (dumpWebViewAsPixelsAndCompareWithExpected):
2006         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2007         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2008         * DumpRenderTree/mac/DumpRenderTree.mm:
2009         (dump):
2010         * DumpRenderTree/mac/ImageDiff.m: Removed.
2011         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2012         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2013         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2014         (setDefaultColorProfileToRGB):
2015         (getBitmapContextFromWebView):
2016         (drawWebViewIntoContext):
2017         (repaintWithVerticalSweep):
2018         (repaintWithHorizontalSweep):
2019         (getSelectionRect):
2020         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2021
2022 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2023
2024         Bug 16052: prepare-ChangeLog doesn't report deleted files
2025         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2026
2027         Reviewed by Sam.
2028
2029         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2030
2031 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2032
2033         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2034         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2035
2036         Reviewed by Adam.
2037
2038         Roll functionality of merge-changelog into resolve-ChangeLogs
2039         script.  The script now checks for ChangeLog.rej and
2040         ChangeLog.orig files first.  If it finds them, it uses the
2041         ChangeLog.rej file as a patch (in old contextual diff format) to
2042         apply with --fuzz=3.
2043
2044         * Scripts/merge-changelog: Removed.
2045         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2046
2047 2007-11-25  Sam Weinig  <sam@webkit.org>
2048
2049         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2050
2051         Reviewed by Mark Rowe.
2052
2053         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2054         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2055         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2056         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2057         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2058
2059 2007-11-25  Sam Weinig  <sam@webkit.org>
2060
2061         Convert DumpRenderTree to ues .xcconfig files.
2062
2063         Reviewed by Mark Rowe.
2064
2065         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2066         * DumpRenderTree/mac/Configurations: Added.
2067         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2068         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2069         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2070
2071 2007-11-25  Sam Weinig  <sam@webkit.org>
2072
2073         Add ForwardingHeaders to wtf for DumpRenderTree.
2074
2075         Reviewed by Mark Rowe.
2076
2077         * DumpRenderTree/DumpRenderTree.h:
2078         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2079         * DumpRenderTree/ForwardingHeaders: Added.
2080         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2081         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2082         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2083         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2084         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2085         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2086         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2087         * DumpRenderTree/LayoutTestController.cpp:
2088         * DumpRenderTree/WorkQueue.cpp:
2089         * DumpRenderTree/mac/DumpRenderTree.mm:
2090         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2091         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2092         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2093         * DumpRenderTree/mac/ObjCController.m:
2094         * DumpRenderTree/mac/UIDelegate.mm:
2095         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2096
2097 2007-11-25  Adam Roben  <aroben@apple.com>
2098
2099         Fix some test failures caused by r28019
2100
2101         Now that stdout is in binary mode, we need to always use printf
2102         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2103         the output.
2104
2105         Reviewed by Sam.
2106
2107         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2108         printf.
2109         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2110         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2111         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2112         (UIDelegate::webViewAddMessageToConsole):
2113
2114 2007-11-25  Adam Roben  <aroben@apple.com>
2115
2116         Set the font smoothing preference in DRT
2117
2118         This makes the pixel results on Windows closer to the Mac results.
2119
2120         Reviewed by Mitz.
2121
2122         * DumpRenderTree/win/DumpRenderTree.cpp:
2123         (initializePreferences):
2124
2125 2007-11-25  Adam Roben  <aroben@apple.com>
2126
2127         Port ImageDiff to CG and C++
2128
2129         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2130         <rdar://5071708>
2131
2132         Reviewed by Sam.
2133
2134         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2135         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2136         (main):
2137         (createImageFromStdin):
2138         (compareImages):
2139         (getDifferenceBitmap):
2140         (computePercentageDifferent):
2141         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2142
2143 2007-11-25  Adam Roben  <aroben@apple.com>
2144
2145         Fix image diff link generation on Windows
2146
2147         Reviewed by Sam.
2148
2149         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2150         to toURL.
2151
2152 2007-11-25  Adam Roben  <aroben@apple.com>
2153
2154         Implement pixel dumping in Windows DRT
2155
2156         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2157         <rdar://5071708>
2158
2159         Reviewed by Sam.
2160
2161         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2162         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2163         Content-Length header.
2164         (getMD5HashStringForBitmap):
2165         (dumpWebViewAsPixelsAndCompareWithExpected):
2166         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2167         * DumpRenderTree/win/DumpRenderTree.cpp:
2168         (dump): Do a pixel dump if requested.
2169         (main): Parse pixel test options.
2170         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2171         the cg/ subdirectory to the include path.
2172         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2173         available in a header or import library, so we have to go through this
2174         LoadLibrary/GetProcAddress dance to use them.
2175         (cryptDLL):
2176         (init):
2177         (update):
2178         (final):
2179         (MD5_Init):
2180         (MD5_Update):
2181         (MD5_Final):
2182         * DumpRenderTree/win/MD5.h: Added.
2183         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2184         moved up to the top level to share it with Mac eventually.
2185         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2186         (getBitmapContextFromWebView): Forces the WebView to paint using a
2187         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2188
2189 2007-11-25  Adam Roben  <aroben@apple.com>
2190
2191         Clean up Windows DRT's option parsing a little bit
2192
2193         Reviewed by Sam.
2194
2195         * DumpRenderTree/win/DumpRenderTree.cpp:
2196         (main): Put non-option arguments into a Vector.
2197
2198 2007-11-25  Adam Roben  <aroben@apple.com>
2199
2200         Make Windows DRT stop changing LF into CRLF
2201
2202         Reviewed by Sam.
2203
2204         * DumpRenderTree/win/DumpRenderTree.cpp:
2205         (main): Put stdout in binary mode.
2206         * Scripts/run-webkit-tests: Remove the CRLF hack.
2207
2208 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2209
2210         Removed empty directory.
2211
2212         * Scripts/resources: Removed.
2213
2214 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2215
2216         Fix bisect-builds to work with recent WebKit nightly builds.
2217
2218         Reviewed by Dan.
2219
2220         * Scripts/bisect-builds: Check for the 
2221         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2222         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2223         to WebKit.app/Contents/Resources.
2224
2225 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2226
2227         Reviewed by Maciej.
2228
2229         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2230         not closed (affects digg.com)
2231
2232         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2233         one after finishing with a test to avoid having its delayed onload handler firing when
2234         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2235         but it helps somewhat.
2236
2237 2007-11-22  Mark Rowe  <mrowe@apple.com>
2238
2239         Reviewed by Alp Toker.
2240
2241         Fix build-webkit to propagate make's exit status if it fails.
2242
2243         * Scripts/webkitdirs.pm:
2244
2245 2007-11-22  Dan Bernstein  <mitz@apple.com>
2246
2247         Reviewed by Mark Rowe.
2248
2249         - fix crash when running pixel tests
2250
2251         * DumpRenderTree/mac/DumpRenderTree.mm:
2252         (dumpRenderTree): Parse the command line options before setting up the
2253         environment so that we know if we need to set up the pixel dump
2254         machinery.
2255
2256 2007-11-21  Eric Seidel  <eric@webkit.org>
2257
2258         Speculative build fix for Tiger.
2259
2260         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2261
2262 2007-11-21  Eric Seidel  <eric@webkit.org>
2263
2264         Reviewed by Tim Hatcher.
2265
2266         Break out more of DumpRenderTree.mm into individual files
2267
2268         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2269         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2270         (checkedMalloc):
2271         (checkedRealloc):
2272         (makeLargeMallocFailSilently):
2273         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2274         * DumpRenderTree/mac/DumpRenderTree.mm:
2275         (crashHandler):
2276         (dump):
2277         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2278         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2279         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2280         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2281         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2282         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2283         (javaScriptThreads):
2284         (runJavaScriptThread):
2285         (startJavaScriptThreads):
2286         (stopJavaScriptThreads):
2287         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2288         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2289         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2290         (restoreColorSpace):
2291         (setDefaultColorProfileToRGB):
2292         (initializeColorSpaceAndScreeBufferForPixelTests):
2293         (md5HashStringForBitmap):
2294         (dumpWebViewAsPixelsAndCompareWithExpected):
2295
2296 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2297
2298         Move install-unix-extras to wx directory as it seems only to be used by that 
2299         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2300         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2301         have install-unix-extras install into WebKitLibraries as per
2302         convention.
2303         
2304         Reviewed by Mark Rowe.
2305
2306         * Scripts/install-unix-extras: Removed.
2307         * wx/build-wxwebkit:
2308         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2309
2310 2007-11-21  Eric Seidel  <eric@webkit.org>
2311
2312         Reviewed by Adam.
2313
2314         More refactoring for greater code readability
2315
2316         * DumpRenderTree/mac/DumpRenderTree.mm:
2317         (initializeGlobalsFromCommandLineOptions):
2318         (initializeColorSpaceAndScreeBufferForPixelTests):
2319         (addTestPluginsToPluginSearchPath):
2320         (useLongRunningServerMode):
2321         (runTestingServerLoop):
2322         (prepareConsistentTestingEnvironment):
2323         (dumpRenderTree):
2324         (main):
2325         (dumpFramesAsText):
2326         (dumpBackForwardListForWebView):
2327         (sizeWebViewForCurrentTest):
2328         (methodNameStringForFailedTest):
2329         (dumpBackForwardListForAllWindows):
2330         (dumpWebViewAsPixelsAndCompareWithExpected):
2331         (invalidateAnyPreviousWaitToDumpWatchdog):
2332         (dump):
2333         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2334         * DumpRenderTree/mac/UIDelegate.mm:
2335         (-[UIDelegate webView:createWebViewWithRequest:]):
2336
2337 2007-11-21  Eric Seidel  <eric@webkit.org>
2338
2339         Reviewed by Tim Hatcher.
2340
2341         Abstract more of DRT into static methods
2342
2343         * DumpRenderTree/mac/DumpRenderTree.mm:
2344         (setDefaultsToConsistentValuesForTesting):
2345         (setupSignalHandlers):
2346         (allocateGlobalControllers):
2347         (releaseAndZero):
2348         (releaseGlobalControllers):
2349         (dumpRenderTree):
2350         (shouldLogFrameLoadDelegates):
2351         (createCFURLFromPathOrURL):
2352         (resetWebViewToConsistentStateBeforeTesting):
2353         (runTest):
2354
2355 2007-11-21  Eric Seidel  <eric@webkit.org>
2356
2357         Reviewed by Tim Hatcher.
2358
2359         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2360
2361         * DumpRenderTree/DumpRenderTree.h:
2362         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2363         * DumpRenderTree/mac/DumpRenderTree.mm:
2364         (dumpRenderTree):
2365         (dump):
2366         (runTest):
2367         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2368         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2369         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2370         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2371         (-[DumpRenderTreePasteboard declareType:owner:]):
2372         (+[LocalPasteboard alloc]):
2373         (-[LocalPasteboard init]):
2374         (-[LocalPasteboard dealloc]):
2375         (-[LocalPasteboard name]):
2376         (-[LocalPasteboard releaseGlobally]):
2377         (-[LocalPasteboard declareTypes:owner:]):
2378         (-[LocalPasteboard addTypes:owner:]):
2379         (-[LocalPasteboard changeCount]):
2380         (-[LocalPasteboard types]):
2381         (-[LocalPasteboard availableTypeFromArray:]):
2382         (-[LocalPasteboard setData:forType:]):
2383         (-[LocalPasteboard dataForType:]):
2384         (-[LocalPasteboard setPropertyList:forType:]):
2385         (-[LocalPasteboard setString:forType:]):
2386         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2387         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2388         (+[DumpRenderTreeWindow allWindows]):
2389         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2390         (-[DumpRenderTreeWindow dealloc]):
2391         (-[DumpRenderTreeWindow isKeyWindow]):
2392         (-[DumpRenderTreeWindow keyDown:]):
2393
2394 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2395
2396         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2397         it indiscriminately copies any headers inside JavaScriptCore,
2398         which includes Tiger ICU headers. 
2399
2400         * wx/build-wxwebkit:
2401         Don't run WebCore/move-js-headers.sh any longer.
2402
2403 2007-11-20  Adam Treat  <treat@kde.org>
2404
2405         Reviewed by David Kilzer.
2406
2407         * Prepend git branch name to $baseProductDir
2408
2409         * Scripts/VCSUtils.pm:
2410         * Scripts/webkitdirs.pm:
2411
2412 2007-11-20  Mark Rowe  <mrowe@apple.com>
2413
2414         Reviewed by Simon Hausmann.
2415
2416         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2417         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2418         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2419         built product and generated Makefile's are removed.
2420
2421 2007-11-19  Alp Toker  <alp@atoker.com>
2422
2423         Reviewed by Mark Rowe.
2424
2425         http://bugs.webkit.org/show_bug.cgi?id=16040
2426         [GTK] GtkLauncher should be written in C
2427
2428         Port GtkLauncher to plain C.
2429
2430         Use a more conventional GTK+ coding style.
2431
2432         Use a toolbar instead of menus.
2433
2434         Various signature fixes and cleanups.
2435
2436         Add a license header. Assume all previous modifications were copyright
2437         assigned to Apple Inc. by default.
2438
2439         * GtkLauncher/GtkLauncher.pro:
2440         * GtkLauncher/main.c: Added.
2441         (activate_url_entry_cb):
2442         (update_title):
2443         (link_hover_cb):
2444         (title_change_cb):
2445         (progress_change_cb):
2446         (destroy_cb):
2447         (go_back_cb):
2448         (go_forward_cb):
2449         (create_browser):
2450         (create_statusbar):
2451         (create_toolbar):
2452         (create_window):
2453         (main):
2454         * GtkLauncher/main.cpp: Removed.
2455
2456 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2457
2458         Build script fixes to ensure they do the right thing for the 
2459         wx port, and update build-wxwebkit to reflect the way the
2460         build scripts now work.
2461
2462         Reviewed by Adam.
2463
2464         * Scripts/build-testkjs:
2465         * Scripts/build-webkit:
2466         * Scripts/run-javascriptcore-tests:
2467         * Scripts/webkitdirs.pm:
2468         * wx/build-wxwebkit:
2469
2470 2007-11-18  Eric Seidel  <eric@webkit.org>
2471
2472         Reviewed by Anders.
2473
2474         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2475
2476         * Scripts/run-javascriptcore-tests:
2477
2478 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2479
2480         Reviewed by Adam Roben.
2481
2482         Make run-webkit-tests work with Windows debug build.
2483
2484         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2485         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2486         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2487         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2488         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2489
2490 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2491
2492         Add wxWebKit sample and build script, and integrate it with 
2493         build-webkit. Also make build-webkit --clean work for all
2494         ports.
2495
2496         Reviewed by Darin Adler.
2497
2498         * Scripts/build-webkit:
2499         * Scripts/webkitdirs.pm:
2500         * wx: Added.
2501         * wx/browser: Added.
2502         * wx/browser/browser.bkl: Added.
2503         * wx/browser/browser.cpp: Added.
2504         * wx/build-wxwebkit: Added.
2505
2506 2007-11-17  Adam Roben  <aroben@apple.com>
2507
2508         Make it easy to run Safari in the debugger on Windows
2509
2510         I've added a new script, debug-safari, which launches Safari in the
2511         debugger. On OS X it just calls gdb-safari.
2512
2513         Reviewed by Mark Rowe.
2514
2515         * FindSafari/FindSafari.cpp:
2516         (_tmain): Added a /debugger flag, which in combination with
2517         /printSafariLauncher will print a script that launches Safari in the
2518         debugger.
2519         * Scripts/debug-safari: Added.
2520         * Scripts/run-safari: Changed to call runSafari().
2521         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2522         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2523         first argument along to FindSafari.
2524         * Scripts/webkitdirs.pm:
2525         (sub runSafari): Added.
2526
2527 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2528
2529         Reviewed by Adam Roben.
2530
2531         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2532
2533 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2534
2535         Reviewed by David Kilzer.
2536
2537         The git config command was renamed to repo-config at some point. This
2538         change tries git config and then git repo-config if the first fails.
2539
2540         * Scripts/prepare-ChangeLog:
2541         (gitConfig):
2542
2543 2007-11-16  Dan Bernstein  <mitz@apple.com>
2544
2545         Reviewed by Darin Adler and Sam Weinig.
2546
2547         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2548
2549         * DumpRenderTree/win/EventSender.cpp:
2550         (keyDownCallback): For characters that cannot be entered on the active
2551         keyboard layout, send a WM_CHAR message with the character along with
2552         a WM_KEYDOWN message with a virtual key code of 255.
2553
2554 2007-11-16  Mark Rowe  <mrowe@apple.com>
2555
2556         Reviewed by Tim Hatcher.
2557
2558         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2559
2560         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2561         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2562
2563 2007-11-15  Adam Roben  <aroben@apple.com>
2564
2565         Make run-safari actually work on Windows
2566
2567         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2568         chdir call.
2569
2570 2007-11-14  Adam Roben  <aroben@apple.com>
2571
2572         Updates to Safari launching now that 3.0.4 is released
2573
2574         Reviewed by Sam.
2575
2576         * FindSafari/FindSafari.cpp:
2577         (getWebViewCLSID): Use version-independent ProgID.
2578         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2579
2580 2007-11-14  Anders Carlsson  <andersca@apple.com>
2581
2582         Reviewed by Adam.
2583
2584         <rdar://problem/5309081>
2585         In DRT, "plugin.logDestroy = true" not working on Windows.
2586         
2587         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2588         (NPP_Destroy):
2589
2590 2007-11-14  Eric Seidel  <eric@webkit.org>
2591
2592         Reviewed by Sam.
2593
2594         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2595
2596 2007-11-14  Anders Carlsson  <andersca@apple.com>
2597
2598         Reviewed by Adam.
2599
2600         <rdar://problem/5141186>
2601         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2602         
2603         Implement setWindowIsKey.
2604         
2605         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2606         (LayoutTestController::setWindowIsKey):
2607
2608 2007-11-13  Sam Weinig  <sam@webkit.org>
2609
2610         Reviewed by Adam Roben.
2611
2612         Fix for <rdar://problem/5382579>
2613         http/tests/security/cross-frame-access-put.html reports large 
2614         negative numbers for screenLeft and screenTop (Mac reports "0")
2615
2616         * DumpRenderTree/win/UIDelegate.cpp:
2617         (UIDelegate::UIDelegate): Initialize the RECT.
2618         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2619         (UIDelegate::webViewFrame): ditto.
2620         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2621
2622 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2623
2624         Reviewed by Adam.
2625
2626         - Make Drosera show source, source URLs, and function stack on Windows,
2627         and some minor fixes.
2628
2629         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2630         (DebuggerDocument::updateFileSource):
2631         * Drosera/debugger.js: Force source to always update display.
2632         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2633         menu controls.
2634         (DebuggerClient::resume):
2635         (DebuggerClient::pause):
2636         (DebuggerClient::stepInto):
2637         (DebuggerClient::stepOver):
2638         (DebuggerClient::stepOut):
2639         (DebuggerClient::showConsole):
2640         (DebuggerClient::closeCurrentFile):
2641         * Drosera/win/DebuggerClient.h: Ditto.
2642         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2643         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2644         removed two bugs.  1) caller could be in a bad state when asked to
2645         assign into it. 2) BSTRs were not created correctly.
2646         (DebuggerDocument::getPlatformCurrentFunctionStack):
2647         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2648         (droseraWndProc):
2649         (handleCommand):
2650         (Drosera::resume):
2651         (Drosera::pause):
2652         (Drosera::stepInto):
2653         (Drosera::stepOver):
2654         (Drosera::stepOut):
2655         (Drosera::showConsole):
2656         (Drosera::closeCurrentFile):
2657         * Drosera/win/Drosera.h: Hook up the menu controls.
2658         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2659         functions, added a null check, and fixed another bug where caller could
2660         be in a bad state when asked to assign into it.
2661         (ServerConnection::didLoadMainResourceForDataSource):
2662         (ServerConnection::getCallerFrame):
2663         * Drosera/win/ServerConnection.h: Safety first.
2664
2665 2007-11-13  Dan Bernstein  <mitz@apple.com>
2666
2667         Reviewed by Darin Adler.
2668
2669         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2670           DumpRenderTree --pixel-tests renders each test twice
2671
2672         * DumpRenderTree/mac/DumpRenderTree.mm:
2673         (dumpRenderTree): Removed the --paint option because the painting code
2674         is always exercised as a result of
2675         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2676         calling -displayIfNeeded.
2677         (dump): Changed to always grab the image from the window since the view
2678         is always displayed.
2679         (runTest):
2680         (displayWebView):
2681         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2682         because it always paints.
2683
2684 2007-11-12  Antti Koivisto  <antti@apple.com>
2685
2686         Reviewed by Adele.
2687         
2688         Add support for http media tests
2689
2690         * Scripts/run-webkit-tests:
2691
2692 2007-11-12  Sam Weinig  <sam@webkit.org>
2693
2694         Reviewed by Adam Roben.
2695
2696         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2697
2698         * DumpRenderTree/win/DumpRenderTree.cpp:
2699         (runTest):
2700         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2701         (LayoutTestController::setPrivateBrowsingEnabled):
2702
2703 2007-11-12  Adam Roben  <aroben@apple.com>
2704
2705         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2706         mac and win subdirectories.
2707
2708 2007-11-11  Adam Roben  <aroben@apple.com>
2709
2710         Fix <rdar://5133816> keepWebHistory is not implemented
2711
2712         Fixes fast/history/clicked-link-is-visited.html.
2713
2714         Reviewed by Darin.
2715
2716         * DumpRenderTree/win/DumpRenderTree.cpp:
2717         (runTest): Clear the optionalSharedHistory.
2718         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2719         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2720
2721 2007-11-10  Sam Weinig  <sam@webkit.org>
2722
2723         Reviewed by Tim Hatcher.
2724
2725         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2726         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2727         is turned on)
2728
2729         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2730
2731         Added test: http/tests/security/cross-frame-access-private-browsing.html
2732
2733         * DumpRenderTree/LayoutTestController.cpp:
2734         (setPrivateBrowsingEnabledCallback):
2735         (LayoutTestController::staticFunctions):
2736         * DumpRenderTree/LayoutTestController.h:
2737         * DumpRenderTree/mac/DumpRenderTree.mm:
2738         (runTest): Default to private browsing disabled.
2739         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2740         (LayoutTestController::setPrivateBrowsingEnabled):
2741         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2742         (LayoutTestController::setPrivateBrowsingEnabled):
2743
2744 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2745
2746         Reviewed by Adam.
2747
2748         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2749         WebCore's!
2750
2751         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2752         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2753         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2754         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2755         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2756         * Drosera/win/Drosera.cpp:
2757         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2758
2759 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2760
2761         Reviewed by Sam.
2762
2763         - Use the new IWebFrame [local] function signature and get the shared
2764         server correctly.
2765
2766         * Drosera/win/DebuggerClient.cpp:
2767         (DebuggerClient::didFinishLoadForFrame):
2768         * Drosera/win/ServerConnection.cpp:
2769         (ServerConnection::attemptToCreateServerConnection):
2770
2771 2007-11-07  Dan Bernstein  <mitz@apple.com>
2772
2773         Reviewed by Darin Adler.
2774
2775         - add an option to run-webkit-tests to ignore pixel test failures where
2776           all pixels differ by no more than a specified threshold
2777
2778         * DumpRenderTree/mac/ImageDiff.m:
2779         (main):
2780         (compareImages):
2781         (computePercentageDifferent):
2782         * Scripts/run-webkit-tests:
2783
2784 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2785
2786         Reviewed by Lars.
2787
2788         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2789
2790         * DumpRenderTree/qt/DumpRenderTree.cpp:
2791
2792 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2793
2794         Reviewed by Lars.
2795
2796         Reworked the QWebSettings API.
2797         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2798
2799         * DumpRenderTree/qt/DumpRenderTree.cpp:
2800
2801 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2802
2803         Reviewed by Lars.
2804
2805         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2806
2807         * DumpRenderTree/qt/jsobjects.cpp:
2808
2809 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2810
2811         Reviewed by Lars Knoll <lars@trolltech.com>.
2812
2813         Add a QWebPage::frameCreated() signal and fix DRT
2814         
2815         The removal of createFrame in QWebPage broke the re-implementation
2816         in DumpRenderTree. Instead emit a frameCreated() signal and
2817         connect to it in DumpRenderTree.
2818         
2819
2820         * DumpRenderTree/qt/DumpRenderTree.cpp:
2821         (WebCore::WebPage::WebPage):
2822         (WebCore::DumpRenderTree::dump):
2823         (WebCore::DumpRenderTree::connectFrame):
2824         * DumpRenderTree/qt/DumpRenderTree.h:
2825
2826 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2827
2828         Reviewed by Lars Knoll <lars@trolltech.com>.
2829
2830         Moved all the event handlers from QWebFrame into QWebPage.
2831         
2832         This cleans up the public API and allows us to remove the
2833         HackWebFrame hack in DumpRenderTree.
2834         
2835
2836         * DumpRenderTree/qt/jsobjects.cpp:
2837         (EventSender::mouseDown):
2838         (EventSender::mouseUp):
2839         (EventSender::mouseMoveTo):
2840
2841 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2842
2843         Reviewed by Mark.
2844
2845         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2846         to prevent the default implementation from popping up messageboxes.
2847
2848         * DumpRenderTree/qt/DumpRenderTree.cpp:
2849         (WebCore::WebPage::javaScriptConfirm):
2850         (WebCore::WebPage::javaScriptPrompt):
2851
2852 2007-11-06  Eric Seidel  <eric@webkit.org>
2853
2854         * Scripts/build-testkjs: build fix... too many $$
2855
2856 2007-11-06  Eric Seidel  <eric@webkit.org>
2857
2858         Reviewed by Mark Rowe.
2859
2860         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2861
2862 2007-11-05  Adam Roben  <aroben@apple.com>
2863
2864         Add support on Windows for WEBKIT_TESTFONTS
2865
2866         This environment variable lets you specify where the fonts to be used
2867         by DumpRenderTree reside. The Qt port is already using this, so I'm
2868         just following their lead.
2869
2870         Reviewed by Darin.
2871
2872         * DumpRenderTree/win/DumpRenderTree.cpp:
2873         (exePath): Refactored code out of initialize().
2874         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2875         DumpRenderTree.resources.
2876         (initialize): Use the new fontsPath function.
2877         (main): Use the new exePath function.
2878         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2879         variable to DRT, like Qt does.
2880
2881 2007-11-05  Mark Rowe  <mrowe@apple.com>
2882
2883         Rubber-stamped by Alp Toker.
2884
2885         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2886
2887         * GtkLauncher/main.cpp:
2888         (goToURLBarText):
2889         (main):
2890
2891 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2892
2893         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2894         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2895
2896         Reviewed by Timothy.
2897
2898         Restrict the range of nightly builds used by the bisect-builds script
2899         based on the version of Safari and the version of Mac OS X being used.
2900
2901         Mac OS X 10.4: Safari 2.0: r11976 or newer
2902         Mac OS X 10.4: Safari 3.0: r19992 or newer
2903
2904         Mac OS X 10.5: Safari 2.0: r19594 or newer
2905         Mac OS X 10.5: Safari 3.0: r25124 or newer
2906
2907         * Scripts/bisect-builds:
2908         (findMacOSXVersion): Added.
2909         (makeNightlyList): Added argument to provide version of Mac OS X.
2910         Restrict range of nightly builds based on Safari and Mac OS X versions.
2911
2912 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2913
2914         Reviewed by Maciej.
2915
2916         - This patch involves several changes, all of them were noticed that
2917         they were needed by the work being done in WebKit to get Drosera and
2918         WebKit working together on Windows.
2919         - The changes are:
2920         1) Added a debugger console for output messages.
2921         2) Drosera now listens for the WebKit server (before, the server would
2922         have to be running before Drosera was started.)
2923         3) Fixed a bug where the WebView started out as 0x0 pixels.
2924         4) Fixed a bug when there is no scope.
2925         5) Added the HTML, JS, and CSS to the project file to make them easy to
2926         find.
2927         6) Made the ServerConnection functions virtual.
2928
2929         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2930         for the WebKit server.
2931         (DebuggerClient::DebuggerClient):
2932         (DebuggerClient::~DebuggerClient):
2933         (DebuggerClient::didFinishLoadForFrame):
2934         (DebuggerClient::serverConnected):
2935         (DebuggerClient::attemptToCreateServerConnection):
2936         * Drosera/win/DebuggerClient.h: Ditto.
2937         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2938         scope.
2939         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2940         (DebuggerDocument::platformValueForScopeVariableNamed):
2941         * Drosera/win/Drosera.cpp:
2942         (_tWinMain): Added a console in debug for output messages.
2943         (Drosera::Drosera): Listen for server.
2944         (Drosera::initUI): The server now Initializes COM.
2945         (Drosera::serverConnected): Part of the listening for the server.
2946         (Drosera::attemptToCreateServerConnection): Ditto.
2947         * Drosera/win/Drosera.h: New interface for listening for the server.
2948         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2949         files to the VS project.
2950         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2951         connection.
2952         (ServerConnection::ServerConnection):
2953         (ServerConnection::attemptToCreateServerConnection):
2954         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2955         methods.
2956         (ServerConnection::serverConnected):
2957
2958 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2959
2960         Reviewed by Maciej.
2961
2962         http://bugs.webkit.org/show_bug.cgi?id=15832
2963         fast/dom/gc-10.html crashes when run alone
2964
2965         Check for !done before using objects that can be already deallocated.
2966
2967         * DumpRenderTree/mac/EditingDelegate.mm:
2968         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2969         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2970         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2971         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2972         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2973         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2974         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2975         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2976         (-[EditingDelegate webViewDidBeginEditing:]):
2977         (-[EditingDelegate webViewDidChange:]):
2978         (-[EditingDelegate webViewDidEndEditing:]):
2979         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2980         (-[EditingDelegate webViewDidChangeSelection:]):
2981         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2982         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2983         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2984         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2985         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2986         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2987         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2988         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2989         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2990         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2991         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2992         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2993         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2994         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2995         (-[FrameLoadDelegate webView:willCloseFrame:]):
2996         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2997         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2998         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2999         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3000         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3001         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3002         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3003         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3004         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3005
3006 2007-11-04  Mark Rowe  <mrowe@apple.com>
3007
3008         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3009         warnings that would otherwise be suppressed due to it being a system header.
3010
3011         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3012
3013 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3014
3015         Rubber stamped by Adam.
3016         
3017         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3018
3019         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3020
3021 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3022
3023         Sort files(...); sections of Xcode project files.
3024
3025         Rubber-stamped by Darin.
3026
3027         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3028         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3029         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3030         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3031
3032 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3033
3034         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3035
3036         Reviewed by Darin.
3037
3038         * Scripts/sort-Xcode-project-file: Added.
3039
3040 2007-11-02  Darin Adler  <darin@apple.com>
3041
3042         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3043
3044 2007-11-02  Darin Adler  <darin@apple.com>
3045
3046         Reviewed by Maciej.
3047
3048         * Scripts/run-sunspider: Pass the "--base" option through.
3049
3050         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3051         the real script do that. Default configuration to Release to match run-sunspider
3052         so we don't end up building Debug just to compare results.
3053
3054 2007-11-01  Adam Roben  <aroben@apple.com>
3055
3056         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3057
3058         Reviewed by Sam.
3059
3060         * Scripts/commit-log-editor: Show all the directories beneath the
3061         source root, instead of just the last one.
3062
3063 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3064
3065         Reviewed by Adam Roben.
3066
3067         Print out an error message when the Windows build fails
3068         and provide guidance on how to find out what went wrong.
3069
3070         * Scripts/build-webkit:
3071         * Scripts/webkitdirs.pm:
3072
3073 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3074
3075         Rubber-stamped by Adam Roben.
3076
3077         Rolled out r27326 - debug CRT seems to cause no problems after all.
3078
3079         * DumpRenderTree/win/DumpRenderTree.vcproj:
3080
3081 2007-10-31  Adam Roben  <aroben@apple.com>
3082
3083         Switch the Debug configuration to using the non-debug CRT
3084
3085         This matches WebKit.
3086
3087         Reviewed by Steve.
3088
3089         * DumpRenderTree/win/DumpRenderTree.vcproj:
3090
3091 2007-10-31  Antti Koivisto  <antti@apple.com>
3092
3093         Reviewed by bdash.
3094         
3095         Disable media tests when doing leak checking on Tiger.
3096         They crash in QuickTime (rdar://problem/5537157).
3097
3098         * Scripts/run-webkit-tests:
3099
3100 2007-10-29  Antti Koivisto  <antti@apple.com>
3101
3102         Reviewed by Maciej.
3103         
3104         Build media support by default on OSX only.
3105
3106         * Scripts/build-webkit:
3107
3108 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3109
3110         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3111         get caught by the pre-commit hooks.
3112
3113 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3114
3115         Reviewed by Adam.
3116
3117         - This is a collection of relatively unrelated changes and cleanups
3118         to Drosera to prepare it for interacting with WebKit.  A lot of these
3119         changes are just correcting mistakes, for example removing included
3120         headers that are no longer needed.
3121
3122         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3123         this will be needed by the DebuggerClient.
3124         (DebuggerDocument::server):
3125         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3126         * Drosera/win/DebuggerClient.cpp: 
3127         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3128         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3129         (DebuggerClient::createWebViewWithRequest): Added comment about its
3130         purpose. 
3131         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3132         declarations.
3133         (DebuggerClient::webViewLoaded): Moved.
3134         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3135         file, since this was the only place it was used.
3136         (cfStringToBSTR):
3137         * Drosera/win/Drosera.h: Cleaned up the includes.
3138         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3139         * Drosera/win/HelperFunctions.h: Removed.
3140
3141 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3142
3143         Reviewed by Adam.
3144
3145         - Small cleanup in the ServerConnection class.
3146
3147         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3148         and added an include.
3149         (ServerConnection::currentFrame):
3150         (ServerConnection::getCallerFrame):
3151         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3152         made a pointer into a COMPtr, and cleaned up the includes.
3153
3154 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3155
3156         Reviewed by John Sullivan.
3157         
3158         - Place the Localizable.strings file in mac or win directories
3159           if that location exists.
3160         - Also look for UI_STRING in .c files.
3161
3162         * Scripts/extract-localizable-strings:
3163
3164 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3165
3166         Reviewed by Adam.
3167
3168         - Set the eol-style to native and made all the line endings the same
3169         so that I avoid messy diffs that show eol changes.
3170
3171         * Drosera/win/ServerConnection.cpp:
3172         (ServerConnection::didParseSource):
3173         (ServerConnection::didEnterCallFrame):
3174         (ServerConnection::willExecuteStatement):
3175         (ServerConnection::willLeaveCallFrame):
3176         (ServerConnection::exceptionWasRaised):
3177
3178 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3179
3180         Reviewed by Adam.
3181
3182         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3183         functionality that could not have existed previously without the new
3184         interfaces.
3185         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3186         from a BSTR to a JSValueRef.
3187         (DebuggerDocument::platformEvaluateScript): Implemented.
3188         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3189         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3190         Implemented.
3191         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3192         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3193         * Drosera/win/ServerConnection.cpp: Added a helper function.
3194         (ServerConnection::getCallerFrame):
3195         * Drosera/win/ServerConnection.h: Added a helper function.
3196
3197 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3198
3199         updated reviewers for my previous changelog.
3200
3201 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3202         Reviewed by Maciej and Adam and Geoff.
3203
3204         - Minor mac-side improvements including moving a function to a more
3205         appropriate location, fixing a warning, and correctly checking
3206         exceptions.
3207
3208         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3209         (DebuggerDocument::willExecuteStatement):
3210         (DebuggerDocument::didEnterCallFrame):
3211         (DebuggerDocument::willLeaveCallFrame):
3212         (DebuggerDocument::windowScriptObjectAvailable):
3213         (DebuggerDocument::callFunctionOnObject):
3214         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3215         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3216         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3217         because it doesn't require the ServerConnection at all.
3218         (NSStringCreateWithJSStringRef): Made an argument const.
3219         (JSValueRefCreateWithNSString): Made an argument const.
3220         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3221         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3222         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3223         * Drosera/mac/ServerConnection.mm: Ditto.
3224         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3225
3226 2007-10-29  Sam Weinig  <sam@webkit.org>
3227
3228         Reviewed by Adam Roben.
3229
3230         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3231
3232         * DumpRenderTree/LayoutTestController.cpp:
3233         (LayoutTestController::LayoutTestController):
3234         (getGlobalFlagCallback):
3235         (setGlobalFlagCallback):
3236         (LayoutTestController::getJSClass):
3237         (LayoutTestController::staticValues):
3238         * DumpRenderTree/LayoutTestController.h:
3239         (LayoutTestController::globalFlag):
3240         (LayoutTestController::setGlobalFlag):
3241
3242 2007-10-29  Darin Adler  <darin@apple.com>
3243
3244         Reviewed by Maciej.
3245
3246         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3247         resolution instead of its default.
3248
3249 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3250
3251         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3252
3253         Reviewed by Mark Rowe.
3254
3255         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3256         was successfully resolved, but this would not show any status because the change had
3257         already been cached in the index using "git add".  The solution is to add an optional
3258         second argument to showStatus() which adds the "--cached" switch to the command.
3259
3260         * Scripts/resolve-ChangeLogs:
3261         (showStatus):
3262
3263 2007-10-28  Eric Seidel  <eric@webkit.org>
3264
3265         Reviewed by Maciej and Geoff, in unison.
3266
3267         * Scripts/run-webkit-tests: remove broken --svg option
3268
3269 2007-10-28  Darin Adler  <darin@apple.com>
3270
3271         Reviewed by Adam.
3272
3273         * Scripts/run-sunspider: Default to "Release" configuration rather than
3274         defaulting to the last configuration used as other scripts do. This can
3275         still be overriden on the command line with "--debug" if there's some
3276         reason to do so. Also fix a typo.
3277
3278         * Scripts/sunspider-compare-results: Fix a typo.
3279
3280 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3281
3282         Reviewed by Adam.
3283
3284         - Implemented the WebScriptDebugListener functions now that the
3285         WebScriptDebugServer exists
3286
3287         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3288         functions.
3289         (ServerConnection::currentFrame):
3290         (ServerConnection::didLoadMainResourceForDataSource):
3291         (ServerConnection::didParseSource):
3292         (ServerConnection::failedToParseSource):
3293         (ServerConnection::didEnterCallFrame):
3294         (ServerConnection::willExecuteStatement):
3295         (ServerConnection::willLeaveCallFrame):
3296         (ServerConnection::exceptionWasRaised):
3297         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3298         members arguments list.
3299
3300 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3301
3302         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3303         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3304
3305         Reviewed by Darin.
3306
3307         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3308         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3309         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3310         file.  Note that it may also be used as a stand-alone script.
3311
3312         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3313         * Scripts/resolve-ChangeLogs: Added.
3314         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3315
3316 2007-10-26  Mark Rowe  <mrowe@apple.com>
3317
3318         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3319         to the Qt port on the assumption that it was an implementation of the cross-platform
3320         LayoutTestController class.  It is not, so it did not need to be changed.
3321
3322         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3323
3324 2007-10-25  Mark Rowe  <mrowe@apple.com>
3325
3326         Reviewed by Maciej.
3327
3328         Fix builds with code coverage enabled.
3329
3330         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3331
3332 2007-10-25  Darin Adler  <darin@apple.com>
3333
3334         Reviewed by Mark Rowe.
3335
3336         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3337         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3338
3339 2007-10-25  Stephanie  <slewis@apple.com>
3340
3341         build Fix
3342
3343         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3344
3345 2007-10-25  Stephanie  <slewis@apple.com>
3346
3347         Reviewed by Mark Rowe, Adam Roben.
3348
3349         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3350
3351         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3352
3353 2007-10-25  Alice Liu  <alice.liu@apple.com>
3354
3355         Reviewed by Adam.
3356
3357         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3358
3359         Moving destructor into platform-specific files
3360         * DumpRenderTree/LayoutTestController.cpp:
3361         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3362         (LayoutTestController::~LayoutTestController):
3363         * DumpRenderTree/qt/jsobjects.cpp:
3364         (LayoutTestController::~LayoutTestController):
3365
3366         LayoutTestController wasn't being destroyed
3367         * DumpRenderTree/win/DumpRenderTree.cpp:
3368         (runTest):
3369
3370         Added declspec
3371         * DumpRenderTree/win/EditingDelegate.h:
3372
3373         Reset certain values on the webview (or related delegate) that might 
3374         have changed while running a test
3375         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3376         (LayoutTestController::~LayoutTestController):
3377
3378 2007-10-25  Adam Roben  <aroben@apple.com>
3379
3380         Make sunspider-compare-results work with relative paths
3381
3382         Reviewed by Sam.
3383
3384         * Scripts/sunspider-compare-results: Convert arguments to absolute
3385         paths before we chdir.
3386
3387 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3388
3389         Reviewed by Sam.
3390
3391         - Implemented server calls now the WebScriptDebugServer exists.
3392         - Also removed no longer needed call to initialize CG.
3393
3394         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3395         automatically now.
3396         (_tWinMain):
3397         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3398         (ServerConnection::ServerConnection):
3399         (ServerConnection::~ServerConnection):
3400         (ServerConnection::pause):
3401         (ServerConnection::resume):
3402         (ServerConnection::stepInto):
3403         (ServerConnection::applicationTerminating):
3404         (ServerConnection::serverConnectionDidDie):
3405         * Drosera/win/ServerConnection.h: Now uses the COM class.
3406
3407 2007-10-24  George Staikos  <staikos@kde.org>
3408
3409         Unbreak Qt build.
3410
3411         * Scripts/build-webkit:
3412
3413 2007-10-24  Adam Roben  <aroben@apple.com>
3414
3415         Remove now-unnecessary call to InitializeCoreGraphics
3416
3417         WebKit takes care of this now.
3418
3419         Reviewed by Ada.
3420
3421         * DumpRenderTree/win/DumpRenderTree.cpp:
3422         (initialize):
3423
3424 2007-10-24  Adam Roben  <aroben@apple.com>
3425
3426         Use WebTextRenderer in DRT
3427
3428         Reviewed by Ada.
3429
3430         * DumpRenderTree/win/DumpRenderTree.cpp:
3431         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3432
3433 2007-10-24  Sven Herzberg  <sven@imendio.com>
3434
3435         Reviewed by Mark Rowe.
3436
3437         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3438         Bug 15614: [GTK] qmake based backends don't build on OS X
3439
3440         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3441         GTK backend on a Mac
3442         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3443         isDarwin() to make it reusable in other places (like the workaround-
3444         for-prebuilt-qmake in build-webkit)
3445
3446 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3447
3448         Refurbish update-webkit script.
3449
3450         Reviewed by Adam.
3451
3452         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3453         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3454         multi-argument version of system() for flexibility and security.  Check for existence
3455         of Internal directory using -d test instead of -x.
3456
3457 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3458
3459         Minor clean-up of prepare-ChangeLog script.
3460
3461         Reviewed by Adam.
3462
3463         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3464         of a string.  Use multi-argument versions of open() and system() for flexibility and
3465         security.
3466
3467 2007-10-24  Alice Liu  <alice.liu@apple.com>
3468
3469         Reviewed by Oliver.
3470
3471         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3472
3473         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3474         replay the saved events when we're still processing the mousedown that starts the drag
3475         * DumpRenderTree/win/EventSender.cpp:
3476         (doMouseMove):
3477         * DumpRenderTree/win/UIDelegate.cpp:
3478         (UIDelegate::doDragDrop):
3479
3480 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3481
3482         Reviewed by Sam, Steve and Darin.
3483
3484         - Stubbed out the WebScriptDebugListener functionality in the Server
3485         Connection class to prepare it for receiving those callbacks.
3486         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3487         and the ServerConnection to not need to be initialized with a server
3488         name, since that is not the way we connect to the WebKit server. 
3489
3490         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3491         no exception.  Now it only loggs when there is an exception
3492         (DebuggerDocument::willExecuteStatement):
3493         (DebuggerDocument::didEnterCallFrame):
3494         (DebuggerDocument::willLeaveCallFrame):
3495         (DebuggerDocument::windowScriptObjectAvailable):
3496         (DebuggerDocument::callFunctionOnObject):
3497         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3498         to be instantiated with a server's name.
3499         (DebuggerClient::DebuggerClient):
3500         (DebuggerClient::didFinishLoadForFrame):
3501         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3502         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3503         a server name.
3504         (Drosera::init):
3505         (Drosera::initServer):
3506         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3507         instantiated with a server's name.
3508         * Drosera/win/ServerConnection.cpp: 
3509         (ServerConnection::ServerConnection): No longer needs a server name
3510         (ServerConnection::~ServerConnection): Only release the global context
3511         if there is one.
3512         (ServerConnection::serverConnectionDidDie): Stub for
3513         IWebScriptDebugListener
3514         (ServerConnection::QueryInterface): ditto
3515         (ServerConnection::AddRef): ditto
3516         (ServerConnection::Release): ditto
3517         (ServerConnection::didLoadMainResourceForDataSource): ditto
3518         (ServerConnection::didParseSource): ditto
3519         (ServerConnection::failedToParseSource): ditto
3520         (ServerConnection::didEnterCallFrame): ditto
3521         (ServerConnection::willExecuteStatement): ditto
3522         (ServerConnection::willLeaveCallFrame): ditto
3523         (ServerConnection::exceptionWasRaised): ditto
3524         * Drosera/win/ServerConnection.h: Stubbed out the
3525         IWebScriptDebugListener functions, and this class no longer needs to be
3526         instantiated with a server name.
3527
3528 2007-10-24  Lars Knoll  <lars@trolltech.com>
3529
3530         Reviewed by Simon.
3531
3532         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3533
3534         * DumpRenderTree/qt/jsobjects.h:
3535
3536 2007-10-24  Lars Knoll  <lars@trolltech.com>
3537
3538         Reviewed by Simon.
3539
3540         add another command.
3541
3542         * DumpRenderTree/qt/jsobjects.cpp:
3543         (TextInputController::doCommand):
3544
3545 2007-10-24  Lars Knoll  <lars@trolltech.com>
3546
3547         Reviewed by Simon.
3548
3549         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3550
3551         * DumpRenderTree/qt/jsobjects.cpp:
3552         (EventSender::keyDown):
3553         * DumpRenderTree/qt/jsobjects.h:
3554
3555 2007-10-24  Lars Knoll  <lars@trolltech.com>
3556
3557         Reviewed by Simon.
3558
3559         implement eventSender.keyDown().
3560
3561         * DumpRenderTree/qt/jsobjects.cpp:
3562         (EventSender::keyDown):
3563
3564 2007-10-24  Lars Knoll  <lars@trolltech.com>
3565
3566         Reviewed by Simon.
3567
3568         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3569
3570         * DumpRenderTree/qt/DumpRenderTree.cpp:
3571         (WebCore::DumpRenderTree::DumpRenderTree):
3572         (WebCore::DumpRenderTree::initJSObjects):
3573         * DumpRenderTree/qt/jsobjects.cpp:
3574         (TextInputController::doCommand):
3575
3576 2007-10-24  Lars Knoll  <lars@trolltech.com>
3577
3578         Reviewed by Simon.
3579
3580         first bit of implementation for the textinputcontroller.
3581
3582         * DumpRenderTree/qt/DumpRenderTree.cpp:
3583         (WebCore::DumpRenderTree::DumpRenderTree):
3584         * DumpRenderTree/qt/DumpRenderTree.h:
3585         * DumpRenderTree/qt/jsobjects.cpp:
3586         (TextInputController::TextInputController):
3587         (TextInputController::doCommand):
3588         * DumpRenderTree/qt/jsobjects.h:
3589
3590 2007-10-24  Lars Knoll  <lars@trolltech.com>
3591
3592         Reviewed by Simon.
3593
3594         make the man webpage believe it has focus, so the editing tests work correctly.
3595
3596         * DumpRenderTree/qt/DumpRenderTree.cpp:
3597         (WebCore::DumpRenderTree::DumpRenderTree):
3598
3599 2007-10-24  Lars Knoll  <lars@trolltech.com>
3600
3601         Reviewed by Simon.
3602
3603         implement layoutTestController.dumpEditingCallbacks() correctly.
3604
3605         * DumpRenderTree/qt/DumpRenderTree.cpp:
3606         (WebCore::DumpRenderTree::DumpRenderTree):
3607         * DumpRenderTree/qt/jsobjects.cpp:
3608         (LayoutTestController::reset):
3609         (LayoutTestController::dumpEditingCallbacks):
3610
3611 2007-10-24  Lars Knoll  <lars@trolltech.com>
3612
3613         Reviewed by Simon.
3614
3615         Implement support for testing editing.
3616
3617         * DumpRenderTree/qt/DumpRenderTree.cpp:
3618         (WebCore::DumpRenderTree::DumpRenderTree):
3619
3620 2007-10-23  Sam Weinig  <sam@webkit.org>
3621
3622         Check for null BSTR that can be passed to the UIDelegate methods
3623         from javascript null and undefined.  Fixes a failing test case on
3624         Windows (fast/dom/Window/alert-undefined.html)
3625
3626         Reviewed by Eric Seidel.
3627
3628         * DumpRenderTree/win/UIDelegate.cpp:
3629         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3630         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3631         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3632         (UIDelegate::webViewAddMessageToConsole):
3633
3634 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3635
3636         Reviewed by Darin.
3637         
3638         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3639
3640         * Scripts/build-testkjs:
3641
3642 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3643
3644         Reviewed by Darin.
3645
3646         - add wrapper that finds the right copy of testkjs
3647         
3648         * Scripts/sunspider-compare-results: Added.
3649
3650 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3651
3652         Reviewed by Sam.
3653
3654         - After talking with Steve I now see that the WebKit server must be
3655         running for DCOM to create the distributed objects, which makes sense
3656         and currently WebKit only allows one instance to be running at a time
3657         which avoids accidentally connecting to the wrong server
3658         - In light of this I have removed the code for the attach box and
3659         NotificationServer and known server names, since they are all extranious
3660         now.
3661