Reviewed by Adam Roben.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2
3         Reviewed by Adam Roben.
4
5         Make run-webkit-tests work with Windows debug build.
6
7         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
8         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
9         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
10         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
11         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
12
13 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
14
15         Add wxWebKit sample and build script, and integrate it with 
16         build-webkit. Also make build-webkit --clean work for all
17         ports.
18
19         Reviewed by Darin Adler.
20
21         * Scripts/build-webkit:
22         * Scripts/webkitdirs.pm:
23         * wx: Added.
24         * wx/browser: Added.
25         * wx/browser/browser.bkl: Added.
26         * wx/browser/browser.cpp: Added.
27         * wx/build-wxwebkit: Added.
28
29 2007-11-17  Adam Roben  <aroben@apple.com>
30
31         Make it easy to run Safari in the debugger on Windows
32
33         I've added a new script, debug-safari, which launches Safari in the
34         debugger. On OS X it just calls gdb-safari.
35
36         Reviewed by Mark Rowe.
37
38         * FindSafari/FindSafari.cpp:
39         (_tmain): Added a /debugger flag, which in combination with
40         /printSafariLauncher will print a script that launches Safari in the
41         debugger.
42         * Scripts/debug-safari: Added.
43         * Scripts/run-safari: Changed to call runSafari().
44         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
45         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
46         first argument along to FindSafari.
47         * Scripts/webkitdirs.pm:
48         (sub runSafari): Added.
49
50 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
51
52         Reviewed by Adam Roben.
53
54         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
55
56 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
57
58         Reviewed by David Kilzer.
59
60         The git config command was renamed to repo-config at some point. This
61         change tries git config and then git repo-config if the first fails.
62
63         * Scripts/prepare-ChangeLog:
64         (gitConfig):
65
66 2007-11-16  Dan Bernstein  <mitz@apple.com>
67
68         Reviewed by Darin Adler and Sam Weinig.
69
70         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
71
72         * DumpRenderTree/win/EventSender.cpp:
73         (keyDownCallback): For characters that cannot be entered on the active
74         keyboard layout, send a WM_CHAR message with the character along with
75         a WM_KEYDOWN message with a virtual key code of 255.
76
77 2007-11-16  Mark Rowe  <mrowe@apple.com>
78
79         Reviewed by Tim Hatcher.
80
81         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
82
83         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
84         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
85
86 2007-11-15  Adam Roben  <aroben@apple.com>
87
88         Make run-safari actually work on Windows
89
90         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
91         chdir call.
92
93 2007-11-14  Adam Roben  <aroben@apple.com>
94
95         Updates to Safari launching now that 3.0.4 is released
96
97         Reviewed by Sam.
98
99         * FindSafari/FindSafari.cpp:
100         (getWebViewCLSID): Use version-independent ProgID.
101         * Scripts/run-safari: Use run-webkit-nightly.cmd.
102
103 2007-11-14  Anders Carlsson  <andersca@apple.com>
104
105         Reviewed by Adam.
106
107         <rdar://problem/5309081>
108         In DRT, "plugin.logDestroy = true" not working on Windows.
109         
110         * DumpRenderTree/win/TestNetscapePlugin/main.c:
111         (NPP_Destroy):
112
113 2007-11-14  Eric Seidel  <eric@webkit.org>
114
115         Reviewed by Sam.
116
117         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
118
119 2007-11-14  Anders Carlsson  <andersca@apple.com>
120
121         Reviewed by Adam.
122
123         <rdar://problem/5141186>
124         window.layoutTestController.setWindowIsKey is not implemented in DRT.
125         
126         Implement setWindowIsKey.
127         
128         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
129         (LayoutTestController::setWindowIsKey):
130
131 2007-11-13  Sam Weinig  <sam@webkit.org>
132
133         Reviewed by Adam Roben.
134
135         Fix for <rdar://problem/5382579>
136         http/tests/security/cross-frame-access-put.html reports large 
137         negative numbers for screenLeft and screenTop (Mac reports "0")
138
139         * DumpRenderTree/win/UIDelegate.cpp:
140         (UIDelegate::UIDelegate): Initialize the RECT.
141         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
142         (UIDelegate::webViewFrame): ditto.
143         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
144
145 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
146
147         Reviewed by Adam.
148
149         - Make Drosera show source, source URLs, and function stack on Windows,
150         and some minor fixes.
151
152         * Drosera/DebuggerDocument.cpp: Force source to always update display.
153         (DebuggerDocument::updateFileSource):
154         * Drosera/debugger.js: Force source to always update display.
155         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
156         menu controls.
157         (DebuggerClient::resume):
158         (DebuggerClient::pause):
159         (DebuggerClient::stepInto):
160         (DebuggerClient::stepOver):
161         (DebuggerClient::stepOut):
162         (DebuggerClient::showConsole):
163         (DebuggerClient::closeCurrentFile):
164         * Drosera/win/DebuggerClient.h: Ditto.
165         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
166         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
167         removed two bugs.  1) caller could be in a bad state when asked to
168         assign into it. 2) BSTRs were not created correctly.
169         (DebuggerDocument::getPlatformCurrentFunctionStack):
170         * Drosera/win/Drosera.cpp: Hook up the menu controls.
171         (droseraWndProc):
172         (handleCommand):
173         (Drosera::resume):
174         (Drosera::pause):
175         (Drosera::stepInto):
176         (Drosera::stepOver):
177         (Drosera::stepOut):
178         (Drosera::showConsole):
179         (Drosera::closeCurrentFile):
180         * Drosera/win/Drosera.h: Hook up the menu controls.
181         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
182         functions, added a null check, and fixed another bug where caller could
183         be in a bad state when asked to assign into it.
184         (ServerConnection::didLoadMainResourceForDataSource):
185         (ServerConnection::getCallerFrame):
186         * Drosera/win/ServerConnection.h: Safety first.
187
188 2007-11-13  Dan Bernstein  <mitz@apple.com>
189
190         Reviewed by Darin Adler.
191
192         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
193           DumpRenderTree --pixel-tests renders each test twice
194
195         * DumpRenderTree/mac/DumpRenderTree.mm:
196         (dumpRenderTree): Removed the --paint option because the painting code
197         is always exercised as a result of
198         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
199         calling -displayIfNeeded.
200         (dump): Changed to always grab the image from the window since the view
201         is always displayed.
202         (runTest):
203         (displayWebView):
204         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
205         because it always paints.
206
207 2007-11-12  Antti Koivisto  <antti@apple.com>
208
209         Reviewed by Adele.
210         
211         Add support for http media tests
212
213         * Scripts/run-webkit-tests:
214
215 2007-11-12  Sam Weinig  <sam@webkit.org>
216
217         Reviewed by Adam Roben.
218
219         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
220
221         * DumpRenderTree/win/DumpRenderTree.cpp:
222         (runTest):
223         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
224         (LayoutTestController::setPrivateBrowsingEnabled):
225
226 2007-11-12  Adam Roben  <aroben@apple.com>
227
228         * Scripts/update-webkit-localizable-strings: Changed to only scan the
229         mac and win subdirectories.
230
231 2007-11-11  Adam Roben  <aroben@apple.com>
232
233         Fix <rdar://5133816> keepWebHistory is not implemented
234
235         Fixes fast/history/clicked-link-is-visited.html.
236
237         Reviewed by Darin.
238
239         * DumpRenderTree/win/DumpRenderTree.cpp:
240         (runTest): Clear the optionalSharedHistory.
241         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
242         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
243
244 2007-11-10  Sam Weinig  <sam@webkit.org>
245
246         Reviewed by Tim Hatcher.
247
248         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
249         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
250         is turned on)
251
252         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
253
254         Added test: http/tests/security/cross-frame-access-private-browsing.html
255
256         * DumpRenderTree/LayoutTestController.cpp:
257         (setPrivateBrowsingEnabledCallback):
258         (LayoutTestController::staticFunctions):
259         * DumpRenderTree/LayoutTestController.h:
260         * DumpRenderTree/mac/DumpRenderTree.mm:
261         (runTest): Default to private browsing disabled.
262         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
263         (LayoutTestController::setPrivateBrowsingEnabled):
264         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
265         (LayoutTestController::setPrivateBrowsingEnabled):
266
267 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
268
269         Reviewed by Adam.
270
271         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
272         WebCore's!
273
274         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
275         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
276         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
277         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
278         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
279         * Drosera/win/Drosera.cpp:
280         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
281
282 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
283
284         Reviewed by Sam.
285
286         - Use the new IWebFrame [local] function signature and get the shared
287         server correctly.
288
289         * Drosera/win/DebuggerClient.cpp:
290         (DebuggerClient::didFinishLoadForFrame):
291         * Drosera/win/ServerConnection.cpp:
292         (ServerConnection::attemptToCreateServerConnection):
293
294 2007-11-07  Dan Bernstein  <mitz@apple.com>
295
296         Reviewed by Darin Adler.
297
298         - add an option to run-webkit-tests to ignore pixel test failures where
299           all pixels differ by no more than a specified threshold
300
301         * DumpRenderTree/mac/ImageDiff.m:
302         (main):
303         (compareImages):
304         (computePercentageDifferent):
305         * Scripts/run-webkit-tests:
306
307 2007-11-07  Simon Hausmann  <hausmann@kde.org>
308
309         Reviewed by Lars.
310
311         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
312
313         * DumpRenderTree/qt/DumpRenderTree.cpp:
314
315 2007-11-07  Simon Hausmann  <hausmann@kde.org>
316
317         Reviewed by Lars.
318
319         Reworked the QWebSettings API.
320         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
321
322         * DumpRenderTree/qt/DumpRenderTree.cpp:
323
324 2007-11-07  Simon Hausmann  <hausmann@kde.org>
325
326         Reviewed by Lars.
327
328         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
329
330         * DumpRenderTree/qt/jsobjects.cpp:
331
332 2007-11-07  Simon Hausmann  <hausmann@kde.org>
333
334         Reviewed by Lars Knoll <lars@trolltech.com>.
335
336         Add a QWebPage::frameCreated() signal and fix DRT
337         
338         The removal of createFrame in QWebPage broke the re-implementation
339         in DumpRenderTree. Instead emit a frameCreated() signal and
340         connect to it in DumpRenderTree.
341         
342
343         * DumpRenderTree/qt/DumpRenderTree.cpp:
344         (WebCore::WebPage::WebPage):
345         (WebCore::DumpRenderTree::dump):
346         (WebCore::DumpRenderTree::connectFrame):
347         * DumpRenderTree/qt/DumpRenderTree.h:
348
349 2007-11-07  Simon Hausmann  <hausmann@kde.org>
350
351         Reviewed by Lars Knoll <lars@trolltech.com>.
352
353         Moved all the event handlers from QWebFrame into QWebPage.
354         
355         This cleans up the public API and allows us to remove the
356         HackWebFrame hack in DumpRenderTree.
357         
358
359         * DumpRenderTree/qt/jsobjects.cpp:
360         (EventSender::mouseDown):
361         (EventSender::mouseUp):
362         (EventSender::mouseMoveTo):
363
364 2007-11-07  Simon Hausmann  <hausmann@kde.org>
365
366         Reviewed by Mark.
367
368         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
369         to prevent the default implementation from popping up messageboxes.
370
371         * DumpRenderTree/qt/DumpRenderTree.cpp:
372         (WebCore::WebPage::javaScriptConfirm):
373         (WebCore::WebPage::javaScriptPrompt):
374
375 2007-11-06  Eric Seidel  <eric@webkit.org>
376
377         * Scripts/build-testkjs: build fix... too many $$
378
379 2007-11-06  Eric Seidel  <eric@webkit.org>
380
381         Reviewed by Mark Rowe.
382
383         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
384
385 2007-11-05  Adam Roben  <aroben@apple.com>
386
387         Add support on Windows for WEBKIT_TESTFONTS
388
389         This environment variable lets you specify where the fonts to be used
390         by DumpRenderTree reside. The Qt port is already using this, so I'm
391         just following their lead.
392
393         Reviewed by Darin.
394
395         * DumpRenderTree/win/DumpRenderTree.cpp:
396         (exePath): Refactored code out of initialize().
397         (fontsPath): Returns either $WEBKIT_TESTFONTS or
398         DumpRenderTree.resources.
399         (initialize): Use the new fontsPath function.
400         (main): Use the new exePath function.
401         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
402         variable to DRT, like Qt does.
403
404 2007-11-05  Mark Rowe  <mrowe@apple.com>
405
406         Rubber-stamped by Alp Toker.
407
408         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
409
410         * GtkLauncher/main.cpp:
411         (goToURLBarText):
412         (main):
413
414 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
415
416         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
417         <http://bugs.webkit.org/show_bug.cgi?id=15830>
418
419         Reviewed by Timothy.
420
421         Restrict the range of nightly builds used by the bisect-builds script
422         based on the version of Safari and the version of Mac OS X being used.
423
424         Mac OS X 10.4: Safari 2.0: r11976 or newer
425         Mac OS X 10.4: Safari 3.0: r19992 or newer
426
427         Mac OS X 10.5: Safari 2.0: r19594 or newer
428         Mac OS X 10.5: Safari 3.0: r25124 or newer
429
430         * Scripts/bisect-builds:
431         (findMacOSXVersion): Added.
432         (makeNightlyList): Added argument to provide version of Mac OS X.
433         Restrict range of nightly builds based on Safari and Mac OS X versions.
434
435 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
436
437         Reviewed by Maciej.
438
439         - This patch involves several changes, all of them were noticed that
440         they were needed by the work being done in WebKit to get Drosera and
441         WebKit working together on Windows.
442         - The changes are:
443         1) Added a debugger console for output messages.
444         2) Drosera now listens for the WebKit server (before, the server would
445         have to be running before Drosera was started.)
446         3) Fixed a bug where the WebView started out as 0x0 pixels.
447         4) Fixed a bug when there is no scope.
448         5) Added the HTML, JS, and CSS to the project file to make them easy to
449         find.
450         6) Made the ServerConnection functions virtual.
451
452         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
453         for the WebKit server.
454         (DebuggerClient::DebuggerClient):
455         (DebuggerClient::~DebuggerClient):
456         (DebuggerClient::didFinishLoadForFrame):
457         (DebuggerClient::serverConnected):
458         (DebuggerClient::attemptToCreateServerConnection):
459         * Drosera/win/DebuggerClient.h: Ditto.
460         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
461         scope.
462         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
463         (DebuggerDocument::platformValueForScopeVariableNamed):
464         * Drosera/win/Drosera.cpp:
465         (_tWinMain): Added a console in debug for output messages.
466         (Drosera::Drosera): Listen for server.
467         (Drosera::initUI): The server now Initializes COM.
468         (Drosera::serverConnected): Part of the listening for the server.
469         (Drosera::attemptToCreateServerConnection): Ditto.
470         * Drosera/win/Drosera.h: New interface for listening for the server.
471         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
472         files to the VS project.
473         * Drosera/win/ServerConnection.cpp: Part of listening for the server
474         connection.
475         (ServerConnection::ServerConnection):
476         (ServerConnection::attemptToCreateServerConnection):
477         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
478         methods.
479         (ServerConnection::serverConnected):
480
481 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
482
483         Reviewed by Maciej.
484
485         http://bugs.webkit.org/show_bug.cgi?id=15832
486         fast/dom/gc-10.html crashes when run alone
487
488         Check for !done before using objects that can be already deallocated.
489
490         * DumpRenderTree/mac/EditingDelegate.mm:
491         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
492         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
493         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
494         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
495         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
496         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
497         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
498         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
499         (-[EditingDelegate webViewDidBeginEditing:]):
500         (-[EditingDelegate webViewDidChange:]):
501         (-[EditingDelegate webViewDidEndEditing:]):
502         (-[EditingDelegate webViewDidChangeTypingStyle:]):
503         (-[EditingDelegate webViewDidChangeSelection:]):
504         * DumpRenderTree/mac/FrameLoadDelegate.mm:
505         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
506         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
507         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
508         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
509         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
510         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
511         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
512         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
513         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
514         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
515         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
516         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
517         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
518         (-[FrameLoadDelegate webView:willCloseFrame:]):
519         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
520         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
521         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
522         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
523         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
524         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
525         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
526         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
527         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
528
529 2007-11-04  Mark Rowe  <mrowe@apple.com>
530
531         Build fix.  Don't use Carbon.h as the prefix header as it triggers
532         warnings that would otherwise be suppressed due to it being a system header.
533
534         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
535
536 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
537
538         Rubber stamped by Adam.
539         
540         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
541
542         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
543
544 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
545
546         Sort files(...); sections of Xcode project files.
547
548         Rubber-stamped by Darin.
549
550         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
551         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
552         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
553         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
554
555 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
556
557         Script to sort "files(...);" sections in Xcode project.pbxproj files.
558
559         Reviewed by Darin.
560
561         * Scripts/sort-Xcode-project-file: Added.
562
563 2007-11-02  Darin Adler  <darin@apple.com>
564
565         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
566
567 2007-11-02  Darin Adler  <darin@apple.com>
568
569         Reviewed by Maciej.
570
571         * Scripts/run-sunspider: Pass the "--base" option through.
572
573         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
574         the real script do that. Default configuration to Release to match run-sunspider
575         so we don't end up building Debug just to compare results.
576
577 2007-11-01  Adam Roben  <aroben@apple.com>
578
579         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
580
581         Reviewed by Sam.
582
583         * Scripts/commit-log-editor: Show all the directories beneath the
584         source root, instead of just the last one.
585
586 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
587
588         Reviewed by Adam Roben.
589
590         Print out an error message when the Windows build fails
591         and provide guidance on how to find out what went wrong.
592
593         * Scripts/build-webkit:
594         * Scripts/webkitdirs.pm:
595
596 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
597
598         Rubber-stamped by Adam Roben.
599
600         Rolled out r27326 - debug CRT seems to cause no problems after all.
601
602         * DumpRenderTree/win/DumpRenderTree.vcproj:
603
604 2007-10-31  Adam Roben  <aroben@apple.com>
605
606         Switch the Debug configuration to using the non-debug CRT
607
608         This matches WebKit.
609
610         Reviewed by Steve.
611
612         * DumpRenderTree/win/DumpRenderTree.vcproj:
613
614 2007-10-31  Antti Koivisto  <antti@apple.com>
615
616         Reviewed by bdash.
617         
618         Disable media tests when doing leak checking on Tiger.
619         They crash in QuickTime (rdar://problem/5537157).
620
621         * Scripts/run-webkit-tests:
622
623 2007-10-29  Antti Koivisto  <antti@apple.com>
624
625         Reviewed by Maciej.
626         
627         Build media support by default on OSX only.
628
629         * Scripts/build-webkit:
630
631 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
632
633         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
634         get caught by the pre-commit hooks.
635
636 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
637
638         Reviewed by Adam.
639
640         - This is a collection of relatively unrelated changes and cleanups
641         to Drosera to prepare it for interacting with WebKit.  A lot of these
642         changes are just correcting mistakes, for example removing included
643         headers that are no longer needed.
644
645         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
646         this will be needed by the DebuggerClient.
647         (DebuggerDocument::server):
648         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
649         * Drosera/win/DebuggerClient.cpp: 
650         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
651         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
652         (DebuggerClient::createWebViewWithRequest): Added comment about its
653         purpose. 
654         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
655         declarations.
656         (DebuggerClient::webViewLoaded): Moved.
657         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
658         file, since this was the only place it was used.
659         (cfStringToBSTR):
660         * Drosera/win/Drosera.h: Cleaned up the includes.
661         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
662         * Drosera/win/HelperFunctions.h: Removed.
663
664 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
665
666         Reviewed by Adam.
667
668         - Small cleanup in the ServerConnection class.
669
670         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
671         and added an include.
672         (ServerConnection::currentFrame):
673         (ServerConnection::getCallerFrame):
674         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
675         made a pointer into a COMPtr, and cleaned up the includes.
676
677 2007-10-29  Timothy Hatcher  <timothy@apple.com>
678
679         Reviewed by John Sullivan.
680         
681         - Place the Localizable.strings file in mac or win directories
682           if that location exists.
683         - Also look for UI_STRING in .c files.
684
685         * Scripts/extract-localizable-strings:
686
687 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
688
689         Reviewed by Adam.
690
691         - Set the eol-style to native and made all the line endings the same
692         so that I avoid messy diffs that show eol changes.
693
694         * Drosera/win/ServerConnection.cpp:
695         (ServerConnection::didParseSource):
696         (ServerConnection::didEnterCallFrame):
697         (ServerConnection::willExecuteStatement):
698         (ServerConnection::willLeaveCallFrame):
699         (ServerConnection::exceptionWasRaised):
700
701 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
702
703         Reviewed by Adam.
704
705         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
706         functionality that could not have existed previously without the new
707         interfaces.
708         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
709         from a BSTR to a JSValueRef.
710         (DebuggerDocument::platformEvaluateScript): Implemented.
711         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
712         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
713         Implemented.
714         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
715         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
716         * Drosera/win/ServerConnection.cpp: Added a helper function.
717         (ServerConnection::getCallerFrame):
718         * Drosera/win/ServerConnection.h: Added a helper function.
719
720 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
721
722         updated reviewers for my previous changelog.
723
724 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
725         Reviewed by Maciej and Adam and Geoff.
726
727         - Minor mac-side improvements including moving a function to a more
728         appropriate location, fixing a warning, and correctly checking
729         exceptions.
730
731         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
732         (DebuggerDocument::willExecuteStatement):
733         (DebuggerDocument::didEnterCallFrame):
734         (DebuggerDocument::willLeaveCallFrame):
735         (DebuggerDocument::windowScriptObjectAvailable):
736         (DebuggerDocument::callFunctionOnObject):
737         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
738         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
739         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
740         because it doesn't require the ServerConnection at all.
741         (NSStringCreateWithJSStringRef): Made an argument const.
742         (JSValueRefCreateWithNSString): Made an argument const.
743         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
744         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
745         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
746         * Drosera/mac/ServerConnection.mm: Ditto.
747         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
748
749 2007-10-29  Sam Weinig  <sam@webkit.org>
750
751         Reviewed by Adam Roben.
752
753         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
754
755         * DumpRenderTree/LayoutTestController.cpp:
756         (LayoutTestController::LayoutTestController):
757         (getGlobalFlagCallback):
758         (setGlobalFlagCallback):
759         (LayoutTestController::getJSClass):
760         (LayoutTestController::staticValues):
761         * DumpRenderTree/LayoutTestController.h:
762         (LayoutTestController::globalFlag):
763         (LayoutTestController::setGlobalFlag):
764
765 2007-10-29  Darin Adler  <darin@apple.com>
766
767         Reviewed by Maciej.
768
769         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
770         resolution instead of its default.
771
772 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
773
774         Fixed showStatus() to print status for successfully resolved conflicts when using git.
775
776         Reviewed by Mark Rowe.
777
778         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
779         was successfully resolved, but this would not show any status because the change had
780         already been cached in the index using "git add".  The solution is to add an optional
781         second argument to showStatus() which adds the "--cached" switch to the command.
782
783         * Scripts/resolve-ChangeLogs:
784         (showStatus):
785
786 2007-10-28  Eric Seidel  <eric@webkit.org>
787
788         Reviewed by Maciej and Geoff, in unison.
789
790         * Scripts/run-webkit-tests: remove broken --svg option
791
792 2007-10-28  Darin Adler  <darin@apple.com>
793
794         Reviewed by Adam.
795
796         * Scripts/run-sunspider: Default to "Release" configuration rather than
797         defaulting to the last configuration used as other scripts do. This can
798         still be overriden on the command line with "--debug" if there's some
799         reason to do so. Also fix a typo.
800
801         * Scripts/sunspider-compare-results: Fix a typo.
802
803 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
804
805         Reviewed by Adam.
806
807         - Implemented the WebScriptDebugListener functions now that the
808         WebScriptDebugServer exists
809
810         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
811         functions.
812         (ServerConnection::currentFrame):
813         (ServerConnection::didLoadMainResourceForDataSource):
814         (ServerConnection::didParseSource):
815         (ServerConnection::failedToParseSource):
816         (ServerConnection::didEnterCallFrame):
817         (ServerConnection::willExecuteStatement):
818         (ServerConnection::willLeaveCallFrame):
819         (ServerConnection::exceptionWasRaised):
820         * Drosera/win/ServerConnection.h: Removed unused arguments from the
821         members arguments list.
822
823 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
824
825         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
826         <http://bugs.webkit.org/show_bug.cgi?id=15600>
827
828         Reviewed by Darin.
829
830         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
831         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
832         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
833         file.  Note that it may also be used as a stand-alone script.
834
835         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
836         * Scripts/resolve-ChangeLogs: Added.
837         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
838
839 2007-10-26  Mark Rowe  <mrowe@apple.com>
840
841         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
842         to the Qt port on the assumption that it was an implementation of the cross-platform
843         LayoutTestController class.  It is not, so it did not need to be changed.
844
845         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
846
847 2007-10-25  Mark Rowe  <mrowe@apple.com>
848
849         Reviewed by Maciej.
850
851         Fix builds with code coverage enabled.
852
853         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
854
855 2007-10-25  Darin Adler  <darin@apple.com>
856
857         Reviewed by Mark Rowe.
858
859         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
860         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
861
862 2007-10-25  Stephanie  <slewis@apple.com>
863
864         build Fix
865
866         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
867
868 2007-10-25  Stephanie  <slewis@apple.com>
869
870         Reviewed by Mark Rowe, Adam Roben.
871
872         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
873
874         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
875
876 2007-10-25  Alice Liu  <alice.liu@apple.com>
877
878         Reviewed by Adam.
879
880         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
881
882         Moving destructor into platform-specific files
883         * DumpRenderTree/LayoutTestController.cpp:
884         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
885         (LayoutTestController::~LayoutTestController):
886         * DumpRenderTree/qt/jsobjects.cpp:
887         (LayoutTestController::~LayoutTestController):
888
889         LayoutTestController wasn't being destroyed
890         * DumpRenderTree/win/DumpRenderTree.cpp:
891         (runTest):
892
893         Added declspec
894         * DumpRenderTree/win/EditingDelegate.h:
895
896         Reset certain values on the webview (or related delegate) that might 
897         have changed while running a test
898         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
899         (LayoutTestController::~LayoutTestController):
900
901 2007-10-25  Adam Roben  <aroben@apple.com>
902
903         Make sunspider-compare-results work with relative paths
904
905         Reviewed by Sam.
906
907         * Scripts/sunspider-compare-results: Convert arguments to absolute
908         paths before we chdir.
909
910 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
911
912         Reviewed by Sam.
913
914         - Implemented server calls now the WebScriptDebugServer exists.
915         - Also removed no longer needed call to initialize CG.
916
917         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
918         automatically now.
919         (_tWinMain):
920         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
921         (ServerConnection::ServerConnection):
922         (ServerConnection::~ServerConnection):
923         (ServerConnection::pause):
924         (ServerConnection::resume):
925         (ServerConnection::stepInto):
926         (ServerConnection::applicationTerminating):
927         (ServerConnection::serverConnectionDidDie):
928         * Drosera/win/ServerConnection.h: Now uses the COM class.
929
930 2007-10-24  George Staikos  <staikos@kde.org>
931
932         Unbreak Qt build.
933
934         * Scripts/build-webkit:
935
936 2007-10-24  Adam Roben  <aroben@apple.com>
937
938         Remove now-unnecessary call to InitializeCoreGraphics
939
940         WebKit takes care of this now.
941
942         Reviewed by Ada.
943
944         * DumpRenderTree/win/DumpRenderTree.cpp:
945         (initialize):
946
947 2007-10-24  Adam Roben  <aroben@apple.com>
948
949         Use WebTextRenderer in DRT
950
951         Reviewed by Ada.
952
953         * DumpRenderTree/win/DumpRenderTree.cpp:
954         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
955
956 2007-10-24  Sven Herzberg  <sven@imendio.com>
957
958         Reviewed by Mark Rowe.
959
960         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
961         Bug 15614: [GTK] qmake based backends don't build on OS X
962
963         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
964         GTK backend on a Mac
965         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
966         isDarwin() to make it reusable in other places (like the workaround-
967         for-prebuilt-qmake in build-webkit)
968
969 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
970
971         Refurbish update-webkit script.
972
973         Reviewed by Adam.
974
975         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
976         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
977         multi-argument version of system() for flexibility and security.  Check for existence
978         of Internal directory using -d test instead of -x.
979
980 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
981
982         Minor clean-up of prepare-ChangeLog script.
983
984         Reviewed by Adam.
985
986         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
987         of a string.  Use multi-argument versions of open() and system() for flexibility and
988         security.
989
990 2007-10-24  Alice Liu  <alice.liu@apple.com>
991
992         Reviewed by Oliver.
993
994         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
995
996         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
997         replay the saved events when we're still processing the mousedown that starts the drag
998         * DumpRenderTree/win/EventSender.cpp:
999         (doMouseMove):
1000         * DumpRenderTree/win/UIDelegate.cpp:
1001         (UIDelegate::doDragDrop):
1002
1003 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1004
1005         Reviewed by Sam, Steve and Darin.
1006
1007         - Stubbed out the WebScriptDebugListener functionality in the Server
1008         Connection class to prepare it for receiving those callbacks.
1009         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1010         and the ServerConnection to not need to be initialized with a server
1011         name, since that is not the way we connect to the WebKit server. 
1012
1013         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1014         no exception.  Now it only loggs when there is an exception
1015         (DebuggerDocument::willExecuteStatement):
1016         (DebuggerDocument::didEnterCallFrame):
1017         (DebuggerDocument::willLeaveCallFrame):
1018         (DebuggerDocument::windowScriptObjectAvailable):
1019         (DebuggerDocument::callFunctionOnObject):
1020         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1021         to be instantiated with a server's name.
1022         (DebuggerClient::DebuggerClient):
1023         (DebuggerClient::didFinishLoadForFrame):
1024         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1025         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1026         a server name.
1027         (Drosera::init):
1028         (Drosera::initServer):
1029         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1030         instantiated with a server's name.
1031         * Drosera/win/ServerConnection.cpp: 
1032         (ServerConnection::ServerConnection): No longer needs a server name
1033         (ServerConnection::~ServerConnection): Only release the global context
1034         if there is one.
1035         (ServerConnection::serverConnectionDidDie): Stub for
1036         IWebScriptDebugListener
1037         (ServerConnection::QueryInterface): ditto
1038         (ServerConnection::AddRef): ditto
1039         (ServerConnection::Release): ditto
1040         (ServerConnection::didLoadMainResourceForDataSource): ditto
1041         (ServerConnection::didParseSource): ditto
1042         (ServerConnection::failedToParseSource): ditto
1043         (ServerConnection::didEnterCallFrame): ditto
1044         (ServerConnection::willExecuteStatement): ditto
1045         (ServerConnection::willLeaveCallFrame): ditto
1046         (ServerConnection::exceptionWasRaised): ditto
1047         * Drosera/win/ServerConnection.h: Stubbed out the
1048         IWebScriptDebugListener functions, and this class no longer needs to be
1049         instantiated with a server name.
1050
1051 2007-10-24  Lars Knoll  <lars@trolltech.com>
1052
1053         Reviewed by Simon.
1054
1055         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1056
1057         * DumpRenderTree/qt/jsobjects.h:
1058
1059 2007-10-24  Lars Knoll  <lars@trolltech.com>
1060
1061         Reviewed by Simon.
1062
1063         add another command.
1064
1065         * DumpRenderTree/qt/jsobjects.cpp:
1066         (TextInputController::doCommand):
1067
1068 2007-10-24  Lars Knoll  <lars@trolltech.com>
1069
1070         Reviewed by Simon.
1071
1072         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1073
1074         * DumpRenderTree/qt/jsobjects.cpp:
1075         (EventSender::keyDown):
1076         * DumpRenderTree/qt/jsobjects.h:
1077
1078 2007-10-24  Lars Knoll  <lars@trolltech.com>
1079
1080         Reviewed by Simon.
1081
1082         implement eventSender.keyDown().
1083
1084         * DumpRenderTree/qt/jsobjects.cpp:
1085         (EventSender::keyDown):
1086
1087 2007-10-24  Lars Knoll  <lars@trolltech.com>
1088
1089         Reviewed by Simon.
1090
1091         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1092
1093         * DumpRenderTree/qt/DumpRenderTree.cpp:
1094         (WebCore::DumpRenderTree::DumpRenderTree):
1095         (WebCore::DumpRenderTree::initJSObjects):
1096         * DumpRenderTree/qt/jsobjects.cpp:
1097         (TextInputController::doCommand):
1098
1099 2007-10-24  Lars Knoll  <lars@trolltech.com>
1100
1101         Reviewed by Simon.
1102
1103         first bit of implementation for the textinputcontroller.
1104
1105         * DumpRenderTree/qt/DumpRenderTree.cpp:
1106         (WebCore::DumpRenderTree::DumpRenderTree):
1107         * DumpRenderTree/qt/DumpRenderTree.h:
1108         * DumpRenderTree/qt/jsobjects.cpp:
1109         (TextInputController::TextInputController):
1110         (TextInputController::doCommand):
1111         * DumpRenderTree/qt/jsobjects.h:
1112
1113 2007-10-24  Lars Knoll  <lars@trolltech.com>
1114
1115         Reviewed by Simon.
1116
1117         make the man webpage believe it has focus, so the editing tests work correctly.
1118
1119         * DumpRenderTree/qt/DumpRenderTree.cpp:
1120         (WebCore::DumpRenderTree::DumpRenderTree):
1121
1122 2007-10-24  Lars Knoll  <lars@trolltech.com>
1123
1124         Reviewed by Simon.
1125
1126         implement layoutTestController.dumpEditingCallbacks() correctly.
1127
1128         * DumpRenderTree/qt/DumpRenderTree.cpp:
1129         (WebCore::DumpRenderTree::DumpRenderTree):
1130         * DumpRenderTree/qt/jsobjects.cpp:
1131         (LayoutTestController::reset):
1132         (LayoutTestController::dumpEditingCallbacks):
1133
1134 2007-10-24  Lars Knoll  <lars@trolltech.com>
1135
1136         Reviewed by Simon.
1137
1138         Implement support for testing editing.
1139
1140         * DumpRenderTree/qt/DumpRenderTree.cpp:
1141         (WebCore::DumpRenderTree::DumpRenderTree):
1142
1143 2007-10-23  Sam Weinig  <sam@webkit.org>
1144
1145         Check for null BSTR that can be passed to the UIDelegate methods
1146         from javascript null and undefined.  Fixes a failing test case on
1147         Windows (fast/dom/Window/alert-undefined.html)
1148
1149         Reviewed by Eric Seidel.
1150
1151         * DumpRenderTree/win/UIDelegate.cpp:
1152         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1153         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1154         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1155         (UIDelegate::webViewAddMessageToConsole):
1156
1157 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1158
1159         Reviewed by Darin.
1160         
1161         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1162
1163         * Scripts/build-testkjs:
1164
1165 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1166
1167         Reviewed by Darin.
1168
1169         - add wrapper that finds the right copy of testkjs
1170         
1171         * Scripts/sunspider-compare-results: Added.
1172
1173 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1174
1175         Reviewed by Sam.
1176
1177         - After talking with Steve I now see that the WebKit server must be
1178         running for DCOM to create the distributed objects, which makes sense
1179         and currently WebKit only allows one instance to be running at a time
1180         which avoids accidentally connecting to the wrong server
1181         - In light of this I have removed the code for the attach box and
1182         NotificationServer and known server names, since they are all extranious
1183         now.
1184
1185         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1186         names.
1187         (_tWinMain): Uses init instead of initUI.
1188         (droseraWndProc): No longer creats an attach dialog box.
1189         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1190         it's not manditory to call init before doing COM stuff.
1191         (Drosera::init): calls initUI and will call attach when the
1192         functionality exists. 
1193         (Drosera::initUI): Has changed very little.
1194         (Drosera::attach): Changed the signature to reflect that we no longer
1195         need the dictionary of known server names.
1196         * Drosera/win/Drosera.h: Removed notification classes and known server
1197         names.  Also renamed and moved some functions.
1198         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1199         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1200         headers to the resources folder. 
1201         * Drosera/win/resource.h: Removed the Attach box.
1202
1203 2007-10-22  Adam Roben  <aroben@apple.com>
1204
1205         Windows build fix
1206
1207         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1208
1209 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1210
1211         - Removed a leak that was fixed.
1212
1213         * Scripts/run-webkit-tests:
1214
1215 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1216
1217         Reviewed by Darin.
1218
1219         - Changed the Client so that the DebuggerDocument now own the
1220         ServerConnection.  This simplifies ownership and cleanup. 
1221
1222         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1223         ServerConnection.
1224         (DebuggerClient::initWithServerName):
1225         (DebuggerClient::didFinishLoadForFrame):
1226         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1227         ServerConnection.
1228         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1229         until after we have a server which we are attached to.
1230         (Drosera::initUI):
1231         (Drosera::attach):
1232         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1233         out previously.
1234
1235 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1236
1237         Reviewed by Nikolas.
1238
1239         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1240
1241         * Scripts/run-javascriptcore-tests:
1242
1243 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1244
1245         Reviewed by Nikolas.
1246
1247         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1248
1249         * Scripts/build-drosera:
1250         * Scripts/build-dumprendertree:
1251         * Scripts/build-testkjs:
1252         * Scripts/build-webkit:
1253         * Scripts/run-javascriptcore-tests:
1254         * Scripts/run-sunspider:
1255         * Scripts/run-webkit-tests:
1256         * Scripts/webkitdirs.pm:
1257
1258 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1259
1260         Reviewed by Mark Rowe.
1261         
1262         Fix for local database support after r26879
1263         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1264
1265         * Scripts/build-webkit:
1266
1267 2007-10-22  Holger Freyther  <zecke@selfish.org>
1268
1269         Reviewed by Simon Hausmann <hausmann@kde.org>.
1270
1271         - Do not build testkjs as an application bundle. This is
1272         needed for run-javascriptcore-tests on OSX.
1273         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1274         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1275         as we do not have -rpath on OSX.
1276
1277         * DumpRenderTree/qt/DumpRenderTree.pro:
1278         * Scripts/run-webkit-tests:
1279
1280 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1281
1282         Reviewed by aroben.
1283
1284         Fix support for Signed-off-by detection in prepare-ChangeLog
1285         --git-commit. The Signed-off-by tag does not appear in the header
1286         but usually at the end.
1287
1288         * Scripts/prepare-ChangeLog:
1289
1290 2007-10-21  Mark Rowe  <mrowe@apple.com>
1291
1292         Reviewed by Eric.
1293
1294         Fix run-javascriptcore-tests for Gtk.
1295
1296         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1297
1298 2007-10-20  Eric Seidel  <eric@webkit.org>
1299
1300         Reviewed by aroben.
1301
1302         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1303
1304 2007-10-20  Eric Seidel  <eric@webkit.org>
1305
1306         Reviewed by darin.
1307         
1308         Add improved argument handling to run-sunspider, including
1309         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1310         Also re-factor code into subroutines
1311
1312         * Scripts/build-dumprendertree: removed bogus comments
1313         * Scripts/build-testkjs: Added.
1314         * Scripts/run-javascriptcore-tests: use build-testkjs
1315         * Scripts/run-sunspider: improved argument handling, abstraction
1316         * Scripts/run-webkit-tests: improved abstraction
1317
1318 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1319
1320         Not reviewed, Windows build fix.
1321
1322         * DumpRenderTree/win/EventSender.cpp:
1323         (keyDownCallback):
1324
1325 2007-10-20  Darin Adler  <darin@apple.com>
1326
1327         Reviewed by Tim Hatcher.
1328
1329         - http://bugs.webkit.org/show_bug.cgi?id=15544
1330           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1331           not rely on Apple-specific key codes
1332
1333         * DumpRenderTree/mac/EventSendingController.mm:
1334         (-[EventSendingController keyDown:withModifiers:]):
1335         Added named key "rightArrow". Later we could have a whole table of these.
1336         Also tweaked modifiers code a little.
1337
1338         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1339
1340 2007-10-19  Darin Adler  <darin@apple.com>
1341
1342         Reviewed by Eric.
1343
1344         - http://bugs.webkit.org/show_bug.cgi?id=15566
1345           possible fix for leak seen in DumpRenderTree
1346
1347         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1348         Delete the item if it's not put on the queue, since the caller has
1349         no way of knowing that. Would be better to have the parameter type
1350         be auto_ptr to express the fact that we take ownership.
1351
1352         - unrelated change
1353
1354         * Drosera/mac/main.m: Add missing include.
1355
1356 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1357
1358         Reviewed by Adam.
1359
1360         - This change should be identical but for some reason was not working
1361         on my machine.
1362
1363         * Scripts/prepare-ChangeLog:
1364
1365 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1366
1367         Reviewed by Oliver and Tim.
1368
1369         - Made use of RetainPtr to avoid retain and release issues and moved the
1370         log function to DebuggerDocumentPlatform, which seems to be a more
1371         logical place for it to live.
1372         - Also moved knownServers from the ServerConnection to
1373         DebuggerApplication to match the Windows code and because it makes sense
1374         that a connection knows its own server but not all of them.
1375
1376         * Drosera/mac/DebuggerClient.h: Moved the log function to
1377           DebuggerDocumentPlatform.
1378         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1379           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1380           call for the server name up from the ServerConnection class.
1381         (-[DebuggerClient dealloc]):
1382         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1383           for the server name up from the ServerConnection.
1384         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1385         (DebuggerDocument::platformPause):
1386         (DebuggerDocument::platformResume):
1387         (DebuggerDocument::platformStepInto):
1388         (DebuggerDocument::platformEvaluateScript):
1389         (DebuggerDocument::getPlatformCurrentFunctionStack):
1390         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1391         (DebuggerDocument::platformValueForScopeVariableNamed):
1392         (DebuggerDocument::platformLog): Log directly from here. No need to call
1393           DebuggerClient.
1394         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1395           way I see it, a ServerConnection should only know about its connection
1396           and the group of all possible servers should be kept by the
1397           application.
1398         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1399           currentServerName, it makes sense that the connection should know that
1400           name.
1401         (-[ServerConnection currentServerName]):
1402
1403 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1404
1405         Reviewed by Adam.
1406
1407         - Integrated changes from mac drosera.  Recently I've encapsulated
1408         out the server connection object from the rest of Drosera because
1409         it is very platform dependent right now and RPC is not implemented on
1410         windows.  This functionality, of communicating with the WebKit server
1411         is the next area I will be focusing on in Windows.
1412
1413         - Other changes and cleanup were made to organize the code and add notes
1414         on which parts still need work.  Also some mac code is added and
1415         commented out, to act as pseudocode for the logic of those parts.
1416
1417         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1418           pointer.
1419         * Drosera/config.h: Added whitespace.
1420         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1421           these files got moved into Drosera.h/cpp
1422         * Drosera/win/DebuggerApplication.h: Removed.
1423         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1424           happened here to better match the logic flow of the same code on the 
1425           mac side and to use the new ServerConnection class.
1426         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1427         (DebuggerClient::initWithServerName): Initializer that will set up the
1428           class to use a ServerConnection object.  This was necessary so I could
1429           create a DebuggerClient without having to initilaize it at
1430           construction.
1431         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1432           will be the UIDelegate and FrameLoadDelegate.
1433         (DebuggerClient::AddRef): For IUnknown.
1434         (DebuggerClient::Release): For IUnknown.
1435         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1436           this still needs to set the global context of the server, but
1437           IWebFrame does not have an accessor for the global context yet. 
1438         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1439           this is a pass through for the same function in the document.
1440         (DebuggerClient::didReceiveTitle): Unimplemented part of
1441           FrameLoadDelegate this would change the title of the window.
1442         (DebuggerClient::createWebViewWithRequest): Part of the
1443           FrameLoadDelegate.  This is about new windows via Window.open() and
1444           how their delegates are set.
1445         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1446           UIDelegate.  Just a debug function for printing messages.
1447         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1448           because the Client should be the UIDelegate and FrameLoadDelegate
1449           to match the delegates on mac.
1450         (DebuggerClient::webViewLoaded): Added accessor method.
1451         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1452           forgotten to add this file before.  This is where the platform
1453           dependent versions of the Documents functions live. Most of these are
1454           unimplemented because some piece of functionality does not exist on
1455           Windows yet.
1456         (DebuggerDocument::platformPause):
1457         (DebuggerDocument::platformResume):
1458         (DebuggerDocument::platformStepInto):
1459         (DebuggerDocument::platformEvaluateScript):
1460         (DebuggerDocument::getPlatformCurrentFunctionStack):
1461         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1462         (DebuggerDocument::platformValueForScopeVariableNamed):
1463         (DebuggerDocument::platformLog):
1464         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1465           responsibilities becaue they belong in the Client. Also I laid the
1466           groundwork for attaching Drosera to a WebKit process
1467         (attachWndProc): Now if a server is selected the Client becomes it's
1468           delegate.
1469         (Drosera::Drosera): Added the construction of the Client and dictionary
1470           of server names. 
1471         (Drosera::initUI): This is no longer the delegates, the Client is.
1472         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1473           state. 
1474         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1475           notification registration when it's possible to implement.
1476         (Drosera::serverLoaded): Ditto
1477         (Drosera::serverUnloaded): Ditto
1478         (Drosera::attach): Attach Drosera to the WebKit server.
1479         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1480         (Drosera::getInst): 
1481         (Drosera::setInst):
1482         (Drosera::knownServers):
1483         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1484           and added the ServerConnection.
1485         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1486         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1487           Most of the functions are completely unimlemented because they cannot
1488           connect with the WebKit server, because one does not exist on Windows
1489           yet.
1490         (ServerConnection::initWithServerName): 
1491         (ServerConnection::~ServerConnection):
1492         (ServerConnection::setGlobalContext):
1493         (ServerConnection::pause):
1494         (ServerConnection::resume):
1495         (ServerConnection::stepInto):
1496         (ServerConnection::switchToServerNamed):
1497         (ServerConnection::applicationTerminating):
1498         (ServerConnection::serverConnectionDidDie):
1499         (ServerConnection::currentFrame):
1500         * Drosera/win/ServerConnection.h: Added. Ditto.
1501         (ServerConnection::ServerConnection):
1502
1503 2007-10-19  Alice Liu  <alice.liu@apple.com>
1504
1505         Reviewed by Darin.
1506
1507         Fix for these broken layout tests on Windows:
1508         
1509         fast/forms/focus-selection-input.html
1510         fast/forms/focus-selection-textarea.html
1511         fast/forms/select-accesskey.html
1512         
1513         * DumpRenderTree/win/EventSender.cpp:
1514         (keyDownCallback):
1515         correct the VK code for alt key.
1516         
1517 2007-10-19  Eric Seidel  <eric@webkit.org>
1518
1519         Reviewed by Mark Rowe.
1520         
1521         Make the GtkLauncher code slightly more readable.
1522
1523         * GtkLauncher/main.cpp:
1524         (setupMainMenu): Added.
1525         (setupMainWindowUI): Added.
1526         (main):
1527
1528 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1529
1530         Rubber stamped by Adam.
1531         
1532         - don't delay-load WebKit in DumpRenderTree.
1533
1534         * DumpRenderTree/win/DumpRenderTree.vcproj:
1535
1536 2007-10-18  Dan Bernstein  <mitz@apple.com>
1537
1538         Reviewed by Adam Roben.
1539
1540         - fix <rdar://problem/5313523>
1541         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1542
1543         * DumpRenderTree/mac/DumpRenderTree.mm:
1544         (dump): Changed to use _responseMIMEType.
1545
1546 2007-10-17  Adam Roben  <aroben@apple.com>
1547
1548         Make it possible to have Windows-specific tests and results
1549
1550         When searching for tests to run and the Skipped file, we will only
1551         look in platform/win and the cross-platform directory. When looking
1552         for expected results, we will look in platform/win, then
1553         platform/mac-leopard, then platform/mac, then finally the
1554         cross-platform directory.
1555
1556         Reviewed by Sam.
1557
1558         * Scripts/run-webkit-tests:
1559         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1560         searching in the cross-platform directory.
1561         (sub buildPlatformHierarchy): Removed some unneeded calls to
1562         dirname/basename.
1563
1564 2007-10-17  Adam Roben  <aroben@apple.com>
1565
1566         Add back the call to register WebKit that we had before WebKitInitializer existed
1567
1568         This is needed to ensure that the right WebKit is used when
1569         instantiating COM objects.
1570
1571         Reviewed by Oliver.
1572
1573         * DumpRenderTree/win/debug_internal.vsprops: Define
1574         DEBUG_WEBKIT_HAS_SUFFIX.
1575         * DumpRenderTree/win/DumpRenderTree.cpp:
1576         (initialize):
1577
1578 2007-10-17  Adam Roben  <aroben@apple.com>
1579
1580         Import File::Basename in webkitdirs since we use it
1581
1582         * Scripts/webkitdirs.pm:
1583
1584 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1585
1586         - Updated the tiger leaks list to make the internal bots green.
1587
1588         * Scripts/run-webkit-tests:
1589
1590 2007-10-17  Adam Roben  <aroben@apple.com>
1591
1592         Build fix for VC++ Express
1593
1594         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1595         and ole32.lib.
1596
1597 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1598
1599         Reviewed by Sam.
1600
1601         - Minor mac improvements based on observations I made while implementing the
1602         Windows code.
1603
1604         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1605         then hand it to the Client who will retain it, it should just be the client who
1606         creates and owns the server.
1607         (-[DebuggerApplication attach:]):
1608         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1609         * Drosera/mac/DebuggerClient.mm: Creates the server.
1610         (-[DebuggerClient initWithServerName:]):
1611         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1612         can instead forward declare what it needs.
1613
1614 2007-10-16  Darin Adler  <darin@apple.com>
1615
1616         Reviewed by Geoff Garen.
1617
1618         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1619         want to turn failing tests into platform-specific test results. Also did a
1620         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1621         would take the type of results into account only some of the time.
1622
1623 2007-10-16  Adam Roben  <aroben@apple.com>
1624
1625         Add a new nightly launcher script for Windows
1626
1627         This new script is for versions of Safari that don't delay-load
1628         WebKit. I had to make FindSafari be able to print out the nightly
1629         launcher script on stdout because Windows shell scripts can't capture
1630         the output from a command into an environment variable.
1631
1632         Reviewed by Steve.
1633
1634         * FindSafari/FindSafari.cpp:
1635         (_tmain): Added /printSafariLauncher option.
1636         * Scripts/run-webkit-nightly.cmd: Added.
1637
1638 2007-10-16  Adam Roben  <aroben@apple.com>
1639
1640         Replace WebKitInitializer with FindSafari
1641
1642         We now rely on setting the PATH environment variable to tell Windows
1643         where to find WebKit and its dependencies (similar to
1644         DYLD_FRAMEWORK_PATH on Mac).
1645
1646         This change also make DumpRenderTree no longer delay-load WebKit.
1647
1648         Reviewed by Sam.
1649
1650         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1651         FindSafari.
1652         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1653         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1654         WebKitInitializer, don't delay-load WebKit.
1655         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1656         * Scripts/run-webkit-tests: Ditto.
1657         * Scripts/webkitdirs.pm:
1658         (sub setPathForRunningWebKitApp): Added.
1659         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1660         * WebKitInitializer/WebKitInitializer.h: Removed.
1661         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1662         * WebKitInitializer/debug.vsprops: Removed.
1663         * WebKitInitializer/debug_internal.vsprops: Removed.
1664         * WebKitInitializer/release.vsprops: Removed.
1665
1666 2007-10-16  Adam Roben  <aroben@apple.com>
1667
1668         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1669
1670         http://bugs.webkit.org/show_bug.cgi?id=15532
1671
1672         FindSafari simply prints the location of an installed Safari.exe on
1673         stdout.
1674
1675         Reviewed by Darin.
1676
1677         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1678         (getStringValue):
1679         (getWebViewCLSID):
1680         (getInstalledWebKitDirectory):
1681         (_tmain):
1682         * FindSafari/FindSafari.vcproj: Added.
1683         * Scripts/webkitdirs.pm:
1684         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1685
1686 2007-10-16  Adam Roben  <aroben@apple.com>
1687
1688         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1689
1690         Reviewed by Kevin McCullough.
1691
1692         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1693         when referring to WebKit.dll.
1694         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1695         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1696         * DumpRenderTree/win/release.vsprops: Ditto.
1697         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1698         never have a _debug suffix on WebKit.dll.
1699         * WebKitInitializer/WebKitInitializer.cpp:
1700         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1701         specified.
1702         * WebKitInitializer/debug_internal.vsprops: Added
1703         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1704
1705 2007-10-16  Darin Adler  <darin@apple.com>
1706
1707         Reviewed by Adele.
1708
1709         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1710         Remove now-unneeded control/alt key hack; the tests have been updated.
1711
1712 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1713
1714         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1715         one of the leaks was fixed between that revision and the bot's previous version of
1716         leopard.
1717
1718         * Scripts/run-webkit-tests:
1719
1720 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1721
1722         Reviewed by Tim.
1723
1724         - I encapsulated out the server connecton functionality because it is a specific part
1725         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1726         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1727         Windows.  So the majority of this patch is moving preexisting functionality.
1728
1729         - Also I removed the prefix header and changed to use config.h because it is more
1730         standard on how we use config.h in windows and it didn't make much sense to keep
1731         the prefix header and the config.h
1732
1733         * Drosera/DebuggerDocument.cpp:
1734         (DebuggerDocument::DebuggerDocument):
1735         * Drosera/DebuggerDocument.h:
1736         * Drosera/config.h:
1737         * Drosera/mac/DebuggerApplication.mm:
1738         (-[DebuggerApplication attach:]):
1739         * Drosera/mac/DebuggerClient.h:
1740         * Drosera/mac/DebuggerClient.mm:
1741         (-[DebuggerClient initWithServerConnection:]):
1742         (-[DebuggerClient dealloc]):
1743         (-[DebuggerClient windowDidLoad]):
1744         (-[DebuggerClient windowWillClose:]):
1745         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1746         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1747         * Drosera/mac/DebuggerDocumentPlatform.mm:
1748         (DebuggerDocument::platformPause):
1749         (DebuggerDocument::platformResume):
1750         (DebuggerDocument::platformStepInto):
1751         (DebuggerDocument::platformEvaluateScript):
1752         (DebuggerDocument::getPlatformCurrentFunctionStack):
1753         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1754         (DebuggerDocument::platformValueForScopeVariableNamed):
1755         (DebuggerDocument::platformLog):
1756         * Drosera/mac/Drosera.pch: Removed.
1757         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1758         * Drosera/mac/ServerConnection.h: Added.
1759         * Drosera/mac/ServerConnection.mm: Added.
1760         (-[ServerConnection initWithServerName:]):
1761         (-[ServerConnection dealloc]):
1762         (-[ServerConnection setGlobalContext:]):
1763         (-[ServerConnection pause]):
1764         (-[ServerConnection resume]):
1765         (-[ServerConnection stepInto]):
1766         (-[ServerConnection switchToServerNamed:]):
1767         (-[ServerConnection applicationTerminating:]):
1768         (-[ServerConnection serverConnectionDidDie:]):
1769         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1770         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1771         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1772         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1773         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1774         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1775         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1776         (-[ServerConnection currentFrame]):
1777         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1778         (-[ServerConnection knownServers]):
1779
1780 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1781
1782         Reviewed by Eric.
1783
1784         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1785           Script to automatically search nightly builds for regressions (bisect-builds)
1786
1787         * Scripts/bisect-builds: Added.
1788
1789 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1790
1791         Reviewed by Darin.
1792
1793         - New JavaScript benchmark
1794         http://bugs.webkit.org/show_bug.cgi?id=15515
1795
1796         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1797         current development or release build of JavaScriptCore.
1798
1799 2007-10-15  Mark Rowe  <mrowe@apple.com>
1800
1801         Reviewed by Sam.
1802
1803         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1804
1805         * Scripts/webkitdirs.pm:
1806         - Change checkArgv to remove the options from @ARGV to prevent
1807         them from interfering with further option processing.
1808         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1809         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1810         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1811         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1812
1813 2007-10-15  Darin Adler  <darin@apple.com>
1814
1815         Reviewed by Sam.
1816
1817         - added logging of window.prompt and window.confirm
1818
1819         * DumpRenderTree/mac/UIDelegate.mm:
1820         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1821         Implement the recommended delegate rather than the deprecated one.
1822         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1823         Added.
1824         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1825         Added.
1826
1827         * DumpRenderTree/win/UIDelegate.h:
1828         * DumpRenderTree/win/UIDelegate.cpp:
1829         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1830         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1831         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1832         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1833
1834 2007-10-15  Alice Liu  <alice.liu@apple.com>
1835
1836         Reviewed by Sam Weinig.
1837
1838         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1839
1840         * DumpRenderTree/win/DumpRenderTree.cpp:
1841         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1842         (main): allocate the global policy delegate for DRT's custom use
1843         * DumpRenderTree/win/DumpRenderTree.vcproj:
1844         Adding files to project
1845         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1846         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1847         (LayoutTestController::setCustomPolicyDelegate):
1848         set the webview's policy delegate to DRT's custom one if the test requests it.
1849         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1850         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1851         (PolicyDelegate::PolicyDelegate):
1852         (PolicyDelegate::QueryInterface):
1853         (PolicyDelegate::AddRef):
1854         (PolicyDelegate::Release):
1855         (PolicyDelegate::decidePolicyForNavigationAction):
1856         * DumpRenderTree/win/PolicyDelegate.h: Added.
1857         (PolicyDelegate::decidePolicyForNewWindowAction):
1858         (PolicyDelegate::decidePolicyForMIMEType):
1859         (PolicyDelegate::unableToImplementPolicyWithError):
1860
1861 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1862
1863         Reviewed by Mark.
1864
1865         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1866         when querying for QMAKE_MKSPECS.
1867
1868 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1869
1870         Reviewed by Adam Roben.
1871         
1872         Fix run-webkit-tests is too greedy calculating platform hierarchy
1873         http://bugs.webkit.org/show_bug.cgi?id=15465
1874         
1875         Fix run-webkit-tests being too greedy in trying to split the platform name up
1876         causing it to try and find tests in every directory above the first "-" in the
1877         path to the LayoutTests
1878
1879         * Scripts/run-webkit-tests:
1880
1881 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1882
1883         Reviewed by Darin.
1884
1885         http://bugs.webkit.org/show_bug.cgi?id=15006
1886         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1887         to reduce code duplication.
1888
1889         * Scripts/build-webkit:
1890         * Scripts/webkitdirs.pm:
1891         buildQMakeProject() renamed to buildQMakeQtProject().
1892         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1893         unused $colorize has been removed.
1894
1895 === Start merge of feature-branch 2007-10-12 ===
1896
1897 2007-10-08  Eric Seidel  <eric@webkit.org>
1898
1899         Reviewed by Mark Rowe.
1900
1901         * Scripts/build-webkit: add --help, remove unused --color
1902
1903 2007-10-07  Eric Seidel  <eric@webkit.org>
1904
1905         Reviewed by darin.
1906
1907         * Drosera/mac/DebuggerDocumentPlatform.mm:
1908         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1909
1910 2007-10-03  Rob Buis  <buis@kde.org>
1911
1912         Reviewed by Olliej.
1913
1914         Adapt to changed location of Ahem font.
1915
1916         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1917
1918 2007-10-02  Eric Seidel  <eric@webkit.org>
1919
1920         Reviewed by Adam Roben.
1921         
1922         Make pixel tests more useful!
1923         Finally fix the image diff 0.00% mystery problem
1924         Highlight any image differences in the image diff.
1925         Add a link from image diffs back to original test file.
1926
1927         * DumpRenderTree/mac/ImageDiff.m:
1928         (compareImages): highlight any differences
1929         (computePercentageDifferent): round to two decimal places
1930         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1931
1932 2007-10-02  Eric Seidel  <eric@webkit.org>
1933
1934         Reviewed by Alexey Proskuryakov.
1935
1936         * Scripts/run-webkit-tests: print the % image difference on main results page
1937
1938 2007-10-02  Mark Rowe  <mrowe@apple.com>
1939
1940         Reviewed by Oliver.
1941
1942         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1943
1944         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1945         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1946
1947 2007-10-01  Mark Rowe  <mrowe@apple.com>
1948
1949         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1950
1951 2007-09-25  Eric Seidel  <eric@webkit.org>
1952
1953         Reviewed by Mark Rowe.
1954         
1955         DerivedSources.make was finding "ENABLE_SVG" in the string
1956         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1957         quite correctly.
1958
1959         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1960
1961 2007-09-25  Mark Rowe  <mrowe@apple.com>
1962
1963         Rubber-stamped by Eric.
1964
1965         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1966         This makes it possible to automate nightly builds for the feature-branch.
1967
1968 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1969
1970         Rubber stamped by Mark.
1971
1972         Enable svg experimental features as default here in feature-branch.
1973
1974         * Scripts/build-webkit:
1975
1976 2007-06-29  Antti Koivisto  <antti@apple.com>
1977
1978         Reviewed by Weinig.
1979         
1980         Add VIDEO flag for timed media features
1981
1982         * Scripts/build-webkit
1983         
1984 === End merge of feature-branch 2007-10-12 ===
1985
1986 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1987
1988         Reviewed by Darin.
1989
1990         - Updated rational for the leaks list to be more clear.
1991
1992         * Scripts/run-webkit-tests:
1993
1994 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1995
1996         Rubber Stamp by Sam.
1997
1998         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1999         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2000
2001         * Scripts/run-webkit-tests:
2002
2003 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2004
2005         Reviewed by Lars.
2006
2007         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2008         includes are needed for INT_MAX, std::auto_ptr and the like.
2009
2010         * DumpRenderTree/qt/main.cpp:
2011
2012 2007-10-09  Lars Knoll  <lars@trolltech.com>
2013
2014         Reviewed by Simon.
2015
2016         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2017
2018         * DumpRenderTree/qt/jsobjects.cpp:
2019         (LayoutTestController::encodeHostName):
2020         (LayoutTestController::decodeHostName):
2021         * DumpRenderTree/qt/jsobjects.h:
2022
2023 2007-10-09  Lars Knoll  <lars@trolltech.com>
2024
2025         Reviewed by Simon.
2026
2027         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2028
2029         * DumpRenderTree/qt/DumpRenderTree.cpp:
2030         (WebCore::WebPage::createFrame):
2031         (WebCore::DumpRenderTree::DumpRenderTree):
2032         (WebCore::DumpRenderTree::titleChanged):
2033         * DumpRenderTree/qt/DumpRenderTree.h:
2034         * DumpRenderTree/qt/jsobjects.cpp:
2035         (LayoutTestController::reset):
2036         * DumpRenderTree/qt/jsobjects.h:
2037
2038 2007-10-09  Lars Knoll  <lars@trolltech.com>
2039
2040         Reviewed by Simon.
2041
2042         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2043
2044         * DumpRenderTree/qt/DumpRenderTree.h:
2045         * DumpRenderTree/qt/jsobjects.cpp:
2046         (LayoutTestController::clearBackForwardList):
2047         * DumpRenderTree/qt/jsobjects.h:
2048
2049 2007-10-09  Lars Knoll  <lars@trolltech.com>
2050
2051         Reviewed by Simon.
2052
2053         make --git-reviewer work again.
2054
2055         * Scripts/prepare-ChangeLog:
2056
2057 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2058
2059         Rubber stamped by Eric.
2060
2061         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2062         show the current link inside the statusbar.
2063         This shows how to make use of this signal and allows to easily test
2064         http://bugs.webkit.org/show_bug.cgi?id=15299.
2065
2066         * GtkLauncher/main.cpp:
2067         (hoveringOverLink):
2068         (main):
2069
2070 2007-10-05  Lars Knoll  <lars@trolltech.com>
2071
2072         add proper error messages to the FrameLoaderClient.
2073         Implement ChromeClientQt::closeWindowSoon and
2074         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2075         Some fixes in DRT to make it work correctly with multiple windows.
2076
2077         Reviewed by Maciej.
2078
2079         * DumpRenderTree/qt/DumpRenderTree.cpp:
2080         (WebCore::DumpRenderTree::DumpRenderTree):
2081         (WebCore::DumpRenderTree::createWindow):
2082         (WebCore::DumpRenderTree::windowCount):
2083         * DumpRenderTree/qt/DumpRenderTree.h:
2084         * DumpRenderTree/qt/jsobjects.cpp:
2085         (LayoutTestController::maybeDump):
2086         (LayoutTestController::windowCount):
2087         * DumpRenderTree/qt/jsobjects.h:
2088
2089 2007-10-05  Lars Knoll  <lars@trolltech.com>
2090
2091         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2092         Add support for layoutTextController.setCanOpenWindows() to DRT
2093         fixing another 2 test cases in fast/dom/Window.
2094
2095         Reviewed by Maciej.
2096
2097         * DumpRenderTree/qt/DumpRenderTree.cpp:
2098         (WebCore::WebPage::WebPage):
2099         (WebCore::WebPage::createWindow):
2100         (WebCore::DumpRenderTree::resetJSObjects):
2101         (WebCore::DumpRenderTree::createWindow):
2102         * DumpRenderTree/qt/DumpRenderTree.h:
2103         * DumpRenderTree/qt/DumpRenderTree.pro:
2104         * DumpRenderTree/qt/jsobjects.cpp:
2105         (LayoutTestController::LayoutTestController):
2106         (LayoutTestController::reset):
2107         * DumpRenderTree/qt/jsobjects.h:
2108         * DumpRenderTree/qt/main.cpp:
2109         * DumpRenderTree/qt/testplugin.cpp: Added.
2110         * DumpRenderTree/qt/testplugin.h: Added.
2111
2112 2007-10-04  Sam Weinig  <sam@webkit.org>
2113
2114         Rubber stamped by Adam.
2115
2116         Remove empty directories.
2117
2118         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2119         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2120
2121 2007-10-03  Darin Adler  <darin@apple.com>
2122
2123         Reviewed by Adam.
2124
2125         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2126         we find the internal libraries in the libraries directory. This
2127         is helpful for Safari team engineers at Apple.
2128
2129 2007-10-03  Adam Roben  <aroben@apple.com>
2130
2131         Update the location of AHEM___.TTF after r25968
2132
2133         Reviewed by Sam.
2134
2135         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2136
2137 2007-10-03  Alp Toker  <alp@atoker.com>
2138
2139         Reviewed by Adam.
2140
2141         http://bugs.webkit.org/show_bug.cgi?id=14726
2142         [gtk] API design. Mapping the WebView delegates to signals.
2143
2144         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2145
2146         * GtkLauncher/main.cpp:
2147         (goToURLBarText):
2148         (titleChanged):
2149         (progressChanged):
2150         (menuMainBackCallback):
2151         (menuMainForwardCallback):
2152         (main):
2153
2154 2007-10-03  Lars Knoll  <lars@trolltech.com>
2155
2156         Reviewed by Rob.
2157
2158         This fixes --strict mode in run-webkit-tests again after
2159         the platform dependent test results have been moved.
2160
2161         * Scripts/run-webkit-tests:
2162
2163 2007-10-03  Lars Knoll  <lars@trolltech.com>
2164
2165         Reviewed by bdash.
2166
2167         remove the hack in run-webkit-tests that forced text only test
2168         to be taken from the platform independent dir. It was only left
2169         there from early days.
2170         
2171         Remove platform dependent results for tests that are text only nowadays,
2172         and add one platform dependent result for a text only test that requires it.
2173
2174         * Scripts/run-webkit-tests:
2175
2176 2007-10-03  Lars Knoll  <lars@trolltech.com>
2177
2178         Reviewed by olliej.
2179
2180         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2181
2182         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2183         (WebCore::WebFrame::WebFrame):
2184         (WebCore::WebPage::WebPage):
2185         (WebCore::WebPage::createFrame):
2186         (WebCore::WebPage::javaScriptAlert):
2187         (WebCore::WebPage::javaScriptConsoleMessage):
2188         (WebCore::DumpRenderTree::DumpRenderTree):
2189         (WebCore::DumpRenderTree::~DumpRenderTree):
2190         (WebCore::DumpRenderTree::open):
2191         (WebCore::DumpRenderTree::readStdin):
2192         (WebCore::DumpRenderTree::resetJSObjects):
2193         (WebCore::DumpRenderTree::initJSObjects):
2194         (WebCore::DumpRenderTree::dumpFramesAsText):
2195         (WebCore::DumpRenderTree::dump):
2196         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2197         (WebCore::DumpRenderTree::layoutTestController):
2198         (WebCore::DumpRenderTree::eventSender):
2199         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2200         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2201         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2202         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2203         (HackWebFrame::mousePressEvent):
2204         (HackWebFrame::mouseReleaseEvent):
2205         (HackWebFrame::mouseMoveEvent):
2206         (HackWebFrame::HackWebFrame):
2207         (HackWebFrame::~HackWebFrame):
2208         (LayoutTestController::LayoutTestController):
2209         (LayoutTestController::reset):
2210         (LayoutTestController::maybeDump):
2211         (LayoutTestController::waitUntilDone):
2212         (LayoutTestController::notifyDone):
2213         (LayoutTestController::dumpEditingCallbacks):
2214         (LayoutTestController::queueReload):
2215         (LayoutTestController::provisionalLoad):
2216         (LayoutTestController::timerEvent):
2217         (EventSender::EventSender):
2218         (EventSender::mouseDown):
2219         (EventSender::mouseUp):
2220         (EventSender::mouseMoveTo):
2221         (EventSender::leapForward):
2222         (EventSender::keyDown):
2223         (EventSender::frameUnderMouse):
2224         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2225         (LayoutTestController::isLoading):
2226         (LayoutTestController::setLoading):
2227         (LayoutTestController::shouldDumpAsText):
2228         (LayoutTestController::shouldDumpChildrenAsText):
2229         (LayoutTestController::shouldWaitUntilDone):
2230         (LayoutTestController::dumpAsText):
2231         (LayoutTestController::dumpChildFramesAsText):
2232         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2233         (messageHandler):
2234         (crashHandler):
2235         (main):
2236         * Scripts/run-webkit-tests:
2237
2238 2007-10-03  Mark Rowe  <mrowe@apple.com>
2239
2240         Reviewed by Alp Toker.
2241
2242         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2243         should take precedence over QTDIR when determining which port we are working with.
2244
2245         * Scripts/webkitdirs.pm: 
2246
2247 2007-10-02  Adam Roben  <aroben@apple.com>
2248
2249         Add keychain to the list of default packages to install
2250
2251         Rubberstamped by Sam.
2252
2253         * CygwinDownloader/cygwin-downloader.py:
2254         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2255
2256 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2257
2258         Reviewed by Adam.
2259
2260         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2261         Also makes WebCore regression test case logic work when using git.
2262
2263         * Scripts/prepare-ChangeLog:
2264         (reviewerAndDescriptionForGitCommit): Added.
2265
2266 2007-10-02  Lars Knoll  <lars@trolltech.com>
2267
2268         Reviewed by bdash.
2269
2270         Add API to retrieve the frame name from QWebFrame.
2271         Implement support for DRT::dumpChildrenAsText.
2272
2273         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2274         (WebCore::DumpRenderTree::dumpFramesAsText):
2275         (WebCore::DumpRenderTree::dump):
2276         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2277         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2278         (LayoutTestController::LayoutTestController):
2279         (LayoutTestController::reset):
2280         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2281
2282 2007-10-02  Lars Knoll  <lars@trolltech.com>
2283
2284         Reviewed by bdash.
2285
2286         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2287
2288         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2289         (WebCore::DumpRenderTree::readStdin):
2290
2291 2007-10-02  Mark Rowe  <mrowe@apple.com>
2292
2293         Reviewed by Oliver.
2294
2295         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2296
2297         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2298         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2299
2300 2007-10-02  Mark Rowe  <mrowe@apple.com>
2301
2302         Rubber-stamped by Maciej.
2303
2304         Configuration changes from build.webkit.org.  The major change is refactoring to work
2305         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2306         last few weeks.
2307
2308         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2309         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2310         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2311         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2312         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2313         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2314         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2315         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2316
2317 2007-10-02  Lars Knoll  <lars@trolltech.com>
2318
2319         Reviewed by Maciej.
2320
2321         Add support for eventSender.mouseMove to DRT.
2322         Fixes fast/css/hover-affects-child.html
2323
2324         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2325         (EventSender::mouseMoveTo):
2326
2327 2007-10-01  Mark Rowe  <mrowe@apple.com>
2328
2329         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2330
2331 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2332
2333         Reviewed by Hyatt.
2334
2335         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2336
2337         * Scripts/svn-apply:
2338         (gitdiff2svndiff): Ignore lines beginning with "new file".
2339         * Scripts/svn-unapply:
2340         (gitdiff2svndiff): Ditto.
2341
2342 2007-09-30  George Staikos  <staikos@kde.org>
2343
2344         Qt build fix (Mac OS X specific)
2345
2346         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2347
2348 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2349
2350         Reviewed by Mark.
2351
2352         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2353         Remove Bakefiles from svn.
2354
2355         * GtkLauncher/Bakefiles.bkgen: Removed.
2356         * GtkLauncher/ENV: Removed.
2357         * GtkLauncher/gdklauncher.bkl: Removed.
2358         * GtkLauncher/mk: Removed.
2359         * Scripts/regenerate-makefiles: Removed.
2360
2361 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2362
2363         Reviewed by John.
2364
2365         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2366
2367         * Scripts/run-webkit-tests:
2368
2369 2007-09-26  Adam Roben  <aroben@apple.com>
2370
2371         Make not finding an installed WebKit non-fatal
2372
2373         What really matters is that we are able to load WebKit and its
2374         dependencies, not whether we think we've found an installed WebKit.
2375
2376         Reviewed by Sam.
2377
2378         * WebKitInitializer/WebKitInitializer.cpp:
2379         (getWebViewCLSID): Use new LOG_WARNING macro.
2380         (getInstalledWebKitDirectory): Ditto.
2381         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2382         and use new macros.
2383         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2384
2385 2007-09-26  Adam Roben  <aroben@apple.com>
2386
2387         Committed this file before saving it
2388
2389         * WebKitInitializer/debug_internal.vsprops:
2390
2391 2007-09-26  Adam Roben  <aroben@apple.com>
2392
2393         Load WebKit and its dependencies manually so they come from DllDirectory
2394
2395         I had to change WebKitInitializer to use malloc/free instead of
2396         new/delete to avoid pulling in WebKit (and its dependencies) early
2397         through use of fastMalloc.
2398
2399         Reviewed by Oliver.
2400
2401         * WebKitInitializer/WebKitInitializer.cpp:
2402         (getStringValue): Changed to use malloc/free.
2403         (getInstalledWebKitDirectory): Ditto.
2404         (initializeWebKit): Call SetDllDirectory first, then load all of
2405         WebKit's dependencies manually, finally followed by WebKit itself.
2406         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2407         configuration to match our other projects.
2408         * WebKitInitializer/debug_internal.vsprops: Added.
2409
2410 2007-09-25  Adam Roben  <aroben@apple.com>
2411
2412         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2413
2414         Rubberstamped by Sam.
2415
2416         * WebKitInitializer/WebKitInitializer.vcproj:
2417
2418 2007-09-25  Adam Roben  <aroben@apple.com>
2419
2420         Make DumpRenderTree delay-load its dependencies
2421
2422         This lets WebKitInitializer re-route the dependencies to be loaded out
2423         of the Safari installation directory.
2424
2425         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2426         same thing), since we can't import the kCFAllocatorDefault symbol when
2427         delay-loading CoreFoundation.dll.
2428
2429         Rubberstamped by Sam.
2430
2431         * DumpRenderTree/win/DumpRenderTree.cpp:
2432         (runTest):
2433         (javaScriptThreads):
2434         * DumpRenderTree/win/DumpRenderTree.vcproj:
2435         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2436         (LayoutTestController::setWaitToDump):
2437
2438 2007-09-25  Adam Roben  <aroben@apple.com>
2439
2440         Pull ole32.lib into WebKitInitializer
2441
2442         Rubberstamped by Sam.
2443
2444         * WebKitInitializer/WebKitInitializer.vcproj:
2445
2446 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2447
2448         Reviewed by Adam.
2449
2450         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2451           LGPL'ed files contain incorrect FSF address
2452
2453         * Drosera/config.h:
2454
2455 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2456
2457         Reviewed by Adam.
2458
2459         Make svn-apply and svn-unapply work with git-diff formatted patches.
2460
2461         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2462         (gitdiff2svndiff): Added.
2463         * Scripts/svn-unapply: Ditto.
2464         (gitdiff2svndiff): Added.
2465
2466 2007-09-25  Adam Roben  <aroben@apple.com>
2467
2468         Pull advapi32.lib into WebKitInitializer
2469
2470         This is needed to get the registry functions we use.
2471
2472         Rubberstamped by Sam.
2473
2474         * WebKitInitializer/WebKitInitializer.vcproj:
2475
2476 2007-09-25  Adam Roben  <aroben@apple.com>
2477
2478         Add python and rsync to cygwin-downloader
2479
2480         Our build slaves need this, and it can't hurt for everyone else to
2481         have it, too.
2482
2483         Reviewed by Sam.
2484
2485         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2486         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2487
2488 2007-09-25  Adam Roben  <aroben@apple.com>
2489
2490         Add WebKitInitializer and use it in DumpRenderTree
2491
2492         WebKitInitializer is a static library that has one function,
2493         initializeWebKit(). This registers WebKit and sets up the DLL search
2494         path so that WebKit's dependencies that are installed with Safari can
2495         be found.
2496
2497         Reviewed by Sam.
2498
2499         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2500         DumpRenderTree depend on it.
2501         * DumpRenderTree/win/DumpRenderTree.cpp:
2502         (initialize): Call initializeWebKit.
2503         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2504         WebKitInitializer.lib.
2505         * WebKitInitializer/WebKitInitializer.cpp: Added.
2506         (getStringValue):
2507         (getWebViewCLSID):
2508         (getInstalledWebKitDirectory):
2509         (initializeWebKit):
2510         * WebKitInitializer/WebKitInitializer.h: Added.
2511         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2512         * WebKitInitializer/debug.vsprops: Added.
2513         * WebKitInitializer/release.vsprops: Added.
2514
2515 2007-09-25  Adam Roben  <aroben@apple.com>
2516
2517         Make run-webkit-tests respect set-webkit-configuration
2518
2519         Reviewed by Sam.
2520
2521         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2522         set-webkit-configuration was last set to.
2523
2524 2007-09-25  Mark Rowe  <mrowe@apple.com>
2525
2526         Rubber-stamped by Eric.
2527
2528         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2529         This makes it possible to automate nightly builds for the feature-branch.
2530
2531 2007-09-25  Adam Roben  <aroben@apple.com>
2532
2533         A couple of fixes/enhancements to update-webkit-*-libs
2534
2535         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2536         to tell update-webkit-support-libraries where it should find the
2537         WebKitSupportLibrary.zip file you downloaded.
2538
2539         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2540         Windows-style path.
2541
2542         Reviewed by Sam.
2543
2544         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2545         to $auxiliaryLibsURL and removed an irrelevant comment.
2546         * Scripts/update-webkit-support-libs:
2547
2548 2007-09-25  Adam Treat  <treat@kde.org>
2549
2550         Reviewed by Simon and Lars.
2551
2552         Refactors and cleans up Qt DRT member variable names, member variable
2553         initialization, style fixes and general code cleanup.
2554
2555         Adds queueReload slot to LayoutTestController that some tests require.
2556
2557         Subclasses QWebFrame to make sure that all frames have an associated
2558         LayoutTestController JS window object.
2559
2560         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2561         aren't dumped twice.
2562
2563         EOF fixes.
2564
2565         Together, this patch fixes some 20+ layout tests in QtWebKit.
2566
2567         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2568         (WebCore::WebFrame::WebFrame):
2569         (WebCore::WebPage::WebPage):
2570         (WebCore::WebPage::createFrame):
2571         (WebCore::DumpRenderTree::DumpRenderTree):
2572         (WebCore::DumpRenderTree::open):
2573         (WebCore::DumpRenderTree::readStdin):
2574         (WebCore::DumpRenderTree::initJSObjects):
2575         (WebCore::DumpRenderTree::dump):
2576         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2577         (WebCore::DumpRenderTree::layoutTestController):
2578         (WebCore::DumpRenderTree::eventSender):
2579         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2580         (LayoutTestController::LayoutTestController):
2581         (LayoutTestController::reset):
2582         (LayoutTestController::maybeDump):
2583         (LayoutTestController::waitUntilDone):
2584         (LayoutTestController::notifyDone):
2585         (LayoutTestController::queueReload):
2586         (LayoutTestController::provisionalLoad):
2587         (EventSender::EventSender):
2588         (EventSender::mouseDown):
2589         (EventSender::mouseUp):
2590         (EventSender::mouseMoveTo):
2591         (EventSender::frameUnderMouse):
2592         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2593         (LayoutTestController::isLoading):
2594         (LayoutTestController::setLoading):
2595         (LayoutTestController::dumpAsText):
2596         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2597         (main):
2598
2599 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2600
2601
2602         - Reverted an accidentally checked in file.
2603
2604         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2605
2606 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2607         Reviewed by Sam.
2608
2609         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2610
2611         * DumpRenderTree/win/DumpRenderTree.vcproj:
2612         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2613
2614 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2615
2616         Rubber stamped by Adam.
2617
2618         * GdkLauncher: Removed.
2619         * GdkLauncher/Bakefiles.bkgen: Removed.
2620         * GdkLauncher/ENV: Removed.
2621         * GdkLauncher/GdkLauncher.pro: Removed.
2622         * GdkLauncher/gdklauncher.bkl: Removed.
2623         * GdkLauncher/main.cpp: Removed.
2624         * GdkLauncher/mk: Removed.
2625         * GdkLauncher/simple.svg: Removed.
2626         * GdkLauncher/text.html: Removed.
2627         * GtkLauncher: Added.
2628         * GtkLauncher/GdkLauncher.pro: Removed.
2629         * GtkLauncher/GtkLauncher.pro: Added.
2630         * GtkLauncher/main.cpp:
2631         (updateWindowTitle):
2632         (main):
2633         * Scripts/build-webkit:
2634         * Scripts/regenerate-makefiles:
2635         * Scripts/run-javascriptcore-tests:
2636         * Scripts/run-launcher:
2637         * Scripts/run-webkit-tests:
2638         * Scripts/webkitdirs.pm:
2639
2640 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2641
2642         Reviewed by Darin.
2643
2644         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2645
2646         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2647         This is tested by plugins/root-object-premature-delete-crash.html.
2648
2649         * DumpRenderTree/mac/ObjCController.m:
2650         (-[ObjCController accessStoredWebScriptObject]):
2651
2652 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2653
2654         Reviewed by Oliver.
2655
2656         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2657
2658         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2659         (FrameLoadDelegate::FrameLoadDelegate):
2660
2661 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2662
2663         Reviewed by Adam.
2664
2665         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2666         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2667
2668         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2669         Now isQt() and isGdk() use global variables that are only set once.
2670
2671         An array of all the parameters is now given to build-dumprender which includes
2672         the platform on linux.
2673
2674         * Scripts/build-dumprendertree:
2675         * Scripts/run-webkit-tests:
2676         * Scripts/webkitdirs.pm:
2677
2678 2007-09-19  Adam Roben  <aroben@apple.com>
2679
2680         Rubberstamped by Hyatt.
2681
2682         * Spinneret: Removed.
2683
2684 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2685
2686         Reviewed by David Kilzer.
2687
2688         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2689
2690 2007-09-18  Sam Weinig  <sam@webkit.org>
2691
2692         Add JSRetainPtr.h #include to fix some builds.
2693
2694         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2695
2696 2007-09-18  Mike Hommey  <glandium@debian.org>
2697
2698         Reviewed by Adam.
2699
2700         * Scripts/prepare-ChangeLog:
2701         - Properly parse GECOS field.
2702         - Use git configuration for user name and email when appropriate.
2703
2704 2007-09-17  Sam Weinig  <sam@webkit.org>
2705
2706         Build fix.
2707
2708         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2709
2710 2007-09-17  Sam Weinig  <sam@webkit.org>
2711
2712         Reviewed by Adam Roben.
2713
2714         Share more code between mac and windows DRT.
2715             - GCController is now shared.
2716             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2717
2718         * DumpRenderTree/GCController.cpp:
2719         * DumpRenderTree/win/DumpRenderTree.cpp:
2720         * DumpRenderTree/win/DumpRenderTree.vcproj:
2721         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2722         (FrameLoadDelegate::FrameLoadDelegate):
2723         (FrameLoadDelegate::~FrameLoadDelegate):
2724         (FrameLoadDelegate::windowScriptObjectAvailable):
2725         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2726         * DumpRenderTree/win/GCController.cpp: Removed.
2727         * DumpRenderTree/win/GCController.h: Removed.
2728         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2729         (GCController::collect):
2730         (GCController::collectOnAlternateThread):
2731         (GCController::getJSObjectCount):
2732         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2733         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2734
2735 2007-09-17  Sam Weinig  <sam@webkit.org>
2736
2737         Reviewed by Adam Roben.
2738
2739         Begin sharing code between mac and windows DRT.
2740             - both now share LayoutTestController.h/cpp and implement platform dependant 
2741               operations in LayoutTestControllerMac/Win.
2742             - DumpRenderTree.h is now shared.
2743             - WorkQueue and WorkQueueItem are also shared.
2744
2745         * DumpRenderTree/DumpRenderTree.h:
2746         * DumpRenderTree/LayoutTestController.cpp:
2747         * DumpRenderTree/win/DumpRenderTree.cpp:
2748         (displayWebView):
2749         (dumpFrameScrollPosition):
2750         (dumpFramesAsText):
2751         (dump):
2752         (runTest):
2753         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2754         * DumpRenderTree/win/DumpRenderTree.vcproj:
2755         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2756         * DumpRenderTree/win/EditingDelegate.cpp:
2757         (EditingDelegate::shouldBeginEditingInDOMRange):
2758         (EditingDelegate::shouldEndEditingInDOMRange):
2759         (EditingDelegate::shouldInsertNode):
2760         (EditingDelegate::shouldInsertText):
2761         (EditingDelegate::shouldDeleteDOMRange):
2762         (EditingDelegate::shouldChangeSelectedDOMRange):
2763         (EditingDelegate::shouldApplyStyle):
2764         (EditingDelegate::shouldChangeTypingStyle):
2765         (EditingDelegate::doPlatformCommand):
2766         (EditingDelegate::webViewDidBeginEditing):
2767         (EditingDelegate::webViewDidChange):
2768         (EditingDelegate::webViewDidEndEditing):
2769         (EditingDelegate::webViewDidChangeTypingStyle):
2770         (EditingDelegate::webViewDidChangeSelection):
2771         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2772         * DumpRenderTree/win/LayoutTestController.h: Removed.
2773         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2774         (LayoutTestController::addDisallowedURL):
2775         (LayoutTestController::clearBackForwardList):
2776         (LayoutTestController::copyDecodedHostName):
2777         (LayoutTestController::copyEncodedHostName):
2778         (LayoutTestController::display):
2779         (LayoutTestController::keepWebHistory):
2780         (LayoutTestController::notifyDone):
2781         (LayoutTestController::queueBackNavigation):
2782         (LayoutTestController::queueForwardNavigation):
2783         (jsStringRefToWString):
2784         (LayoutTestController::queueLoad):
2785         (LayoutTestController::queueReload):
2786         (LayoutTestController::queueScript):
2787         (LayoutTestController::setAcceptsEditing):
2788         (LayoutTestController::setCustomPolicyDelegate):
2789         (LayoutTestController::setMainFrameIsFirstResponder):
2790         (LayoutTestController::setTabKeyCyclesThroughElements):
2791         (LayoutTestController::setUseDashboardCompatibilityMode):
2792         (LayoutTestController::setUserStyleSheetEnabled):
2793         (LayoutTestController::setUserStyleSheetLocation):
2794         (LayoutTestController::setWindowIsKey):
2795         (waitUntilDoneWatchdogFired):
2796         (LayoutTestController::setWaitToDump):
2797         (LayoutTestController::windowCount):
2798         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2799         (FrameLoadDelegate::didReceiveTitle):
2800         (FrameLoadDelegate::processWork):
2801         (FrameLoadDelegate::locationChangeDone):
2802         (FrameLoadDelegate::windowScriptObjectAvailable):
2803         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2804         * DumpRenderTree/win/WorkQueue.h: Removed.
2805         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2806         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2807         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2808         (jsStringRefToWString):
2809         (LoadItem::invoke):
2810         (ScriptItem::invoke):
2811
2812 2007-09-17  Sam Weinig  <sam@webkit.org>
2813
2814         Reviewed by Adam Roben.
2815
2816         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2817
2818         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2819         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2820         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2821         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2822         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2823         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2824         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2825         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2826         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2827         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2828         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2829         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2830         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2831         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2832         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2833         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2834         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2835         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2836         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2837         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2838         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2839         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2840         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2841         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2842         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2843         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2844         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2845         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2846         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2847         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2848         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2849         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2850         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2851         * DumpRenderTree/win: Added.
2852         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2853         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2854         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2855         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2856         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2857         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2858         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2859         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2860         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2861         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2862         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2863         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2864         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2865         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2866         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2867         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2868         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2869         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2870         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2871         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2872         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2873         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2874         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2875         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2876         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2877         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2878
2879 2007-09-15  Mark Rowe  <mrowe@apple.com>
2880
2881         Build fix for DumpRenderTree.
2882
2883         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2884
2885 2007-09-14  Sam Weinig  <sam@webkit.org>
2886
2887         Rubber stamped by Adam Roben.
2888
2889         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2890           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2891             kept in the WaitUntilDoneDelegate file for the time being.
2892
2893         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2894         (main):
2895         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2896         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2897         (UIDelegate::QueryInterface):
2898         (UIDelegate::AddRef):
2899         (UIDelegate::Release):
2900         (UIDelegate::hasCustomMenuImplementation):
2901         (UIDelegate::setFrame):
2902         (UIDelegate::webViewFrame):
2903         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2904         (UIDelegate::webViewAddMessageToConsole):
2905         (UIDelegate::doDragDrop):
2906         (UIDelegate::webViewGetDlgCode):
2907         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2908         (UIDelegate::UIDelegate):
2909         (UIDelegate::createWebViewWithRequest):
2910         (UIDelegate::webViewShow):
2911         (UIDelegate::webViewClose):
2912         (UIDelegate::webViewFocus):
2913         (UIDelegate::webViewUnfocus):
2914         (UIDelegate::webViewFirstResponder):
2915         (UIDelegate::makeFirstResponder):
2916         (UIDelegate::setStatusText):
2917         (UIDelegate::webViewStatusText):
2918         (UIDelegate::webViewAreToolbarsVisible):
2919         (UIDelegate::setToolbarsVisible):
2920         (UIDelegate::webViewIsStatusBarVisible):
2921         (UIDelegate::setStatusBarVisible):
2922         (UIDelegate::webViewIsResizable):
2923         (UIDelegate::setResizable):
2924         (UIDelegate::setContentRect):
2925         (UIDelegate::webViewContentRect):
2926         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2927         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2928         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2929         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2930         (UIDelegate::mouseDidMoveOverElement):
2931         (UIDelegate::contextMenuItemsForElement):
2932         (UIDelegate::validateUserInterfaceItem):
2933         (UIDelegate::shouldPerformAction):
2934         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2935         (UIDelegate::willPerformDragDestinationAction):
2936         (UIDelegate::dragSourceActionMaskForPoint):
2937         (UIDelegate::willPerformDragSourceAction):
2938         (UIDelegate::contextMenuItemSelected):
2939         (UIDelegate::trackCustomPopupMenu):
2940         (UIDelegate::measureCustomMenuItem):
2941         (UIDelegate::drawCustomMenuItem):
2942         (UIDelegate::addCustomMenuDrawingData):
2943         (UIDelegate::cleanUpCustomMenuDrawingData):
2944         (UIDelegate::canTakeFocus):
2945         (UIDelegate::takeFocus):
2946         (UIDelegate::registerUndoWithTarget):
2947         (UIDelegate::removeAllActionsWithTarget):
2948         (UIDelegate::setActionTitle):
2949         (UIDelegate::undo):
2950         (UIDelegate::redo):
2951         (UIDelegate::canUndo):
2952         (UIDelegate::canRedo):
2953         (UIDelegate::webViewResizerRect):
2954         (UIDelegate::webViewDrawResizer):
2955         (UIDelegate::webViewScrolled):
2956         (UIDelegate::webViewShouldInterruptJavaScript):
2957         (UIDelegate::webViewReceivedFocus):
2958         (UIDelegate::webViewLostFocus):
2959         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2960         (FrameLoadDelegate::QueryInterface):
2961         (FrameLoadDelegate::AddRef):
2962         (FrameLoadDelegate::Release):
2963         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2964         (FrameLoadDelegate::didCommitLoadForFrame):
2965         (FrameLoadDelegate::didReceiveTitle):
2966         (FrameLoadDelegate::processWork):
2967         (processWorkTimer):
2968         (FrameLoadDelegate::locationChangeDone):
2969         (FrameLoadDelegate::didFinishLoadForFrame):
2970         (FrameLoadDelegate::didFailLoadWithError):
2971         (FrameLoadDelegate::windowScriptObjectAvailable):
2972         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2973         (FrameLoadDelegate::FrameLoadDelegate):
2974
2975 2007-09-14  Sam Weinig  <sam@webkit.org>
2976
2977         Reviewed by Kevin McCullough.
2978
2979         Move mac specific globals in to mac/DumpRenderTreeMac.h
2980
2981         * DumpRenderTree/DumpRenderTree.h:
2982         * DumpRenderTree/DumpRenderTree.mm: Removed.
2983         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2984         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2985         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2986
2987 2007-09-14  Brady Eidson  <beidson@apple.com>
2988
2989         Rubberstamped by Weinig
2990
2991         You know, Sam, some of us use case-sensitve filesystems...
2992
2993         * DumpRenderTree/DumpRenderTree.h:
2994         * DumpRenderTree/mac/UIDelegate.mm:
2995
2996 2007-09-14  Sam Weinig  <sam@webkit.org>
2997
2998         Rubber stamped by Adam Roben.
2999
3000         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
3001         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
3002
3003         * DumpRenderTree/AppleScriptController.h: Removed.
3004         * DumpRenderTree/AppleScriptController.m: Removed.
3005         * DumpRenderTree/DumpRenderTree.h:
3006         * DumpRenderTree/DumpRenderTree.mm:
3007         (startJavaScriptThreads):
3008         (stopJavaScriptThreads):
3009         (activateAhemFont):
3010         (setDefaultColorProfileToRGB):
3011         (makeLargeMallocFailSilently):
3012         (dumpFrameScrollPosition):
3013         (dumpFramesAsText):
3014         (dump):
3015         (runTest):
3016         (-[DumpRenderTreeWindow isKeyWindow]):
3017         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3018         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
3019         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
3020         * DumpRenderTree/EditingDelegate.h: Removed.
3021         * DumpRenderTree/EditingDelegate.m: Removed.
3022         * DumpRenderTree/EventSendingController.h: Removed.
3023         * DumpRenderTree/EventSendingController.m: Removed.
3024         * DumpRenderTree/FrameLoadDelegate.h: Removed.
3025         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
3026         * DumpRenderTree/GCController.mm: Removed.
3027         * DumpRenderTree/ImageDiff.m: Removed.
3028         * DumpRenderTree/LayoutTestController.cpp:
3029         (LayoutTestController::LayoutTestController):
3030         (dumpAsTextCallback):
3031         (dumpBackForwardListCallback):
3032         (dumpChildFramesAsTextCallback):
3033         (dumpChildFrameScrollPositionsCallback):
3034         (dumpDOMAsWebArchiveCallback):
3035         (dumpEditingCallbacksCallback):
3036         (dumpFrameLoadCallbacksCallback):
3037         (dumpResourceLoadCallbacksCallback):
3038         (dumpSelectionRectCallback):
3039         (dumpSourceAsWebArchiveCallback):
3040         (dumpTitleChangesCallback):
3041         (repaintSweepHorizontallyCallback):
3042         (setCallCloseOnWebViewsCallback):
3043         (setCanOpenWindowsCallback):
3044         (setCloseRemainingWindowsWhenCompleteCallback):
3045         (testRepaintCallback):
3046         (addFileToPasteboardOnDragCallback):
3047         (waitUntilDoneCallback):
3048         * DumpRenderTree/LayoutTestController.h:
3049         (LayoutTestController::dumpAsText):
3050         (LayoutTestController::setDumpAsText):
3051         (LayoutTestController::dumpBackForwardList):
3052         (LayoutTestController::setDumpBackForwardList):
3053         (LayoutTestController::dumpChildFrameScrollPositions):
3054         (LayoutTestController::setDumpChildFrameScrollPositions):
3055         (LayoutTestController::dumpChildFramesAsText):
3056         (LayoutTestController::setDumpChildFramesAsText):
3057         (LayoutTestController::dumpDOMAsWebArchive):
3058         (LayoutTestController::setDumpDOMAsWebArchive):
3059         (LayoutTestController::dumpSelectionRect):
3060         (LayoutTestController::setDumpSelectionRect):
3061         (LayoutTestController::dumpSourceAsWebArchive):
3062         (LayoutTestController::setDumpSourceAsWebArchive):
3063         (LayoutTestController::dumpTitleChanges):
3064         (LayoutTestController::setDumpTitleChanges):
3065         (LayoutTestController::dumpEditingCallbacks):
3066         (LayoutTestController::setDumpEditingCallbacks):
3067         (LayoutTestController::dumpResourceLoadCallbacks):
3068         (LayoutTestController::setDumpResourceLoadCallbacks):
3069         (LayoutTestController::dumpFrameLoadCallbacks):
3070         (LayoutTestController::setDumpFrameLoadCallbacks):
3071         (LayoutTestController::addFileToPasteboardOnDrag):
3072         (LayoutTestController::setAddFileToPasteboardOnDrag):
3073         (LayoutTestController::callCloseOnWebViews):
3074         (LayoutTestController::setCallCloseOnWebViews):
3075         (LayoutTestController::canOpenWindows):
3076         (LayoutTestController::setCanOpenWindows):
3077         (LayoutTestController::closeRemainingWindowsWhenComplete):
3078         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3079         (LayoutTestController::testRepaint):
3080         (LayoutTestController::setTestRepaint):
3081         (LayoutTestController::testRepaintSweepHorizontally):
3082         (LayoutTestController::setTestRepaintSweepHorizontally):
3083         (LayoutTestController::waitToDump):
3084         (LayoutTestController::windowIsKey):
3085         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
3086         * DumpRenderTree/NavigationController.h: Removed.
3087         * DumpRenderTree/NavigationController.m: Removed.
3088         * DumpRenderTree/ObjCController.h: Removed.
3089         * DumpRenderTree/ObjCController.m: Removed.
3090         * DumpRenderTree/ObjCPlugin.h: Removed.
3091         * DumpRenderTree/ObjCPlugin.m: Removed.
3092         * DumpRenderTree/ObjCPluginFunction.h: Removed.
3093         * DumpRenderTree/ObjCPluginFunction.m: Removed.
3094         * DumpRenderTree/PolicyDelegate.h: Removed.
3095         * DumpRenderTree/PolicyDelegate.m: Removed.
3096         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
3097         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
3098         * DumpRenderTree/TextInputController.h: Removed.
3099         * DumpRenderTree/TextInputController.m: Removed.
3100         * DumpRenderTree/UIDelegate.h: Removed.
3101         * DumpRenderTree/UIDelegate.mm: Removed.
3102         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3103         * DumpRenderTree/mac: Added.
3104         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3105         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3106         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3107         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3108         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3109         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3110         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3111         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3112         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3113         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3114         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3115         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3116         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3117         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3118         (-[EditingDelegate webViewDidBeginEditing:]):
3119         (-[EditingDelegate webViewDidChange:]):
3120         (-[EditingDelegate webViewDidEndEditing:]):
3121         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3122         (-[EditingDelegate webViewDidChangeSelection:]):
3123         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3124         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3125         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3126         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3127         (-[FrameLoadDelegate init]):
3128         (-[FrameLoadDelegate dealloc]):
3129         (-[FrameLoadDelegate processWork:]):
3130         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3131         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3132         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3133         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3134         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3135         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3136         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3137         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3138         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3139         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3140         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3141         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3142         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3143         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3144         (-[FrameLoadDelegate webView:willCloseFrame:]):
3145         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3146         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3147         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3148         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3149         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3150         (LayoutTestController::notifyDone):
3151         (LayoutTestController::setWindowIsKey):
3152         (LayoutTestController::setWaitToDump):
3153         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3154         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3155         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3156         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3157         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3158         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3159         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3160         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3161         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3162         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3163         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3164         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3165         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3166         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3167         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3168         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3169         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3170         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3171         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3172         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3173         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3174         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3175         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3176         (-[UIDelegate webViewFocus:]):
3177         (-[UIDelegate webView:createWebViewWithRequest:]):
3178         (-[UIDelegate webViewClose:]):
3179         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3180
3181 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3182
3183         Reviewed by Adam.
3184
3185         - Changing Win version of Drosera work with recent changes.
3186
3187         * Drosera/DebuggerDocument.cpp:
3188         * Drosera/DebuggerDocument.h:
3189         * Drosera/mac/DebuggerDocumentPlatform.mm:
3190         (NSStringCreateWithJSStringRef):
3191         (JSValueRefCreateWithNSString):
3192         * Drosera/win/DebuggerClient.cpp:
3193         (DebuggerClient::stepInto):
3194         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3195
3196 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3197
3198         Reviewed by Tim.
3199
3200         - Moved isPaused into the JS for efficiency and simplicity.
3201
3202         * Drosera/DebuggerDocument.cpp:
3203         (DebuggerDocument::DebuggerDocument):
3204         (DebuggerDocument::pauseCallback):
3205         (DebuggerDocument::resumeCallback):
3206         (DebuggerDocument::isPaused):
3207         (DebuggerDocument::staticFunctions):
3208         * Drosera/DebuggerDocument.h:
3209         * Drosera/console.js:
3210         * Drosera/debugger.js:
3211         * Drosera/mac/DebuggerClient.mm:
3212         (-[DebuggerClient validateUserInterfaceItem:]):
3213
3214 2007-09-13  Sam Weinig  <sam@webkit.org>
3215
3216         Rubber stamped by Darin.
3217
3218         Make DumpRenderTree more cross platform ready.
3219         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3220         - Use CF types instead of NS objects.
3221         - General cleanup.
3222
3223         * DumpRenderTree/DumpRenderTree.h:
3224         * DumpRenderTree/DumpRenderTree.mm:
3225         (dumpRenderTree):
3226         (dump):
3227         (runTest):
3228         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3229         * DumpRenderTree/EditingDelegate.m:
3230         * DumpRenderTree/FrameLoadDelegate.h:
3231         * DumpRenderTree/FrameLoadDelegate.mm:
3232         (-[FrameLoadDelegate init]):
3233         (-[FrameLoadDelegate dealloc]):
3234         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3235         * DumpRenderTree/GCController.cpp: Added.
3236         (GCController::GCController):
3237         (GCController::~GCController):
3238         (collectCallback):
3239         (collectOnAlternateThreadCallback):
3240         (getJSObjectCountCallback):
3241         (GCController::makeWindowObject):
3242         (GCController::getJSClass):
3243         (GCController::staticFunctions):
3244         * DumpRenderTree/GCController.h:
3245         * DumpRenderTree/GCController.mm:
3246         (GCController::collect):
3247         (GCController::collectOnAlternateThread):
3248         (GCController::getJSObjectCount):
3249         * DumpRenderTree/LayoutTestController.cpp:
3250         (LayoutTestController::makeWindowObject):
3251         (LayoutTestController::getJSClass):
3252         * DumpRenderTree/LayoutTestController.h:
3253         * DumpRenderTree/LayoutTestControllerMac.mm:
3254         (LayoutTestController::addDisallowedURL):
3255         (waitUntilDoneWatchdogFired):
3256         (LayoutTestController::waitUntilDone):
3257         * DumpRenderTree/ResourceLoadDelegate.m:
3258         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3259
3260 2007-09-12  Sam Weinig  <sam@webkit.org>
3261
3262         Reviewed by Stephanie.
3263
3264         Fix leaks in mac DumpRenderTree.
3265
3266         * DumpRenderTree/FrameLoadDelegate.mm:
3267         (-[FrameLoadDelegate init]): Initalize in the correct order.
3268         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3269         * DumpRenderTree/LayoutTestController.cpp:
3270         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3271         (encodeHostNameCallback): ditto.
3272         * DumpRenderTree/LayoutTestController.h:
3273         * DumpRenderTree/LayoutTestControllerMac.mm:
3274         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3275         (LayoutTestController::copyEncodedHostName): ditto
3276         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3277
3278 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3279
3280         Reviewed by Geof.
3281
3282         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3283
3284         * Scripts/run-webkit-tests:
3285
3286 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3287
3288         Reviewed by Darin.
3289
3290         - Simplified code paths and extracted out functions to increase encapsulation.
3291
3292         * Drosera/DebuggerDocument.cpp:
3293         (DebuggerDocument::breakpointEditorHTMLCallback):
3294         (DebuggerDocument::isPausedCallback):
3295         (DebuggerDocument::pauseCallback):
3296         (DebuggerDocument::resumeCallback):
3297         (DebuggerDocument::stepIntoCallback):
3298         (DebuggerDocument::evaluateScriptCallback):
3299         (DebuggerDocument::currentFunctionStackCallback):
3300         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3301         (DebuggerDocument::valueForScopeVariableNamedCallback):
3302         (DebuggerDocument::logCallback):
3303         * Drosera/DebuggerDocument.h:
3304         (DebuggerDocument::getPaused):
3305         * Drosera/mac/DebuggerClient.mm:
3306         (-[DebuggerClient pause:]):
3307         (-[DebuggerClient resume:]):
3308         (-[DebuggerClient stepInto:]):
3309         (-[DebuggerClient stepOver:]):
3310         (-[DebuggerClient stepOut:]):
3311         (-[DebuggerClient showConsole:]):
3312         (-[DebuggerClient closeCurrentFile:]):
3313         (-[DebuggerClient validateUserInterfaceItem:]):
3314         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3315         (+[NSString stringOrNilFromWebScriptResult:]):
3316         (DebuggerDocument::platformPause):
3317         (DebuggerDocument::platformResume):
3318         (DebuggerDocument::platformStepInto):
3319         (DebuggerDocument::platformEvaluateScript):
3320         (DebuggerDocument::getPlatformCurrentFunctionStack):
3321         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3322         (DebuggerDocument::platformValueForScopeVariableNamed):
3323         (DebuggerDocument::platformLog):
3324         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3325
3326 2007-09-12  Sam Weinig  <sam@webkit.org>
3327
3328         Build fix for Buildbot.
3329
3330         * DumpRenderTree/DumpRenderTree.mm:
3331         (dump):
3332
3333 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3334
3335         Reviewed by Geoff.
3336
3337         - Updated the leaks list for leopard to help identify regressions.
3338
3339         * Scripts/run-webkit-tests:
3340
3341 2007-09-12  Sam Weinig  <sam@webkit.org>
3342
3343         Rubber stamped by Darin.
3344
3345         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3346
3347         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
3348         * DumpRenderTree/DumpRenderTree.m: Removed.
3349         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3350         (stopJavaScriptThreads): Fix initialization.
3351         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3352         (dumpRenderTree): Ditto.
3353         (runTest):
3354         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3355
3356         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3357         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3358         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3359         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3360         (-[FrameLoadDelegate init]):
3361         (-[FrameLoadDelegate dealloc]):
3362         (-[FrameLoadDelegate processWork:]):
3363         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3364         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3365         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3366         
3367         * DumpRenderTree/LayoutTestController.cpp: Added.
3368         (LayoutTestController::LayoutTestController):
3369         (LayoutTestController::~LayoutTestController):
3370         (dumpAsTextCallback):
3371         (dumpBackForwardListCallback):
3372         (dumpChildFramesAsTextCallback):
3373         (dumpChildFrameScrollPositionsCallback):
3374         (dumpDOMAsWebArchiveCallback):
3375         (dumpEditingCallbacksCallback):
3376         (dumpFrameLoadCallbacksCallback):
3377         (dumpResourceLoadCallbacksCallback):
3378         (dumpSelectionRectCallback):
3379         (dumpSourceAsWebArchiveCallback):
3380         (dumpTitleChangesCallback):
3381         (repaintSweepHorizontallyCallback):
3382         (setCallCloseOnWebViewsCallback):
3383         (setCanOpenWindowsCallback):
3384         (setCloseRemainingWindowsWhenCompleteCallback):
3385         (testRepaintCallback):
3386         (addFileToPasteboardOnDragCallback):
3387         (addDisallowedURLCallback):
3388         (clearBackForwardListCallback):
3389         (decodeHostNameCallback):
3390         (displayCallback):
3391         (encodeHostNameCallback):
3392         (keepWebHistoryCallback):
3393         (notifyDoneCallback):
3394         (queueBackNavigationCallback):
3395         (queueForwardNavigationCallback):
3396         (queueLoadCallback):
3397         (queueReloadCallback):
3398         (queueScriptCallback):
3399         (setAcceptsEditingCallback):
3400         (setCustomPolicyDelegateCallback):
3401         (setMainFrameIsFirstResponderCallback):
3402         (setTabKeyCyclesThroughElementsCallback):
3403         (setUseDashboardCompatibilityModeCallback):
3404         (setUserStyleSheetEnabledCallback):
3405         (setUserStyleSheetLocationCallback):
3406         (setWindowIsKeyCallback):
3407         (waitUntilDoneCallback):
3408         (windowCountCallback):
3409         (LayoutTestController::makeWindowObject):
3410         (LayoutTestController::getLayoutTestControllerJSClass):
3411         (LayoutTestController::staticFunctions):
3412         * DumpRenderTree/LayoutTestController.h: Replaced.
3413         * DumpRenderTree/LayoutTestController.m: Removed.
3414         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
3415         (LayoutTestController::dumpAsText):
3416         (LayoutTestController::dumpBackForwardList):
3417         (LayoutTestController::dumpChildFramesAsText):
3418         (LayoutTestController::dumpChildFrameScrollPositions):
3419         (LayoutTestController::dumpDOMAsWebArchive):
3420         (LayoutTestController::dumpEditingCallbacks):
3421         (LayoutTestController::dumpFrameLoadCallbacks):
3422         (LayoutTestController::dumpResourceLoadCallbacks):
3423         (LayoutTestController::dumpSelectionRect):
3424         (LayoutTestController::dumpSourceAsWebArchive):
3425         (LayoutTestController::dumpTitleChanges):
3426         (LayoutTestController::repaintSweepHorizontally):
3427         (LayoutTestController::setCallCloseOnWebViews):
3428         (LayoutTestController::setCanOpenWindows):
3429         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3430         (LayoutTestController::testRepaint):
3431         (LayoutTestController::addFileToPasteboardOnDrag):
3432         (LayoutTestController::addDisallowedURL):
3433         (LayoutTestController::clearBackForwardList):
3434         (LayoutTestController::decodeHostName):
3435         (LayoutTestController::encodeHostName):
3436         (LayoutTestController::display):
3437         (LayoutTestController::keepWebHistory):
3438         (LayoutTestController::notifyDone):
3439         (LayoutTestController::queueBackNavigation):
3440         (LayoutTestController::queueForwardNavigation):
3441         (LayoutTestController::queueLoad):
3442         (LayoutTestController::queueReload):
3443         (LayoutTestController::queueScript):
3444         (LayoutTestController::setAcceptsEditing):
3445         (LayoutTestController::setCustomPolicyDelegate):
3446         (LayoutTestController::setMainFrameIsFirstResponder):
3447         (LayoutTestController::setTabKeyCyclesThroughElements):
3448         (LayoutTestController::setUseDashboardCompatibilityMode):
3449         (LayoutTestController::setUserStyleSheetEnabled):
3450         (LayoutTestController::setUserStyleSheetLocation):
3451         (LayoutTestController::setWindowIsKey):
3452         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
3453         (LayoutTestController::waitUntilDone):
3454         (LayoutTestController::windowCount):
3455         Use the JSCore API to implement the LayoutTestController.
3456
3457         * DumpRenderTree/ObjCController.h:
3458         * DumpRenderTree/ObjCController.m:
3459         (+[ObjCController isSelectorExcludedFromWebScript:]):
3460         (+[ObjCController webScriptNameForSelector:]):
3461         (-[ObjCController accessStoredWebScriptObject]):
3462         (-[ObjCController storeWebScriptObject:]):
3463         (-[ObjCController dealloc]):
3464         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
3465         Move WebScriptObject tests to ObjCController.
3466
3467         * DumpRenderTree/UIDelegate.m: Removed.
3468         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
3469
3470         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3471         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3472         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3473         (WorkQueueItem::~WorkQueueItem):
3474         (LoadItem::LoadItem):
3475         (LoadItem::url):
3476         (LoadItem::target):
3477         (ScriptItem::ScriptItem):
3478         (ScriptItem::script):
3479         * DumpRenderTree/WorkQueueItemMac.mm: Added.
3480         (LoadItem::invoke):
3481         (ReloadItem::invoke):
3482         (ScriptItem::invoke):
3483         (BackForwardItem::invoke):
3484         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
3485         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
3486         sharing code.
3487
3488 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3489
3490         Reviewed by Maciej.
3491
3492         - Updated Win side to take advantage of the platform separating changes.
3493
3494         * Drosera/DebuggerDocument.cpp:
3495         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3496         * Drosera/DebuggerDocument.h:
3497         * Drosera/win/DebuggerClient.cpp:
3498         (DebuggerClient::pause):
3499         (DebuggerClient::resume):
3500         (DebuggerClient::stepInto):
3501         (DebuggerDocument::platformPause):
3502         (DebuggerDocument::platformResume):
3503         (DebuggerDocument::platformStepInto):
3504         (DebuggerDocument::platformEvaluateScript):
3505         (DebuggerDocument::getPlatformCurrentFunctionStack):
3506         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3507         (DebuggerDocument::platformValueForScopeVariableNamed):
3508         (DebuggerDocument::platformLog):
3509         * Drosera/win/DebuggerClient.h:
3510         * Drosera/win/Drosera.cpp:
3511         (Drosera::Drosera):
3512         (Drosera::windowScriptObjectAvailable):
3513         (Drosera::initWithServerName):
3514         (Drosera::switchToServerNamed):
3515         * Drosera/win/Drosera.h:
3516         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3517
3518 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3519
3520         Reviewed by Adam.
3521
3522         - Just doing the moves in a separate patch so the changes are easier to see.
3523
3524         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
3525         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
3526         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
3527         * Drosera/win/DebuggerDocumentWin.h: Removed.
3528         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3529
3530 2007-09-11  Sven Herzberg  <sven@imendio.com>
3531
3532         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
3533         http://bugs.webkit.org/show_bug.cgi?id=15176
3534
3535         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
3536         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
3537         other paths eg. from jhbuild)
3538
3539 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3540
3541         Reviewed by Adam.
3542
3543         - Made an order-of-deletion mistake.
3544
3545         * Drosera/DebuggerDocument.h:
3546         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3547         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.