1 2009-11-25 Yuzo Fujishima <yuzo@google.com>
3 Reviewed by Eric Seidel.
5 Update pywebsocket to 0.4.2
7 Update pywebsocket to 0.4.2
8 https://bugs.webkit.org/show_bug.cgi?id=31861
10 * pywebsocket/example/echo_client.py:
11 * pywebsocket/example/echo_wsh.py:
12 * pywebsocket/mod_pywebsocket/__init__.py:
13 * pywebsocket/mod_pywebsocket/dispatch.py:
14 * pywebsocket/mod_pywebsocket/msgutil.py:
15 * pywebsocket/mod_pywebsocket/standalone.py:
16 * pywebsocket/setup.py:
17 * pywebsocket/test/test_dispatch.py:
18 * pywebsocket/test/test_msgutil.py:
20 2009-11-25 Adam Barth <abarth@webkit.org>
22 Reviewed by Eric Seidel.
24 Add unit test for mark-fixed
25 https://bugs.webkit.org/show_bug.cgi?id=31896
27 * Scripts/modules/commands/commandtest.py: Added.
28 * Scripts/modules/commands/queries_unittest.py:
29 * Scripts/modules/commands/upload_unittest.py: Added.
30 * Scripts/modules/mock_bugzillatool.py:
31 * Scripts/run-webkit-unittests:
33 2009-11-25 Adam Barth <abarth@webkit.org>
35 Reviewed by Eric Seidel.
37 bugzilla-tool should have a mark-fixed command
38 https://bugs.webkit.org/show_bug.cgi?id=31853
42 * Scripts/modules/commands/upload.py:
44 2009-11-25 Eric Seidel <eric@webkit.org>
46 Reviewed by Adam Barth.
48 'bugzilla-tool help' should only show common commands like how 'git help' does
49 https://bugs.webkit.org/show_bug.cgi?id=31772
51 I also took this opportunity to make 'help' a real Command.
52 Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
54 * Scripts/bugzilla-tool:
55 - change should_show_command_help to should_show_in_main_help
56 * Scripts/modules/commands/download.py:
57 - Mark commands as being shown in main help or not.
58 - show_in_main_help = False is not required (default is false),
59 but it seemed to make the commands more self-documenting.
60 * Scripts/modules/commands/queries.py: ditto
61 * Scripts/modules/commands/queues.py: ditto
62 * Scripts/modules/commands/upload.py: ditto
63 * Scripts/modules/multicommandtool.py:
64 - Make Command hold a pointer to tool in self.tool. Most Command
65 subclasses do not take advantage of this yet, but it was required
66 for HelpCommand to be able to reach the tool from _help_epilog().
67 - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
68 - Move MultiCommandTool._help_epilog to Command._help_epilog
69 - Move "help" logic into HelpCommand.execute()
70 - Change should_show_command_help to should_show_in_main_help and add a default implementation.
71 * Scripts/modules/multicommandtool_unittest.py:
72 - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
74 2009-11-25 Brian Weinstein <bweinstein@apple.com>
76 Reviewed by Dan Bernstein.
80 The buildbots are failing on Windows because when they were upgraded
81 to 4.0.4, Apple Application Support was not in their path. Add it to
82 the path to fix the buildots.
84 * Scripts/webkitdirs.pm:
86 2009-11-25 Csaba Osztrogonác <ossy@webkit.org>
88 Reviewed by David Kilzer.
90 run-webkit-tests doesn't accept directories/files with --skipped=only parameter
91 https://bugs.webkit.org/show_bug.cgi?id=31799
93 * Scripts/run-webkit-tests: Fixed.
95 2009-11-25 Zoltan Horvath <zoltan@webkit.org>
97 Reviewed by Eric Seidel.
99 Change run_command to give back stderr by default
100 https://bugs.webkit.org/show_bug.cgi?id=31734
102 Change run_command to give back stderr by default.
103 Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
104 Change the related unittest call.
106 * Scripts/modules/scm.py:
107 * Scripts/modules/scm_unittest.py:
109 2009-11-25 Eric Seidel <eric@webkit.org>
111 Reviewed by Adam Barth.
113 Centralize required argument parsing in Command
114 https://bugs.webkit.org/show_bug.cgi?id=31872
116 * Scripts/modules/commands/download.py: remove custom required arg message.
117 * Scripts/modules/commands/upload.py: ditto.
118 * Scripts/modules/multicommandtool.py:
119 - Add _parse_required_arguments.
120 - Pass program name off to OptionParser.
121 - Add name() for access to tool name.
122 - Add check_arguments_and_execute and make it return a return code.
123 - Replace a couple uses of + with %.
124 * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
126 2009-11-25 Eric Seidel <eric@webkit.org>
128 Reviewed by Adam Barth.
130 Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
131 https://bugs.webkit.org/show_bug.cgi?id=31870
133 * Scripts/modules/commands/queries_unittest.py: Use the new class.
134 * Scripts/modules/multicommandtool_unittest.py: Ditto.
135 * Scripts/modules/outputcapture.py: Added.
137 2009-11-24 Dmitry Titov <dimich@chromium.org>
139 Reviewed by Eric Seidel.
141 Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
142 https://bugs.webkit.org/show_bug.cgi?id=31444
144 * Scripts/build-webkit:
146 2009-11-24 Chris Marrin <cmarrin@apple.com>
148 Reviewed by Simon Fraser.
150 Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
151 https://bugs.webkit.org/show_bug.cgi?id=27314
153 Now the script allows the directories with these tests to be included on all
154 platforms but Mac, where they behave the same as always. For all other platforms
155 the tests need to be excluded using the Skipped files, which is currently done
156 for all platforms (including win since we're not turned on yet)
158 * Scripts/webkitdirs.pm:
160 2009-11-24 Eric Seidel <eric@webkit.org>
162 Reviewed by Adam Barth.
164 queries_unittest.py should test command output
165 https://bugs.webkit.org/show_bug.cgi?id=31845
167 * Scripts/modules/commands/queries_unittest.py:
168 - Capture stdout and stderr and compare with expected strings.
170 2009-11-24 Simon Fraser <simon.fraser@apple.com>
174 Fix spelling error ("depenedencies").
176 * Scripts/build-webkit:
178 2009-11-24 Mark Rowe <mrowe@apple.com>
180 Land the configuration that includes the two debug GTK Linux builders.
182 * BuildSlaveSupport/build.webkit.org-config/config.json:
184 2009-11-24 David Kilzer <ddkilzer@apple.com>
186 <http://webkit.org/b/31840> bisect-builds broke after r50080
188 Reviewed by Dan Bernstein.
190 * Scripts/bisect-builds:
191 (mountAndRunNightly): Switched back to using backticks to run
192 the hdiutil command since exec() will terminate the existing
193 script, which is not what we want. Store the output of
194 File::Spec->devnull() in a variable for use in the hdiutil
197 2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
199 Reviewed by Kenneth Rohde Christiansen.
201 Include "config.h" to meet Coding Style Guidelines
202 https://bugs.webkit.org/show_bug.cgi?id=31792
204 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
205 * DumpRenderTree/qt/jsobjects.cpp:
206 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
208 2009-11-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
210 Reviewed by Oliver Hunt.
212 Implement new required function to pass test we used to pass. This
213 change is required since r51294.
215 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
216 (LayoutTestController::setAllowUniversalAccessFromFileURLs):
218 2009-11-23 Jakub Wieczorek <faw217@gmail.com>
220 Reviewed by Kenneth Rohde Christiansen.
222 [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
223 https://bugs.webkit.org/show_bug.cgi?id=31775
225 LayoutTestController::dumpBackForwardList() should work with local URLs
226 as well as with normal URLs (in http tests for instance).
227 Currently it does not output the latter properly.
229 Unskip a bunch of passing http/navigation tests.
231 * DumpRenderTree/qt/DumpRenderTree.cpp:
232 (WebCore::dumpHistoryItem):
234 2009-11-22 Chris Fleizach <cfleizach@apple.com>
236 Reviewed by Oliver Hunt.
238 ARIA: support aria-flowto
239 https://bugs.webkit.org/show_bug.cgi?id=31762
241 * DumpRenderTree/AccessibilityUIElement.cpp:
242 (ariaFlowToElementAtIndexCallback):
243 (AccessibilityUIElement::getJSClass):
244 * DumpRenderTree/AccessibilityUIElement.h:
245 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
246 (AccessibilityUIElement::ariaFlowToElementAtIndex):
247 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
248 (AccessibilityUIElement::ariaFlowToElementAtIndex):
249 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
250 (AccessibilityUIElement::ariaFlowToElementAtIndex):
252 2009-11-22 Antonio Gomes <tonikitoo@webkit.org>
254 Reviewed by Kenneth Christiansen.
256 [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
257 https://bugs.webkit.org/show_bug.cgi?id=31638
259 Unfreeze WorkQueue after each test execution.
261 * DumpRenderTree/qt/DumpRenderTree.cpp:
262 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
264 2009-11-22 Jakub Wieczorek <faw217@gmail.com>
266 Reviewed by Adam Barth.
268 [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
269 for localhost and 127.0.0.1.
270 https://bugs.webkit.org/show_bug.cgi?id=31783
272 Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
274 * DumpRenderTree/qt/DumpRenderTree.cpp:
275 (WebCore::NetworkAccessManager::NetworkAccessManager):
276 (WebCore::NetworkAccessManager::sslErrorsEncountered):
277 (WebCore::WebPage::WebPage):
278 * DumpRenderTree/qt/DumpRenderTree.h:
280 2009-11-22 Chris Evans <cevans@chromium.org>
282 Reviewed by Adam Barth.
284 Disable access to file:/// directory listings
285 https://bugs.webkit.org/show_bug.cgi?id=31329
287 Implemented setAllowUniversalAccessFromFileURLs to support testing of
290 * DumpRenderTree/LayoutTestController.cpp:
291 (setAllowUniversalAccessFromFileURLsCallback):
292 (LayoutTestController::staticFunctions):
293 * DumpRenderTree/LayoutTestController.h:
294 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
295 (LayoutTestController::setAllowUniversalAccessFromFileURLs):
296 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
297 (LayoutTestController::setAllowUniversalAccessFromFileURLs):
298 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
299 (LayoutTestController::setAllowUniversalAccessFromFileURLs):
300 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
301 (LayoutTestController::setAllowUniversalAccessFromFileURLs):
303 2009-11-22 Jakub Wieczorek <faw217@gmail.com>
305 Reviewed by Kenneth Rohde Christiansen.
307 [Qt] Fix the timeout of fast/frames/frame-navigation.html
308 https://bugs.webkit.org/show_bug.cgi?id=31638
310 The test is timeouting, because it uses the WorkQueue to load a document in one
311 of the child frames and once the loading is finished, the DRT does not dump the
312 tree. This is because it waits for the QWebFrame::loadFinished() signal from
313 the main frame, while it should connect to QWebPage::loadFinished().
315 * DumpRenderTree/qt/DumpRenderTree.cpp:
316 (WebCore::DumpRenderTree::DumpRenderTree):
318 2009-11-21 Eric Seidel <eric@webkit.org>
320 Reviewed by Adam Barth.
322 bugzilla-tool --help spews way too much text
323 https://bugs.webkit.org/show_bug.cgi?id=31771
325 * Scripts/bugzilla-tool:
326 - Remove self.cached_scm initialization hack.
327 * Scripts/modules/buildbot.py:
328 - Make default_host accessible to callers.
329 * Scripts/modules/commands/download.py:
330 - Phrase help for all commands consistently and remove spurious help text punctuation.
331 * Scripts/modules/commands/queries.py: Ditto.
332 * Scripts/modules/commands/queues.py: Ditto.
333 * Scripts/modules/commands/upload.py: Ditto.
334 * Scripts/modules/multicommandtool.py:
335 - Add HelpPrintingOptionParser.format_epilog to replace
336 NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
337 per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
338 - Make --help only show a list of commands like "svn help" and "git help" do --
339 previously --help was listing all commands and options.
340 - Sort list of commands alphabetically.
342 2009-11-21 Eric Seidel <eric@webkit.org>
344 No review. Fixing a typo from the previous patch for bug 31767.
346 AbstractQueue.run_bugzilla_tool throws an exception
347 https://bugs.webkit.org/show_bug.cgi?id=31769
349 * Scripts/modules/commands/queues.py:
351 2009-11-21 Eric Seidel <eric@webkit.org>
353 Reviewed by Adam Barth.
355 commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
356 https://bugs.webkit.org/show_bug.cgi?id=31767
358 What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
359 Since we don't have a good way to test BugzillaTool pieces, I've
360 left out a test for now.
362 * Scripts/bugzilla-tool:
363 - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
364 * Scripts/modules/commands/queues.py:
365 - Use tool.path() instead of __file__.
366 * Scripts/modules/multicommandtool.py:
367 - Add a new path() method to MultiComandTool.
368 * Scripts/modules/multicommandtool_unittest.py:
369 - Provide a path() method. Little point in testing this mock implementation.
371 2009-11-21 Adam Barth <abarth@webkit.org>
373 Unreviewed "build" fix. Turns out I was testing the wrong copy of
376 * Scripts/modules/commands/download.py:
378 2009-11-21 Adam Barth <abarth@webkit.org>
380 Reviewed by Eric Seidel.
382 Convert check-style to use LandingSequence
383 https://bugs.webkit.org/show_bug.cgi?id=31763
385 Instead of manipulating the working copy by hand, we should use the
386 LandingSequence in CheckStyle. This will make this code eaiser to
389 * Scripts/modules/commands/download.py:
391 2009-11-20 Adam Barth <abarth@webkit.org>
393 Reviewed by Eric Seidel.
395 Unit test query commands
396 https://bugs.webkit.org/show_bug.cgi?id=31755
398 These tests are pretty rough, but hopefully they'll grow.
400 * Scripts/modules/commands/queries_unittest.py: Added.
401 * Scripts/modules/mock_bugzillatool.py: Added.
402 * Scripts/run-webkit-unittests:
404 2009-11-20 Eric Seidel <eric@webkit.org>
406 Reviewed by Adam Barth.
408 Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
409 https://bugs.webkit.org/show_bug.cgi?id=31758
411 * Scripts/modules/multicommandtool.py:
412 - Allow passing of explicit commands to MultiCommandTool.__init__
413 * Scripts/modules/multicommandtool_unittest.py:
414 - Use new Command.name naming system.
415 - Test Command auto-discovery.
416 * Scripts/modules/workqueue.py:
417 - bug_id no longer exists, use patch['bug_id'] instead.
418 * Scripts/modules/workqueue_unittest.py:
419 - WorkQueues require names now.
420 - should_proceed_with_work_item must return a patch object.
422 2009-11-20 Chris Fleizach <cfleizach@apple.com>
424 Reviewed by Beth Dakin.
426 WAI-ARIA: add support for aria-owns
427 https://bugs.webkit.org/show_bug.cgi?id=31702
429 * DumpRenderTree/AccessibilityUIElement.cpp:
430 (ariaOwnsElementAtIndexCallback):
431 (AccessibilityUIElement::getJSClass):
432 * DumpRenderTree/AccessibilityUIElement.h:
433 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
434 (AccessibilityUIElement::ariaOwnsElementAtIndex):
435 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
436 (AccessibilityUIElement::ariaOwnsElementAtIndex):
437 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
438 (AccessibilityUIElement::ariaOwnsElementAtIndex):
440 2009-11-20 Eric Seidel <eric@webkit.org>
442 Reviewed by Adam Barth.
444 Fix exception thrown when running the commit-queue.
446 * Scripts/modules/statusbot.py: patch is optional.
447 * Scripts/modules/workqueue.py: WorkQUeue requires a name.
449 2009-11-20 Eric Seidel <eric@webkit.org>
451 Reviewed by Adam Barth.
453 Teach the StatusBot how to support more than just the commit-queue
454 https://bugs.webkit.org/show_bug.cgi?id=31754
456 * Scripts/modules/workqueue.py: Another typo.
458 2009-11-20 Eric Seidel <eric@webkit.org>
460 Reviewed by Adam Barth.
462 Teach the StatusBot how to support more than just the commit-queue
463 https://bugs.webkit.org/show_bug.cgi?id=31754
465 * Scripts/modules/commands/queues.py: Fix silly typo.
467 2009-11-20 Eric Seidel <eric@webkit.org>
469 Reviewed by Adam Barth.
471 Teach the StatusBot how to support more than just the commit-queue
472 https://bugs.webkit.org/show_bug.cgi?id=31754
474 * CommitQueueStatus/index.yaml:
475 - Add indices required for the new queries.
476 * CommitQueueStatus/queue_status.py:
477 - Add a patch-status page and move update_status to update-status.
478 - Only display "commit-queue" status records for the commit-queue.
479 - Add support for a queue_name property on status records.
480 - Fix _int_from_request to actually work.
481 * CommitQueueStatus/update_status.html:
482 - Add support for a queue_name on status records.
483 - Remove unused list of bug ids.
484 * Scripts/modules/commands/queues.py
485 - Make the queues pass the patch instead of the bug_id to StatusBot.
486 * Scripts/modules/statusbot.py:
487 - Support passing the queue_name to the status updates.
488 - Support fetching patch status with patch_status().
489 * Scripts/modules/workqueue.py:
490 - Pass the patch to the StatusBot instead of the bug_id.
491 - Let WorkQueues have a name.
493 2009-11-20 Adam Barth <abarth@webkit.org>
495 Reviewed by Eric Seidel.
497 Move bugzilla-tool commands into their own file
498 https://bugs.webkit.org/show_bug.cgi?id=31752
500 This will let us write unit tests.
502 * Scripts/bugzilla-tool:
503 * Scripts/modules/commands/__init__.py: Added.
504 * Scripts/modules/commands/download.py: Added.
505 * Scripts/modules/commands/queries.py: Added.
506 * Scripts/modules/commands/queues.py: Added.
507 * Scripts/modules/commands/upload.py: Added.
508 * Scripts/modules/grammar.py: Added.
510 2009-11-20 Adam Barth <abarth@webkit.org>
512 Reviewed by Eric Seidel.
514 BuildQueue should check if the tree is currently buildable
515 https://bugs.webkit.org/show_bug.cgi?id=31744
517 * Scripts/bugzilla-tool:
518 * Scripts/modules/landingsequence.py:
519 * Scripts/modules/webkitlandingscripts.py:
521 2009-11-20 Adam Barth <abarth@webkit.org>
523 Reviewed by Eric Seidel.
525 Move prepare_clean_working_directory into the LandingSequence
526 https://bugs.webkit.org/show_bug.cgi?id=31743
528 * Scripts/bugzilla-tool:
529 * Scripts/modules/landingsequence.py:
531 2009-11-20 Yael Aharon <yael.aharon@nokia.com>
533 Reviewed by Kenneth Rohde Christiansen.
535 NPN_ReloadPlugins does not reload the page even if reloadPages is true.
536 https://bugs.webkit.org/show_bug.cgi?id=30460
538 Added code for calling NPN_ReloadPlugins with reloadPages true and false.
540 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
543 2009-11-20 Adam Barth <abarth@webkit.org>
545 Reviewed by Eric Seidel.
547 Pass the port information to the child process
548 https://bugs.webkit.org/show_bug.cgi?id=31736
550 We need to do this so the child process knows what to build!
552 * Scripts/bugzilla-tool:
553 * Scripts/modules/landingsequence.py:
554 * Scripts/modules/webkitport.py:
555 * Scripts/modules/webkitport_unittest.py:
557 2009-11-20 Adam Barth <abarth@webkit.org>
559 Reviewed by Eric Seidel.
561 Support Qt port in build-queue
562 https://bugs.webkit.org/show_bug.cgi?id=31733
564 * Scripts/bugzilla-tool:
566 2009-11-20 Adam Barth <abarth@webkit.org>
568 Reviewed by Eric Seidel.
570 Implement a build-queue
571 https://bugs.webkit.org/show_bug.cgi?id=31725
573 Currently this just builds the first 10 patches in the review queue.
574 We'll want to do something smarter soon.
576 * Scripts/bugzilla-tool:
578 2009-11-20 Adam Barth <abarth@webkit.org>
580 Reviewed by Eric Seidel.
582 Make commit-queue and style-queue show up in help
583 https://bugs.webkit.org/show_bug.cgi?id=31724
585 We need to store their names on their class to make these commands
586 properly register themselves with MultiCommandTool.
588 * Scripts/bugzilla-tool:
590 2009-11-20 Adam Barth <abarth@webkit.org>
592 Reviewed by Eric Seidel.
594 Implement bugzilla-tool build-attachment
595 https://bugs.webkit.org/show_bug.cgi?id=31722
597 This command builds an attachment from bugzilla. It leaves the built
598 patch in the working copy.
600 * Scripts/bugzilla-tool:
601 * Scripts/modules/landingsequence.py:
602 * Scripts/modules/webkitlandingscripts.py:
604 2009-11-20 Alejandro G. Castro <alex@igalia.com>
606 Reviewed by Xan Lopez.
608 [GTK] DRT release event does not create the state correctly
609 https://bugs.webkit.org/show_bug.cgi?id=31717
611 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
613 2009-11-20 Eric Seidel <eric@webkit.org>
615 Reviewed by Adam Barth.
617 MultiCommandTool should find Command objects automatically instead of with a manual list
618 https://bugs.webkit.org/show_bug.cgi?id=31710
620 * Scripts/bugzilla-tool:
621 * Scripts/modules/multicommandtool.py:
622 - Use some wild python-fu to crawl all the known subclasses of Command.
624 2009-11-20 Adam Barth <abarth@webkit.org>
626 Unreviewed "build" fix. Added missing import.
628 * Scripts/bugzilla-tool:
630 2009-11-20 Adam Barth <abarth@webkit.org>
632 Unreviewed "build" fix. I failed to update LandingSequence.test
635 * Scripts/modules/landingsequence.py:
637 2009-11-20 Adam Barth <abarth@webkit.org>
639 Reviewed by Eric Seidel.
641 Create LandingSequence as the all-sing, all-dance landing class
642 https://bugs.webkit.org/show_bug.cgi?id=31709
644 Client can inherit from this class to carefully control exactly which
645 steps they wish to have happen in the landing sequence.
647 * Scripts/bugzilla-tool:
648 * Scripts/modules/landingsequence.py: Added.
649 * Scripts/modules/webkitlandingscripts.py: Added.
651 2009-11-19 Adam Barth <abarth@webkit.org>
653 Reviewed by Eric Seidel.
655 Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
656 https://bugs.webkit.org/show_bug.cgi?id=31707
658 This is to help when we implement build-attachment.
660 * Scripts/bugzilla-tool:
662 2009-11-19 Adam Barth <abarth@webkit.org>
664 Reviewed by Eric Seidel.
666 Support Qt port in bugzilla-tool
667 https://bugs.webkit.org/show_bug.cgi?id=31701
669 Now we support building with Qt!
671 * Scripts/bugzilla-tool:
672 * Scripts/modules/webkitport.py: Added.
673 * Scripts/modules/webkitport_unittest.py: Added.
674 * Scripts/run-webkit-unittests:
676 2009-11-19 Zoltan Horvath <zoltan@webkit.org>
678 Reviewed by Adam Barth.
680 Remove inserting stderr into patch in bugzilla-tool
681 https://bugs.webkit.org/show_bug.cgi?id=29914
683 Modify SCM python module's run_command function to avoid return of stderr
684 by default, so stderr won't be inserted into the patches.
685 Modify the related unit test.
687 * Scripts/modules/scm.py:
688 * Scripts/modules/scm_unittest.py:
690 2009-11-19 Eric Seidel <eric@webkit.org>
692 Reviewed by Adam Barth.
694 bugzilla-tool needs per-command help
695 https://bugs.webkit.org/show_bug.cgi?id=31697
697 Added support for "bugzilla-tool help command-name"
698 and a unit test to make sure it works.
700 * Scripts/modules/multicommandtool.py:
701 * Scripts/modules/multicommandtool_unittest.py:
703 2009-11-19 Eric Seidel <eric@webkit.org>
705 Reviewed by Adam Barth.
707 Move MultiCommandTool and Command into a separate file and add some basic unit tests
708 https://bugs.webkit.org/show_bug.cgi?id=31695
710 * Scripts/bugzilla-tool:
711 * Scripts/modules/multicommandtool.py: Added.
712 * Scripts/modules/multicommandtool_unittest.py: Added.
713 * Scripts/run-webkit-unittests:
715 2009-11-19 Eric Seidel <eric@webkit.org>
717 No review, just adding a FIXME.
719 Split out command parsing and help printing from BugzillaTool
720 https://bugs.webkit.org/show_bug.cgi?id=31688
722 * Scripts/bugzilla-tool: Add an extra comment about current design failures.
724 2009-11-19 Eric Seidel <eric@webkit.org>
726 Reviewed by Adam Barth.
728 Split out command parsing and help printing from BugzillaTool
729 https://bugs.webkit.org/show_bug.cgi?id=31688
731 * Scripts/bugzilla-tool:
732 - Add new MultiCommandTool class to contain option parsing and help printing logic.
733 - Rename private methods to use _ pattern.
734 - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
737 2009-11-19 Eric Seidel <eric@webkit.org>
739 Reviewed by Adam Barth.
741 Re-factor help printing to use modern python idioms
742 https://bugs.webkit.org/show_bug.cgi?id=31685
744 * Scripts/bugzilla-tool:
746 2009-11-19 Eric Seidel <eric@webkit.org>
748 Reviewed by Darin Adler.
750 commit-queue empty queue logs twice
751 https://bugs.webkit.org/show_bug.cgi?id=31679
753 * Scripts/bugzilla-tool:
755 2009-11-19 Eric Seidel <eric@webkit.org>
757 Reviewed by Darin Adler.
759 bugzilla-tool's reviewer/committer rejection message should be clearer
760 https://bugs.webkit.org/show_bug.cgi?id=31126
762 Add more explanatory prose to bugzilla-tool's flag permission rejection message.
764 * Scripts/modules/bugzilla.py:
766 2009-11-19 Eric Z. Ayers <zundel@google.com>
768 Reviewed by Pavel Feldman.
770 Forces a WM_PAINT event on calling layoutTestController.display()
771 in order to enable the timeline-paint.html test on Windows.
772 ::UpdateWindow() does not force an event becaue the window is
775 https://bugs.webkit.org/show_bug.cgi?id=31402
777 * DumpRenderTree/win/DumpRenderTree.cpp:
780 2009-11-19 Michelangelo De Simone <michelangelo@webkit.org>
784 Added myself to committers list.
786 * Scripts/modules/committers.py:
788 2009-11-19 Adam Barth <abarth@webkit.org>
790 Reviewed by Eric Seidel.
792 Bugzilla-tool command classes should match command names
793 https://bugs.webkit.org/show_bug.cgi?id=31666
795 I renamed all the commands except CommitMessageForCurrentDiff because
796 the new name would conflict with an existing class.
798 * Scripts/bugzilla-tool:
800 2009-11-19 Pavel Feldman <pfeldman@chromium.org>
802 Reviewed by Gustavo Noronha Silva.
804 Web Inspector: Implement "show inspector" in WebKit GTK
805 API and enable console tests.
807 https://bugs.webkit.org/show_bug.cgi?id=31669
809 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
810 (LayoutTestController::showWebInspector):
812 2009-11-19 Kenneth Rohde Christiansen <kenneth@webkit.org>
814 Reviewed by Simon Hausmann.
816 Minor refactoring + more documentation.
818 * DumpRenderTree/qt/DumpRenderTree.cpp:
819 (WebCore::clearHistory):
820 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
822 2009-11-19 Fumitoshi Ukai <ukai@chromium.org>
824 Reviewed by Eric Seidel.
826 Ignore websocket tests when --no-http is specified.
827 https://bugs.webkit.org/show_bug.cgi?id=31662
829 * Scripts/run-webkit-tests:
831 2009-11-18 Adam Barth <abarth@webkit.org>
833 Reviewed by Eric Seidel.
835 Normalize ' and " in bugzilla-tool
836 https://bugs.webkit.org/show_bug.cgi?id=31655
838 We decided " is better than ' and we should be consistent.
840 * Scripts/bugzilla-tool:
842 2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
844 Reviewed by Kenneth Rohde Christiansen.
846 [Qt] Remove support for Qt v4.3 or older versions
847 https://bugs.webkit.org/show_bug.cgi?id=29469
849 * DumpRenderTree/qt/DumpRenderTree.pro:
850 * DumpRenderTree/qt/ImageDiff.pro:
852 2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>
854 Reviewed by Eric Seidel.
856 GitTest.test_create_binary_patch fails if /tmp is symlink
857 https://bugs.webkit.org/show_bug.cgi?id=31536
859 * Scripts/modules/scm_unittest.py:
861 2009-11-18 Yaar Schnitman <yaar@chromium.org>
863 Reviewed by Darin Adler.
865 Configuration for Chromium Build Slaves.
867 https://bugs.webkit.org/show_bug.cgi?id=31442
869 * BuildSlaveSupport/build.webkit.org-config/config.json:
870 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
872 2009-11-18 Eric Seidel <eric@webkit.org>
874 Reviewed by Darin Adler.
876 workqueue.py results in totally broken commit-queue UI
877 https://bugs.webkit.org/show_bug.cgi?id=31645
879 * Scripts/bugzilla-tool:
880 - Remove unneeded use of PatchCollection.
881 - Grab a new copy of the cq'd patches every run of the queue.
883 2009-11-18 Sam Weinig <sam@webkit.org>
885 Reviewed by Anders Carlsson.
887 Make the Mac Geolocation API async.
889 Update DRT to use the new async Mac Geolocation API.
891 * DumpRenderTree/mac/UIDelegate.mm:
892 (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
894 2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
896 Reviewed by Kenneth Rohde Christiansen.
898 Add and option to toggle HTML5 datalist support to build-webkit
899 https://bugs.webkit.org/show_bug.cgi?id=31599
901 * Scripts/build-webkit:
903 2009-11-18 Kevin Watters <kevinwatters@gmail.com>
905 Reviewed by Kevin Ollivier.
907 Enable wx plugin support using the Windows implementation as a base.
909 https://bugs.webkit.org/show_bug.cgi?id=31636
911 * wx/build/settings.py:
913 2009-11-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
915 Reviewed by Simon Hausmann.
917 Change the initialization order so that the controllers
918 will be created before exporting them to the JS DOM window.
920 * DumpRenderTree/qt/DumpRenderTree.cpp:
921 (WebCore::DumpRenderTree::DumpRenderTree):
923 2009-11-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
925 Reviewed by Simon Hausmann.
927 Fix a code copy and paste error. m_page should be page.
929 * DumpRenderTree/qt/DumpRenderTree.cpp:
930 (WebCore::DumpRenderTree::createWindow):
932 2009-11-17 Mark Rowe <mrowe@apple.com>
934 Reviewed by Alexey Proskuryakov.
936 <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
938 * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
939 This prevents symlinks from confusing the descendant check.
941 2009-11-17 Mark Rowe <mrowe@apple.com>
943 Reviewed by Alexey Proskuryakov.
945 <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
947 If the WebSocket server fails to start have DRT load an error page in place of tests that require the
948 server to be up rather than having run-webkit-tests abort immediately.
950 * Scripts/run-webkit-tests:
952 2009-11-17 Eric Seidel <eric@webkit.org>
954 Reviewed by Darin Adler.
956 commit-queue is failing to set reviewer in ChangeLogs
957 https://bugs.webkit.org/show_bug.cgi?id=31592
959 * Scripts/bugzilla-tool: Clarify the "applying" log message.
960 * Scripts/modules/bugzilla.py:
961 - Add a new _validate_committer_and_reviewer function as a
962 temporary solution until we can make a real Attachment object
963 which knows how to fill in its committer/reviewer fields automatically.
965 2009-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
967 Unreviewed buildbot fix.
969 Revert part of earlier patch and add comment, as it
970 was causing timeouts on the buildbot.
972 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
973 (LayoutTestController::notifyDone):
975 2009-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
977 Reviewed by Oliver Hunt.
979 Make the timeout 15 sec as for the other DRT's and make
980 it print out the same output when a test timeout.
982 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
983 (LayoutTestController::waitUntilDone):
984 (LayoutTestController::notifyDone):
985 (LayoutTestController::timerEvent):
987 2009-11-17 Joseph Pecoraro <joepeck@webkit.org>
989 Reviewed by Timothy Hatcher.
991 Fixed typos in comments.
993 * Scripts/modules/committers.py:
995 2009-11-17 Pavel Feldman <pfeldman@chromium.org>
997 Reviewed by Timothy Hatcher.
999 Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1000 - Updated DRT to show/close inspector for all tests under /inspector
1001 - Introduced LayoutTestController::setTimelineProfilingEnabled and
1002 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1003 - Removed reload on each inspector test
1004 - Renamed fast/inspector to fast/inspector-support in order not to trigger
1005 inspector for those.
1006 - Reimplemented timeline tests in order to get rid of reload there.
1007 - Moved tests that don't require harness into the fast group.
1009 https://bugs.webkit.org/show_bug.cgi?id=31472
1011 * DumpRenderTree/LayoutTestController.cpp:
1012 (setTimelineProfilingEnabledCallback):
1013 (closeWebInspectorCallback):
1014 (LayoutTestController::staticFunctions):
1015 * DumpRenderTree/LayoutTestController.h:
1016 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1017 (shouldOpenWebInspector):
1019 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1020 (LayoutTestController::setTimelineProfilingEnabled):
1021 * DumpRenderTree/mac/DumpRenderTree.mm:
1022 (shouldOpenWebInspector):
1024 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1025 (LayoutTestController::setTimelineProfilingEnabled):
1026 * DumpRenderTree/win/DumpRenderTree.cpp:
1027 (shouldOpenWebInspector):
1029 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1030 (LayoutTestController::setTimelineProfilingEnabled):
1032 2009-11-17 Oliver Hunt <oliver@apple.com>
1034 Reviewed by Maciej Stachowiak.
1036 Incorrect use of JavaScriptCore API in DumpRenderTree
1037 https://bugs.webkit.org/show_bug.cgi?id=31577
1039 Return undefined rather than a literal null.
1041 * DumpRenderTree/AccessibilityUIElement.cpp:
1042 (setSelectedTextRangeCallback):
1043 (incrementCallback):
1044 (decrementCallback):
1047 2009-11-16 Chris Fleizach <cfleizach@apple.com>
1049 Reviewed by Beth Dakin.
1051 AX: aria-labelledby duplicates some of its WAI-ARIA label
1052 https://bugs.webkit.org/show_bug.cgi?id=31565
1054 * DumpRenderTree/AccessibilityUIElement.cpp:
1055 (titleUIElementCallback):
1056 (getIsValidCallback):
1057 (AccessibilityUIElement::getJSClass):
1059 2009-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>
1061 Reviewed by Simon Hausmann.
1063 r50942 broke output from created windows. Make the
1064 m_enableTextOutput a member of the DRT and not the
1067 * DumpRenderTree/qt/DumpRenderTree.cpp:
1068 (WebCore::WebPage::WebPage):
1069 (WebCore::WebPage::javaScriptAlert):
1070 (WebCore::WebPage::javaScriptConsoleMessage):
1071 (WebCore::WebPage::javaScriptConfirm):
1072 (WebCore::WebPage::javaScriptPrompt):
1073 (WebCore::WebPage::acceptNavigationRequest):
1074 (WebCore::DumpRenderTree::DumpRenderTree):
1075 (WebCore::DumpRenderTree::open):
1076 (WebCore::DumpRenderTree::createWindow):
1077 * DumpRenderTree/qt/DumpRenderTree.h:
1078 (WebCore::DumpRenderTree::setTextOutputEnabled):
1079 (WebCore::DumpRenderTree::isTextOutputEnabled):
1080 (WebCore::WebPage::shouldInterruptJavaScript):
1081 (WebCore::WebPage::isTextOutputEnabled):
1082 (WebCore::WebPage::setViewGeometry):
1084 2009-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>
1086 Reviewed by Gustavo Noronha Silva.
1088 Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1089 as the implementation is being used by at least Qt and Gtk+.
1091 Update buildsystems as well.
1093 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1094 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1095 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1096 * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1097 * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1100 2009-11-16 Yuzo Fujishima <yuzo@google.com>
1102 Reviewed by Alexey Proskuryakov.
1104 Disable wss until all platforms support pyOpenSSL
1106 https://bugs.webkit.org/show_bug.cgi?id=31479
1108 * Scripts/run-webkit-tests:
1110 2009-11-14 Antonio Gomes <tonikitoo@webkit.org>
1112 Reviewed by Kenneth Christiansen.
1114 [Qt] Implement load error pages support for Qt's DRT.
1115 https://bugs.webkit.org/show_bug.cgi?id=31509
1117 For now, it will not be a default feature, and layout tests
1118 that want to make use of this have to explicitily call
1119 'handleErrorPages();' for the test source.
1121 Any of the other DumpRenderTree's (mac, win and gtk)
1122 support handling error pages. Qt's will be the first.
1124 * DumpRenderTree/qt/DumpRenderTree.cpp:
1125 (WebCore::WebPage::supportsExtension):
1126 (WebCore::WebPage::extension):
1127 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1128 (LayoutTestController::reset):
1129 * DumpRenderTree/qt/LayoutTestControllerQt.h:
1130 (LayoutTestController::shouldHandleErrorPages):
1131 (LayoutTestController::handleErrorPages):
1133 2009-11-16 Eric Seidel <eric@webkit.org>
1135 Reviewed by Adam Barth.
1137 Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1138 https://bugs.webkit.org/show_bug.cgi?id=31549
1140 Renamed --commit-queue to --non-interactive in most places
1141 and remove the code in land-patches which is no longer needed.
1143 * Scripts/bugzilla-tool:
1145 2009-11-16 Eric Seidel <eric@webkit.org>
1147 Reviewed by Adam Barth.
1149 The commit-queue should use land-attachment
1150 https://bugs.webkit.org/show_bug.cgi?id=31548
1152 * Scripts/bugzilla-tool:
1154 2009-11-16 Adam Barth <abarth@webkit.org>
1156 Reviewed by Eric Seidel.
1158 Convert CommitQueue over to PatchCollection
1159 https://bugs.webkit.org/show_bug.cgi?id=31547
1161 Also fixes a bug in workqueue and adds a test!
1163 * Scripts/bugzilla-tool:
1164 * Scripts/modules/workqueue.py:
1165 * Scripts/modules/workqueue_unittest.py:
1167 2009-11-16 Adam Barth <abarth@webkit.org>
1169 Reviewed by Eric Seidel.
1171 Move StyleQueue over to using PatchCollection
1172 https://bugs.webkit.org/show_bug.cgi?id=31544
1174 That's what the class it's for.
1176 * Scripts/bugzilla-tool:
1177 * Scripts/modules/patchcollection.py:
1178 * Scripts/modules/patchcollection_unittest.py:
1180 2009-11-16 Eric Seidel <eric@webkit.org>
1182 Reviewed by Adam Barth.
1184 bugzilla-tool needs a land-attachment command
1185 https://bugs.webkit.org/show_bug.cgi?id=31546
1187 * Scripts/bugzilla-tool:
1188 - Move all the logic into AbstractLandingCommand and
1189 add a new LandAttachment command subclass.
1190 - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1192 2009-11-16 Eric Seidel <eric@webkit.org>
1194 Reviewed by Adam Barth.
1196 Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1197 https://bugs.webkit.org/show_bug.cgi?id=31543
1199 Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1201 * Scripts/bugzilla-tool:
1203 2009-11-16 Eric Seidel <eric@webkit.org>
1205 Reviewed by Adam Barth.
1207 Disable the style queue from posting to the commit queue status page.
1209 * Scripts/bugzilla-tool:
1211 2009-11-16 Adam Barth <abarth@webkit.org>
1213 Reviewed by Eric Seidel.
1215 Implement PatchCollection
1216 https://bugs.webkit.org/show_bug.cgi?id=31541
1218 This class holds a set of patches and lets clients iterate through
1219 them. Optionally, clients can install a filter.
1221 * Scripts/modules/patchcollection.py: Added.
1222 * Scripts/modules/patchcollection_unittest.py: Added.
1223 * Scripts/run-webkit-unittests:
1225 2009-11-16 Eric Seidel <eric@webkit.org>
1227 Reviewed by Adam Barth.
1229 bugzilla-tool land-patches will close bugs with patches r=?
1230 https://bugs.webkit.org/show_bug.cgi?id=28230
1232 The commit-queue shouldn't close patches with outstanding reviews on them,
1233 even if many reviewers seem to be against multi-patch bugs.
1235 * Scripts/bugzilla-tool:
1237 2009-11-16 Eric Seidel <eric@webkit.org>
1239 Reviewed by Adam Barth.
1241 bugzilla-tool check-style should work with attachment ids instead of bug ids
1242 https://bugs.webkit.org/show_bug.cgi?id=31540
1244 * Scripts/bugzilla-tool:
1246 2009-11-16 Eric Seidel <eric@webkit.org>
1248 Reviewed by Adam Barth.
1250 WorkQueue is the only place that should know about special exit codes
1251 https://bugs.webkit.org/show_bug.cgi?id=31534
1253 Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1254 and add tests for handling exit codes.
1255 I also cleaned up workqueue_unittest.py more.
1257 * Scripts/bugzilla-tool:
1258 * Scripts/modules/workqueue.py:
1259 * Scripts/modules/workqueue_unittest.py:
1261 2009-11-16 Eric Seidel <eric@webkit.org>
1263 Reviewed by Adam Barth.
1265 Re-factor workqueue_unittest to allow for more than one test.
1266 https://bugs.webkit.org/show_bug.cgi?id=31535
1268 * Scripts/modules/workqueue_unittest.py:
1270 2009-11-16 Eric Seidel <eric@webkit.org>
1272 Reviewed by Adam Barth.
1274 land-patches needs to be re-factored into smaller chunks
1275 https://bugs.webkit.org/show_bug.cgi?id=31532
1277 * Scripts/bugzilla-tool: fix a couple obvious typos.
1279 2009-11-16 Eric Seidel <eric@webkit.org>
1281 Reviewed by Adam Barth.
1283 land-patches needs to be re-factored into smaller chunks
1284 https://bugs.webkit.org/show_bug.cgi?id=31532
1286 The next patch will move these methods into WebKitLandingScripts.
1288 * Scripts/bugzilla-tool:
1289 - Split out _land_patch and _close_bug_if_no_active_patches.
1291 2009-11-16 Adam Barth <abarth@webkit.org>
1293 Reviewed by Eric Seidel.
1295 Fix silly copy-and-paste code. I am a terrible coder.
1297 * Scripts/modules/bugzilla.py:
1299 2009-11-16 Adam Barth <abarth@webkit.org>
1301 Reviewed by Eric Seidel.
1303 Implement a StyleQueue
1304 https://bugs.webkit.org/show_bug.cgi?id=31537
1306 The first iteration of the style queue only produces output locally.
1307 There is also a limit of 10 patches because it's not that useful to
1308 iterate through the entire review queue at this point. We can remove
1311 * Scripts/bugzilla-tool:
1312 * Scripts/modules/bugzilla.py:
1314 2009-11-16 Adam Barth <abarth@webkit.org>
1316 Reviewed by Eric Seidel.
1319 https://bugs.webkit.org/show_bug.cgi?id=31531
1321 Adds basic unit testing for WorkQueue. Just runs through one cycle.
1323 * Scripts/bugzilla-tool:
1324 * Scripts/modules/statusbot.py:
1325 * Scripts/modules/workqueue.py:
1326 * Scripts/modules/workqueue_unittest.py: Added.
1327 * Scripts/run-webkit-unittests:
1329 2009-11-16 Eric Seidel <eric@webkit.org>
1331 Reviewed by Adam Barth.
1333 bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1334 https://bugs.webkit.org/show_bug.cgi?id=31530
1336 * Scripts/bugzilla-tool:
1338 2009-11-16 Eric Seidel <eric@webkit.org>
1340 Reviewed by Adam Barth.
1342 bugzilla-tool needs apply-attachment
1343 https://bugs.webkit.org/show_bug.cgi?id=31528
1345 * Scripts/bugzilla-tool:
1346 - Add ApplyAttachment command.
1347 - Abstract applying code into WebKitApplyingScripts.
1348 - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1349 * Scripts/modules/bugzilla.py:
1350 - Add fetch_attachment and bug_id_for_attachment_id.
1351 * Scripts/modules/bugzilla_unittest.py:
1352 - Add test for new parsing.
1353 - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1355 2009-11-16 Eric Seidel <eric@webkit.org>
1357 Reviewed by Adam Barth.
1359 Document check-style's use of force_clean.
1361 * Scripts/bugzilla-tool:
1362 * Scripts/modules/scm.py:
1364 2009-11-16 Adam Barth <abarth@webkit.org>
1366 Reviewed by Eric Seidel.
1368 Move WorkQueue to its own file
1369 https://bugs.webkit.org/show_bug.cgi?id=31529
1371 WorkQueue and WorkQueueDelegate are separate concerns from
1372 bugzilla-tool. Also added a missing include to logging.py.
1374 * Scripts/bugzilla-tool:
1375 * Scripts/modules/logging.py:
1376 * Scripts/modules/workqueue.py:
1378 2009-11-16 Adam Barth <abarth@webkit.org>
1380 Reviewed by Eric Seidel.
1382 Move OutputTee to logging.py.
1384 * Scripts/bugzilla-tool:
1385 * Scripts/modules/logging.py:
1387 2009-11-15 Adam Barth <abarth@webkit.org>
1389 Reviewed by Eric Seidel.
1391 Refactor bugzilla-tool to allow for multiple queues
1392 https://bugs.webkit.org/show_bug.cgi?id=31513
1394 Divide the commit queue class into three class to make creating
1395 additional queues easier.
1397 * Scripts/bugzilla-tool:
1399 2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>
1401 Reviewed by Eric Seidel.
1403 svn-apply may not handle git patches created by bugzilla-tool
1404 https://bugs.webkit.org/show_bug.cgi?id=31457
1406 * Scripts/modules/scm.py:
1407 * Scripts/modules/scm_unittest.py:
1409 2009-11-15 Shinichiro Hamaji <hamaji@chromium.org>
1411 Reviewed by Eric Seidel.
1413 bugzilla-tool should post git binary diff
1414 https://bugs.webkit.org/show_bug.cgi?id=31458
1416 Add --binary option to Git.create_patch.
1418 * Scripts/modules/scm.py:
1419 * Scripts/modules/scm_unittest.py:
1421 2009-11-15 Adam Barth <abarth@webkit.org>
1423 Reviewed by Darin Adler.
1425 Add bugzilla-tool check-style
1426 https://bugs.webkit.org/show_bug.cgi?id=31515
1428 * Scripts/bugzilla-tool:
1429 * Scripts/modules/bugzilla.py:
1431 2009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
1433 Reviewed by Simon Hausmann.
1435 Make the Qt Linux only --valgrind feature, suppress errors
1436 defined in the SuppressedValgrindErrors file.
1438 * Scripts/run-webkit-tests:
1440 2009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
1442 Reviewed by Simon Hausmann.
1444 Set the locale to C and not to the current one in use on the system.
1446 * DumpRenderTree/qt/DumpRenderTree.cpp:
1447 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1449 2009-11-13 Adam Roben <aroben@apple.com>
1452 http/tests/security/isolatedWorld/didClearWindowObject.html
1454 Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1455 window objects in isolated worlds are cleared
1457 Reviewed by Dave Hyatt.
1459 * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1461 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1462 (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1463 Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1464 (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1465 Added. Sets a __worldID property on the global object whose value is
1466 the ID of this world.
1467 (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1468 Respond to this new delegate callback by calling through to one of the
1470 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1471 (worldMap): Added. Returns a HashMap containing all the worlds we've
1473 (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1474 haven't kept track of this world.
1475 (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1476 instead of declaring our own.
1478 * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1480 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1481 (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1482 didClearWindowObjectForFrameInStandardWorld.
1483 (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1484 Respond to this new delegate callback by calling through to one of the
1486 (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1487 Added. Sets a __worldID property on the gobal object whose value is
1488 the ID of this world.
1489 (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1490 Added. Moved code here from didClearWindowObject.
1492 * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1493 didClearWindowObjectForFrame* functions.
1495 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1496 (worldMap): Added. Returns a HashMap containing all the worlds we've
1498 (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1499 haven't kept track of this world.
1500 (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1501 instead of declaring our own.
1503 2009-11-13 Adam Roben <aroben@apple.com>
1505 Finish replacing worldIDs with world objects
1507 The only remaining use of worldIDs was in a method only used by DRT
1508 for the isolated worlds tests.
1510 Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1512 Reviewed by Mark Rowe.
1514 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1515 (LayoutTestController::evaluateScriptInIsolatedWorld):
1516 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1517 (LayoutTestController::evaluateScriptInIsolatedWorld):
1518 Updated for changes to WebFrame. Now holds the map of worldID -> world
1519 at this level instead of making WebKit do it.
1521 2009-11-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1523 Reviewed by Simon Hausmann.
1525 [Qt] Ensure the DRT does not output anything until first test is run
1527 * DumpRenderTree/qt/DumpRenderTree.cpp:
1528 * DumpRenderTree/qt/DumpRenderTree.h:
1530 2009-11-13 Kenneth Rohde Christiansen <kenneth@webkit.org>
1532 Reviewed by Tor Arne Vestbø.
1534 Clear the undo stack in before each new test run.
1536 Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1538 * DumpRenderTree/qt/DumpRenderTree.cpp:
1539 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1541 2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
1543 Reviewed by Kenneth Rohde Christiansen.
1545 [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1547 * DumpRenderTree/qt/DumpRenderTree.cpp:
1548 (WebCore::WebPage::resetSettings):
1549 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1550 (LayoutTestController::overridePreference):
1552 2009-11-13 Eric Seidel <eric@webkit.org>
1554 Reviewed by Adam Barth.
1556 Update committers.py based on svn records
1557 https://bugs.webkit.org/show_bug.cgi?id=31366
1559 This list was generated using validate-committer-lists from
1560 https://bugs.webkit.org/show_bug.cgi?id=30970
1561 and makes committers.py current for committers who have
1562 committed in the last 3 years.
1564 * Scripts/modules/committers.py:
1566 2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>
1568 Reviewed by Adam Barth.
1570 The document-open.html test was flaky at times. The test invokes the layout test plugin
1571 which in its destroy stream handler opens a new document. This basically tears down the
1572 stream and the associated plugin instance. The pluginLog function in the layout test
1573 plugin attempts to retrieve the window script object on a torn down plugin instance
1574 which crashed consistently on windows in the debugger. The functions which issue
1575 these logs already have a valid window script object. We now have variants of the pluginLog
1576 function which take in a window script object with and without variable arguments.
1578 https://bugs.webkit.org/show_bug.cgi?id=31067
1580 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1581 (pluginLogWithWindowObject):
1582 (pluginLogWithWindowObjectVariableArgs):
1584 (notifyTestCompletion):
1588 2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>
1590 Reviewed by Gustavo Noronha Silva.
1592 https://bugs.webkit.org/show_bug.cgi?id=30997
1593 [Gtk] Implemment AtkDocument
1595 Added testing support.
1597 * DumpRenderTree/AccessibilityUIElement.cpp:
1598 * DumpRenderTree/AccessibilityUIElement.h:
1599 (getDocumentEncodingCallback):
1600 (getDocumentURICallback):
1601 (AccessibilityUIElement::getJSClass):
1602 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1603 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1604 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1605 (AccessibilityUIElement::documentEncoding):
1606 (AccessibilityUIElement::documentURI):
1608 2009-11-12 Adam Roben <aroben@apple.com>
1610 Replace worldIDs with world objects
1612 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1613 user scripts/stylesheets and isolated worlds
1615 Reviewed by Sam Weinig.
1617 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1618 (LayoutTestController::addUserScript):
1619 (LayoutTestController::addUserStyleSheet):
1620 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1621 (LayoutTestController::addUserScript):
1622 (LayoutTestController::addUserStyleSheet):
1623 Changed these functions to create a new WebJSWorld each time they're
1624 called and to pass that world to WebKit.
1626 2009-11-11 Chris Fleizach <cfleizach@apple.com>
1628 Reviewed by Oliver Hunt.
1630 need to implement aria tree roles
1631 https://bugs.webkit.org/show_bug.cgi?id=31284
1633 * DumpRenderTree/AccessibilityUIElement.cpp:
1634 (disclosedRowAtIndexCallback):
1635 (selectedRowAtIndexCallback):
1637 (isAttributeSettableCallback):
1638 (isActionSupportedCallback):
1639 (disclosedByRowCallback):
1640 (hierarchicalLevelCallback):
1641 (AccessibilityUIElement::getJSClass):
1642 * DumpRenderTree/AccessibilityUIElement.h:
1643 (AccessibilityUIElement::isEqual):
1644 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1645 (AccessibilityUIElement::hierarchicalLevel):
1646 (AccessibilityUIElement::disclosedRowAtIndex):
1647 (AccessibilityUIElement::selectedRowAtIndex):
1648 (AccessibilityUIElement::disclosedByRow):
1649 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1650 (AccessibilityUIElement::getChildAtIndex):
1651 (AccessibilityUIElement::disclosedRowAtIndex):
1652 (AccessibilityUIElement::selectedRowAtIndex):
1653 (AccessibilityUIElement::titleUIElement):
1654 (AccessibilityUIElement::parentElement):
1655 (AccessibilityUIElement::disclosedByRow):
1656 (AccessibilityUIElement::hierarchicalLevel):
1657 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1658 (AccessibilityUIElement::hierarchicalLevel):
1659 (AccessibilityUIElement::disclosedRowAtIndex):
1660 (AccessibilityUIElement::selectedRowAtIndex):
1661 (AccessibilityUIElement::disclosedByRow):
1663 2009-11-11 Shinichiro Hamaji <hamaji@chromium.org>
1665 Reviewed by Darin Adler.
1667 svn-apply can not handle git binary diffs
1668 https://bugs.webkit.org/show_bug.cgi?id=26830
1670 Support "literal" type git binary diffs.
1672 * Scripts/VCSUtils.pm:
1673 * Scripts/modules/scm_unittest.py:
1674 * Scripts/svn-apply:
1676 2009-11-11 Dmitry Titov <dimich@chromium.org>
1678 Not reviewed, removing duplicate entry for myself in committers.py.
1680 * Scripts/modules/committers.py:
1682 2009-11-11 Alexey Proskuryakov <ap@apple.com>
1684 Reviewed by Darin Adler and Mark Rowe.
1686 https://bugs.webkit.org/show_bug.cgi?id=31200
1687 Tests in http/tests/security/mixedContent start to fail when new tests are added
1689 * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1691 2009-11-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1693 Reviewed by Jan Alonzo.
1695 Create, and display a window for the inspector, for inspector
1698 Need to also show/hide the inspector window to avoid having
1699 problems with code assuming it is realized
1700 https://bugs.webkit.org/show_bug.cgi?id=31347
1702 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1703 (webInspectorShowWindow):
1704 (webInspectorCloseWindow):
1705 (webInspectorInspectWebView):
1708 2009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>
1710 Unreviewed Qt buildbot fix.
1712 My previous fix was wrong, so revert that change and fix it by
1713 returning when the document of the frame has no document element.
1714 Idea is borrowed from mac and win DRT.
1716 * DumpRenderTree/qt/DumpRenderTree.cpp:
1717 (WebCore::DumpRenderTree::dumpFramesAsText):
1719 2009-11-11 Eric Seidel <eric@webkit.org>
1721 Reviewed byg Kenneth Rohde Christiansen.
1723 Update Kenneth's committer record to include the email he
1724 uses on lists.webkit.org.
1726 * Scripts/modules/committers.py:
1728 2009-11-11 Eric Seidel <eric@webkit.org>
1730 Reviewed by Gustavo Noronha Silva.
1732 Several committers use separate email addresses for bugzilla and svn.webkit.org
1733 https://bugs.webkit.org/show_bug.cgi?id=31364
1735 Update records for existing committers to include email addresses
1736 used in svn.webkit.org and lists.webkit.org.
1737 Most committers use the same email address in all 3 places, but some use
1738 separate addresses. committers.py needs record of each of these addresses.
1740 * Scripts/modules/committers.py:
1742 2009-11-11 Eric Seidel <eric@webkit.org>
1744 No review, adding second email address for an existing committer.
1746 Add Yong Li's second bugzilla account to his committer record.
1747 See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1749 * Scripts/modules/committers.py:
1751 2009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>
1753 Reviewed by Simon Hausmann.
1755 If the frame has no innerText don't append it, and
1756 do not add a newline which breaks some cross platform
1759 * DumpRenderTree/qt/DumpRenderTree.cpp:
1760 (WebCore::DumpRenderTree::dumpFramesAsText):
1762 2009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>
1764 Reviewed by Simon Hausmann.
1766 Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1768 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1769 (webkit_test_plugin_new_instance):
1770 (webkit_test_plugin_destroy_instance):
1771 (webkit_test_plugin_destroy_stream):
1773 2009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>
1775 Reviewed by Mark Rowe.
1777 Implement the functionality needed by plugins/window-open.html
1779 * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1780 (webkit_test_plugin_new_instance):
1781 (webkit_test_plugin_set_window):
1783 2009-11-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1785 Reviewed by Simon Hausmann.
1787 [Qt] Force -graphicssystem raster and -style windows when running DRT
1789 * DumpRenderTree/qt/main.cpp:
1790 * Scripts/run-webkit-tests:
1792 2009-11-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1794 Reviewed by Simon Hausmann.
1796 Compute correct library paths for Qt
1798 * Scripts/webkitdirs.pm:
1800 2009-11-10 Mark Rowe <mrowe@apple.com>
1802 Reviewed by Sam Weinig.
1804 <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1806 The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1807 about the validity of the self-signed certificates used in the regression tests. We would then add the
1808 host to the ignore list for SSL certificate errors and retry the request. If this happened during a test
1809 that had enabled frame load delegate logging this would result in extra log messages being generated,
1810 causing the test to fail.
1812 We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1815 * DumpRenderTree/mac/DumpRenderTree.mm:
1817 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1818 (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1820 2009-11-10 Andras Becsi <becsi.andras@stud.u-szeged.hu>
1822 Reviewed by Kenneth Rohde Christiansen.
1824 [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1826 * DumpRenderTree/qt/DumpRenderTree.cpp:
1827 (WebCore::DumpRenderTree::DumpRenderTree):
1829 2009-11-10 Philippe Normand <pnormand@igalia.com>
1831 Reviewed by Jan Alonzo.
1833 [GTK] Remove WebSocket configuration from WebKitWebSettings
1834 https://bugs.webkit.org/show_bug.cgi?id=31244
1836 Follow-up of r50724. Don't set the enable-web-socket property
1839 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1840 (resetDefaultsToConsistentValues):
1842 2009-11-10 Oliver Hunt <oliver@apple.com>
1844 Reviewed by Maciej Stachowiak.
1846 Rename 3D Canvas related classes to use WebGL prefix
1847 https://bugs.webkit.org/show_bug.cgi?id=29095
1849 Checkin new version of do-webcore-rename used to do the WebGL type rename,
1850 and upate webkitdirs script to new method of testing for WebGL.
1852 * Scripts/do-webcore-rename:
1853 * Scripts/webkitdirs.pm:
1855 2009-11-09 Oliver Hunt <oliver@apple.com>
1857 Reviewed by Geoff Garen.
1859 Make do-webcore-rename work with git.
1861 * Scripts/do-webcore-rename:
1863 2009-11-09 Simon Hausmann <simon.hausmann@nokia.com>
1865 Adding Kenneth to the reviewers list.
1867 * Scripts/modules/committers.py:
1869 2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
1871 Reviewed by Jan Alonzo.
1873 [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1874 https://bugs.webkit.org/show_bug.cgi?id=30482
1876 LayoutTestControllerGtk now uses the exposed
1877 Page::tabKeyCyclesThroughElements API
1879 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1880 (LayoutTestController::setTabKeyCyclesThroughElements):
1882 2009-11-08 Shu Chang <Chang.Shu@nokia.com>
1884 Reviewed by Holger Freyther.
1886 [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1887 This helps to pass the test case below. Also replaced hardcoded
1888 code numbers with defined constants.
1889 https://bugs.webkit.org/show_bug.cgi?id=31185
1891 Test: editing/undo/undo-deleteWord.html
1893 * DumpRenderTree/qt/EventSenderQt.cpp:
1894 (EventSender::keyDown):
1896 2009-11-07 Antonio Gomes <tonikitoo@webkit.org>
1898 Reviewed by Holger Freyther.
1900 [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1901 https://bugs.webkit.org/show_bug.cgi?id=31164
1903 Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1905 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1906 (LayoutTestController::processWork):
1908 2009-11-05 Antonio Gomes <tonikitoo@webkit.org>
1910 Reviewed by Holger Freyther.
1912 [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1913 https://bugs.webkit.org/show_bug.cgi?id=31158
1915 By invoking a script queue'd by queueScript(), 'true' was beeing returned
1916 always, which from WorkQueue prospective means that a load has been started
1917 and the queue processing should stop and wait for the load to finish.
1918 Spinning it off into a loading and a non-loading variants was the solution
1919 adopted by Mac's DRT to work around this problem. The former keeps returning
1920 'true' while the later executes the script synchronously and returns 'false'
1921 making it possible to the WorkQueue to proceed right away.
1923 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1924 (LayoutTestController::processWork):
1925 (LayoutTestController::queueLoadingScript):
1926 (LayoutTestController::queueNonLoadingScript):
1927 * DumpRenderTree/qt/LayoutTestControllerQt.h:
1928 * DumpRenderTree/qt/WorkQueueItem.h:
1929 (LoadingScriptItem::LoadingScriptItem):
1930 (LoadingScriptItem::invoke):
1931 (NonLoadingScriptItem::NonLoadingScriptItem):
1932 (NonLoadingScriptItem::invoke):
1934 2009-11-07 Mark Rowe <mrowe@apple.com>
1936 Rubber-stamped by Cameron Zwarich.
1938 Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1940 * Scripts/commit-log-editor:
1942 2009-11-07 Mark Rowe <mrowe@apple.com>
1944 Reviewed by Darin Adler.
1946 Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1947 commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1949 Move logic for determining the name and email address to use in a ChangeLog entry from
1950 prepare-ChangeLog to VCSUtils so that commit-log-editor can use it. It wants to check
1951 whether the author of the patch matches committer, and therefore needs access to the
1952 email address that would be used in a ChangeLog entry.
1954 Based on a patch by Pierre d'Herbemont.
1956 * Scripts/VCSUtils.pm:
1957 * Scripts/commit-log-editor:
1958 * Scripts/prepare-ChangeLog:
1959 * Scripts/webkitdirs.pm:
1961 2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>
1963 Reviewed by Adam Barth.
1965 Added functionality to the layout test plugin to invoke document.open and
1966 window.open with default arguments. The associated webkit bug is
1967 https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1968 window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1969 work in Chromium (V8) if there is no calling javascript context. To achieve this
1970 effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1971 for the window.open test case and in NPP_DestroyStream for the document.open test case.
1973 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1977 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1978 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1981 (NPP_DestroyStream):
1982 * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1986 (NPP_DestroyStream):
1988 2009-11-06 Eric Seidel <eric@webkit.org>
1990 Reviewed by Adam Barth.
1992 bugzilla-tool crashed with exception
1993 https://bugs.webkit.org/show_bug.cgi?id=31092
1995 * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1997 2009-11-04 Eric Seidel <eric@webkit.org>
1999 No review, just add a line which got left out of the patch uploaded for commit.
2001 commit-queue is crashing when trying to reject patches after unknown failures
2002 https://bugs.webkit.org/show_bug.cgi?id=31091
2004 * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2006 2009-11-04 Adam Roben <aroben@apple.com>
2008 Remove bogus else clause in bugzilla-tool
2010 Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2011 create-bug raises exception after entering bug description
2013 Reviewed by David Kilzer.
2015 * Scripts/bugzilla-tool:
2016 (CreateBug): else clauses are only hit if no exception is raised, so
2017 it makes no sense to try to re-raise the exception in an else clause.
2018 The exception will automatically be re-raised if it doesn't match any
2019 of the except clauses, so we don't have to do anything special here at
2020 all to get the desired behavior.
2022 2009-11-04 Eric Seidel <eric@webkit.org>
2024 Reviewed by David Kilzer.
2026 svn-apply's fixChangeLogPatch function seems broken
2027 https://bugs.webkit.org/show_bug.cgi?id=30683
2029 Update fixChangeLogPatch to be able to handle patches which
2030 don't start at line 1.
2031 Add unit tests for svn-apply to scm_unittest.py.
2033 * Scripts/VCSUtils.pm:
2034 * Scripts/modules/scm_unittest.py:
2036 2009-11-04 Chris Fleizach <cfleizach@apple.com>
2038 Reviewed by Beth Dakin.
2040 Need to implement ARIA role="combobox"
2041 https://bugs.webkit.org/show_bug.cgi?id=31096
2043 * DumpRenderTree/AccessibilityUIElement.cpp:
2045 (getIsExpandedCallback):
2046 (AccessibilityUIElement::getJSClass):
2047 * DumpRenderTree/AccessibilityUIElement.h:
2048 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2049 (AccessibilityUIElement::isExpanded):
2050 (AccessibilityUIElement::showMenu):
2051 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2052 (AccessibilityUIElement::isExpanded):
2053 (AccessibilityUIElement::showMenu):
2054 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2055 (AccessibilityUIElement::isSelected):
2056 (AccessibilityUIElement::isExpanded):
2057 (AccessibilityUIElement::showMenu):
2059 2009-11-04 Eric Seidel <eric@webkit.org>
2061 Reviewed by Adam Barth.
2063 commit-queue is crashing when trying to reject patches after unknown failures
2064 https://bugs.webkit.org/show_bug.cgi?id=31091
2066 * Scripts/bugzilla-tool:
2067 - patch['id'] was a copy/paste mistake. This code has no 'patch' variable
2068 so we have to find out what the current patch is by asking bugzilla again.
2069 - Discovered that this code was also leaking file descriptors, so fixed that.
2071 2009-11-04 Adam Roben <aroben@apple.com>
2073 Make run-webkit-tests work for the Debug_Internal Windows
2076 In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2079 Fixes <http://webkit.org/b/31123>.
2081 Reviewed by Sam Weinig.
2083 * Scripts/run-webkit-tests: Don't add the _debug suffix in
2084 Debug_Internal, either.
2086 2009-11-04 Eric Seidel <eric@webkit.org>
2088 Reviewed by Adam Barth.
2090 committers.py needs a way to store non-bugzilla email addresses
2091 https://bugs.webkit.org/show_bug.cgi?id=31037
2093 Make Committer and Reviewer constructors take a single email or a list of emails.
2094 Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2095 Expose reviewers(), used by validate-committer-lists on bug 30970.
2097 * Scripts/modules/committers.py:
2098 * Scripts/modules/committers_unittest.py: Added tests for the new code.
2100 2009-11-03 Yuzo Fujishima <yuzo@google.com>
2102 Reviewed by David Levin.
2104 Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2105 https://bugs.webkit.org/show_bug.cgi?id=27491
2107 The test path determination logic is changed to handle websocket and websocket/ssl cases.
2108 The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2110 Functions to start or stop Web Socket servers are added.
2112 * Scripts/run-webkit-tests:
2114 2009-11-03 Eric Seidel <eric@webkit.org>
2116 No review, just changing wording of log message.
2118 Change log string to say "failed" instead of "rejected"
2119 when a commit fails due to an out of date checkout.
2120 This makes grepping the commit-queue log for rejected patches easier.
2122 * Scripts/bugzilla-tool:
2124 2009-11-03 Eric Seidel <eric@webkit.org>
2126 No review, adding commonly known committers missing from the file.
2128 * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2130 2009-11-03 Eric Seidel <eric@webkit.org>
2132 No review, just sort-order cleanup.
2134 * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2136 2009-11-03 Stephen White <senorblanco@chromium.org>
2140 Add myself to committers.py.
2142 * Scripts/modules/committers.py:
2144 2009-11-03 Robin Dunn <robin@alldunn.com>
2146 Reviewed by Kevin Ollviier.
2148 Add packaging scripts for Debian-based Linux distros.
2150 https://bugs.webkit.org/show_bug.cgi?id=31075
2152 * wx/packaging/build-debian-installer.py: Added.
2153 * wx/packaging/debian: Added.
2155 2009-11-03 Dan Bernstein <mitz@apple.com>
2157 Reviewed by Anders Carlsson and Beth Dakin.
2159 https://bugs.webkit.org/show_bug.cgi?id=31070
2161 Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2162 destroyed, it executes the value of the 'ondestroy' parameter as a
2165 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2166 (pluginAllocate): Initialize onDestroy.
2167 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2169 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2170 (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2172 (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2174 2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>
2176 Reviewed by Xan Lopez.
2178 https://bugs.webkit.org/show_bug.cgi?id=31035
2179 [GTK] some accessibility tests hitting assertion in debug builds
2181 Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2183 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2184 (AccessibilityController::rootElement):
2186 2009-11-02 Chris Fleizach <cfleizach@apple.com>
2188 Reviewed by Beth Dakin.
2190 Support ARIA "tab" roles
2191 https://bugs.webkit.org/show_bug.cgi?id=30842
2193 * DumpRenderTree/AccessibilityUIElement.cpp:
2194 * DumpRenderTree/AccessibilityUIElement.h:
2195 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2196 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2197 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2199 2009-11-01 Eric Seidel <eric@webkit.org>
2201 Reviewed by David Levin.
2203 buildbots should use --exit-after-N-failures
2204 https://bugs.webkit.org/show_bug.cgi?id=30809
2206 Make the bots exit after 20 failures to prevent never-ending
2207 test runs where every test spends a minute crashing.
2209 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2211 2009-11-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2213 Reviewed by Eric Seidel.
2215 Turn on warnings for QtWebKit for gcc
2216 https://bugs.webkit.org/show_bug.cgi?id=30958
2218 * DumpRenderTree/qt/main.cpp:
2219 (crashHandler): Mark function NO_RETURN
2221 2009-11-01 Jessie Berlin <jberlin@webkit.org>
2223 Adding myself to the committers list.
2225 * Scripts/modules/committers.py:
2227 2009-10-30 Jon Honeycutt <jhoneycutt@apple.com>
2229 Fix an issue that Adam noticed in DRT.
2231 Reviewed by Darin Adler.
2233 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2234 (AccessibilityUIElement::role):
2235 Get the length of the role text, and create a buffer dynamically.
2237 2009-10-30 Eric Seidel <eric@webkit.org>
2239 No review, rolling out r50105.
2240 http://trac.webkit.org/changeset/50105
2242 This commit was causing:
2243 https://bugs.webkit.org/show_bug.cgi?id=30869
2244 We'll re-implement the feature a different way.
2246 * Scripts/bugzilla-tool:
2248 2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
2250 Test for MSAA: Accessibility of headings is not correct
2252 https://bugs.webkit.org/show_bug.cgi?id=30937
2254 Reviewed by Adam Roben.
2256 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2257 (AccessibilityUIElement::role):
2258 Allow the role returned to be a BSTR.
2259 (AccessibilityUIElement::description):
2260 Fix a copy/paste error.
2262 2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
2264 Test for MSAA: Accessibility of links is wrong
2266 https://bugs.webkit.org/show_bug.cgi?id=30928
2268 Reviewed by Darin Adler.
2270 * DumpRenderTree/AccessibilityUIElement.cpp:
2271 (getAccessibilityValueCallback):
2272 Return the accessibility value.
2273 (AccessibilityUIElement::getJSClass):
2274 Added "accessibilityValue" value.
2276 * DumpRenderTree/AccessibilityUIElement.h:
2278 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2279 (AccessibilityUIElement::accessibilityValue):
2282 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2283 (AccessibilityUIElement::accessibilityValue):
2286 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2287 (AccessibilityUIElement::accessibilityValue):
2288 Get the object's value, and return it as a JS string.
2290 2009-10-30 Kevin Ollivier <kevino@theolliviers.com>
2292 Fix typo in command name used by wx build system.
2294 * wx/build/build_utils.py:
2296 2009-10-30 Adam Barth <abarth@webkit.org>
2298 Reviewed by Darin Adler.
2300 Patch v1 is a dumb default name for patches
2301 https://bugs.webkit.org/show_bug.cgi?id=30952
2303 Let's use "Patch" instead.
2305 * Scripts/bugzilla-tool:
2307 2009-10-30 Andras Becsi <becsi.andras@stud.u-szeged.hu>
2309 Unreviewed trivial buildfix.
2311 [Qt] Buildfix for r50333.
2313 * DumpRenderTree/qt/DumpRenderTree.pro:
2315 2009-10-30 Antonio Gomes <tonikitoo@webkit.org>
2317 Reviewed by Holger Freyther.
2319 [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2320 https://bugs.webkit.org/show_bug.cgi?id=30953
2322 DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2323 same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2324 makes qt DRT to share this implementation (as gtk and mac ports do).
2326 * DumpRenderTree/qt/DumpRenderTree.pro:
2327 * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2328 * DumpRenderTree/qt/WorkQueue.h: Removed.
2330 2009-10-30 Kenneth Rohde Christiansen <kenneth@webkit.org>
2332 Unreviewed potential buildbot fix.
2334 Second try: Reset page history before running each test.
2336 Apparently the QWebHistory::clear() keeps the current page
2337 in history which is not what we want, so we not additionally
2338 sets the history capacity to 0 (forces removing everything)
2339 and then sets it back to its original value.
2341 * DumpRenderTree/qt/DumpRenderTree.cpp:
2342 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2344 2009-10-30 Kenneth Rohde Christiansen <kenneth@webkit.org>
2346 Unreviewed potential buildbot fix.
2348 Reset page history before running each test.
2350 * DumpRenderTree/qt/DumpRenderTree.cpp:
2351 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2353 2009-10-30 Roland Steiner <rolandsteiner@chromium.org>
2355 Reviewed by Eric Seidel.
2357 Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2359 Bug 28420 - Implement HTML5 <ruby> rendering
2360 (https://bugs.webkit.org/show_bug.cgi?id=28420)
2362 No new tests (no functional change).
2364 * Scripts/build-webkit:
2366 2009-10-29 Dan Bernstein <mitz@apple.com>
2368 Reviewed by Mark Rowe.
2370 Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2371 from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2374 * Scripts/VCSUtils.pm:
2375 * Scripts/svn-apply:
2376 * Scripts/svn-unapply:
2378 2009-10-29 Xan Lopez <xlopez@igalia.com>
2380 Reviewed by Gustavo Noronha.
2382 Use the GTK+ main loop instead of rolling our own mini-version of
2385 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2388 (webViewLoadFinished):
2390 2009-10-29 Kenneth Rohde Christiansen <kenneth@webkit.org>
2392 Reviewed by Oliver Hunt.
2394 Implement the Qt version of DRT dumpBackForwardList().
2396 * DumpRenderTree/qt/DumpRenderTree.cpp:
2397 (WebCore::dumpHistoryItem):
2398 (WebCore::DumpRenderTree::dumpBackForwardList):
2400 2009-10-29 Kenneth Rohde Christiansen <kenneth@webkit.org>
2402 Reviewed by Adam Roben.
2404 Implement DRT functionality for Qt introduced in
2407 - Implemented pathToLocalResource which exposes the functionality of
2408 converting a given unix path to the correct location on Windows.
2409 - Implemented a way to remove machine-dependent information from paths
2410 in layout test results.
2412 * DumpRenderTree/qt/DumpRenderTree.cpp:
2413 (WebCore::urlSuitableForTestResult):
2414 (WebCore::WebPage::javaScriptConsoleMessage):
2415 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2416 (LayoutTestController::pathToLocalResource):
2417 * DumpRenderTree/qt/LayoutTestControllerQt.h:
2419 2009-10-28 Roland Steiner <rolandsteiner@chromium.org>
2421 Adding myself to the committers list.
2423 * Scripts/modules/committers.py:
2425 2009-10-28 Chris Fleizach <cfleizach@apple.com>
2427 Adding myself to the committers list.
2429 * Scripts/modules/committers.py:
2431 2009-10-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2433 Reviewed by Jan Alonzo.
2435 [GTK] API to start inspector for a WebView
2436 https://bugs.webkit.org/show_bug.cgi?id=22551
2438 Use the new inspector API to implement the LayoutTestController
2439 interfaces used to test the inspector.
2441 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2442 (webInspectorInspectWebView):
2444 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2445 (LayoutTestController::showWebInspector):
2446 (LayoutTestController::closeWebInspector):
2447 (LayoutTestController::evaluateInWebInspector):
2449 2009-10-28 Shinichiro Hamaji <hamaji@chromium.org>
2451 Reviewed by Eric Seidel.
2453 [Qt] WebFrame::counterValueForElementById must not be exposed
2454 https://bugs.webkit.org/show_bug.cgi?id=30882
2456 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2457 (LayoutTestController::counterValueForElementById):
2459 2009-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
2461 Rubberstamped by Oliver Hunt.
2465 "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2466 declared with attribute warn_unused_result".
2468 by actually checking the result. In the case it is null, an
2469 error has occoured, so treat it as the other fatal errors.
2471 * DumpRenderTree/qt/DumpRenderTree.cpp:
2472 (WebCore::DumpRenderTree::initializeFonts):
2474 2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
2476 Reviewed by Darin Adler.
2478 Provide a way to get counter values with layoutTestContoller
2479 https://bugs.webkit.org/show_bug.cgi?id=30555
2481 Define layoutTestContoller.counterValueForElementById.
2483 * DumpRenderTree/LayoutTestController.cpp:
2484 (counterValueForElementByIdCallback):
2485 (LayoutTestController::staticFunctions):
2486 * DumpRenderTree/LayoutTestController.h:
2487 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2488 (LayoutTestController::counterValueForElementById):
2490 2009-10-27 Kenneth Rohde Christiansen <kenneth@webkit.org>
2492 Rubberstamped by Oliver Hunt.
2494 Change two methods to be internal for DRT use only.
2496 Part of [Qt] Review all new API in Qt 4.6
2497 https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2499 * DumpRenderTree/qt/DumpRenderTree.cpp:
2500 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2501 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2502 (LayoutTestController::whiteListAccessFromOrigin):
2504 2009-10-27 Eric Seidel <eric@webkit.org>
2506 Reviewed by Adam Barth.
2508 REGRESSION: svn-apply exits(1) when applying a patch with a file add
2509 https://bugs.webkit.org/show_bug.cgi?id=30826
2511 * Scripts/svn-apply:
2512 - Add () around all system() calls.
2513 - Use the correct system() == 0 or die instead of system() or die
2514 - Add descriptive messages to all die statements.
2516 2009-10-27 Steve Block <steveblock@google.com>
2520 Adds steveblock@google.com to list of committers.
2522 * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2524 2009-10-27 Eric Seidel <eric@webkit.org>
2526 Reviewed by Adam Barth.
2528 svn-apply can exit(0) even on patch failure
2529 https://bugs.webkit.org/show_bug.cgi?id=29622
2531 * Scripts/svn-apply:
2532 - Add a bunch of "or die" statements, hopefully catching all
2533 possible cases where failure could still exit(0).
2535 2009-10-27 Eric Seidel <eric@webkit.org>
2537 Reviewed by Adam Barth.
2539 svn-* scripts should share code through VCSUtils.pm
2540 https://bugs.webkit.org/show_bug.cgi?id=30791
2542 Just moving code into a shared location.
2544 * Scripts/VCSUtils.pm:
2545 * Scripts/prepare-ChangeLog:
2546 * Scripts/resolve-ChangeLogs:
2547 * Scripts/svn-apply:
2548 * Scripts/svn-create-patch:
2549 * Scripts/svn-unapply:
2550 * Scripts/update-webkit:
2552 2009-10-27 Vadim Zeitlin <vadim@wxwidgets.org>
2554 Suppress a huge number of MSVC warnings when building wxWebKit.
2556 * wx/build/settings.py:
2558 2009-10-26 Eric Seidel <eric@webkit.org>
2560 No review, just adding Mike Belshe to the committers list.
2562 * Scripts/modules/committers.py:
2564 2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2566 Reviewed by Darin Adler.
2568 Make .rc files compile on Windows without depending on MFC headers
2569 https://bugs.webkit.org/show_bug.cgi?id=30750
2571 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2572 windows.h instead of afxres.h because it exists even when MFC is not
2573 installed, and is all that's needed here.
2575 * FindSafari/FindSafari.rc: Ditto
2577 2009-10-24 Eric Seidel <eric@webkit.org>
2579 Reviewed by Adam Barth.
2581 bugzilla-tool post-diff should know how to mark commit-queue=?
2582 https://bugs.webkit.org/show_bug.cgi?id=29202
2584 * Scripts/bugzilla-tool:
2585 - Add --commit-queue option to post-diff, post-commits and create-bug.
2586 * Scripts/modules/bugzilla.py:
2587 - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2588 - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2590 2009-10-23 Eric Seidel <eric@webkit.org>
2592 Reviewed by Adam Barth.
2594 bugzilla-tool commit-queue does not notice modifications to committers.py
2595 https://bugs.webkit.org/show_bug.cgi?id=30084
2597 * Scripts/bugzilla-tool:
2598 - Make commit-queue re-exec itself instead of using while(1).
2599 - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2600 - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2602 2009-10-22 Eric Seidel <eric@webkit.org>
2604 Reviewed by Adam Barth.
2606 commit-queue will get stuck on patches if land-patches terminates unexpectedly
2607 https://bugs.webkit.org/show_bug.cgi?id=30634
2609 * Scripts/bugzilla-tool:
2610 - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2611 - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2613 2009-10-26 Yuzo Fujishima <yuzo@google.com>
2615 Reviewed by Eric Seidel.
2617 Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2619 https://bugs.webkit.org/show_bug.cgi?id=30763
2621 * pywebsocket/mod_pywebsocket/__init__.py:
2622 * pywebsocket/mod_pywebsocket/dispatch.py:
2623 * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2624 * pywebsocket/mod_pywebsocket/standalone.py:
2625 * pywebsocket/setup.py:
2626 * pywebsocket/test/test_dispatch.py:
2628 2009-10-26 Carol Szabo <carol.szabo@nokia.com>
2630 Reviewed by David Levin.
2632 REGRESSION: 2 failures in run-webkit-unittests
2633 https://bugs.webkit.org/show_bug.cgi?id=30645
2635 * Scripts/modules/cpp_style_unittest.py:
2636 Fixed a few test scenarios which apparently lost some spaces from
2639 2009-10-26 Kevin Ollivier <kevino@theolliviers.com>
2641 wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2643 * Scripts/webkitdirs.pm:
2645 2009-10-26 Csaba Osztrogonác <ossy@webkit.org>
2647 Reviewed by Darin Adler.
2649 Unification of using null device in perl scripts.
2650 https://bugs.webkit.org/show_bug.cgi?id=30572
2652 * Scripts/VCSUtils.pm:
2653 * Scripts/bisect-builds:
2654 * Scripts/resolve-ChangeLogs:
2655 * Scripts/run-iexploder-tests:
2657 * Scripts/run-mangleme-tests:
2658 * Scripts/run-webkit-tests:
2659 * Scripts/webkitdirs.pm:
2660 Using File::Spec->devnull() instead of hard coded /dev/null.
2662 2009-10-26 Eric Seidel <eric@webkit.org>
2664 Reviewed by Holger Freyther.
2666 Reviewers are missing from committers.py
2667 https://bugs.webkit.org/show_bug.cgi?id=30733
2669 * Scripts/modules/committers.py:
2671 2009-10-23 Eric Seidel <eric@webkit.org>
2673 No review, only adding Alice to the list of reviewers.
2675 * Scripts/modules/committers.py:
2677 2009-10-23 Eric Seidel <eric@webkit.org>
2679 Reviewed by Eric Carlson.
2681 fast/media/mq-transform-02.html failed on Leopard Commit Bot
2682 https://bugs.webkit.org/show_bug.cgi?id=30700
2684 * DumpRenderTree/mac/DumpRenderTree.mm:
2685 (resetDefaultsToConsistentValues): Update QuickTime version check.
2687 2009-10-23 Kevin Ollivier <kevino@theolliviers.com>
2689 wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2690 character measurement APIs that are private on Tiger.
2692 * wx/build/settings.py:
2694 2009-10-22 Gavin Barraclough <barraclough@apple.com>
2696 Reviewed by NOBODY (build fix).
2697 Build fix following bug #30696.
2699 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2700 (LayoutTestController::evaluateScriptInIsolatedWorld):
2702 2009-10-22 Gavin Barraclough <barraclough@apple.com>
2704 Reviewed by Sam Weinig & Geoff Garen.
2706 https://bugs.webkit.org/show_bug.cgi?id=30696
2707 Enable isolated-worlds tests on mac.
2709 Add private interface for DRT to invoke execution in a given world.
2711 * DumpRenderTree/LayoutTestController.cpp:
2712 (evaluateScriptInIsolatedWorldCallback):
2713 (LayoutTestController::staticFunctions):
2714 * DumpRenderTree/LayoutTestController.h:
2715 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2716 (LayoutTestController::evaluateScriptInIsolatedWorld):
2717 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2718 (LayoutTestController::evaluateScriptInIsolatedWorld):
2720 2009-10-21 Eric Seidel <eric@webkit.org>
2722 Reviewed by Adam Barth.
2724 bugzilla-tool's "patch failed to download an apply" error should give more information
2725 https://bugs.webkit.org/show_bug.cgi?id=30632
2727 * Scripts/modules/scm.py:
2728 - Use the common run_command method instead of custom POpen code.
2729 - Make run_command know how to take pipes as input.
2730 * Scripts/modules/scm_unittest.py:
2731 - Add new tests to cover change.
2732 - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2734 2009-10-21 Kent Tamura <tkent@chromium.org>
2736 Unreviewed. Adding myself to the committers list.
2738 * Scripts/modules/committers.py:
2740 2009-10-21 Robin Dunn <robin@alldunn.com>
2742 Reviewed by Kevin Ollivier.
2744 Update the Windows installer builder to work with Vista / Win 7 and with git.
2746 https://bugs.webkit.org/show_bug.cgi?id=30649
2748 * wx/build/build_utils.py:
2749 * wx/packaging/build-mac-installer.py:
2750 * wx/packaging/build-win-installer.py:
2751 * wx/packaging/wxWebKitInstaller.iss.in:
2753 2009-10-21 Alejandro G. Castro <alex@igalia.com>
2755 Reviewed by Gustavo Noronha.
2757 [GTK] Added conditional code to avoid using
2758 gdk_window_get_root_coords if we do not have a gtk+ release newer
2760 https://bugs.webkit.org/show_bug.cgi?id=30636
2762 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2764 2009-10-21 Shu Chang <Chang.Shu@nokia.com>
2766 Reviewed by Eric Seidel.
2768 [Qt] Added dummy implementation for keepWebHistory()
2769 https://bugs.webkit.org/show_bug.cgi?id=30592
2771 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2772 (LayoutTestController::keepWebHistory):
2773 * DumpRenderTree/qt/LayoutTestControllerQt.h:
2775 2009-10-21 Alejandro G. Castro <alex@igalia.com>
2777 Reviewed by Xan Lopez.
2779 [GTK] Fixed the double click condition, it is not double click if
2780 we move in just in one direction.
2781 https://bugs.webkit.org/show_bug.cgi?id=30636
2783 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2785 2009-10-21 Alejandro G. Castro <alex@igalia.com>
2787 Reviewed by Xan Lopez.
2789 [GTK] Initialize the events completly before emitting them.
2790 https://bugs.webkit.org/show_bug.cgi?id=30633
2792 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2794 2009-10-21 Kevin Ollivier <kevino@theolliviers.com>
2796 wx build fix. Fix for when linking using --as-needed with gcc.
2798 * wx/browser/wscript:
2800 2009-10-21 Kevin Ollivier <kevino@theolliviers.com>
2802 wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2803 to support all the features used by CURL backend.
2805 * wx/build/settings.py:
2806 * wx/install-unix-extras:
2808 2009-10-20 Anton Muhin <antonm@chromium.org>
2810 Reviewed by Adam Barth.
2812 Add {ager,antonm,yurys}@chromium.org into committers.py
2813 https://bugs.webkit.org/show_bug.cgi?id=30560
2815 * Scripts/modules/committers.py:
2817 2009-10-20 Kenneth Rohde Christiansen <kenneth@webkit.org>
2819 Reviewed by Tor Arne Vestbø.
2821 Make the Netscape Test plugin available to the Qt launcher.
2823 * Scripts/run-launcher:
2825 2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
2827 Reviewed by David Levin.
2829 Removed WebSocket runtime settings.
2830 https://bugs.webkit.org/show_bug.cgi?id=29896
2832 WebSocket runtime configuration is supported by chromium/v8 only.
2834 * DumpRenderTree/mac/DumpRenderTree.mm:
2835 (resetDefaultsToConsistentValues):
2836 * DumpRenderTree/win/DumpRenderTree.cpp:
2837 (resetDefaultsToConsistentValues):
2839 2009-10-19 Nate Chapin <japhet@chromium.org>
2841 Reviewed by Adam Barth.
2843 Add testFail() to test plugin so we can test our handling of a
2844 plugin invoke call returning false.
2846 https://bugs.webkit.org/show_bug.cgi?id=30239
2848 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2850 (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2852 2009-10-19 Zan Dobersek <zandobersek@gmail.com>
2854 Reviewed by Gustavo Noronha.
2856 Enable DOM pasting when running layout tests.
2858 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2859 (resetDefaultsToConsistentValues):
2861 2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
2863 Reviewed by Simon Hausmann.
2865 Use the setPreferredContentsSize method instead
2866 of setFixedContentsSize, as the method has been renamed.
2868 * DumpRenderTree/qt/DumpRenderTree.cpp:
2869 (WebCore::DumpRenderTree::open):
2870 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2871 (LayoutTestController::setFixedContentsSize):
2873 2009-10-16 Steve Falkenburg <sfalken@apple.com>
2875 Reviewed by Dan Bernstein.
2877 https://bugs.webkit.org/show_bug.cgi?id=30456
2878 Fixes for new Debug_All Windows build configuration.
2880 * DumpRenderTree/win/DumpRenderTree.cpp:
2881 (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2882 * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2884 2009-10-16 Eric Seidel <eric@webkit.org>
2886 Reviewed by Adam Barth.
2888 commit-queue status bot should list which buildbot is blocking the queue
2889 https://bugs.webkit.org/show_bug.cgi?id=30452
2891 Add new methods and testing.
2893 * Scripts/bugzilla-tool:
2894 * Scripts/modules/buildbot.py:
2895 * Scripts/modules/buildbot_unittest.py:
2897 2009-10-16 Eric Seidel <eric@webkit.org>
2899 Reviewed by Adam Barth.
2901 run-webkit-tests fails when CWD is not inside a WebKit checkout
2902 https://bugs.webkit.org/show_bug.cgi?id=30451
2904 * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2905 * Scripts/modules/scm_unittest.py:
2906 - Remove use of original_path (we don't need to restore the CWD).
2907 - Don't use '.' to find the webkit checkout, use __file__ instead.
2909 2009-10-16 Steve Falkenburg <sfalken@apple.com>
2911 Reviewed by Adam Roben.
2913 Add a Debug_All configuration to build entire stack as debug.
2914 Change Debug_Internal to:
2915 - stop using _debug suffix for all WebKit/Safari binaries
2916 - not use _debug as a DLL naming suffix
2917 - use non-debug C runtime lib.
2919 * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2920 * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2921 * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2922 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2923 Add missing debug.vsprops inherited property sheet.
2924 Add Debug_All configuration.
2925 * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2926 * WinLauncher/WinLauncher.vcproj:
2927 Removed extraneous definitions inherited from vsprops.
2928 Add Debug_All configuration.
2930 2009-10-16 Carol Szabo <carol.szabo@nokia.com>
2932 Reviewed by David Levin.
2934 check-webkit-style is wrong about indent checking in namespaces
2935 in header files and a few other things
2936 https://bugs.webkit.org/show_bug.cgi?id=30362
2938 The few other things include:
2939 + check-webkit-style does not require spaces around the equal sign
2940 inside 'if' statements and around binary operators that take
2942 + check-webkit-style reports false errors for the / operator
2943 when part of a filename in the #include directive.
2945 * Scripts/modules/cpp_style.py:
2946 Improved indentation checking and space checking around
2947 binary operators. While the checks are still not perfect,
2948 they are clearly better than before.
2949 * Scripts/modules/cpp_style_unittest.py:
2950 Added test cases for the newly supported checks and modified old
2951 test cases to match the new guidelines
2953 2009-10-16 Kevin Ollivier <kevino@theolliviers.com>
2955 wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2957 * wx/build/settings.py:
2959 2009-10-15 Yuzo Fujishima <yuzo@google.com>
2961 Reviewed by David Levin.
2963 Add mod_pywebsocket to test Web Sockets.
2964 http://code.google.com/p/pywebsocket/
2965 https://bugs.webkit.org/show_bug.cgi?id=27490
2967 * pywebsocket/COPYING: Added.
2968 * pywebsocket/MANIFEST.in: Added.
2969 * pywebsocket/README: Added.
2970 * pywebsocket/example/echo_client.py: Added.
2971 * pywebsocket/example/echo_wsh.py: Added.
2972 * pywebsocket/mod_pywebsocket/__init__.py: Added.
2973 * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2974 * pywebsocket/mod_pywebsocket/handshake.py: Added.
2975 * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2976 * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2977 * pywebsocket/mod_pywebsocket/standalone.py: Added.
2978 * pywebsocket/mod_pywebsocket/util.py: Added.
2979 * pywebsocket/setup.py: Added.
2980 * pywebsocket/test/config.py: Added.
2981 * pywebsocket/test/mock.py: Added.
2982 * pywebsocket/test/run_all.py: Added.
2983 * pywebsocket/test/test_dispatch.py: Added.
2984 * pywebsocket/test/test_handshake.py: Added.
2985 * pywebsocket/test/test_mock.py: Added.
2986 * pywebsocket/test/test_msgutil.py: Added.
2987 * pywebsocket/test/test_util.py: Added.
2988 * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2989 * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2990 * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2991 * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2992 * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2993 * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2994 * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2995 * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2997 2009-10-15 James Robinson <jamesr@google.com>
2999 Reviewed by David Levin.
3001 Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3003 https://bugs.webkit.org/show_bug.cgi?id=30426
3005 * Scripts/modules/cpp_style.py:
3006 * Scripts/modules/cpp_style_unittest.py:
3008 2009-10-15 Brian Weinstein <bweinstein@apple.com>
3010 Reviewed by Adam Roben.
3012 Fixes <http://webkit.org/b/30411>.
3013 REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3015 Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3020 2009-10-15 Robin Dunn <robin@alldunn.com>
3022 Reviewed by Kevin Ollivier.
3024 Add Mac package building scripts for wx.
3026 https://bugs.webkit.org/show_bug.cgi?id=30405
3028 * wx/build/build_utils.py:
3029 * wx/build/settings.py:
3030 * wx/packaging/build-mac-installer.py: Added.
3032 2009-10-15 Zan Dobersek <zandobersek@gmail.com>
3034 Reviewed by Gustavo Noronha.
3036 Enable Web Sockets support when running layout tests.
3038 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3039 (resetDefaultsToConsistentValues):
3041 2009-10-15 Xan Lopez <xlopez@igalia.com>
3043 Reviewed by Gustavo Noronha.
3045 Need to initialize event.button.button, since in most cases a
3046 button number is not passed as an argument.
3048 * DumpRenderTree/gtk/EventSender.cpp:
3049 (mouseDownCallback):
3052 2009-10-15 Kevin Ollivier <kevino@theolliviers.com>
3054 wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3055 the OS if none was explicitly set.
3057 * wx/build/settings.py:
3059 2009-10-14 Pavel Feldman <pfeldman@chromium.org>
3061 Reviewed by Timothy Hatcher.
3063 Web Inspector: enable developers extras within inspector layout tests.
3065 https://bugs.webkit.org/show_bug.cgi?id=30014
3067 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3068 (LayoutTestController::showWebInspector):
3069 (LayoutTestController::closeWebInspector):
3070 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3071 (LayoutTestController::showWebInspector):
3072 (LayoutTestController::closeWebInspector):
3074 2009-10-14 José Millán Soto <jmillan@igalia.com>
3076 Reviewed by Jan Alonzo.
3078 GtkLauncher is using a deprecated signal
3079 https://bugs.webkit.org/show_bug.cgi?id=30364
3081 Modified GtkLauncher to use notify::title signal instead of
3082 deprecated title-changed signal
3084 * GtkLauncher/main.c:
3088 2009-10-14 Brady Eidson <beidson@apple.com>
3090 Reviewed by Sam Weinig.
3092 Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3093 1 - Disables WebHistory
3094 2 - Doesn't make sense in that context anyway.
3096 * DumpRenderTree/win/DumpRenderTree.cpp:
3097 (createWebViewAndOffscreenWindow):
3099 2009-10-14 Kevin Ollivier <kevino@theolliviers.com>
3101 wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3102 the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3104 * wx/build/settings.py:
3105 * wx/install-unix-extras:
3107 2009-10-14 Brady Eidson <beidson@apple.com>
3109 Reviewed by Sam Weinig.
3111 WebKit Win API should provide a delegate interface for global history.
3112 https://bugs.webkit.org/show_bug.cgi?id=29905
3114 * DumpRenderTree/LayoutTestController.cpp:
3115 (LayoutTestController::LayoutTestController):
3116 * DumpRenderTree/LayoutTestController.h:
3117 (LayoutTestController::dumpHistoryDelegateCallbacks):
3118 (LayoutTestController::setDumpHistoryDelegateCallbacks):
3120 * DumpRenderTree/win/DumpRenderTree.cpp:
3121 (shouldLogHistoryDelegates):
3123 (createWebViewAndOffscreenWindow):
3125 * DumpRenderTree/win/DumpRenderTree.vcproj:
3127 Add the IWebHistoryDelegate to DRT Windows:
3128 * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3130 (HistoryDelegate::HistoryDelegate):
3131 (HistoryDelegate::~HistoryDelegate):
3132 (HistoryDelegate::QueryInterface):
3133 (HistoryDelegate::AddRef):
3134 (HistoryDelegate::Release):
3135 (HistoryDelegate::didNavigateWithNavigationData):
3136 (HistoryDelegate::didPerformClientRedirectFromURL):
3137 (HistoryDelegate::didPerformServerRedirectFromURL):
3138 (HistoryDelegate::updateHistoryTitle):
3139 (HistoryDelegate::populateVisitedLinksForWebView):
3140 * DumpRenderTree/win/HistoryDelegate.h: Added.
3142 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3143 (LayoutTestController::removeAllVisitedLinks):
3145 2009-10-14 Shu Chang <Chang.Shu@nokia.com>
3147 Reviewed by Simon Hausmann.
3149 [Qt] Implement support for setPOSIXLocale on Qt.
3150 https://bugs.webkit.org/show_bug.cgi?id=30268
3152 * DumpRenderTree/qt/DumpRenderTree.cpp:
3153 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3154 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3155 (LayoutTestController::setPOSIXLocale):
3156 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3158 2009-10-13 Stephanie Lewis <slewis@apple.com>
3160 Unreviewed, adding myself to reviewers list.
3162 * Scripts/modules/committers.py:
3164 2009-10-13 Stephanie Lewis <slewis@apple.com>
3166 Reviewed by Mark Rowe.
3168 Fix null assignment so root tests work again.
3170 * Scripts/webkitdirs.pm:
3172 2009-10-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
3174 Reviewed by Simon Hausmann.
3176 [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3177 out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3178 This is done in preparation of implementing missing features in DRT.
3179 No functionality changes made yet.
3181 * DumpRenderTree/qt/DumpRenderTree.cpp:
3182 * DumpRenderTree/qt/DumpRenderTree.pro:
3183 * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3184 (EventSender::EventSender):
3185 (EventSender::mouseDown):
3186 (EventSender::mouseUp):
3187 (EventSender::mouseMoveTo):
3188 (EventSender::leapForward):
3189 (EventSender::keyDown):
3190 (EventSender::contextClick):
3191 (EventSender::scheduleAsynchronousClick):
3192 (EventSender::frameUnderMouse):
3193 * DumpRenderTree/qt/EventSenderQt.h: Added.
3194 (EventSender::clearKillRing):
3195 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3196 (LayoutTestController::LayoutTestController):
3197 (LayoutTestController::reset):
3198 (LayoutTestController::processWork):
3199 (LayoutTestController::maybeDump):
3200 (LayoutTestController::waitUntilDone):
3201 (LayoutTestController::notifyDone):
3202 (LayoutTestController::windowCount):
3203 (LayoutTestController::clearBackForwardList):
3204 (LayoutTestController::dumpEditingCallbacks):
3205 (LayoutTestController::dumpResourceLoadCallbacks):
3206 (LayoutTestController::queueBackNavigation):
3207 (LayoutTestController::queueForwardNavigation):
3208 (LayoutTestController::queueLoad):
3209 (LayoutTestController::queueReload):
3210 (LayoutTestController::queueScript):
3211 (LayoutTestController::provisionalLoad):
3212 (LayoutTestController::timerEvent):
3213 (LayoutTestController::encodeHostName):
3214 (LayoutTestController::decodeHostName):
3215 (LayoutTestController::setJavaScriptProfilingEnabled):
3216 (LayoutTestController::setFixedContentsSize):
3217 (LayoutTestController::setPrivateBrowsingEnabled):
3218 (LayoutTestController::setPopupBlockingEnabled):
3219 (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3220 (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3221 (LayoutTestController::numberOfActiveAnimations):
3222 (LayoutTestController::disableImageLoading):
3223 (LayoutTestController::dispatchPendingLoadRequests):
3224 (LayoutTestController::setDatabaseQuota):
3225 (LayoutTestController::clearAllDatabases):
3226 (LayoutTestController::whiteListAccessFromOrigin):
3227 (LayoutTestController::waitForPolicyDelegate):
3228 (LayoutTestController::overridePreference):
3229 * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3230 (LayoutTestController::isLoading):
3231 (LayoutTestController::setLoading):
3232 (LayoutTestController::shouldDumpAsText):
3233 (LayoutTestController::shouldDumpBackForwardList):
3234 (LayoutTestController::shouldDumpChildrenAsText):
3235 (LayoutTestController::shouldDumpDatabaseCallbacks):
3236 (LayoutTestController::shouldDumpStatusCallbacks):
3237 (LayoutTestController::shouldWaitUntilDone):
3238 (LayoutTestController::canOpenWindows):
3239 (LayoutTestController::shouldDumpTitleChanges):
3240 (LayoutTestController::waitForPolicy):
3241 (LayoutTestController::dumpAsText):
3242 (LayoutTestController::dumpChildFramesAsText):
3243 (LayoutTestController::dumpDatabaseCallbacks):
3244 (LayoutTestController::dumpStatusCallbacks):
3245 (LayoutTestController::setCanOpenWindows):
3246 (LayoutTestController::dumpBackForwardList):
3247 (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3248 (LayoutTestController::display):
3249 (LayoutTestController::dumpTitleChanges):
3250 (LayoutTestController::dumpSelectionRect):
3251 * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3252 (TextInputController::TextInputController):
3253 (TextInputController::doCommand):
3254 * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3255 * DumpRenderTree/qt/WorkQueue.cpp:
3256 * DumpRenderTree/qt/WorkQueue.h:
3257 * DumpRenderTree/qt/WorkQueueItem.h:
3258 * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3261 (ReloadItem::invoke):
3262 (ScriptItem::invoke):
3263 (BackForwardItem::invoke):
3264 * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3265 * DumpRenderTree/qt/jsobjects.h:
3267 2009-10-13 Dmitry Titov <dimich@chromium.org>
3269 Not reviewed, adding myself to the list of reviewers.
3271 * Scripts/modules/committers.py:
3273 2009-10-13 Anders Carlsson <andersca@apple.com>
3275 Reviewed by Sam Weinig.
3277 <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3279 Make the private browsing mode testable by the test plug-in.
3281 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3282 (pluginGetProperty):
3283 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3284 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3288 2009-10-13 Pavel Feldman <pfeldman@chromium.org>
3290 No review, just adding self to the list of reviewers.
3292 * Scripts/modules/committers.py:
3294 2009-10-12 Pavel Feldman <pfeldman@chromium.org>
3296 Reviewed by Adam Roben.
3298 Web Inspector: Use proper web view in inspector layout
3301 https://bugs.webkit.org/show_bug.cgi?id=30298
3303 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3304 (LayoutTestController::showWebInspector):
3305 (LayoutTestController::closeWebInspector):
3306 (LayoutTestController::evaluateInWebInspector):
3308 2009-10-12 Fumitoshi Ukai <ukai@chromium.org>
3310 Reviewed by Sam Weinig.
3312 Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3313 https://bugs.webkit.org/show_bug.cgi?id=29841
3315 * DumpRenderTree/mac/DumpRenderTree.mm:
3316 (resetDefaultsToConsistentValues):
3317 * DumpRenderTree/win/DumpRenderTree.cpp:
3318 (resetDefaultsToConsistentValues):
3320 2009-10-12 Yaar Schnitman <yaar@chromium.org>
3322 Reviewed by Dimitri Glazkov.
3324 Chromium Port - Windows
3325 https://bugs.webkit.org/show_bug.cgi?id=29969
3327 * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3328 * Scripts/webkitdirs.pm:
3330 2009-10-12 Csaba Osztrogonac <ossy@webkit.org>
3332 Reviewed by Darin Adler.
3334 jsc scripts cleanup and Qt/GTK fix
3335 https://bugs.webkit.org/show_bug.cgi?id=30288
3337 Duplicated jscPath() moved to webkitdirs.pm.
3338 New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3339 Configuration added (release/debug) to path for Qt-port on Windows.
3341 * Scripts/run-javascriptcore-tests:
3343 * Scripts/run-sunspider:
3344 * Scripts/sunspider-compare-results:
3345 * Scripts/webkitdirs.pm:
3347 2009-10-11 Adam Barth <abarth@webkit.org>
3349 Unreviewed. Add Collin to committers.py.
3351 * Scripts/modules/committers.py:
3353 2009-10-11 Kevin Ollivier <kevino@theolliviers.com>
3355 wx build fix, add bindings to source/include dirs now that there are sources there.
3357 * wx/build/settings.py:
3359 2009-10-09 Mark Rowe <mrowe@apple.com>
3361 Reviewed by Brady Eidson.
3363 Enable plug-in halting in DumpRenderTree.
3365 We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3366 This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3368 * DumpRenderTree/mac/DumpRenderTree.mm:
3369 (resetDefaultsToConsistentValues):
3370 * DumpRenderTree/mac/UIDelegate.mm:
3371 (-[UIDelegate webView:shouldHaltPlugin:]):
3373 2009-10-08 Brady Eidson <beidson@apple.com>
3375 Reviewed by Dan Bernstein.
3377 Ask the History Delegate to populate the visited links hash.
3378 <rdar://problem/7285293> and https://webkit.org/b/29904
3380 Add the ability for LayoutTestController to clear all visited links.
3381 Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3383 * DumpRenderTree/LayoutTestController.cpp:
3384 (LayoutTestController::LayoutTestController):
3385 (removeAllVisitedLinksCallback):
3386 (LayoutTestController::staticFunctions):
3387 * DumpRenderTree/LayoutTestController.h:
3388 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3389 (LayoutTestController::removeAllVisitedLinks):
3391 * DumpRenderTree/mac/HistoryDelegate.mm:
3392 (-[HistoryDelegate populateVisitedLinksForWebView:]):
3394 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3395 (LayoutTestController::removeAllVisitedLinks):
3396 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3397 (LayoutTestController::removeAllVisitedLinks):
3398 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3399 (LayoutTestController::removeAllVisitedLinks):
3402 2009-10-08 Daniel Bates <dbates@webkit.org>
3404 Reviewed by Adam Roben.
3406 https://bugs.webkit.org/show_bug.cgi?id=30175
3408 The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3409 the OLE drag-and-drop return value like the function it emulates. Currently,
3410 UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3411 whether the drag-and-drop operation was successful or was cancelled.
3413 This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3414 return value according to whether the drop operation was successful or not.
3416 * DumpRenderTree/win/EventSender.cpp:
3417 (doMouseUp): Added parameter oleDragAndDropReturnValue.
3418 (replaySavedEvents): Ditto.
3419 * DumpRenderTree/win/EventSender.h:
3420 * DumpRenderTree/win/UIDelegate.cpp:
3421 (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3423 2009-10-08 Alejandro G. Castro <alex@igalia.com>
3425 Reviewed by Xan Lopez.
3427 [GTK] Added support for a parameter setting the button that was
3428 pressed in the mouseDown function.
3429 https://bugs.webkit.org/show_bug.cgi?id=30220
3431 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3433 2009-10-08 Alejandro G. Castro <alex@igalia.com>
3435 Reviewed by Xan Lopez.
3437 [GTK] Added a line to the bottom of the expected result to match
3438 the output of the test.
3439 https://bugs.webkit.org/show_bug.cgi?id=30220
3441 * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3444 2009-10-08 Adam Roben <aroben@apple.com>
3446 Use QueryInterface to get IWebInspectorPrivate
3448 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3449 accessed in a more standard way
3451 Reviewed by John Sullivan and Tim Hatcher.
3453 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3454 (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3455 by calling IWebViewPrivate::inspector, then use QueryInterface to get
3456 to the IWebInspectorPrivate interface.
3458 2009-10-07 Adam Roben <aroben@apple.com>
3460 Implement DRT support for origin whitelisting
3462 Fixes <http://webkit.org/b/30185>.
3464 Reviewed by Eric Seidel.
3466 * DumpRenderTree/win/DumpRenderTree.cpp:
3467 (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3468 whitelist, to match Mac DRT.
3469 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3470 (LayoutTestController::whiteListAccessFromOrigin): Call through to
3471 IWebViewPrivate::whiteListAccessFromOrigin.
3473 2009-10-07 Brady Eidson <beidson@apple.com>
3475 Reviewed by Darin Adler.
3477 Send title changes to the global history delegate.
3478 <rdar://problem/7285293> and https://webkit.org/b/29904
3480 * DumpRenderTree/mac/HistoryDelegate.mm:
3481 (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3483 2009-10-07 Adam Barth <abarth@webkit.org>
3485 Unreviewed. Remove some folks from committers.py who were listed on
3486 the WebKit Team wiki page but who weren't actually listed as commit+.
3487 At some point, we should coorelate this list with the committers
3490 * Scripts/modules/committers.py:
3492 2009-10-07 Adam Barth <abarth@webkit.org>
3494 Unreviewed. Import a bunch of committers from the WebKit Team page on
3495 the wiki into committers.py.
3497 * Scripts/modules/committers.py:
3499 2009-10-07 Adam Barth <abarth@webkit.org>
3501 Unreviewed. Added Aaron Boodman to committers.py.
3503 * Scripts/modules/committers.py:
3505 2009-10-07 Evan Martin <evan@chromium.org>
3507 Reviewed by Darin Adler.
3509 Add API to LayoutTestController for re/setting the system locale.
3510 https://bugs.webkit.org/show_bug.cgi?id=18994
3512 * DumpRenderTree/LayoutTestController.cpp:
3513 (setLocaleCallback):
3514 (LayoutTestController::staticFunctions):
3515 (LayoutTestController::setLocale):
3516 * DumpRenderTree/LayoutTestController.h:
3518 2009-10-06 Shinichiro Hamaji <hamaji@chromium.org>
3520 Reviewed by Jan Alonzo.
3522 [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3523 https://bugs.webkit.org/show_bug.cgi?id=29689
3525 Build fix by adding -lfontconfig for DumpRenderTree.
3529 2009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
3531 Reviewed by Simon Hausmann.
3533 Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3535 * Scripts/run-webkit-tests:
3537 2009-10-07 Xan Lopez <xlopez@igalia.com>
3539 Reviewed by Gustavo Noronha.
3541 "delete" in EventSender is the backspace key, not the delete one.
3543 * DumpRenderTree/gtk/EventSender.cpp:
3546 2009-10-07 Xan Lopez <xlopez@igalia.com>
3548 Reviewed by Gustavo Noronha.
3550 getChildrenWithRange expects as last parameter the end index, not
3551 the length of the range. Correct this and clarify the variable
3552 names to reflect how the code works.
3554 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3555 (AccessibilityUIElement::getChildrenWithRange):
3556 (AccessibilityUIElement::getChildAtIndex):
3558 2009-10-06 Mark Rowe <mrowe@apple.com>
3560 Reviewed by Simon Fraser.
3562 <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3564 * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3565 the fact we have already changed the working directory to the top of the open source tree.
3567 2009-10-06 Julie Parent <jparent@chromium.org>
3569 Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3570 rather than my committer email.
3572 * Scripts/modules/committers.py:
3574 2009-10-06 Jakub Wieczorek <faw217@gmail.com>
3576 Reviewed by Eric Seidel.
3578 [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3580 r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3581 it after each layout test as it should do, making the DRT dump additional output
3582 for all of the subsequent layout tests.
3584 * DumpRenderTree/qt/jsobjects.cpp:
3585 (LayoutTestController::reset):
3587 2009-10-06 Jakub Wieczorek <faw217@gmail.com>
3589 Reviewed by Simon Hausmann.
3591 [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3592 fast/dom/assign-to-window-status.html test, which is passing as a result.
3594 https://bugs.webkit.org/show_bug.cgi?id=30127
3596 * DumpRenderTree/qt/DumpRenderTree.cpp:
3597 (WebCore::DumpRenderTree::DumpRenderTree):
3598 (WebCore::DumpRenderTree::statusBarMessage):
3599 * DumpRenderTree/qt/DumpRenderTree.h:
3600 * DumpRenderTree/qt/jsobjects.h:
3601 (LayoutTestController::shouldDumpStatusCallbacks):
3602 (LayoutTestController::dumpStatusCallbacks):
3604 2009-10-06 Jakub Wieczorek <faw217@gmail.com>
3606 Reviewed by Simon Hausmann.
3608 [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3609 ignores the argument indicating which mouse button to trigger.
3610 https://bugs.webkit.org/show_bug.cgi?id=30048
3612 This affects the fast/events/mouse-click-events.html layout test.
3614 * DumpRenderTree/qt/jsobjects.cpp:
3615 (EventSender::mouseDown):
3616 (EventSender::mouseUp):
3617 * DumpRenderTree/qt/jsobjects.h:
3619 2009-10-06 Jakub Wieczorek <faw217@gmail.com>
3621 Reviewed by Simon Hausmann.
3623 [Qt] Fix the EventSender::keyDown() implementation
3624 https://bugs.webkit.org/show_bug.cgi?id=30043
3626 It should post both a key press event and a key release event,
3627 just like other ports do.
3629 * DumpRenderTree/qt/jsobjects.cpp:
3630 (EventSender::keyDown):
3632 2009-10-05 Kevin Ollivier <kevino@theolliviers.com>
3634 wx build fix. Add jpeg to the list of libs to link against.
3636 * wx/build/settings.py:
3638 2009-10-05 Jakub Wieczorek <faw217@gmail.com>
3640 Reviewed by Simon Hausmann.
3642 [Qt] EventSender::keyDown() cannot send function-key events.
3643 https://bugs.webkit.org/show_bug.cgi?id=30044
3645 This affects the fast/events/keydown-function-keys.html layout test.
3647 * DumpRenderTree/qt/jsobjects.cpp:
3648 (EventSender::keyDown):
3650 2009-10-05 Vadim Zeitlin <vadim@wxwidgets.org>
3652 Added --wx-compiler-prefix waf option to allow building wxWebKit with
3653 wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3655 * wx/build/settings.py:
3656 * wx/build/wxpresets.py:
3658 2009-10-05 Pavel Feldman <pfeldman@chromium.org>
3660 Reviewed by Timothy Hatcher.
3662 Web Inspector: add testing harness for Web Inspector.
3664 https://bugs.webkit.org/show_bug.cgi?id=30010
3666 * DumpRenderTree/LayoutTestController.cpp:
3667 (showWebInspectorCallback):
3668 (closeWebInspectorCallback):
3669 (evaluateInWebInspectorCallback):
3670 (LayoutTestController::staticFunctions):
3671 * DumpRenderTree/LayoutTestController.h:
3672 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3673 (LayoutTestController::showWebInspector):
3674 (LayoutTestController::closeWebInspector):
3675 (LayoutTestController::evaluateInWebInspector):
3676 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3677 (LayoutTestController::showWebInspector):
3678 (LayoutTestController::closeWebInspector):
3679 (LayoutTestController::evaluateInWebInspector):
3680 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3681 (LayoutTestController::showWebInspector):
3682 (LayoutTestController::closeWebInspector):
3683 (LayoutTestController::evaluateInWebInspector):
3684 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: