2009-11-25 Yuzo Fujishima <yuzo@google.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
2
3         Reviewed by Eric Seidel.
4
5         Update pywebsocket to 0.4.2
6
7         Update pywebsocket to 0.4.2
8         https://bugs.webkit.org/show_bug.cgi?id=31861
9
10         * pywebsocket/example/echo_client.py:
11         * pywebsocket/example/echo_wsh.py:
12         * pywebsocket/mod_pywebsocket/__init__.py:
13         * pywebsocket/mod_pywebsocket/dispatch.py:
14         * pywebsocket/mod_pywebsocket/msgutil.py:
15         * pywebsocket/mod_pywebsocket/standalone.py:
16         * pywebsocket/setup.py:
17         * pywebsocket/test/test_dispatch.py:
18         * pywebsocket/test/test_msgutil.py:
19
20 2009-11-25  Adam Barth  <abarth@webkit.org>
21
22         Reviewed by Eric Seidel.
23
24         Add unit test for mark-fixed
25         https://bugs.webkit.org/show_bug.cgi?id=31896
26
27         * Scripts/modules/commands/commandtest.py: Added.
28         * Scripts/modules/commands/queries_unittest.py:
29         * Scripts/modules/commands/upload_unittest.py: Added.
30         * Scripts/modules/mock_bugzillatool.py:
31         * Scripts/run-webkit-unittests:
32
33 2009-11-25  Adam Barth  <abarth@webkit.org>
34
35         Reviewed by Eric Seidel.
36
37         bugzilla-tool should have a mark-fixed command
38         https://bugs.webkit.org/show_bug.cgi?id=31853
39
40         Pretty simple stuff.
41
42         * Scripts/modules/commands/upload.py:
43
44 2009-11-25  Eric Seidel  <eric@webkit.org>
45
46         Reviewed by Adam Barth.
47
48         'bugzilla-tool help' should only show common commands like how 'git help' does
49         https://bugs.webkit.org/show_bug.cgi?id=31772
50
51         I also took this opportunity to make 'help' a real Command.
52         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
53
54         * Scripts/bugzilla-tool:
55          - change should_show_command_help to should_show_in_main_help
56         * Scripts/modules/commands/download.py:
57          - Mark commands as being shown in main help or not.
58          - show_in_main_help = False is not required (default is false),
59            but it seemed to make the commands more self-documenting.
60         * Scripts/modules/commands/queries.py: ditto
61         * Scripts/modules/commands/queues.py: ditto
62         * Scripts/modules/commands/upload.py: ditto
63         * Scripts/modules/multicommandtool.py:
64          - Make Command hold a pointer to tool in self.tool.  Most Command
65            subclasses do not take advantage of this yet, but it was required
66            for HelpCommand to be able to reach the tool from _help_epilog().
67          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
68          - Move MultiCommandTool._help_epilog to Command._help_epilog
69          - Move "help" logic into HelpCommand.execute()
70          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
71         * Scripts/modules/multicommandtool_unittest.py:
72          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
73
74 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
75
76         Reviewed by Dan Bernstein.
77         
78         Patch by Mark Rowe.
79
80         The buildbots are failing on Windows because when they were upgraded
81         to 4.0.4, Apple Application Support was not in their path. Add it to
82         the path to fix the buildots.
83
84         * Scripts/webkitdirs.pm:
85
86 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
87
88         Reviewed by David Kilzer.
89
90         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
91         https://bugs.webkit.org/show_bug.cgi?id=31799
92
93         * Scripts/run-webkit-tests: Fixed.
94
95 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
96
97         Reviewed by Eric Seidel.
98
99         Change run_command to give back stderr by default
100         https://bugs.webkit.org/show_bug.cgi?id=31734
101
102         Change run_command to give back stderr by default.
103         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
104         Change the related unittest call.
105
106         * Scripts/modules/scm.py:
107         * Scripts/modules/scm_unittest.py:
108
109 2009-11-25  Eric Seidel  <eric@webkit.org>
110
111         Reviewed by Adam Barth.
112
113         Centralize required argument parsing in Command
114         https://bugs.webkit.org/show_bug.cgi?id=31872
115
116         * Scripts/modules/commands/download.py: remove custom required arg message.
117         * Scripts/modules/commands/upload.py: ditto.
118         * Scripts/modules/multicommandtool.py:
119          - Add _parse_required_arguments.
120          - Pass program name off to OptionParser.
121          - Add name() for access to tool name.
122          - Add check_arguments_and_execute and make it return a return code.
123          - Replace a couple uses of + with %.
124         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
125
126 2009-11-25  Eric Seidel  <eric@webkit.org>
127
128         Reviewed by Adam Barth.
129
130         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
131         https://bugs.webkit.org/show_bug.cgi?id=31870
132
133         * Scripts/modules/commands/queries_unittest.py: Use the new class.
134         * Scripts/modules/multicommandtool_unittest.py: Ditto.
135         * Scripts/modules/outputcapture.py: Added.
136
137 2009-11-24  Dmitry Titov  <dimich@chromium.org>
138
139         Reviewed by Eric Seidel.
140
141         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
142         https://bugs.webkit.org/show_bug.cgi?id=31444
143
144         * Scripts/build-webkit:
145
146 2009-11-24  Chris Marrin  <cmarrin@apple.com>
147
148         Reviewed by Simon Fraser.
149
150         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
151         https://bugs.webkit.org/show_bug.cgi?id=27314
152         
153         Now the script allows the directories with these tests to be included on all
154         platforms but Mac, where they behave the same as always. For all other platforms
155         the tests need to be excluded using the Skipped files, which is currently done
156         for all platforms (including win since we're not turned on yet)
157
158         * Scripts/webkitdirs.pm:
159
160 2009-11-24  Eric Seidel  <eric@webkit.org>
161
162         Reviewed by Adam Barth.
163
164         queries_unittest.py should test command output
165         https://bugs.webkit.org/show_bug.cgi?id=31845
166
167         * Scripts/modules/commands/queries_unittest.py:
168          - Capture stdout and stderr and compare with expected strings.
169
170 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
171
172         No Review.
173
174         Fix spelling error ("depenedencies").
175
176         * Scripts/build-webkit:
177
178 2009-11-24  Mark Rowe  <mrowe@apple.com>
179
180         Land the configuration that includes the two debug GTK Linux builders.
181
182         * BuildSlaveSupport/build.webkit.org-config/config.json:
183
184 2009-11-24  David Kilzer  <ddkilzer@apple.com>
185
186         <http://webkit.org/b/31840> bisect-builds broke after r50080
187
188         Reviewed by Dan Bernstein.
189
190         * Scripts/bisect-builds:
191         (mountAndRunNightly): Switched back to using backticks to run
192         the hdiutil command since exec() will terminate the existing
193         script, which is not what we want.  Store the output of
194         File::Spec->devnull() in a variable for use in the hdiutil
195         detach commands.
196
197 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
198
199         Reviewed by Kenneth Rohde Christiansen.
200
201         Include "config.h" to meet Coding Style Guidelines
202         https://bugs.webkit.org/show_bug.cgi?id=31792
203
204         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
205         * DumpRenderTree/qt/jsobjects.cpp:
206         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
207
208 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
209
210         Reviewed by Oliver Hunt.
211
212         Implement new required function to pass test we used to pass. This
213         change is required since r51294.
214
215         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
216         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
217
218 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
219
220         Reviewed by Kenneth Rohde Christiansen.
221
222         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
223         https://bugs.webkit.org/show_bug.cgi?id=31775
224
225         LayoutTestController::dumpBackForwardList() should work with local URLs
226         as well as with normal URLs (in http tests for instance).
227         Currently it does not output the latter properly.
228
229         Unskip a bunch of passing http/navigation tests.
230
231         * DumpRenderTree/qt/DumpRenderTree.cpp:
232         (WebCore::dumpHistoryItem):
233
234 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
235
236         Reviewed by Oliver Hunt.
237
238         ARIA: support aria-flowto
239         https://bugs.webkit.org/show_bug.cgi?id=31762
240
241         * DumpRenderTree/AccessibilityUIElement.cpp:
242         (ariaFlowToElementAtIndexCallback):
243         (AccessibilityUIElement::getJSClass):
244         * DumpRenderTree/AccessibilityUIElement.h:
245         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
246         (AccessibilityUIElement::ariaFlowToElementAtIndex):
247         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
248         (AccessibilityUIElement::ariaFlowToElementAtIndex):
249         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
250         (AccessibilityUIElement::ariaFlowToElementAtIndex):
251
252 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
253
254         Reviewed by Kenneth Christiansen.
255
256         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
257         https://bugs.webkit.org/show_bug.cgi?id=31638
258
259         Unfreeze WorkQueue after each test execution.
260
261         * DumpRenderTree/qt/DumpRenderTree.cpp:
262         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
263
264 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
265
266         Reviewed by Adam Barth.
267
268         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
269         for localhost and 127.0.0.1.
270         https://bugs.webkit.org/show_bug.cgi?id=31783
271
272         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
273
274         * DumpRenderTree/qt/DumpRenderTree.cpp:
275         (WebCore::NetworkAccessManager::NetworkAccessManager):
276         (WebCore::NetworkAccessManager::sslErrorsEncountered):
277         (WebCore::WebPage::WebPage):
278         * DumpRenderTree/qt/DumpRenderTree.h:
279
280 2009-11-22  Chris Evans  <cevans@chromium.org>
281
282         Reviewed by Adam Barth.
283
284         Disable access to file:/// directory listings
285         https://bugs.webkit.org/show_bug.cgi?id=31329
286
287         Implemented setAllowUniversalAccessFromFileURLs to support testing of
288         file URL security.
289
290         * DumpRenderTree/LayoutTestController.cpp:
291         (setAllowUniversalAccessFromFileURLsCallback):
292         (LayoutTestController::staticFunctions):
293         * DumpRenderTree/LayoutTestController.h:
294         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
295         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
296         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
297         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
298         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
299         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
300         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
301         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
302
303 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
304
305         Reviewed by Kenneth Rohde Christiansen.
306
307         [Qt] Fix the timeout of fast/frames/frame-navigation.html
308         https://bugs.webkit.org/show_bug.cgi?id=31638
309
310         The test is timeouting, because it uses the WorkQueue to load a document in one
311         of the child frames and once the loading is finished, the DRT does not dump the
312         tree. This is because it waits for the QWebFrame::loadFinished() signal from
313         the main frame, while it should connect to QWebPage::loadFinished().
314
315         * DumpRenderTree/qt/DumpRenderTree.cpp:
316         (WebCore::DumpRenderTree::DumpRenderTree):
317
318 2009-11-21  Eric Seidel  <eric@webkit.org>
319
320         Reviewed by Adam Barth.
321
322         bugzilla-tool --help spews way too much text
323         https://bugs.webkit.org/show_bug.cgi?id=31771
324
325         * Scripts/bugzilla-tool:
326          - Remove self.cached_scm initialization hack.
327         * Scripts/modules/buildbot.py:
328          - Make default_host accessible to callers.
329         * Scripts/modules/commands/download.py:
330          - Phrase help for all commands consistently and remove spurious help text punctuation.
331         * Scripts/modules/commands/queries.py: Ditto.
332         * Scripts/modules/commands/queues.py: Ditto.
333         * Scripts/modules/commands/upload.py: Ditto.
334         * Scripts/modules/multicommandtool.py:
335          - Add HelpPrintingOptionParser.format_epilog to replace
336            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
337            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
338          - Make --help only show a list of commands like "svn help" and "git help" do --
339            previously --help was listing all commands and options.
340          - Sort list of commands alphabetically.
341
342 2009-11-21  Eric Seidel  <eric@webkit.org>
343
344         No review.  Fixing a typo from the previous patch for bug 31767.
345
346         AbstractQueue.run_bugzilla_tool throws an exception
347         https://bugs.webkit.org/show_bug.cgi?id=31769
348
349         * Scripts/modules/commands/queues.py:
350
351 2009-11-21  Eric Seidel  <eric@webkit.org>
352
353         Reviewed by Adam Barth.
354
355         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
356         https://bugs.webkit.org/show_bug.cgi?id=31767
357
358         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
359         Since we don't have a good way to test BugzillaTool pieces, I've
360         left out a test for now.
361
362         * Scripts/bugzilla-tool:
363          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
364         * Scripts/modules/commands/queues.py:
365          - Use tool.path() instead of __file__.
366         * Scripts/modules/multicommandtool.py:
367          - Add a new path() method to MultiComandTool.
368         * Scripts/modules/multicommandtool_unittest.py:
369          - Provide a path() method.  Little point in testing this mock implementation.
370
371 2009-11-21  Adam Barth  <abarth@webkit.org>
372
373         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
374         WebKitTools.
375
376         * Scripts/modules/commands/download.py:
377
378 2009-11-21  Adam Barth  <abarth@webkit.org>
379
380         Reviewed by Eric Seidel.
381
382         Convert check-style to use LandingSequence
383         https://bugs.webkit.org/show_bug.cgi?id=31763
384
385         Instead of manipulating the working copy by hand, we should use the
386         LandingSequence in CheckStyle.  This will make this code eaiser to
387         test.
388
389         * Scripts/modules/commands/download.py:
390
391 2009-11-20  Adam Barth  <abarth@webkit.org>
392
393         Reviewed by Eric Seidel.
394
395         Unit test query commands
396         https://bugs.webkit.org/show_bug.cgi?id=31755
397
398         These tests are pretty rough, but hopefully they'll grow.
399
400         * Scripts/modules/commands/queries_unittest.py: Added.
401         * Scripts/modules/mock_bugzillatool.py: Added.
402         * Scripts/run-webkit-unittests:
403
404 2009-11-20  Eric Seidel  <eric@webkit.org>
405
406         Reviewed by Adam Barth.
407
408         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
409         https://bugs.webkit.org/show_bug.cgi?id=31758
410
411         * Scripts/modules/multicommandtool.py:
412          - Allow passing of explicit commands to MultiCommandTool.__init__
413         * Scripts/modules/multicommandtool_unittest.py:
414          - Use new Command.name naming system.
415          - Test Command auto-discovery.
416         * Scripts/modules/workqueue.py:
417          - bug_id no longer exists, use patch['bug_id'] instead.
418         * Scripts/modules/workqueue_unittest.py:
419          - WorkQueues require names now.
420          - should_proceed_with_work_item must return a patch object.
421
422 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
423
424         Reviewed by Beth Dakin.
425
426         WAI-ARIA: add support for aria-owns
427         https://bugs.webkit.org/show_bug.cgi?id=31702
428
429         * DumpRenderTree/AccessibilityUIElement.cpp:
430         (ariaOwnsElementAtIndexCallback):
431         (AccessibilityUIElement::getJSClass):
432         * DumpRenderTree/AccessibilityUIElement.h:
433         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
434         (AccessibilityUIElement::ariaOwnsElementAtIndex):
435         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
436         (AccessibilityUIElement::ariaOwnsElementAtIndex):
437         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
438         (AccessibilityUIElement::ariaOwnsElementAtIndex):
439
440 2009-11-20  Eric Seidel  <eric@webkit.org>
441
442         Reviewed by Adam Barth.
443
444         Fix exception thrown when running the commit-queue.
445
446         * Scripts/modules/statusbot.py: patch is optional.
447         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
448
449 2009-11-20  Eric Seidel  <eric@webkit.org>
450
451         Reviewed by Adam Barth.
452
453         Teach the StatusBot how to support more than just the commit-queue
454         https://bugs.webkit.org/show_bug.cgi?id=31754
455
456         * Scripts/modules/workqueue.py: Another typo.
457
458 2009-11-20  Eric Seidel  <eric@webkit.org>
459
460         Reviewed by Adam Barth.
461
462         Teach the StatusBot how to support more than just the commit-queue
463         https://bugs.webkit.org/show_bug.cgi?id=31754
464
465         * Scripts/modules/commands/queues.py: Fix silly typo.
466
467 2009-11-20  Eric Seidel  <eric@webkit.org>
468
469         Reviewed by Adam Barth.
470
471         Teach the StatusBot how to support more than just the commit-queue
472         https://bugs.webkit.org/show_bug.cgi?id=31754
473
474         * CommitQueueStatus/index.yaml:
475          - Add indices required for the new queries.
476         * CommitQueueStatus/queue_status.py:
477          - Add a patch-status page and move update_status to update-status.
478          - Only display "commit-queue" status records for the commit-queue.
479          - Add support for a queue_name property on status records.
480          - Fix _int_from_request to actually work.
481         * CommitQueueStatus/update_status.html:
482          - Add support for a queue_name on status records.
483          - Remove unused list of bug ids.
484          * Scripts/modules/commands/queues.py
485           - Make the queues pass the patch instead of the bug_id to StatusBot.
486         * Scripts/modules/statusbot.py:
487          - Support passing the queue_name to the status updates.
488          - Support fetching patch status with patch_status().
489         * Scripts/modules/workqueue.py:
490          - Pass the patch to the StatusBot instead of the bug_id.
491          - Let WorkQueues have a name.
492
493 2009-11-20  Adam Barth  <abarth@webkit.org>
494
495         Reviewed by Eric Seidel.
496
497         Move bugzilla-tool commands into their own file
498         https://bugs.webkit.org/show_bug.cgi?id=31752
499
500         This will let us write unit tests.
501
502         * Scripts/bugzilla-tool:
503         * Scripts/modules/commands/__init__.py: Added.
504         * Scripts/modules/commands/download.py: Added.
505         * Scripts/modules/commands/queries.py: Added.
506         * Scripts/modules/commands/queues.py: Added.
507         * Scripts/modules/commands/upload.py: Added.
508         * Scripts/modules/grammar.py: Added.
509
510 2009-11-20  Adam Barth  <abarth@webkit.org>
511
512         Reviewed by Eric Seidel.
513
514         BuildQueue should check if the tree is currently buildable
515         https://bugs.webkit.org/show_bug.cgi?id=31744
516
517         * Scripts/bugzilla-tool:
518         * Scripts/modules/landingsequence.py:
519         * Scripts/modules/webkitlandingscripts.py:
520
521 2009-11-20  Adam Barth  <abarth@webkit.org>
522
523         Reviewed by Eric Seidel.
524
525         Move prepare_clean_working_directory into the LandingSequence
526         https://bugs.webkit.org/show_bug.cgi?id=31743
527
528         * Scripts/bugzilla-tool:
529         * Scripts/modules/landingsequence.py:
530
531 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
532
533         Reviewed by Kenneth Rohde Christiansen.
534
535         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
536         https://bugs.webkit.org/show_bug.cgi?id=30460
537
538         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
539
540         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
541         (pluginInvoke):
542
543 2009-11-20  Adam Barth  <abarth@webkit.org>
544
545         Reviewed by Eric Seidel.
546
547         Pass the port information to the child process
548         https://bugs.webkit.org/show_bug.cgi?id=31736
549
550         We need to do this so the child process knows what to build!
551
552         * Scripts/bugzilla-tool:
553         * Scripts/modules/landingsequence.py:
554         * Scripts/modules/webkitport.py:
555         * Scripts/modules/webkitport_unittest.py:
556
557 2009-11-20  Adam Barth  <abarth@webkit.org>
558
559         Reviewed by Eric Seidel.
560
561         Support Qt port in build-queue
562         https://bugs.webkit.org/show_bug.cgi?id=31733
563
564         * Scripts/bugzilla-tool:
565
566 2009-11-20  Adam Barth  <abarth@webkit.org>
567
568         Reviewed by Eric Seidel.
569
570         Implement a build-queue
571         https://bugs.webkit.org/show_bug.cgi?id=31725
572
573         Currently this just builds the first 10 patches in the review queue.
574         We'll want to do something smarter soon.
575
576         * Scripts/bugzilla-tool:
577
578 2009-11-20  Adam Barth  <abarth@webkit.org>
579
580         Reviewed by Eric Seidel.
581
582         Make commit-queue and style-queue show up in help
583         https://bugs.webkit.org/show_bug.cgi?id=31724
584
585         We need to store their names on their class to make these commands
586         properly register themselves with MultiCommandTool.
587
588         * Scripts/bugzilla-tool:
589
590 2009-11-20  Adam Barth  <abarth@webkit.org>
591
592         Reviewed by Eric Seidel.
593
594         Implement bugzilla-tool build-attachment
595         https://bugs.webkit.org/show_bug.cgi?id=31722
596
597         This command builds an attachment from bugzilla.  It leaves the built
598         patch in the working copy.
599
600         * Scripts/bugzilla-tool:
601         * Scripts/modules/landingsequence.py:
602         * Scripts/modules/webkitlandingscripts.py:
603
604 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
605
606         Reviewed by Xan Lopez.
607
608         [GTK] DRT release event does not create the state correctly
609         https://bugs.webkit.org/show_bug.cgi?id=31717
610
611         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
612
613 2009-11-20  Eric Seidel  <eric@webkit.org>
614
615         Reviewed by Adam Barth.
616
617         MultiCommandTool should find Command objects automatically instead of with a manual list
618         https://bugs.webkit.org/show_bug.cgi?id=31710
619
620         * Scripts/bugzilla-tool:
621         * Scripts/modules/multicommandtool.py:
622          - Use some wild python-fu to crawl all the known subclasses of Command.
623
624 2009-11-20  Adam Barth  <abarth@webkit.org>
625
626         Unreviewed "build" fix.  Added missing import.
627
628         * Scripts/bugzilla-tool:
629
630 2009-11-20  Adam Barth  <abarth@webkit.org>
631
632         Unreviewed "build" fix.  I failed to update LandingSequence.test
633         properly.
634
635         * Scripts/modules/landingsequence.py:
636
637 2009-11-20  Adam Barth  <abarth@webkit.org>
638
639         Reviewed by Eric Seidel.
640
641         Create LandingSequence as the all-sing, all-dance landing class
642         https://bugs.webkit.org/show_bug.cgi?id=31709
643
644         Client can inherit from this class to carefully control exactly which
645         steps they wish to have happen in the landing sequence.
646
647         * Scripts/bugzilla-tool:
648         * Scripts/modules/landingsequence.py: Added.
649         * Scripts/modules/webkitlandingscripts.py: Added.
650
651 2009-11-19  Adam Barth  <abarth@webkit.org>
652
653         Reviewed by Eric Seidel.
654
655         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
656         https://bugs.webkit.org/show_bug.cgi?id=31707
657
658         This is to help when we implement build-attachment.
659
660         * Scripts/bugzilla-tool:
661
662 2009-11-19  Adam Barth  <abarth@webkit.org>
663
664         Reviewed by Eric Seidel.
665
666         Support Qt port in bugzilla-tool
667         https://bugs.webkit.org/show_bug.cgi?id=31701
668
669         Now we support building with Qt!
670
671         * Scripts/bugzilla-tool:
672         * Scripts/modules/webkitport.py: Added.
673         * Scripts/modules/webkitport_unittest.py: Added.
674         * Scripts/run-webkit-unittests:
675
676 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
677
678         Reviewed by Adam Barth.
679
680         Remove inserting stderr into patch in bugzilla-tool
681         https://bugs.webkit.org/show_bug.cgi?id=29914
682
683         Modify SCM python module's run_command function to avoid return of stderr
684         by default, so stderr won't be inserted into the patches.
685         Modify the related unit test.
686
687         * Scripts/modules/scm.py:
688         * Scripts/modules/scm_unittest.py:
689
690 2009-11-19  Eric Seidel  <eric@webkit.org>
691
692         Reviewed by Adam Barth.
693
694         bugzilla-tool needs per-command help
695         https://bugs.webkit.org/show_bug.cgi?id=31697
696
697         Added support for "bugzilla-tool help command-name"
698         and a unit test to make sure it works.
699
700         * Scripts/modules/multicommandtool.py:
701         * Scripts/modules/multicommandtool_unittest.py:
702
703 2009-11-19  Eric Seidel  <eric@webkit.org>
704
705         Reviewed by Adam Barth.
706
707         Move MultiCommandTool and Command into a separate file and add some basic unit tests
708         https://bugs.webkit.org/show_bug.cgi?id=31695
709
710         * Scripts/bugzilla-tool:
711         * Scripts/modules/multicommandtool.py: Added.
712         * Scripts/modules/multicommandtool_unittest.py: Added.
713         * Scripts/run-webkit-unittests:
714
715 2009-11-19  Eric Seidel  <eric@webkit.org>
716
717         No review, just adding a FIXME.
718
719         Split out command parsing and help printing from BugzillaTool
720         https://bugs.webkit.org/show_bug.cgi?id=31688
721
722         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
723
724 2009-11-19  Eric Seidel  <eric@webkit.org>
725
726         Reviewed by Adam Barth.
727
728         Split out command parsing and help printing from BugzillaTool
729         https://bugs.webkit.org/show_bug.cgi?id=31688
730
731         * Scripts/bugzilla-tool:
732          - Add new MultiCommandTool class to contain option parsing and help printing logic.
733          - Rename private methods to use _ pattern.
734          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
735          - 
736
737 2009-11-19  Eric Seidel  <eric@webkit.org>
738
739         Reviewed by Adam Barth.
740
741         Re-factor help printing to use modern python idioms
742         https://bugs.webkit.org/show_bug.cgi?id=31685
743
744         * Scripts/bugzilla-tool:
745
746 2009-11-19  Eric Seidel  <eric@webkit.org>
747
748         Reviewed by Darin Adler.
749
750         commit-queue empty queue logs twice
751         https://bugs.webkit.org/show_bug.cgi?id=31679
752
753         * Scripts/bugzilla-tool:
754
755 2009-11-19  Eric Seidel  <eric@webkit.org>
756
757         Reviewed by Darin Adler.
758
759         bugzilla-tool's reviewer/committer rejection message should be clearer
760         https://bugs.webkit.org/show_bug.cgi?id=31126
761
762         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
763
764         * Scripts/modules/bugzilla.py:
765
766 2009-11-19  Eric Z. Ayers  <zundel@google.com>
767
768         Reviewed by Pavel Feldman.
769
770         Forces a WM_PAINT event on calling layoutTestController.display()
771         in order to enable the timeline-paint.html test on Windows.
772         ::UpdateWindow() does not force an event becaue the window is 
773         not visible.
774
775         https://bugs.webkit.org/show_bug.cgi?id=31402
776
777         * DumpRenderTree/win/DumpRenderTree.cpp:
778         (displayWebView):
779
780 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
781
782         No review needed.
783
784         Added myself to committers list.
785
786         * Scripts/modules/committers.py:
787
788 2009-11-19  Adam Barth  <abarth@webkit.org>
789
790         Reviewed by Eric Seidel.
791
792         Bugzilla-tool command classes should match command names
793         https://bugs.webkit.org/show_bug.cgi?id=31666
794
795         I renamed all the commands except CommitMessageForCurrentDiff because
796         the new name would conflict with an existing class.
797
798         * Scripts/bugzilla-tool:
799
800 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
801
802         Reviewed by Gustavo Noronha Silva.
803
804         Web Inspector: Implement "show inspector" in WebKit GTK
805         API and enable console tests.
806
807         https://bugs.webkit.org/show_bug.cgi?id=31669
808
809         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
810         (LayoutTestController::showWebInspector):
811
812 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
813
814         Reviewed by Simon Hausmann.
815
816         Minor refactoring + more documentation.
817
818         * DumpRenderTree/qt/DumpRenderTree.cpp:
819         (WebCore::clearHistory):
820         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
821
822 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
823
824         Reviewed by Eric Seidel.
825
826         Ignore websocket tests when --no-http is specified.
827         https://bugs.webkit.org/show_bug.cgi?id=31662
828
829         * Scripts/run-webkit-tests:
830
831 2009-11-18  Adam Barth  <abarth@webkit.org>
832
833         Reviewed by Eric Seidel.
834
835         Normalize ' and " in bugzilla-tool
836         https://bugs.webkit.org/show_bug.cgi?id=31655
837
838         We decided " is better than ' and we should be consistent.
839
840         * Scripts/bugzilla-tool:
841
842 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
843
844         Reviewed by Kenneth Rohde Christiansen.
845
846         [Qt] Remove support for Qt v4.3 or older versions
847         https://bugs.webkit.org/show_bug.cgi?id=29469
848
849         * DumpRenderTree/qt/DumpRenderTree.pro:
850         * DumpRenderTree/qt/ImageDiff.pro:
851
852 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
853
854         Reviewed by Eric Seidel.
855
856         GitTest.test_create_binary_patch fails if /tmp is symlink
857         https://bugs.webkit.org/show_bug.cgi?id=31536
858
859         * Scripts/modules/scm_unittest.py:
860
861 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
862
863         Reviewed by Darin Adler.
864
865         Configuration for Chromium Build Slaves.
866
867         https://bugs.webkit.org/show_bug.cgi?id=31442
868
869         * BuildSlaveSupport/build.webkit.org-config/config.json:
870         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
871
872 2009-11-18  Eric Seidel  <eric@webkit.org>
873
874         Reviewed by Darin Adler.
875
876         workqueue.py results in totally broken commit-queue UI
877         https://bugs.webkit.org/show_bug.cgi?id=31645
878
879         * Scripts/bugzilla-tool:
880          - Remove unneeded use of PatchCollection.
881          - Grab a new copy of the cq'd patches every run of the queue.
882
883 2009-11-18  Sam Weinig  <sam@webkit.org>
884
885         Reviewed by Anders Carlsson.
886
887         Make the Mac Geolocation API async.
888
889         Update DRT to use the new async Mac Geolocation API.
890
891         * DumpRenderTree/mac/UIDelegate.mm:
892         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
893
894 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
895
896         Reviewed by Kenneth Rohde Christiansen.
897
898         Add and option to toggle HTML5 datalist support to build-webkit
899         https://bugs.webkit.org/show_bug.cgi?id=31599
900
901         * Scripts/build-webkit:
902
903 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
904
905         Reviewed by Kevin Ollivier.
906
907         Enable wx plugin support using the Windows implementation as a base.
908         
909         https://bugs.webkit.org/show_bug.cgi?id=31636
910
911         * wx/build/settings.py:
912
913 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
914
915         Reviewed by Simon Hausmann.
916
917         Change the initialization order so that the controllers
918         will be created before exporting them to the JS DOM window.
919
920         * DumpRenderTree/qt/DumpRenderTree.cpp:
921         (WebCore::DumpRenderTree::DumpRenderTree):
922
923 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
924
925         Reviewed by Simon Hausmann.
926
927         Fix a code copy and paste error. m_page should be page.
928
929         * DumpRenderTree/qt/DumpRenderTree.cpp:
930         (WebCore::DumpRenderTree::createWindow):
931
932 2009-11-17  Mark Rowe  <mrowe@apple.com>
933
934         Reviewed by Alexey Proskuryakov.
935
936         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
937
938         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
939         This prevents symlinks from confusing the descendant check.
940
941 2009-11-17  Mark Rowe  <mrowe@apple.com>
942
943         Reviewed by Alexey Proskuryakov.
944
945         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
946
947         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
948         server to be up rather than having run-webkit-tests abort immediately.
949
950         * Scripts/run-webkit-tests:
951
952 2009-11-17  Eric Seidel  <eric@webkit.org>
953
954         Reviewed by Darin Adler.
955
956         commit-queue is failing to set reviewer in ChangeLogs
957         https://bugs.webkit.org/show_bug.cgi?id=31592
958
959         * Scripts/bugzilla-tool: Clarify the "applying" log message.
960         * Scripts/modules/bugzilla.py:
961          - Add a new _validate_committer_and_reviewer function as a
962            temporary solution until we can make a real Attachment object
963            which knows how to fill in its committer/reviewer fields automatically.
964
965 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
966
967         Unreviewed buildbot fix.
968
969         Revert part of earlier patch and add comment, as it
970         was causing timeouts on the buildbot.
971
972         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
973         (LayoutTestController::notifyDone):
974
975 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
976
977         Reviewed by Oliver Hunt.
978
979         Make the timeout 15 sec as for the other DRT's and make
980         it print out the same output when a test timeout.
981
982         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
983         (LayoutTestController::waitUntilDone):
984         (LayoutTestController::notifyDone):
985         (LayoutTestController::timerEvent):
986
987 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
988
989         Reviewed by Timothy Hatcher.
990
991         Fixed typos in comments.
992
993         * Scripts/modules/committers.py:
994
995 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
996
997         Reviewed by Timothy Hatcher.
998
999         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1000         - Updated DRT to show/close inspector for all tests under /inspector
1001         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1002           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1003         - Removed reload on each inspector test
1004         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1005         inspector for those.
1006         - Reimplemented timeline tests in order to get rid of reload there.
1007         - Moved tests that don't require harness into the fast group.
1008
1009         https://bugs.webkit.org/show_bug.cgi?id=31472
1010
1011         * DumpRenderTree/LayoutTestController.cpp:
1012         (setTimelineProfilingEnabledCallback):
1013         (closeWebInspectorCallback):
1014         (LayoutTestController::staticFunctions):
1015         * DumpRenderTree/LayoutTestController.h:
1016         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1017         (shouldOpenWebInspector):
1018         (runTest):
1019         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1020         (LayoutTestController::setTimelineProfilingEnabled):
1021         * DumpRenderTree/mac/DumpRenderTree.mm:
1022         (shouldOpenWebInspector):
1023         (runTest):
1024         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1025         (LayoutTestController::setTimelineProfilingEnabled):
1026         * DumpRenderTree/win/DumpRenderTree.cpp:
1027         (shouldOpenWebInspector):
1028         (runTest):
1029         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1030         (LayoutTestController::setTimelineProfilingEnabled):
1031
1032 2009-11-17  Oliver Hunt  <oliver@apple.com>
1033
1034         Reviewed by Maciej Stachowiak.
1035
1036         Incorrect use of JavaScriptCore API in DumpRenderTree
1037         https://bugs.webkit.org/show_bug.cgi?id=31577
1038
1039         Return undefined rather than a literal null.
1040
1041         * DumpRenderTree/AccessibilityUIElement.cpp:
1042         (setSelectedTextRangeCallback):
1043         (incrementCallback):
1044         (decrementCallback):
1045         (showMenuCallback):
1046
1047 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1048
1049         Reviewed by Beth Dakin.
1050
1051         AX: aria-labelledby duplicates some of its WAI-ARIA label
1052         https://bugs.webkit.org/show_bug.cgi?id=31565
1053
1054         * DumpRenderTree/AccessibilityUIElement.cpp:
1055         (titleUIElementCallback):
1056         (getIsValidCallback):
1057         (AccessibilityUIElement::getJSClass):
1058
1059 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1060
1061         Reviewed by Simon Hausmann.
1062
1063         r50942 broke output from created windows. Make the
1064         m_enableTextOutput a member of the DRT and not the
1065         WebPage.
1066
1067         * DumpRenderTree/qt/DumpRenderTree.cpp:
1068         (WebCore::WebPage::WebPage):
1069         (WebCore::WebPage::javaScriptAlert):
1070         (WebCore::WebPage::javaScriptConsoleMessage):
1071         (WebCore::WebPage::javaScriptConfirm):
1072         (WebCore::WebPage::javaScriptPrompt):
1073         (WebCore::WebPage::acceptNavigationRequest):
1074         (WebCore::DumpRenderTree::DumpRenderTree):
1075         (WebCore::DumpRenderTree::open):
1076         (WebCore::DumpRenderTree::createWindow):
1077         * DumpRenderTree/qt/DumpRenderTree.h:
1078         (WebCore::DumpRenderTree::setTextOutputEnabled):
1079         (WebCore::DumpRenderTree::isTextOutputEnabled):
1080         (WebCore::WebPage::shouldInterruptJavaScript):
1081         (WebCore::WebPage::isTextOutputEnabled):
1082         (WebCore::WebPage::setViewGeometry):
1083
1084 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1085
1086         Reviewed by Gustavo Noronha Silva.
1087
1088         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1089         as the implementation is being used by at least Qt and Gtk+.
1090
1091         Update buildsystems as well.
1092
1093         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1094         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1095         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1096         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1097         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1098         * GNUmakefile.am:
1099
1100 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1101
1102         Reviewed by Alexey Proskuryakov.
1103
1104         Disable wss until all platforms support pyOpenSSL
1105
1106         https://bugs.webkit.org/show_bug.cgi?id=31479
1107
1108         * Scripts/run-webkit-tests:
1109
1110 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1111
1112         Reviewed by Kenneth Christiansen.
1113
1114         [Qt] Implement load error pages support for Qt's DRT.
1115         https://bugs.webkit.org/show_bug.cgi?id=31509
1116
1117         For now, it will not be a default feature, and layout tests
1118         that want to make use of this have to explicitily call
1119         'handleErrorPages();' for the test source.
1120
1121         Any of the other DumpRenderTree's (mac, win and gtk)
1122         support handling error pages. Qt's will be the first.
1123
1124         * DumpRenderTree/qt/DumpRenderTree.cpp:
1125         (WebCore::WebPage::supportsExtension):
1126         (WebCore::WebPage::extension):
1127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1128         (LayoutTestController::reset):
1129         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1130         (LayoutTestController::shouldHandleErrorPages):
1131         (LayoutTestController::handleErrorPages):
1132
1133 2009-11-16  Eric Seidel  <eric@webkit.org>
1134
1135         Reviewed by Adam Barth.
1136
1137         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1138         https://bugs.webkit.org/show_bug.cgi?id=31549
1139
1140         Renamed --commit-queue to --non-interactive in most places
1141         and remove the code in land-patches which is no longer needed.
1142
1143         * Scripts/bugzilla-tool:
1144
1145 2009-11-16  Eric Seidel  <eric@webkit.org>
1146
1147         Reviewed by Adam Barth.
1148
1149         The commit-queue should use land-attachment
1150         https://bugs.webkit.org/show_bug.cgi?id=31548
1151
1152         * Scripts/bugzilla-tool:
1153
1154 2009-11-16  Adam Barth  <abarth@webkit.org>
1155
1156         Reviewed by Eric Seidel.
1157
1158         Convert CommitQueue over to PatchCollection
1159         https://bugs.webkit.org/show_bug.cgi?id=31547
1160
1161         Also fixes a bug in workqueue and adds a test!
1162
1163         * Scripts/bugzilla-tool:
1164         * Scripts/modules/workqueue.py:
1165         * Scripts/modules/workqueue_unittest.py:
1166
1167 2009-11-16  Adam Barth  <abarth@webkit.org>
1168
1169         Reviewed by Eric Seidel.
1170
1171         Move StyleQueue over to using PatchCollection
1172         https://bugs.webkit.org/show_bug.cgi?id=31544
1173
1174         That's what the class it's for.
1175
1176         * Scripts/bugzilla-tool:
1177         * Scripts/modules/patchcollection.py:
1178         * Scripts/modules/patchcollection_unittest.py:
1179
1180 2009-11-16  Eric Seidel  <eric@webkit.org>
1181
1182         Reviewed by Adam Barth.
1183
1184         bugzilla-tool needs a land-attachment command
1185         https://bugs.webkit.org/show_bug.cgi?id=31546
1186
1187         * Scripts/bugzilla-tool:
1188          - Move all the logic into AbstractLandingCommand and
1189            add a new LandAttachment command subclass.
1190          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1191
1192 2009-11-16  Eric Seidel  <eric@webkit.org>
1193
1194         Reviewed by Adam Barth.
1195
1196         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1197         https://bugs.webkit.org/show_bug.cgi?id=31543
1198
1199         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1200
1201         * Scripts/bugzilla-tool:
1202
1203 2009-11-16  Eric Seidel  <eric@webkit.org>
1204
1205         Reviewed by Adam Barth.
1206
1207         Disable the style queue from posting to the commit queue status page.
1208
1209         * Scripts/bugzilla-tool:
1210
1211 2009-11-16  Adam Barth  <abarth@webkit.org>
1212
1213         Reviewed by Eric Seidel.
1214
1215         Implement PatchCollection
1216         https://bugs.webkit.org/show_bug.cgi?id=31541
1217
1218         This class holds a set of patches and lets clients iterate through
1219         them.  Optionally, clients can install a filter.
1220
1221         * Scripts/modules/patchcollection.py: Added.
1222         * Scripts/modules/patchcollection_unittest.py: Added.
1223         * Scripts/run-webkit-unittests:
1224
1225 2009-11-16  Eric Seidel  <eric@webkit.org>
1226
1227         Reviewed by Adam Barth.
1228
1229         bugzilla-tool land-patches will close bugs with patches r=?
1230         https://bugs.webkit.org/show_bug.cgi?id=28230
1231
1232         The commit-queue shouldn't close patches with outstanding reviews on them,
1233         even if many reviewers seem to be against multi-patch bugs.
1234
1235         * Scripts/bugzilla-tool:
1236
1237 2009-11-16  Eric Seidel  <eric@webkit.org>
1238
1239         Reviewed by Adam Barth.
1240
1241         bugzilla-tool check-style should work with attachment ids instead of bug ids
1242         https://bugs.webkit.org/show_bug.cgi?id=31540
1243
1244         * Scripts/bugzilla-tool:
1245
1246 2009-11-16  Eric Seidel  <eric@webkit.org>
1247
1248         Reviewed by Adam Barth.
1249
1250         WorkQueue is the only place that should know about special exit codes
1251         https://bugs.webkit.org/show_bug.cgi?id=31534
1252
1253         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1254         and add tests for handling exit codes.
1255         I also cleaned up workqueue_unittest.py more.
1256
1257         * Scripts/bugzilla-tool:
1258         * Scripts/modules/workqueue.py:
1259         * Scripts/modules/workqueue_unittest.py:
1260
1261 2009-11-16  Eric Seidel  <eric@webkit.org>
1262
1263         Reviewed by Adam Barth.
1264
1265         Re-factor workqueue_unittest to allow for more than one test.
1266         https://bugs.webkit.org/show_bug.cgi?id=31535
1267
1268         * Scripts/modules/workqueue_unittest.py:
1269
1270 2009-11-16  Eric Seidel  <eric@webkit.org>
1271
1272         Reviewed by Adam Barth.
1273
1274         land-patches needs to be re-factored into smaller chunks
1275         https://bugs.webkit.org/show_bug.cgi?id=31532
1276
1277         * Scripts/bugzilla-tool: fix a couple obvious typos.
1278
1279 2009-11-16  Eric Seidel  <eric@webkit.org>
1280
1281         Reviewed by Adam Barth.
1282
1283         land-patches needs to be re-factored into smaller chunks
1284         https://bugs.webkit.org/show_bug.cgi?id=31532
1285
1286         The next patch will move these methods into WebKitLandingScripts.
1287
1288         * Scripts/bugzilla-tool:
1289          - Split out _land_patch and _close_bug_if_no_active_patches.
1290
1291 2009-11-16  Adam Barth  <abarth@webkit.org>
1292
1293         Reviewed by Eric Seidel.
1294
1295         Fix silly copy-and-paste code.  I am a terrible coder.
1296
1297         * Scripts/modules/bugzilla.py:
1298
1299 2009-11-16  Adam Barth  <abarth@webkit.org>
1300
1301         Reviewed by Eric Seidel.
1302
1303         Implement a StyleQueue
1304         https://bugs.webkit.org/show_bug.cgi?id=31537
1305
1306         The first iteration of the style queue only produces output locally.
1307         There is also a limit of 10 patches because it's not that useful to
1308         iterate through the entire review queue at this point.  We can remove
1309         the limit later.
1310
1311         * Scripts/bugzilla-tool:
1312         * Scripts/modules/bugzilla.py:
1313
1314 2009-11-16  Adam Barth  <abarth@webkit.org>
1315
1316         Reviewed by Eric Seidel.
1317
1318         Unit test WorkQueue
1319         https://bugs.webkit.org/show_bug.cgi?id=31531
1320
1321         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1322
1323         * Scripts/bugzilla-tool:
1324         * Scripts/modules/statusbot.py:
1325         * Scripts/modules/workqueue.py:
1326         * Scripts/modules/workqueue_unittest.py: Added.
1327         * Scripts/run-webkit-unittests:
1328
1329 2009-11-16  Eric Seidel  <eric@webkit.org>
1330
1331         Reviewed by Adam Barth.
1332
1333         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1334         https://bugs.webkit.org/show_bug.cgi?id=31530
1335
1336         * Scripts/bugzilla-tool:
1337
1338 2009-11-16  Eric Seidel  <eric@webkit.org>
1339
1340         Reviewed by Adam Barth.
1341
1342         bugzilla-tool needs apply-attachment
1343         https://bugs.webkit.org/show_bug.cgi?id=31528
1344
1345         * Scripts/bugzilla-tool:
1346          - Add ApplyAttachment command.
1347          - Abstract applying code into WebKitApplyingScripts.
1348          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1349         * Scripts/modules/bugzilla.py:
1350          - Add fetch_attachment and bug_id_for_attachment_id.
1351         * Scripts/modules/bugzilla_unittest.py:
1352          - Add test for new parsing.
1353          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1354
1355 2009-11-16  Eric Seidel  <eric@webkit.org>
1356
1357         Reviewed by Adam Barth.
1358
1359         Document check-style's use of force_clean.
1360
1361         * Scripts/bugzilla-tool:
1362         * Scripts/modules/scm.py:
1363
1364 2009-11-16  Adam Barth  <abarth@webkit.org>
1365
1366         Reviewed by Eric Seidel.
1367
1368         Move WorkQueue to its own file
1369         https://bugs.webkit.org/show_bug.cgi?id=31529
1370
1371         WorkQueue and WorkQueueDelegate are separate concerns from
1372         bugzilla-tool.  Also added a missing include to logging.py.
1373
1374         * Scripts/bugzilla-tool:
1375         * Scripts/modules/logging.py:
1376         * Scripts/modules/workqueue.py:
1377
1378 2009-11-16  Adam Barth  <abarth@webkit.org>
1379
1380         Reviewed by Eric Seidel.
1381
1382         Move OutputTee to logging.py.
1383
1384         * Scripts/bugzilla-tool:
1385         * Scripts/modules/logging.py:
1386
1387 2009-11-15  Adam Barth  <abarth@webkit.org>
1388
1389         Reviewed by Eric Seidel.
1390
1391         Refactor bugzilla-tool to allow for multiple queues
1392         https://bugs.webkit.org/show_bug.cgi?id=31513
1393
1394         Divide the commit queue class into three class to make creating
1395         additional queues easier.
1396
1397         * Scripts/bugzilla-tool:
1398
1399 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1400
1401         Reviewed by Eric Seidel.
1402
1403         svn-apply may not handle git patches created by bugzilla-tool
1404         https://bugs.webkit.org/show_bug.cgi?id=31457
1405
1406         * Scripts/modules/scm.py:
1407         * Scripts/modules/scm_unittest.py:
1408
1409 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1410
1411         Reviewed by Eric Seidel.
1412
1413         bugzilla-tool should post git binary diff
1414         https://bugs.webkit.org/show_bug.cgi?id=31458
1415
1416         Add --binary option to Git.create_patch.
1417
1418         * Scripts/modules/scm.py:
1419         * Scripts/modules/scm_unittest.py:
1420
1421 2009-11-15  Adam Barth  <abarth@webkit.org>
1422
1423         Reviewed by Darin Adler.
1424
1425         Add bugzilla-tool check-style
1426         https://bugs.webkit.org/show_bug.cgi?id=31515
1427
1428         * Scripts/bugzilla-tool:
1429         * Scripts/modules/bugzilla.py:
1430
1431 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1432
1433         Reviewed by Simon Hausmann.
1434
1435         Make the Qt Linux only --valgrind feature, suppress errors
1436         defined in the SuppressedValgrindErrors file.
1437
1438         * Scripts/run-webkit-tests:
1439
1440 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1441
1442         Reviewed by Simon Hausmann.
1443
1444         Set the locale to C and not to the current one in use on the system.
1445
1446         * DumpRenderTree/qt/DumpRenderTree.cpp:
1447         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1448
1449 2009-11-13  Adam Roben  <aroben@apple.com>
1450
1451         Add support for
1452         http/tests/security/isolatedWorld/didClearWindowObject.html
1453
1454         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1455         window objects in isolated worlds are cleared
1456
1457         Reviewed by Dave Hyatt.
1458
1459         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1460
1461         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1462         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1463         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1464         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1465         Added. Sets a __worldID property on the global object whose value is
1466         the ID of this world.
1467         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1468         Respond to this new delegate callback by calling through to one of the
1469         above new methods.
1470         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1471         (worldMap): Added. Returns a HashMap containing all the worlds we've
1472         created.
1473         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1474         haven't kept track of this world.
1475         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1476         instead of declaring our own.
1477
1478         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1479
1480         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1481         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1482         didClearWindowObjectForFrameInStandardWorld.
1483         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1484         Respond to this new delegate callback by calling through to one of the
1485         below new methods.
1486         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1487         Added. Sets a __worldID property on the gobal object whose value is
1488         the ID of this world.
1489         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1490         Added. Moved code here from didClearWindowObject.
1491
1492         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1493         didClearWindowObjectForFrame* functions.
1494
1495         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1496         (worldMap): Added. Returns a HashMap containing all the worlds we've
1497         created.
1498         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1499         haven't kept track of this world.
1500         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1501         instead of declaring our own.
1502
1503 2009-11-13  Adam Roben  <aroben@apple.com>
1504
1505         Finish replacing worldIDs with world objects
1506
1507         The only remaining use of worldIDs was in a method only used by DRT
1508         for the isolated worlds tests.
1509
1510         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1511
1512         Reviewed by Mark Rowe.
1513
1514         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1515         (LayoutTestController::evaluateScriptInIsolatedWorld):
1516         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1517         (LayoutTestController::evaluateScriptInIsolatedWorld):
1518         Updated for changes to WebFrame. Now holds the map of worldID -> world
1519         at this level instead of making WebKit do it.
1520
1521 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1522
1523         Reviewed by Simon Hausmann.
1524
1525         [Qt] Ensure the DRT does not output anything until first test is run
1526
1527         * DumpRenderTree/qt/DumpRenderTree.cpp:
1528         * DumpRenderTree/qt/DumpRenderTree.h:
1529
1530 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1531
1532         Reviewed by Tor Arne Vestbø.
1533
1534         Clear the undo stack in before each new test run.
1535
1536         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1537
1538         * DumpRenderTree/qt/DumpRenderTree.cpp:
1539         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1540
1541 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1542
1543         Reviewed by Kenneth Rohde Christiansen.
1544
1545         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1546
1547         * DumpRenderTree/qt/DumpRenderTree.cpp:
1548         (WebCore::WebPage::resetSettings):
1549         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1550         (LayoutTestController::overridePreference):
1551
1552 2009-11-13  Eric Seidel  <eric@webkit.org>
1553
1554         Reviewed by Adam Barth.
1555
1556         Update committers.py based on svn records
1557         https://bugs.webkit.org/show_bug.cgi?id=31366
1558
1559         This list was generated using validate-committer-lists from
1560         https://bugs.webkit.org/show_bug.cgi?id=30970
1561         and makes committers.py current for committers who have
1562         committed in the last 3 years.
1563
1564         * Scripts/modules/committers.py:
1565
1566 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1567
1568         Reviewed by Adam Barth.
1569
1570         The document-open.html test was flaky at times. The test invokes the layout test plugin
1571         which in its destroy stream handler opens a new document. This basically tears down the
1572         stream and the associated plugin instance. The pluginLog function in the layout test
1573         plugin attempts to retrieve the window script object on a torn down plugin instance
1574         which crashed consistently on windows in the debugger. The functions which issue
1575         these logs already have a valid window script object. We now have variants of the pluginLog
1576         function which take in a window script object with and without variable arguments. 
1577
1578         https://bugs.webkit.org/show_bug.cgi?id=31067
1579
1580         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1581         (pluginLogWithWindowObject):
1582         (pluginLogWithWindowObjectVariableArgs):
1583         (pluginLog):
1584         (notifyTestCompletion):
1585         (testDocumentOpen):
1586         (testWindowOpen):
1587
1588 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1589
1590         Reviewed by Gustavo Noronha Silva.
1591
1592         https://bugs.webkit.org/show_bug.cgi?id=30997
1593         [Gtk] Implemment AtkDocument
1594
1595         Added testing support.
1596
1597         * DumpRenderTree/AccessibilityUIElement.cpp:
1598         * DumpRenderTree/AccessibilityUIElement.h:
1599         (getDocumentEncodingCallback):
1600         (getDocumentURICallback):
1601         (AccessibilityUIElement::getJSClass):
1602         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1603         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1604         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1605         (AccessibilityUIElement::documentEncoding):
1606         (AccessibilityUIElement::documentURI):
1607
1608 2009-11-12  Adam Roben  <aroben@apple.com>
1609
1610         Replace worldIDs with world objects
1611
1612         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1613         user scripts/stylesheets and isolated worlds
1614
1615         Reviewed by Sam Weinig.
1616
1617         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1618         (LayoutTestController::addUserScript):
1619         (LayoutTestController::addUserStyleSheet):
1620         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1621         (LayoutTestController::addUserScript):
1622         (LayoutTestController::addUserStyleSheet):
1623         Changed these functions to create a new WebJSWorld each time they're
1624         called and to pass that world to WebKit.
1625
1626 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1627
1628         Reviewed by Oliver Hunt.
1629
1630         need to implement aria tree roles
1631         https://bugs.webkit.org/show_bug.cgi?id=31284
1632
1633         * DumpRenderTree/AccessibilityUIElement.cpp:
1634         (disclosedRowAtIndexCallback):
1635         (selectedRowAtIndexCallback):
1636         (isEqualCallback):
1637         (isAttributeSettableCallback):
1638         (isActionSupportedCallback):
1639         (disclosedByRowCallback):
1640         (hierarchicalLevelCallback):
1641         (AccessibilityUIElement::getJSClass):
1642         * DumpRenderTree/AccessibilityUIElement.h:
1643         (AccessibilityUIElement::isEqual):
1644         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1645         (AccessibilityUIElement::hierarchicalLevel):
1646         (AccessibilityUIElement::disclosedRowAtIndex):
1647         (AccessibilityUIElement::selectedRowAtIndex):
1648         (AccessibilityUIElement::disclosedByRow):
1649         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1650         (AccessibilityUIElement::getChildAtIndex):
1651         (AccessibilityUIElement::disclosedRowAtIndex):
1652         (AccessibilityUIElement::selectedRowAtIndex):
1653         (AccessibilityUIElement::titleUIElement):
1654         (AccessibilityUIElement::parentElement):
1655         (AccessibilityUIElement::disclosedByRow):
1656         (AccessibilityUIElement::hierarchicalLevel):
1657         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1658         (AccessibilityUIElement::hierarchicalLevel):
1659         (AccessibilityUIElement::disclosedRowAtIndex):
1660         (AccessibilityUIElement::selectedRowAtIndex):
1661         (AccessibilityUIElement::disclosedByRow):
1662
1663 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1664
1665         Reviewed by Darin Adler.
1666
1667         svn-apply can not handle git binary diffs
1668         https://bugs.webkit.org/show_bug.cgi?id=26830
1669
1670         Support "literal" type git binary diffs.
1671
1672         * Scripts/VCSUtils.pm:
1673         * Scripts/modules/scm_unittest.py:
1674         * Scripts/svn-apply:
1675
1676 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1677
1678         Not reviewed, removing duplicate entry for myself in committers.py.
1679
1680         * Scripts/modules/committers.py:
1681
1682 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1683
1684         Reviewed by Darin Adler and Mark Rowe.
1685
1686         https://bugs.webkit.org/show_bug.cgi?id=31200
1687         Tests in http/tests/security/mixedContent start to fail when new tests are added
1688
1689         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1690
1691 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1692
1693         Reviewed by Jan Alonzo.
1694
1695         Create, and display a window for the inspector, for inspector
1696         tests.
1697
1698         Need to also show/hide the inspector window to avoid having
1699         problems with code assuming it is realized
1700         https://bugs.webkit.org/show_bug.cgi?id=31347
1701
1702         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1703         (webInspectorShowWindow):
1704         (webInspectorCloseWindow):
1705         (webInspectorInspectWebView):
1706         (createWebView):
1707
1708 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1709
1710         Unreviewed Qt buildbot fix.
1711
1712         My previous fix was wrong, so revert that change and fix it by
1713         returning when the document of the frame has no document element.
1714         Idea is borrowed from mac and win DRT.
1715
1716         * DumpRenderTree/qt/DumpRenderTree.cpp:
1717         (WebCore::DumpRenderTree::dumpFramesAsText):
1718
1719 2009-11-11  Eric Seidel  <eric@webkit.org>
1720
1721         Reviewed byg Kenneth Rohde Christiansen.
1722
1723         Update Kenneth's committer record to include the email he
1724         uses on lists.webkit.org.
1725
1726         * Scripts/modules/committers.py:
1727
1728 2009-11-11  Eric Seidel  <eric@webkit.org>
1729
1730         Reviewed by Gustavo Noronha Silva.
1731
1732         Several committers use separate email addresses for bugzilla and svn.webkit.org
1733         https://bugs.webkit.org/show_bug.cgi?id=31364
1734
1735         Update records for existing committers to include email addresses
1736         used in svn.webkit.org and lists.webkit.org.
1737         Most committers use the same email address in all 3 places, but some use
1738         separate addresses.  committers.py needs record of each of these addresses.
1739
1740         * Scripts/modules/committers.py:
1741
1742 2009-11-11  Eric Seidel  <eric@webkit.org>
1743
1744         No review, adding second email address for an existing committer.
1745
1746         Add Yong Li's second bugzilla account to his committer record.
1747         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1748
1749         * Scripts/modules/committers.py:
1750
1751 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1752
1753         Reviewed by Simon Hausmann.
1754
1755         If the frame has no innerText don't append it, and
1756         do not add a newline which breaks some cross platform
1757         results.
1758
1759         * DumpRenderTree/qt/DumpRenderTree.cpp:
1760         (WebCore::DumpRenderTree::dumpFramesAsText):
1761
1762 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1763
1764         Reviewed by Simon Hausmann.
1765
1766         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1767
1768         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1769         (webkit_test_plugin_new_instance):
1770         (webkit_test_plugin_destroy_instance):
1771         (webkit_test_plugin_destroy_stream):
1772
1773 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1774
1775         Reviewed by Mark Rowe.
1776
1777         Implement the functionality needed by plugins/window-open.html
1778
1779         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1780         (webkit_test_plugin_new_instance):
1781         (webkit_test_plugin_set_window):
1782
1783 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1784
1785         Reviewed by Simon Hausmann.
1786
1787         [Qt] Force -graphicssystem raster and -style windows when running DRT
1788
1789         * DumpRenderTree/qt/main.cpp:
1790         * Scripts/run-webkit-tests:
1791
1792 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1793
1794         Reviewed by Simon Hausmann.
1795
1796         Compute correct library paths for Qt
1797
1798         * Scripts/webkitdirs.pm:
1799
1800 2009-11-10  Mark Rowe  <mrowe@apple.com>
1801
1802         Reviewed by Sam Weinig.
1803
1804         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1805
1806         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1807         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1808         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1809         that had enabled frame load delegate logging this would result in extra log messages being generated,
1810         causing the test to fail.
1811
1812         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1813         tests.
1814
1815         * DumpRenderTree/mac/DumpRenderTree.mm:
1816         (dumpRenderTree):
1817         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1818         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1819
1820 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1821
1822         Reviewed by Kenneth Rohde Christiansen.
1823
1824         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1825
1826         * DumpRenderTree/qt/DumpRenderTree.cpp:
1827         (WebCore::DumpRenderTree::DumpRenderTree):
1828
1829 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1830
1831         Reviewed by Jan Alonzo.
1832
1833         [GTK] Remove WebSocket configuration from WebKitWebSettings
1834         https://bugs.webkit.org/show_bug.cgi?id=31244
1835
1836         Follow-up of r50724. Don't set the enable-web-socket property
1837         anymore.
1838
1839         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1840         (resetDefaultsToConsistentValues):
1841
1842 2009-11-10  Oliver Hunt  <oliver@apple.com>
1843
1844         Reviewed by Maciej Stachowiak.
1845
1846         Rename 3D Canvas related classes to use WebGL prefix
1847         https://bugs.webkit.org/show_bug.cgi?id=29095
1848
1849         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1850         and upate webkitdirs script to new method of testing for WebGL.
1851
1852         * Scripts/do-webcore-rename:
1853         * Scripts/webkitdirs.pm:
1854
1855 2009-11-09  Oliver Hunt  <oliver@apple.com>
1856
1857         Reviewed by Geoff Garen.
1858
1859         Make do-webcore-rename work with git.
1860
1861         * Scripts/do-webcore-rename:
1862
1863 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1864
1865         Adding Kenneth to the reviewers list.
1866
1867         * Scripts/modules/committers.py:
1868
1869 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1870
1871         Reviewed by Jan Alonzo.
1872
1873         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1874         https://bugs.webkit.org/show_bug.cgi?id=30482
1875
1876         LayoutTestControllerGtk now uses the exposed
1877         Page::tabKeyCyclesThroughElements API
1878
1879         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1880         (LayoutTestController::setTabKeyCyclesThroughElements):
1881
1882 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1883
1884         Reviewed by Holger Freyther.
1885
1886         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1887         This helps to pass the test case below. Also replaced hardcoded
1888         code numbers with defined constants.
1889         https://bugs.webkit.org/show_bug.cgi?id=31185
1890         
1891         Test: editing/undo/undo-deleteWord.html
1892
1893         * DumpRenderTree/qt/EventSenderQt.cpp:
1894         (EventSender::keyDown):
1895
1896 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1897
1898         Reviewed by Holger Freyther.
1899
1900         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1901         https://bugs.webkit.org/show_bug.cgi?id=31164
1902
1903         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1904
1905         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1906         (LayoutTestController::processWork):
1907
1908 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1909
1910         Reviewed by Holger Freyther.
1911
1912         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1913         https://bugs.webkit.org/show_bug.cgi?id=31158
1914
1915         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1916         always, which from WorkQueue prospective means that a load has been started
1917         and the queue processing should stop and wait for the load to finish.
1918         Spinning it off into a loading and a non-loading variants was the solution
1919         adopted by Mac's DRT to work around this problem. The former keeps returning
1920         'true' while the later executes the script synchronously and returns 'false'
1921         making it possible to the WorkQueue to proceed right away.
1922
1923         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1924         (LayoutTestController::processWork):
1925         (LayoutTestController::queueLoadingScript):
1926         (LayoutTestController::queueNonLoadingScript):
1927         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1928         * DumpRenderTree/qt/WorkQueueItem.h:
1929         (LoadingScriptItem::LoadingScriptItem):
1930         (LoadingScriptItem::invoke):
1931         (NonLoadingScriptItem::NonLoadingScriptItem):
1932         (NonLoadingScriptItem::invoke):
1933
1934 2009-11-07  Mark Rowe  <mrowe@apple.com>
1935
1936         Rubber-stamped by Cameron Zwarich.
1937
1938         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1939
1940         * Scripts/commit-log-editor:
1941
1942 2009-11-07  Mark Rowe  <mrowe@apple.com>
1943
1944         Reviewed by Darin Adler.
1945
1946         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1947         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1948
1949         Move logic for determining the name and email address to use in a ChangeLog entry from
1950         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1951         whether the author of the patch matches committer, and therefore needs access to the
1952         email address that would be used in a ChangeLog entry.
1953
1954         Based on a patch by Pierre d'Herbemont.
1955
1956         * Scripts/VCSUtils.pm:
1957         * Scripts/commit-log-editor:
1958         * Scripts/prepare-ChangeLog:
1959         * Scripts/webkitdirs.pm:
1960
1961 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1962
1963         Reviewed by Adam Barth.
1964
1965         Added functionality to the layout test plugin to invoke document.open and
1966         window.open with default arguments. The associated webkit bug is
1967         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1968         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1969         work in Chromium (V8) if there is no calling javascript context. To achieve this
1970         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1971         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1972
1973         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1974         (testDocumentOpen):
1975         (testWindowOpen):
1976         (pluginAllocate):
1977         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1978         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1979         (NPP_New):
1980         (NPP_SetWindow):
1981         (NPP_DestroyStream):
1982         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1983         (NPP_New):
1984         (NPP_SetWindow):
1985         (NPP_NewStream):
1986         (NPP_DestroyStream):
1987
1988 2009-11-06  Eric Seidel  <eric@webkit.org>
1989
1990         Reviewed by Adam Barth.
1991
1992         bugzilla-tool crashed with exception
1993         https://bugs.webkit.org/show_bug.cgi?id=31092
1994
1995         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1996
1997 2009-11-04  Eric Seidel  <eric@webkit.org>
1998
1999         No review, just add a line which got left out of the patch uploaded for commit.
2000
2001         commit-queue is crashing when trying to reject patches after unknown failures
2002         https://bugs.webkit.org/show_bug.cgi?id=31091
2003
2004         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2005
2006 2009-11-04  Adam Roben  <aroben@apple.com>
2007
2008         Remove bogus else clause in bugzilla-tool
2009
2010         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2011         create-bug raises exception after entering bug description
2012
2013         Reviewed by David Kilzer.
2014
2015         * Scripts/bugzilla-tool:
2016         (CreateBug): else clauses are only hit if no exception is raised, so
2017         it makes no sense to try to re-raise the exception in an else clause.
2018         The exception will automatically be re-raised if it doesn't match any
2019         of the except clauses, so we don't have to do anything special here at
2020         all to get the desired behavior.
2021
2022 2009-11-04  Eric Seidel  <eric@webkit.org>
2023
2024         Reviewed by David Kilzer.
2025
2026         svn-apply's fixChangeLogPatch function seems broken
2027         https://bugs.webkit.org/show_bug.cgi?id=30683
2028
2029         Update fixChangeLogPatch to be able to handle patches which
2030         don't start at line 1.
2031         Add unit tests for svn-apply to scm_unittest.py.
2032
2033         * Scripts/VCSUtils.pm:
2034         * Scripts/modules/scm_unittest.py:
2035
2036 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2037
2038         Reviewed by Beth Dakin.
2039
2040         Need to implement ARIA role="combobox"
2041         https://bugs.webkit.org/show_bug.cgi?id=31096
2042
2043         * DumpRenderTree/AccessibilityUIElement.cpp:
2044         (showMenuCallback):
2045         (getIsExpandedCallback):
2046         (AccessibilityUIElement::getJSClass):
2047         * DumpRenderTree/AccessibilityUIElement.h:
2048         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2049         (AccessibilityUIElement::isExpanded):
2050         (AccessibilityUIElement::showMenu):
2051         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2052         (AccessibilityUIElement::isExpanded):
2053         (AccessibilityUIElement::showMenu):
2054         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2055         (AccessibilityUIElement::isSelected):
2056         (AccessibilityUIElement::isExpanded):
2057         (AccessibilityUIElement::showMenu):
2058
2059 2009-11-04  Eric Seidel  <eric@webkit.org>
2060
2061         Reviewed by Adam Barth.
2062
2063         commit-queue is crashing when trying to reject patches after unknown failures
2064         https://bugs.webkit.org/show_bug.cgi?id=31091
2065
2066         * Scripts/bugzilla-tool:
2067          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2068            so we have to find out what the current patch is by asking bugzilla again.
2069          - Discovered that this code was also leaking file descriptors, so fixed that.
2070
2071 2009-11-04  Adam Roben  <aroben@apple.com>
2072
2073         Make run-webkit-tests work for the Debug_Internal Windows
2074         configuration
2075
2076         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2077         suffix.
2078
2079         Fixes <http://webkit.org/b/31123>.
2080
2081         Reviewed by Sam Weinig.
2082
2083         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2084         Debug_Internal, either.
2085
2086 2009-11-04  Eric Seidel  <eric@webkit.org>
2087
2088         Reviewed by Adam Barth.
2089
2090         committers.py needs a way to store non-bugzilla email addresses
2091         https://bugs.webkit.org/show_bug.cgi?id=31037
2092
2093         Make Committer and Reviewer constructors take a single email or a list of emails.
2094         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2095         Expose reviewers(), used by validate-committer-lists on bug 30970.
2096
2097         * Scripts/modules/committers.py:
2098         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2099
2100 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2101
2102         Reviewed by David Levin.
2103
2104         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2105         https://bugs.webkit.org/show_bug.cgi?id=27491
2106
2107         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2108         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2109
2110         Functions to start or stop Web Socket servers are added.
2111
2112         * Scripts/run-webkit-tests:
2113
2114 2009-11-03  Eric Seidel  <eric@webkit.org>
2115
2116         No review, just changing wording of log message.
2117
2118         Change log string to say "failed" instead of "rejected"
2119         when a commit fails due to an out of date checkout.
2120         This makes grepping the commit-queue log for rejected patches easier.
2121
2122         * Scripts/bugzilla-tool:
2123
2124 2009-11-03  Eric Seidel  <eric@webkit.org>
2125
2126         No review, adding commonly known committers missing from the file.
2127
2128         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2129
2130 2009-11-03  Eric Seidel  <eric@webkit.org>
2131
2132         No review, just sort-order cleanup.
2133
2134         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2135
2136 2009-11-03  Stephen White  <senorblanco@chromium.org>
2137
2138         (Unreviewed).
2139
2140         Add myself to committers.py.
2141
2142         * Scripts/modules/committers.py:
2143
2144 2009-11-03  Robin Dunn  <robin@alldunn.com>
2145
2146         Reviewed by Kevin Ollviier.
2147
2148         Add packaging scripts for Debian-based Linux distros.
2149         
2150         https://bugs.webkit.org/show_bug.cgi?id=31075
2151
2152         * wx/packaging/build-debian-installer.py: Added.
2153         * wx/packaging/debian: Added.
2154
2155 2009-11-03  Dan Bernstein  <mitz@apple.com>
2156
2157         Reviewed by Anders Carlsson and Beth Dakin.
2158
2159         https://bugs.webkit.org/show_bug.cgi?id=31070
2160
2161         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2162         destroyed, it executes the value of the 'ondestroy' parameter as a
2163         script.
2164
2165         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2166         (pluginAllocate): Initialize onDestroy.
2167         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2168         onDestroy.
2169         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2170         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2171         specified.
2172         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2173
2174 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2175
2176         Reviewed by Xan Lopez.
2177
2178         https://bugs.webkit.org/show_bug.cgi?id=31035
2179         [GTK] some accessibility tests hitting assertion in debug builds
2180
2181         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2182
2183         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2184         (AccessibilityController::rootElement):
2185
2186 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2187
2188         Reviewed by Beth Dakin.
2189
2190         Support ARIA "tab" roles
2191         https://bugs.webkit.org/show_bug.cgi?id=30842
2192
2193         * DumpRenderTree/AccessibilityUIElement.cpp:
2194         * DumpRenderTree/AccessibilityUIElement.h:
2195         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2196         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2197         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2198
2199 2009-11-01  Eric Seidel  <eric@webkit.org>
2200
2201         Reviewed by David Levin.
2202
2203         buildbots should use --exit-after-N-failures
2204         https://bugs.webkit.org/show_bug.cgi?id=30809
2205
2206         Make the bots exit after 20 failures to prevent never-ending
2207         test runs where every test spends a minute crashing.
2208
2209         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2210
2211 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2212
2213         Reviewed by Eric Seidel.
2214
2215         Turn on warnings for QtWebKit for gcc
2216         https://bugs.webkit.org/show_bug.cgi?id=30958
2217
2218         * DumpRenderTree/qt/main.cpp: 
2219         (crashHandler): Mark function NO_RETURN
2220
2221 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2222
2223         Adding myself to the committers list.
2224
2225         * Scripts/modules/committers.py:
2226
2227 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2228
2229         Fix an issue that Adam noticed in DRT.
2230
2231         Reviewed by Darin Adler.
2232
2233         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2234         (AccessibilityUIElement::role):
2235         Get the length of the role text, and create a buffer dynamically.
2236
2237 2009-10-30  Eric Seidel  <eric@webkit.org>
2238
2239         No review, rolling out r50105.
2240         http://trac.webkit.org/changeset/50105
2241
2242         This commit was causing:
2243         https://bugs.webkit.org/show_bug.cgi?id=30869
2244         We'll re-implement the feature a different way.
2245
2246         * Scripts/bugzilla-tool:
2247
2248 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2249
2250         Test for MSAA: Accessibility of headings is not correct
2251
2252         https://bugs.webkit.org/show_bug.cgi?id=30937
2253
2254         Reviewed by Adam Roben.
2255
2256         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2257         (AccessibilityUIElement::role):
2258         Allow the role returned to be a BSTR.
2259         (AccessibilityUIElement::description):
2260         Fix a copy/paste error.
2261
2262 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2263
2264         Test for MSAA: Accessibility of links is wrong
2265
2266         https://bugs.webkit.org/show_bug.cgi?id=30928
2267
2268         Reviewed by Darin Adler.
2269
2270         * DumpRenderTree/AccessibilityUIElement.cpp:
2271         (getAccessibilityValueCallback):
2272         Return the accessibility value.
2273         (AccessibilityUIElement::getJSClass):
2274         Added "accessibilityValue" value.
2275
2276         * DumpRenderTree/AccessibilityUIElement.h:
2277
2278         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2279         (AccessibilityUIElement::accessibilityValue):
2280         Stubbed.
2281
2282         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2283         (AccessibilityUIElement::accessibilityValue):
2284         Stubbed.
2285
2286         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2287         (AccessibilityUIElement::accessibilityValue):
2288         Get the object's value, and return it as a JS string.
2289
2290 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2291
2292         Fix typo in command name used by wx build system.
2293
2294         * wx/build/build_utils.py:
2295
2296 2009-10-30  Adam Barth  <abarth@webkit.org>
2297
2298         Reviewed by Darin Adler.
2299
2300         Patch v1 is a dumb default name for patches
2301         https://bugs.webkit.org/show_bug.cgi?id=30952
2302
2303         Let's use "Patch" instead.
2304
2305         * Scripts/bugzilla-tool:
2306
2307 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2308
2309         Unreviewed trivial buildfix.
2310
2311         [Qt] Buildfix for r50333.
2312
2313         * DumpRenderTree/qt/DumpRenderTree.pro:
2314
2315 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2316
2317         Reviewed by Holger Freyther.
2318
2319         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2320         https://bugs.webkit.org/show_bug.cgi?id=30953
2321
2322         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2323         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2324         makes qt DRT to share this implementation (as gtk and mac ports do).
2325
2326         * DumpRenderTree/qt/DumpRenderTree.pro:
2327         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2328         * DumpRenderTree/qt/WorkQueue.h: Removed.
2329
2330 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2331
2332         Unreviewed potential buildbot fix.
2333
2334         Second try: Reset page history before running each test.
2335
2336         Apparently the QWebHistory::clear() keeps the current page
2337         in history which is not what we want, so we not additionally
2338         sets the history capacity to 0 (forces removing everything)
2339         and then sets it back to its original value.
2340
2341         * DumpRenderTree/qt/DumpRenderTree.cpp:
2342         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2343
2344 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2345
2346         Unreviewed potential buildbot fix.
2347
2348         Reset page history before running each test.
2349
2350         * DumpRenderTree/qt/DumpRenderTree.cpp:
2351         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2352
2353 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2354
2355         Reviewed by Eric Seidel.
2356
2357         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2358
2359         Bug 28420 -  Implement HTML5 <ruby> rendering
2360         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2361
2362         No new tests (no functional change).
2363
2364         * Scripts/build-webkit:
2365
2366 2009-10-29  Dan Bernstein  <mitz@apple.com>
2367
2368         Reviewed by Mark Rowe.
2369
2370         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2371         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2372         define it.
2373
2374         * Scripts/VCSUtils.pm:
2375         * Scripts/svn-apply:
2376         * Scripts/svn-unapply:
2377
2378 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2379
2380         Reviewed by Gustavo Noronha.
2381
2382         Use the GTK+ main loop instead of rolling our own mini-version of
2383         it.
2384
2385         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2386         (dump):
2387         (runTest):
2388         (webViewLoadFinished):
2389
2390 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2391
2392         Reviewed by Oliver Hunt.
2393
2394         Implement the Qt version of DRT dumpBackForwardList().
2395
2396         * DumpRenderTree/qt/DumpRenderTree.cpp:
2397         (WebCore::dumpHistoryItem):
2398         (WebCore::DumpRenderTree::dumpBackForwardList):
2399
2400 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2401
2402         Reviewed by Adam Roben.
2403
2404         Implement DRT functionality for Qt introduced in
2405         r28690 and r28705.
2406
2407         - Implemented pathToLocalResource which exposes the functionality of
2408         converting a given unix path to the correct location on Windows.
2409         - Implemented a way to remove machine-dependent information from paths
2410         in layout test results.
2411
2412         * DumpRenderTree/qt/DumpRenderTree.cpp:
2413         (WebCore::urlSuitableForTestResult):
2414         (WebCore::WebPage::javaScriptConsoleMessage):
2415         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2416         (LayoutTestController::pathToLocalResource):
2417         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2418
2419 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2420
2421         Adding myself to the committers list.
2422
2423         * Scripts/modules/committers.py:
2424
2425 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2426
2427         Adding myself to the committers list.
2428
2429         * Scripts/modules/committers.py:
2430
2431 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2432
2433         Reviewed by Jan Alonzo.
2434
2435         [GTK] API to start inspector for a WebView
2436         https://bugs.webkit.org/show_bug.cgi?id=22551
2437
2438         Use the new inspector API to implement the LayoutTestController
2439         interfaces used to test the inspector.
2440
2441         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2442         (webInspectorInspectWebView):
2443         (createWebView):
2444         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2445         (LayoutTestController::showWebInspector):
2446         (LayoutTestController::closeWebInspector):
2447         (LayoutTestController::evaluateInWebInspector):
2448
2449 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2450
2451         Reviewed by Eric Seidel.
2452
2453         [Qt] WebFrame::counterValueForElementById must not be exposed
2454         https://bugs.webkit.org/show_bug.cgi?id=30882
2455
2456         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2457         (LayoutTestController::counterValueForElementById):
2458
2459 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2460
2461         Rubberstamped by Oliver Hunt.
2462
2463         Fix the warning:
2464
2465         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2466         declared with attribute warn_unused_result".
2467
2468         by actually checking the result. In the case it is null, an
2469         error has occoured, so treat it as the other fatal errors.
2470
2471         * DumpRenderTree/qt/DumpRenderTree.cpp:
2472         (WebCore::DumpRenderTree::initializeFonts):
2473
2474 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2475
2476         Reviewed by Darin Adler.
2477
2478         Provide a way to get counter values with layoutTestContoller
2479         https://bugs.webkit.org/show_bug.cgi?id=30555
2480
2481         Define layoutTestContoller.counterValueForElementById.
2482
2483         * DumpRenderTree/LayoutTestController.cpp:
2484         (counterValueForElementByIdCallback):
2485         (LayoutTestController::staticFunctions):
2486         * DumpRenderTree/LayoutTestController.h:
2487         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2488         (LayoutTestController::counterValueForElementById):
2489
2490 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2491
2492         Rubberstamped by Oliver Hunt.
2493
2494         Change two methods to be internal for DRT use only.
2495
2496         Part of [Qt] Review all new API in Qt 4.6
2497         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2498
2499         * DumpRenderTree/qt/DumpRenderTree.cpp:
2500         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2501         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2502         (LayoutTestController::whiteListAccessFromOrigin):
2503
2504 2009-10-27  Eric Seidel  <eric@webkit.org>
2505
2506         Reviewed by Adam Barth.
2507
2508         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2509         https://bugs.webkit.org/show_bug.cgi?id=30826
2510
2511         * Scripts/svn-apply:
2512          - Add () around all system() calls.
2513          - Use the correct system() == 0 or die instead of system() or die
2514          - Add descriptive messages to all die statements.
2515
2516 2009-10-27  Steve Block  <steveblock@google.com>
2517
2518         Reviewed by NOBODY.
2519
2520         Adds steveblock@google.com to list of committers.
2521
2522         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2523
2524 2009-10-27  Eric Seidel  <eric@webkit.org>
2525
2526         Reviewed by Adam Barth.
2527
2528         svn-apply can exit(0) even on patch failure
2529         https://bugs.webkit.org/show_bug.cgi?id=29622
2530
2531         * Scripts/svn-apply:
2532          - Add a bunch of "or die" statements, hopefully catching all
2533            possible cases where failure could still exit(0).
2534
2535 2009-10-27  Eric Seidel  <eric@webkit.org>
2536
2537         Reviewed by Adam Barth.
2538
2539         svn-* scripts should share code through VCSUtils.pm
2540         https://bugs.webkit.org/show_bug.cgi?id=30791
2541
2542         Just moving code into a shared location.
2543
2544         * Scripts/VCSUtils.pm:
2545         * Scripts/prepare-ChangeLog:
2546         * Scripts/resolve-ChangeLogs:
2547         * Scripts/svn-apply:
2548         * Scripts/svn-create-patch:
2549         * Scripts/svn-unapply:
2550         * Scripts/update-webkit:
2551
2552 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2553
2554         Suppress a huge number of MSVC warnings when building wxWebKit.
2555
2556         * wx/build/settings.py:
2557
2558 2009-10-26  Eric Seidel  <eric@webkit.org>
2559
2560         No review, just adding Mike Belshe to the committers list.
2561
2562         * Scripts/modules/committers.py:
2563
2564 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2565
2566         Reviewed by Darin Adler.
2567
2568         Make .rc files compile on Windows without depending on MFC headers
2569         https://bugs.webkit.org/show_bug.cgi?id=30750
2570
2571         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2572         windows.h instead of afxres.h because it exists even when MFC is not 
2573         installed, and is all that's needed here.
2574
2575         * FindSafari/FindSafari.rc: Ditto
2576
2577 2009-10-24  Eric Seidel  <eric@webkit.org>
2578
2579         Reviewed by Adam Barth.
2580
2581         bugzilla-tool post-diff should know how to mark commit-queue=?
2582         https://bugs.webkit.org/show_bug.cgi?id=29202
2583
2584         * Scripts/bugzilla-tool:
2585          - Add --commit-queue option to post-diff, post-commits and create-bug.
2586         * Scripts/modules/bugzilla.py:
2587          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2588          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2589
2590 2009-10-23  Eric Seidel  <eric@webkit.org>
2591
2592         Reviewed by Adam Barth.
2593
2594         bugzilla-tool commit-queue does not notice modifications to committers.py
2595         https://bugs.webkit.org/show_bug.cgi?id=30084
2596
2597         * Scripts/bugzilla-tool:
2598          - Make commit-queue re-exec itself instead of using while(1).
2599          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2600          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2601
2602 2009-10-22  Eric Seidel  <eric@webkit.org>
2603
2604         Reviewed by Adam Barth.
2605
2606         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2607         https://bugs.webkit.org/show_bug.cgi?id=30634
2608
2609         * Scripts/bugzilla-tool:
2610          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2611          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2612
2613 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2614
2615         Reviewed by Eric Seidel.
2616
2617         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2618
2619         https://bugs.webkit.org/show_bug.cgi?id=30763
2620
2621         * pywebsocket/mod_pywebsocket/__init__.py:
2622         * pywebsocket/mod_pywebsocket/dispatch.py:
2623         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2624         * pywebsocket/mod_pywebsocket/standalone.py:
2625         * pywebsocket/setup.py:
2626         * pywebsocket/test/test_dispatch.py:
2627
2628 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2629
2630         Reviewed by David Levin.
2631
2632         REGRESSION: 2 failures in run-webkit-unittests
2633         https://bugs.webkit.org/show_bug.cgi?id=30645
2634
2635         * Scripts/modules/cpp_style_unittest.py:
2636         Fixed a few test scenarios which apparently lost some spaces from 
2637         text literals.
2638
2639 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2640
2641         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2642
2643         * Scripts/webkitdirs.pm:
2644
2645 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2646
2647         Reviewed by Darin Adler.
2648
2649         Unification of using null device in perl scripts.
2650         https://bugs.webkit.org/show_bug.cgi?id=30572
2651
2652         * Scripts/VCSUtils.pm:
2653         * Scripts/bisect-builds:
2654         * Scripts/resolve-ChangeLogs:
2655         * Scripts/run-iexploder-tests:
2656         * Scripts/run-jsc:
2657         * Scripts/run-mangleme-tests:
2658         * Scripts/run-webkit-tests:
2659         * Scripts/webkitdirs.pm:
2660         Using File::Spec->devnull() instead of hard coded /dev/null.
2661
2662 2009-10-26  Eric Seidel  <eric@webkit.org>
2663
2664         Reviewed by Holger Freyther.
2665
2666         Reviewers are missing from committers.py
2667         https://bugs.webkit.org/show_bug.cgi?id=30733
2668
2669         * Scripts/modules/committers.py:
2670
2671 2009-10-23  Eric Seidel  <eric@webkit.org>
2672
2673         No review, only adding Alice to the list of reviewers.
2674
2675         * Scripts/modules/committers.py:
2676
2677 2009-10-23  Eric Seidel  <eric@webkit.org>
2678
2679         Reviewed by Eric Carlson.
2680
2681         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2682         https://bugs.webkit.org/show_bug.cgi?id=30700
2683
2684         * DumpRenderTree/mac/DumpRenderTree.mm:
2685         (resetDefaultsToConsistentValues): Update QuickTime version check.
2686
2687 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2688
2689         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2690         character measurement APIs that are private on Tiger.
2691
2692         * wx/build/settings.py:
2693
2694 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2695
2696         Reviewed by NOBODY (build fix).
2697         Build fix following bug #30696.
2698
2699         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2700         (LayoutTestController::evaluateScriptInIsolatedWorld):
2701
2702 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2703
2704         Reviewed by Sam Weinig & Geoff Garen.
2705
2706         https://bugs.webkit.org/show_bug.cgi?id=30696
2707         Enable isolated-worlds tests on mac.
2708
2709         Add private interface for DRT to invoke execution in a given world.
2710
2711         * DumpRenderTree/LayoutTestController.cpp:
2712         (evaluateScriptInIsolatedWorldCallback):
2713         (LayoutTestController::staticFunctions):
2714         * DumpRenderTree/LayoutTestController.h:
2715         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2716         (LayoutTestController::evaluateScriptInIsolatedWorld):
2717         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2718         (LayoutTestController::evaluateScriptInIsolatedWorld):
2719
2720 2009-10-21  Eric Seidel  <eric@webkit.org>
2721
2722         Reviewed by Adam Barth.
2723
2724         bugzilla-tool's "patch failed to download an apply" error should give more information
2725         https://bugs.webkit.org/show_bug.cgi?id=30632
2726
2727         * Scripts/modules/scm.py:
2728          - Use the common run_command method instead of custom POpen code.
2729          - Make run_command know how to take pipes as input.
2730         * Scripts/modules/scm_unittest.py:
2731          - Add new tests to cover change.
2732          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2733
2734 2009-10-21  Kent Tamura  <tkent@chromium.org>
2735
2736         Unreviewed.  Adding myself to the committers list.
2737
2738         * Scripts/modules/committers.py:
2739
2740 2009-10-21  Robin Dunn  <robin@alldunn.com>
2741
2742         Reviewed by Kevin Ollivier.
2743
2744         Update the Windows installer builder to work with Vista / Win 7 and with git.
2745         
2746         https://bugs.webkit.org/show_bug.cgi?id=30649
2747
2748         * wx/build/build_utils.py:
2749         * wx/packaging/build-mac-installer.py:
2750         * wx/packaging/build-win-installer.py:
2751         * wx/packaging/wxWebKitInstaller.iss.in:
2752
2753 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2754
2755         Reviewed by Gustavo Noronha.
2756
2757         [GTK] Added conditional code to avoid using
2758         gdk_window_get_root_coords if we do not have a gtk+ release newer
2759         than 2.17.3.
2760         https://bugs.webkit.org/show_bug.cgi?id=30636
2761
2762         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2763
2764 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2765
2766         Reviewed by Eric Seidel.
2767
2768         [Qt] Added dummy implementation for keepWebHistory()
2769         https://bugs.webkit.org/show_bug.cgi?id=30592
2770
2771         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2772         (LayoutTestController::keepWebHistory):
2773         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2774
2775 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2776
2777         Reviewed by Xan Lopez.
2778
2779         [GTK] Fixed the double click condition, it is not double click if
2780         we move in just in one direction.
2781         https://bugs.webkit.org/show_bug.cgi?id=30636
2782
2783         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2784
2785 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2786
2787         Reviewed by Xan Lopez.
2788
2789         [GTK] Initialize the events completly before emitting them.
2790         https://bugs.webkit.org/show_bug.cgi?id=30633
2791
2792         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2793
2794 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2795
2796         wx build fix. Fix for when linking using --as-needed with gcc.
2797
2798         * wx/browser/wscript:
2799
2800 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2801
2802         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2803         to support all the features used by CURL backend.
2804         
2805         * wx/build/settings.py:
2806         * wx/install-unix-extras:
2807
2808 2009-10-20  Anton Muhin  <antonm@chromium.org>
2809
2810         Reviewed by Adam Barth.
2811
2812         Add {ager,antonm,yurys}@chromium.org into committers.py
2813         https://bugs.webkit.org/show_bug.cgi?id=30560
2814
2815         * Scripts/modules/committers.py:
2816
2817 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2818
2819         Reviewed by Tor Arne Vestbø.
2820
2821         Make the Netscape Test plugin available to the Qt launcher.
2822
2823         * Scripts/run-launcher:
2824
2825 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2826
2827         Reviewed by David Levin.
2828
2829         Removed WebSocket runtime settings.
2830         https://bugs.webkit.org/show_bug.cgi?id=29896
2831
2832         WebSocket runtime configuration is supported by chromium/v8 only.
2833
2834         * DumpRenderTree/mac/DumpRenderTree.mm:
2835         (resetDefaultsToConsistentValues):
2836         * DumpRenderTree/win/DumpRenderTree.cpp:
2837         (resetDefaultsToConsistentValues):
2838
2839 2009-10-19  Nate Chapin  <japhet@chromium.org>
2840
2841         Reviewed by Adam Barth.
2842
2843         Add testFail() to test plugin so we can test our handling of a
2844         plugin invoke call returning false.
2845
2846         https://bugs.webkit.org/show_bug.cgi?id=30239
2847
2848         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2849         (pluginInvoke):
2850         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2851
2852 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2853
2854         Reviewed by Gustavo Noronha.
2855
2856         Enable DOM pasting when running layout tests.
2857
2858         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2859         (resetDefaultsToConsistentValues):
2860
2861 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2862
2863         Reviewed by Simon Hausmann.
2864
2865         Use the setPreferredContentsSize method instead
2866         of setFixedContentsSize, as the method has been renamed.
2867
2868         * DumpRenderTree/qt/DumpRenderTree.cpp:
2869         (WebCore::DumpRenderTree::open):
2870         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2871         (LayoutTestController::setFixedContentsSize):
2872
2873 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2874
2875         Reviewed by Dan Bernstein.
2876
2877         https://bugs.webkit.org/show_bug.cgi?id=30456
2878         Fixes for new Debug_All Windows build configuration.
2879
2880         * DumpRenderTree/win/DumpRenderTree.cpp:
2881         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2882         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2883
2884 2009-10-16  Eric Seidel  <eric@webkit.org>
2885
2886         Reviewed by Adam Barth.
2887
2888         commit-queue status bot should list which buildbot is blocking the queue
2889         https://bugs.webkit.org/show_bug.cgi?id=30452
2890
2891         Add new methods and testing.
2892
2893         * Scripts/bugzilla-tool:
2894         * Scripts/modules/buildbot.py:
2895         * Scripts/modules/buildbot_unittest.py:
2896
2897 2009-10-16  Eric Seidel  <eric@webkit.org>
2898
2899         Reviewed by Adam Barth.
2900
2901         run-webkit-tests fails when CWD is not inside a WebKit checkout
2902         https://bugs.webkit.org/show_bug.cgi?id=30451
2903
2904         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2905         * Scripts/modules/scm_unittest.py:
2906           - Remove use of original_path (we don't need to restore the CWD).
2907           - Don't use '.' to find the webkit checkout, use __file__ instead.
2908
2909 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2910
2911         Reviewed by Adam Roben.
2912
2913         Add a Debug_All configuration to build entire stack as debug.
2914         Change Debug_Internal to:
2915         - stop using _debug suffix for all WebKit/Safari binaries
2916         - not use _debug as a DLL naming suffix
2917         - use non-debug C runtime lib.
2918
2919         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2920         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2921         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2922         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2923         Add missing debug.vsprops inherited property sheet.
2924         Add Debug_All configuration.
2925         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2926         * WinLauncher/WinLauncher.vcproj:
2927         Removed extraneous definitions inherited from vsprops.
2928         Add Debug_All configuration.
2929
2930 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2931
2932         Reviewed by David Levin.
2933
2934         check-webkit-style is wrong about indent checking in namespaces
2935         in header files and a few other things
2936         https://bugs.webkit.org/show_bug.cgi?id=30362
2937
2938         The few other things include:
2939         + check-webkit-style does not require spaces around the equal sign
2940           inside 'if' statements and around binary operators that take 
2941           numeric literals.
2942         + check-webkit-style reports false errors for the / operator
2943           when part of a filename in the #include directive.
2944
2945         * Scripts/modules/cpp_style.py:
2946         Improved indentation checking and space checking around
2947         binary operators. While the checks are still not perfect,
2948         they are clearly better than before.
2949         * Scripts/modules/cpp_style_unittest.py:
2950         Added test cases for the newly supported checks and modified old
2951         test cases to match the new guidelines
2952
2953 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2954
2955         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2956
2957         * wx/build/settings.py:
2958
2959 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2960
2961         Reviewed by David Levin.
2962
2963         Add mod_pywebsocket to test Web Sockets.
2964         http://code.google.com/p/pywebsocket/
2965         https://bugs.webkit.org/show_bug.cgi?id=27490
2966
2967         * pywebsocket/COPYING: Added.
2968         * pywebsocket/MANIFEST.in: Added.
2969         * pywebsocket/README: Added.
2970         * pywebsocket/example/echo_client.py: Added.
2971         * pywebsocket/example/echo_wsh.py: Added.
2972         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2973         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2974         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2975         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2976         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2977         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2978         * pywebsocket/mod_pywebsocket/util.py: Added.
2979         * pywebsocket/setup.py: Added.
2980         * pywebsocket/test/config.py: Added.
2981         * pywebsocket/test/mock.py: Added.
2982         * pywebsocket/test/run_all.py: Added.
2983         * pywebsocket/test/test_dispatch.py: Added.
2984         * pywebsocket/test/test_handshake.py: Added.
2985         * pywebsocket/test/test_mock.py: Added.
2986         * pywebsocket/test/test_msgutil.py: Added.
2987         * pywebsocket/test/test_util.py: Added.
2988         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2989         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2990         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2991         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2992         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2993         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2994         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2995         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2996
2997 2009-10-15  James Robinson  <jamesr@google.com>
2998
2999         Reviewed by David Levin.
3000
3001         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3002
3003         https://bugs.webkit.org/show_bug.cgi?id=30426
3004
3005         * Scripts/modules/cpp_style.py:
3006         * Scripts/modules/cpp_style_unittest.py:
3007
3008 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3009
3010         Reviewed by Adam Roben.
3011
3012         Fixes <http://webkit.org/b/30411>.
3013         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3014         
3015         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3016         building Chromium.
3017
3018         * Scripts/pdevenv:
3019
3020 2009-10-15  Robin Dunn  <robin@alldunn.com>
3021
3022         Reviewed by Kevin Ollivier.
3023
3024         Add Mac package building scripts for wx.
3025         
3026         https://bugs.webkit.org/show_bug.cgi?id=30405
3027
3028         * wx/build/build_utils.py:
3029         * wx/build/settings.py:
3030         * wx/packaging/build-mac-installer.py: Added.
3031
3032 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3033
3034         Reviewed by Gustavo Noronha.
3035
3036         Enable Web Sockets support when running layout tests.
3037
3038         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3039         (resetDefaultsToConsistentValues):
3040
3041 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3042
3043         Reviewed by Gustavo Noronha.
3044
3045         Need to initialize event.button.button, since in most cases a
3046         button number is not passed as an argument.
3047
3048         * DumpRenderTree/gtk/EventSender.cpp:
3049         (mouseDownCallback):
3050         (mouseUpCallback):
3051
3052 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3053
3054         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3055         the OS if none was explicitly set.
3056
3057         * wx/build/settings.py:
3058
3059 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3060
3061         Reviewed by Timothy Hatcher.
3062
3063         Web Inspector: enable developers extras within inspector layout tests.
3064
3065         https://bugs.webkit.org/show_bug.cgi?id=30014
3066
3067         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3068         (LayoutTestController::showWebInspector):
3069         (LayoutTestController::closeWebInspector):
3070         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3071         (LayoutTestController::showWebInspector):
3072         (LayoutTestController::closeWebInspector):
3073
3074 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3075
3076         Reviewed by Jan Alonzo.
3077
3078         GtkLauncher is using a deprecated signal
3079         https://bugs.webkit.org/show_bug.cgi?id=30364
3080
3081         Modified GtkLauncher to use notify::title signal instead of
3082         deprecated title-changed signal
3083
3084         * GtkLauncher/main.c:
3085         (notify_title_cb):
3086         (create_browser):
3087
3088 2009-10-14  Brady Eidson  <beidson@apple.com>
3089
3090         Reviewed by Sam Weinig.
3091
3092         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3093         1 - Disables WebHistory
3094         2 - Doesn't make sense in that context anyway.
3095
3096         * DumpRenderTree/win/DumpRenderTree.cpp:
3097         (createWebViewAndOffscreenWindow):
3098
3099 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3100
3101         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3102         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3103
3104         * wx/build/settings.py:
3105         * wx/install-unix-extras:
3106
3107 2009-10-14  Brady Eidson  <beidson@apple.com>
3108
3109         Reviewed by Sam Weinig.
3110
3111         WebKit Win API should provide a delegate interface for global history.
3112         https://bugs.webkit.org/show_bug.cgi?id=29905
3113
3114         * DumpRenderTree/LayoutTestController.cpp:
3115         (LayoutTestController::LayoutTestController):
3116         * DumpRenderTree/LayoutTestController.h:
3117         (LayoutTestController::dumpHistoryDelegateCallbacks):
3118         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3119                 
3120         * DumpRenderTree/win/DumpRenderTree.cpp:
3121         (shouldLogHistoryDelegates):
3122         (runTest):
3123         (createWebViewAndOffscreenWindow):
3124         (main):
3125         * DumpRenderTree/win/DumpRenderTree.vcproj:
3126         
3127         Add the IWebHistoryDelegate to DRT Windows:
3128         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3129         (wstringFromBSTR):
3130         (HistoryDelegate::HistoryDelegate):
3131         (HistoryDelegate::~HistoryDelegate):
3132         (HistoryDelegate::QueryInterface):
3133         (HistoryDelegate::AddRef):
3134         (HistoryDelegate::Release):
3135         (HistoryDelegate::didNavigateWithNavigationData):
3136         (HistoryDelegate::didPerformClientRedirectFromURL):
3137         (HistoryDelegate::didPerformServerRedirectFromURL):
3138         (HistoryDelegate::updateHistoryTitle):
3139         (HistoryDelegate::populateVisitedLinksForWebView):
3140         * DumpRenderTree/win/HistoryDelegate.h: Added.
3141
3142         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3143         (LayoutTestController::removeAllVisitedLinks):
3144
3145 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3146
3147         Reviewed by Simon Hausmann.
3148
3149         [Qt] Implement support for setPOSIXLocale on Qt.
3150         https://bugs.webkit.org/show_bug.cgi?id=30268 
3151  
3152         * DumpRenderTree/qt/DumpRenderTree.cpp:
3153         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3154         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3155         (LayoutTestController::setPOSIXLocale):
3156         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3157
3158 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3159
3160         Unreviewed, adding myself to reviewers list.
3161
3162         * Scripts/modules/committers.py:
3163
3164 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3165
3166         Reviewed by Mark Rowe.
3167
3168         Fix null assignment so root tests work again.
3169
3170         * Scripts/webkitdirs.pm:
3171
3172 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3173
3174         Reviewed by Simon Hausmann.
3175
3176         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3177         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3178         This is done in preparation of implementing missing features in DRT.
3179         No functionality changes made yet.
3180
3181         * DumpRenderTree/qt/DumpRenderTree.cpp:
3182         * DumpRenderTree/qt/DumpRenderTree.pro:
3183         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3184         (EventSender::EventSender):
3185         (EventSender::mouseDown):
3186         (EventSender::mouseUp):
3187         (EventSender::mouseMoveTo):
3188         (EventSender::leapForward):
3189         (EventSender::keyDown):
3190         (EventSender::contextClick):
3191         (EventSender::scheduleAsynchronousClick):
3192         (EventSender::frameUnderMouse):
3193         * DumpRenderTree/qt/EventSenderQt.h: Added.
3194         (EventSender::clearKillRing):
3195         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3196         (LayoutTestController::LayoutTestController):
3197         (LayoutTestController::reset):
3198         (LayoutTestController::processWork):
3199         (LayoutTestController::maybeDump):
3200         (LayoutTestController::waitUntilDone):
3201         (LayoutTestController::notifyDone):
3202         (LayoutTestController::windowCount):
3203         (LayoutTestController::clearBackForwardList):
3204         (LayoutTestController::dumpEditingCallbacks):
3205         (LayoutTestController::dumpResourceLoadCallbacks):
3206         (LayoutTestController::queueBackNavigation):
3207         (LayoutTestController::queueForwardNavigation):
3208         (LayoutTestController::queueLoad):
3209         (LayoutTestController::queueReload):
3210         (LayoutTestController::queueScript):
3211         (LayoutTestController::provisionalLoad):
3212         (LayoutTestController::timerEvent):
3213         (LayoutTestController::encodeHostName):
3214         (LayoutTestController::decodeHostName):
3215         (LayoutTestController::setJavaScriptProfilingEnabled):
3216         (LayoutTestController::setFixedContentsSize):
3217         (LayoutTestController::setPrivateBrowsingEnabled):
3218         (LayoutTestController::setPopupBlockingEnabled):
3219         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3220         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3221         (LayoutTestController::numberOfActiveAnimations):
3222         (LayoutTestController::disableImageLoading):
3223         (LayoutTestController::dispatchPendingLoadRequests):
3224         (LayoutTestController::setDatabaseQuota):
3225         (LayoutTestController::clearAllDatabases):
3226         (LayoutTestController::whiteListAccessFromOrigin):
3227         (LayoutTestController::waitForPolicyDelegate):
3228         (LayoutTestController::overridePreference):
3229         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3230         (LayoutTestController::isLoading):
3231         (LayoutTestController::setLoading):
3232         (LayoutTestController::shouldDumpAsText):
3233         (LayoutTestController::shouldDumpBackForwardList):
3234         (LayoutTestController::shouldDumpChildrenAsText):
3235         (LayoutTestController::shouldDumpDatabaseCallbacks):
3236         (LayoutTestController::shouldDumpStatusCallbacks):
3237         (LayoutTestController::shouldWaitUntilDone):
3238         (LayoutTestController::canOpenWindows):
3239         (LayoutTestController::shouldDumpTitleChanges):
3240         (LayoutTestController::waitForPolicy):
3241         (LayoutTestController::dumpAsText):
3242         (LayoutTestController::dumpChildFramesAsText):
3243         (LayoutTestController::dumpDatabaseCallbacks):
3244         (LayoutTestController::dumpStatusCallbacks):
3245         (LayoutTestController::setCanOpenWindows):
3246         (LayoutTestController::dumpBackForwardList):
3247         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3248         (LayoutTestController::display):
3249         (LayoutTestController::dumpTitleChanges):
3250         (LayoutTestController::dumpSelectionRect):
3251         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3252         (TextInputController::TextInputController):
3253         (TextInputController::doCommand):
3254         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3255         * DumpRenderTree/qt/WorkQueue.cpp:
3256         * DumpRenderTree/qt/WorkQueue.h:
3257         * DumpRenderTree/qt/WorkQueueItem.h:
3258         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3259         (findFrameNamed):
3260         (LoadItem::invoke):
3261         (ReloadItem::invoke):
3262         (ScriptItem::invoke):
3263         (BackForwardItem::invoke):
3264         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3265         * DumpRenderTree/qt/jsobjects.h:
3266
3267 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3268
3269         Not reviewed, adding myself to the list of reviewers.
3270
3271         * Scripts/modules/committers.py:
3272
3273 2009-10-13  Anders Carlsson  <andersca@apple.com>
3274
3275         Reviewed by Sam Weinig.
3276
3277         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3278
3279         Make the private browsing mode testable by the test plug-in.
3280         
3281         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3282         (pluginGetProperty):
3283         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3284         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3285         (NPP_New):
3286         (NPP_SetValue):
3287
3288 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3289
3290         No review, just adding self to the list of reviewers.
3291
3292         * Scripts/modules/committers.py:
3293
3294 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3295
3296         Reviewed by Adam Roben.
3297
3298         Web Inspector: Use proper web view in inspector layout
3299         tests for windows.
3300
3301         https://bugs.webkit.org/show_bug.cgi?id=30298
3302
3303         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3304         (LayoutTestController::showWebInspector):
3305         (LayoutTestController::closeWebInspector):
3306         (LayoutTestController::evaluateInWebInspector):
3307
3308 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3309
3310         Reviewed by Sam Weinig.
3311
3312         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3313         https://bugs.webkit.org/show_bug.cgi?id=29841
3314
3315         * DumpRenderTree/mac/DumpRenderTree.mm:
3316         (resetDefaultsToConsistentValues):
3317         * DumpRenderTree/win/DumpRenderTree.cpp:
3318         (resetDefaultsToConsistentValues):
3319
3320 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3321
3322         Reviewed by Dimitri Glazkov.
3323
3324         Chromium Port - Windows
3325         https://bugs.webkit.org/show_bug.cgi?id=29969
3326
3327         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3328         * Scripts/webkitdirs.pm:
3329
3330 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3331
3332         Reviewed by Darin Adler.
3333
3334         jsc scripts cleanup and Qt/GTK fix
3335         https://bugs.webkit.org/show_bug.cgi?id=30288
3336
3337         Duplicated jscPath() moved to webkitdirs.pm.
3338         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3339         Configuration added (release/debug) to path for Qt-port on Windows.
3340
3341         * Scripts/run-javascriptcore-tests:
3342         * Scripts/run-jsc:
3343         * Scripts/run-sunspider:
3344         * Scripts/sunspider-compare-results:
3345         * Scripts/webkitdirs.pm:
3346
3347 2009-10-11  Adam Barth  <abarth@webkit.org>
3348
3349         Unreviewed.  Add Collin to committers.py.
3350
3351         * Scripts/modules/committers.py:
3352
3353 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3354
3355         wx build fix, add bindings to source/include dirs now that there are sources there.
3356
3357         * wx/build/settings.py:
3358
3359 2009-10-09  Mark Rowe  <mrowe@apple.com>
3360
3361         Reviewed by Brady Eidson.
3362
3363         Enable plug-in halting in DumpRenderTree.
3364
3365         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3366         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3367
3368         * DumpRenderTree/mac/DumpRenderTree.mm:
3369         (resetDefaultsToConsistentValues):
3370         * DumpRenderTree/mac/UIDelegate.mm:
3371         (-[UIDelegate webView:shouldHaltPlugin:]):
3372
3373 2009-10-08  Brady Eidson  <beidson@apple.com>
3374
3375         Reviewed by Dan Bernstein.
3376
3377         Ask the History Delegate to populate the visited links hash.
3378         <rdar://problem/7285293> and https://webkit.org/b/29904
3379
3380         Add the ability for LayoutTestController to clear all visited links.
3381         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3382
3383         * DumpRenderTree/LayoutTestController.cpp:
3384         (LayoutTestController::LayoutTestController):
3385         (removeAllVisitedLinksCallback):
3386         (LayoutTestController::staticFunctions):
3387         * DumpRenderTree/LayoutTestController.h:
3388         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3389         (LayoutTestController::removeAllVisitedLinks):
3390
3391         * DumpRenderTree/mac/HistoryDelegate.mm:
3392         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3393
3394         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3395         (LayoutTestController::removeAllVisitedLinks):
3396         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3397         (LayoutTestController::removeAllVisitedLinks):
3398         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3399         (LayoutTestController::removeAllVisitedLinks):
3400
3401
3402 2009-10-08  Daniel Bates  <dbates@webkit.org>
3403
3404         Reviewed by Adam Roben.
3405
3406         https://bugs.webkit.org/show_bug.cgi?id=30175
3407         
3408         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3409         the OLE drag-and-drop return value like the function it emulates. Currently, 
3410         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3411         whether the drag-and-drop operation was successful or was cancelled.
3412         
3413         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3414         return value according to whether the drop operation was successful or not.
3415
3416         * DumpRenderTree/win/EventSender.cpp:
3417         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3418         (replaySavedEvents): Ditto.
3419         * DumpRenderTree/win/EventSender.h:
3420         * DumpRenderTree/win/UIDelegate.cpp:
3421         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3422
3423 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3424
3425         Reviewed by Xan Lopez.
3426
3427         [GTK] Added support for a parameter setting the button that was
3428         pressed in the mouseDown function.
3429         https://bugs.webkit.org/show_bug.cgi?id=30220
3430
3431         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3432
3433 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3434
3435         Reviewed by Xan Lopez.
3436
3437         [GTK] Added a line to the bottom of the expected result to match
3438         the output of the test.
3439         https://bugs.webkit.org/show_bug.cgi?id=30220
3440
3441         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3442         expected.txt:
3443
3444 2009-10-08  Adam Roben  <aroben@apple.com>
3445
3446         Use QueryInterface to get IWebInspectorPrivate
3447
3448         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3449         accessed in a more standard way
3450
3451         Reviewed by John Sullivan and Tim Hatcher.
3452
3453         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3454         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3455         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3456         to the IWebInspectorPrivate interface.
3457
3458 2009-10-07  Adam Roben  <aroben@apple.com>
3459
3460         Implement DRT support for origin whitelisting
3461
3462         Fixes <http://webkit.org/b/30185>.
3463
3464         Reviewed by Eric Seidel.
3465
3466         * DumpRenderTree/win/DumpRenderTree.cpp:
3467         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3468         whitelist, to match Mac DRT.
3469         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3470         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3471         IWebViewPrivate::whiteListAccessFromOrigin.
3472
3473 2009-10-07  Brady Eidson  <beidson@apple.com>
3474
3475         Reviewed by Darin Adler.
3476
3477         Send title changes to the global history delegate.
3478         <rdar://problem/7285293> and https://webkit.org/b/29904
3479
3480         * DumpRenderTree/mac/HistoryDelegate.mm:
3481         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3482
3483 2009-10-07  Adam Barth  <abarth@webkit.org>
3484
3485         Unreviewed.  Remove some folks from committers.py who were listed on
3486         the WebKit Team wiki page but who weren't actually listed as commit+.
3487         At some point, we should coorelate this list with the committers
3488         mailing list.
3489
3490         * Scripts/modules/committers.py:
3491
3492 2009-10-07  Adam Barth  <abarth@webkit.org>
3493
3494         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3495         the wiki into committers.py.
3496
3497         * Scripts/modules/committers.py:
3498
3499 2009-10-07  Adam Barth  <abarth@webkit.org>
3500
3501         Unreviewed.  Added Aaron Boodman to committers.py.
3502
3503         * Scripts/modules/committers.py:
3504
3505 2009-10-07  Evan Martin  <evan@chromium.org>
3506
3507         Reviewed by Darin Adler.
3508
3509         Add API to LayoutTestController for re/setting the system locale.
3510         https://bugs.webkit.org/show_bug.cgi?id=18994
3511
3512         * DumpRenderTree/LayoutTestController.cpp:
3513         (setLocaleCallback):
3514         (LayoutTestController::staticFunctions):
3515         (LayoutTestController::setLocale):
3516         * DumpRenderTree/LayoutTestController.h:
3517
3518 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3519
3520         Reviewed by Jan Alonzo.
3521
3522         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3523         https://bugs.webkit.org/show_bug.cgi?id=29689
3524
3525         Build fix by adding -lfontconfig for DumpRenderTree.
3526
3527         * GNUmakefile.am:
3528
3529 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3530
3531         Reviewed by Simon Hausmann.
3532
3533         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3534
3535         * Scripts/run-webkit-tests:
3536
3537 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3538
3539         Reviewed by Gustavo Noronha.
3540
3541         "delete" in EventSender is the backspace key, not the delete one.
3542
3543         * DumpRenderTree/gtk/EventSender.cpp:
3544         (keyDownCallback):
3545
3546 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3547
3548         Reviewed by Gustavo Noronha.
3549
3550         getChildrenWithRange expects as last parameter the end index, not
3551         the length of the range. Correct this and clarify the variable
3552         names to reflect how the code works.
3553
3554         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3555         (AccessibilityUIElement::getChildrenWithRange):
3556         (AccessibilityUIElement::getChildAtIndex):
3557
3558 2009-10-06  Mark Rowe  <mrowe@apple.com>
3559
3560         Reviewed by Simon Fraser.
3561
3562         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3563
3564         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3565         the fact we have already changed the working directory to the top of the open source tree.
3566
3567 2009-10-06  Julie Parent  <jparent@chromium.org>
3568
3569         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3570         rather than my committer email.
3571
3572         * Scripts/modules/committers.py:
3573
3574 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3575
3576         Reviewed by Eric Seidel.
3577
3578         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3579
3580         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3581         it after each layout test as it should do, making the DRT dump additional output
3582         for all of the subsequent layout tests.
3583
3584         * DumpRenderTree/qt/jsobjects.cpp:
3585         (LayoutTestController::reset):
3586
3587 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3588
3589         Reviewed by Simon Hausmann.
3590
3591         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3592         fast/dom/assign-to-window-status.html test, which is passing as a result.
3593
3594         https://bugs.webkit.org/show_bug.cgi?id=30127
3595
3596         * DumpRenderTree/qt/DumpRenderTree.cpp:
3597         (WebCore::DumpRenderTree::DumpRenderTree):
3598         (WebCore::DumpRenderTree::statusBarMessage):
3599         * DumpRenderTree/qt/DumpRenderTree.h:
3600         * DumpRenderTree/qt/jsobjects.h:
3601         (LayoutTestController::shouldDumpStatusCallbacks):
3602         (LayoutTestController::dumpStatusCallbacks):
3603
3604 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3605
3606         Reviewed by Simon Hausmann.
3607
3608         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3609         ignores the argument indicating which mouse button to trigger.
3610         https://bugs.webkit.org/show_bug.cgi?id=30048
3611
3612         This affects the fast/events/mouse-click-events.html layout test.
3613
3614         * DumpRenderTree/qt/jsobjects.cpp:
3615         (EventSender::mouseDown):
3616         (EventSender::mouseUp):
3617         * DumpRenderTree/qt/jsobjects.h:
3618
3619 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3620
3621         Reviewed by Simon Hausmann.
3622
3623         [Qt] Fix the EventSender::keyDown() implementation
3624         https://bugs.webkit.org/show_bug.cgi?id=30043
3625
3626         It should post both a key press event and a key release event,
3627         just like other ports do.
3628
3629         * DumpRenderTree/qt/jsobjects.cpp:
3630         (EventSender::keyDown):
3631
3632 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3633
3634         wx build fix. Add jpeg to the list of libs to link against.
3635
3636         * wx/build/settings.py:
3637
3638 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3639
3640         Reviewed by Simon Hausmann.
3641
3642         [Qt] EventSender::keyDown() cannot send function-key events.
3643         https://bugs.webkit.org/show_bug.cgi?id=30044
3644
3645         This affects the fast/events/keydown-function-keys.html layout test.
3646
3647         * DumpRenderTree/qt/jsobjects.cpp:
3648         (EventSender::keyDown):
3649
3650 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3651
3652         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3653         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3654
3655         * wx/build/settings.py:
3656         * wx/build/wxpresets.py:
3657
3658 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3659
3660         Reviewed by Timothy Hatcher.
3661
3662         Web Inspector: add testing harness for Web Inspector.
3663
3664         https://bugs.webkit.org/show_bug.cgi?id=30010
3665
3666         * DumpRenderTree/LayoutTestController.cpp:
3667         (showWebInspectorCallback):
3668         (closeWebInspectorCallback):
3669         (evaluateInWebInspectorCallback):
3670         (LayoutTestController::staticFunctions):
3671         * DumpRenderTree/LayoutTestController.h:
3672         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3673         (LayoutTestController::showWebInspector):
3674         (LayoutTestController::closeWebInspector):
3675         (LayoutTestController::evaluateInWebInspector):
3676         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3677         (LayoutTestController::showWebInspector):
3678         (LayoutTestController::closeWebInspector):
3679         (LayoutTestController::evaluateInWebInspector):
3680         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3681         (LayoutTestController::showWebInspector):
3682         (LayoutTestController::closeWebInspector):
3683         (LayoutTestController::evaluateInWebInspector):
3684         * DumpR