fa9bbc6839e6f1650407ee0775deb00afb4aac43
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-24  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Ada Chan.
4
5         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
6
7         - Adds simplified UndoManager to windows DRT to allow testing the
8           undo/redo code paths in WebCore and WebKit.  This is a temporary
9           solution to an issue that should eventually be solved by having a
10           shared UndoManager in WebKit.
11
12         * DumpRenderTree/win/DumpRenderTree.cpp:
13         (runTest):
14         * DumpRenderTree/win/UIDelegate.cpp:
15         (DRTUndoObject::DRTUndoObject):
16         (DRTUndoObject::invoke):
17         (DRTUndoStack::~DRTUndoStack):
18         (DRTUndoStack::isEmpty):
19         (DRTUndoStack::clear):
20         (DRTUndoStack::push):
21         (DRTUndoStack::pop):
22         (DRTUndoManager::canRedo):
23         (DRTUndoManager::canUndo):
24         (DRTUndoManager::DRTUndoManager):
25         (DRTUndoManager::removeAllActions):
26         (DRTUndoManager::registerUndoWithTarget):
27         (DRTUndoManager::redo):
28         (DRTUndoManager::undo):
29         (UIDelegate::UIDelegate):
30         (UIDelegate::resetUndoManager):
31         (UIDelegate::registerUndoWithTarget):
32         (UIDelegate::removeAllActionsWithTarget):
33         (UIDelegate::setActionTitle):
34         (UIDelegate::undo):
35         (UIDelegate::redo):
36         (UIDelegate::canUndo):
37         (UIDelegate::canRedo):
38         * DumpRenderTree/win/UIDelegate.h:
39
40 2008-01-23  Adam Roben  <aroben@apple.com>
41
42         Allow directories containing ChangeLogs to be passed to
43         resolve-ChangeLogs
44
45         Reviewed by David Kilzer.
46
47         * Scripts/resolve-ChangeLogs:
48         (sub findChangeLog): Return a ChangeLog contained within the specified
49         directory if one exists.
50
51 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
52
53         <rdar://problem/5698732> Copyright strings should include 2008
54
55         Reviewed by Sam.
56
57         * Drosera/win/Drosera.vcproj/Drosera.rc:
58         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
59
60 2008-01-23  Alp Toker  <alp@atoker.com>
61
62         Rubber-stamped by Mark Rowe.
63
64         Remove whitespace after -I in automake include lists.
65
66         * GNUmakefile.am:
67
68 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
69
70         Reviewed by Lars Knoll <lars@trolltech.com>.
71
72         Reworked the JavaScriptCore Qt bindings:
73         
74         * Update JS DRT controller for Qt JS binding changes.
75         There were two functions that needed some changes
76         so that the layout tests would work, so this makes
77         a few tests pass again.
78         
79         * Bump the timeout for layout tests up to 11s.
80         At least some tests have an internal timeout of
81         10 seconds, so make the waitUntilDone approach
82         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
83         is one of these - now the failure message is more
84         accurate.
85         
86
87         * DumpRenderTree/qt/jsobjects.cpp:
88         (LayoutTestController::waitUntilDone):
89         * DumpRenderTree/qt/jsobjects.h:
90
91 2008-01-22  Anders Carlsson  <andersca@apple.com>
92
93         Reviewed by Darin and Adam.
94
95         <rdar://problem/5688975>
96         div element on microsoft site has wrong left offset.
97         
98         Add new method for testing the return vale of NPN_GetProperty.
99         
100         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
101         (pluginInvoke):
102
103 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
104
105         Reviewed by Adam Roben.
106
107         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
108
109         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
110
111 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
112
113         Reviewed by Alp Toker.
114
115         http://bugs.webkit.org/show_bug.cgi?id=16955
116         Get errors when cross-compile webkit-gtk
117
118         * GNUmakefile.am: Removed ICU_CFLAGS 
119
120 2008-01-21  Darin Adler  <darin@apple.com>
121
122         Reviewed by Mitz and Adam.
123
124         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
125         sorting speed by doing all sort criteria in a single pass instead of three sorts.
126
127 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
128
129         Reviewed by Holger.
130
131         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
132         
133         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
134         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
135         and make the return value depend on whether we successfully determined a focusable
136         node or not.
137         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
138         if we could not handle the focus chain ourselves.
139         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
140         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
141         used to control the situation of stepping out of the focus chain inside the page.
142         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
143         The layout tests expect this to be disabled but for the user it seems sensible to have it
144         on by default, hence the default in qwebsettings.cpp
145         
146
147         * DumpRenderTree/qt/DumpRenderTree.cpp:
148         (WebCore::WebPage::WebPage):
149
150 2008-01-19  Mark Rowe  <mrowe@apple.com>
151
152         Reviewed by Alp Toker.
153
154         Allow the --http flag to run-webkit-tests to override
155         the default behaviour of disabling HTTP tests for Qt,
156         Gtk and Wx.
157
158         * Scripts/run-webkit-tests:
159
160 2008-01-19  David Kilzer  <ddkilzer@apple.com>
161
162         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
163
164         Reviewed by Darin.
165
166         We now touch a check-for-global-initializers.timestamp file in
167         the TARGET_TEMP_DIR directory to determine when new object files
168         have been compiled and thus need to be checked.  If the timestamp
169         file doesn't exist, all object files will be checked.
170
171         Previously the modification time of the "executable" (the
172         framework binary, e.g., WebKit.framework/WebKit) was used, but
173         since this was the last file modified at the end of the compile
174         phase, no object files would ever get checked!
175
176         Also added JSCustomSQLTransactionCallback.o to the list of files
177         since it has static initializers in Debug builds of WebCore.
178
179         * Scripts/check-for-global-initializers:
180
181 2008-01-18  Adam Roben  <aroben@apple.com>
182
183         Build fix
184
185         * Scripts/build-webkit:
186
187 2008-01-18  Beth Dakin  <bdakin@apple.com>
188
189         Reviewed by Oliver.
190
191         Update build-webkit to account for foreign-object being disabled by 
192         default.
193
194         * Scripts/build-webkit:
195
196 2008-01-18  Adam Roben  <aroben@apple.com>
197
198         Updated for method renames
199
200         Reviewed by Adele.
201
202         * DumpRenderTree/mac/FrameLoadDelegate.mm:
203         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
204         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
205         (LayoutTestController::setMainFrameIsFirstResponder):
206         (LayoutTestController::setWindowIsKey):
207         * DumpRenderTree/mac/UIDelegate.mm:
208         (-[UIDelegate webViewFocus:]):
209         * DumpRenderTree/win/FrameLoadDelegate.cpp:
210         (FrameLoadDelegate::didCommitLoadForFrame):
211
212 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
213
214         Reviewed by Adam Roben.
215
216         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
217         between DRT and TestNetscapePlugin.
218
219         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
220         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
221
222 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
223
224         Reviewed by Holger.
225
226         Fix fast/dom/Window/window-resize.html
227         
228         In DRT connect the page's geometryChangeRequest signal to a slot that
229         sets the geometry of the view widget.
230         
231
232         * DumpRenderTree/qt/DumpRenderTree.cpp:
233         (WebCore::WebPage::setViewGeometry):
234         (WebCore::WebPage::WebPage):
235
236 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
237
238         Build fix.
239
240         * Drosera/DroseraWin.make:
241
242 2008-01-17  Darin Adler  <darin@apple.com>
243
244         * Scripts/run-webkit-tests: Fixed a bug number.
245
246 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
247
248         Reviewed by Adam Roben.
249
250         http://bugs.webkit.org/show_bug.cgi?id=16908
251         run-webkit-tests complains about missing FindSafari.exe
252
253         * Scripts/webkitdirs.pm: Append _debug as appropriate.
254
255 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
256
257         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
258         
259         Rubber-stamped by Jon Honeycutt.
260
261         * DumpRenderTree/win/DumpRenderTree.vcproj:
262
263 2008-01-16  Alp Toker  <alp@atoker.com>
264
265         Reviewed by Mark Rowe.
266
267         http://bugs.webkit.org/show_bug.cgi?id=16218
268         [GTK] API: Should this entry point be called go_back rather than go_backward?
269
270         Track back/forward API changes in the tools.
271
272         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
273         (BackForwardItem::invoke):
274         * GtkLauncher/main.c:
275         (go_back_cb):
276
277 2008-01-16  Adam Roben  <aroben@apple.com>
278
279         Windows build fix after r29488
280
281         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
282         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
283         expects to find the plugin.
284
285 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
286
287         Reviewed by Sam Weinig.
288         
289         Fixed the waitUntilDone watchdog timer -- the old code never added the
290         timer to the run loop, so it didn't do anything.
291
292         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
293         (LayoutTestController::setWaitToDump):
294         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
295         (LayoutTestController::setWaitToDump):
296
297 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
298
299         Use shared vsprops for most vcproj properties.
300         
301         Reviewed by Darin.
302
303         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
304         * DumpRenderTree/win/DumpRenderTree.vcproj:
305         * DumpRenderTree/win/ImageDiff.vcproj:
306         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
307         * FindSafari/FindSafari.vcproj:
308
309 2008-01-14  Stephanie  <slewis@apple.com>
310
311        Reviewed by NOBODY.
312   
313        revert accidental character.
314
315        * Scripts/run-webkit-tests:
316
317 2008-01-14  Stephanie  <slewis@apple.com>
318
319         RS=Oliver
320
321         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
322
323         * Scripts/run-webkit-tests:
324
325 2008-01-14  Darin Adler  <darin@apple.com>
326
327         * Scripts/do-webcore-rename: Queue up another rename.
328
329 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
330
331         Reviewed by Darin.
332
333         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
334         the tests were ran.
335         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
336
337         * Scripts/run-webkit-tests:
338
339 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
340
341         Reviewed by Darin.
342
343         * Randomize tests array to spot test cases where the results depends on the order
344         the tests are ran.
345         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
346
347         * Scripts/run-webkit-tests:
348
349 2008-01-14  Darin Adler  <darin@apple.com>
350
351         * Scripts/run-webkit-tests: More ignore list tweaking.
352
353 2008-01-14  Darin Adler  <darin@apple.com>
354
355         * Scripts/run-webkit-tests: Add another leak to the ignore list.
356
357 2008-01-14  Dan Bernstein  <mitz@apple.com>
358
359         Reviewed by Adam Roben.
360
361         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
362           build bots
363
364         * DumpRenderTree/win/DumpRenderTree.cpp:
365         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
366
367 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
368
369         Share common files across projects.
370         
371         Unify vsprops files
372         Debug:          common.vsprops, debug.vsprops
373         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
374         Release:        common.vsprops, release.vsprops
375         
376         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
377         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
378
379         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
380
381         Reviewed by Adam Roben.
382
383         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
384         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
385         * Drosera/win/Drosera.vcproj/VERSION: Removed.
386         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
387         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
388         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
389         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
390         * DumpRenderTree/win/DumpRenderTree.vcproj:
391         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
392         * DumpRenderTree/win/debug.vsprops: Removed.
393         * DumpRenderTree/win/debug_internal.vsprops: Removed.
394         * DumpRenderTree/win/release.vsprops: Removed.
395
396 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
397
398         Reviewed by Maciej.
399
400         - http://bugs.webkit.org/show_bug.cgi?id=16314
401           Script to launch Drosera
402
403         * Scripts/gdb-drosera: Added.
404         * Scripts/run-drosera: Added.
405         * Scripts/run-drosera-nightly.cmd: Added.
406         * Scripts/webkitdirs.pm: Added runDrosera function.
407
408 2008-01-13  Dan Bernstein  <mitz@apple.com>
409
410         - fix breakage due to last-minute change
411
412         * DumpRenderTree/win/DumpRenderTree.cpp:
413         (runTest): Declare the loop variable.
414
415 2008-01-13  Dan Bernstein  <mitz@apple.com>
416
417         Reviewed by Adam Roben.
418
419         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
420
421         * DumpRenderTree/win/DumpRenderTree.cpp:
422         (DumpRenderTreeWndProc):
423         (initialize):
424         (dumpBackForwardList):
425         (dumpBackForwardListForAllWindows):
426         (dump):
427         (resetWebViewToConsistentStateBeforeTesting): Factored out of
428         runTest().
429         (runTest):
430         (allWindows): Added. Returns a vector of all open windows.
431         (windowToWebViewMap): Added. Returns a map from open windows to their
432         WebViews.
433         (createWebViewAndOffscreenWindow): Factored out of main() to be
434         reusable for creating extra windows.
435         (main):
436         * DumpRenderTree/win/DumpRenderTreeWin.h:
437         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
438         (LayoutTestController::windowCount): Implemented.
439         * DumpRenderTree/win/UIDelegate.cpp:
440         (UIDelegate::createWebViewWithRequest): Implemented.
441         (UIDelegate::webViewClose): Implemented.
442         * DumpRenderTree/win/UIDelegate.h:
443
444 2008-01-12  Alp Toker  <alp@atoker.com>
445
446         Reviewed by Mark Rowe.
447
448         Hide non-public symbols in GTK+/autotools release builds.
449
450         * GNUmakefile.am:
451
452 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
453
454         Reviewed by Ap.
455
456         * Make launching of the WebKit httpd work on GNU/Debian/Linux
457         
458         The configuration of Apache2 and installation does not depend on
459         the kernel but on the distribution policy. Make launching of httpd
460         work for Debian derived distributions.
461
462         * Scripts/run-webkit-httpd:
463         * Scripts/run-webkit-tests:
464         * Scripts/webkitdirs.pm:
465
466 2008-01-12  Mark Rowe  <mrowe@apple.com>
467
468         Reviewed by Maciej Stachowiak.
469
470         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
471
472         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
473         match the callers expectations that it can take ownership of the string.
474
475 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
476
477         Reviewed by Adam Roben.
478
479         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
480
481         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
482         as these are only posted because the test window is not a normal visible one, and
483         they confuse drag&drop machinery.
484
485 2008-01-11  Adam Roben  <aroben@apple.com>
486
487         Fix a crash when pathToLocalResource fails and a leak
488
489         Reviewed by Darin.
490
491         * DumpRenderTree/LayoutTestController.cpp:
492         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
493         sure not to pass null to JSValueMakeString.
494         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
495         (LayoutTestController::pathToLocalResource): Print an error message if
496         the conversion fails so it's clear what happened.
497
498 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
499
500         Reviewed by John Sullivan.
501
502         * DumpRenderTree/mac/GCControllerMac.mm:
503         (GCController::collectOnAlternateThread): Updated for name change.
504
505 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
506
507         wx build fix. Don't build dftables any longer since it's now a Perl
508         script.
509
510         * wx/build-wxwebkit:
511
512 2008-01-10  Sam Weinig  <sam@webkit.org>
513
514         Reviewed by Anders Carlsson.
515
516         Make DRT track open windows instead of allocated windows so that
517         we can avoid ASSERTION due to late deallocs out of our control.
518
519         * DumpRenderTree/mac/DumpRenderTree.mm:
520         (dumpBackForwardListForAllWindows):
521         (runTest):
522         * DumpRenderTree/mac/DumpRenderTreeMac.h:
523         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
524         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
525         (+[DumpRenderTreeWindow openWindows]):
526         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
527         (-[DumpRenderTreeWindow close]):
528         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
529         (LayoutTestController::windowCount):
530
531 2008-01-10  Ada Chan  <adachan@apple.com>
532
533         Meta key is not the same as Alt key on windows.
534
535         Reviewed by Darin.
536
537         * DumpRenderTree/win/EventSender.cpp:
538         (keyDownCallback):
539
540 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
541
542         Reviewed by Darin, Sam and Adam.
543
544         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
545         link in gmail message displays JavaScript alert falsely complaining
546         about pop-up blocking.
547         - Added the ability to enable the pop-up blocker via the
548         LayoutTestController.
549
550         * DumpRenderTree/LayoutTestController.cpp:
551         (setPopupBlockingEnabledCallback):
552         (LayoutTestController::staticFunctions):
553         * DumpRenderTree/LayoutTestController.h:
554         * DumpRenderTree/mac/DumpRenderTree.mm:
555         (setDefaultsToConsistentValuesForTesting):
556         (resetWebViewToConsistentStateBeforeTesting):
557         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
558         (LayoutTestController::setPopupBlockingEnabled):
559
560 2008-01-10  Lars Knoll  <lars@trolltech.com>
561
562         Reviewed by Simon.
563
564         rename QWebPageHistory to QWebHistory.
565         
566
567         * DumpRenderTree/qt/jsobjects.cpp:
568
569 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
570
571         Reviewed by Darin.
572         
573         - add some more renames, adjust some
574
575         * Scripts/do-webcore-rename:
576
577 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
578
579         Reviewed by Oliver.
580
581         Enable SVG Fonts support by default.
582
583         * Scripts/build-webkit:
584
585 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
586
587         Reviewed by Adam.
588
589         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
590         DRT doesn't handle platform specific pixel test results correctly.
591
592         <test>-expected.txt files and <test>-expected.png files may now live
593         in different directories (ie. a cross-platform <test>-expected.txt file
594         and a platform-specific <test>-expected.png file).
595
596         * Scripts/run-webkit-tests:
597
598 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
599
600         Reviewed by Darin.
601
602         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
603         DRT did not correctly handle printing the '\0' char.  Now it does.
604
605         * DumpRenderTree/win/DumpRenderTree.cpp:
606         (dumpFramesAsText):
607         (dump):
608
609 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
610
611         Reviewed by Lars.
612
613         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
614         
615
616         * DumpRenderTree/qt/main.cpp:
617         * DumpRenderTree/qt/testplugin.cpp:
618         * DumpRenderTree/qt/testplugin.h:
619
620 2008-01-05  Mark Rowe  <mrowe@apple.com>
621
622         Reviewed by Alp Toker.
623
624         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
625
626         * DumpRenderTree/gtk/DumpRenderTree.cpp:
627         (processWork): Process pending work.
628         (webViewLoadFinished): Schedule processing of pending work.
629         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
630
631 2008-01-05  Darin Adler  <darin@apple.com>
632
633         * Scripts/do-webcore-rename: Some more renaming plans.
634
635 2008-01-04  Alice Liu  <alice.liu@apple.com>
636
637         Reviewed by Alexey and Darin.
638
639         Adding "home" and "end" to DRT's keydown since
640         DOM key events can't handle keyIdentifiers at this point. 
641
642         * DumpRenderTree/mac/EventSendingController.mm:
643         (-[EventSendingController keyDown:withModifiers:]):
644         * DumpRenderTree/win/EventSender.cpp:
645         (keyDownCallback):
646
647 2008-01-04  Lars Knoll  <lars@trolltech.com>
648
649         Reviewed by Simon.
650
651         fix DRT after the changes to QWebPage.
652         
653         The great thing is that we actually don't have
654         any regressions from the QWebPage change :)
655         
656
657         * DumpRenderTree/qt/DumpRenderTree.cpp:
658         (WebCore::DumpRenderTree::DumpRenderTree):
659
660 2008-01-04  Lars Knoll  <lars@trolltech.com>
661
662         Reviewed by Simon.
663
664         make QWebPage a QObject and get things to compile.
665         
666         Nothing works currently though.
667         
668
669         * DumpRenderTree/qt/DumpRenderTree.cpp:
670         (WebCore::DumpRenderTree::DumpRenderTree):
671
672 2008-01-04  Lars Knoll  <lars@trolltech.com>
673
674         Reviewed by Simon.
675
676         take a QString as identifier in QWebFrame::addToJSWindowObject.
677
678         * DumpRenderTree/qt/DumpRenderTree.cpp:
679         (WebCore::DumpRenderTree::initJSObjects):
680
681 2008-01-04  Alp Toker  <alp@atoker.com>
682
683         GTK+ DRT build fix for breakage introduced in r29149.
684
685         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
686         (LayoutTestController::execCommand):
687
688 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
689
690         Reviewed by Darin.
691
692         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
693
694         Added layoutTestController.execCommand to access editor commands that are not available
695         via document.execCommand.
696
697         * DumpRenderTree/LayoutTestController.cpp:
698         (execCommandCallback):
699         (LayoutTestController::staticFunctions):
700         * DumpRenderTree/LayoutTestController.h:
701         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
702         (LayoutTestController::execCommand):
703         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
704         (LayoutTestController::queueLoad):
705         (LayoutTestController::execCommand):
706
707 2008-01-03  Alice Liu  <alice.liu@apple.com>
708
709         Reviewed by Darin, Mitz.
710
711         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
712
713         the clickcount should not increase if the last click was at a different location.  it's a new click.
714
715         * DumpRenderTree/mac/DumpRenderTree.mm:
716         (runTest):
717         * DumpRenderTree/mac/EventSendingController.h:
718         * DumpRenderTree/mac/EventSendingController.mm:
719         (-[EventSendingController mouseDown]):
720         (-[EventSendingController mouseUp]):
721
722 2008-01-03  Darin Adler  <darin@apple.com>
723
724         Reviewed by Adam.
725
726         * Scripts/update-webkit: Make this work a little better for the people at Apple
727         who have a directory named Internal.
728
729 2008-01-03  Adam Roben  <aroben@apple.com>
730
731         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
732
733         Rubberstamped by Mark.
734
735         * Scripts/update-webkit-auxiliary-libs:
736
737 2008-01-03  Adam Roben  <aroben@apple.com>
738
739         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
740
741         http://bugs.webkit.org/show_bug.cgi?id=15663
742
743         Added a fuzz factor into the Last-Modified comparison for downloading
744         WebKitAuxiliaryLibrary.zip.
745
746         The zip file is served from a set of mirrors who give Last-Modified
747         times that are off by 1-3 seconds from each other. This was causing
748         the build bots to redownload WebKitAuxiliaryLibrary for every build,
749         which would then cause all of WebCore to rebuild each time.
750
751         Reviewed by Mark.
752
753         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
754         at least 30 seconds newer than the old one -- otherwise we assume that
755         the difference in time is due to the mirrors being slightly offset
756         from each other.
757         (sub lastModifiedToUnixTime): Added.
758
759 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
760
761         Windows build fix.
762
763         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
764
765 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
766
767         Reviewed by Lars.
768
769         Moved QWebPage::open to QWebFrame::load and added setHtml.
770         
771
772         * DumpRenderTree/qt/DumpRenderTree.cpp:
773         (WebCore::DumpRenderTree::open):
774
775 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
776
777         Reviewed by Lars.
778
779         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
780         
781
782         * DumpRenderTree/qt/DumpRenderTree.cpp:
783         (WebCore::DumpRenderTree::DumpRenderTree):
784
785 2008-01-02  Sam Weinig  <sam@webkit.org>
786
787         * Scripts/do-webcore-rename: Yet more renaming ideas.
788
789 2008-01-02  Darin Adler  <darin@apple.com>
790
791         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
792
793 2008-01-02  Alice Liu  <alice.liu@apple.com>
794
795         Reviewed by Sam Weinig.
796
797         fixing assertion hit with editing/selection/move-begin-end.html
798
799         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
800         * DumpRenderTree/win/DumpRenderTree.vcproj:
801         * DumpRenderTree/win/EventSender.cpp:
802         (keyDownCallback):
803         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
804
805 2008-01-02  Darin Adler  <darin@apple.com>
806
807         * Scripts/do-webcore-rename: Some more name change plans.
808
809 2008-01-02  Alice Liu  <alice.liu@apple.com>
810
811         Reviewed by Maciej.
812
813         Added handling for page up and page down in EventSender
814
815         * DumpRenderTree/mac/EventSendingController.mm:
816         (-[EventSendingController keyDown:withModifiers:]):
817         * DumpRenderTree/win/EventSender.cpp:
818         (keyDownCallback):
819
820 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
821
822         Reviewed by Darin.
823
824         Fix fast/events/arrow-keys-on-body.html for real.
825
826         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
827
828 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
829
830         Reviewed by Darin.
831
832         http://bugs.webkit.org/show_bug.cgi?id=16674
833         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
834
835         * Scripts/run-launcher:
836
837 2007-12-31  Darin Adler  <darin@apple.com>
838
839         Suggested by Antti.
840
841         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
842         we get it installed on the build bots.
843
844 2007-12-30  Eric Seidel  <eric@webkit.org>
845
846         Reviewed by Sam.
847
848         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
849
850 2007-12-29  Darin Adler  <darin@apple.com>
851
852         Reviewed by Oliver.
853
854         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
855           leak bot shows createCStringFromNPVariant result leaking
856
857         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
858         (pluginInvoke): Added a missing free.
859
860 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
861
862         Reviewed by Alp Toker.
863
864         http://bugs.webkit.org/show_bug.cgi?id=16390
865         Use autotools or GNU make as the build system for the GTK port
866
867         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
868         * GNUmakefile.am: Added.
869
870 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
871
872         Reviewed by Oliver.
873
874         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
875
876         * DumpRenderTree/win/EventSender.cpp:
877         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
878         of 1, even though WebKit currently ignores it.
879
880 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
881
882         wx buildbot fix. Update libpng dl script to the latest version.
883
884         * wx/install-unix-extras:
885
886 2007-12-22  Antti Koivisto  <antti@apple.com>
887
888         Fix a typo.
889
890         * Scripts/webkitdirs.pm:
891
892 2007-12-21  Sam Weinig  <sam@webkit.org>
893
894         Reviewed by Mark Rowe.
895
896         - Disable the back/forward cache using the new WebPreferences API
897           instead of through the BackForwardList.  This makes us match what
898           we do on Windows.
899
900         * DumpRenderTree/mac/DumpRenderTree.mm:
901         (createWebViewAndOffscreenWindow):
902         (setDefaultsToConsistentValuesForTesting):
903
904 2007-12-21  Dan Bernstein  <mitz@apple.com>
905
906         Reviewed by Mark Rowe.
907
908         - disable the back/forward cache in Windows DumpRenderTree. It is
909           already disabled in Mac DumpRenderTree.
910
911         * DumpRenderTree/win/DumpRenderTree.cpp:
912         (initializePreferences):
913
914 2007-12-13  Antti Koivisto  <antti@apple.com>
915
916         Reviewed by Darin and Steve.
917         
918         - check for QuickTime SDK on Windows.
919         - build media support on Windows by default
920
921         * Scripts/build-webkit:
922         * Scripts/webkitdirs.pm:
923
924 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
925
926         Build script fix for buildbot.
927
928         * wx/build-wxwebkit:
929
930 2007-12-20  Eric Seidel  <eric@webkit.org>
931
932         Reviewed by mjs.
933
934         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
935
936 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
937
938         Reviewed by Steve.
939
940         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
941         WebKit.
942
943         - Drosera and Safari need to use the same ProgIDs in order for
944         CoCreateInstance to work properly.  The most robust way to do this is
945         for WebKit to dynamically publish those ProgIDs.
946
947         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
948         (DebuggerClient::createWebViewWithRequest):
949         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
950         statics.
951         (Drosera::initUI):
952         (Drosera::attach):
953         (Drosera::attemptToCreateServerConnection):
954         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
955         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
956         make use of the published ProgIDs.
957         (ServerConnection::attemptToCreateServerConnection):
958
959 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
960
961         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
962         - Build bot and leak fix.
963
964         * DumpRenderTree/LayoutTestController.cpp:
965         (pathToLocalResourceCallback):
966
967 2007-12-19  David Kilzer  <ddkilzer@apple.com>
968
969         Make svn-apply/svn-unapply work with patches from git-format-patch.
970
971         Reviewed by Darin.
972
973         * Scripts/svn-apply:
974         (patch): If 'Index:' can't be found in the text passed in, print it
975         out with a warning and return early.
976         * Scripts/svn-unapply:
977         (patch): Ditto.
978
979 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
980
981         Reviewed by Alp Toker.
982
983         Build related fixes.
984
985         * wx/build-wxwebkit:
986         - Check to make sure the user is running a supported wx port
987         - More robust checks for Cygwin
988         - Only run install-unix-extras on Mac, it's not the right solution
989           for Linux distros.
990         - Remove outdated Linux instructions after successful build
991         - Clean Bakefile-generated files during a clean operation
992
993 2007-12-18  Darin Adler  <darin@apple.com>
994
995         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
996
997 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
998
999         Add script to run Drosera as part of the nightly.
1000         
1001         Reviewed by Kevin M.
1002
1003         * Scripts/run-drosera.cmd: Added.
1004
1005 2007-12-18  Darin Adler  <darin@apple.com>
1006
1007         * Scripts/do-webcore-rename: Remove a stray K.
1008
1009 2007-12-18  Darin Adler  <darin@apple.com>
1010
1011         * Scripts/do-webcore-rename: Plan more renaming.
1012
1013 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1014
1015         Reviewed by Alp Toker.
1016
1017         http://bugs.webkit.org/show_bug.cgi?id=16042
1018         [GTK] Eliminate webkit_init()
1019
1020         Moving webkit initialization to WebView class init.
1021
1022         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1023         (main):
1024         * GtkLauncher/main.c:
1025         (main):
1026
1027 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1028
1029         Reviewed by Alp Toker.
1030
1031         http://bugs.webkit.org/show_bug.cgi?id=13542
1032         gdklauncher doesnt change URL in adress GTKEntry.
1033
1034         * GtkLauncher/main.c:
1035         (load_commit_cb): added
1036         (title_change_cb):
1037         (create_browser):
1038
1039 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1040
1041         Reviewed by Adam Roben.
1042
1043         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1044
1045         * FindSafari/FindSafari.cpp:
1046         (_tmain):
1047
1048 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1049
1050         Reviewed by Adam Roben.
1051
1052         http://bugs.webkit.org/show_bug.cgi?id=16315
1053         FindSafari needs a path-only option.
1054
1055         * FindSafari/FindSafari.cpp:
1056         (_tmain):
1057
1058 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1059
1060         Reviewed by Darin.
1061
1062         http://bugs.webkit.org/show_bug.cgi?id=16462
1063         REGRESSION: access keys broken on Windows
1064
1065         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1066         if Alt is pressed.
1067
1068 2007-12-15  Sam Weinig  <sam@webkit.org>
1069
1070         Reviewed by Mark Rowe.
1071
1072         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1073         the case when wstring.find doesn't find anything.
1074
1075         * DumpRenderTree/win/DumpRenderTree.cpp:
1076         (urlSuitableForTestResult):
1077
1078 2007-12-15  Alp Toker  <alp@atoker.com>
1079
1080         GTK+ DRT build fix for GLib < 2.14.
1081
1082         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1083         (LayoutTestController::setWaitToDump):
1084
1085 2007-12-05  Mark Rowe  <mrowe@apple.com>
1086
1087         Reviewed by Alp Toker.
1088
1089         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1090         many layout tests from hanging while waiting on user responses to dialogs.
1091
1092         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1093         (invalidateAnyPreviousWaitToDumpWatchdog):
1094         (webViewScriptAlert):
1095         (webViewScriptPrompt):
1096         (webViewScriptConfirm):
1097         (main):
1098         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1099         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1100         (waitToDumpWatchdogFired):
1101         (LayoutTestController::setWaitToDump):
1102
1103 2007-12-05  Mark Rowe  <mrowe@apple.com>
1104
1105         Reviewed by Alp Toker.
1106
1107         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1108
1109         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1110         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1111         (dump):
1112         (runTest):
1113         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1114         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1115         work queue is empty.
1116         (webViewWindowObjectCleared): Set up window.layoutTestController.
1117         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1118         (main): Hook up the new signals.
1119         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1120         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1121         dumping multiple times.
1122         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1123         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1124
1125 2007-12-14  Anders Carlsson  <andersca@apple.com>
1126
1127         Reviewed by Brady.
1128
1129         Assert that a web frame that's loading a resource always has either a data source or 
1130         a provisional data source.
1131         
1132         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1133         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1134
1135 2007-12-14  Darin Adler  <darin@apple.com>
1136
1137         - fix mistake causing nearly all tests to fail on Windows
1138
1139         * DumpRenderTree/win/UIDelegate.cpp:
1140         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1141         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1142
1143         * DumpRenderTree/mac/UIDelegate.mm:
1144         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1145         than passing the entire message.
1146
1147 2007-12-14  Darin Adler  <darin@apple.com>
1148
1149         - fix Tiger build
1150
1151         * DumpRenderTree/mac/UIDelegate.mm:
1152         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1153         new-to-Leopard methods.
1154
1155 2007-12-14  Darin Adler  <darin@apple.com>
1156
1157         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1158         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1159         delegate methods here.
1160
1161 2007-12-14  Anders Carlsson  <andersca@apple.com>
1162
1163         Reviewed by Darin and Geoff.
1164
1165         <rdar://problem/5619295> 
1166         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1167         
1168         Add property getting methods to the plug-in.
1169         
1170         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1171         (pluginInvoke):
1172
1173 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1174
1175         Reviewed by Darin.
1176
1177         - Layout test fix for mac. When dumped to the console local file paths
1178         now only show the name of the resource not the whole path.  This is to
1179         make the results machine and OS independent.
1180
1181         * DumpRenderTree/mac/UIDelegate.mm:
1182         (-[UIDelegate webView:addMessageToConsole:]):
1183
1184 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1185
1186         Reviewed by Adam.
1187
1188         - Layout tests fix.  We need a way to remove machine-dependent
1189         information from paths in layout test results. The UIDelegate now does
1190         this.
1191
1192         * DumpRenderTree/DumpRenderTree.h:
1193         * DumpRenderTree/win/DumpRenderTree.cpp:
1194         (urlSuitableForTestResult):
1195         * DumpRenderTree/win/DumpRenderTreeWin.h:
1196         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1197         * DumpRenderTree/win/UIDelegate.cpp:
1198         (UIDelegate::webViewAddMessageToConsole):
1199
1200 2007-12-13  Alp Toker  <alp@atoker.com>
1201
1202         Build fix for DRT breakage introduced in r28690.
1203
1204         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1205         (LayoutTestController::pathToLocalResource):
1206
1207 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1208
1209         Reviewed by Alice and Sam.
1210
1211         - <rdar://5621435> Need a way to specify local resources (being loaded
1212         from HTTP tests) on Windows.
1213         - Implemented pathToLocalResource which exposes the functionality of
1214         converting a given unix path to the correct location on Windows.
1215
1216         * DumpRenderTree/LayoutTestController.cpp:
1217         (pathToLocalResourceCallback):
1218         (LayoutTestController::staticFunctions):
1219         * DumpRenderTree/LayoutTestController.h:
1220         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1221         (LayoutTestController::pathToLocalResource):
1222         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1223         (LayoutTestController::pathToLocalResource):
1224
1225 2007-12-12  Anders Carlsson  <andersca@apple.com>
1226
1227         Reviewed by Sam.
1228
1229         <rdar://problem/5132003>
1230         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1231
1232         * DumpRenderTree/win/DumpRenderTree.cpp:
1233         (main):
1234         Set the resource load delegate.
1235         
1236         * DumpRenderTree/win/DumpRenderTree.vcproj:
1237         
1238         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1239         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1240
1241 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1242
1243         Reviewed by Adam Roben.
1244
1245         Fix conversion from double to LPARAM in dispatchMessage().
1246
1247         * DumpRenderTree/win/EventSender.cpp:
1248         (dispatchMessageCallback):
1249
1250 2007-12-11  Dan Bernstein  <mitz@apple.com>
1251
1252         Reviewed by Mark Rowe and Sam Weinig too!
1253
1254         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1255           fonts DumpRenderTree registers.
1256
1257         * DumpRenderTree/win/DumpRenderTree.cpp:
1258         (initialize):
1259
1260 2007-12-11  Brady Eidson  <beidson@apple.com>
1261
1262         Reviewed by Anders
1263
1264         Make DumpRenderTree on mac use its own path for Databases testing
1265
1266         * DumpRenderTree/mac/DumpRenderTree.mm:
1267         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1268           for future DRT-only use, then use it to construct the Databases path and set that default
1269
1270 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1271
1272         Reviewed by Darin.
1273
1274         <rdar://problem/5535636>
1275         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1276
1277         http://bugs.webkit.org/show_bug.cgi?id=13916
1278         JavaScript detects Tab as a character input on a textfield validation
1279
1280         * DumpRenderTree/mac/EventSendingController.mm:
1281         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1282         Dispatch a keyup to better match what happens when a key is physically pressed.
1283
1284         * DumpRenderTree/win/EventSender.cpp:
1285         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1286         returning from keyDown().
1287         (getConstantCallback): Fixed a couple copy/paste mistakes.
1288
1289 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1290
1291         Reviewed by Oliver.
1292
1293         - <rdar://5599845> Drosera: Does not show loal files in the file list
1294         on the left side.
1295
1296         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1297         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1298         so the open source community can build.
1299
1300 2007-12-10  Brady Eidson  <beidson@apple.com>
1301
1302         Rubberstamped by Sam Weinig
1303
1304         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1305
1306         * DumpRenderTree/mac/UIDelegate.mm:
1307         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1308         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1309
1310 2007-12-08  Oliver Hunt  <oliver@apple.com>
1311
1312         Reviewed by Sam W.
1313
1314         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1315         
1316         Fixes <rdar://problem/5620249> Must disable SVG animation
1317         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1318         
1319         In order to allow finer grained control over the set of SVG features
1320         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1321         distinct flags:
1322         ENABLE_SVG_ANIMATION
1323         ENABLE_SVG_FILTERS
1324         ENABLE_SVG_FONTS
1325         ENABLE_SVG_AS_IMAGE
1326         ENABLE_SVG_USE
1327         
1328         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1329         
1330         Script handles all the new build flags, and allows --svg-experimental
1331         to automatically enable all features.
1332
1333         * Scripts/build-webkit:
1334
1335 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1336
1337         Fix version parsing.
1338
1339         Rubber-stamped by Oliver.
1340
1341         * Drosera/win/Drosera.vcproj/auto-version.sh:
1342
1343 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1344
1345         Build modifications for Drosera.
1346
1347         Reviewed by Adam.
1348
1349         * Drosera/DroseraWin.make: Added.
1350         * Drosera/win/Drosera.vcproj/Drosera.rc:
1351         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1352         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1353         * Drosera/win/Drosera.vcproj/VERSION: Added.
1354         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1355
1356 2007-12-06  Adam Roben  <aroben@apple.com>
1357
1358         Explicitly turn on the Mac font ascent hack on Windows
1359
1360         This keeps our font metrics matching those from Mac.
1361
1362         Reviewed by Hyatt.
1363
1364         * DumpRenderTree/win/DumpRenderTree.cpp:
1365         (main):
1366
1367 2007-12-06  Anders Carlsson  <andersca@apple.com>
1368
1369         Rename main.c to main.cpp here too.
1370         
1371         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1372
1373 2007-12-06  Sam Weinig  <sam@webkit.org>
1374
1375         Rubber stamped by Geoff.
1376
1377         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1378
1379 2007-12-06  Darin Adler  <darin@apple.com>
1380
1381         * Scripts/do-webcore-rename: Some more renaming plans.
1382
1383 2007-12-06  Anders Carlsson  <andersca@apple.com>
1384
1385         Restore implementation of testGetIntIdentifier that was accidentally
1386         removed somehow (possibly when I made PluginObject be a cpp file).
1387         
1388         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1389         (pluginInvoke):
1390
1391 2007-12-05  Anders Carlsson  <andersca@apple.com>
1392
1393         Make the entry points extern "C".
1394         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1395         
1396 2007-12-05  Anders Carlsson  <andersca@apple.com>
1397
1398         C++ warning fixes.
1399         
1400         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1401         (NPP_New):
1402         (NPP_Destroy):
1403         (NPP_SetWindow):
1404         (NPP_NewStream):
1405         (NPP_HandleEvent):
1406         (NPP_URLNotify):
1407         (NPP_GetValue):
1408
1409 2007-12-05  Anders Carlsson  <andersca@apple.com>
1410
1411         Add the .cpp files to the TestNetscapePlugIn target.
1412
1413         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1414
1415 2007-12-05  Anders Carlsson  <andersca@apple.com>
1416
1417         Reviewed by Geoff.
1418         
1419         Rename the TestNetscapePlugIn .c files to be .cpp.
1420
1421         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1422         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1423         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1424         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1425         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1426         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1427         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1428         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1429
1430 2007-12-05  Adam Roben  <aroben@apple.com>
1431
1432         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1433
1434         This fixes several regression tests.
1435
1436         Reviewed by Alice.
1437
1438         * DumpRenderTree/win/EventSender.cpp:
1439         (keyDownCallback): Virtual keycodes for ASCII characters are always
1440         uppercase, so we need to check the case of the original character
1441         passed in to eventSender.keyDown.
1442
1443 2007-12-05  Adam Roben  <aroben@apple.com>
1444
1445         Learn from Tim's mistakes
1446
1447         * DumpRenderTree/win/DumpRenderTree.cpp:
1448         (runTest): Reset the authorAndUserStylesEnabled preference for each
1449         test.
1450
1451 2007-12-05  Alp Toker  <alp@atoker.com>
1452
1453         Reviewed by Mark Rowe.
1454
1455         Initialize GTK+ and WebKit so the tests can run.
1456
1457         Reorganize the headers a little.
1458
1459         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1460         (main):
1461
1462 2007-12-04  Anders Carlsson  <andersca@apple.com>
1463
1464         Remove IWebScriptScope include.
1465         
1466         * Drosera/win/DebuggerDocumentPlatform.cpp:
1467
1468 2007-12-04  Sam Weinig  <sam@webkit.org>
1469
1470         Rubber stamped by Mark Rowe.
1471
1472         Define CF as platform for mac and revert r28409
1473
1474         * DumpRenderTree/DumpRenderTree.h:
1475         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1476
1477 2007-12-04  Sam Weinig  <sam@webkit.org>
1478
1479         Define CF as platform for windows.
1480
1481         Reviewed by Adam Roben.
1482
1483         * DumpRenderTree/win/DumpRenderTreeWin.h:
1484
1485 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1486
1487         Reviewed by Adam and Darin.
1488
1489         - Removed a needless BSTR cleanup.
1490
1491         * Drosera/win/DebuggerDocumentPlatform.cpp:
1492         (DebuggerDocument::getPlatformCurrentFunctionStack):
1493
1494 2007-11-27  Adam Roben  <aroben@apple.com>
1495
1496         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1497
1498         Reviewed by Maciej.
1499
1500         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1501         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1502
1503 2007-12-04  Alp Toker  <alp@atoker.com>
1504
1505         Prospective Win DRT build fix.
1506
1507         * DumpRenderTree/DumpRenderTree.h:
1508
1509 2007-12-04  Alp Toker  <alp@atoker.com>
1510
1511         Fix a clobbered copyright header.
1512
1513         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1514
1515 2007-12-04  Xan Lopez  <xan@gnome.org>
1516
1517         Reviewed by Alp Toker.
1518
1519         http://bugs.webkit.org/show_bug.cgi?id=15561
1520         GTK port needs DumpRenderTree implementation
1521
1522         Start work on the GTK+ DRT.
1523
1524         This does not work yet, and there are a few lingering style issues
1525         (nothing major) but this patch has been stuck in the bug tracker for
1526         too long already.
1527
1528         * DumpRenderTree/DumpRenderTree.h:
1529         * DumpRenderTree/gtk: Added.
1530         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1531         (autocorrectURL):
1532         (shouldLogFrameLoadDelegates):
1533         (dumpFrameScrollPosition):
1534         (displayWebView):
1535         (appendString):
1536         (dumpFramesAsText):
1537         (dumpRenderTreeAsText):
1538         (dump):
1539         (runTest):
1540         (main):
1541         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1542         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1543         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1544         (GCController::collect):
1545         (GCController::collectOnAlternateThread):
1546         (GCController::getJSObjectCount):
1547         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1548         (LayoutTestController::~LayoutTestController):
1549         (LayoutTestController::addDisallowedURL):
1550         (LayoutTestController::clearBackForwardList):
1551         (LayoutTestController::copyDecodedHostName):
1552         (LayoutTestController::copyEncodedHostName):
1553         (LayoutTestController::display):
1554         (LayoutTestController::keepWebHistory):
1555         (LayoutTestController::notifyDone):
1556         (LayoutTestController::queueBackNavigation):
1557         (LayoutTestController::queueForwardNavigation):
1558         (LayoutTestController::queueLoad):
1559         (LayoutTestController::queueReload):
1560         (LayoutTestController::queueScript):
1561         (LayoutTestController::setAcceptsEditing):
1562         (LayoutTestController::setCustomPolicyDelegate):
1563         (LayoutTestController::setMainFrameIsFirstResponder):
1564         (LayoutTestController::setTabKeyCyclesThroughElements):
1565         (LayoutTestController::setUseDashboardCompatibilityMode):
1566         (LayoutTestController::setUserStyleSheetEnabled):
1567         (LayoutTestController::setUserStyleSheetLocation):
1568         (LayoutTestController::setWindowIsKey):
1569         (LayoutTestController::setWaitToDump):
1570         (LayoutTestController::windowCount):
1571         (LayoutTestController::setPrivateBrowsingEnabled):
1572         (LayoutTestController::setAuthorAndUserStylesEnabled):
1573         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1574         (JSStringCopyUTF8CString):
1575         (LoadItem::invoke):
1576         (ReloadItem::invoke):
1577         (ScriptItem::invoke):
1578         (BackForwardItem::invoke):
1579
1580 2007-12-03  Sam Weinig  <sam@webkit.org>
1581
1582         Move JavaScriptCore thread testing code to pthread specific directory
1583         and remove the dependance on CoreFoundation by using WTF::HashSet.
1584
1585         Reviewed by Geoff and Oliver.
1586
1587         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1588         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1589         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1590         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1591         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1592         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1593         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1594         * DumpRenderTree/pthreads: Added.
1595         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1596         (javaScriptThreads):
1597         (runJavaScriptThread):
1598         (startJavaScriptThreads):
1599         (stopJavaScriptThreads):
1600
1601 2007-12-03  Andrew Bonventre  <andybons@google.com>
1602
1603         Reviewed by Darin Adler.
1604
1605         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1606         Symbol lookup menu broken in debugger view
1607
1608         * Drosera/debugger.js: Fixed javascript error where document property
1609         should have been used instead of contentDocument in switchFunction that
1610         was breaking the select symbol dropdown menu.  This is because
1611         window.frames will return a Window object and not a frame object like
1612         the author was originally expecting.
1613
1614 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1615
1616         Reviewed by Adam.
1617
1618         - <rdar://5618942> Drosera: Console window does not process everything
1619         correctly.
1620         - <rdar://5619005> Drosera: could be sped up by moving the 
1621         WebScriptScope stuff into the WebScriptCallFrame.
1622         - Now the console can correctly process objects and does not receive
1623         notifications from JavaScriptCore about the JavaScript in Drosera's
1624         own process.
1625
1626         * Drosera/win/DebuggerDocumentPlatform.cpp:
1627         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1628         (DebuggerDocument::platformValueForScopeVariableNamed):
1629
1630 2007-12-03  Stephanie  <slewis@apple.com>
1631
1632         Reviewed by Darin.
1633
1634         Check to see if we are building a debug root
1635
1636         * Scripts/check-for-global-initializers: 
1637
1638 2007-12-03  Dan Bernstein  <mitz@apple.com>
1639
1640         Reviewed by Darin Adler.
1641
1642         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1643
1644         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1645         (pluginInvoke):
1646
1647 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1648
1649         Reviewed by Oliver.
1650
1651         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1652         in a more fine-grained manner than eventSender.keyDown().
1653
1654         * DumpRenderTree/win/EventSender.cpp:
1655         (getConstantCallback):
1656         (dispatchMessageCallback):
1657
1658 2007-12-02  Darin Adler  <darin@apple.com>
1659
1660         * Scripts/do-webcore-rename: More planned renaming.
1661
1662 2007-12-02  Sam Weinig  <sam@webkit.org>
1663
1664         Rubber stamped by Anders.
1665
1666         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1667         more uniform results cross platform.
1668
1669         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1670         (-[NSURL _drt_descriptionSuitableForTestResult]):
1671
1672 2007-12-02  Sam Weinig  <sam@webkit.org>
1673
1674         Rubber stamped by Niko.
1675
1676         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1677
1678         * DumpRenderTree/win/DumpRenderTree.cpp:
1679         * DumpRenderTree/win/DumpRenderTree.vcproj:
1680         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1681         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1682         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1683         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1684
1685 2007-12-01  Alp Toker  <alp@atoker.com>
1686
1687         Reviewed by Adam Roben.
1688
1689         Make use of the newly introduced webkit.h convenience header.
1690
1691         * GtkLauncher/main.c:
1692
1693 2007-12-01  Adam Treat  <treat@kde.org>
1694
1695         Reviewed by Simon.
1696
1697         * Check to see if the directory exists and exit if not.
1698
1699         * DumpRenderTree/qt/main.cpp:
1700         (main):
1701
1702 2007-12-01  Adam Treat  <treat@kde.org>
1703
1704         Reviewed by Simon.
1705
1706         * Don't hide symbols when in Debug mode
1707         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1708
1709
1710         * DumpRenderTree/qt/main.cpp:
1711         (messageHandler):
1712
1713 2007-11-30  Alp Toker  <alp@atoker.com>
1714
1715         Reviewed by Adam Roben.
1716
1717         http://bugs.webkit.org/show_bug.cgi?id=15691
1718         [GTK] Public API does not follow GTK+ conventions
1719
1720         Refactor the WebKit/GTK+ public API. Changes:
1721           WebKitPage -> WebKitWebView
1722           WebKitFrame -> WebKitWebFrame
1723
1724         Public API source and header names have been updated to mirror the API
1725         changes.
1726
1727         The API is now kept in WebKit/gtk/WebView to match other ports in the
1728         same class such as Mac and Win.
1729
1730         * GtkLauncher/main.c:
1731         (activate_uri_entry_cb):
1732         (link_hover_cb):
1733         (title_change_cb):
1734         (progress_change_cb):
1735         (go_back_cb):
1736         (go_forward_cb):
1737         (create_browser):
1738         (main):
1739
1740 2007-11-30  Adam Roben  <aroben@apple.com>
1741
1742         Hopefully the final build fix
1743
1744         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1745         pull in WTF's assertion/logging functions.
1746
1747 2007-11-30  Adam Roben  <aroben@apple.com>
1748
1749         Another build fix
1750
1751         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1752         WebKit.lib.
1753
1754 2007-11-30  Adam Roben  <aroben@apple.com>
1755
1756         Debug build fix
1757
1758         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1759         configuration.
1760         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1761         projects.
1762         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1763         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1764         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1765
1766 2007-11-30  Sam Weinig  <sam@webkit.org>
1767
1768         Reviewed by Adam Roben.
1769
1770         Fix drawSelectionRect to actually draw the selection rect.
1771
1772         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1773         (drawSelectionRect):
1774
1775 2007-11-30  Darin Adler  <darin@apple.com>
1776
1777         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1778
1779 2007-11-30  Darin Adler  <darin@apple.com>
1780
1781         * Scripts/do-webcore-rename: Get ready for some future renaming.
1782
1783 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1784
1785         Reviewed by Adam.
1786
1787         - Removed some unnecessary functions and changed an unused return type. 
1788
1789         * Drosera/win/DebuggerClient.cpp:
1790         (registerConsoleClass):
1791         * Drosera/win/DebuggerClient.h:
1792         * Drosera/win/Drosera.cpp:
1793         (registerDroseraClass):
1794
1795 2007-11-28  Alp Toker  <alp@atoker.com>
1796
1797         Reviewed by Timothy Hatcher.
1798
1799         http://bugs.webkit.org/show_bug.cgi?id=16174
1800         [GTK] Use "URI" not "URL" in public API
1801
1802         Replace use of the term "URL" with "URI" in public headers,
1803         documentation and some internal code to match GLib/GTK+ convention.
1804
1805         This is now mentioned in the API guidelines:
1806           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1807
1808         * GtkLauncher/main.c:
1809         (activate_uri_entry_cb):
1810         (title_change_cb):
1811         (create_toolbar):
1812         (main):
1813
1814 2007-11-29  Anders Carlsson  <andersca@apple.com>
1815
1816         Reviewed by Sam.
1817
1818         <rdar://problem/5230478>
1819         FrameLoadDelegate callbacks are not dumped in DRT.
1820         
1821         * DumpRenderTree/win/DumpRenderTree.cpp:
1822         (shouldLogFrameLoadDelegates):
1823         (runTest):
1824         (main):
1825         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1826         (BSTRtoString):
1827         (descriptionSuitableForTestResult):
1828         (FrameLoadDelegate::QueryInterface):
1829         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1830         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1831         (FrameLoadDelegate::didCommitLoadForFrame):
1832         (FrameLoadDelegate::didFinishLoadForFrame):
1833         (FrameLoadDelegate::willCloseFrame):
1834         (FrameLoadDelegate::didClearWindowObject):
1835         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1836         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1837         * DumpRenderTree/win/FrameLoaderDelegate.h:
1838         (FrameLoadDelegate::windowScriptObjectAvailable):
1839         (FrameLoadDelegate::didFirstLayoutInFrame):
1840
1841 2007-11-29  Sam Weinig  <sam@webkit.org>
1842
1843         Reviewed by Anders.
1844
1845         Add database quota UIDelegates methods to DRT UIDelegate.
1846
1847         * DumpRenderTree/mac/UIDelegate.mm:
1848         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1849         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1850
1851 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1852
1853         Reviewed by Sam.
1854
1855         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1856         dying and vice versa.
1857         - This fix will allow Drosera and Safari to reconnect if either of them
1858         closes correctly, but does not fix the case where one of them dies
1859         silently.
1860
1861         * Drosera/win/ServerConnection.cpp:
1862         (ServerConnection::attemptToCreateServerConnection): Added a safety
1863         check, because it's possilbe to try to connect to a server that's dying.
1864         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1865         the server has died.
1866         * Drosera/win/ServerConnection.h: Added the new function and removed
1867         an unnecessary member.
1868
1869 2007-11-29  Anders Carlsson  <andersca@apple.com>
1870
1871         * DumpRenderTree/win/DumpRenderTree.vcproj:
1872         Add shlwapi.lib to all configurations.
1873
1874 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1875
1876         - Build fix.  Added additional includes for VS Express to the Release
1877         project.
1878
1879         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1880
1881 2007-11-29  Anders Carlsson  <andersca@apple.com>
1882
1883         Reviewed by Adam.
1884
1885         <rdar://problem/5132005>
1886         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1887         
1888         * DumpRenderTree/win/DumpRenderTree.vcproj:
1889         Add shlwapi.lib
1890         
1891         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1892         (LayoutTestController::setUserStyleSheetEnabled):
1893         Implement this.
1894         
1895         (appendComponentToPath):
1896         New method which wraps the Win32 API PathAppend.
1897         
1898         (followShortcuts):
1899         New method which checks if a file points to a shortcut and
1900         follows the shortcut.
1901         
1902         (resolveCygwinPath):
1903         New method that takes a cygwin unix-style path and returns the Win32 path.
1904         
1905         (cfStringRefToWString):
1906         
1907         (LayoutTestController::setUserStyleSheetLocation):
1908         Implement this.
1909
1910 2007-11-29  Alice Liu  <alice.liu@apple.com>
1911
1912         Reviewed by Adam.
1913
1914         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1915
1916         * DumpRenderTree/win/EventSender.cpp:
1917         (keyDownCallback):
1918         uppercase letters were being sent as lowercase letters without the shift key down.
1919
1920 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1921
1922         - Windows build fix. VS express needs some love.
1923
1924         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1925
1926 2007-11-28  Darin Adler  <darin@apple.com>
1927
1928         Reviewed by Adam Roben.
1929
1930         * DumpRenderTree/mac/EventSendingController.mm:
1931         (-[EventSendingController keyDown:withModifiers:]):
1932         Send capital letters through as lowercase letters with the shift key down
1933         rather than sending them as if they were highly unusual "capital letter keys".
1934
1935         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1936         where you need to update results and more tests are failing than before.
1937
1938 2007-11-28  Anders Carlsson  <andersca@apple.com>
1939
1940         Reviewed by Darin.
1941
1942         <rdar://problem/5132001>
1943         contextClick is not implemented in DRT on Windows.
1944         
1945         * DumpRenderTree/win/EventSender.cpp:
1946         (contextClickCallback):
1947         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1948         by a WM_RBUTTONUP message.
1949         
1950         * DumpRenderTree/win/UIDelegate.cpp:
1951         (UIDelegate::hasCustomMenuImplementation):
1952         (UIDelegate::trackCustomPopupMenu):
1953         * DumpRenderTree/win/UIDelegate.h:
1954         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1955         menu from being shown (and causing the DRT to hang).
1956
1957 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1958
1959         Reviewed by Darin.
1960
1961         Fix DumpRenderTree ObjC bug comparing strings.
1962
1963         * DumpRenderTree/mac/ObjCController.m:
1964         (-[ObjCController identityIsEqual::]): Compare strings with string
1965         equality instead of identiy equality.
1966
1967 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1968
1969         Reviewed by Sam.
1970
1971         Reset the authorAndUserStylesEnabled preference
1972         back to YES for each test. Fixes the broken tests.
1973
1974         * DumpRenderTree/mac/DumpRenderTree.mm:
1975         (resetWebViewToConsistentStateBeforeTesting):
1976
1977 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1978
1979         Reviewed by Adam.
1980
1981         - Drosera now displays the console window, although it cannot currently
1982         process JavaScript.
1983
1984         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1985         (registerConsoleClass): Implemented.
1986         (consoleWndProc): Implemented.
1987         (DebuggerClient::onSize): Implemented.
1988         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1989         new window.
1990         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1991         creating and maintaining a new window.
1992         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1993         lines of code to more appropriate places.
1994         (Drosera::handleCommand):
1995         (Drosera::initUI):
1996         (Drosera::onSize):
1997         (Drosera::attach):
1998
1999 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2000
2001         Reviewed by Dave Hyatt.
2002
2003         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2004         
2005         Add support for disabling author and user styles for testing.
2006
2007         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2008         * DumpRenderTree/LayoutTestController.cpp:
2009         (setAuthorAndUserStylesEnabledCallback):
2010         (LayoutTestController::staticFunctions):
2011         * DumpRenderTree/LayoutTestController.h:
2012         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2013         (LayoutTestController::setAuthorAndUserStylesEnabled):
2014         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2015         (LayoutTestController::setAuthorAndUserStylesEnabled):
2016
2017 2007-11-26  Dan Bernstein  <mitz@apple.com>
2018
2019         - Tiger build fix.
2020
2021         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2022
2023 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2024
2025         Reviewed by Maciej.
2026
2027         - Implemented displaying variables for Drosera on Win.
2028
2029         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2030         that retrieve variables to not hold onto the return value since it's
2031         not returned.  Also changed to use the new signatures of the retrieval
2032         functions.
2033         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2034         (DebuggerDocument::platformValueForScopeVariableNamed):
2035         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2036         (droseraWndProc):
2037
2038 2007-11-26  Sam Weinig  <sam@webkit.org>
2039
2040         Cleanup names of painting and repainting functions.
2041
2042         Reviewed by Adam Roben.
2043
2044         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2045         (drawSelectionRect): was drawSelectionRectIntoContext.
2046         (dumpWebViewAsPixelsAndCompareWithExpected):
2047         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2048         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2049         (paintWebView): was drawWebViewIntoContext.
2050         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2051
2052 2007-11-26  Sam Weinig  <sam@webkit.org>
2053
2054         Reviewed by Dan Bernstein.
2055
2056         - Leopard build fix
2057
2058         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2059
2060 2007-11-26  Sam Weinig  <sam@webkit.org>
2061
2062         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2063         Use shared PixelDumpSupport for Mac DRT
2064
2065         Reviewed by Adam Roben.
2066
2067         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2068         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2069         * DumpRenderTree/cg/ImageDiffCG.cpp:
2070         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2071         (drawSelectionRectIntoContext):
2072         (dumpWebViewAsPixelsAndCompareWithExpected):
2073         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2074         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2075         * DumpRenderTree/mac/DumpRenderTree.mm:
2076         (dump):
2077         * DumpRenderTree/mac/ImageDiff.m: Removed.
2078         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2079         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2080         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2081         (setDefaultColorProfileToRGB):
2082         (getBitmapContextFromWebView):
2083         (drawWebViewIntoContext):
2084         (repaintWithVerticalSweep):
2085         (repaintWithHorizontalSweep):
2086         (getSelectionRect):
2087         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2088
2089 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2090
2091         Bug 16052: prepare-ChangeLog doesn't report deleted files
2092         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2093
2094         Reviewed by Sam.
2095
2096         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2097
2098 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2099
2100         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2101         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2102
2103         Reviewed by Adam.
2104
2105         Roll functionality of merge-changelog into resolve-ChangeLogs
2106         script.  The script now checks for ChangeLog.rej and
2107         ChangeLog.orig files first.  If it finds them, it uses the
2108         ChangeLog.rej file as a patch (in old contextual diff format) to
2109         apply with --fuzz=3.
2110
2111         * Scripts/merge-changelog: Removed.
2112         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2113
2114 2007-11-25  Sam Weinig  <sam@webkit.org>
2115
2116         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2117
2118         Reviewed by Mark Rowe.
2119
2120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2121         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2122         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2123         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2124         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2125
2126 2007-11-25  Sam Weinig  <sam@webkit.org>
2127
2128         Convert DumpRenderTree to ues .xcconfig files.
2129
2130         Reviewed by Mark Rowe.
2131
2132         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2133         * DumpRenderTree/mac/Configurations: Added.
2134         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2135         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2136         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2137
2138 2007-11-25  Sam Weinig  <sam@webkit.org>
2139
2140         Add ForwardingHeaders to wtf for DumpRenderTree.
2141
2142         Reviewed by Mark Rowe.
2143
2144         * DumpRenderTree/DumpRenderTree.h:
2145         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2146         * DumpRenderTree/ForwardingHeaders: Added.
2147         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2148         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2149         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2150         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2151         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2152         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2153         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2154         * DumpRenderTree/LayoutTestController.cpp:
2155         * DumpRenderTree/WorkQueue.cpp:
2156         * DumpRenderTree/mac/DumpRenderTree.mm:
2157         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2158         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2159         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2160         * DumpRenderTree/mac/ObjCController.m:
2161         * DumpRenderTree/mac/UIDelegate.mm:
2162         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2163
2164 2007-11-25  Adam Roben  <aroben@apple.com>
2165
2166         Fix some test failures caused by r28019
2167
2168         Now that stdout is in binary mode, we need to always use printf
2169         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2170         the output.
2171
2172         Reviewed by Sam.
2173
2174         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2175         printf.
2176         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2177         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2178         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2179         (UIDelegate::webViewAddMessageToConsole):
2180
2181 2007-11-25  Adam Roben  <aroben@apple.com>
2182
2183         Set the font smoothing preference in DRT
2184
2185         This makes the pixel results on Windows closer to the Mac results.
2186
2187         Reviewed by Mitz.
2188
2189         * DumpRenderTree/win/DumpRenderTree.cpp:
2190         (initializePreferences):
2191
2192 2007-11-25  Adam Roben  <aroben@apple.com>
2193
2194         Port ImageDiff to CG and C++
2195
2196         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2197         <rdar://5071708>
2198
2199         Reviewed by Sam.
2200
2201         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2202         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2203         (main):
2204         (createImageFromStdin):
2205         (compareImages):
2206         (getDifferenceBitmap):
2207         (computePercentageDifferent):
2208         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2209
2210 2007-11-25  Adam Roben  <aroben@apple.com>
2211
2212         Fix image diff link generation on Windows
2213
2214         Reviewed by Sam.
2215
2216         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2217         to toURL.
2218
2219 2007-11-25  Adam Roben  <aroben@apple.com>
2220
2221         Implement pixel dumping in Windows DRT
2222
2223         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2224         <rdar://5071708>
2225
2226         Reviewed by Sam.
2227
2228         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2229         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2230         Content-Length header.
2231         (getMD5HashStringForBitmap):
2232         (dumpWebViewAsPixelsAndCompareWithExpected):
2233         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2234         * DumpRenderTree/win/DumpRenderTree.cpp:
2235         (dump): Do a pixel dump if requested.
2236         (main): Parse pixel test options.
2237         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2238         the cg/ subdirectory to the include path.
2239         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2240         available in a header or import library, so we have to go through this
2241         LoadLibrary/GetProcAddress dance to use them.
2242         (cryptDLL):
2243         (init):
2244         (update):
2245         (final):
2246         (MD5_Init):
2247         (MD5_Update):
2248         (MD5_Final):
2249         * DumpRenderTree/win/MD5.h: Added.
2250         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2251         moved up to the top level to share it with Mac eventually.
2252         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2253         (getBitmapContextFromWebView): Forces the WebView to paint using a
2254         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2255
2256 2007-11-25  Adam Roben  <aroben@apple.com>
2257
2258         Clean up Windows DRT's option parsing a little bit
2259
2260         Reviewed by Sam.
2261
2262         * DumpRenderTree/win/DumpRenderTree.cpp:
2263         (main): Put non-option arguments into a Vector.
2264
2265 2007-11-25  Adam Roben  <aroben@apple.com>
2266
2267         Make Windows DRT stop changing LF into CRLF
2268
2269         Reviewed by Sam.
2270
2271         * DumpRenderTree/win/DumpRenderTree.cpp:
2272         (main): Put stdout in binary mode.
2273         * Scripts/run-webkit-tests: Remove the CRLF hack.
2274
2275 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2276
2277         Removed empty directory.
2278
2279         * Scripts/resources: Removed.
2280
2281 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2282
2283         Fix bisect-builds to work with recent WebKit nightly builds.
2284
2285         Reviewed by Dan.
2286
2287         * Scripts/bisect-builds: Check for the 
2288         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2289         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2290         to WebKit.app/Contents/Resources.
2291
2292 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2293
2294         Reviewed by Maciej.
2295
2296         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2297         not closed (affects digg.com)
2298
2299         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2300         one after finishing with a test to avoid having its delayed onload handler firing when
2301         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2302         but it helps somewhat.
2303
2304 2007-11-22  Mark Rowe  <mrowe@apple.com>
2305
2306         Reviewed by Alp Toker.
2307
2308         Fix build-webkit to propagate make's exit status if it fails.
2309
2310         * Scripts/webkitdirs.pm:
2311
2312 2007-11-22  Dan Bernstein  <mitz@apple.com>
2313
2314         Reviewed by Mark Rowe.
2315
2316         - fix crash when running pixel tests
2317
2318         * DumpRenderTree/mac/DumpRenderTree.mm:
2319         (dumpRenderTree): Parse the command line options before setting up the
2320         environment so that we know if we need to set up the pixel dump
2321         machinery.
2322
2323 2007-11-21  Eric Seidel  <eric@webkit.org>
2324
2325         Speculative build fix for Tiger.
2326
2327         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2328
2329 2007-11-21  Eric Seidel  <eric@webkit.org>
2330
2331         Reviewed by Tim Hatcher.
2332
2333         Break out more of DumpRenderTree.mm into individual files
2334
2335         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2336         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2337         (checkedMalloc):
2338         (checkedRealloc):
2339         (makeLargeMallocFailSilently):
2340         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2341         * DumpRenderTree/mac/DumpRenderTree.mm:
2342         (crashHandler):
2343         (dump):
2344         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2345         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2346         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2347         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2348         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2349         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2350         (javaScriptThreads):
2351         (runJavaScriptThread):
2352         (startJavaScriptThreads):
2353         (stopJavaScriptThreads):
2354         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2355         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2356         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2357         (restoreColorSpace):
2358         (setDefaultColorProfileToRGB):
2359         (initializeColorSpaceAndScreeBufferForPixelTests):
2360         (md5HashStringForBitmap):
2361         (dumpWebViewAsPixelsAndCompareWithExpected):
2362
2363 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2364
2365         Move install-unix-extras to wx directory as it seems only to be used by that 
2366         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2367         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2368         have install-unix-extras install into WebKitLibraries as per
2369         convention.
2370         
2371         Reviewed by Mark Rowe.
2372
2373         * Scripts/install-unix-extras: Removed.
2374         * wx/build-wxwebkit:
2375         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2376
2377 2007-11-21  Eric Seidel  <eric@webkit.org>
2378
2379         Reviewed by Adam.
2380
2381         More refactoring for greater code readability
2382
2383         * DumpRenderTree/mac/DumpRenderTree.mm:
2384         (initializeGlobalsFromCommandLineOptions):
2385         (initializeColorSpaceAndScreeBufferForPixelTests):
2386         (addTestPluginsToPluginSearchPath):
2387         (useLongRunningServerMode):
2388         (runTestingServerLoop):
2389         (prepareConsistentTestingEnvironment):
2390         (dumpRenderTree):
2391         (main):
2392         (dumpFramesAsText):
2393         (dumpBackForwardListForWebView):
2394         (sizeWebViewForCurrentTest):
2395         (methodNameStringForFailedTest):
2396         (dumpBackForwardListForAllWindows):
2397         (dumpWebViewAsPixelsAndCompareWithExpected):
2398         (invalidateAnyPreviousWaitToDumpWatchdog):
2399         (dump):
2400         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2401         * DumpRenderTree/mac/UIDelegate.mm:
2402         (-[UIDelegate webView:createWebViewWithRequest:]):
2403
2404 2007-11-21  Eric Seidel  <eric@webkit.org>
2405
2406         Reviewed by Tim Hatcher.
2407
2408         Abstract more of DRT into static methods
2409
2410         * DumpRenderTree/mac/DumpRenderTree.mm:
2411         (setDefaultsToConsistentValuesForTesting):
2412         (setupSignalHandlers):
2413         (allocateGlobalControllers):
2414         (releaseAndZero):
2415         (releaseGlobalControllers):
2416         (dumpRenderTree):
2417         (shouldLogFrameLoadDelegates):
2418         (createCFURLFromPathOrURL):
2419         (resetWebViewToConsistentStateBeforeTesting):
2420         (runTest):
2421
2422 2007-11-21  Eric Seidel  <eric@webkit.org>
2423
2424         Reviewed by Tim Hatcher.
2425
2426         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2427
2428         * DumpRenderTree/DumpRenderTree.h:
2429         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2430         * DumpRenderTree/mac/DumpRenderTree.mm:
2431         (dumpRenderTree):
2432         (dump):
2433         (runTest):
2434         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2435         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2436         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2437         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2438         (-[DumpRenderTreePasteboard declareType:owner:]):
2439         (+[LocalPasteboard alloc]):
2440         (-[LocalPasteboard init]):
2441         (-[LocalPasteboard dealloc]):
2442         (-[LocalPasteboard name]):
2443         (-[LocalPasteboard releaseGlobally]):
2444         (-[LocalPasteboard declareTypes:owner:]):
2445         (-[LocalPasteboard addTypes:owner:]):
2446         (-[LocalPasteboard changeCount]):
2447         (-[LocalPasteboard types]):
2448         (-[LocalPasteboard availableTypeFromArray:]):
2449         (-[LocalPasteboard setData:forType:]):
2450         (-[LocalPasteboard dataForType:]):
2451         (-[LocalPasteboard setPropertyList:forType:]):
2452         (-[LocalPasteboard setString:forType:]):
2453         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2454         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2455         (+[DumpRenderTreeWindow allWindows]):
2456         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2457         (-[DumpRenderTreeWindow dealloc]):
2458         (-[DumpRenderTreeWindow isKeyWindow]):
2459         (-[DumpRenderTreeWindow keyDown:]):
2460
2461 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2462
2463         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2464         it indiscriminately copies any headers inside JavaScriptCore,
2465         which includes Tiger ICU headers. 
2466
2467         * wx/build-wxwebkit:
2468         Don't run WebCore/move-js-headers.sh any longer.
2469
2470 2007-11-20  Adam Treat  <treat@kde.org>
2471
2472         Reviewed by David Kilzer.
2473
2474         * Prepend git branch name to $baseProductDir
2475
2476         * Scripts/VCSUtils.pm:
2477         * Scripts/webkitdirs.pm:
2478
2479 2007-11-20  Mark Rowe  <mrowe@apple.com>
2480
2481         Reviewed by Simon Hausmann.
2482
2483         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2484         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2485         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2486         built product and generated Makefile's are removed.
2487
2488 2007-11-19  Alp Toker  <alp@atoker.com>
2489
2490         Reviewed by Mark Rowe.
2491
2492         http://bugs.webkit.org/show_bug.cgi?id=16040
2493         [GTK] GtkLauncher should be written in C
2494
2495         Port GtkLauncher to plain C.
2496
2497         Use a more conventional GTK+ coding style.
2498
2499         Use a toolbar instead of menus.
2500
2501         Various signature fixes and cleanups.
2502
2503         Add a license header. Assume all previous modifications were copyright
2504         assigned to Apple Inc. by default.
2505
2506         * GtkLauncher/GtkLauncher.pro:
2507         * GtkLauncher/main.c: Added.
2508         (activate_url_entry_cb):
2509         (update_title):
2510         (link_hover_cb):
2511         (title_change_cb):
2512         (progress_change_cb):
2513         (destroy_cb):
2514         (go_back_cb):
2515         (go_forward_cb):
2516         (create_browser):
2517         (create_statusbar):
2518         (create_toolbar):
2519         (create_window):
2520         (main):
2521         * GtkLauncher/main.cpp: Removed.
2522
2523 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2524
2525         Build script fixes to ensure they do the right thing for the 
2526         wx port, and update build-wxwebkit to reflect the way the
2527         build scripts now work.
2528
2529         Reviewed by Adam.
2530
2531         * Scripts/build-testkjs:
2532         * Scripts/build-webkit:
2533         * Scripts/run-javascriptcore-tests:
2534         * Scripts/webkitdirs.pm:
2535         * wx/build-wxwebkit:
2536
2537 2007-11-18  Eric Seidel  <eric@webkit.org>
2538
2539         Reviewed by Anders.
2540
2541         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2542
2543         * Scripts/run-javascriptcore-tests:
2544
2545 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2546
2547         Reviewed by Adam Roben.
2548
2549         Make run-webkit-tests work with Windows debug build.
2550
2551         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2552         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2553         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2554         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2555         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2556
2557 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2558
2559         Add wxWebKit sample and build script, and integrate it with 
2560         build-webkit. Also make build-webkit --clean work for all
2561         ports.
2562
2563         Reviewed by Darin Adler.
2564
2565         * Scripts/build-webkit:
2566         * Scripts/webkitdirs.pm:
2567         * wx: Added.
2568         * wx/browser: Added.
2569         * wx/browser/browser.bkl: Added.
2570         * wx/browser/browser.cpp: Added.
2571         * wx/build-wxwebkit: Added.
2572
2573 2007-11-17  Adam Roben  <aroben@apple.com>
2574
2575         Make it easy to run Safari in the debugger on Windows
2576
2577         I've added a new script, debug-safari, which launches Safari in the
2578         debugger. On OS X it just calls gdb-safari.
2579
2580         Reviewed by Mark Rowe.
2581
2582         * FindSafari/FindSafari.cpp:
2583         (_tmain): Added a /debugger flag, which in combination with
2584         /printSafariLauncher will print a script that launches Safari in the
2585         debugger.
2586         * Scripts/debug-safari: Added.
2587         * Scripts/run-safari: Changed to call runSafari().
2588         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2589         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2590         first argument along to FindSafari.
2591         * Scripts/webkitdirs.pm:
2592         (sub runSafari): Added.
2593
2594 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2595
2596         Reviewed by Adam Roben.
2597
2598         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2599
2600 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2601
2602         Reviewed by David Kilzer.
2603
2604         The git config command was renamed to repo-config at some point. This
2605         change tries git config and then git repo-config if the first fails.
2606
2607         * Scripts/prepare-ChangeLog:
2608         (gitConfig):
2609
2610 2007-11-16  Dan Bernstein  <mitz@apple.com>
2611
2612         Reviewed by Darin Adler and Sam Weinig.
2613
2614         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2615
2616         * DumpRenderTree/win/EventSender.cpp:
2617         (keyDownCallback): For characters that cannot be entered on the active
2618         keyboard layout, send a WM_CHAR message with the character along with
2619         a WM_KEYDOWN message with a virtual key code of 255.
2620
2621 2007-11-16  Mark Rowe  <mrowe@apple.com>
2622
2623         Reviewed by Tim Hatcher.
2624
2625         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2626
2627         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2628         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2629
2630 2007-11-15  Adam Roben  <aroben@apple.com>
2631
2632         Make run-safari actually work on Windows
2633
2634         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2635         chdir call.
2636
2637 2007-11-14  Adam Roben  <aroben@apple.com>
2638
2639         Updates to Safari launching now that 3.0.4 is released
2640
2641         Reviewed by Sam.
2642
2643         * FindSafari/FindSafari.cpp:
2644         (getWebViewCLSID): Use version-independent ProgID.
2645         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2646
2647 2007-11-14  Anders Carlsson  <andersca@apple.com>
2648
2649         Reviewed by Adam.
2650
2651         <rdar://problem/5309081>
2652         In DRT, "plugin.logDestroy = true" not working on Windows.
2653         
2654         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2655         (NPP_Destroy):
2656
2657 2007-11-14  Eric Seidel  <eric@webkit.org>
2658
2659         Reviewed by Sam.
2660
2661         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2662
2663 2007-11-14  Anders Carlsson  <andersca@apple.com>
2664
2665         Reviewed by Adam.
2666
2667         <rdar://problem/5141186>
2668         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2669         
2670         Implement setWindowIsKey.
2671         
2672         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2673         (LayoutTestController::setWindowIsKey):
2674
2675 2007-11-13  Sam Weinig  <sam@webkit.org>
2676
2677         Reviewed by Adam Roben.
2678
2679         Fix for <rdar://problem/5382579>
2680         http/tests/security/cross-frame-access-put.html reports large 
2681         negative numbers for screenLeft and screenTop (Mac reports "0")
2682
2683         * DumpRenderTree/win/UIDelegate.cpp:
2684         (UIDelegate::UIDelegate): Initialize the RECT.
2685         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2686         (UIDelegate::webViewFrame): ditto.
2687         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2688
2689 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2690
2691         Reviewed by Adam.
2692
2693         - Make Drosera show source, source URLs, and function stack on Windows,
2694         and some minor fixes.
2695
2696         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2697         (DebuggerDocument::updateFileSource):
2698         * Drosera/debugger.js: Force source to always update display.
2699         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2700         menu controls.
2701         (DebuggerClient::resume):
2702         (DebuggerClient::pause):
2703         (DebuggerClient::stepInto):
2704         (DebuggerClient::stepOver):
2705         (DebuggerClient::stepOut):
2706         (DebuggerClient::showConsole):
2707         (DebuggerClient::closeCurrentFile):
2708         * Drosera/win/DebuggerClient.h: Ditto.
2709         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2710         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2711         removed two bugs.  1) caller could be in a bad state when asked to
2712         assign into it. 2) BSTRs were not created correctly.
2713         (DebuggerDocument::getPlatformCurrentFunctionStack):
2714         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2715         (droseraWndProc):
2716         (handleCommand):
2717         (Drosera::resume):
2718         (Drosera::pause):
2719         (Drosera::stepInto):
2720         (Drosera::stepOver):
2721         (Drosera::stepOut):
2722         (Drosera::showConsole):
2723         (Drosera::closeCurrentFile):
2724         * Drosera/win/Drosera.h: Hook up the menu controls.
2725         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2726         functions, added a null check, and fixed another bug where caller could
2727         be in a bad state when asked to assign into it.
2728         (ServerConnection::didLoadMainResourceForDataSource):
2729         (ServerConnection::getCallerFrame):
2730         * Drosera/win/ServerConnection.h: Safety first.
2731
2732 2007-11-13  Dan Bernstein  <mitz@apple.com>
2733
2734         Reviewed by Darin Adler.
2735
2736         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2737           DumpRenderTree --pixel-tests renders each test twice
2738
2739         * DumpRenderTree/mac/DumpRenderTree.mm:
2740         (dumpRenderTree): Removed the --paint option because the painting code
2741         is always exercised as a result of
2742         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2743         calling -displayIfNeeded.
2744         (dump): Changed to always grab the image from the window since the view
2745         is always displayed.
2746         (runTest):
2747         (displayWebView):
2748         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2749         because it always paints.
2750
2751 2007-11-12  Antti Koivisto  <antti@apple.com>
2752
2753         Reviewed by Adele.
2754         
2755         Add support for http media tests
2756
2757         * Scripts/run-webkit-tests:
2758
2759 2007-11-12  Sam Weinig  <sam@webkit.org>
2760
2761         Reviewed by Adam Roben.
2762
2763         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2764
2765         * DumpRenderTree/win/DumpRenderTree.cpp:
2766         (runTest):
2767         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2768         (LayoutTestController::setPrivateBrowsingEnabled):
2769
2770 2007-11-12  Adam Roben  <aroben@apple.com>
2771
2772         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2773         mac and win subdirectories.
2774
2775 2007-11-11  Adam Roben  <aroben@apple.com>
2776
2777         Fix <rdar://5133816> keepWebHistory is not implemented
2778
2779         Fixes fast/history/clicked-link-is-visited.html.
2780
2781         Reviewed by Darin.
2782
2783         * DumpRenderTree/win/DumpRenderTree.cpp:
2784         (runTest): Clear the optionalSharedHistory.
2785         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2786         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2787
2788 2007-11-10  Sam Weinig  <sam@webkit.org>
2789
2790         Reviewed by Tim Hatcher.
2791
2792         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2793         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2794         is turned on)
2795
2796         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2797
2798         Added test: http/tests/security/cross-frame-access-private-browsing.html
2799
2800         * DumpRenderTree/LayoutTestController.cpp:
2801         (setPrivateBrowsingEnabledCallback):
2802         (LayoutTestController::staticFunctions):
2803         * DumpRenderTree/LayoutTestController.h:
2804         * DumpRenderTree/mac/DumpRenderTree.mm:
2805         (runTest): Default to private browsing disabled.
2806         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2807         (LayoutTestController::setPrivateBrowsingEnabled):
2808         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2809         (LayoutTestController::setPrivateBrowsingEnabled):
2810
2811 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2812
2813         Reviewed by Adam.
2814
2815         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2816         WebCore's!
2817
2818         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2819         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2820         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2821         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2822         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2823         * Drosera/win/Drosera.cpp:
2824         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2825
2826 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2827
2828         Reviewed by Sam.
2829
2830         - Use the new IWebFrame [local] function signature and get the shared
2831         server correctly.
2832
2833         * Drosera/win/DebuggerClient.cpp:
2834         (DebuggerClient::didFinishLoadForFrame):
2835         * Drosera/win/ServerConnection.cpp:
2836         (ServerConnection::attemptToCreateServerConnection):
2837
2838 2007-11-07  Dan Bernstein  <mitz@apple.com>
2839
2840         Reviewed by Darin Adler.
2841
2842         - add an option to run-webkit-tests to ignore pixel test failures where
2843           all pixels differ by no more than a specified threshold
2844
2845         * DumpRenderTree/mac/ImageDiff.m:
2846         (main):
2847         (compareImages):
2848         (computePercentageDifferent):
2849         * Scripts/run-webkit-tests:
2850
2851 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2852
2853         Reviewed by Lars.
2854
2855         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2856
2857         * DumpRenderTree/qt/DumpRenderTree.cpp:
2858
2859 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2860
2861         Reviewed by Lars.
2862
2863         Reworked the QWebSettings API.
2864         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2865
2866         * DumpRenderTree/qt/DumpRenderTree.cpp:
2867
2868 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2869
2870         Reviewed by Lars.
2871
2872         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2873
2874         * DumpRenderTree/qt/jsobjects.cpp:
2875
2876 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2877
2878         Reviewed by Lars Knoll <lars@trolltech.com>.
2879
2880         Add a QWebPage::frameCreated() signal and fix DRT
2881         
2882         The removal of createFrame in QWebPage broke the re-implementation
2883         in DumpRenderTree. Instead emit a frameCreated() signal and
2884         connect to it in DumpRenderTree.
2885         
2886
2887         * DumpRenderTree/qt/DumpRenderTree.cpp:
2888         (WebCore::WebPage::WebPage):
2889         (WebCore::DumpRenderTree::dump):
2890         (WebCore::DumpRenderTree::connectFrame):
2891         * DumpRenderTree/qt/DumpRenderTree.h:
2892
2893 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2894
2895         Reviewed by Lars Knoll <lars@trolltech.com>.
2896
2897         Moved all the event handlers from QWebFrame into QWebPage.
2898         
2899         This cleans up the public API and allows us to remove the
2900         HackWebFrame hack in DumpRenderTree.
2901         
2902
2903         * DumpRenderTree/qt/jsobjects.cpp:
2904         (EventSender::mouseDown):
2905         (EventSender::mouseUp):
2906         (EventSender::mouseMoveTo):
2907
2908 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2909
2910         Reviewed by Mark.
2911
2912         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2913         to prevent the default implementation from popping up messageboxes.
2914
2915         * DumpRenderTree/qt/DumpRenderTree.cpp:
2916         (WebCore::WebPage::javaScriptConfirm):
2917         (WebCore::WebPage::javaScriptPrompt):
2918
2919 2007-11-06  Eric Seidel  <eric@webkit.org>
2920
2921         * Scripts/build-testkjs: build fix... too many $$
2922
2923 2007-11-06  Eric Seidel  <eric@webkit.org>
2924
2925         Reviewed by Mark Rowe.
2926
2927         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2928
2929 2007-11-05  Adam Roben  <aroben@apple.com>
2930
2931         Add support on Windows for WEBKIT_TESTFONTS
2932
2933         This environment variable lets you specify where the fonts to be used
2934         by DumpRenderTree reside. The Qt port is already using this, so I'm
2935         just following their lead.
2936
2937         Reviewed by Darin.
2938
2939         * DumpRenderTree/win/DumpRenderTree.cpp:
2940         (exePath): Refactored code out of initialize().
2941         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2942         DumpRenderTree.resources.
2943         (initialize): Use the new fontsPath function.
2944         (main): Use the new exePath function.
2945         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2946         variable to DRT, like Qt does.
2947
2948 2007-11-05  Mark Rowe  <mrowe@apple.com>
2949
2950         Rubber-stamped by Alp Toker.
2951
2952         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2953
2954         * GtkLauncher/main.cpp:
2955         (goToURLBarText):
2956         (main):
2957
2958 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2959
2960         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2961         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2962
2963         Reviewed by Timothy.
2964
2965         Restrict the range of nightly builds used by the bisect-builds script
2966         based on the version of Safari and the version of Mac OS X being used.
2967
2968         Mac OS X 10.4: Safari 2.0: r11976 or newer
2969         Mac OS X 10.4: Safari 3.0: r19992 or newer
2970
2971         Mac OS X 10.5: Safari 2.0: r19594 or newer
2972         Mac OS X 10.5: Safari 3.0: r25124 or newer
2973
2974         * Scripts/bisect-builds:
2975         (findMacOSXVersion): Added.
2976         (makeNightlyList): Added argument to provide version of Mac OS X.
2977         Restrict range of nightly builds based on Safari and Mac OS X versions.
2978
2979 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2980
2981         Reviewed by Maciej.
2982
2983         - This patch involves several changes, all of them were noticed that
2984         they were needed by the work being done in WebKit to get Drosera and
2985         WebKit working together on Windows.
2986         - The changes are:
2987         1) Added a debugger console for output messages.
2988         2) Drosera now listens for the WebKit server (before, the server would
2989         have to be running before Drosera was started.)
2990         3) Fixed a bug where the WebView started out as 0x0 pixels.
2991         4) Fixed a bug when there is no scope.
2992         5) Added the HTML, JS, and CSS to the project file to make them easy to
2993         find.
2994         6) Made the ServerConnection functions virtual.
2995
2996         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2997         for the WebKit server.
2998         (DebuggerClient::DebuggerClient):
2999         (DebuggerClient::~DebuggerClient):
3000         (DebuggerClient::didFinishLoadForFrame):
3001         (DebuggerClient::serverConnected):
3002         (DebuggerClient::attemptToCreateServerConnection):
3003         * Drosera/win/DebuggerClient.h: Ditto.
3004         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3005         scope.
3006         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3007         (DebuggerDocument::platformValueForScopeVariableNamed):
3008         * Drosera/win/Drosera.cpp:
3009         (_tWinMain): Added a console in debug for output messages.
3010         (Drosera::Drosera): Listen for server.
3011         (Drosera::initUI): The server now Initializes COM.
3012         (Drosera::serverConnected): Part of the listening for the server.
3013         (Drosera::attemptToCreateServerConnection): Ditto.
3014         * Drosera/win/Drosera.h: New interface for listening for the server.
3015         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3016         files to the VS project.
3017         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3018         connection.
3019         (ServerConnection::ServerConnection):
3020         (ServerConnection::attemptToCreateServerConnection):
3021         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3022         methods.
3023         (ServerConnection::serverConnected):
3024
3025 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3026
3027         Reviewed by Maciej.
3028
3029         http://bugs.webkit.org/show_bug.cgi?id=15832
3030         fast/dom/gc-10.html crashes when run alone
3031
3032         Check for !done before using objects that can be already deallocated.
3033
3034         * DumpRenderTree/mac/EditingDelegate.mm:
3035         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3036         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3037         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3038         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3039         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3040         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3041         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3042         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3043         (-[EditingDelegate webViewDidBeginEditing:]):
3044         (-[EditingDelegate webViewDidChange:]):
3045         (-[EditingDelegate webViewDidEndEditing:]):
3046         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3047         (-[EditingDelegate webViewDidChangeSelection:]):
3048         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3049         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3050         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3051         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3052         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3053         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3054         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3055         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3056         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3057         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3058         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3059         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3060         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3061         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3062         (-[FrameLoadDelegate webView:willCloseFrame:]):
3063         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3064         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3065         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3066         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3067         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3068         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3069         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3070         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3071         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3072
3073 2007-11-04  Mark Rowe  <mrowe@apple.com>
3074
3075         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3076         warnings that would otherwise be suppressed due to it being a system header.
3077
3078         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3079
3080 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3081
3082         Rubber stamped by Adam.
3083         
3084         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3085
3086         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3087
3088 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3089
3090         Sort files(...); sections of Xcode project files.
3091
3092         Rubber-stamped by Darin.
3093
3094         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3095         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3096         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3097         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3098
3099 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3100
3101         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3102
3103         Reviewed by Darin.
3104
3105         * Scripts/sort-Xcode-project-file: Added.
3106
3107 2007-11-02  Darin Adler  <darin@apple.com>
3108
3109         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3110
3111 2007-11-02  Darin Adler  <darin@apple.com>
3112
3113         Reviewed by Maciej.
3114
3115         * Scripts/run-sunspider: Pass the "--base" option through.
3116
3117         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3118         the real script do that. Default configuration to Release to match run-sunspider
3119         so we don't end up building Debug just to compare results.
3120
3121 2007-11-01  Adam Roben  <aroben@apple.com>
3122
3123         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3124
3125         Reviewed by Sam.
3126
3127         * Scripts/commit-log-editor: Show all the directories beneath the
3128         source root, instead of just the last one.
3129
3130 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3131
3132         Reviewed by Adam Roben.
3133
3134         Print out an error message when the Windows build fails
3135         and provide guidance on how to find out what went wrong.
3136
3137         * Scripts/build-webkit:
3138         * Scripts/webkitdirs.pm:
3139
3140 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3141
3142         Rubber-stamped by Adam Roben.
3143
3144         Rolled out r27326 - debug CRT seems to cause no problems after all.
3145
3146         * DumpRenderTree/win/DumpRenderTree.vcproj:
3147
3148 2007-10-31  Adam Roben  <aroben@apple.com>
3149
3150         Switch the Debug configuration to using the non-debug CRT
3151
3152         This matches WebKit.
3153
3154         Reviewed by Steve.
3155
3156         * DumpRenderTree/win/DumpRenderTree.vcproj:
3157
3158 2007-10-31  Antti Koivisto  <antti@apple.com>
3159
3160         Reviewed by bdash.
3161         
3162         Disable media tests when doing leak checking on Tiger.
3163         They crash in QuickTime (rdar://problem/5537157).
3164
3165         * Scripts/run-webkit-tests:
3166
3167 2007-10-29  Antti Koivisto  <antti@apple.com>
3168
3169         Reviewed by Maciej.
3170         
3171         Build media support by default on OSX only.
3172
3173         * Scripts/build-webkit:
3174
3175 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3176
3177         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3178         get caught by the pre-commit hooks.
3179
3180 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3181
3182         Reviewed by Adam.
3183
3184         - This is a collection of relatively unrelated changes and cleanups
3185         to Drosera to prepare it for interacting with WebKit.  A lot of these
3186         changes are just correcting mistakes, for example removing included
3187         headers that are no longer needed.
3188
3189         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3190         this will be needed by the DebuggerClient.
3191         (DebuggerDocument::server):
3192         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3193         * Drosera/win/DebuggerClient.cpp: 
3194         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3195         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3196         (DebuggerClient::createWebViewWithRequest): Added comment about its
3197         purpose. 
3198         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3199         declarations.
3200         (DebuggerClient::webViewLoaded): Moved.
3201         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3202         file, since this was the only place it was used.
3203         (cfStringToBSTR):
3204         * Drosera/win/Drosera.h: Cleaned up the includes.
3205         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3206         * Drosera/win/HelperFunctions.h: Removed.
3207
3208 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3209
3210         Reviewed by Adam.
3211
3212         - Small cleanup in the ServerConnection class.
3213
3214         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3215         and added an include.
3216         (ServerConnection::currentFrame):
3217         (ServerConnection::getCallerFrame):
3218         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3219         made a pointer into a COMPtr, and cleaned up the includes.
3220
3221 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3222
3223         Reviewed by John Sullivan.
3224         
3225         - Place the Localizable.strings file in mac or win directories
3226           if that location exists.
3227         - Also look for UI_STRING in .c files.
3228
3229         * Scripts/extract-localizable-strings:
3230
3231 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3232
3233         Reviewed by Adam.
3234
3235         - Set the eol-style to native and made all the line endings the same
3236         so that I avoid messy diffs that show eol changes.
3237
3238         * Drosera/win/ServerConnection.cpp:
3239         (ServerConnection::didParseSource):
3240         (ServerConnection::didEnterCallFrame):
3241         (ServerConnection::willExecuteStatement):
3242         (ServerConnection::willLeaveCallFrame):
3243         (ServerConnection::exceptionWasRaised):
3244
3245 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3246
3247         Reviewed by Adam.
3248
3249         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3250         functionality that could not have existed previously without the new
3251         interfaces.
3252         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3253         from a BSTR to a JSValueRef.
3254         (DebuggerDocument::platformEvaluateScript): Implemented.
3255         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3256         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3257         Implemented.
3258         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3259         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3260         * Drosera/win/ServerConnection.cpp: Added a helper function.
3261         (ServerConnection::getCallerFrame):
3262         * Drosera/win/ServerConnection.h: Added a helper function.
3263
3264 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3265
3266         updated reviewers for my previous changelog.
3267
3268 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3269         Reviewed by Maciej and Adam and Geoff.
3270
3271         - Minor mac-side improvements including moving a function to a more
3272         appropriate location, fixing a warning, and correctly checking
3273         exceptions.
3274
3275         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3276         (DebuggerDocument::willExecuteStatement):
3277         (DebuggerDocument::didEnterCallFrame):
3278         (DebuggerDocument::willLeaveCallFrame):
3279         (DebuggerDocument::windowScriptObjectAvailable):
3280         (DebuggerDocument::callFunctionOnObject):
3281         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3282         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3283         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3284         because it doesn't require the ServerConnection at all.
3285         (NSStringCreateWithJSStringRef): Made an argument const.
3286         (JSValueRefCreateWithNSString): Made an argument const.
3287         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3288         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3289         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3290         * Drosera/mac/ServerConnection.mm: Ditto.
3291         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3292
3293 2007-10-29  Sam Weinig  <sam@webkit.org>
3294
3295         Reviewed by Adam Roben.
3296
3297         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3298
3299         * DumpRenderTree/LayoutTestController.cpp:
3300         (LayoutTestController::LayoutTestController):
3301         (getGlobalFlagCallback):
3302         (setGlobalFlagCallback):
3303         (LayoutTestController::getJSClass):
3304         (LayoutTestController::staticValues):
3305         * DumpRenderTree/LayoutTestController.h:
3306         (LayoutTestController::globalFlag):
3307         (LayoutTestController::setGlobalFlag):
3308
3309 2007-10-29  Darin Adler  <darin@apple.com>
3310
3311         Reviewed by Maciej.
3312
3313         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3314         resolution instead of its default.
3315
3316 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3317
3318         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3319
3320         Reviewed by Mark Rowe.
3321
3322         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3323         was successfully resolved, but this would not show any status because the change had
3324         already been cached in the index using "git add".  The solution is to add an optional
3325         second argument to showStatus() which adds the "--cached" switch to the command.
3326
3327         * Scripts/resolve-ChangeLogs:
3328         (showStatus):
3329
3330 2007-10-28  Eric Seidel  <eric@webkit.org>
3331
3332         Reviewed by Maciej and Geoff, in unison.
3333
3334         * Scripts/run-webkit-tests: remove broken --svg option
3335
3336 2007-10-28  Darin Adler  <darin@apple.com>
3337
3338         Reviewed by Adam.
3339
3340         * Scripts/run-sunspider: Default to "Release" configuration rather than
3341         defaulting to the last configuration used as other scripts do. This can
3342         still be overriden on the command line with "--debug" if there's some
3343         reason to do so. Also fix a typo.
3344
3345         * Scripts/sunspider-compare-results: Fix a typo.
3346
3347 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3348
3349         Reviewed by Adam.
3350
3351         - Implemented the WebScriptDebugListener functions now that the
3352         WebScriptDebugServer exists
3353
3354         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3355         functions.
3356         (ServerConnection::currentFrame):
3357         (ServerConnection::didLoadMainResourceForDataSource):
3358         (ServerConnection::didParseSource):
3359         (ServerConnection::failedToParseSource):
3360         (ServerConnection::didEnterCallFrame):
3361         (ServerConnection::willExecuteStatement):
3362         (ServerConnection::willLeaveCallFrame):
3363         (ServerConnection::exceptionWasRaised):
3364         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3365         members arguments list.
3366
3367 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3368
3369         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3370         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3371
3372         Reviewed by Darin.
3373
3374         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3375         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3376         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3377         file.  Note that it may also be used as a stand-alone script.
3378
3379         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3380         * Scripts/resolve-ChangeLogs: Added.
3381         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3382
3383 2007-10-26  Mark Rowe  <mrowe@apple.com>
3384
3385         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3386         to the Qt port on the assumption that it was an implementation of the cross-platform
3387         LayoutTestController class.  It is not, so it did not need to be changed.
3388
3389         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3390
3391 2007-10-25  Mark Rowe  <mrowe@apple.com>
3392
3393         Reviewed by Maciej.
3394
3395         Fix builds with code coverage enabled.
3396
3397         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3398
3399 2007-10-25  Darin Adler  <darin@apple.com>
3400
3401         Reviewed by Mark Rowe.
3402
3403         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3404         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3405
3406 2007-10-25  Stephanie  <slewis@apple.com>
3407
3408         build Fix
3409
3410         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3411
3412 2007-10-25  Stephanie  <slewis@apple.com>
3413
3414         Reviewed by Mark Rowe, Adam Roben.
3415
3416         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3417
3418         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3419
3420 2007-10-25  Alice Liu  <alice.liu@apple.com>
3421
3422         Reviewed by Adam.
3423
3424         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3425
3426         Moving destructor into platform-specific files
3427         * DumpRenderTree/LayoutTestController.cpp:
3428         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3429         (LayoutTestController::~LayoutTestController):
3430         * DumpRenderTree/qt/jsobjects.cpp:
3431         (LayoutTestController::~LayoutTestController):
3432
3433         LayoutTestController wasn't being destroyed
3434         * DumpRenderTree/win/DumpRenderTree.cpp:
3435         (runTest):
3436
3437         Added declspec
3438         * DumpRenderTree/win/EditingDelegate.h:
3439
3440         Reset certain values on the webview (or related delegate) that might 
3441         have changed while running a test
3442         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3443         (LayoutTestController::~LayoutTestController):
3444
3445 2007-10-25  Adam Roben  <aroben@apple.com>
3446
3447         Make sunspider-compare-results work with relative paths
3448
3449         Reviewed by Sam.
3450
3451         * Scripts/sunspider-compare-results: Convert arguments to absolute
3452         paths before we chdir.
3453
3454 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3455
3456         Reviewed by Sam.
3457
3458         - Implemented server calls now the WebScriptDebugServer exists.
3459         - Also removed no longer needed call to initialize CG.
3460
3461         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3462         automatically now.
3463         (_tWinMain):
3464         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3465         (ServerConnection::ServerConnection):
3466         (ServerConnection::~ServerConnection):
3467         (ServerConnection::pause):
3468         (ServerConnection::resume):
3469         (ServerConnection::stepInto):
3470         (ServerConnection::applicationTerminating):
3471         (ServerConnection::serverConnectionDidDie):
3472         * Drosera/win/ServerConnection.h: Now uses the COM class.
3473
3474 2007-10-24  George Staikos  <staikos@kde.org>
3475
3476         Unbreak Qt build.
3477
3478         * Scripts/build-webkit:
3479
3480 2007-10-24  Adam Roben  <aroben@apple.com>
3481
3482         Remove now-unnecessary call to InitializeCoreGraphics
3483
3484         WebKit takes care of this now.
3485
3486         Reviewed by Ada.
3487
3488         * DumpRenderTree/win/DumpRenderTree.cpp:
3489         (initialize):
3490
3491 2007-10-24  Adam Roben  <aroben@apple.com>
3492
3493         Use WebTextRenderer in DRT
3494
3495         Reviewed by Ada.
3496
3497         * DumpRenderTree/win/DumpRenderTree.cpp:
3498         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3499
3500 2007-10-24  Sven Herzberg  <sven@imendio.com>
3501
3502         Reviewed by Mark Rowe.
3503
3504         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3505         Bug 15614: [GTK] qmake based backends don't build on OS X
3506
3507         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3508         GTK backend on a Mac
3509         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3510         isDarwin() to make it reusable in other places (like the workaround-
3511         for-prebuilt-qmake in build-webkit)
3512
3513 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3514
3515         Refurbish update-webkit script.
3516
3517         Reviewed by Adam.
3518
3519         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3520         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3521         multi-argument version of system() for flexibility and security.  Check for existence
3522         of Internal directory using -d test instead of -x.
3523
3524 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3525
3526         Minor clean-up of prepare-ChangeLog script.
3527
3528         Reviewed by Adam.
3529
3530         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3531         of a string.  Use multi-argument versions of open() and system() for flexibility and
3532         security.
3533
3534 2007-10-24  Alice Liu  <alice.liu@apple.com>
3535
3536         Reviewed by Oliver.
3537
3538         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3539
3540         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3541         replay the saved events when we're still processing the mousedown that starts the drag
3542         * DumpRenderTree/win/EventSender.cpp:
3543         (doMouseMove):
3544         * DumpRenderTree/win/UIDelegate.cpp:
3545         (UIDelegate::doDragDrop):
3546
3547 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3548
3549         Reviewed by Sam, Steve and Darin.
3550
3551         - Stubbed out the WebScriptDebugListener functionality in the Server
3552         Connection class to prepare it for receiving those callbacks.
3553         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3554         and the ServerConnection to not need to be initialized with a server
3555         name, since that is not the way we connect to the WebKit server. 
3556
3557         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3558         no exception.  Now it only loggs when there is an exception
3559         (DebuggerDocument::willExecuteStatement):
3560         (DebuggerDocument::didEnterCallFrame):
3561         (DebuggerDocument::willLeaveCallFrame):
3562         (DebuggerDocument::windowScriptObjectAvailable):
3563         (DebuggerDocument::callFunctionOnObject):
3564         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3565         to be instantiated with a server's name.
3566         (DebuggerClient::DebuggerClient):
3567         (DebuggerClient::didFinishLoadForFrame):
3568         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3569         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3570         a server name.
3571         (Drosera::init):
3572         (Drosera::initServer):
3573         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3574         instantiated with a server's name.
3575         * Drosera/win/ServerConnection.cpp: 
3576         (ServerConnection::ServerConnection): No longer needs a server name
3577         (ServerConnection::~ServerConnection): Only release the global context
3578         if there is one.
3579         (ServerConnection::serverConnectionDidDie): Stub for
3580         IWebScriptDebugListener
3581         (ServerConnection::QueryInterface): ditto
3582         (ServerConnection::AddRef): ditto
3583         (ServerConnection::Release): ditto
3584         (ServerConnection::didLoadMainResourceForDataSource): ditto
3585         (ServerConnection::didParseSource): ditto
3586         (ServerConnection::failedToParseSource): ditto
3587         (ServerConnection::didEnterCallFrame): ditto
3588         (ServerConnection::willExecuteStatement): ditto
3589         (ServerConnection::willLeaveCallFrame): ditto
3590         (ServerConnection::exceptionWasRaised): ditto
3591         * Drosera/win/ServerConnection.h: Stubbed out the
3592         IWebScriptDebugListener functions, and this class no longer needs to be
3593         instantiated with a server name.
3594
3595 2007-10-24  Lars Knoll  <lars@trolltech.com>
3596
3597         Reviewed by Simon.
3598
3599         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3600
3601         * DumpRenderTree/qt/jsobjects.h:
3602
3603 2007-10-24  Lars Knoll  <lars@trolltech.com>
3604
3605         Reviewed by Simon.
3606
3607         add another command.
3608
3609         * DumpRenderTree/qt/jsobjects.cpp:
3610         (TextInputController::doCommand):
3611
3612 2007-10-24  Lars Knoll  <lars@trolltech.com>
3613
3614         Reviewed by Simon.
3615
3616         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3617
3618         * DumpRenderTree/qt/jsobjects.cpp:
3619         (EventSender::keyDown):
3620         * DumpRenderTree/qt/jsobjects.h:
3621
3622 2007-10-24  Lars Knoll  <lars@trolltech.com>
3623
3624         Reviewed by Simon.
3625
3626         implement eventSender.keyDown().
3627
3628         * DumpRenderTree/qt/jsobjects.cpp:
3629         (EventSender::keyDown):
3630
3631 2007-10-24  Lars Knoll  <lars@trolltech.com>
3632
3633         Reviewed by Simon.
3634
3635         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3636
3637         * DumpRenderTree/qt/DumpRenderTree.cpp:
3638         (WebCore::DumpRenderTree::DumpRenderTree):
3639         (WebCore::DumpRenderTree::initJSObjects):
3640         * DumpRenderTree/qt/jsobjects.cpp:
3641         (TextInputController::doCommand):
3642
3643 2007-10-24  Lars Knoll  <lars@trolltech.com>
3644
3645         Reviewed by Simon.
3646
3647         first bit of implementation for the textinputcontroller.
3648
3649         * DumpRenderTree/qt/DumpRenderTree.cpp:
3650         (WebCore::DumpRenderTree::DumpRenderTree):
3651         * DumpRenderTree/qt/DumpRenderTree.h:
3652         * DumpRenderTree/qt/jsobjects.cpp:
3653         (TextInputController::TextInputController):
3654         (TextInputController::doCommand):
3655         * DumpRenderTree/qt/jsobjects.h:
3656
3657 2007-10-24  Lars Knoll  <lars@trolltech.com>
3658
3659         Reviewed by Simon.
3660
3661         make the man webpage believe it has focus, so the editing tests work correctly.
3662
3663         * DumpRenderTree/qt/DumpRenderTree.cpp:
3664         (WebCore::DumpRenderTree::DumpRenderTree):
3665
3666 2007-10-24  Lars Knoll  <lars@trolltech.com>
3667
3668         Reviewed by Simon.
3669
3670         implement layoutTestController.dumpEditingCallbacks() correctly.
3671
3672         * DumpRenderTree/qt/DumpRenderTree.cpp:
3673         (WebCore::DumpRenderTree::DumpRenderTree):
3674         * DumpRenderTree/qt/jsobjects.cpp:
3675         (LayoutTestController::reset):
3676         (LayoutTestController::dumpEditingCallbacks):
3677
3678 2007-10-24  Lars Knoll  <lars@trolltech.com>
3679
3680         Reviewed by Simon.
3681
3682         Implement support for testing editing.
3683
3684         * DumpRenderTree/qt/DumpRenderTree.cpp:
3685         (WebCore::DumpRenderTree::DumpRenderTree):
3686
3687 2007-10-23  Sam Weinig  <sam@webkit.org>
3688
3689         Check for null BSTR that can be passed to the UIDelegate methods
3690         from javascript null and undefined.  Fixes a failing test case on
3691         Windows (fast/dom/Window/alert-undefined.html)
3692
3693         Reviewed by Eric Seidel.
3694
3695         * DumpRenderTree/win/UIDelegate.cpp:
3696         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3697         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3698         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3699         (UIDelegate::webViewAddMessageToConsole):
3700
3701 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3702
3703         Reviewed by Darin.
3704         
3705         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3706
3707         * Scripts/build-testkjs:
3708
3709 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3710
3711         Reviewed by Darin.
3712
3713         - add wrapper that finds the right copy of testkjs
3714         
3715         * Scripts/sunspider-compare-results: Added.
3716
3717 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3718
3719         Reviewed by Sam.
3720
3721         - After talking with Steve I now see that the WebKit server must be
3722         running for DCOM to create the distributed objects, which makes sense
3723         and currently WebKit only allows one instance to be running at a time
3724         which avoids accidentally connecting to the wrong server
3725         - In light of this I have removed the code for the attach box and
3726         NotificationServer and known server names, since they are all extranious
3727         now.
3728
3729         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3730         names.
3731         (_tWinMain): Uses init instead of initUI.
3732         (droseraWndProc): No longer creats an attach dialog box.
3733         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3734         it's not manditory to call init before doing COM stuff.
3735         (Drosera::init): calls initUI and will call attach when the
3736         functionality exists. 
3737         (Drosera::initUI): Has changed very little.
3738         (Drosera::attach): Changed the signature to reflect that we no longer
3739         need the dictionary of known server names.
3740         * Drosera/win/Drosera.h: Removed notification classes and known server
3741         names.  Also renamed and moved some functions.
3742         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3743         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3744         headers to the resources folder. 
3745         * Drosera/win/resource.h: Removed the Attach box.
3746
3747 2007-10-22  Adam Roben  <aroben@apple.com>
3748
3749         Windows build fix
3750
3751         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3752
3753 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3754
3755         - Removed a leak that was fixed.
3756
3757         * Scripts/run-webkit-tests:
3758
3759 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3760
3761         Reviewed by Darin.
3762
3763         - Changed the Client so that the DebuggerDocument now own the
3764         ServerConnection.  This simplifies ownership and cleanup. 
3765
3766         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3767         ServerConnection.
3768         (DebuggerClient::initWithServerName):
3769         (DebuggerClient::didFinishLoadForFrame):
3770         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3771         ServerConnection.
3772         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3773         until after we have a server which we are attached to.
3774         (Drosera::initUI):
3775         (Drosera::attach):
3776         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3777         out previously.
3778
3779 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3780
3781         Reviewed by Nikolas.
3782
3783         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3784
3785         * Scripts/run-javascriptcore-tests:
3786
3787 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3788
3789         Reviewed by Nikolas.
3790
3791         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3792
3793         * Scripts/build-drosera:
3794         * Scripts/build-dumprendertree:
3795         * Scripts/build-testkjs:
3796         * Scripts/build-webkit:
3797         * Scripts/run-javascriptcore-tests:
3798         * Scripts/run-sunspider:
3799         * Scripts/run-webkit-tests:
3800         * Scripts/webkitdirs.pm:
3801
3802 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3803
3804         Reviewed by Mark Rowe.
3805         
3806         Fix for local database support after r26879
3807         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3808
3809         * Scripts/build-webkit:
3810
3811 2007-10-22  Holger Freyther  <zecke@selfish.org>
3812
3813         Reviewed by Simon Hausmann <hausmann@kde.org>.
3814
3815         - Do not build testkjs as an application bundle. This is
3816         needed for run-javascriptcore-tests on OSX.
3817         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3818         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3819         as we do not have -rpath on OSX.
3820
3821         * DumpRenderTree/qt/DumpRenderTree.pro:
3822         * Scripts/run-webkit-tests:
3823
3824 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3825
3826         Reviewed by aroben.
3827
3828         Fix support for Signed-off-by detection in prepare-ChangeLog
3829         --git-commit. The Signed-off-by tag does not appear in the header
3830         but usually at the end.
3831
3832         * Scripts/prepare-ChangeLog:
3833
3834 2007-10-21  Mark Rowe  <mrowe@apple.com>
3835
3836         Reviewed by Eric.
3837
3838         Fix run-javascriptcore-tests for Gtk.
3839
3840         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3841
3842 2007-10-20  Eric Seidel  <eric@webkit.org>
3843
3844         Reviewed by aroben.
3845
3846         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3847
3848 2007-10-20  Eric Seidel  <eric@webkit.org>
3849
3850         Reviewed by darin.
3851         
3852         Add improved argument handling to run-sunspider, including
3853         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3854         Also re-factor code into subroutines
3855
3856         * Scripts/build-dumprendertree: removed bogus comments
3857         * Scripts/build-testkjs: Added.
3858         * Scripts/run-javascriptcore-tests: use build-testkjs
3859         * Scripts/run-sunspider: improved argument handling, abstraction
3860         * Scripts/run-webkit-tests: improved abstraction
3861
3862 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3863
3864         Not reviewed, Windows build fix.
3865
3866         * DumpRenderTree/win/EventSender.cpp:
3867         (keyDownCallback):
3868
3869 2007-10-20  Darin Adler  <darin@apple.com>
3870
3871         Reviewed by Tim Hatcher.
3872
3873         - http://bugs.webkit.org/show_bug.cgi?id=15544
3874           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3875           not rely on Apple-specific key codes
3876
3877         * DumpRenderTree/mac/EventSendingController.mm:
3878         (-[EventSendingController keyDown:withModifiers:]):
3879         Added named key "rightArrow". Later we could have a whole table of these.
3880         Also tweaked modifiers code a little.
3881
3882         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3883
3884 2007-10-19  Darin Adler  <darin@apple.com>
3885
3886         Reviewed by Eric.
3887
3888         - http://bugs.webkit.org/show_bug.cgi?id=15566
3889           possible fix for leak seen in DumpRenderTree
3890
3891         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3892         Delete the item if it's not put on the queue, since the caller has
3893         no way of knowing that. Would be better to have the parameter type
3894         be auto_ptr to express the fact that we take ownership.
3895
3896         - unrelated change
3897
3898         * Drosera/mac/main.m: Add missing include.
3899
3900 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3901
3902         Reviewed by Adam.
3903
3904         - This change should be identical but for some reason was not working
3905         on my machine.
3906
3907         * Scripts/prepare-ChangeLog:
3908
3909 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3910
3911         Reviewed by Oliver and Tim.
3912
3913         - Made use of RetainPtr to avoid retain and release issues and moved the
3914         log function to DebuggerDocumentPlatform, which seems to be a more
3915         logical place for it to live.
3916         - Also moved knownServers from the ServerConnection to
3917         DebuggerApplication to match the Windows code and because it makes sense
3918         that a connection knows its own server but not all of them.
3919
3920         * Drosera/mac/DebuggerClient.h: Moved the log function to
3921           DebuggerDocumentPlatform.
3922         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3923           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3924           call for the server name up from the ServerConnection class.
3925         (-[DebuggerClient dealloc]):
3926         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3927           for the server name up from the ServerConnection.
3928         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3929         (DebuggerDocument::platformPause):
3930         (DebuggerDocument::platformResume):
3931         (DebuggerDocument::platformStepInto):
3932         (DebuggerDocument::platformEvaluateScript):
3933         (DebuggerDocument::getPlatformCurrentFunctionStack):
3934         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3935         (DebuggerDocument::platformValueForScopeVariableNamed):
3936         (DebuggerDocument::platformLog): Log directly from here. No need to call
3937           DebuggerClient.
3938         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3939           way I see it, a ServerConnection should only know about its connection
3940           and the group of all possible servers should be kept by the
3941           application.
3942         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3943           currentServerName, it makes sense that the connection should know that
3944           name.
3945         (-[ServerConnection currentServerName]):
3946
3947 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3948
3949         Reviewed by Adam.
3950
3951         - Integrated changes from mac drosera.  Recently I've encapsulated
3952         out the server connection object from the rest of Drosera because
3953         it is very platform dependent right now and RPC is not implemented on
3954         windows.  This functionality, of communicating with the WebKit server
3955         is the next area I will be focusing on in Windows.
3956
3957         - Other changes and cleanup were made to organize the code and add notes
3958         on which parts still need work.  Also some mac code is added and
3959         commented out, to act as pseudocode for the logic of those parts.
3960
3961         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3962           pointer.
3963         * Drosera/config.h: Added whitespace.
3964         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3965           these files got moved into Drosera.h/cpp
3966         * Drosera/win/DebuggerApplication.h: Removed.
3967         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3968           happened here to better match the logic flow of the same code on the 
3969           mac side and to use the new ServerConnection class.
3970         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3971         (DebuggerClient::initWithServerName): Initializer that will set up the
3972           class to use a ServerConnection object.  This was necessary so I could
3973           create a DebuggerClient without having to initilaize it at
3974           construction.
3975         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3976           will be the UIDelegate and FrameLoadDelegate.
3977         (DebuggerClient::AddRef): For IUnknown.
3978         (DebuggerClient::Release): For IUnknown.
3979         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3980           this still needs to set the global context of the server, but
3981           IWebFrame does not have an accessor for the global context yet. 
3982         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3983           this is a pass through for the same function in the document.
3984         (DebuggerClient::didReceiveTitle): Unimplemented part of
3985           FrameLoadDelegate this would change the title of the window.
3986         (DebuggerClient::createWebViewWithRequest): Part of the
3987           FrameLoadDelegate.  This is about new windows via Window.open() and
3988           how their delegates are set.
3989         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3990           UIDelegate.  Just a debug function for printing messages.
3991         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3992           because the Client should be the UIDelegate and FrameLoadDelegate
3993           to match the delegates on mac.
3994         (DebuggerClient::webViewLoaded): Added accessor method.
3995         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3996           forgotten to add this file before.  This is where the platform
3997           dependent versions of the Documents functions live. Most of these are
3998           unimplemented because some piece of functionality does not exist on
3999           Windows yet.
4000         (DebuggerDocument::platformPause):
4001         (DebuggerDocument::platformResume):
4002         (DebuggerDocument::platformStepInto):
4003         (DebuggerDocument::platformEvaluateScript):
4004         (DebuggerDocument::getPlatformCurrentFunctionStack):
4005         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4006         (DebuggerDocument::platformValueForScopeVariableNamed):
4007         (DebuggerDocument::platformLog):
4008         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
4009           responsibilities becaue they belong in the Client. Also I laid the
4010           groundwork for attaching Drosera to a WebKit process
4011         (attachWndProc): Now if a server is selected the Client becomes it's
4012           delegate.
4013         (Drosera::Drosera): Added the construction of the Client and dictionary
4014           of server names. 
4015         (Drosera::initUI): This is no longer the delegates, the Client is.
4016         (Drosera::webViewLoaded): Now asks the Client instead of holding local
4017           state. 
4018         (Drosera::applicationDidFinishLaunching): Placeholder for needed
4019           notification registration when it's possible to implement.
4020         (Drosera::serverLoaded): Ditto
4021         (Drosera::serverUnloaded): Ditto
4022         (Drosera::attach): Attach Drosera to the WebKit server.
4023         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
4024         (Drosera::getInst): 
4025         (Drosera::setInst):
4026         (Drosera::knownServers):
4027         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
4028           and added the ServerConnection.
4029         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
4030         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
4031           Most of the functions are completely unimlemented because they cannot
4032           connect with the WebKit server, because one does not exist on Windows
4033           yet.
4034         (ServerConnection::initWithServerName): 
4035         (ServerConnection::~ServerConnection):
4036         (ServerConnection::setGlobalContext):
4037         (ServerConnection::pause):
4038         (ServerConnection::resume):
4039         (ServerConnection::stepInto):
4040         (ServerConnection::switchToServerNamed):
4041         (ServerConnection::applicationTerminating):
4042         (ServerConnection::serverConnectionDidDie):
4043         (ServerConnection::currentFrame):
4044         * Drosera/win/ServerConnection.h: Added. Ditto.
4045         (ServerConnection::ServerConnection):
4046
4047 2007-10-19  Alice Liu  <alice.liu@apple.com>
4048
4049         Reviewed by Darin.
4050
4051         Fix for these broken layout tests on Windows:
4052         
4053         fast/forms/focus-selection-input.html
4054         fast/forms/focus-selection-textarea.html
4055         fast/forms/select-accesskey.html
4056         
4057         * DumpRenderTree/win/EventSender.cpp:
4058         (keyDownCallback):
4059         correct the VK code for alt key.
4060         
4061 2007-10-19  Eric Seidel  <eric@webkit.org>
4062
4063         Reviewed by Mark Rowe.
4064         
4065         Make the GtkLauncher code slightly more readable.
4066
4067         * GtkLauncher/main.cpp:
4068         (setupMainMenu): Added.
4069         (setupMainWindowUI): Added.
4070         (main):
4071
4072 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
4073
4074         Rubber stamped by Adam.
4075         
4076         - don't delay-load WebKit in DumpRenderTree.
4077
4078         * DumpRenderTree/win/DumpRenderTree.vcproj:
4079
4080 2007-10-18  Dan Bernstein  <mitz@apple.com>
4081
4082         Reviewed by Adam Roben.
4083
4084         - fix <rdar://problem/5313523>
4085         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
4086
4087         * DumpRenderTree/mac/DumpRenderTree.mm:
4088         (dump): Changed to use _responseMIMEType.
4089
4090 2007-10-17  Adam Roben  <aroben@apple.com>
4091
4092         Make it possible to have Windows-specific tests and results
4093
4094         When searching for tests to run and the Skipped file, we will only
4095         look in platform/win and the cross-platform directory. When looking
4096         for expected results, we will look in platform/win, then
4097         platform/mac-leopard, then platform/mac, then finally the
4098         cross-platform directory.
4099
4100         Reviewed by Sam.
4101
4102         * Scripts/run-webkit-tests:
4103         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
4104         searching in the cross-platform directory.
4105         (sub buildPlatformHierarchy): Removed some unneeded calls to
4106         dirname/basename.
4107
4108 2007-10-17  Adam Roben  <aroben@apple.com>
4109
4110         Add back the call to register WebKit that we had before WebKitInitializer existed
4111
4112         This is needed to ensure that the right WebKit is used when
4113         instantiating COM objects.
4114
4115         Reviewed by Oliver.
4116
4117         * DumpRenderTree/win/debug_internal.vsprops: Define
4118         DEBUG_WEBKIT_HAS_SUFFIX.
4119         * DumpRenderTree/win/DumpRenderTree.cpp:
4120         (initialize):
4121
4122 2007-10-17  Adam Roben  <aroben@apple.com>
4123
4124         Import File::Basename in webkitdirs since we use it
4125
4126         * Scripts/webkitdirs.pm:
4127
4128 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
4129
4130         - Updated the tiger leaks list to make the internal bots green.
4131
4132         * Scripts/run-webkit-tests:
4133
4134 2007-10-17  Adam Roben  <aroben@apple.com>
4135
4136         Build fix for VC++ Express
4137
4138         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
4139         and ole32.lib.
4140
4141 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
4142
4143         Reviewed by Sam.
4144
4145         - Minor mac improvements based on observations I made while implementing the
4146         Windows code.
4147
4148         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
4149         then hand it to the Client who will retain it, it should just be the client who
4150         creates and owns the server.
4151         (-[DebuggerApplication attach:]):
4152         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
4153         * Drosera/mac/DebuggerClient.mm: Creates the server.
4154         (-[DebuggerClient initWithServerName:]):
4155         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
4156         can instead forward declare what it needs.
4157
4158 2007-10-16  Darin Adler  <darin@apple.com>
4159
4160         Reviewed by Geoff Garen.
4161
4162         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
4163         want to turn failing tests into platform-specific test results. Also did a
4164         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
4165         would take the type of results into account only some of the time.
4166
4167 2007-10-16  Adam Roben  <aroben@apple.com>
4168
4169         Add a new nightly launcher script for Windows
4170
4171         This new script is for versions of Safari that don't delay-load
4172         WebKit. I had to make FindSafari be able to print out the nightly
4173         launcher script on stdout because Windows shell scripts can't capture
4174         the output from a command into an environment variable.
4175
4176         Reviewed by Steve.
4177
4178         * FindSafari/FindSafari.cpp:
4179         (_tmain): Added /printSafariLauncher option.
4180         * Scripts/run-webkit-nightly.cmd: Added.
4181
4182 2007-10-16  Adam Roben  <aroben@apple.com>
4183
4184         Replace WebKitInitializer with FindSafari
4185
4186         We now rely on setting the PATH environment variable to tell Windows
4187         where to find WebKit and its dependencies (similar to
4188         DYLD_FRAMEWORK_PATH on Mac).
4189
4190         This change also make DumpRenderTree no longer delay-load WebKit.
4191
4192         Reviewed by Sam.
4193
4194         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
4195         FindSafari.
4196         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
4197         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
4198         WebKitInitializer, don't delay-load WebKit.
4199         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
4200         * Scripts/run-webkit-tests: Ditto.
4201         * Scripts/webkitdirs.pm:
4202         (sub setPathForRunningWebKitApp): Added.
4203         * WebKitInitializer/WebKitInitializer.cpp: Removed.
4204         * WebKitInitializer/WebKitInitializer.h: Removed.
4205         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
4206         * WebKitInitializer/debug.vsprops: Removed.
4207         * WebKitInitializer/debug_internal.vsprops: Removed.
4208         * WebKitInitializer/release.vsprops: Removed.
4209
4210 2007-10-16  Adam Roben  <aroben@apple.com>
4211
4212         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
4213
4214         http://bugs.webkit.org/show_bug.cgi?id=15532
4215
4216         FindSafari simply prints the location of an installed Safari.exe on
4217         stdout.
4218
4219         Reviewed by Darin.
4220
4221         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
4222         (getStringValue):
4223         (getWebViewCLSID):
4224         (getInstalledWebKitDirectory):
4225         (_tmain):
4226         * FindSafari/FindSafari.vcproj: Added.
4227         * Scripts/webkitdirs.pm:
4228         (sub installedSafariPath): Added. Calls FindSafari on Windows.
4229
4230 2007-10-16  Adam Roben  <aroben@apple.com>
4231
4232         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
4233
4234         Reviewed by Kevin McCullough.
4235
4236         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
4237         when referring to WebKit.dll.
4238         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
4239         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
4240         * DumpRenderTree/win/release.vsprops: Ditto.
4241         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
4242         never have a _debug suffix on WebKit.dll.
4243         * WebKitInitializer/WebKitInitializer.cpp:
4244         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
4245         specified.
4246         * WebKitInitializer/debug_internal.vsprops: Added
4247         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
4248
4249 2007-10-16  Darin Adler  <darin@apple.com>
4250
4251         Reviewed by Adele.
4252
4253         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
4254         Remove now-unneeded control/alt key hack; the tests have been updated.
4255
4256 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
4257
4258         - Updated leaks list because our internal bot upgraded it's version of leopard and 
4259         one of the leaks was fixed between that revision and the bot's previous version of
4260         leopard.
4261
4262         * Scripts/run-webkit-tests:
4263
4264 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
4265
4266         Reviewed by Tim.
4267
4268         - I encapsulated out the server connecton functionality because it is a specific part
4269         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
4270         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
4271         Windows.  So the majority of this patch is moving preexisting functionality.
4272
4273         - Also I removed the prefix header and changed to use config.h because it is more
4274         standard on how we use config.h in windows and it didn't make much sense to keep
4275         the prefix header and the config.h
4276
4277         * Drosera/DebuggerDocument.cpp:
4278         (DebuggerDocument::DebuggerDocument):
4279         * Drosera/DebuggerDocument.h:
4280         * Drosera/config.h:
4281         * Drosera/mac/DebuggerApplication.mm:
4282         (-[DebuggerApplication attach:]):
4283         * Drosera/mac/DebuggerClient.h:
4284         * Drosera/mac/DebuggerClient.mm:
4285         (-[DebuggerClient initWithServerConnection:]):
4286         (-[DebuggerClient dealloc]):
4287         (-[DebuggerClient windowDidLoad]):
4288         (-[DebuggerClient windowWillClose:]):
4289         (-[DebuggerClient webView:didFinishLoadForFrame:]):
4290         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
4291         * Drosera/mac/DebuggerDocumentPlatform.mm:
4292         (DebuggerDocument::platformPause):
4293         (DebuggerDocument::platformResume):
4294         (DebuggerDocument::platformStepInto):
4295         (DebuggerDocument::platformEvaluateScript):
4296         (DebuggerDocument::getPlatformCurrentFunctionStack):
4297         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4298         (DebuggerDocument::platformValueForScopeVariableNamed):