WebKitTools/ChangeLog

   1 2007-10-28  Eric Seidel  <eric@webkit.org>
   2
   3         Reviewed by Maciej and Geoff, in unison.
   4
   5         * Scripts/run-webkit-tests: remove broken --svg option
   6
   7 2007-10-28  Darin Adler  <darin@apple.com>
   8
   9         Reviewed by Adam.
  10
  11         * Scripts/run-sunspider: Default to "Release" configuration rather than
  12         defaulting to the last configuration used as other scripts do. This can
  13         still be overriden on the command line with "--debug" if there's some
  14         reason to do so. Also fix a typo.
  15
  16         * Scripts/sunspider-compare-results: Fix a typo.
  17
  18 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
  19
  20         Reviewed by Adam.
  21
  22         - Implemented the WebScriptDebugListener functions now that the
  23         WebScriptDebugServer exists
  24
  25         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
  26         functions.
  27         (ServerConnection::currentFrame):
  28         (ServerConnection::didLoadMainResourceForDataSource):
  29         (ServerConnection::didParseSource):
  30         (ServerConnection::failedToParseSource):
  31         (ServerConnection::didEnterCallFrame):
  32         (ServerConnection::willExecuteStatement):
  33         (ServerConnection::willLeaveCallFrame):
  34         (ServerConnection::exceptionWasRaised):
  35         * Drosera/win/ServerConnection.h: Removed unused arguments from the
  36         members arguments list.
  37
  38 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
  39
  40         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
  41         <http://bugs.webkit.org/show_bug.cgi?id=15600>
  42
  43         Reviewed by Darin.
  44
  45         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
  46         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
  47         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
  48         file.  Note that it may also be used as a stand-alone script.
  49
  50         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
  51         * Scripts/resolve-ChangeLogs: Added.
  52         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
  53
  54 2007-10-26  Mark Rowe  <mrowe@apple.com>
  55
  56         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
  57         to the Qt port on the assumption that it was an implementation of the cross-platform
  58         LayoutTestController class.  It is not, so it did not need to be changed.
  59
  60         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
  61
  62 2007-10-25  Mark Rowe  <mrowe@apple.com>
  63
  64         Reviewed by Maciej.
  65
  66         Fix builds with code coverage enabled.
  67
  68         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
  69
  70 2007-10-25  Darin Adler  <darin@apple.com>
  71
  72         Reviewed by Mark Rowe.
  73
  74         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
  75         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
  76
  77 2007-10-25  Stephanie  <slewis@apple.com>
  78
  79         build Fix
  80
  81         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  82
  83 2007-10-25  Stephanie  <slewis@apple.com>
  84
  85         Reviewed by Mark Rowe, Adam Roben.
  86
  87         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
  88
  89         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  90
  91 2007-10-25  Alice Liu  <alice.liu@apple.com>
  92
  93         Reviewed by Adam.
  94
  95         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
  96
  97         Moving destructor into platform-specific files
  98         * DumpRenderTree/LayoutTestController.cpp:
  99         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 100         (LayoutTestController::~LayoutTestController):
 101         * DumpRenderTree/qt/jsobjects.cpp:
 102         (LayoutTestController::~LayoutTestController):
 103
 104         LayoutTestController wasn't being destroyed
 105         * DumpRenderTree/win/DumpRenderTree.cpp:
 106         (runTest):
 107
 108         Added declspec
 109         * DumpRenderTree/win/EditingDelegate.h:
 110
 111         Reset certain values on the webview (or related delegate) that might
 112         have changed while running a test
 113         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 114         (LayoutTestController::~LayoutTestController):
 115
 116 2007-10-25  Adam Roben  <aroben@apple.com>
 117
 118         Make sunspider-compare-results work with relative paths
 119
 120         Reviewed by Sam.
 121
 122         * Scripts/sunspider-compare-results: Convert arguments to absolute
 123         paths before we chdir.
 124
 125 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
 126
 127         Reviewed by Sam.
 128
 129         - Implemented server calls now the WebScriptDebugServer exists.
 130         - Also removed no longer needed call to initialize CG.
 131
 132         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
 133         automatically now.
 134         (_tWinMain):
 135         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
 136         (ServerConnection::ServerConnection):
 137         (ServerConnection::~ServerConnection):
 138         (ServerConnection::pause):
 139         (ServerConnection::resume):
 140         (ServerConnection::stepInto):
 141         (ServerConnection::applicationTerminating):
 142         (ServerConnection::serverConnectionDidDie):
 143         * Drosera/win/ServerConnection.h: Now uses the COM class.
 144
 145 2007-10-24  George Staikos  <staikos@kde.org>
 146
 147         Unbreak Qt build.
 148
 149         * Scripts/build-webkit:
 150
 151 2007-10-24  Adam Roben  <aroben@apple.com>
 152
 153         Remove now-unnecessary call to InitializeCoreGraphics
 154
 155         WebKit takes care of this now.
 156
 157         Reviewed by Ada.
 158
 159         * DumpRenderTree/win/DumpRenderTree.cpp:
 160         (initialize):
 161
 162 2007-10-24  Adam Roben  <aroben@apple.com>
 163
 164         Use WebTextRenderer in DRT
 165
 166         Reviewed by Ada.
 167
 168         * DumpRenderTree/win/DumpRenderTree.cpp:
 169         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
 170
 171 2007-10-24  Sven Herzberg  <sven@imendio.com>
 172
 173         Reviewed by Mark Rowe.
 174
 175         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
 176         Bug 15614: [GTK] qmake based backends don't build on OS X
 177
 178         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
 179         GTK backend on a Mac
 180         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
 181         isDarwin() to make it reusable in other places (like the workaround-
 182         for-prebuilt-qmake in build-webkit)
 183
 184 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 185
 186         Refurbish update-webkit script.
 187
 188         Reviewed by Adam.
 189
 190         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
 191         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
 192         multi-argument version of system() for flexibility and security.  Check for existence
 193         of Internal directory using -d test instead of -x.
 194
 195 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 196
 197         Minor clean-up of prepare-ChangeLog script.
 198
 199         Reviewed by Adam.
 200
 201         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
 202         of a string.  Use multi-argument versions of open() and system() for flexibility and
 203         security.
 204
 205 2007-10-24  Alice Liu  <alice.liu@apple.com>
 206
 207         Reviewed by Oliver.
 208
 209         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
 210
 211         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
 212         replay the saved events when we're still processing the mousedown that starts the drag
 213         * DumpRenderTree/win/EventSender.cpp:
 214         (doMouseMove):
 215         * DumpRenderTree/win/UIDelegate.cpp:
 216         (UIDelegate::doDragDrop):
 217
 218 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 219
 220         Reviewed by Sam, Steve and Darin.
 221
 222         - Stubbed out the WebScriptDebugListener functionality in the Server
 223         Connection class to prepare it for receiving those callbacks.
 224         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
 225         and the ServerConnection to not need to be initialized with a server
 226         name, since that is not the way we connect to the WebKit server.
 227
 228         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
 229         no exception.  Now it only loggs when there is an exception
 230         (DebuggerDocument::willExecuteStatement):
 231         (DebuggerDocument::didEnterCallFrame):
 232         (DebuggerDocument::willLeaveCallFrame):
 233         (DebuggerDocument::windowScriptObjectAvailable):
 234         (DebuggerDocument::callFunctionOnObject):
 235         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
 236         to be instantiated with a server's name.
 237         (DebuggerClient::DebuggerClient):
 238         (DebuggerClient::didFinishLoadForFrame):
 239         * Drosera/win/DebuggerClient.h: Removed unsued variable.
 240         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
 241         a server name.
 242         (Drosera::init):
 243         (Drosera::initServer):
 244         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
 245         instantiated with a server's name.
 246         * Drosera/win/ServerConnection.cpp:
 247         (ServerConnection::ServerConnection): No longer needs a server name
 248         (ServerConnection::~ServerConnection): Only release the global context
 249         if there is one.
 250         (ServerConnection::serverConnectionDidDie): Stub for
 251         IWebScriptDebugListener
 252         (ServerConnection::QueryInterface): ditto
 253         (ServerConnection::AddRef): ditto
 254         (ServerConnection::Release): ditto
 255         (ServerConnection::didLoadMainResourceForDataSource): ditto
 256         (ServerConnection::didParseSource): ditto
 257         (ServerConnection::failedToParseSource): ditto
 258         (ServerConnection::didEnterCallFrame): ditto
 259         (ServerConnection::willExecuteStatement): ditto
 260         (ServerConnection::willLeaveCallFrame): ditto
 261         (ServerConnection::exceptionWasRaised): ditto
 262         * Drosera/win/ServerConnection.h: Stubbed out the
 263         IWebScriptDebugListener functions, and this class no longer needs to be
 264         instantiated with a server name.
 265
 266 2007-10-24  Lars Knoll  <lars@trolltech.com>
 267
 268         Reviewed by Simon.
 269
 270         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
 271
 272         * DumpRenderTree/qt/jsobjects.h:
 273
 274 2007-10-24  Lars Knoll  <lars@trolltech.com>
 275
 276         Reviewed by Simon.
 277
 278         add another command.
 279
 280         * DumpRenderTree/qt/jsobjects.cpp:
 281         (TextInputController::doCommand):
 282
 283 2007-10-24  Lars Knoll  <lars@trolltech.com>
 284
 285         Reviewed by Simon.
 286
 287         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
 288
 289         * DumpRenderTree/qt/jsobjects.cpp:
 290         (EventSender::keyDown):
 291         * DumpRenderTree/qt/jsobjects.h:
 292
 293 2007-10-24  Lars Knoll  <lars@trolltech.com>
 294
 295         Reviewed by Simon.
 296
 297         implement eventSender.keyDown().
 298
 299         * DumpRenderTree/qt/jsobjects.cpp:
 300         (EventSender::keyDown):
 301
 302 2007-10-24  Lars Knoll  <lars@trolltech.com>
 303
 304         Reviewed by Simon.
 305
 306         some smaller fixes to the editing support in DRT. Makes another few tests pass.
 307
 308         * DumpRenderTree/qt/DumpRenderTree.cpp:
 309         (WebCore::DumpRenderTree::DumpRenderTree):
 310         (WebCore::DumpRenderTree::initJSObjects):
 311         * DumpRenderTree/qt/jsobjects.cpp:
 312         (TextInputController::doCommand):
 313
 314 2007-10-24  Lars Knoll  <lars@trolltech.com>
 315
 316         Reviewed by Simon.
 317
 318         first bit of implementation for the textinputcontroller.
 319
 320         * DumpRenderTree/qt/DumpRenderTree.cpp:
 321         (WebCore::DumpRenderTree::DumpRenderTree):
 322         * DumpRenderTree/qt/DumpRenderTree.h:
 323         * DumpRenderTree/qt/jsobjects.cpp:
 324         (TextInputController::TextInputController):
 325         (TextInputController::doCommand):
 326         * DumpRenderTree/qt/jsobjects.h:
 327
 328 2007-10-24  Lars Knoll  <lars@trolltech.com>
 329
 330         Reviewed by Simon.
 331
 332         make the man webpage believe it has focus, so the editing tests work correctly.
 333
 334         * DumpRenderTree/qt/DumpRenderTree.cpp:
 335         (WebCore::DumpRenderTree::DumpRenderTree):
 336
 337 2007-10-24  Lars Knoll  <lars@trolltech.com>
 338
 339         Reviewed by Simon.
 340
 341         implement layoutTestController.dumpEditingCallbacks() correctly.
 342
 343         * DumpRenderTree/qt/DumpRenderTree.cpp:
 344         (WebCore::DumpRenderTree::DumpRenderTree):
 345         * DumpRenderTree/qt/jsobjects.cpp:
 346         (LayoutTestController::reset):
 347         (LayoutTestController::dumpEditingCallbacks):
 348
 349 2007-10-24  Lars Knoll  <lars@trolltech.com>
 350
 351         Reviewed by Simon.
 352
 353         Implement support for testing editing.
 354
 355         * DumpRenderTree/qt/DumpRenderTree.cpp:
 356         (WebCore::DumpRenderTree::DumpRenderTree):
 357
 358 2007-10-23  Sam Weinig  <sam@webkit.org>
 359
 360         Check for null BSTR that can be passed to the UIDelegate methods
 361         from javascript null and undefined.  Fixes a failing test case on
 362         Windows (fast/dom/Window/alert-undefined.html)
 363
 364         Reviewed by Eric Seidel.
 365
 366         * DumpRenderTree/win/UIDelegate.cpp:
 367         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 368         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 369         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 370         (UIDelegate::webViewAddMessageToConsole):
 371
 372 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 373
 374         Reviewed by Darin.
 375
 376         Don't print a massive pile of setenvs from tools that automatically build testkjs.
 377
 378         * Scripts/build-testkjs:
 379
 380 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 381
 382         Reviewed by Darin.
 383
 384         - add wrapper that finds the right copy of testkjs
 385
 386         * Scripts/sunspider-compare-results: Added.
 387
 388 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
 389
 390         Reviewed by Sam.
 391
 392         - After talking with Steve I now see that the WebKit server must be
 393         running for DCOM to create the distributed objects, which makes sense
 394         and currently WebKit only allows one instance to be running at a time
 395         which avoids accidentally connecting to the wrong server
 396         - In light of this I have removed the code for the attach box and
 397         NotificationServer and known server names, since they are all extranious
 398         now.
 399
 400         * Drosera/win/Drosera.cpp: Removed notification classes and known server
 401         names.
 402         (_tWinMain): Uses init instead of initUI.
 403         (droseraWndProc): No longer creats an attach dialog box.
 404         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
 405         it's not manditory to call init before doing COM stuff.
 406         (Drosera::init): calls initUI and will call attach when the
 407         functionality exists.
 408         (Drosera::initUI): Has changed very little.
 409         (Drosera::attach): Changed the signature to reflect that we no longer
 410         need the dictionary of known server names.
 411         * Drosera/win/Drosera.h: Removed notification classes and known server
 412         names.  Also renamed and moved some functions.
 413         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
 414         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
 415         headers to the resources folder.
 416         * Drosera/win/resource.h: Removed the Attach box.
 417
 418 2007-10-22  Adam Roben  <aroben@apple.com>
 419
 420         Windows build fix
 421
 422         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
 423
 424 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
 425
 426         - Removed a leak that was fixed.
 427
 428         * Scripts/run-webkit-tests:
 429
 430 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 431
 432         Reviewed by Darin.
 433
 434         - Changed the Client so that the DebuggerDocument now own the
 435         ServerConnection.  This simplifies ownership and cleanup.
 436
 437         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
 438         ServerConnection.
 439         (DebuggerClient::initWithServerName):
 440         (DebuggerClient::didFinishLoadForFrame):
 441         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
 442         ServerConnection.
 443         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
 444         until after we have a server which we are attached to.
 445         (Drosera::initUI):
 446         (Drosera::attach):
 447         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
 448         out previously.
 449
 450 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 451
 452         Reviewed by Nikolas.
 453
 454         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
 455
 456         * Scripts/run-javascriptcore-tests:
 457
 458 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 459
 460         Reviewed by Nikolas.
 461
 462         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
 463
 464         * Scripts/build-drosera:
 465         * Scripts/build-dumprendertree:
 466         * Scripts/build-testkjs:
 467         * Scripts/build-webkit:
 468         * Scripts/run-javascriptcore-tests:
 469         * Scripts/run-sunspider:
 470         * Scripts/run-webkit-tests:
 471         * Scripts/webkitdirs.pm:
 472
 473 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
 474
 475         Reviewed by Mark Rowe.
 476
 477         Fix for local database support after r26879
 478         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
 479
 480         * Scripts/build-webkit:
 481
 482 2007-10-22  Holger Freyther  <zecke@selfish.org>
 483
 484         Reviewed by Simon Hausmann <hausmann@kde.org>.
 485
 486         - Do not build testkjs as an application bundle. This is
 487         needed for run-javascriptcore-tests on OSX.
 488         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
 489         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
 490         as we do not have -rpath on OSX.
 491
 492         * DumpRenderTree/qt/DumpRenderTree.pro:
 493         * Scripts/run-webkit-tests:
 494
 495 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 496
 497         Reviewed by aroben.
 498
 499         Fix support for Signed-off-by detection in prepare-ChangeLog
 500         --git-commit. The Signed-off-by tag does not appear in the header
 501         but usually at the end.
 502
 503         * Scripts/prepare-ChangeLog:
 504
 505 2007-10-21  Mark Rowe  <mrowe@apple.com>
 506
 507         Reviewed by Eric.
 508
 509         Fix run-javascriptcore-tests for Gtk.
 510
 511         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
 512
 513 2007-10-20  Eric Seidel  <eric@webkit.org>
 514
 515         Reviewed by aroben.
 516
 517         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
 518
 519 2007-10-20  Eric Seidel  <eric@webkit.org>
 520
 521         Reviewed by darin.
 522
 523         Add improved argument handling to run-sunspider, including
 524         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
 525         Also re-factor code into subroutines
 526
 527         * Scripts/build-dumprendertree: removed bogus comments
 528         * Scripts/build-testkjs: Added.
 529         * Scripts/run-javascriptcore-tests: use build-testkjs
 530         * Scripts/run-sunspider: improved argument handling, abstraction
 531         * Scripts/run-webkit-tests: improved abstraction
 532
 533 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
 534
 535         Not reviewed, Windows build fix.
 536
 537         * DumpRenderTree/win/EventSender.cpp:
 538         (keyDownCallback):
 539
 540 2007-10-20  Darin Adler  <darin@apple.com>
 541
 542         Reviewed by Tim Hatcher.
 543
 544         - http://bugs.webkit.org/show_bug.cgi?id=15544
 545           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
 546           not rely on Apple-specific key codes
 547
 548         * DumpRenderTree/mac/EventSendingController.mm:
 549         (-[EventSendingController keyDown:withModifiers:]):
 550         Added named key "rightArrow". Later we could have a whole table of these.
 551         Also tweaked modifiers code a little.
 552
 553         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
 554
 555 2007-10-19  Darin Adler  <darin@apple.com>
 556
 557         Reviewed by Eric.
 558
 559         - http://bugs.webkit.org/show_bug.cgi?id=15566
 560           possible fix for leak seen in DumpRenderTree
 561
 562         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
 563         Delete the item if it's not put on the queue, since the caller has
 564         no way of knowing that. Would be better to have the parameter type
 565         be auto_ptr to express the fact that we take ownership.
 566
 567         - unrelated change
 568
 569         * Drosera/mac/main.m: Add missing include.
 570
 571 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 572
 573         Reviewed by Adam.
 574
 575         - This change should be identical but for some reason was not working
 576         on my machine.
 577
 578         * Scripts/prepare-ChangeLog:
 579
 580 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 581
 582         Reviewed by Oliver and Tim.
 583
 584         - Made use of RetainPtr to avoid retain and release issues and moved the
 585         log function to DebuggerDocumentPlatform, which seems to be a more
 586         logical place for it to live.
 587         - Also moved knownServers from the ServerConnection to
 588         DebuggerApplication to match the Windows code and because it makes sense
 589         that a connection knows its own server but not all of them.
 590
 591         * Drosera/mac/DebuggerClient.h: Moved the log function to
 592           DebuggerDocumentPlatform.
 593         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
 594           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
 595           call for the server name up from the ServerConnection class.
 596         (-[DebuggerClient dealloc]):
 597         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
 598           for the server name up from the ServerConnection.
 599         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
 600         (DebuggerDocument::platformPause):
 601         (DebuggerDocument::platformResume):
 602         (DebuggerDocument::platformStepInto):
 603         (DebuggerDocument::platformEvaluateScript):
 604         (DebuggerDocument::getPlatformCurrentFunctionStack):
 605         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 606         (DebuggerDocument::platformValueForScopeVariableNamed):
 607         (DebuggerDocument::platformLog): Log directly from here. No need to call
 608           DebuggerClient.
 609         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
 610           way I see it, a ServerConnection should only know about its connection
 611           and the group of all possible servers should be kept by the
 612           application.
 613         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
 614           currentServerName, it makes sense that the connection should know that
 615           name.
 616         (-[ServerConnection currentServerName]):
 617
 618 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 619
 620         Reviewed by Adam.
 621
 622         - Integrated changes from mac drosera.  Recently I've encapsulated
 623         out the server connection object from the rest of Drosera because
 624         it is very platform dependent right now and RPC is not implemented on
 625         windows.  This functionality, of communicating with the WebKit server
 626         is the next area I will be focusing on in Windows.
 627
 628         - Other changes and cleanup were made to organize the code and add notes
 629         on which parts still need work.  Also some mac code is added and
 630         commented out, to act as pseudocode for the logic of those parts.
 631
 632         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
 633           pointer.
 634         * Drosera/config.h: Added whitespace.
 635         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
 636           these files got moved into Drosera.h/cpp
 637         * Drosera/win/DebuggerApplication.h: Removed.
 638         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
 639           happened here to better match the logic flow of the same code on the
 640           mac side and to use the new ServerConnection class.
 641         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
 642         (DebuggerClient::initWithServerName): Initializer that will set up the
 643           class to use a ServerConnection object.  This was necessary so I could
 644           create a DebuggerClient without having to initilaize it at
 645           construction.
 646         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
 647           will be the UIDelegate and FrameLoadDelegate.
 648         (DebuggerClient::AddRef): For IUnknown.
 649         (DebuggerClient::Release): For IUnknown.
 650         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
 651           this still needs to set the global context of the server, but
 652           IWebFrame does not have an accessor for the global context yet.
 653         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
 654           this is a pass through for the same function in the document.
 655         (DebuggerClient::didReceiveTitle): Unimplemented part of
 656           FrameLoadDelegate this would change the title of the window.
 657         (DebuggerClient::createWebViewWithRequest): Part of the
 658           FrameLoadDelegate.  This is about new windows via Window.open() and
 659           how their delegates are set.
 660         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
 661           UIDelegate.  Just a debug function for printing messages.
 662         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
 663           because the Client should be the UIDelegate and FrameLoadDelegate
 664           to match the delegates on mac.
 665         (DebuggerClient::webViewLoaded): Added accessor method.
 666         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
 667           forgotten to add this file before.  This is where the platform
 668           dependent versions of the Documents functions live. Most of these are
 669           unimplemented because some piece of functionality does not exist on
 670           Windows yet.
 671         (DebuggerDocument::platformPause):
 672         (DebuggerDocument::platformResume):
 673         (DebuggerDocument::platformStepInto):
 674         (DebuggerDocument::platformEvaluateScript):
 675         (DebuggerDocument::getPlatformCurrentFunctionStack):
 676         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 677         (DebuggerDocument::platformValueForScopeVariableNamed):
 678         (DebuggerDocument::platformLog):
 679         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
 680           responsibilities becaue they belong in the Client. Also I laid the
 681           groundwork for attaching Drosera to a WebKit process
 682         (attachWndProc): Now if a server is selected the Client becomes it's
 683           delegate.
 684         (Drosera::Drosera): Added the construction of the Client and dictionary
 685           of server names.
 686         (Drosera::initUI): This is no longer the delegates, the Client is.
 687         (Drosera::webViewLoaded): Now asks the Client instead of holding local
 688           state.
 689         (Drosera::applicationDidFinishLaunching): Placeholder for needed
 690           notification registration when it's possible to implement.
 691         (Drosera::serverLoaded): Ditto
 692         (Drosera::serverUnloaded): Ditto
 693         (Drosera::attach): Attach Drosera to the WebKit server.
 694         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
 695         (Drosera::getInst):
 696         (Drosera::setInst):
 697         (Drosera::knownServers):
 698         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
 699           and added the ServerConnection.
 700         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
 701         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
 702           Most of the functions are completely unimlemented because they cannot
 703           connect with the WebKit server, because one does not exist on Windows
 704           yet.
 705         (ServerConnection::initWithServerName):
 706         (ServerConnection::~ServerConnection):
 707         (ServerConnection::setGlobalContext):
 708         (ServerConnection::pause):
 709         (ServerConnection::resume):
 710         (ServerConnection::stepInto):
 711         (ServerConnection::switchToServerNamed):
 712         (ServerConnection::applicationTerminating):
 713         (ServerConnection::serverConnectionDidDie):
 714         (ServerConnection::currentFrame):
 715         * Drosera/win/ServerConnection.h: Added. Ditto.
 716         (ServerConnection::ServerConnection):
 717
 718 2007-10-19  Alice Liu  <alice.liu@apple.com>
 719
 720         Reviewed by Darin.
 721
 722         Fix for these broken layout tests on Windows:
 723
 724         fast/forms/focus-selection-input.html
 725         fast/forms/focus-selection-textarea.html
 726         fast/forms/select-accesskey.html
 727
 728         * DumpRenderTree/win/EventSender.cpp:
 729         (keyDownCallback):
 730         correct the VK code for alt key.
 731
 732 2007-10-19  Eric Seidel  <eric@webkit.org>
 733
 734         Reviewed by Mark Rowe.
 735
 736         Make the GtkLauncher code slightly more readable.
 737
 738         * GtkLauncher/main.cpp:
 739         (setupMainMenu): Added.
 740         (setupMainWindowUI): Added.
 741         (main):
 742
 743 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
 744
 745         Rubber stamped by Adam.
 746
 747         - don't delay-load WebKit in DumpRenderTree.
 748
 749         * DumpRenderTree/win/DumpRenderTree.vcproj:
 750
 751 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
 752
 753         Reviewed by Adam Roben.
 754
 755         - fix <rdar://problem/5313523>
 756         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
 757
 758         * DumpRenderTree/mac/DumpRenderTree.mm:
 759         (dump): Changed to use _responseMIMEType.
 760
 761 2007-10-17  Adam Roben  <aroben@apple.com>
 762
 763         Make it possible to have Windows-specific tests and results
 764
 765         When searching for tests to run and the Skipped file, we will only
 766         look in platform/win and the cross-platform directory. When looking
 767         for expected results, we will look in platform/win, then
 768         platform/mac-leopard, then platform/mac, then finally the
 769         cross-platform directory.
 770
 771         Reviewed by Sam.
 772
 773         * Scripts/run-webkit-tests:
 774         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
 775         searching in the cross-platform directory.
 776         (sub buildPlatformHierarchy): Removed some unneeded calls to
 777         dirname/basename.
 778
 779 2007-10-17  Adam Roben  <aroben@apple.com>
 780
 781         Add back the call to register WebKit that we had before WebKitInitializer existed
 782
 783         This is needed to ensure that the right WebKit is used when
 784         instantiating COM objects.
 785
 786         Reviewed by Oliver.
 787
 788         * DumpRenderTree/win/debug_internal.vsprops: Define
 789         DEBUG_WEBKIT_HAS_SUFFIX.
 790         * DumpRenderTree/win/DumpRenderTree.cpp:
 791         (initialize):
 792
 793 2007-10-17  Adam Roben  <aroben@apple.com>
 794
 795         Import File::Basename in webkitdirs since we use it
 796
 797         * Scripts/webkitdirs.pm:
 798
 799 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
 800
 801         - Updated the tiger leaks list to make the internal bots green.
 802
 803         * Scripts/run-webkit-tests:
 804
 805 2007-10-17  Adam Roben  <aroben@apple.com>
 806
 807         Build fix for VC++ Express
 808
 809         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
 810         and ole32.lib.
 811
 812 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
 813
 814         Reviewed by Sam.
 815
 816         - Minor mac improvements based on observations I made while implementing the
 817         Windows code.
 818
 819         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
 820         then hand it to the Client who will retain it, it should just be the client who
 821         creates and owns the server.
 822         (-[DebuggerApplication attach:]):
 823         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
 824         * Drosera/mac/DebuggerClient.mm: Creates the server.
 825         (-[DebuggerClient initWithServerName:]):
 826         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
 827         can instead forward declare what it needs.
 828
 829 2007-10-16  Darin Adler  <darin@apple.com>
 830
 831         Reviewed by Geoff Garen.
 832
 833         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
 834         want to turn failing tests into platform-specific test results. Also did a
 835         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
 836         would take the type of results into account only some of the time.
 837
 838 2007-10-16  Adam Roben  <aroben@apple.com>
 839
 840         Add a new nightly launcher script for Windows
 841
 842         This new script is for versions of Safari that don't delay-load
 843         WebKit. I had to make FindSafari be able to print out the nightly
 844         launcher script on stdout because Windows shell scripts can't capture
 845         the output from a command into an environment variable.
 846
 847         Reviewed by Steve.
 848
 849         * FindSafari/FindSafari.cpp:
 850         (_tmain): Added /printSafariLauncher option.
 851         * Scripts/run-webkit-nightly.cmd: Added.
 852
 853 2007-10-16  Adam Roben  <aroben@apple.com>
 854
 855         Replace WebKitInitializer with FindSafari
 856
 857         We now rely on setting the PATH environment variable to tell Windows
 858         where to find WebKit and its dependencies (similar to
 859         DYLD_FRAMEWORK_PATH on Mac).
 860
 861         This change also make DumpRenderTree no longer delay-load WebKit.
 862
 863         Reviewed by Sam.
 864
 865         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
 866         FindSafari.
 867         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
 868         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
 869         WebKitInitializer, don't delay-load WebKit.
 870         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
 871         * Scripts/run-webkit-tests: Ditto.
 872         * Scripts/webkitdirs.pm:
 873         (sub setPathForRunningWebKitApp): Added.
 874         * WebKitInitializer/WebKitInitializer.cpp: Removed.
 875         * WebKitInitializer/WebKitInitializer.h: Removed.
 876         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
 877         * WebKitInitializer/debug.vsprops: Removed.
 878         * WebKitInitializer/debug_internal.vsprops: Removed.
 879         * WebKitInitializer/release.vsprops: Removed.
 880
 881 2007-10-16  Adam Roben  <aroben@apple.com>
 882
 883         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
 884
 885         http://bugs.webkit.org/show_bug.cgi?id=15532
 886
 887         FindSafari simply prints the location of an installed Safari.exe on
 888         stdout.
 889
 890         Reviewed by Darin.
 891
 892         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
 893         (getStringValue):
 894         (getWebViewCLSID):
 895         (getInstalledWebKitDirectory):
 896         (_tmain):
 897         * FindSafari/FindSafari.vcproj: Added.
 898         * Scripts/webkitdirs.pm:
 899         (sub installedSafariPath): Added. Calls FindSafari on Windows.
 900
 901 2007-10-16  Adam Roben  <aroben@apple.com>
 902
 903         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
 904
 905         Reviewed by Kevin McCullough.
 906
 907         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
 908         when referring to WebKit.dll.
 909         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
 910         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
 911         * DumpRenderTree/win/release.vsprops: Ditto.
 912         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
 913         never have a _debug suffix on WebKit.dll.
 914         * WebKitInitializer/WebKitInitializer.cpp:
 915         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
 916         specified.
 917         * WebKitInitializer/debug_internal.vsprops: Added
 918         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
 919
 920 2007-10-16  Darin Adler  <darin@apple.com>
 921
 922         Reviewed by Adele.
 923
 924         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
 925         Remove now-unneeded control/alt key hack; the tests have been updated.
 926
 927 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
 928
 929         - Updated leaks list because our internal bot upgraded it's version of leopard and
 930         one of the leaks was fixed between that revision and the bot's previous version of
 931         leopard.
 932
 933         * Scripts/run-webkit-tests:
 934
 935 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
 936
 937         Reviewed by Tim.
 938
 939         - I encapsulated out the server connecton functionality because it is a specific part
 940         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
 941         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
 942         Windows.  So the majority of this patch is moving preexisting functionality.
 943
 944         - Also I removed the prefix header and changed to use config.h because it is more
 945         standard on how we use config.h in windows and it didn't make much sense to keep
 946         the prefix header and the config.h
 947
 948         * Drosera/DebuggerDocument.cpp:
 949         (DebuggerDocument::DebuggerDocument):
 950         * Drosera/DebuggerDocument.h:
 951         * Drosera/config.h:
 952         * Drosera/mac/DebuggerApplication.mm:
 953         (-[DebuggerApplication attach:]):
 954         * Drosera/mac/DebuggerClient.h:
 955         * Drosera/mac/DebuggerClient.mm:
 956         (-[DebuggerClient initWithServerConnection:]):
 957         (-[DebuggerClient dealloc]):
 958         (-[DebuggerClient windowDidLoad]):
 959         (-[DebuggerClient windowWillClose:]):
 960         (-[DebuggerClient webView:didFinishLoadForFrame:]):
 961         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
 962         * Drosera/mac/DebuggerDocumentPlatform.mm:
 963         (DebuggerDocument::platformPause):
 964         (DebuggerDocument::platformResume):
 965         (DebuggerDocument::platformStepInto):
 966         (DebuggerDocument::platformEvaluateScript):
 967         (DebuggerDocument::getPlatformCurrentFunctionStack):
 968         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 969         (DebuggerDocument::platformValueForScopeVariableNamed):
 970         (DebuggerDocument::platformLog):
 971         * Drosera/mac/Drosera.pch: Removed.
 972         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
 973         * Drosera/mac/ServerConnection.h: Added.
 974         * Drosera/mac/ServerConnection.mm: Added.
 975         (-[ServerConnection initWithServerName:]):
 976         (-[ServerConnection dealloc]):
 977         (-[ServerConnection setGlobalContext:]):
 978         (-[ServerConnection pause]):
 979         (-[ServerConnection resume]):
 980         (-[ServerConnection stepInto]):
 981         (-[ServerConnection switchToServerNamed:]):
 982         (-[ServerConnection applicationTerminating:]):
 983         (-[ServerConnection serverConnectionDidDie:]):
 984         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
 985         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
 986         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
 987         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
 988         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
 989         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
 990         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
 991         (-[ServerConnection currentFrame]):
 992         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
 993         (-[ServerConnection knownServers]):
 994
 995 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
 996
 997         Reviewed by Eric.
 998
 999         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1000           Script to automatically search nightly builds for regressions (bisect-builds)
1001
1002         * Scripts/bisect-builds: Added.
1003
1004 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1005
1006         Reviewed by Darin.
1007
1008         - New JavaScript benchmark
1009         http://bugs.webkit.org/show_bug.cgi?id=15515
1010
1011         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1012         current development or release build of JavaScriptCore.
1013
1014 2007-10-15  Mark Rowe  <mrowe@apple.com>
1015
1016         Reviewed by Sam.
1017
1018         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1019
1020         * Scripts/webkitdirs.pm:
1021         - Change checkArgv to remove the options from @ARGV to prevent
1022         them from interfering with further option processing.
1023         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1024         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1025         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1026         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1027
1028 2007-10-15  Darin Adler  <darin@apple.com>
1029
1030         Reviewed by Sam.
1031
1032         - added logging of window.prompt and window.confirm
1033
1034         * DumpRenderTree/mac/UIDelegate.mm:
1035         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1036         Implement the recommended delegate rather than the deprecated one.
1037         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1038         Added.
1039         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1040         Added.
1041
1042         * DumpRenderTree/win/UIDelegate.h:
1043         * DumpRenderTree/win/UIDelegate.cpp:
1044         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1045         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1046         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1047         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1048
1049 2007-10-15  Alice Liu  <alice.liu@apple.com>
1050
1051         Reviewed by Sam Weinig.
1052
1053         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1054
1055         * DumpRenderTree/win/DumpRenderTree.cpp:
1056         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1057         (main): allocate the global policy delegate for DRT's custom use
1058         * DumpRenderTree/win/DumpRenderTree.vcproj:
1059         Adding files to project
1060         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1061         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1062         (LayoutTestController::setCustomPolicyDelegate):
1063         set the webview's policy delegate to DRT's custom one if the test requests it.
1064         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1065         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1066         (PolicyDelegate::PolicyDelegate):
1067         (PolicyDelegate::QueryInterface):
1068         (PolicyDelegate::AddRef):
1069         (PolicyDelegate::Release):
1070         (PolicyDelegate::decidePolicyForNavigationAction):
1071         * DumpRenderTree/win/PolicyDelegate.h: Added.
1072         (PolicyDelegate::decidePolicyForNewWindowAction):
1073         (PolicyDelegate::decidePolicyForMIMEType):
1074         (PolicyDelegate::unableToImplementPolicyWithError):
1075
1076 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1077
1078         Reviewed by Mark.
1079
1080         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1081         when querying for QMAKE_MKSPECS.
1082
1083 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1084
1085         Reviewed by Adam Roben.
1086
1087         Fix run-webkit-tests is too greedy calculating platform hierarchy
1088         http://bugs.webkit.org/show_bug.cgi?id=15465
1089
1090         Fix run-webkit-tests being too greedy in trying to split the platform name up
1091         causing it to try and find tests in every directory above the first "-" in the
1092         path to the LayoutTests
1093
1094         * Scripts/run-webkit-tests:
1095
1096 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1097
1098         Reviewed by Darin.
1099
1100         http://bugs.webkit.org/show_bug.cgi?id=15006
1101         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1102         to reduce code duplication.
1103
1104         * Scripts/build-webkit:
1105         * Scripts/webkitdirs.pm:
1106         buildQMakeProject() renamed to buildQMakeQtProject().
1107         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1108         unused $colorize has been removed.
1109
1110 === Start merge of feature-branch 2007-10-12 ===
1111
1112 2007-10-08  Eric Seidel  <eric@webkit.org>
1113
1114         Reviewed by Mark Rowe.
1115
1116         * Scripts/build-webkit: add --help, remove unused --color
1117
1118 2007-10-07  Eric Seidel  <eric@webkit.org>
1119
1120         Reviewed by darin.
1121
1122         * Drosera/mac/DebuggerDocumentPlatform.mm:
1123         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1124
1125 2007-10-03  Rob Buis  <buis@kde.org>
1126
1127         Reviewed by Olliej.
1128
1129         Adapt to changed location of Ahem font.
1130
1131         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1132
1133 2007-10-02  Eric Seidel  <eric@webkit.org>
1134
1135         Reviewed by Adam Roben.
1136
1137         Make pixel tests more useful!
1138         Finally fix the image diff 0.00% mystery problem
1139         Highlight any image differences in the image diff.
1140         Add a link from image diffs back to original test file.
1141
1142         * DumpRenderTree/mac/ImageDiff.m:
1143         (compareImages): highlight any differences
1144         (computePercentageDifferent): round to two decimal places
1145         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1146
1147 2007-10-02  Eric Seidel  <eric@webkit.org>
1148
1149         Reviewed by Alexey Proskuryakov.
1150
1151         * Scripts/run-webkit-tests: print the % image difference on main results page
1152
1153 2007-10-02  Mark Rowe  <mrowe@apple.com>
1154
1155         Reviewed by Oliver.
1156
1157         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1158
1159         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1160         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1161
1162 2007-10-01  Mark Rowe  <mrowe@apple.com>
1163
1164         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1165
1166 2007-09-25  Eric Seidel  <eric@webkit.org>
1167
1168         Reviewed by Mark Rowe.
1169
1170         DerivedSources.make was finding "ENABLE_SVG" in the string
1171         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1172         quite correctly.
1173
1174         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1175
1176 2007-09-25  Mark Rowe  <mrowe@apple.com>
1177
1178         Rubber-stamped by Eric.
1179
1180         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1181         This makes it possible to automate nightly builds for the feature-branch.
1182
1183 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1184
1185         Rubber stamped by Mark.
1186
1187         Enable svg experimental features as default here in feature-branch.
1188
1189         * Scripts/build-webkit:
1190
1191 2007-06-29  Antti Koivisto  <antti@apple.com>
1192
1193         Reviewed by Weinig.
1194
1195         Add VIDEO flag for timed media features
1196
1197         * Scripts/build-webkit
1198
1199 === End merge of feature-branch 2007-10-12 ===
1200
1201 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1202
1203         Reviewed by Darin.
1204
1205         - Updated rational for the leaks list to be more clear.
1206
1207         * Scripts/run-webkit-tests:
1208
1209 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1210
1211         Rubber Stamp by Sam.
1212
1213         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1214         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1215
1216         * Scripts/run-webkit-tests:
1217
1218 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1219
1220         Reviewed by Lars.
1221
1222         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1223         includes are needed for INT_MAX, std::auto_ptr and the like.
1224
1225         * DumpRenderTree/qt/main.cpp:
1226
1227 2007-10-09  Lars Knoll  <lars@trolltech.com>
1228
1229         Reviewed by Simon.
1230
1231         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1232
1233         * DumpRenderTree/qt/jsobjects.cpp:
1234         (LayoutTestController::encodeHostName):
1235         (LayoutTestController::decodeHostName):
1236         * DumpRenderTree/qt/jsobjects.h:
1237
1238 2007-10-09  Lars Knoll  <lars@trolltech.com>
1239
1240         Reviewed by Simon.
1241
1242         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1243
1244         * DumpRenderTree/qt/DumpRenderTree.cpp:
1245         (WebCore::WebPage::createFrame):
1246         (WebCore::DumpRenderTree::DumpRenderTree):
1247         (WebCore::DumpRenderTree::titleChanged):
1248         * DumpRenderTree/qt/DumpRenderTree.h:
1249         * DumpRenderTree/qt/jsobjects.cpp:
1250         (LayoutTestController::reset):
1251         * DumpRenderTree/qt/jsobjects.h:
1252
1253 2007-10-09  Lars Knoll  <lars@trolltech.com>
1254
1255         Reviewed by Simon.
1256
1257         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1258
1259         * DumpRenderTree/qt/DumpRenderTree.h:
1260         * DumpRenderTree/qt/jsobjects.cpp:
1261         (LayoutTestController::clearBackForwardList):
1262         * DumpRenderTree/qt/jsobjects.h:
1263
1264 2007-10-09  Lars Knoll  <lars@trolltech.com>
1265
1266         Reviewed by Simon.
1267
1268         make --git-reviewer work again.
1269
1270         * Scripts/prepare-ChangeLog:
1271
1272 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1273
1274         Rubber stamped by Eric.
1275
1276         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1277         show the current link inside the statusbar.
1278         This shows how to make use of this signal and allows to easily test
1279         http://bugs.webkit.org/show_bug.cgi?id=15299.
1280
1281         * GtkLauncher/main.cpp:
1282         (hoveringOverLink):
1283         (main):
1284
1285 2007-10-05  Lars Knoll  <lars@trolltech.com>
1286
1287         add proper error messages to the FrameLoaderClient.
1288         Implement ChromeClientQt::closeWindowSoon and
1289         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1290         Some fixes in DRT to make it work correctly with multiple windows.
1291
1292         Reviewed by Maciej.
1293
1294         * DumpRenderTree/qt/DumpRenderTree.cpp:
1295         (WebCore::DumpRenderTree::DumpRenderTree):
1296         (WebCore::DumpRenderTree::createWindow):
1297         (WebCore::DumpRenderTree::windowCount):
1298         * DumpRenderTree/qt/DumpRenderTree.h:
1299         * DumpRenderTree/qt/jsobjects.cpp:
1300         (LayoutTestController::maybeDump):
1301         (LayoutTestController::windowCount):
1302         * DumpRenderTree/qt/jsobjects.h:
1303
1304 2007-10-05  Lars Knoll  <lars@trolltech.com>
1305
1306         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1307         Add support for layoutTextController.setCanOpenWindows() to DRT
1308         fixing another 2 test cases in fast/dom/Window.
1309
1310         Reviewed by Maciej.
1311
1312         * DumpRenderTree/qt/DumpRenderTree.cpp:
1313         (WebCore::WebPage::WebPage):
1314         (WebCore::WebPage::createWindow):
1315         (WebCore::DumpRenderTree::resetJSObjects):
1316         (WebCore::DumpRenderTree::createWindow):
1317         * DumpRenderTree/qt/DumpRenderTree.h:
1318         * DumpRenderTree/qt/DumpRenderTree.pro:
1319         * DumpRenderTree/qt/jsobjects.cpp:
1320         (LayoutTestController::LayoutTestController):
1321         (LayoutTestController::reset):
1322         * DumpRenderTree/qt/jsobjects.h:
1323         * DumpRenderTree/qt/main.cpp:
1324         * DumpRenderTree/qt/testplugin.cpp: Added.
1325         * DumpRenderTree/qt/testplugin.h: Added.
1326
1327 2007-10-04  Sam Weinig  <sam@webkit.org>
1328
1329         Rubber stamped by Adam.
1330
1331         Remove empty directories.
1332
1333         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1334         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1335
1336 2007-10-03  Darin Adler  <darin@apple.com>
1337
1338         Reviewed by Adam.
1339
1340         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1341         we find the internal libraries in the libraries directory. This
1342         is helpful for Safari team engineers at Apple.
1343
1344 2007-10-03  Adam Roben  <aroben@apple.com>
1345
1346         Update the location of AHEM___.TTF after r25968
1347
1348         Reviewed by Sam.
1349
1350         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1351
1352 2007-10-03  Alp Toker  <alp@atoker.com>
1353
1354         Reviewed by Adam.
1355
1356         http://bugs.webkit.org/show_bug.cgi?id=14726
1357         [gtk] API design. Mapping the WebView delegates to signals.
1358
1359         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1360
1361         * GtkLauncher/main.cpp:
1362         (goToURLBarText):
1363         (titleChanged):
1364         (progressChanged):
1365         (menuMainBackCallback):
1366         (menuMainForwardCallback):
1367         (main):
1368
1369 2007-10-03  Lars Knoll  <lars@trolltech.com>
1370
1371         Reviewed by Rob.
1372
1373         This fixes --strict mode in run-webkit-tests again after
1374         the platform dependent test results have been moved.
1375
1376         * Scripts/run-webkit-tests:
1377
1378 2007-10-03  Lars Knoll  <lars@trolltech.com>
1379
1380         Reviewed by bdash.
1381
1382         remove the hack in run-webkit-tests that forced text only test
1383         to be taken from the platform independent dir. It was only left
1384         there from early days.
1385
1386         Remove platform dependent results for tests that are text only nowadays,
1387         and add one platform dependent result for a text only test that requires it.
1388
1389         * Scripts/run-webkit-tests:
1390
1391 2007-10-03  Lars Knoll  <lars@trolltech.com>
1392
1393         Reviewed by olliej.
1394
1395         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1396
1397         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1398         (WebCore::WebFrame::WebFrame):
1399         (WebCore::WebPage::WebPage):
1400         (WebCore::WebPage::createFrame):
1401         (WebCore::WebPage::javaScriptAlert):
1402         (WebCore::WebPage::javaScriptConsoleMessage):
1403         (WebCore::DumpRenderTree::DumpRenderTree):
1404         (WebCore::DumpRenderTree::~DumpRenderTree):
1405         (WebCore::DumpRenderTree::open):
1406         (WebCore::DumpRenderTree::readStdin):
1407         (WebCore::DumpRenderTree::resetJSObjects):
1408         (WebCore::DumpRenderTree::initJSObjects):
1409         (WebCore::DumpRenderTree::dumpFramesAsText):
1410         (WebCore::DumpRenderTree::dump):
1411         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1412         (WebCore::DumpRenderTree::layoutTestController):
1413         (WebCore::DumpRenderTree::eventSender):
1414         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1415         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1416         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1417         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1418         (HackWebFrame::mousePressEvent):
1419         (HackWebFrame::mouseReleaseEvent):
1420         (HackWebFrame::mouseMoveEvent):
1421         (HackWebFrame::HackWebFrame):
1422         (HackWebFrame::~HackWebFrame):
1423         (LayoutTestController::LayoutTestController):
1424         (LayoutTestController::reset):
1425         (LayoutTestController::maybeDump):
1426         (LayoutTestController::waitUntilDone):
1427         (LayoutTestController::notifyDone):
1428         (LayoutTestController::dumpEditingCallbacks):
1429         (LayoutTestController::queueReload):
1430         (LayoutTestController::provisionalLoad):
1431         (LayoutTestController::timerEvent):
1432         (EventSender::EventSender):
1433         (EventSender::mouseDown):
1434         (EventSender::mouseUp):
1435         (EventSender::mouseMoveTo):
1436         (EventSender::leapForward):
1437         (EventSender::keyDown):
1438         (EventSender::frameUnderMouse):
1439         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
1440         (LayoutTestController::isLoading):
1441         (LayoutTestController::setLoading):
1442         (LayoutTestController::shouldDumpAsText):
1443         (LayoutTestController::shouldDumpChildrenAsText):
1444         (LayoutTestController::shouldWaitUntilDone):
1445         (LayoutTestController::dumpAsText):
1446         (LayoutTestController::dumpChildFramesAsText):
1447         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
1448         (messageHandler):
1449         (crashHandler):
1450         (main):
1451         * Scripts/run-webkit-tests:
1452
1453 2007-10-03  Mark Rowe  <mrowe@apple.com>
1454
1455         Reviewed by Alp Toker.
1456
1457         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
1458         should take precedence over QTDIR when determining which port we are working with.
1459
1460         * Scripts/webkitdirs.pm:
1461
1462 2007-10-02  Adam Roben  <aroben@apple.com>
1463
1464         Add keychain to the list of default packages to install
1465
1466         Rubberstamped by Sam.
1467
1468         * CygwinDownloader/cygwin-downloader.py:
1469         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1470
1471 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
1472
1473         Reviewed by Adam.
1474
1475         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
1476         Also makes WebCore regression test case logic work when using git.
1477
1478         * Scripts/prepare-ChangeLog:
1479         (reviewerAndDescriptionForGitCommit): Added.
1480
1481 2007-10-02  Lars Knoll  <lars@trolltech.com>
1482
1483         Reviewed by bdash.
1484
1485         Add API to retrieve the frame name from QWebFrame.
1486         Implement support for DRT::dumpChildrenAsText.
1487
1488         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1489         (WebCore::DumpRenderTree::dumpFramesAsText):
1490         (WebCore::DumpRenderTree::dump):
1491         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1492         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1493         (LayoutTestController::LayoutTestController):
1494         (LayoutTestController::reset):
1495         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1496
1497 2007-10-02  Lars Knoll  <lars@trolltech.com>
1498
1499         Reviewed by bdash.
1500
1501         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
1502
1503         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1504         (WebCore::DumpRenderTree::readStdin):
1505
1506 2007-10-02  Mark Rowe  <mrowe@apple.com>
1507
1508         Reviewed by Oliver.
1509
1510         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1511
1512         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1513         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1514
1515 2007-10-02  Mark Rowe  <mrowe@apple.com>
1516
1517         Rubber-stamped by Maciej.
1518
1519         Configuration changes from build.webkit.org.  The major change is refactoring to work
1520         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
1521         last few weeks.
1522
1523         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1524         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
1525         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
1526         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
1527         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
1528         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
1529         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
1530         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1531
1532 2007-10-02  Lars Knoll  <lars@trolltech.com>
1533
1534         Reviewed by Maciej.
1535
1536         Add support for eventSender.mouseMove to DRT.
1537         Fixes fast/css/hover-affects-child.html
1538
1539         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1540         (EventSender::mouseMoveTo):
1541
1542 2007-10-01  Mark Rowe  <mrowe@apple.com>
1543
1544         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1545
1546 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
1547
1548         Reviewed by Hyatt.
1549
1550         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
1551
1552         * Scripts/svn-apply:
1553         (gitdiff2svndiff): Ignore lines beginning with "new file".
1554         * Scripts/svn-unapply:
1555         (gitdiff2svndiff): Ditto.
1556
1557 2007-09-30  George Staikos  <staikos@kde.org>
1558
1559         Qt build fix (Mac OS X specific)
1560
1561         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
1562
1563 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1564
1565         Reviewed by Mark.
1566
1567         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
1568         Remove Bakefiles from svn.
1569
1570         * GtkLauncher/Bakefiles.bkgen: Removed.
1571         * GtkLauncher/ENV: Removed.
1572         * GtkLauncher/gdklauncher.bkl: Removed.
1573         * GtkLauncher/mk: Removed.
1574         * Scripts/regenerate-makefiles: Removed.
1575
1576 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
1577
1578         Reviewed by John.
1579
1580         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
1581
1582         * Scripts/run-webkit-tests:
1583
1584 2007-09-26  Adam Roben  <aroben@apple.com>
1585
1586         Make not finding an installed WebKit non-fatal
1587
1588         What really matters is that we are able to load WebKit and its
1589         dependencies, not whether we think we've found an installed WebKit.
1590
1591         Reviewed by Sam.
1592
1593         * WebKitInitializer/WebKitInitializer.cpp:
1594         (getWebViewCLSID): Use new LOG_WARNING macro.
1595         (getInstalledWebKitDirectory): Ditto.
1596         (initializeWebKit): Don't die if we didn't find an installed WebKit,
1597         and use new macros.
1598         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
1599
1600 2007-09-26  Adam Roben  <aroben@apple.com>
1601
1602         Committed this file before saving it
1603
1604         * WebKitInitializer/debug_internal.vsprops:
1605
1606 2007-09-26  Adam Roben  <aroben@apple.com>
1607
1608         Load WebKit and its dependencies manually so they come from DllDirectory
1609
1610         I had to change WebKitInitializer to use malloc/free instead of
1611         new/delete to avoid pulling in WebKit (and its dependencies) early
1612         through use of fastMalloc.
1613
1614         Reviewed by Oliver.
1615
1616         * WebKitInitializer/WebKitInitializer.cpp:
1617         (getStringValue): Changed to use malloc/free.
1618         (getInstalledWebKitDirectory): Ditto.
1619         (initializeWebKit): Call SetDllDirectory first, then load all of
1620         WebKit's dependencies manually, finally followed by WebKit itself.
1621         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
1622         configuration to match our other projects.
1623         * WebKitInitializer/debug_internal.vsprops: Added.
1624
1625 2007-09-25  Adam Roben  <aroben@apple.com>
1626
1627         Actually define DEBUG/NDEBUG so that we load WebKit correctly
1628
1629         Rubberstamped by Sam.
1630
1631         * WebKitInitializer/WebKitInitializer.vcproj:
1632
1633 2007-09-25  Adam Roben  <aroben@apple.com>
1634
1635         Make DumpRenderTree delay-load its dependencies
1636
1637         This lets WebKitInitializer re-route the dependencies to be loaded out
1638         of the Safari installation directory.
1639
1640         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
1641         same thing), since we can't import the kCFAllocatorDefault symbol when
1642         delay-loading CoreFoundation.dll.
1643
1644         Rubberstamped by Sam.
1645
1646         * DumpRenderTree/win/DumpRenderTree.cpp:
1647         (runTest):
1648         (javaScriptThreads):
1649         * DumpRenderTree/win/DumpRenderTree.vcproj:
1650         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1651         (LayoutTestController::setWaitToDump):
1652
1653 2007-09-25  Adam Roben  <aroben@apple.com>
1654
1655         Pull ole32.lib into WebKitInitializer
1656
1657         Rubberstamped by Sam.
1658
1659         * WebKitInitializer/WebKitInitializer.vcproj:
1660
1661 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1662
1663         Reviewed by Adam.
1664
1665         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
1666           LGPL'ed files contain incorrect FSF address
1667
1668         * Drosera/config.h:
1669
1670 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1671
1672         Reviewed by Adam.
1673
1674         Make svn-apply and svn-unapply work with git-diff formatted patches.
1675
1676         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
1677         (gitdiff2svndiff): Added.
1678         * Scripts/svn-unapply: Ditto.
1679         (gitdiff2svndiff): Added.
1680
1681 2007-09-25  Adam Roben  <aroben@apple.com>
1682
1683         Pull advapi32.lib into WebKitInitializer
1684
1685         This is needed to get the registry functions we use.
1686
1687         Rubberstamped by Sam.
1688
1689         * WebKitInitializer/WebKitInitializer.vcproj:
1690
1691 2007-09-25  Adam Roben  <aroben@apple.com>
1692
1693         Add python and rsync to cygwin-downloader
1694
1695         Our build slaves need this, and it can't hurt for everyone else to
1696         have it, too.
1697
1698         Reviewed by Sam.
1699
1700         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
1701         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1702
1703 2007-09-25  Adam Roben  <aroben@apple.com>
1704
1705         Add WebKitInitializer and use it in DumpRenderTree
1706
1707         WebKitInitializer is a static library that has one function,
1708         initializeWebKit(). This registers WebKit and sets up the DLL search
1709         path so that WebKit's dependencies that are installed with Safari can
1710         be found.
1711
1712         Reviewed by Sam.
1713
1714         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
1715         DumpRenderTree depend on it.
1716         * DumpRenderTree/win/DumpRenderTree.cpp:
1717         (initialize): Call initializeWebKit.
1718         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
1719         WebKitInitializer.lib.
1720         * WebKitInitializer/WebKitInitializer.cpp: Added.
1721         (getStringValue):
1722         (getWebViewCLSID):
1723         (getInstalledWebKitDirectory):
1724         (initializeWebKit):
1725         * WebKitInitializer/WebKitInitializer.h: Added.
1726         * WebKitInitializer/WebKitInitializer.vcproj: Added.
1727         * WebKitInitializer/debug.vsprops: Added.
1728         * WebKitInitializer/release.vsprops: Added.
1729
1730 2007-09-25  Adam Roben  <aroben@apple.com>
1731
1732         Make run-webkit-tests respect set-webkit-configuration
1733
1734         Reviewed by Sam.
1735
1736         * Scripts/run-webkit-tests: Initialize $configuration to whatever
1737         set-webkit-configuration was last set to.
1738
1739 2007-09-25  Mark Rowe  <mrowe@apple.com>
1740
1741         Rubber-stamped by Eric.
1742
1743         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1744         This makes it possible to automate nightly builds for the feature-branch.
1745
1746 2007-09-25  Adam Roben  <aroben@apple.com>
1747
1748         A couple of fixes/enhancements to update-webkit-*-libs
1749
1750         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
1751         to tell update-webkit-support-libraries where it should find the
1752         WebKitSupportLibrary.zip file you downloaded.
1753
1754         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
1755         Windows-style path.
1756
1757         Reviewed by Sam.
1758
1759         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
1760         to $auxiliaryLibsURL and removed an irrelevant comment.
1761         * Scripts/update-webkit-support-libs:
1762
1763 2007-09-25  Adam Treat  <treat@kde.org>
1764
1765         Reviewed by Simon and Lars.
1766
1767         Refactors and cleans up Qt DRT member variable names, member variable
1768         initialization, style fixes and general code cleanup.
1769
1770         Adds queueReload slot to LayoutTestController that some tests require.
1771
1772         Subclasses QWebFrame to make sure that all frames have an associated
1773         LayoutTestController JS window object.
1774
1775         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
1776         aren't dumped twice.
1777
1778         EOF fixes.
1779
1780         Together, this patch fixes some 20+ layout tests in QtWebKit.
1781
1782         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1783         (WebCore::WebFrame::WebFrame):
1784         (WebCore::WebPage::WebPage):
1785         (WebCore::WebPage::createFrame):
1786         (WebCore::DumpRenderTree::DumpRenderTree):
1787         (WebCore::DumpRenderTree::open):
1788         (WebCore::DumpRenderTree::readStdin):
1789         (WebCore::DumpRenderTree::initJSObjects):
1790         (WebCore::DumpRenderTree::dump):
1791         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1792         (WebCore::DumpRenderTree::layoutTestController):
1793         (WebCore::DumpRenderTree::eventSender):
1794         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1795         (LayoutTestController::LayoutTestController):
1796         (LayoutTestController::reset):
1797         (LayoutTestController::maybeDump):
1798         (LayoutTestController::waitUntilDone):
1799         (LayoutTestController::notifyDone):
1800         (LayoutTestController::queueReload):
1801         (LayoutTestController::provisionalLoad):
1802         (EventSender::EventSender):
1803         (EventSender::mouseDown):
1804         (EventSender::mouseUp):
1805         (EventSender::mouseMoveTo):
1806         (EventSender::frameUnderMouse):
1807         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1808         (LayoutTestController::isLoading):
1809         (LayoutTestController::setLoading):
1810         (LayoutTestController::dumpAsText):
1811         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
1812         (main):
1813
1814 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1815
1816
1817         - Reverted an accidentally checked in file.
1818
1819         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
1820
1821 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1822         Reviewed by Sam.
1823
1824         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
1825
1826         * DumpRenderTree/win/DumpRenderTree.vcproj:
1827         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1828
1829 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1830
1831         Rubber stamped by Adam.
1832
1833         * GdkLauncher: Removed.
1834         * GdkLauncher/Bakefiles.bkgen: Removed.
1835         * GdkLauncher/ENV: Removed.
1836         * GdkLauncher/GdkLauncher.pro: Removed.
1837         * GdkLauncher/gdklauncher.bkl: Removed.
1838         * GdkLauncher/main.cpp: Removed.
1839         * GdkLauncher/mk: Removed.
1840         * GdkLauncher/simple.svg: Removed.
1841         * GdkLauncher/text.html: Removed.
1842         * GtkLauncher: Added.
1843         * GtkLauncher/GdkLauncher.pro: Removed.
1844         * GtkLauncher/GtkLauncher.pro: Added.
1845         * GtkLauncher/main.cpp:
1846         (updateWindowTitle):
1847         (main):
1848         * Scripts/build-webkit:
1849         * Scripts/regenerate-makefiles:
1850         * Scripts/run-javascriptcore-tests:
1851         * Scripts/run-launcher:
1852         * Scripts/run-webkit-tests:
1853         * Scripts/webkitdirs.pm:
1854
1855 2007-09-21  Timothy Hatcher  <timothy@apple.com>
1856
1857         Reviewed by Darin.
1858
1859         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
1860
1861         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
1862         This is tested by plugins/root-object-premature-delete-crash.html.
1863
1864         * DumpRenderTree/mac/ObjCController.m:
1865         (-[ObjCController accessStoredWebScriptObject]):
1866
1867 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
1868
1869         Reviewed by Oliver.
1870
1871         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
1872
1873         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1874         (FrameLoadDelegate::FrameLoadDelegate):
1875
1876 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
1877
1878         Reviewed by Adam.
1879
1880         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
1881         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
1882
1883         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
1884         Now isQt() and isGdk() use global variables that are only set once.
1885
1886         An array of all the parameters is now given to build-dumprender which includes
1887         the platform on linux.
1888
1889         * Scripts/build-dumprendertree:
1890         * Scripts/run-webkit-tests:
1891         * Scripts/webkitdirs.pm:
1892
1893 2007-09-19  Adam Roben  <aroben@apple.com>
1894
1895         Rubberstamped by Hyatt.
1896
1897         * Spinneret: Removed.
1898
1899 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
1900
1901         Reviewed by David Kilzer.
1902
1903         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
1904
1905 2007-09-18  Sam Weinig  <sam@webkit.org>
1906
1907         Add JSRetainPtr.h #include to fix some builds.
1908
1909         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1910
1911 2007-09-18  Mike Hommey  <glandium@debian.org>
1912
1913         Reviewed by Adam.
1914
1915         * Scripts/prepare-ChangeLog:
1916         - Properly parse GECOS field.
1917         - Use git configuration for user name and email when appropriate.
1918
1919 2007-09-17  Sam Weinig  <sam@webkit.org>
1920
1921         Build fix.
1922
1923         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1924
1925 2007-09-17  Sam Weinig  <sam@webkit.org>
1926
1927         Reviewed by Adam Roben.
1928
1929         Share more code between mac and windows DRT.
1930             - GCController is now shared.
1931             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
1932
1933         * DumpRenderTree/GCController.cpp:
1934         * DumpRenderTree/win/DumpRenderTree.cpp:
1935         * DumpRenderTree/win/DumpRenderTree.vcproj:
1936         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
1937         (FrameLoadDelegate::FrameLoadDelegate):
1938         (FrameLoadDelegate::~FrameLoadDelegate):
1939         (FrameLoadDelegate::windowScriptObjectAvailable):
1940         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
1941         * DumpRenderTree/win/GCController.cpp: Removed.
1942         * DumpRenderTree/win/GCController.h: Removed.
1943         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
1944         (GCController::collect):
1945         (GCController::collectOnAlternateThread):
1946         (GCController::getJSObjectCount):
1947         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
1948         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
1949
1950 2007-09-17  Sam Weinig  <sam@webkit.org>
1951
1952         Reviewed by Adam Roben.
1953
1954         Begin sharing code between mac and windows DRT.
1955             - both now share LayoutTestController.h/cpp and implement platform dependant
1956               operations in LayoutTestControllerMac/Win.
1957             - DumpRenderTree.h is now shared.
1958             - WorkQueue and WorkQueueItem are also shared.
1959
1960         * DumpRenderTree/DumpRenderTree.h:
1961         * DumpRenderTree/LayoutTestController.cpp:
1962         * DumpRenderTree/win/DumpRenderTree.cpp:
1963         (displayWebView):
1964         (dumpFrameScrollPosition):
1965         (dumpFramesAsText):
1966         (dump):
1967         (runTest):
1968         * DumpRenderTree/win/DumpRenderTree.h: Removed.
1969         * DumpRenderTree/win/DumpRenderTree.vcproj:
1970         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
1971         * DumpRenderTree/win/EditingDelegate.cpp:
1972         (EditingDelegate::shouldBeginEditingInDOMRange):
1973         (EditingDelegate::shouldEndEditingInDOMRange):
1974         (EditingDelegate::shouldInsertNode):
1975         (EditingDelegate::shouldInsertText):
1976         (EditingDelegate::shouldDeleteDOMRange):
1977         (EditingDelegate::shouldChangeSelectedDOMRange):
1978         (EditingDelegate::shouldApplyStyle):
1979         (EditingDelegate::shouldChangeTypingStyle):
1980         (EditingDelegate::doPlatformCommand):
1981         (EditingDelegate::webViewDidBeginEditing):
1982         (EditingDelegate::webViewDidChange):
1983         (EditingDelegate::webViewDidEndEditing):
1984         (EditingDelegate::webViewDidChangeTypingStyle):
1985         (EditingDelegate::webViewDidChangeSelection):
1986         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
1987         * DumpRenderTree/win/LayoutTestController.h: Removed.
1988         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
1989         (LayoutTestController::addDisallowedURL):
1990         (LayoutTestController::clearBackForwardList):
1991         (LayoutTestController::copyDecodedHostName):
1992         (LayoutTestController::copyEncodedHostName):
1993         (LayoutTestController::display):
1994         (LayoutTestController::keepWebHistory):
1995         (LayoutTestController::notifyDone):
1996         (LayoutTestController::queueBackNavigation):
1997         (LayoutTestController::queueForwardNavigation):
1998         (jsStringRefToWString):
1999         (LayoutTestController::queueLoad):
2000         (LayoutTestController::queueReload):
2001         (LayoutTestController::queueScript):
2002         (LayoutTestController::setAcceptsEditing):
2003         (LayoutTestController::setCustomPolicyDelegate):
2004         (LayoutTestController::setMainFrameIsFirstResponder):
2005         (LayoutTestController::setTabKeyCyclesThroughElements):
2006         (LayoutTestController::setUseDashboardCompatibilityMode):
2007         (LayoutTestController::setUserStyleSheetEnabled):
2008         (LayoutTestController::setUserStyleSheetLocation):
2009         (LayoutTestController::setWindowIsKey):
2010         (waitUntilDoneWatchdogFired):
2011         (LayoutTestController::setWaitToDump):
2012         (LayoutTestController::windowCount):
2013         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2014         (FrameLoadDelegate::didReceiveTitle):
2015         (FrameLoadDelegate::processWork):
2016         (FrameLoadDelegate::locationChangeDone):
2017         (FrameLoadDelegate::windowScriptObjectAvailable):
2018         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2019         * DumpRenderTree/win/WorkQueue.h: Removed.
2020         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2021         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2022         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2023         (jsStringRefToWString):
2024         (LoadItem::invoke):
2025         (ScriptItem::invoke):
2026
2027 2007-09-17  Sam Weinig  <sam@webkit.org>
2028
2029         Reviewed by Adam Roben.
2030
2031         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2032
2033         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2034         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2035         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2036         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2037         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2038         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2039         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2040         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2041         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2042         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2043         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2044         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2045         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2046         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2047         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2048         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2049         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2050         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2051         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2052         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2053         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2054         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2055         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2056         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2057         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2058         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2059         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2060         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2061         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2062         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2063         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2064         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2065         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2066         * DumpRenderTree/win: Added.
2067         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2068         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2069         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2070         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2071         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2072         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2073         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2074         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2075         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2076         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2077         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2078         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2079         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2080         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2081         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2082         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2083         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2084         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2085         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2086         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2087         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2088         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2089         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2090         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2091         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2092         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2093
2094 2007-09-15  Mark Rowe  <mrowe@apple.com>
2095
2096         Build fix for DumpRenderTree.
2097
2098         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2099
2100 2007-09-14  Sam Weinig  <sam@webkit.org>
2101
2102         Rubber stamped by Adam Roben.
2103
2104         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2105           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2106             kept in the WaitUntilDoneDelegate file for the time being.
2107
2108         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2109         (main):
2110         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2111         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2112         (UIDelegate::QueryInterface):
2113         (UIDelegate::AddRef):
2114         (UIDelegate::Release):
2115         (UIDelegate::hasCustomMenuImplementation):
2116         (UIDelegate::setFrame):
2117         (UIDelegate::webViewFrame):
2118         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2119         (UIDelegate::webViewAddMessageToConsole):
2120         (UIDelegate::doDragDrop):
2121         (UIDelegate::webViewGetDlgCode):
2122         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2123         (UIDelegate::UIDelegate):
2124         (UIDelegate::createWebViewWithRequest):
2125         (UIDelegate::webViewShow):
2126         (UIDelegate::webViewClose):
2127         (UIDelegate::webViewFocus):
2128         (UIDelegate::webViewUnfocus):
2129         (UIDelegate::webViewFirstResponder):
2130         (UIDelegate::makeFirstResponder):
2131         (UIDelegate::setStatusText):
2132         (UIDelegate::webViewStatusText):
2133         (UIDelegate::webViewAreToolbarsVisible):
2134         (UIDelegate::setToolbarsVisible):
2135         (UIDelegate::webViewIsStatusBarVisible):
2136         (UIDelegate::setStatusBarVisible):
2137         (UIDelegate::webViewIsResizable):
2138         (UIDelegate::setResizable):
2139         (UIDelegate::setContentRect):
2140         (UIDelegate::webViewContentRect):
2141         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2142         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2143         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2144         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2145         (UIDelegate::mouseDidMoveOverElement):
2146         (UIDelegate::contextMenuItemsForElement):
2147         (UIDelegate::validateUserInterfaceItem):
2148         (UIDelegate::shouldPerformAction):
2149         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2150         (UIDelegate::willPerformDragDestinationAction):
2151         (UIDelegate::dragSourceActionMaskForPoint):
2152         (UIDelegate::willPerformDragSourceAction):
2153         (UIDelegate::contextMenuItemSelected):
2154         (UIDelegate::trackCustomPopupMenu):
2155         (UIDelegate::measureCustomMenuItem):
2156         (UIDelegate::drawCustomMenuItem):
2157         (UIDelegate::addCustomMenuDrawingData):
2158         (UIDelegate::cleanUpCustomMenuDrawingData):
2159         (UIDelegate::canTakeFocus):
2160         (UIDelegate::takeFocus):
2161         (UIDelegate::registerUndoWithTarget):
2162         (UIDelegate::removeAllActionsWithTarget):
2163         (UIDelegate::setActionTitle):
2164         (UIDelegate::undo):
2165         (UIDelegate::redo):
2166         (UIDelegate::canUndo):
2167         (UIDelegate::canRedo):
2168         (UIDelegate::webViewResizerRect):
2169         (UIDelegate::webViewDrawResizer):
2170         (UIDelegate::webViewScrolled):
2171         (UIDelegate::webViewShouldInterruptJavaScript):
2172         (UIDelegate::webViewReceivedFocus):
2173         (UIDelegate::webViewLostFocus):
2174         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2175         (FrameLoadDelegate::QueryInterface):
2176         (FrameLoadDelegate::AddRef):
2177         (FrameLoadDelegate::Release):
2178         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2179         (FrameLoadDelegate::didCommitLoadForFrame):
2180         (FrameLoadDelegate::didReceiveTitle):
2181         (FrameLoadDelegate::processWork):
2182         (processWorkTimer):
2183         (FrameLoadDelegate::locationChangeDone):
2184         (FrameLoadDelegate::didFinishLoadForFrame):
2185         (FrameLoadDelegate::didFailLoadWithError):
2186         (FrameLoadDelegate::windowScriptObjectAvailable):
2187         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2188         (FrameLoadDelegate::FrameLoadDelegate):
2189
2190 2007-09-14  Sam Weinig  <sam@webkit.org>
2191
2192         Reviewed by Kevin McCullough.
2193
2194         Move mac specific globals in to mac/DumpRenderTreeMac.h
2195
2196         * DumpRenderTree/DumpRenderTree.h:
2197         * DumpRenderTree/DumpRenderTree.mm: Removed.
2198         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2199         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2200         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2201
2202 2007-09-14  Brady Eidson  <beidson@apple.com>
2203
2204         Rubberstamped by Weinig
2205
2206         You know, Sam, some of us use case-sensitve filesystems...
2207
2208         * DumpRenderTree/DumpRenderTree.h:
2209         * DumpRenderTree/mac/UIDelegate.mm:
2210
2211 2007-09-14  Sam Weinig  <sam@webkit.org>
2212
2213         Rubber stamped by Adam Roben.
2214
2215         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2216         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2217
2218         * DumpRenderTree/AppleScriptController.h: Removed.
2219         * DumpRenderTree/AppleScriptController.m: Removed.
2220         * DumpRenderTree/DumpRenderTree.h:
2221         * DumpRenderTree/DumpRenderTree.mm:
2222         (startJavaScriptThreads):
2223         (stopJavaScriptThreads):
2224         (activateAhemFont):
2225         (setDefaultColorProfileToRGB):
2226         (makeLargeMallocFailSilently):
2227         (dumpFrameScrollPosition):
2228         (dumpFramesAsText):
2229         (dump):
2230         (runTest):
2231         (-[DumpRenderTreeWindow isKeyWindow]):
2232         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2233         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2234         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2235         * DumpRenderTree/EditingDelegate.h: Removed.
2236         * DumpRenderTree/EditingDelegate.m: Removed.
2237         * DumpRenderTree/EventSendingController.h: Removed.
2238         * DumpRenderTree/EventSendingController.m: Removed.
2239         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2240         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2241         * DumpRenderTree/GCController.mm: Removed.
2242         * DumpRenderTree/ImageDiff.m: Removed.
2243         * DumpRenderTree/LayoutTestController.cpp:
2244         (LayoutTestController::LayoutTestController):
2245         (dumpAsTextCallback):
2246         (dumpBackForwardListCallback):
2247         (dumpChildFramesAsTextCallback):
2248         (dumpChildFrameScrollPositionsCallback):
2249         (dumpDOMAsWebArchiveCallback):
2250         (dumpEditingCallbacksCallback):
2251         (dumpFrameLoadCallbacksCallback):
2252         (dumpResourceLoadCallbacksCallback):
2253         (dumpSelectionRectCallback):
2254         (dumpSourceAsWebArchiveCallback):
2255         (dumpTitleChangesCallback):
2256         (repaintSweepHorizontallyCallback):
2257         (setCallCloseOnWebViewsCallback):
2258         (setCanOpenWindowsCallback):
2259         (setCloseRemainingWindowsWhenCompleteCallback):
2260         (testRepaintCallback):
2261         (addFileToPasteboardOnDragCallback):
2262         (waitUntilDoneCallback):
2263         * DumpRenderTree/LayoutTestController.h:
2264         (LayoutTestController::dumpAsText):
2265         (LayoutTestController::setDumpAsText):
2266         (LayoutTestController::dumpBackForwardList):
2267         (LayoutTestController::setDumpBackForwardList):
2268         (LayoutTestController::dumpChildFrameScrollPositions):
2269         (LayoutTestController::setDumpChildFrameScrollPositions):
2270         (LayoutTestController::dumpChildFramesAsText):
2271         (LayoutTestController::setDumpChildFramesAsText):
2272         (LayoutTestController::dumpDOMAsWebArchive):
2273         (LayoutTestController::setDumpDOMAsWebArchive):
2274         (LayoutTestController::dumpSelectionRect):
2275         (LayoutTestController::setDumpSelectionRect):
2276         (LayoutTestController::dumpSourceAsWebArchive):
2277         (LayoutTestController::setDumpSourceAsWebArchive):
2278         (LayoutTestController::dumpTitleChanges):
2279         (LayoutTestController::setDumpTitleChanges):
2280         (LayoutTestController::dumpEditingCallbacks):
2281         (LayoutTestController::setDumpEditingCallbacks):
2282         (LayoutTestController::dumpResourceLoadCallbacks):
2283         (LayoutTestController::setDumpResourceLoadCallbacks):
2284         (LayoutTestController::dumpFrameLoadCallbacks):
2285         (LayoutTestController::setDumpFrameLoadCallbacks):
2286         (LayoutTestController::addFileToPasteboardOnDrag):
2287         (LayoutTestController::setAddFileToPasteboardOnDrag):
2288         (LayoutTestController::callCloseOnWebViews):
2289         (LayoutTestController::setCallCloseOnWebViews):
2290         (LayoutTestController::canOpenWindows):
2291         (LayoutTestController::setCanOpenWindows):
2292         (LayoutTestController::closeRemainingWindowsWhenComplete):
2293         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2294         (LayoutTestController::testRepaint):
2295         (LayoutTestController::setTestRepaint):
2296         (LayoutTestController::testRepaintSweepHorizontally):
2297         (LayoutTestController::setTestRepaintSweepHorizontally):
2298         (LayoutTestController::waitToDump):
2299         (LayoutTestController::windowIsKey):
2300         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2301         * DumpRenderTree/NavigationController.h: Removed.
2302         * DumpRenderTree/NavigationController.m: Removed.
2303         * DumpRenderTree/ObjCController.h: Removed.
2304         * DumpRenderTree/ObjCController.m: Removed.
2305         * DumpRenderTree/ObjCPlugin.h: Removed.
2306         * DumpRenderTree/ObjCPlugin.m: Removed.
2307         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2308         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2309         * DumpRenderTree/PolicyDelegate.h: Removed.
2310         * DumpRenderTree/PolicyDelegate.m: Removed.
2311         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2312         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2313         * DumpRenderTree/TextInputController.h: Removed.
2314         * DumpRenderTree/TextInputController.m: Removed.
2315         * DumpRenderTree/UIDelegate.h: Removed.
2316         * DumpRenderTree/UIDelegate.mm: Removed.
2317         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2318         * DumpRenderTree/mac: Added.
2319         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2320         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2321         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2322         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2323         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2324         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2325         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2326         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2327         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2328         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2329         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2330         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2331         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2332         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2333         (-[EditingDelegate webViewDidBeginEditing:]):
2334         (-[EditingDelegate webViewDidChange:]):
2335         (-[EditingDelegate webViewDidEndEditing:]):
2336         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2337         (-[EditingDelegate webViewDidChangeSelection:]):
2338         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2339         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2340         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2341         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2342         (-[FrameLoadDelegate init]):
2343         (-[FrameLoadDelegate dealloc]):
2344         (-[FrameLoadDelegate processWork:]):
2345         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2346         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2347         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2348         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2349         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2350         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2351         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2352         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2353         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2354         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2355         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2356         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2357         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2358         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2359         (-[FrameLoadDelegate webView:willCloseFrame:]):
2360         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2361         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2362         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2363         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2364         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2365         (LayoutTestController::notifyDone):
2366         (LayoutTestController::setWindowIsKey):
2367         (LayoutTestController::setWaitToDump):
2368         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2369         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2370         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2371         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2372         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2373         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2374         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2375         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2376         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2377         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2378         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2379         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2380         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2381         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2382         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2383         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2384         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2385         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2386         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2387         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2388         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2389         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2390         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2391         (-[UIDelegate webViewFocus:]):
2392         (-[UIDelegate webView:createWebViewWithRequest:]):
2393         (-[UIDelegate webViewClose:]):
2394         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2395
2396 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2397
2398         Reviewed by Adam.
2399
2400         - Changing Win version of Drosera work with recent changes.
2401
2402         * Drosera/DebuggerDocument.cpp:
2403         * Drosera/DebuggerDocument.h:
2404         * Drosera/mac/DebuggerDocumentPlatform.mm:
2405         (NSStringCreateWithJSStringRef):
2406         (JSValueRefCreateWithNSString):
2407         * Drosera/win/DebuggerClient.cpp:
2408         (DebuggerClient::stepInto):
2409         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2410
2411 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2412
2413         Reviewed by Tim.
2414
2415         - Moved isPaused into the JS for efficiency and simplicity.
2416
2417         * Drosera/DebuggerDocument.cpp:
2418         (DebuggerDocument::DebuggerDocument):
2419         (DebuggerDocument::pauseCallback):
2420         (DebuggerDocument::resumeCallback):
2421         (DebuggerDocument::isPaused):
2422         (DebuggerDocument::staticFunctions):
2423         * Drosera/DebuggerDocument.h:
2424         * Drosera/console.js:
2425         * Drosera/debugger.js:
2426         * Drosera/mac/DebuggerClient.mm:
2427         (-[DebuggerClient validateUserInterfaceItem:]):
2428
2429 2007-09-13  Sam Weinig  <sam@webkit.org>
2430
2431         Rubber stamped by Darin.
2432
2433         Make DumpRenderTree more cross platform ready.
2434         - Convert GCController to use the JSCore API instead of the WebScriptObject.
2435         - Use CF types instead of NS objects.
2436         - General cleanup.
2437
2438         * DumpRenderTree/DumpRenderTree.h:
2439         * DumpRenderTree/DumpRenderTree.mm:
2440         (dumpRenderTree):
2441         (dump):
2442         (runTest):
2443         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2444         * DumpRenderTree/EditingDelegate.m:
2445         * DumpRenderTree/FrameLoadDelegate.h:
2446         * DumpRenderTree/FrameLoadDelegate.mm:
2447         (-[FrameLoadDelegate init]):
2448         (-[FrameLoadDelegate dealloc]):
2449         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2450         * DumpRenderTree/GCController.cpp: Added.
2451         (GCController::GCController):
2452         (GCController::~GCController):
2453         (collectCallback):
2454         (collectOnAlternateThreadCallback):
2455         (getJSObjectCountCallback):
2456         (GCController::makeWindowObject):
2457         (GCController::getJSClass):
2458         (GCController::staticFunctions):
2459         * DumpRenderTree/GCController.h:
2460         * DumpRenderTree/GCController.mm:
2461         (GCController::collect):
2462         (GCController::collectOnAlternateThread):
2463         (GCController::getJSObjectCount):
2464         * DumpRenderTree/LayoutTestController.cpp:
2465         (LayoutTestController::makeWindowObject):
2466         (LayoutTestController::getJSClass):
2467         * DumpRenderTree/LayoutTestController.h:
2468         * DumpRenderTree/LayoutTestControllerMac.mm:
2469         (LayoutTestController::addDisallowedURL):
2470         (waitUntilDoneWatchdogFired):
2471         (LayoutTestController::waitUntilDone):
2472         * DumpRenderTree/ResourceLoadDelegate.m:
2473         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2474
2475 2007-09-12  Sam Weinig  <sam@webkit.org>
2476
2477         Reviewed by Stephanie.
2478
2479         Fix leaks in mac DumpRenderTree.
2480
2481         * DumpRenderTree/FrameLoadDelegate.mm:
2482         (-[FrameLoadDelegate init]): Initalize in the correct order.
2483         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
2484         * DumpRenderTree/LayoutTestController.cpp:
2485         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
2486         (encodeHostNameCallback): ditto.
2487         * DumpRenderTree/LayoutTestController.h:
2488         * DumpRenderTree/LayoutTestControllerMac.mm:
2489         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
2490         (LayoutTestController::copyEncodedHostName): ditto
2491         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
2492
2493 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2494
2495         Reviewed by Geof.
2496
2497         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
2498
2499         * Scripts/run-webkit-tests:
2500
2501 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2502
2503         Reviewed by Darin.
2504
2505         - Simplified code paths and extracted out functions to increase encapsulation.
2506
2507         * Drosera/DebuggerDocument.cpp:
2508         (DebuggerDocument::breakpointEditorHTMLCallback):
2509         (DebuggerDocument::isPausedCallback):
2510         (DebuggerDocument::pauseCallback):
2511         (DebuggerDocument::resumeCallback):
2512         (DebuggerDocument::stepIntoCallback):
2513         (DebuggerDocument::evaluateScriptCallback):
2514         (DebuggerDocument::currentFunctionStackCallback):
2515         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2516         (DebuggerDocument::valueForScopeVariableNamedCallback):
2517         (DebuggerDocument::logCallback):
2518         * Drosera/DebuggerDocument.h:
2519         (DebuggerDocument::getPaused):
2520         * Drosera/mac/DebuggerClient.mm:
2521         (-[DebuggerClient pause:]):
2522         (-[DebuggerClient resume:]):
2523         (-[DebuggerClient stepInto:]):
2524         (-[DebuggerClient stepOver:]):
2525         (-[DebuggerClient stepOut:]):
2526         (-[DebuggerClient showConsole:]):
2527         (-[DebuggerClient closeCurrentFile:]):
2528         (-[DebuggerClient validateUserInterfaceItem:]):
2529         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
2530         (+[NSString stringOrNilFromWebScriptResult:]):
2531         (DebuggerDocument::platformPause):
2532         (DebuggerDocument::platformResume):
2533         (DebuggerDocument::platformStepInto):
2534         (DebuggerDocument::platformEvaluateScript):
2535         (DebuggerDocument::getPlatformCurrentFunctionStack):
2536         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2537         (DebuggerDocument::platformValueForScopeVariableNamed):
2538         (DebuggerDocument::platformLog):
2539         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2540
2541 2007-09-12  Sam Weinig  <sam@webkit.org>
2542
2543         Build fix for Buildbot.
2544
2545         * DumpRenderTree/DumpRenderTree.mm:
2546         (dump):
2547
2548 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2549
2550         Reviewed by Geoff.
2551
2552         - Updated the leaks list for leopard to help identify regressions.
2553
2554         * Scripts/run-webkit-tests:
2555
2556 2007-09-12  Sam Weinig  <sam@webkit.org>
2557
2558         Rubber stamped by Darin.
2559
2560         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
2561
2562         * DumpRenderTree/DumpRenderTree.h: Re-order variables.
2563         * DumpRenderTree/DumpRenderTree.m: Removed.
2564         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
2565         (stopJavaScriptThreads): Fix initialization.
2566         (setDefaultColorProfileToRGB): Add explicit cast from void*.
2567         (dumpRenderTree): Ditto.
2568         (runTest):
2569         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
2570
2571         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2572         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
2573         * DumpRenderTree/FrameLoadDelegate.m: Removed.
2574         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
2575         (-[FrameLoadDelegate init]):
2576         (-[FrameLoadDelegate dealloc]):
2577         (-[FrameLoadDelegate processWork:]):
2578         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2579         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2580         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
2581
2582         * DumpRenderTree/LayoutTestController.cpp: Added.
2583         (LayoutTestController::LayoutTestController):
2584         (LayoutTestController::~LayoutTestController):
2585         (dumpAsTextCallback):
2586         (dumpBackForwardListCallback):
2587         (dumpChildFramesAsTextCallback):
2588         (dumpChildFrameScrollPositionsCallback):
2589         (dumpDOMAsWebArchiveCallback):
2590         (dumpEditingCallbacksCallback):
2591         (dumpFrameLoadCallbacksCallback):
2592         (dumpResourceLoadCallbacksCallback):
2593         (dumpSelectionRectCallback):
2594         (dumpSourceAsWebArchiveCallback):
2595         (dumpTitleChangesCallback):
2596         (repaintSweepHorizontallyCallback):
2597         (setCallCloseOnWebViewsCallback):
2598         (setCanOpenWindowsCallback):
2599         (setCloseRemainingWindowsWhenCompleteCallback):
2600         (testRepaintCallback):
2601         (addFileToPasteboardOnDragCallback):
2602         (addDisallowedURLCallback):
2603         (clearBackForwardListCallback):
2604         (decodeHostNameCallback):
2605         (displayCallback):
2606         (encodeHostNameCallback):
2607         (keepWebHistoryCallback):
2608         (notifyDoneCallback):
2609         (queueBackNavigationCallback):
2610         (queueForwardNavigationCallback):
2611         (queueLoadCallback):
2612         (queueReloadCallback):
2613         (queueScriptCallback):
2614         (setAcceptsEditingCallback):
2615         (setCustomPolicyDelegateCallback):
2616         (setMainFrameIsFirstResponderCallback):
2617         (setTabKeyCyclesThroughElementsCallback):
2618         (setUseDashboardCompatibilityModeCallback):
2619         (setUserStyleSheetEnabledCallback):
2620         (setUserStyleSheetLocationCallback):
2621         (setWindowIsKeyCallback):
2622         (waitUntilDoneCallback):
2623         (windowCountCallback):
2624         (LayoutTestController::makeWindowObject):
2625         (LayoutTestController::getLayoutTestControllerJSClass):
2626         (LayoutTestController::staticFunctions):
2627         * DumpRenderTree/LayoutTestController.h: Replaced.
2628         * DumpRenderTree/LayoutTestController.m: Removed.
2629         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
2630         (LayoutTestController::dumpAsText):
2631         (LayoutTestController::dumpBackForwardList):
2632         (LayoutTestController::dumpChildFramesAsText):
2633         (LayoutTestController::dumpChildFrameScrollPositions):
2634         (LayoutTestController::dumpDOMAsWebArchive):
2635         (LayoutTestController::dumpEditingCallbacks):
2636         (LayoutTestController::dumpFrameLoadCallbacks):
2637         (LayoutTestController::dumpResourceLoadCallbacks):
2638         (LayoutTestController::dumpSelectionRect):
2639         (LayoutTestController::dumpSourceAsWebArchive):
2640         (LayoutTestController::dumpTitleChanges):
2641         (LayoutTestController::repaintSweepHorizontally):
2642         (LayoutTestController::setCallCloseOnWebViews):
2643         (LayoutTestController::setCanOpenWindows):
2644         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2645         (LayoutTestController::testRepaint):
2646         (LayoutTestController::addFileToPasteboardOnDrag):
2647         (LayoutTestController::addDisallowedURL):
2648         (LayoutTestController::clearBackForwardList):
2649         (LayoutTestController::decodeHostName):
2650         (LayoutTestController::encodeHostName):
2651         (LayoutTestController::display):
2652         (LayoutTestController::keepWebHistory):
2653         (LayoutTestController::notifyDone):
2654         (LayoutTestController::queueBackNavigation):
2655         (LayoutTestController::queueForwardNavigation):
2656         (LayoutTestController::queueLoad):
2657         (LayoutTestController::queueReload):
2658         (LayoutTestController::queueScript):
2659         (LayoutTestController::setAcceptsEditing):
2660         (LayoutTestController::setCustomPolicyDelegate):
2661         (LayoutTestController::setMainFrameIsFirstResponder):
2662         (LayoutTestController::setTabKeyCyclesThroughElements):
2663         (LayoutTestController::setUseDashboardCompatibilityMode):
2664         (LayoutTestController::setUserStyleSheetEnabled):
2665         (LayoutTestController::setUserStyleSheetLocation):
2666         (LayoutTestController::setWindowIsKey):
2667         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
2668         (LayoutTestController::waitUntilDone):
2669         (LayoutTestController::windowCount):
2670         Use the JSCore API to implement the LayoutTestController.
2671
2672         * DumpRenderTree/ObjCController.h:
2673         * DumpRenderTree/ObjCController.m:
2674         (+[ObjCController isSelectorExcludedFromWebScript:]):
2675         (+[ObjCController webScriptNameForSelector:]):
2676         (-[ObjCController accessStoredWebScriptObject]):
2677         (-[ObjCController storeWebScriptObject:]):
2678         (-[ObjCController dealloc]):
2679         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
2680         Move WebScriptObject tests to ObjCController.
2681
2682         * DumpRenderTree/UIDelegate.m: Removed.
2683         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
2684
2685         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2686         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2687         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2688         (WorkQueueItem::~WorkQueueItem):
2689         (LoadItem::LoadItem):
2690         (LoadItem::url):
2691         (LoadItem::target):
2692         (ScriptItem::ScriptItem):
2693         (ScriptItem::script):
2694         * DumpRenderTree/WorkQueueItemMac.mm: Added.
2695         (LoadItem::invoke):
2696         (ReloadItem::invoke):
2697         (ScriptItem::invoke):
2698         (BackForwardItem::invoke):
2699         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
2700         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
2701         sharing code.
2702
2703 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2704
2705         Reviewed by Maciej.
2706
2707         - Updated Win side to take advantage of the platform separating changes.
2708
2709         * Drosera/DebuggerDocument.cpp:
2710         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2711         * Drosera/DebuggerDocument.h:
2712         * Drosera/win/DebuggerClient.cpp:
2713         (DebuggerClient::pause):
2714         (DebuggerClient::resume):
2715         (DebuggerClient::stepInto):
2716         (DebuggerDocument::platformPause):
2717         (DebuggerDocument::platformResume):
2718         (DebuggerDocument::platformStepInto):
2719         (DebuggerDocument::platformEvaluateScript):
2720         (DebuggerDocument::getPlatformCurrentFunctionStack):
2721         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2722         (DebuggerDocument::platformValueForScopeVariableNamed):
2723         (DebuggerDocument::platformLog):
2724         * Drosera/win/DebuggerClient.h:
2725         * Drosera/win/Drosera.cpp:
2726         (Drosera::Drosera):
2727         (Drosera::windowScriptObjectAvailable):
2728         (Drosera::initWithServerName):
2729         (Drosera::switchToServerNamed):
2730         * Drosera/win/Drosera.h:
2731         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2732
2733 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2734
2735         Reviewed by Adam.
2736
2737         - Just doing the moves in a separate patch so the changes are easier to see.
2738
2739         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
2740         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
2741         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
2742         * Drosera/win/DebuggerDocumentWin.h: Removed.
2743         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2744
2745 2007-09-11  Sven Herzberg  <sven@imendio.com>
2746
2747         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
2748         http://bugs.webkit.org/show_bug.cgi?id=15176
2749
2750         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
2751         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
2752         other paths eg. from jhbuild)
2753
2754 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2755
2756         Reviewed by Adam.
2757
2758         - Made an order-of-deletion mistake.
2759
2760         * Drosera/DebuggerDocument.h:
2761         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
2762         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
2763         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
2764         * Drosera/mac/DebuggerClient.mm:
2765         (DebuggerDocument::platformPause):
2766         (DebuggerDocument::platformResume):
2767         (DebuggerDocument::platformStepInto):
2768         (DebuggerDocument::platformEvaluateScript):
2769         (DebuggerDocument::getPlatformCurrentFunctionStack):
2770         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2771         (DebuggerDocument::platformValueForScopeVariableNamed):
2772         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2773
2774 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2775
2776         Reviewed by Darin.
2777
2778         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
2779
2780         * Drosera/DebuggerDocument.cpp:
2781         (DebuggerDocument::DebuggerDocument):
2782         * Drosera/DebuggerDocument.h:
2783         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2784         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2785         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2786         * Drosera/mac/DebuggerApplication.mm:
2787         (-[DebuggerApplication attach:]):
2788         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
2789         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
2790         (DebuggerDocument::platformPause):
2791         (DebuggerDocument::platformResume):
2792         (DebuggerDocument::platformStepInto):
2793         (DebuggerDocument::platformEvaluateScript):
2794         (DebuggerDocument::getPlatformCurrentFunctionStack):
2795         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2796         (DebuggerDocument::platformValueForScopeVariableNamed):
2797         (DebuggerDocument::platformLog):
2798         * Drosera/mac/DebuggerDocumentMac.h: Removed.
2799         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
2800         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2801
2802 2007-09-09  Sam Weinig  <sam@webkit.org>
2803
2804         Reviewed by Mark Rowe.
2805
2806         Remove 'objC' prefix from methods now in the ObjCController.
2807
2808         * DumpRenderTree/ObjCController.m:
2809         (+[ObjCController isSelectorExcludedFromWebScript:]):
2810         (+[ObjCController webScriptNameForSelector:]):
2811         (-[ObjCController classNameOf:]):
2812         (-[ObjCController objectOfClass:]):
2813         (-[ObjCController identityIsEqual::]):
2814         (-[ObjCController longLongRoundTrip:]):
2815         (-[ObjCController unsignedLongLongRoundTrip:]):
2816
2817 2007-09-09  Sam Weinig  <sam@webkit.org>
2818
2819         Reviewed by Oliver.
2820
2821         Initial refactor of DumpRenderTree in preparation of making it more platform independent.
2822         - Move LayoutTestController into its own file.
2823         - Move Objective-C only functions on LayoutTestController into a new controller called the
2824           ObjCController.
2825
2826         * DumpRenderTree/DumpRenderTree.h:
2827         * DumpRenderTree/DumpRenderTree.m:
2828         (displayWebView):
2829         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2830         * DumpRenderTree/FrameLoadDelegate.m:
2831         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2832         * DumpRenderTree/LayoutTestController.h: Added.
2833         * DumpRenderTree/LayoutTestController.m: Added.
2834         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2835         (+[LayoutTestController webScriptNameForSelector:]):
2836         (-[LayoutTestController clearBackForwardList]):
2837         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
2838         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
2839         (-[LayoutTestController setCustomPolicyDelegate:]):
2840         (-[LayoutTestController keepWebHistory]):
2841         (-[LayoutTestController setCallCloseOnWebViews:]):
2842         (-[LayoutTestController setCanOpenWindows]):
2843         (-[LayoutTestController waitUntilDone]):
2844         (-[LayoutTestController waitUntilDoneWatchdogFired]):
2845         (-[LayoutTestController notifyDone]):
2846         (-[LayoutTestController dumpAsText]):
2847         (-[LayoutTestController addFileToPasteboardOnDrag]):
2848         (-[LayoutTestController addDisallowedURL:]):
2849         (-[LayoutTestController setUserStyleSheetLocation:]):
2850         (-[LayoutTestController setUserStyleSheetEnabled:]):
2851         (-[LayoutTestController dumpDOMAsWebArchive]):
2852         (-[LayoutTestController dumpSourceAsWebArchive]):
2853         (-[LayoutTestController dumpSelectionRect]):
2854         (-[LayoutTestController dumpTitleChanges]):
2855         (-[LayoutTestController dumpBackForwardList]):
2856         (-[LayoutTestController windowCount]):
2857         (-[LayoutTestController dumpChildFrameScrollPositions]):
2858         (-[LayoutTestController dumpChildFramesAsText]):
2859         (-[LayoutTestController dumpEditingCallbacks]):
2860         (-[LayoutTestController dumpResourceLoadCallbacks]):
2861         (-[LayoutTestController dumpFrameLoadCallbacks]):
2862         (-[LayoutTestController setWindowIsKey:]):
2863         (-[LayoutTestController setMainFrameIsFirstResponder:]):
2864         (-[LayoutTestController display]):
2865         (-[LayoutTestController testRepaint]):
2866         (-[LayoutTestController repaintSweepHorizontally]):
2867         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
2868         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
2869         (-[LayoutTestController _doLoad:target:]):
2870         (-[LayoutTestController _doBackOrForwardNavigation:]):
2871         (-[LayoutTestController queueBackNavigation:]):
2872         (-[LayoutTestController queueForwardNavigation:]):
2873         (-[LayoutTestController queueReload]):
2874         (-[LayoutTestController queueScript:]):
2875         (-[LayoutTestController queueLoad:target:]):
2876         (-[LayoutTestController setAcceptsEditing:]):
2877         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
2878         (-[LayoutTestController storeWebScriptObject:]):
2879         (-[LayoutTestController accessStoredWebScriptObject]):
2880         (-[LayoutTestController dealloc]):
2881         (-[LayoutTestController decodeHostName:]):
2882         (-[LayoutTestController encodeHostName:]):
2883         * DumpRenderTree/ObjCController.h: Added.
2884         * DumpRenderTree/ObjCController.m: Added.
2885         (+[ObjCController isSelectorExcludedFromWebScript:]):
2886         (+[ObjCController webScriptNameForSelector:]):
2887         (-[ObjCController objCClassNameOf:]):
2888         (-[ObjCController objCObjectOfClass:]):
2889         (-[ObjCController objCIdentityIsEqual::]):
2890         (-[ObjCController objCLongLongRoundTrip:]):
2891         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
2892         (-[ObjCController testWrapperRoundTripping:]):
2893
2894 2007-09-07  Sam Weinig  <sam@webkit.org>
2895
2896         Reviewed by Alice.
2897
2898         Strip trailing and leading space/newline characters from skiplist file names.
2899
2900         * Scripts/run-webkit-tests:
2901
2902 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
2903
2904         Reviewed by Maciej.
2905
2906         - Changed Drosera to take advantage of the JSRetainPtr changes.
2907
2908         * Drosera/DebuggerDocument.cpp:
2909         (DebuggerDocument::breakpointEditorHTML):
2910         (DebuggerDocument::evaluateScript):
2911         (DebuggerDocument::valueForScopeVariableNamed):
2912         (DebuggerDocument::log):
2913         (DebuggerDocument::windowScriptObjectAvailable):
2914         (DebuggerDocument::toJSArray):
2915         (DebuggerDocument::callFunctionOnObject):
2916         (DebuggerDocument::logException):
2917         * Drosera/mac/DebuggerDocumentMac.mm:
2918         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
2919         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2920         (DebuggerDocument::platformEvaluateScript):
2921         (DebuggerDocument::getPlatformCurrentFunctionStack):
2922         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2923         (DebuggerDocument::platformValueForScopeVariableNamed):
2924
2925 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
2926
2927         Reviewed by Adam, Sam, Darin.
2928
2929         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
2930
2931         * Drosera/Debugger.h: Added.
2932         * Drosera/DebuggerDocument.cpp:
2933         (DebuggerDocument::breakpointEditorHTMLCallback):
2934         (DebuggerDocument::isPausedCallback):
2935         (DebuggerDocument::pauseCallback):
2936         (DebuggerDocument::resumeCallback):
2937         (DebuggerDocument::stepIntoCallback):
2938         (DebuggerDocument::evaluateScriptCallback):
2939         (DebuggerDocument::currentFunctionStackCallback):
2940         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2941         (DebuggerDocument::valueForScopeVariableNamedCallback):
2942         (DebuggerDocument::logCallback):
2943         (DebuggerDocument::breakpointEditorHTML):
2944         (DebuggerDocument::isPaused):
2945         (DebuggerDocument::pause):
2946         (DebuggerDocument::resume):
2947         (DebuggerDocument::stepInto):
2948         (DebuggerDocument::evaluateScript):
2949         (DebuggerDocument::currentFunctionStack):
2950         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2951         (DebuggerDocument::valueForScopeVariableNamed):
2952         (DebuggerDocument::log):
2953         (DebuggerDocument::toolbarPause):
2954         (DebuggerDocument::toolbarResume):
2955         (DebuggerDocument::toolbarStepInto):
2956         (DebuggerDocument::toolbarStepOver):
2957         (DebuggerDocument::toolbarStepOut):
2958         (DebuggerDocument::toolbarShowConsole):
2959         (DebuggerDocument::toolbarCloseCurrentFile):
2960         (DebuggerDocument::updateFileSource):
2961         (DebuggerDocument::didParseScript):
2962         (DebuggerDocument::willExecuteStatement):
2963         (DebuggerDocument::didEnterCallFrame):
2964         (DebuggerDocument::willLeaveCallFrame):
2965         (DebuggerDocument::exceptionWasRaised):
2966         (DebuggerDocument::windowScriptObjectAvailable):
2967         (DebuggerDocument::toJSArray):
2968         (DebuggerDocument::callGlobalFunction):
2969         (DebuggerDocument::callFunctionOnObject):
2970         (DebuggerDocument::getDroseraJSClass):
2971         (DebuggerDocument::staticFunctions):
2972         (DebuggerDocument::logException):
2973         * Drosera/DebuggerDocument.h:
2974         (DebuggerDocument::DebuggerDocument):
2975         * Drosera/ForwardingHeaders: Added.
2976         * Drosera/ForwardingHeaders/wtf: Added.
2977         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
2978         * Drosera/config.h:
2979         * Drosera/console.html:
2980         * Drosera/console.js:
2981         * Drosera/debugger.js:
2982         * Drosera/mac/DebuggerApplication.mm:
2983         (-[DebuggerApplication attach:]):
2984         * Drosera/mac/DebuggerDocumentMac.h:
2985         * Drosera/mac/DebuggerDocumentMac.mm:
2986         (+[NSString stringOrNilFromWebScriptResult:]):
2987         (+[DebuggerClientMac log:]):
2988         (-[DebuggerClientMac initWithServerName:]):
2989         (-[DebuggerClientMac dealloc]):
2990         (-[DebuggerClientMac pause]):
2991         (-[DebuggerClientMac resume]):
2992         (-[DebuggerClientMac pause:]):
2993         (-[DebuggerClientMac resume:]):
2994         (-[DebuggerClientMac stepInto:]):
2995         (-[DebuggerClientMac stepOver:]):
2996         (-[DebuggerClientMac stepOut:]):
2997         (-[DebuggerClientMac showConsole:]):
2998         (-[DebuggerClientMac closeCurrentFile:]):
2999         (-[DebuggerClientMac validateUserInterfaceItem:]):
3000         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3001         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3002         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3003         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3004         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3005         (DebuggerDocument::platformPause):
3006         (DebuggerDocument::platformResume):
3007         (DebuggerDocument::platformStepInto):
3008         (DebuggerDocument::platformEvaluateScript):
3009         (DebuggerDocument::platformCurrentFunctionStack):
3010         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3011         (DebuggerDocument::platformValueForScopeVariableNamed):
3012         (DebuggerDocument::platformLog):
3013         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3014
3015 2007-09-06  Sam Weinig  <sam@webkit.org>
3016
3017         Reviewed by Adam Roben.
3018
3019         Register the WebKit DLL on initialization of the DumpRenderTree.
3020
3021         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3022         (initialize):
3023
3024 2007-09-05  Sam Weinig  <sam@webkit.org>
3025
3026         Reviewed by Oliver.
3027
3028         Fix many layout test failures caused by r25364.
3029         Set text size to standand size at the begining of each test matching the mac.
3030
3031         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3032         (runTest):
3033
3034 2007-09-04  Sam Weinig  <sam@webkit.org>
3035
3036         Reviewed by Adam.
3037
3038         Fix for <rdar://problem/5382277>
3039         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3040
3041         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3042         (textZoomInCallback):
3043         (textZoomOutCallback):
3044
3045 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3046
3047         Reviewed by Adam.
3048
3049         Added case-insensitivity to checks for adding regression tests.
3050
3051         * Scripts/prepare-ChangeLog:
3052         (generateFileList):
3053
3054 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3055
3056         Reviewed by Maciej.
3057
3058         Ignore files in /resources/ subdirectories when creating a list of added tests.
3059
3060         * Scripts/prepare-ChangeLog:
3061         (generateFileList):
3062
3063 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3064
3065         Reviewed by John.
3066
3067         - Removed Leopard leaks list since all of those radars were fixed.
3068
3069         * Scripts/run-webkit-tests:
3070
3071 2007-08-27  Adam Roben  <aroben@apple.com>
3072
3073         Rubberstamped by Mark.
3074
3075         * Scripts/pdevenv: Pass arguments along to devenv.com.
3076
3077 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3078
3079         Reviewed by Mark Rowe.
3080
3081         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3082
3083         * Scripts/prepare-ChangeLog:
3084         (changeLogDate): Added.
3085
3086 2007-08-24  Sam Weinig  <sam@webkit.org>
3087
3088         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3089
3090 2007-08-24  Sam Weinig  <sam@webkit.org>
3091
3092         Rubber-stamped by Adam Roben.
3093
3094         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3095
3096         Rename COM DOM bindings to use Deprecated prefix.
3097
3098         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3099         (dumpFramesAsText):
3100         (dump):
3101         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3102         (dumpPath):
3103         (dump):
3104         (EditingDelegate::shouldBeginEditingInDOMRange):
3105         (EditingDelegate::shouldEndEditingInDOMRange):
3106         (EditingDelegate::shouldInsertNode):
3107         (EditingDelegate::shouldInsertText):
3108         (EditingDelegate::shouldDeleteDOMRange):
3109         (EditingDelegate::shouldChangeSelectedDOMRange):
3110         (EditingDelegate::shouldApplyStyle):
3111         (EditingDelegate::shouldChangeTypingStyle):
3112         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3113
3114 2007-08-24  Oliver Hunt  <oliver@apple.com>
3115
3116         Reviewed by John H.
3117
3118         WebDataSource::response can legitimately have a null response, so we
3119         must check that case.
3120
3121         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3122         (queueLoadCallback):
3123
3124 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3125
3126         Reviewed by Darin and Adam.
3127
3128         - DumpRenderTree changes to allow testing for
3129           http://bugs.webkit.org/show_bug.cgi?id=11756
3130           REGRESSION: link targeting a frame in another window does not work
3131           <rdar://problem/5286420>
3132
3133         Use a frame group name for all WebViews created by DumpRenderTree to
3134         allow testing of cross-page frame lookup.
3135
3136         * DumpRenderTree/DumpRenderTree.m:
3137         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3138         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3139         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3140
3141 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3142
3143         Reviewed by Adam.
3144
3145         Quote the $sslCertificate path in case it contains a space.
3146
3147         * Scripts/run-webkit-httpd:
3148         * Scripts/run-webkit-tests:
3149
3150 2007-08-22  Oliver Hunt  <oliver@apple.com>
3151
3152         Reviewed by John and Adam.
3153
3154         WebDataSource::response can legitimately have a null response, so we
3155         must check that case.
3156
3157         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3158         (dump):
3159
3160 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3161
3162         Reviewed by Geof.
3163
3164         - Changing the usage to be more clear.
3165
3166         * Scripts/run-testkjs:
3167
3168 2007-08-20  John Sullivan  <sullivan@apple.com>
3169
3170         Reviewed by Adam Roben
3171
3172         * DumpRenderTree/DumpRenderTree.m:
3173         (runTest):
3174         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3175         in layout tests on Tiger and Leopard
3176
3177 2007-08-20  Adam Roben  <aroben@apple.com>
3178
3179         Put LayoutTests after all other ChangeLogs in commit logs
3180
3181         We use "~" to sort LayoutTests after all the other ChangeLogs because
3182         "~" is the last ASCII character (other than "DEL").
3183
3184         Reviewed by Sam.
3185
3186         * Scripts/commit-log-editor:
3187
3188 2007-08-20  Adam Roben  <aroben@apple.com>
3189
3190         Detect that DRT crashed even if a crash dialog is running
3191
3192         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3193         process is still running at this point, so run-webkit-tests wouldn't
3194         detect that DRT had crashed. We now record the crash in our SIGPIPE
3195         handler so that we know if DRT crashed even if the crash dialog is up.
3196
3197         Reviewed by Sam.
3198
3199         * Scripts/run-webkit-tests:
3200         (sub catch_pipe): Set the crashed bit.
3201         (sub openDumpTool): Reset the crashed bit.
3202         (sub dumpToolDidCrash): Check the crashed bit.
3203
3204 2007-08-20  Adam Roben  <aroben@apple.com>
3205
3206         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3207
3208         http://bugs.webkit.org/show_bug.cgi?id=15026
3209
3210         Reviewed by David Kilzer and Darin Adler.
3211
3212         * Scripts/prepare-ChangeLog:
3213         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3214         (sub isAddedStatus): Ditto.
3215         (sub testListForChangeLog): Added.
3216
3217 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3218
3219         Reviewed by Mark.
3220
3221         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3222
3223         * Scripts/webkitdirs.pm:
3224         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3225
3226 2007-08-17  Darin Adler  <darin@apple.com>
3227
3228         Reviewed by Oliver Hunt.
3229
3230         - don't look for Apple-style localizable strings in the GTK version of WebKit
3231
3232         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3233         name of subdirectories to skip.
3234         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3235         to skip.
3236
3237 2007-08-17  Anders Carlsson  <andersca@apple.com>
3238
3239         Build fix.
3240
3241         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3242         (NPP_SetWindow):
3243
3244 2007-08-17  Anders Carlsson  <andersca@apple.com>
3245
3246         Reviewed by Dave Hyatt.
3247
3248         <rdar://problem/5379040>
3249         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3250
3251         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3252
3253         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3254         (pluginAllocate):
3255         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3256         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3257         (NPP_New):
3258         (NPP_SetWindow):
3259
3260 2007-08-16  Alice Liu  <alice.liu@apple.com>
3261
3262         Reviewed by Maciej.
3263
3264         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3265
3266         * DumpRenderTree/DumpRenderTree.m:
3267         (createWebView):
3268         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3269         (dumpRenderTree):
3270         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
3271
3272 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3273
3274         Reviewed by Adam.
3275
3276         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3277
3278         * Scripts/run-webkit-tests:
3279
3280 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3281
3282         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3283         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3284
3285         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3286         this prevents making "build" directories in each project folder.
3287
3288         * Scripts/webkitdirs.pm:
3289
3290 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3291
3292         Reviewed by Kevin Mccullough.
3293
3294         Removed special case that didn't belong. (It would allow a global
3295         initializer to sneak into production builds, which would cause a
3296         system-wide performance regression on Mac OS X.)
3297
3298         * Scripts/check-for-global-initializers:
3299
3300 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3301
3302         Reviewed by Tim.
3303
3304         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3305
3306         * DumpRenderTree/EditingDelegate.m:
3307         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3308         only for elements with the class needsDeletionUI.
3309
3310 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3311
3312         Reviewed by Darin.
3313
3314         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3315           svn-create-patch uses deprecated tail switch
3316
3317         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3318
3319 2007-08-13  Sam Weinig  <sam@webkit.org>
3320
3321         Reviewed by Adam Roben.
3322
3323         Use the cygwin specific Apache config file under cygwin.
3324
3325         * Scripts/run-webkit-httpd:
3326
3327 2007-08-12  Adam Roben  <aroben@apple.com>
3328
3329         Generate results for new tests in a more logical location
3330
3331         New platform-specific tests always have their results generated right
3332         next to the test. New cross-platform tests will have their results
3333         generated a) in the cross-platform directory, if they are text-only,
3334         or b) in the least-specific platform directory, if they are render
3335         tree dumps.
3336
3337         Reviewed by Lars.
3338
3339         * Scripts/run-webkit-tests:
3340
3341 2007-08-12  Adam Roben  <aroben@apple.com>
3342
3343         Print the actual directory where new results are generated.
3344
3345         Before, we were printing an unpredictable, context-specific substring
3346         of the directory.
3347
3348         Reviewed by Lars.
3349
3350         * Scripts/run-webkit-tests:
3351
3352 2007-08-12  Adam Roben  <aroben@apple.com>
3353
3354         Factor some common code into a stripExtension() subroutine.
3355
3356         Reviewed by Lars.
3357
3358         * Scripts/run-webkit-tests: Also removed some debugging output.
3359
3360 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
3361
3362         Reviewed over and over and over by Adam Roben.
3363
3364         Bug 14740: Hierarchical layout tests and platform organization
3365         http://bugs.webkit.org/show_bug.cgi?id=14740
3366
3367         Add support for platform-specific layout tests and results.
3368
3369         * Scripts/run-webkit-tests:
3370
3371 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
3372
3373         Reviewed by Adam.
3374
3375         Refactored svn-create-path to use a hash-of-hashes data structure to keep
3376         track of changed files.  In the top level hash, keys are paths to files and
3377         values are 'fileData' hashes with the following keys and values:
3378
3379         - isBinary: boolean value (set to true for non-text files like images, etc.)
3380         - isTestFile: boolean value (set to true if file exists within a known test
3381           directory)
3382         - modificationType: string equal to one of 'addition', 'additionWithHistory',
3383           'modification' or 'deletion'
3384         - path: string equal to the path to the file (this may seem redundant, but it
3385           is required to use the second-level 'fileData' hash independent of the
3386           top-level hash)
3387         - sourceFile: [optional] string equal to the path of the original file that was
3388           copied or moved
3389         - sourceRevision: [optional] string equal to the revision of the original file
3390           that was copied or moved
3391
3392         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
3393         that saves the return value in $result, then checks it before printing help.
3394         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
3395         and eliminated two for() loops.
3396         (binarycmp): Added.  Used with sort() to order non-binary files before binary
3397         files.
3398         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
3399         (findMimeType): Added optional second argument that takes a revision number.
3400         (generateDiff): Updated to take one fileData argument instead of three ($file,
3401         $modificationType, $isBinary).
3402         (generateFileList): Updated to take one hash ref argument (%diffFiles)
3403         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
3404         %diffFiles using paths for keys and fileData hashes for values.
3405         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
3406         argument.
3407         (pathcmp): Updated to take two fileData arguments instead of two strings.
3408         (testfilecmp): Added.  Used with sort() to order non-test files before test
3409         files.
3410
3411 2007-08-11  Darin Adler  <darin@apple.com>
3412
3413         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
3414
3415 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
3416
3417         Reviewed by David Kilzer.
3418
3419         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
3420         http://bugs.webkit.org/show_bug.cgi?id=14745
3421
3422         * Scripts/run-launcher:
3423         Scrub the "--gdk" out of the command line args, if given, so that
3424         GdkLauncher doesn't try to interpret it as a URL.
3425
3426 2007-08-03  Adam Roben  <aroben@apple.com>
3427
3428         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
3429
3430         Reviewed by Sam.
3431
3432         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
3433
3434 2007-08-03  Sam Weinig  <sam@webkit.org>
3435
3436         Reviewed by Darin.
3437
3438         Recursively dump all frames as text using new
3439         layoutTestController.dumpChildFramesAsText() function.
3440
3441         * DumpRenderTree/DumpRenderTree.m:
3442         (dumpFramesAsText):
3443         (dump):
3444         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3445         (-[LayoutTestController dumpChildFramesAsText]):
3446         (runTest):
3447         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3448         (dumpFramesAsText):
3449         (dump):
3450         (runTest):
3451         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
3452         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3453         (dumpChildFramesAsTextCallback):
3454         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3455
3456 2007-08-02  Adam Roben  <aroben@apple.com>
3457
3458         Fix fast/dom/Window/alert-undefined.html
3459
3460         Reviewed by Sam.
3461
3462         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3463         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
3464         Windows translate a null BSTR into "(null)"
3465
3466 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
3467
3468         Reviewed by Tim.
3469
3470         - It would help if I actually called the right function.
3471
3472         * Drosera/DebuggerDocument.cpp:
3473         (DebuggerDocument::showConsole):
3474
3475 2007-08-02  Adam Roben  <aroben@apple.com>
3476
3477         Don't delete the stderr file right after creating it
3478
3479         * Scripts/run-webkit-tests:
3480
3481 2007-08-01  Adam Roben  <aroben@apple.com>
3482
3483         When DRT crashes, record stderr and restart DRT
3484
3485         This prevents a DRT crash from causing the next few hundred tests to
3486         "fail" because DRT is no longer running.
3487
3488         I also changed the terminology that run-webkit-tests uses in its
3489         output a bit, so that crashing tests are referred to as "crashes"
3490         instead of "failures".
3491
3492         Reviewed by Mark.
3493
3494         * Scripts/run-webkit-tests: Detect a crash and record it as a tool
3495         failure.
3496         (sub openDumpTool): Use open3 so that we can access stderr.
3497         (sub dumpToolCrashed): Added.
3498         (sub printFailureMessageForTest): Added.
3499         (sub htmlForExpectedAndActualResults): Added.
3500         (sub deleteExpectedAndActualResults): Added.
3501         (sub recordActualResultsAndDiff): Added.
3502
3503 2007-07-30  Darin Adler  <darin@apple.com>
3504
3505         Reviewed by Tim Hatcher.
3506
3507         * DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null
3508         characters. This turned out not to be needed for the test case that motivated me to
3509         do it, but it's nice to have this for the future.
3510
3511 2007-07-30  Simon Hausmann  <hausmann@kde.org>
3512
3513         Reviewed by Lars.
3514
3515         Link QtLauncher into $$OUTPUT_DIR/bin
3516
3517         * Scripts/run-launcher:
3518
3519 2007-07-27  David Kilzer  <ddkilzer@apple.com>
3520
3521         Reviewed by Geoff and Darin.
3522
3523         Use a subroutine for validating the --skipped switch.
3524
3525         * Scripts/run-webkit-tests:
3526
3527 2007-07-27  Darin Adler  <darin@apple.com>
3528
3529         Reviewed by Sam.
3530
3531         * Scripts/run-webkit-tests: Remove exception for leaks bug that has been fixed on Leopard.
3532
3533 2007-07-27  Holger Hans Peter Freyther  <zecke@selfish.org>
3534
3535         Reviewed by Mark.
3536
3537         Correct the path of GdkLauncher and make checkFrameworks work on OSX
3538         when building the Qt or Gtk+ port.
3539
3540         * GdkLauncher/GdkLauncher.pro: Don't create an app bundle on OSX
3541         * Scripts/run-launcher:
3542         * Scripts/webkitdirs.pm: Don't add WebKit if we build the Qt or Gtk+ port.
3543
3544 2007-07-27  Simon Hausmann  <hausmann@kde.org>
3545
3546         Done with and reviewed by Lars and Zack.
3547
3548         Fix build-webkit for the Qt build on Windows with msvc/nmake by trying to detect the Qt mkspec and using "nmake" instead of "make" as build command.
3549