f96fd66cd56dd10772149012772afc64d38b18da
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2
3         Reviewed by Dumitru Daniliuc.
4
5         check-webkit-style fails on operator+=, operator-=, ... methods
6         https://bugs.webkit.org/show_bug.cgi?id=48258
7
8         * Scripts/webkitpy/style/checkers/cpp.py: Added exceptions
9         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit-tests
10
11 2010-10-26  Ojan Vafai  <ojan@chromium.org>
12
13         Reviewed by Tony Chang.
14
15         remove DEFER support from new-run-webkit-tests
16         https://bugs.webkit.org/show_bug.cgi?id=48387
17
18         DEFER was needed when we were trying to ship Chrome beta.
19         Now it's just extra complication.
20
21         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
22         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
23         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
24         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
25         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
26         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
27
28 2010-10-26  Eric Seidel  <eric@webkit.org>
29
30         Unreviewed.  Adding import with_statement to fix python 2.5.
31
32         Teach webkit-patch how to read credentials from the environment
33         https://bugs.webkit.org/show_bug.cgi?id=48275
34
35         * Scripts/webkitpy/common/net/credentials_unittest.py:
36          - import with_statement to fix python 2.5.
37
38 2010-10-26  Alexey Proskuryakov  <ap@apple.com>
39
40         Reviewed by Sam Weinig.
41
42         https://bugs.webkit.org/show_bug.cgi?id=48375
43         <rdar://problem/8392724> Need delegate calls in PageLoaderClient to indicate if we have
44         loaded insecure content
45
46         Updated for WebKit2 changes.
47
48         * MiniBrowser/mac/BrowserWindowController.m:
49         (didDisplayInsecureContentForFrame):
50         (didRunInsecureContentForFrame):
51         (-[BrowserWindowController awakeFromNib]):
52         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
53         (WTR::InjectedBundlePage::InjectedBundlePage):
54         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
55         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
56         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
57         * WebKitTestRunner/TestController.cpp:
58         (WTR::TestController::initialize):
59
60 2010-10-26  Adam Roben  <aroben@apple.com>
61
62         Clear up confusion between "3D rendering" and "accelerated compositing"
63
64         WebKit has no software-based 3D rendering implementation, so 3D
65         rendering can only be enabled when accelerated compositing is. But DRT
66         was falsely reporting that 3D rendering was available on machines that
67         don't support accelerated compositing, leading to much confusion.
68
69         Reviewed by Darin Adler.
70
71         Fixes <http://webkit.org/b/48370> REGRESSION (r70540): Many
72         transforms/3d tests are failing on the XP bots
73
74         * DumpRenderTree/win/DumpRenderTree.cpp:
75         (main): When ENABLE(3D_RENDERING) is turned on, only report that 3D
76         rendering is available when acclerated compositing is also available.
77
78         * Scripts/old-run-webkit-tests: Skip tests that use the
79         -webkit-transform-3d media query when 3D rendering is disabled,
80         rather than when accelerated compositing is disabled.
81
82 2010-10-26  Eric Seidel  <eric@webkit.org>
83
84         Reviewed by Ojan Vafai.
85
86         Remove rietveld code now that it's unused
87         https://bugs.webkit.org/show_bug.cgi?id=48359
88
89         Was cool that we added this support, but now that it's
90         not used it makes little sense to keep it around.
91         We can always restore this code from SVN if we need it.
92
93         * Scripts/webkitpy/common/config/__init__.py:
94         * Scripts/webkitpy/common/net/bugzilla.py:
95         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
96         * Scripts/webkitpy/common/net/rietveld.py: Removed.
97         * Scripts/webkitpy/common/net/rietveld_unittest.py: Removed.
98         * Scripts/webkitpy/thirdparty/__init__.py:
99         * Scripts/webkitpy/tool/commands/download.py:
100         * Scripts/webkitpy/tool/commands/download_unittest.py:
101         * Scripts/webkitpy/tool/commands/queues.py:
102         * Scripts/webkitpy/tool/commands/queues_unittest.py:
103         * Scripts/webkitpy/tool/main.py:
104         * Scripts/webkitpy/tool/mocktool.py:
105         * Scripts/webkitpy/tool/steps/__init__.py:
106         * Scripts/webkitpy/tool/steps/postcodereview.py: Removed.
107
108 2010-10-26  Anders Carlsson  <andersca@apple.com>
109
110         Reviewed by Sam Weinig.
111
112         pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client
113         https://bugs.webkit.org/show_bug.cgi?id=48366
114         <rdar://problem/8595202>
115
116         * MiniBrowser/mac/BrowserWindowController.m:
117         (-[BrowserWindowController awakeFromNib]):
118         * WebKitTestRunner/TestController.cpp:
119         (WTR::createOtherPage):
120         (WTR::TestController::initialize):
121
122 2010-10-26  Eric Seidel  <eric@webkit.org>
123
124         Reviewed by Tony Chang.
125
126         Teach webkit-patch how to read credentials from the environment
127         https://bugs.webkit.org/show_bug.cgi?id=48275
128
129         This makes it possible for svn users to have their bugzilla credentials
130         stored in their environment instead of typing them every time.
131
132         We need this for making it easy to run the win-ews bot (which currently
133         uses svn instead of git).
134
135         * Scripts/webkitpy/common/net/credentials.py:
136         * Scripts/webkitpy/common/net/credentials_unittest.py:
137
138 2010-10-26  Kenichi Ishibashi  <bashi@google.com>
139
140         Reviewed by Kent Tamura.
141
142         Input Method inserts conversion candidates unexpectedly
143         https://bugs.webkit.org/show_bug.cgi?id=46868
144
145         Adds setComposition() to TextInputController to make DRT emulate
146         an input method behavior.
147
148         * DumpRenderTree/chromium/TextInputController.cpp:
149         (TextInputController::TextInputController):
150         (TextInputController::setComposition): Added.
151         * DumpRenderTree/chromium/TextInputController.h:
152
153 2010-10-26  Simon Fraser  <simon.fraser@apple.com>
154
155         Reviewed by Sam Weinig.
156
157         Support layoutTestController.layerTreeAsText in WebKitTestRunner
158         https://bugs.webkit.org/show_bug.cgi?id=42145
159         
160         Implement layerTreeAsText() in WebKitTestRunner.
161
162         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
163         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
164         (WTR::LayoutTestController::layerTreeAsText):
165         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
166
167 2010-10-26  Adam Barth  <abarth@webkit.org>
168
169         Reviewed by Eric Seidel.
170
171         webkit-patch rollout produces incorrect patch when using svn move
172         https://bugs.webkit.org/show_bug.cgi?id=48244
173
174         We need to flush our caches when we modify the working copy.
175
176         * Scripts/webkitpy/tool/steps/revertrevision.py:
177
178 2010-10-26  Eric Seidel  <eric@webkit.org>
179
180         Reviewed by Adam Barth.
181
182         commit-queue flaky test message can list the same author more than once
183         https://bugs.webkit.org/show_bug.cgi?id=48268
184
185         tonikitoo reported to me over IRC this morning that he's seen
186         the commit-queue report flaky tests with author lists like:
187         "adam, adam and adam", suggesting we're not uniquing authors
188         before writing the message.
189
190         I fixed the uniquing and added a bunch more unit testing.
191
192         * Scripts/webkitpy/tool/commands/queues.py:
193         * Scripts/webkitpy/tool/commands/queues_unittest.py:
194         * Scripts/webkitpy/tool/mocktool.py:
195
196 2010-10-26  Adam Roben  <aroben@apple.com>
197
198         Pull in the FeatureDefines*.vsprops files when building DRT
199
200         This ensures that various ENABLE() macros will get set correctly.
201         (Prior to r70320 we were picking up the ENABLE(3D_RENDERING) flag
202         through wtf/Platform.h.)
203
204         Fixes <http://webkit.org/b/48343> REGRESSION (r70320): DumpRenderTree
205         says 3D_RENDERING is disabled even when it is enabled
206
207         Reviewed by Ada Chan.
208
209         * DumpRenderTree/win/DumpRenderTree.vcproj: Added
210         FeaturesDefines*.vsprops to all configurations.
211
212         * DumpRenderTree/win/DumpRenderTreeWin.h: Touched to force a rebuild.
213
214 2010-10-26  Søren Gjesse  <sgjesse@chromium.org>
215
216         Reviewed by Dimitri Glazkov.
217
218         Added options --multiple-loads and --js-flags to chromium DumpRenderTree. The option --multiple-loads=X
219         is used to have DumpRenderTree load each test it runs X times. To be able to have more fine-grained control
220         of how the JavaScript engine behaves for each load the flag --js-flags can specify a list of flag-sets like this
221
222           --js-flags="--xxx,--noxxx --yyy,--noyyy"
223
224         First load will run with --xxx, the second with --yyy and the third without any (the 'no' prefix is handled by
225         V8 to turn off the flag).
226
227         The changes to the Python test runner will be in a separate change.
228
229
230         * DumpRenderTree/chromium/DumpRenderTree.cpp:
231         (runTest):
232         (main):
233         * DumpRenderTree/chromium/TestShell.cpp:
234         (TestShell::TestShell):
235         (TestShell::runFileTest):
236         (TestShell::testFinished):
237         * DumpRenderTree/chromium/TestShell.h:
238         (TestShell::loadCount):
239         (TestShell::setLoadCount):
240         (TestShell::javaScriptFlagsForLoad):
241         (TestShell::setJavaScriptFlags):
242         (TestShell::setDumpWhenFinished):
243
244 2010-10-26  Adam Roben  <aroben@apple.com>
245
246         Skip more tests that depend on accelerated compositing when accelerated
247         compositing is disabled
248
249         Fixes <http://webkit.org/b/48329> Some tests fail when accelerated
250         compositing is disabled
251
252         Reviewed by John Sullivan.
253
254         * Scripts/old-run-webkit-tests: Added more tests to skip when
255         accelerated compositing is disable. The tests all have output that
256         changes depending on whether accelerated compositing is enabled.
257
258 2010-10-25  Eric Seidel  <eric@webkit.org>
259
260         Reviewed by Adam Barth.
261
262         webkit-patch should clean up svn locks when passed --force-clean
263         https://bugs.webkit.org/show_bug.cgi?id=48269
264
265         * Scripts/webkitpy/common/checkout/scm.py:
266
267 2010-10-25  Anders Carlsson  <andersca@apple.com>
268
269         Reviewed by Adam Roben.
270
271         Add a pageDidScroll BundleUIClient callback
272         https://bugs.webkit.org/show_bug.cgi?id=48260
273         <rdar://problem/8531159>
274
275         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
276         (WTR::InjectedBundlePage::InjectedBundlePage):
277
278 2010-10-25  Johnny Ding  <jnd@chromium.org>
279
280         Reviewed by Tony Chang.
281
282         Dump the gesture status of frame in frame load callbacks in DumpRenderTree
283         by adding a new method dumpUserGestureInFrameLoadCallbacks.
284         Now only dump the gesture status in "DidStartProvisionalLoad" callback.
285         https://bugs.webkit.org/show_bug.cgi?id=47849
286
287         * DumpRenderTree/LayoutTestController.cpp:
288         (LayoutTestController::LayoutTestController):
289         (dumpUserGestureInFrameLoadCallbacksCallback):
290         (LayoutTestController::staticFunctions):
291         * DumpRenderTree/LayoutTestController.h:
292         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
293         (LayoutTestController::setDumpUserGestureInFrameLoadCallbacks):
294         * DumpRenderTree/chromium/LayoutTestController.cpp:
295         (LayoutTestController::LayoutTestController):
296         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
297         (LayoutTestController::reset):
298         * DumpRenderTree/chromium/LayoutTestController.h:
299         (LayoutTestController::shouldDumpUserGestureInFrameLoadCallbacks):
300         (LayoutTestController::setShouldDumpUserGestureInFrameLoadCallbacks):
301         * DumpRenderTree/chromium/TestShell.h:
302         (TestShell::shouldDumpUserGestureInFrameLoadCallbacks):
303         * DumpRenderTree/chromium/WebViewHost.cpp:
304         (WebViewHost::didStartProvisionalLoad):
305         (WebViewHost::printFrameUserGestureStatus):
306         * DumpRenderTree/chromium/WebViewHost.h:
307         * DumpRenderTree/mac/FrameLoadDelegate.mm:
308         (-[WebFrame _drt_printFrameUserGestureStatus]):
309         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
310         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
311         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
312         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
313         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
314         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
315         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
316         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
317         (LayoutTestController::reset):
318         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
319         * DumpRenderTree/qt/LayoutTestControllerQt.h:
320
321 2010-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
322
323         Unreviewed, rolling out r70442.
324         http://trac.webkit.org/changeset/70442
325         https://bugs.webkit.org/show_bug.cgi?id=48248
326
327         http locking doesn't work on Windows (Requested by Ossy on
328         #webkit).
329
330         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
331         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
332
333 2010-10-25  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
334
335         Reviewed by Ojan Vafai.
336
337         Make http locking default in NRWT.
338         https://bugs.webkit.org/show_bug.cgi?id=48053
339
340         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
341         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
342
343 2010-10-25  David Kilzer  <ddkilzer@apple.com>
344
345         <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
346         (Re-landing r70413 after Qt minimal buildfix: r70440.)
347
348         Reviewed by Kenneth Rohde Christiansen.
349
350         * Scripts/build-webkit: Added support for --progress-tag switch.
351         It should have been added with r57051.
352
353 2010-10-24  Adam Barth  <abarth@webkit.org>
354
355         Reviewed by David Kilzer.
356
357         webkit-patch upload fails when the patch removes a file
358         https://bugs.webkit.org/show_bug.cgi?id=48187
359
360         We need to use "--" to separate file names from the rest of the
361         command.
362
363         * Scripts/webkitpy/common/checkout/scm.py:
364
365 2010-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
366
367         Unreviewed, rolling out r70413.
368         http://trac.webkit.org/changeset/70413
369         https://bugs.webkit.org/show_bug.cgi?id=48210
370
371         It broke Qt minimal build (Requested by Ossy on #webkit).
372
373         * Scripts/build-webkit:
374
375 2010-10-24  Yi Shen  <yi.4.shen@nokia.com>
376
377         Reviewed by Andreas Kling.
378
379         [Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu
380         https://bugs.webkit.org/show_bug.cgi?id=48141
381
382         * QtTestBrowser/launcherwindow.cpp:
383         (LauncherWindow::init):
384         (LauncherWindow::initializeView):
385         (LauncherWindow::toggleWebView):
386
387 2010-10-24  Daniel Bates  <dbates@rim.com>
388
389         Reviewed by David Kilzer.
390
391         Fix Perl uninitialized warnings in VCSUtils::svnStatus()
392         and VCSUtils::removeEOL().
393         https://bugs.webkit.org/show_bug.cgi?id=48196
394
395         VCSUtils::svnStatus() concatenates the output of svn status with
396         a new line character and svn status may return no output (say for
397         a file that has not been added, deleted, or modified). We should
398         only concatenate the output of svn status if there is some.
399
400         Also, VCSUtils::removeEOL() should ensure that its argument
401         is initialized before performing a string substitution.
402
403         * Scripts/VCSUtils.pm:
404           - Modified removeEOL() to return "" if its argument is undefined.
405           - Exported removeEOL() so that it can be tested. 
406         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Added.
407
408 2010-10-24  David Kilzer  <ddkilzer@apple.com>
409
410         <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
411
412         Reviewed by Kenneth Rohde Christiansen.
413
414         * Scripts/build-webkit: Added support for --progress-tag switch.
415         It should have been added with r57051.
416
417 2010-10-24  David Kilzer  <ddkilzer@apple.com>
418
419         <http://webkit.org/b/48184> build-webkit: reformat support variables for better maintainability
420
421         Reviewed by Daniel Bates.
422
423         * Scripts/build-webkit: Alphabetized the @features array based
424         on the name of the feature.  Reformatted the list of support
425         variables so that they match the order of @features, and so that
426         each has its own line.  This makes it easy to add new variables
427         in the correct order.
428
429 2010-10-23  Eric Seidel  <eric@webkit.org>
430
431         Reviewed by Adam Barth.
432
433         EWS never removes invalid patch ids
434         https://bugs.webkit.org/show_bug.cgi?id=48173
435
436         This is just sticking another finger in the dam.
437         However this adds more unit testing which will help
438         us make sure we're always releasing patches once we
439         redesign the release_patch API and call these from
440         a more central place.
441
442         * Scripts/webkitpy/tool/commands/queues.py:
443         * Scripts/webkitpy/tool/commands/queues_unittest.py:
444         * Scripts/webkitpy/tool/mocktool.py:
445          - Added the ability to request invalid patches.
446            Log a warning message to make sure we don't ever have
447            tests use invalid patch fetches by mistake.
448
449 2010-10-23  Dan Bernstein  <mitz@apple.com>
450
451         Build fix. Add stub implementations for required NSDraggingInfo methods.
452
453         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
454         (-[DumpRenderTreeDraggingInfo draggingFormation]):
455         (-[DumpRenderTreeDraggingInfo setDraggingFormation:]):
456         (-[DumpRenderTreeDraggingInfo animatesToDestination]):
457         (-[DumpRenderTreeDraggingInfo setAnimatesToDestination:]):
458         (-[DumpRenderTreeDraggingInfo numberOfValidItemsForDrop]):
459         (-[DumpRenderTreeDraggingInfo setNumberOfValidItemsForDrop:]):
460         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
461
462 2010-10-23  David Kilzer  <ddkilzer@apple.com>
463
464         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
465
466         Reviewed by Sam Weinig.
467
468         The only method defined in WebHTMLRepresentationInternal.h is
469         also defined in WebHTMLRepresentation.h, so use that instead.
470
471         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Removed.
472         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Switched to use
473         WebHTMLRepresentation.h.
474
475 2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
476
477         Unreviewed, rolling out r70367.
478         http://trac.webkit.org/changeset/70367
479         https://bugs.webkit.org/show_bug.cgi?id=48176
480
481         It made 8-10 tests crash on Qt bot (Requested by Ossy on
482         #webkit).
483
484         * DumpRenderTree/LayoutTestController.cpp:
485         (setCustomPolicyDelegateCallback):
486         * DumpRenderTree/LayoutTestController.h:
487         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
488         (LayoutTestController::setCustomPolicyDelegate):
489         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
490         (LayoutTestController::setCustomPolicyDelegate):
491         * DumpRenderTree/mac/PolicyDelegate.h:
492         * DumpRenderTree/mac/PolicyDelegate.mm:
493         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
494         (-[PolicyDelegate setPermissive:]):
495         (-[PolicyDelegate setControllerToNotifyDone:]):
496         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
497         (LayoutTestController::setCustomPolicyDelegate):
498         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
499         (LayoutTestController::setCustomPolicyDelegate):
500
501 2010-10-22  Eric Seidel  <eric@webkit.org>
502
503         Reviewed by Adam Barth.
504
505         EWS never releases patches which fail to apply
506         https://bugs.webkit.org/show_bug.cgi?id=48171
507
508         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
509         * Scripts/webkitpy/tool/commands/queues.py:
510
511 2010-10-22  Eric Seidel  <eric@webkit.org>
512
513         Unreviewed.
514
515         Make the EWS queues restart themselves more often.
516         This matches the commit-queue.
517
518         * EWSTools/start-queue.sh:
519
520 2010-10-22  Eric Seidel  <eric@webkit.org>
521
522         Reviewed by Adam Barth.
523
524         commit-queue should not pass --quiet to subcommands now that the parent command does the reporting
525         https://bugs.webkit.org/show_bug.cgi?id=48165
526
527         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
528         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
529         * Scripts/webkitpy/tool/commands/queues_unittest.py:
530
531 2010-10-22  Mario Sanchez Prada  <msanchez@igalia.com>
532
533         Adding myself as a committer.
534
535         * Scripts/webkitpy/common/config/committers.py:
536
537 2010-10-20  Anders Carlsson  <andersca@apple.com>
538
539         Reviewed by Adam Barth and Darin Adler.
540
541         Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
542         https://bugs.webkit.org/show_bug.cgi?id=48014
543         <rdar://problem/8202716>
544         
545         * DumpRenderTree/LayoutTestController.cpp:
546         (setCustomPolicyDelegateCallback):
547         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
548
549         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
550         (LayoutTestController::setCustomPolicyDelegate):
551         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
552
553         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
554         (LayoutTestController::setCustomPolicyDelegate):
555         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
556
557         * DumpRenderTree/mac/PolicyDelegate.h:
558         * DumpRenderTree/mac/PolicyDelegate.mm:
559         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
560         If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second.
561
562         (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]):
563         Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond.
564         
565         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
566         (LayoutTestController::setCustomPolicyDelegate):
567         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
568
569         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
570         (LayoutTestController::setCustomPolicyDelegate):
571         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
572
573 2010-10-22  Sam Weinig  <sam@webkit.org>
574
575         Reviewed by Anders Carlsson.
576
577         Rename the InjectedBundle for TestWebKitAPI to InjectedBundleTestWebKitAPI.bundle
578
579         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
581         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
582         (TestWebKitAPI::Util::createInjectedBundlePath):
583
584 2010-10-22  Dirk Pranke  <dpranke@chromium.org>
585
586         Reviewed by Eric Seidel.
587
588         test-webkitpy fails when passed -v (or any other option)
589
590         Fix port/base_unittest to pass an explicit list of arguments
591         rather than accidentally picking up sys.argv.
592
593         https://bugs.webkit.org/show_bug.cgi?id=48071
594
595         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
596
597 2010-10-22  Brian Weinstein  <bweinstein@apple.com>
598
599         Windows build fix. Update the createNewPage callback to account for the new
600         arguments.
601
602         * MiniBrowser/win/BrowserView.cpp:
603         (createNewPage):
604
605 2010-10-22  Sam Weinig  <sam@webkit.org>
606
607         Reviewed by Anders Carlsson.
608
609         WebKit2 needs to pass the current event modifier flags when requesting a new window
610         https://bugs.webkit.org/show_bug.cgi?id=48140
611
612         * MiniBrowser/mac/BrowserWindowController.m:
613         (createNewPage):
614         * WebKitTestRunner/TestController.cpp:
615         (WTR::createOtherPage):
616         Update for new signature for the WKPageCreateNewPageCallback.
617
618 2010-10-22  Eric Seidel  <eric@webkit.org>
619
620         Unreviewed.  Just adding a test case.
621
622         The style-queue was not recognizing new patches.  It turns
623         out I had fixed this in an earlier change, but just not
624         deployed to queues.webkit.org.  As part of investigating why it
625         was broken, I wrote a test for my previous change which I'm now landing.
626
627         * QueueStatusServer/model/queues_unittest.py:
628
629 2010-10-22  Eric Seidel  <eric@webkit.org>
630
631         Reviewed by Adam Barth.
632
633         EWS does not need to process obsolete patches
634         https://bugs.webkit.org/show_bug.cgi?id=48093
635
636         This was an easy change, but to test it I had to pipe
637         real Attachment objects into the queue testing system.
638         Doing so revealed a whole bunch of bugs in our unit tests,
639         which I fixed as part of this patch.
640
641         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
642          - This is the actual code change.  This will not reduce the
643            backlog in the EWS queues much, but it will make rejections
644            much quicker for obsolete patches or closed bugs.
645         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
646          - Test my new code.
647          - Used a real attachment object and got rid of MockPatch
648          - Shared code between the mac-ews and cr-mac-ews tests.
649         * Scripts/webkitpy/tool/commands/queues_unittest.py:
650          - Can't use MockPatch anymore.
651          - Removing MockPatch found more bugs here!
652         * Scripts/webkitpy/tool/commands/queuestest.py:
653         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
654         * Scripts/webkitpy/tool/mocktool.py:
655          - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
656            is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.
657
658 2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
659
660         Unreviewed, rolling out r70301.
661         http://trac.webkit.org/changeset/70301
662         https://bugs.webkit.org/show_bug.cgi?id=48126
663
664         "Lang attribute layout tests failing" (Requested by satish on
665         #webkit).
666
667         * DumpRenderTree/LayoutTestController.cpp:
668         (setMockSpeechInputResultCallback):
669         * DumpRenderTree/LayoutTestController.h:
670         * DumpRenderTree/chromium/LayoutTestController.cpp:
671         (LayoutTestController::setMockSpeechInputResult):
672         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
673         (LayoutTestController::setMockSpeechInputResult):
674         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
675         (LayoutTestController::setMockSpeechInputResult):
676         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
677         (LayoutTestController::setMockSpeechInputResult):
678         * DumpRenderTree/qt/LayoutTestControllerQt.h:
679         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
680         (LayoutTestController::setMockSpeechInputResult):
681         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
682         (LayoutTestController::setMockSpeechInputResult):
683
684 2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
685
686         Reviewed by Jeremy Orlow.
687
688         Added a second parameter to setMockSpeechInputResult for
689         the language used in speech input.
690         https://bugs.webkit.org/show_bug.cgi?id=47089
691
692         * DumpRenderTree/LayoutTestController.cpp:
693         (setMockSpeechInputResultCallback):
694         * DumpRenderTree/LayoutTestController.h:
695         * DumpRenderTree/chromium/LayoutTestController.cpp:
696         (LayoutTestController::setMockSpeechInputResult):
697         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
698         (LayoutTestController::setMockSpeechInputResult):
699         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
700         (LayoutTestController::setMockSpeechInputResult):
701         * DumpRenderTree/qt/LayoutTestControllerQt.h:
702         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
703         (LayoutTestController::setMockSpeechInputResult):
704         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
705         (LayoutTestController::setMockSpeechInputResult):
706         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
707         (LayoutTestController::setMockSpeechInputResult):
708
709 2010-10-21  MORITA Hajime  <morrita@google.com>
710
711         Reviewed by Kent Tamura.
712
713         [Win][DRT] should have LayoutTestController.hasSpellingMarker()
714         https://bugs.webkit.org/show_bug.cgi?id=47885
715
716         - Implemented LayoutTestController.hasSpellingMarker(),
717         - Added fake spellcheck implementation.
718
719         * DumpRenderTree/win/DumpRenderTree.cpp:
720         (main):
721         * DumpRenderTree/win/EditingDelegate.cpp:
722         (indexOfFirstWordCharacter):
723         (wordLength):
724         (EditingDelegate::checkSpellingOfString):
725         * DumpRenderTree/win/EditingDelegate.h:
726         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
727         (LayoutTestController::hasSpellingMarker):
728
729 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
730
731         Unreviewed. Re-enable test that was mistakenly disabled by r67974.
732
733         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
734
735 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
736
737         Unreviewed fix for rebaseline-chromium-webkit-tests.
738
739         Port.diff_image no longer has a tolerance parameter. Also, use
740         get_option('tolerance') which is safer if the options object doesn't
741         define a tolerance attribute (it doesn't for the one used in
742         rebaseline_chromium_webkit_tests).
743
744         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
745         * Scripts/webkitpy/layout_tests/port/webkit.py:
746         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
747
748 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
749
750         Reviewed by Ojan Vafai.
751
752         Add support for --tolerance in NRWT
753         https://bugs.webkit.org/show_bug.cgi?id=47959
754         
755         Add support for the --tolerance flag in NRWT. The Port.diff_image
756         signature shouldn't need a tolerance parameter (it's not set per test),
757         just have ports that use it (currently only WebKitPort) read it from 
758         the options object.
759
760         * Scripts/webkitpy/layout_tests/port/chromium.py:
761         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
762         * Scripts/webkitpy/layout_tests/port/test.py:
763         * Scripts/webkitpy/layout_tests/port/webkit.py:
764         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
765         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
766
767 2010-10-21  Eric Seidel  <eric@webkit.org>
768
769         Reviewed by Adam Barth.
770
771         Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
772         https://bugs.webkit.org/show_bug.cgi?id=48088
773
774         This is a first-pass.  Works, but we'll eventually
775         turn this on by default, refine the suggestion algorithm
776         and possibly move it to a different place in the upload step order.
777
778         * Scripts/webkitpy/common/checkout/api.py:
779         * Scripts/webkitpy/tool/commands/download_unittest.py:
780         * Scripts/webkitpy/tool/commands/upload.py:
781         * Scripts/webkitpy/tool/commands/upload_unittest.py:
782         * Scripts/webkitpy/tool/mocktool.py:
783         * Scripts/webkitpy/tool/steps/__init__.py:
784         * Scripts/webkitpy/tool/steps/options.py:
785
786 2010-10-21  Mario Sanchez Prada  <msanchez@igalia.com>
787
788         Reviewed by Chris Fleizach.
789
790         [GTK] Segfault while testing accessibility/iframe-bastardization.html
791         https://bugs.webkit.org/show_bug.cgi?id=30123
792
793         Check m_element before actually using it to get the parent.
794
795         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
796         (AccessibilityUIElement::parentElement): Add an extra check to
797         make sure m_element points to a valid value before actually using
798         it to get the parent. Also, assert ATK_IS_OBJECT(m_element).
799
800 2010-10-21  Anders Carlsson  <andersca@apple.com>
801
802         Reviewed by Adam Roben.
803
804         Crash evaluating JavaScript string that throws an exception
805         https://bugs.webkit.org/show_bug.cgi?id=48092
806         <rdar://problem/8487657>
807
808         Add a test that evaluates a JavaScript string that throws an exception and check that 
809         the callback is called.
810
811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
812         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added.
813         (TestWebKitAPI::didRunJavaScript):
814         (TestWebKitAPI::WebKit2_EvaluateJavaScript):
815         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
816
817 2010-10-21  Adam Roben  <aroben@apple.com>
818
819         Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
820         called
821
822         Test for <http://webkit.org/b/48086> <rdar://problem/8482944>
823         Silverlight doesn't repaint in WebKit2
824
825         Reviewed by Anders Carlsson.
826
827         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
828         (PluginTest::NPN_InvalidateRect): Added. Calls through to the browser.
829         (executeScript): Added. Asks the browser to evaluate the script.
830
831         (PluginTest::waitUntilDone):
832         (PluginTest::notifyDone):
833         Added. Calls through to layoutTestController.
834
835         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added
836         * NPN_InvalidateRect and waitUntilDone/notifyDone.
837
838         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added.
839         (TemporaryWindowMover::moveSucceeded):
840         (TemporaryWindowMover::TemporaryWindowMover):
841         (TemporaryWindowMover::~TemporaryWindowMover):
842         This class moves a window on-screen and shows it, then moves it back and hides it.
843
844         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
845         Initialize our members.
846         (NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow):
847         Delete our window mover if it hasn't been deleted already.
848         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the
849         plugin HWND and move the test harness window on screen.
850         (NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint
851         when we get a WM_PAINT message.
852         (NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell
853         LayoutTestController we're done.
854         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate
855         ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect,
856         then check that our HWND's invalid region is the rect that we
857         invalidated.
858
859         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
860         * Added NPNInvalidateRectInvalidatesWindow.
861
862 2010-10-21  Daniel Bates  <dbates@rim.com>
863
864         Add Git-support to do-file-rename
865         https://bugs.webkit.org/show_bug.cgi?id=48015
866
867         Fix tools. Export function scmMoveOrRenameFile so that it can be called from
868         do-file-rename and do-webcore-rename. I inadvertently left this out of the patch.
869
870         * Scripts/VCSUtils.pm:
871
872 2010-10-21  Eric Seidel  <eric@webkit.org>
873
874         Reviewed by Adam Barth.
875
876         mac-ews is not properly releasing patches
877         https://bugs.webkit.org/show_bug.cgi?id=48076
878
879         mac-ews overrides process_work_item, so it was not calling
880         release_work_item like the default process_work_item would.
881         To fix this I made all the status-reporting methods just
882         release the patch.  I expect we'll iterate on this design further.
883
884         * Scripts/webkitpy/common/net/statusserver.py:
885         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
886         * Scripts/webkitpy/tool/commands/queues.py:
887         * Scripts/webkitpy/tool/commands/queues_unittest.py:
888
889 2010-10-18  Martin Robinson  <mrobinson@igalia.com>
890
891         Reviewed by Gustavo Noronha Silva.
892
893         [GTK] mathml flaky tests after adding SystemFonts to the theme
894         https://bugs.webkit.org/show_bug.cgi?id=47727
895
896         The Fontconfig setup in the GTK+ now specifically checks for and
897         loads the STIX fonts for MathML tests.
898
899         * DumpRenderTree/gtk/DumpRenderTree.cpp:
900         (initializeFonts): Add hooks for loading the STIX fonts specifically.
901
902 2010-10-20  Adam Roben  <aroben@apple.com>
903
904         Test that the UI client gets notified when WKView receives a WM_CLOSE
905         message
906
907         Test for <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing
908         Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't
909         close its parent window
910
911         Reviewed by Jon Honeycutt.
912
913         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added.
914         (TestWebKitAPI::close): Record that this function was called.
915         (TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView,
916         send it a WM_CLOSE message, and test that the UI client's close
917         callback got called. Note that this will hang if the bug is
918         reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI
919         able to handle hangs.
920
921         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
922
923 2010-10-20  Adam Roben  <aroben@apple.com>
924
925         Make prepare-ChangeLog much faster when using git
926
927         This change also seems to make it detect renames better in some cases.
928
929         Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using
930         git
931
932         Reviewed by David Kilzer.
933
934         * Scripts/prepare-ChangeLog:
935         (statusCommand):
936         (createPatchCommand):
937         Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames
938         and copies. The two "-C"s were making it read many more files than were
939         necessary.
940
941 2010-10-21  Sam Weinig  <sam@webkit.org>
942
943         Reviewed by Adam Roben.
944
945         Null frame passed when running alert from UserScript run at document start
946         <rdar://problem/8573809>
947         https://bugs.webkit.org/show_bug.cgi?id=48036
948
949         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
950         * TestWebKitAPI/InjectedBundleController.cpp:
951         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
952         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
953         * TestWebKitAPI/InjectedBundleController.h:
954         * TestWebKitAPI/InjectedBundleTest.h:
955         (TestWebKitAPI::InjectedBundleTest::initialize):
956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
957         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added.
958         (TestWebKitAPI::runJavaScriptAlert):
959         (TestWebKitAPI::TEST):
960         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added.
961         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest):
962         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
963         Add test for invoking an alert during a UserScript run at document start.
964
965 2010-10-21  Andreas Kling  <kling@webkit.org>
966
967         Reviewed by Adam Roben.
968
969         TestNetscapePlugIn: Actually call NPP_SetWindow on Unix
970
971         We were just returning NPERR_NO_ERROR previously.
972
973         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
974         (webkit_test_plugin_set_window):
975
976 2010-10-21  David Kilzer  <ddkilzer@apple.com>
977
978         <http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h
979
980         Reviewed by Adam Roben.
981
982         * DumpRenderTree/config.h: Moved macros to here...
983         * DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here.
984         Addresses a FIXME comment from r28419.
985
986 2010-10-21  David Kilzer  <ddkilzer@apple.com>
987
988         <http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types
989
990         Reviewed by Adam Roben.
991
992         Fixes the following warnings:
993
994             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'.
995             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'.
996             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'.
997             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'.
998             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'.
999             5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj.
1000
1001         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1002         Removed explicit file type for *.cpp files above to make them
1003         match other C++ source files.  This exposed the fact that
1004         DumpRenderTreeMac.h was not safe to include in C++ source, which
1005         caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail
1006         to build.
1007         * DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order.
1008         * DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include
1009         in C++ source files.  Included CoreFoundation/CoreFoundation.h
1010         to make sure all CF types were defined.  Removed CFStringRef
1011         typedef.
1012
1013 2010-10-21  Adam Roben  <aroben@apple.com>
1014
1015         Attempt to fix plugins/pass-different-npp-struct.html on GTK.
1016
1017         See <http://webkit.org/b/47690>.
1018
1019         * GNUmakefile.am: Added PassDifferentNPPStruct.cpp.
1020
1021 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1022
1023         Reviewed by Csaba Osztrogonác.
1024
1025         [NRWT] Set ImageDiff path on Qt port
1026         https://bugs.webkit.org/show_bug.cgi?id=48052
1027
1028         * Scripts/webkitpy/layout_tests/port/qt.py:
1029
1030 2010-10-21  Adam Barth  <abarth@webkit.org>
1031
1032         Reviewed by Eric Seidel.
1033
1034         Don't CC authors of flaky tests
1035         https://bugs.webkit.org/show_bug.cgi?id=48038
1036
1037         Some authors found this too annoying.  We'll look for another way to
1038         close the flaky test loop.
1039
1040         * Scripts/webkitpy/tool/commands/queues.py:
1041         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1042
1043 2010-10-21  Eric Seidel  <eric@webkit.org>
1044
1045         Reviewed by Adam Barth.
1046
1047         commit-queue should run run-webkit-tests with --no-new-test-results
1048         https://bugs.webkit.org/show_bug.cgi?id=47998
1049
1050         * Scripts/webkitpy/tool/steps/runtests.py:
1051         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1052
1053 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1054
1055         Reviewed by Ojan Vafai.
1056
1057         [NRWT] Get child process number from an environment variable
1058         https://bugs.webkit.org/show_bug.cgi?id=47981
1059
1060         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1061
1062 2010-10-20  David Kilzer  <ddkilzer@apple.com>
1063
1064         <http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files
1065
1066         Reviewed by Darin Adler.
1067
1068         The script parses an Xcode project file and makes sure the file
1069         extension matches the explicit file type set for all source
1070         files.  Note that the majority of source files will have their
1071         type set by Xcode, so the script doesn't check them since there
1072         is no need to second-guess Xcode.
1073
1074         * Scripts/check-Xcode-source-file-types: Added.  Code borrowed
1075         heavily from sort-Xcode-project-file.
1076
1077 2010-10-20  Adam Roben  <aroben@apple.com>
1078         
1079         Windows build fix
1080
1081         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include.
1082
1083 2010-10-20  Adam Roben  <aroben@apple.com>
1084
1085         Qt test fix
1086
1087         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added
1088         PassDifferentNPPStruct.cpp.
1089
1090 2010-10-20  Sam Weinig  <sam@webkit.org>
1091
1092         Reviewed by Adam Roben.
1093
1094         Add ability to test injected bundle API using TestWebKitAPI
1095         https://bugs.webkit.org/show_bug.cgi?id=48027
1096
1097         * TestWebKitAPI/InjectedBundleController.cpp: Added.
1098         * TestWebKitAPI/InjectedBundleController.h: Added.
1099         Shared main object for bundle functionality.
1100
1101         * TestWebKitAPI/InjectedBundleMain.cpp: Added.
1102         Bundle entry point.
1103
1104         * TestWebKitAPI/InjectedBundleTest.h: Added.
1105         Base class for which the bundle portion of a test derives from. 
1106
1107         * TestWebKitAPI/PlatformUtilities.h:
1108         * TestWebKitAPI/PlatformUtilities.cpp: Added.
1109         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1110         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1111         (TestWebKitAPI::Util::createInjectedBundlePath):
1112         (TestWebKitAPI::Util::createURLForResource):
1113         (TestWebKitAPI::Util::URLForNonExistentResource):
1114         Add helper to create a context with the shared injected bundle,
1115         and send the initial message to set up the test.
1116
1117         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added.
1118         * TestWebKitAPI/InjectedBundle-Info.plist: Added.
1119         Add mac configuration files.
1120
1121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1122         Add the new files.
1123
1124         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added.
1125         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added.
1126         Add a simple initial bundle test.
1127
1128 2010-10-20  Eric Seidel  <eric@webkit.org>
1129
1130         Unreviewed.  Fixing /release-patch url used by the EWS bots.
1131
1132         EWS should test patches with r+
1133         https://bugs.webkit.org/show_bug.cgi?id=35460
1134
1135         * Scripts/webkitpy/common/net/statusserver.py:
1136          - I changed the URL during development, and 404s are
1137          intentionally silenced during release_patch.
1138
1139 2010-10-14  Adam Roben  <aroben@apple.com>
1140
1141         Test that passing a different NPP struct back to the browser doesn't
1142         cause an assertion failure
1143
1144         Test for <http://webkit.org/b/47690> <rdar://problem/8553020>
1145         Assertion failure in NetscapePlugin::fromNPP when using Shockwave in
1146         WebKit2
1147
1148         Reviewed by John Sullivan.
1149
1150         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp.
1151         (PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our
1152         members.
1153         (PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the
1154         browser than the one it gave us in NPP_New and see if it works.
1155
1156         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1157         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1158         Added PassDifferentNPPStruct.
1159
1160 2010-10-19  Adam Roben  <aroben@apple.com>
1161
1162         Gently nudge old-run-webkit-tests toward working with Win32 Perl
1163
1164         This makes old-run-webkit-tests able to build DRT and find all the
1165         tests to run. It even invokes DRT and passes it the list of tests. But
1166         DRT ends up hung blocking on I/O.
1167
1168         Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly
1169         working with Win32 Perl
1170
1171         Reviewed by David Kilzer.
1172
1173         * Scripts/old-run-webkit-tests:
1174           - Use File::Spec instead of manually concatenating paths
1175           - Use dirname instead of manually stripping off the base name
1176           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
1177           - Explicitly invoke Perl when running Perl scripts
1178           - Quote paths when using them in regular expressions to allow them
1179             to include characters that have special meanings in regular
1180             expressions
1181
1182         * Scripts/run-webkit-tests: Use File::Spec instead of manually
1183         concatenating paths.
1184
1185         * Scripts/webkitdirs.pm:
1186           - Remove the unused $windowsTmpPath variable
1187           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
1188           - Only pass paths to cygpath when using Cygwin Perl
1189           - Only use pdevenv when using Cygwin Perl, for now
1190
1191 2010-10-20  Daniel Bates  <dbates@rim.com>
1192
1193         Reviewed by Martin Robinson.
1194
1195         Add Git-support to do-file-rename
1196         https://bugs.webkit.org/show_bug.cgi?id=48015
1197
1198         Also, abstracts the SCM move/rename functionality in do-file-rename and
1199         do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile().
1200
1201         Currently, do-file-rename is hard coded to assume the SCM is Subversion.
1202         Instead, we should abstract the rename logic to be SCM-independent. This
1203         will allow us to add Git support as well move such functionality into
1204         our SCM library VCSUtils, where it can be shared by do-webcore-rename.
1205
1206         * Scripts/VCSUtils.pm:
1207           - Added function scmMoveOrRenameFile.
1208         * Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile().
1209         * Scripts/do-webcore-rename: Ditto.
1210
1211 2010-10-20  Adam Roben  <aroben@apple.com>
1212
1213         Fix old-run-webkit-tests when there's a space in the path to DRT
1214
1215         Reviewed by Jon Honeycutt.
1216
1217         * Scripts/old-run-webkit-tests: Quote the path to DRT before executing
1218         it.
1219
1220 2010-10-20  Kenneth Russell  <kbr@google.com>
1221
1222         Reviewed by Dimitri Glazkov.
1223
1224         Regression in chromium_gpu_unittests after r70175
1225         https://bugs.webkit.org/show_bug.cgi?id=48008
1226
1227         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1228
1229 2010-10-20  Kenneth Russell  <kbr@google.com>
1230
1231         Reviewed by James Robinson.
1232
1233         chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
1234         https://bugs.webkit.org/show_bug.cgi?id=48005
1235
1236         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1237
1238 2010-10-20  Adam Barth  <abarth@webkit.org>
1239
1240         Reviewed by Eric Seidel.
1241
1242         webkit-patch doesn't get along with git rm
1243         https://bugs.webkit.org/show_bug.cgi?id=47940
1244
1245         Turns out we need to pass "--" to tell git this is a path.
1246
1247         * Scripts/webkitpy/common/checkout/scm.py:
1248
1249 2010-10-20  Robert Hogan  <robert@webkit.org>
1250
1251         Reviewed by Antonio Gomes.
1252
1253         [Qt] Fix layoutTestController.getJsObjectCount
1254
1255         Qt Bridge doesn't know size_t so pass result as unsigned int.
1256
1257         Unskip fast/dom/gc-10.html
1258
1259         https://bugs.webkit.org/show_bug.cgi?id=47931
1260
1261         * DumpRenderTree/qt/GCControllerQt.cpp:
1262         (GCController::getJSObjectCount):
1263         * DumpRenderTree/qt/GCControllerQt.h:
1264
1265 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1266
1267         Unreviewed, rolling out r70149.
1268         http://trac.webkit.org/changeset/70149
1269         https://bugs.webkit.org/show_bug.cgi?id=47989
1270
1271         "Build breaks in mac and win" (Requested by satish on
1272         #webkit).
1273
1274         * DumpRenderTree/LayoutTestController.cpp:
1275         (setMockSpeechInputResultCallback):
1276         * DumpRenderTree/LayoutTestController.h:
1277         * DumpRenderTree/chromium/LayoutTestController.cpp:
1278         (LayoutTestController::setMockSpeechInputResult):
1279         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1280         (LayoutTestController::setMockSpeechInputResult):
1281
1282 2010-10-19  Adam Roben  <aroben@apple.com>
1283
1284         Teach update-webkit-support-libs about the new versioning of
1285         WebKitSupportLibrary
1286
1287         Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
1288         check version numbers instead of modification times
1289
1290         Reviewed by Sam Weinig.
1291
1292         * Scripts/update-webkit-support-libs: Fetch the expected version
1293         number from developer.apple.com, then compare with the version number
1294         of the extracted library and of the zipped library to see if anything
1295         needs to be done. Removed code that tracked the modified timestamp of
1296         the library, as it is no longer needed.
1297
1298 2010-10-19  Eric Seidel  <eric@webkit.org>
1299
1300         Reviewed by Adam Barth.
1301
1302         EWS should test patches with r+
1303         https://bugs.webkit.org/show_bug.cgi?id=35460
1304
1305         * QueueStatusServer/handlers/submittoews.py:
1306         * QueueStatusServer/model/queues.py:
1307         * Scripts/webkitpy/tool/bot/patchcollection.py: Removed.
1308         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed.
1309         * Scripts/webkitpy/tool/commands/queues.py:
1310
1311 2010-10-19  Eric Seidel  <eric@webkit.org>
1312
1313         Reviewed by Adam Barth.
1314
1315         Teach feeder-queue how to feed the EWS bots
1316         https://bugs.webkit.org/show_bug.cgi?id=47943
1317
1318         queues.webkit.org already knew how to accept EWS submissions
1319         via /submit-to-ews.  This teaches the feeder queue how to post
1320         to that page with any new r? patches it sees.
1321
1322         * QueueStatusServer/model/activeworkitems_unitest.py: Added.
1323          - More unit testing is always a good thing.
1324         * Scripts/webkitpy/common/net/bugzilla.py:
1325         * Scripts/webkitpy/common/net/statusserver.py:
1326         * Scripts/webkitpy/tool/bot/feeders.py:
1327         * Scripts/webkitpy/tool/commands/queues.py:
1328         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1329         * Scripts/webkitpy/tool/mocktool.py:
1330
1331 2010-10-19  Eric Seidel  <eric@webkit.org>
1332
1333         Unreviewed, just fixing test-webkitpy.  I'm really on a roll today.
1334
1335         commit-queue gets stuck when release-patch returns 404
1336         https://bugs.webkit.org/show_bug.cgi?id=47935
1337
1338         Fix test-webkitpy and unittest NetworkTransaction.
1339
1340         * Scripts/webkitpy/common/net/networktransaction.py:
1341         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1342
1343 2010-10-19  Eric Seidel  <eric@webkit.org>
1344
1345         Unreviewed.
1346
1347         commit-queue gets stuck when release-patch returns 404
1348         https://bugs.webkit.org/show_bug.cgi?id=47935
1349
1350         Turns out ClientForm gets upset if passed an int() instead of a string type.
1351         Yay for untestable code.
1352
1353         * Scripts/webkitpy/common/net/statusserver.py:
1354
1355 2010-10-19  Eric Seidel  <eric@webkit.org>
1356
1357         Unreviewed.  Will get Adam's commentary after his meeting
1358         for now this gets the commit-cluster back running.
1359
1360         commit-queue gets stuck when release-patch returns 404
1361         https://bugs.webkit.org/show_bug.cgi?id=47935
1362
1363         I taught NetworkTransaction the basics of 404 handling.
1364         We'll want to go back and teach it how to handle urllib2 404's too
1365         and then deploy it to the places that want it.
1366
1367         * QueueStatusServer/handlers/releasepatch.py:
1368         * Scripts/webkitpy/common/net/buildbot.py:
1369         * Scripts/webkitpy/common/net/networktransaction.py:
1370         * Scripts/webkitpy/common/net/statusserver.py:
1371
1372 2010-10-19  Eric Seidel  <eric@webkit.org>
1373
1374         Unreviewed.  Fixing typos in my previous commit.
1375
1376         Make patch release explicit and not a magic part of "retry" status
1377         https://bugs.webkit.org/show_bug.cgi?id=47909
1378
1379         All of these typos again due to our inability to unit
1380         test much of this code.  I added one unit test where
1381         possible.  activeworkitems_unittest.py will be in a separate patch.
1382
1383         * QueueStatusServer/handlers/releasepatch.py:
1384         * QueueStatusServer/main.py:
1385         * QueueStatusServer/model/activeworkitems.py:
1386         * QueueStatusServer/model/workitems.py:
1387         * QueueStatusServer/model/workitems_unittest.py:
1388         * QueueStatusServer/templates/releasepatch.html:
1389         * Scripts/webkitpy/common/net/statusserver.py:
1390
1391 2010-10-19  Tony Chang  <tony@chromium.org>
1392
1393         Reviewed by Kent Tamura.
1394
1395         [chromium] Use webkit's TestNetscapePlugIn in DRT mac
1396         https://bugs.webkit.org/show_bug.cgi?id=47850
1397
1398         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
1399             because we're going to name our plugin WebKitTestNetscapePlugIn
1400             temporarily until the chromium forked plugin goes away.
1401
1402 2010-10-19  Eric Seidel  <eric@webkit.org>
1403
1404         Reviewed by Adam Barth.
1405
1406         Make patch release explicit and not a magic part of "retry" status
1407         https://bugs.webkit.org/show_bug.cgi?id=47909
1408
1409         This moves us another step closer to running r+ patches on the EWS bots.
1410         Currently all bots just spam /update-work-items with their list of current
1411         work items.  queues.webkit.org uses that data for display.  As part of making
1412         the EWS run r+ patches, we're moving the official list of patches-to-process
1413         into the server, and feeding them out to bots one at a time.  We need to be
1414         able to remove patches from the queues one at a time instead of just spamming
1415         /update-work-items with a new complete list.  That's what this patch adds.
1416
1417         * QueueStatusServer/handlers/nextpatch.py:
1418         * QueueStatusServer/handlers/queuestatus.py:
1419         * QueueStatusServer/handlers/releasepatch.py: Added.
1420         * QueueStatusServer/handlers/statusbubble_unittest.py:
1421          - Fix a typo causing test failure.  This was not caught by the bots
1422            because they don't have AppEngineLauncher installed and thus don't run
1423            the QueueStatusServer tests.
1424         * QueueStatusServer/handlers/updatestatus.py:
1425         * QueueStatusServer/model/activeworkitems.py:
1426         * QueueStatusServer/templates/releasepatch.html: Added.
1427         * Scripts/webkitpy/common/net/statusserver.py:
1428         * Scripts/webkitpy/tool/commands/queues.py:
1429         * Scripts/webkitpy/tool/mocktool.py:
1430
1431 2010-10-19  Eric Seidel  <eric@webkit.org>
1432
1433         Reviewed by Adam Barth.
1434
1435         cr-mac bubble has caused status bubbles to wrap
1436         https://bugs.webkit.org/show_bug.cgi?id=47928
1437
1438         We now have too many EWSes to fit in the bugs.webkit.org
1439         status-bubble iframe when more than a couple EWS builds are pending.
1440         To fix this I've reduced the space taken up by queue position,
1441         and also moved cr-mac to the end of the list (since it's going to be
1442         triple-digits for a while).
1443
1444         * QueueStatusServer/model/queues.py:
1445         * QueueStatusServer/templates/statusbubble.html:
1446
1447 2010-10-19  Kenneth Russell  <kbr@google.com>
1448
1449         Reviewed by David Levin.
1450
1451         chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
1452         https://bugs.webkit.org/show_bug.cgi?id=47874
1453
1454         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1455         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1456
1457 2010-10-19  Tony Chang  <tony@chromium.org>
1458
1459         Reviewed by Kent Tamura.
1460
1461         [chromium] DumpRenderTree shouldn't put '.' in include path
1462         https://bugs.webkit.org/show_bug.cgi?id=47877
1463
1464         Fix include paths.
1465
1466         * DumpRenderTree/chromium/AccessibilityController.cpp:
1467         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1468         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1469         * DumpRenderTree/chromium/CppBoundClass.cpp:
1470         * DumpRenderTree/chromium/CppVariant.cpp:
1471         * DumpRenderTree/chromium/CppVariant.h:
1472         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1473         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1474         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1475         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1476         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1477         * DumpRenderTree/chromium/EventSender.cpp:
1478         * DumpRenderTree/chromium/EventSender.h:
1479         * DumpRenderTree/chromium/LayoutTestController.cpp:
1480         * DumpRenderTree/chromium/LayoutTestController.h:
1481         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1482         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1483         * DumpRenderTree/chromium/NotificationPresenter.h:
1484         * DumpRenderTree/chromium/PlainTextController.cpp:
1485         * DumpRenderTree/chromium/Task.cpp:
1486         * DumpRenderTree/chromium/TestNavigationController.h:
1487         * DumpRenderTree/chromium/TestShell.cpp:
1488         * DumpRenderTree/chromium/TestWebWorker.h:
1489         * DumpRenderTree/chromium/TextInputController.cpp:
1490         * DumpRenderTree/chromium/WebPreferences.cpp:
1491         * DumpRenderTree/chromium/WebPreferences.h:
1492         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
1493         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
1494         * DumpRenderTree/chromium/WebViewHost.cpp:
1495         * DumpRenderTree/chromium/WebViewHost.h:
1496
1497 2010-10-19  Sam Weinig  <sam@webkit.org>
1498
1499         Reviewed by Dan Bernstein.
1500
1501         Need to include WKErrorRef in the WKPageDidFail... functions
1502         https://bugs.webkit.org/show_bug.cgi?id=47871
1503
1504         Update tools for new parameter in failure callbacks.
1505
1506         * MiniBrowser/mac/BrowserWindowController.m:
1507         (didFailProvisionalLoadWithErrorForFrame):
1508         (didFailLoadWithErrorForFrame):
1509         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1510         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1511         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1512         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1513         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1514         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1516
1517 2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>
1518
1519         Reviewed by Antti Koivisto.
1520
1521         [Qt] WebKit2 MacOS build fix
1522         https://bugs.webkit.org/show_bug.cgi?id=47897
1523
1524         Qt WebKit2 MacOS build fix.
1525
1526         * WebKitTestRunner/PlatformWebView.h:
1527         * WebKitTestRunner/qt/TestControllerQt.cpp:
1528
1529 2010-10-19  Adam Barth  <abarth@webkit.org>
1530
1531         Reviewed by Eric Seidel.
1532
1533         webkit-patch stats the filesystem too many times
1534         https://bugs.webkit.org/show_bug.cgi?id=47883
1535
1536         This patch attempts to cache the list of changed files more agressively
1537         and to use that list to compute the diff instead of stating the file
1538         system again.
1539
1540         * Scripts/webkitpy/common/checkout/api.py:
1541         * Scripts/webkitpy/common/checkout/scm.py:
1542         * Scripts/webkitpy/tool/mocktool.py:
1543         * Scripts/webkitpy/tool/steps/abstractstep.py:
1544         * Scripts/webkitpy/tool/steps/editchangelog.py:
1545         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1546
1547 2010-10-19  David Kilzer  <ddkilzer@apple.com>
1548
1549         <http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
1550
1551         Reviewed by Darin Adler.
1552
1553         * Scripts/sort-Xcode-project-file:
1554         - Don't print an error message about missing arguments when
1555           -h|--help is used.
1556         - Allow Xcode project files to be specified as Project.xcodeproj
1557           instead of Project.xcodeproj/project.pbxproj.
1558
1559 2010-10-18  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1560
1561         Reviewed by Andreas Kling.
1562
1563         [Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
1564         https://bugs.webkit.org/show_bug.cgi?id=47809
1565
1566         Connecting a call to load from the loadFinished signal can cause
1567         re-entrance crashes in WebCore. This patch uses a timer to do so,
1568         also giving some time to subsequent frames to finish loading.
1569
1570         * QtTestBrowser/urlloader.cpp:
1571         (UrlLoader::UrlLoader):
1572         (UrlLoader::loadNext):
1573         (UrlLoader::checkIfFinished):
1574         (UrlLoader::frameLoadStarted):
1575         (UrlLoader::frameLoadFinished):
1576         * QtTestBrowser/urlloader.h:
1577
1578 2010-10-19  Sergio Villar Senín  <svillar@igalia.com>
1579
1580         Reviewed by Xan Lopez.
1581
1582         [GTK] http/history tests are failing
1583         https://bugs.webkit.org/show_bug.cgi?id=36173
1584
1585         Clear the history each time a test is run. Return the actual
1586         history item count when calling
1587         LayoutTestController::webHistoryItemCount
1588
1589         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1590         (resetDefaultsToConsistentValues):
1591         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1592         (LayoutTestController::webHistoryItemCount):
1593
1594 2010-10-18  Eric Seidel  <eric@webkit.org>
1595
1596         Reviewed by Adam Barth.
1597
1598         Add Chromium Mac EWS to the list of queues at queues.webkit.org
1599         https://bugs.webkit.org/show_bug.cgi?id=47878
1600
1601         * QueueStatusServer/model/queues.py:
1602
1603 2010-10-18  Eric Seidel  <eric@webkit.org>
1604
1605         Reviewed by Adam Barth.
1606
1607         queues.webkit.org/next_patch is always 404
1608         https://bugs.webkit.org/show_bug.cgi?id=47881
1609
1610         With the addition of the Queue class, I changed most of the
1611         code to lookup WorkItems using get_or_insert with a key_name
1612         instead of WorkItems.all().filter(queue_name=).
1613         Because the new get_or_insert code uses an explicit key_name
1614         (which is obviously different from the previously autogenerated
1615         ones), there were new WorkItem records created for each queue.
1616         However, some parts of the code still use WorkItems.all().filter,
1617         thus some parts were getting the new record and some parts the old record.
1618
1619         The same basic bug was occurring with ActiveWorkItems, because I
1620         changed the key_name for that class as well.
1621
1622         To fix this I've moved more of the code over to using Queue.*work_items.
1623         I've also enabled the datastore_admin (new in GAE 1.3.8) so that
1624         we can go delete the old WorkItems records.
1625         I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
1626
1627         * QueueStatusServer/app.yaml:
1628         * QueueStatusServer/handlers/queuestatus.py:
1629         * QueueStatusServer/handlers/recentstatus.py:
1630         * QueueStatusServer/handlers/updatestatus.py:
1631         * QueueStatusServer/handlers/updateworkitems.py:
1632
1633 2010-10-18  Eric Seidel  <eric@webkit.org>
1634
1635         Reviewed by Adam Barth.
1636
1637         Correct a bunch of typos in QueueStatusServer
1638         https://bugs.webkit.org/show_bug.cgi?id=47880
1639
1640         These are all due to our complete lack of unit testing in QueueStatusServer.
1641         I added a couple unit tests to cover a few of these fixes, but most of these
1642         are still only caught by actually running the application.
1643
1644         * QueueStatusServer/handlers/nextpatch.py:
1645         * QueueStatusServer/handlers/statusbubble.py:
1646         * QueueStatusServer/handlers/statusbubble_unittest.py: Added.
1647         * QueueStatusServer/handlers/updateworkitems.py:
1648         * QueueStatusServer/model/attachment.py:
1649         * QueueStatusServer/model/queuepropertymixin.py:
1650         * QueueStatusServer/model/queuepropertymixin_unittest.py:
1651         * QueueStatusServer/model/workitems.py:
1652         * QueueStatusServer/model/workitems_unittest.py: Added.
1653
1654 2010-10-18  Adam Barth  <abarth@webkit.org>
1655
1656         Disable this test because it's failing on the bots and the authors
1657         aren't around to fix it.
1658
1659         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1660
1661 2010-10-18  Adam Barth  <abarth@webkit.org>
1662
1663         Reviewed by Eric Seidel.
1664
1665         CC authors of flaky tests when the commit-queue hits a flaky test
1666         https://bugs.webkit.org/show_bug.cgi?id=47872
1667
1668         * Scripts/webkitpy/common/checkout/api.py:
1669         * Scripts/webkitpy/common/net/layouttestresults.py:
1670         * Scripts/webkitpy/tool/commands/queues.py:
1671         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1672         * Scripts/webkitpy/tool/mocktool.py:
1673
1674 2010-10-18  Eric Seidel  <eric@webkit.org>
1675
1676         Reviewed by Adam Barth.
1677
1678         Make it possible to run a chromium-mac-ews builder
1679         https://bugs.webkit.org/show_bug.cgi?id=47876
1680
1681         Since we can't run Mac OS X in a VM, we need to only run committer patches.
1682         There was a multiple inheritance problem which was holding this patch back,
1683         but I decided to just ignore the problem and go with a functional hack for now.
1684
1685         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1686         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1687
1688 2010-10-18  Kenneth Russell  <kbr@google.com>
1689
1690         Reviewed by Tony Chang.
1691
1692         Regression in run_webkit_tests_unittest from r70017
1693         https://bugs.webkit.org/show_bug.cgi?id=47875
1694
1695         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1696
1697 2010-10-18  Adam Barth  <abarth@webkit.org>
1698
1699         Reviewed by Eric Seidel.
1700
1701         Implement webkit-patch suggest-reviewers
1702         https://bugs.webkit.org/show_bug.cgi?id=47866
1703
1704         * Scripts/webkitpy/common/checkout/api.py:
1705             - The main logic.  We look at the last five changes to each
1706               modified (non-ChangeLog) file and collect up the reviewers of
1707               those changes as well as the authors of those changes who are
1708               reviewers.
1709         * Scripts/webkitpy/common/checkout/api_unittest.py:
1710             - Test the logic with some fun mocks.
1711         * Scripts/webkitpy/common/checkout/scm.py:
1712             - Fix a bug when you have local git commits.
1713         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1714             - Test that the bug is fixed.
1715         * Scripts/webkitpy/tool/commands/queries.py:
1716             - Add the query.
1717
1718 2010-10-18  Kenneth Russell  <kbr@google.com>
1719
1720         Reviewed by Eric Seidel.
1721
1722         new-run-webkit-tests produces corrupt PNG baselines on Windows
1723         https://bugs.webkit.org/show_bug.cgi?id=47867
1724
1725         * Scripts/webkitpy/layout_tests/port/base.py:
1726
1727 2010-10-18  Eric Seidel  <eric@webkit.org>
1728
1729         Reviewed by Adam Barth.
1730
1731         Make it possible to submit patches to the EWS bots
1732         https://bugs.webkit.org/show_bug.cgi?id=47869
1733
1734         * QueueStatusServer/handlers/nextpatch.py:
1735          - Move more logic into Queue, so that it can be shared with SubmitToEWS.
1736         * QueueStatusServer/handlers/queuestatus.py:
1737          - Fix two typos from a previous commit.
1738         * QueueStatusServer/handlers/submittoews.py: Added.
1739         * QueueStatusServer/handlers/updatestatus.py:
1740          - Use the new is_retry_request method to share this (hacky) code with SubmitToEWS
1741         * QueueStatusServer/main.py:
1742          - Add /submit-to-ews
1743         * QueueStatusServer/model/queuepropertymixin.py:
1744          - Fix circular imports caused by adding Queue.work_items()
1745         * QueueStatusServer/model/queues.py:
1746          - Add work_items() and active_work_items()
1747         * QueueStatusServer/model/queuestatus.py:
1748         * QueueStatusServer/model/workitems.py:
1749          - Add transaction-safe add/remove methods.
1750         * QueueStatusServer/templates/submittoews.html: Added.
1751
1752 2010-10-18  Eric Seidel  <eric@webkit.org>
1753
1754         Reviewed by Adam Barth.
1755
1756         Deploy Queue class in more places throughout QueueStatusServer
1757         https://bugs.webkit.org/show_bug.cgi?id=47855
1758
1759         I also caught two typos from the previous change.  Unfortunately
1760         I don't yet know how to unittest request handlers yet.
1761
1762         * QueueStatusServer/handlers/dashboard.py:
1763         * QueueStatusServer/handlers/statusbubble.py:
1764         * QueueStatusServer/handlers/updateworkitems.py:
1765         * QueueStatusServer/model/activeworkitems.py:
1766         * QueueStatusServer/model/attachment.py:
1767         * QueueStatusServer/model/queuepropertymixin.py: Added.
1768         * QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
1769         * QueueStatusServer/model/queuestatus.py:
1770         * QueueStatusServer/model/workitems.py:
1771
1772 2010-10-18  Adam Barth  <abarth@webkit.org>
1773
1774         Reviewed by Eric Seidel.
1775
1776         scm.py should be able tell us what revisions made changes to a given file
1777         https://bugs.webkit.org/show_bug.cgi?id=47863
1778
1779         Look again, your SCM.py can now log files.
1780
1781         * Scripts/webkitpy/common/checkout/scm.py:
1782         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1783
1784 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1785
1786         Reviewed by Eric Siedel.
1787
1788         new-run-webkit-tests: clean up the options-parsing code in the port
1789         classes.
1790         
1791         This change modifies the Port interface to have a get_option() and
1792         set_option_default() method for accessing the options argument
1793         passed to the constructor. If the constructor is not passed an
1794         options argument, we default to a MockOptions() argument from
1795         mocktool, which has the same semantics we want.
1796
1797         Note that there is a disadvantage to port.get_option('foo') over
1798         port._options.foo, which is that you lose some of the checking
1799         for whether 'foo' is set (typos result in the default value, not
1800         an exception being raised. This is desired in this case, since the
1801         Port class is not allowed to assume that options does have any
1802         particular values set, and so this change ensures that all of
1803         the subclasses are following the same, intended, logic.
1804
1805         Arguably this is the wrong semantics to have, and the Port
1806         classes should be able to assume a default set of
1807         attributes/arguments, but that change will need to wait for a
1808         different CL where we can modify new-run-webkit-tests to pull a
1809         list of arguments from the port factory routines.
1810
1811         Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
1812
1813         https://bugs.webkit.org/show_bug.cgi?id=47510
1814
1815         * Scripts/webkitpy/layout_tests/port/base.py:
1816         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1817         * Scripts/webkitpy/layout_tests/port/chromium.py:
1818         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1819         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1820         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1821         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1822         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1823         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1824         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1825         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1826         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1827         * Scripts/webkitpy/layout_tests/port/test.py:
1828         * Scripts/webkitpy/layout_tests/port/webkit.py:
1829         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1830         * Scripts/webkitpy/tool/mocktool_unittest.py: Added.
1831
1832 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1833
1834         Reviewed by Eric Seidel.
1835
1836         Re-submit a revised version of r69638 - enabling new-run-webkit-tests
1837         under cygwin. The initial version had a bug in base:uri_to_test_name
1838         that was causing tests to fail. This version corrects that bug, but
1839         also makes the code safer by calling cygpath more reliably, and
1840         leaving a long-running cygpath process open.
1841
1842         This patch also corrects a couple of minor bugs in http_lock_unittest,
1843         chromium_unittest, and dedpulicate_tests_unittest that showed up
1844         while testing this.
1845
1846         https://bugs.webkit.org/show_bug.cgi?id=47220
1847
1848         * Scripts/webkitpy/common/system/path.py:
1849         * Scripts/webkitpy/common/system/path_unittest.py:
1850         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1851         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1852         * Scripts/webkitpy/layout_tests/port/base.py:
1853         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1854         * Scripts/webkitpy/layout_tests/port/chromium.py:
1855         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1856         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1857         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1858
1859 2010-10-18  Eric Seidel  <eric@webkit.org>
1860
1861         Reviewed by Adam Barth.
1862
1863         Add Queue class and add minimal unittesting of QueueStatusServer code
1864         https://bugs.webkit.org/show_bug.cgi?id=47847
1865
1866         * QueueStatusServer/handlers/dashboard.py:
1867         * QueueStatusServer/handlers/queuestatus.py:
1868         * QueueStatusServer/handlers/recentstatus.py:
1869         * QueueStatusServer/handlers/statusbubble.py:
1870         * QueueStatusServer/handlers/updateworkitems.py:
1871         * QueueStatusServer/model/attachment.py:
1872         * QueueStatusServer/model/queues.py:
1873         * QueueStatusServer/model/queues_unittest.py: Added.
1874         * QueueStatusServer/model/svnrevision.py:
1875         * Scripts/test-webkitpy:
1876         * Scripts/webkitpy/test/main.py:
1877
1878 2010-10-18  Anders Carlsson  <andersca@apple.com>
1879
1880         Fix build.
1881
1882         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1883         (handleEventCarbon):
1884
1885 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
1886
1887         Reviewed by Eric Seidel.
1888
1889         Switch to using the new Carbon NPAPI event declarations, and remove
1890         the old ones.
1891
1892         https://bugs.webkit.org/show_bug.cgi?id=40784
1893
1894         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1895         (handleEventCarbon):
1896
1897 2010-10-18  David Levin  <levin@chromium.org>
1898
1899         Reviewed by Adam Barth.
1900
1901         check-webkit-style should treat the GObject binding directory like other GTK directories.
1902         https://bugs.webkit.org/show_bug.cgi?id=47796
1903
1904         * Scripts/webkitpy/style/checker.py: Added the GObject binding directory
1905         with the other gtk directories (and fixed typo).
1906
1907 2010-10-18  David Levin  <levin@chromium.org>
1908
1909         Reviewed by Oliver Hunt.
1910
1911         check-webkit-style needs to ignore underscores in opcode names and vm_throw
1912         https://bugs.webkit.org/show_bug.cgi?id=47789
1913
1914         * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
1915         * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
1916         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
1917
1918 2010-10-18  MORITA Hajime  <morrita@google.com>
1919
1920         Reviewed by Kent Tamura.
1921
1922         TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
1923         https://bugs.webkit.org/show_bug.cgi?id=47659
1924         
1925         Moved hasSpellingMarkers() from TextInputController to
1926         LayoutTestController.  Currently the implementation is available
1927         only for Mac and for Chromium.
1928
1929         * DumpRenderTree/LayoutTestController.cpp:
1930         (hasSpellingMarkerCallback):
1931         (LayoutTestController::staticFunctions):
1932         * DumpRenderTree/LayoutTestController.h:
1933         * DumpRenderTree/chromium/LayoutTestController.cpp:
1934         (LayoutTestController::LayoutTestController):
1935         (LayoutTestController::hasSpellingMarker):
1936         * DumpRenderTree/chromium/LayoutTestController.h:
1937         * DumpRenderTree/chromium/TextInputController.cpp:
1938         (TextInputController::TextInputController):
1939         (TextInputController::makeAttributedString):
1940         * DumpRenderTree/chromium/TextInputController.h:
1941         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1942         (LayoutTestController::hasSpellingMarker):
1943         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1944         (LayoutTestController::hasSpellingMarker):
1945         * DumpRenderTree/mac/TextInputController.m:
1946         (+[TextInputController isSelectorExcludedFromWebScript:]):
1947         (+[TextInputController webScriptNameForSelector:]):
1948         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1949         (LayoutTestController::hasSpellingMarker):
1950         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1951         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1952         (LayoutTestController::hasSpellingMarker):
1953         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1954         (LayoutTestController::hasSpellingMarker):
1955
1956 2010-10-18  Adam Barth  <abarth@webkit.org>
1957
1958         Reviewed by David Levin.
1959
1960         commit-queue's flaky test notice is very Pythony
1961         https://bugs.webkit.org/show_bug.cgi?id=47790
1962
1963         This patch make the list of tests delimted by \n instead of just
1964         converting the array to a string.
1965
1966         * Scripts/webkitpy/tool/commands/queues.py:
1967         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1968
1969 2010-10-14  Antonio Gomes  <agomes@rim.com>
1970
1971         Reviewed by Martin Robinson and Xan Lopez.
1972
1973         [Gtk]: DRT does not support frame flattening testing
1974         https://bugs.webkit.org/show_bug.cgi?id=38650
1975
1976         Implement DRT's support for toggling on/off frame flattening
1977         support.
1978
1979         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1980         (resetDefaultsToConsistentValues):
1981         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1982         (LayoutTestController::setFrameFlatteningEnabled):
1983
1984 2010-10-15  Dirk Pranke  <dpranke@chromium.org>
1985
1986         Reviewed by Eric Siedel.
1987
1988         mocktool.MockOptions is inheriting from Mock, which has the side
1989         effect of defaulting any attribute to another MockObject. So,
1990         MockOptions().foo would always evaluate to true. This was
1991         covering over bugs in the unit tests, and is probably the wrong
1992         default behavior for anything attempting to mock out the options
1993         argument returned from optparse.parse_args().
1994
1995         This patch changes the default behavior. The new MockOptions()
1996         class takes an optional list of keyword parameters to set; this
1997         patch doesn't use that feature but the fix for bug 47510 will.
1998
1999         Also, this patch just fills in the default values necessary to
2000         get all of the tests to pass; I didn't stare at each test by
2001         hand to determine the "right" values. We can either fix that in
2002         subsequent patches or let me know if we want to do that now (and
2003         give me some guidance on what those values might want to be).
2004
2005         https://bugs.webkit.org/show_bug.cgi?id=47709
2006
2007         * Scripts/webkitpy/tool/commands/commandtest.py:
2008         * Scripts/webkitpy/tool/commands/download_unittest.py:
2009         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2010         * Scripts/webkitpy/tool/mocktool.py:
2011         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2012         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2013
2014 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
2015
2016         Fix the build; need to add new slot to PageUIClient callbacks.
2017
2018         * MiniBrowser/mac/BrowserWindowController.m:
2019         (-[BrowserWindowController awakeFromNib]):
2020         * WebKitTestRunner/TestController.cpp:
2021         (WTR::createOtherPage):
2022         (WTR::TestController::initialize):
2023
2024 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
2025
2026         Add Matt Delaney to committers.py.
2027
2028         * Scripts/webkitpy/common/config/committers.py:
2029
2030 2010-10-15  Tony Chang  <tony@chromium.org>
2031
2032         Reviewed by Kent Tamura.
2033
2034         [chromium] compile TestNetscapePlugIn on Chromium mac
2035         https://bugs.webkit.org/show_bug.cgi?id=47633
2036
2037         * DumpRenderTree/DumpRenderTree.gypi: files to compile
2038         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
2039         (NP_GetEntryPoints):
2040         (NPP_New):
2041         (NPP_Destroy):
2042         (NPP_HandleEvent):
2043         (NPP_GetValue):
2044         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
2045         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
2046         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
2047
2048 2010-10-15  Leandro Pereira  <leandro@profusion.mobi>
2049
2050         Reviewed by Gustavo Noronha Silva.
2051
2052         build-webkit: Should die when make fails when build a CMake project
2053         https://bugs.webkit.org/show_bug.cgi?id=47726
2054
2055         * Scripts/webkitdirs.pm: If make fails, die immediately.
2056
2057 2010-10-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2058
2059         Unreviewed, rolling out r69809.
2060         http://trac.webkit.org/changeset/69809
2061         https://bugs.webkit.org/show_bug.cgi?id=47725
2062
2063         Broke chromium mac compile (Requested by japhet on #webkit).
2064
2065         * DumpRenderTree/DumpRenderTree.gypi:
2066         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2067         (NP_GetEntryPoints):
2068         (NPP_New):
2069         (NPP_Destroy):
2070         (NPP_HandleEvent):
2071         (NPP_GetValue):
2072         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
2073         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2074         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
2075
2076 2010-10-15  Adam Barth  <abarth@webkit.org>
2077
2078         Reviewed by Adam Barth.
2079
2080         test-webkitpy fails on Linux
2081         https://bugs.webkit.org/show_bug.cgi?id=47713
2082
2083         The old code failed on Linux because the MacPort tries to read
2084         something out of platform that doesn't make sense on Linux.
2085
2086         * Scripts/webkitpy/tool/mocktool.py:
2087
2088 2010-10-14  Balazs Kelemen  <kbalazs@webkit.org>
2089
2090         Reviewed by Kenneth Rohde Christiansen.
2091
2092         [Qt] WTR is sloooow
2093         https://bugs.webkit.org/show_bug.cgi?id=47695
2094
2095         * WebKitTestRunner/qt/TestControllerQt.cpp:
2096         Change the timer interval of RunUntilConditionLoop from
2097         50 milliseconds to 1 to avoid wasting time after the 
2098         test had been finished.
2099
2100 2010-10-14  Eric Seidel  <eric@webkit.org>
2101
2102         Unreviewed, just fixing an exception seen on the commit-queue.
2103
2104         I should have unit tested this function before.
2105
2106         * Scripts/webkitpy/tool/commands/queues.py:
2107         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2108
2109 2010-10-14  Eric Seidel  <eric@webkit.org>
2110
2111         Reviewed by Adam Barth.
2112
2113         commit-queue should not fail patches due to flaky tests
2114         https://bugs.webkit.org/show_bug.cgi?id=47647
2115
2116         This patch makes it so that the *same* flaky test has to fail
2117         twice in a row to have a false negative from a flaky test.
2118
2119         If different flaky tests fail (or if a test fails and then passes
2120         in a second run) then we will warn in the bug that we encountered
2121         a flaky test.
2122
2123         This patch grew to include moving port off of steps onto tool
2124         (which Adam wrote and then I integrated), as well as removing the
2125         use of tool from CommitQueueTask.
2126
2127         * Scripts/webkitpy/common/config/ports.py:
2128          - Added a layout_test_results_path method.  This covers old-run-webkit-tests
2129            but doesn't cover NRWT.  This is probably not the long term solution, but
2130            putting this knowledge on port makes more sense than in LayoutTestResults.
2131         * Scripts/webkitpy/common/net/buildbot.py:
2132          - LayoutTestResults shouldn't know how to fetch from the network, make
2133            the Build code do that instead.
2134         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2135          - Code style fix.
2136         * Scripts/webkitpy/common/net/layouttestresults.py:
2137          - Remove code for reading from the network.
2138         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2139          - Test the new entrypoint.
2140         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2141          - Make the delegate interface explicit.
2142          - Remove the _tool member, since using the delegate for
2143            everything is cleaner.
2144          - Teach the testing logic how to deal with flaky tests.
2145         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2146          - Update to match the CommitQueueTask changes.
2147         * Scripts/webkitpy/tool/commands/queues.py:
2148          - Use the new CommitQueueTaskDelegate interface.
2149         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2150          - Fix the SecondThoughtsCommitQueue test which was broken.
2151          - Add a new test to make sure the flaky test reporting works.
2152         * Scripts/webkitpy/tool/main.py:
2153          - Store the port on the tool object.
2154         * Scripts/webkitpy/tool/mocktool.py:
2155          - Add a port() accessor to MockTool
2156         * Scripts/webkitpy/tool/steps/abstractstep.py:
2157          - Move port() off of Step and onto Tool.
2158         * Scripts/webkitpy/tool/steps/build.py:
2159         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2160         * Scripts/webkitpy/tool/steps/runtests.py:
2161         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2162          - Two tests with the same name!  only the latter was being run.
2163         * Scripts/webkitpy/tool/steps/update.py:
2164
2165 2010-10-14  Dirk Pranke  <dpranke@chromium.org>
2166
2167         Reviewed by Eric Seidel.
2168
2169         new-run-webkit-tests will now handle missing Ruby installs (or
2170         missing PrettyPatch scripts) more cleanly - previously this
2171         would be detected when we actually tried to create the diff, and
2172         the error message was obscure. Now we'll log a warning up front
2173         and otherwise be silent.
2174
2175         This change also refactors some global variables to be class or
2176         instance variables to be slightly more testable and more
2177         modular. There are no cases where we create lots of port objects
2178         and can't afford to test for configurations repeatedly, so
2179         there's no performance concern here.
2180
2181         https://bugs.webkit.org/show_bug.cgi?id=47466
2182
2183         * Scripts/webkitpy/layout_tests/port/base.py:
2184         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2185         * Scripts/webkitpy/layout_tests/port/chromium.py:
2186
2187 2010-10-08  Martin Robinson  <mrobinson@igalia.com>
2188
2189         Reviewed by Xan Lopez.
2190
2191         [GTK] Form controls do not respect GTK+ font size
2192         https://bugs.webkit.org/show_bug.cgi?id=47134
2193
2194         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2195         (initializeGtkFontSettings): Initialize the font control size when running
2196         DumpRenderTree to a standard value.
2197
2198 2010-10-14  Tony Chang  <tony@chromium.org>
2199
2200         Reviewed by Kent Tamura.
2201
2202         [chromium] compile TestNetscapePlugIn on Chromium mac
2203         https://bugs.webkit.org/show_bug.cgi?id=47633
2204
2205         * DumpRenderTree/DumpRenderTree.gypi: files to compile
2206         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
2207         (NP_GetEntryPoints):
2208         (NPP_New):
2209         (NPP_Destroy):
2210         (NPP_HandleEvent):
2211         (NPP_GetValue):
2212         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
2213         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
2214         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
2215
2216 2010-10-14  Victor Wang  <victorw@chromium.org>
2217
2218         Reviewed by Nate Chapin.
2219
2220         [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
2221
2222         https://bugs.webkit.org/show_bug.cgi?id=47686
2223
2224         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2225
2226 2010-10-14  Eric Seidel  <eric@webkit.org>
2227
2228         Reviewed by Adam Barth.
2229
2230         test-webkitpy spews Delegate terminated queue messages
2231         https://bugs.webkit.org/show_bug.cgi?id=47678
2232
2233         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2234
2235 2010-10-14  Adam Roben  <aroben@apple.com>
2236
2237         Test that pressing the Alt key generates a WM_SYSCOMMAND message
2238
2239         Test for <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
2240         the Alt key when MiniBrowser's WKView is focused doesn't send focus to
2241         the menu bar
2242
2243         Reviewed by Steve Falkenburg.
2244
2245         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
2246         TestWebKitAPI/win to the include path so that WindowMessageObserver
2247         can be found.
2248
2249         * TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
2250         Windows-specific members.
2251         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
2252         Added this simple setter.
2253
2254         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
2255         (TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
2256         Initialize our lone data member.
2257         (TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
2258         Simple getter.
2259         (TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
2260         when a WM_SYSCOMMAND message is received.
2261         (TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
2262         WM_SYSKEYUP message is not handled.
2263         (TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
2264         pressing the Alt key and check that a WM_SYSCOMMAND message got sent
2265         to the WKView's parent window.
2266
2267         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2268         (TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
2269         member function so it could access PlatformWebView::wndProc. Use
2270         PlatformWebView::wndProc as the WNDPROC.
2271         (TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
2272         data member and pass the this pointer to CreateWindowEx so we can
2273         store it on the HWND.
2274         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
2275         constants from here to the top of the file.
2276         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
2277         the same messages that Notepad receives when you press the Alt key.
2278         (TestWebKitAPI::PlatformWebView::wndProc): Added.
2279           - When WM_CREATE is received, we set the PlatformWebView instance
2280             pointer as a property on the HWND so we can access it later.
2281           - For other messages, we try to get the PlatformWebView instance
2282             pointer from the HWND property.
2283           - When WM_NCDESTROY is received (which is the last message we will
2284             receive), we remove the PlatformWebView instance property.
2285           - Pass messages to the parent window's message observer, if there is
2286             one.
2287           - Pass all messages through to ::DefWindowProcW.
2288
2289         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
2290         and AltKeyGeneratesWMSysCommand.
2291
2292         * TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
2293         used to observe messages sent to one or more windows.
2294
2295 2010-10-01  Martin Robinson  <mrobinson@igalia.com>
2296
2297         Reviewed by Holger Freyther.
2298
2299         [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
2300         https://bugs.webkit.org/show_bug.cgi?id=47033
2301
2302         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2303         (initializeGtkFontSettings): Added this method which initializes XSettings
2304         font settings to consistent values before running a test. For the one test
2305         in which we need subpixel aliasing turned on, do that.
2306         (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
2307         (runTest): Pass the testURL to initializeFonts.
2308
2309 2010-10-14  Adam Barth  <abarth@webkit.org>
2310
2311         Reviewed by Eric Seidel.
2312
2313         ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
2314         https://bugs.webkit.org/show_bug.cgi?id=47655
2315
2316         * Scripts/webkitpy/common/config/ports.py:
2317         * Scripts/webkitpy/common/config/ports_unittest.py:
2318
2319 2010-10-13  Eric Seidel  <eric@webkit.org>
2320
2321         Reviewed by Adam Barth.
2322
2323         beat diff_parser with the ugly stick
2324         https://bugs.webkit.org/show_bug.cgi?id=47626
2325
2326         * Scripts/webkitpy/common/checkout/diff_parser.py:
2327         * Scripts/webkitpy/style/patchreader.py:
2328         * Scripts/webkitpy/style/patchreader_unittest.py:
2329
2330 2010-10-13  Eric Seidel  <eric@webkit.org>
2331
2332         Reviewed by Adam Barth.
2333
2334         Break LayoutTestResults out into its own file
2335         https://bugs.webkit.org/show_bug.cgi?id=47637
2336
2337         * Scripts/webkitpy/common/net/buildbot.py:
2338         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2339         * Scripts/webkitpy/common/net/layouttestresults.py: Added.
2340         * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
2341
2342 2010-10-13  Adam Barth  <abarth@webkit.org>
2343
2344         Unreviewed.
2345
2346         Chromium port can't run JavaScriptCore tests
2347         https://bugs.webkit.org/show_bug.cgi?id=47654
2348
2349         This lets webkit-patch build-and-test work on Chromium.
2350
2351         * Scripts/webkitpy/common/config/ports.py:
2352         * Scripts/webkitpy/tool/steps/runtests.py:
2353
2354 2010-10-13  Adam Barth  <abarth@webkit.org>
2355
2356         Reviewed by Eric Seidel.
2357
2358         Make --port a global option and pass the port information to the commit-queue subprocess
2359         https://bugs.webkit.org/show_bug.cgi?id=47650
2360
2361         This patch paves the way to run the commit-queue on a non-Mac port.
2362
2363         * Scripts/webkitpy/tool/commands/queues.py:
2364         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2365         * Scripts/webkitpy/tool/commands/queuestest.py:
2366         * Scripts/webkitpy/tool/main.py:
2367         * Scripts/webkitpy/tool/steps/options.py:
2368         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2369         * Scripts/webkitpy/tool/steps/runtests.py:
2370         * Scripts/webkitpy/tool/steps/update.py:
2371
2372 2010-10-13  Adam Barth  <abarth@webkit.org>
2373
2374         Reviewed by Eric Seidel.
2375
2376         Introduce the ChromiumXVFBPort for running commit-queue on EC2
2377         https://bugs.webkit.org/show_bug.cgi?id=47653
2378
2379         I'm not entirely sure this is the best way to do this, but we need to
2380         run the tests under XVFB on EC2 because the EC2 instances don't have a
2381         real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
2382         that way.  The idea is that XVFB is like a platform for the Chromium
2383         port, but we don't have a real notion of platform separate from port.
2384
2385         * Scripts/webkitpy/common/config/ports.py:
2386
2387 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
2388
2389         Reviewed by Martin Robinson.
2390
2391         [GTK] Add HTTP caching support
2392         https://bugs.webkit.org/show_bug.cgi?id=44261
2393
2394         Add include paths for the new soup HTTP cache code.
2395
2396         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
2397
2398 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
2399
2400         Reviewed by Antonio Gomes.
2401
2402         [Qt] QtTestBrowser shows two Url input fields
2403         https://bugs.webkit.org/show_bug.cgi?id=47613
2404
2405         * QtTestBrowser/mainwindow.cpp:
2406         (MainWindow::MainWindow):
2407         (MainWindow::buildUI):
2408
2409 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
2410
2411         Reviewed by Tony Chang.
2412
2413         [gdb] Add pretty-print supports for UString, Identifier and JSString
2414         https://bugs.webkit.org/show_bug.cgi?id=47601
2415
2416         * gdb/webkit.py:
2417
2418 2010-10-13  Adam Barth  <abarth@webkit.org>
2419
2420         Reviewed by Eric Seidel.
2421
2422         Add list of Ubuntu packages needed by the EWS bots
2423         https://bugs.webkit.org/show_bug.cgi?id=47628
2424
2425         I've been copy/pasting this list between bots, but it's better to have
2426         this checked in.
2427
2428         * EWSTools/ubuntu-ews-packages: Added.
2429
2430 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
2431
2432         Reviewed by Csaba Osztrogonác.
2433
2434         [EFL] Adds a build slave.
2435         https://bugs.webkit.org/show_bug.cgi?id=47290
2436
2437         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2438         entry for a release build of the EFL port.
2439         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2440         flag to build the EFL port.
2441
2442 2010-10-13  Adam Barth  <abarth@webkit.org>
2443
2444         Reviewed by Csaba Osztrogonác.
2445
2446         webkit-patch build shouldn't need --build to actually build!
2447         https://bugs.webkit.org/show_bug.cgi?id=47438
2448
2449         Yeah, requiring --build for the build command is really dumb.  We did
2450         this originally because the build step is usually optional in other
2451         commands.  We don't have a good way of reversing the default for an
2452         option in one command.  This approach is slightly hacky since --build
2453         still shows up as an option on the help page, but at least it makes
2454         progress.  Passing --build is harmless, so the EWS bots shouldn't
2455         explode because of this change.
2456
2457         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2458         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2459         * Scripts/webkitpy/tool/commands/download.py:
2460         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2461         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2462
2463 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2464
2465         Unreviewed, rolling out r69638.
2466         http://trac.webkit.org/changeset/69638
2467         https://bugs.webkit.org/show_bug.cgi?id=47595
2468
2469         "Broke win and chromium-win bots" (Requested by dglazkov on
2470         #webkit).
2471
2472         * Scripts/webkitpy/common/system/path.py:
2473         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2474         * Scripts/webkitpy/layout_tests/port/base.py:
2475         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2476         * Scripts/webkitpy/layout_tests/port/chromium.py:
2477         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2478
2479 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
2480
2481         Reviewed by Steve Block.
2482
2483         First step towards client-based Geolocation in Chromium. Build
2484         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
2485         https://bugs.webkit.org/show_bug.cgi?id=47586
2486
2487         * DumpRenderTree/chromium/WebViewHost.cpp:
2488         * DumpRenderTree/chromium/WebViewHost.h:
2489
2490 2010-10-13  Adam Roben  <aroben@apple.com>
2491
2492         Test that pressing the spacebar in a text field does not scroll the
2493         document
2494
2495         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
2496         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
2497         insert a space, scrolls the page instead
2498
2499         Reviewed by Sam Weinig.
2500
2501         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
2502
2503         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
2504
2505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2506         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2507         * TestWebKitAPI/win/copy-resources.cmd:
2508         Added new files.
2509
2510         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
2511         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
2512         We use this to track what the result of calling into JavaScript was.
2513         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
2514         finishes loading.
2515         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
2516         event is not handled.
2517         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
2518         executing and whether the result matched our expectation.
2519         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
2520         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
2521         complete, and returns whether we got back the expected result.
2522         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
2523         spacebar inside a text field does not scroll the document and that
2524         pressing it outside the text field does scroll the document.
2525
2526         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
2527
2528         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2529         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
2530
2531         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2532         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
2533         code from DRT's EventSendingController.
2534
2535         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2536         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
2537
2538         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2539         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
2540         same messages that get sent when you press spacebar in Notepad.
2541
2542 2010-10-13  Adam Roben  <aroben@apple.com>
2543
2544         Fix a couple of issues with the TestWebKitAPI build
2545
2546         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
2547         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
2548         Fixed a typo.
2549
2550         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
2551         to set our output and intermediate directories so that we don't spew
2552         files into the source tree.
2553
2554 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
2555
2556         Reviewed by Csaba Osztrogonác.
2557
2558         WTR should accept relative paths
2559         https://bugs.webkit.org/show_bug.cgi?id=47486
2560
2561         * WebKitTestRunner/StringFunctions.h:
2562         * WebKitTestRunner/TestInvocation.cpp:
2563         (WTR::createWKURL): Moved from StringFunctions.h since it is
2564         used only here. Extend relative paths to absolute.
2565
2566 2010-10-12  Adam Roben  <aroben@apple.com>
2567
2568         Make TestWebKitAPI work on Windows
2569
2570         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
2571
2572         Reviewed by Sam Weinig.
2573
2574         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
2575
2576         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
2577         run on Windows.
2578         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
2579         on unsupported platforms.
2580         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
2581         die on other platforms. Extracted some formerly-Mac-specific code to
2582         be cross-platform and made it handle any style of line-endings.
2583
2584         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
2585         Links against CFLite.
2586
2587         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
2588         Contains most properties for the project.
2589
2590         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
2591         Added. Links against CoreFoundation.
2592
2593         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
2594         section and moved the cross-platform section after the
2595         platform-specific parts.
2596
2597         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2598         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
2599         done.
2600         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
2601         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
2602         resource path.
2603         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
2604         WKURL.
2605
2606         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2607         (TestWebKitAPI::registerWindowClass):
2608         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2609         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2610         (TestWebKitAPI::PlatformWebView::page):
2611         This was mostly copied from WebKitTestRunner's PlatformWebView.
2612
2613         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
2614         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
2615         build-api-tests script.
2616
2617         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
2618         TestWebKitAPI.exe.
2619
2620         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
2621         through to copy-resources.cmd.
2622
2623         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
2624         or deletes resources from TestWebKitAPI.resources.
2625
2626         * TestWebKitAPI/win/main.cpp: Added.
2627         (main): Calls through to TestsController.
2628
2629 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2630
2631         Reviewed by Kenneth Rohde Christiansen.
2632
2633         [EFL] Support viewport configuration and add new arguments for WebKit EFL
2634         https://bugs.webkit.org/show_bug.cgi?id=47084
2635
2636         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
2637         needs to be modified according to the changes.
2638
2639         * EWebLauncher/main.c:
2640         (on_viewport_changed):
2641
2642 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
2643
2644         Reviewed by Eric Seidel.
2645
2646         This patch enables new-run-webkit-tests (in particular the
2647         chromium-win port) to run under Cygwin as well as Win32. Mostly
2648         this just required some conversions from cygwin paths to Win32
2649         paths when we spawn off Win32 binaries like test_shell.
2650
2651         https://bugs.webkit.org/show_bug.cgi?id=47220
2652
2653         * Scripts/webkitpy/common/system/path.py:
2654         - Expose the cygpath() function for path conversion
2655
2656         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2657         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2658         - shift filename->uri conversion in the TestInfo objects to the
2659           dump_render_tree thread
2660
2661         * Scripts/webkitpy/layout_tests/port/base.py:
2662         * Scripts/webkitpy/layout_tests/port/chromium.py:
2663         - use cygpath()
2664
2665 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
2666
2667         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
2668
2669         * Scripts/webkitpy/common/config/committers.py:
2670
2671 2010-10-12  Sam Weinig  <sam@webkit.org>
2672
2673         Reviewed by Dan Bernstein.
2674
2675         When a provisional load fails, the provisional URL returned
2676         from WKFrameCopyProvisionalURL should be empty
2677         <rdar://problem/8540878>
2678         https://bugs.webkit.org/show_bug.cgi?id=47546
2679
2680         Add test.
2681
2682         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2683         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2684
2685 2010-10-12  Anders Carlsson  <andersca@apple.com>
2686
2687         Reviewed by Sam Weinig.
2688
2689         Start fleshing out find page overlays
2690         https://bugs.webkit.org/show_bug.cgi?id=47559
2691
2692         * MiniBrowser/mac/BrowserWindowController.m:
2693         (-[BrowserWindowController find:]):
2694         Pass kWKFindOptionsShowOverlay to WKPageFindString.
2695
2696 2010-10-12  Robert Hogan  <robert@webkit.org>
2697
2698         Reviewed by Antonio Gomes.
2699
2700         [Qt] editing/input/emacs-ctrl-o.html
2701
2702         ctrl-o is bound to a sequence of commands on Mac, namely:
2703         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
2704         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
2705         result we only issue one command, so don't generate the change in caret
2706         position that results in the extra editing delegate messages.
2707
2708         So for the sake of not managing suspicious-looking differences, just
2709         make DRT issue the appropriate edit commands to pass the test.
2710
2711         https://bugs.webkit.org/show_bug.cgi?id=47548
2712
2713         * DumpRenderTree/qt/EventSenderQt.cpp:
2714         (EventSender::keyDown):
2715
2716 2010-10-12  Anders Carlsson  <andersca@apple.com>
2717
2718         Reviewed by Sam Weinig.
2719
2720         Add a simple Find UI to MiniBrowser
2721         https://bugs.webkit.org/show_bug.cgi?id=47553
2722
2723         * MiniBrowser/mac/BrowserWindow.xib:
2724         Add Find panel.
2725
2726         * MiniBrowser/mac/BrowserWindowController.h:
2727         * MiniBrowser/mac/BrowserWindowController.m:
2728         (-[BrowserWindowController performFindPanelAction:]):
2729         Show the find panel.
2730
2731         (-[BrowserWindowController find:]):
2732         Tell the WKPageRef to find the given string.
2733
2734 2010-10-12  Tony Chang  <tony@chromium.org>
2735
2736         Unreviewed, fixing DRT compile on Windows after r69586.
2737
2738         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2739
2740 2010-10-12  Tony Chang  <tony@chromium.org>
2741
2742         Unreviewed, trying to fix NRWT on Windows.
2743
2744         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2745
2746 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
2747
2748         Reviewed by Kenneth Rohde Christiansen.
2749
2750         [Qt][WTR] Checking the path of the injected bundle is bogus
2751         https://bugs.webkit.org/show_bug.cgi?id=47541
2752
2753         * WebKitTestRunner/qt/TestControllerQt.cpp:
2754         (WTR::isExistingLibrary): Added (static helper).
2755         Extend the path with the appropriate suffix(es) on the
2756         platform and check that the file exists.
2757         (WTR::TestController::initializeInjectedBundlePath):
2758         There were two bugs with the path checking:
2759             - the condition should have been inverted
2760             - QLibrary::fileName does not give back the filename
2761               with the library suffix so we cannot check
2762               that existance of the file this way.
2763
2764 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2765
2766         Reviewed by Tony Chang.
2767
2768         Implement http locking in NRWT.
2769         https://bugs.webkit.org/show_bug.cgi?id=47072
2770
2771         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2772         * Scripts/webkitpy/layout_tests/port/base.py:
2773         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
2774         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
2775         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2776
2777 2010-10-12  Mark Rowe  <mrowe@apple.com>
2778
2779         Fix the 32-bit WebKit2 build.
2780
2781         * MiniBrowser/mac/BrowserWindowController.m:
2782         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
2783         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
2784
2785 2010-10-11  Tony Chang  <tony@chromium.org>
2786
2787         Reviewed by Adam Barth.
2788
2789         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
2790         https://bugs.webkit.org/show_bug.cgi?id=47513
2791
2792         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
2793         which doesn't actually work.
2794
2795         * Scripts/webkitpy/common/config/committers.py:
2796
2797 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
2798
2799         Reviewed by Dmitry Titov.
2800
2801         Added support for showModalDialog on chromium port.
2802
2803         Implement showModalDialog for Layout tests for chromium port
2804         https://bugs.webkit.org/show_bug.cgi?id=46759
2805
2806         * DumpRenderTree/chromium/WebViewHost.cpp:
2807         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
2808         (WebViewHost::runModal):  Start a nested message loop and remember that.
2809         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
2810         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
2811
2812 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
2813
2814         Reviewed by Gustavo Noronha Silva.
2815
2816         [GTK] Cleanup font selection code for the Freetype backend
2817         https://bugs.webkit.org/show_bug.cgi?id=47503
2818
2819         Update DRT to set values for the cursive and fantasy font families, so
2820         that we can generate consistent results for tests that use these families.
2821         Add some missing information to fonts.conf.
2822
2823         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2824         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
2825         family names.
2826         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
2827         to our default serif font. Eventually we may want to import or require some "real"
2828         fonts, but this should at least ensure consistent rendering during test runs. Also
2829         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
2830         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
2831         in some incorrect baselines for the synthetic oblique test.
2832
2833 2010-10-11  Adam Barth  <abarth@webkit.org>
2834
2835         Unreviewed.
2836
2837         Fix sheriffbot not to crash when there are failing tests.  It turns out
2838         Python sets don't support the + operator.  We need to use union
2839         instead.  There's a more elegant way to do this in Python 2.6, but we
2840         need this code to work in 2.5.
2841
2842         * Scripts/webkitpy/common/net/failuremap.py:
2843         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2844
2845 2010-10-10  Robert Hogan  <robert@webkit.org>
2846
2847         Unreviewed, fix failing test from r69468.
2848
2849         [Qt] Put all DRT-created pages in a page group
2850
2851         Fix on r69468.
2852
2853         Because we don't delete closed pages immediately in DRT we need
2854         to remove them from the page group explicitly instead.
2855
2856         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
2857
2858         https://bugs.webkit.org/show_bug.cgi?id=47469
2859
2860         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2861         (WebCore::DumpRenderTree::windowCloseRequested):
2862
2863 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
2864
2865         Reviewed by Adam Barth.
2866
2867         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
2868         EFL-EWS bot is up and running.
2869         https://bugs.webkit.org/show_bug.cgi?id=47277
2870
2871         * QueueStatusServer/handlers/statusbubble.py:
2872
2873 2010-10-10  Robert Hogan  <robert@webkit.org>
2874
2875         Reviewed by Antonio Gomes.
2876
2877         [Qt] Put all DRT-created pages in a page group
2878
2879         https://bugs.webkit.org/show_bug.cgi?id=47469
2880
2881         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2882         (WebCore::DumpRenderTree::DumpRenderTree):
2883         (WebCore::DumpRenderTree::createWindow):
2884
2885 2010-10-09  Sam Weinig  <sam@webkit.org>
2886
2887         Reviewed by Dan Bernstein.
2888
2889         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
2890         <rdar://problem/8173667>
2891         https://bugs.webkit.org/show_bug.cgi?id=47461
2892
2893         * TestWebKitAPI/PlatformUtilities.h:
2894         * TestWebKitAPI/Test.h:
2895         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2896         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
2897         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2898         (TestWebKitAPI::TEST):
2899         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2900         (TestWebKitAPI::Util::URLForNonExistentResource):
2901         Adds a test for the frame load state after a failed provisional load. I wanted to test
2902         the frame load state after a committed load failed, but I don't believe that is possible
2903         to do without hooking up the http server to serve a long loading page.
2904
2905 2010-10-09  Sam Weinig  <sam@webkit.org>
2906
2907         Reviewed by Dan Bernstein.
2908
2909         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
2910         <rdar://problem/8447690>
2911         https://bugs.webkit.org/show_bug.cgi?id=47459
2912
2913         * MiniBrowser/mac/BrowserWindowController.m:
2914         (runBeforeUnloadConfirmPanel):
2915         (-[BrowserWindowController awakeFromNib]):
2916         * WebKitTestRunner/TestController.cpp:
2917         (WTR::createOtherPage):
2918         (WTR::TestController::initialize):
2919
2920 2010-10-09  Sam Weinig  <sam@webkit.org>
2921
2922         Reviewed by Dan Bernstein.
2923
2924         Need implementation of ChromeClient windowRect related functions.
2925         <rdar://problem/8469476>
2926         https://bugs.webkit.org/show_bug.cgi?id=47386
2927
2928         * MiniBrowser/mac/BrowserWindowController.m:
2929         (getWindowFrame):
2930         (setWindowFrame):
2931         (-[BrowserWindowController awakeFromNib]):
2932         * WebKitTestRunner/PlatformWebView.h:
2933         * WebKitTestRunner/TestController.cpp:
2934         (WTR::TestController::initialize):
2935         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2936         (WTR::PlatformWebView::windowFrame):
2937         (WTR::PlatformWebView::setWindowFrame):
2938         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2939         (WTR::PlatformWebView::windowFrame):
2940         (WTR::PlatformWebView::setWindowFrame):
2941         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2942         (WTR::PlatformWebView::windowFrame):
2943         (WTR::PlatformWebView::setWindowFrame):
2944
2945 2010-10-08  Adam Barth  <abarth@webkit.org>
2946
2947         Unreviewed (Eric is on vacation in this change is trivial).
2948
2949         Add a "clean" command to webkit-patch to clean the working directory
2950         https://bugs.webkit.org/show_bug.cgi?id=47436
2951
2952         This command is useful when using SVN because "svn revert" leaves
2953         unversioned files behind.
2954
2955         * Scripts/webkitpy/tool/commands/download.py:
2956
2957 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2958
2959         Unreviewed build fix.
2960
2961         [Qt] Add missing limits.h include since the Qt version currently
2962         ran on the bot does need that.
2963
2964         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2965
2966 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2967
2968         Reviewed by Csaba Osztrogonác.
2969
2970         [Qt] Turn on building WTR
2971         https://bugs.webkit.org/show_bug.cgi?id=47349
2972
2973         * Scripts/webkitdirs.pm:
2974
2975 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2976
2977         Reviewed by Andreas Kling.
2978
2979         [Qt] TestController needs its platform dependent methods
2980         https://bugs.webkit.org/show_bug.cgi?id=47413
2981
2982         * WebKitTestRunner/qt/TestControllerQt.cpp:
2983         (WTR::TestController::initializeInjectedBundlePath):
2984         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
2985         set then use that otherwise use the path where the bundle
2986         lives in a normal trunk build.
2987         (WTR::TestController::initializeTestPluginDirectory):
2988         Set the bundle's value. It is not used currently.
2989         (WTR::TestController::platformInitializeContext):
2990         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2991
2992 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2993
2994         Reviewed by Kenneth Rohde Christiansen.
2995
2996         WTR: Prevent sending the Done message twice on test timeout.
2997         https://bugs.webkit.org/show_bug.cgi?id=47410
2998
2999         When InjectedBundle::done() calls stopLoading, this may trigger
3000         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
3001         InjectedBundle::done() itself later in the stack.
3002         This would output the timeout failure message twice and confuse
3003         the run-webkit-tests script.
3004
3005         This patch adds a third state, Stopping, which prevents WebCore
3006         errors to trigger done() when testing is over.
3007
3008         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3009         (WTR::InjectedBundle::done):
3010         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3011
3012 2010-10-08  Andras Becsi  <abecsi@webkit.org>
3013
3014         Reviewed by Kenneth Rohde Christiansen.
3015
3016         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
3017         Original code by Simon Hausmann.
3018         https://bugs.webkit.org/show_bug.cgi?id=47402
3019
3020         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
3021         (WTR::activateFonts):
3022
3023 2010-10-08  Andras Becsi  <abecsi@webkit.org>
3024
3025         Reviewed by Csaba Osztrogonác.
3026
3027         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
3028         https://bugs.webkit.org/show_bug.cgi?id=47401
3029
3030         * Scripts/build-webkittestrunner:
3031         * Scripts/old-run-webkit-tests:
3032
3033 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3034
3035         Reviewed by Kenneth Rohde Christiansen.
3036
3037         [Qt] WTR first compile: fix compile issues.
3038         https://bugs.webkit.org/show_bug.cgi?id=47343
3039
3040         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
3041         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3042         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3043         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3044         * WebKitTestRunner/TestController.cpp:
3045         * WebKitTestRunner/TestInvocation.cpp:
3046
3047 2010-10-07  Antonio Gomes  <agomes@rim.com>
3048
3049         Reviewed by Simon Fraser.
3050
3051         [Mac] [DRT] implement setSpatialNavigationEnabled
3052         https://bugs.webkit.org/show_bug.cgi?id=47291
3053
3054         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
3055         so it can track regression on the existing implementation and future improvements
3056         we are making.
3057
3058         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3059         (LayoutTestController::setSpatialNavigationEnabled):
3060
3061 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
3062
3063         Reviewed by Adam Barth.
3064
3065         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
3066         hook in the Port infrastructure to generate URIs for the files
3067         in its summary HTML report; however, that method is supposed to only
3068         be used for test files (and should really be renamed), so this would
3069         crash.
3070
3071         This change adds a new "path" module to the system package with a
3072         routine called abspath_to_uri() that handles converting paths to
3073         file: URIs independently of anything in the layout_tests package,
3074         and changes the code to use this. At some point in the near future
3075         the layout_tests/port/* code should use this as well.
3076
3077         This change also deletes a bunch of unused code and fixes some
3078         comments in rebaseline_chromium_webkit_tests.py.
3079
3080         https://bugs.webkit.org/show_bug.cgi?id=47319
3081
3082         * Scripts/webkitpy/common/system/path.py: Added.
3083         * Scripts/webkitpy/common/system/path_unittest.py: Added.
3084         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3085         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3086
3087 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
3088
3089         Reviewed by Gustavo Noronha Silva.
3090
3091         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
3092         https://bugs.webkit.org/show_bug.cgi?id=46216
3093
3094         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
3095
3096         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3097         (initializeFonts): Also initialize the DevaVu Sans font.
3098
3099 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
3100
3101         Reviewed by Tony Chang.
3102
3103         [chromium] Minor naming cleanup in WebDragData, part 2
3104         https://bugs.webkit.org/show_bug.cgi?id=47227
3105
3106         Update DRT to use the renamed methods.
3107
3108         * DumpRenderTree/chromium/EventSender.cpp:
3109         (EventSender::beginDragWithFiles):
3110         * DumpRenderTree/chromium/WebViewHost.cpp:
3111         (addDRTFakeFileToDataObject):
3112
3113 2010-10-07  Anders Carlsson  <andersca@apple.com>
3114
3115         Reviewed by Sam Weinig.
3116
3117         Add a WKPageFindClient, hook up WKPageCountStringMatches
3118         https://bugs.webkit.org/show_bug.cgi?id=47373
3119
3120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3121         Remove hard coded paths.
3122
3123         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3124         (TestWebKitAPI::TEST):
3125         Fix expected result.
3126
3127         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
3128         (TestWebKitAPI::didFinishLoadForFrame):
3129         (TestWebKitAPI::didCountStringMatches):
3130         (TestWebKitAPI::TEST):
3131         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
3132         Add test for WKPageCountStringMatches.
3133
3134 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
3135
3136         Reviewed by Chris Fleizach.
3137
3138         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
3139         https://bugs.webkit.org/show_bug.cgi?id=46216
3140
3141         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
3142         for DejaVu Serif when there is no bold version available. This is necessary to
3143         properly test the property in layout tests.
3144
3145 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
3146
3147         Reviewed by Kenneth Rohde Christiansen.
3148
3149         [Qt] Add WTR's InjectedBundle build files.
3150         https://bugs.webkit.org/show_bug.cgi?id=47333
3151
3152         * Scripts/webkitdirs.pm:
3153         * WebKitTestRunner/DerivedSources.pro: Added.
3154         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
3155         * WebKitTestRunner/WebKitTestRunner.pro: Added.
3156         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
3157         Content merged in ../DerivedSources.pro
3158
3159 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3160
3161         Unreviewed, rolling out r69315.
3162         http://trac.webkit.org/changeset/69315
3163         https://bugs.webkit.org/show_bug.cgi?id=47363
3164
3165         Forgot to add the new files (Requested by kbalazs on #webkit).
3166
3167         * Scripts/webkitdirs.pm:
3168         * WebKitTestRunner/qt/DerivedSources.pro: Added.
3169
3170 2010-10-07  Sam Weinig  <sam@webkit.org>
3171
3172         Reviewed by Anders Carlsson.
3173
3174         Change API tester to ask the executable for the list of all
3175         tests instead of relying on the directory structure.
3176         https://bugs.webkit.org/show_bug.cgi?id=47359
3177
3178         * Scripts/run-test-webkit-api: Added.
3179         * Scripts/webkitdirs.pm:
3180         Add additional script to just launch the api tester with the correct settings.
3181
3182         * Scripts/run-api-tests:
3183         Change to use the new --dump-tests options to build the list of tests and change
3184         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
3185
3186         * TestWebKitAPI/Test.h:
3187         (TestWebKitAPI::Test::Register::Register):
3188         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3189         (TestWebKitAPI::TEST):
3190         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3191         (TestWebKitAPI::TEST):
3192         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3193         (TestWebKitAPI::TEST):
3194         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3195         (TestWebKitAPI::TEST):
3196         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3197         (TestWebKitAPI::TEST):
3198         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
3199         (TestWebKitAPI::TEST):
3200         Give each test a suite name in addition to the test name.
3201
3202         * TestWebKitAPI/TestsController.cpp:
3203         (TestWebKitAPI::TestsController::dumpTestNames):
3204         (TestWebKitAPI::TestsController::runTestNamed):
3205         * TestWebKitAPI/TestsController.h:
3206         * TestWebKitAPI/mac/main.mm:
3207         (main):
3208         Add option to print all registered tests.
3209
3210 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
3211
3212         Reviewed by Kenneth Rohde Christiansen.
3213
3214         [Qt] Add WTR's InjectedBundle build files.
3215         https://bugs.webkit.org/show_bug.cgi?id=47333
3216
3217         * Scripts/webkitdirs.pm:
3218         * WebKitTestRunner/DerivedSources.pro: Added.
3219         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
3220         * WebKitTestRunner/WebKitTestRunner.pro: Added.
3221         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
3222         Content merged in ../DerivedSources.pro
3223
3224 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
3225
3226         Unreviewed. Do a renaming that was recommended by the reviewer
3227         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
3228
3229         * WebKitTestRunner/qt/TestControllerQt.cpp:
3230         (WTR::RunUntilConditionLoop::start):
3231         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
3232         (WTR::TestController::runUntil):
3233
3234 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
3235
3236         Reviewed by Kenneth Rohde Christiansen.
3237
3238         [Qt] Watchdog timer implementation for WTR
3239         https://bugs.webkit.org/show_bug.cgi?id=47337
3240
3241         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
3242         the definition of the timer type to a typedef.
3243         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
3244         Timer implementation with QTimer and a helper QObject class.
3245         (WTR::WatchdogTimerHelper::instance):
3246         (WTR::WatchdogTimerHelper::timerFired):
3247         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
3248         (WTR::LayoutTestController::platformInitialize):
3249         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
3250         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3251
3252 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
3253
3254         Unreviewed buildfix for 69297 again
3255
3256         * WebKitTestRunner/TestController.cpp:
3257         (WTR::blankURL):
3258
3259 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
3260
3261         Unreviewed trivial build fix for r69297
3262
3263         * WebKitTestRunner/TestController.cpp:
3264         (WTR::blankURL):
3265
3266 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
3267
3268         Reviewed by Kenneth Rohde Christiansen.
3269
3270         WebKitTestRunner should be portable
3271         https://bugs.webkit.org/show_bug.cgi?id=45393
3272
3273         Use only the WebKit API for working with urls.
3274         * WebKitTestRunner/StringFunctions.h:
3275         (WTR::createWKURL):
3276         * WebKitTestRunner/TestController.cpp:
3277         (WTR::blankURL):
3278         (WTR::TestController::resetStateToConsistentValues):
3279         (WTR::TestController::didFinishLoadForFrame):
3280
3281 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3282
3283         Reviewed by Xan Lopez.
3284
3285         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
3286         https://bugs.webkit.org/show_bug.cgi?id=47332
3287
3288         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3289         (createBitmapContextFromWebView):
3290
3291 2010-10-06  Chris Guillory  <chris.guillory@google.com>
3292
3293         Reviewed by Chris Fleizach.
3294
3295         Remove unused accessibility functions from webkit.
3296         https://bugs.webkit.org/attachment.cgi?bugid=46707
3297
3298         * DumpRenderTree/chromium/WebViewHost.cpp:
3299         (WebViewHost::postAccessibilityNotification):
3300         * DumpRenderTree/chromium/WebViewHost.h:
3301
3302 2010-10-06  Lucas Forschler  <lforschler@apple.com>
3303
3304         Reviewed by Adam Roben.
3305
3306         Fix the sunspider-compare-results to actually use the passed in value for $root.
3307
3308         * Scripts/sunspider-compare-results:
3309
3310 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
3311
3312         Reviewed by Kenneth Rohde Christiansen.
3313
3314         [Qt] Runloop implementation for WTR
3315         https://bugs.webkit.org/show_bug.cgi?id=47280
3316
3317         * WebKitTestRunner/qt/TestControllerQt.cpp:
3318         Implemented TestController::runUntil by a timerEvent
3319         and a QEventLoop. We step into the event loop from runUntil.
3320         While we are waiting in the loop a timerEvent is periodically
3321         checking the value of the condition. Once the condition has
3322         becoming true the timerEvent wakes us up.
3323         (WTR::RunUntilLoop::start):
3324         (WTR::RunUntilLoop::RunUntilLoop):
3325         (WTR::RunUntilLoop::run):
3326         (WTR::RunUntilLoop::timerEvent):
3327         (WTR::TestController::platformInitialize):
3328         (WTR::TestController::runUntil):
3329         * WebKitTestRunner/qt/main.cpp:
3330         Start the main event loop first and creating the TestController later.
3331         (Launcher::Launcher):
3332         (Launcher::~Launcher):
3333         (Launcher::launch): Creating the TestController.
3334         (main): Setting up a timer for calling Launcher::launch from
3335         the main event loop.
3336
3337 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
3338
3339         Reviewed by Kenneth Russell.
3340
3341         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
3342         enable 'accelerated-composting' instead of 'accelerated-compositing'.
3343
3344         https://bugs.webkit.org/show_bug.cgi?id=47312
3345
3346         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3347         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3348
3349 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
3350
3351         Reviewed by Kenneth Rohde Christiansen.
3352
3353         [Qt] PlatformWebView implementation for WebKitTestRunner
3354         https://bugs.webkit.org/show_bug.cgi?id=47276
3355
3356         The implementation follows the way how
3357         we use the API in MiniBrowser.
3358         * WebKitTestRunner/PlatformWebView.h:
3359         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3360         (WTR::WebView::wkView):
3361         (WTR::WebView::~WebView):
3362         (WTR::WebView::WebView):
3363         (WTR::PlatformWebView::PlatformWebView):
3364         (WTR::PlatformWebView::~PlatformWebView):
3365         (WTR::PlatformWebView::resizeTo):
3366         (WTR::PlatformWebView::page):
3367         (WTR::PlatformWebView::focus):
3368         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3369
3370 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
3371
3372         Reviewed by Kenneth Rohde Christiansen.
3373
3374         [Qt] Add WebKitTestRunner's build files
3375         https://bugs.webkit.org/show_bug.cgi?id=44155
3376
3377         Parts was taken by Zoltan Horvath's patch.
3378
3379         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
3380         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
3381         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
3382         PlatformWKView and PlatformWindow (void* for now).
3383         Buildfix the case when __APPLE__ is not defined.
3384         * WebKitTestRunner/qt/DerivedSources.pro: Added.
3385         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
3386         Empty stub implementation.
3387         (WTR::registerWindowClass):
3388         (WTR::PlatformWebView::PlatformWebView):
3389         (WTR::PlatformWebView::~PlatformWebView):
3390         (WTR::PlatformWebView::resizeTo):
3391         (WTR::PlatformWebView::page):
3392         (WTR::PlatformWebView::focus):
3393         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
3394         Empty stub implementation.
3395         (WTR::registerWindowClass):
3396         (WTR::TestController::runUntil):
3397         (WTR::TestController::platformInitialize):
3398         (WTR::TestController::initializeInjectedBundlePath):
3399         (WTR::TestController::initializeTestPluginDirectory):
3400         (WTR::TestController::platformInitializeContext):
3401         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
3402         * WebKitTestRunner/qt/main.cpp: Added.
3403         (main):
3404
3405 2010-10-06  Tony Chang  <tony@chromium.org>
3406
3407         Unreviewed, rolling out r69202.
3408         http://trac.webkit.org/changeset/69202
3409         https://bugs.webkit.org/show_bug.cgi?id=46937
3410
3411         Broke compile of test_shell
3412
3413         * DumpRenderTree/chromium/EventSender.cpp:
3414         (EventSender::beginDragWithFiles):
3415         * DumpRenderTree/chromium/WebViewHost.cpp:
3416         (addDRTFakeFileToDataObject):
3417
3418 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
3419
3420         Reviewed by Tony Chang.
3421
3422         [chromium] Minor naming cleanup in WebDragData, part 2
3423         https://bugs.webkit.org/show_bug.cgi?id=46937
3424
3425         Update DRT to use the renamed methods.
3426
3427         * DumpRenderTree/chromium/EventSender.cpp:
3428         (EventSender::beginDragWithFiles):
3429         * DumpRenderTree/chromium/WebViewHost.cpp:
3430         (addDRTFakeFileToDataObject):
3431
3432 2010-10-06  David Kilzer  <ddkilzer@apple.com>
3433
3434         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
3435
3436         Reviewed by Adam Roben.
3437
3438         This is the first step in making webarchive tests work on
3439         Windows.
3440
3441         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
3442         new files to the project.
3443         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
3444         to WebArchiveDumpSupport.mm.
3445         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
3446         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
3447         (serializeWebArchiveToXML):
3448
3449 2010-10-05  Daniel Bates  <dbates@rim.com>
3450
3451         Reviewed by David Kilzer.
3452
3453         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
3454         https://bugs.webkit.org/show_bug.cgi?id=46058
3455
3456         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
3457         structure so as to support returning additional information
3458         about a change log diff.
3459
3460         Currently, VCSUtils::fixChangeLogPatch() returns a string that
3461         represents the change log diff. Towards supporting the return
3462         of additional information, such as whether the change log diff
3463         inserts an entry at the top of the ChangeLog file, we need to
3464         make VCSUtils::fixChangeLogPatch() return a reference to hash
3465         structure.
3466
3467         * Scripts/VCSUtils.pm:
3468           - Modified fixChangeLogPatch() to return a reference to a
3469             hash structure.
3470           - Added documentation to fixChangeLogPatch().
3471           - Modified call site in mergeChangeLogs() as necessary.
3472         * Scripts/svn-apply:
3473           - Modified call site in patch() as necessary.
3474         * Scripts/svn-create-patch:
3475           - Modified call site in generateDiff() as necessary.
3476         * Scripts/svn-unapply:
3477           - Modified call site in patch() as necessary.
3478         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3479           - Modified the unit tests as necessary.
3480
3481 2010-10-05  Tony Chang  <tony@chromium.org>
3482
3483         Reviewed by Darin Adler.
3484
3485         fix the link to the expected image on windows
3486         https://bugs.webkit.org/show_bug.cgi?id=47228
3487
3488         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
3489             windows, the file must be opened in binary mode when writing
3490             binary data.
3491
3492 2010-10-05  Adam Barth  <abarth@webkit.org>
3493
3494         Update expected result of unittest to match Tony's change below.
3495
3496         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3497
3498 2010-10-05  Tony Chang  <tony@chromium.org>
3499
3500         Reviewed by Ojan Vafai (over the shoulder).
3501
3502         Paper over errors in image_diff so we don't crash the whole test run.
3503
3504         * Scripts/webkitpy/layout_tests/port/chromium.py:
3505
3506 2010-10-05  Tony Chang  <tony@chromium.org>
3507
3508         Unreviewed, make shutil.rmtree more resiliant to errors
3509         since windows was raising WindowsError: The process cannot access the file because it
3510         is being used by another process.
3511
3512         * Scripts/webkitpy/layout_tests/port/chromium.py:
3513
3514 2010-10-05  Tony Chang  <tony@chromium.org>
3515
3516         Reviewed by Ojan Vafai.
3517
3518         [chromium] fix image diffing in NRWT
3519         https://bugs.webkit.org/show_bug.cgi?id=47128
3520
3521         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
3522             NamedTemporaryFile since it doesn't work on Windows.
3523         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3524
3525 2010-10-05  Kenneth Russell  <kbr@google.com>
3526
3527         Reviewed by Tony Chang.
3528
3529         [chromium] Implement layerTreeAsText in DumpRenderTree
3530         https://bugs.webkit.org/show_bug.cgi?id=47216
3531
3532         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
3533         make it callable from DumpRenderTree.
3534
3535         No new tests; verified with existing compositor layout tests.
3536
3537         * DumpRenderTree/chromium/LayoutTestController.cpp:
3538         (LayoutTestController::LayoutTestController):
3539         (LayoutTestController::layerTreeAsText):
3540         * DumpRenderTree/chromium/LayoutTestController.h:
3541
3542 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
3543
3544         Unreviewed build correction.
3545
3546         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
3547         property sheet so proper libraries are linked.
3548
3549 2010-10-05  Robert Hogan  <robert@webkit.org>
3550
3551         Reviewed by Andreas Kling.
3552
3553         [Qt] Fix url conversion in QWebHistory
3554
3555         Converting from KURL to WFT::String to QUrl does not
3556         permit proper percent encoding later.
3557
3558         https://bugs.webkit.org/show_bug.cgi?id=47048
3559
3560         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3561         (WebCore::dumpHistoryItem):
3562
3563 2010-10-05  Anders Carlsson  <andersca@apple.com>
3564
3565         Reviewed by Sam Weinig.
3566
3567         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
3568         https://bugs.webkit.org/show_bug.cgi?id=47188
3569         <rdar://problem/8514104>
3570
3571         When constructing the std::string, use the real string length instead of the maximum buffer size.
3572
3573         * TestWebKitAPI/PlatformUtilities.h:
3574         (TestWebKitAPI::Util::toSTD):
3575         * WebKitTestRunner/StringFunctions.h:
3576         (WTR::toSTD):
3577
3578 2010-10-04  Sam Weinig  <sam@webkit.org>
3579
3580         Reviewed by Mark Rowe.
3581
3582         Add MIMEType accessor to WKFrame
3583         <rdar://problem/8347683>
3584         https://bugs.webkit.org/show_bug.cgi?id=47138
3585
3586         * TestWebKitAPI/PlatformUtilities.h:
3587         (TestWebKitAPI::Util::toSTD):
3588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3589         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
3590         (TestWebKitAPI::didStartProvisionalLoadForFrame):
3591         (TestWebKitAPI::didCommitLoadForFrame):
3592         (TestWebKitAPI::didFinishLoadForFrame):
3593         (TestWebKitAPI::TEST):
3594         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
3595         (TestWebKitAPI::didStartProvisionalLoadForFrame):
3596         (TestWebKitAPI::didCommitLoadForFrame):
3597         (TestWebKitAPI::didFinishLoadForFrame):
3598         (TestWebKitAPI::TEST):
3599         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3600         (TestWebKitAPI::TEST):
3601         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
3602         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
3603         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
3604         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3605         (TestWebKitAPI::Util::createURLForResource):
3606
3607 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3608
3609         Reviewed by Ojan Vafai.
3610
3611         [NRWT] Rename current_dir to current_group because it's not a directory
3612         https://bugs.webkit.org/show_bug.cgi?id=47169
3613
3614         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3615         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3616
3617 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3618
3619         Unreviewed, build fix.
3620
3621         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
3622         which can't always be done. This test uses tempfile.mkdtemp(), which
3623         should be safe.
3624
3625         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3626
3627 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3628
3629         Unreviewed, build fix.
3630
3631         Add missing "from __future__ import with_statement" that was
3632         breaking test-webkitpy on the Leopard bots (broke in r69040).
3633
3634         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3635
3636 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3637
3638         Unreviewed, rolling out r69066.
3639         http://trac.webkit.org/changeset/69066
3640         https://bugs.webkit.org/show_bug.cgi?id=47163
3641
3642         Made NRWT reliability worse. (Requested by tkent on #webkit).
3643
3644         * Scripts/webkitpy/layout_tests/port/chromium.py:
3645         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3646
3647 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3648
3649         Reviewed by Tony Chang.
3650
3651         [NRWT] Reverse the http tests to alphabetical order.
3652         https://bugs.webkit.org/show_bug.cgi?id=47075
3653
3654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3655
3656 2010-10-04  Robert Hogan  <robert@webkit.org>
3657
3658         Reviewed by Andreas Kling.
3659
3660         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
3661
3662         We need to queue back and forward navigations in the DRT from the
3663         LayoutTestController so that maybeDump() knows about them.
3664
3665         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3666         (LayoutTestController::queueBackNavigation):
3667         (LayoutTestController::queueForwardNavigation):
3668
3669 2010-10-04  Tony Chang  <tony@chromium.org>
3670
3671         Reviewed by Kent Tamura.
3672
3673         [chromium] fix image diffing in NRWT
3674         https://bugs.webkit.org/show_bug.cgi?id=47128
3675
3676         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
3677               temp file and check the image_diff error code more carefully
3678         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3679
3680 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3681
3682         Reviewed by Adam Barth.
3683
3684         aroben's change in r68792 actually broke new-run-webkit-tests when
3685         running the DRT code path. His change was intended to fix the
3686         way we were converting windows paths to URIs when running under
3687         Cygwin (the paths were getting one too many "/" on the front).
3688         However, the change ended up breaking the chromium_win port, which
3689         had slightly different logic.
3690
3691         This patch removes the port-specific code and adds tests to make
3692         sure we're getting the behavior we expect. The Port object no longer
3693         exposes a get_absolute_path() method that can be used outside of
3694         of converting test filenames, because it's unreliable otherwise
3695         (we don't have the right context to know which conversion is intended).
3696
3697         https://bugs.webkit.org/show_bug.cgi?id=47140
3698
3699         * Scripts/webkitpy/layout_tests/port/base.py:
3700         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3701         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3702         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3703         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3704
3705 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3706
3707         Unreviewed, build fix.
3708
3709         Handle crash introduced in r69040 if we are not running in a
3710         Chromium checkout.
3711
3712         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3713
3714 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3715
3716         Reviewed by Tony Chang.
3717
3718         Add a way for us to have test expectations that are specific to the
3719         official builds of Google Chrome (as opposed to Chromium). This change
3720         looks for an additional "test_expectations_chrome.txt" file in
3721         Chromium's repository (webkit/tools/layout_tests), and uses the
3722         concatenation of that file and the regular test_expectations.txt
3723         file for test overrides.
3724
3725         https://bugs.webkit.org/show_bug.cgi?id=46854
3726
3727         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3728         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3729
3730 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
3731
3732         Color tests in the list based on existing pass/fail result.
3733         
3734         Fix the summary data to account for htmlOnly and nonHTML tests.
3735
3736         * CSSTestSuiteHarness/harness/harness.css:
3737         (#test-list > option.pass):
3738         (#test-list > option.fail):
3739         (#test-list > option.skipped):
3740         * CSSTestSuiteHarness/harness/harness.js:
3741         (Test):
3742         (Test.prototype.statusForFormat):
3743         (TestSuite.prototype.fillTestList):
3744         (TestSuite.prototype.updateTestList):
3745         (TestSuite.prototype.recordResult):
3746         (TestSuite.prototype.markTestCompleted):
3747         (TestSuite.prototype.countTestsWithFlag):
3748         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
3749         (TestSuite.prototype.queryDatabaseForSummary):
3750
3751 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
3752
3753         Reviewed by Beth Dakin.
3754
3755         AX: doAXRangeForLine does not work
3756         https://bugs.webkit.org/show_bug.cgi?id=47101
3757
3758         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
3759
3760         * DumpRenderTree/AccessibilityUIElement.cpp:
3761         (rangeForLineCallback):
3762         (AccessibilityUIElement::rangeForLine):
3763         (AccessibilityUIElement::getJSClass):
3764         * DumpRenderTree/AccessibilityUIElement.h:
3765         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3766         (AccessibilityUIElement::rangeForLine):
3767
3768 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
3769
3770         Unreviewed. Adding myself to the committers list.
3771
3772         * Scripts/webkitpy/common/config/committers.py:
3773
3774 2010-10-04  Sam Weinig  <sam@webkit.org>
3775
3776         Reviewed by Anders Carlsson.
3777
3778         Add ability to set the CacheModel in Webkit2
3779         https://bugs.webkit.org/show_bug.cgi?id=47066
3780
3781         * MiniBrowser/mac/AppDelegate.m:
3782         (-[BrowserAppDelegate init]): Opt minibrowser into
3783         a PrimaryWebBrowser cache model.
3784
3785 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3786
3787         Make sure to enter all tests when creating the database
3788         for the first time.
3789         
3790         When migrating to a new version of the suite, be sure to
3791         sync up the database and testinfo.data by removing old
3792         tests, and inserting new ones.
3793
3794         * CSSTestSuiteHarness/harness/harness.js:
3795         (TestSuite.prototype.openDatabase.creation):
3796         (TestSuite.prototype.databaseCreated):
3797         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3798         (TestSuite.prototype.insertTest):
3799
3800 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3801
3802         More work on treating HTML4 and XHTML1 independently; when 
3803         changing the format, rebuild the test list, and update the 
3804         numbers in the chapter popup.
3805
3806         * CSSTestSuiteHarness/harness/harness.js:
3807         (Test):
3808         (Test.prototype.runForFormat):
3809         (Test.prototype.completedForFormat):
3810         (ChapterSection):
3811         (ChapterSection.prototype.countTests):
3812         (Chapter):
3813         (Chapter.prototype.description):
3814         (Chapter.prototype.countTests):
3815         (Chapter.prototype.testCount):
3816         (Chapter.prototype.untestedCount):
3817         (TestSuite.prototype.buildChapters):
3818         (TestSuite.prototype.loadCurrentTest):
3819         (TestSuite.prototype.updateProgressLabel):
3820         (TestSuite.prototype.processFlags):
3821         (TestSuite.prototype.formatChanged):
3822
3823 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3824
3825         Update test suite version 20101001.
3826         
3827         Handle database migration, and delete tests from the db that are
3828         not present in testinfo.data.
3829         
3830         Load about:blank into the test frame before the test url, to make
3831         missing tests more obvious.
3832         
3833         * CSSTestSuiteHarness/harness/harness.js:
3834         (TestSuite.prototype.loadTest):
3835         (TestSuite.prototype.openDatabase.creation):
3836         (TestSuite.prototype.openDatabase.migration1_0To1_1):
3837         (TestSuite.prototype.openDatabase.if.return):
3838         (TestSuite.prototype.databaseReady):
3839         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3840         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
3841         (TestSuite.prototype.syncDatabaseWithTestInfoData):
3842
3843 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3844
3845         Add the ability to jump to a specific test.
3846
3847         * CSSTestSuiteHarness/harness/harness.html:
3848         * CSSTestSuiteHarness/harness/harness.js:
3849         (TestSuite.prototype.goToTestByName):
3850         (TestSuite.prototype.switchToFormat):
3851
3852 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3853
3854         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
3855         as the test.
3856
3857         * CSSTestSuiteHarness/harness/harness.js:
3858         (TestSuite.prototype.loadRef):
3859
3860 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3861
3862         Update the UI to reflect the fact that each test needs to be tested
3863         in both HTML4 and XHTML1 format.
3864         
3865         * CSSTestSuiteHarness/harness/harness.js:
3866         (Test):
3867         (Chapter.prototype.description):
3868         (Chapter.prototype.untestedCount):
3869         (TestSuite.prototype.fillChapterPopup):
3870         (TestSuite.prototype.updateChapterPopup):
3871         (TestSuite.prototype.fillTestList):
3872         (TestSuite.prototype.updateTestList):
3873         (TestSuite.prototype.goToNextIncompleteTest):
3874         (TestSuite.prototype.firstIncompleteTestIndex):
3875         (TestSuite.prototype.recordResult):
3876         (TestSuite.prototype.formatChanged):
3877         (TestSuite.prototype.markTestCompleted):
3878         (TestSuite.prototype.resetTestStatus):
3879
3880 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
3881
3882         Add the ability to remove results for re-testing, and
3883         to import results.
3884
3885         * CSSTestSuiteHarness/harness/harness.css:
3886         (.custom button):
3887         (#overlay):
3888         (#overlay.visible):
3889         (.overlay-contents):
3890         (.overlay-contents textarea):
3891         (.overlay-contents .buttons):
3892         (.overlay-contents .note):
3893         (.overlay-contents .buttons button):
3894         * CSSTestSuiteHarness/harness/harness.html:
3895         * CSSTestSuiteHarness/harness/harness.js:
3896         (TestSuite.prototype.importResults):
3897         (TestSuite.prototype.clearResults):
3898         (TestSuite.prototype.markTestCompleted):
3899         (TestSuite.prototype.resetTestStatus):
3900         (TestSuite.prototype.storeTestResult):
3901         (TestSuite.prototype.importTestResults):
3902         (TestSuite.prototype.clearTestResults):
3903
3904 2010-10-01  Sam Weinig  <sam@webkit.org>
3905
3906         Reviewed by Jon Honeycutt.
3907
3908         Deploy the new WKString functions to remove most uses of CF from
3909         the WebKitTestRunner.
3910
3911         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3912         (WTR::InjectedBundle::didReceiveMessage):
3913         (WTR::InjectedBundle::done):
3914         * WebKitTestRunner/StringFunctions.h:
3915         (WTR::toWK):
3916         (WTR::toJS):
3917         (WTR::toSTD):
3918         (WTR::operator<<):
3919         (WTR::copyURLString):
3920         * WebKitTestRunner/TestController.cpp:
3921         (WTR::TestController::resetStateToConsistentValues):
3922         (WTR::TestController::didFinishLoadForFrame):
3923         * WebKitTestRunner/TestInvocation.cpp:
3924         (WTR::TestInvocation::invoke):
3925         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3926
3927 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
3928
3929         Unreviewed TestResultsServer change.
3930
3931         Add files introduced by http://crrev.com/61273 to the list of dashboard 
3932         files to update.
3933
3934         * TestResultServer/handlers/dashboardhandler.py:
3935
3936 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
3937
3938         Build Fix for Windows.
3939
3940         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
3941             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
3942             ForwardingHeaders to the include path.
3943
3944 2010-10-01  Sam Weinig  <sam@webkit.org>
3945
3946         Reviewed by Anders Carlsson.
3947
3948         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
3949
3950         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3951         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3952         (TestWebKitAPI::TEST):
3953         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
3954         (TestWebKitAPI::TEST):
3955
3956 2010-10-01  Sam Weinig  <sam@webkit.org>
3957
3958         Reviewed by Kenneth Rohde Christiansen.
3959
3960         Add additional WKString API
3961         https://bugs.webkit.org/show_bug.cgi?id=46958
3962
3963         Add basic WKStringRef tests.
3964
3965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3966         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
3967
3968 2010-10-01  Sam Weinig  <sam@webkit.org>
3969
3970         Reviewed by Dan Bernstein.
3971
3972         Add makefile for TestWebKitAPI and call it from the base makefile.
3973
3974         * Makefile:
3975         * TestWebKitAPI/Makefile: Added.
3976
3977 2010-10-01  Sam Weinig  <sam@webkit.org>
3978
3979         Reviewed by Adam Roben.
3980
3981         Remove unnecessary ForwardingHeaders from test runners.
3982         https://bugs.webkit.org/show_bug.cgi?id=47010
3983
3984         * TestWebKitAPI/Configurations/Base.xcconfig:
3985         * TestWebKitAPI/ForwardingHeaders: Removed.
3986         * WebKitTestRunner/Configurations/Base.xcconfig:
3987         * WebKitTestRunner/ForwardingHeaders: Removed.
3988
3989 2010-09-30  Adam Barth  <abarth@webkit.org>
3990
3991         Reviewed by Eric Seidel.
3992
3993         WebSocket tests are flaky
3994         https://bugs.webkit.org/show_bug.cgi?id=46956
3995
3996         Update these tools to understand how to run the WebSocket tests off the
3997         Apache server.
3998
3999         * Scripts/old-run-webkit-tests:
4000         * Scripts/webkitpy/layout_tests/port/base.py:
4001         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
4002         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4003
4004 2010-10-01  Adam Roben  <aroben@apple.com>
4005
4006         Encode Executive command arguments using UTF-8 on Cygwin
4007
4008         Cygwin's Python's os.execv doesn't support unicode command arguments.
4009         Cygwin's execv expects arguments to be encoded using the current code
4010         page. But code pages are limited in what characters they can handle,
4011         and our tests include characters that the English code page can't
4012         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
4013         which can handle all characters but might confuse some commands, for
4014         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
4015         good enough, but we can deal with that when the problem arises.
4016
4017         Reviewed by Adam Barth.
4018
4019         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
4020         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
4021         fails on Windows
4022
4023         * Scripts/webkitpy/common/system/executive.py:
4024         (Executive._run_command_with_teed_output):
4025         (Executive.run_command):
4026         On Cygwin, encode arguments using UTF-8.
4027
4028 2010-10-01  Sam Weinig  <sam@webkit.org>
4029
4030         Reviewed by Adam Roben.
4031
4032         Add simple API tester for WebKit2
4033         https://bugs.webkit.org/show_bug.cgi?id=46953
4034
4035         This adds a very simple testing infrastructure for testing APIs exposed
4036         through the WebKit project. It consists of two parts: 1) a project that
4037         builds the all the tests 2) a script that searches the tests directory and
4038         calls the tester once for each test.
4039
4040         This adds the infrastructure and two tests:
4041         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
4042         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
4043
4044         This currently only works on the mac, but is designed to be easily ported 
4045         to any platform.
4046
4047         * Scripts/run-api-tests: Added.
4048         * Scripts/build-api-tests: Added.
4049         Scripts to build/run the tests.
4050
4051         * TestWebKitAPI: Added.
4052         * TestWebKitAPI/Configurations: Added.
4053         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
4054         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
4055         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
4056         * TestWebKitAPI/ForwardingHeaders: Added.
4057         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
4058         * TestWebKitAPI/PlatformUtilities.h: Added.
4059         * TestWebKitAPI/PlatformWebView.h: Added.
4060         (TestWebKitAPI::PlatformWebView::platformView):
4061         * TestWebKitAPI/StringFunctions.h: Added.
4062         * TestWebKitAPI/Test.h: Added.
4063         (TestWebKitAPI::Test::~Test):
4064         (TestWebKitAPI::Test::name):
4065         (TestWebKitAPI::Test::Register::Register):
4066         (TestWebKitAPI::Test::Register::create):
4067         (TestWebKitAPI::Test::Test):
4068         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
4069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
4070         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
4071         * TestWebKitAPI/TestsController.cpp: Added.
4072         (TestWebKitAPI::TestsController::shared):
4073         (TestWebKitAPI::TestsController::TestsController):
4074         (TestWebKitAPI::TestsController::runTestNamed):
4075         (TestWebKitAPI::TestsController::testFailed):
4076         (TestWebKitAPI::TestsController::registerCreateTestFunction):
4077         * TestWebKitAPI/TestsController.h: Added.
4078         * TestWebKitAPI/mac: Added.
4079         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
4080         (TestWebKitAPI::Util::run):
4081         (TestWebKitAPI::Util::createURLForResource):
4082         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
4083         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4084         (TestWebKitAPI::PlatformWebView::resizeTo):
4085         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
4086         (TestWebKitAPI::PlatformWebView::page):
4087         (TestWebKitAPI::PlatformWebView::focus):
4088         * TestWebKitAPI/mac/main.mm: Added.
4089         Infrastructure.
4090
4091         * TestWebKitAPI/Tests: Added.
4092         * TestWebKitAPI/Tests/WTF: Added.
4093         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
4094         * TestWebKitAPI/Tests/WebKit2: Added.
4095         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
4096         (TestWebKitAPI::State::State):
4097         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
4098         Proof of concept tests.
4099
4100 2010-10-01  Adam Roben  <aroben@apple.com>
4101
4102         Don't assume AccessibleObjectFromEvent succeeds
4103
4104         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
4105         DumpRenderTree!notificationListenerProc when running
4106         plugins/access-after-page-destroyed.html
4107
4108         Reviewed by Sam Weinig.
4109
4110         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4111         (notificationListenerProc): Check both the return value of
4112         AccessibleObjectFromEvent and the object it returns, as MSDN
4113         recommends.
4114
4115 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4116
4117         Reviewed by Tony Chang.
4118
4119         [NRWT] Put the http and websocket tests first in the test list.
4120         https://bugs.webkit.org/show_bug.cgi?id=46453
4121
4122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4123         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4124
4125 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
4126
4127         Unreviewed, adding myself to the committer list.
4128
4129         * Scripts/webkitpy/common/config/committers.py:
4130
4131 2010-10-01  Adam Roben  <aroben@apple.com>
4132
4133         Test NPN_GetValue(NPNVnetscapeWindow)
4134
4135         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
4136         Right-clicking on windowless Flash plugin in WebKit2 makes a context
4137         menu appear in the bottom-right corner of the screen
4138
4139         Reviewed by Anders Carlsson.
4140
4141         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4142         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
4143
4144         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
4145
4146         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
4147         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
4148         (GetValueNetscapeWindow::NPP_SetWindow): Test that
4149         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
4150         isn't our HWND.
4151
4152         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4153         Added GetValueNetscapeWindow.
4154
4155 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
4156
4157         Unreviewed, adding my webkit.org identity to reviewer list.
4158
4159         * Scripts/webkitpy/common/config/committers.py:
4160
4161 2010-09-30  Adam Barth  <abarth@webkit.org>
4162
4163         Reviewed by Eric Seidel.
4164
4165         The WebSocket server should flush its logs
4166         https://bugs.webkit.org/show_bug.cgi?id=46946
4167
4168         The WebSocket server logs are truncated because the driver just
4169         terminates the child.  It should run Python without buffering so we can
4170         see the end of the log.
4171
4172         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
4173
4174 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
4175
4176         Add a button to jump to the next untested test.
4177         
4178         * CSSTestSuiteHarness/harness/harness.css:
4179         (.test-type):
4180         (.name > button):
4181         * CSSTestSuiteHarness/harness/harness.html:
4182         * CSSTestSuiteHarness/harness/harness.js:
4183         (Chapter.prototype.description):
4184         (Chapter.prototype.untestedCount):
4185         (TestSuite.prototype.testInfoDataLoaded):
4186         (TestSuite.prototype.fillChapterPopup):
4187         (TestSuite.prototype.updateChapterPopup):
4188         (TestSuite.prototype.buildTestListForChapter):
4189         (TestSuite.prototype.goToNextIncompleteTest):
4190         (TestSuite.prototype.firstIncompleteTestIndex):
4191         (TestSuite.prototype.testCompletionStateChanged):
4192
4193 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
4194
4195         WebKit2 on Windows should use Windows fonts for the various standard
4196         font families
4197         https://bugs.webkit.org/show_bug.cgi?id=43499
4198         <rdar://problem/8272758>
4199
4200         Reviewed by Adam Roben.
4201
4202         * WebKitTestRunner/TestController.cpp:
4203         (WTR::TestController::resetStateToConsistentValues):
4204         Use the Mac fonts for running tests. This matches DRT behavior.
4205
4206 2010-09-30  Adam Barth  <abarth@webkit.org>
4207
4208         Third attempt.  We need a better integration test environment.
4209
4210         * Scripts/webkitpy/common/net/failuremap.py:
4211         * Scripts/webkitpy/common/net/failuremap_unittest.py:
4212
4213 2010-09-30  Robert Hogan  <robert@webkit.org>
4214
4215         Reviewed by Andreas Kling.
4216
4217         [Qt] Support for PlainTextController
4218
4219         Unskip editing/text-iterator/basic-iteration.html
4220
4221         https://bugs.webkit.org/show_bug.cgi?id=38805
4222
4223         * DumpRenderTree/qt/DumpRenderTree.pro:
4224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4225         (WebCore::DumpRenderTree::DumpRenderTree):
4226         (WebCore::DumpRenderTree::initJSObjects):