WebKitTools: Make the Qt Linux only --valgrind feature, suppress errors
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2
3         Reviewed by Simon Hausmann.
4
5         Make the Qt Linux only --valgrind feature, suppress errors
6         defined in the SuppressedValgrindErrors file.
7
8         * Scripts/run-webkit-tests:
9
10 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
11
12         Reviewed by Simon Hausmann.
13
14         Set the locale to C and not to the current one in use on the system.
15
16         * DumpRenderTree/qt/DumpRenderTree.cpp:
17         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
18
19 2009-11-13  Adam Roben  <aroben@apple.com>
20
21         Finish replacing worldIDs with world objects
22
23         The only remaining use of worldIDs was in a method only used by DRT
24         for the isolated worlds tests.
25
26         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
27
28         Reviewed by Mark Rowe.
29
30         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
31         (LayoutTestController::evaluateScriptInIsolatedWorld):
32         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
33         (LayoutTestController::evaluateScriptInIsolatedWorld):
34         Updated for changes to WebFrame. Now holds the map of worldID -> world
35         at this level instead of making WebKit do it.
36
37 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
38
39         Reviewed by Simon Hausmann.
40
41         [Qt] Ensure the DRT does not output anything until first test is run
42
43         * DumpRenderTree/qt/DumpRenderTree.cpp:
44         * DumpRenderTree/qt/DumpRenderTree.h:
45
46 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
47
48         Reviewed by Tor Arne Vestbø.
49
50         Clear the undo stack in before each new test run.
51
52         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
53
54         * DumpRenderTree/qt/DumpRenderTree.cpp:
55         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
56
57 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
58
59         Reviewed by Kenneth Rohde Christiansen.
60
61         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
62
63         * DumpRenderTree/qt/DumpRenderTree.cpp:
64         (WebCore::WebPage::resetSettings):
65         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
66         (LayoutTestController::overridePreference):
67
68 2009-11-13  Eric Seidel  <eric@webkit.org>
69
70         Reviewed by Adam Barth.
71
72         Update committers.py based on svn records
73         https://bugs.webkit.org/show_bug.cgi?id=31366
74
75         This list was generated using validate-committer-lists from
76         https://bugs.webkit.org/show_bug.cgi?id=30970
77         and makes committers.py current for committers who have
78         committed in the last 3 years.
79
80         * Scripts/modules/committers.py:
81
82 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
83
84         Reviewed by Adam Barth.
85
86         The document-open.html test was flaky at times. The test invokes the layout test plugin
87         which in its destroy stream handler opens a new document. This basically tears down the
88         stream and the associated plugin instance. The pluginLog function in the layout test
89         plugin attempts to retrieve the window script object on a torn down plugin instance
90         which crashed consistently on windows in the debugger. The functions which issue
91         these logs already have a valid window script object. We now have variants of the pluginLog
92         function which take in a window script object with and without variable arguments. 
93
94         https://bugs.webkit.org/show_bug.cgi?id=31067
95
96         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
97         (pluginLogWithWindowObject):
98         (pluginLogWithWindowObjectVariableArgs):
99         (pluginLog):
100         (notifyTestCompletion):
101         (testDocumentOpen):
102         (testWindowOpen):
103
104 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
105
106         Reviewed by Gustavo Noronha Silva.
107
108         https://bugs.webkit.org/show_bug.cgi?id=30997
109         [Gtk] Implemment AtkDocument
110
111         Added testing support.
112
113         * DumpRenderTree/AccessibilityUIElement.cpp:
114         * DumpRenderTree/AccessibilityUIElement.h:
115         (getDocumentEncodingCallback):
116         (getDocumentURICallback):
117         (AccessibilityUIElement::getJSClass):
118         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
119         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
120         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
121         (AccessibilityUIElement::documentEncoding):
122         (AccessibilityUIElement::documentURI):
123
124 2009-11-12  Adam Roben  <aroben@apple.com>
125
126         Replace worldIDs with world objects
127
128         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
129         user scripts/stylesheets and isolated worlds
130
131         Reviewed by Sam Weinig.
132
133         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
134         (LayoutTestController::addUserScript):
135         (LayoutTestController::addUserStyleSheet):
136         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
137         (LayoutTestController::addUserScript):
138         (LayoutTestController::addUserStyleSheet):
139         Changed these functions to create a new WebJSWorld each time they're
140         called and to pass that world to WebKit.
141
142 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
143
144         Reviewed by Oliver Hunt.
145
146         need to implement aria tree roles
147         https://bugs.webkit.org/show_bug.cgi?id=31284
148
149         * DumpRenderTree/AccessibilityUIElement.cpp:
150         (disclosedRowAtIndexCallback):
151         (selectedRowAtIndexCallback):
152         (isEqualCallback):
153         (isAttributeSettableCallback):
154         (isActionSupportedCallback):
155         (disclosedByRowCallback):
156         (hierarchicalLevelCallback):
157         (AccessibilityUIElement::getJSClass):
158         * DumpRenderTree/AccessibilityUIElement.h:
159         (AccessibilityUIElement::isEqual):
160         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
161         (AccessibilityUIElement::hierarchicalLevel):
162         (AccessibilityUIElement::disclosedRowAtIndex):
163         (AccessibilityUIElement::selectedRowAtIndex):
164         (AccessibilityUIElement::disclosedByRow):
165         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
166         (AccessibilityUIElement::getChildAtIndex):
167         (AccessibilityUIElement::disclosedRowAtIndex):
168         (AccessibilityUIElement::selectedRowAtIndex):
169         (AccessibilityUIElement::titleUIElement):
170         (AccessibilityUIElement::parentElement):
171         (AccessibilityUIElement::disclosedByRow):
172         (AccessibilityUIElement::hierarchicalLevel):
173         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
174         (AccessibilityUIElement::hierarchicalLevel):
175         (AccessibilityUIElement::disclosedRowAtIndex):
176         (AccessibilityUIElement::selectedRowAtIndex):
177         (AccessibilityUIElement::disclosedByRow):
178
179 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
180
181         Reviewed by Darin Adler.
182
183         svn-apply can not handle git binary diffs
184         https://bugs.webkit.org/show_bug.cgi?id=26830
185
186         Support "literal" type git binary diffs.
187
188         * Scripts/VCSUtils.pm:
189         * Scripts/modules/scm_unittest.py:
190         * Scripts/svn-apply:
191
192 2009-11-11  Dmitry Titov  <dimich@chromium.org>
193
194         Not reviewed, removing duplicate entry for myself in committers.py.
195
196         * Scripts/modules/committers.py:
197
198 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
199
200         Reviewed by Darin Adler and Mark Rowe.
201
202         https://bugs.webkit.org/show_bug.cgi?id=31200
203         Tests in http/tests/security/mixedContent start to fail when new tests are added
204
205         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
206
207 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
208
209         Reviewed by Jan Alonzo.
210
211         Create, and display a window for the inspector, for inspector
212         tests.
213
214         Need to also show/hide the inspector window to avoid having
215         problems with code assuming it is realized
216         https://bugs.webkit.org/show_bug.cgi?id=31347
217
218         * DumpRenderTree/gtk/DumpRenderTree.cpp:
219         (webInspectorShowWindow):
220         (webInspectorCloseWindow):
221         (webInspectorInspectWebView):
222         (createWebView):
223
224 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
225
226         Unreviewed Qt buildbot fix.
227
228         My previous fix was wrong, so revert that change and fix it by
229         returning when the document of the frame has no document element.
230         Idea is borrowed from mac and win DRT.
231
232         * DumpRenderTree/qt/DumpRenderTree.cpp:
233         (WebCore::DumpRenderTree::dumpFramesAsText):
234
235 2009-11-11  Eric Seidel  <eric@webkit.org>
236
237         Reviewed byg Kenneth Rohde Christiansen.
238
239         Update Kenneth's committer record to include the email he
240         uses on lists.webkit.org.
241
242         * Scripts/modules/committers.py:
243
244 2009-11-11  Eric Seidel  <eric@webkit.org>
245
246         Reviewed by Gustavo Noronha Silva.
247
248         Several committers use separate email addresses for bugzilla and svn.webkit.org
249         https://bugs.webkit.org/show_bug.cgi?id=31364
250
251         Update records for existing committers to include email addresses
252         used in svn.webkit.org and lists.webkit.org.
253         Most committers use the same email address in all 3 places, but some use
254         separate addresses.  committers.py needs record of each of these addresses.
255
256         * Scripts/modules/committers.py:
257
258 2009-11-11  Eric Seidel  <eric@webkit.org>
259
260         No review, adding second email address for an existing committer.
261
262         Add Yong Li's second bugzilla account to his committer record.
263         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
264
265         * Scripts/modules/committers.py:
266
267 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
268
269         Reviewed by Simon Hausmann.
270
271         If the frame has no innerText don't append it, and
272         do not add a newline which breaks some cross platform
273         results.
274
275         * DumpRenderTree/qt/DumpRenderTree.cpp:
276         (WebCore::DumpRenderTree::dumpFramesAsText):
277
278 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
279
280         Reviewed by Simon Hausmann.
281
282         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
283
284         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
285         (webkit_test_plugin_new_instance):
286         (webkit_test_plugin_destroy_instance):
287         (webkit_test_plugin_destroy_stream):
288
289 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
290
291         Reviewed by Mark Rowe.
292
293         Implement the functionality needed by plugins/window-open.html
294
295         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
296         (webkit_test_plugin_new_instance):
297         (webkit_test_plugin_set_window):
298
299 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
300
301         Reviewed by Simon Hausmann.
302
303         [Qt] Force -graphicssystem raster and -style windows when running DRT
304
305         * DumpRenderTree/qt/main.cpp:
306         * Scripts/run-webkit-tests:
307
308 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
309
310         Reviewed by Simon Hausmann.
311
312         Compute correct library paths for Qt
313
314         * Scripts/webkitdirs.pm:
315
316 2009-11-10  Mark Rowe  <mrowe@apple.com>
317
318         Reviewed by Sam Weinig.
319
320         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
321
322         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
323         about the validity of the self-signed certificates used in the regression tests.  We would then add the
324         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
325         that had enabled frame load delegate logging this would result in extra log messages being generated,
326         causing the test to fail.
327
328         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
329         tests.
330
331         * DumpRenderTree/mac/DumpRenderTree.mm:
332         (dumpRenderTree):
333         * DumpRenderTree/mac/FrameLoadDelegate.mm:
334         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
335
336 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
337
338         Reviewed by Kenneth Rohde Christiansen.
339
340         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
341
342         * DumpRenderTree/qt/DumpRenderTree.cpp:
343         (WebCore::DumpRenderTree::DumpRenderTree):
344
345 2009-11-10  Philippe Normand  <pnormand@igalia.com>
346
347         Reviewed by Jan Alonzo.
348
349         [GTK] Remove WebSocket configuration from WebKitWebSettings
350         https://bugs.webkit.org/show_bug.cgi?id=31244
351
352         Follow-up of r50724. Don't set the enable-web-socket property
353         anymore.
354
355         * DumpRenderTree/gtk/DumpRenderTree.cpp:
356         (resetDefaultsToConsistentValues):
357
358 2009-11-10  Oliver Hunt  <oliver@apple.com>
359
360         Reviewed by Maciej Stachowiak.
361
362         Rename 3D Canvas related classes to use WebGL prefix
363         https://bugs.webkit.org/show_bug.cgi?id=29095
364
365         Checkin new version of do-webcore-rename used to do the WebGL type rename,
366         and upate webkitdirs script to new method of testing for WebGL.
367
368         * Scripts/do-webcore-rename:
369         * Scripts/webkitdirs.pm:
370
371 2009-11-09  Oliver Hunt  <oliver@apple.com>
372
373         Reviewed by Geoff Garen.
374
375         Make do-webcore-rename work with git.
376
377         * Scripts/do-webcore-rename:
378
379 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
380
381         Adding Kenneth to the reviewers list.
382
383         * Scripts/modules/committers.py:
384
385 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
386
387         Reviewed by Jan Alonzo.
388
389         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
390         https://bugs.webkit.org/show_bug.cgi?id=30482
391
392         LayoutTestControllerGtk now uses the exposed
393         Page::tabKeyCyclesThroughElements API
394
395         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
396         (LayoutTestController::setTabKeyCyclesThroughElements):
397
398 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
399
400         Reviewed by Holger Freyther.
401
402         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
403         This helps to pass the test case below. Also replaced hardcoded
404         code numbers with defined constants.
405         https://bugs.webkit.org/show_bug.cgi?id=31185
406         
407         Test: editing/undo/undo-deleteWord.html
408
409         * DumpRenderTree/qt/EventSenderQt.cpp:
410         (EventSender::keyDown):
411
412 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
413
414         Reviewed by Holger Freyther.
415
416         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
417         https://bugs.webkit.org/show_bug.cgi?id=31164
418
419         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
420
421         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
422         (LayoutTestController::processWork):
423
424 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
425
426         Reviewed by Holger Freyther.
427
428         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
429         https://bugs.webkit.org/show_bug.cgi?id=31158
430
431         By invoking a script queue'd by queueScript(), 'true' was beeing returned
432         always, which from WorkQueue prospective means that a load has been started
433         and the queue processing should stop and wait for the load to finish.
434         Spinning it off into a loading and a non-loading variants was the solution
435         adopted by Mac's DRT to work around this problem. The former keeps returning
436         'true' while the later executes the script synchronously and returns 'false'
437         making it possible to the WorkQueue to proceed right away.
438
439         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
440         (LayoutTestController::processWork):
441         (LayoutTestController::queueLoadingScript):
442         (LayoutTestController::queueNonLoadingScript):
443         * DumpRenderTree/qt/LayoutTestControllerQt.h:
444         * DumpRenderTree/qt/WorkQueueItem.h:
445         (LoadingScriptItem::LoadingScriptItem):
446         (LoadingScriptItem::invoke):
447         (NonLoadingScriptItem::NonLoadingScriptItem):
448         (NonLoadingScriptItem::invoke):
449
450 2009-11-07  Mark Rowe  <mrowe@apple.com>
451
452         Rubber-stamped by Cameron Zwarich.
453
454         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
455
456         * Scripts/commit-log-editor:
457
458 2009-11-07  Mark Rowe  <mrowe@apple.com>
459
460         Reviewed by Darin Adler.
461
462         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
463         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
464
465         Move logic for determining the name and email address to use in a ChangeLog entry from
466         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
467         whether the author of the patch matches committer, and therefore needs access to the
468         email address that would be used in a ChangeLog entry.
469
470         Based on a patch by Pierre d'Herbemont.
471
472         * Scripts/VCSUtils.pm:
473         * Scripts/commit-log-editor:
474         * Scripts/prepare-ChangeLog:
475         * Scripts/webkitdirs.pm:
476
477 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
478
479         Reviewed by Adam Barth.
480
481         Added functionality to the layout test plugin to invoke document.open and
482         window.open with default arguments. The associated webkit bug is
483         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
484         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
485         work in Chromium (V8) if there is no calling javascript context. To achieve this
486         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
487         for the window.open test case and in NPP_DestroyStream for the document.open test case.
488
489         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
490         (testDocumentOpen):
491         (testWindowOpen):
492         (pluginAllocate):
493         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
494         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
495         (NPP_New):
496         (NPP_SetWindow):
497         (NPP_DestroyStream):
498         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
499         (NPP_New):
500         (NPP_SetWindow):
501         (NPP_NewStream):
502         (NPP_DestroyStream):
503
504 2009-11-06  Eric Seidel  <eric@webkit.org>
505
506         Reviewed by Adam Barth.
507
508         bugzilla-tool crashed with exception
509         https://bugs.webkit.org/show_bug.cgi?id=31092
510
511         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
512
513 2009-11-04  Eric Seidel  <eric@webkit.org>
514
515         No review, just add a line which got left out of the patch uploaded for commit.
516
517         commit-queue is crashing when trying to reject patches after unknown failures
518         https://bugs.webkit.org/show_bug.cgi?id=31091
519
520         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
521
522 2009-11-04  Adam Roben  <aroben@apple.com>
523
524         Remove bogus else clause in bugzilla-tool
525
526         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
527         create-bug raises exception after entering bug description
528
529         Reviewed by David Kilzer.
530
531         * Scripts/bugzilla-tool:
532         (CreateBug): else clauses are only hit if no exception is raised, so
533         it makes no sense to try to re-raise the exception in an else clause.
534         The exception will automatically be re-raised if it doesn't match any
535         of the except clauses, so we don't have to do anything special here at
536         all to get the desired behavior.
537
538 2009-11-04  Eric Seidel  <eric@webkit.org>
539
540         Reviewed by David Kilzer.
541
542         svn-apply's fixChangeLogPatch function seems broken
543         https://bugs.webkit.org/show_bug.cgi?id=30683
544
545         Update fixChangeLogPatch to be able to handle patches which
546         don't start at line 1.
547         Add unit tests for svn-apply to scm_unittest.py.
548
549         * Scripts/VCSUtils.pm:
550         * Scripts/modules/scm_unittest.py:
551
552 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
553
554         Reviewed by Beth Dakin.
555
556         Need to implement ARIA role="combobox"
557         https://bugs.webkit.org/show_bug.cgi?id=31096
558
559         * DumpRenderTree/AccessibilityUIElement.cpp:
560         (showMenuCallback):
561         (getIsExpandedCallback):
562         (AccessibilityUIElement::getJSClass):
563         * DumpRenderTree/AccessibilityUIElement.h:
564         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
565         (AccessibilityUIElement::isExpanded):
566         (AccessibilityUIElement::showMenu):
567         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
568         (AccessibilityUIElement::isExpanded):
569         (AccessibilityUIElement::showMenu):
570         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
571         (AccessibilityUIElement::isSelected):
572         (AccessibilityUIElement::isExpanded):
573         (AccessibilityUIElement::showMenu):
574
575 2009-11-04  Eric Seidel  <eric@webkit.org>
576
577         Reviewed by Adam Barth.
578
579         commit-queue is crashing when trying to reject patches after unknown failures
580         https://bugs.webkit.org/show_bug.cgi?id=31091
581
582         * Scripts/bugzilla-tool:
583          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
584            so we have to find out what the current patch is by asking bugzilla again.
585          - Discovered that this code was also leaking file descriptors, so fixed that.
586
587 2009-11-04  Adam Roben  <aroben@apple.com>
588
589         Make run-webkit-tests work for the Debug_Internal Windows
590         configuration
591
592         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
593         suffix.
594
595         Fixes <http://webkit.org/b/31123>.
596
597         Reviewed by Sam Weinig.
598
599         * Scripts/run-webkit-tests: Don't add the _debug suffix in
600         Debug_Internal, either.
601
602 2009-11-04  Eric Seidel  <eric@webkit.org>
603
604         Reviewed by Adam Barth.
605
606         committers.py needs a way to store non-bugzilla email addresses
607         https://bugs.webkit.org/show_bug.cgi?id=31037
608
609         Make Committer and Reviewer constructors take a single email or a list of emails.
610         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
611         Expose reviewers(), used by validate-committer-lists on bug 30970.
612
613         * Scripts/modules/committers.py:
614         * Scripts/modules/committers_unittest.py: Added tests for the new code.
615
616 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
617
618         Reviewed by David Levin.
619
620         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
621         https://bugs.webkit.org/show_bug.cgi?id=27491
622
623         The test path determination logic is changed to handle websocket and websocket/ssl cases.
624         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
625
626         Functions to start or stop Web Socket servers are added.
627
628         * Scripts/run-webkit-tests:
629
630 2009-11-03  Eric Seidel  <eric@webkit.org>
631
632         No review, just changing wording of log message.
633
634         Change log string to say "failed" instead of "rejected"
635         when a commit fails due to an out of date checkout.
636         This makes grepping the commit-queue log for rejected patches easier.
637
638         * Scripts/bugzilla-tool:
639
640 2009-11-03  Eric Seidel  <eric@webkit.org>
641
642         No review, adding commonly known committers missing from the file.
643
644         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
645
646 2009-11-03  Eric Seidel  <eric@webkit.org>
647
648         No review, just sort-order cleanup.
649
650         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
651
652 2009-11-03  Stephen White  <senorblanco@chromium.org>
653
654         (Unreviewed).
655
656         Add myself to committers.py.
657
658         * Scripts/modules/committers.py:
659
660 2009-11-03  Robin Dunn  <robin@alldunn.com>
661
662         Reviewed by Kevin Ollviier.
663
664         Add packaging scripts for Debian-based Linux distros.
665         
666         https://bugs.webkit.org/show_bug.cgi?id=31075
667
668         * wx/packaging/build-debian-installer.py: Added.
669         * wx/packaging/debian: Added.
670
671 2009-11-03  Dan Bernstein  <mitz@apple.com>
672
673         Reviewed by Anders Carlsson and Beth Dakin.
674
675         https://bugs.webkit.org/show_bug.cgi?id=31070
676
677         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
678         destroyed, it executes the value of the 'ondestroy' parameter as a
679         script.
680
681         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
682         (pluginAllocate): Initialize onDestroy.
683         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
684         onDestroy.
685         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
686         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
687         specified.
688         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
689
690 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
691
692         Reviewed by Xan Lopez.
693
694         https://bugs.webkit.org/show_bug.cgi?id=31035
695         [GTK] some accessibility tests hitting assertion in debug builds
696
697         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
698
699         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
700         (AccessibilityController::rootElement):
701
702 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
703
704         Reviewed by Beth Dakin.
705
706         Support ARIA "tab" roles
707         https://bugs.webkit.org/show_bug.cgi?id=30842
708
709         * DumpRenderTree/AccessibilityUIElement.cpp:
710         * DumpRenderTree/AccessibilityUIElement.h:
711         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
712         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
713         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
714
715 2009-11-01  Eric Seidel  <eric@webkit.org>
716
717         Reviewed by David Levin.
718
719         buildbots should use --exit-after-N-failures
720         https://bugs.webkit.org/show_bug.cgi?id=30809
721
722         Make the bots exit after 20 failures to prevent never-ending
723         test runs where every test spends a minute crashing.
724
725         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
726
727 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
728
729         Reviewed by Eric Seidel.
730
731         Turn on warnings for QtWebKit for gcc
732         https://bugs.webkit.org/show_bug.cgi?id=30958
733
734         * DumpRenderTree/qt/main.cpp: 
735         (crashHandler): Mark function NO_RETURN
736
737 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
738
739         Adding myself to the committers list.
740
741         * Scripts/modules/committers.py:
742
743 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
744
745         Fix an issue that Adam noticed in DRT.
746
747         Reviewed by Darin Adler.
748
749         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
750         (AccessibilityUIElement::role):
751         Get the length of the role text, and create a buffer dynamically.
752
753 2009-10-30  Eric Seidel  <eric@webkit.org>
754
755         No review, rolling out r50105.
756         http://trac.webkit.org/changeset/50105
757
758         This commit was causing:
759         https://bugs.webkit.org/show_bug.cgi?id=30869
760         We'll re-implement the feature a different way.
761
762         * Scripts/bugzilla-tool:
763
764 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
765
766         Test for MSAA: Accessibility of headings is not correct
767
768         https://bugs.webkit.org/show_bug.cgi?id=30937
769
770         Reviewed by Adam Roben.
771
772         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
773         (AccessibilityUIElement::role):
774         Allow the role returned to be a BSTR.
775         (AccessibilityUIElement::description):
776         Fix a copy/paste error.
777
778 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
779
780         Test for MSAA: Accessibility of links is wrong
781
782         https://bugs.webkit.org/show_bug.cgi?id=30928
783
784         Reviewed by Darin Adler.
785
786         * DumpRenderTree/AccessibilityUIElement.cpp:
787         (getAccessibilityValueCallback):
788         Return the accessibility value.
789         (AccessibilityUIElement::getJSClass):
790         Added "accessibilityValue" value.
791
792         * DumpRenderTree/AccessibilityUIElement.h:
793
794         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
795         (AccessibilityUIElement::accessibilityValue):
796         Stubbed.
797
798         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
799         (AccessibilityUIElement::accessibilityValue):
800         Stubbed.
801
802         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
803         (AccessibilityUIElement::accessibilityValue):
804         Get the object's value, and return it as a JS string.
805
806 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
807
808         Fix typo in command name used by wx build system.
809
810         * wx/build/build_utils.py:
811
812 2009-10-30  Adam Barth  <abarth@webkit.org>
813
814         Reviewed by Darin Adler.
815
816         Patch v1 is a dumb default name for patches
817         https://bugs.webkit.org/show_bug.cgi?id=30952
818
819         Let's use "Patch" instead.
820
821         * Scripts/bugzilla-tool:
822
823 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
824
825         Unreviewed trivial buildfix.
826
827         [Qt] Buildfix for r50333.
828
829         * DumpRenderTree/qt/DumpRenderTree.pro:
830
831 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
832
833         Reviewed by Holger Freyther.
834
835         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
836         https://bugs.webkit.org/show_bug.cgi?id=30953
837
838         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
839         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
840         makes qt DRT to share this implementation (as gtk and mac ports do).
841
842         * DumpRenderTree/qt/DumpRenderTree.pro:
843         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
844         * DumpRenderTree/qt/WorkQueue.h: Removed.
845
846 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
847
848         Unreviewed potential buildbot fix.
849
850         Second try: Reset page history before running each test.
851
852         Apparently the QWebHistory::clear() keeps the current page
853         in history which is not what we want, so we not additionally
854         sets the history capacity to 0 (forces removing everything)
855         and then sets it back to its original value.
856
857         * DumpRenderTree/qt/DumpRenderTree.cpp:
858         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
859
860 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
861
862         Unreviewed potential buildbot fix.
863
864         Reset page history before running each test.
865
866         * DumpRenderTree/qt/DumpRenderTree.cpp:
867         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
868
869 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
870
871         Reviewed by Eric Seidel.
872
873         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
874
875         Bug 28420 -  Implement HTML5 <ruby> rendering
876         (https://bugs.webkit.org/show_bug.cgi?id=28420)
877
878         No new tests (no functional change).
879
880         * Scripts/build-webkit:
881
882 2009-10-29  Dan Bernstein  <mitz@apple.com>
883
884         Reviewed by Mark Rowe.
885
886         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
887         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
888         define it.
889
890         * Scripts/VCSUtils.pm:
891         * Scripts/svn-apply:
892         * Scripts/svn-unapply:
893
894 2009-10-29  Xan Lopez  <xlopez@igalia.com>
895
896         Reviewed by Gustavo Noronha.
897
898         Use the GTK+ main loop instead of rolling our own mini-version of
899         it.
900
901         * DumpRenderTree/gtk/DumpRenderTree.cpp:
902         (dump):
903         (runTest):
904         (webViewLoadFinished):
905
906 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
907
908         Reviewed by Oliver Hunt.
909
910         Implement the Qt version of DRT dumpBackForwardList().
911
912         * DumpRenderTree/qt/DumpRenderTree.cpp:
913         (WebCore::dumpHistoryItem):
914         (WebCore::DumpRenderTree::dumpBackForwardList):
915
916 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
917
918         Reviewed by Adam Roben.
919
920         Implement DRT functionality for Qt introduced in
921         r28690 and r28705.
922
923         - Implemented pathToLocalResource which exposes the functionality of
924         converting a given unix path to the correct location on Windows.
925         - Implemented a way to remove machine-dependent information from paths
926         in layout test results.
927
928         * DumpRenderTree/qt/DumpRenderTree.cpp:
929         (WebCore::urlSuitableForTestResult):
930         (WebCore::WebPage::javaScriptConsoleMessage):
931         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
932         (LayoutTestController::pathToLocalResource):
933         * DumpRenderTree/qt/LayoutTestControllerQt.h:
934
935 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
936
937         Adding myself to the committers list.
938
939         * Scripts/modules/committers.py:
940
941 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
942
943         Adding myself to the committers list.
944
945         * Scripts/modules/committers.py:
946
947 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
948
949         Reviewed by Jan Alonzo.
950
951         [GTK] API to start inspector for a WebView
952         https://bugs.webkit.org/show_bug.cgi?id=22551
953
954         Use the new inspector API to implement the LayoutTestController
955         interfaces used to test the inspector.
956
957         * DumpRenderTree/gtk/DumpRenderTree.cpp:
958         (webInspectorInspectWebView):
959         (createWebView):
960         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
961         (LayoutTestController::showWebInspector):
962         (LayoutTestController::closeWebInspector):
963         (LayoutTestController::evaluateInWebInspector):
964
965 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
966
967         Reviewed by Eric Seidel.
968
969         [Qt] WebFrame::counterValueForElementById must not be exposed
970         https://bugs.webkit.org/show_bug.cgi?id=30882
971
972         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
973         (LayoutTestController::counterValueForElementById):
974
975 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
976
977         Rubberstamped by Oliver Hunt.
978
979         Fix the warning:
980
981         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
982         declared with attribute warn_unused_result".
983
984         by actually checking the result. In the case it is null, an
985         error has occoured, so treat it as the other fatal errors.
986
987         * DumpRenderTree/qt/DumpRenderTree.cpp:
988         (WebCore::DumpRenderTree::initializeFonts):
989
990 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
991
992         Reviewed by Darin Adler.
993
994         Provide a way to get counter values with layoutTestContoller
995         https://bugs.webkit.org/show_bug.cgi?id=30555
996
997         Define layoutTestContoller.counterValueForElementById.
998
999         * DumpRenderTree/LayoutTestController.cpp:
1000         (counterValueForElementByIdCallback):
1001         (LayoutTestController::staticFunctions):
1002         * DumpRenderTree/LayoutTestController.h:
1003         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1004         (LayoutTestController::counterValueForElementById):
1005
1006 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1007
1008         Rubberstamped by Oliver Hunt.
1009
1010         Change two methods to be internal for DRT use only.
1011
1012         Part of [Qt] Review all new API in Qt 4.6
1013         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1014
1015         * DumpRenderTree/qt/DumpRenderTree.cpp:
1016         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1017         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1018         (LayoutTestController::whiteListAccessFromOrigin):
1019
1020 2009-10-27  Eric Seidel  <eric@webkit.org>
1021
1022         Reviewed by Adam Barth.
1023
1024         REGRESSION: svn-apply exits(1) when applying a patch with a file add
1025         https://bugs.webkit.org/show_bug.cgi?id=30826
1026
1027         * Scripts/svn-apply:
1028          - Add () around all system() calls.
1029          - Use the correct system() == 0 or die instead of system() or die
1030          - Add descriptive messages to all die statements.
1031
1032 2009-10-27  Steve Block  <steveblock@google.com>
1033
1034         Reviewed by NOBODY.
1035
1036         Adds steveblock@google.com to list of committers.
1037
1038         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
1039
1040 2009-10-27  Eric Seidel  <eric@webkit.org>
1041
1042         Reviewed by Adam Barth.
1043
1044         svn-apply can exit(0) even on patch failure
1045         https://bugs.webkit.org/show_bug.cgi?id=29622
1046
1047         * Scripts/svn-apply:
1048          - Add a bunch of "or die" statements, hopefully catching all
1049            possible cases where failure could still exit(0).
1050
1051 2009-10-27  Eric Seidel  <eric@webkit.org>
1052
1053         Reviewed by Adam Barth.
1054
1055         svn-* scripts should share code through VCSUtils.pm
1056         https://bugs.webkit.org/show_bug.cgi?id=30791
1057
1058         Just moving code into a shared location.
1059
1060         * Scripts/VCSUtils.pm:
1061         * Scripts/prepare-ChangeLog:
1062         * Scripts/resolve-ChangeLogs:
1063         * Scripts/svn-apply:
1064         * Scripts/svn-create-patch:
1065         * Scripts/svn-unapply:
1066         * Scripts/update-webkit:
1067
1068 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
1069
1070         Suppress a huge number of MSVC warnings when building wxWebKit.
1071
1072         * wx/build/settings.py:
1073
1074 2009-10-26  Eric Seidel  <eric@webkit.org>
1075
1076         No review, just adding Mike Belshe to the committers list.
1077
1078         * Scripts/modules/committers.py:
1079
1080 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1081
1082         Reviewed by Darin Adler.
1083
1084         Make .rc files compile on Windows without depending on MFC headers
1085         https://bugs.webkit.org/show_bug.cgi?id=30750
1086
1087         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
1088         windows.h instead of afxres.h because it exists even when MFC is not 
1089         installed, and is all that's needed here.
1090
1091         * FindSafari/FindSafari.rc: Ditto
1092
1093 2009-10-24  Eric Seidel  <eric@webkit.org>
1094
1095         Reviewed by Adam Barth.
1096
1097         bugzilla-tool post-diff should know how to mark commit-queue=?
1098         https://bugs.webkit.org/show_bug.cgi?id=29202
1099
1100         * Scripts/bugzilla-tool:
1101          - Add --commit-queue option to post-diff, post-commits and create-bug.
1102         * Scripts/modules/bugzilla.py:
1103          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1104          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
1105
1106 2009-10-23  Eric Seidel  <eric@webkit.org>
1107
1108         Reviewed by Adam Barth.
1109
1110         bugzilla-tool commit-queue does not notice modifications to committers.py
1111         https://bugs.webkit.org/show_bug.cgi?id=30084
1112
1113         * Scripts/bugzilla-tool:
1114          - Make commit-queue re-exec itself instead of using while(1).
1115          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
1116          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
1117
1118 2009-10-22  Eric Seidel  <eric@webkit.org>
1119
1120         Reviewed by Adam Barth.
1121
1122         commit-queue will get stuck on patches if land-patches terminates unexpectedly
1123         https://bugs.webkit.org/show_bug.cgi?id=30634
1124
1125         * Scripts/bugzilla-tool:
1126          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
1127          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
1128
1129 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
1130
1131         Reviewed by Eric Seidel.
1132
1133         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
1134
1135         https://bugs.webkit.org/show_bug.cgi?id=30763
1136
1137         * pywebsocket/mod_pywebsocket/__init__.py:
1138         * pywebsocket/mod_pywebsocket/dispatch.py:
1139         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
1140         * pywebsocket/mod_pywebsocket/standalone.py:
1141         * pywebsocket/setup.py:
1142         * pywebsocket/test/test_dispatch.py:
1143
1144 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
1145
1146         Reviewed by David Levin.
1147
1148         REGRESSION: 2 failures in run-webkit-unittests
1149         https://bugs.webkit.org/show_bug.cgi?id=30645
1150
1151         * Scripts/modules/cpp_style_unittest.py:
1152         Fixed a few test scenarios which apparently lost some spaces from 
1153         text literals.
1154
1155 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
1156
1157         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
1158
1159         * Scripts/webkitdirs.pm:
1160
1161 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
1162
1163         Reviewed by Darin Adler.
1164
1165         Unification of using null device in perl scripts.
1166         https://bugs.webkit.org/show_bug.cgi?id=30572
1167
1168         * Scripts/VCSUtils.pm:
1169         * Scripts/bisect-builds:
1170         * Scripts/resolve-ChangeLogs:
1171         * Scripts/run-iexploder-tests:
1172         * Scripts/run-jsc:
1173         * Scripts/run-mangleme-tests:
1174         * Scripts/run-webkit-tests:
1175         * Scripts/webkitdirs.pm:
1176         Using File::Spec->devnull() instead of hard coded /dev/null.
1177
1178 2009-10-26  Eric Seidel  <eric@webkit.org>
1179
1180         Reviewed by Holger Freyther.
1181
1182         Reviewers are missing from committers.py
1183         https://bugs.webkit.org/show_bug.cgi?id=30733
1184
1185         * Scripts/modules/committers.py:
1186
1187 2009-10-23  Eric Seidel  <eric@webkit.org>
1188
1189         No review, only adding Alice to the list of reviewers.
1190
1191         * Scripts/modules/committers.py:
1192
1193 2009-10-23  Eric Seidel  <eric@webkit.org>
1194
1195         Reviewed by Eric Carlson.
1196
1197         fast/media/mq-transform-02.html failed on Leopard Commit Bot
1198         https://bugs.webkit.org/show_bug.cgi?id=30700
1199
1200         * DumpRenderTree/mac/DumpRenderTree.mm:
1201         (resetDefaultsToConsistentValues): Update QuickTime version check.
1202
1203 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
1204
1205         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
1206         character measurement APIs that are private on Tiger.
1207
1208         * wx/build/settings.py:
1209
1210 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1211
1212         Reviewed by NOBODY (build fix).
1213         Build fix following bug #30696.
1214
1215         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1216         (LayoutTestController::evaluateScriptInIsolatedWorld):
1217
1218 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1219
1220         Reviewed by Sam Weinig & Geoff Garen.
1221
1222         https://bugs.webkit.org/show_bug.cgi?id=30696
1223         Enable isolated-worlds tests on mac.
1224
1225         Add private interface for DRT to invoke execution in a given world.
1226
1227         * DumpRenderTree/LayoutTestController.cpp:
1228         (evaluateScriptInIsolatedWorldCallback):
1229         (LayoutTestController::staticFunctions):
1230         * DumpRenderTree/LayoutTestController.h:
1231         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1232         (LayoutTestController::evaluateScriptInIsolatedWorld):
1233         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1234         (LayoutTestController::evaluateScriptInIsolatedWorld):
1235
1236 2009-10-21  Eric Seidel  <eric@webkit.org>
1237
1238         Reviewed by Adam Barth.
1239
1240         bugzilla-tool's "patch failed to download an apply" error should give more information
1241         https://bugs.webkit.org/show_bug.cgi?id=30632
1242
1243         * Scripts/modules/scm.py:
1244          - Use the common run_command method instead of custom POpen code.
1245          - Make run_command know how to take pipes as input.
1246         * Scripts/modules/scm_unittest.py:
1247          - Add new tests to cover change.
1248          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
1249
1250 2009-10-21  Kent Tamura  <tkent@chromium.org>
1251
1252         Unreviewed.  Adding myself to the committers list.
1253
1254         * Scripts/modules/committers.py:
1255
1256 2009-10-21  Robin Dunn  <robin@alldunn.com>
1257
1258         Reviewed by Kevin Ollivier.
1259
1260         Update the Windows installer builder to work with Vista / Win 7 and with git.
1261         
1262         https://bugs.webkit.org/show_bug.cgi?id=30649
1263
1264         * wx/build/build_utils.py:
1265         * wx/packaging/build-mac-installer.py:
1266         * wx/packaging/build-win-installer.py:
1267         * wx/packaging/wxWebKitInstaller.iss.in:
1268
1269 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1270
1271         Reviewed by Gustavo Noronha.
1272
1273         [GTK] Added conditional code to avoid using
1274         gdk_window_get_root_coords if we do not have a gtk+ release newer
1275         than 2.17.3.
1276         https://bugs.webkit.org/show_bug.cgi?id=30636
1277
1278         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1279
1280 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
1281
1282         Reviewed by Eric Seidel.
1283
1284         [Qt] Added dummy implementation for keepWebHistory()
1285         https://bugs.webkit.org/show_bug.cgi?id=30592
1286
1287         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1288         (LayoutTestController::keepWebHistory):
1289         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1290
1291 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1292
1293         Reviewed by Xan Lopez.
1294
1295         [GTK] Fixed the double click condition, it is not double click if
1296         we move in just in one direction.
1297         https://bugs.webkit.org/show_bug.cgi?id=30636
1298
1299         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1300
1301 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1302
1303         Reviewed by Xan Lopez.
1304
1305         [GTK] Initialize the events completly before emitting them.
1306         https://bugs.webkit.org/show_bug.cgi?id=30633
1307
1308         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1309
1310 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
1311
1312         wx build fix. Fix for when linking using --as-needed with gcc.
1313
1314         * wx/browser/wscript:
1315
1316 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
1317
1318         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
1319         to support all the features used by CURL backend.
1320         
1321         * wx/build/settings.py:
1322         * wx/install-unix-extras:
1323
1324 2009-10-20  Anton Muhin  <antonm@chromium.org>
1325
1326         Reviewed by Adam Barth.
1327
1328         Add {ager,antonm,yurys}@chromium.org into committers.py
1329         https://bugs.webkit.org/show_bug.cgi?id=30560
1330
1331         * Scripts/modules/committers.py:
1332
1333 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1334
1335         Reviewed by Tor Arne Vestbø.
1336
1337         Make the Netscape Test plugin available to the Qt launcher.
1338
1339         * Scripts/run-launcher:
1340
1341 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
1342
1343         Reviewed by David Levin.
1344
1345         Removed WebSocket runtime settings.
1346         https://bugs.webkit.org/show_bug.cgi?id=29896
1347
1348         WebSocket runtime configuration is supported by chromium/v8 only.
1349
1350         * DumpRenderTree/mac/DumpRenderTree.mm:
1351         (resetDefaultsToConsistentValues):
1352         * DumpRenderTree/win/DumpRenderTree.cpp:
1353         (resetDefaultsToConsistentValues):
1354
1355 2009-10-19  Nate Chapin  <japhet@chromium.org>
1356
1357         Reviewed by Adam Barth.
1358
1359         Add testFail() to test plugin so we can test our handling of a
1360         plugin invoke call returning false.
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=30239
1363
1364         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
1365         (pluginInvoke):
1366         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
1367
1368 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
1369
1370         Reviewed by Gustavo Noronha.
1371
1372         Enable DOM pasting when running layout tests.
1373
1374         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1375         (resetDefaultsToConsistentValues):
1376
1377 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1378
1379         Reviewed by Simon Hausmann.
1380
1381         Use the setPreferredContentsSize method instead
1382         of setFixedContentsSize, as the method has been renamed.
1383
1384         * DumpRenderTree/qt/DumpRenderTree.cpp:
1385         (WebCore::DumpRenderTree::open):
1386         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1387         (LayoutTestController::setFixedContentsSize):
1388
1389 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
1390
1391         Reviewed by Dan Bernstein.
1392
1393         https://bugs.webkit.org/show_bug.cgi?id=30456
1394         Fixes for new Debug_All Windows build configuration.
1395
1396         * DumpRenderTree/win/DumpRenderTree.cpp:
1397         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
1398         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
1399
1400 2009-10-16  Eric Seidel  <eric@webkit.org>
1401
1402         Reviewed by Adam Barth.
1403
1404         commit-queue status bot should list which buildbot is blocking the queue
1405         https://bugs.webkit.org/show_bug.cgi?id=30452
1406
1407         Add new methods and testing.
1408
1409         * Scripts/bugzilla-tool:
1410         * Scripts/modules/buildbot.py:
1411         * Scripts/modules/buildbot_unittest.py:
1412
1413 2009-10-16  Eric Seidel  <eric@webkit.org>
1414
1415         Reviewed by Adam Barth.
1416
1417         run-webkit-tests fails when CWD is not inside a WebKit checkout
1418         https://bugs.webkit.org/show_bug.cgi?id=30451
1419
1420         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
1421         * Scripts/modules/scm_unittest.py:
1422           - Remove use of original_path (we don't need to restore the CWD).
1423           - Don't use '.' to find the webkit checkout, use __file__ instead.
1424
1425 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
1426
1427         Reviewed by Adam Roben.
1428
1429         Add a Debug_All configuration to build entire stack as debug.
1430         Change Debug_Internal to:
1431         - stop using _debug suffix for all WebKit/Safari binaries
1432         - not use _debug as a DLL naming suffix
1433         - use non-debug C runtime lib.
1434
1435         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
1436         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
1437         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
1438         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1439         Add missing debug.vsprops inherited property sheet.
1440         Add Debug_All configuration.
1441         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
1442         * WinLauncher/WinLauncher.vcproj:
1443         Removed extraneous definitions inherited from vsprops.
1444         Add Debug_All configuration.
1445
1446 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
1447
1448         Reviewed by David Levin.
1449
1450         check-webkit-style is wrong about indent checking in namespaces
1451         in header files and a few other things
1452         https://bugs.webkit.org/show_bug.cgi?id=30362
1453
1454         The few other things include:
1455         + check-webkit-style does not require spaces around the equal sign
1456           inside 'if' statements and around binary operators that take 
1457           numeric literals.
1458         + check-webkit-style reports false errors for the / operator
1459           when part of a filename in the #include directive.
1460
1461         * Scripts/modules/cpp_style.py:
1462         Improved indentation checking and space checking around
1463         binary operators. While the checks are still not perfect,
1464         they are clearly better than before.
1465         * Scripts/modules/cpp_style_unittest.py:
1466         Added test cases for the newly supported checks and modified old
1467         test cases to match the new guidelines
1468
1469 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
1470
1471         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
1472
1473         * wx/build/settings.py:
1474
1475 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
1476
1477         Reviewed by David Levin.
1478
1479         Add mod_pywebsocket to test Web Sockets.
1480         http://code.google.com/p/pywebsocket/
1481         https://bugs.webkit.org/show_bug.cgi?id=27490
1482
1483         * pywebsocket/COPYING: Added.
1484         * pywebsocket/MANIFEST.in: Added.
1485         * pywebsocket/README: Added.
1486         * pywebsocket/example/echo_client.py: Added.
1487         * pywebsocket/example/echo_wsh.py: Added.
1488         * pywebsocket/mod_pywebsocket/__init__.py: Added.
1489         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
1490         * pywebsocket/mod_pywebsocket/handshake.py: Added.
1491         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
1492         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
1493         * pywebsocket/mod_pywebsocket/standalone.py: Added.
1494         * pywebsocket/mod_pywebsocket/util.py: Added.
1495         * pywebsocket/setup.py: Added.
1496         * pywebsocket/test/config.py: Added.
1497         * pywebsocket/test/mock.py: Added.
1498         * pywebsocket/test/run_all.py: Added.
1499         * pywebsocket/test/test_dispatch.py: Added.
1500         * pywebsocket/test/test_handshake.py: Added.
1501         * pywebsocket/test/test_mock.py: Added.
1502         * pywebsocket/test/test_msgutil.py: Added.
1503         * pywebsocket/test/test_util.py: Added.
1504         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
1505         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
1506         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
1507         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
1508         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
1509         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
1510         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
1511         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
1512
1513 2009-10-15  James Robinson  <jamesr@google.com>
1514
1515         Reviewed by David Levin.
1516
1517         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
1518
1519         https://bugs.webkit.org/show_bug.cgi?id=30426
1520
1521         * Scripts/modules/cpp_style.py:
1522         * Scripts/modules/cpp_style_unittest.py:
1523
1524 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
1525
1526         Reviewed by Adam Roben.
1527
1528         Fixes <http://webkit.org/b/30411>.
1529         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
1530         
1531         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
1532         building Chromium.
1533
1534         * Scripts/pdevenv:
1535
1536 2009-10-15  Robin Dunn  <robin@alldunn.com>
1537
1538         Reviewed by Kevin Ollivier.
1539
1540         Add Mac package building scripts for wx.
1541         
1542         https://bugs.webkit.org/show_bug.cgi?id=30405
1543
1544         * wx/build/build_utils.py:
1545         * wx/build/settings.py:
1546         * wx/packaging/build-mac-installer.py: Added.
1547
1548 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
1549
1550         Reviewed by Gustavo Noronha.
1551
1552         Enable Web Sockets support when running layout tests.
1553
1554         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1555         (resetDefaultsToConsistentValues):
1556
1557 2009-10-15  Xan Lopez  <xlopez@igalia.com>
1558
1559         Reviewed by Gustavo Noronha.
1560
1561         Need to initialize event.button.button, since in most cases a
1562         button number is not passed as an argument.
1563
1564         * DumpRenderTree/gtk/EventSender.cpp:
1565         (mouseDownCallback):
1566         (mouseUpCallback):
1567
1568 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
1569
1570         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
1571         the OS if none was explicitly set.
1572
1573         * wx/build/settings.py:
1574
1575 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
1576
1577         Reviewed by Timothy Hatcher.
1578
1579         Web Inspector: enable developers extras within inspector layout tests.
1580
1581         https://bugs.webkit.org/show_bug.cgi?id=30014
1582
1583         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1584         (LayoutTestController::showWebInspector):
1585         (LayoutTestController::closeWebInspector):
1586         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1587         (LayoutTestController::showWebInspector):
1588         (LayoutTestController::closeWebInspector):
1589
1590 2009-10-14  José Millán Soto  <jmillan@igalia.com>
1591
1592         Reviewed by Jan Alonzo.
1593
1594         GtkLauncher is using a deprecated signal
1595         https://bugs.webkit.org/show_bug.cgi?id=30364
1596
1597         Modified GtkLauncher to use notify::title signal instead of
1598         deprecated title-changed signal
1599
1600         * GtkLauncher/main.c:
1601         (notify_title_cb):
1602         (create_browser):
1603
1604 2009-10-14  Brady Eidson  <beidson@apple.com>
1605
1606         Reviewed by Sam Weinig.
1607
1608         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1609         1 - Disables WebHistory
1610         2 - Doesn't make sense in that context anyway.
1611
1612         * DumpRenderTree/win/DumpRenderTree.cpp:
1613         (createWebViewAndOffscreenWindow):
1614
1615 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
1616
1617         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
1618         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
1619
1620         * wx/build/settings.py:
1621         * wx/install-unix-extras:
1622
1623 2009-10-14  Brady Eidson  <beidson@apple.com>
1624
1625         Reviewed by Sam Weinig.
1626
1627         WebKit Win API should provide a delegate interface for global history.
1628         https://bugs.webkit.org/show_bug.cgi?id=29905
1629
1630         * DumpRenderTree/LayoutTestController.cpp:
1631         (LayoutTestController::LayoutTestController):
1632         * DumpRenderTree/LayoutTestController.h:
1633         (LayoutTestController::dumpHistoryDelegateCallbacks):
1634         (LayoutTestController::setDumpHistoryDelegateCallbacks):
1635                 
1636         * DumpRenderTree/win/DumpRenderTree.cpp:
1637         (shouldLogHistoryDelegates):
1638         (runTest):
1639         (createWebViewAndOffscreenWindow):
1640         (main):
1641         * DumpRenderTree/win/DumpRenderTree.vcproj:
1642         
1643         Add the IWebHistoryDelegate to DRT Windows:
1644         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
1645         (wstringFromBSTR):
1646         (HistoryDelegate::HistoryDelegate):
1647         (HistoryDelegate::~HistoryDelegate):
1648         (HistoryDelegate::QueryInterface):
1649         (HistoryDelegate::AddRef):
1650         (HistoryDelegate::Release):
1651         (HistoryDelegate::didNavigateWithNavigationData):
1652         (HistoryDelegate::didPerformClientRedirectFromURL):
1653         (HistoryDelegate::didPerformServerRedirectFromURL):
1654         (HistoryDelegate::updateHistoryTitle):
1655         (HistoryDelegate::populateVisitedLinksForWebView):
1656         * DumpRenderTree/win/HistoryDelegate.h: Added.
1657
1658         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1659         (LayoutTestController::removeAllVisitedLinks):
1660
1661 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
1662
1663         Reviewed by Simon Hausmann.
1664
1665         [Qt] Implement support for setPOSIXLocale on Qt.
1666         https://bugs.webkit.org/show_bug.cgi?id=30268 
1667  
1668         * DumpRenderTree/qt/DumpRenderTree.cpp:
1669         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1670         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1671         (LayoutTestController::setPOSIXLocale):
1672         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1673
1674 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1675
1676         Unreviewed, adding myself to reviewers list.
1677
1678         * Scripts/modules/committers.py:
1679
1680 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1681
1682         Reviewed by Mark Rowe.
1683
1684         Fix null assignment so root tests work again.
1685
1686         * Scripts/webkitdirs.pm:
1687
1688 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1689
1690         Reviewed by Simon Hausmann.
1691
1692         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
1693         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
1694         This is done in preparation of implementing missing features in DRT.
1695         No functionality changes made yet.
1696
1697         * DumpRenderTree/qt/DumpRenderTree.cpp:
1698         * DumpRenderTree/qt/DumpRenderTree.pro:
1699         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
1700         (EventSender::EventSender):
1701         (EventSender::mouseDown):
1702         (EventSender::mouseUp):
1703         (EventSender::mouseMoveTo):
1704         (EventSender::leapForward):
1705         (EventSender::keyDown):
1706         (EventSender::contextClick):
1707         (EventSender::scheduleAsynchronousClick):
1708         (EventSender::frameUnderMouse):
1709         * DumpRenderTree/qt/EventSenderQt.h: Added.
1710         (EventSender::clearKillRing):
1711         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
1712         (LayoutTestController::LayoutTestController):
1713         (LayoutTestController::reset):
1714         (LayoutTestController::processWork):
1715         (LayoutTestController::maybeDump):
1716         (LayoutTestController::waitUntilDone):
1717         (LayoutTestController::notifyDone):
1718         (LayoutTestController::windowCount):
1719         (LayoutTestController::clearBackForwardList):
1720         (LayoutTestController::dumpEditingCallbacks):
1721         (LayoutTestController::dumpResourceLoadCallbacks):
1722         (LayoutTestController::queueBackNavigation):
1723         (LayoutTestController::queueForwardNavigation):
1724         (LayoutTestController::queueLoad):
1725         (LayoutTestController::queueReload):
1726         (LayoutTestController::queueScript):
1727         (LayoutTestController::provisionalLoad):
1728         (LayoutTestController::timerEvent):
1729         (LayoutTestController::encodeHostName):
1730         (LayoutTestController::decodeHostName):
1731         (LayoutTestController::setJavaScriptProfilingEnabled):
1732         (LayoutTestController::setFixedContentsSize):
1733         (LayoutTestController::setPrivateBrowsingEnabled):
1734         (LayoutTestController::setPopupBlockingEnabled):
1735         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1736         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1737         (LayoutTestController::numberOfActiveAnimations):
1738         (LayoutTestController::disableImageLoading):
1739         (LayoutTestController::dispatchPendingLoadRequests):
1740         (LayoutTestController::setDatabaseQuota):
1741         (LayoutTestController::clearAllDatabases):
1742         (LayoutTestController::whiteListAccessFromOrigin):
1743         (LayoutTestController::waitForPolicyDelegate):
1744         (LayoutTestController::overridePreference):
1745         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
1746         (LayoutTestController::isLoading):
1747         (LayoutTestController::setLoading):
1748         (LayoutTestController::shouldDumpAsText):
1749         (LayoutTestController::shouldDumpBackForwardList):
1750         (LayoutTestController::shouldDumpChildrenAsText):
1751         (LayoutTestController::shouldDumpDatabaseCallbacks):
1752         (LayoutTestController::shouldDumpStatusCallbacks):
1753         (LayoutTestController::shouldWaitUntilDone):
1754         (LayoutTestController::canOpenWindows):
1755         (LayoutTestController::shouldDumpTitleChanges):
1756         (LayoutTestController::waitForPolicy):
1757         (LayoutTestController::dumpAsText):
1758         (LayoutTestController::dumpChildFramesAsText):
1759         (LayoutTestController::dumpDatabaseCallbacks):
1760         (LayoutTestController::dumpStatusCallbacks):
1761         (LayoutTestController::setCanOpenWindows):
1762         (LayoutTestController::dumpBackForwardList):
1763         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1764         (LayoutTestController::display):
1765         (LayoutTestController::dumpTitleChanges):
1766         (LayoutTestController::dumpSelectionRect):
1767         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
1768         (TextInputController::TextInputController):
1769         (TextInputController::doCommand):
1770         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
1771         * DumpRenderTree/qt/WorkQueue.cpp:
1772         * DumpRenderTree/qt/WorkQueue.h:
1773         * DumpRenderTree/qt/WorkQueueItem.h:
1774         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
1775         (findFrameNamed):
1776         (LoadItem::invoke):
1777         (ReloadItem::invoke):
1778         (ScriptItem::invoke):
1779         (BackForwardItem::invoke):
1780         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
1781         * DumpRenderTree/qt/jsobjects.h:
1782
1783 2009-10-13  Dmitry Titov  <dimich@chromium.org>
1784
1785         Not reviewed, adding myself to the list of reviewers.
1786
1787         * Scripts/modules/committers.py:
1788
1789 2009-10-13  Anders Carlsson  <andersca@apple.com>
1790
1791         Reviewed by Sam Weinig.
1792
1793         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
1794
1795         Make the private browsing mode testable by the test plug-in.
1796         
1797         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1798         (pluginGetProperty):
1799         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1800         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1801         (NPP_New):
1802         (NPP_SetValue):
1803
1804 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
1805
1806         No review, just adding self to the list of reviewers.
1807
1808         * Scripts/modules/committers.py:
1809
1810 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
1811
1812         Reviewed by Adam Roben.
1813
1814         Web Inspector: Use proper web view in inspector layout
1815         tests for windows.
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=30298
1818
1819         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1820         (LayoutTestController::showWebInspector):
1821         (LayoutTestController::closeWebInspector):
1822         (LayoutTestController::evaluateInWebInspector):
1823
1824 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
1825
1826         Reviewed by Sam Weinig.
1827
1828         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
1829         https://bugs.webkit.org/show_bug.cgi?id=29841
1830
1831         * DumpRenderTree/mac/DumpRenderTree.mm:
1832         (resetDefaultsToConsistentValues):
1833         * DumpRenderTree/win/DumpRenderTree.cpp:
1834         (resetDefaultsToConsistentValues):
1835
1836 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
1837
1838         Reviewed by Dimitri Glazkov.
1839
1840         Chromium Port - Windows
1841         https://bugs.webkit.org/show_bug.cgi?id=29969
1842
1843         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
1844         * Scripts/webkitdirs.pm:
1845
1846 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
1847
1848         Reviewed by Darin Adler.
1849
1850         jsc scripts cleanup and Qt/GTK fix
1851         https://bugs.webkit.org/show_bug.cgi?id=30288
1852
1853         Duplicated jscPath() moved to webkitdirs.pm.
1854         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
1855         Configuration added (release/debug) to path for Qt-port on Windows.
1856
1857         * Scripts/run-javascriptcore-tests:
1858         * Scripts/run-jsc:
1859         * Scripts/run-sunspider:
1860         * Scripts/sunspider-compare-results:
1861         * Scripts/webkitdirs.pm:
1862
1863 2009-10-11  Adam Barth  <abarth@webkit.org>
1864
1865         Unreviewed.  Add Collin to committers.py.
1866
1867         * Scripts/modules/committers.py:
1868
1869 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
1870
1871         wx build fix, add bindings to source/include dirs now that there are sources there.
1872
1873         * wx/build/settings.py:
1874
1875 2009-10-09  Mark Rowe  <mrowe@apple.com>
1876
1877         Reviewed by Brady Eidson.
1878
1879         Enable plug-in halting in DumpRenderTree.
1880
1881         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
1882         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
1883
1884         * DumpRenderTree/mac/DumpRenderTree.mm:
1885         (resetDefaultsToConsistentValues):
1886         * DumpRenderTree/mac/UIDelegate.mm:
1887         (-[UIDelegate webView:shouldHaltPlugin:]):
1888
1889 2009-10-08  Brady Eidson  <beidson@apple.com>
1890
1891         Reviewed by Dan Bernstein.
1892
1893         Ask the History Delegate to populate the visited links hash.
1894         <rdar://problem/7285293> and https://webkit.org/b/29904
1895
1896         Add the ability for LayoutTestController to clear all visited links.
1897         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
1898
1899         * DumpRenderTree/LayoutTestController.cpp:
1900         (LayoutTestController::LayoutTestController):
1901         (removeAllVisitedLinksCallback):
1902         (LayoutTestController::staticFunctions):
1903         * DumpRenderTree/LayoutTestController.h:
1904         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1905         (LayoutTestController::removeAllVisitedLinks):
1906
1907         * DumpRenderTree/mac/HistoryDelegate.mm:
1908         (-[HistoryDelegate populateVisitedLinksForWebView:]):
1909
1910         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1911         (LayoutTestController::removeAllVisitedLinks):
1912         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1913         (LayoutTestController::removeAllVisitedLinks):
1914         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1915         (LayoutTestController::removeAllVisitedLinks):
1916
1917
1918 2009-10-08  Daniel Bates  <dbates@webkit.org>
1919
1920         Reviewed by Adam Roben.
1921
1922         https://bugs.webkit.org/show_bug.cgi?id=30175
1923         
1924         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
1925         the OLE drag-and-drop return value like the function it emulates. Currently, 
1926         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
1927         whether the drag-and-drop operation was successful or was cancelled.
1928         
1929         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
1930         return value according to whether the drop operation was successful or not.
1931
1932         * DumpRenderTree/win/EventSender.cpp:
1933         (doMouseUp): Added parameter oleDragAndDropReturnValue.
1934         (replaySavedEvents): Ditto.
1935         * DumpRenderTree/win/EventSender.h:
1936         * DumpRenderTree/win/UIDelegate.cpp:
1937         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
1938
1939 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1940
1941         Reviewed by Xan Lopez.
1942
1943         [GTK] Added support for a parameter setting the button that was
1944         pressed in the mouseDown function.
1945         https://bugs.webkit.org/show_bug.cgi?id=30220
1946
1947         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1948
1949 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1950
1951         Reviewed by Xan Lopez.
1952
1953         [GTK] Added a line to the bottom of the expected result to match
1954         the output of the test.
1955         https://bugs.webkit.org/show_bug.cgi?id=30220
1956
1957         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
1958         expected.txt:
1959
1960 2009-10-08  Adam Roben  <aroben@apple.com>
1961
1962         Use QueryInterface to get IWebInspectorPrivate
1963
1964         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
1965         accessed in a more standard way
1966
1967         Reviewed by John Sullivan and Tim Hatcher.
1968
1969         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1970         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
1971         by calling IWebViewPrivate::inspector, then use QueryInterface to get
1972         to the IWebInspectorPrivate interface.
1973
1974 2009-10-07  Adam Roben  <aroben@apple.com>
1975
1976         Implement DRT support for origin whitelisting
1977
1978         Fixes <http://webkit.org/b/30185>.
1979
1980         Reviewed by Eric Seidel.
1981
1982         * DumpRenderTree/win/DumpRenderTree.cpp:
1983         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
1984         whitelist, to match Mac DRT.
1985         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1986         (LayoutTestController::whiteListAccessFromOrigin): Call through to
1987         IWebViewPrivate::whiteListAccessFromOrigin.
1988
1989 2009-10-07  Brady Eidson  <beidson@apple.com>
1990
1991         Reviewed by Darin Adler.
1992
1993         Send title changes to the global history delegate.
1994         <rdar://problem/7285293> and https://webkit.org/b/29904
1995
1996         * DumpRenderTree/mac/HistoryDelegate.mm:
1997         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
1998
1999 2009-10-07  Adam Barth  <abarth@webkit.org>
2000
2001         Unreviewed.  Remove some folks from committers.py who were listed on
2002         the WebKit Team wiki page but who weren't actually listed as commit+.
2003         At some point, we should coorelate this list with the committers
2004         mailing list.
2005
2006         * Scripts/modules/committers.py:
2007
2008 2009-10-07  Adam Barth  <abarth@webkit.org>
2009
2010         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2011         the wiki into committers.py.
2012
2013         * Scripts/modules/committers.py:
2014
2015 2009-10-07  Adam Barth  <abarth@webkit.org>
2016
2017         Unreviewed.  Added Aaron Boodman to committers.py.
2018
2019         * Scripts/modules/committers.py:
2020
2021 2009-10-07  Evan Martin  <evan@chromium.org>
2022
2023         Reviewed by Darin Adler.
2024
2025         Add API to LayoutTestController for re/setting the system locale.
2026         https://bugs.webkit.org/show_bug.cgi?id=18994
2027
2028         * DumpRenderTree/LayoutTestController.cpp:
2029         (setLocaleCallback):
2030         (LayoutTestController::staticFunctions):
2031         (LayoutTestController::setLocale):
2032         * DumpRenderTree/LayoutTestController.h:
2033
2034 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
2035
2036         Reviewed by Jan Alonzo.
2037
2038         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2039         https://bugs.webkit.org/show_bug.cgi?id=29689
2040
2041         Build fix by adding -lfontconfig for DumpRenderTree.
2042
2043         * GNUmakefile.am:
2044
2045 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2046
2047         Reviewed by Simon Hausmann.
2048
2049         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
2050
2051         * Scripts/run-webkit-tests:
2052
2053 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2054
2055         Reviewed by Gustavo Noronha.
2056
2057         "delete" in EventSender is the backspace key, not the delete one.
2058
2059         * DumpRenderTree/gtk/EventSender.cpp:
2060         (keyDownCallback):
2061
2062 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2063
2064         Reviewed by Gustavo Noronha.
2065
2066         getChildrenWithRange expects as last parameter the end index, not
2067         the length of the range. Correct this and clarify the variable
2068         names to reflect how the code works.
2069
2070         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2071         (AccessibilityUIElement::getChildrenWithRange):
2072         (AccessibilityUIElement::getChildAtIndex):
2073
2074 2009-10-06  Mark Rowe  <mrowe@apple.com>
2075
2076         Reviewed by Simon Fraser.
2077
2078         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
2079
2080         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
2081         the fact we have already changed the working directory to the top of the open source tree.
2082
2083 2009-10-06  Julie Parent  <jparent@chromium.org>
2084
2085         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
2086         rather than my committer email.
2087
2088         * Scripts/modules/committers.py:
2089
2090 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2091
2092         Reviewed by Eric Seidel.
2093
2094         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
2095
2096         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
2097         it after each layout test as it should do, making the DRT dump additional output
2098         for all of the subsequent layout tests.
2099
2100         * DumpRenderTree/qt/jsobjects.cpp:
2101         (LayoutTestController::reset):
2102
2103 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2104
2105         Reviewed by Simon Hausmann.
2106
2107         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
2108         fast/dom/assign-to-window-status.html test, which is passing as a result.
2109
2110         https://bugs.webkit.org/show_bug.cgi?id=30127
2111
2112         * DumpRenderTree/qt/DumpRenderTree.cpp:
2113         (WebCore::DumpRenderTree::DumpRenderTree):
2114         (WebCore::DumpRenderTree::statusBarMessage):
2115         * DumpRenderTree/qt/DumpRenderTree.h:
2116         * DumpRenderTree/qt/jsobjects.h:
2117         (LayoutTestController::shouldDumpStatusCallbacks):
2118         (LayoutTestController::dumpStatusCallbacks):
2119
2120 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2121
2122         Reviewed by Simon Hausmann.
2123
2124         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
2125         ignores the argument indicating which mouse button to trigger.
2126         https://bugs.webkit.org/show_bug.cgi?id=30048
2127
2128         This affects the fast/events/mouse-click-events.html layout test.
2129
2130         * DumpRenderTree/qt/jsobjects.cpp:
2131         (EventSender::mouseDown):
2132         (EventSender::mouseUp):
2133         * DumpRenderTree/qt/jsobjects.h:
2134
2135 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2136
2137         Reviewed by Simon Hausmann.
2138
2139         [Qt] Fix the EventSender::keyDown() implementation
2140         https://bugs.webkit.org/show_bug.cgi?id=30043
2141
2142         It should post both a key press event and a key release event,
2143         just like other ports do.
2144
2145         * DumpRenderTree/qt/jsobjects.cpp:
2146         (EventSender::keyDown):
2147
2148 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
2149
2150         wx build fix. Add jpeg to the list of libs to link against.
2151
2152         * wx/build/settings.py:
2153
2154 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
2155
2156         Reviewed by Simon Hausmann.
2157
2158         [Qt] EventSender::keyDown() cannot send function-key events.
2159         https://bugs.webkit.org/show_bug.cgi?id=30044
2160
2161         This affects the fast/events/keydown-function-keys.html layout test.
2162
2163         * DumpRenderTree/qt/jsobjects.cpp:
2164         (EventSender::keyDown):
2165
2166 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
2167
2168         Added --wx-compiler-prefix waf option to allow building wxWebKit with
2169         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
2170
2171         * wx/build/settings.py:
2172         * wx/build/wxpresets.py:
2173
2174 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
2175
2176         Reviewed by Timothy Hatcher.
2177
2178         Web Inspector: add testing harness for Web Inspector.
2179
2180         https://bugs.webkit.org/show_bug.cgi?id=30010
2181
2182         * DumpRenderTree/LayoutTestController.cpp:
2183         (showWebInspectorCallback):
2184         (closeWebInspectorCallback):
2185         (evaluateInWebInspectorCallback):
2186         (LayoutTestController::staticFunctions):
2187         * DumpRenderTree/LayoutTestController.h:
2188         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2189         (LayoutTestController::showWebInspector):
2190         (LayoutTestController::closeWebInspector):
2191         (LayoutTestController::evaluateInWebInspector):
2192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2193         (LayoutTestController::showWebInspector):
2194         (LayoutTestController::closeWebInspector):
2195         (LayoutTestController::evaluateInWebInspector):
2196         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2197         (LayoutTestController::showWebInspector):
2198         (LayoutTestController::closeWebInspector):
2199         (LayoutTestController::evaluateInWebInspector):
2200         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2201         (LayoutTestController::showWebInspector):
2202         (LayoutTestController::closeWebInspector):
2203         (LayoutTestController::evaluateInWebInspector):
2204
2205 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2206
2207         Reviewed by Ariyha Hidayat.
2208
2209         Pass arguments to system() as a string instead of array
2210
2211         When passed as an array entries with a space fail to translate
2212         to two arguments to the child process, so instead of manually
2213         splitting all the entries in @buildArgs we pass the whole thing
2214         as a string instead.
2215
2216         * Scripts/webkitdirs.pm:
2217
2218 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
2219
2220         Reviewed by David Levin.
2221
2222         check-webkit-style misses whitespace errors for operators:
2223         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
2224         https://bugs.webkit.org/show_bug.cgi?id=30021
2225
2226         * Scripts/modules/cpp_style.py:
2227         Added the operators mentioned above to the same list as == and !=.
2228
2229 2009-10-02  Julie Parent  <jparent@chromium.org>
2230
2231         Unreviewed.
2232
2233         Adding myself and Ojan Vafai as committers, because we are committers.
2234
2235         * Scripts/modules/committers.py:
2236
2237 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
2238
2239         Reviewed by Adam Roben.
2240
2241         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
2242         this will help the patch merging process when TryBots are used.
2243
2244         * Scripts/svn-create-patch:
2245
2246 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
2247
2248         Reviewed by Simon Hausmann.
2249
2250         [Qt] Implement layoutTestController.overridePreference().
2251         https://bugs.webkit.org/show_bug.cgi?id=29970
2252
2253         * DumpRenderTree/qt/DumpRenderTree.cpp:
2254         (WebCore::WebPage::WebPage):
2255         (WebCore::WebPage::resetSettings):
2256         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2257         * DumpRenderTree/qt/jsobjects.cpp:
2258         (LayoutTestController::reset):
2259         (LayoutTestController::setPrivateBrowsingEnabled):
2260         (LayoutTestController::setPopupBlockingEnabled):
2261         (LayoutTestController::overridePreference):
2262         * DumpRenderTree/qt/jsobjects.h:
2263
2264 2009-10-01  Chris Marrin  <cmarrin@apple.com>
2265
2266         Reviewed by Oliver Hunt.
2267
2268         Turn on ENABLE_3D_CANVAS in TOT
2269         https://bugs.webkit.org/show_bug.cgi?id=29906
2270
2271         * Scripts/build-webkit:
2272
2273 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2274
2275         Rubberstamped by Simon Hausmann.
2276
2277         Enable HTTP tests for Qt
2278
2279         * Scripts/run-webkit-tests:
2280
2281 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
2282
2283         Reviewed by Dimitri Glazkov.
2284
2285         build-webkit --chromium now also works on cygwin.
2286
2287         https://bugs.webkit.org/show_bug.cgi?id=29973
2288
2289         * Scripts/webkitdirs.pm:
2290
2291 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
2292
2293         Reviewed by Simon Hausmann.
2294
2295         [Qt] Don't use TCmalloc in DumpRenderTree
2296         https://bugs.webkit.org/show_bug.cgi?id=27029
2297
2298         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
2299
2300         * DumpRenderTree/qt/DumpRenderTree.pro:
2301
2302 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
2303
2304         Reviewed by Simon Hausmann.
2305
2306         [Qt] Implement eventSender.scheduleAsynchronousClick().
2307
2308         https://bugs.webkit.org/show_bug.cgi?id=29931
2309
2310         * DumpRenderTree/qt/jsobjects.cpp:
2311         (EventSender::scheduleAsynchronousClick):
2312         * DumpRenderTree/qt/jsobjects.h:
2313
2314 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
2315
2316         Reviewed by Simon Hausmann.
2317
2318         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
2319         fast/events/open-window-from-another-frame.html from the Skipped list.
2320
2321         https://bugs.webkit.org/show_bug.cgi?id=29930
2322
2323         * DumpRenderTree/qt/jsobjects.cpp:
2324         (LayoutTestController::setPopupBlockingEnabled):
2325         * DumpRenderTree/qt/jsobjects.h:
2326
2327 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
2328
2329         Unreviewed.
2330
2331         Added myself to the list of committers.
2332
2333         * Scripts/modules/committers.py:
2334
2335 2009-09-30  Eric Seidel  <eric@webkit.org>
2336
2337         No review, just adding Geoff to the list of reviewers.
2338
2339         * Scripts/modules/committers.py:
2340
2341 2009-09-30  Dan Bernstein  <mitz@apple.com>
2342
2343         Reviewed by Sam Weinig.
2344
2345         Added the WebKit Layout Tests fonts that are referenced in
2346         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
2347
2348         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
2349         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
2350
2351 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2352
2353         Reviewed by David Kilzer.
2354
2355         Make sunspider scripts work on Windows platform.
2356         https://bugs.webkit.org/show_bug.cgi?id=29656
2357
2358         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
2359         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
2360         * Scripts/webkitdirs.pm: currentPerlPath() added.
2361
2362 2009-09-29  Brady Eidson  <beidson@apple.com>
2363
2364         Rubberstamped by Dan Bernstein.
2365
2366         Fix license and some sorting in new files.
2367
2368         * DumpRenderTree/mac/HistoryDelegate.h:
2369         * DumpRenderTree/mac/HistoryDelegate.mm:
2370
2371 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
2372
2373         Reviewed by David Kilzer.
2374
2375         Fixed how error codes are handled.
2376         https://bugs.webkit.org/show_bug.cgi?id=29898
2377
2378         * Scripts/update-webkit:
2379         * Scripts/update-webkit-chromium:
2380
2381 2009-09-29  Brady Eidson  <beidson@apple.com>
2382
2383         Reviewed by John Sullivan.
2384
2385         Updated way-out-of-date sorting throughout the dump methods/flags.
2386
2387         * DumpRenderTree/LayoutTestController.cpp:
2388         (LayoutTestController::LayoutTestController):
2389         (dumpAsPDFCallback):
2390         (dumpAsTextCallback):
2391         (dumpFrameLoadCallbacksCallback):
2392         (dumpResourceLoadCallbacksCallback):
2393         (LayoutTestController::staticFunctions):
2394
2395         * DumpRenderTree/LayoutTestController.h:
2396         (LayoutTestController::dumpAsText):
2397         (LayoutTestController::setDumpAsText):
2398         (LayoutTestController::dumpFrameLoadCallbacks):
2399         (LayoutTestController::setDumpFrameLoadCallbacks):
2400         (LayoutTestController::dumpSelectionRect):
2401         (LayoutTestController::setDumpSelectionRect):
2402         (LayoutTestController::dumpSourceAsWebArchive):
2403         (LayoutTestController::setDumpSourceAsWebArchive):
2404         (LayoutTestController::dumpStatusCallbacks):
2405         (LayoutTestController::setDumpStatusCallbacks):
2406         (LayoutTestController::dumpTitleChanges):
2407         (LayoutTestController::setDumpTitleChanges):
2408         (LayoutTestController::dumpWillCacheResponse):
2409         (LayoutTestController::setDumpWillCacheResponse):
2410
2411 2009-09-29  Brady Eidson  <beidson@apple.com>
2412
2413         Reviewed by John Sullivan.
2414
2415         WebKit Mac API should provide a delegate interface for global history.
2416         <rdar://problem/7042773> and https://webkit.org/b/29904
2417
2418         Adding the dumping of global history delegate callbacks.
2419
2420         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2421
2422         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
2423         * DumpRenderTree/mac/DumpRenderTree.mm:
2424         (createWebViewAndOffscreenWindow):
2425         (allocateGlobalControllers):
2426         (shouldLogFrameLoadDelegates):
2427         (shouldLogHistoryDelegates):
2428         (runTest):
2429
2430         Dump history delegate callbacks:
2431         * DumpRenderTree/mac/HistoryDelegate.h: Added.
2432         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
2433         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
2434         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
2435         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
2436
2437 2009-09-29  Daniel Bates  <dbates@webkit.org>
2438
2439         Reviewed by Adam Roben.
2440
2441         https://bugs.webkit.org/show_bug.cgi?id=28902
2442         
2443         Fixes an issue where the drop effect returned by Window Dump Render Tree 
2444         was always DROPEFFECT_NONE (since it was hard coded to do so).
2445         
2446         This patch corrects this issue by determining the actual drop effect 
2447         performed by the corresponding drag-and-drop operation so that we can 
2448         return it.
2449
2450         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
2451         (DraggingInfo::DraggingInfo):
2452         (DraggingInfo::performedDropEffect): Added method.
2453         (DraggingInfo::setPerformedDropEffect): Added method.
2454         * DumpRenderTree/win/EventSender.cpp:
2455         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
2456         Moved delete draggingInfo to UIDelegate::doDragDrop.
2457         * DumpRenderTree/win/UIDelegate.cpp:
2458         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
2459
2460 2009-09-29  Dan Bernstein  <mitz@apple.com>
2461
2462         Reviewed by Adam Roben.
2463
2464         Remove copying of unnecessary or nonexistent files from the ImageDiff
2465         post-build event.
2466
2467         * DumpRenderTree/win/ImageDiff.vcproj:
2468
2469 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2470
2471         Reviewed by David Kilzer.
2472
2473         [Qt] Make build-webkit script work on Windows
2474         https://bugs.webkit.org/show_bug.cgi?id=29802
2475
2476         * Scripts/run-webkit-tests:
2477         * Scripts/webkitdirs.pm:
2478          - Removed unnecessary -p switch for mkdir on Windows.
2479          - Use canonical path, which uses slashes or backslashes depends on platform.
2480          - isWindows() only test for Windows and not for Cyqwin.
2481
2482 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2483
2484         Reviewed by Simon Hausmann.
2485
2486         Fix time measurement in build-webkit after refactoring done in r48853.
2487
2488         * Scripts/build-webkit:
2489
2490 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2491
2492         Reviewed by Tor Arne Vestbø.
2493
2494         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
2495         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
2496
2497         * DumpRenderTree/qt/DumpRenderTree.cpp:
2498         (WebCore::WebPage::WebPage):
2499
2500 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
2501
2502         Reviewed by Simon Hausmann.
2503
2504         [Qt] Implement eventSender.contextClick().
2505         https://bugs.webkit.org/show_bug.cgi?id=29821
2506
2507         * DumpRenderTree/qt/jsobjects.cpp:
2508         (EventSender::contextClick):
2509         * DumpRenderTree/qt/jsobjects.h:
2510
2511 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
2512
2513         Reviewed by Eric Seidel.
2514
2515         Add experimentalWebSocketsEnabled in WebPreferences.
2516         https://bugs.webkit.org/show_bug.cgi?id=28941
2517
2518         * DumpRenderTree/mac/DumpRenderTree.mm:
2519         (resetDefaultsToConsistentValues):
2520         * DumpRenderTree/win/DumpRenderTree.cpp:
2521         (resetDefaultsToConsistentValues):
2522
2523 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
2524
2525         Reviewed by David Kilzer.
2526
2527         Integrated chromium port building into webkit tools update-webkit and
2528         build-webkit.
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=29749
2531
2532         * Scripts/build-webkit: When --chromium is specified, will build
2533           the chromium port (currently only Mac is supported).
2534         * Scripts/update-webkit: When --chromium is specified, delegates to
2535           update-webkit-chromium.
2536         * Scripts/webkitdirs.pm: Added chromium specific defs.
2537         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
2538           chromium port's dependencies and update its project files.
2539
2540 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
2541
2542         Unreviewed.
2543
2544         Add myself to list of committers.
2545
2546         * Scripts/modules/committers.py:
2547
2548 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
2549
2550         Reviewed by Darin Adler.
2551
2552         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
2553         https://bugs.webkit.org/show_bug.cgi?id=29771
2554
2555         * Scripts/run-webkit-tests:
2556
2557 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
2558
2559         Reviewed by Simon Hausmann.
2560
2561         [Qt] Implement layoutTestController.waitForPolicyDelegate.
2562         https://bugs.webkit.org/show_bug.cgi?id=25037
2563
2564         * DumpRenderTree/qt/DumpRenderTree.cpp:
2565         (WebCore::WebPage::acceptNavigationRequest):
2566         * DumpRenderTree/qt/DumpRenderTree.pro:
2567         * DumpRenderTree/qt/jsobjects.cpp:
2568         (LayoutTestController::reset):
2569         (LayoutTestController::notifyDone):
2570         (LayoutTestController::waitForPolicyDelegate):
2571         * DumpRenderTree/qt/jsobjects.h:
2572         (LayoutTestController::waitForPolicy):
2573
2574 2009-09-26  David Kilzer  <ddkilzer@apple.com>
2575
2576         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
2577
2578         Reviewed by Eric Seidel.
2579
2580         The -o|--open switch uses the open(1) command on Mac OS X to
2581         open the bug URL in the default web browser.  If there are
2582         similar mechanisms on other platforms, they may be added later.
2583
2584         * Scripts/mark-bug-fixed:
2585         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
2586         options.
2587         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
2588         code into main() and extracted prompting code into
2589         _prompt_user_for_correctness().
2590         (MarkBugFixed._open_bug_in_web_browser): Added.
2591         (MarkBugFixed._prompt_user_for_correctness): Added.
2592         (MarkBugFixed.main): Added logging code from
2593         _determine_bug_id_and_svn_revision().  Added code to call
2594         _open_bug_in_web_browser() if the switch is set.  Added code to
2595         call _prompt_user_for_correctness() when needed.
2596         * Scripts/modules/bugzilla.py:
2597         (Bugzilla.short_bug_url_for_bug_id): Added.
2598
2599 2009-09-26  David Kilzer  <ddkilzer@apple.com>
2600
2601         svn-unapply and svn-apply don't work when used outside multiple svn working directories
2602
2603         <http://webkit.org/b/29744>
2604         <rdar://problem/7252905>
2605
2606         Reviewed by Eric Seidel.
2607
2608         Some users have a workflow where svn-create-patch, svn-apply and
2609         svn-unapply are used outside of multiple svn working
2610         directories.  Instead of aborting the scripts in these cases,
2611         print a warning and assume that Subversion is being used.
2612
2613         * Scripts/VCSUtils.pm:
2614         (determineVCSRoot): Call warn() instead of die() if both isGit()
2615         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
2616         to enforce the assumption about Subversion, then return
2617         determineSVNRoot().
2618         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
2619         VCSUtils.pm.  They both already cache their values and checking
2620         here is redundant since determineVCSRoot() is called later.
2621
2622 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
2623
2624         Reviewed by Gustavo Noronha.
2625
2626         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2627         https://bugs.webkit.org/show_bug.cgi?id=29689
2628
2629         Load test fonts through FontConfig before each test.
2630         This ensures a more proper rendering of the tests.
2631
2632         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2633         (initializeFonts):
2634         (runTest):
2635         (main):
2636         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
2637         * GNUmakefile.am:
2638
2639 2009-09-25  David Kilzer  <ddkilzer@apple.com>
2640
2641         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
2642
2643         Reviewed by Eric Seidel.
2644
2645         * Scripts/mark-bug-fixed:
2646         (MarkBugFixed.__init__): Added -u|--update-only switch to list
2647         of parse options.
2648         (MarkBugFixed.main): When -u|--update-only is specified, add a
2649         comment to the bug without marking it Resolved/Fixed.
2650
2651 2009-09-25  Darin Adler  <darin@apple.com>
2652
2653         Reviewed by Geoffrey Garen.
2654
2655         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
2656         out, just as we do for the resources directory.
2657
2658 2009-09-25  Adam Barth  <abarth@webkit.org>
2659
2660         Unreviewed.  Added Tony to committers.py because he's a
2661         committer now.
2662
2663         * Scripts/modules/committers.py:
2664
2665 2009-09-25  Eric Seidel  <eric@webkit.org>
2666
2667         Reviewed by Simon Fraser.
2668
2669         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
2670         https://bugs.webkit.org/show_bug.cgi?id=28624
2671
2672         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
2673
2674         * DumpRenderTree/mac/DumpRenderTree.mm:
2675         (resetDefaultsToConsistentValues):
2676
2677 2009-09-25  Eric Seidel  <eric@webkit.org>
2678
2679         Reviewed by Adam Barth.
2680
2681         commit-queue should auto-retry patches which fail to commit due to out of date files
2682         https://bugs.webkit.org/show_bug.cgi?id=28316
2683
2684         * Scripts/bugzilla-tool:
2685          - Handle new CheckoutNeedsUpdate exception.
2686         * Scripts/modules/logging_unittest.py:
2687          - Call the ScriptError constructor correctly (this test had regressed).
2688         * Scripts/modules/scm.py:
2689          - Added the ability to define custom error handlers for run_command
2690            and added a commit_error_handler which throws CheckoutNeedsUpdate
2691            instead of ScriptError.
2692          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
2693         * Scripts/modules/scm_unittest.py:
2694          - Added tests of new error handlers.
2695
2696 2009-09-25  Eric Seidel  <eric@webkit.org>
2697
2698         Reviewed by Adam Barth.
2699
2700         commit-queue should give better feedback when failing a patch
2701         https://bugs.webkit.org/show_bug.cgi?id=29316
2702
2703         * Scripts/bugzilla-tool:
2704          - Update ScriptError uses to the new constructor format.
2705          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
2706            so that we can print to both stdout as well as an output buffer for error reporting.
2707          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
2708          - Use e.message_with_output() when failing a patch (this is the real fix here).
2709            I also removed use of "This patch will require manual commit." as that's not always true.
2710          - Add missing word "bug" from log message.
2711         * Scripts/modules/scm.py:
2712          - Make ScriptError save a bunch more data so that error messages can be nicer.
2713          - Update ScriptError callers.
2714
2715 2009-09-24  John Gregg  <johnnyg@google.com>
2716
2717         Reviewed by Eric Seidel.
2718
2719         Enable switch for notifications (experimental) in Page Settings
2720         https://bugs.webkit.org/show_bug.cgi?id=28930
2721
2722         Now that desktop notifications are controlled by run-time switch,
2723         set that switch to true for DumpRenderTree.
2724
2725         * DumpRenderTree/mac/DumpRenderTree.mm:
2726         (resetDefaultsToConsistentValues):
2727         * DumpRenderTree/win/DumpRenderTree.cpp:
2728         (resetDefaultsToConsistentValues):
2729         * DumpRenderTree/win/UIDelegate.cpp:
2730         (UIDelegate::QueryInterface):
2731
2732 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
2733
2734         wx build fix. SnowLeopard fixes for Mac dependencies.
2735
2736         * wx/build/build_utils.py:
2737         * wx/build/settings.py:
2738         * wx/install-unix-extras:
2739
2740 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2741
2742         Reviewed by Oliver Hunt.
2743
2744         Add support for DRT to send mouse wheel events.
2745
2746         https://bugs.webkit.org/show_bug.cgi?id=29348
2747         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
2748
2749         * DumpRenderTree/gtk/EventSender.cpp:
2750         (mouseWheelToCallback):
2751
2752 2009-09-17  Eric Seidel  <eric@webkit.org>
2753
2754         Reviewed by David Levin.
2755
2756         commit-queue needs web-based status reporting
2757         https://bugs.webkit.org/show_bug.cgi?id=29307
2758
2759         Add a first-pass web-based status for the commit-queue.
2760         The bot is currently reachable at:
2761         http://webkit-commit-queue.appspot.com/
2762
2763         * CommitQueueStatus/app.yaml: Added.
2764          - Application description file required by App Engine.
2765         * CommitQueueStatus/filters/__init__.py: Added.
2766          - Required by python to treat 'filters' as a module.
2767         * CommitQueueStatus/filters/webkit_extras.py: Added.
2768          - Support for turning 'bug 123' and 'patch 123' into links.
2769            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
2770         * CommitQueueStatus/index.html: Added.
2771         * CommitQueueStatus/index.yaml: Added.
2772          - Some auto-generated file from app engine.
2773         * CommitQueueStatus/queue_status.py: Added.
2774          - The core logic of this bot.  We could eventually split this file out into pieces.
2775         * CommitQueueStatus/stylesheets/main.css: Added.
2776          - Some basic lame-o CSS to make the page look less awful.
2777         * CommitQueueStatus/update_status.html: Added.
2778          - The form that the commit-queue (or a human) can use to update the status.
2779         * Scripts/bugzilla-tool:
2780          - Add some very basic update_status calls.
2781         * Scripts/modules/statusbot.py: Added.
2782          - Knows how to post to the CommitQueueStatus web application.
2783
2784 2009-09-24  David Kilzer  <ddkilzer@apple.com>
2785
2786         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
2787
2788         Reviewed by Adam Roben.
2789
2790         * Scripts/mark-bug-fixed:
2791         (MarkBugFixed.__init__): Added -m|--comment switch to list of
2792         parse options.
2793         (MarkBugFixed.main): When specified, prepend comment from
2794         -m|--comment command-line switch to the bug comment.
2795
2796 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2797
2798         Reviewed by Jan Alonzo.
2799
2800         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
2801         https://bugs.webkit.org/show_bug.cgi?id=29693
2802
2803         Show the window, to be able to synthesize events correctly.
2804
2805         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2806         (runTest):
2807         (main):
2808
2809 2009-09-24  Oliver Hunt  <oliver@apple.com>
2810
2811         Reviewed by NOBODY(rollout)
2812
2813         Roll out r48712 as it is incorrect.
2814
2815         * DumpRenderTree/mac/ObjCController.m:
2816         (+[ObjCController isSelectorExcludedFromWebScript:]):
2817         (+[ObjCController webScriptNameForSelector:]):
2818
2819 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
2820
2821         Reviewed by Eric Seidel.
2822
2823         https://bugs.webkit.org/show_bug.cgi?id=29005
2824         The indices of RuntimeArray should be enumerated like for a regular array.
2825
2826         * DumpRenderTree/mac/ObjCController.m:
2827         (+[ObjCController isSelectorExcludedFromWebScript:]):
2828         (+[ObjCController webScriptNameForSelector:]):
2829         (-[ObjCController arrayOfString]):
2830
2831 2009-09-23  David Kilzer  <ddkilzer@apple.com>
2832
2833         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
2834
2835         Reviewed by Darin Adler.
2836
2837         Also fixed a bug where specifying a revision on the command-line
2838         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
2839
2840         * Scripts/bugzilla-tool: Updated module import statements.
2841         (parse_bug_id): Removed.  Moved to bugzilla.py.
2842         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
2843         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
2844         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
2845         (BugzillaTool.__init__): Removed mark-fixed subcommand.
2846         * Scripts/mark-bug-fixed: Added.
2847         * Scripts/modules/bugzilla.py:
2848         (parse_bug_id): Added.  Moved from bugzilla-tool.
2849         * Scripts/modules/comments.py: Added.
2850         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
2851         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
2852
2853 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
2854
2855         Reviewed by Eric Seidel.
2856         
2857          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
2858          "false" in non-implemented stub for setAlwaysAcceptCookies.
2859          https://bugs.webkit.org/show_bug.cgi?id=29661
2860
2861         * DumpRenderTree/win/DumpRenderTree.vcproj:
2862         * DumpRenderTree/win/DumpRenderTree.cpp:
2863
2864 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2865
2866         Reviewed by Xan Lopez.
2867
2868         [GTK] need to dump number of pending unload handlers
2869         https://bugs.webkit.org/show_bug.cgi?id=29685
2870
2871         Implement dumping of the number of pending unload handlers.
2872
2873         The following tests will pass:
2874
2875           fast/loader/unload-form-about-blank.html
2876           fast/loader/unload-form-post-about-blank.html
2877           fast/loader/unload-form-post.html
2878           fast/loader/unload-form.html
2879           fast/loader/unload-hyperlink.html
2880           fast/loader/unload-javascript-url.html
2881           fast/loader/unload-reload.html
2882           fast/loader/unload-window-location.html
2883
2884         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2885         (getFrameNameSuitableForTestResult):
2886         (webViewLoadFinished):
2887
2888 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
2889
2890         Reviewed by Eric Seidel.
2891
2892         js tests should move into jstests subdirectory instead of resources/
2893         https://bugs.webkit.org/show_bug.cgi?id=25880
2894
2895         Remove support of resources directory.
2896
2897         * Scripts/make-script-test-wrappers:
2898
2899 2009-09-22  Eric Seidel  <eric@webkit.org>
2900
2901         No review, only fixing typo (missing space character).
2902
2903         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
2904
2905         * Scripts/run-webkit-tests:
2906
2907 2009-09-22  Eric Seidel  <eric@webkit.org>
2908
2909         Reviewed by Darin Adler.
2910
2911         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
2912         https://bugs.webkit.org/show_bug.cgi?id=29220
2913
2914         * Scripts/run-webkit-tests:
2915
2916 2009-09-22  Eric Seidel  <eric@webkit.org>
2917
2918         Reviewed by David Kilzer.
2919
2920         svn-apply can't handle single-line binary file additions
2921         https://bugs.webkit.org/show_bug.cgi?id=29100
2922
2923         Fixed the regexp and added a unit test.
2924
2925         * Scripts/modules/scm_unittest.py:
2926         * Scripts/svn-apply:
2927
2928 2009-09-11  Eric Seidel  <eric@webkit.org>
2929
2930         Reviewed by David Kilzer.
2931
2932         post-diff and post-commits should be able to find bug urls in ChangeLogs.
2933         https://bugs.webkit.org/show_bug.cgi?id=29206
2934
2935         * Scripts/bugzilla-tool:
2936          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
2937          - Rename --no-comment to --add-log-as-comment and reverse behavior.
2938            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
2939          - Split out code into helper functions to try and make execute() more legible.
2940          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
2941          - Fallback to bug urls in commit diffs, instead of just in commit messages,
2942            meaning post-commits will now find bug urls in ChangeLogs.
2943
2944 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2945
2946         Reviewed by Maciej Stachowiak.
2947
2948         --parse-only parameter wasn't passed to SunSpider/sunspider script.
2949         https://bugs.webkit.org/show_bug.cgi?id=29611
2950
2951         * Scripts/run-sunspider: Missing parameter passing added.
2952
2953 2009-09-20  David Kilzer  <ddkilzer@apple.com>
2954
2955         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
2956
2957         Reviewed by Mark Rowe.
2958
2959         The require statement is like the use statement, except that it
2960         is run during script execution instead of during the 'BEGIN'
2961         phase.  This makes it possible to change @INC before the require
2962         statement is run.  See 'require' and 'use' in the perlfunc(1)
2963         manpage and 'BEGIN' in perlmod(1) manpage.
2964
2965         * Scripts/run-webkit-tests: Replace eval statement with require
2966         statement.
2967
2968 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
2969
2970         wx build fixes. Fix the config name under git and allow users to specify
2971         their own waf install for experimenting with new versions.
2972
2973         * Scripts/webkitdirs.pm:
2974         * wx/build/settings.py:
2975
2976 2009-09-18  Alex Milowski  <alex@milowski.com>
2977
2978         Reviewed by Maciej Stachowiak.
2979
2980         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
2981         checking for whether MathML tests should be run
2982
2983         * Scripts/run-webkit-tests:
2984         * Scripts/webkitdirs.pm:
2985
2986 2009-08-28  Darin Adler  <darin@apple.com>
2987
2988         Reviewed by Mark Rowe.
2989
2990         Break more of run-webkit-tests into separate functions
2991         https://bugs.webkit.org/show_bug.cgi?id=29497
2992
2993         Some small steps toward improving run-webkit-tests. My goal is to
2994         refactor much more of the script into functions. Later we can add
2995         parallel test running to the tool. But better structure may help
2996         even if someone decides to translate this into another scripting
2997         language instead.
2998
2999         * Scripts/run-webkit-tests: Break more pieces of the script into
3000         seprate functions. Added readSkippedFiles, findTestsToRun, and
3001         printResults functions. Removed custom code to skip results.html
3002         and instead just put it into the ignoredFiles hash. Fixed some
3003         indentation. Sorted function declarations, global variables,
3004         and options at the top of the file alphabetically so they're not
3005         in a semi-random order.
3006
3007 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
3008
3009         wx build fix, add missing dependency.
3010
3011         * wx/browser/wscript:
3012
3013 2009-09-16  Mark Rowe  <mrowe@apple.com>
3014
3015         Split the SnowLeopard build across a few machines.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/config.json:
3018
3019 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
3020
3021         wx build fix to support monolithic builds on Windows.
3022
3023         * wx/build/wxpresets.py:
3024
3025 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
3026
3027         wx build fix, improve debug support and 2.9 support on MSW.
3028
3029         * wx/build/settings.py:
3030         * wx/build/wxpresets.py:
3031
3032 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3033
3034         Blind try at fixing new test failure on Windows.
3035
3036         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3037         (FrameLoadDelegate::didReceiveTitle):
3038
3039 2009-09-15  Alex Milowski  <alex@milowski.com>
3040
3041         Reviewed by Tor Arne Vestbø.
3042
3043         Added mathml toggle
3044
3045         * Scripts/build-webkit:
3046
3047 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
3048
3049         wx build fix. Allow waf build to support Python < 2.6.
3050
3051         * wx/build/waf_extensions.py:
3052
3053 2009-09-14  Chris Marrin  <cmarrin@apple.com>
3054
3055         Reviewed by Oliver Hunt.
3056
3057         Add LayoutTests infrastructure to enable and disable webgl tests.
3058         https://bugs.webkit.org/show_bug.cgi?id=29254
3059
3060         * Scripts/run-webkit-tests:
3061         * Scripts/webkitdirs.pm:
3062
3063 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
3064
3065         Reviewed by Darin Adler.
3066         
3067         Add --iterations option to run-webkit-tests to repeat the tests N times
3068         https://bugs.webkit.org/show_bug.cgi?id=29263
3069
3070         When run with --iterations N, run-webkit-tests will repeat the tests N times.
3071
3072         * Scripts/run-webkit-tests:
3073
3074 2009-09-14  Brady Eidson  <beidson@apple.com>
3075
3076         Not reviewed, maybe should've been:
3077
3078         Cleaning up more Windows-specific fallout from the fix for:
3079         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
3080
3081         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3082         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
3083           and call the correct method to get the Sender.
3084
3085 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
3086
3087         GTK build fix.
3088
3089         Unreviewed.
3090
3091         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3092         (AccessibilityController::setLogScrollingStartEvents):
3093
3094 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
3095
3096         DRT/test part of
3097         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
3098         jumping to a named anchor
3099
3100         https://bugs.webkit.org/show_bug.cgi?id=28899
3101
3102         Reviewed by Adam Roben.
3103
3104         * DumpRenderTree/AccessibilityController.cpp:
3105         (logScrollingStartEventsCallback):
3106         Turn on logging of scrolling start events.
3107         (AccessibilityController::getJSClass):
3108         Add a "logScrollingStartEvents" to the AccessibilityController's JS
3109         class definition.
3110         (AccessibilityController::resetToConsistentState):
3111         Turn off logging of scrolling start events.
3112
3113         * DumpRenderTree/AccessibilityController.h:
3114         Declare setLogScrollingStartEvents(). Add a member for the scrolling
3115         start event hook.
3116
3117         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
3118         (AccessibilityController::setLogScrollingStartEvents):
3119         Stubbed.
3120
3121         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3122         (AccessibilityController::AccessibilityController):
3123         Initialize the handle to 0.
3124         (logEventProc):
3125         Renamed from logFocusEventProc; now logs scrolling start events, too.
3126         Removed the assertion that the event is a focus event. Added a switch
3127         to print a message for focus, scrolling start, and other, unknown
3128         events.
3129         (AccessibilityController::setLogFocusEvents):
3130         Changed to use logEventProc.
3131         (AccessibilityController::setLogScrollingStartEvents):
3132         If turning logging off, unhook the scrolling start event hook, and clear
3133         the member holding the handle. If turning on, query for the root
3134         accessible, so that accessibility is enabled for the WebView, and call
3135         SetWinEventHook to setup an event hook using logEventProc as the
3136         callback function.
3137
3138 2009-09-14  Brady Eidson  <beidson@apple.com>
3139
3140         Windows build fix.
3141
3142         * DumpRenderTree/LayoutTestController.cpp:
3143         (setAuthenticationPasswordCallback):
3144         (setAuthenticationUsernameCallback):
3145         
3146         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3147         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3148
3149 2009-09-14  Brady Eidson  <beidson@apple.com>
3150
3151         Reviewed by Alexey Proskuryakov.
3152
3153         Safari 4 cannot be used to update firmware on Linksys routers.
3154         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
3155
3156         Add the ability for DRT to handle authentication challenges.
3157
3158         * DumpRenderTree/LayoutTestController.cpp:
3159         (setAuthenticationPasswordCallback):
3160         (setAuthenticationUsernameCallback):
3161         (setHandlesAuthenticationChallengesCallback):
3162         (LayoutTestController::staticFunctions):
3163
3164         * DumpRenderTree/LayoutTestController.h:
3165         (LayoutTestController::handlesAuthenticationChallenges):
3166         (LayoutTestController::setHandlesAuthenticationChallenges):
3167         (LayoutTestController::authenticationUsername):
3168         (LayoutTestController::setAuthenticationUsername):
3169         (LayoutTestController::authenticationPassword):
3170         (LayoutTestController::setAuthenticationPassword):
3171
3172         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3173         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3174
3175         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3176         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3177         * DumpRenderTree/win/ResourceLoadDelegate.h:
3178
3179 2009-09-12  Mark Rowe  <mrowe@apple.com>
3180
3181         Reviewed by Dan Bernstein.
3182
3183         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
3184
3185         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
3186         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
3187
3188         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3189         (NPP_New):
3190
3191 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3192
3193         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
3194
3195         * wx/build/build_utils.py:
3196         * wx/build/settings.py:
3197
3198 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3199
3200         Reviewed by Tor Arne Vestbø.
3201
3202         [Qt] Build fix for windows build.
3203
3204         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
3205
3206 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
3207
3208         Fix typo accidently landed in last commit.
3209
3210         * wx/build/settings.py:
3211
3212 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
3213
3214         wx build fix, error out if using the wrong Python.
3215
3216         * wx/build/settings.py:
3217
3218 2009-09-13  Xan Lopez  <xlopez@igalia.com>
3219
3220         Build fix for GTK+ < 2.14.
3221
3222         Do not use gtk_widget_get_window, access the window directly
3223         through the struct.
3224
3225         * DumpRenderTree/gtk/EventSender.cpp:
3226         (contextClickCallback):
3227         (mouseDownCallback):
3228         (mouseUpCallback):
3229         (mouseMoveToCallback):
3230         (keyDownCallback):
3231
3232 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
3233
3234         Reviewed by Xan Lopez and Jan Alonzo.
3235
3236         [GTK] EventSender does not set 'window' property on synthesized GDK events
3237         https://bugs.webkit.org/show_bug.cgi?id=29169
3238
3239         Set the window property on synthesized GDK events in the GTK+ EventSender.
3240
3241         * DumpRenderTree/gtk/EventSender.cpp:
3242         (contextClickCallback):
3243         (mouseDownCallback):
3244         (mouseUpCallback):
3245         (mouseMoveToCallback):
3246         (keyDownCallback):
3247
3248 2009-09-12  Drew Wilson  <atwilson@google.com>
3249
3250         Reviewed by Mark Rowe.
3251
3252         run-webkit-tests has a timeout value that is too low
3253         https://bugs.webkit.org/show_bug.cgi?id=29223
3254
3255         * Scripts/run-webkit-tests:
3256         Changed timeout value to 20 seconds to avoid timing out too early.
3257
3258 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
3259
3260         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
3261         architectures are supported for building wxWebKit.
3262
3263         * wx/build/settings.py:
3264
3265 2009-09-11  Eric Seidel  <eric@webkit.org>
3266
3267         Reviewed by David Levin.
3268
3269         bugzilla-tool rollout threw exception under svn
3270         https://bugs.webkit.org/show_bug.cgi?id=29211
3271
3272         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
3273         * Scripts/modules/scm_unittest.py: add testing for this fix.
3274
3275 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
3276
3277         Add myself to the committers list.
3278
3279         * Scripts/modules/committers.py:
3280
3281 2009-09-11  Eric Seidel  <eric@webkit.org>
3282
3283         Reviewed by Adam Barth.
3284
3285         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
3286         https://bugs.webkit.org/show_bug.cgi?id=29201
3287
3288         * Scripts/bugzilla-tool:
3289
3290 2009-09-11  Adam Roben  <aroben@apple.com>
3291
3292         Make commit-log-editor move common prefixes to the top of the log
3293
3294         Fies <http://webkit.org/b/29190> commit-log-editor should move common
3295         prefixes to the top of the commit log
3296
3297         Reviewed by Darin Adler.
3298
3299         * Scripts/commit-log-editor: Find and remove the longest common prefix
3300         ending in a double newline from each ChangeLog entry, then put that
3301         common prefix at the top of the commit log.
3302         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
3303         removes, and returns the longest common prefix ending in a double
3304         newline from a hash of strings
3305
3306 2009-09-11  Eric Seidel  <eric@webkit.org>
3307
3308         Fix obvious typo in previous commit, no review.
3309
3310         bugzilla-tool should automate rollouts
3311         https://bugs.webkit.org/show_bug.cgi?id=26715
3312
3313         * Scripts/bugzilla-tool: add back missing "scm" argument.
3314
3315 2009-09-11  Eric Seidel  <eric@webkit.org>
3316
3317         Reviewed by Adam Barth.
3318
3319         bugzilla-tool should automate rollouts
3320         https://bugs.webkit.org/show_bug.cgi?id=26715
3321
3322         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
3323         The --complete-rollout option will automatically land and update the bug.
3324         Eventually --complete-rollout will be default, but that will require more testing.
3325
3326         This first pass is good enough for others to try and file bugs about.
3327
3328         * Scripts/bugzilla-tool:
3329          - Move modified_changelogs into scm.py.
3330          - Move svn_revision_from_commit_text logic into scm.py.
3331          - Add RolloutCommit command.
3332         * Scripts/modules/bugzilla.py:
3333          - Add reopen_bug command used by RolloutCommit.
3334         * Scripts/modules/scm.py:
3335          - Add functions to support RolloutCommit.
3336          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
3337          - Add a str() call so that svn_commit_log can take a numeric argument.
3338          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
3339          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
3340         * Scripts/modules/scm_unittest.py:
3341          - Add read_from_path for easy file reading.
3342          - Put test4 on a new line to make reverts work w/o conflict.
3343          - Add an "svn update" call so that the checkout revision matches the server revision.
3344          - Add tests for svn_revision_from_commit_text.
3345          - Add a simple test for apply_reverse_diff.
3346          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
3347          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
3348
3349 2009-09-11  Adam Roben  <aroben@apple.com>
3350
3351         Get user script/stylesheet tests running on Windows
3352
3353         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
3354         skipped on Windows
3355
3356         Reviewed by John Sullivan.
3357
3358         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
3359         against comsuppw.lib so we can use _bstr_t.
3360
3361         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
3362         order, added #include of comutil.h for _bstr_t.
3363
3364         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
3365         (LayoutTestController::addUserScript):
3366         (LayoutTestController::addUserStyleSheet):
3367         Implemented. Implementations were based on those in
3368         LayoutTestControllerMac.mm.
3369
3370 2009-09-10  David Kilzer  <ddkilzer@apple.com>
3371
3372         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
3373
3374         Reviewed by Mark Rowe.
3375
3376         * Scripts/run-webkit-tests: Updated to make -h switch show help.
3377
3378 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
3379
3380         Reviewed by Alexey Proskuryakov.
3381
3382         Add WebCore/websockets directory in wx build system.
3383         https://bugs.webkit.org/show_bug.cgi?id=28038
3384
3385         * wx/build/settings.py:
3386
3387 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
3388
3389         [GTK] EventSender does not properly convert some keyDown strings
3390         https://bugs.webkit.org/show_bug.cgi?id=29119
3391
3392         Add more keyDown string to character code conversions for GTK+ EventSender.
3393
3394         * DumpRenderTree/gtk/EventSender.cpp:
3395         (keyDownCallback):
3396
3397 2009-09-09  Steve Block  <steveblock@google.com>
3398
3399         Reviewed by Maciej Stachowiak.
3400
3401         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
3402         https://bugs.webkit.org/show_bug.cgi?id=29080
3403
3404         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
3405
3406 2009-09-09  Eric Seidel  <eric@webkit.org>
3407
3408         Reviewed by Eric Carlson.
3409
3410         reviewer/committer lookups are backwards
3411         https://bugs.webkit.org/show_bug.cgi?id=29113
3412
3413         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
3414
3415         * Scripts/modules/bugzilla.py:
3416         * Scripts/modules/committers.py:
3417
3418 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
3419
3420         Reviewed by Eric Seidel.
3421
3422         svn-unapply doesn't revert directories correctly
3423         https://bugs.webkit.org/show_bug.cgi?id=29065
3424
3425         * Scripts/svn-unapply: Make svnStatus consistently return status
3426         lines including a newline.
3427         * Scripts/svn-apply: Keep svnStatus in sync with the one in
3428         svn-unapply, in lieu of moving it to a common file.
3429
3430 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
3431
3432         Reviewed by Eric Seidel.
3433
3434         svn-apply doesn't handle changes to files copied to new directories properly
3435         https://bugs.webkit.org/show_bug.cgi?id=29059
3436
3437         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
3438         additions if we know that we've just copied a file to this name.
3439
3440 2009-09-09  Eric Seidel  <eric@webkit.org>
3441
3442         Reviewed by David Levin.
3443
3444         commit-queue hangs if a builder has never built
3445         https://bugs.webkit.org/show_bug.cgi?id=29091
3446
3447         * Scripts/modules/buildbot.py:
3448         * Scripts/modules/buildbot_unittest.py:
3449
3450 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
3451
3452         Reviewed by Gustavo Noronha.
3453
3454         [GTK] DumpRenderTree needs eventSender object and implementation
3455         https://bugs.webkit.org/show_bug.cgi?id=25990
3456
3457         Implements most of the EventSender object's functionality for
3458         the DumpRenderTree tool. Implementation still lacks support
3459         for drag and drop tests and forward leaps.
3460
3461         Based on work by Holger Hans Peter Freyther.
3462
3463         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3464         (runTest): Focus on the view before loading a new test.
3465         (webViewWindowObjectCleared):
3466         * DumpRenderTree/gtk/EventSender.cpp: Added.
3467         (getDragModeCallback):
3468         (setDragModeCallback):
3469         (leapForwardCallback):
3470         (contextClickCallback):
3471         (updateClickCount):
3472         (mouseDownCallback):
3473         (mouseUpCallback):
3474         (mouseMoveToCallback):
3475         (beginDragWithFilesCallback):
3476         (replaySavedEvents):
3477         (keyDownCallback):
3478         (textZoomInCallback):
3479         (textZoomOutCallback):
3480         (zoomPageInCallback):
3481         (zoomPageOutCallback):
3482         (getClass):
3483         (makeEventSender):
3484         * DumpRenderTree/gtk/EventSender.h: Added.
3485         * GNUmakefile.am: Add build rules for EventSender.
3486
3487 2009-09-09  Daniel Bates  <dbates@webkit.org>
3488
3489         Reviewed by Adam Roben.
3490         
3491         https://bugs.webkit.org/show_bug.cgi?id=28953
3492
3493         Added pre- and post- build events so that on build failure, the file 
3494         buildfailed is written to the directory $(WebKitOutputDir).
3495
3496         * WinLauncher/WinLauncher.vcproj:
3497
3498 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3499
3500         Unreviewed.
3501
3502         Add myself to list of committers.
3503
3504         * Scripts/modules/committers.py:
3505
3506 2009-09-08  Eric Seidel  <eric@webkit.org>
3507
3508         Reviewed by David Levin.
3509
3510         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
3511         https://bugs.webkit.org/show_bug.cgi?id=28605
3512         https://bugs.webkit.org/show_bug.cgi?id=28916
3513
3514         * Scripts/bugzilla-tool:
3515          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
3516            comment now that it's used for rejecting patches for invalid committers too.
3517          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
3518          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
3519         * Scripts/modules/bugzilla.py:
3520          - Make _parse_attachment_element not validate reviewer/committer.
3521          - Share flag parsing code in _parse_attachment_flag.
3522          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
3523          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
3524          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
3525         * Scripts/modules/bugzilla_unittest.py:
3526          - Update this test to no longer expect committer/reviewer validation.
3527         * Scripts/modules/committers.py:
3528          - Return None on failed lookups instead of raising Exceptions.
3529         * Scripts/modules/committers_unittest.py:
3530          - Update tests to expect None returns instead of exceptions.
3531
3532 2009-09-09  David Kilzer  <ddkilzer@apple.com>
3533
3534         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
3535
3536         Reviewed by Mark Rowe.
3537
3538         No change to layout test results.
3539
3540         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3541         (AccessibilityUIElement::clickPointY): Changed to return y value
3542         instead of x value.
3543
3544 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
3545
3546         Reviewed by Mark Rowe.
3547
3548         Reduce dglazkov's boboiness by properly concatenating revision value.
3549
3550         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
3551             rather than "+".
3552
3553 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
3554
3555         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
3556
3557         * wx/build/build_utils.py:
3558
3559 2009-09-08  Mark Rowe  <mrowe@apple.com>
3560
3561         Fix an incorrect variable name in UpdateChromiumSource.
3562
3563         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3564
3565 2009-09-08  Mark Rowe  <mrowe@apple.com>
3566
3567         Don't check for leaks on the release SnowLeopard builder.
3568
3569         * BuildSlaveSupport/build.webkit.org-config/config.json:
3570
3571 2009-09-08  Mark Rowe  <mrowe@apple.com>
3572
3573         Add a SnowLeopard release builder.
3574
3575         * BuildSlaveSupport/build.webkit.org-config/config.json:
3576
3577 2009-09-08  David Levin  <levin@chromium.org>
3578
3579         Reviewed by Darin Adler.
3580
3581         Remove end of line whitespace check from check-webkit-style.
3582         https://bugs.webkit.org/show_bug.cgi?id=29053
3583
3584         * Scripts/modules/cpp_style.py:
3585
3586 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
3587
3588         Reviewed by Darin Adler.
3589
3590         Fix DumpRenderTree build from clean tree on Tiger
3591         https://bugs.webkit.org/show_bug.cgi?id=28927
3592
3593         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
3594         DerivedSources/DumpRenderTree directory exists when
3595         building on Tiger.
3596
3597 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
3598
3599         wx build fix after introduction of platform/mock directory.
3600
3601         * wx/build/settings.py:
3602
3603 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
3604
3605         Unreviewed.
3606
3607         Add myself to list of committers.
3608
3609         * Scripts/modules/committers.py:
3610
3611 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3612
3613         Unreviewed.
3614
3615         Add myself to list of committers.
3616
3617         * Scripts/modules/committers.py:
3618
3619 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
3620
3621         Reviewed by Darin Adler.
3622
3623         prepare-ChangeLog too chatty on file additions
3624         https://bugs.webkit.org/show_bug.cgi?id=29019
3625
3626         * Scripts/prepare-ChangeLog: Omit description of added properties
3627         on newly added files.
3628
3629 2009-09-08  Steve Block  <steveblock@google.com>
3630
3631         Reviewed by Adam Barth.
3632
3633         Adds a LayoutTestController method to set the permission state for Geolocation.
3634         This is required to use the mock Geolocation service for testing.
3635         https://bugs.webkit.org/show_bug.cgi?id=29027
3636
3637         * DumpRenderTree/LayoutTestController.cpp: Modified.
3638         (setDatabaseQuotaCallback): Modified. Style fix.
3639         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
3640         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
3641         * DumpRenderTree/LayoutTestController.h: Modified.
3642         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
3643         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
3644         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
3645         * DumpRenderTree/mac/UIDelegate.mm: Modified.
3646         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
3647
3648 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3649
3650         Reviewed by Simon Hausmann.
3651
3652         [Qt] QtWebKit single API to enable persistency
3653         https://bugs.webkit.org/show_bug.cgi?id=28682
3654
3655         Use the new enablePersistentStorage API instead 
3656         of enabling all persistent features one-by-one.
3657
3658         * DumpRenderTree/qt/DumpRenderTree.cpp:
3659         (WebCore::WebPage::WebPage):
3660         (WebCore::DumpRenderTree::DumpRenderTree):
3661
3662 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3663
3664         Reviewed by Tor Arne Vestbø.
3665