2007-12-13 Alp Toker <alp@atoker.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-13  Alp Toker  <alp@atoker.com>
2
3         Build fix for DRT breakage introduced in r28690.
4
5         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
6         (LayoutTestController::pathToLocalResource):
7
8 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
9
10         Reviewed by Alice and Sam.
11
12         - <rdar://5621435> Need a way to specify local resources (being loaded
13         from HTTP tests) on Windows.
14         - Implemented pathToLocalResource which exposes the functionality of
15         converting a given unix path to the correct location on Windows.
16
17         * DumpRenderTree/LayoutTestController.cpp:
18         (pathToLocalResourceCallback):
19         (LayoutTestController::staticFunctions):
20         * DumpRenderTree/LayoutTestController.h:
21         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
22         (LayoutTestController::pathToLocalResource):
23         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
24         (LayoutTestController::pathToLocalResource):
25
26 2007-12-11  Anders Carlsson  <andersca@apple.com>
27
28         Reviewed by Sam.
29
30         <rdar://problem/5132003>
31         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
32
33         * DumpRenderTree/win/DumpRenderTree.cpp:
34         (main):
35         Set the resource load delegate.
36         
37         * DumpRenderTree/win/DumpRenderTree.vcproj:
38         
39         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
40         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
41
42 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
43
44         Reviewed by Adam Roben.
45
46         Fix conversion from double to LPARAM in dispatchMessage().
47
48         * DumpRenderTree/win/EventSender.cpp:
49         (dispatchMessageCallback):
50
51 2007-12-11  Dan Bernstein  <mitz@apple.com>
52
53         Reviewed by Mark Rowe and Sam Weinig too!
54
55         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
56           fonts DumpRenderTree registers.
57
58         * DumpRenderTree/win/DumpRenderTree.cpp:
59         (initialize):
60
61 2007-12-11  Brady Eidson  <beidson@apple.com>
62
63         Reviewed by Anders
64
65         Make DumpRenderTree on mac use its own path for Databases testing
66
67         * DumpRenderTree/mac/DumpRenderTree.mm:
68         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
69           for future DRT-only use, then use it to construct the Databases path and set that default
70
71 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
72
73         Reviewed by Darin.
74
75         <rdar://problem/5535636>
76         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
77
78         http://bugs.webkit.org/show_bug.cgi?id=13916
79         JavaScript detects Tab as a character input on a textfield validation
80
81         * DumpRenderTree/mac/EventSendingController.mm:
82         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
83         Dispatch a keyup to better match what happens when a key is physically pressed.
84
85         * DumpRenderTree/win/EventSender.cpp:
86         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
87         returning from keyDown().
88         (getConstantCallback): Fixed a couple copy/paste mistakes.
89
90 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
91
92         Reviewed by Oliver.
93
94         - <rdar://5599845> Drosera: Does not show loal files in the file list
95         on the left side.
96
97         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
98         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
99         so the open source community can build.
100
101 2007-12-10  Brady Eidson  <beidson@apple.com>
102
103         Rubberstamped by Sam Weinig
104
105         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
106
107         * DumpRenderTree/mac/UIDelegate.mm:
108         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
109         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
110
111 2007-12-08  Oliver Hunt  <oliver@apple.com>
112
113         Reviewed by Sam W.
114
115         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
116         
117         Fixes <rdar://problem/5620249> Must disable SVG animation
118         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
119         
120         In order to allow finer grained control over the set of SVG features
121         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
122         distinct flags:
123         ENABLE_SVG_ANIMATION
124         ENABLE_SVG_FILTERS
125         ENABLE_SVG_FONTS
126         ENABLE_SVG_AS_IMAGE
127         ENABLE_SVG_USE
128         
129         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
130         
131         Script handles all the new build flags, and allows --svg-experimental
132         to automatically enable all features.
133
134         * Scripts/build-webkit:
135
136 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
137
138         Fix version parsing.
139
140         Rubber-stamped by Oliver.
141
142         * Drosera/win/Drosera.vcproj/auto-version.sh:
143
144 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
145
146         Build modifications for Drosera.
147
148         Reviewed by Adam.
149
150         * Drosera/DroseraWin.make: Added.
151         * Drosera/win/Drosera.vcproj/Drosera.rc:
152         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
153         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
154         * Drosera/win/Drosera.vcproj/VERSION: Added.
155         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
156
157 2007-12-06  Adam Roben  <aroben@apple.com>
158
159         Explicitly turn on the Mac font ascent hack on Windows
160
161         This keeps our font metrics matching those from Mac.
162
163         Reviewed by Hyatt.
164
165         * DumpRenderTree/win/DumpRenderTree.cpp:
166         (main):
167
168 2007-12-06  Anders Carlsson  <andersca@apple.com>
169
170         Rename main.c to main.cpp here too.
171         
172         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
173
174 2007-12-06  Sam Weinig  <sam@webkit.org>
175
176         Rubber stamped by Geoff.
177
178         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
179
180 2007-12-06  Darin Adler  <darin@apple.com>
181
182         * Scripts/do-webcore-rename: Some more renaming plans.
183
184 2007-12-06  Anders Carlsson  <andersca@apple.com>
185
186         Restore implementation of testGetIntIdentifier that was accidentally
187         removed somehow (possibly when I made PluginObject be a cpp file).
188         
189         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
190         (pluginInvoke):
191
192 2007-12-05  Anders Carlsson  <andersca@apple.com>
193
194         Make the entry points extern "C".
195         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
196         
197 2007-12-05  Anders Carlsson  <andersca@apple.com>
198
199         C++ warning fixes.
200         
201         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
202         (NPP_New):
203         (NPP_Destroy):
204         (NPP_SetWindow):
205         (NPP_NewStream):
206         (NPP_HandleEvent):
207         (NPP_URLNotify):
208         (NPP_GetValue):
209
210 2007-12-05  Anders Carlsson  <andersca@apple.com>
211
212         Add the .cpp files to the TestNetscapePlugIn target.
213
214         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
215
216 2007-12-05  Anders Carlsson  <andersca@apple.com>
217
218         Reviewed by Geoff.
219         
220         Rename the TestNetscapePlugIn .c files to be .cpp.
221
222         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
223         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
224         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
225         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
226         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
227         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
228         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
229         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
230
231 2007-12-05  Adam Roben  <aroben@apple.com>
232
233         Fix case of keypresses from the Windows implementation of eventSender.keyDown
234
235         This fixes several regression tests.
236
237         Reviewed by Alice.
238
239         * DumpRenderTree/win/EventSender.cpp:
240         (keyDownCallback): Virtual keycodes for ASCII characters are always
241         uppercase, so we need to check the case of the original character
242         passed in to eventSender.keyDown.
243
244 2007-12-05  Adam Roben  <aroben@apple.com>
245
246         Learn from Tim's mistakes
247
248         * DumpRenderTree/win/DumpRenderTree.cpp:
249         (runTest): Reset the authorAndUserStylesEnabled preference for each
250         test.
251
252 2007-12-05  Alp Toker  <alp@atoker.com>
253
254         Reviewed by Mark Rowe.
255
256         Initialize GTK+ and WebKit so the tests can run.
257
258         Reorganize the headers a little.
259
260         * DumpRenderTree/gtk/DumpRenderTree.cpp:
261         (main):
262
263 2007-12-04  Anders Carlsson  <andersca@apple.com>
264
265         Remove IWebScriptScope include.
266         
267         * Drosera/win/DebuggerDocumentPlatform.cpp:
268
269 2007-12-04  Sam Weinig  <sam@webkit.org>
270
271         Rubber stamped by Mark Rowe.
272
273         Define CF as platform for mac and revert r28409
274
275         * DumpRenderTree/DumpRenderTree.h:
276         * DumpRenderTree/mac/DumpRenderTreeMac.h:
277
278 2007-12-04  Sam Weinig  <sam@webkit.org>
279
280         Define CF as platform for windows.
281
282         Reviewed by Adam Roben.
283
284         * DumpRenderTree/win/DumpRenderTreeWin.h:
285
286 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
287
288         Reviewed by Adam and Darin.
289
290         - Removed a needless BSTR cleanup.
291
292         * Drosera/win/DebuggerDocumentPlatform.cpp:
293         (DebuggerDocument::getPlatformCurrentFunctionStack):
294
295 2007-11-27  Adam Roben  <aroben@apple.com>
296
297         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
298
299         Reviewed by Maciej.
300
301         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
302         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
303
304 2007-12-04  Alp Toker  <alp@atoker.com>
305
306         Prospective Win DRT build fix.
307
308         * DumpRenderTree/DumpRenderTree.h:
309
310 2007-12-04  Alp Toker  <alp@atoker.com>
311
312         Fix a clobbered copyright header.
313
314         * DumpRenderTree/gtk/DumpRenderTree.cpp:
315
316 2007-12-04  Xan Lopez  <xan@gnome.org>
317
318         Reviewed by Alp Toker.
319
320         http://bugs.webkit.org/show_bug.cgi?id=15561
321         GTK port needs DumpRenderTree implementation
322
323         Start work on the GTK+ DRT.
324
325         This does not work yet, and there are a few lingering style issues
326         (nothing major) but this patch has been stuck in the bug tracker for
327         too long already.
328
329         * DumpRenderTree/DumpRenderTree.h:
330         * DumpRenderTree/gtk: Added.
331         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
332         (autocorrectURL):
333         (shouldLogFrameLoadDelegates):
334         (dumpFrameScrollPosition):
335         (displayWebView):
336         (appendString):
337         (dumpFramesAsText):
338         (dumpRenderTreeAsText):
339         (dump):
340         (runTest):
341         (main):
342         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
343         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
344         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
345         (GCController::collect):
346         (GCController::collectOnAlternateThread):
347         (GCController::getJSObjectCount):
348         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
349         (LayoutTestController::~LayoutTestController):
350         (LayoutTestController::addDisallowedURL):
351         (LayoutTestController::clearBackForwardList):
352         (LayoutTestController::copyDecodedHostName):
353         (LayoutTestController::copyEncodedHostName):
354         (LayoutTestController::display):
355         (LayoutTestController::keepWebHistory):
356         (LayoutTestController::notifyDone):
357         (LayoutTestController::queueBackNavigation):
358         (LayoutTestController::queueForwardNavigation):
359         (LayoutTestController::queueLoad):
360         (LayoutTestController::queueReload):
361         (LayoutTestController::queueScript):
362         (LayoutTestController::setAcceptsEditing):
363         (LayoutTestController::setCustomPolicyDelegate):
364         (LayoutTestController::setMainFrameIsFirstResponder):
365         (LayoutTestController::setTabKeyCyclesThroughElements):
366         (LayoutTestController::setUseDashboardCompatibilityMode):
367         (LayoutTestController::setUserStyleSheetEnabled):
368         (LayoutTestController::setUserStyleSheetLocation):
369         (LayoutTestController::setWindowIsKey):
370         (LayoutTestController::setWaitToDump):
371         (LayoutTestController::windowCount):
372         (LayoutTestController::setPrivateBrowsingEnabled):
373         (LayoutTestController::setAuthorAndUserStylesEnabled):
374         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
375         (JSStringCopyUTF8CString):
376         (LoadItem::invoke):
377         (ReloadItem::invoke):
378         (ScriptItem::invoke):
379         (BackForwardItem::invoke):
380
381 2007-12-03  Sam Weinig  <sam@webkit.org>
382
383         Move JavaScriptCore thread testing code to pthread specific directory
384         and remove the dependance on CoreFoundation by using WTF::HashSet.
385
386         Reviewed by Geoff and Oliver.
387
388         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
389         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
390         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
391         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
392         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
393         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
394         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
395         * DumpRenderTree/pthreads: Added.
396         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
397         (javaScriptThreads):
398         (runJavaScriptThread):
399         (startJavaScriptThreads):
400         (stopJavaScriptThreads):
401
402 2007-12-03  Andrew Bonventre  <andybons@google.com>
403
404         Reviewed by Darin Adler.
405
406         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
407         Symbol lookup menu broken in debugger view
408
409         * Drosera/debugger.js: Fixed javascript error where document property
410         should have been used instead of contentDocument in switchFunction that
411         was breaking the select symbol dropdown menu.  This is because
412         window.frames will return a Window object and not a frame object like
413         the author was originally expecting.
414
415 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
416
417         Reviewed by Adam.
418
419         - <rdar://5618942> Drosera: Console window does not process everything
420         correctly.
421         - <rdar://5619005> Drosera: could be sped up by moving the 
422         WebScriptScope stuff into the WebScriptCallFrame.
423         - Now the console can correctly process objects and does not receive
424         notifications from JavaScriptCore about the JavaScript in Drosera's
425         own process.
426
427         * Drosera/win/DebuggerDocumentPlatform.cpp:
428         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
429         (DebuggerDocument::platformValueForScopeVariableNamed):
430
431 2007-12-03  Stephanie  <slewis@apple.com>
432
433         Reviewed by Darin.
434
435         Check to see if we are building a debug root
436
437         * Scripts/check-for-global-initializers: 
438
439 2007-12-03  Dan Bernstein  <mitz@apple.com>
440
441         Reviewed by Darin Adler.
442
443         - added a testGetIntIdentifier() method to TestNetscapePlugIn
444
445         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
446         (pluginInvoke):
447
448 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
449
450         Reviewed by Oliver.
451
452         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
453         in a more fine-grained manner than eventSender.keyDown().
454
455         * DumpRenderTree/win/EventSender.cpp:
456         (getConstantCallback):
457         (dispatchMessageCallback):
458
459 2007-12-02  Darin Adler  <darin@apple.com>
460
461         * Scripts/do-webcore-rename: More planned renaming.
462
463 2007-12-02  Sam Weinig  <sam@webkit.org>
464
465         Rubber stamped by Anders.
466
467         Use [NSURL absoluteString] instead of [NSURL description] in order to get
468         more uniform results cross platform.
469
470         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
471         (-[NSURL _drt_descriptionSuitableForTestResult]):
472
473 2007-12-02  Sam Weinig  <sam@webkit.org>
474
475         Rubber stamped by Niko.
476
477         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
478
479         * DumpRenderTree/win/DumpRenderTree.cpp:
480         * DumpRenderTree/win/DumpRenderTree.vcproj:
481         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
482         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
483         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
484         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
485
486 2007-12-01  Alp Toker  <alp@atoker.com>
487
488         Reviewed by Adam Roben.
489
490         Make use of the newly introduced webkit.h convenience header.
491
492         * GtkLauncher/main.c:
493
494 2007-12-01  Adam Treat  <treat@kde.org>
495
496         Reviewed by Simon.
497
498         * Check to see if the directory exists and exit if not.
499
500         * DumpRenderTree/qt/main.cpp:
501         (main):
502
503 2007-12-01  Adam Treat  <treat@kde.org>
504
505         Reviewed by Simon.
506
507         * Don't hide symbols when in Debug mode
508         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
509
510
511         * DumpRenderTree/qt/main.cpp:
512         (messageHandler):
513
514 2007-11-30  Alp Toker  <alp@atoker.com>
515
516         Reviewed by Adam Roben.
517
518         http://bugs.webkit.org/show_bug.cgi?id=15691
519         [GTK] Public API does not follow GTK+ conventions
520
521         Refactor the WebKit/GTK+ public API. Changes:
522           WebKitPage -> WebKitWebView
523           WebKitFrame -> WebKitWebFrame
524
525         Public API source and header names have been updated to mirror the API
526         changes.
527
528         The API is now kept in WebKit/gtk/WebView to match other ports in the
529         same class such as Mac and Win.
530
531         * GtkLauncher/main.c:
532         (activate_uri_entry_cb):
533         (link_hover_cb):
534         (title_change_cb):
535         (progress_change_cb):
536         (go_back_cb):
537         (go_forward_cb):
538         (create_browser):
539         (main):
540
541 2007-11-30  Adam Roben  <aroben@apple.com>
542
543         Hopefully the final build fix
544
545         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
546         pull in WTF's assertion/logging functions.
547
548 2007-11-30  Adam Roben  <aroben@apple.com>
549
550         Another build fix
551
552         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
553         WebKit.lib.
554
555 2007-11-30  Adam Roben  <aroben@apple.com>
556
557         Debug build fix
558
559         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
560         configuration.
561         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
562         projects.
563         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
564         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
565         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
566
567 2007-11-30  Sam Weinig  <sam@webkit.org>
568
569         Reviewed by Adam Roben.
570
571         Fix drawSelectionRect to actually draw the selection rect.
572
573         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
574         (drawSelectionRect):
575
576 2007-11-30  Darin Adler  <darin@apple.com>
577
578         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
579
580 2007-11-30  Darin Adler  <darin@apple.com>
581
582         * Scripts/do-webcore-rename: Get ready for some future renaming.
583
584 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
585
586         Reviewed by Adam.
587
588         - Removed some unnecessary functions and changed an unused return type. 
589
590         * Drosera/win/DebuggerClient.cpp:
591         (registerConsoleClass):
592         * Drosera/win/DebuggerClient.h:
593         * Drosera/win/Drosera.cpp:
594         (registerDroseraClass):
595
596 2007-11-28  Alp Toker  <alp@atoker.com>
597
598         Reviewed by Timothy Hatcher.
599
600         http://bugs.webkit.org/show_bug.cgi?id=16174
601         [GTK] Use "URI" not "URL" in public API
602
603         Replace use of the term "URL" with "URI" in public headers,
604         documentation and some internal code to match GLib/GTK+ convention.
605
606         This is now mentioned in the API guidelines:
607           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
608
609         * GtkLauncher/main.c:
610         (activate_uri_entry_cb):
611         (title_change_cb):
612         (create_toolbar):
613         (main):
614
615 2007-11-29  Anders Carlsson  <andersca@apple.com>
616
617         Reviewed by Sam.
618
619         <rdar://problem/5230478>
620         FrameLoadDelegate callbacks are not dumped in DRT.
621         
622         * DumpRenderTree/win/DumpRenderTree.cpp:
623         (shouldLogFrameLoadDelegates):
624         (runTest):
625         (main):
626         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
627         (BSTRtoString):
628         (descriptionSuitableForTestResult):
629         (FrameLoadDelegate::QueryInterface):
630         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
631         (FrameLoadDelegate::didFailProvisionalLoadWithError):
632         (FrameLoadDelegate::didCommitLoadForFrame):
633         (FrameLoadDelegate::didFinishLoadForFrame):
634         (FrameLoadDelegate::willCloseFrame):
635         (FrameLoadDelegate::didClearWindowObject):
636         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
637         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
638         * DumpRenderTree/win/FrameLoaderDelegate.h:
639         (FrameLoadDelegate::windowScriptObjectAvailable):
640         (FrameLoadDelegate::didFirstLayoutInFrame):
641
642 2007-11-29  Sam Weinig  <sam@webkit.org>
643
644         Reviewed by Anders.
645
646         Add database quota UIDelegates methods to DRT UIDelegate.
647
648         * DumpRenderTree/mac/UIDelegate.mm:
649         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
650         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
651
652 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
653
654         Reviewed by Sam.
655
656         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
657         dying and vice versa.
658         - This fix will allow Drosera and Safari to reconnect if either of them
659         closes correctly, but does not fix the case where one of them dies
660         silently.
661
662         * Drosera/win/ServerConnection.cpp:
663         (ServerConnection::attemptToCreateServerConnection): Added a safety
664         check, because it's possilbe to try to connect to a server that's dying.
665         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
666         the server has died.
667         * Drosera/win/ServerConnection.h: Added the new function and removed
668         an unnecessary member.
669
670 2007-11-29  Anders Carlsson  <andersca@apple.com>
671
672         * DumpRenderTree/win/DumpRenderTree.vcproj:
673         Add shlwapi.lib to all configurations.
674
675 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
676
677         - Build fix.  Added additional includes for VS Express to the Release
678         project.
679
680         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
681
682 2007-11-29  Anders Carlsson  <andersca@apple.com>
683
684         Reviewed by Adam.
685
686         <rdar://problem/5132005>
687         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
688         
689         * DumpRenderTree/win/DumpRenderTree.vcproj:
690         Add shlwapi.lib
691         
692         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
693         (LayoutTestController::setUserStyleSheetEnabled):
694         Implement this.
695         
696         (appendComponentToPath):
697         New method which wraps the Win32 API PathAppend.
698         
699         (followShortcuts):
700         New method which checks if a file points to a shortcut and
701         follows the shortcut.
702         
703         (resolveCygwinPath):
704         New method that takes a cygwin unix-style path and returns the Win32 path.
705         
706         (cfStringRefToWString):
707         
708         (LayoutTestController::setUserStyleSheetLocation):
709         Implement this.
710
711 2007-11-29  Alice Liu  <alice.liu@apple.com>
712
713         Reviewed by Adam.
714
715         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
716
717         * DumpRenderTree/win/EventSender.cpp:
718         (keyDownCallback):
719         uppercase letters were being sent as lowercase letters without the shift key down.
720
721 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
722
723         - Windows build fix. VS express needs some love.
724
725         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
726
727 2007-11-28  Darin Adler  <darin@apple.com>
728
729         Reviewed by Adam Roben.
730
731         * DumpRenderTree/mac/EventSendingController.mm:
732         (-[EventSendingController keyDown:withModifiers:]):
733         Send capital letters through as lowercase letters with the shift key down
734         rather than sending them as if they were highly unusual "capital letter keys".
735
736         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
737         where you need to update results and more tests are failing than before.
738
739 2007-11-28  Anders Carlsson  <andersca@apple.com>
740
741         Reviewed by Darin.
742
743         <rdar://problem/5132001>
744         contextClick is not implemented in DRT on Windows.
745         
746         * DumpRenderTree/win/EventSender.cpp:
747         (contextClickCallback):
748         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
749         by a WM_RBUTTONUP message.
750         
751         * DumpRenderTree/win/UIDelegate.cpp:
752         (UIDelegate::hasCustomMenuImplementation):
753         (UIDelegate::trackCustomPopupMenu):
754         * DumpRenderTree/win/UIDelegate.h:
755         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
756         menu from being shown (and causing the DRT to hang).
757
758 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
759
760         Reviewed by Darin.
761
762         Fix DumpRenderTree ObjC bug comparing strings.
763
764         * DumpRenderTree/mac/ObjCController.m:
765         (-[ObjCController identityIsEqual::]): Compare strings with string
766         equality instead of identiy equality.
767
768 2007-11-27  Timothy Hatcher  <timothy@apple.com>
769
770         Reviewed by Sam.
771
772         Reset the authorAndUserStylesEnabled preference
773         back to YES for each test. Fixes the broken tests.
774
775         * DumpRenderTree/mac/DumpRenderTree.mm:
776         (resetWebViewToConsistentStateBeforeTesting):
777
778 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
779
780         Reviewed by Adam.
781
782         - Drosera now displays the console window, although it cannot currently
783         process JavaScript.
784
785         * Drosera/win/DebuggerClient.cpp: Shows the console window.
786         (registerConsoleClass): Implemented.
787         (consoleWndProc): Implemented.
788         (DebuggerClient::onSize): Implemented.
789         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
790         new window.
791         * Drosera/win/DebuggerClient.h: Added needed method and members for 
792         creating and maintaining a new window.
793         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
794         lines of code to more appropriate places.
795         (Drosera::handleCommand):
796         (Drosera::initUI):
797         (Drosera::onSize):
798         (Drosera::attach):
799
800 2007-11-27  Timothy Hatcher  <timothy@apple.com>
801
802         Reviewed by Dave Hyatt.
803
804         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
805         
806         Add support for disabling author and user styles for testing.
807
808         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
809         * DumpRenderTree/LayoutTestController.cpp:
810         (setAuthorAndUserStylesEnabledCallback):
811         (LayoutTestController::staticFunctions):
812         * DumpRenderTree/LayoutTestController.h:
813         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
814         (LayoutTestController::setAuthorAndUserStylesEnabled):
815         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
816         (LayoutTestController::setAuthorAndUserStylesEnabled):
817
818 2007-11-26  Dan Bernstein  <mitz@apple.com>
819
820         - Tiger build fix.
821
822         * DumpRenderTree/mac/Configurations/Base.xcconfig:
823
824 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
825
826         Reviewed by Maciej.
827
828         - Implemented displaying variables for Drosera on Win.
829
830         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
831         that retrieve variables to not hold onto the return value since it's
832         not returned.  Also changed to use the new signatures of the retrieval
833         functions.
834         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
835         (DebuggerDocument::platformValueForScopeVariableNamed):
836         * Drosera/win/Drosera.cpp: Removed a needless TODO.
837         (droseraWndProc):
838
839 2007-11-26  Sam Weinig  <sam@webkit.org>
840
841         Cleanup names of painting and repainting functions.
842
843         Reviewed by Adam Roben.
844
845         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
846         (drawSelectionRect): was drawSelectionRectIntoContext.
847         (dumpWebViewAsPixelsAndCompareWithExpected):
848         * DumpRenderTree/cg/PixelDumpSupportCG.h:
849         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
850         (paintWebView): was drawWebViewIntoContext.
851         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
852
853 2007-11-26  Sam Weinig  <sam@webkit.org>
854
855         Reviewed by Dan Bernstein.
856
857         - Leopard build fix
858
859         * DumpRenderTree/mac/Configurations/Base.xcconfig:
860
861 2007-11-26  Sam Weinig  <sam@webkit.org>
862
863         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
864         Use shared PixelDumpSupport for Mac DRT
865
866         Reviewed by Adam Roben.
867
868         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
869         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
870         * DumpRenderTree/cg/ImageDiffCG.cpp:
871         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
872         (drawSelectionRectIntoContext):
873         (dumpWebViewAsPixelsAndCompareWithExpected):
874         * DumpRenderTree/cg/PixelDumpSupportCG.h:
875         * DumpRenderTree/mac/Configurations/Base.xcconfig:
876         * DumpRenderTree/mac/DumpRenderTree.mm:
877         (dump):
878         * DumpRenderTree/mac/ImageDiff.m: Removed.
879         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
880         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
881         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
882         (setDefaultColorProfileToRGB):
883         (getBitmapContextFromWebView):
884         (drawWebViewIntoContext):
885         (repaintWithVerticalSweep):
886         (repaintWithHorizontalSweep):
887         (getSelectionRect):
888         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
889
890 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
891
892         Bug 16052: prepare-ChangeLog doesn't report deleted files
893         <http://bugs.webkit.org/show_bug.cgi?id=16052>
894
895         Reviewed by Sam.
896
897         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
898
899 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
900
901         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
902         <http://bugs.webkit.org/show_bug.cgi?id=15864>
903
904         Reviewed by Adam.
905
906         Roll functionality of merge-changelog into resolve-ChangeLogs
907         script.  The script now checks for ChangeLog.rej and
908         ChangeLog.orig files first.  If it finds them, it uses the
909         ChangeLog.rej file as a patch (in old contextual diff format) to
910         apply with --fuzz=3.
911
912         * Scripts/merge-changelog: Removed.
913         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
914
915 2007-11-25  Sam Weinig  <sam@webkit.org>
916
917         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
918
919         Reviewed by Mark Rowe.
920
921         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
922         * DumpRenderTree/mac/Configurations/Base.xcconfig:
923         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
924         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
925         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
926
927 2007-11-25  Sam Weinig  <sam@webkit.org>
928
929         Convert DumpRenderTree to ues .xcconfig files.
930
931         Reviewed by Mark Rowe.
932
933         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
934         * DumpRenderTree/mac/Configurations: Added.
935         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
936         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
937         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
938
939 2007-11-25  Sam Weinig  <sam@webkit.org>
940
941         Add ForwardingHeaders to wtf for DumpRenderTree.
942
943         Reviewed by Mark Rowe.
944
945         * DumpRenderTree/DumpRenderTree.h:
946         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
947         * DumpRenderTree/ForwardingHeaders: Added.
948         * DumpRenderTree/ForwardingHeaders/wtf: Added.
949         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
950         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
951         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
952         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
953         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
954         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
955         * DumpRenderTree/LayoutTestController.cpp:
956         * DumpRenderTree/WorkQueue.cpp:
957         * DumpRenderTree/mac/DumpRenderTree.mm:
958         * DumpRenderTree/mac/FrameLoadDelegate.mm:
959         * DumpRenderTree/mac/JavaScriptThreading.cpp:
960         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
961         * DumpRenderTree/mac/ObjCController.m:
962         * DumpRenderTree/mac/UIDelegate.mm:
963         * DumpRenderTree/mac/WorkQueueItemMac.mm:
964
965 2007-11-25  Adam Roben  <aroben@apple.com>
966
967         Fix some test failures caused by r28019
968
969         Now that stdout is in binary mode, we need to always use printf
970         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
971         the output.
972
973         Reviewed by Sam.
974
975         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
976         printf.
977         (UIDelegate::runJavaScriptAlertPanelWithMessage):
978         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
979         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
980         (UIDelegate::webViewAddMessageToConsole):
981
982 2007-11-25  Adam Roben  <aroben@apple.com>
983
984         Set the font smoothing preference in DRT
985
986         This makes the pixel results on Windows closer to the Mac results.
987
988         Reviewed by Mitz.
989
990         * DumpRenderTree/win/DumpRenderTree.cpp:
991         (initializePreferences):
992
993 2007-11-25  Adam Roben  <aroben@apple.com>
994
995         Port ImageDiff to CG and C++
996
997         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
998         <rdar://5071708>
999
1000         Reviewed by Sam.
1001
1002         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1003         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1004         (main):
1005         (createImageFromStdin):
1006         (compareImages):
1007         (getDifferenceBitmap):
1008         (computePercentageDifferent):
1009         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1010
1011 2007-11-25  Adam Roben  <aroben@apple.com>
1012
1013         Fix image diff link generation on Windows
1014
1015         Reviewed by Sam.
1016
1017         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1018         to toURL.
1019
1020 2007-11-25  Adam Roben  <aroben@apple.com>
1021
1022         Implement pixel dumping in Windows DRT
1023
1024         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1025         <rdar://5071708>
1026
1027         Reviewed by Sam.
1028
1029         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1030         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1031         Content-Length header.
1032         (getMD5HashStringForBitmap):
1033         (dumpWebViewAsPixelsAndCompareWithExpected):
1034         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1035         * DumpRenderTree/win/DumpRenderTree.cpp:
1036         (dump): Do a pixel dump if requested.
1037         (main): Parse pixel test options.
1038         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1039         the cg/ subdirectory to the include path.
1040         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1041         available in a header or import library, so we have to go through this
1042         LoadLibrary/GetProcAddress dance to use them.
1043         (cryptDLL):
1044         (init):
1045         (update):
1046         (final):
1047         (MD5_Init):
1048         (MD5_Update):
1049         (MD5_Final):
1050         * DumpRenderTree/win/MD5.h: Added.
1051         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1052         moved up to the top level to share it with Mac eventually.
1053         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1054         (getBitmapContextFromWebView): Forces the WebView to paint using a
1055         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1056
1057 2007-11-25  Adam Roben  <aroben@apple.com>
1058
1059         Clean up Windows DRT's option parsing a little bit
1060
1061         Reviewed by Sam.
1062
1063         * DumpRenderTree/win/DumpRenderTree.cpp:
1064         (main): Put non-option arguments into a Vector.
1065
1066 2007-11-25  Adam Roben  <aroben@apple.com>
1067
1068         Make Windows DRT stop changing LF into CRLF
1069
1070         Reviewed by Sam.
1071
1072         * DumpRenderTree/win/DumpRenderTree.cpp:
1073         (main): Put stdout in binary mode.
1074         * Scripts/run-webkit-tests: Remove the CRLF hack.
1075
1076 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1077
1078         Removed empty directory.
1079
1080         * Scripts/resources: Removed.
1081
1082 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1083
1084         Fix bisect-builds to work with recent WebKit nightly builds.
1085
1086         Reviewed by Dan.
1087
1088         * Scripts/bisect-builds: Check for the 
1089         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1090         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1091         to WebKit.app/Contents/Resources.
1092
1093 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1094
1095         Reviewed by Maciej.
1096
1097         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1098         not closed (affects digg.com)
1099
1100         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1101         one after finishing with a test to avoid having its delayed onload handler firing when
1102         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1103         but it helps somewhat.
1104
1105 2007-11-22  Mark Rowe  <mrowe@apple.com>
1106
1107         Reviewed by Alp Toker.
1108
1109         Fix build-webkit to propagate make's exit status if it fails.
1110
1111         * Scripts/webkitdirs.pm:
1112
1113 2007-11-22  Dan Bernstein  <mitz@apple.com>
1114
1115         Reviewed by Mark Rowe.
1116
1117         - fix crash when running pixel tests
1118
1119         * DumpRenderTree/mac/DumpRenderTree.mm:
1120         (dumpRenderTree): Parse the command line options before setting up the
1121         environment so that we know if we need to set up the pixel dump
1122         machinery.
1123
1124 2007-11-21  Eric Seidel  <eric@webkit.org>
1125
1126         Speculative build fix for Tiger.
1127
1128         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1129
1130 2007-11-21  Eric Seidel  <eric@webkit.org>
1131
1132         Reviewed by Tim Hatcher.
1133
1134         Break out more of DumpRenderTree.mm into individual files
1135
1136         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1137         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1138         (checkedMalloc):
1139         (checkedRealloc):
1140         (makeLargeMallocFailSilently):
1141         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1142         * DumpRenderTree/mac/DumpRenderTree.mm:
1143         (crashHandler):
1144         (dump):
1145         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1146         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1147         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1148         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1149         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1150         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1151         (javaScriptThreads):
1152         (runJavaScriptThread):
1153         (startJavaScriptThreads):
1154         (stopJavaScriptThreads):
1155         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1156         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1157         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1158         (restoreColorSpace):
1159         (setDefaultColorProfileToRGB):
1160         (initializeColorSpaceAndScreeBufferForPixelTests):
1161         (md5HashStringForBitmap):
1162         (dumpWebViewAsPixelsAndCompareWithExpected):
1163
1164 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1165
1166         Move install-unix-extras to wx directory as it seems only to be used by that 
1167         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1168         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1169         have install-unix-extras install into WebKitLibraries as per
1170         convention.
1171         
1172         Reviewed by Mark Rowe.
1173
1174         * Scripts/install-unix-extras: Removed.
1175         * wx/build-wxwebkit:
1176         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1177
1178 2007-11-21  Eric Seidel  <eric@webkit.org>
1179
1180         Reviewed by Adam.
1181
1182         More refactoring for greater code readability
1183
1184         * DumpRenderTree/mac/DumpRenderTree.mm:
1185         (initializeGlobalsFromCommandLineOptions):
1186         (initializeColorSpaceAndScreeBufferForPixelTests):
1187         (addTestPluginsToPluginSearchPath):
1188         (useLongRunningServerMode):
1189         (runTestingServerLoop):
1190         (prepareConsistentTestingEnvironment):
1191         (dumpRenderTree):
1192         (main):
1193         (dumpFramesAsText):
1194         (dumpBackForwardListForWebView):
1195         (sizeWebViewForCurrentTest):
1196         (methodNameStringForFailedTest):
1197         (dumpBackForwardListForAllWindows):
1198         (dumpWebViewAsPixelsAndCompareWithExpected):
1199         (invalidateAnyPreviousWaitToDumpWatchdog):
1200         (dump):
1201         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1202         * DumpRenderTree/mac/UIDelegate.mm:
1203         (-[UIDelegate webView:createWebViewWithRequest:]):
1204
1205 2007-11-21  Eric Seidel  <eric@webkit.org>
1206
1207         Reviewed by Tim Hatcher.
1208
1209         Abstract more of DRT into static methods
1210
1211         * DumpRenderTree/mac/DumpRenderTree.mm:
1212         (setDefaultsToConsistentValuesForTesting):
1213         (setupSignalHandlers):
1214         (allocateGlobalControllers):
1215         (releaseAndZero):
1216         (releaseGlobalControllers):
1217         (dumpRenderTree):
1218         (shouldLogFrameLoadDelegates):
1219         (createCFURLFromPathOrURL):
1220         (resetWebViewToConsistentStateBeforeTesting):
1221         (runTest):
1222
1223 2007-11-21  Eric Seidel  <eric@webkit.org>
1224
1225         Reviewed by Tim Hatcher.
1226
1227         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1228
1229         * DumpRenderTree/DumpRenderTree.h:
1230         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1231         * DumpRenderTree/mac/DumpRenderTree.mm:
1232         (dumpRenderTree):
1233         (dump):
1234         (runTest):
1235         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1236         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1237         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1238         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1239         (-[DumpRenderTreePasteboard declareType:owner:]):
1240         (+[LocalPasteboard alloc]):
1241         (-[LocalPasteboard init]):
1242         (-[LocalPasteboard dealloc]):
1243         (-[LocalPasteboard name]):
1244         (-[LocalPasteboard releaseGlobally]):
1245         (-[LocalPasteboard declareTypes:owner:]):
1246         (-[LocalPasteboard addTypes:owner:]):
1247         (-[LocalPasteboard changeCount]):
1248         (-[LocalPasteboard types]):
1249         (-[LocalPasteboard availableTypeFromArray:]):
1250         (-[LocalPasteboard setData:forType:]):
1251         (-[LocalPasteboard dataForType:]):
1252         (-[LocalPasteboard setPropertyList:forType:]):
1253         (-[LocalPasteboard setString:forType:]):
1254         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1255         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1256         (+[DumpRenderTreeWindow allWindows]):
1257         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1258         (-[DumpRenderTreeWindow dealloc]):
1259         (-[DumpRenderTreeWindow isKeyWindow]):
1260         (-[DumpRenderTreeWindow keyDown:]):
1261
1262 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1263
1264         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1265         it indiscriminately copies any headers inside JavaScriptCore,
1266         which includes Tiger ICU headers. 
1267
1268         * wx/build-wxwebkit:
1269         Don't run WebCore/move-js-headers.sh any longer.
1270
1271 2007-11-20  Adam Treat  <treat@kde.org>
1272
1273         Reviewed by David Kilzer.
1274
1275         * Prepend git branch name to $baseProductDir
1276
1277         * Scripts/VCSUtils.pm:
1278         * Scripts/webkitdirs.pm:
1279
1280 2007-11-20  Mark Rowe  <mrowe@apple.com>
1281
1282         Reviewed by Simon Hausmann.
1283
1284         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1285         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1286         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1287         built product and generated Makefile's are removed.
1288
1289 2007-11-19  Alp Toker  <alp@atoker.com>
1290
1291         Reviewed by Mark Rowe.
1292
1293         http://bugs.webkit.org/show_bug.cgi?id=16040
1294         [GTK] GtkLauncher should be written in C
1295
1296         Port GtkLauncher to plain C.
1297
1298         Use a more conventional GTK+ coding style.
1299
1300         Use a toolbar instead of menus.
1301
1302         Various signature fixes and cleanups.
1303
1304         Add a license header. Assume all previous modifications were copyright
1305         assigned to Apple Inc. by default.
1306
1307         * GtkLauncher/GtkLauncher.pro:
1308         * GtkLauncher/main.c: Added.
1309         (activate_url_entry_cb):
1310         (update_title):
1311         (link_hover_cb):
1312         (title_change_cb):
1313         (progress_change_cb):
1314         (destroy_cb):
1315         (go_back_cb):
1316         (go_forward_cb):
1317         (create_browser):
1318         (create_statusbar):
1319         (create_toolbar):
1320         (create_window):
1321         (main):
1322         * GtkLauncher/main.cpp: Removed.
1323
1324 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1325
1326         Build script fixes to ensure they do the right thing for the 
1327         wx port, and update build-wxwebkit to reflect the way the
1328         build scripts now work.
1329
1330         Reviewed by Adam.
1331
1332         * Scripts/build-testkjs:
1333         * Scripts/build-webkit:
1334         * Scripts/run-javascriptcore-tests:
1335         * Scripts/webkitdirs.pm:
1336         * wx/build-wxwebkit:
1337
1338 2007-11-18  Eric Seidel  <eric@webkit.org>
1339
1340         Reviewed by Anders.
1341
1342         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1343
1344         * Scripts/run-javascriptcore-tests:
1345
1346 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1347
1348         Reviewed by Adam Roben.
1349
1350         Make run-webkit-tests work with Windows debug build.
1351
1352         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1353         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1354         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1355         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1356         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1357
1358 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1359
1360         Add wxWebKit sample and build script, and integrate it with 
1361         build-webkit. Also make build-webkit --clean work for all
1362         ports.
1363
1364         Reviewed by Darin Adler.
1365
1366         * Scripts/build-webkit:
1367         * Scripts/webkitdirs.pm:
1368         * wx: Added.
1369         * wx/browser: Added.
1370         * wx/browser/browser.bkl: Added.
1371         * wx/browser/browser.cpp: Added.
1372         * wx/build-wxwebkit: Added.
1373
1374 2007-11-17  Adam Roben  <aroben@apple.com>
1375
1376         Make it easy to run Safari in the debugger on Windows
1377
1378         I've added a new script, debug-safari, which launches Safari in the
1379         debugger. On OS X it just calls gdb-safari.
1380
1381         Reviewed by Mark Rowe.
1382
1383         * FindSafari/FindSafari.cpp:
1384         (_tmain): Added a /debugger flag, which in combination with
1385         /printSafariLauncher will print a script that launches Safari in the
1386         debugger.
1387         * Scripts/debug-safari: Added.
1388         * Scripts/run-safari: Changed to call runSafari().
1389         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1390         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1391         first argument along to FindSafari.
1392         * Scripts/webkitdirs.pm:
1393         (sub runSafari): Added.
1394
1395 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1396
1397         Reviewed by Adam Roben.
1398
1399         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1400
1401 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1402
1403         Reviewed by David Kilzer.
1404
1405         The git config command was renamed to repo-config at some point. This
1406         change tries git config and then git repo-config if the first fails.
1407
1408         * Scripts/prepare-ChangeLog:
1409         (gitConfig):
1410
1411 2007-11-16  Dan Bernstein  <mitz@apple.com>
1412
1413         Reviewed by Darin Adler and Sam Weinig.
1414
1415         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1416
1417         * DumpRenderTree/win/EventSender.cpp:
1418         (keyDownCallback): For characters that cannot be entered on the active
1419         keyboard layout, send a WM_CHAR message with the character along with
1420         a WM_KEYDOWN message with a virtual key code of 255.
1421
1422 2007-11-16  Mark Rowe  <mrowe@apple.com>
1423
1424         Reviewed by Tim Hatcher.
1425
1426         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1427
1428         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1429         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1430
1431 2007-11-15  Adam Roben  <aroben@apple.com>
1432
1433         Make run-safari actually work on Windows
1434
1435         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1436         chdir call.
1437
1438 2007-11-14  Adam Roben  <aroben@apple.com>
1439
1440         Updates to Safari launching now that 3.0.4 is released
1441
1442         Reviewed by Sam.
1443
1444         * FindSafari/FindSafari.cpp:
1445         (getWebViewCLSID): Use version-independent ProgID.
1446         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1447
1448 2007-11-14  Anders Carlsson  <andersca@apple.com>
1449
1450         Reviewed by Adam.
1451
1452         <rdar://problem/5309081>
1453         In DRT, "plugin.logDestroy = true" not working on Windows.
1454         
1455         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1456         (NPP_Destroy):
1457
1458 2007-11-14  Eric Seidel  <eric@webkit.org>
1459
1460         Reviewed by Sam.
1461
1462         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1463
1464 2007-11-14  Anders Carlsson  <andersca@apple.com>
1465
1466         Reviewed by Adam.
1467
1468         <rdar://problem/5141186>
1469         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1470         
1471         Implement setWindowIsKey.
1472         
1473         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1474         (LayoutTestController::setWindowIsKey):
1475
1476 2007-11-13  Sam Weinig  <sam@webkit.org>
1477
1478         Reviewed by Adam Roben.
1479
1480         Fix for <rdar://problem/5382579>
1481         http/tests/security/cross-frame-access-put.html reports large 
1482         negative numbers for screenLeft and screenTop (Mac reports "0")
1483
1484         * DumpRenderTree/win/UIDelegate.cpp:
1485         (UIDelegate::UIDelegate): Initialize the RECT.
1486         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1487         (UIDelegate::webViewFrame): ditto.
1488         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1489
1490 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1491
1492         Reviewed by Adam.
1493
1494         - Make Drosera show source, source URLs, and function stack on Windows,
1495         and some minor fixes.
1496
1497         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1498         (DebuggerDocument::updateFileSource):
1499         * Drosera/debugger.js: Force source to always update display.
1500         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1501         menu controls.
1502         (DebuggerClient::resume):
1503         (DebuggerClient::pause):
1504         (DebuggerClient::stepInto):
1505         (DebuggerClient::stepOver):
1506         (DebuggerClient::stepOut):
1507         (DebuggerClient::showConsole):
1508         (DebuggerClient::closeCurrentFile):
1509         * Drosera/win/DebuggerClient.h: Ditto.
1510         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1511         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1512         removed two bugs.  1) caller could be in a bad state when asked to
1513         assign into it. 2) BSTRs were not created correctly.
1514         (DebuggerDocument::getPlatformCurrentFunctionStack):
1515         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1516         (droseraWndProc):
1517         (handleCommand):
1518         (Drosera::resume):
1519         (Drosera::pause):
1520         (Drosera::stepInto):
1521         (Drosera::stepOver):
1522         (Drosera::stepOut):
1523         (Drosera::showConsole):
1524         (Drosera::closeCurrentFile):
1525         * Drosera/win/Drosera.h: Hook up the menu controls.
1526         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1527         functions, added a null check, and fixed another bug where caller could
1528         be in a bad state when asked to assign into it.
1529         (ServerConnection::didLoadMainResourceForDataSource):
1530         (ServerConnection::getCallerFrame):
1531         * Drosera/win/ServerConnection.h: Safety first.
1532
1533 2007-11-13  Dan Bernstein  <mitz@apple.com>
1534
1535         Reviewed by Darin Adler.
1536
1537         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1538           DumpRenderTree --pixel-tests renders each test twice
1539
1540         * DumpRenderTree/mac/DumpRenderTree.mm:
1541         (dumpRenderTree): Removed the --paint option because the painting code
1542         is always exercised as a result of
1543         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1544         calling -displayIfNeeded.
1545         (dump): Changed to always grab the image from the window since the view
1546         is always displayed.
1547         (runTest):
1548         (displayWebView):
1549         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1550         because it always paints.
1551
1552 2007-11-12  Antti Koivisto  <antti@apple.com>
1553
1554         Reviewed by Adele.
1555         
1556         Add support for http media tests
1557
1558         * Scripts/run-webkit-tests:
1559
1560 2007-11-12  Sam Weinig  <sam@webkit.org>
1561
1562         Reviewed by Adam Roben.
1563
1564         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1565
1566         * DumpRenderTree/win/DumpRenderTree.cpp:
1567         (runTest):
1568         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1569         (LayoutTestController::setPrivateBrowsingEnabled):
1570
1571 2007-11-12  Adam Roben  <aroben@apple.com>
1572
1573         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1574         mac and win subdirectories.
1575
1576 2007-11-11  Adam Roben  <aroben@apple.com>
1577
1578         Fix <rdar://5133816> keepWebHistory is not implemented
1579
1580         Fixes fast/history/clicked-link-is-visited.html.
1581
1582         Reviewed by Darin.
1583
1584         * DumpRenderTree/win/DumpRenderTree.cpp:
1585         (runTest): Clear the optionalSharedHistory.
1586         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1587         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1588
1589 2007-11-10  Sam Weinig  <sam@webkit.org>
1590
1591         Reviewed by Tim Hatcher.
1592
1593         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1594         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1595         is turned on)
1596
1597         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1598
1599         Added test: http/tests/security/cross-frame-access-private-browsing.html
1600
1601         * DumpRenderTree/LayoutTestController.cpp:
1602         (setPrivateBrowsingEnabledCallback):
1603         (LayoutTestController::staticFunctions):
1604         * DumpRenderTree/LayoutTestController.h:
1605         * DumpRenderTree/mac/DumpRenderTree.mm:
1606         (runTest): Default to private browsing disabled.
1607         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1608         (LayoutTestController::setPrivateBrowsingEnabled):
1609         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1610         (LayoutTestController::setPrivateBrowsingEnabled):
1611
1612 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1613
1614         Reviewed by Adam.
1615
1616         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1617         WebCore's!
1618
1619         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1620         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1621         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1622         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1623         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1624         * Drosera/win/Drosera.cpp:
1625         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1626
1627 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1628
1629         Reviewed by Sam.
1630
1631         - Use the new IWebFrame [local] function signature and get the shared
1632         server correctly.
1633
1634         * Drosera/win/DebuggerClient.cpp:
1635         (DebuggerClient::didFinishLoadForFrame):
1636         * Drosera/win/ServerConnection.cpp:
1637         (ServerConnection::attemptToCreateServerConnection):
1638
1639 2007-11-07  Dan Bernstein  <mitz@apple.com>
1640
1641         Reviewed by Darin Adler.
1642
1643         - add an option to run-webkit-tests to ignore pixel test failures where
1644           all pixels differ by no more than a specified threshold
1645
1646         * DumpRenderTree/mac/ImageDiff.m:
1647         (main):
1648         (compareImages):
1649         (computePercentageDifferent):
1650         * Scripts/run-webkit-tests:
1651
1652 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1653
1654         Reviewed by Lars.
1655
1656         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1657
1658         * DumpRenderTree/qt/DumpRenderTree.cpp:
1659
1660 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1661
1662         Reviewed by Lars.
1663
1664         Reworked the QWebSettings API.
1665         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1666
1667         * DumpRenderTree/qt/DumpRenderTree.cpp:
1668
1669 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1670
1671         Reviewed by Lars.
1672
1673         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1674
1675         * DumpRenderTree/qt/jsobjects.cpp:
1676
1677 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1678
1679         Reviewed by Lars Knoll <lars@trolltech.com>.
1680
1681         Add a QWebPage::frameCreated() signal and fix DRT
1682         
1683         The removal of createFrame in QWebPage broke the re-implementation
1684         in DumpRenderTree. Instead emit a frameCreated() signal and
1685         connect to it in DumpRenderTree.
1686         
1687
1688         * DumpRenderTree/qt/DumpRenderTree.cpp:
1689         (WebCore::WebPage::WebPage):
1690         (WebCore::DumpRenderTree::dump):
1691         (WebCore::DumpRenderTree::connectFrame):
1692         * DumpRenderTree/qt/DumpRenderTree.h:
1693
1694 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1695
1696         Reviewed by Lars Knoll <lars@trolltech.com>.
1697
1698         Moved all the event handlers from QWebFrame into QWebPage.
1699         
1700         This cleans up the public API and allows us to remove the
1701         HackWebFrame hack in DumpRenderTree.
1702         
1703
1704         * DumpRenderTree/qt/jsobjects.cpp:
1705         (EventSender::mouseDown):
1706         (EventSender::mouseUp):
1707         (EventSender::mouseMoveTo):
1708
1709 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1710
1711         Reviewed by Mark.
1712
1713         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1714         to prevent the default implementation from popping up messageboxes.
1715
1716         * DumpRenderTree/qt/DumpRenderTree.cpp:
1717         (WebCore::WebPage::javaScriptConfirm):
1718         (WebCore::WebPage::javaScriptPrompt):
1719
1720 2007-11-06  Eric Seidel  <eric@webkit.org>
1721
1722         * Scripts/build-testkjs: build fix... too many $$
1723
1724 2007-11-06  Eric Seidel  <eric@webkit.org>
1725
1726         Reviewed by Mark Rowe.
1727
1728         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1729
1730 2007-11-05  Adam Roben  <aroben@apple.com>
1731
1732         Add support on Windows for WEBKIT_TESTFONTS
1733
1734         This environment variable lets you specify where the fonts to be used
1735         by DumpRenderTree reside. The Qt port is already using this, so I'm
1736         just following their lead.
1737
1738         Reviewed by Darin.
1739
1740         * DumpRenderTree/win/DumpRenderTree.cpp:
1741         (exePath): Refactored code out of initialize().
1742         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1743         DumpRenderTree.resources.
1744         (initialize): Use the new fontsPath function.
1745         (main): Use the new exePath function.
1746         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1747         variable to DRT, like Qt does.
1748
1749 2007-11-05  Mark Rowe  <mrowe@apple.com>
1750
1751         Rubber-stamped by Alp Toker.
1752
1753         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1754
1755         * GtkLauncher/main.cpp:
1756         (goToURLBarText):
1757         (main):
1758
1759 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1760
1761         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1762         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1763
1764         Reviewed by Timothy.
1765
1766         Restrict the range of nightly builds used by the bisect-builds script
1767         based on the version of Safari and the version of Mac OS X being used.
1768
1769         Mac OS X 10.4: Safari 2.0: r11976 or newer
1770         Mac OS X 10.4: Safari 3.0: r19992 or newer
1771
1772         Mac OS X 10.5: Safari 2.0: r19594 or newer
1773         Mac OS X 10.5: Safari 3.0: r25124 or newer
1774
1775         * Scripts/bisect-builds:
1776         (findMacOSXVersion): Added.
1777         (makeNightlyList): Added argument to provide version of Mac OS X.
1778         Restrict range of nightly builds based on Safari and Mac OS X versions.
1779
1780 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1781
1782         Reviewed by Maciej.
1783
1784         - This patch involves several changes, all of them were noticed that
1785         they were needed by the work being done in WebKit to get Drosera and
1786         WebKit working together on Windows.
1787         - The changes are:
1788         1) Added a debugger console for output messages.
1789         2) Drosera now listens for the WebKit server (before, the server would
1790         have to be running before Drosera was started.)
1791         3) Fixed a bug where the WebView started out as 0x0 pixels.
1792         4) Fixed a bug when there is no scope.
1793         5) Added the HTML, JS, and CSS to the project file to make them easy to
1794         find.
1795         6) Made the ServerConnection functions virtual.
1796
1797         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1798         for the WebKit server.
1799         (DebuggerClient::DebuggerClient):
1800         (DebuggerClient::~DebuggerClient):
1801         (DebuggerClient::didFinishLoadForFrame):
1802         (DebuggerClient::serverConnected):
1803         (DebuggerClient::attemptToCreateServerConnection):
1804         * Drosera/win/DebuggerClient.h: Ditto.
1805         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1806         scope.
1807         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1808         (DebuggerDocument::platformValueForScopeVariableNamed):
1809         * Drosera/win/Drosera.cpp:
1810         (_tWinMain): Added a console in debug for output messages.
1811         (Drosera::Drosera): Listen for server.
1812         (Drosera::initUI): The server now Initializes COM.
1813         (Drosera::serverConnected): Part of the listening for the server.
1814         (Drosera::attemptToCreateServerConnection): Ditto.
1815         * Drosera/win/Drosera.h: New interface for listening for the server.
1816         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1817         files to the VS project.
1818         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1819         connection.
1820         (ServerConnection::ServerConnection):
1821         (ServerConnection::attemptToCreateServerConnection):
1822         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1823         methods.
1824         (ServerConnection::serverConnected):
1825
1826 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1827
1828         Reviewed by Maciej.
1829
1830         http://bugs.webkit.org/show_bug.cgi?id=15832
1831         fast/dom/gc-10.html crashes when run alone
1832
1833         Check for !done before using objects that can be already deallocated.
1834
1835         * DumpRenderTree/mac/EditingDelegate.mm:
1836         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1837         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1838         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1839         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1840         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1841         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1842         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1843         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1844         (-[EditingDelegate webViewDidBeginEditing:]):
1845         (-[EditingDelegate webViewDidChange:]):
1846         (-[EditingDelegate webViewDidEndEditing:]):
1847         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1848         (-[EditingDelegate webViewDidChangeSelection:]):
1849         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1850         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1851         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1852         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1853         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1854         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1855         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1856         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1857         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1858         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1859         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1860         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1861         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1862         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1863         (-[FrameLoadDelegate webView:willCloseFrame:]):
1864         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1865         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1866         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1867         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1868         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1869         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1870         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1871         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1872         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1873
1874 2007-11-04  Mark Rowe  <mrowe@apple.com>
1875
1876         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1877         warnings that would otherwise be suppressed due to it being a system header.
1878
1879         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1880
1881 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1882
1883         Rubber stamped by Adam.
1884         
1885         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1886
1887         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1888
1889 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1890
1891         Sort files(...); sections of Xcode project files.
1892
1893         Rubber-stamped by Darin.
1894
1895         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1896         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1897         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1898         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1899
1900 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1901
1902         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1903
1904         Reviewed by Darin.
1905
1906         * Scripts/sort-Xcode-project-file: Added.
1907
1908 2007-11-02  Darin Adler  <darin@apple.com>
1909
1910         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1911
1912 2007-11-02  Darin Adler  <darin@apple.com>
1913
1914         Reviewed by Maciej.
1915
1916         * Scripts/run-sunspider: Pass the "--base" option through.
1917
1918         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1919         the real script do that. Default configuration to Release to match run-sunspider
1920         so we don't end up building Debug just to compare results.
1921
1922 2007-11-01  Adam Roben  <aroben@apple.com>
1923
1924         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1925
1926         Reviewed by Sam.
1927
1928         * Scripts/commit-log-editor: Show all the directories beneath the
1929         source root, instead of just the last one.
1930
1931 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1932
1933         Reviewed by Adam Roben.
1934
1935         Print out an error message when the Windows build fails
1936         and provide guidance on how to find out what went wrong.
1937
1938         * Scripts/build-webkit:
1939         * Scripts/webkitdirs.pm:
1940
1941 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1942
1943         Rubber-stamped by Adam Roben.
1944
1945         Rolled out r27326 - debug CRT seems to cause no problems after all.
1946
1947         * DumpRenderTree/win/DumpRenderTree.vcproj:
1948
1949 2007-10-31  Adam Roben  <aroben@apple.com>
1950
1951         Switch the Debug configuration to using the non-debug CRT
1952
1953         This matches WebKit.
1954
1955         Reviewed by Steve.
1956
1957         * DumpRenderTree/win/DumpRenderTree.vcproj:
1958
1959 2007-10-31  Antti Koivisto  <antti@apple.com>
1960
1961         Reviewed by bdash.
1962         
1963         Disable media tests when doing leak checking on Tiger.
1964         They crash in QuickTime (rdar://problem/5537157).
1965
1966         * Scripts/run-webkit-tests:
1967
1968 2007-10-29  Antti Koivisto  <antti@apple.com>
1969
1970         Reviewed by Maciej.
1971         
1972         Build media support by default on OSX only.
1973
1974         * Scripts/build-webkit:
1975
1976 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1977
1978         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1979         get caught by the pre-commit hooks.
1980
1981 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1982
1983         Reviewed by Adam.
1984
1985         - This is a collection of relatively unrelated changes and cleanups
1986         to Drosera to prepare it for interacting with WebKit.  A lot of these
1987         changes are just correcting mistakes, for example removing included
1988         headers that are no longer needed.
1989
1990         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1991         this will be needed by the DebuggerClient.
1992         (DebuggerDocument::server):
1993         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1994         * Drosera/win/DebuggerClient.cpp: 
1995         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1996         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1997         (DebuggerClient::createWebViewWithRequest): Added comment about its
1998         purpose. 
1999         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2000         declarations.
2001         (DebuggerClient::webViewLoaded): Moved.
2002         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2003         file, since this was the only place it was used.
2004         (cfStringToBSTR):
2005         * Drosera/win/Drosera.h: Cleaned up the includes.
2006         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2007         * Drosera/win/HelperFunctions.h: Removed.
2008
2009 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2010
2011         Reviewed by Adam.
2012
2013         - Small cleanup in the ServerConnection class.
2014
2015         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2016         and added an include.
2017         (ServerConnection::currentFrame):
2018         (ServerConnection::getCallerFrame):
2019         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2020         made a pointer into a COMPtr, and cleaned up the includes.
2021
2022 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2023
2024         Reviewed by John Sullivan.
2025         
2026         - Place the Localizable.strings file in mac or win directories
2027           if that location exists.
2028         - Also look for UI_STRING in .c files.
2029
2030         * Scripts/extract-localizable-strings:
2031
2032 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2033
2034         Reviewed by Adam.
2035
2036         - Set the eol-style to native and made all the line endings the same
2037         so that I avoid messy diffs that show eol changes.
2038
2039         * Drosera/win/ServerConnection.cpp:
2040         (ServerConnection::didParseSource):
2041         (ServerConnection::didEnterCallFrame):
2042         (ServerConnection::willExecuteStatement):
2043         (ServerConnection::willLeaveCallFrame):
2044         (ServerConnection::exceptionWasRaised):
2045
2046 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2047
2048         Reviewed by Adam.
2049
2050         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2051         functionality that could not have existed previously without the new
2052         interfaces.
2053         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2054         from a BSTR to a JSValueRef.
2055         (DebuggerDocument::platformEvaluateScript): Implemented.
2056         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2057         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2058         Implemented.
2059         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2060         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2061         * Drosera/win/ServerConnection.cpp: Added a helper function.
2062         (ServerConnection::getCallerFrame):
2063         * Drosera/win/ServerConnection.h: Added a helper function.
2064
2065 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2066
2067         updated reviewers for my previous changelog.
2068
2069 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2070         Reviewed by Maciej and Adam and Geoff.
2071
2072         - Minor mac-side improvements including moving a function to a more
2073         appropriate location, fixing a warning, and correctly checking
2074         exceptions.
2075
2076         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2077         (DebuggerDocument::willExecuteStatement):
2078         (DebuggerDocument::didEnterCallFrame):
2079         (DebuggerDocument::willLeaveCallFrame):
2080         (DebuggerDocument::windowScriptObjectAvailable):
2081         (DebuggerDocument::callFunctionOnObject):
2082         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2083         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2084         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2085         because it doesn't require the ServerConnection at all.
2086         (NSStringCreateWithJSStringRef): Made an argument const.
2087         (JSValueRefCreateWithNSString): Made an argument const.
2088         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2089         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2090         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2091         * Drosera/mac/ServerConnection.mm: Ditto.
2092         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2093
2094 2007-10-29  Sam Weinig  <sam@webkit.org>
2095
2096         Reviewed by Adam Roben.
2097
2098         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2099
2100         * DumpRenderTree/LayoutTestController.cpp:
2101         (LayoutTestController::LayoutTestController):
2102         (getGlobalFlagCallback):
2103         (setGlobalFlagCallback):
2104         (LayoutTestController::getJSClass):
2105         (LayoutTestController::staticValues):
2106         * DumpRenderTree/LayoutTestController.h:
2107         (LayoutTestController::globalFlag):
2108         (LayoutTestController::setGlobalFlag):
2109
2110 2007-10-29  Darin Adler  <darin@apple.com>
2111
2112         Reviewed by Maciej.
2113
2114         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2115         resolution instead of its default.
2116
2117 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2118
2119         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2120
2121         Reviewed by Mark Rowe.
2122
2123         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2124         was successfully resolved, but this would not show any status because the change had
2125         already been cached in the index using "git add".  The solution is to add an optional
2126         second argument to showStatus() which adds the "--cached" switch to the command.
2127
2128         * Scripts/resolve-ChangeLogs:
2129         (showStatus):
2130
2131 2007-10-28  Eric Seidel  <eric@webkit.org>
2132
2133         Reviewed by Maciej and Geoff, in unison.
2134
2135         * Scripts/run-webkit-tests: remove broken --svg option
2136
2137 2007-10-28  Darin Adler  <darin@apple.com>
2138
2139         Reviewed by Adam.
2140
2141         * Scripts/run-sunspider: Default to "Release" configuration rather than
2142         defaulting to the last configuration used as other scripts do. This can
2143         still be overriden on the command line with "--debug" if there's some
2144         reason to do so. Also fix a typo.
2145
2146         * Scripts/sunspider-compare-results: Fix a typo.
2147
2148 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2149
2150         Reviewed by Adam.
2151
2152         - Implemented the WebScriptDebugListener functions now that the
2153         WebScriptDebugServer exists
2154
2155         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2156         functions.
2157         (ServerConnection::currentFrame):
2158         (ServerConnection::didLoadMainResourceForDataSource):
2159         (ServerConnection::didParseSource):
2160         (ServerConnection::failedToParseSource):
2161         (ServerConnection::didEnterCallFrame):
2162         (ServerConnection::willExecuteStatement):
2163         (ServerConnection::willLeaveCallFrame):
2164         (ServerConnection::exceptionWasRaised):
2165         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2166         members arguments list.
2167
2168 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2169
2170         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2171         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2172
2173         Reviewed by Darin.
2174
2175         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2176         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2177         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2178         file.  Note that it may also be used as a stand-alone script.
2179
2180         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2181         * Scripts/resolve-ChangeLogs: Added.
2182         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2183
2184 2007-10-26  Mark Rowe  <mrowe@apple.com>
2185
2186         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2187         to the Qt port on the assumption that it was an implementation of the cross-platform
2188         LayoutTestController class.  It is not, so it did not need to be changed.
2189
2190         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2191
2192 2007-10-25  Mark Rowe  <mrowe@apple.com>
2193
2194         Reviewed by Maciej.
2195
2196         Fix builds with code coverage enabled.
2197
2198         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2199
2200 2007-10-25  Darin Adler  <darin@apple.com>
2201
2202         Reviewed by Mark Rowe.
2203
2204         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2205         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2206
2207 2007-10-25  Stephanie  <slewis@apple.com>
2208
2209         build Fix
2210
2211         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2212
2213 2007-10-25  Stephanie  <slewis@apple.com>
2214
2215         Reviewed by Mark Rowe, Adam Roben.
2216
2217         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2218
2219         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2220
2221 2007-10-25  Alice Liu  <alice.liu@apple.com>
2222
2223         Reviewed by Adam.
2224
2225         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2226
2227         Moving destructor into platform-specific files
2228         * DumpRenderTree/LayoutTestController.cpp:
2229         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2230         (LayoutTestController::~LayoutTestController):
2231         * DumpRenderTree/qt/jsobjects.cpp:
2232         (LayoutTestController::~LayoutTestController):
2233
2234         LayoutTestController wasn't being destroyed
2235         * DumpRenderTree/win/DumpRenderTree.cpp:
2236         (runTest):
2237
2238         Added declspec
2239         * DumpRenderTree/win/EditingDelegate.h:
2240
2241         Reset certain values on the webview (or related delegate) that might 
2242         have changed while running a test
2243         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2244         (LayoutTestController::~LayoutTestController):
2245
2246 2007-10-25  Adam Roben  <aroben@apple.com>
2247
2248         Make sunspider-compare-results work with relative paths
2249
2250         Reviewed by Sam.
2251
2252         * Scripts/sunspider-compare-results: Convert arguments to absolute
2253         paths before we chdir.
2254
2255 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2256
2257         Reviewed by Sam.
2258
2259         - Implemented server calls now the WebScriptDebugServer exists.
2260         - Also removed no longer needed call to initialize CG.
2261
2262         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2263         automatically now.
2264         (_tWinMain):
2265         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2266         (ServerConnection::ServerConnection):
2267         (ServerConnection::~ServerConnection):
2268         (ServerConnection::pause):
2269         (ServerConnection::resume):
2270         (ServerConnection::stepInto):
2271         (ServerConnection::applicationTerminating):
2272         (ServerConnection::serverConnectionDidDie):
2273         * Drosera/win/ServerConnection.h: Now uses the COM class.
2274
2275 2007-10-24  George Staikos  <staikos@kde.org>
2276
2277         Unbreak Qt build.
2278
2279         * Scripts/build-webkit:
2280
2281 2007-10-24  Adam Roben  <aroben@apple.com>
2282
2283         Remove now-unnecessary call to InitializeCoreGraphics
2284
2285         WebKit takes care of this now.
2286
2287         Reviewed by Ada.
2288
2289         * DumpRenderTree/win/DumpRenderTree.cpp:
2290         (initialize):
2291
2292 2007-10-24  Adam Roben  <aroben@apple.com>
2293
2294         Use WebTextRenderer in DRT
2295
2296         Reviewed by Ada.
2297
2298         * DumpRenderTree/win/DumpRenderTree.cpp:
2299         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2300
2301 2007-10-24  Sven Herzberg  <sven@imendio.com>
2302
2303         Reviewed by Mark Rowe.
2304
2305         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2306         Bug 15614: [GTK] qmake based backends don't build on OS X
2307
2308         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2309         GTK backend on a Mac
2310         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2311         isDarwin() to make it reusable in other places (like the workaround-
2312         for-prebuilt-qmake in build-webkit)
2313
2314 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2315
2316         Refurbish update-webkit script.
2317
2318         Reviewed by Adam.
2319
2320         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2321         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2322         multi-argument version of system() for flexibility and security.  Check for existence
2323         of Internal directory using -d test instead of -x.
2324
2325 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2326
2327         Minor clean-up of prepare-ChangeLog script.
2328
2329         Reviewed by Adam.
2330
2331         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2332         of a string.  Use multi-argument versions of open() and system() for flexibility and
2333         security.
2334
2335 2007-10-24  Alice Liu  <alice.liu@apple.com>
2336
2337         Reviewed by Oliver.
2338
2339         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2340
2341         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2342         replay the saved events when we're still processing the mousedown that starts the drag
2343         * DumpRenderTree/win/EventSender.cpp:
2344         (doMouseMove):
2345         * DumpRenderTree/win/UIDelegate.cpp:
2346         (UIDelegate::doDragDrop):
2347
2348 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2349
2350         Reviewed by Sam, Steve and Darin.
2351
2352         - Stubbed out the WebScriptDebugListener functionality in the Server
2353         Connection class to prepare it for receiving those callbacks.
2354         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2355         and the ServerConnection to not need to be initialized with a server
2356         name, since that is not the way we connect to the WebKit server. 
2357
2358         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2359         no exception.  Now it only loggs when there is an exception
2360         (DebuggerDocument::willExecuteStatement):
2361         (DebuggerDocument::didEnterCallFrame):
2362         (DebuggerDocument::willLeaveCallFrame):
2363         (DebuggerDocument::windowScriptObjectAvailable):
2364         (DebuggerDocument::callFunctionOnObject):
2365         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2366         to be instantiated with a server's name.
2367         (DebuggerClient::DebuggerClient):
2368         (DebuggerClient::didFinishLoadForFrame):
2369         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2370         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2371         a server name.
2372         (Drosera::init):
2373         (Drosera::initServer):
2374         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2375         instantiated with a server's name.
2376         * Drosera/win/ServerConnection.cpp: 
2377         (ServerConnection::ServerConnection): No longer needs a server name
2378         (ServerConnection::~ServerConnection): Only release the global context
2379         if there is one.
2380         (ServerConnection::serverConnectionDidDie): Stub for
2381         IWebScriptDebugListener
2382         (ServerConnection::QueryInterface): ditto
2383         (ServerConnection::AddRef): ditto
2384         (ServerConnection::Release): ditto
2385         (ServerConnection::didLoadMainResourceForDataSource): ditto
2386         (ServerConnection::didParseSource): ditto
2387         (ServerConnection::failedToParseSource): ditto
2388         (ServerConnection::didEnterCallFrame): ditto
2389         (ServerConnection::willExecuteStatement): ditto
2390         (ServerConnection::willLeaveCallFrame): ditto
2391         (ServerConnection::exceptionWasRaised): ditto
2392         * Drosera/win/ServerConnection.h: Stubbed out the
2393         IWebScriptDebugListener functions, and this class no longer needs to be
2394         instantiated with a server name.
2395
2396 2007-10-24  Lars Knoll  <lars@trolltech.com>
2397
2398         Reviewed by Simon.
2399
2400         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2401
2402         * DumpRenderTree/qt/jsobjects.h:
2403
2404 2007-10-24  Lars Knoll  <lars@trolltech.com>
2405
2406         Reviewed by Simon.
2407
2408         add another command.
2409
2410         * DumpRenderTree/qt/jsobjects.cpp:
2411         (TextInputController::doCommand):
2412
2413 2007-10-24  Lars Knoll  <lars@trolltech.com>
2414
2415         Reviewed by Simon.
2416
2417         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2418
2419         * DumpRenderTree/qt/jsobjects.cpp:
2420         (EventSender::keyDown):
2421         * DumpRenderTree/qt/jsobjects.h:
2422
2423 2007-10-24  Lars Knoll  <lars@trolltech.com>
2424
2425         Reviewed by Simon.
2426
2427         implement eventSender.keyDown().
2428
2429         * DumpRenderTree/qt/jsobjects.cpp:
2430         (EventSender::keyDown):
2431
2432 2007-10-24  Lars Knoll  <lars@trolltech.com>
2433
2434         Reviewed by Simon.
2435
2436         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2437
2438         * DumpRenderTree/qt/DumpRenderTree.cpp:
2439         (WebCore::DumpRenderTree::DumpRenderTree):
2440         (WebCore::DumpRenderTree::initJSObjects):
2441         * DumpRenderTree/qt/jsobjects.cpp:
2442         (TextInputController::doCommand):
2443
2444 2007-10-24  Lars Knoll  <lars@trolltech.com>
2445
2446         Reviewed by Simon.
2447
2448         first bit of implementation for the textinputcontroller.
2449
2450         * DumpRenderTree/qt/DumpRenderTree.cpp:
2451         (WebCore::DumpRenderTree::DumpRenderTree):
2452         * DumpRenderTree/qt/DumpRenderTree.h:
2453         * DumpRenderTree/qt/jsobjects.cpp:
2454         (TextInputController::TextInputController):
2455         (TextInputController::doCommand):
2456         * DumpRenderTree/qt/jsobjects.h:
2457
2458 2007-10-24  Lars Knoll  <lars@trolltech.com>
2459
2460         Reviewed by Simon.
2461
2462         make the man webpage believe it has focus, so the editing tests work correctly.
2463
2464         * DumpRenderTree/qt/DumpRenderTree.cpp:
2465         (WebCore::DumpRenderTree::DumpRenderTree):
2466
2467 2007-10-24  Lars Knoll  <lars@trolltech.com>
2468
2469         Reviewed by Simon.
2470
2471         implement layoutTestController.dumpEditingCallbacks() correctly.
2472
2473         * DumpRenderTree/qt/DumpRenderTree.cpp:
2474         (WebCore::DumpRenderTree::DumpRenderTree):
2475         * DumpRenderTree/qt/jsobjects.cpp:
2476         (LayoutTestController::reset):
2477         (LayoutTestController::dumpEditingCallbacks):
2478
2479 2007-10-24  Lars Knoll  <lars@trolltech.com>
2480
2481         Reviewed by Simon.
2482
2483         Implement support for testing editing.
2484
2485         * DumpRenderTree/qt/DumpRenderTree.cpp:
2486         (WebCore::DumpRenderTree::DumpRenderTree):
2487
2488 2007-10-23  Sam Weinig  <sam@webkit.org>
2489
2490         Check for null BSTR that can be passed to the UIDelegate methods
2491         from javascript null and undefined.  Fixes a failing test case on
2492         Windows (fast/dom/Window/alert-undefined.html)
2493
2494         Reviewed by Eric Seidel.
2495
2496         * DumpRenderTree/win/UIDelegate.cpp:
2497         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2498         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2499         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2500         (UIDelegate::webViewAddMessageToConsole):
2501
2502 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2503
2504         Reviewed by Darin.
2505         
2506         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2507
2508         * Scripts/build-testkjs:
2509
2510 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2511
2512         Reviewed by Darin.
2513
2514         - add wrapper that finds the right copy of testkjs
2515         
2516         * Scripts/sunspider-compare-results: Added.
2517
2518 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2519
2520         Reviewed by Sam.
2521
2522         - After talking with Steve I now see that the WebKit server must be
2523         running for DCOM to create the distributed objects, which makes sense
2524         and currently WebKit only allows one instance to be running at a time
2525         which avoids accidentally connecting to the wrong server
2526         - In light of this I have removed the code for the attach box and
2527         NotificationServer and known server names, since they are all extranious
2528         now.
2529
2530         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2531         names.
2532         (_tWinMain): Uses init instead of initUI.
2533         (droseraWndProc): No longer creats an attach dialog box.
2534         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2535         it's not manditory to call init before doing COM stuff.
2536         (Drosera::init): calls initUI and will call attach when the
2537         functionality exists. 
2538         (Drosera::initUI): Has changed very little.
2539         (Drosera::attach): Changed the signature to reflect that we no longer
2540         need the dictionary of known server names.
2541         * Drosera/win/Drosera.h: Removed notification classes and known server
2542         names.  Also renamed and moved some functions.
2543         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2544         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2545         headers to the resources folder. 
2546         * Drosera/win/resource.h: Removed the Attach box.
2547
2548 2007-10-22  Adam Roben  <aroben@apple.com>
2549
2550         Windows build fix
2551
2552         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2553
2554 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2555
2556         - Removed a leak that was fixed.
2557
2558         * Scripts/run-webkit-tests:
2559
2560 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2561
2562         Reviewed by Darin.
2563
2564         - Changed the Client so that the DebuggerDocument now own the
2565         ServerConnection.  This simplifies ownership and cleanup. 
2566
2567         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2568         ServerConnection.
2569         (DebuggerClient::initWithServerName):
2570         (DebuggerClient::didFinishLoadForFrame):
2571         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2572         ServerConnection.
2573         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2574         until after we have a server which we are attached to.
2575         (Drosera::initUI):
2576         (Drosera::attach):
2577         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2578         out previously.
2579
2580 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2581
2582         Reviewed by Nikolas.
2583
2584         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2585
2586         * Scripts/run-javascriptcore-tests:
2587
2588 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2589
2590         Reviewed by Nikolas.
2591
2592         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2593
2594         * Scripts/build-drosera:
2595         * Scripts/build-dumprendertree:
2596         * Scripts/build-testkjs:
2597         * Scripts/build-webkit:
2598         * Scripts/run-javascriptcore-tests:
2599         * Scripts/run-sunspider:
2600         * Scripts/run-webkit-tests:
2601         * Scripts/webkitdirs.pm:
2602
2603 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2604
2605         Reviewed by Mark Rowe.
2606         
2607         Fix for local database support after r26879
2608         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2609
2610         * Scripts/build-webkit:
2611
2612 2007-10-22  Holger Freyther  <zecke@selfish.org>
2613
2614         Reviewed by Simon Hausmann <hausmann@kde.org>.
2615
2616         - Do not build testkjs as an application bundle. This is
2617         needed for run-javascriptcore-tests on OSX.
2618         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2619         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2620         as we do not have -rpath on OSX.
2621
2622         * DumpRenderTree/qt/DumpRenderTree.pro:
2623         * Scripts/run-webkit-tests:
2624
2625 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2626
2627         Reviewed by aroben.
2628
2629         Fix support for Signed-off-by detection in prepare-ChangeLog
2630         --git-commit. The Signed-off-by tag does not appear in the header
2631         but usually at the end.
2632
2633         * Scripts/prepare-ChangeLog:
2634
2635 2007-10-21  Mark Rowe  <mrowe@apple.com>
2636
2637         Reviewed by Eric.
2638
2639         Fix run-javascriptcore-tests for Gtk.
2640
2641         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2642
2643 2007-10-20  Eric Seidel  <eric@webkit.org>
2644
2645         Reviewed by aroben.
2646
2647         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2648
2649 2007-10-20  Eric Seidel  <eric@webkit.org>
2650
2651         Reviewed by darin.
2652         
2653         Add improved argument handling to run-sunspider, including
2654         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2655         Also re-factor code into subroutines
2656
2657         * Scripts/build-dumprendertree: removed bogus comments
2658         * Scripts/build-testkjs: Added.
2659         * Scripts/run-javascriptcore-tests: use build-testkjs
2660         * Scripts/run-sunspider: improved argument handling, abstraction
2661         * Scripts/run-webkit-tests: improved abstraction
2662
2663 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2664
2665         Not reviewed, Windows build fix.
2666
2667         * DumpRenderTree/win/EventSender.cpp:
2668         (keyDownCallback):
2669
2670 2007-10-20  Darin Adler  <darin@apple.com>
2671
2672         Reviewed by Tim Hatcher.
2673
2674         - http://bugs.webkit.org/show_bug.cgi?id=15544
2675           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2676           not rely on Apple-specific key codes
2677
2678         * DumpRenderTree/mac/EventSendingController.mm:
2679         (-[EventSendingController keyDown:withModifiers:]):
2680         Added named key "rightArrow". Later we could have a whole table of these.
2681         Also tweaked modifiers code a little.
2682
2683         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2684
2685 2007-10-19  Darin Adler  <darin@apple.com>
2686
2687         Reviewed by Eric.
2688
2689         - http://bugs.webkit.org/show_bug.cgi?id=15566
2690           possible fix for leak seen in DumpRenderTree
2691
2692         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2693         Delete the item if it's not put on the queue, since the caller has
2694         no way of knowing that. Would be better to have the parameter type
2695         be auto_ptr to express the fact that we take ownership.
2696
2697         - unrelated change
2698
2699         * Drosera/mac/main.m: Add missing include.
2700
2701 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2702
2703         Reviewed by Adam.
2704
2705         - This change should be identical but for some reason was not working
2706         on my machine.
2707
2708         * Scripts/prepare-ChangeLog:
2709
2710 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2711
2712         Reviewed by Oliver and Tim.
2713
2714         - Made use of RetainPtr to avoid retain and release issues and moved the
2715         log function to DebuggerDocumentPlatform, which seems to be a more
2716         logical place for it to live.
2717         - Also moved knownServers from the ServerConnection to
2718         DebuggerApplication to match the Windows code and because it makes sense
2719         that a connection knows its own server but not all of them.
2720
2721         * Drosera/mac/DebuggerClient.h: Moved the log function to
2722           DebuggerDocumentPlatform.
2723         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2724           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2725           call for the server name up from the ServerConnection class.
2726         (-[DebuggerClient dealloc]):
2727         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2728           for the server name up from the ServerConnection.
2729         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2730         (DebuggerDocument::platformPause):
2731         (DebuggerDocument::platformResume):
2732         (DebuggerDocument::platformStepInto):
2733         (DebuggerDocument::platformEvaluateScript):
2734         (DebuggerDocument::getPlatformCurrentFunctionStack):
2735         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2736         (DebuggerDocument::platformValueForScopeVariableNamed):
2737         (DebuggerDocument::platformLog): Log directly from here. No need to call
2738           DebuggerClient.
2739         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2740           way I see it, a ServerConnection should only know about its connection
2741           and the group of all possible servers should be kept by the
2742           application.
2743         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2744           currentServerName, it makes sense that the connection should know that
2745           name.
2746         (-[ServerConnection currentServerName]):
2747
2748 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2749
2750         Reviewed by Adam.
2751
2752         - Integrated changes from mac drosera.  Recently I've encapsulated
2753         out the server connection object from the rest of Drosera because
2754         it is very platform dependent right now and RPC is not implemented on
2755         windows.  This functionality, of communicating with the WebKit server
2756         is the next area I will be focusing on in Windows.
2757
2758         - Other changes and cleanup were made to organize the code and add notes
2759         on which parts still need work.  Also some mac code is added and
2760         commented out, to act as pseudocode for the logic of those parts.
2761
2762         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2763           pointer.
2764         * Drosera/config.h: Added whitespace.
2765         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2766           these files got moved into Drosera.h/cpp
2767         * Drosera/win/DebuggerApplication.h: Removed.
2768         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2769           happened here to better match the logic flow of the same code on the 
2770           mac side and to use the new ServerConnection class.
2771         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2772         (DebuggerClient::initWithServerName): Initializer that will set up the
2773           class to use a ServerConnection object.  This was necessary so I could
2774           create a DebuggerClient without having to initilaize it at
2775           construction.
2776         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2777           will be the UIDelegate and FrameLoadDelegate.
2778         (DebuggerClient::AddRef): For IUnknown.
2779         (DebuggerClient::Release): For IUnknown.
2780         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2781           this still needs to set the global context of the server, but
2782           IWebFrame does not have an accessor for the global context yet. 
2783         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2784           this is a pass through for the same function in the document.
2785         (DebuggerClient::didReceiveTitle): Unimplemented part of
2786           FrameLoadDelegate this would change the title of the window.
2787         (DebuggerClient::createWebViewWithRequest): Part of the
2788           FrameLoadDelegate.  This is about new windows via Window.open() and
2789           how their delegates are set.
2790         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2791           UIDelegate.  Just a debug function for printing messages.
2792         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2793           because the Client should be the UIDelegate and FrameLoadDelegate
2794           to match the delegates on mac.
2795         (DebuggerClient::webViewLoaded): Added accessor method.
2796         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2797           forgotten to add this file before.  This is where the platform
2798           dependent versions of the Documents functions live. Most of these are
2799           unimplemented because some piece of functionality does not exist on
2800           Windows yet.
2801         (DebuggerDocument::platformPause):
2802         (DebuggerDocument::platformResume):
2803         (DebuggerDocument::platformStepInto):
2804         (DebuggerDocument::platformEvaluateScript):
2805         (DebuggerDocument::getPlatformCurrentFunctionStack):
2806         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2807         (DebuggerDocument::platformValueForScopeVariableNamed):
2808         (DebuggerDocument::platformLog):
2809         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2810           responsibilities becaue they belong in the Client. Also I laid the
2811           groundwork for attaching Drosera to a WebKit process
2812         (attachWndProc): Now if a server is selected the Client becomes it's
2813           delegate.
2814         (Drosera::Drosera): Added the construction of the Client and dictionary
2815           of server names. 
2816         (Drosera::initUI): This is no longer the delegates, the Client is.
2817         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2818           state. 
2819         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2820           notification registration when it's possible to implement.
2821         (Drosera::serverLoaded): Ditto
2822         (Drosera::serverUnloaded): Ditto
2823         (Drosera::attach): Attach Drosera to the WebKit server.
2824         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2825         (Drosera::getInst): 
2826         (Drosera::setInst):
2827         (Drosera::knownServers):
2828         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2829           and added the ServerConnection.
2830         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2831         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2832           Most of the functions are completely unimlemented because they cannot
2833           connect with the WebKit server, because one does not exist on Windows
2834           yet.
2835         (ServerConnection::initWithServerName): 
2836         (ServerConnection::~ServerConnection):
2837         (ServerConnection::setGlobalContext):
2838         (ServerConnection::pause):
2839         (ServerConnection::resume):
2840         (ServerConnection::stepInto):
2841         (ServerConnection::switchToServerNamed):
2842         (ServerConnection::applicationTerminating):
2843         (ServerConnection::serverConnectionDidDie):
2844         (ServerConnection::currentFrame):
2845         * Drosera/win/ServerConnection.h: Added. Ditto.
2846         (ServerConnection::ServerConnection):
2847
2848 2007-10-19  Alice Liu  <alice.liu@apple.com>
2849
2850         Reviewed by Darin.
2851
2852         Fix for these broken layout tests on Windows:
2853         
2854         fast/forms/focus-selection-input.html
2855         fast/forms/focus-selection-textarea.html
2856         fast/forms/select-accesskey.html
2857         
2858         * DumpRenderTree/win/EventSender.cpp:
2859         (keyDownCallback):
2860         correct the VK code for alt key.
2861         
2862 2007-10-19  Eric Seidel  <eric@webkit.org>
2863
2864         Reviewed by Mark Rowe.
2865         
2866         Make the GtkLauncher code slightly more readable.
2867
2868         * GtkLauncher/main.cpp:
2869         (setupMainMenu): Added.
2870         (setupMainWindowUI): Added.
2871         (main):
2872
2873 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2874
2875         Rubber stamped by Adam.
2876         
2877         - don't delay-load WebKit in DumpRenderTree.
2878
2879         * DumpRenderTree/win/DumpRenderTree.vcproj:
2880
2881 2007-10-18  Dan Bernstein  <mitz@apple.com>
2882
2883         Reviewed by Adam Roben.
2884
2885         - fix <rdar://problem/5313523>
2886         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2887
2888         * DumpRenderTree/mac/DumpRenderTree.mm:
2889         (dump): Changed to use _responseMIMEType.
2890
2891 2007-10-17  Adam Roben  <aroben@apple.com>
2892
2893         Make it possible to have Windows-specific tests and results
2894
2895         When searching for tests to run and the Skipped file, we will only
2896         look in platform/win and the cross-platform directory. When looking
2897         for expected results, we will look in platform/win, then
2898         platform/mac-leopard, then platform/mac, then finally the
2899         cross-platform directory.
2900
2901         Reviewed by Sam.
2902
2903         * Scripts/run-webkit-tests:
2904         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2905         searching in the cross-platform directory.
2906         (sub buildPlatformHierarchy): Removed some unneeded calls to
2907         dirname/basename.
2908
2909 2007-10-17  Adam Roben  <aroben@apple.com>
2910
2911         Add back the call to register WebKit that we had before WebKitInitializer existed
2912
2913         This is needed to ensure that the right WebKit is used when
2914         instantiating COM objects.
2915
2916         Reviewed by Oliver.
2917
2918         * DumpRenderTree/win/debug_internal.vsprops: Define
2919         DEBUG_WEBKIT_HAS_SUFFIX.
2920         * DumpRenderTree/win/DumpRenderTree.cpp:
2921         (initialize):
2922
2923 2007-10-17  Adam Roben  <aroben@apple.com>
2924
2925         Import File::Basename in webkitdirs since we use it
2926
2927         * Scripts/webkitdirs.pm:
2928
2929 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2930
2931         - Updated the tiger leaks list to make the internal bots green.
2932
2933         * Scripts/run-webkit-tests:
2934
2935 2007-10-17  Adam Roben  <aroben@apple.com>
2936
2937         Build fix for VC++ Express
2938
2939         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2940         and ole32.lib.
2941
2942 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2943
2944         Reviewed by Sam.
2945
2946         - Minor mac improvements based on observations I made while implementing the
2947         Windows code.
2948
2949         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2950         then hand it to the Client who will retain it, it should just be the client who
2951         creates and owns the server.
2952         (-[DebuggerApplication attach:]):
2953         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2954         * Drosera/mac/DebuggerClient.mm: Creates the server.
2955         (-[DebuggerClient initWithServerName:]):
2956         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2957         can instead forward declare what it needs.
2958
2959 2007-10-16  Darin Adler  <darin@apple.com>
2960
2961         Reviewed by Geoff Garen.
2962
2963         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2964         want to turn failing tests into platform-specific test results. Also did a
2965         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2966         would take the type of results into account only some of the time.
2967
2968 2007-10-16  Adam Roben  <aroben@apple.com>
2969
2970         Add a new nightly launcher script for Windows
2971
2972         This new script is for versions of Safari that don't delay-load
2973         WebKit. I had to make FindSafari be able to print out the nightly
2974         launcher script on stdout because Windows shell scripts can't capture
2975         the output from a command into an environment variable.
2976
2977         Reviewed by Steve.
2978
2979         * FindSafari/FindSafari.cpp:
2980         (_tmain): Added /printSafariLauncher option.
2981         * Scripts/run-webkit-nightly.cmd: Added.
2982
2983 2007-10-16  Adam Roben  <aroben@apple.com>
2984
2985         Replace WebKitInitializer with FindSafari
2986
2987         We now rely on setting the PATH environment variable to tell Windows
2988         where to find WebKit and its dependencies (similar to
2989         DYLD_FRAMEWORK_PATH on Mac).
2990
2991         This change also make DumpRenderTree no longer delay-load WebKit.
2992
2993         Reviewed by Sam.
2994
2995         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2996         FindSafari.
2997         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2998         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2999         WebKitInitializer, don't delay-load WebKit.
3000         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3001         * Scripts/run-webkit-tests: Ditto.
3002         * Scripts/webkitdirs.pm:
3003         (sub setPathForRunningWebKitApp): Added.
3004         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3005         * WebKitInitializer/WebKitInitializer.h: Removed.
3006         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3007         * WebKitInitializer/debug.vsprops: Removed.
3008         * WebKitInitializer/debug_internal.vsprops: Removed.
3009         * WebKitInitializer/release.vsprops: Removed.
3010
3011 2007-10-16  Adam Roben  <aroben@apple.com>
3012
3013         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3014
3015         http://bugs.webkit.org/show_bug.cgi?id=15532
3016
3017         FindSafari simply prints the location of an installed Safari.exe on
3018         stdout.
3019
3020         Reviewed by Darin.
3021
3022         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3023         (getStringValue):
3024         (getWebViewCLSID):
3025         (getInstalledWebKitDirectory):
3026         (_tmain):
3027         * FindSafari/FindSafari.vcproj: Added.
3028         * Scripts/webkitdirs.pm:
3029         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3030
3031 2007-10-16  Adam Roben  <aroben@apple.com>
3032
3033         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3034
3035         Reviewed by Kevin McCullough.
3036
3037         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3038         when referring to WebKit.dll.
3039         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3040         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3041         * DumpRenderTree/win/release.vsprops: Ditto.
3042         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3043         never have a _debug suffix on WebKit.dll.
3044         * WebKitInitializer/WebKitInitializer.cpp:
3045         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3046         specified.
3047         * WebKitInitializer/debug_internal.vsprops: Added
3048         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3049
3050 2007-10-16  Darin Adler  <darin@apple.com>
3051
3052         Reviewed by Adele.
3053
3054         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3055         Remove now-unneeded control/alt key hack; the tests have been updated.
3056
3057 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3058
3059         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3060         one of the leaks was fixed between that revision and the bot's previous version of
3061         leopard.
3062
3063         * Scripts/run-webkit-tests:
3064
3065 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3066
3067         Reviewed by Tim.
3068
3069         - I encapsulated out the server connecton functionality because it is a specific part
3070         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3071         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3072         Windows.  So the majority of this patch is moving preexisting functionality.
3073
3074         - Also I removed the prefix header and changed to use config.h because it is more
3075         standard on how we use config.h in windows and it didn't make much sense to keep
3076         the prefix header and the config.h
3077
3078         * Drosera/DebuggerDocument.cpp:
3079         (DebuggerDocument::DebuggerDocument):
3080         * Drosera/DebuggerDocument.h:
3081         * Drosera/config.h:
3082         * Drosera/mac/DebuggerApplication.mm:
3083         (-[DebuggerApplication attach:]):
3084         * Drosera/mac/DebuggerClient.h:
3085         * Drosera/mac/DebuggerClient.mm:
3086         (-[DebuggerClient initWithServerConnection:]):
3087         (-[DebuggerClient dealloc]):
3088         (-[DebuggerClient windowDidLoad]):
3089         (-[DebuggerClient windowWillClose:]):
3090         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3091         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3092         * Drosera/mac/DebuggerDocumentPlatform.mm:
3093         (DebuggerDocument::platformPause):
3094         (DebuggerDocument::platformResume):
3095         (DebuggerDocument::platformStepInto):
3096         (DebuggerDocument::platformEvaluateScript):
3097         (DebuggerDocument::getPlatformCurrentFunctionStack):
3098         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3099         (DebuggerDocument::platformValueForScopeVariableNamed):
3100         (DebuggerDocument::platformLog):
3101         * Drosera/mac/Drosera.pch: Removed.
3102         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3103         * Drosera/mac/ServerConnection.h: Added.
3104         * Drosera/mac/ServerConnection.mm: Added.
3105         (-[ServerConnection initWithServerName:]):
3106         (-[ServerConnection dealloc]):
3107         (-[ServerConnection setGlobalContext:]):
3108         (-[ServerConnection pause]):
3109         (-[ServerConnection resume]):
3110         (-[ServerConnection stepInto]):
3111         (-[ServerConnection switchToServerNamed:]):
3112         (-[ServerConnection applicationTerminating:]):
3113         (-[ServerConnection serverConnectionDidDie:]):
3114         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3115         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3116         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3117         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3118         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3119         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3120         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3121         (-[ServerConnection currentFrame]):
3122         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3123         (-[ServerConnection knownServers]):
3124
3125 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3126
3127         Reviewed by Eric.
3128
3129         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3130           Script to automatically search nightly builds for regressions (bisect-builds)
3131
3132         * Scripts/bisect-builds: Added.
3133
3134 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3135
3136         Reviewed by Darin.
3137
3138         - New JavaScript benchmark
3139         http://bugs.webkit.org/show_bug.cgi?id=15515
3140
3141         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3142         current development or release build of JavaScriptCore.
3143
3144 2007-10-15  Mark Rowe  <mrowe@apple.com>
3145
3146         Reviewed by Sam.
3147
3148         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3149
3150         * Scripts/webkitdirs.pm:
3151         - Change checkArgv to remove the options from @ARGV to prevent
3152         them from interfering with further option processing.
3153         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3154         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3155         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3156         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3157
3158 2007-10-15  Darin Adler  <darin@apple.com>
3159
3160         Reviewed by Sam.
3161
3162         - added logging of window.prompt and window.confirm
3163
3164         * DumpRenderTree/mac/UIDelegate.mm:
3165         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3166         Implement the recommended delegate rather than the deprecated one.
3167         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3168         Added.
3169         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3170         Added.
3171
3172         * DumpRenderTree/win/UIDelegate.h:
3173         * DumpRenderTree/win/UIDelegate.cpp:
3174         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3175         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3176         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3177         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3178
3179 2007-10-15  Alice Liu  <alice.liu@apple.com>
3180
3181         Reviewed by Sam Weinig.
3182
3183         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3184
3185         * DumpRenderTree/win/DumpRenderTree.cpp:
3186         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3187         (main): allocate the global policy delegate for DRT's custom use
3188         * DumpRenderTree/win/DumpRenderTree.vcproj:
3189         Adding files to project
3190         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3191         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3192         (LayoutTestController::setCustomPolicyDelegate):
3193         set the webview's policy delegate to DRT's custom one if the test requests it.
3194         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3195         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3196         (PolicyDelegate::PolicyDelegate):
3197         (PolicyDelegate::QueryInterface):
3198         (PolicyDelegate::AddRef):
3199         (PolicyDelegate::Release):
3200         (PolicyDelegate::decidePolicyForNavigationAction):
3201         * DumpRenderTree/win/PolicyDelegate.h: Added.
3202         (PolicyDelegate::decidePolicyForNewWindowAction):
3203         (PolicyDelegate::decidePolicyForMIMEType):
3204         (PolicyDelegate::unableToImplementPolicyWithError):
3205
3206 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3207
3208         Reviewed by Mark.
3209
3210         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3211         when querying for QMAKE_MKSPECS.
3212
3213 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3214
3215         Reviewed by Adam Roben.
3216         
3217         Fix run-webkit-tests is too greedy calculating platform hierarchy
3218         http://bugs.webkit.org/show_bug.cgi?id=15465
3219         
3220         Fix run-webkit-tests being too greedy in trying to split the platform name up
3221         causing it to try and find tests in every directory above the first "-" in the
3222         path to the LayoutTests
3223
3224         * Scripts/run-webkit-tests:
3225
3226 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3227
3228         Reviewed by Darin.
3229
3230         http://bugs.webkit.org/show_bug.cgi?id=15006
3231         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3232         to reduce code duplication.
3233
3234         * Scripts/build-webkit:
3235         * Scripts/webkitdirs.pm:
3236         buildQMakeProject() renamed to buildQMakeQtProject().
3237         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3238         unused $colorize has been removed.
3239
3240 === Start merge of feature-branch 2007-10-12 ===
3241
3242 2007-10-08  Eric Seidel  <eric@webkit.org>
3243
3244         Reviewed by Mark Rowe.
3245
3246         * Scripts/build-webkit: add --help, remove unused --color
3247
3248 2007-10-07  Eric Seidel  <eric@webkit.org>
3249
3250         Reviewed by darin.
3251
3252         * Drosera/mac/DebuggerDocumentPlatform.mm:
3253         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3254
3255 2007-10-03  Rob Buis  <buis@kde.org>
3256
3257         Reviewed by Olliej.
3258
3259         Adapt to changed location of Ahem font.
3260
3261         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3262
3263 2007-10-02  Eric Seidel  <eric@webkit.org>
3264
3265         Reviewed by Adam Roben.
3266         
3267         Make pixel tests more useful!
3268         Finally fix the image diff 0.00% mystery problem
3269         Highlight any image differences in the image diff.
3270         Add a link from image diffs back to original test file.
3271
3272         * DumpRenderTree/mac/ImageDiff.m:
3273         (compareImages): highlight any differences
3274         (computePercentageDifferent): round to two decimal places
3275         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3276
3277 2007-10-02  Eric Seidel  <eric@webkit.org>
3278
3279         Reviewed by Alexey Proskuryakov.
3280
3281         * Scripts/run-webkit-tests: print the % image difference on main results page
3282
3283 2007-10-02  Mark Rowe  <mrowe@apple.com>
3284
3285         Reviewed by Oliver.
3286
3287         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3288
3289         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3290         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3291
3292 2007-10-01  Mark Rowe  <mrowe@apple.com>
3293
3294         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3295
3296 2007-09-25  Eric Seidel  <eric@webkit.org>
3297
3298         Reviewed by Mark Rowe.
3299         
3300         DerivedSources.make was finding "ENABLE_SVG" in the string
3301         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3302         quite correctly.
3303
3304         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3305
3306 2007-09-25  Mark Rowe  <mrowe@apple.com>
3307
3308         Rubber-stamped by Eric.
3309
3310         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3311         This makes it possible to automate nightly builds for the feature-branch.
3312
3313 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3314
3315         Rubber stamped by Mark.
3316
3317         Enable svg experimental features as default here in feature-branch.
3318
3319         * Scripts/build-webkit:
3320
3321 2007-06-29  Antti Koivisto  <antti@apple.com>
3322
3323         Reviewed by Weinig.
3324         
3325         Add VIDEO flag for timed media features
3326
3327         * Scripts/build-webkit
3328         
3329 === End merge of feature-branch 2007-10-12 ===
3330
3331 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3332
3333         Reviewed by Darin.
3334
3335         - Updated rational for the leaks list to be more clear.
3336
3337         * Scripts/run-webkit-tests:
3338
3339 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3340
3341         Rubber Stamp by Sam.
3342
3343         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3344         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3345
3346         * Scripts/run-webkit-tests:
3347
3348 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3349
3350         Reviewed by Lars.
3351
3352         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3353         includes are needed for INT_MAX, std::auto_ptr and the like.
3354
3355         * DumpRenderTree/qt/main.cpp:
3356
3357 2007-10-09  Lars Knoll  <lars@trolltech.com>
3358
3359         Reviewed by Simon.
3360
3361         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3362
3363         * DumpRenderTree/qt/jsobjects.cpp:
3364         (LayoutTestController::encodeHostName):
3365         (LayoutTestController::decodeHostName):
3366         * DumpRenderTree/qt/jsobjects.h:
3367
3368 2007-10-09  Lars Knoll  <lars@trolltech.com>
3369
3370         Reviewed by Simon.
3371
3372         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3373
3374         * DumpRenderTree/qt/DumpRenderTree.cpp:
3375         (WebCore::WebPage::createFrame):
3376         (WebCore::DumpRenderTree::DumpRenderTree):
3377         (WebCore::DumpRenderTree::titleChanged):
3378         * DumpRenderTree/qt/DumpRenderTree.h:
3379         * DumpRenderTree/qt/jsobjects.cpp:
3380         (LayoutTestController::reset):
3381         * DumpRenderTree/qt/jsobjects.h:
3382
3383 2007-10-09  Lars Knoll  <lars@trolltech.com>
3384
3385         Reviewed by Simon.
3386
3387         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3388
3389         * DumpRenderTree/qt/DumpRenderTree.h:
3390         * DumpRenderTree/qt/jsobjects.cpp:
3391         (LayoutTestController::clearBackForwardList):
3392         * DumpRenderTree/qt/jsobjects.h:
3393
3394 2007-10-09  Lars Knoll  <lars@trolltech.com>
3395
3396         Reviewed by Simon.
3397
3398         make --git-reviewer work again.
3399
3400         * Scripts/prepare-ChangeLog:
3401
3402 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3403
3404         Rubber stamped by Eric.
3405
3406         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3407         show the current link inside the statusbar.
3408         This shows how to make use of this signal and allows to easily test
3409         http://bugs.webkit.org/show_bug.cgi?id=15299.
3410
3411         * GtkLauncher/main.cpp:
3412         (hoveringOverLink):
3413         (main):
3414
3415 2007-10-05  Lars Knoll  <lars@trolltech.com>
3416
3417         add proper error messages to the FrameLoaderClient.
3418         Implement ChromeClientQt::closeWindowSoon and
3419         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3420         Some fixes in DRT to make it work correctly with multiple windows.
3421
3422         Reviewed by Maciej.
3423
3424         * DumpRenderTree/qt/DumpRenderTree.cpp:
3425         (WebCore::DumpRenderTree::DumpRenderTree):
3426         (WebCore::DumpRenderTree::createWindow):
3427         (WebCore::DumpRenderTree::windowCount):
3428         * DumpRenderTree/qt/DumpRenderTree.h:
3429         * DumpRenderTree/qt/jsobjects.cpp:
3430         (LayoutTestController::maybeDump):
3431         (LayoutTestController::windowCount):
3432         * DumpRenderTree/qt/jsobjects.h:
3433
3434 2007-10-05  Lars Knoll  <lars@trolltech.com>
3435
3436         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3437         Add support for layoutTextController.setCanOpenWindows() to DRT
3438         fixing another 2 test cases in fast/dom/Window.
3439
3440         Reviewed by Maciej.
3441
3442         * DumpRenderTree/qt/DumpRenderTree.cpp:
3443         (WebCore::WebPage::WebPage):
3444         (WebCore::WebPage::createWindow):
3445         (WebCore::DumpRenderTree::resetJSObjects):
3446         (WebCore::DumpRenderTree::createWindow):
3447         * DumpRenderTree/qt/DumpRenderTree.h:
3448         * DumpRenderTree/qt/DumpRenderTree.pro:
3449         * DumpRenderTree/qt/jsobjects.cpp:
3450         (LayoutTestController::LayoutTestController):
3451         (LayoutTestController::reset):
3452         * DumpRenderTree/qt/jsobjects.h:
3453         * DumpRenderTree/qt/main.cpp:
3454         * DumpRenderTree/qt/testplugin.cpp: Added.
3455         * DumpRenderTree/qt/testplugin.h: Added.
3456
3457 2007-10-04  Sam Weinig  <sam@webkit.org>
3458
3459         Rubber stamped by Adam.
3460
3461         Remove empty directories.
3462
3463         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3464         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3465
3466 2007-10-03  Darin Adler  <darin@apple.com>
3467
3468         Reviewed by Adam.
3469
3470         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3471         we find the internal libraries in the libraries directory. This
3472         is helpful for Safari team engineers at Apple.
3473
3474 2007-10-03  Adam Roben  <aroben@apple.com>
3475
3476         Update the location of AHEM___.TTF after r25968
3477
3478         Reviewed by Sam.
3479
3480         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3481
3482 2007-10-03  Alp Toker  <alp@atoker.com>
3483
3484         Reviewed by Adam.
3485
3486         http://bugs.webkit.org/show_bug.cgi?id=14726
3487         [gtk] API design. Mapping the WebView delegates to signals.
3488
3489         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3490
3491         * GtkLauncher/main.cpp:
3492         (goToURLBarText):
3493         (titleChanged):
3494         (progressChanged):
3495         (menuMainBackCallback):
3496         (menuMainForwardCallback):
3497         (main):
3498
3499 2007-10-03  Lars Knoll  <lars@trolltech.com>
3500
3501         Reviewed by Rob.
3502
3503         This fixes --strict mode in run-webkit-tests again after
3504         the platform dependent test results have been moved.
3505
3506         * Scripts/run-webkit-tests:
3507
3508 2007-10-03  Lars Knoll  <lars@trolltech.com>
3509
3510         Reviewed by bdash.
3511
3512         remove the hack in run-webkit-tests that forced text only test
3513         to be taken from the platform independent dir. It was only left
3514         there from early days.
3515         
3516         Remove platform dependent results for tests that are text only nowadays,
3517         and add one platform dependent result for a text only test that requires it.
3518
3519         * Scripts/run-webkit-tests:
3520
3521 2007-10-03  Lars Knoll  <lars@trolltech.com>
3522
3523         Reviewed by olliej.
3524
3525         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3526
3527         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3528         (WebCore::WebFrame::WebFrame):
3529         (WebCore::WebPage::WebPage):
3530         (WebCore::WebPage::createFrame):
3531         (WebCore::WebPage::javaScriptAlert):
3532         (WebCore::WebPage::javaScriptConsoleMessage):
3533         (WebCore::DumpRenderTree::DumpRenderTree):
3534         (WebCore::DumpRenderTree::~DumpRenderTree):
3535         (WebCore::DumpRenderTree::open):
3536         (WebCore::DumpRenderTree::readStdin):
3537         (WebCore::DumpRenderTree::resetJSObjects):
3538         (WebCore::DumpRenderTree::initJSObjects):
3539         (WebCore::DumpRenderTree::dumpFramesAsText):
3540         (WebCore::DumpRenderTree::dump):
3541         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3542         (WebCore::DumpRenderTree::layoutTestController):
3543         (WebCore::DumpRenderTree::eventSender):
3544         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3545         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3546         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3547         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3548         (HackWebFrame::mousePressEvent):
3549         (HackWebFrame::mouseReleaseEvent):
3550         (HackWebFrame::mouseMoveEvent):
3551         (HackWebFrame::HackWebFrame):
3552         (HackWebFrame::~HackWebFrame):
3553         (LayoutTestController::LayoutTestController):
3554         (LayoutTestController::reset):
3555         (LayoutTestController::maybeDump):
3556         (LayoutTestController::waitUntilDone):
3557         (LayoutTestController::notifyDone):
3558         (LayoutTestController::dumpEditingCallbacks):
3559         (LayoutTestController::queueReload):
3560         (LayoutTestController::provisionalLoad):
3561         (LayoutTestController::timerEvent):
3562         (EventSender::EventSender):
3563         (EventSender::mouseDown):
3564         (EventSender::mouseUp):
3565         (EventSender::mouseMoveTo):
3566         (EventSender::leapForward):
3567         (EventSender::keyDown):
3568         (EventSender::frameUnderMouse):
3569         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3570         (LayoutTestController::isLoading):
3571         (LayoutTestController::setLoading):
3572         (LayoutTestController::shouldDumpAsText):
3573         (LayoutTestController::shouldDumpChildrenAsText):
3574         (LayoutTestController::shouldWaitUntilDone):
3575         (LayoutTestController::dumpAsText):
3576         (LayoutTestController::dumpChildFramesAsText):
3577         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3578         (messageHandler):
3579         (crashHandler):
3580         (main):
3581         * Scripts/run-webkit-tests:
3582
3583 2007-10-03  Mark Rowe  <mrowe@apple.com>
3584
3585         Reviewed by Alp Toker.
3586
3587         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3588         should take precedence over QTDIR when determining which port we are working with.
3589
3590         * Scripts/webkitdirs.pm: 
3591
3592 2007-10-02  Adam Roben  <aroben@apple.com>
3593
3594         Add keychain to the list of default packages to install
3595
3596         Rubberstamped by Sam.
3597
3598         * CygwinDownloader/cygwin-downloader.py:
3599         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3600
3601 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3602
3603         Reviewed by Adam.
3604
3605         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3606         Also makes WebCore regression test case logic work when using git.
3607
3608         * Scripts/prepare-ChangeLog:
3609         (reviewerAndDescriptionForGitCommit): Added.
3610
3611 2007-10-02  Lars Knoll  <lars@trolltech.com>
3612