WebKitTools/ChangeLog

   1 2009-11-24  Dmitry Titov  <dimich@chromium.org>
   2
   3         Reviewed by Eric Seidel.
   4
   5         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
   6         https://bugs.webkit.org/show_bug.cgi?id=31444
   7
   8         * Scripts/build-webkit:
   9
  10 2009-11-24  Chris Marrin  <cmarrin@apple.com>
  11
  12         Reviewed by Simon Fraser.
  13
  14         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
  15         https://bugs.webkit.org/show_bug.cgi?id=27314
  16
  17         Now the script allows the directories with these tests to be included on all
  18         platforms but Mac, where they behave the same as always. For all other platforms
  19         the tests need to be excluded using the Skipped files, which is currently done
  20         for all platforms (including win since we're not turned on yet)
  21
  22         * Scripts/webkitdirs.pm:
  23
  24 2009-11-24  Eric Seidel  <eric@webkit.org>
  25
  26         Reviewed by Adam Barth.
  27
  28         queries_unittest.py should test command output
  29         https://bugs.webkit.org/show_bug.cgi?id=31845
  30
  31         * Scripts/modules/commands/queries_unittest.py:
  32          - Capture stdout and stderr and compare with expected strings.
  33
  34 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
  35
  36         No Review.
  37
  38         Fix spelling error ("depenedencies").
  39
  40         * Scripts/build-webkit:
  41
  42 2009-11-24  Mark Rowe  <mrowe@apple.com>
  43
  44         Land the configuration that includes the two debug GTK Linux builders.
  45
  46         * BuildSlaveSupport/build.webkit.org-config/config.json:
  47
  48 2009-11-24  David Kilzer  <ddkilzer@apple.com>
  49
  50         <http://webkit.org/b/31840> bisect-builds broke after r50080
  51
  52         Reviewed by Dan Bernstein.
  53
  54         * Scripts/bisect-builds:
  55         (mountAndRunNightly): Switched back to using backticks to run
  56         the hdiutil command since exec() will terminate the existing
  57         script, which is not what we want.  Store the output of
  58         File::Spec->devnull() in a variable for use in the hdiutil
  59         detach commands.
  60
  61 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
  62
  63         Reviewed by Kenneth Rohde Christiansen.
  64
  65         Include "config.h" to meet Coding Style Guidelines
  66         https://bugs.webkit.org/show_bug.cgi?id=31792
  67
  68         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
  69         * DumpRenderTree/qt/jsobjects.cpp:
  70         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  71
  72 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
  73
  74         Reviewed by Oliver Hunt.
  75
  76         Implement new required function to pass test we used to pass. This
  77         change is required since r51294.
  78
  79         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  80         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  81
  82 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
  83
  84         Reviewed by Kenneth Rohde Christiansen.
  85
  86         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
  87         https://bugs.webkit.org/show_bug.cgi?id=31775
  88
  89         LayoutTestController::dumpBackForwardList() should work with local URLs
  90         as well as with normal URLs (in http tests for instance).
  91         Currently it does not output the latter properly.
  92
  93         Unskip a bunch of passing http/navigation tests.
  94
  95         * DumpRenderTree/qt/DumpRenderTree.cpp:
  96         (WebCore::dumpHistoryItem):
  97
  98 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
  99
 100         Reviewed by Oliver Hunt.
 101
 102         ARIA: support aria-flowto
 103         https://bugs.webkit.org/show_bug.cgi?id=31762
 104
 105         * DumpRenderTree/AccessibilityUIElement.cpp:
 106         (ariaFlowToElementAtIndexCallback):
 107         (AccessibilityUIElement::getJSClass):
 108         * DumpRenderTree/AccessibilityUIElement.h:
 109         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 110         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 111         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 112         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 113         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 114         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 115
 116 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
 117
 118         Reviewed by Kenneth Christiansen.
 119
 120         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
 121         https://bugs.webkit.org/show_bug.cgi?id=31638
 122
 123         Unfreeze WorkQueue after each test execution.
 124
 125         * DumpRenderTree/qt/DumpRenderTree.cpp:
 126         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 127
 128 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 129
 130         Reviewed by Adam Barth.
 131
 132         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
 133         for localhost and 127.0.0.1.
 134         https://bugs.webkit.org/show_bug.cgi?id=31783
 135
 136         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
 137
 138         * DumpRenderTree/qt/DumpRenderTree.cpp:
 139         (WebCore::NetworkAccessManager::NetworkAccessManager):
 140         (WebCore::NetworkAccessManager::sslErrorsEncountered):
 141         (WebCore::WebPage::WebPage):
 142         * DumpRenderTree/qt/DumpRenderTree.h:
 143
 144 2009-11-22  Chris Evans  <cevans@chromium.org>
 145
 146         Reviewed by Adam Barth.
 147
 148         Disable access to file:/// directory listings
 149         https://bugs.webkit.org/show_bug.cgi?id=31329
 150
 151         Implemented setAllowUniversalAccessFromFileURLs to support testing of
 152         file URL security.
 153
 154         * DumpRenderTree/LayoutTestController.cpp:
 155         (setAllowUniversalAccessFromFileURLsCallback):
 156         (LayoutTestController::staticFunctions):
 157         * DumpRenderTree/LayoutTestController.h:
 158         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 159         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 160         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 161         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 162         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 163         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 164         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 165         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 166
 167 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 168
 169         Reviewed by Kenneth Rohde Christiansen.
 170
 171         [Qt] Fix the timeout of fast/frames/frame-navigation.html
 172         https://bugs.webkit.org/show_bug.cgi?id=31638
 173
 174         The test is timeouting, because it uses the WorkQueue to load a document in one
 175         of the child frames and once the loading is finished, the DRT does not dump the
 176         tree. This is because it waits for the QWebFrame::loadFinished() signal from
 177         the main frame, while it should connect to QWebPage::loadFinished().
 178
 179         * DumpRenderTree/qt/DumpRenderTree.cpp:
 180         (WebCore::DumpRenderTree::DumpRenderTree):
 181
 182 2009-11-21  Eric Seidel  <eric@webkit.org>
 183
 184         Reviewed by Adam Barth.
 185
 186         bugzilla-tool --help spews way too much text
 187         https://bugs.webkit.org/show_bug.cgi?id=31771
 188
 189         * Scripts/bugzilla-tool:
 190          - Remove self.cached_scm initialization hack.
 191         * Scripts/modules/buildbot.py:
 192          - Make default_host accessible to callers.
 193         * Scripts/modules/commands/download.py:
 194          - Phrase help for all commands consistently and remove spurious help text punctuation.
 195         * Scripts/modules/commands/queries.py: Ditto.
 196         * Scripts/modules/commands/queues.py: Ditto.
 197         * Scripts/modules/commands/upload.py: Ditto.
 198         * Scripts/modules/multicommandtool.py:
 199          - Add HelpPrintingOptionParser.format_epilog to replace
 200            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 201            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 202          - Make --help only show a list of commands like "svn help" and "git help" do --
 203            previously --help was listing all commands and options.
 204          - Sort list of commands alphabetically.
 205
 206 2009-11-21  Eric Seidel  <eric@webkit.org>
 207
 208         No review.  Fixing a typo from the previous patch for bug 31767.
 209
 210         AbstractQueue.run_bugzilla_tool throws an exception
 211         https://bugs.webkit.org/show_bug.cgi?id=31769
 212
 213         * Scripts/modules/commands/queues.py:
 214
 215 2009-11-21  Eric Seidel  <eric@webkit.org>
 216
 217         Reviewed by Adam Barth.
 218
 219         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 220         https://bugs.webkit.org/show_bug.cgi?id=31767
 221
 222         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 223         Since we don't have a good way to test BugzillaTool pieces, I've
 224         left out a test for now.
 225
 226         * Scripts/bugzilla-tool:
 227          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 228         * Scripts/modules/commands/queues.py:
 229          - Use tool.path() instead of __file__.
 230         * Scripts/modules/multicommandtool.py:
 231          - Add a new path() method to MultiComandTool.
 232         * Scripts/modules/multicommandtool_unittest.py:
 233          - Provide a path() method.  Little point in testing this mock implementation.
 234
 235 2009-11-21  Adam Barth  <abarth@webkit.org>
 236
 237         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 238         WebKitTools.
 239
 240         * Scripts/modules/commands/download.py:
 241
 242 2009-11-21  Adam Barth  <abarth@webkit.org>
 243
 244         Reviewed by Eric Seidel.
 245
 246         Convert check-style to use LandingSequence
 247         https://bugs.webkit.org/show_bug.cgi?id=31763
 248
 249         Instead of manipulating the working copy by hand, we should use the
 250         LandingSequence in CheckStyle.  This will make this code eaiser to
 251         test.
 252
 253         * Scripts/modules/commands/download.py:
 254
 255 2009-11-20  Adam Barth  <abarth@webkit.org>
 256
 257         Reviewed by Eric Seidel.
 258
 259         Unit test query commands
 260         https://bugs.webkit.org/show_bug.cgi?id=31755
 261
 262         These tests are pretty rough, but hopefully they'll grow.
 263
 264         * Scripts/modules/commands/queries_unittest.py: Added.
 265         * Scripts/modules/mock_bugzillatool.py: Added.
 266         * Scripts/run-webkit-unittests:
 267
 268 2009-11-20  Eric Seidel  <eric@webkit.org>
 269
 270         Reviewed by Adam Barth.
 271
 272         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 273         https://bugs.webkit.org/show_bug.cgi?id=31758
 274
 275         * Scripts/modules/multicommandtool.py:
 276          - Allow passing of explicit commands to MultiCommandTool.__init__
 277         * Scripts/modules/multicommandtool_unittest.py:
 278          - Use new Command.name naming system.
 279          - Test Command auto-discovery.
 280         * Scripts/modules/workqueue.py:
 281          - bug_id no longer exists, use patch['bug_id'] instead.
 282         * Scripts/modules/workqueue_unittest.py:
 283          - WorkQueues require names now.
 284          - should_proceed_with_work_item must return a patch object.
 285
 286 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 287
 288         Reviewed by Beth Dakin.
 289
 290         WAI-ARIA: add support for aria-owns
 291         https://bugs.webkit.org/show_bug.cgi?id=31702
 292
 293         * DumpRenderTree/AccessibilityUIElement.cpp:
 294         (ariaOwnsElementAtIndexCallback):
 295         (AccessibilityUIElement::getJSClass):
 296         * DumpRenderTree/AccessibilityUIElement.h:
 297         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 298         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 299         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 300         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 301         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 302         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 303
 304 2009-11-20  Eric Seidel  <eric@webkit.org>
 305
 306         Reviewed by Adam Barth.
 307
 308         Fix exception thrown when running the commit-queue.
 309
 310         * Scripts/modules/statusbot.py: patch is optional.
 311         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 312
 313 2009-11-20  Eric Seidel  <eric@webkit.org>
 314
 315         Reviewed by Adam Barth.
 316
 317         Teach the StatusBot how to support more than just the commit-queue
 318         https://bugs.webkit.org/show_bug.cgi?id=31754
 319
 320         * Scripts/modules/workqueue.py: Another typo.
 321
 322 2009-11-20  Eric Seidel  <eric@webkit.org>
 323
 324         Reviewed by Adam Barth.
 325
 326         Teach the StatusBot how to support more than just the commit-queue
 327         https://bugs.webkit.org/show_bug.cgi?id=31754
 328
 329         * Scripts/modules/commands/queues.py: Fix silly typo.
 330
 331 2009-11-20  Eric Seidel  <eric@webkit.org>
 332
 333         Reviewed by Adam Barth.
 334
 335         Teach the StatusBot how to support more than just the commit-queue
 336         https://bugs.webkit.org/show_bug.cgi?id=31754
 337
 338         * CommitQueueStatus/index.yaml:
 339          - Add indices required for the new queries.
 340         * CommitQueueStatus/queue_status.py:
 341          - Add a patch-status page and move update_status to update-status.
 342          - Only display "commit-queue" status records for the commit-queue.
 343          - Add support for a queue_name property on status records.
 344          - Fix _int_from_request to actually work.
 345         * CommitQueueStatus/update_status.html:
 346          - Add support for a queue_name on status records.
 347          - Remove unused list of bug ids.
 348          * Scripts/modules/commands/queues.py
 349           - Make the queues pass the patch instead of the bug_id to StatusBot.
 350         * Scripts/modules/statusbot.py:
 351          - Support passing the queue_name to the status updates.
 352          - Support fetching patch status with patch_status().
 353         * Scripts/modules/workqueue.py:
 354          - Pass the patch to the StatusBot instead of the bug_id.
 355          - Let WorkQueues have a name.
 356
 357 2009-11-20  Adam Barth  <abarth@webkit.org>
 358
 359         Reviewed by Eric Seidel.
 360
 361         Move bugzilla-tool commands into their own file
 362         https://bugs.webkit.org/show_bug.cgi?id=31752
 363
 364         This will let us write unit tests.
 365
 366         * Scripts/bugzilla-tool:
 367         * Scripts/modules/commands/__init__.py: Added.
 368         * Scripts/modules/commands/download.py: Added.
 369         * Scripts/modules/commands/queries.py: Added.
 370         * Scripts/modules/commands/queues.py: Added.
 371         * Scripts/modules/commands/upload.py: Added.
 372         * Scripts/modules/grammar.py: Added.
 373
 374 2009-11-20  Adam Barth  <abarth@webkit.org>
 375
 376         Reviewed by Eric Seidel.
 377
 378         BuildQueue should check if the tree is currently buildable
 379         https://bugs.webkit.org/show_bug.cgi?id=31744
 380
 381         * Scripts/bugzilla-tool:
 382         * Scripts/modules/landingsequence.py:
 383         * Scripts/modules/webkitlandingscripts.py:
 384
 385 2009-11-20  Adam Barth  <abarth@webkit.org>
 386
 387         Reviewed by Eric Seidel.
 388
 389         Move prepare_clean_working_directory into the LandingSequence
 390         https://bugs.webkit.org/show_bug.cgi?id=31743
 391
 392         * Scripts/bugzilla-tool:
 393         * Scripts/modules/landingsequence.py:
 394
 395 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 396
 397         Reviewed by Kenneth Rohde Christiansen.
 398
 399         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 400         https://bugs.webkit.org/show_bug.cgi?id=30460
 401
 402         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 403
 404         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 405         (pluginInvoke):
 406
 407 2009-11-20  Adam Barth  <abarth@webkit.org>
 408
 409         Reviewed by Eric Seidel.
 410
 411         Pass the port information to the child process
 412         https://bugs.webkit.org/show_bug.cgi?id=31736
 413
 414         We need to do this so the child process knows what to build!
 415
 416         * Scripts/bugzilla-tool:
 417         * Scripts/modules/landingsequence.py:
 418         * Scripts/modules/webkitport.py:
 419         * Scripts/modules/webkitport_unittest.py:
 420
 421 2009-11-20  Adam Barth  <abarth@webkit.org>
 422
 423         Reviewed by Eric Seidel.
 424
 425         Support Qt port in build-queue
 426         https://bugs.webkit.org/show_bug.cgi?id=31733
 427
 428         * Scripts/bugzilla-tool:
 429
 430 2009-11-20  Adam Barth  <abarth@webkit.org>
 431
 432         Reviewed by Eric Seidel.
 433
 434         Implement a build-queue
 435         https://bugs.webkit.org/show_bug.cgi?id=31725
 436
 437         Currently this just builds the first 10 patches in the review queue.
 438         We'll want to do something smarter soon.
 439
 440         * Scripts/bugzilla-tool:
 441
 442 2009-11-20  Adam Barth  <abarth@webkit.org>
 443
 444         Reviewed by Eric Seidel.
 445
 446         Make commit-queue and style-queue show up in help
 447         https://bugs.webkit.org/show_bug.cgi?id=31724
 448
 449         We need to store their names on their class to make these commands
 450         properly register themselves with MultiCommandTool.
 451
 452         * Scripts/bugzilla-tool:
 453
 454 2009-11-20  Adam Barth  <abarth@webkit.org>
 455
 456         Reviewed by Eric Seidel.
 457
 458         Implement bugzilla-tool build-attachment
 459         https://bugs.webkit.org/show_bug.cgi?id=31722
 460
 461         This command builds an attachment from bugzilla.  It leaves the built
 462         patch in the working copy.
 463
 464         * Scripts/bugzilla-tool:
 465         * Scripts/modules/landingsequence.py:
 466         * Scripts/modules/webkitlandingscripts.py:
 467
 468 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 469
 470         Reviewed by Xan Lopez.
 471
 472         [GTK] DRT release event does not create the state correctly
 473         https://bugs.webkit.org/show_bug.cgi?id=31717
 474
 475         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 476
 477 2009-11-20  Eric Seidel  <eric@webkit.org>
 478
 479         Reviewed by Adam Barth.
 480
 481         MultiCommandTool should find Command objects automatically instead of with a manual list
 482         https://bugs.webkit.org/show_bug.cgi?id=31710
 483
 484         * Scripts/bugzilla-tool:
 485         * Scripts/modules/multicommandtool.py:
 486          - Use some wild python-fu to crawl all the known subclasses of Command.
 487
 488 2009-11-20  Adam Barth  <abarth@webkit.org>
 489
 490         Unreviewed "build" fix.  Added missing import.
 491
 492         * Scripts/bugzilla-tool:
 493
 494 2009-11-20  Adam Barth  <abarth@webkit.org>
 495
 496         Unreviewed "build" fix.  I failed to update LandingSequence.test
 497         properly.
 498
 499         * Scripts/modules/landingsequence.py:
 500
 501 2009-11-20  Adam Barth  <abarth@webkit.org>
 502
 503         Reviewed by Eric Seidel.
 504
 505         Create LandingSequence as the all-sing, all-dance landing class
 506         https://bugs.webkit.org/show_bug.cgi?id=31709
 507
 508         Client can inherit from this class to carefully control exactly which
 509         steps they wish to have happen in the landing sequence.
 510
 511         * Scripts/bugzilla-tool:
 512         * Scripts/modules/landingsequence.py: Added.
 513         * Scripts/modules/webkitlandingscripts.py: Added.
 514
 515 2009-11-19  Adam Barth  <abarth@webkit.org>
 516
 517         Reviewed by Eric Seidel.
 518
 519         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 520         https://bugs.webkit.org/show_bug.cgi?id=31707
 521
 522         This is to help when we implement build-attachment.
 523
 524         * Scripts/bugzilla-tool:
 525
 526 2009-11-19  Adam Barth  <abarth@webkit.org>
 527
 528         Reviewed by Eric Seidel.
 529
 530         Support Qt port in bugzilla-tool
 531         https://bugs.webkit.org/show_bug.cgi?id=31701
 532
 533         Now we support building with Qt!
 534
 535         * Scripts/bugzilla-tool:
 536         * Scripts/modules/webkitport.py: Added.
 537         * Scripts/modules/webkitport_unittest.py: Added.
 538         * Scripts/run-webkit-unittests:
 539
 540 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 541
 542         Reviewed by Adam Barth.
 543
 544         Remove inserting stderr into patch in bugzilla-tool
 545         https://bugs.webkit.org/show_bug.cgi?id=29914
 546
 547         Modify SCM python module's run_command function to avoid return of stderr
 548         by default, so stderr won't be inserted into the patches.
 549         Modify the related unit test.
 550
 551         * Scripts/modules/scm.py:
 552         * Scripts/modules/scm_unittest.py:
 553
 554 2009-11-19  Eric Seidel  <eric@webkit.org>
 555
 556         Reviewed by Adam Barth.
 557
 558         bugzilla-tool needs per-command help
 559         https://bugs.webkit.org/show_bug.cgi?id=31697
 560
 561         Added support for "bugzilla-tool help command-name"
 562         and a unit test to make sure it works.
 563
 564         * Scripts/modules/multicommandtool.py:
 565         * Scripts/modules/multicommandtool_unittest.py:
 566
 567 2009-11-19  Eric Seidel  <eric@webkit.org>
 568
 569         Reviewed by Adam Barth.
 570
 571         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 572         https://bugs.webkit.org/show_bug.cgi?id=31695
 573
 574         * Scripts/bugzilla-tool:
 575         * Scripts/modules/multicommandtool.py: Added.
 576         * Scripts/modules/multicommandtool_unittest.py: Added.
 577         * Scripts/run-webkit-unittests:
 578
 579 2009-11-19  Eric Seidel  <eric@webkit.org>
 580
 581         No review, just adding a FIXME.
 582
 583         Split out command parsing and help printing from BugzillaTool
 584         https://bugs.webkit.org/show_bug.cgi?id=31688
 585
 586         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 587
 588 2009-11-19  Eric Seidel  <eric@webkit.org>
 589
 590         Reviewed by Adam Barth.
 591
 592         Split out command parsing and help printing from BugzillaTool
 593         https://bugs.webkit.org/show_bug.cgi?id=31688
 594
 595         * Scripts/bugzilla-tool:
 596          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 597          - Rename private methods to use _ pattern.
 598          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 599          -
 600
 601 2009-11-19  Eric Seidel  <eric@webkit.org>
 602
 603         Reviewed by Adam Barth.
 604
 605         Re-factor help printing to use modern python idioms
 606         https://bugs.webkit.org/show_bug.cgi?id=31685
 607
 608         * Scripts/bugzilla-tool:
 609
 610 2009-11-19  Eric Seidel  <eric@webkit.org>
 611
 612         Reviewed by Darin Adler.
 613
 614         commit-queue empty queue logs twice
 615         https://bugs.webkit.org/show_bug.cgi?id=31679
 616
 617         * Scripts/bugzilla-tool:
 618
 619 2009-11-19  Eric Seidel  <eric@webkit.org>
 620
 621         Reviewed by Darin Adler.
 622
 623         bugzilla-tool's reviewer/committer rejection message should be clearer
 624         https://bugs.webkit.org/show_bug.cgi?id=31126
 625
 626         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 627
 628         * Scripts/modules/bugzilla.py:
 629
 630 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 631
 632         Reviewed by Pavel Feldman.
 633
 634         Forces a WM_PAINT event on calling layoutTestController.display()
 635         in order to enable the timeline-paint.html test on Windows.
 636         ::UpdateWindow() does not force an event becaue the window is
 637         not visible.
 638
 639         https://bugs.webkit.org/show_bug.cgi?id=31402
 640
 641         * DumpRenderTree/win/DumpRenderTree.cpp:
 642         (displayWebView):
 643
 644 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 645
 646         No review needed.
 647
 648         Added myself to committers list.
 649
 650         * Scripts/modules/committers.py:
 651
 652 2009-11-19  Adam Barth  <abarth@webkit.org>
 653
 654         Reviewed by Eric Seidel.
 655
 656         Bugzilla-tool command classes should match command names
 657         https://bugs.webkit.org/show_bug.cgi?id=31666
 658
 659         I renamed all the commands except CommitMessageForCurrentDiff because
 660         the new name would conflict with an existing class.
 661
 662         * Scripts/bugzilla-tool:
 663
 664 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 665
 666         Reviewed by Gustavo Noronha Silva.
 667
 668         Web Inspector: Implement "show inspector" in WebKit GTK
 669         API and enable console tests.
 670
 671         https://bugs.webkit.org/show_bug.cgi?id=31669
 672
 673         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 674         (LayoutTestController::showWebInspector):
 675
 676 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 677
 678         Reviewed by Simon Hausmann.
 679
 680         Minor refactoring + more documentation.
 681
 682         * DumpRenderTree/qt/DumpRenderTree.cpp:
 683         (WebCore::clearHistory):
 684         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 685
 686 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 687
 688         Reviewed by Eric Seidel.
 689
 690         Ignore websocket tests when --no-http is specified.
 691         https://bugs.webkit.org/show_bug.cgi?id=31662
 692
 693         * Scripts/run-webkit-tests:
 694
 695 2009-11-18  Adam Barth  <abarth@webkit.org>
 696
 697         Reviewed by Eric Seidel.
 698
 699         Normalize ' and " in bugzilla-tool
 700         https://bugs.webkit.org/show_bug.cgi?id=31655
 701
 702         We decided " is better than ' and we should be consistent.
 703
 704         * Scripts/bugzilla-tool:
 705
 706 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 707
 708         Reviewed by Kenneth Rohde Christiansen.
 709
 710         [Qt] Remove support for Qt v4.3 or older versions
 711         https://bugs.webkit.org/show_bug.cgi?id=29469
 712
 713         * DumpRenderTree/qt/DumpRenderTree.pro:
 714         * DumpRenderTree/qt/ImageDiff.pro:
 715
 716 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 717
 718         Reviewed by Eric Seidel.
 719
 720         GitTest.test_create_binary_patch fails if /tmp is symlink
 721         https://bugs.webkit.org/show_bug.cgi?id=31536
 722
 723         * Scripts/modules/scm_unittest.py:
 724
 725 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 726
 727         Reviewed by Darin Adler.
 728
 729         Configuration for Chromium Build Slaves.
 730
 731         https://bugs.webkit.org/show_bug.cgi?id=31442
 732
 733         * BuildSlaveSupport/build.webkit.org-config/config.json:
 734         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 735
 736 2009-11-18  Eric Seidel  <eric@webkit.org>
 737
 738         Reviewed by Darin Adler.
 739
 740         workqueue.py results in totally broken commit-queue UI
 741         https://bugs.webkit.org/show_bug.cgi?id=31645
 742
 743         * Scripts/bugzilla-tool:
 744          - Remove unneeded use of PatchCollection.
 745          - Grab a new copy of the cq'd patches every run of the queue.
 746
 747 2009-11-18  Sam Weinig  <sam@webkit.org>
 748
 749         Reviewed by Anders Carlsson.
 750
 751         Make the Mac Geolocation API async.
 752
 753         Update DRT to use the new async Mac Geolocation API.
 754
 755         * DumpRenderTree/mac/UIDelegate.mm:
 756         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 757
 758 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 759
 760         Reviewed by Kenneth Rohde Christiansen.
 761
 762         Add and option to toggle HTML5 datalist support to build-webkit
 763         https://bugs.webkit.org/show_bug.cgi?id=31599
 764
 765         * Scripts/build-webkit:
 766
 767 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 768
 769         Reviewed by Kevin Ollivier.
 770
 771         Enable wx plugin support using the Windows implementation as a base.
 772
 773         https://bugs.webkit.org/show_bug.cgi?id=31636
 774
 775         * wx/build/settings.py:
 776
 777 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 778
 779         Reviewed by Simon Hausmann.
 780
 781         Change the initialization order so that the controllers
 782         will be created before exporting them to the JS DOM window.
 783
 784         * DumpRenderTree/qt/DumpRenderTree.cpp:
 785         (WebCore::DumpRenderTree::DumpRenderTree):
 786
 787 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 788
 789         Reviewed by Simon Hausmann.
 790
 791         Fix a code copy and paste error. m_page should be page.
 792
 793         * DumpRenderTree/qt/DumpRenderTree.cpp:
 794         (WebCore::DumpRenderTree::createWindow):
 795
 796 2009-11-17  Mark Rowe  <mrowe@apple.com>
 797
 798         Reviewed by Alexey Proskuryakov.
 799
 800         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 801
 802         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 803         This prevents symlinks from confusing the descendant check.
 804
 805 2009-11-17  Mark Rowe  <mrowe@apple.com>
 806
 807         Reviewed by Alexey Proskuryakov.
 808
 809         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 810
 811         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 812         server to be up rather than having run-webkit-tests abort immediately.
 813
 814         * Scripts/run-webkit-tests:
 815
 816 2009-11-17  Eric Seidel  <eric@webkit.org>
 817
 818         Reviewed by Darin Adler.
 819
 820         commit-queue is failing to set reviewer in ChangeLogs
 821         https://bugs.webkit.org/show_bug.cgi?id=31592
 822
 823         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 824         * Scripts/modules/bugzilla.py:
 825          - Add a new _validate_committer_and_reviewer function as a
 826            temporary solution until we can make a real Attachment object
 827            which knows how to fill in its committer/reviewer fields automatically.
 828
 829 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 830
 831         Unreviewed buildbot fix.
 832
 833         Revert part of earlier patch and add comment, as it
 834         was causing timeouts on the buildbot.
 835
 836         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 837         (LayoutTestController::notifyDone):
 838
 839 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 840
 841         Reviewed by Oliver Hunt.
 842
 843         Make the timeout 15 sec as for the other DRT's and make
 844         it print out the same output when a test timeout.
 845
 846         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 847         (LayoutTestController::waitUntilDone):
 848         (LayoutTestController::notifyDone):
 849         (LayoutTestController::timerEvent):
 850
 851 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 852
 853         Reviewed by Timothy Hatcher.
 854
 855         Fixed typos in comments.
 856
 857         * Scripts/modules/committers.py:
 858
 859 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 860
 861         Reviewed by Timothy Hatcher.
 862
 863         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 864         - Updated DRT to show/close inspector for all tests under /inspector
 865         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 866           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 867         - Removed reload on each inspector test
 868         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 869         inspector for those.
 870         - Reimplemented timeline tests in order to get rid of reload there.
 871         - Moved tests that don't require harness into the fast group.
 872
 873         https://bugs.webkit.org/show_bug.cgi?id=31472
 874
 875         * DumpRenderTree/LayoutTestController.cpp:
 876         (setTimelineProfilingEnabledCallback):
 877         (closeWebInspectorCallback):
 878         (LayoutTestController::staticFunctions):
 879         * DumpRenderTree/LayoutTestController.h:
 880         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 881         (shouldOpenWebInspector):
 882         (runTest):
 883         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 884         (LayoutTestController::setTimelineProfilingEnabled):
 885         * DumpRenderTree/mac/DumpRenderTree.mm:
 886         (shouldOpenWebInspector):
 887         (runTest):
 888         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 889         (LayoutTestController::setTimelineProfilingEnabled):
 890         * DumpRenderTree/win/DumpRenderTree.cpp:
 891         (shouldOpenWebInspector):
 892         (runTest):
 893         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 894         (LayoutTestController::setTimelineProfilingEnabled):
 895
 896 2009-11-17  Oliver Hunt  <oliver@apple.com>
 897
 898         Reviewed by Maciej Stachowiak.
 899
 900         Incorrect use of JavaScriptCore API in DumpRenderTree
 901         https://bugs.webkit.org/show_bug.cgi?id=31577
 902
 903         Return undefined rather than a literal null.
 904
 905         * DumpRenderTree/AccessibilityUIElement.cpp:
 906         (setSelectedTextRangeCallback):
 907         (incrementCallback):
 908         (decrementCallback):
 909         (showMenuCallback):
 910
 911 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 912
 913         Reviewed by Beth Dakin.
 914
 915         AX: aria-labelledby duplicates some of its WAI-ARIA label
 916         https://bugs.webkit.org/show_bug.cgi?id=31565
 917
 918         * DumpRenderTree/AccessibilityUIElement.cpp:
 919         (titleUIElementCallback):
 920         (getIsValidCallback):
 921         (AccessibilityUIElement::getJSClass):
 922
 923 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 924
 925         Reviewed by Simon Hausmann.
 926
 927         r50942 broke output from created windows. Make the
 928         m_enableTextOutput a member of the DRT and not the
 929         WebPage.
 930
 931         * DumpRenderTree/qt/DumpRenderTree.cpp:
 932         (WebCore::WebPage::WebPage):
 933         (WebCore::WebPage::javaScriptAlert):
 934         (WebCore::WebPage::javaScriptConsoleMessage):
 935         (WebCore::WebPage::javaScriptConfirm):
 936         (WebCore::WebPage::javaScriptPrompt):
 937         (WebCore::WebPage::acceptNavigationRequest):
 938         (WebCore::DumpRenderTree::DumpRenderTree):
 939         (WebCore::DumpRenderTree::open):
 940         (WebCore::DumpRenderTree::createWindow):
 941         * DumpRenderTree/qt/DumpRenderTree.h:
 942         (WebCore::DumpRenderTree::setTextOutputEnabled):
 943         (WebCore::DumpRenderTree::isTextOutputEnabled):
 944         (WebCore::WebPage::shouldInterruptJavaScript):
 945         (WebCore::WebPage::isTextOutputEnabled):
 946         (WebCore::WebPage::setViewGeometry):
 947
 948 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 949
 950         Reviewed by Gustavo Noronha Silva.
 951
 952         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 953         as the implementation is being used by at least Qt and Gtk+.
 954
 955         Update buildsystems as well.
 956
 957         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 958         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 959         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 960         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 961         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 962         * GNUmakefile.am:
 963
 964 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 965
 966         Reviewed by Alexey Proskuryakov.
 967
 968         Disable wss until all platforms support pyOpenSSL
 969
 970         https://bugs.webkit.org/show_bug.cgi?id=31479
 971
 972         * Scripts/run-webkit-tests:
 973
 974 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
 975
 976         Reviewed by Kenneth Christiansen.
 977
 978         [Qt] Implement load error pages support for Qt's DRT.
 979         https://bugs.webkit.org/show_bug.cgi?id=31509
 980
 981         For now, it will not be a default feature, and layout tests
 982         that want to make use of this have to explicitily call
 983         'handleErrorPages();' for the test source.
 984
 985         Any of the other DumpRenderTree's (mac, win and gtk)
 986         support handling error pages. Qt's will be the first.
 987
 988         * DumpRenderTree/qt/DumpRenderTree.cpp:
 989         (WebCore::WebPage::supportsExtension):
 990         (WebCore::WebPage::extension):
 991         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 992         (LayoutTestController::reset):
 993         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 994         (LayoutTestController::shouldHandleErrorPages):
 995         (LayoutTestController::handleErrorPages):
 996
 997 2009-11-16  Eric Seidel  <eric@webkit.org>
 998
 999         Reviewed by Adam Barth.
1000
1001         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1002         https://bugs.webkit.org/show_bug.cgi?id=31549
1003
1004         Renamed --commit-queue to --non-interactive in most places
1005         and remove the code in land-patches which is no longer needed.
1006
1007         * Scripts/bugzilla-tool:
1008
1009 2009-11-16  Eric Seidel  <eric@webkit.org>
1010
1011         Reviewed by Adam Barth.
1012
1013         The commit-queue should use land-attachment
1014         https://bugs.webkit.org/show_bug.cgi?id=31548
1015
1016         * Scripts/bugzilla-tool:
1017
1018 2009-11-16  Adam Barth  <abarth@webkit.org>
1019
1020         Reviewed by Eric Seidel.
1021
1022         Convert CommitQueue over to PatchCollection
1023         https://bugs.webkit.org/show_bug.cgi?id=31547
1024
1025         Also fixes a bug in workqueue and adds a test!
1026
1027         * Scripts/bugzilla-tool:
1028         * Scripts/modules/workqueue.py:
1029         * Scripts/modules/workqueue_unittest.py:
1030
1031 2009-11-16  Adam Barth  <abarth@webkit.org>
1032
1033         Reviewed by Eric Seidel.
1034
1035         Move StyleQueue over to using PatchCollection
1036         https://bugs.webkit.org/show_bug.cgi?id=31544
1037
1038         That's what the class it's for.
1039
1040         * Scripts/bugzilla-tool:
1041         * Scripts/modules/patchcollection.py:
1042         * Scripts/modules/patchcollection_unittest.py:
1043
1044 2009-11-16  Eric Seidel  <eric@webkit.org>
1045
1046         Reviewed by Adam Barth.
1047
1048         bugzilla-tool needs a land-attachment command
1049         https://bugs.webkit.org/show_bug.cgi?id=31546
1050
1051         * Scripts/bugzilla-tool:
1052          - Move all the logic into AbstractLandingCommand and
1053            add a new LandAttachment command subclass.
1054          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1055
1056 2009-11-16  Eric Seidel  <eric@webkit.org>
1057
1058         Reviewed by Adam Barth.
1059
1060         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1061         https://bugs.webkit.org/show_bug.cgi?id=31543
1062
1063         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1064
1065         * Scripts/bugzilla-tool:
1066
1067 2009-11-16  Eric Seidel  <eric@webkit.org>
1068
1069         Reviewed by Adam Barth.
1070
1071         Disable the style queue from posting to the commit queue status page.
1072
1073         * Scripts/bugzilla-tool:
1074
1075 2009-11-16  Adam Barth  <abarth@webkit.org>
1076
1077         Reviewed by Eric Seidel.
1078
1079         Implement PatchCollection
1080         https://bugs.webkit.org/show_bug.cgi?id=31541
1081
1082         This class holds a set of patches and lets clients iterate through
1083         them.  Optionally, clients can install a filter.
1084
1085         * Scripts/modules/patchcollection.py: Added.
1086         * Scripts/modules/patchcollection_unittest.py: Added.
1087         * Scripts/run-webkit-unittests:
1088
1089 2009-11-16  Eric Seidel  <eric@webkit.org>
1090
1091         Reviewed by Adam Barth.
1092
1093         bugzilla-tool land-patches will close bugs with patches r=?
1094         https://bugs.webkit.org/show_bug.cgi?id=28230
1095
1096         The commit-queue shouldn't close patches with outstanding reviews on them,
1097         even if many reviewers seem to be against multi-patch bugs.
1098
1099         * Scripts/bugzilla-tool:
1100
1101 2009-11-16  Eric Seidel  <eric@webkit.org>
1102
1103         Reviewed by Adam Barth.
1104
1105         bugzilla-tool check-style should work with attachment ids instead of bug ids
1106         https://bugs.webkit.org/show_bug.cgi?id=31540
1107
1108         * Scripts/bugzilla-tool:
1109
1110 2009-11-16  Eric Seidel  <eric@webkit.org>
1111
1112         Reviewed by Adam Barth.
1113
1114         WorkQueue is the only place that should know about special exit codes
1115         https://bugs.webkit.org/show_bug.cgi?id=31534
1116
1117         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1118         and add tests for handling exit codes.
1119         I also cleaned up workqueue_unittest.py more.
1120
1121         * Scripts/bugzilla-tool:
1122         * Scripts/modules/workqueue.py:
1123         * Scripts/modules/workqueue_unittest.py:
1124
1125 2009-11-16  Eric Seidel  <eric@webkit.org>
1126
1127         Reviewed by Adam Barth.
1128
1129         Re-factor workqueue_unittest to allow for more than one test.
1130         https://bugs.webkit.org/show_bug.cgi?id=31535
1131
1132         * Scripts/modules/workqueue_unittest.py:
1133
1134 2009-11-16  Eric Seidel  <eric@webkit.org>
1135
1136         Reviewed by Adam Barth.
1137
1138         land-patches needs to be re-factored into smaller chunks
1139         https://bugs.webkit.org/show_bug.cgi?id=31532
1140
1141         * Scripts/bugzilla-tool: fix a couple obvious typos.
1142
1143 2009-11-16  Eric Seidel  <eric@webkit.org>
1144
1145         Reviewed by Adam Barth.
1146
1147         land-patches needs to be re-factored into smaller chunks
1148         https://bugs.webkit.org/show_bug.cgi?id=31532
1149
1150         The next patch will move these methods into WebKitLandingScripts.
1151
1152         * Scripts/bugzilla-tool:
1153          - Split out _land_patch and _close_bug_if_no_active_patches.
1154
1155 2009-11-16  Adam Barth  <abarth@webkit.org>
1156
1157         Reviewed by Eric Seidel.
1158
1159         Fix silly copy-and-paste code.  I am a terrible coder.
1160
1161         * Scripts/modules/bugzilla.py:
1162
1163 2009-11-16  Adam Barth  <abarth@webkit.org>
1164
1165         Reviewed by Eric Seidel.
1166
1167         Implement a StyleQueue
1168         https://bugs.webkit.org/show_bug.cgi?id=31537
1169
1170         The first iteration of the style queue only produces output locally.
1171         There is also a limit of 10 patches because it's not that useful to
1172         iterate through the entire review queue at this point.  We can remove
1173         the limit later.
1174
1175         * Scripts/bugzilla-tool:
1176         * Scripts/modules/bugzilla.py:
1177
1178 2009-11-16  Adam Barth  <abarth@webkit.org>
1179
1180         Reviewed by Eric Seidel.
1181
1182         Unit test WorkQueue
1183         https://bugs.webkit.org/show_bug.cgi?id=31531
1184
1185         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1186
1187         * Scripts/bugzilla-tool:
1188         * Scripts/modules/statusbot.py:
1189         * Scripts/modules/workqueue.py:
1190         * Scripts/modules/workqueue_unittest.py: Added.
1191         * Scripts/run-webkit-unittests:
1192
1193 2009-11-16  Eric Seidel  <eric@webkit.org>
1194
1195         Reviewed by Adam Barth.
1196
1197         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1198         https://bugs.webkit.org/show_bug.cgi?id=31530
1199
1200         * Scripts/bugzilla-tool:
1201
1202 2009-11-16  Eric Seidel  <eric@webkit.org>
1203
1204         Reviewed by Adam Barth.
1205
1206         bugzilla-tool needs apply-attachment
1207         https://bugs.webkit.org/show_bug.cgi?id=31528
1208
1209         * Scripts/bugzilla-tool:
1210          - Add ApplyAttachment command.
1211          - Abstract applying code into WebKitApplyingScripts.
1212          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1213         * Scripts/modules/bugzilla.py:
1214          - Add fetch_attachment and bug_id_for_attachment_id.
1215         * Scripts/modules/bugzilla_unittest.py:
1216          - Add test for new parsing.
1217          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1218
1219 2009-11-16  Eric Seidel  <eric@webkit.org>
1220
1221         Reviewed by Adam Barth.
1222
1223         Document check-style's use of force_clean.
1224
1225         * Scripts/bugzilla-tool:
1226         * Scripts/modules/scm.py:
1227
1228 2009-11-16  Adam Barth  <abarth@webkit.org>
1229
1230         Reviewed by Eric Seidel.
1231
1232         Move WorkQueue to its own file
1233         https://bugs.webkit.org/show_bug.cgi?id=31529
1234
1235         WorkQueue and WorkQueueDelegate are separate concerns from
1236         bugzilla-tool.  Also added a missing include to logging.py.
1237
1238         * Scripts/bugzilla-tool:
1239         * Scripts/modules/logging.py:
1240         * Scripts/modules/workqueue.py:
1241
1242 2009-11-16  Adam Barth  <abarth@webkit.org>
1243
1244         Reviewed by Eric Seidel.
1245
1246         Move OutputTee to logging.py.
1247
1248         * Scripts/bugzilla-tool:
1249         * Scripts/modules/logging.py:
1250
1251 2009-11-15  Adam Barth  <abarth@webkit.org>
1252
1253         Reviewed by Eric Seidel.
1254
1255         Refactor bugzilla-tool to allow for multiple queues
1256         https://bugs.webkit.org/show_bug.cgi?id=31513
1257
1258         Divide the commit queue class into three class to make creating
1259         additional queues easier.
1260
1261         * Scripts/bugzilla-tool:
1262
1263 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1264
1265         Reviewed by Eric Seidel.
1266
1267         svn-apply may not handle git patches created by bugzilla-tool
1268         https://bugs.webkit.org/show_bug.cgi?id=31457
1269
1270         * Scripts/modules/scm.py:
1271         * Scripts/modules/scm_unittest.py:
1272
1273 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1274
1275         Reviewed by Eric Seidel.
1276
1277         bugzilla-tool should post git binary diff
1278         https://bugs.webkit.org/show_bug.cgi?id=31458
1279
1280         Add --binary option to Git.create_patch.
1281
1282         * Scripts/modules/scm.py:
1283         * Scripts/modules/scm_unittest.py:
1284
1285 2009-11-15  Adam Barth  <abarth@webkit.org>
1286
1287         Reviewed by Darin Adler.
1288
1289         Add bugzilla-tool check-style
1290         https://bugs.webkit.org/show_bug.cgi?id=31515
1291
1292         * Scripts/bugzilla-tool:
1293         * Scripts/modules/bugzilla.py:
1294
1295 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1296
1297         Reviewed by Simon Hausmann.
1298
1299         Make the Qt Linux only --valgrind feature, suppress errors
1300         defined in the SuppressedValgrindErrors file.
1301
1302         * Scripts/run-webkit-tests:
1303
1304 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1305
1306         Reviewed by Simon Hausmann.
1307
1308         Set the locale to C and not to the current one in use on the system.
1309
1310         * DumpRenderTree/qt/DumpRenderTree.cpp:
1311         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1312
1313 2009-11-13  Adam Roben  <aroben@apple.com>
1314
1315         Add support for
1316         http/tests/security/isolatedWorld/didClearWindowObject.html
1317
1318         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1319         window objects in isolated worlds are cleared
1320
1321         Reviewed by Dave Hyatt.
1322
1323         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1324
1325         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1326         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1327         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1328         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1329         Added. Sets a __worldID property on the global object whose value is
1330         the ID of this world.
1331         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1332         Respond to this new delegate callback by calling through to one of the
1333         above new methods.
1334         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1335         (worldMap): Added. Returns a HashMap containing all the worlds we've
1336         created.
1337         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1338         haven't kept track of this world.
1339         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1340         instead of declaring our own.
1341
1342         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1343
1344         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1345         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1346         didClearWindowObjectForFrameInStandardWorld.
1347         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1348         Respond to this new delegate callback by calling through to one of the
1349         below new methods.
1350         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1351         Added. Sets a __worldID property on the gobal object whose value is
1352         the ID of this world.
1353         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1354         Added. Moved code here from didClearWindowObject.
1355
1356         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1357         didClearWindowObjectForFrame* functions.
1358
1359         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1360         (worldMap): Added. Returns a HashMap containing all the worlds we've
1361         created.
1362         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1363         haven't kept track of this world.
1364         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1365         instead of declaring our own.
1366
1367 2009-11-13  Adam Roben  <aroben@apple.com>
1368
1369         Finish replacing worldIDs with world objects
1370
1371         The only remaining use of worldIDs was in a method only used by DRT
1372         for the isolated worlds tests.
1373
1374         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1375
1376         Reviewed by Mark Rowe.
1377
1378         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1379         (LayoutTestController::evaluateScriptInIsolatedWorld):
1380         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1381         (LayoutTestController::evaluateScriptInIsolatedWorld):
1382         Updated for changes to WebFrame. Now holds the map of worldID -> world
1383         at this level instead of making WebKit do it.
1384
1385 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1386
1387         Reviewed by Simon Hausmann.
1388
1389         [Qt] Ensure the DRT does not output anything until first test is run
1390
1391         * DumpRenderTree/qt/DumpRenderTree.cpp:
1392         * DumpRenderTree/qt/DumpRenderTree.h:
1393
1394 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1395
1396         Reviewed by Tor Arne Vestbø.
1397
1398         Clear the undo stack in before each new test run.
1399
1400         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1401
1402         * DumpRenderTree/qt/DumpRenderTree.cpp:
1403         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1404
1405 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1406
1407         Reviewed by Kenneth Rohde Christiansen.
1408
1409         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1410
1411         * DumpRenderTree/qt/DumpRenderTree.cpp:
1412         (WebCore::WebPage::resetSettings):
1413         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1414         (LayoutTestController::overridePreference):
1415
1416 2009-11-13  Eric Seidel  <eric@webkit.org>
1417
1418         Reviewed by Adam Barth.
1419
1420         Update committers.py based on svn records
1421         https://bugs.webkit.org/show_bug.cgi?id=31366
1422
1423         This list was generated using validate-committer-lists from
1424         https://bugs.webkit.org/show_bug.cgi?id=30970
1425         and makes committers.py current for committers who have
1426         committed in the last 3 years.
1427
1428         * Scripts/modules/committers.py:
1429
1430 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1431
1432         Reviewed by Adam Barth.
1433
1434         The document-open.html test was flaky at times. The test invokes the layout test plugin
1435         which in its destroy stream handler opens a new document. This basically tears down the
1436         stream and the associated plugin instance. The pluginLog function in the layout test
1437         plugin attempts to retrieve the window script object on a torn down plugin instance
1438         which crashed consistently on windows in the debugger. The functions which issue
1439         these logs already have a valid window script object. We now have variants of the pluginLog
1440         function which take in a window script object with and without variable arguments.
1441
1442         https://bugs.webkit.org/show_bug.cgi?id=31067
1443
1444         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1445         (pluginLogWithWindowObject):
1446         (pluginLogWithWindowObjectVariableArgs):
1447         (pluginLog):
1448         (notifyTestCompletion):
1449         (testDocumentOpen):
1450         (testWindowOpen):
1451
1452 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1453
1454         Reviewed by Gustavo Noronha Silva.
1455
1456         https://bugs.webkit.org/show_bug.cgi?id=30997
1457         [Gtk] Implemment AtkDocument
1458
1459         Added testing support.
1460
1461         * DumpRenderTree/AccessibilityUIElement.cpp:
1462         * DumpRenderTree/AccessibilityUIElement.h:
1463         (getDocumentEncodingCallback):
1464         (getDocumentURICallback):
1465         (AccessibilityUIElement::getJSClass):
1466         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1467         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1468         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1469         (AccessibilityUIElement::documentEncoding):
1470         (AccessibilityUIElement::documentURI):
1471
1472 2009-11-12  Adam Roben  <aroben@apple.com>
1473
1474         Replace worldIDs with world objects
1475
1476         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1477         user scripts/stylesheets and isolated worlds
1478
1479         Reviewed by Sam Weinig.
1480
1481         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1482         (LayoutTestController::addUserScript):
1483         (LayoutTestController::addUserStyleSheet):
1484         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1485         (LayoutTestController::addUserScript):
1486         (LayoutTestController::addUserStyleSheet):
1487         Changed these functions to create a new WebJSWorld each time they're
1488         called and to pass that world to WebKit.
1489
1490 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1491
1492         Reviewed by Oliver Hunt.
1493
1494         need to implement aria tree roles
1495         https://bugs.webkit.org/show_bug.cgi?id=31284
1496
1497         * DumpRenderTree/AccessibilityUIElement.cpp:
1498         (disclosedRowAtIndexCallback):
1499         (selectedRowAtIndexCallback):
1500         (isEqualCallback):
1501         (isAttributeSettableCallback):
1502         (isActionSupportedCallback):
1503         (disclosedByRowCallback):
1504         (hierarchicalLevelCallback):
1505         (AccessibilityUIElement::getJSClass):
1506         * DumpRenderTree/AccessibilityUIElement.h:
1507         (AccessibilityUIElement::isEqual):
1508         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1509         (AccessibilityUIElement::hierarchicalLevel):
1510         (AccessibilityUIElement::disclosedRowAtIndex):
1511         (AccessibilityUIElement::selectedRowAtIndex):
1512         (AccessibilityUIElement::disclosedByRow):
1513         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1514         (AccessibilityUIElement::getChildAtIndex):
1515         (AccessibilityUIElement::disclosedRowAtIndex):
1516         (AccessibilityUIElement::selectedRowAtIndex):
1517         (AccessibilityUIElement::titleUIElement):
1518         (AccessibilityUIElement::parentElement):
1519         (AccessibilityUIElement::disclosedByRow):
1520         (AccessibilityUIElement::hierarchicalLevel):
1521         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1522         (AccessibilityUIElement::hierarchicalLevel):
1523         (AccessibilityUIElement::disclosedRowAtIndex):
1524         (AccessibilityUIElement::selectedRowAtIndex):
1525         (AccessibilityUIElement::disclosedByRow):
1526
1527 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1528
1529         Reviewed by Darin Adler.
1530
1531         svn-apply can not handle git binary diffs
1532         https://bugs.webkit.org/show_bug.cgi?id=26830
1533
1534         Support "literal" type git binary diffs.
1535
1536         * Scripts/VCSUtils.pm:
1537         * Scripts/modules/scm_unittest.py:
1538         * Scripts/svn-apply:
1539
1540 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1541
1542         Not reviewed, removing duplicate entry for myself in committers.py.
1543
1544         * Scripts/modules/committers.py:
1545
1546 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1547
1548         Reviewed by Darin Adler and Mark Rowe.
1549
1550         https://bugs.webkit.org/show_bug.cgi?id=31200
1551         Tests in http/tests/security/mixedContent start to fail when new tests are added
1552
1553         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1554
1555 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1556
1557         Reviewed by Jan Alonzo.
1558
1559         Create, and display a window for the inspector, for inspector
1560         tests.
1561
1562         Need to also show/hide the inspector window to avoid having
1563         problems with code assuming it is realized
1564         https://bugs.webkit.org/show_bug.cgi?id=31347
1565
1566         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1567         (webInspectorShowWindow):
1568         (webInspectorCloseWindow):
1569         (webInspectorInspectWebView):
1570         (createWebView):
1571
1572 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1573
1574         Unreviewed Qt buildbot fix.
1575
1576         My previous fix was wrong, so revert that change and fix it by
1577         returning when the document of the frame has no document element.
1578         Idea is borrowed from mac and win DRT.
1579
1580         * DumpRenderTree/qt/DumpRenderTree.cpp:
1581         (WebCore::DumpRenderTree::dumpFramesAsText):
1582
1583 2009-11-11  Eric Seidel  <eric@webkit.org>
1584
1585         Reviewed byg Kenneth Rohde Christiansen.
1586
1587         Update Kenneth's committer record to include the email he
1588         uses on lists.webkit.org.
1589
1590         * Scripts/modules/committers.py:
1591
1592 2009-11-11  Eric Seidel  <eric@webkit.org>
1593
1594         Reviewed by Gustavo Noronha Silva.
1595
1596         Several committers use separate email addresses for bugzilla and svn.webkit.org
1597         https://bugs.webkit.org/show_bug.cgi?id=31364
1598
1599         Update records for existing committers to include email addresses
1600         used in svn.webkit.org and lists.webkit.org.
1601         Most committers use the same email address in all 3 places, but some use
1602         separate addresses.  committers.py needs record of each of these addresses.
1603
1604         * Scripts/modules/committers.py:
1605
1606 2009-11-11  Eric Seidel  <eric@webkit.org>
1607
1608         No review, adding second email address for an existing committer.
1609
1610         Add Yong Li's second bugzilla account to his committer record.
1611         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1612
1613         * Scripts/modules/committers.py:
1614
1615 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1616
1617         Reviewed by Simon Hausmann.
1618
1619         If the frame has no innerText don't append it, and
1620         do not add a newline which breaks some cross platform
1621         results.
1622
1623         * DumpRenderTree/qt/DumpRenderTree.cpp:
1624         (WebCore::DumpRenderTree::dumpFramesAsText):
1625
1626 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1627
1628         Reviewed by Simon Hausmann.
1629
1630         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1631
1632         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1633         (webkit_test_plugin_new_instance):
1634         (webkit_test_plugin_destroy_instance):
1635         (webkit_test_plugin_destroy_stream):
1636
1637 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1638
1639         Reviewed by Mark Rowe.
1640
1641         Implement the functionality needed by plugins/window-open.html
1642
1643         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1644         (webkit_test_plugin_new_instance):
1645         (webkit_test_plugin_set_window):
1646
1647 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1648
1649         Reviewed by Simon Hausmann.
1650
1651         [Qt] Force -graphicssystem raster and -style windows when running DRT
1652
1653         * DumpRenderTree/qt/main.cpp:
1654         * Scripts/run-webkit-tests:
1655
1656 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1657
1658         Reviewed by Simon Hausmann.
1659
1660         Compute correct library paths for Qt
1661
1662         * Scripts/webkitdirs.pm:
1663
1664 2009-11-10  Mark Rowe  <mrowe@apple.com>
1665
1666         Reviewed by Sam Weinig.
1667
1668         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1669
1670         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1671         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1672         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1673         that had enabled frame load delegate logging this would result in extra log messages being generated,
1674         causing the test to fail.
1675
1676         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1677         tests.
1678
1679         * DumpRenderTree/mac/DumpRenderTree.mm:
1680         (dumpRenderTree):
1681         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1682         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1683
1684 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1685
1686         Reviewed by Kenneth Rohde Christiansen.
1687
1688         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1689
1690         * DumpRenderTree/qt/DumpRenderTree.cpp:
1691         (WebCore::DumpRenderTree::DumpRenderTree):
1692
1693 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1694
1695         Reviewed by Jan Alonzo.
1696
1697         [GTK] Remove WebSocket configuration from WebKitWebSettings
1698         https://bugs.webkit.org/show_bug.cgi?id=31244
1699
1700         Follow-up of r50724. Don't set the enable-web-socket property
1701         anymore.
1702
1703         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1704         (resetDefaultsToConsistentValues):
1705
1706 2009-11-10  Oliver Hunt  <oliver@apple.com>
1707
1708         Reviewed by Maciej Stachowiak.
1709
1710         Rename 3D Canvas related classes to use WebGL prefix
1711         https://bugs.webkit.org/show_bug.cgi?id=29095
1712
1713         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1714         and upate webkitdirs script to new method of testing for WebGL.
1715
1716         * Scripts/do-webcore-rename:
1717         * Scripts/webkitdirs.pm:
1718
1719 2009-11-09  Oliver Hunt  <oliver@apple.com>
1720
1721         Reviewed by Geoff Garen.
1722
1723         Make do-webcore-rename work with git.
1724
1725         * Scripts/do-webcore-rename:
1726
1727 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1728
1729         Adding Kenneth to the reviewers list.
1730
1731         * Scripts/modules/committers.py:
1732
1733 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1734
1735         Reviewed by Jan Alonzo.
1736
1737         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1738         https://bugs.webkit.org/show_bug.cgi?id=30482
1739
1740         LayoutTestControllerGtk now uses the exposed
1741         Page::tabKeyCyclesThroughElements API
1742
1743         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1744         (LayoutTestController::setTabKeyCyclesThroughElements):
1745
1746 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1747
1748         Reviewed by Holger Freyther.
1749
1750         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1751         This helps to pass the test case below. Also replaced hardcoded
1752         code numbers with defined constants.
1753         https://bugs.webkit.org/show_bug.cgi?id=31185
1754
1755         Test: editing/undo/undo-deleteWord.html
1756
1757         * DumpRenderTree/qt/EventSenderQt.cpp:
1758         (EventSender::keyDown):
1759
1760 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1761
1762         Reviewed by Holger Freyther.
1763
1764         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1765         https://bugs.webkit.org/show_bug.cgi?id=31164
1766
1767         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1768
1769         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1770         (LayoutTestController::processWork):
1771
1772 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1773
1774         Reviewed by Holger Freyther.
1775
1776         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1777         https://bugs.webkit.org/show_bug.cgi?id=31158
1778
1779         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1780         always, which from WorkQueue prospective means that a load has been started
1781         and the queue processing should stop and wait for the load to finish.
1782         Spinning it off into a loading and a non-loading variants was the solution
1783         adopted by Mac's DRT to work around this problem. The former keeps returning
1784         'true' while the later executes the script synchronously and returns 'false'
1785         making it possible to the WorkQueue to proceed right away.
1786
1787         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1788         (LayoutTestController::processWork):
1789         (LayoutTestController::queueLoadingScript):
1790         (LayoutTestController::queueNonLoadingScript):
1791         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1792         * DumpRenderTree/qt/WorkQueueItem.h:
1793         (LoadingScriptItem::LoadingScriptItem):
1794         (LoadingScriptItem::invoke):
1795         (NonLoadingScriptItem::NonLoadingScriptItem):
1796         (NonLoadingScriptItem::invoke):
1797
1798 2009-11-07  Mark Rowe  <mrowe@apple.com>
1799
1800         Rubber-stamped by Cameron Zwarich.
1801
1802         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1803
1804         * Scripts/commit-log-editor:
1805
1806 2009-11-07  Mark Rowe  <mrowe@apple.com>
1807
1808         Reviewed by Darin Adler.
1809
1810         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1811         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1812
1813         Move logic for determining the name and email address to use in a ChangeLog entry from
1814         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1815         whether the author of the patch matches committer, and therefore needs access to the
1816         email address that would be used in a ChangeLog entry.
1817
1818         Based on a patch by Pierre d'Herbemont.
1819
1820         * Scripts/VCSUtils.pm:
1821         * Scripts/commit-log-editor:
1822         * Scripts/prepare-ChangeLog:
1823         * Scripts/webkitdirs.pm:
1824
1825 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1826
1827         Reviewed by Adam Barth.
1828
1829         Added functionality to the layout test plugin to invoke document.open and
1830         window.open with default arguments. The associated webkit bug is
1831         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1832         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1833         work in Chromium (V8) if there is no calling javascript context. To achieve this
1834         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1835         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1836
1837         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1838         (testDocumentOpen):
1839         (testWindowOpen):
1840         (pluginAllocate):
1841         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1842         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1843         (NPP_New):
1844         (NPP_SetWindow):
1845         (NPP_DestroyStream):
1846         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1847         (NPP_New):
1848         (NPP_SetWindow):
1849         (NPP_NewStream):
1850         (NPP_DestroyStream):
1851
1852 2009-11-06  Eric Seidel  <eric@webkit.org>
1853
1854         Reviewed by Adam Barth.
1855
1856         bugzilla-tool crashed with exception
1857         https://bugs.webkit.org/show_bug.cgi?id=31092
1858
1859         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1860
1861 2009-11-04  Eric Seidel  <eric@webkit.org>
1862
1863         No review, just add a line which got left out of the patch uploaded for commit.
1864
1865         commit-queue is crashing when trying to reject patches after unknown failures
1866         https://bugs.webkit.org/show_bug.cgi?id=31091
1867
1868         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1869
1870 2009-11-04  Adam Roben  <aroben@apple.com>
1871
1872         Remove bogus else clause in bugzilla-tool
1873
1874         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1875         create-bug raises exception after entering bug description
1876
1877         Reviewed by David Kilzer.
1878
1879         * Scripts/bugzilla-tool:
1880         (CreateBug): else clauses are only hit if no exception is raised, so
1881         it makes no sense to try to re-raise the exception in an else clause.
1882         The exception will automatically be re-raised if it doesn't match any
1883         of the except clauses, so we don't have to do anything special here at
1884         all to get the desired behavior.
1885
1886 2009-11-04  Eric Seidel  <eric@webkit.org>
1887
1888         Reviewed by David Kilzer.
1889
1890         svn-apply's fixChangeLogPatch function seems broken
1891         https://bugs.webkit.org/show_bug.cgi?id=30683
1892
1893         Update fixChangeLogPatch to be able to handle patches which
1894         don't start at line 1.
1895         Add unit tests for svn-apply to scm_unittest.py.
1896
1897         * Scripts/VCSUtils.pm:
1898         * Scripts/modules/scm_unittest.py:
1899
1900 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1901
1902         Reviewed by Beth Dakin.
1903
1904         Need to implement ARIA role="combobox"
1905         https://bugs.webkit.org/show_bug.cgi?id=31096
1906
1907         * DumpRenderTree/AccessibilityUIElement.cpp:
1908         (showMenuCallback):
1909         (getIsExpandedCallback):
1910         (AccessibilityUIElement::getJSClass):
1911         * DumpRenderTree/AccessibilityUIElement.h:
1912         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1913         (AccessibilityUIElement::isExpanded):
1914         (AccessibilityUIElement::showMenu):
1915         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1916         (AccessibilityUIElement::isExpanded):
1917         (AccessibilityUIElement::showMenu):
1918         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1919         (AccessibilityUIElement::isSelected):
1920         (AccessibilityUIElement::isExpanded):
1921         (AccessibilityUIElement::showMenu):
1922
1923 2009-11-04  Eric Seidel  <eric@webkit.org>
1924
1925         Reviewed by Adam Barth.
1926
1927         commit-queue is crashing when trying to reject patches after unknown failures
1928         https://bugs.webkit.org/show_bug.cgi?id=31091
1929
1930         * Scripts/bugzilla-tool:
1931          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1932            so we have to find out what the current patch is by asking bugzilla again.
1933          - Discovered that this code was also leaking file descriptors, so fixed that.
1934
1935 2009-11-04  Adam Roben  <aroben@apple.com>
1936
1937         Make run-webkit-tests work for the Debug_Internal Windows
1938         configuration
1939
1940         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1941         suffix.
1942
1943         Fixes <http://webkit.org/b/31123>.
1944
1945         Reviewed by Sam Weinig.
1946
1947         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1948         Debug_Internal, either.
1949
1950 2009-11-04  Eric Seidel  <eric@webkit.org>
1951
1952         Reviewed by Adam Barth.
1953
1954         committers.py needs a way to store non-bugzilla email addresses
1955         https://bugs.webkit.org/show_bug.cgi?id=31037
1956
1957         Make Committer and Reviewer constructors take a single email or a list of emails.
1958         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1959         Expose reviewers(), used by validate-committer-lists on bug 30970.
1960
1961         * Scripts/modules/committers.py:
1962         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1963
1964 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1965
1966         Reviewed by David Levin.
1967
1968         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1969         https://bugs.webkit.org/show_bug.cgi?id=27491
1970
1971         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1972         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1973
1974         Functions to start or stop Web Socket servers are added.
1975
1976         * Scripts/run-webkit-tests:
1977
1978 2009-11-03  Eric Seidel  <eric@webkit.org>
1979
1980         No review, just changing wording of log message.
1981
1982         Change log string to say "failed" instead of "rejected"
1983         when a commit fails due to an out of date checkout.
1984         This makes grepping the commit-queue log for rejected patches easier.
1985
1986         * Scripts/bugzilla-tool:
1987
1988 2009-11-03  Eric Seidel  <eric@webkit.org>
1989
1990         No review, adding commonly known committers missing from the file.
1991
1992         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1993
1994 2009-11-03  Eric Seidel  <eric@webkit.org>
1995
1996         No review, just sort-order cleanup.
1997
1998         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1999
2000 2009-11-03  Stephen White  <senorblanco@chromium.org>
2001
2002         (Unreviewed).
2003
2004         Add myself to committers.py.
2005
2006         * Scripts/modules/committers.py:
2007
2008 2009-11-03  Robin Dunn  <robin@alldunn.com>
2009
2010         Reviewed by Kevin Ollviier.
2011
2012         Add packaging scripts for Debian-based Linux distros.
2013
2014         https://bugs.webkit.org/show_bug.cgi?id=31075
2015
2016         * wx/packaging/build-debian-installer.py: Added.
2017         * wx/packaging/debian: Added.
2018
2019 2009-11-03  Dan Bernstein  <mitz@apple.com>
2020
2021         Reviewed by Anders Carlsson and Beth Dakin.
2022
2023         https://bugs.webkit.org/show_bug.cgi?id=31070
2024
2025         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2026         destroyed, it executes the value of the 'ondestroy' parameter as a
2027         script.
2028
2029         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2030         (pluginAllocate): Initialize onDestroy.
2031         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2032         onDestroy.
2033         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2034         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2035         specified.
2036         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2037
2038 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2039
2040         Reviewed by Xan Lopez.
2041
2042         https://bugs.webkit.org/show_bug.cgi?id=31035
2043         [GTK] some accessibility tests hitting assertion in debug builds
2044
2045         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2046
2047         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2048         (AccessibilityController::rootElement):
2049
2050 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2051
2052         Reviewed by Beth Dakin.
2053
2054         Support ARIA "tab" roles
2055         https://bugs.webkit.org/show_bug.cgi?id=30842
2056
2057         * DumpRenderTree/AccessibilityUIElement.cpp:
2058         * DumpRenderTree/AccessibilityUIElement.h:
2059         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2060         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2061         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2062
2063 2009-11-01  Eric Seidel  <eric@webkit.org>
2064
2065         Reviewed by David Levin.
2066
2067         buildbots should use --exit-after-N-failures
2068         https://bugs.webkit.org/show_bug.cgi?id=30809
2069
2070         Make the bots exit after 20 failures to prevent never-ending
2071         test runs where every test spends a minute crashing.
2072
2073         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2074
2075 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2076
2077         Reviewed by Eric Seidel.
2078
2079         Turn on warnings for QtWebKit for gcc
2080         https://bugs.webkit.org/show_bug.cgi?id=30958
2081
2082         * DumpRenderTree/qt/main.cpp:
2083         (crashHandler): Mark function NO_RETURN
2084
2085 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2086
2087         Adding myself to the committers list.
2088
2089         * Scripts/modules/committers.py:
2090
2091 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2092
2093         Fix an issue that Adam noticed in DRT.
2094
2095         Reviewed by Darin Adler.
2096
2097         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2098         (AccessibilityUIElement::role):
2099         Get the length of the role text, and create a buffer dynamically.
2100
2101 2009-10-30  Eric Seidel  <eric@webkit.org>
2102
2103         No review, rolling out r50105.
2104         http://trac.webkit.org/changeset/50105
2105
2106         This commit was causing:
2107         https://bugs.webkit.org/show_bug.cgi?id=30869
2108         We'll re-implement the feature a different way.
2109
2110         * Scripts/bugzilla-tool:
2111
2112 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2113
2114         Test for MSAA: Accessibility of headings is not correct
2115
2116         https://bugs.webkit.org/show_bug.cgi?id=30937
2117
2118         Reviewed by Adam Roben.
2119
2120         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2121         (AccessibilityUIElement::role):
2122         Allow the role returned to be a BSTR.
2123         (AccessibilityUIElement::description):
2124         Fix a copy/paste error.
2125
2126 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2127
2128         Test for MSAA: Accessibility of links is wrong
2129
2130         https://bugs.webkit.org/show_bug.cgi?id=30928
2131
2132         Reviewed by Darin Adler.
2133
2134         * DumpRenderTree/AccessibilityUIElement.cpp:
2135         (getAccessibilityValueCallback):
2136         Return the accessibility value.
2137         (AccessibilityUIElement::getJSClass):
2138         Added "accessibilityValue" value.
2139
2140         * DumpRenderTree/AccessibilityUIElement.h:
2141
2142         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2143         (AccessibilityUIElement::accessibilityValue):
2144         Stubbed.
2145
2146         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2147         (AccessibilityUIElement::accessibilityValue):
2148         Stubbed.
2149
2150         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2151         (AccessibilityUIElement::accessibilityValue):
2152         Get the object's value, and return it as a JS string.
2153
2154 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2155
2156         Fix typo in command name used by wx build system.
2157
2158         * wx/build/build_utils.py:
2159
2160 2009-10-30  Adam Barth  <abarth@webkit.org>
2161
2162         Reviewed by Darin Adler.
2163
2164         Patch v1 is a dumb default name for patches
2165         https://bugs.webkit.org/show_bug.cgi?id=30952
2166
2167         Let's use "Patch" instead.
2168
2169         * Scripts/bugzilla-tool:
2170
2171 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2172
2173         Unreviewed trivial buildfix.
2174
2175         [Qt] Buildfix for r50333.
2176
2177         * DumpRenderTree/qt/DumpRenderTree.pro:
2178
2179 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2180
2181         Reviewed by Holger Freyther.
2182
2183         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2184         https://bugs.webkit.org/show_bug.cgi?id=30953
2185
2186         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2187         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2188         makes qt DRT to share this implementation (as gtk and mac ports do).
2189
2190         * DumpRenderTree/qt/DumpRenderTree.pro:
2191         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2192         * DumpRenderTree/qt/WorkQueue.h: Removed.
2193
2194 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2195
2196         Unreviewed potential buildbot fix.
2197
2198         Second try: Reset page history before running each test.
2199
2200         Apparently the QWebHistory::clear() keeps the current page
2201         in history which is not what we want, so we not additionally
2202         sets the history capacity to 0 (forces removing everything)
2203         and then sets it back to its original value.
2204
2205         * DumpRenderTree/qt/DumpRenderTree.cpp:
2206         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2207
2208 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2209
2210         Unreviewed potential buildbot fix.
2211
2212         Reset page history before running each test.
2213
2214         * DumpRenderTree/qt/DumpRenderTree.cpp:
2215         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2216
2217 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2218
2219         Reviewed by Eric Seidel.
2220
2221         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2222
2223         Bug 28420 -  Implement HTML5 <ruby> rendering
2224         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2225
2226         No new tests (no functional change).
2227
2228         * Scripts/build-webkit:
2229
2230 2009-10-29  Dan Bernstein  <mitz@apple.com>
2231
2232         Reviewed by Mark Rowe.
2233
2234         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2235         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2236         define it.
2237
2238         * Scripts/VCSUtils.pm:
2239         * Scripts/svn-apply:
2240         * Scripts/svn-unapply:
2241
2242 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2243
2244         Reviewed by Gustavo Noronha.
2245
2246         Use the GTK+ main loop instead of rolling our own mini-version of
2247         it.
2248
2249         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2250         (dump):
2251         (runTest):
2252         (webViewLoadFinished):
2253
2254 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2255
2256         Reviewed by Oliver Hunt.
2257
2258         Implement the Qt version of DRT dumpBackForwardList().
2259
2260         * DumpRenderTree/qt/DumpRenderTree.cpp:
2261         (WebCore::dumpHistoryItem):
2262         (WebCore::DumpRenderTree::dumpBackForwardList):
2263
2264 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2265
2266         Reviewed by Adam Roben.
2267
2268         Implement DRT functionality for Qt introduced in
2269         r28690 and r28705.
2270
2271         - Implemented pathToLocalResource which exposes the functionality of
2272         converting a given unix path to the correct location on Windows.
2273         - Implemented a way to remove machine-dependent information from paths
2274         in layout test results.
2275
2276         * DumpRenderTree/qt/DumpRenderTree.cpp:
2277         (WebCore::urlSuitableForTestResult):
2278         (WebCore::WebPage::javaScriptConsoleMessage):
2279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2280         (LayoutTestController::pathToLocalResource):
2281         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2282
2283 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2284
2285         Adding myself to the committers list.
2286
2287         * Scripts/modules/committers.py:
2288
2289 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2290
2291         Adding myself to the committers list.
2292
2293         * Scripts/modules/committers.py:
2294
2295 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2296
2297         Reviewed by Jan Alonzo.
2298
2299         [GTK] API to start inspector for a WebView
2300         https://bugs.webkit.org/show_bug.cgi?id=22551
2301
2302         Use the new inspector API to implement the LayoutTestController
2303         interfaces used to test the inspector.
2304
2305         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2306         (webInspectorInspectWebView):
2307         (createWebView):
2308         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2309         (LayoutTestController::showWebInspector):
2310         (LayoutTestController::closeWebInspector):
2311         (LayoutTestController::evaluateInWebInspector):
2312
2313 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2314
2315         Reviewed by Eric Seidel.
2316
2317         [Qt] WebFrame::counterValueForElementById must not be exposed
2318         https://bugs.webkit.org/show_bug.cgi?id=30882
2319
2320         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2321         (LayoutTestController::counterValueForElementById):
2322
2323 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2324
2325         Rubberstamped by Oliver Hunt.
2326
2327         Fix the warning:
2328
2329         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2330         declared with attribute warn_unused_result".
2331
2332         by actually checking the result. In the case it is null, an
2333         error has occoured, so treat it as the other fatal errors.
2334
2335         * DumpRenderTree/qt/DumpRenderTree.cpp:
2336         (WebCore::DumpRenderTree::initializeFonts):
2337
2338 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2339
2340         Reviewed by Darin Adler.
2341
2342         Provide a way to get counter values with layoutTestContoller
2343         https://bugs.webkit.org/show_bug.cgi?id=30555
2344
2345         Define layoutTestContoller.counterValueForElementById.
2346
2347         * DumpRenderTree/LayoutTestController.cpp:
2348         (counterValueForElementByIdCallback):
2349         (LayoutTestController::staticFunctions):
2350         * DumpRenderTree/LayoutTestController.h:
2351         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2352         (LayoutTestController::counterValueForElementById):
2353
2354 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2355
2356         Rubberstamped by Oliver Hunt.
2357
2358         Change two methods to be internal for DRT use only.
2359
2360         Part of [Qt] Review all new API in Qt 4.6
2361         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2362
2363         * DumpRenderTree/qt/DumpRenderTree.cpp:
2364         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2365         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2366         (LayoutTestController::whiteListAccessFromOrigin):
2367
2368 2009-10-27  Eric Seidel  <eric@webkit.org>
2369
2370         Reviewed by Adam Barth.
2371
2372         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2373         https://bugs.webkit.org/show_bug.cgi?id=30826
2374
2375         * Scripts/svn-apply:
2376          - Add () around all system() calls.
2377          - Use the correct system() == 0 or die instead of system() or die
2378          - Add descriptive messages to all die statements.
2379
2380 2009-10-27  Steve Block  <steveblock@google.com>
2381
2382         Reviewed by NOBODY.
2383
2384         Adds steveblock@google.com to list of committers.
2385
2386         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2387
2388 2009-10-27  Eric Seidel  <eric@webkit.org>
2389
2390         Reviewed by Adam Barth.
2391
2392         svn-apply can exit(0) even on patch failure
2393         https://bugs.webkit.org/show_bug.cgi?id=29622
2394
2395         * Scripts/svn-apply:
2396          - Add a bunch of "or die" statements, hopefully catching all
2397            possible cases where failure could still exit(0).
2398
2399 2009-10-27  Eric Seidel  <eric@webkit.org>
2400
2401         Reviewed by Adam Barth.
2402
2403         svn-* scripts should share code through VCSUtils.pm
2404         https://bugs.webkit.org/show_bug.cgi?id=30791
2405
2406         Just moving code into a shared location.
2407
2408         * Scripts/VCSUtils.pm:
2409         * Scripts/prepare-ChangeLog:
2410         * Scripts/resolve-ChangeLogs:
2411         * Scripts/svn-apply:
2412         * Scripts/svn-create-patch:
2413         * Scripts/svn-unapply:
2414         * Scripts/update-webkit:
2415
2416 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2417
2418         Suppress a huge number of MSVC warnings when building wxWebKit.
2419
2420         * wx/build/settings.py:
2421
2422 2009-10-26  Eric Seidel  <eric@webkit.org>
2423
2424         No review, just adding Mike Belshe to the committers list.
2425
2426         * Scripts/modules/committers.py:
2427
2428 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2429
2430         Reviewed by Darin Adler.
2431
2432         Make .rc files compile on Windows without depending on MFC headers
2433         https://bugs.webkit.org/show_bug.cgi?id=30750
2434
2435         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2436         windows.h instead of afxres.h because it exists even when MFC is not
2437         installed, and is all that's needed here.
2438
2439         * FindSafari/FindSafari.rc: Ditto
2440
2441 2009-10-24  Eric Seidel  <eric@webkit.org>
2442
2443         Reviewed by Adam Barth.
2444
2445         bugzilla-tool post-diff should know how to mark commit-queue=?
2446         https://bugs.webkit.org/show_bug.cgi?id=29202
2447
2448         * Scripts/bugzilla-tool:
2449          - Add --commit-queue option to post-diff, post-commits and create-bug.
2450         * Scripts/modules/bugzilla.py:
2451          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2452          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2453
2454 2009-10-23  Eric Seidel  <eric@webkit.org>
2455
2456         Reviewed by Adam Barth.
2457
2458         bugzilla-tool commit-queue does not notice modifications to committers.py
2459         https://bugs.webkit.org/show_bug.cgi?id=30084
2460
2461         * Scripts/bugzilla-tool:
2462          - Make commit-queue re-exec itself instead of using while(1).
2463          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2464          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2465
2466 2009-10-22  Eric Seidel  <eric@webkit.org>
2467
2468         Reviewed by Adam Barth.
2469
2470         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2471         https://bugs.webkit.org/show_bug.cgi?id=30634
2472
2473         * Scripts/bugzilla-tool:
2474          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2475          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2476
2477 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2478
2479         Reviewed by Eric Seidel.
2480
2481         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2482
2483         https://bugs.webkit.org/show_bug.cgi?id=30763
2484
2485         * pywebsocket/mod_pywebsocket/__init__.py:
2486         * pywebsocket/mod_pywebsocket/dispatch.py:
2487         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2488         * pywebsocket/mod_pywebsocket/standalone.py:
2489         * pywebsocket/setup.py:
2490         * pywebsocket/test/test_dispatch.py:
2491
2492 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2493
2494         Reviewed by David Levin.
2495
2496         REGRESSION: 2 failures in run-webkit-unittests
2497         https://bugs.webkit.org/show_bug.cgi?id=30645
2498
2499         * Scripts/modules/cpp_style_unittest.py:
2500         Fixed a few test scenarios which apparently lost some spaces from
2501         text literals.
2502
2503 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2504
2505         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2506
2507         * Scripts/webkitdirs.pm:
2508
2509 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2510
2511         Reviewed by Darin Adler.
2512
2513         Unification of using null device in perl scripts.
2514         https://bugs.webkit.org/show_bug.cgi?id=30572
2515
2516         * Scripts/VCSUtils.pm:
2517         * Scripts/bisect-builds:
2518         * Scripts/resolve-ChangeLogs:
2519         * Scripts/run-iexploder-tests:
2520         * Scripts/run-jsc:
2521         * Scripts/run-mangleme-tests:
2522         * Scripts/run-webkit-tests:
2523         * Scripts/webkitdirs.pm:
2524         Using File::Spec->devnull() instead of hard coded /dev/null.
2525
2526 2009-10-26  Eric Seidel  <eric@webkit.org>
2527
2528         Reviewed by Holger Freyther.
2529
2530         Reviewers are missing from committers.py
2531         https://bugs.webkit.org/show_bug.cgi?id=30733
2532
2533         * Scripts/modules/committers.py:
2534
2535 2009-10-23  Eric Seidel  <eric@webkit.org>
2536
2537         No review, only adding Alice to the list of reviewers.
2538
2539         * Scripts/modules/committers.py:
2540
2541 2009-10-23  Eric Seidel  <eric@webkit.org>
2542
2543         Reviewed by Eric Carlson.
2544
2545         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2546         https://bugs.webkit.org/show_bug.cgi?id=30700
2547
2548         * DumpRenderTree/mac/DumpRenderTree.mm:
2549         (resetDefaultsToConsistentValues): Update QuickTime version check.
2550
2551 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2552
2553         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2554         character measurement APIs that are private on Tiger.
2555
2556         * wx/build/settings.py:
2557
2558 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2559
2560         Reviewed by NOBODY (build fix).
2561         Build fix following bug #30696.
2562
2563         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2564         (LayoutTestController::evaluateScriptInIsolatedWorld):
2565
2566 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2567
2568         Reviewed by Sam Weinig & Geoff Garen.
2569
2570         https://bugs.webkit.org/show_bug.cgi?id=30696
2571         Enable isolated-worlds tests on mac.
2572
2573         Add private interface for DRT to invoke execution in a given world.
2574
2575         * DumpRenderTree/LayoutTestController.cpp:
2576         (evaluateScriptInIsolatedWorldCallback):
2577         (LayoutTestController::staticFunctions):
2578         * DumpRenderTree/LayoutTestController.h:
2579         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2580         (LayoutTestController::evaluateScriptInIsolatedWorld):
2581         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2582         (LayoutTestController::evaluateScriptInIsolatedWorld):
2583
2584 2009-10-21  Eric Seidel  <eric@webkit.org>
2585
2586         Reviewed by Adam Barth.
2587
2588         bugzilla-tool's "patch failed to download an apply" error should give more information
2589         https://bugs.webkit.org/show_bug.cgi?id=30632
2590
2591         * Scripts/modules/scm.py:
2592          - Use the common run_command method instead of custom POpen code.
2593          - Make run_command know how to take pipes as input.
2594         * Scripts/modules/scm_unittest.py:
2595          - Add new tests to cover change.
2596          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2597
2598 2009-10-21  Kent Tamura  <tkent@chromium.org>
2599
2600         Unreviewed.  Adding myself to the committers list.
2601
2602         * Scripts/modules/committers.py:
2603
2604 2009-10-21  Robin Dunn  <robin@alldunn.com>
2605
2606         Reviewed by Kevin Ollivier.
2607
2608         Update the Windows installer builder to work with Vista / Win 7 and with git.
2609
2610         https://bugs.webkit.org/show_bug.cgi?id=30649
2611
2612         * wx/build/build_utils.py:
2613         * wx/packaging/build-mac-installer.py:
2614         * wx/packaging/build-win-installer.py:
2615         * wx/packaging/wxWebKitInstaller.iss.in:
2616
2617 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2618
2619         Reviewed by Gustavo Noronha.
2620
2621         [GTK] Added conditional code to avoid using
2622         gdk_window_get_root_coords if we do not have a gtk+ release newer
2623         than 2.17.3.
2624         https://bugs.webkit.org/show_bug.cgi?id=30636
2625
2626         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2627
2628 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2629
2630         Reviewed by Eric Seidel.
2631
2632         [Qt] Added dummy implementation for keepWebHistory()
2633         https://bugs.webkit.org/show_bug.cgi?id=30592
2634
2635         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2636         (LayoutTestController::keepWebHistory):
2637         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2638
2639 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2640
2641         Reviewed by Xan Lopez.
2642
2643         [GTK] Fixed the double click condition, it is not double click if
2644         we move in just in one direction.
2645         https://bugs.webkit.org/show_bug.cgi?id=30636
2646
2647         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2648
2649 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2650
2651         Reviewed by Xan Lopez.
2652
2653         [GTK] Initialize the events completly before emitting them.
2654         https://bugs.webkit.org/show_bug.cgi?id=30633
2655
2656         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2657
2658 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2659
2660         wx build fix. Fix for when linking using --as-needed with gcc.
2661
2662         * wx/browser/wscript:
2663
2664 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2665
2666         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2667         to support all the features used by CURL backend.
2668
2669         * wx/build/settings.py:
2670         * wx/install-unix-extras:
2671
2672 2009-10-20  Anton Muhin  <antonm@chromium.org>
2673
2674         Reviewed by Adam Barth.
2675
2676         Add {ager,antonm,yurys}@chromium.org into committers.py
2677         https://bugs.webkit.org/show_bug.cgi?id=30560
2678
2679         * Scripts/modules/committers.py:
2680
2681 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2682
2683         Reviewed by Tor Arne Vestbø.
2684
2685         Make the Netscape Test plugin available to the Qt launcher.
2686
2687         * Scripts/run-launcher:
2688
2689 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2690
2691         Reviewed by David Levin.
2692
2693         Removed WebSocket runtime settings.
2694         https://bugs.webkit.org/show_bug.cgi?id=29896
2695
2696         WebSocket runtime configuration is supported by chromium/v8 only.
2697
2698         * DumpRenderTree/mac/DumpRenderTree.mm:
2699         (resetDefaultsToConsistentValues):
2700         * DumpRenderTree/win/DumpRenderTree.cpp:
2701         (resetDefaultsToConsistentValues):
2702
2703 2009-10-19  Nate Chapin  <japhet@chromium.org>
2704
2705         Reviewed by Adam Barth.
2706
2707         Add testFail() to test plugin so we can test our handling of a
2708         plugin invoke call returning false.
2709
2710         https://bugs.webkit.org/show_bug.cgi?id=30239
2711
2712         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2713         (pluginInvoke):
2714         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2715
2716 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2717
2718         Reviewed by Gustavo Noronha.
2719
2720         Enable DOM pasting when running layout tests.
2721
2722         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2723         (resetDefaultsToConsistentValues):
2724
2725 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2726
2727         Reviewed by Simon Hausmann.
2728
2729         Use the setPreferredContentsSize method instead
2730         of setFixedContentsSize, as the method has been renamed.
2731
2732         * DumpRenderTree/qt/DumpRenderTree.cpp:
2733         (WebCore::DumpRenderTree::open):
2734         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2735         (LayoutTestController::setFixedContentsSize):
2736
2737 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2738
2739         Reviewed by Dan Bernstein.
2740
2741         https://bugs.webkit.org/show_bug.cgi?id=30456
2742         Fixes for new Debug_All Windows build configuration.
2743
2744         * DumpRenderTree/win/DumpRenderTree.cpp:
2745         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2746         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2747
2748 2009-10-16  Eric Seidel  <eric@webkit.org>
2749
2750         Reviewed by Adam Barth.
2751
2752         commit-queue status bot should list which buildbot is blocking the queue
2753         https://bugs.webkit.org/show_bug.cgi?id=30452
2754
2755         Add new methods and testing.
2756
2757         * Scripts/bugzilla-tool:
2758         * Scripts/modules/buildbot.py:
2759         * Scripts/modules/buildbot_unittest.py:
2760
2761 2009-10-16  Eric Seidel  <eric@webkit.org>
2762
2763         Reviewed by Adam Barth.
2764
2765         run-webkit-tests fails when CWD is not inside a WebKit checkout
2766         https://bugs.webkit.org/show_bug.cgi?id=30451
2767
2768         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2769         * Scripts/modules/scm_unittest.py:
2770           - Remove use of original_path (we don't need to restore the CWD).
2771           - Don't use '.' to find the webkit checkout, use __file__ instead.
2772
2773 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2774
2775         Reviewed by Adam Roben.
2776
2777         Add a Debug_All configuration to build entire stack as debug.
2778         Change Debug_Internal to:
2779         - stop using _debug suffix for all WebKit/Safari binaries
2780         - not use _debug as a DLL naming suffix
2781         - use non-debug C runtime lib.
2782
2783         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2784         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2785         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2786         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2787         Add missing debug.vsprops inherited property sheet.
2788         Add Debug_All configuration.
2789         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2790         * WinLauncher/WinLauncher.vcproj:
2791         Removed extraneous definitions inherited from vsprops.
2792         Add Debug_All configuration.
2793
2794 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2795
2796         Reviewed by David Levin.
2797
2798         check-webkit-style is wrong about indent checking in namespaces
2799         in header files and a few other things
2800         https://bugs.webkit.org/show_bug.cgi?id=30362
2801
2802         The few other things include:
2803         + check-webkit-style does not require spaces around the equal sign
2804           inside 'if' statements and around binary operators that take
2805           numeric literals.
2806         + check-webkit-style reports false errors for the / operator
2807           when part of a filename in the #include directive.
2808
2809         * Scripts/modules/cpp_style.py:
2810         Improved indentation checking and space checking around
2811         binary operators. While the checks are still not perfect,
2812         they are clearly better than before.
2813         * Scripts/modules/cpp_style_unittest.py:
2814         Added test cases for the newly supported checks and modified old
2815         test cases to match the new guidelines
2816
2817 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2818
2819         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2820
2821         * wx/build/settings.py:
2822
2823 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2824
2825         Reviewed by David Levin.
2826
2827         Add mod_pywebsocket to test Web Sockets.
2828         http://code.google.com/p/pywebsocket/
2829         https://bugs.webkit.org/show_bug.cgi?id=27490
2830
2831         * pywebsocket/COPYING: Added.
2832         * pywebsocket/MANIFEST.in: Added.
2833         * pywebsocket/README: Added.
2834         * pywebsocket/example/echo_client.py: Added.
2835         * pywebsocket/example/echo_wsh.py: Added.
2836         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2837         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2838         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2839         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2840         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2841         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2842         * pywebsocket/mod_pywebsocket/util.py: Added.
2843         * pywebsocket/setup.py: Added.
2844         * pywebsocket/test/config.py: Added.
2845         * pywebsocket/test/mock.py: Added.
2846         * pywebsocket/test/run_all.py: Added.
2847         * pywebsocket/test/test_dispatch.py: Added.
2848         * pywebsocket/test/test_handshake.py: Added.
2849         * pywebsocket/test/test_mock.py: Added.
2850         * pywebsocket/test/test_msgutil.py: Added.
2851         * pywebsocket/test/test_util.py: Added.
2852         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2853         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2854         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2855         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2856         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2857         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2858         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2859         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2860
2861 2009-10-15  James Robinson  <jamesr@google.com>
2862
2863         Reviewed by David Levin.
2864
2865         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2866
2867         https://bugs.webkit.org/show_bug.cgi?id=30426
2868
2869         * Scripts/modules/cpp_style.py:
2870         * Scripts/modules/cpp_style_unittest.py:
2871
2872 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2873
2874         Reviewed by Adam Roben.
2875
2876         Fixes <http://webkit.org/b/30411>.
2877         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2878
2879         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2880         building Chromium.
2881
2882         * Scripts/pdevenv:
2883
2884 2009-10-15  Robin Dunn  <robin@alldunn.com>
2885
2886         Reviewed by Kevin Ollivier.
2887
2888         Add Mac package building scripts for wx.
2889
2890         https://bugs.webkit.org/show_bug.cgi?id=30405
2891
2892         * wx/build/build_utils.py:
2893         * wx/build/settings.py:
2894         * wx/packaging/build-mac-installer.py: Added.
2895
2896 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2897
2898         Reviewed by Gustavo Noronha.
2899
2900         Enable Web Sockets support when running layout tests.
2901
2902         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2903         (resetDefaultsToConsistentValues):
2904
2905 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2906
2907         Reviewed by Gustavo Noronha.
2908
2909         Need to initialize event.button.button, since in most cases a
2910         button number is not passed as an argument.
2911
2912         * DumpRenderTree/gtk/EventSender.cpp:
2913         (mouseDownCallback):
2914         (mouseUpCallback):
2915
2916 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2917
2918         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2919         the OS if none was explicitly set.
2920
2921         * wx/build/settings.py:
2922
2923 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2924
2925         Reviewed by Timothy Hatcher.
2926
2927         Web Inspector: enable developers extras within inspector layout tests.
2928
2929         https://bugs.webkit.org/show_bug.cgi?id=30014
2930
2931         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2932         (LayoutTestController::showWebInspector):
2933         (LayoutTestController::closeWebInspector):
2934         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2935         (LayoutTestController::showWebInspector):
2936         (LayoutTestController::closeWebInspector):
2937
2938 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2939
2940         Reviewed by Jan Alonzo.
2941
2942         GtkLauncher is using a deprecated signal
2943         https://bugs.webkit.org/show_bug.cgi?id=30364
2944
2945         Modified GtkLauncher to use notify::title signal instead of
2946         deprecated title-changed signal
2947
2948         * GtkLauncher/main.c:
2949         (notify_title_cb):
2950         (create_browser):
2951
2952 2009-10-14  Brady Eidson  <beidson@apple.com>
2953
2954         Reviewed by Sam Weinig.
2955
2956         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2957         1 - Disables WebHistory
2958         2 - Doesn't make sense in that context anyway.
2959
2960         * DumpRenderTree/win/DumpRenderTree.cpp:
2961         (createWebViewAndOffscreenWindow):
2962
2963 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2964
2965         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2966         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2967
2968         * wx/build/settings.py:
2969         * wx/install-unix-extras:
2970
2971 2009-10-14  Brady Eidson  <beidson@apple.com>
2972
2973         Reviewed by Sam Weinig.
2974
2975         WebKit Win API should provide a delegate interface for global history.
2976         https://bugs.webkit.org/show_bug.cgi?id=29905
2977
2978         * DumpRenderTree/LayoutTestController.cpp:
2979         (LayoutTestController::LayoutTestController):
2980         * DumpRenderTree/LayoutTestController.h:
2981         (LayoutTestController::dumpHistoryDelegateCallbacks):
2982         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2983
2984         * DumpRenderTree/win/DumpRenderTree.cpp:
2985         (shouldLogHistoryDelegates):
2986         (runTest):
2987         (createWebViewAndOffscreenWindow):
2988         (main):
2989         * DumpRenderTree/win/DumpRenderTree.vcproj:
2990
2991         Add the IWebHistoryDelegate to DRT Windows:
2992         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2993         (wstringFromBSTR):
2994         (HistoryDelegate::HistoryDelegate):
2995         (HistoryDelegate::~HistoryDelegate):
2996         (HistoryDelegate::QueryInterface):
2997         (HistoryDelegate::AddRef):
2998         (HistoryDelegate::Release):
2999         (HistoryDelegate::didNavigateWithNavigationData):
3000         (HistoryDelegate::didPerformClientRedirectFromURL):
3001         (HistoryDelegate::didPerformServerRedirectFromURL):
3002         (HistoryDelegate::updateHistoryTitle):
3003         (HistoryDelegate::populateVisitedLinksForWebView):
3004         * DumpRenderTree/win/HistoryDelegate.h: Added.
3005
3006         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3007         (LayoutTestController::removeAllVisitedLinks):
3008
3009 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3010
3011         Reviewed by Simon Hausmann.
3012
3013         [Qt] Implement support for setPOSIXLocale on Qt.
3014         https://bugs.webkit.org/show_bug.cgi?id=30268
3015
3016         * DumpRenderTree/qt/DumpRenderTree.cpp:
3017         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3018         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3019         (LayoutTestController::setPOSIXLocale):
3020         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3021
3022 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3023
3024         Unreviewed, adding myself to reviewers list.
3025
3026         * Scripts/modules/committers.py:
3027
3028 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3029
3030         Reviewed by Mark Rowe.
3031
3032         Fix null assignment so root tests work again.
3033
3034         * Scripts/webkitdirs.pm:
3035
3036 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3037
3038         Reviewed by Simon Hausmann.
3039
3040         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3041         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3042         This is done in preparation of implementing missing features in DRT.
3043         No functionality changes made yet.
3044
3045         * DumpRenderTree/qt/DumpRenderTree.cpp:
3046         * DumpRenderTree/qt/DumpRenderTree.pro:
3047         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3048         (EventSender::EventSender):
3049         (EventSender::mouseDown):
3050         (EventSender::mouseUp):
3051         (EventSender::mouseMoveTo):
3052         (EventSender::leapForward):
3053         (EventSender::keyDown):
3054         (EventSender::contextClick):
3055         (EventSender::scheduleAsynchronousClick):
3056         (EventSender::frameUnderMouse):
3057         * DumpRenderTree/qt/EventSenderQt.h: Added.
3058         (EventSender::clearKillRing):
3059         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3060         (LayoutTestController::LayoutTestController):
3061         (LayoutTestController::reset):
3062         (LayoutTestController::processWork):
3063         (LayoutTestController::maybeDump):
3064         (LayoutTestController::waitUntilDone):
3065         (LayoutTestController::notifyDone):
3066         (LayoutTestController::windowCount):
3067         (LayoutTestController::clearBackForwardList):
3068         (LayoutTestController::dumpEditingCallbacks):
3069         (LayoutTestController::dumpResourceLoadCallbacks):
3070         (LayoutTestController::queueBackNavigation):
3071         (LayoutTestController::queueForwardNavigation):
3072         (LayoutTestController::queueLoad):
3073         (LayoutTestController::queueReload):
3074         (LayoutTestController::queueScript):
3075         (LayoutTestController::provisionalLoad):
3076         (LayoutTestController::timerEvent):
3077         (LayoutTestController::encodeHostName):
3078         (LayoutTestController::decodeHostName):
3079         (LayoutTestController::setJavaScriptProfilingEnabled):
3080         (LayoutTestController::setFixedContentsSize):
3081         (LayoutTestController::setPrivateBrowsingEnabled):
3082         (LayoutTestController::setPopupBlockingEnabled):
3083         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3084         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3085         (LayoutTestController::numberOfActiveAnimations):
3086         (LayoutTestController::disableImageLoading):
3087         (LayoutTestController::dispatchPendingLoadRequests):
3088         (LayoutTestController::setDatabaseQuota):
3089         (LayoutTestController::clearAllDatabases):
3090         (LayoutTestController::whiteListAccessFromOrigin):
3091         (LayoutTestController::waitForPolicyDelegate):
3092         (LayoutTestController::overridePreference):
3093         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3094         (LayoutTestController::isLoading):
3095         (LayoutTestController::setLoading):
3096         (LayoutTestController::shouldDumpAsText):
3097         (LayoutTestController::shouldDumpBackForwardList):
3098         (LayoutTestController::shouldDumpChildrenAsText):
3099         (LayoutTestController::shouldDumpDatabaseCallbacks):
3100         (LayoutTestController::shouldDumpStatusCallbacks):
3101         (LayoutTestController::shouldWaitUntilDone):
3102         (LayoutTestController::canOpenWindows):
3103         (LayoutTestController::shouldDumpTitleChanges):
3104         (LayoutTestController::waitForPolicy):
3105         (LayoutTestController::dumpAsText):
3106         (LayoutTestController::dumpChildFramesAsText):
3107         (LayoutTestController::dumpDatabaseCallbacks):
3108         (LayoutTestController::dumpStatusCallbacks):
3109         (LayoutTestController::setCanOpenWindows):
3110         (LayoutTestController::dumpBackForwardList):
3111         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3112         (LayoutTestController::display):
3113         (LayoutTestController::dumpTitleChanges):
3114         (LayoutTestController::dumpSelectionRect):
3115         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3116         (TextInputController::TextInputController):
3117         (TextInputController::doCommand):
3118         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3119         * DumpRenderTree/qt/WorkQueue.cpp:
3120         * DumpRenderTree/qt/WorkQueue.h:
3121         * DumpRenderTree/qt/WorkQueueItem.h:
3122         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3123         (findFrameNamed):
3124         (LoadItem::invoke):
3125         (ReloadItem::invoke):
3126         (ScriptItem::invoke):
3127         (BackForwardItem::invoke):
3128         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3129         * DumpRenderTree/qt/jsobjects.h:
3130
3131 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3132
3133         Not reviewed, adding myself to the list of reviewers.
3134
3135         * Scripts/modules/committers.py:
3136
3137 2009-10-13  Anders Carlsson  <andersca@apple.com>
3138
3139         Reviewed by Sam Weinig.
3140
3141         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3142
3143         Make the private browsing mode testable by the test plug-in.
3144
3145         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3146         (pluginGetProperty):
3147         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3148         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3149         (NPP_New):
3150         (NPP_SetValue):
3151
3152 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3153
3154         No review, just adding self to the list of reviewers.
3155
3156         * Scripts/modules/committers.py:
3157
3158 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3159
3160         Reviewed by Adam Roben.
3161
3162         Web Inspector: Use proper web view in inspector layout
3163         tests for windows.
3164
3165         https://bugs.webkit.org/show_bug.cgi?id=30298
3166
3167         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3168         (LayoutTestController::showWebInspector):
3169         (LayoutTestController::closeWebInspector):
3170         (LayoutTestController::evaluateInWebInspector):
3171
3172 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3173
3174         Reviewed by Sam Weinig.
3175
3176         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3177         https://bugs.webkit.org/show_bug.cgi?id=29841
3178
3179         * DumpRenderTree/mac/DumpRenderTree.mm:
3180         (resetDefaultsToConsistentValues):
3181         * DumpRenderTree/win/DumpRenderTree.cpp:
3182         (resetDefaultsToConsistentValues):
3183
3184 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3185
3186         Reviewed by Dimitri Glazkov.
3187
3188         Chromium Port - Windows
3189         https://bugs.webkit.org/show_bug.cgi?id=29969
3190
3191         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3192         * Scripts/webkitdirs.pm:
3193
3194 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3195
3196         Reviewed by Darin Adler.
3197
3198         jsc scripts cleanup and Qt/GTK fix
3199         https://bugs.webkit.org/show_bug.cgi?id=30288
3200
3201         Duplicated jscPath() moved to webkitdirs.pm.
3202         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3203         Configuration added (release/debug) to path for Qt-port on Windows.
3204
3205         * Scripts/run-javascriptcore-tests:
3206         * Scripts/run-jsc:
3207         * Scripts/run-sunspider:
3208         * Scripts/sunspider-compare-results:
3209         * Scripts/webkitdirs.pm:
3210
3211 2009-10-11  Adam Barth  <abarth@webkit.org>
3212
3213         Unreviewed.  Add Collin to committers.py.
3214
3215         * Scripts/modules/committers.py:
3216
3217 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3218
3219         wx build fix, add bindings to source/include dirs now that there are sources there.
3220
3221         * wx/build/settings.py:
3222
3223 2009-10-09  Mark Rowe  <mrowe@apple.com>
3224
3225         Reviewed by Brady Eidson.
3226
3227         Enable plug-in halting in DumpRenderTree.
3228
3229         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3230         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3231
3232         * DumpRenderTree/mac/DumpRenderTree.mm:
3233         (resetDefaultsToConsistentValues):
3234         * DumpRenderTree/mac/UIDelegate.mm:
3235         (-[UIDelegate webView:shouldHaltPlugin:]):
3236
3237 2009-10-08  Brady Eidson  <beidson@apple.com>
3238
3239         Reviewed by Dan Bernstein.
3240
3241         Ask the History Delegate to populate the visited links hash.
3242         <rdar://problem/7285293> and https://webkit.org/b/29904
3243
3244         Add the ability for LayoutTestController to clear all visited links.
3245         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3246
3247         * DumpRenderTree/LayoutTestController.cpp:
3248         (LayoutTestController::LayoutTestController):
3249         (removeAllVisitedLinksCallback):
3250         (LayoutTestController::staticFunctions):
3251         * DumpRenderTree/LayoutTestController.h:
3252         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3253         (LayoutTestController::removeAllVisitedLinks):
3254
3255         * DumpRenderTree/mac/HistoryDelegate.mm:
3256         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3257
3258         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3259         (LayoutTestController::removeAllVisitedLinks):
3260         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3261         (LayoutTestController::removeAllVisitedLinks):
3262         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3263         (LayoutTestController::removeAllVisitedLinks):
3264
3265
3266 2009-10-08  Daniel Bates  <dbates@webkit.org>
3267
3268         Reviewed by Adam Roben.
3269
3270         https://bugs.webkit.org/show_bug.cgi?id=30175
3271
3272         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3273         the OLE drag-and-drop return value like the function it emulates. Currently,
3274         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3275         whether the drag-and-drop operation was successful or was cancelled.
3276
3277         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3278         return value according to whether the drop operation was successful or not.
3279
3280         * DumpRenderTree/win/EventSender.cpp:
3281         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3282         (replaySavedEvents): Ditto.
3283         * DumpRenderTree/win/EventSender.h:
3284         * DumpRenderTree/win/UIDelegate.cpp:
3285         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3286
3287 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3288
3289         Reviewed by Xan Lopez.
3290
3291         [GTK] Added support for a parameter setting the button that was
3292         pressed in the mouseDown function.
3293         https://bugs.webkit.org/show_bug.cgi?id=30220
3294
3295         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3296
3297 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3298
3299         Reviewed by Xan Lopez.
3300
3301         [GTK] Added a line to the bottom of the expected result to match
3302         the output of the test.
3303         https://bugs.webkit.org/show_bug.cgi?id=30220
3304
3305         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3306         expected.txt:
3307
3308 2009-10-08  Adam Roben  <aroben@apple.com>
3309
3310         Use QueryInterface to get IWebInspectorPrivate
3311
3312         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3313         accessed in a more standard way
3314
3315         Reviewed by John Sullivan and Tim Hatcher.
3316
3317         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3318         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3319         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3320         to the IWebInspectorPrivate interface.
3321
3322 2009-10-07  Adam Roben  <aroben@apple.com>
3323
3324         Implement DRT support for origin whitelisting
3325
3326         Fixes <http://webkit.org/b/30185>.
3327
3328         Reviewed by Eric Seidel.
3329
3330         * DumpRenderTree/win/DumpRenderTree.cpp:
3331         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3332         whitelist, to match Mac DRT.
3333         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3334         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3335         IWebViewPrivate::whiteListAccessFromOrigin.
3336
3337 2009-10-07  Brady Eidson  <beidson@apple.com>
3338
3339         Reviewed by Darin Adler.
3340
3341         Send title changes to the global history delegate.
3342         <rdar://problem/7285293> and https://webkit.org/b/29904
3343
3344         * DumpRenderTree/mac/HistoryDelegate.mm:
3345         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3346
3347 2009-10-07  Adam Barth  <abarth@webkit.org>
3348
3349         Unreviewed.  Remove some folks from committers.py who were listed on
3350         the WebKit Team wiki page but who weren't actually listed as commit+.
3351         At some point, we should coorelate this list with the committers
3352         mailing list.
3353
3354         * Scripts/modules/committers.py:
3355
3356 2009-10-07  Adam Barth  <abarth@webkit.org>
3357
3358         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3359         the wiki into committers.py.
3360
3361         * Scripts/modules/committers.py:
3362
3363 2009-10-07  Adam Barth  <abarth@webkit.org>
3364
3365         Unreviewed.  Added Aaron Boodman to committers.py.
3366
3367         * Scripts/modules/committers.py:
3368
3369 2009-10-07  Evan Martin  <evan@chromium.org>
3370
3371         Reviewed by Darin Adler.
3372
3373         Add API to LayoutTestController for re/setting the system locale.
3374         https://bugs.webkit.org/show_bug.cgi?id=18994
3375
3376         * DumpRenderTree/LayoutTestController.cpp:
3377         (setLocaleCallback):
3378         (LayoutTestController::staticFunctions):
3379         (LayoutTestController::setLocale):
3380         * DumpRenderTree/LayoutTestController.h:
3381
3382 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3383
3384         Reviewed by Jan Alonzo.
3385
3386         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3387         https://bugs.webkit.org/show_bug.cgi?id=29689
3388
3389         Build fix by adding -lfontconfig for DumpRenderTree.
3390
3391         * GNUmakefile.am:
3392
3393 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3394
3395         Reviewed by Simon Hausmann.
3396
3397         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3398
3399         * Scripts/run-webkit-tests:
3400
3401 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3402
3403         Reviewed by Gustavo Noronha.
3404
3405         "delete" in EventSender is the backspace key, not the delete one.
3406
3407         * DumpRenderTree/gtk/EventSender.cpp:
3408         (keyDownCallback):
3409
3410 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3411
3412         Reviewed by Gustavo Noronha.
3413
3414         getChildrenWithRange expects as last parameter the end index, not
3415         the length of the range. Correct this and clarify the variable
3416         names to reflect how the code works.
3417
3418         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3419         (AccessibilityUIElement::getChildrenWithRange):
3420         (AccessibilityUIElement::getChildAtIndex):
3421
3422 2009-10-06  Mark Rowe  <mrowe@apple.com>
3423
3424         Reviewed by Simon Fraser.
3425
3426         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3427
3428         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3429         the fact we have already changed the working directory to the top of the open source tree.
3430
3431 2009-10-06  Julie Parent  <jparent@chromium.org>
3432
3433         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3434         rather than my committer email.
3435
3436         * Scripts/modules/committers.py:
3437
3438 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3439
3440         Reviewed by Eric Seidel.
3441
3442         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3443
3444         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3445         it after each layout test as it should do, making the DRT dump additional output
3446         for all of the subsequent layout tests.
3447
3448         * DumpRenderTree/qt/jsobjects.cpp:
3449         (LayoutTestController::reset):
3450
3451 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3452
3453         Reviewed by Simon Hausmann.
3454
3455         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3456         fast/dom/assign-to-window-status.html test, which is passing as a result.
3457
3458         https://bugs.webkit.org/show_bug.cgi?id=30127
3459
3460         * DumpRenderTree/qt/DumpRenderTree.cpp:
3461         (WebCore::DumpRenderTree::DumpRenderTree):
3462         (WebCore::DumpRenderTree::statusBarMessage):
3463         * DumpRenderTree/qt/DumpRenderTree.h:
3464         * DumpRenderTree/qt/jsobjects.h:
3465         (LayoutTestController::shouldDumpStatusCallbacks):
3466         (LayoutTestController::dumpStatusCallbacks):
3467
3468 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3469
3470         Reviewed by Simon Hausmann.
3471
3472         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3473         ignores the argument indicating which mouse button to trigger.
3474         https://bugs.webkit.org/show_bug.cgi?id=30048
3475
3476         This affects the fast/events/mouse-click-events.html layout test.
3477
3478         * DumpRenderTree/qt/jsobjects.cpp:
3479         (EventSender::mouseDown):
3480         (EventSender::mouseUp):
3481         * DumpRenderTree/qt/jsobjects.h:
3482
3483 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3484
3485         Reviewed by Simon Hausmann.
3486
3487         [Qt] Fix the EventSender::keyDown() implementation
3488         https://bugs.webkit.org/show_bug.cgi?id=30043
3489
3490         It should post both a key press event and a key release event,
3491         just like other ports do.
3492
3493         * DumpRenderTree/qt/jsobjects.cpp:
3494         (EventSender::keyDown):
3495
3496 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3497
3498         wx build fix. Add jpeg to the list of libs to link against.
3499
3500         * wx/build/settings.py:
3501
3502 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3503
3504         Reviewed by Simon Hausmann.
3505
3506         [Qt] EventSender::keyDown() cannot send function-key events.
3507         https://bugs.webkit.org/show_bug.cgi?id=30044
3508
3509         This affects the fast/events/keydown-function-keys.html layout test.
3510
3511         * DumpRenderTree/qt/jsobjects.cpp:
3512         (EventSender::keyDown):
3513
3514 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3515
3516         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3517         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3518
3519         * wx/build/settings.py:
3520         * wx/build/wxpresets.py:
3521
3522 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3523
3524         Reviewed by Timothy Hatcher.
3525
3526         Web Inspector: add testing harness for Web Inspector.
3527
3528         https://bugs.webkit.org/show_bug.cgi?id=30010
3529
3530         * DumpRenderTree/LayoutTestController.cpp:
3531         (showWebInspectorCallback):
3532         (closeWebInspectorCallback):
3533         (evaluateInWebInspectorCallback):
3534         (LayoutTestController::staticFunctions):
3535         * DumpRenderTree/LayoutTestController.h:
3536         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3537         (LayoutTestController::showWebInspector):
3538         (LayoutTestController::closeWebInspector):
3539         (LayoutTestController::evaluateInWebInspector):
3540         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3541         (LayoutTestController::showWebInspector):
3542         (LayoutTestController::closeWebInspector):
3543         (LayoutTestController::evaluateInWebInspector):
3544         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3545         (LayoutTestController::showWebInspector):
3546         (LayoutTestController::closeWebInspector):
3547         (LayoutTestController::evaluateInWebInspector):
3548         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3549         (LayoutTestController::showWebInspector):
3550         (LayoutTestController::closeWebInspector):
3551         (LayoutTestController::evaluateInWebInspector):
3552
3553 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3554
3555         Reviewed by Ariyha Hidayat.
3556
3557         Pass arguments to system() as a string instead of array
3558
3559         When passed as an array entries with a space fail to translate
3560         to two arguments to the child process, so instead of manually
3561         splitting all the entries in @buildArgs we pass the whole thing
3562         as a string instead.
3563
3564         * Scripts/webkitdirs.pm:
3565
3566 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3567
3568         Reviewed by David Levin.
3569
3570         check-webkit-style misses whitespace errors for operators:
3571         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3572         https://bugs.webkit.org/show_bug.cgi?id=30021
3573
3574         * Scripts/modules/cpp_style.py:
3575         Added the operators mentioned above to the same list as == and !=.
3576
3577 2009-10-02  Julie Parent  <jparent@chromium.org>
3578
3579         Unreviewed.
3580
3581         Adding myself and Ojan Vafai as committers, because we are committers.
3582
3583         * Scripts/modules/committers.py:
3584
3585 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3586
3587         Reviewed by Adam Roben.
3588
3589         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3590         this will help the patch merging process when TryBots are used.
3591
3592         * Scripts/svn-create-patch:
3593
3594 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3595
3596         Reviewed by Simon Hausmann.
3597
3598         [Qt] Implement layoutTestController.overridePreference().
3599         https://bugs.webkit.org/show_bug.cgi?id=29970
3600
3601         * DumpRenderTree/qt/DumpRenderTree.cpp:
3602         (WebCore::WebPage::WebPage):
3603         (WebCore::WebPage::resetSettings):
3604         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3605         * DumpRenderTree/qt/jsobjects.cpp:
3606         (LayoutTestController::reset):
3607         (LayoutTestController::setPrivateBrowsingEnabled):
3608         (LayoutTestController::setPopupBlockingEnabled):
3609         (LayoutTestController::overridePreference):
3610         * DumpRenderTree/qt/jsobjects.h:
3611
3612 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3613
3614         Reviewed by Oliver Hunt.
3615
3616         Turn on ENABLE_3D_CANVAS in TOT
3617         https://bugs.webkit.org/show_bug.cgi?id=29906
3618
3619         * Scripts/build-webkit:
3620
3621 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3622
3623         Rubberstamped by Simon Hausmann.
3624
3625         Enable HTTP tests for Qt
3626
3627         * Scripts/run-webkit-tests:
3628
3629 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3630
3631         Reviewed by Dimitri Glazkov.
3632
3633         build-webkit --chromium now also works on cygwin.
3634
3635         https://bugs.webkit.org/show_bug.cgi?id=29973
3636
3637         * Scripts/webkitdirs.pm:
3638
3639 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3640
3641         Reviewed by Simon Hausmann.
3642
3643         [Qt] Don't use TCmalloc in DumpRenderTree
3644         https://bugs.webkit.org/show_bug.cgi?id=27029
3645
3646         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3647
3648         * DumpRenderTree/qt/DumpRenderTree.pro:
3649
3650 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3651
3652         Reviewed by Simon Hausmann.
3653
3654         [Qt] Implement eventSender.scheduleAsynchronousClick().
3655
3656         https://bugs.webkit.org/show_bug.cgi?id=29931
3657
3658         * DumpRenderTree/qt/jsobjects.cpp:
3659         (EventSender::scheduleAsynchronousClick):
3660         * DumpRenderTree/qt/jsobjects.h:
3661
3662 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3663
3664         Reviewed by Simon Hausmann.
3665
3666         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3667         fast/events/open-window-from-another-frame.html from the Skipped list.
3668
3669         https://bugs.webkit.org/show_bug.cgi?id=29930
3670
3671         * DumpRenderTree/qt/jsobjects.cpp:
3672         (LayoutTestController::setPopupBlockingEnabled):
3673         * DumpRenderTree/qt/jsobjects.h:
3674
3675 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3676
3677         Unreviewed.
3678
3679         Added myself to the list of committers.
3680
3681         * Scripts/modules/committers.py:
3682
3683 2009-09-30  Eric Seidel  <eric@webkit.org>
3684
3685         No review, just adding Geoff to the list of reviewers.
3686
3687         * Scripts/modules/committers.py:
3688
3689 2009-09-30  Dan Bernstein  <mitz@apple.com>
3690
3691         Reviewed by Sam Weinig.
3692
3693         Added the WebKit Layout Tests fonts that are referenced in
3694         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3695
3696         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3697         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3698
3699 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3700
3701         Reviewed by David Kilzer.
3702
3703         Make sunspider scripts work on Windows platform.
3704         https://bugs.webkit.org/show_bug.cgi?id=29656
3705
3706         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3707         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3708         * Scripts/webkitdirs.pm: currentPerlPath() added.
3709
3710 2009-09-29  Brady Eidson  <beidson@apple.com>
3711
3712         Rubberstamped by Dan Bernstein.
3713
3714         Fix license and some sorting in new files.
3715
3716         * DumpRenderTree/mac/HistoryDelegate.h:
3717         * DumpRenderTree/mac/HistoryDelegate.mm:
3718
3719 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3720
3721         Reviewed by David Kilzer.
3722
3723         Fixed how error codes are handled.
3724         https://bugs.webkit.org/show_bug.cgi?id=29898
3725
3726         * Scripts/update-webkit:
3727         * Scripts/update-webkit-chromium:
3728
3729 2009-09-29  Brady Eidson  <beidson@apple.com>
3730
3731         Reviewed by John Sullivan.
3732
3733         Updated way-out-of-date sorting throughout the dump methods/flags.
3734
3735         * DumpRenderTree/LayoutTestController.cpp:
3736         (LayoutTestController::LayoutTestController):
3737         (dumpAsPDFCallback):
3738         (dumpAsTextCallback):
3739         (dumpFrameLoadCallbacksCallback):
3740         (dumpResourceLoadCallbacksCallback):
3741         (LayoutTestController::staticFunctions):
3742
3743         * DumpRenderTree/LayoutTestController.h:
3744         (LayoutTestController::dumpAsText):
3745         (LayoutTestController::setDumpAsText):
3746         (LayoutTestController::dumpFrameLoadCallbacks):
3747         (LayoutTestController::setDumpFrameLoadCallbacks):
3748         (LayoutTestController::dumpSelectionRect):
3749         (LayoutTestController::setDumpSelectionRect):
3750         (LayoutTestController::dumpSourceAsWebArchive):
3751         (LayoutTestController::setDumpSourceAsWebArchive):
3752         (LayoutTestController::dumpStatusCallbacks):
3753         (LayoutTestController::setDumpStatusCallbacks):
3754         (LayoutTestController::dumpTitleChanges):
3755         (LayoutTestController::setDumpTitleChanges):
3756         (LayoutTestController::dumpWillCacheResponse):
3757         (LayoutTestController::setDumpWillCacheResponse):
3758
3759 2009-09-29  Brady Eidson  <beidson@apple.com>
3760
3761         Reviewed by John Sullivan.
3762
3763         WebKit Mac API should provide a delegate interface for global history.
3764         <rdar://problem/7042773> and https://webkit.org/b/29904
3765
3766         Adding the dumping of global history delegate callbacks.
3767
3768         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3769
3770         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3771         * DumpRenderTree/mac/DumpRenderTree.mm:
3772         (createWebViewAndOffscreenWindow):
3773         (allocateGlobalControllers):
3774         (shouldLogFrameLoadDelegates):
3775         (shouldLogHistoryDelegates):
3776         (runTest):
3777
3778         Dump history delegate callbacks:
3779         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3780         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3781         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3782         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3783         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3784
3785 2009-09-29  Daniel Bates  <dbates@webkit.org>
3786
3787         Reviewed by Adam Roben.
3788
3789         https://bugs.webkit.org/show_bug.cgi?id=28902
3790
3791         Fixes an issue where the drop effect returned by Window Dump Render Tree
3792         was always DROPEFFECT_NONE (since it was hard coded to do so).
3793
3794         This patch corrects this issue by determining the actual drop effect
3795         performed by the corresponding drag-and-drop operation so that we can
3796         return it.
3797
3798         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3799         (DraggingInfo::DraggingInfo):
3800         (DraggingInfo::performedDropEffect): Added method.
3801         (DraggingInfo::setPerformedDropEffect): Added method.
3802         * DumpRenderTree/win/EventSender.cpp:
3803         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3804         Moved delete draggingInfo to UIDelegate::doDragDrop.
3805         * DumpRenderTree/win/UIDelegate.cpp:
3806         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3807
3808 2009-09-29  Dan Bernstein  <mitz@apple.com>
3809
3810         Reviewed by Adam Roben.
3811
3812         Remove copying of unnecessary or nonexistent files from the ImageDiff
3813         post-build event.
3814
3815         * DumpRenderTree/win/ImageDiff.vcproj:
3816
3817 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3818
3819         Reviewed by David Kilzer.
3820
3821         [Qt] Make build-webkit script work on Windows
3822         https://bugs.webkit.org/show_bug.cgi?id=29802
3823
3824         * Scripts/run-webkit-tests:
3825         * Scripts/webkitdirs.pm:
3826          - Removed unnecessary -p switch for mkdir on Windows.
3827          - Use canonical path, which uses slashes or backslashes depends on platform.
3828          - isWindows() only test for Windows and not for Cyqwin.
3829
3830 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3831
3832         Reviewed by Simon Hausmann.
3833
3834         Fix time measurement in build-webkit after refactoring done in r48853.
3835
3836         * Scripts/build-webkit:
3837
3838 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3839
3840         Reviewed by Tor Arne Vestbø.
3841
3842         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3843         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3844
3845         * DumpRenderTree/qt/DumpRenderTree.cpp:
3846         (WebCore::WebPage::WebPage):
3847
3848 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3849
3850         Reviewed by Simon Hausmann.
3851
3852         [Qt] Implement eventSender.contextClick().
3853         https://bugs.webkit.org/show_bug.cgi?id=29821
3854
3855         * DumpRenderTree/qt/jsobjects.cpp:
3856         (EventSender::contextClick):
3857         * DumpRenderTree/qt/jsobjects.h:
3858
3859 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3860
3861         Reviewed by Eric Seidel.
3862
3863         Add experimentalWebSocketsEnabled in WebPreferences.
3864         https://bugs.webkit.org/show_bug.cgi?id=28941
3865
3866         * DumpRenderTree/mac/DumpRenderTree.mm:
3867         (resetDefaultsToConsistentValues):
3868         * DumpRenderTree/win/DumpRenderTree.cpp:
3869         (resetDefaultsToConsistentValues):
3870
3871 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3872
3873         Reviewed by David Kilzer.
3874
3875         Integrated chromium port building into webkit tools update-webkit and
3876         build-webkit.
3877
3878         https://bugs.webkit.org/show_bug.cgi?id=29749
3879
3880         * Scripts/build-webkit: When --chromium is specified, will build
3881           the chromium port (currently only Mac is supported).
3882         * Scripts/update-webkit: When --chromium is specified, delegates to
3883           update-webkit-chromium.
3884         * Scripts/webkitdirs.pm: Added chromium specific defs.
3885         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3886           chromium port's dependencies and update its project files.
3887
3888 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3889
3890         Unreviewed.
3891
3892         Add myself to list of committers.
3893
3894         * Scripts/modules/committers.py:
3895
3896 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3897
3898         Reviewed by Darin Adler.
3899
3900         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3901         https://bugs.webkit.org/show_bug.cgi?id=29771
3902
3903         * Scripts/run-webkit-tests:
3904
3905 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3906
3907         Reviewed by Simon Hausmann.
3908
3909         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3910         https://bugs.webkit.org/show_bug.cgi?id=25037
3911
3912         * DumpRenderTree/qt/DumpRenderTree.cpp:
3913         (WebCore::WebPage::acceptNavigationRequest):
3914         * DumpRenderTree/qt/DumpRenderTree.pro:
3915         * DumpRenderTree/qt/jsobjects.cpp:
3916         (LayoutTestController::reset):
3917         (LayoutTestController::notifyDone):
3918         (LayoutTestController::waitForPolicyDelegate):
3919         * DumpRenderTree/qt/jsobjects.h:
3920         (LayoutTestController::waitForPolicy):
3921
3922 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3923
3924         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3925
3926         Reviewed by Eric Seidel.
3927
3928         The -o|--open switch uses the open(1) command on Mac OS X to
3929         open the bug URL in the default web browser.  If there are
3930         similar mechanisms on other platforms, they may be added later.
3931
3932         * Scripts/mark-bug-fixed:
3933         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3934         options.
3935         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3936         code into main() and extracted prompting code into
3937         _prompt_user_for_correctness().
3938         (MarkBugFixed._open_bug_in_web_browser): Added.
3939         (MarkBugFixed._prompt_user_for_correctness): Added.
3940         (MarkBugFixed.main): Added logging code from
3941         _determine_bug_id_and_svn_revision().  Added code to call
3942         _open_bug_in_web_browser() if the switch is set.  Added code to
3943         call _prompt_user_for_correctness() when needed.
3944         * Scripts/modules/bugzilla.py:
3945         (Bugzilla.short_bug_url_for_bug_id): Added.
3946
3947 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3948
3949         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3950
3951         <http://webkit.org/b/29744>
3952         <rdar://problem/7252905>
3953
3954         Reviewed by Eric Seidel.
3955
3956         Some users have a workflow where svn-create-patch, svn-apply and
3957         svn-unapply are used outside of multiple svn working
3958         directories.  Instead of aborting the scripts in these cases,
3959         print a warning and assume that Subversion is being used.
3960
3961         * Scripts/VCSUtils.pm:
3962         (determineVCSRoot): Call warn() instead of die() if both isGit()
3963         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3964         to enforce the assumption about Subversion, then return
3965         determineSVNRoot().
3966         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3967         VCSUtils.pm.  They both already cache their values and checking
3968         here is redundant since determineVCSRoot() is called later.
3969
3970 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3971
3972         Reviewed by Gustavo Noronha.
3973
3974         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3975         https://bugs.webkit.org/show_bug.cgi?id=29689
3976
3977         Load test fonts through FontConfig before each test.
3978         This ensures a more proper rendering of the tests.
3979
3980         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3981         (initializeFonts):
3982         (runTest):
3983         (main):
3984         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3985         * GNUmakefile.am:
3986
3987 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3988
3989         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3990
3991         Reviewed by Eric Seidel.
3992
3993         * Scripts/mark-bug-fixed:
3994         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3995         of parse options.
3996         (MarkBugFixed.main): When -u|--update-only is specified, add a
3997         comment to the bug without marking it Resolved/Fixed.
3998
3999 2009-09-25  Darin Adler  <darin@apple.com>
4000
4001         Reviewed by Geoffrey Garen.
4002
4003         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
4004         out, just as we do for the resources directory.
4005
4006 2009-09-25  Adam Barth  <abarth@webkit.org>
4007
4008         Unreviewed.  Added Tony to committers.py because he's a
4009         committer now.
4010
4011         * Scripts/modules/committers.py:
4012
4013 2009-09-25  Eric Seidel  <eric@webkit.org>
4014
4015         Reviewed by Simon Fraser.
4016
4017         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
4018         https://bugs.webkit.org/show_bug.cgi?id=28624
4019
4020         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
4021
4022         * DumpRenderTree/mac/DumpRenderTree.mm:
4023         (resetDefaultsToConsistentValues):
4024
4025 2009-09-25  Eric Seidel  <eric@webkit.org>
4026
4027         Reviewed by Adam Barth.
4028
4029         commit-queue should auto-retry patches which fail to commit due to out of date files
4030         https://bugs.webkit.org/show_bug.cgi?id=28316
4031
4032         * Scripts/bugzilla-tool:
4033          - Handle new CheckoutNeedsUpdate exception.
4034         * Scripts/modules/logging_unittest.py:
4035          - Call the ScriptError constructor correctly (this test had regressed).
4036         * Scripts/modules/scm.py:
4037          - Added the ability to define custom error handlers for run_command
4038            and added a commit_error_handler which throws CheckoutNeedsUpdate
4039            instead of ScriptError.
4040          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
4041         * Scripts/modules/scm_unittest.py:
4042          - Added tests of new error handlers.
4043
4044 2009-09-25  Eric Seidel  <eric@webkit.org>
4045
4046         Reviewed by Adam Barth.
4047
4048         commit-queue should give better feedback when failing a patch
4049         https://bugs.webkit.org/show_bug.cgi?id=29316
4050
4051         * Scripts/bugzilla-tool:
4052          - Update ScriptError uses to the new constructor format.
4053          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
4054            so that we can print to both stdout as well as an output buffer for error reporting.
4055          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
4056          - Use e.message_with_output() when failing a patch (this is the real fix here).
4057            I also removed use of "This patch will require manual commit." as that's not always true.
4058          - Add missing word "bug" from log message.
4059         * Scripts/modules/scm.py:
4060          - Make ScriptError save a bunch more data so that error messages can be nicer.
4061          - Update ScriptError callers.
4062
4063 2009-09-24  John Gregg  <johnnyg@google.com>
4064
4065         Reviewed by Eric Seidel.
4066
4067         Enable switch for notifications (experimental) in Page Settings
4068         https://bugs.webkit.org/show_bug.cgi?id=28930
4069
4070         Now that desktop notifications are controlled by run-time switch,
4071         set that switch to true for DumpRenderTree.
4072
4073         * DumpRenderTree/mac/DumpRenderTree.mm:
4074         (resetDefaultsToConsistentValues):
4075         * DumpRenderTree/win/DumpRenderTree.cpp:
4076         (resetDefaultsToConsistentValues):
4077         * DumpRenderTree/win/UIDelegate.cpp:
4078         (UIDelegate::QueryInterface):
4079
4080 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
4081
4082         wx build fix. SnowLeopard fixes for Mac dependencies.
4083
4084         * wx/build/build_utils.py:
4085         * wx/build/settings.py:
4086         * wx/install-unix-extras:
4087
4088 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4089
4090         Reviewed by Oliver Hunt.
4091
4092         Add support for DRT to send mouse wheel events.
4093
4094         https://bugs.webkit.org/show_bug.cgi?id=29348
4095         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
4096
4097         * DumpRenderTree/gtk/EventSender.cpp:
4098         (mouseWheelToCallback):
4099
4100 2009-09-17  Eric Seidel  <eric@webkit.org>
4101
4102         Reviewed by David Levin.
4103
4104         commit-queue needs web-based status reporting
4105         https://bugs.webkit.org/show_bug.cgi?id=29307
4106
4107         Add a first-pass web-based status for the commit-queue.
4108         The bot is currently reachable at:
4109         http://webkit-commit-queue.appspot.com/
4110
4111         * CommitQueueStatus/app.yaml: Added.
4112          - Application description file required by App Engine.
4113         * CommitQueueStatus/filters/__init__.py: Added.
4114          - Required by python to treat 'filters' as a module.
4115         * CommitQueueStatus/filters/webkit_extras.py: Added.
4116          - Support for turning 'bug 123' and 'patch 123' into links.
4117            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
4118         * CommitQueueStatus/index.html: Added.
4119         * CommitQueueStatus/index.yaml: Added.
4120          - Some auto-generated file from app engine.
4121         * CommitQueueStatus/queue_status.py: Added.
4122          - The core logic of this bot.  We could eventually split this file out into pieces.
4123         * CommitQueueStatus/stylesheets/main.css: Added.
4124          - Some basic lame-o CSS to make the page look less awful.
4125         * CommitQueueStatus/update_status.html: Added.
4126          - The form that the commit-queue (or a human) can use to update the status.
4127         * Scripts/bugzilla-tool:
4128          - Add some very basic update_status calls.
4129         * Scripts/modules/statusbot.py: Added.
4130          - Knows how to post to the CommitQueueStatus web application.
4131
4132 2009-09-24  David Kilzer  <ddkilzer@apple.com>
4133
4134         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
4135
4136         Reviewed by Adam Roben.
4137
4138         * Scripts/mark-bug-fixed:
4139         (MarkBugFixed.__init__): Added -m|--comment switch to list of
4140         parse options.
4141         (MarkBugFixed.main): When specified, prepend comment from
4142         -m|--comment command-line switch to the bug comment.
4143
4144 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4145
4146         Reviewed by Jan Alonzo.
4147
4148         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
4149         https://bugs.webkit.org/show_bug.cgi?id=29693
4150
4151         Show the window, to be able to synthesize events correctly.
4152
4153         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4154         (runTest):
4155         (main):
4156
4157 2009-09-24  Oliver Hunt  <oliver@apple.com>
4158
4159         Reviewed by NOBODY(rollout)
4160
4161         Roll out r48712 as it is incorrect.
4162
4163         * DumpRenderTree/mac/ObjCController.m:
4164         (+[ObjCController isSelectorExcludedFromWebScript:]):
4165         (+[ObjCController webScriptNameForSelector:]):
4166
4167 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
4168
4169         Reviewed by Eric Seidel.
4170
4171         https://bugs.webkit.org/show_bug.cgi?id=29005
4172         The indices of RuntimeArray should be enumerated like for a regular array.
4173
4174         * DumpRenderTree/mac/ObjCController.m:
4175         (+[ObjCController isSelectorExcludedFromWebScript:]):
4176         (+[ObjCController webScriptNameForSelector:]):
4177         (-[ObjCController arrayOfString]):
4178
4179 2009-09-23  David Kilzer  <ddkilzer@apple.com>
4180
4181         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
4182
4183         Reviewed by Darin Adler.
4184
4185         Also fixed a bug where specifying a revision on the command-line
4186         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
4187
4188         * Scripts/bugzilla-tool: Updated module import statements.
4189         (parse_bug_id): Removed.  Moved to bugzilla.py.
4190         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
4191         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
4192         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
4193         (BugzillaTool.__init__): Removed mark-fixed subcommand.
4194         * Scripts/mark-bug-fixed: Added.
4195         * Scripts/modules/bugzilla.py:
4196         (parse_bug_id): Added.  Moved from bugzilla-tool.
4197         * Scripts/modules/comments.py: Added.
4198         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
4199         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
4200
4201 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
4202
4203         Reviewed by Eric Seidel.
4204
4205          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
4206          "false" in non-implemented stub for setAlwaysAcceptCookies.
4207          https://bugs.webkit.org/show_bug.cgi?id=29661
4208
4209         * DumpRenderTree/win/DumpRenderTree.vcproj:
4210         * DumpRenderTree/win/DumpRenderTree.cpp:
4211
4212 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4213
4214         Reviewed by Xan Lopez.
4215
4216         [GTK] need to dump number of pending unload handlers
4217         https://bugs.webkit.org/show_bug.cgi?id=29685
4218
4219         Implement dumping of the number of pending unload handlers.
4220
4221         The following tests will pass:
4222
4223           fast/loader/unload-form-about-blank.html
4224           fast/loader/unload-form-post-about-blank.html
4225           fast/loader/unload-form-post.html
4226           fast/loader/unload-form.html
4227           fast/loader/unload-hyperlink.html
4228           fast/loader/unload-javascript-url.html
4229           fast/loader/unload-reload.html
4230           fast/loader/unload-window-location.html
4231
4232         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4233         (getFrameNameSuitableForTestResult):
4234         (webViewLoadFinished):
4235
4236 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
4237
4238         Reviewed by Eric Seidel.
4239
4240         js tests should move into jstests subdirectory instead of resources/
4241         https://bugs.webkit.org/show_bug.cgi?id=25880
4242
4243         Remove support of resources directory.
4244
4245         * Scripts/make-script-test-wrappers:
4246
4247 2009-09-22  Eric Seidel  <eric@webkit.org>
4248
4249         No review, only fixing typo (missing space character).
4250
4251         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
4252
4253         * Scripts/run-webkit-tests:
4254
4255 2009-09-22  Eric Seidel  <eric@webkit.org>
4256
4257         Reviewed by Darin Adler.
4258
4259         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
4260         https://bugs.webkit.org/show_bug.cgi?id=29220
4261
4262         * Scripts/run-webkit-tests:
4263
4264 2009-09-22  Eric Seidel  <eric@webkit.org>
4265
4266         Reviewed by David Kilzer.
4267
4268         svn-apply can't handle single-line binary file additions
4269         https://bugs.webkit.org/show_bug.cgi?id=29100
4270
4271         Fixed the regexp and added a unit test.
4272
4273         * Scripts/modules/scm_unittest.py:
4274         * Scripts/svn-apply:
4275
4276 2009-09-11  Eric Seidel  <eric@webkit.org>
4277
4278         Reviewed by David Kilzer.
4279
4280         post-diff and post-commits should be able to find bug urls in ChangeLogs.
4281         https://bugs.webkit.org/show_bug.cgi?id=29206
4282
4283         * Scripts/bugzilla-tool:
4284          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
4285          - Rename --no-comment to --add-log-as-comment and reverse behavior.
4286            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
4287          - Split out code into helper functions to try and make execute() more legible.
4288          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
4289          - Fallback to bug urls in commit diffs, instead of just in commit messages,
4290            meaning post-commits will now find bug urls in ChangeLogs.
4291
4292 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4293
4294         Reviewed by Maciej Stachowiak.
4295
4296         --parse-only parameter wasn't passed to SunSpider/sunspider script.
4297         https://bugs.webkit.org/show_bug.cgi?id=29611
4298
4299         * Scripts/run-sunspider: Missing parameter passing added.
4300
4301 2009-09-20  David Kilzer  <ddkilzer@apple.com>
4302
4303         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
4304
4305         Reviewed by Mark Rowe.
4306
4307         The require statement is like the use statement, except that it
4308         is run during script execution instead of during the 'BEGIN'
4309         phase.  This makes it possible to change @INC before the require
4310         statement is run.  See 'require' and 'use' in the perlfunc(1)
4311         manpage and 'BEGIN' in perlmod(1) manpage.
4312
4313         * Scripts/run-webkit-tests: Replace eval statement with require
4314         statement.
4315
4316 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
4317
4318         wx build fixes. Fix the config name under git and allow users to specify
4319         their own waf install for experimenting with new versions.
4320
4321         * Scripts/webkitdirs.pm:
4322         * wx/build/settings.py:
4323
4324 2009-09-18  Alex Milowski  <alex@milowski.com>
4325
4326         Reviewed by Maciej Stachowiak.
4327
4328         Added checkWebCoreMathMLSupport and hasMathMLSupport to support
4329         checking for whether MathML tests should be run
4330
4331         * Scripts/run-webkit-tests:
4332         * Scripts/webkitdirs.pm:
4333
4334 2009-08-28  Darin Adler  <darin@apple.com>
4335
4336         Reviewed by Mark Rowe.
4337
4338         Break more of run-webkit-tests into separate functions
4339         https://bugs.webkit.org/show_bug.cgi?id=29497
4340
4341         Some small steps toward improving run-webkit-tests. My goal is to
4342         refactor much more of the script into functions. Later we can add
4343         parallel test running to the tool. But better structure may help
4344         even if someone decides to translate this into another scripting
4345         language instead.
4346
4347         * Scripts/run-webkit-tests: Break more pieces of the script into
4348         seprate functions. Added readSkippedFiles, findTestsToRun, and
4349         printResults functions. Removed custom code to skip results.html
4350         and instead just put it into the ignoredFiles hash. Fixed some
4351         indentation. Sorted function declarations, global variables,
4352         and options at the top of the file alphabetically so they're not
4353         in a semi-random order.
4354
4355 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
4356