2010-09-20 Hayato Ito <hayato@chromium.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-20  Hayato Ito  <hayato@chromium.org>
2
3         Unreviewed.
4         Adding myself to the committers list.
5
6         * Scripts/webkitpy/common/config/committers.py:
7
8 2010-09-20  Adam Barth  <abarth@webkit.org>
9
10         Reviewed by Eric Seidel.
11
12         The tool member variable should be called _tool
13         https://bugs.webkit.org/show_bug.cgi?id=46160
14
15         Created by find-and-replace.
16
17         * Scripts/webkitpy/tool/commands/download.py:
18         * Scripts/webkitpy/tool/commands/openbugs.py:
19         * Scripts/webkitpy/tool/commands/queries.py:
20         * Scripts/webkitpy/tool/commands/queues.py:
21         * Scripts/webkitpy/tool/commands/queues_unittest.py:
22         * Scripts/webkitpy/tool/commands/rebaseline.py:
23         * Scripts/webkitpy/tool/commands/sheriffbot.py:
24         * Scripts/webkitpy/tool/commands/upload.py:
25         * Scripts/webkitpy/tool/multicommandtool.py:
26
27 2010-09-20  Adam Barth  <abarth@webkit.org>
28
29         I ran the tests before landing but ignored the fact that they failed.  :(
30
31         * Scripts/webkitpy/tool/commands/queues.py:
32
33 2010-09-20  Adam Barth  <abarth@webkit.org>
34
35         Reviewed by Eric Seidel.
36
37         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
38         https://bugs.webkit.org/show_bug.cgi?id=46141
39
40         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
41         list of work items on the status server.  The individual commit-cluster
42         nodes then grab the patches from the server and process them.
43
44         * Scripts/webkitpy/tool/bot/feeders.py: Added.
45         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
46         * Scripts/webkitpy/tool/commands/queues.py:
47         * Scripts/webkitpy/tool/commands/queues_unittest.py:
48         * Scripts/webkitpy/tool/commands/queuestest.py:
49
50 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
51
52         Reviewed by Darin Adler.
53
54         build-webkit: Add support for CMake build system
55         https://bugs.webkit.org/show_bug.cgi?id=44979
56
57         * Scripts/build-webkit: Add "--efl" command-line option to build the
58         EFL port of WebKit.
59         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
60         buildEflCMakeProject() subroutines.
61
62 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
63
64         Reviewed by Ojan Vafai.
65
66         new-run-webkit-tests: refactor command line args getting passed to DRT
67
68         This change cleans up some argument parsing between functions to get
69         rid of some overlapping data structures. There should be no functional
70         changes in this patch; it is pure refactoring in preparation for
71         landing the Chrome GPU port and adding a generic way to pass
72         args to DRT/TestShell.
73
74         https://bugs.webkit.org/show_bug.cgi?id=46135
75
76         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
77           - pass the options argument explicitly to the threads and drivers,
78             also consolidate the passing of options to the driver.
79           - pass options directly to process_output() to remove a couple
80             parameters (minor cleanup).
81         * Scripts/webkitpy/layout_tests/port/base.py:
82           - pass the options argument to Port.create_driver().
83         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
84           - update Port.create_driver() test
85         * Scripts/webkitpy/layout_tests/port/chromium.py:
86           - pass the options argument to Port.create_driver(), and clean up
87             building of the cmd line for DRT.
88         * Scripts/webkitpy/layout_tests/port/dryrun.py:
89           - pass the options argument to Port.create_driver()
90         * Scripts/webkitpy/layout_tests/port/test.py:
91           - pass the options argument to Port.create_driver()
92         * Scripts/webkitpy/layout_tests/port/webkit.py:
93           - pass the options argument to Port.create_driver(), and clean up
94             building of the cmd line for DRT.
95         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
96           - consolidate args in _get_dump_render_tree_args and rename to
97             _get_test_args(); move all of the command-line args to the
98             Port implementations.
99
100 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
101
102         Revert change which was accidentally committed along with some expectation changes.
103
104         * Scripts/webkitpy/layout_tests/port/base.py:
105
106 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
107
108         Reviewed by Adam Barth.
109
110         Add explicit --force-patch flag to webkitpy tools
111         https://bugs.webkit.org/show_bug.cgi?id=46103
112         
113         It wasn't obvious until I read the applypatch.py source code that
114         --non-interfactive implies passing --force to patch. Add --force-patch
115         as an alias to the flag, so that this behavior is more discoverable.
116
117         * Scripts/webkitpy/tool/steps/applypatch.py:
118         * Scripts/webkitpy/tool/steps/options.py:
119
120 2010-09-20  Eric Seidel  <eric@webkit.org>
121
122         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
123
124         commit-queue can't land patches
125         https://bugs.webkit.org/show_bug.cgi?id=46138
126
127         Add a line of code I forgot in my last commit.
128
129         * Scripts/webkitpy/common/net/bugzilla.py:
130         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
131
132 2010-09-20  Adam Barth  <abarth@webkit.org>
133
134         Reviewed by Eric Seidel.
135
136         The commit-cluster bots still race to lock patch_ids
137         https://bugs.webkit.org/show_bug.cgi?id=46130
138
139         It turns out we need to use a transaction object to make the
140         read/modify/write lock operation atomic.  From reading the AppEngine
141         documentation, I think this patch should do what we want.  It's hard to
142         test locally because the test instance isn't distributed in the same
143         way the production instance is.
144
145         * QueueStatusServer/handlers/nextpatch.py:
146         * QueueStatusServer/model/activeworkitems.py: Added.
147
148 2010-09-20  Andy Estes  <aestes@apple.com>
149
150         Reviewed by Adam Barth.
151
152         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
153         https://bugs.webkit.org/show_bug.cgi?id=40961
154
155         Implement WebKitUsePreHTML5ParserQuirks preference.
156
157         * DumpRenderTree/mac/DumpRenderTree.mm:
158         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
159         to false after a test finishes.
160
161 2010-09-20  Adam Roben  <aroben@apple.com>
162
163         Windows build fix
164
165         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
166         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
167         we'll pick up the most recent versions of the headers.
168
169 2010-09-20  Eric Seidel  <eric@webkit.org>
170
171         Reviewed by Adam Barth.
172
173         commit-queue should check commit-queue+ again just before committing
174         https://bugs.webkit.org/show_bug.cgi?id=32679
175
176         Added a _revalidate_patch check, right before landing.
177
178         Since _revalidate_patch passes the patch_id from the work item
179         back to bugzilla, I had to fix all of the previous queue tests to
180         use valid attachment ids (that's the majority of this change).
181
182         In order to validate that the bug was still open, I had to teach
183         bugzilla.Bug about open/closed states.
184
185         * Scripts/webkitpy/common/net/bugzilla.py:
186         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
187         * Scripts/webkitpy/tool/commands/queues.py:
188         * Scripts/webkitpy/tool/commands/queues_unittest.py:
189         * Scripts/webkitpy/tool/commands/queuestest.py:
190         * Scripts/webkitpy/tool/mocktool.py:
191
192 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
193
194         Unreviewed.
195
196         Adding myself as a comitter.
197
198         * Scripts/webkitpy/common/config/committers.py:
199
200 2010-09-20  Adam Barth  <abarth@webkit.org>
201
202         Reviewed by Eric Seidel.
203
204         Two instances of commit-queue try to process the same patch
205         https://bugs.webkit.org/show_bug.cgi?id=46113
206
207         This patch makes next-patch atomic so that the server won't vend the
208         same patch twice in the same hour.
209
210         * QueueStatusServer/handlers/nextpatch.py:
211
212 2010-09-20  Adam Roben  <aroben@apple.com>
213
214         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
215
216         We were previously trying to use a CFRunLoopTimer, but since Windows
217         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
218         Windows-style timer on Windows.
219
220         I also replaced all uses of "watchdog" with "watchdog timer".
221
222         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
223         watchdog timer doesn't work on Windows
224
225         Reviewed by Anders Carlsson.
226
227         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
228         (WTR::InjectedBundlePage::dump): Updated for rename.
229
230         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
231         platform-specific functions.
232         (WTR::LayoutTestController::LayoutTestController): Added call to
233         platformInitialize.
234         (WTR::LayoutTestController::waitUntilDone): Changed to call
235         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
236         right in this function.
237         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
238         rename.
239
240         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
241         members needed to support the watchdog timer abstraction. Replaced
242         some "watchdog"s with "watchdog timer".
243
244         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
245         Added.
246         (WTR::LayoutTestController::platformInitialize): Does nothing on this
247         platform.
248         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
249         from LayoutTestController.cpp and changed to use an early return.
250         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
251         LayoutTestController.cpp.
252         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
253         Moved code here from LayoutTestController::waitUntilDone and changed
254         to use an early return.
255
256         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
257         Added.
258         (WTR::LayoutTestController::platformInitialize): Initialize our
259         watchdog timer.
260         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
261         Kills and clears the watchdog timer.
262         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
263         LayoutTestController member function of the same name.
264         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
265         Added. Sets up the timer if it isn't already set.
266
267         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
268         LayoutTestControllerMac.mm.
269
270         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
271         LayoutTestControllerWin.cpp.
272
273 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
274
275         Reviewed by Daniel Bates.
276
277         [GTK] fast/forms/listbox-selection.html fails
278         https://bugs.webkit.org/show_bug.cgi?id=45942
279
280         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
281         strings in keyDownCallback.
282
283         * DumpRenderTree/gtk/EventSender.cpp:
284         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
285         modifier parsing logic.
286
287 2010-09-19  Sam Weinig  <sam@webkit.org>
288
289         Reviewed by Anders Carlsson.
290
291         WebKit2 decidePolicyForNavigationAction should include mouse button information
292         <rdar://problem/8413165>
293         https://bugs.webkit.org/show_bug.cgi?id=46060
294
295         * MiniBrowser/mac/BrowserWindowController.m:
296         (decidePolicyForNavigationAction):
297         (decidePolicyForNewWindowAction):
298
299 2010-09-19  Daniel Bates  <dbates@rim.com>
300
301         Reviewed by Martin Robinson.
302
303         Add unit tests for diffs that delete or modify a change log entry
304         or describe changes that are far apart
305         https://bugs.webkit.org/show_bug.cgi?id=46046
306
307         Add additional unit tests to test change log diffs that contain
308         deletions or changes that are far apart from each other in the
309         ChangeLog file.
310
311         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
312           - Added the following unit tests:
313           "fixChangeLogPatch: [no change] In-place change."
314           "fixChangeLogPatch: [no change] Remove first entry."
315           "fixChangeLogPatch: [no change] Remove entry in the middle."
316           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
317
318 2010-09-19  Sam Weinig  <sam@webkit.org>
319
320         Reviewed by Anders Carlsson.
321
322         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
323         https://bugs.webkit.org/show_bug.cgi?id=46054
324
325         The new one acts like WKBundleNodeHandleRef and allows for getting a
326         wrapper in a specific world for the handle.
327
328         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
329         (WTR::propertyValue):
330         (WTR::propertyValueDouble):
331         (WTR::propertyValueInt):
332         (WTR::numericWindowPropertyValue):
333         (WTR::toStr):
334         (WTR::InjectedBundlePage::shouldBeginEditing):
335         (WTR::InjectedBundlePage::shouldEndEditing):
336         (WTR::InjectedBundlePage::shouldInsertNode):
337         (WTR::InjectedBundlePage::shouldInsertText):
338         (WTR::InjectedBundlePage::shouldDeleteRange):
339         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
340         (WTR::InjectedBundlePage::shouldApplyStyle):
341         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
342
343 2010-09-19  Kent Tamura  <tkent@chromium.org>
344
345         Unreviewed. Fix WebGL test regressions by r67809.
346
347         * DumpRenderTree/chromium/WebPreferences.cpp:
348         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
349
350 2010-09-19  Kent Tamura  <tkent@chromium.org>
351
352         Reviewed by Adam Barth.
353
354         [DRT/Chromium] Fix a WebSettings handling bug
355         https://bugs.webkit.org/show_bug.cgi?id=45945
356
357         Before this change, Chromium DRT reset WebSettings for every new
358         window. It was wrong.
359         If new window is not the first one, we have to apply the same
360         settings as the first window.  So, we introduce WebPreference to
361         store the current settings, and apply it to new windows. It's same
362         as test_shell's behavior.
363
364         * DumpRenderTree/DumpRenderTree.gypi:
365         * DumpRenderTree/chromium/LayoutTestController.cpp:
366           Use WebPreferences instead of WebSettings.
367         (LayoutTestController::setUserStyleSheetEnabled):
368         (LayoutTestController::setUserStyleSheetLocation):
369         (LayoutTestController::setAuthorAndUserStylesEnabled):
370         (LayoutTestController::setPopupBlockingEnabled):
371         (LayoutTestController::disableImageLoading):
372         (LayoutTestController::setJavaScriptCanAccessClipboard):
373         (LayoutTestController::setXSSAuditorEnabled):
374         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
375         (LayoutTestController::setAllowFileAccessFromFileURLs):
376         (LayoutTestController::overridePreference):
377         (LayoutTestController::setEditingBehavior):
378         * DumpRenderTree/chromium/TestShell.cpp:
379         (TestShell::resetWebSettings): Use WebPreferences.
380         (TestShell::runFileTest): ditto.
381         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
382         * DumpRenderTree/chromium/TestShell.h:
383         (TestShell::preferences):
384         (TestShell::applyPreferences):
385         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
386         * DumpRenderTree/chromium/WebPreferences.h: Added.
387
388 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
389
390         Reviewed by David Levin.
391
392         update-webkit --chromium spitting out a spurious error
393         https://bugs.webkit.org/show_bug.cgi?id=45868
394
395         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
396
397 2010-09-18  Sam Weinig  <sam@webkit.org>
398
399         Reviewed by Dan Bernstein.
400
401         Improve/unify the PageLoadClient interfaces
402         https://bugs.webkit.org/show_bug.cgi?id=46043
403
404         * MiniBrowser/mac/BrowserWindowController.m:
405         (didStartProvisionalLoadForFrame):
406         (didReceiveServerRedirectForProvisionalLoadForFrame):
407         (didFailProvisionalLoadWithErrorForFrame):
408         (didCommitLoadForFrame):
409         (didFinishDocumentLoadForFrame):
410         (didFinishLoadForFrame):
411         (didFailLoadWithErrorForFrame):
412         (didReceiveTitleForFrame):
413         (didFirstLayoutForFrame):
414         (didFirstVisuallyNonEmptyLayoutForFrame):
415         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
416         (WTR::InjectedBundlePage::InjectedBundlePage):
417         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
418         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
419         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
420         (WTR::InjectedBundlePage::didCommitLoadForFrame):
421         (WTR::InjectedBundlePage::didFinishLoadForFrame):
422         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
423         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
424         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
425         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
426         * WebKitTestRunner/TestController.cpp:
427         (WTR::TestController::didReceiveMessageFromInjectedBundle):
428         (WTR::TestController::didFinishLoadForFrame):
429         * WebKitTestRunner/TestController.h:
430
431 2010-09-17  Eric Seidel  <eric@webkit.org>
432
433         Unreviewed.  Adding a shell script I use to run the
434         commit-queue. Now that multiple machines run the cq,
435         it makes sense to share the script between them.
436
437         * EWSTools/start-commit-queue.sh: Added.
438
439 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
440
441         Reviewed by Jon Honeycutt.
442
443         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
444         slightly harder to read, so this reverts the previous background colors for various
445         states, making it easier to read.
446
447         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
448         (.success):
449         (.failure):
450         (.warnings):
451         (.exception):
452         (.start,.running,td.building):
453         (.offline,td.offline):
454
455 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
456
457         Unreviewed, rolling out r67692.
458         http://trac.webkit.org/changeset/67692
459         https://bugs.webkit.org/show_bug.cgi?id=46011
460
461         broke layout test dashboard (Requested by johnny_g on
462         #webkit).
463
464         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
465         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
466         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
467
468 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
469
470         Reviewed by Oliver Hunt.
471
472         Style bot complains about cairo forward declaration naming
473         https://bugs.webkit.org/show_bug.cgi?id=45867
474
475         Exclude Cairo forward declarations from indentifiers with underscores checks.
476
477         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
478         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
479
480 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
481
482         Reviewed by Ojan Vafai.
483
484         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
485         https://bugs.webkit.org/show_bug.cgi?id=45408
486
487         This change also tries to remove duplicated upload_results_json methods
488         in run_webkit_tests.py and json_results_generator.py.
489
490         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
491         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
492         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
493
494 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
495
496         Reviewed by Andreas Kling.
497
498         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
499
500         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
501         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
502         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
503         all page specific stuff to the UI.
504
505         * QtTestBrowser/launcherwindow.cpp:
506         (LauncherWindow::initializeView):
507         * QtTestBrowser/mainwindow.cpp:
508         (MainWindow::MainWindow):
509         (MainWindow::buildUI):
510         (MainWindow::setPage):
511         * QtTestBrowser/mainwindow.h:
512
513 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
514
515         Reviewed by Andreas Kling.
516
517         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
518
519         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
520         object will move to the qgraphicsscene instead of the qgraphicsview.
521
522         * QtTestBrowser/webview.cpp:
523         (WebViewGraphicsBased::setPage):
524         (WebViewGraphicsBased::setResizesToContents):
525         (WebViewGraphicsBased::resizeEvent):
526         (WebViewGraphicsBased::animatedFlip):
527         * QtTestBrowser/webview.h:
528         (WebViewGraphicsBased::setItemCacheMode):
529         (WebViewGraphicsBased::itemCacheMode):
530
531 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
532
533         Reviewed by Andreas Kling.
534
535         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
536
537         We usually separate methods whose body are larger than a few lines from the class definition.
538
539         * QtTestBrowser/webview.h:
540         (WebViewGraphicsBased::yRotation):
541         (WebViewGraphicsBased::setYRotation):
542
543 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
544
545         Reviewed by Andreas Kling.
546
547         Make initializeView method of LauncherWindow private.
548
549         No one else needs to be able to call it but LauncherWindow.
550         Also moving the declation of isGraphicsBased method down in the same file, in order
551         to better group related methods.
552
553         * QtTestBrowser/launcherwindow.h:
554
555 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
556
557         Reviewed by Andreas Kling.
558
559         Make the getter 'page' method of MainWindow const.
560
561         * QtTestBrowser/mainwindow.cpp:
562         (MainWindow::page):
563         * QtTestBrowser/mainwindow.h:
564
565 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
566
567         Reviewed by Andreas Kling.
568
569         Remove useless parameter from MainWindow class' constructor.
570
571         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
572         not referred in the constructor body and does not make much sense.
573
574         * QtTestBrowser/mainwindow.cpp:
575         (MainWindow::MainWindow):
576         * QtTestBrowser/mainwindow.h:
577
578 2010-09-15  Tony Chang  <tony@chromium.org>
579
580         Reviewed by Kent Tamura.
581
582         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
583         https://bugs.webkit.org/show_bug.cgi?id=42151
584
585         * DumpRenderTree/chromium/LayoutTestController.cpp:
586         (LayoutTestController::LayoutTestController):
587         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
588         (WorkItemLoadHTMLString::run):
589         (LayoutTestController::queueLoadHTMLString):
590         (LayoutTestController::reset):
591         (LayoutTestController::setDeferMainResourceDataLoad):
592         * DumpRenderTree/chromium/LayoutTestController.h:
593         (LayoutTestController::deferMainResourceDataLoad):
594         * DumpRenderTree/chromium/WebViewHost.cpp:
595         (WebViewHost::didCreateDataSource):
596
597 2010-09-16  Adrienne Walker  <enne@google.com>
598
599         Reviewed by Kenneth Russell.
600
601         Add script to synchronize WebKit and Khronos WebGL tests
602         https://bugs.webkit.org/show_bug.cgi?id=42336
603
604         * Scripts/update-webgl-conformance-tests: Added.
605         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
606         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
607
608 2010-09-16  Sam Weinig  <sam@webkit.org>
609
610         Reviewed by Anders Carlsson.
611
612         Add support for sending synchronous messages from the InjectedBundle to the WKContext
613         <rdar://problem/8365320>
614         https://bugs.webkit.org/show_bug.cgi?id=44785
615
616         * MiniBrowser/mac/AppDelegate.m:
617         (didReceiveSynchronousMessageFromInjectedBundle):
618         (-[BrowserAppDelegate init]):
619         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
620         (didCreatePage):
621         * WebKitTestRunner/TestController.cpp:
622         (WTR::TestController::initialize):
623
624 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
625
626         Reviewed by Andreas Kling.
627
628         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
629         https://bugs.webkit.org/show_bug.cgi?id=45885
630
631         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
632
633         * QtTestBrowser/launcherwindow.cpp:
634         (LauncherWindow::screenshot):
635
636 2010-09-16  Anders Carlsson  <andersca@apple.com>
637
638         Fix clang++ build.
639
640         * MiniBrowser/mac/BrowserWindowController.m:
641         (-[BrowserWindowController zoomIn:]):
642         (-[BrowserWindowController zoomOut:]):
643         (-[BrowserWindowController resetZoom:]):
644         Remove trailing semicolons.
645
646 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
647
648         Unreviewed, rolling out r67628.
649         http://trac.webkit.org/changeset/67628
650         https://bugs.webkit.org/show_bug.cgi?id=45904
651
652         broke the build (Requested by eric_carlson on #webkit).
653
654         * DumpRenderTree/gtk/EventSender.cpp:
655         (contextClickCallback):
656
657 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
658
659         Unreviewed.
660
661         Adding myself as a comitter.
662
663         * Scripts/webkitpy/common/config/committers.py:
664
665 2010-09-15  Philippe Normand  <pnormand@igalia.com>
666
667         Reviewed by Eric Carlson.
668
669         [GTK] enhanced context menu for media elements
670         https://bugs.webkit.org/show_bug.cgi?id=45021
671
672         EventSender::contextClick() now returns an array of js
673         objects. Each object has a title property and a click() method.
674
675         * DumpRenderTree/gtk/EventSender.cpp:
676         (getMenuItemTitleCallback):
677         (setMenuItemTitleCallback):
678         (menuItemClickCallback):
679         (getMenuItemClass):
680         (contextClickCallback):
681
682 2010-09-14  Philippe Normand  <pnormand@igalia.com>
683
684         Reviewed by Eric Carlson and Martin Robinson.
685
686         [GTK] eventSender.contextClick() should return the contents of the context menu
687         https://bugs.webkit.org/show_bug.cgi?id=39102
688
689         Make the eventSender use the new private WebKitGtk+ API to
690         retrieve the context-menu item titles and store them in an array.
691
692         * DumpRenderTree/gtk/EventSender.cpp:
693         (contextClickCallback):
694
695 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
696
697         Reviewed by Jian Li.
698
699         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
700         https://bugs.webkit.org/show_bug.cgi?id=45798
701
702         * Scripts/build-webkit:
703
704 2010-09-16  Robert Hogan  <robert@webkit.org>
705
706         Reviewed by Antonio Gomes.
707
708         [Qt] Support globalhistory tests
709         https://bugs.webkit.org/show_bug.cgi?id=45774
710
711         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
712         (WebCore::isGlobalHistoryTest):
713         (WebCore::DumpRenderTree::open):
714         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
715         (LayoutTestController::reset):
716         (LayoutTestController::dumpHistoryCallbacks):
717         (LayoutTestController::removeAllVisitedLinks):
718         * DumpRenderTree/qt/LayoutTestControllerQt.h:
719
720 2010-09-10  Tony Chang  <tony@chromium.org>
721
722         Reviewed by Eric Seidel.
723
724         deduplicate-tests should be runnable from any WebKit directory
725         https://bugs.webkit.org/show_bug.cgi?id=44709
726
727         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
728         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
729
730 2010-09-15  Tony Chang  <tony@chromium.org>
731
732         Reviewed by Kent Tamura.
733
734         [chromium] sort testing methods in DRT
735         https://bugs.webkit.org/show_bug.cgi?id=45850
736
737         * DumpRenderTree/chromium/EventSender.cpp:
738         (EventSender::EventSender):
739         * DumpRenderTree/chromium/LayoutTestController.cpp:
740         (LayoutTestController::LayoutTestController):
741         * DumpRenderTree/chromium/TextInputController.cpp:
742         (TextInputController::TextInputController):
743
744 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
745
746         Reviewed by Adam Barth.
747
748         CQ status shows items out of order
749         https://bugs.webkit.org/show_bug.cgi?id=45846
750         
751         Only group consecutive status items with the same patch ID into the same
752         group, so that overall item ordering is preserved.
753         
754         Also don't indent status items that only have a single item in their
755         group.
756
757         * QueueStatusServer/handlers/queuestatus.py:
758         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
759         * QueueStatusServer/templates/queuestatus.html:
760
761 2010-09-15  Eric Seidel  <eric@webkit.org>
762
763         Reviewed by Adam Barth.
764
765         Add queue start/stop messages
766         https://bugs.webkit.org/show_bug.cgi?id=45853
767
768         I ended up needing to clean up a bunch of our unit testing
769         in order to test this new code path nicely.
770
771         There are also a few PEP8 changes needed to pass check-webkit-style.
772
773         * Scripts/webkitpy/tool/bot/queueengine.py:
774         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
775         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
776         * Scripts/webkitpy/tool/commands/queues.py:
777         * Scripts/webkitpy/tool/commands/queues_unittest.py:
778         * Scripts/webkitpy/tool/commands/queuestest.py:
779         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
780
781 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
782
783         https://bugs.webkit.org/show_bug.cgi?id=45849
784         WKURLCreateWithCFURL crashes with null url
785         
786         Fix MiniBrowser crash when the url is not parseable.
787
788         * MiniBrowser/mac/BrowserWindowController.m:
789         (-[BrowserWindowController fetch:]):
790
791 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
792
793         Unreviewed.
794
795         Adding myself to the committers list.
796
797         * Scripts/webkitpy/common/config/committers.py:
798
799 2010-09-14  Eric Seidel  <eric@webkit.org>
800
801         Reviewed by Adam Barth.
802
803         Make it possible to run more than one commit-queue instance
804         https://bugs.webkit.org/show_bug.cgi?id=45786
805
806         Mostly we need to make sure the two (or more) instances get
807         different patches to work on.  To do this, I re-worked
808         the code responsible for getting the next work item to
809         round trip through the status server.  The status server only
810         vends patches from the work items list, only if those patches
811         have not had status reported for them in the last hour.
812
813         This is another step towards making all queues go through the
814         status server, thus making it possible to run more than one
815         instance of various EWS bots (as requested in bug 44292).
816
817         The webkitpy changes are already covered by existing unit tests.
818         The QueueStatusSever sadly has no testing infrastructure yet. :(
819
820         * QueueStatusServer/handlers/nextpatch.py: Added.
821         * QueueStatusServer/index.yaml:
822         * QueueStatusServer/main.py:
823         * Scripts/webkitpy/tool/commands/queues.py:
824
825 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
826
827         Reviewed by Tony Chang.
828
829         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
830         https://bugs.webkit.org/show_bug.cgi?id=45791
831
832         Force filenames to be raw bytes before running difflib.unified_diff.
833
834         * Scripts/webkitpy/layout_tests/port/base.py:
835         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
836
837 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
838
839         Reviewed by Tor Arne Vestbø.
840
841         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
842         https://bugs.webkit.org/show_bug.cgi?id=35247
843
844         The main issue when changing the views is that the plugins and any other components that
845         depend on view specific attributes such as the native window id are not teared down.
846         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
847         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
848         we decided to work around this in QtTestBrowser by making toggling between QWebView
849         and QGraphicsWebView also re-create the page.
850
851         * QtTestBrowser/launcherwindow.cpp:
852         (LauncherWindow::initializeView):
853         * QtTestBrowser/mainwindow.h:
854
855 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
856
857         Reviewed by Adam Barth.
858
859         Send webkit accessibility notifications to Chromium
860         https://bugs.webkit.org/show_bug.cgi?id=45156
861
862         Move printf inside shouldDumpAccessibilityNotifications check.
863
864         * DumpRenderTree/chromium/WebViewHost.cpp:
865         (WebViewHost::postAccessibilityNotification):
866
867 2010-09-14  Tony Chang  <tony@chromium.org>
868
869         Reviewed by Kent Tamura.
870
871         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
872         https://bugs.webkit.org/show_bug.cgi?id=45788
873
874         * DumpRenderTree/chromium/LayoutTestController.cpp:
875         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
876
877 2010-09-14  Tony Chang  <tony@chromium.org>
878
879         Reviewed by Ojan Vafai.
880
881         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
882         https://bugs.webkit.org/show_bug.cgi?id=45768
883
884         * DumpRenderTree/chromium/TestShell.cpp:
885         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
886
887 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
888
889         [wx] Build fix, add newly added directories to the directory list.
890
891         * wx/build/settings.py:
892
893 2010-09-14  Sam Weinig  <sam@webkit.org>
894
895         Reviewed by Anders Carlsson.
896
897         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
898         https://bugs.webkit.org/show_bug.cgi?id=45785
899
900         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
901         (WTR::propertyValue):
902         (WTR::numericWindowPropertyValue):
903         (WTR::dumpPath):
904         (WTR::toStr):
905         (WTR::operator<<):
906         (WTR::InjectedBundlePage::InjectedBundlePage):
907         (WTR::InjectedBundlePage::shouldInsertNode):
908         (WTR::InjectedBundlePage::shouldBeginEditing):
909         (WTR::InjectedBundlePage::shouldEndEditing):
910         (WTR::InjectedBundlePage::shouldInsertText):
911         (WTR::InjectedBundlePage::shouldDeleteRange):
912         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
913         (WTR::InjectedBundlePage::shouldApplyStyle):
914         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
915
916 2010-09-14  Adam Barth  <abarth@webkit.org>
917
918         Fix two typos in commit-queue.  The first is harmless.  The second
919         causes the queue to reject patches when the build is broken.  :(
920
921         * Scripts/webkitpy/tool/commands/queues.py:
922         * Scripts/webkitpy/tool/commands/queues_unittest.py:
923
924 2010-09-14  Chris Guillory   <chris.guillory@google.com>
925
926         Reviewed by Chris Fleizach.
927
928         Send all accessibility notifications to Chromium.
929         https://bugs.webkit.org/show_bug.cgi?id=45156
930
931         * DumpRenderTree/chromium/WebViewHost.cpp:
932         (WebViewHost::postAccessibilityNotification):
933         * DumpRenderTree/chromium/WebViewHost.h:
934
935 2010-09-14  Adam Barth  <abarth@webkit.org>
936
937         Reviewed by Eric Seidel.
938
939         commit-queue is slow during the day
940         https://bugs.webkit.org/show_bug.cgi?id=45780
941
942         Thanks to the new logging, we've noticed that checkout-is-out-of-date
943         errors in the first pass of landing don't retry the land.  Instead,
944         they're treated as failures and cause the commit-queue to do two more
945         builds before really trying to land the patch.  Worse, in the second
946         build, we can get bitten by a flaky test.
947
948         This patch takes a slightly different approach to the commit-queue's
949         main control logic.  We now use a separate subprocess for building and
950         testing and for landing.  This means we should very rarely see the
951         checkout-is-out-of-date error, and when we do see it, we should retry
952         more quickly.  If my understanding is correct, this should be a big
953         speed win for the commit-queue.
954
955         * Scripts/webkitpy/tool/commands/download.py:
956         * Scripts/webkitpy/tool/commands/queues.py:
957         * Scripts/webkitpy/tool/commands/queues_unittest.py:
958
959 2010-09-14  Tony Chang  <tony@chromium.org>
960
961         Reviewed by Dimitri Glazkov.
962
963         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
964         https://bugs.webkit.org/show_bug.cgi?id=45762
965
966         * DumpRenderTree/chromium/LayoutTestController.cpp:
967         (LayoutTestController::LayoutTestController):
968         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
969         * DumpRenderTree/chromium/LayoutTestController.h:
970
971 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
972
973         Adding myself as a reviewer.
974
975         * Scripts/webkitpy/common/config/committers.py:
976
977 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
978
979         Reviewed by Kenneth Rohde Christiansen.
980
981         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
982         https://bugs.webkit.org/show_bug.cgi?id=45736
983
984         Build-webkit has showed a warning when WebKitBuild didn't exist, add
985         an additional condition to avoid it.
986
987         * Scripts/build-webkit:
988
989 2010-09-13  Eric Seidel  <eric@webkit.org>
990
991         Reviewed by Adam Barth.
992
993         commit-queue should log when it's retrying due to checkout out of date error
994         https://bugs.webkit.org/show_bug.cgi?id=45725
995
996         This will allow us to better track how often we see these errors
997         and how long it takes the queue to recover from them.
998
999         In order to pass the tests, I had to correct an error
1000         from a previous change.  The UnitTestPort should not have
1001         ever been using the base port method as that will read
1002         a file from disk.  If the unit tests haven't passed the contents
1003         it should raise an IOError as though the file doesn't exist.
1004
1005         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1006         * Scripts/webkitpy/tool/commands/queues.py:
1007         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1008
1009 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
1010
1011         Reviewed by Adam Barth.
1012
1013         Upload results when cq patch landing fails
1014         https://bugs.webkit.org/show_bug.cgi?id=45683
1015         
1016         Include script errors when CommitQueue._land fails.
1017
1018         * Scripts/webkitpy/tool/commands/queues.py:
1019
1020 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1021
1022         Reviewed by David Kilzer.
1023
1024         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
1025         https://bugs.webkit.org/show_bug.cgi?id=45548
1026
1027         * DumpRenderTree/AccessibilityUIElement.cpp:
1028         (isIgnoredCallback):
1029         (AccessibilityUIElement::getJSClass):
1030         * DumpRenderTree/AccessibilityUIElement.h:
1031         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1032         (AccessibilityUIElement::isIgnored):
1033         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1034         (AccessibilityUIElement::isIgnored):
1035         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1036         (AccessibilityUIElement::isIgnored):
1037
1038 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1039
1040         Reviewed by Andreas Kling.
1041
1042         jscPath() is incorrect in Windows' cmd.exe shell
1043         https://bugs.webkit.org/show_bug.cgi?id=45651
1044
1045         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
1046
1047 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
1048
1049         Reviewed by Darin Adler.
1050
1051         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
1052         https://bugs.webkit.org/show_bug.cgi?id=43807
1053
1054         * DumpRenderTree/AccessibilityUIElement.cpp:
1055         (textMarkerForPointCallback):
1056         (AccessibilityUIElement::textMarkerForPoint):
1057         (AccessibilityUIElement::getJSClass):
1058         * DumpRenderTree/AccessibilityUIElement.h:
1059         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1060         (AccessibilityUIElement::textMarkerForPoint):
1061
1062 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
1063
1064         Reviewed by Kenneth Rohde Christiansen.
1065
1066         [Qt] build-webkit: Add --v8 option to build against V8
1067
1068         Note that V8 is picked up from QtScript, so this currently requires building
1069         against the experimental qt-script-v8 branch.
1070
1071         * Scripts/build-webkit:
1072
1073 2010-09-13  Hans Wennborg  <hans@chromium.org>
1074
1075         Reviewed by Jeremy Orlow.
1076
1077         Add WebDeviceOrientationClientMock::create() and use it from DRT.
1078         https://bugs.webkit.org/show_bug.cgi?id=45650
1079
1080         Do not use the WebDeviceOrientationClientMock constructor directly,
1081         but use the create() member function.
1082
1083         This should fix the linker errors for the multi-DLL Chromium DRT build.
1084
1085         * DumpRenderTree/chromium/LayoutTestController.cpp:
1086         (LayoutTestController::setMockDeviceOrientation):
1087         (LayoutTestController::deviceOrientationClient):
1088
1089 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
1090
1091         Reviewed by Antti Koivisto.
1092
1093         Add support for testing the viewport meta tag algorithm,
1094         based on the following draft spec:
1095
1096         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
1097
1098         Add common handling of viewport meta tag based on new Opera spec
1099         https://bugs.webkit.org/show_bug.cgi?id=44201
1100
1101         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1102         (LayoutTestController::dumpConfigurationForViewport):
1103         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1104
1105 2010-09-12  Kent Tamura  <tkent@chromium.org>
1106
1107         Reviewed by Tony Chang.
1108
1109         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
1110         https://bugs.webkit.org/show_bug.cgi?id=45517
1111
1112         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
1113
1114         * DumpRenderTree/chromium/ImageDiff.cpp:
1115         (Image::craeteFromStdin):
1116         (Image::createFromFilename):
1117         (diffImages):
1118         * DumpRenderTree/chromium/TestShell.cpp:
1119         (TestShell::dumpImage):
1120
1121 2010-09-10  MORITA Hajime  <morrita@google.com>
1122
1123         Reviewed by Tony Chang.
1124
1125         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
1126         https://bugs.webkit.org/show_bug.cgi?id=45441
1127
1128         Added TextInputController::hasSpellingMarker().
1129         
1130         * DumpRenderTree/chromium/TextInputController.cpp:
1131         (TextInputController::TextInputController):
1132         (TextInputController::hasSpellingMarker):
1133         * DumpRenderTree/chromium/TextInputController.h:
1134
1135 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
1136
1137         Unreviewed, build fix.
1138
1139         My last change accidentally contained a local change to the
1140         rebaselinig script; webkit-patch land picked it up without telling
1141         me and committed it :(
1142
1143         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1144
1145 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
1146
1147         Reviewed by Anders Carlsson.
1148
1149         Attempt to fix Windows MiniBrowser build (untested)
1150         https://bugs.webkit.org/show_bug.cgi?id=45609
1151
1152         * MiniBrowser/win/BrowserView.cpp:
1153         (runJavaScriptConfirm):
1154         (runJavaScriptPrompt):
1155
1156 2010-09-11  Sam Weinig  <sam@webkit.org>
1157
1158         Reviewed by Maciej Stachowiak.
1159
1160         Fix zoom related tests when testing WebKit2.
1161
1162         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1163         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
1164
1165 2010-09-11  Sam Weinig  <sam@webkit.org>
1166
1167         Reviewed by Dan Bernstein.
1168
1169         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
1170         <rdar://problem/8359252>
1171         https://bugs.webkit.org/show_bug.cgi?id=45605
1172
1173         * MiniBrowser/mac/BrowserWindowController.m:
1174         (setStatusText):
1175         (contentsSizeChanged):
1176         (-[BrowserWindowController awakeFromNib]):
1177         * MiniBrowser/win/BrowserView.cpp:
1178         (runJavaScriptConfirm):
1179         (runJavaScriptPrompt):
1180         (setStatusText):
1181         (contentsSizeChanged):
1182         (BrowserView::create):
1183         * WebKitTestRunner/TestController.cpp:
1184         (WTR::createOtherPage):
1185         (WTR::TestController::initialize):
1186
1187 2010-09-11  Sam Weinig  <sam@webkit.org>
1188
1189         Reviewed by Dan Bernstein.
1190
1191         Add callback mechanism for the getting the source of a frame
1192         <rdar://problem/8364681>
1193         https://bugs.webkit.org/show_bug.cgi?id=45604
1194
1195         Add ability to dump the main frame's source to the console.
1196
1197         * MiniBrowser/mac/BrowserWindowController.h:
1198         * MiniBrowser/mac/BrowserWindowController.m:
1199         (-[BrowserWindowController dumpSourceToConsole:]):
1200         * MiniBrowser/mac/MainMenu.xib:
1201
1202 2010-09-11  Eric Seidel  <eric@webkit.org>
1203
1204         Reviewed by Adam Barth.
1205
1206         Remove unneeded Empty Queue messages
1207         https://bugs.webkit.org/show_bug.cgi?id=45602
1208
1209         We already have a /gc job to delete these.
1210         recentstatus.py is already smart enough to use the
1211         most recent of the workitems last update or the most recent status,
1212         so removing these should not change the _last_status_date() return
1213         value more than a few milliseconds.
1214
1215         These messages just spam the recent status log.
1216
1217         * Scripts/webkitpy/tool/commands/queues.py:
1218
1219 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1220
1221         Reviewed by Adam Barth.
1222
1223         Fix Python exception when generating synthetic patch IDs
1224         https://bugs.webkit.org/show_bug.cgi?id=45592
1225
1226         Can't concatenate strings and numbers directly.
1227
1228         * QueueStatusServer/handlers/queuestatus.py:
1229
1230 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1231
1232         Reviewed by Adam Barth.
1233
1234         Group statuses in queue status by patch ID
1235         https://bugs.webkit.org/show_bug.cgi?id=45588
1236
1237         Group statuses by patch ID so that the status page is easier
1238         to scan.
1239
1240         * QueueStatusServer/handlers/queuestatus.py:
1241         * QueueStatusServer/stylesheets/dashboard.css:
1242         (.status-group):
1243         (.status-bug):
1244         (.status-group ul):
1245         (.status-group ul li):
1246         (.status-group ul li:hover):
1247         (.status-cell):
1248         (.status-cell:hover):
1249         (.status-cell.pass):
1250         (.status-cell.fail):
1251         (.status-cell.pending):
1252         (.status-cell.error):
1253         * QueueStatusServer/templates/dashboard.html:
1254         * QueueStatusServer/templates/queuestatus.html:
1255
1256 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
1257
1258         Reviewed by Tony Chang.
1259
1260         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1261         https://bugs.webkit.org/show_bug.cgi?id=45479
1262
1263         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1264         implementation in ResourceLoadDelegate in the Mac port).
1265
1266         * DumpRenderTree/chromium/LayoutTestController.cpp:
1267         (LayoutTestController::LayoutTestController):
1268         (LayoutTestController::dumpResourceResponseMIMETypes):
1269         (LayoutTestController::reset):
1270         * DumpRenderTree/chromium/LayoutTestController.h:
1271         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1272         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1273         * DumpRenderTree/chromium/TestShell.h:
1274         (TestShell::shouldDumpResourceResponseMIMETypes):
1275         * DumpRenderTree/chromium/WebViewHost.cpp:
1276         (WebViewHost::didReceiveResponse):
1277
1278 2010-09-11  Eric Seidel  <eric@webkit.org>
1279
1280         Reviewed by Adam Barth.
1281
1282         queues.webkit.org should expose /remote_api for data upload/download
1283         https://bugs.webkit.org/show_bug.cgi?id=45559
1284
1285         * QueueStatusServer/app.yaml:
1286          - /remote_api is a standard app-engine service which allows use of
1287            the bulk uploader for data upload/download.  Exposing this
1288            (for admin access only) allows us to use 
1289
1290 2010-09-10  Sam Weinig  <sam@webkit.org>
1291
1292         Reviewed by Dan Bernstein.
1293
1294         Add zoom support to WebKit2 API
1295         <rdar://problem/7660657>
1296         https://bugs.webkit.org/show_bug.cgi?id=45585
1297
1298         - Add zoom options to MiniBrowser that mimic Safari's options using
1299           the new WebKit2 zoom APIs.
1300         - Switch uses of float for the zoom APIs to use double.
1301
1302         * MiniBrowser/mac/BrowserWindowController.h:
1303         * MiniBrowser/mac/BrowserWindowController.m:
1304         (-[BrowserWindowController initWithPageNamespace:]):
1305         (-[BrowserWindowController validateMenuItem:]):
1306         (-[BrowserWindowController validateUserInterfaceItem:]):
1307         (-[BrowserWindowController currentZoomFactor]):
1308         (-[BrowserWindowController setCurrentZoomFactor:]):
1309         (-[BrowserWindowController canZoomIn]):
1310         (-[BrowserWindowController zoomIn:]):
1311         (-[BrowserWindowController canZoomOut]):
1312         (-[BrowserWindowController zoomOut:]):
1313         (-[BrowserWindowController canResetZoom]):
1314         (-[BrowserWindowController resetZoom:]):
1315         (-[BrowserWindowController toggleZoomMode:]):
1316         * MiniBrowser/mac/MainMenu.xib:
1317         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1318         (WTR::EventSendingController::textZoomIn):
1319         (WTR::EventSendingController::textZoomOut):
1320         (WTR::EventSendingController::zoomPageIn):
1321         (WTR::EventSendingController::zoomPageOut):
1322
1323 2010-09-10  Robert Hogan  <robert@webkit.org>
1324
1325         Reviewed by Andreas Kling.
1326
1327         [Qt] Fix crash in DRT in standalone mode
1328
1329         https://bugs.webkit.org/show_bug.cgi?id=45454
1330
1331         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1332         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1333
1334 2010-09-10  Sam Weinig  <sam@webkit.org>
1335
1336         Reviewed by Darin Adler.
1337
1338         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
1339         Precursor to <rdar://problem/7660657>
1340         https://bugs.webkit.org/show_bug.cgi?id=45522
1341
1342         Update for changes to the Bundle API to allow separate control of page and text zoom
1343         levels.
1344
1345         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1346         (WTR::EventSendingController::textZoomIn):
1347         (WTR::EventSendingController::textZoomOut):
1348         (WTR::EventSendingController::zoomPageIn):
1349         (WTR::EventSendingController::zoomPageOut):
1350         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1351         (WTR::InjectedBundlePage::reset):
1352
1353 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
1354
1355         Reviewed by Andreas Kling.
1356
1357         [Qt] Support click event for notifications
1358         https://bugs.webkit.org/show_bug.cgi?id=44836
1359
1360         Add support for simulateDesktopNotificationClick by calling
1361         back to DumpRenderTreeSupportQt.cpp.
1362
1363         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1364         (LayoutTestController::simulateDesktopNotificationClick):
1365         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1366
1367 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
1368
1369         Reviewed by Eric Seidel.
1370
1371         Update queue status when patches fail their first land attempt
1372         https://bugs.webkit.org/show_bug.cgi?id=45583
1373
1374         Add a few more _update_status calls to make it more obvious if a patch is 
1375         being retried because tests failed.
1376
1377         * Scripts/webkitpy/tool/commands/queues.py:
1378
1379 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
1380
1381         Reviewed by Andreas Kling.
1382
1383         [Qt] MiniBrowser crashes with multiply windows when closing one of them
1384         https://bugs.webkit.org/show_bug.cgi?id=45536
1385
1386         * MiniBrowser/qt/BrowserView.cpp:
1387         (BrowserView::BrowserView): Reference the context instead of adopting it
1388         because it can be shared across different views.
1389
1390 2010-09-10  Tony Chang  <tony@chromium.org>
1391
1392         Unreviewed, rolling out r67241.
1393         http://trac.webkit.org/changeset/67241
1394         https://bugs.webkit.org/show_bug.cgi?id=44709
1395
1396         Accidentally committed.
1397
1398         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1399         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1400
1401 2010-09-10  Tony Chang  <tony@chromium.org>
1402
1403         Reviewed by Ojan Vafai.
1404
1405         deduplicate-tests should be runnable from any WebKit directory
1406         https://bugs.webkit.org/show_bug.cgi?id=44709
1407
1408         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1409         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1410
1411 2010-09-10  Tony Chang  <tony@chromium.org>
1412
1413         Unreviewed, rolling out r67216.
1414         http://trac.webkit.org/changeset/67216
1415         https://bugs.webkit.org/show_bug.cgi?id=44709
1416
1417         Broke
1418
1419         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1420         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1421
1422 2010-09-10  Tony Chang  <tony@chromium.org>
1423
1424         Reviewed by Ojan Vafai.
1425
1426         deduplicate-tests should be runnable from any WebKit directory
1427         https://bugs.webkit.org/show_bug.cgi?id=44709
1428
1429         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1430         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1431
1432 2010-09-09  Hans Wennborg  <hans@chromium.org>
1433
1434         Reviewed by Jeremy Orlow.
1435
1436         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
1437         https://bugs.webkit.org/show_bug.cgi?id=45460
1438
1439         This enables DumpRenderTree to run layout tests for DeviceOrientation.
1440
1441         Also declare the LayoutTestController destructor out-of-line.
1442         Otherwise the implicit destructor would cause compiler errors because
1443         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
1444
1445         * DumpRenderTree/chromium/LayoutTestController.cpp:
1446         (LayoutTestController::~LayoutTestController):
1447         (LayoutTestController::setMockDeviceOrientation):
1448         (LayoutTestController::deviceOrientationClient):
1449         * DumpRenderTree/chromium/LayoutTestController.h:
1450         * DumpRenderTree/chromium/WebViewHost.cpp:
1451         (WebViewHost::deviceOrientationClient):
1452         * DumpRenderTree/chromium/WebViewHost.h:
1453
1454 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1455
1456         Unreviewed, rolling out r67119.
1457         http://trac.webkit.org/changeset/67119
1458         https://bugs.webkit.org/show_bug.cgi?id=45505
1459
1460         Extra newlines in results (Requested by tony^work on #webkit).
1461
1462         * DumpRenderTree/chromium/LayoutTestController.cpp:
1463         (LayoutTestController::LayoutTestController):
1464         (LayoutTestController::reset):
1465         * DumpRenderTree/chromium/LayoutTestController.h:
1466         * DumpRenderTree/chromium/TestShell.h:
1467         * DumpRenderTree/chromium/WebViewHost.cpp:
1468         (printResponseDescription):
1469         (printNodeDescription):
1470         (printRangeDescription):
1471         (WebViewHost::shouldBeginEditing):
1472         (WebViewHost::shouldEndEditing):
1473         (WebViewHost::shouldInsertNode):
1474         (WebViewHost::shouldChangeSelectedRange):
1475         (WebViewHost::shouldDeleteRange):
1476         (WebViewHost::shouldApplyStyle):
1477         (WebViewHost::didBeginEditing):
1478         (WebViewHost::didChangeSelection):
1479         (WebViewHost::didChangeContents):
1480         (WebViewHost::didEndEditing):
1481         (WebViewHost::decidePolicyForNavigation):
1482         (WebViewHost::didCancelClientRedirect):
1483         (WebViewHost::didStartProvisionalLoad):
1484         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1485         (WebViewHost::didFailProvisionalLoad):
1486         (WebViewHost::didCommitProvisionalLoad):
1487         (WebViewHost::didFinishDocumentLoad):
1488         (WebViewHost::didHandleOnloadEvents):
1489         (WebViewHost::didFailLoad):
1490         (WebViewHost::didFinishLoad):
1491         (WebViewHost::didChangeLocationWithinPage):
1492         (WebViewHost::willSendRequest):
1493         (WebViewHost::didReceiveResponse):
1494         (WebViewHost::didFinishResourceLoad):
1495         (WebViewHost::didFailResourceLoad):
1496         (WebViewHost::didDisplayInsecureContent):
1497         (WebViewHost::didRunInsecureContent):
1498         (WebViewHost::printFrameDescription):
1499
1500 2010-09-09  Michael Saboff  <msaboff@apple.com>
1501
1502         Unreviewed, adding myself to committers list.
1503
1504         * Scripts/webkitpy/common/config/committers.py:
1505
1506 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1507
1508         Reviewed by Tony Chang.
1509
1510         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
1511         https://bugs.webkit.org/show_bug.cgi?id=45479
1512
1513         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
1514         implementation in ResourceLoadDelegate in the Mac port).
1515
1516         * DumpRenderTree/chromium/LayoutTestController.cpp:
1517         (LayoutTestController::LayoutTestController):
1518         (LayoutTestController::dumpResourceResponseMIMETypes):
1519         (LayoutTestController::reset):
1520         * DumpRenderTree/chromium/LayoutTestController.h:
1521         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
1522         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
1523         * DumpRenderTree/chromium/TestShell.h:
1524         (TestShell::shouldDumpResourceResponseMIMETypes):
1525         * DumpRenderTree/chromium/WebViewHost.cpp:
1526         (WebViewHost::didReceiveResponse):
1527
1528 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
1529
1530         Reviewed by Daniel Bates.
1531
1532         svn-apply tries to delete directories it shouldn't
1533         https://bugs.webkit.org/show_bug.cgi?id=45424
1534
1535         isDirectoryEmptyForRemoval had the wrong check. If an item in the
1536         directory is itself a directory, then the directory is definitely
1537         not empty.
1538
1539         * Scripts/svn-apply:
1540
1541 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
1542
1543         Fixing GTK and windows build failure.
1544
1545         AX: Support AccessibilityTextMarkers in DRT
1546         https://bugs.webkit.org/show_bug.cgi?id=44778
1547
1548         * DumpRenderTree/AccessibilityTextMarker.h:
1549         (AccessibilityTextMarker::platformTextMarker):
1550         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1551         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1552         (AccessibilityTextMarker::platformTextMarker):
1553         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1554
1555 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
1556
1557         Reviewed by David Kilzer.
1558
1559         AX: Support AccessibilityTextMarkers in DRT
1560         https://bugs.webkit.org/show_bug.cgi?id=44778
1561
1562         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
1563         that WebCore uses when vending information about its VisiblePositions through AX.
1564
1565         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
1566         methods for encapsulating and checking equality.
1567
1568         This will allow future bug fixes in the text marker system to be adequately tested.
1569
1570         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
1571         (toTextMarker):
1572         (isMarkerEqualCallback):
1573         (markerFinalize):
1574         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
1575         (AccessibilityTextMarker::getJSClass):
1576         (toTextMarkerRange):
1577         (isMarkerRangeEqualCallback):
1578         (markerRangeFinalize):
1579         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
1580         (AccessibilityTextMarkerRange::getJSClass):
1581         * DumpRenderTree/AccessibilityTextMarker.h: Added.
1582         (AccessibilityTextMarker::platformTextMarker):
1583         (AccessibilityTextMarkerRange::platformTextMarkerRange):
1584         (AccessibilityTextMarker::AccessibilityTextMarker):
1585         (AccessibilityTextMarker::~AccessibilityTextMarker):
1586         (AccessibilityTextMarker::isEqual):
1587         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1588         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1589         (AccessibilityTextMarkerRange::isEqual):
1590         * DumpRenderTree/AccessibilityUIElement.cpp:
1591         (textMarkerRangeForElementCallback):
1592         (textMarkerRangeLengthCallback):
1593         (textMarkerRangeForMarkersCallback):
1594         (startTextMarkerForTextMarkerRangeCallback):
1595         (endTextMarkerForTextMarkerRangeCallback):
1596         (accessibilityElementForTextMarkerCallback):
1597         (AccessibilityUIElement::textMarkerRangeForElement):
1598         (AccessibilityUIElement::textMarkerRangeLength):
1599         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1600         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1601         (AccessibilityUIElement::accessibilityElementForTextMarker):
1602         (AccessibilityUIElement::getJSClass):
1603         * DumpRenderTree/AccessibilityUIElement.h:
1604         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1605         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
1606         (AccessibilityTextMarker::AccessibilityTextMarker):
1607         (AccessibilityTextMarker::~AccessibilityTextMarker):
1608         (AccessibilityTextMarker::isEqual):
1609         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1610         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1611         (AccessibilityTextMarkerRange::isEqual):
1612         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1613         (AccessibilityUIElement::textMarkerRangeForElement):
1614         (AccessibilityUIElement::textMarkerRangeLength):
1615         (AccessibilityUIElement::textMarkerRangeForMarkers):
1616         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1617         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1618         (AccessibilityUIElement::accessibilityElementForTextMarker):
1619         * DumpRenderTree/win/DumpRenderTree.vcproj:
1620
1621 2010-08-25  Tony Chang  <tony@chromium.org>
1622
1623         Reviewed by Ojan Vafai.
1624
1625         don't delete duplicates needed because of intermediate results
1626         https://bugs.webkit.org/show_bug.cgi?id=44653
1627
1628         Also, output the full path so we can pipe the output to rm.
1629
1630         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1631         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1632
1633 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
1634
1635         Reviewed by Andreas Kling.
1636
1637         [Qt] MiniBrowser does not starts properly
1638         https://bugs.webkit.org/show_bug.cgi?id=45459
1639
1640         Do not try set up the first window by calling newWindow on a
1641         newly created BrowserWindow since it creates a new object.
1642         * MiniBrowser/qt/BrowserWindow.cpp:
1643         (BrowserWindow::BrowserWindow):
1644         * MiniBrowser/qt/main.cpp:
1645         (main):
1646
1647 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
1648
1649         Reviewed by Xan Lopez.
1650
1651         [GTK] Get ImageDiff building on Win32
1652         https://bugs.webkit.org/show_bug.cgi?id=45353
1653
1654         * DumpRenderTree/gtk/ImageDiff.cpp:
1655         (main): Switch from using strtok to g_strsplit.
1656
1657 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
1658
1659         Reviewed by Andreas Kling.
1660
1661         [Qt] Modify load method of MiniBrowser's BrowserView class
1662         https://bugs.webkit.org/show_bug.cgi?id=45442
1663
1664         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
1665
1666         * MiniBrowser/qt/BrowserView.cpp:
1667         (BrowserView::load):
1668         * MiniBrowser/qt/BrowserView.h:
1669         * MiniBrowser/qt/BrowserWindow.cpp:
1670         (BrowserWindow::load):
1671
1672 2010-09-09  Tony Chang  <tony@chromium.org>
1673
1674         Reviewed by Ojan Vafai.
1675
1676         fix show_results in new-run-webkit-tests
1677         https://bugs.webkit.org/show_bug.cgi?id=45413
1678
1679         * Scripts/webkitpy/layout_tests/port/chromium.py:
1680
1681 2010-09-08  Victor Wang  <victorw@chromium.org>
1682
1683         Reviewed by Ojan Vafai.
1684
1685         [Chromium] Fix test results server to make sure
1686         it does not have corrupted data.
1687
1688         results.json file size coulbe be >1M and we split
1689         the data into multiple data store entries in this
1690         case. This patch fixes the issue that the data may
1691         be corrupted if data store error happens in the middle
1692         of saving multiple entries.
1693
1694         https://bugs.webkit.org/show_bug.cgi?id=45063
1695
1696         * TestResultServer/model/datastorefile.py:
1697
1698 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
1699
1700         Reviewed by Kenneth Rohde Christiansen.
1701
1702         Fix ignoring return value warning in case of gcc 4.4.4
1703         https://bugs.webkit.org/show_bug.cgi?id=45384
1704
1705         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1706         (testPostURLFile):
1707         If fwrite have written zero byte then the testPostURLFile function
1708         returns with false as tempFile can't be opened.
1709         * DumpRenderTree/qt/ImageDiff.cpp:
1710         (main):
1711         Put fwrite function into an if condition without body to avoid
1712         warning. It is safe because this function writes to the stdout.
1713
1714 2010-09-08  Satish Sampath  <satish@chromium.org>
1715
1716         Unreviewed, adding myself to committers list.
1717
1718         * Scripts/webkitpy/common/config/committers.py:
1719
1720 2010-09-08  Hans Wennborg  <hans@chromium.org>
1721
1722         Unreviewed.
1723
1724         Adding myself as a committer in committers.py.
1725
1726         * Scripts/webkitpy/common/config/committers.py:
1727
1728 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
1729
1730         Reviewed by Simon Hausmann.
1731
1732         [Qt] Refactor MiniBrowser 
1733         https://bugs.webkit.org/show_bug.cgi?id=45173
1734
1735         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
1736
1737         * MiniBrowser/qt/BrowserView.cpp: Added.
1738         (createNewPage):
1739         (BrowserView::BrowserView):
1740         (BrowserView::resizeEvent):
1741         (BrowserView::load):
1742         (BrowserView::view):
1743         * MiniBrowser/qt/BrowserView.h: Added.
1744         (BrowserView::~BrowserView):
1745         * MiniBrowser/qt/BrowserWindow.cpp:
1746         * MiniBrowser/qt/BrowserWindow.h:
1747         * MiniBrowser/qt/MiniBrowser.pro:
1748
1749 2010-09-08  Adam Barth  <abarth@webkit.org>
1750
1751         Rubber-stamped by Eric Seidel.
1752
1753         Rename DocLoader to CachedResourceLoader because that's what it does.
1754
1755         * Scripts/do-webcore-rename:
1756
1757 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
1758
1759         Reviewed by Ojan Vafai.
1760
1761         Enable incremental results.json generation for non-layout tests.
1762         https://bugs.webkit.org/show_bug.cgi?id=45315
1763
1764         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
1765
1766         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
1767
1768
1769 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
1770
1771         Unreviewed, build fix
1772
1773         Missed one test in mac_unittest.py in previous change; for some
1774         reason the method is listed twice. I will fix both for now, but will
1775         figure this out in a later, not-time-sensitive patch.
1776
1777         https://bugs.webkit.org/show_bug.cgi?id=45357
1778
1779         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1780
1781 2010-09-07  Kent Tamura  <tkent@chromium.org>
1782
1783         Reviewed by Tony Chang.
1784
1785         test-webkitpy: Fix load error of
1786         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
1787         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
1788
1789         * Scripts/webkitpy/layout_tests/port/server_process.py:
1790           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
1791           and we don't use server_process.py on Win32 Python. However
1792           unittest.py tries to load everything in a module.
1793
1794 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
1795
1796         Reviewed by Kent Tamura.
1797
1798         Fix regression introduced in previous change to new-run-webkit-tests
1799         (bug 45090) to not try to run unittests for the Mac implementation
1800         of the Port interface if we aren't running on a Mac.
1801
1802         Also fix the overrides implementation mock in the chromium unittests
1803         to fix the case where there are overrides checked in that cause
1804         problems.
1805
1806         https://bugs.webkit.org/show_bug.cgi?id=45357
1807
1808         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1809         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1810         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1811
1812 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1813
1814         Reviewed by Ojan Vafai.
1815
1816         new-run-webkit-tests: still more unit tests
1817
1818         Clean up and remove unnecessary code. Biggest notable change is
1819         moving the chromium-specific imagediff code from port/base to
1820         port/chromium.
1821
1822         Add more unit tests for run_webkit_tests.py, port/base.py,
1823         port/factory.py, port/dryrun.py, and
1824         layout_package/dump_render_tree_thread.py
1825
1826         This covers almost all of the generic and test code paths except for
1827         a few error paths involving invalid or port-specific command line
1828         arguments, and the code path for uploading results files to the
1829         buildbots.
1830         
1831         https://bugs.webkit.org/show_bug.cgi?id=45090
1832
1833         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
1834         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1835         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1836         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1837         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1838         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1839         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1840         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1841         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1842         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
1843         * Scripts/webkitpy/layout_tests/port/base.py:
1844         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1845         * Scripts/webkitpy/layout_tests/port/chromium.py:
1846         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1847         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1848         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1849         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
1850         * Scripts/webkitpy/layout_tests/port/server_process.py:
1851         * Scripts/webkitpy/layout_tests/port/test.py:
1852         * Scripts/webkitpy/layout_tests/port/webkit.py:
1853         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1854         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1855
1856 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
1857
1858         Reviewed by Darin Adler.
1859
1860         Provide a way to trigger a <select multiple> onchange event on changes
1861         https://bugs.webkit.org/show_bug.cgi?id=45192
1862
1863         Adds a selector on ObjCController for testing
1864         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
1865         its different uses.
1866
1867         * DumpRenderTree/mac/ObjCController.m:
1868         (+[ObjCController isSelectorExcludedFromWebScript:]):
1869         (+[ObjCController webScriptNameForSelector:]):
1870         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
1871
1872 2010-09-07  James Robinson  <jamesr@chromium.org>
1873
1874         Rubber-stamped by Dimitri Glazkov.
1875
1876         Move myself from the committer to the reviewer list.
1877
1878         * Scripts/webkitpy/common/config/committers.py:
1879
1880 2010-09-07  Tony Chang  <tony@chromium.org>
1881
1882         Reviewed by Darin Fisher.
1883
1884         [chromium] Make a public flag for how DRT generates bitmaps on Linux
1885         https://bugs.webkit.org/show_bug.cgi?id=45133
1886
1887         * DumpRenderTree/chromium/TestShell.cpp:
1888         (TestShell::dumpImage):
1889
1890 2010-09-07  Kent Tamura  <tkent@chromium.org>
1891
1892         Reviewed by Dimitri Glazkov.
1893
1894         [DRT/Chromium] Implement --check-layout-test-sys-deps
1895         https://bugs.webkit.org/show_bug.cgi?id=45283
1896
1897         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1898         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
1899         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
1900         * DumpRenderTree/chromium/TestShellGtk.cpp:
1901         (checkLayoutTestSystemDependencies): Add an empty implementation.
1902         * DumpRenderTree/chromium/TestShellMac.mm:
1903         (checkLayoutTestSystemDependencies): Add an empty implementation.
1904         * DumpRenderTree/chromium/TestShellWin.cpp:
1905         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
1906
1907 2010-09-07  Jessie Berlin  <jberlin@apple.com>
1908
1909         Unreviewed. Mac build fix.
1910
1911         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1912         (didClearWindowObjectForFrame):
1913
1914 2010-09-07  Jessie Berlin  <jberlin@apple.com>
1915
1916         Reviewed by Darin Adler.
1917
1918         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
1919         https://bugs.webkit.org/show_bug.cgi?id=45217
1920         
1921         Make WebKitTestRunner work with this change.
1922
1923         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1924         (WTR::InjectedBundlePage::didClearWindowForFrame):
1925         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
1926         WebFrameLoaderClient.
1927         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1928
1929 2010-09-07  Philippe Normand  <pnormand@igalia.com>
1930
1931         Unreviewed, build fix.
1932
1933         webkit-patch command to find the ports covering a specific layout test
1934         https://bugs.webkit.org/show_bug.cgi?id=42832
1935
1936         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
1937         tests are present when building the expectations. This is needed
1938         for the unittests.
1939
1940 2010-09-06  Philippe Normand  <pnormand@igalia.com>
1941
1942         Reviewed by Adam Barth.
1943
1944         webkit-patch command to find the ports covering a specific layout test
1945         https://bugs.webkit.org/show_bug.cgi?id=42832
1946
1947         To use it: webkit-patch skipped-ports some/layout/test.html
1948
1949         * Scripts/webkitpy/layout_tests/port/base.py:
1950         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1951         * Scripts/webkitpy/layout_tests/port/chromium.py:
1952         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1953         * Scripts/webkitpy/layout_tests/port/factory.py:
1954         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1955         * Scripts/webkitpy/layout_tests/port/test.py:
1956         * Scripts/webkitpy/layout_tests/port/webkit.py:
1957         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1958         * Scripts/webkitpy/tool/commands/queries.py:
1959         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1960         * Scripts/webkitpy/tool/main.py:
1961         * Scripts/webkitpy/tool/mocktool.py:
1962
1963 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1964
1965         Reviewed by Eric Seidel.
1966
1967         [NRWT] Add temp directory to all running drivers.
1968         https://bugs.webkit.org/show_bug.cgi?id=45261
1969
1970         * Scripts/webkitpy/layout_tests/port/webkit.py:
1971
1972 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
1973
1974         Reviewed by Kent Tamura.
1975
1976         [Chromium/DRT] Empty out user stylesheet after each test run.
1977         https://bugs.webkit.org/show_bug.cgi?id=45282
1978
1979         This should significantly cut down on the number of the mysterious flaky tests
1980         whose diffs looked like the page was blown up to a very lage size. This
1981         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
1982         which set the base body font to 100px.
1983
1984         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
1985         the same thread failed.
1986
1987         * DumpRenderTree/chromium/TestShell.cpp:
1988         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
1989
1990 2010-09-06  Kent Tamura  <tkent@chromium.org>
1991
1992         Reviewed by Dimitri Glazkov.
1993
1994         [DRT/Chromium] Do not generate pixel results for text/plain resources
1995         https://bugs.webkit.org/show_bug.cgi?id=45253
1996
1997         * DumpRenderTree/chromium/TestShell.cpp:
1998         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
1999
2000 2010-09-06  Ojan Vafai  <ojan@chromium.org>
2001
2002         Reviewed by Kent Tamura.
2003
2004         print out correct error when a DRT thread dies in NRWT
2005         https://bugs.webkit.org/show_bug.cgi?id=45281
2006
2007         Not sure why, but with the parens, python 2.6.5 on Linux
2008         gives an error that raise takes 5 arguments and 0 were given.
2009         Didn't test other platforms or python versions, but putting it
2010         all on one line fixes it and correctly prints the exception
2011         from the DRT thread.
2012
2013         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2014
2015 2010-09-06  Eric Seidel  <eric@webkit.org>
2016
2017         Unreviewed, just adding some emails from lists.webkit.org.
2018
2019         Update committers.py to include emails from lists.webkit.org
2020         as found by the validate-committer-lists script.
2021
2022         * Scripts/webkitpy/common/config/committers.py:
2023
2024 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2025
2026         Reviewed by Xan Lopez.
2027
2028         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
2029         https://bugs.webkit.org/show_bug.cgi?id=45213
2030
2031         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2032         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
2033         have to surround the invocation with #ifdefs.
2034         (useLongRunningServerMode): Added.
2035         (runTestingServerLoop): Added.
2036         (initializeGlobalsFromCommandLineOptions): Added.
2037         (runTest): Removed ifdefs.
2038         (main): Use new helper functions.
2039
2040 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
2041
2042         Reviewed by Xan Lopez.
2043
2044         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
2045         https://bugs.webkit.org/show_bug.cgi?id=45235
2046
2047         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
2048         methods of the EventSender.
2049
2050         * DumpRenderTree/gtk/EventSender.cpp:
2051         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
2052         with the current modifiers.
2053         (contextClickCallback): Always send no modifiers when preparing the mouse event.
2054         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
2055         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
2056         (mouseUpCallback): Ditto.
2057
2058 2010-09-05  Peter Kasting  <pkasting@google.com>
2059
2060         Reviewed by Adam Barth.
2061
2062         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
2063         https://bugs.webkit.org/show_bug.cgi?id=45155
2064
2065         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
2066         (EventSender::handleMouseWheel):
2067
2068 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
2069
2070         Reviewed by Joseph Pecoraro.
2071
2072         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
2073         https://bugs.webkit.org/show_bug.cgi?id=45179
2074
2075         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2076         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2077
2078 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
2079
2080         Rubber-stamped by Daniel Bates.
2081
2082         Adding myself as reviewer.
2083
2084         * Scripts/webkitpy/common/config/committers.py:
2085
2086 2010-09-04  Daniel Bates  <dbates@rim.com>
2087
2088         Reviewed by Martin Robinson.
2089
2090         Teach svn-apply/unapply about svn:mergeinfo
2091         https://bugs.webkit.org/show_bug.cgi?id=45236
2092
2093         Recognize the svn:mergeinfo property and ignore it for now.
2094
2095         Currently, svn-apply/unapply recognize only '+' and '-'
2096         property changes within a diff. We should add support
2097         to recognize "Merged" and "Reverse-merged" changes as well.
2098         Because svn:mergeinfo is metadata that is used only by SVN
2099         and tends to be error-prone and/or nuisance (*), we will ignore
2100         it for now.
2101         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
2102
2103         * Scripts/VCSUtils.pm:
2104           - Modified parseSvnProperty() to recognize "Merged" and
2105             "Reverse-merged" as the start of a property value.
2106         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2107           - Added the following unit tests:
2108             "simple: add svn:mergeinfo"
2109             "simple: delete svn:mergeinfo"
2110             "simple: modified svn:mergeinfo"
2111         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2112           - Added the following unit tests:
2113             "simple: add svn:mergeinfo"
2114             "simple: delete svn:mergeinfo"
2115             "simple: modified svn:mergeinfo"
2116             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
2117             "'Merged' change followed by 'Merged' change"
2118             "'Reverse-merged' change followed by 'Reverse-merged' change"
2119         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2120           - Added the following unit tests:
2121             "'Merged' change"
2122             "'Reverse-merged' change"
2123             "'Reverse-merged' change followed by 'Merge' change"
2124             "'Merged' change followed by 'Merge' change"
2125             "'Reverse-merged' change followed by 'Reverse-merged' change"
2126             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
2127
2128 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2129
2130         Reviewed by Kenneth Rohde Christiansen.
2131
2132         [EFL] Move test browser to WebKitTools directory
2133         https://bugs.webkit.org/show_bug.cgi?id=45212
2134
2135         Follow other ports like QT and GTK which moved the test browser to
2136         WebKitTools directory.
2137
2138         * CMakeListsEfl.txt: Added.
2139         * EWebLauncher/main.c: Added.
2140         (print_history):
2141         (zoom_level_set):
2142         (on_ecore_evas_resize):
2143         (title_set):
2144         (viewport_set):
2145         (on_title_changed):
2146         (on_progress):
2147         (on_load_finished):
2148         (on_toolbars_visible_set):
2149         (on_toolbars_visible_get):
2150         (on_statusbar_visible_set):
2151         (on_statusbar_visible_get):
2152         (on_scrollbars_visible_set):
2153         (on_scrollbars_visible_get):
2154         (on_menubar_visible_set):
2155         (on_menubar_visible_get):
2156         (on_tooltip_text_set):
2157         (on_inputmethod_changed):
2158         (on_viewport_changed):
2159         (on_mouse_down):
2160         (on_focus_out):
2161         (on_focus_in):
2162         (on_resized):
2163         (on_key_down):
2164         (on_browser_del):
2165         (on_closeWindow):
2166         (quit):
2167         (browserCreate):
2168         (browserDestroy):
2169         (closeWindow):
2170         (main_signal_exit):
2171         (findThemePath):
2172         (main):
2173
2174 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
2175
2176         Reviewed by Adam Roben.
2177
2178         Set project dependencies so that they build serially. This fixes
2179         issues when running run-webkit-tests if DRT is not built yet.
2180
2181         * DumpRenderTree/DumpRenderTree.sln:
2182
2183 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
2184
2185         Reviewed by Adam Barth.
2186
2187         Fix reading configuraiton in NWRT to work on Windows.
2188         https://bugs.webkit.org/show_bug.cgi?id=45180
2189
2190         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
2191             with the file otherwise.
2192
2193 2010-09-03  Chris Rogers  <crogers@google.com>
2194
2195         Unreviewed
2196
2197         Add myself to the committers list
2198         https://bugs.webkit.org/show_bug.cgi?id=45189
2199
2200         * Scripts/webkitpy/common/config/committers.py:
2201
2202 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
2203
2204         Reviewed by Yury Semikhatsky.
2205
2206         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
2207         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
2208         https://bugs.webkit.org/show_bug.cgi?id=45137
2209
2210         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
2211
2212 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2213
2214         Reviewed by Eric Seidel.
2215
2216         Add feature detection support to NRWT.
2217         https://bugs.webkit.org/show_bug.cgi?id=41842
2218
2219         * Scripts/webkitpy/layout_tests/port/base.py:
2220         * Scripts/webkitpy/layout_tests/port/qt.py:
2221         * Scripts/webkitpy/layout_tests/port/webkit.py:
2222         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
2223
2224 2010-09-03  Hironori Bono  <hbono@chromium.org>
2225
2226         Reviewed by Kent Tamura.
2227
2228         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
2229         and implements it for Mac.
2230         https://bugs.webkit.org/show_bug.cgi?id=41832
2231
2232         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
2233         and bind it so we can call it from JavaScript.
2234         (+[TextInputController isSelectorExcludedFromWebScript:]):
2235         (+[TextInputController webScriptNameForSelector:]):
2236         (-[TextInputController hasSpellingMarker:length:]):
2237
2238 2010-09-02  Eric Seidel  <eric@webkit.org>
2239
2240         Reviewed by Adam Barth.
2241
2242         Add a unit test for commit-queue retries
2243         https://bugs.webkit.org/show_bug.cgi?id=45162
2244
2245         I think commit-queue retries are not correctly avoiding
2246         build and test on retries.  So I started testing the code.
2247         Unfortunately this test did not find the bug.  But now
2248         that we have the test we might as well keep it.
2249         I also fixed a broken import in validate-committer-lists.
2250
2251         * Scripts/validate-committer-lists:
2252         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2253
2254 2010-09-02  Kent Tamura  <tkent@chromium.org>
2255
2256         Reviewed by Dimitri Glazkov.
2257
2258         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
2259         https://bugs.webkit.org/show_bug.cgi?id=45091
2260
2261         Task.{cpp,h} introduces a simpler version of Chromium
2262         base/task.h. It doesn't have TupleN and Method.
2263
2264         * DumpRenderTree/DumpRenderTree.gypi:
2265          Add Task.cpp and Task.h
2266         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2267         (DRTDevToolsAgent::DRTDevToolsAgent):
2268         (DRTDevToolsAgent::reset):
2269         (DRTDevToolsAgent::asyncCall):
2270         (DRTDevToolsAgent::frontendLoaded):
2271         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2272         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
2273         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2274         (DRTDevToolsClient::DRTDevToolsClient):
2275         (DRTDevToolsClient::~DRTDevToolsClient):
2276         (DRTDevToolsClient::reset):
2277         (DRTDevToolsClient::asyncCall):
2278         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2279         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
2280         * DumpRenderTree/chromium/EventSender.cpp:
2281         (EventSender::EventSender):
2282         (EventSender::reset):
2283         (EventSender::scheduleAsynchronousClick):
2284         * DumpRenderTree/chromium/EventSender.h:
2285         (EventSender::taskList): Added to use MethodTask<T>.
2286         * DumpRenderTree/chromium/LayoutTestController.cpp:
2287         (LayoutTestController::LayoutTestController):
2288         (LayoutTestController::WorkQueue::processWorkSoon):
2289         (LayoutTestController::waitUntilDone):
2290         (LayoutTestController::notifyDone):
2291         (LayoutTestController::reset):
2292         * DumpRenderTree/chromium/LayoutTestController.h:
2293         (LayoutTestController::taskList): Added to use MethodTask<T>.
2294         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
2295         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2296         (deferredDisplayDispatch):
2297         (NotificationPresenter::show):
2298         * DumpRenderTree/chromium/Task.cpp: Added.
2299         * DumpRenderTree/chromium/Task.h: Added.
2300
2301 2010-09-02  Steve Block  <steveblock@google.com>
2302
2303         Reviewed by Adam Barth.
2304
2305         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
2306         https://bugs.webkit.org/show_bug.cgi?id=43181
2307
2308         * DumpRenderTree/mac/DumpRenderTree.mm:
2309         (createWebViewAndOffscreenWindow):
2310         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2311         (LayoutTestController::setMockDeviceOrientation):
2312
2313 2010-08-31  Adam Roben  <aroben@apple.com>
2314
2315         Fix flashiness when resizing the browser window on Windows
2316
2317         Reviewed by Sam Weinig.
2318
2319         * MiniBrowser/win/BrowserWindow.cpp:
2320         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
2321         periodically fill the window with white.
2322
2323 2010-09-02  Peter Kasting  <pkasting@google.com>
2324
2325         Reviewed by Dimitri Glazkov.
2326
2327         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
2328         https://bugs.webkit.org/show_bug.cgi?id=45073
2329
2330         * DumpRenderTree/chromium/EventSender.cpp:
2331         (EventSender::EventSender):
2332         (EventSender::mouseScrollBy):
2333         (EventSender::continuousMouseScrollBy):
2334         (EventSender::sendCurrentTouchEvent):
2335         (EventSender::handleMouseWheel):
2336         * DumpRenderTree/chromium/EventSender.h:
2337         * DumpRenderTree/gtk/EventSender.cpp:
2338         (mouseScrollByCallback):
2339         (continuousMouseScrollByCallback):
2340
2341 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
2342
2343         Reviewed by Tony Chang.
2344
2345         Land a patched version of r66542 - change TestRunner to have an
2346         separate cleanup method and fix the ordering of cleanup between
2347         TestRunner and the printing module, and then wrap everything in a
2348         try/finally block to ensure reliable cleanup without needing to
2349         rely on stuff happening in the destructor of the TestRunner.
2350
2351         Also refactor run_webkit_tests.run() to be much smaller and cleaner
2352         by creating a bunch of helper methods and moving more stuff into
2353         the TestRunner class.
2354
2355         This fixes the crash at the end of the linux test run of
2356         new-run-webkit-tests (and undoes the rollout in 66547).
2357
2358         https://bugs.webkit.org/show_bug.cgi?id=44902
2359
2360         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2361         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2362         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2363         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2364         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2365         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2366         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2367         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2368         * Scripts/webkitpy/layout_tests/port/base.py:
2369         * Scripts/webkitpy/layout_tests/port/test.py:
2370         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2371         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2372
2373 2010-09-01  Mark Rowe  <mrowe@apple.com>
2374
2375         Reviewed by Adam Roben.
2376
2377         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
2378
2379         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2380
2381 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
2382
2383         Reviewed by Adam Roben.
2384
2385         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
2386         and WebKitTestRunner.
2387
2388         * BuildSlaveSupport/win/kill-old-processes:
2389
2390 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2391
2392         Reviewed by Antonio Gomes.
2393
2394         [Qt] Remove obsolete include path from DumpRenderTree.pro
2395
2396         * DumpRenderTree/qt/DumpRenderTree.pro:
2397
2398 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2399
2400         Reviewed by Laszlo Gombos.
2401
2402         [Qt] QWebPage::allowGeolocationRequest should be async API
2403         https://bugs.webkit.org/show_bug.cgi?id=41364
2404
2405         Implements new async API for geolocation permission similar to
2406         Notification. WebPage maintains list of geolocation permission request
2407         QtWebkit and set's when LayoutTestController gets the access from test JS
2408
2409         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2410         (WebCore::WebPage::WebPage):
2411         (WebCore::WebPage::resetSettings):
2412         (WebCore::WebPage::requestPermission):
2413         (WebCore::WebPage::cancelPermission):
2414         (WebCore::WebPage::permissionSet):
2415         (WebCore::DumpRenderTree::DumpRenderTree):
2416         (WebCore::DumpRenderTree::processLine):
2417         (WebCore::DumpRenderTree::geolocationPermissionSet):
2418         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2419         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2420         (LayoutTestController::reset):
2421         (LayoutTestController::setGeolocationPermission):
2422         (LayoutTestController::setGeolocationPermissionCommon):
2423         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2424
2425 2010-09-01  Andras Becsi  <abecsi@webkit.org>
2426
2427         Reviewed by Antti Koivisto.
2428
2429         [Qt] Auto-generate WebKit2 forwarding headers
2430         https://bugs.webkit.org/show_bug.cgi?id=44692
2431
2432         * MiniBrowser/qt/BrowserWindow.h: use source style includes
2433         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
2434         * Scripts/enumerate-included-framework-headers: Removed.
2435
2436 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2437
2438         Reviewed by Adam Barth.
2439
2440         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
2441         https://bugs.webkit.org/show_bug.cgi?id=44789
2442
2443         * Scripts/webkitpy/common/net/bugzilla.py:
2444
2445 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
2446
2447         Reviewed by Adam Barth.
2448
2449         ews: Add support for EFL-EWS
2450         https://bugs.webkit.org/show_bug.cgi?id=44982
2451
2452         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
2453         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
2454         and add it to the ports dict.
2455         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
2456         EflEWS class.
2457         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
2458         a test case for the EFL EWS.
2459
2460 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
2461
2462         Reviewed by Sam Weinig.
2463
2464         https://bugs.webkit.org/show_bug.cgi?id=42195
2465         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
2466
2467         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2468         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
2469         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2470         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
2471         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
2472
2473         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2474         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
2475         which forgets its override.
2476
2477 2010-08-31  Sam Weinig  <sam@webkit.org>
2478
2479         Reviewed by Gavin Barraclough.
2480
2481         WebKitTestRunner needs layoutTestController.addUserStyleSheet
2482         https://bugs.webkit.org/show_bug.cgi?id=42680
2483
2484         WebKitTestRunner needs layoutTestController.addUserScript
2485         https://bugs.webkit.org/show_bug.cgi?id=42681
2486
2487         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2488         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2489         (WTR::InjectedBundle::beginTesting):
2490         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2491         (WTR::LayoutTestController::addUserScript):
2492         (WTR::LayoutTestController::addUserStyleSheet):
2493         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2494
2495 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2496
2497         Unreviewed, rolling out r66542.
2498         http://trac.webkit.org/changeset/66542
2499         https://bugs.webkit.org/show_bug.cgi?id=44902
2500
2501         r66542 - the weird logging dependencies in Python stuck again ...
2502
2503         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
2504         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
2505         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
2506         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
2507         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2508         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2509         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2510         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2511         * Scripts/webkitpy/layout_tests/port/base.py:
2512         * Scripts/webkitpy/layout_tests/port/test.py:
2513         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2514         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2515
2516 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
2517
2518         Reviewed by Tony Chang.
2519
2520         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
2521
2522         * DumpRenderTree/chromium/LayoutTestController.cpp:
2523         (LayoutTestController::LayoutTestController):
2524         (LayoutTestController::markerTextForListItem):
2525         * DumpRenderTree/chromium/LayoutTestController.h:
2526
2527 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
2528
2529         Reviewed by Ojan Vafai.
2530
2531         new-run-webkit-tests: add more unit tests
2532
2533         Add more unit tests for new-run-webkit-tests; we now cover all but
2534         the most obscure code paths in the generic code. We still need to
2535         add coverage for the http server and web socket paths, and add better
2536         coverage of the platform-specific logic. Note that the rebaselining
2537         tool is still not well tested.
2538
2539         Also clean up some of the configuration logic for the printing
2540         module and the way it interacts with the Python logging module; that
2541         is a crufty interface, to be certain.
2542         
2543         https://bugs.webkit.org/show_bug.cgi?id=44902
2544
2545         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
2546         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
2547         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
2548         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
2549         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2550         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2551         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2552         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2553         * Scripts/webkitpy/layout_tests/port/base.py:
2554         * Scripts/webkitpy/layout_tests/port/test.py:
2555         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2556         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2557
2558 2010-08-31  Darin Adler  <darin@apple.com>
2559
2560         Reviewed by Anders Carlsson.
2561
2562         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
2563         in a debug build when built with certain compilers.
2564
2565 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
2566
2567         Reviewed by Gustavo Noronha Silva.
2568
2569         [GTK] Isolate all GTK+ typedefs into one file
2570         https://bugs.webkit.org/show_bug.cgi?id=44900
2571
2572         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
2573
2574 2010-08-31  Eric Seidel  <eric@webkit.org>
2575
2576         Reviewed by Adam Barth.
2577
2578         Show more status on queue status pages
2579         https://bugs.webkit.org/show_bug.cgi?id=44938
2580
2581         I upped the number of status lines from 6 to 15 --
2582         this has been bugging me for a while...
2583
2584         I also disabled showing the chromium-win EWS queue
2585         since it's been down for almost 5 months now.
2586
2587         * QueueStatusServer/handlers/dashboard.py:
2588         * QueueStatusServer/handlers/queuestatus.py:
2589         * QueueStatusServer/model/queues.py:
2590
2591 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
2592
2593         Reviewed by Antonio Gomes.
2594
2595         [Qt] Read command line arguments and open them as URLs in new windows
2596         https://bugs.webkit.org/show_bug.cgi?id=44944
2597
2598         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
2599
2600         * MiniBrowser/qt/main.cpp:
2601         (main):
2602
2603 2010-08-31  Adrian Perez  <aperez@igalia.com>
2604
2605         Reviewed by Martin Robinson.
2606
2607         Support scripts to run Buildbot slaves under daemontools (gtk related)
2608         https://bugs.webkit.org/show_bug.cgi?id=40053
2609
2610         * BuildSlaveSupport/gtk: Added.
2611         * BuildSlaveSupport/gtk/README: Added.
2612         * BuildSlaveSupport/gtk/buildbot: Added.
2613         * BuildSlaveSupport/gtk/buildbot/log: Added.
2614         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
2615         * BuildSlaveSupport/gtk/buildbot/run: Added.
2616         * BuildSlaveSupport/gtk/crashmon: Added.
2617         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
2618         * BuildSlaveSupport/gtk/crashmon/log: Added.
2619         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
2620         * BuildSlaveSupport/gtk/crashmon/run: Added.
2621         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
2622         * BuildSlaveSupport/gtk/pulseaudio: Added.
2623         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
2624         * BuildSlaveSupport/gtk/xvfb: Added.
2625         * BuildSlaveSupport/gtk/xvfb/log: Added.
2626         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
2627         * BuildSlaveSupport/gtk/xvfb/run: Added.
2628
2629 2010-08-27  John Gregg  <johnnyg@google.com>
2630
2631         Reviewed by David Levin.
2632
2633         Notifications should support a click event.
2634         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
2635         can be simulated during a layout test.  Requires storing a list of active
2636         notifications so that they can be referred to later for clicking.
2637         https://bugs.webkit.org/show_bug.cgi?id=44800
2638
2639         * DumpRenderTree/chromium/LayoutTestController.cpp:
2640         (LayoutTestController::LayoutTestController):
2641         (LayoutTestController::simulateDesktopNotificationClick):
2642         * DumpRenderTree/chromium/LayoutTestController.h:
2643         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2644         (NotificationPresenter::simulateClick):
2645         (NotificationPresenter::show):
2646         (NotificationPresenter::cancel):
2647         (NotificationPresenter::objectDestroyed):
2648         * DumpRenderTree/chromium/NotificationPresenter.h:
2649
2650 2010-08-30  Alice Liu  <alice.liu@apple.com>
2651
2652         Reviewed by Darin Adler.
2653
2654         Add missing parts of didFinishDocumentLoadForFrame
2655         https://bugs.webkit.org/show_bug.cgi?id=44913
2656
2657         * MiniBrowser/mac/BrowserWindowController.m:
2658         (didFinishDocumentLoadForFrame): Added
2659         (-[BrowserWindowController awakeFromNib]): Updated struct
2660         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2661         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
2662         * WebKitTestRunner/TestController.cpp:
2663         (WTR::TestController::initialize): Updated struct
2664
2665 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
2666
2667         Unreviewed: Add myself to the list of Committers.
2668
2669         * Scripts/webkitpy/common/config/committers.py:
2670
2671 2010-08-30  Kent Tamura  <tkent@chromium.org>
2672
2673         Reviewed by Adam Barth.
2674
2675         Fix fast/notifications/notifications-display-close-events.html failure
2676         https://bugs.webkit.org/show_bug.cgi?id=44585
2677
2678         Apply http://crrev.com/48893. We should dispatch display events
2679         asynchronously.
2680
2681         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2682         (deferredDisplayDispatch):
2683         (NotificationPresenter::show):
2684
2685 2010-08-30  Robert Hogan  <robert@webkit.org>
2686
2687         Reviewed by Simon Hausmann.
2688
2689         allow ports with windowed plugins to support windowless plugin tests
2690
2691         https://bugs.webkit.org/show_bug.cgi?id=40730
2692
2693         Ports that implement plugins windowed by default need to have a way of
2694         supporting plugin tests that assume the plugin is windowless. Add this
2695         feature to the tests and support it in the webkit test plugin. Also
2696         add mouse and keyboard event logging to the webkit-test plugin on Unix.
2697
2698         Unskip the following tests on Qt:
2699
2700         plugins/mouse-events.html
2701         plugins/keyboard-events.html
2702         plugins/mouse-events-fixedpos.html
2703
2704         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2705         (pluginSetProperty):
2706         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2707         (NPP_New):
2708         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2709         (webkit_test_plugin_handle_event):
2710
2711 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
2712
2713         [wx] Build fix after addition of fileapi directory in WebCore.
2714
2715         * wx/build/settings.py:
2716
2717 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2718
2719         Reviewed by Xan Lopez.
2720
2721         Fixed compilation error, now that we have included the
2722         GtkVersioning.h we have to remove some version dependent code from
2723         EventSender.
2724
2725         * DumpRenderTree/gtk/EventSender.cpp:
2726
2727 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2728
2729         Reviewed by Martin Robinson.
2730
2731         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
2732         are deprecated
2733         https://bugs.webkit.org/show_bug.cgi?id=44787
2734
2735         We have replaced GtkVersioning.cpp with GtkVersioning.c and
2736         created a function (getDefaultGDKPointerDevice) to get the pointer
2737         of the window with the new APIs. We added that function to DRT and
2738         copyandpaste unit test.
2739
2740         * DumpRenderTree/gtk/EventSender.cpp:
2741         (prepareMouseButtonEvent):
2742         (mouseMoveToCallback):
2743         (keyDownCallback):
2744         * GNUmakefile.am:
2745
2746 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
2747
2748         Reviewed by Kenneth Rohde Christiansen.
2749
2750         [Qt] Add new window menu to MiniBrowser
2751
2752         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
2753
2754         * MiniBrowser/qt/BrowserWindow.cpp:
2755         (BrowserWindow::BrowserWindow):
2756         (BrowserWindow::newWindow):
2757         * MiniBrowser/qt/BrowserWindow.h:
2758         * MiniBrowser/qt/main.cpp:
2759         (main):
2760
2761 2010-08-29  James Robinson  <jamesr@chromium.org>
2762
2763         Reviewed by David Levin.
2764
2765         Make failing the download step fail the build
2766         https://bugs.webkit.org/show_bug.cgi?id=44298
2767
2768         If the download step fails on a test bot, this ensures that
2769         the build goes red instead of only the download step going red
2770         and the overall build staying green.
2771
2772         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2773
2774 2010-08-29  Kent Tamura  <tkent@chromium.org>
2775
2776         Reviewed by Dimitri Glazkov.
2777
2778         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
2779         https://bugs.webkit.org/show_bug.cgi?id=44847
2780
2781         * DumpRenderTree/chromium/EventSender.cpp:
2782          Use webkit_support::VKEY_* instead of base::VKEY_*.
2783
2784 2010-08-29  Darin Adler  <darin@apple.com>
2785
2786         https://bugs.webkit.org/show_bug.cgi?id=40589
2787
2788         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
2789         function names.
2790
2791 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2792
2793         Reviewed by Darin Adler.
2794
2795         [iExploder] Add new CSS Properties and HTML Attributes
2796         https://bugs.webkit.org/show_bug.cgi?id=44746
2797
2798         Updated the files with the update-iexploder-cssproperties script
2799         and manually readded the -webkit-binding CSS Property to the list.
2800
2801         * iExploder/htdocs/cssproperties.in:
2802         * iExploder/htdocs/htmlattrs.in:
2803         * iExploder/htdocs/htmltags.in:
2804
2805 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2806
2807         Reviewed by Darin Adler.
2808
2809         Fix Coverage build after the addition of ANGLE
2810         https://bugs.webkit.org/show_bug.cgi?id=44744
2811
2812         ANGLE is using libtool to build a static library and the version of
2813         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
2814         parameters. The easiest way to handle this is to not build ANGLE with
2815         coverage information.
2816
2817         This is achieved by applying the XCode options for each project
2818         separately and exclude ANGLE.
2819
2820         * Scripts/build-webkit: Remove -framework AppKit due link errors.
2821         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
2822
2823 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
2824
2825         [wx] Build fix after directory addition.
2826
2827         * wx/build/settings.py:
2828
2829 2010-08-28  Chris Guillory   <chris.guillory@google.com>
2830
2831         Reviewed by Chris Fleizach.
2832
2833         Add AX notification for childrenChanged
2834         https://bugs.webkit.org/show_bug.cgi?id=44472
2835
2836         * DumpRenderTree/chromium/AccessibilityController.cpp:
2837         (AccessibilityController::AccessibilityController):
2838         (AccessibilityController::reset):
2839         (AccessibilityController::getRootElement):
2840         (AccessibilityController::dumpAccessibilityNotifications):
2841         * DumpRenderTree/chromium/AccessibilityController.h:
2842         (AccessibilityController::shouldDumpAccessibilityNotifications):
2843         * DumpRenderTree/chromium/WebViewHost.cpp:
2844         (WebViewHost::didChangeAccessibilityObjectChildren):
2845         * DumpRenderTree/chromium/WebViewHost.h:
2846
2847 2010-08-28  Eric Seidel  <eric@webkit.org>
2848
2849         Reviewed by Adam Barth.
2850
2851         Update commit-queue failure message
2852         https://bugs.webkit.org/show_bug.cgi?id=44798
2853
2854         The commit-queue auto-restarts itself and has for a very long time.
2855         No need for people to email me to request a restart anymore.
2856
2857         * Scripts/webkitpy/common/net/bugzilla.py:
2858         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2859         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2860
2861 2010-07-27  Jer Noble  <jer.noble@apple.com>
2862
2863         Reviewed by Eric Carlson.
2864
2865         Add JavaScript API to allow a page to go fullscreen.
2866         rdar://problem/6867795
2867         
2868         Added basic full screen support to DumpRenderTree: when a webView requests
2869         that DumpRenderTree go "full screen", just call the provided callback listener object's
2870         will/did Enter/Exit full screen methods.  Also, register a new user default which 
2871         enables full screen support.
2872
2873         * DumpRenderTree/mac/DumpRenderTree.mm:
2874         (resetDefaultsToConsistentValues):
2875         * DumpRenderTree/mac/UIDelegate.mm:
2876         (-[UIDelegate webView:supportsFullscreenForElement:]):
2877         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
2878         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
2879
2880 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2881
2882         Unreviewed. Add myself to the committers list.
2883
2884         * Scripts/webkitpy/common/config/committers.py:
2885
2886 2010-08-27  Kent Tamura  <tkent@chromium.org>
2887
2888         Reviewed by Pavel Feldman.
2889
2890         [DRT/Chromium] Fix inspector test failures
2891         https://bugs.webkit.org/show_bug.cgi?id=44748
2892
2893         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2894         (DRTDevToolsAgent::createClientMessageLoop):
2895           Returns a valid WebKitClientMessageLoop instance
2896         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2897
2898 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
2899
2900         Add Windows WebKit2 Tester to buildbot
2901         <rdar://problem/7887703>
2902
2903         Reviewed by Dan Bernstein.
2904
2905         * BuildSlaveSupport/build.webkit.org-config/config.json:
2906
2907 2010-08-26  Philippe Normand  <pnormand@igalia.com>
2908
2909         Reviewed by Martin Robinson.
2910
2911         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
2912         https://bugs.webkit.org/show_bug.cgi?id=42152
2913
2914         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2915         (LoadHTMLStringItem::invoke): Implementation using
2916         webkit_web_frame_load_string().
2917
2918 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
2919
2920         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
2921         WebKitTestRunner (44331)
2922
2923         Reviewed by Darin Adler.
2924
2925         * WebKitTestRunner/TestController.cpp:
2926         (WTR::TestController::initialize):
2927         The hang occurs when WebKitTestRunner begins launching the WebKit2
2928         web process then exits before it finishes launching. Work around this by
2929         looking for the --print-supported-features argument and exiting without
2930         creating the web process.
2931
2932 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
2933
2934         Reviewed by Tony Chang.
2935
2936         new-run-webkit-tests: add rebaselining tests for test_expectations
2937         
2938         This patch adds more unit tests for the rebaselining code in the
2939         test_expectations module. It doesn't add any tests for
2940         rebaseline_chromium_webkit_tests itself; that will come some other
2941         time.
2942
2943         https://bugs.webkit.org/show_bug.cgi?id=44648
2944
2945         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2946         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2947
2948 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2949
2950         Reviewed by Martin Robinson.
2951
2952         [GTK] Add HTTP caching support
2953         https://bugs.webkit.org/show_bug.cgi?id=44261
2954
2955         Ignore new soup API that we decided to merge into the soup backend
2956         while it is being cooked. It follows the libsoup style, and will
2957         be removed from WebKit as soon as it is merged into libsoup.
2958
2959         * Scripts/webkitpy/style/checker.py:
2960
2961 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2962
2963         Reviewed by Kenneth Rohde Christiansen.
2964
2965         [Qt] DumpRenderTree runs only one test from command mode
2966         https://bugs.webkit.org/show_bug.cgi?id=44012
2967
2968         Enables support to run multiple test files and single
2969         folder containing html files in stand alone mode
2970
2971         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2972         (WebCore::DumpRenderTree::DumpRenderTree):
2973         (WebCore::DumpRenderTree::processArgsLine):
2974         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2975         (WebCore::DumpRenderTree::processLine):
2976         (WebCore::DumpRenderTree::dump):
2977         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2978         (WebCore::DumpRenderTree::setStandAloneMode):
2979         (WebCore::DumpRenderTree::isStandAloneMode):
2980         * DumpRenderTree/qt/main.cpp:
2981         (main):
2982
2983 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
2984
2985         Updating webkitpy test expectations.
2986
2987         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2988
2989 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2990
2991         Reviewed by Eric Seidel.
2992
2993         fix the always squash git config
2994         https://bugs.webkit.org/show_bug.cgi?id=44651
2995
2996         Fix help text and apparently underscores are not allowed
2997         in git config keys.
2998
2999         * Scripts/webkitpy/common/checkout/scm.py:
3000         * Scripts/webkitpy/tool/steps/commit.py:
3001
3002 2010-08-25  Darin Adler  <darin@apple.com>
3003
3004         Reviewed by John Sullivan.
3005
3006         * Scripts/commit-log-editor: Fix perl warning for people who have no
3007         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
3008
3009 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3010
3011         Reviewed by Eric Seidel.
3012
3013         stop blocking commits when the bots are red
3014         https://bugs.webkit.org/show_bug.cgi?id=44644
3015
3016         This check currently is just annoying. It doesn't actually
3017         help keep the tree green. We can always add it back later
3018         if we decide the tree is generally more green.
3019
3020         * Scripts/webkitpy/tool/commands/download_unittest.py:
3021         * Scripts/webkitpy/tool/mocktool.py:
3022         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
3023
3024 2010-08-25  Eric Seidel  <eric@webkit.org>
3025
3026         Reviewed by Simon Fraser.
3027
3028         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
3029         https://bugs.webkit.org/show_bug.cgi?id=38912
3030
3031         I know of nothing else to do but skip all media tests for the cq.
3032
3033         * Scripts/webkitpy/tool/steps/runtests.py:
3034
3035 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3036
3037         Reviewed by Ojan Vafai.
3038
3039         new-run-webkit-tests: add more unit tests for test_expectations
3040         This adds unit tests to cover (almost?) all of the non-rebaselining
3041         functionality.
3042
3043         https://bugs.webkit.org/show_bug.cgi?id=44579
3044
3045         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3046         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3047
3048 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3049
3050         Reviewed by Ojan Vafai.
3051
3052         new-run-webkit-tests: add more unit tests
3053
3054         This change adds more unit tests for the image_diff, test_failures,
3055         and test_files modules, bringing them to 100% coverage (and adds a
3056         couple tests to run_webkit_tests while we're at it).
3057
3058         This test also turns on the "dryrun" port for testing when run on
3059         the mac, increasing coverage in a few other places.
3060
3061         https://bugs.webkit.org/show_bug.cgi?id=44578
3062
3063         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
3064         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
3065         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
3066         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
3067         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
3068         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
3069         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
3070         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
3071         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3072         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
3073         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3074         * Scripts/webkitpy/layout_tests/port/test.py:
3075         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3076
3077 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
3078
3079         Reviewed by Ojan Vafai.
3080
3081         new-run-webkit-tests: add more unit tests for layout_package/printing.py
3082
3083         This change adds more unit tests to get the test coverage to 100%
3084         for the printing module. This code is actually pretty crufty and
3085         has some layering violations that need to be cleaned up but I'll
3086         save that for another CL after we get all the unit tests written and
3087         we fix the multithreading issues. At least now we'll be able to tell
3088         if we break things.
3089
3090         https://bugs.webkit.org/show_bug.cgi?id=44576
3091
3092         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3093         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3094
3095 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3096
3097         Reviewed by Adam Barth.
3098
3099         new-run-webkit-tests should respect set-webkit-configuration
3100         https://bugs.webkit.org/show_bug.cgi?id=44633
3101
3102         Moves the getting of the configuration into the base Port so that
3103         chromium ports use it as well. In the downstream chromium port,
3104         this should still just return Release.
3105
3106         * Scripts/webkitpy/layout_tests/port/base.py:
3107         * Scripts/webkitpy/layout_tests/port/webkit.py:
3108
3109 2010-08-25  Tony Chang  <tony@chromium.org>
3110
3111         Not reviewed, changing svn props for a script.
3112
3113         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
3114
3115 2010-08-25  Adam Barth  <abarth@webkit.org>
3116
3117         Reviewed by Eric Seidel.
3118
3119         Remove WebKit2 from core builders
3120         https://bugs.webkit.org/show_bug.cgi?id=44625
3121
3122         This builder was added to the core builders by accident.  It doesn't
3123         appear to be green enough to be a core builder yet.
3124
3125         * Scripts/webkitpy/common/net/buildbot.py:
3126         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3127
3128 2010-08-19  Adam Roben  <aroben@apple.com>
3129
3130         Test that NP_Initialize and NP_GetEntryPoints are called in the
3131         correct order
3132
3133         The order differs between Mac and Windows (see r38858).
3134
3135         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
3136         NP_Initialize when loading QuickTime when running
3137         plugins/embed-attributes-setting.html in WebKit2 on Windows
3138
3139         Reviewed by John Sullivan.
3140
3141         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
3142         a boolean to record whether NP_GetEntryPoints has been called.
3143         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
3144         called yet. This matches Flash and QuickTime's behavior.
3145         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
3146         yet. This matches Silverlight's behavior.
3147
3148 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
3149
3150         Reviewed by Gustavo Noronha Silva.
3151
3152         Cairo and EFL port shouldn't depend on glib.
3153         https://bugs.webkit.org/show_bug.cgi?id=44354
3154
3155         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
3156         adoptPlatformRef.
3157
3158         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3159         (AccessibilityUIElement::isSelected):
3160
3161 2010-08-25  Ojan Vafai  <ojan@chromium.org>
3162
3163         Fix order of Timothy's email address. The script, and
3164         other tools all assume that the first email is the bugzilla address.
3165
3166         * Scripts/webkitpy/common/config/committers.py:
3167
3168 2010-08-24  Kent Tamura  <tkent@chromium.org>
3169
3170         Reviewed by Pavel Feldman.
3171
3172         [DRT/Chromium] Fix 26 inspector test crashes
3173         https://bugs.webkit.org/show_bug.cgi?id=44580
3174
3175         - DRTDevToolsAgent has a reference to the main WebView. So we
3176           should not clear it in closeDevTools() and should clear it in
3177           ~TestShell().
3178         - DRTDevToolsClient has a reference to a DevTools WebView and no
3179           way to update it. So we should delete DRTDevToolsClient instances
3180           in closeDevTools().
3181
3182         * DumpRenderTree/chromium/TestShell.cpp:
3183         (TestShell::~TestShell):
3184         (TestShell::closeDevTools):
3185
3186 2010-08-24  Eric Seidel  <eric@webkit.org>
3187
3188         Reviewed by Adam Barth.
3189
3190         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
3191         https://bugs.webkit.org/show_bug.cgi?id=44584
3192
3193         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3194
3195 2010-08-24  Eric Seidel  <eric@webkit.org>
3196
3197         Reviewed by Adam Barth.
3198
3199         commit-queue and EWS bots should report all failures
3200         https://bugs.webkit.org/show_bug.cgi?id=41820
3201
3202         Right now commit-queue/EWS only report failures when the
3203         patch under testing fails.  We should report all failures
3204         to the status server so that we can diagnose when the bots
3205         are wedged w/o needing to log into the machines.
3206
3207         I also reduced the amount of data we upload since we've seen
3208         timeouts during status upload.
3209
3210         * Scripts/webkitpy/common/system/executive.py:
3211         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3212         * Scripts/webkitpy/tool/commands/queues.py:
3213         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3214
3215 2010-08-24  Eric Seidel  <eric@webkit.org>
3216
3217         Reviewed by Adam Barth.
3218
3219         Remove HTML5 parser testing infrastructure now that we don't need it
3220         https://bugs.webkit.org/show_bug.cgi?id=44581
3221
3222         * DumpRenderTree/mac/DumpRenderTree.mm:
3223         (resetDefaultsToConsistentValues):
3224         (initializeGlobalsFromCommandLineOptions):
3225         * Scripts/old-run-webkit-tests:
3226         * Scripts/test-html5-parser: Removed.
3227
3228 2010-08-24  Kent Tamura  <tkent@chromium.org>
3229
3230         Reviewed by Dimitri Glazkov.
3231
3232         [DRT/Chromium] Fix 28 inspector test crashes
3233         https://bugs.webkit.org/show_bug.cgi?id=44574
3234
3235         Reset DevToolsClient and DevToolsAgent before closing a DevTools
3236         WebView in order to avoid accessing to a deleted WebView instance.
3237
3238         * DumpRenderTree/chromium/TestShell.cpp:
3239         (TestShell::closeDevTools):
3240
3241 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3242
3243         Reviewed by Ojan Vafai.
3244
3245         new-run-webkit-tests: clean up code for test_types, test_failures
3246
3247         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
3248         webkitpy.layout_tests.layout_package.test_failures, and remove
3249         some dead code and otherwise clean up things.
3250
3251         https://bugs.webkit.org/show_bug.cgi?id=44559
3252
3253         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3254         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
3255         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3256         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3257         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3258         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
3259         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3260
3261 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3262
3263         Reviewed by Eric Seidel.
3264
3265         new-run-webkit-tests: revise unit testing strategy for test failures
3266     
3267         This change revamps the way we store test data for new-run-webkit-tests.
3268         Previously we had a few copies of test files from the main test tree.
3269         Now we have a bunch of completely fake test data and use the test
3270         data to generate different kinds of test failures, getting
3271         much better coverage.
3272
3273         https://bugs.webkit.org/show_bug.cgi?id=44556
3274
3275         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
3276         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
3277         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
3278         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
3279         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
3280         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
3281         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
3282         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
3283         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
3284         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
3285         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
3286         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
3287         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
3288         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
3289         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
3290         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
3291         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
3292         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
3293         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
3294         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
3295         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
3296         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
3297         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
3298         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
3299         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
3300         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
3301         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
3302         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
3303         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
3304         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
3305         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
3306         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
3307         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
3308         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
3309         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
3310         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
3311         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
3312         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
3313         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
3314         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
3315         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
3316         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
3317         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
3318         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3319         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
3320         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
3321         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3322         * Scripts/webkitpy/layout_tests/port/test.py:
3323         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3324         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3325
3326 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
3327
3328         Reviewed by Eric Seidel.
3329
3330         speed up new-run-webkit-tests unit tests
3331
3332         Add a --no-record-results flag that turns off generating the JSON
3333         results file on every test run. Generating the file requires us to
3334         fetch the old results down from the bots, which can be slow. This
3335         flag is off by default.
3336     
3337         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
3338     
3339         These changes together shorten the test cycle from ~4.5s to ~1.5s
3340         - a 3x speedup.
3341
3342         https://bugs.webkit.org/show_bug.cgi?id=44553
3343
3344         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3345         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3346
3347 2010-08-24  Tony Chang  <tony@chromium.org>
3348
3349         Reviewed by Eric Seidel.
3350
3351         [chromium] fix the platform result fallback order on mac/win
3352         https://bugs.webkit.org/show_bug.cgi?id=44483
3353
3354         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3355
3356 2010-08-24  Xan Lopez  <xlopez@igalia.com>
3357
3358         Reviewed by Martin Robinson.
3359
3360         Set a device to the event struct when building with GTK+ 3.x, it's
3361         mandatory.
3362
3363         * DumpRenderTree/gtk/EventSender.cpp:
3364         (keyDownCallback):
3365
3366 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
3367
3368         Reviewed by Xan Lopez.
3369
3370         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
3371         https://bugs.webkit.org/show_bug.cgi?id=44534
3372
3373         Fix two double-frees introduced in my previous commit.
3374
3375         * DumpRenderTree/gtk/EventSender.cpp:
3376         (contextClickCallback): Copy the event before using it again.
3377         (keyDownCallback): Ditto.
3378
3379 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
3380
3381         Reviewed by Xan Lopez.
3382
3383         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
3384         https://bugs.webkit.org/show_bug.cgi?id=44534
3385
3386         * DumpRenderTree/gtk/EventSender.cpp:
3387         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
3388         when setting it on the event. It is dereferenced by gdk_event_free(...).
3389         (contextClickCallback): Ditto.
3390         (mouseDownCallback): Ditto.
3391         (mouseUpCallback): Ditto.
3392         (mouseMoveToCallback): Ditto.
3393         (mouseWheelToCallback): Ditto.
3394         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
3395         (dispatchEvent): Ditto. Also free the event when we are done with it.
3396         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
3397
3398 2010-08-24  Andras Becsi  <abecsi@webkit.org>
3399
3400         [Qt] WebKit2 build fix.
3401
3402         * Scripts/enumerate-included-framework-headers:
3403         Remove stray global option form sed.
3404
3405 2010-08-24  Kent Tamura  <tkent@chromium.org>
3406
3407         Reviewed by Jeremy Orlow.
3408
3409         [DRT/Chromium] Support for IndexedDB tests
3410         https://bugs.webkit.org/show_bug.cgi?id=44490
3411
3412         * DumpRenderTree/chromium/TestShell.cpp:
3413         (TestShell::TestShell): Enable IndexedDB.
3414
3415 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
3416
3417         Reviewed by Gustavo Noronha Silva.
3418
3419         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
3420         https://bugs.webkit.org/show_bug.cgi?id=44465
3421
3422         Initialize the axes field of mouse button and motion events to null.
3423         This is the value that should be used for events originating from the
3424         mouse device.
3425
3426         * DumpRenderTree/gtk/EventSender.cpp:
3427         (prepareMouseButtonEvent): Initalize button event axes field to null.
3428         (mouseMoveToCallback): Initialize motion event axes field to null.
3429
3430 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3431
3432         Unreviewed, rolling out r65703.
3433         http://trac.webkit.org/changeset/65703
3434         https://bugs.webkit.org/show_bug.cgi?id=44460
3435
3436         "Causing lots of crashes on Snow Leopard when running the
3437         layout tests" (Requested by eseidel2 on #webkit).
3438
3439         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3440         (NP_Initialize):
3441         (NP_GetEntryPoints):
3442
3443 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
3444
3445         Layout tests do not run when using WebKitTestRunner in a Debug build.
3446         https://bugs.webkit.org/show_bug.cgi?id=44409
3447
3448         Reviewed by Dan Bernstein.
3449
3450         * WebKitTestRunner/win/TestControllerWin.cpp:
3451         (WTR::TestController::initializeInjectedBundlePath):
3452         Use InjectedBundle_debug.dll when building Debug.
3453
3454 2010-08-23  Xan Lopez  <xlopez@igalia.com>
3455
3456         Reviewed by Martin Robinson.
3457
3458         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
3459         https://bugs.webkit.org/show_bug.cgi?id=42026
3460
3461         If a GTK+ 3.x build is present return that as the library to use,
3462         otherwise fallback to the GTK+ 2.x build.
3463
3464         * Scripts/webkitdirs.pm:
3465
3466 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
3467
3468         Reviewed by Ariya Hidayat.
3469
3470         [Qt] Find needed forwarding headers for WebKit2 automatically
3471         https://bugs.webkit.org/show_bug.cgi?id=44336
3472
3473         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
3474         The new script does not satisfy the needs of this file however using normal includes
3475         is generally better here.
3476         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
3477         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
3478         given frameworks by files in the current directory (and subdirectories).
3479         In the future this needs to be rewritten in perl for being able to use on Windows.
3480
3481 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
3482
3483         Reviewed by Ariya Hidayat.
3484
3485         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
3486         https://bugs.webkit.org/show_bug.cgi?id=43010
3487
3488         * QtTestBrowser/launcherwindow.cpp:
3489         (LauncherWindow::applyPrefs):
3490         * QtTestBrowser/main.cpp:
3491         (LauncherApplication::handleUserOptions):
3492
3493 2010-08-21  Sam Weinig  <sam@webkit.org>
3494
3495         Reviewed by Dan Bernstein.
3496
3497         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
3498         https://bugs.webkit.org/show_bug.cgi?id=44386
3499
3500         * MiniBrowser/mac/AppDelegate.m:
3501         (didRecieveMessageFromInjectedBundle):
3502         (didNavigateWithNavigationData):
3503         (-[BrowserAppDelegate init]):
3504         (-[BrowserAppDelegate applicationWillTerminate:]):
3505         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3506         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
3507         (-[BrowserStatisticsWindowController dealloc]):
3508         * MiniBrowser/mac/BrowserWindowController.m:
3509         (-[BrowserWindowController initWithPageNamespace:]):
3510         (-[BrowserWindowController fetch:]):
3511         (-[BrowserWindowController windowWillClose:]):
3512         (-[BrowserWindowController applicationTerminating]):
3513         (closePage):
3514         (runJavaScriptAlert):
3515         (runJavaScriptConfirm):
3516         (runJavaScriptPrompt):
3517         (-[BrowserWindowController updateProvisionalURLForFrame:]):
3518         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3519         (didClearWindowObjectForFrame):
3520         * MiniBrowser/win/BrowserView.cpp:
3521         (BrowserView::goToURL):
3522         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3523         (WTR::PlatformWebView::~PlatformWebView):
3524
3525 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
3526
3527         Reviewed by Kenneth Rohde Christiansen.
3528
3529         WebKit does not build with Python 2.3
3530         https://bugs.webkit.org/show_bug.cgi?id=44373
3531
3532         Replaced the function sorted() by a call to sort()
3533         on the entry list.
3534         The function sorted() has been added to Python 2.4.
3535         The function method sort() of List works with older
3536         versions of Python.
3537
3538         * Scripts/create-html-entity-table:
3539
3540 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
3541
3542         Reviewed by Pavel Feldman.
3543
3544         Web Inspector: Inspector tests were disabled for GTK.
3545         https://bugs.webkit.org/show_bug.cgi?id=43977
3546
3547         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
3548         path before running tests.
3549
3550 2010-08-20  Daniel Bates  <dbates@rim.com>
3551
3552         Reviewed by Eric Seidel.
3553
3554         svn-apply doesn't detect empty line with Windows line endings
3555         after property value
3556         https://bugs.webkit.org/show_bug.cgi?id=43981
3557
3558         Part 2 of 2
3559
3560         Add unit tests that were not landed in the first commit.
3561
3562         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3563           - Added the following test cases:
3564             "SVN: binary file (isBinary true) using Windows line endings"
3565             "SVN: property diff, followed by file change diff using Windows line endings"
3566             "SVN: two consecutive property diffs using Windows line endings"
3567             "SVN: binary file with executable bit change usng Windows line endings"
3568             "SVN: binary file followed by property change on different file using Windows line endings"
3569             "SVN: binary file followed by file change on different file using Windows line endings"
3570             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
3571             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
3572         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3573           - Added the following test cases:
3574             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
3575             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
3576             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
3577             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
3578             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
3579             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
3580             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
3581             "single-line '+' with trailing new line using Windows line endings"
3582             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
3583             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
3584             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
3585         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3586           - Added the following test cases:
3587             "single-line '-' change followed by empty line with Windows line endings"
3588             "multi-line '+' change and start of binary patch with Windows line endings"
3589
3590 2010-08-20  Daniel Bates  <dbates@rim.com>
3591