2007-12-04 Xan Lopez <xan@gnome.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-04  Xan Lopez  <xan@gnome.org>
2
3         Reviewed by Alp Toker.
4
5         http://bugs.webkit.org/show_bug.cgi?id=15561
6         GTK port needs DumpRenderTree implementation
7
8         Start work on the GTK+ DRT.
9
10         This does not work yet, and there are a few lingering style issues
11         (nothing major) but this patch has been stuck in the bug tracker for
12         too long already.
13
14         * DumpRenderTree/DumpRenderTree.h:
15         * DumpRenderTree/gtk: Added.
16         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
17         (autocorrectURL):
18         (shouldLogFrameLoadDelegates):
19         (dumpFrameScrollPosition):
20         (displayWebView):
21         (appendString):
22         (dumpFramesAsText):
23         (dumpRenderTreeAsText):
24         (dump):
25         (runTest):
26         (main):
27         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
28         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
29         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
30         (GCController::collect):
31         (GCController::collectOnAlternateThread):
32         (GCController::getJSObjectCount):
33         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
34         (LayoutTestController::~LayoutTestController):
35         (LayoutTestController::addDisallowedURL):
36         (LayoutTestController::clearBackForwardList):
37         (LayoutTestController::copyDecodedHostName):
38         (LayoutTestController::copyEncodedHostName):
39         (LayoutTestController::display):
40         (LayoutTestController::keepWebHistory):
41         (LayoutTestController::notifyDone):
42         (LayoutTestController::queueBackNavigation):
43         (LayoutTestController::queueForwardNavigation):
44         (LayoutTestController::queueLoad):
45         (LayoutTestController::queueReload):
46         (LayoutTestController::queueScript):
47         (LayoutTestController::setAcceptsEditing):
48         (LayoutTestController::setCustomPolicyDelegate):
49         (LayoutTestController::setMainFrameIsFirstResponder):
50         (LayoutTestController::setTabKeyCyclesThroughElements):
51         (LayoutTestController::setUseDashboardCompatibilityMode):
52         (LayoutTestController::setUserStyleSheetEnabled):
53         (LayoutTestController::setUserStyleSheetLocation):
54         (LayoutTestController::setWindowIsKey):
55         (LayoutTestController::setWaitToDump):
56         (LayoutTestController::windowCount):
57         (LayoutTestController::setPrivateBrowsingEnabled):
58         (LayoutTestController::setAuthorAndUserStylesEnabled):
59         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
60         (JSStringCopyUTF8CString):
61         (LoadItem::invoke):
62         (ReloadItem::invoke):
63         (ScriptItem::invoke):
64         (BackForwardItem::invoke):
65
66 2007-12-03  Sam Weinig  <sam@webkit.org>
67
68         Move JavaScriptCore thread testing code to pthread specific directory
69         and remove the dependance on CoreFoundation by using WTF::HashSet.
70
71         Reviewed by Geoff and Oliver.
72
73         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
74         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
75         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
76         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
77         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
78         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
79         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
80         * DumpRenderTree/pthreads: Added.
81         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
82         (javaScriptThreads):
83         (runJavaScriptThread):
84         (startJavaScriptThreads):
85         (stopJavaScriptThreads):
86
87 2007-12-03  Andrew Bonventre  <andybons@google.com>
88
89         Reviewed by Darin Adler.
90
91         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
92         Symbol lookup menu broken in debugger view
93
94         * Drosera/debugger.js: Fixed javascript error where document property
95         should have been used instead of contentDocument in switchFunction that
96         was breaking the select symbol dropdown menu.  This is because
97         window.frames will return a Window object and not a frame object like
98         the author was originally expecting.
99
100 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
101
102         Reviewed by Adam.
103
104         - <rdar://5618942> Drosera: Console window does not process everything
105         correctly.
106         - <rdar://5619005> Drosera: could be sped up by moving the 
107         WebScriptScope stuff into the WebScriptCallFrame.
108         - Now the console can correctly process objects and does not receive
109         notifications from JavaScriptCore about the JavaScript in Drosera's
110         own process.
111
112         * Drosera/win/DebuggerDocumentPlatform.cpp:
113         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
114         (DebuggerDocument::platformValueForScopeVariableNamed):
115
116 2007-12-03  Stephanie  <slewis@apple.com>
117
118         Reviewed by Darin.
119
120         Check to see if we are building a debug root
121
122         * Scripts/check-for-global-initializers: 
123
124 2007-12-03  Dan Bernstein  <mitz@apple.com>
125
126         Reviewed by Darin Adler.
127
128         - added a testGetIntIdentifier() method to TestNetscapePlugIn
129
130         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
131         (pluginInvoke):
132
133 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
134
135         Reviewed by Oliver.
136
137         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
138         in a more fine-grained manner than eventSender.keyDown().
139
140         * DumpRenderTree/win/EventSender.cpp:
141         (getConstantCallback):
142         (dispatchMessageCallback):
143
144 2007-12-02  Darin Adler  <darin@apple.com>
145
146         * Scripts/do-webcore-rename: More planned renaming.
147
148 2007-12-02  Sam Weinig  <sam@webkit.org>
149
150         Rubber stamped by Anders.
151
152         Use [NSURL absoluteString] instead of [NSURL description] in order to get
153         more uniform results cross platform.
154
155         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
156         (-[NSURL _drt_descriptionSuitableForTestResult]):
157
158 2007-12-02  Sam Weinig  <sam@webkit.org>
159
160         Rubber stamped by Niko.
161
162         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
163
164         * DumpRenderTree/win/DumpRenderTree.cpp:
165         * DumpRenderTree/win/DumpRenderTree.vcproj:
166         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
167         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
168         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
169         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
170
171 2007-12-01  Alp Toker  <alp@atoker.com>
172
173         Reviewed by Adam Roben.
174
175         Make use of the newly introduced webkit.h convenience header.
176
177         * GtkLauncher/main.c:
178
179 2007-12-01  Adam Treat  <treat@kde.org>
180
181         Reviewed by Simon.
182
183         * Check to see if the directory exists and exit if not.
184
185         * DumpRenderTree/qt/main.cpp:
186         (main):
187
188 2007-12-01  Adam Treat  <treat@kde.org>
189
190         Reviewed by Simon.
191
192         * Don't hide symbols when in Debug mode
193         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
194
195
196         * DumpRenderTree/qt/main.cpp:
197         (messageHandler):
198
199 2007-11-30  Alp Toker  <alp@atoker.com>
200
201         Reviewed by Adam Roben.
202
203         http://bugs.webkit.org/show_bug.cgi?id=15691
204         [GTK] Public API does not follow GTK+ conventions
205
206         Refactor the WebKit/GTK+ public API. Changes:
207           WebKitPage -> WebKitWebView
208           WebKitFrame -> WebKitWebFrame
209
210         Public API source and header names have been updated to mirror the API
211         changes.
212
213         The API is now kept in WebKit/gtk/WebView to match other ports in the
214         same class such as Mac and Win.
215
216         * GtkLauncher/main.c:
217         (activate_uri_entry_cb):
218         (link_hover_cb):
219         (title_change_cb):
220         (progress_change_cb):
221         (go_back_cb):
222         (go_forward_cb):
223         (create_browser):
224         (main):
225
226 2007-11-30  Adam Roben  <aroben@apple.com>
227
228         Hopefully the final build fix
229
230         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
231         pull in WTF's assertion/logging functions.
232
233 2007-11-30  Adam Roben  <aroben@apple.com>
234
235         Another build fix
236
237         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
238         WebKit.lib.
239
240 2007-11-30  Adam Roben  <aroben@apple.com>
241
242         Debug build fix
243
244         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
245         configuration.
246         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
247         projects.
248         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
249         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
250         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
251
252 2007-11-30  Sam Weinig  <sam@webkit.org>
253
254         Reviewed by Adam Roben.
255
256         Fix drawSelectionRect to actually draw the selection rect.
257
258         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
259         (drawSelectionRect):
260
261 2007-11-30  Darin Adler  <darin@apple.com>
262
263         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
264
265 2007-11-30  Darin Adler  <darin@apple.com>
266
267         * Scripts/do-webcore-rename: Get ready for some future renaming.
268
269 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
270
271         Reviewed by Adam.
272
273         - Removed some unnecessary functions and changed an unused return type. 
274
275         * Drosera/win/DebuggerClient.cpp:
276         (registerConsoleClass):
277         * Drosera/win/DebuggerClient.h:
278         * Drosera/win/Drosera.cpp:
279         (registerDroseraClass):
280
281 2007-11-28  Alp Toker  <alp@atoker.com>
282
283         Reviewed by Timothy Hatcher.
284
285         http://bugs.webkit.org/show_bug.cgi?id=16174
286         [GTK] Use "URI" not "URL" in public API
287
288         Replace use of the term "URL" with "URI" in public headers,
289         documentation and some internal code to match GLib/GTK+ convention.
290
291         This is now mentioned in the API guidelines:
292           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
293
294         * GtkLauncher/main.c:
295         (activate_uri_entry_cb):
296         (title_change_cb):
297         (create_toolbar):
298         (main):
299
300 2007-11-29  Anders Carlsson  <andersca@apple.com>
301
302         Reviewed by Sam.
303
304         <rdar://problem/5230478>
305         FrameLoadDelegate callbacks are not dumped in DRT.
306         
307         * DumpRenderTree/win/DumpRenderTree.cpp:
308         (shouldLogFrameLoadDelegates):
309         (runTest):
310         (main):
311         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
312         (BSTRtoString):
313         (descriptionSuitableForTestResult):
314         (FrameLoadDelegate::QueryInterface):
315         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
316         (FrameLoadDelegate::didFailProvisionalLoadWithError):
317         (FrameLoadDelegate::didCommitLoadForFrame):
318         (FrameLoadDelegate::didFinishLoadForFrame):
319         (FrameLoadDelegate::willCloseFrame):
320         (FrameLoadDelegate::didClearWindowObject):
321         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
322         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
323         * DumpRenderTree/win/FrameLoaderDelegate.h:
324         (FrameLoadDelegate::windowScriptObjectAvailable):
325         (FrameLoadDelegate::didFirstLayoutInFrame):
326
327 2007-11-29  Sam Weinig  <sam@webkit.org>
328
329         Reviewed by Anders.
330
331         Add database quota UIDelegates methods to DRT UIDelegate.
332
333         * DumpRenderTree/mac/UIDelegate.mm:
334         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
335         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
336
337 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
338
339         Reviewed by Sam.
340
341         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
342         dying and vice versa.
343         - This fix will allow Drosera and Safari to reconnect if either of them
344         closes correctly, but does not fix the case where one of them dies
345         silently.
346
347         * Drosera/win/ServerConnection.cpp:
348         (ServerConnection::attemptToCreateServerConnection): Added a safety
349         check, because it's possilbe to try to connect to a server that's dying.
350         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
351         the server has died.
352         * Drosera/win/ServerConnection.h: Added the new function and removed
353         an unnecessary member.
354
355 2007-11-29  Anders Carlsson  <andersca@apple.com>
356
357         * DumpRenderTree/win/DumpRenderTree.vcproj:
358         Add shlwapi.lib to all configurations.
359
360 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
361
362         - Build fix.  Added additional includes for VS Express to the Release
363         project.
364
365         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
366
367 2007-11-29  Anders Carlsson  <andersca@apple.com>
368
369         Reviewed by Adam.
370
371         <rdar://problem/5132005>
372         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
373         
374         * DumpRenderTree/win/DumpRenderTree.vcproj:
375         Add shlwapi.lib
376         
377         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
378         (LayoutTestController::setUserStyleSheetEnabled):
379         Implement this.
380         
381         (appendComponentToPath):
382         New method which wraps the Win32 API PathAppend.
383         
384         (followShortcuts):
385         New method which checks if a file points to a shortcut and
386         follows the shortcut.
387         
388         (resolveCygwinPath):
389         New method that takes a cygwin unix-style path and returns the Win32 path.
390         
391         (cfStringRefToWString):
392         
393         (LayoutTestController::setUserStyleSheetLocation):
394         Implement this.
395
396 2007-11-29  Alice Liu  <alice.liu@apple.com>
397
398         Reviewed by Adam.
399
400         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
401
402         * DumpRenderTree/win/EventSender.cpp:
403         (keyDownCallback):
404         uppercase letters were being sent as lowercase letters without the shift key down.
405
406 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
407
408         - Windows build fix. VS express needs some love.
409
410         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
411
412 2007-11-28  Darin Adler  <darin@apple.com>
413
414         Reviewed by Adam Roben.
415
416         * DumpRenderTree/mac/EventSendingController.mm:
417         (-[EventSendingController keyDown:withModifiers:]):
418         Send capital letters through as lowercase letters with the shift key down
419         rather than sending them as if they were highly unusual "capital letter keys".
420
421         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
422         where you need to update results and more tests are failing than before.
423
424 2007-11-28  Anders Carlsson  <andersca@apple.com>
425
426         Reviewed by Darin.
427
428         <rdar://problem/5132001>
429         contextClick is not implemented in DRT on Windows.
430         
431         * DumpRenderTree/win/EventSender.cpp:
432         (contextClickCallback):
433         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
434         by a WM_RBUTTONUP message.
435         
436         * DumpRenderTree/win/UIDelegate.cpp:
437         (UIDelegate::hasCustomMenuImplementation):
438         (UIDelegate::trackCustomPopupMenu):
439         * DumpRenderTree/win/UIDelegate.h:
440         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
441         menu from being shown (and causing the DRT to hang).
442
443 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
444
445         Reviewed by Darin.
446
447         Fix DumpRenderTree ObjC bug comparing strings.
448
449         * DumpRenderTree/mac/ObjCController.m:
450         (-[ObjCController identityIsEqual::]): Compare strings with string
451         equality instead of identiy equality.
452
453 2007-11-27  Timothy Hatcher  <timothy@apple.com>
454
455         Reviewed by Sam.
456
457         Reset the authorAndUserStylesEnabled preference
458         back to YES for each test. Fixes the broken tests.
459
460         * DumpRenderTree/mac/DumpRenderTree.mm:
461         (resetWebViewToConsistentStateBeforeTesting):
462
463 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
464
465         Reviewed by Adam.
466
467         - Drosera now displays the console window, although it cannot currently
468         process JavaScript.
469
470         * Drosera/win/DebuggerClient.cpp: Shows the console window.
471         (registerConsoleClass): Implemented.
472         (consoleWndProc): Implemented.
473         (DebuggerClient::onSize): Implemented.
474         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
475         new window.
476         * Drosera/win/DebuggerClient.h: Added needed method and members for 
477         creating and maintaining a new window.
478         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
479         lines of code to more appropriate places.
480         (Drosera::handleCommand):
481         (Drosera::initUI):
482         (Drosera::onSize):
483         (Drosera::attach):
484
485 2007-11-27  Timothy Hatcher  <timothy@apple.com>
486
487         Reviewed by Dave Hyatt.
488
489         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
490         
491         Add support for disabling author and user styles for testing.
492
493         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
494         * DumpRenderTree/LayoutTestController.cpp:
495         (setAuthorAndUserStylesEnabledCallback):
496         (LayoutTestController::staticFunctions):
497         * DumpRenderTree/LayoutTestController.h:
498         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
499         (LayoutTestController::setAuthorAndUserStylesEnabled):
500         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
501         (LayoutTestController::setAuthorAndUserStylesEnabled):
502
503 2007-11-26  Dan Bernstein  <mitz@apple.com>
504
505         - Tiger build fix.
506
507         * DumpRenderTree/mac/Configurations/Base.xcconfig:
508
509 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
510
511         Reviewed by Maciej.
512
513         - Implemented displaying variables for Drosera on Win.
514
515         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
516         that retrieve variables to not hold onto the return value since it's
517         not returned.  Also changed to use the new signatures of the retrieval
518         functions.
519         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
520         (DebuggerDocument::platformValueForScopeVariableNamed):
521         * Drosera/win/Drosera.cpp: Removed a needless TODO.
522         (droseraWndProc):
523
524 2007-11-26  Sam Weinig  <sam@webkit.org>
525
526         Cleanup names of painting and repainting functions.
527
528         Reviewed by Adam Roben.
529
530         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
531         (drawSelectionRect): was drawSelectionRectIntoContext.
532         (dumpWebViewAsPixelsAndCompareWithExpected):
533         * DumpRenderTree/cg/PixelDumpSupportCG.h:
534         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
535         (paintWebView): was drawWebViewIntoContext.
536         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
537
538 2007-11-26  Sam Weinig  <sam@webkit.org>
539
540         Reviewed by Dan Bernstein.
541
542         - Leopard build fix
543
544         * DumpRenderTree/mac/Configurations/Base.xcconfig:
545
546 2007-11-26  Sam Weinig  <sam@webkit.org>
547
548         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
549         Use shared PixelDumpSupport for Mac DRT
550
551         Reviewed by Adam Roben.
552
553         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
554         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
555         * DumpRenderTree/cg/ImageDiffCG.cpp:
556         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
557         (drawSelectionRectIntoContext):
558         (dumpWebViewAsPixelsAndCompareWithExpected):
559         * DumpRenderTree/cg/PixelDumpSupportCG.h:
560         * DumpRenderTree/mac/Configurations/Base.xcconfig:
561         * DumpRenderTree/mac/DumpRenderTree.mm:
562         (dump):
563         * DumpRenderTree/mac/ImageDiff.m: Removed.
564         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
565         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
566         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
567         (setDefaultColorProfileToRGB):
568         (getBitmapContextFromWebView):
569         (drawWebViewIntoContext):
570         (repaintWithVerticalSweep):
571         (repaintWithHorizontalSweep):
572         (getSelectionRect):
573         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
574
575 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
576
577         Bug 16052: prepare-ChangeLog doesn't report deleted files
578         <http://bugs.webkit.org/show_bug.cgi?id=16052>
579
580         Reviewed by Sam.
581
582         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
583
584 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
585
586         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
587         <http://bugs.webkit.org/show_bug.cgi?id=15864>
588
589         Reviewed by Adam.
590
591         Roll functionality of merge-changelog into resolve-ChangeLogs
592         script.  The script now checks for ChangeLog.rej and
593         ChangeLog.orig files first.  If it finds them, it uses the
594         ChangeLog.rej file as a patch (in old contextual diff format) to
595         apply with --fuzz=3.
596
597         * Scripts/merge-changelog: Removed.
598         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
599
600 2007-11-25  Sam Weinig  <sam@webkit.org>
601
602         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
603
604         Reviewed by Mark Rowe.
605
606         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
607         * DumpRenderTree/mac/Configurations/Base.xcconfig:
608         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
609         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
610         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
611
612 2007-11-25  Sam Weinig  <sam@webkit.org>
613
614         Convert DumpRenderTree to ues .xcconfig files.
615
616         Reviewed by Mark Rowe.
617
618         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
619         * DumpRenderTree/mac/Configurations: Added.
620         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
621         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
622         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
623
624 2007-11-25  Sam Weinig  <sam@webkit.org>
625
626         Add ForwardingHeaders to wtf for DumpRenderTree.
627
628         Reviewed by Mark Rowe.
629
630         * DumpRenderTree/DumpRenderTree.h:
631         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
632         * DumpRenderTree/ForwardingHeaders: Added.
633         * DumpRenderTree/ForwardingHeaders/wtf: Added.
634         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
635         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
636         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
637         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
638         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
639         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
640         * DumpRenderTree/LayoutTestController.cpp:
641         * DumpRenderTree/WorkQueue.cpp:
642         * DumpRenderTree/mac/DumpRenderTree.mm:
643         * DumpRenderTree/mac/FrameLoadDelegate.mm:
644         * DumpRenderTree/mac/JavaScriptThreading.cpp:
645         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
646         * DumpRenderTree/mac/ObjCController.m:
647         * DumpRenderTree/mac/UIDelegate.mm:
648         * DumpRenderTree/mac/WorkQueueItemMac.mm:
649
650 2007-11-25  Adam Roben  <aroben@apple.com>
651
652         Fix some test failures caused by r28019
653
654         Now that stdout is in binary mode, we need to always use printf
655         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
656         the output.
657
658         Reviewed by Sam.
659
660         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
661         printf.
662         (UIDelegate::runJavaScriptAlertPanelWithMessage):
663         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
664         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
665         (UIDelegate::webViewAddMessageToConsole):
666
667 2007-11-25  Adam Roben  <aroben@apple.com>
668
669         Set the font smoothing preference in DRT
670
671         This makes the pixel results on Windows closer to the Mac results.
672
673         Reviewed by Mitz.
674
675         * DumpRenderTree/win/DumpRenderTree.cpp:
676         (initializePreferences):
677
678 2007-11-25  Adam Roben  <aroben@apple.com>
679
680         Port ImageDiff to CG and C++
681
682         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
683         <rdar://5071708>
684
685         Reviewed by Sam.
686
687         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
688         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
689         (main):
690         (createImageFromStdin):
691         (compareImages):
692         (getDifferenceBitmap):
693         (computePercentageDifferent):
694         * DumpRenderTree/win/ImageDiff.vcproj: Added.
695
696 2007-11-25  Adam Roben  <aroben@apple.com>
697
698         Fix image diff link generation on Windows
699
700         Reviewed by Sam.
701
702         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
703         to toURL.
704
705 2007-11-25  Adam Roben  <aroben@apple.com>
706
707         Implement pixel dumping in Windows DRT
708
709         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
710         <rdar://5071708>
711
712         Reviewed by Sam.
713
714         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
715         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
716         Content-Length header.
717         (getMD5HashStringForBitmap):
718         (dumpWebViewAsPixelsAndCompareWithExpected):
719         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
720         * DumpRenderTree/win/DumpRenderTree.cpp:
721         (dump): Do a pixel dump if requested.
722         (main): Parse pixel test options.
723         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
724         the cg/ subdirectory to the include path.
725         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
726         available in a header or import library, so we have to go through this
727         LoadLibrary/GetProcAddress dance to use them.
728         (cryptDLL):
729         (init):
730         (update):
731         (final):
732         (MD5_Init):
733         (MD5_Update):
734         (MD5_Final):
735         * DumpRenderTree/win/MD5.h: Added.
736         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
737         moved up to the top level to share it with Mac eventually.
738         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
739         (getBitmapContextFromWebView): Forces the WebView to paint using a
740         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
741
742 2007-11-25  Adam Roben  <aroben@apple.com>
743
744         Clean up Windows DRT's option parsing a little bit
745
746         Reviewed by Sam.
747
748         * DumpRenderTree/win/DumpRenderTree.cpp:
749         (main): Put non-option arguments into a Vector.
750
751 2007-11-25  Adam Roben  <aroben@apple.com>
752
753         Make Windows DRT stop changing LF into CRLF
754
755         Reviewed by Sam.
756
757         * DumpRenderTree/win/DumpRenderTree.cpp:
758         (main): Put stdout in binary mode.
759         * Scripts/run-webkit-tests: Remove the CRLF hack.
760
761 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
762
763         Removed empty directory.
764
765         * Scripts/resources: Removed.
766
767 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
768
769         Fix bisect-builds to work with recent WebKit nightly builds.
770
771         Reviewed by Dan.
772
773         * Scripts/bisect-builds: Check for the 
774         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
775         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
776         to WebKit.app/Contents/Resources.
777
778 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
779
780         Reviewed by Maciej.
781
782         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
783         not closed (affects digg.com)
784
785         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
786         one after finishing with a test to avoid having its delayed onload handler firing when
787         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
788         but it helps somewhat.
789
790 2007-11-22  Mark Rowe  <mrowe@apple.com>
791
792         Reviewed by Alp Toker.
793
794         Fix build-webkit to propagate make's exit status if it fails.
795
796         * Scripts/webkitdirs.pm:
797
798 2007-11-22  Dan Bernstein  <mitz@apple.com>
799
800         Reviewed by Mark Rowe.
801
802         - fix crash when running pixel tests
803
804         * DumpRenderTree/mac/DumpRenderTree.mm:
805         (dumpRenderTree): Parse the command line options before setting up the
806         environment so that we know if we need to set up the pixel dump
807         machinery.
808
809 2007-11-21  Eric Seidel  <eric@webkit.org>
810
811         Speculative build fix for Tiger.
812
813         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
814
815 2007-11-21  Eric Seidel  <eric@webkit.org>
816
817         Reviewed by Tim Hatcher.
818
819         Break out more of DumpRenderTree.mm into individual files
820
821         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
822         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
823         (checkedMalloc):
824         (checkedRealloc):
825         (makeLargeMallocFailSilently):
826         * DumpRenderTree/mac/CheckedMalloc.h: Added.
827         * DumpRenderTree/mac/DumpRenderTree.mm:
828         (crashHandler):
829         (dump):
830         * DumpRenderTree/mac/DumpRenderTreeMac.h:
831         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
832         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
833         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
834         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
835         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
836         (javaScriptThreads):
837         (runJavaScriptThread):
838         (startJavaScriptThreads):
839         (stopJavaScriptThreads):
840         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
841         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
842         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
843         (restoreColorSpace):
844         (setDefaultColorProfileToRGB):
845         (initializeColorSpaceAndScreeBufferForPixelTests):
846         (md5HashStringForBitmap):
847         (dumpWebViewAsPixelsAndCompareWithExpected):
848
849 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
850
851         Move install-unix-extras to wx directory as it seems only to be used by that 
852         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
853         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
854         have install-unix-extras install into WebKitLibraries as per
855         convention.
856         
857         Reviewed by Mark Rowe.
858
859         * Scripts/install-unix-extras: Removed.
860         * wx/build-wxwebkit:
861         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
862
863 2007-11-21  Eric Seidel  <eric@webkit.org>
864
865         Reviewed by Adam.
866
867         More refactoring for greater code readability
868
869         * DumpRenderTree/mac/DumpRenderTree.mm:
870         (initializeGlobalsFromCommandLineOptions):
871         (initializeColorSpaceAndScreeBufferForPixelTests):
872         (addTestPluginsToPluginSearchPath):
873         (useLongRunningServerMode):
874         (runTestingServerLoop):
875         (prepareConsistentTestingEnvironment):
876         (dumpRenderTree):
877         (main):
878         (dumpFramesAsText):
879         (dumpBackForwardListForWebView):
880         (sizeWebViewForCurrentTest):
881         (methodNameStringForFailedTest):
882         (dumpBackForwardListForAllWindows):
883         (dumpWebViewAsPixelsAndCompareWithExpected):
884         (invalidateAnyPreviousWaitToDumpWatchdog):
885         (dump):
886         * DumpRenderTree/mac/DumpRenderTreeMac.h:
887         * DumpRenderTree/mac/UIDelegate.mm:
888         (-[UIDelegate webView:createWebViewWithRequest:]):
889
890 2007-11-21  Eric Seidel  <eric@webkit.org>
891
892         Reviewed by Tim Hatcher.
893
894         Abstract more of DRT into static methods
895
896         * DumpRenderTree/mac/DumpRenderTree.mm:
897         (setDefaultsToConsistentValuesForTesting):
898         (setupSignalHandlers):
899         (allocateGlobalControllers):
900         (releaseAndZero):
901         (releaseGlobalControllers):
902         (dumpRenderTree):
903         (shouldLogFrameLoadDelegates):
904         (createCFURLFromPathOrURL):
905         (resetWebViewToConsistentStateBeforeTesting):
906         (runTest):
907
908 2007-11-21  Eric Seidel  <eric@webkit.org>
909
910         Reviewed by Tim Hatcher.
911
912         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
913
914         * DumpRenderTree/DumpRenderTree.h:
915         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
916         * DumpRenderTree/mac/DumpRenderTree.mm:
917         (dumpRenderTree):
918         (dump):
919         (runTest):
920         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
921         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
922         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
923         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
924         (-[DumpRenderTreePasteboard declareType:owner:]):
925         (+[LocalPasteboard alloc]):
926         (-[LocalPasteboard init]):
927         (-[LocalPasteboard dealloc]):
928         (-[LocalPasteboard name]):
929         (-[LocalPasteboard releaseGlobally]):
930         (-[LocalPasteboard declareTypes:owner:]):
931         (-[LocalPasteboard addTypes:owner:]):
932         (-[LocalPasteboard changeCount]):
933         (-[LocalPasteboard types]):
934         (-[LocalPasteboard availableTypeFromArray:]):
935         (-[LocalPasteboard setData:forType:]):
936         (-[LocalPasteboard dataForType:]):
937         (-[LocalPasteboard setPropertyList:forType:]):
938         (-[LocalPasteboard setString:forType:]):
939         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
940         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
941         (+[DumpRenderTreeWindow allWindows]):
942         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
943         (-[DumpRenderTreeWindow dealloc]):
944         (-[DumpRenderTreeWindow isKeyWindow]):
945         (-[DumpRenderTreeWindow keyDown:]):
946
947 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
948
949         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
950         it indiscriminately copies any headers inside JavaScriptCore,
951         which includes Tiger ICU headers. 
952
953         * wx/build-wxwebkit:
954         Don't run WebCore/move-js-headers.sh any longer.
955
956 2007-11-20  Adam Treat  <treat@kde.org>
957
958         Reviewed by David Kilzer.
959
960         * Prepend git branch name to $baseProductDir
961
962         * Scripts/VCSUtils.pm:
963         * Scripts/webkitdirs.pm:
964
965 2007-11-20  Mark Rowe  <mrowe@apple.com>
966
967         Reviewed by Simon Hausmann.
968
969         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
970         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
971         Have it trigger a "make distclean" rather than "make clean" to ensure that the
972         built product and generated Makefile's are removed.
973
974 2007-11-19  Alp Toker  <alp@atoker.com>
975
976         Reviewed by Mark Rowe.
977
978         http://bugs.webkit.org/show_bug.cgi?id=16040
979         [GTK] GtkLauncher should be written in C
980
981         Port GtkLauncher to plain C.
982
983         Use a more conventional GTK+ coding style.
984
985         Use a toolbar instead of menus.
986
987         Various signature fixes and cleanups.
988
989         Add a license header. Assume all previous modifications were copyright
990         assigned to Apple Inc. by default.
991
992         * GtkLauncher/GtkLauncher.pro:
993         * GtkLauncher/main.c: Added.
994         (activate_url_entry_cb):
995         (update_title):
996         (link_hover_cb):
997         (title_change_cb):
998         (progress_change_cb):
999         (destroy_cb):
1000         (go_back_cb):
1001         (go_forward_cb):
1002         (create_browser):
1003         (create_statusbar):
1004         (create_toolbar):
1005         (create_window):
1006         (main):
1007         * GtkLauncher/main.cpp: Removed.
1008
1009 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1010
1011         Build script fixes to ensure they do the right thing for the 
1012         wx port, and update build-wxwebkit to reflect the way the
1013         build scripts now work.
1014
1015         Reviewed by Adam.
1016
1017         * Scripts/build-testkjs:
1018         * Scripts/build-webkit:
1019         * Scripts/run-javascriptcore-tests:
1020         * Scripts/webkitdirs.pm:
1021         * wx/build-wxwebkit:
1022
1023 2007-11-18  Eric Seidel  <eric@webkit.org>
1024
1025         Reviewed by Anders.
1026
1027         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1028
1029         * Scripts/run-javascriptcore-tests:
1030
1031 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1032
1033         Reviewed by Adam Roben.
1034
1035         Make run-webkit-tests work with Windows debug build.
1036
1037         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1038         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1039         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1040         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1041         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1042
1043 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1044
1045         Add wxWebKit sample and build script, and integrate it with 
1046         build-webkit. Also make build-webkit --clean work for all
1047         ports.
1048
1049         Reviewed by Darin Adler.
1050
1051         * Scripts/build-webkit:
1052         * Scripts/webkitdirs.pm:
1053         * wx: Added.
1054         * wx/browser: Added.
1055         * wx/browser/browser.bkl: Added.
1056         * wx/browser/browser.cpp: Added.
1057         * wx/build-wxwebkit: Added.
1058
1059 2007-11-17  Adam Roben  <aroben@apple.com>
1060
1061         Make it easy to run Safari in the debugger on Windows
1062
1063         I've added a new script, debug-safari, which launches Safari in the
1064         debugger. On OS X it just calls gdb-safari.
1065
1066         Reviewed by Mark Rowe.
1067
1068         * FindSafari/FindSafari.cpp:
1069         (_tmain): Added a /debugger flag, which in combination with
1070         /printSafariLauncher will print a script that launches Safari in the
1071         debugger.
1072         * Scripts/debug-safari: Added.
1073         * Scripts/run-safari: Changed to call runSafari().
1074         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1075         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1076         first argument along to FindSafari.
1077         * Scripts/webkitdirs.pm:
1078         (sub runSafari): Added.
1079
1080 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1081
1082         Reviewed by Adam Roben.
1083
1084         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1085
1086 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1087
1088         Reviewed by David Kilzer.
1089
1090         The git config command was renamed to repo-config at some point. This
1091         change tries git config and then git repo-config if the first fails.
1092
1093         * Scripts/prepare-ChangeLog:
1094         (gitConfig):
1095
1096 2007-11-16  Dan Bernstein  <mitz@apple.com>
1097
1098         Reviewed by Darin Adler and Sam Weinig.
1099
1100         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1101
1102         * DumpRenderTree/win/EventSender.cpp:
1103         (keyDownCallback): For characters that cannot be entered on the active
1104         keyboard layout, send a WM_CHAR message with the character along with
1105         a WM_KEYDOWN message with a virtual key code of 255.
1106
1107 2007-11-16  Mark Rowe  <mrowe@apple.com>
1108
1109         Reviewed by Tim Hatcher.
1110
1111         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1112
1113         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1114         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1115
1116 2007-11-15  Adam Roben  <aroben@apple.com>
1117
1118         Make run-safari actually work on Windows
1119
1120         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1121         chdir call.
1122
1123 2007-11-14  Adam Roben  <aroben@apple.com>
1124
1125         Updates to Safari launching now that 3.0.4 is released
1126
1127         Reviewed by Sam.
1128
1129         * FindSafari/FindSafari.cpp:
1130         (getWebViewCLSID): Use version-independent ProgID.
1131         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1132
1133 2007-11-14  Anders Carlsson  <andersca@apple.com>
1134
1135         Reviewed by Adam.
1136
1137         <rdar://problem/5309081>
1138         In DRT, "plugin.logDestroy = true" not working on Windows.
1139         
1140         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1141         (NPP_Destroy):
1142
1143 2007-11-14  Eric Seidel  <eric@webkit.org>
1144
1145         Reviewed by Sam.
1146
1147         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1148
1149 2007-11-14  Anders Carlsson  <andersca@apple.com>
1150
1151         Reviewed by Adam.
1152
1153         <rdar://problem/5141186>
1154         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1155         
1156         Implement setWindowIsKey.
1157         
1158         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1159         (LayoutTestController::setWindowIsKey):
1160
1161 2007-11-13  Sam Weinig  <sam@webkit.org>
1162
1163         Reviewed by Adam Roben.
1164
1165         Fix for <rdar://problem/5382579>
1166         http/tests/security/cross-frame-access-put.html reports large 
1167         negative numbers for screenLeft and screenTop (Mac reports "0")
1168
1169         * DumpRenderTree/win/UIDelegate.cpp:
1170         (UIDelegate::UIDelegate): Initialize the RECT.
1171         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1172         (UIDelegate::webViewFrame): ditto.
1173         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1174
1175 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1176
1177         Reviewed by Adam.
1178
1179         - Make Drosera show source, source URLs, and function stack on Windows,
1180         and some minor fixes.
1181
1182         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1183         (DebuggerDocument::updateFileSource):
1184         * Drosera/debugger.js: Force source to always update display.
1185         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1186         menu controls.
1187         (DebuggerClient::resume):
1188         (DebuggerClient::pause):
1189         (DebuggerClient::stepInto):
1190         (DebuggerClient::stepOver):
1191         (DebuggerClient::stepOut):
1192         (DebuggerClient::showConsole):
1193         (DebuggerClient::closeCurrentFile):
1194         * Drosera/win/DebuggerClient.h: Ditto.
1195         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1196         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1197         removed two bugs.  1) caller could be in a bad state when asked to
1198         assign into it. 2) BSTRs were not created correctly.
1199         (DebuggerDocument::getPlatformCurrentFunctionStack):
1200         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1201         (droseraWndProc):
1202         (handleCommand):
1203         (Drosera::resume):
1204         (Drosera::pause):
1205         (Drosera::stepInto):
1206         (Drosera::stepOver):
1207         (Drosera::stepOut):
1208         (Drosera::showConsole):
1209         (Drosera::closeCurrentFile):
1210         * Drosera/win/Drosera.h: Hook up the menu controls.
1211         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1212         functions, added a null check, and fixed another bug where caller could
1213         be in a bad state when asked to assign into it.
1214         (ServerConnection::didLoadMainResourceForDataSource):
1215         (ServerConnection::getCallerFrame):
1216         * Drosera/win/ServerConnection.h: Safety first.
1217
1218 2007-11-13  Dan Bernstein  <mitz@apple.com>
1219
1220         Reviewed by Darin Adler.
1221
1222         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1223           DumpRenderTree --pixel-tests renders each test twice
1224
1225         * DumpRenderTree/mac/DumpRenderTree.mm:
1226         (dumpRenderTree): Removed the --paint option because the painting code
1227         is always exercised as a result of
1228         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1229         calling -displayIfNeeded.
1230         (dump): Changed to always grab the image from the window since the view
1231         is always displayed.
1232         (runTest):
1233         (displayWebView):
1234         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1235         because it always paints.
1236
1237 2007-11-12  Antti Koivisto  <antti@apple.com>
1238
1239         Reviewed by Adele.
1240         
1241         Add support for http media tests
1242
1243         * Scripts/run-webkit-tests:
1244
1245 2007-11-12  Sam Weinig  <sam@webkit.org>
1246
1247         Reviewed by Adam Roben.
1248
1249         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1250
1251         * DumpRenderTree/win/DumpRenderTree.cpp:
1252         (runTest):
1253         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1254         (LayoutTestController::setPrivateBrowsingEnabled):
1255
1256 2007-11-12  Adam Roben  <aroben@apple.com>
1257
1258         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1259         mac and win subdirectories.
1260
1261 2007-11-11  Adam Roben  <aroben@apple.com>
1262
1263         Fix <rdar://5133816> keepWebHistory is not implemented
1264
1265         Fixes fast/history/clicked-link-is-visited.html.
1266
1267         Reviewed by Darin.
1268
1269         * DumpRenderTree/win/DumpRenderTree.cpp:
1270         (runTest): Clear the optionalSharedHistory.
1271         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1272         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1273
1274 2007-11-10  Sam Weinig  <sam@webkit.org>
1275
1276         Reviewed by Tim Hatcher.
1277
1278         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1279         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1280         is turned on)
1281
1282         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1283
1284         Added test: http/tests/security/cross-frame-access-private-browsing.html
1285
1286         * DumpRenderTree/LayoutTestController.cpp:
1287         (setPrivateBrowsingEnabledCallback):
1288         (LayoutTestController::staticFunctions):
1289         * DumpRenderTree/LayoutTestController.h:
1290         * DumpRenderTree/mac/DumpRenderTree.mm:
1291         (runTest): Default to private browsing disabled.
1292         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1293         (LayoutTestController::setPrivateBrowsingEnabled):
1294         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1295         (LayoutTestController::setPrivateBrowsingEnabled):
1296
1297 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1298
1299         Reviewed by Adam.
1300
1301         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1302         WebCore's!
1303
1304         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1305         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1306         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1307         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1308         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1309         * Drosera/win/Drosera.cpp:
1310         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1311
1312 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1313
1314         Reviewed by Sam.
1315
1316         - Use the new IWebFrame [local] function signature and get the shared
1317         server correctly.
1318
1319         * Drosera/win/DebuggerClient.cpp:
1320         (DebuggerClient::didFinishLoadForFrame):
1321         * Drosera/win/ServerConnection.cpp:
1322         (ServerConnection::attemptToCreateServerConnection):
1323
1324 2007-11-07  Dan Bernstein  <mitz@apple.com>
1325
1326         Reviewed by Darin Adler.
1327
1328         - add an option to run-webkit-tests to ignore pixel test failures where
1329           all pixels differ by no more than a specified threshold
1330
1331         * DumpRenderTree/mac/ImageDiff.m:
1332         (main):
1333         (compareImages):
1334         (computePercentageDifferent):
1335         * Scripts/run-webkit-tests:
1336
1337 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1338
1339         Reviewed by Lars.
1340
1341         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1342
1343         * DumpRenderTree/qt/DumpRenderTree.cpp:
1344
1345 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1346
1347         Reviewed by Lars.
1348
1349         Reworked the QWebSettings API.
1350         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1351
1352         * DumpRenderTree/qt/DumpRenderTree.cpp:
1353
1354 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1355
1356         Reviewed by Lars.
1357
1358         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1359
1360         * DumpRenderTree/qt/jsobjects.cpp:
1361
1362 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1363
1364         Reviewed by Lars Knoll <lars@trolltech.com>.
1365
1366         Add a QWebPage::frameCreated() signal and fix DRT
1367         
1368         The removal of createFrame in QWebPage broke the re-implementation
1369         in DumpRenderTree. Instead emit a frameCreated() signal and
1370         connect to it in DumpRenderTree.
1371         
1372
1373         * DumpRenderTree/qt/DumpRenderTree.cpp:
1374         (WebCore::WebPage::WebPage):
1375         (WebCore::DumpRenderTree::dump):
1376         (WebCore::DumpRenderTree::connectFrame):
1377         * DumpRenderTree/qt/DumpRenderTree.h:
1378
1379 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1380
1381         Reviewed by Lars Knoll <lars@trolltech.com>.
1382
1383         Moved all the event handlers from QWebFrame into QWebPage.
1384         
1385         This cleans up the public API and allows us to remove the
1386         HackWebFrame hack in DumpRenderTree.
1387         
1388
1389         * DumpRenderTree/qt/jsobjects.cpp:
1390         (EventSender::mouseDown):
1391         (EventSender::mouseUp):
1392         (EventSender::mouseMoveTo):
1393
1394 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1395
1396         Reviewed by Mark.
1397
1398         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1399         to prevent the default implementation from popping up messageboxes.
1400
1401         * DumpRenderTree/qt/DumpRenderTree.cpp:
1402         (WebCore::WebPage::javaScriptConfirm):
1403         (WebCore::WebPage::javaScriptPrompt):
1404
1405 2007-11-06  Eric Seidel  <eric@webkit.org>
1406
1407         * Scripts/build-testkjs: build fix... too many $$
1408
1409 2007-11-06  Eric Seidel  <eric@webkit.org>
1410
1411         Reviewed by Mark Rowe.
1412
1413         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1414
1415 2007-11-05  Adam Roben  <aroben@apple.com>
1416
1417         Add support on Windows for WEBKIT_TESTFONTS
1418
1419         This environment variable lets you specify where the fonts to be used
1420         by DumpRenderTree reside. The Qt port is already using this, so I'm
1421         just following their lead.
1422
1423         Reviewed by Darin.
1424
1425         * DumpRenderTree/win/DumpRenderTree.cpp:
1426         (exePath): Refactored code out of initialize().
1427         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1428         DumpRenderTree.resources.
1429         (initialize): Use the new fontsPath function.
1430         (main): Use the new exePath function.
1431         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1432         variable to DRT, like Qt does.
1433
1434 2007-11-05  Mark Rowe  <mrowe@apple.com>
1435
1436         Rubber-stamped by Alp Toker.
1437
1438         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1439
1440         * GtkLauncher/main.cpp:
1441         (goToURLBarText):
1442         (main):
1443
1444 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1445
1446         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1447         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1448
1449         Reviewed by Timothy.
1450
1451         Restrict the range of nightly builds used by the bisect-builds script
1452         based on the version of Safari and the version of Mac OS X being used.
1453
1454         Mac OS X 10.4: Safari 2.0: r11976 or newer
1455         Mac OS X 10.4: Safari 3.0: r19992 or newer
1456
1457         Mac OS X 10.5: Safari 2.0: r19594 or newer
1458         Mac OS X 10.5: Safari 3.0: r25124 or newer
1459
1460         * Scripts/bisect-builds:
1461         (findMacOSXVersion): Added.
1462         (makeNightlyList): Added argument to provide version of Mac OS X.
1463         Restrict range of nightly builds based on Safari and Mac OS X versions.
1464
1465 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1466
1467         Reviewed by Maciej.
1468
1469         - This patch involves several changes, all of them were noticed that
1470         they were needed by the work being done in WebKit to get Drosera and
1471         WebKit working together on Windows.
1472         - The changes are:
1473         1) Added a debugger console for output messages.
1474         2) Drosera now listens for the WebKit server (before, the server would
1475         have to be running before Drosera was started.)
1476         3) Fixed a bug where the WebView started out as 0x0 pixels.
1477         4) Fixed a bug when there is no scope.
1478         5) Added the HTML, JS, and CSS to the project file to make them easy to
1479         find.
1480         6) Made the ServerConnection functions virtual.
1481
1482         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1483         for the WebKit server.
1484         (DebuggerClient::DebuggerClient):
1485         (DebuggerClient::~DebuggerClient):
1486         (DebuggerClient::didFinishLoadForFrame):
1487         (DebuggerClient::serverConnected):
1488         (DebuggerClient::attemptToCreateServerConnection):
1489         * Drosera/win/DebuggerClient.h: Ditto.
1490         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1491         scope.
1492         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1493         (DebuggerDocument::platformValueForScopeVariableNamed):
1494         * Drosera/win/Drosera.cpp:
1495         (_tWinMain): Added a console in debug for output messages.
1496         (Drosera::Drosera): Listen for server.
1497         (Drosera::initUI): The server now Initializes COM.
1498         (Drosera::serverConnected): Part of the listening for the server.
1499         (Drosera::attemptToCreateServerConnection): Ditto.
1500         * Drosera/win/Drosera.h: New interface for listening for the server.
1501         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1502         files to the VS project.
1503         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1504         connection.
1505         (ServerConnection::ServerConnection):
1506         (ServerConnection::attemptToCreateServerConnection):
1507         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1508         methods.
1509         (ServerConnection::serverConnected):
1510
1511 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1512
1513         Reviewed by Maciej.
1514
1515         http://bugs.webkit.org/show_bug.cgi?id=15832
1516         fast/dom/gc-10.html crashes when run alone
1517
1518         Check for !done before using objects that can be already deallocated.
1519
1520         * DumpRenderTree/mac/EditingDelegate.mm:
1521         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1522         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1523         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1524         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1525         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1526         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1527         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1528         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1529         (-[EditingDelegate webViewDidBeginEditing:]):
1530         (-[EditingDelegate webViewDidChange:]):
1531         (-[EditingDelegate webViewDidEndEditing:]):
1532         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1533         (-[EditingDelegate webViewDidChangeSelection:]):
1534         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1535         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1536         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1537         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1538         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1539         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1540         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1541         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1542         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1543         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1544         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1545         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1546         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1547         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1548         (-[FrameLoadDelegate webView:willCloseFrame:]):
1549         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1550         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1551         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1552         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1553         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1554         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1555         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1556         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1557         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1558
1559 2007-11-04  Mark Rowe  <mrowe@apple.com>
1560
1561         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1562         warnings that would otherwise be suppressed due to it being a system header.
1563
1564         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1565
1566 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1567
1568         Rubber stamped by Adam.
1569         
1570         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1571
1572         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1573
1574 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1575
1576         Sort files(...); sections of Xcode project files.
1577
1578         Rubber-stamped by Darin.
1579
1580         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1581         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1582         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1583         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1584
1585 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1586
1587         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1588
1589         Reviewed by Darin.
1590
1591         * Scripts/sort-Xcode-project-file: Added.
1592
1593 2007-11-02  Darin Adler  <darin@apple.com>
1594
1595         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1596
1597 2007-11-02  Darin Adler  <darin@apple.com>
1598
1599         Reviewed by Maciej.
1600
1601         * Scripts/run-sunspider: Pass the "--base" option through.
1602
1603         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1604         the real script do that. Default configuration to Release to match run-sunspider
1605         so we don't end up building Debug just to compare results.
1606
1607 2007-11-01  Adam Roben  <aroben@apple.com>
1608
1609         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1610
1611         Reviewed by Sam.
1612
1613         * Scripts/commit-log-editor: Show all the directories beneath the
1614         source root, instead of just the last one.
1615
1616 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1617
1618         Reviewed by Adam Roben.
1619
1620         Print out an error message when the Windows build fails
1621         and provide guidance on how to find out what went wrong.
1622
1623         * Scripts/build-webkit:
1624         * Scripts/webkitdirs.pm:
1625
1626 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1627
1628         Rubber-stamped by Adam Roben.
1629
1630         Rolled out r27326 - debug CRT seems to cause no problems after all.
1631
1632         * DumpRenderTree/win/DumpRenderTree.vcproj:
1633
1634 2007-10-31  Adam Roben  <aroben@apple.com>
1635
1636         Switch the Debug configuration to using the non-debug CRT
1637
1638         This matches WebKit.
1639
1640         Reviewed by Steve.
1641
1642         * DumpRenderTree/win/DumpRenderTree.vcproj:
1643
1644 2007-10-31  Antti Koivisto  <antti@apple.com>
1645
1646         Reviewed by bdash.
1647         
1648         Disable media tests when doing leak checking on Tiger.
1649         They crash in QuickTime (rdar://problem/5537157).
1650
1651         * Scripts/run-webkit-tests:
1652
1653 2007-10-29  Antti Koivisto  <antti@apple.com>
1654
1655         Reviewed by Maciej.
1656         
1657         Build media support by default on OSX only.
1658
1659         * Scripts/build-webkit:
1660
1661 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1662
1663         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1664         get caught by the pre-commit hooks.
1665
1666 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1667
1668         Reviewed by Adam.
1669
1670         - This is a collection of relatively unrelated changes and cleanups
1671         to Drosera to prepare it for interacting with WebKit.  A lot of these
1672         changes are just correcting mistakes, for example removing included
1673         headers that are no longer needed.
1674
1675         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1676         this will be needed by the DebuggerClient.
1677         (DebuggerDocument::server):
1678         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1679         * Drosera/win/DebuggerClient.cpp: 
1680         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1681         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1682         (DebuggerClient::createWebViewWithRequest): Added comment about its
1683         purpose. 
1684         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1685         declarations.
1686         (DebuggerClient::webViewLoaded): Moved.
1687         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1688         file, since this was the only place it was used.
1689         (cfStringToBSTR):
1690         * Drosera/win/Drosera.h: Cleaned up the includes.
1691         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1692         * Drosera/win/HelperFunctions.h: Removed.
1693
1694 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1695
1696         Reviewed by Adam.
1697
1698         - Small cleanup in the ServerConnection class.
1699
1700         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1701         and added an include.
1702         (ServerConnection::currentFrame):
1703         (ServerConnection::getCallerFrame):
1704         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1705         made a pointer into a COMPtr, and cleaned up the includes.
1706
1707 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1708
1709         Reviewed by John Sullivan.
1710         
1711         - Place the Localizable.strings file in mac or win directories
1712           if that location exists.
1713         - Also look for UI_STRING in .c files.
1714
1715         * Scripts/extract-localizable-strings:
1716
1717 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1718
1719         Reviewed by Adam.
1720
1721         - Set the eol-style to native and made all the line endings the same
1722         so that I avoid messy diffs that show eol changes.
1723
1724         * Drosera/win/ServerConnection.cpp:
1725         (ServerConnection::didParseSource):
1726         (ServerConnection::didEnterCallFrame):
1727         (ServerConnection::willExecuteStatement):
1728         (ServerConnection::willLeaveCallFrame):
1729         (ServerConnection::exceptionWasRaised):
1730
1731 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1732
1733         Reviewed by Adam.
1734
1735         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1736         functionality that could not have existed previously without the new
1737         interfaces.
1738         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1739         from a BSTR to a JSValueRef.
1740         (DebuggerDocument::platformEvaluateScript): Implemented.
1741         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1742         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1743         Implemented.
1744         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1745         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1746         * Drosera/win/ServerConnection.cpp: Added a helper function.
1747         (ServerConnection::getCallerFrame):
1748         * Drosera/win/ServerConnection.h: Added a helper function.
1749
1750 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1751
1752         updated reviewers for my previous changelog.
1753
1754 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1755         Reviewed by Maciej and Adam and Geoff.
1756
1757         - Minor mac-side improvements including moving a function to a more
1758         appropriate location, fixing a warning, and correctly checking
1759         exceptions.
1760
1761         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1762         (DebuggerDocument::willExecuteStatement):
1763         (DebuggerDocument::didEnterCallFrame):
1764         (DebuggerDocument::willLeaveCallFrame):
1765         (DebuggerDocument::windowScriptObjectAvailable):
1766         (DebuggerDocument::callFunctionOnObject):
1767         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1768         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1769         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1770         because it doesn't require the ServerConnection at all.
1771         (NSStringCreateWithJSStringRef): Made an argument const.
1772         (JSValueRefCreateWithNSString): Made an argument const.
1773         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1774         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1775         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1776         * Drosera/mac/ServerConnection.mm: Ditto.
1777         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1778
1779 2007-10-29  Sam Weinig  <sam@webkit.org>
1780
1781         Reviewed by Adam Roben.
1782
1783         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1784
1785         * DumpRenderTree/LayoutTestController.cpp:
1786         (LayoutTestController::LayoutTestController):
1787         (getGlobalFlagCallback):
1788         (setGlobalFlagCallback):
1789         (LayoutTestController::getJSClass):
1790         (LayoutTestController::staticValues):
1791         * DumpRenderTree/LayoutTestController.h:
1792         (LayoutTestController::globalFlag):
1793         (LayoutTestController::setGlobalFlag):
1794
1795 2007-10-29  Darin Adler  <darin@apple.com>
1796
1797         Reviewed by Maciej.
1798
1799         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1800         resolution instead of its default.
1801
1802 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1803
1804         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1805
1806         Reviewed by Mark Rowe.
1807
1808         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1809         was successfully resolved, but this would not show any status because the change had
1810         already been cached in the index using "git add".  The solution is to add an optional
1811         second argument to showStatus() which adds the "--cached" switch to the command.
1812
1813         * Scripts/resolve-ChangeLogs:
1814         (showStatus):
1815
1816 2007-10-28  Eric Seidel  <eric@webkit.org>
1817
1818         Reviewed by Maciej and Geoff, in unison.
1819
1820         * Scripts/run-webkit-tests: remove broken --svg option
1821
1822 2007-10-28  Darin Adler  <darin@apple.com>
1823
1824         Reviewed by Adam.
1825
1826         * Scripts/run-sunspider: Default to "Release" configuration rather than
1827         defaulting to the last configuration used as other scripts do. This can
1828         still be overriden on the command line with "--debug" if there's some
1829         reason to do so. Also fix a typo.
1830
1831         * Scripts/sunspider-compare-results: Fix a typo.
1832
1833 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1834
1835         Reviewed by Adam.
1836
1837         - Implemented the WebScriptDebugListener functions now that the
1838         WebScriptDebugServer exists
1839
1840         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1841         functions.
1842         (ServerConnection::currentFrame):
1843         (ServerConnection::didLoadMainResourceForDataSource):
1844         (ServerConnection::didParseSource):
1845         (ServerConnection::failedToParseSource):
1846         (ServerConnection::didEnterCallFrame):
1847         (ServerConnection::willExecuteStatement):
1848         (ServerConnection::willLeaveCallFrame):
1849         (ServerConnection::exceptionWasRaised):
1850         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1851         members arguments list.
1852
1853 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1854
1855         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1856         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1857
1858         Reviewed by Darin.
1859
1860         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1861         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1862         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1863         file.  Note that it may also be used as a stand-alone script.
1864
1865         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1866         * Scripts/resolve-ChangeLogs: Added.
1867         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1868
1869 2007-10-26  Mark Rowe  <mrowe@apple.com>
1870
1871         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1872         to the Qt port on the assumption that it was an implementation of the cross-platform
1873         LayoutTestController class.  It is not, so it did not need to be changed.
1874
1875         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1876
1877 2007-10-25  Mark Rowe  <mrowe@apple.com>
1878
1879         Reviewed by Maciej.
1880
1881         Fix builds with code coverage enabled.
1882
1883         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1884
1885 2007-10-25  Darin Adler  <darin@apple.com>
1886
1887         Reviewed by Mark Rowe.
1888
1889         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1890         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1891
1892 2007-10-25  Stephanie  <slewis@apple.com>
1893
1894         build Fix
1895
1896         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1897
1898 2007-10-25  Stephanie  <slewis@apple.com>
1899
1900         Reviewed by Mark Rowe, Adam Roben.
1901
1902         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1903
1904         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1905
1906 2007-10-25  Alice Liu  <alice.liu@apple.com>
1907
1908         Reviewed by Adam.
1909
1910         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1911
1912         Moving destructor into platform-specific files
1913         * DumpRenderTree/LayoutTestController.cpp:
1914         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1915         (LayoutTestController::~LayoutTestController):
1916         * DumpRenderTree/qt/jsobjects.cpp:
1917         (LayoutTestController::~LayoutTestController):
1918
1919         LayoutTestController wasn't being destroyed
1920         * DumpRenderTree/win/DumpRenderTree.cpp:
1921         (runTest):
1922
1923         Added declspec
1924         * DumpRenderTree/win/EditingDelegate.h:
1925
1926         Reset certain values on the webview (or related delegate) that might 
1927         have changed while running a test
1928         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1929         (LayoutTestController::~LayoutTestController):
1930
1931 2007-10-25  Adam Roben  <aroben@apple.com>
1932
1933         Make sunspider-compare-results work with relative paths
1934
1935         Reviewed by Sam.
1936
1937         * Scripts/sunspider-compare-results: Convert arguments to absolute
1938         paths before we chdir.
1939
1940 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1941
1942         Reviewed by Sam.
1943
1944         - Implemented server calls now the WebScriptDebugServer exists.
1945         - Also removed no longer needed call to initialize CG.
1946
1947         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1948         automatically now.
1949         (_tWinMain):
1950         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1951         (ServerConnection::ServerConnection):
1952         (ServerConnection::~ServerConnection):
1953         (ServerConnection::pause):
1954         (ServerConnection::resume):
1955         (ServerConnection::stepInto):
1956         (ServerConnection::applicationTerminating):
1957         (ServerConnection::serverConnectionDidDie):
1958         * Drosera/win/ServerConnection.h: Now uses the COM class.
1959
1960 2007-10-24  George Staikos  <staikos@kde.org>
1961
1962         Unbreak Qt build.
1963
1964         * Scripts/build-webkit:
1965
1966 2007-10-24  Adam Roben  <aroben@apple.com>
1967
1968         Remove now-unnecessary call to InitializeCoreGraphics
1969
1970         WebKit takes care of this now.
1971
1972         Reviewed by Ada.
1973
1974         * DumpRenderTree/win/DumpRenderTree.cpp:
1975         (initialize):
1976
1977 2007-10-24  Adam Roben  <aroben@apple.com>
1978
1979         Use WebTextRenderer in DRT
1980
1981         Reviewed by Ada.
1982
1983         * DumpRenderTree/win/DumpRenderTree.cpp:
1984         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1985
1986 2007-10-24  Sven Herzberg  <sven@imendio.com>
1987
1988         Reviewed by Mark Rowe.
1989
1990         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1991         Bug 15614: [GTK] qmake based backends don't build on OS X
1992
1993         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1994         GTK backend on a Mac
1995         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1996         isDarwin() to make it reusable in other places (like the workaround-
1997         for-prebuilt-qmake in build-webkit)
1998
1999 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2000
2001         Refurbish update-webkit script.
2002
2003         Reviewed by Adam.
2004
2005         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2006         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2007         multi-argument version of system() for flexibility and security.  Check for existence
2008         of Internal directory using -d test instead of -x.
2009
2010 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2011
2012         Minor clean-up of prepare-ChangeLog script.
2013
2014         Reviewed by Adam.
2015
2016         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2017         of a string.  Use multi-argument versions of open() and system() for flexibility and
2018         security.
2019
2020 2007-10-24  Alice Liu  <alice.liu@apple.com>
2021
2022         Reviewed by Oliver.
2023
2024         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2025
2026         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2027         replay the saved events when we're still processing the mousedown that starts the drag
2028         * DumpRenderTree/win/EventSender.cpp:
2029         (doMouseMove):
2030         * DumpRenderTree/win/UIDelegate.cpp:
2031         (UIDelegate::doDragDrop):
2032
2033 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2034
2035         Reviewed by Sam, Steve and Darin.
2036
2037         - Stubbed out the WebScriptDebugListener functionality in the Server
2038         Connection class to prepare it for receiving those callbacks.
2039         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2040         and the ServerConnection to not need to be initialized with a server
2041         name, since that is not the way we connect to the WebKit server. 
2042
2043         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2044         no exception.  Now it only loggs when there is an exception
2045         (DebuggerDocument::willExecuteStatement):
2046         (DebuggerDocument::didEnterCallFrame):
2047         (DebuggerDocument::willLeaveCallFrame):
2048         (DebuggerDocument::windowScriptObjectAvailable):
2049         (DebuggerDocument::callFunctionOnObject):
2050         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2051         to be instantiated with a server's name.
2052         (DebuggerClient::DebuggerClient):
2053         (DebuggerClient::didFinishLoadForFrame):
2054         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2055         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2056         a server name.
2057         (Drosera::init):
2058         (Drosera::initServer):
2059         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2060         instantiated with a server's name.
2061         * Drosera/win/ServerConnection.cpp: 
2062         (ServerConnection::ServerConnection): No longer needs a server name
2063         (ServerConnection::~ServerConnection): Only release the global context
2064         if there is one.
2065         (ServerConnection::serverConnectionDidDie): Stub for
2066         IWebScriptDebugListener
2067         (ServerConnection::QueryInterface): ditto
2068         (ServerConnection::AddRef): ditto
2069         (ServerConnection::Release): ditto
2070         (ServerConnection::didLoadMainResourceForDataSource): ditto
2071         (ServerConnection::didParseSource): ditto
2072         (ServerConnection::failedToParseSource): ditto
2073         (ServerConnection::didEnterCallFrame): ditto
2074         (ServerConnection::willExecuteStatement): ditto
2075         (ServerConnection::willLeaveCallFrame): ditto
2076         (ServerConnection::exceptionWasRaised): ditto
2077         * Drosera/win/ServerConnection.h: Stubbed out the
2078         IWebScriptDebugListener functions, and this class no longer needs to be
2079         instantiated with a server name.
2080
2081 2007-10-24  Lars Knoll  <lars@trolltech.com>
2082
2083         Reviewed by Simon.
2084
2085         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2086
2087         * DumpRenderTree/qt/jsobjects.h:
2088
2089 2007-10-24  Lars Knoll  <lars@trolltech.com>
2090
2091         Reviewed by Simon.
2092
2093         add another command.
2094
2095         * DumpRenderTree/qt/jsobjects.cpp:
2096         (TextInputController::doCommand):
2097
2098 2007-10-24  Lars Knoll  <lars@trolltech.com>
2099
2100         Reviewed by Simon.
2101
2102         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2103
2104         * DumpRenderTree/qt/jsobjects.cpp:
2105         (EventSender::keyDown):
2106         * DumpRenderTree/qt/jsobjects.h:
2107
2108 2007-10-24  Lars Knoll  <lars@trolltech.com>
2109
2110         Reviewed by Simon.
2111
2112         implement eventSender.keyDown().
2113
2114         * DumpRenderTree/qt/jsobjects.cpp:
2115         (EventSender::keyDown):
2116
2117 2007-10-24  Lars Knoll  <lars@trolltech.com>
2118
2119         Reviewed by Simon.
2120
2121         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2122
2123         * DumpRenderTree/qt/DumpRenderTree.cpp:
2124         (WebCore::DumpRenderTree::DumpRenderTree):
2125         (WebCore::DumpRenderTree::initJSObjects):
2126         * DumpRenderTree/qt/jsobjects.cpp:
2127         (TextInputController::doCommand):
2128
2129 2007-10-24  Lars Knoll  <lars@trolltech.com>
2130
2131         Reviewed by Simon.
2132
2133         first bit of implementation for the textinputcontroller.
2134
2135         * DumpRenderTree/qt/DumpRenderTree.cpp:
2136         (WebCore::DumpRenderTree::DumpRenderTree):
2137         * DumpRenderTree/qt/DumpRenderTree.h:
2138         * DumpRenderTree/qt/jsobjects.cpp:
2139         (TextInputController::TextInputController):
2140         (TextInputController::doCommand):
2141         * DumpRenderTree/qt/jsobjects.h:
2142
2143 2007-10-24  Lars Knoll  <lars@trolltech.com>
2144
2145         Reviewed by Simon.
2146
2147         make the man webpage believe it has focus, so the editing tests work correctly.
2148
2149         * DumpRenderTree/qt/DumpRenderTree.cpp:
2150         (WebCore::DumpRenderTree::DumpRenderTree):
2151
2152 2007-10-24  Lars Knoll  <lars@trolltech.com>
2153
2154         Reviewed by Simon.
2155
2156         implement layoutTestController.dumpEditingCallbacks() correctly.
2157
2158         * DumpRenderTree/qt/DumpRenderTree.cpp:
2159         (WebCore::DumpRenderTree::DumpRenderTree):
2160         * DumpRenderTree/qt/jsobjects.cpp:
2161         (LayoutTestController::reset):
2162         (LayoutTestController::dumpEditingCallbacks):
2163
2164 2007-10-24  Lars Knoll  <lars@trolltech.com>
2165
2166         Reviewed by Simon.
2167
2168         Implement support for testing editing.
2169
2170         * DumpRenderTree/qt/DumpRenderTree.cpp:
2171         (WebCore::DumpRenderTree::DumpRenderTree):
2172
2173 2007-10-23  Sam Weinig  <sam@webkit.org>
2174
2175         Check for null BSTR that can be passed to the UIDelegate methods
2176         from javascript null and undefined.  Fixes a failing test case on
2177         Windows (fast/dom/Window/alert-undefined.html)
2178
2179         Reviewed by Eric Seidel.
2180
2181         * DumpRenderTree/win/UIDelegate.cpp:
2182         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2183         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2184         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2185         (UIDelegate::webViewAddMessageToConsole):
2186
2187 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2188
2189         Reviewed by Darin.
2190         
2191         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2192
2193         * Scripts/build-testkjs:
2194
2195 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2196
2197         Reviewed by Darin.
2198
2199         - add wrapper that finds the right copy of testkjs
2200         
2201         * Scripts/sunspider-compare-results: Added.
2202
2203 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2204
2205         Reviewed by Sam.
2206
2207         - After talking with Steve I now see that the WebKit server must be
2208         running for DCOM to create the distributed objects, which makes sense
2209         and currently WebKit only allows one instance to be running at a time
2210         which avoids accidentally connecting to the wrong server
2211         - In light of this I have removed the code for the attach box and
2212         NotificationServer and known server names, since they are all extranious
2213         now.
2214
2215         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2216         names.
2217         (_tWinMain): Uses init instead of initUI.
2218         (droseraWndProc): No longer creats an attach dialog box.
2219         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2220         it's not manditory to call init before doing COM stuff.
2221         (Drosera::init): calls initUI and will call attach when the
2222         functionality exists. 
2223         (Drosera::initUI): Has changed very little.
2224         (Drosera::attach): Changed the signature to reflect that we no longer
2225         need the dictionary of known server names.
2226         * Drosera/win/Drosera.h: Removed notification classes and known server
2227         names.  Also renamed and moved some functions.
2228         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2229         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2230         headers to the resources folder. 
2231         * Drosera/win/resource.h: Removed the Attach box.
2232
2233 2007-10-22  Adam Roben  <aroben@apple.com>
2234
2235         Windows build fix
2236
2237         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2238
2239 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2240
2241         - Removed a leak that was fixed.
2242
2243         * Scripts/run-webkit-tests:
2244
2245 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2246
2247         Reviewed by Darin.
2248
2249         - Changed the Client so that the DebuggerDocument now own the
2250         ServerConnection.  This simplifies ownership and cleanup. 
2251
2252         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2253         ServerConnection.
2254         (DebuggerClient::initWithServerName):
2255         (DebuggerClient::didFinishLoadForFrame):
2256         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2257         ServerConnection.
2258         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2259         until after we have a server which we are attached to.
2260         (Drosera::initUI):
2261         (Drosera::attach):
2262         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2263         out previously.
2264
2265 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2266
2267         Reviewed by Nikolas.
2268
2269         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2270
2271         * Scripts/run-javascriptcore-tests:
2272
2273 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2274
2275         Reviewed by Nikolas.
2276
2277         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2278
2279         * Scripts/build-drosera:
2280         * Scripts/build-dumprendertree:
2281         * Scripts/build-testkjs:
2282         * Scripts/build-webkit:
2283         * Scripts/run-javascriptcore-tests:
2284         * Scripts/run-sunspider:
2285         * Scripts/run-webkit-tests:
2286         * Scripts/webkitdirs.pm:
2287
2288 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2289
2290         Reviewed by Mark Rowe.
2291         
2292         Fix for local database support after r26879
2293         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2294
2295         * Scripts/build-webkit:
2296
2297 2007-10-22  Holger Freyther  <zecke@selfish.org>
2298
2299         Reviewed by Simon Hausmann <hausmann@kde.org>.
2300
2301         - Do not build testkjs as an application bundle. This is
2302         needed for run-javascriptcore-tests on OSX.
2303         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2304         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2305         as we do not have -rpath on OSX.
2306
2307         * DumpRenderTree/qt/DumpRenderTree.pro:
2308         * Scripts/run-webkit-tests:
2309
2310 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2311
2312         Reviewed by aroben.
2313
2314         Fix support for Signed-off-by detection in prepare-ChangeLog
2315         --git-commit. The Signed-off-by tag does not appear in the header
2316         but usually at the end.
2317
2318         * Scripts/prepare-ChangeLog:
2319
2320 2007-10-21  Mark Rowe  <mrowe@apple.com>
2321
2322         Reviewed by Eric.
2323
2324         Fix run-javascriptcore-tests for Gtk.
2325
2326         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2327
2328 2007-10-20  Eric Seidel  <eric@webkit.org>
2329
2330         Reviewed by aroben.
2331
2332         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2333
2334 2007-10-20  Eric Seidel  <eric@webkit.org>
2335
2336         Reviewed by darin.
2337         
2338         Add improved argument handling to run-sunspider, including
2339         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2340         Also re-factor code into subroutines
2341
2342         * Scripts/build-dumprendertree: removed bogus comments
2343         * Scripts/build-testkjs: Added.
2344         * Scripts/run-javascriptcore-tests: use build-testkjs
2345         * Scripts/run-sunspider: improved argument handling, abstraction
2346         * Scripts/run-webkit-tests: improved abstraction
2347
2348 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2349
2350         Not reviewed, Windows build fix.
2351
2352         * DumpRenderTree/win/EventSender.cpp:
2353         (keyDownCallback):
2354
2355 2007-10-20  Darin Adler  <darin@apple.com>
2356
2357         Reviewed by Tim Hatcher.
2358
2359         - http://bugs.webkit.org/show_bug.cgi?id=15544
2360           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2361           not rely on Apple-specific key codes
2362
2363         * DumpRenderTree/mac/EventSendingController.mm:
2364         (-[EventSendingController keyDown:withModifiers:]):
2365         Added named key "rightArrow". Later we could have a whole table of these.
2366         Also tweaked modifiers code a little.
2367
2368         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2369
2370 2007-10-19  Darin Adler  <darin@apple.com>
2371
2372         Reviewed by Eric.
2373
2374         - http://bugs.webkit.org/show_bug.cgi?id=15566
2375           possible fix for leak seen in DumpRenderTree
2376
2377         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2378         Delete the item if it's not put on the queue, since the caller has
2379         no way of knowing that. Would be better to have the parameter type
2380         be auto_ptr to express the fact that we take ownership.
2381
2382         - unrelated change
2383
2384         * Drosera/mac/main.m: Add missing include.
2385
2386 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2387
2388         Reviewed by Adam.
2389
2390         - This change should be identical but for some reason was not working
2391         on my machine.
2392
2393         * Scripts/prepare-ChangeLog:
2394
2395 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2396
2397         Reviewed by Oliver and Tim.
2398
2399         - Made use of RetainPtr to avoid retain and release issues and moved the
2400         log function to DebuggerDocumentPlatform, which seems to be a more
2401         logical place for it to live.
2402         - Also moved knownServers from the ServerConnection to
2403         DebuggerApplication to match the Windows code and because it makes sense
2404         that a connection knows its own server but not all of them.
2405
2406         * Drosera/mac/DebuggerClient.h: Moved the log function to
2407           DebuggerDocumentPlatform.
2408         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2409           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2410           call for the server name up from the ServerConnection class.
2411         (-[DebuggerClient dealloc]):
2412         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2413           for the server name up from the ServerConnection.
2414         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2415         (DebuggerDocument::platformPause):
2416         (DebuggerDocument::platformResume):
2417         (DebuggerDocument::platformStepInto):
2418         (DebuggerDocument::platformEvaluateScript):
2419         (DebuggerDocument::getPlatformCurrentFunctionStack):
2420         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2421         (DebuggerDocument::platformValueForScopeVariableNamed):
2422         (DebuggerDocument::platformLog): Log directly from here. No need to call
2423           DebuggerClient.
2424         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2425           way I see it, a ServerConnection should only know about its connection
2426           and the group of all possible servers should be kept by the
2427           application.
2428         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2429           currentServerName, it makes sense that the connection should know that
2430           name.
2431         (-[ServerConnection currentServerName]):
2432
2433 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2434
2435         Reviewed by Adam.
2436
2437         - Integrated changes from mac drosera.  Recently I've encapsulated
2438         out the server connection object from the rest of Drosera because
2439         it is very platform dependent right now and RPC is not implemented on
2440         windows.  This functionality, of communicating with the WebKit server
2441         is the next area I will be focusing on in Windows.
2442
2443         - Other changes and cleanup were made to organize the code and add notes
2444         on which parts still need work.  Also some mac code is added and
2445         commented out, to act as pseudocode for the logic of those parts.
2446
2447         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2448           pointer.
2449         * Drosera/config.h: Added whitespace.
2450         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2451           these files got moved into Drosera.h/cpp
2452         * Drosera/win/DebuggerApplication.h: Removed.
2453         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2454           happened here to better match the logic flow of the same code on the 
2455           mac side and to use the new ServerConnection class.
2456         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2457         (DebuggerClient::initWithServerName): Initializer that will set up the
2458           class to use a ServerConnection object.  This was necessary so I could
2459           create a DebuggerClient without having to initilaize it at
2460           construction.
2461         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2462           will be the UIDelegate and FrameLoadDelegate.
2463         (DebuggerClient::AddRef): For IUnknown.
2464         (DebuggerClient::Release): For IUnknown.
2465         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2466           this still needs to set the global context of the server, but
2467           IWebFrame does not have an accessor for the global context yet. 
2468         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2469           this is a pass through for the same function in the document.
2470         (DebuggerClient::didReceiveTitle): Unimplemented part of
2471           FrameLoadDelegate this would change the title of the window.
2472         (DebuggerClient::createWebViewWithRequest): Part of the
2473           FrameLoadDelegate.  This is about new windows via Window.open() and
2474           how their delegates are set.
2475         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2476           UIDelegate.  Just a debug function for printing messages.
2477         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2478           because the Client should be the UIDelegate and FrameLoadDelegate
2479           to match the delegates on mac.
2480         (DebuggerClient::webViewLoaded): Added accessor method.
2481         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2482           forgotten to add this file before.  This is where the platform
2483           dependent versions of the Documents functions live. Most of these are
2484           unimplemented because some piece of functionality does not exist on
2485           Windows yet.
2486         (DebuggerDocument::platformPause):
2487         (DebuggerDocument::platformResume):
2488         (DebuggerDocument::platformStepInto):
2489         (DebuggerDocument::platformEvaluateScript):
2490         (DebuggerDocument::getPlatformCurrentFunctionStack):
2491         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2492         (DebuggerDocument::platformValueForScopeVariableNamed):
2493         (DebuggerDocument::platformLog):
2494         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2495           responsibilities becaue they belong in the Client. Also I laid the
2496           groundwork for attaching Drosera to a WebKit process
2497         (attachWndProc): Now if a server is selected the Client becomes it's
2498           delegate.
2499         (Drosera::Drosera): Added the construction of the Client and dictionary
2500           of server names. 
2501         (Drosera::initUI): This is no longer the delegates, the Client is.
2502         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2503           state. 
2504         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2505           notification registration when it's possible to implement.
2506         (Drosera::serverLoaded): Ditto
2507         (Drosera::serverUnloaded): Ditto
2508         (Drosera::attach): Attach Drosera to the WebKit server.
2509         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2510         (Drosera::getInst): 
2511         (Drosera::setInst):
2512         (Drosera::knownServers):
2513         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2514           and added the ServerConnection.
2515         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2516         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2517           Most of the functions are completely unimlemented because they cannot
2518           connect with the WebKit server, because one does not exist on Windows
2519           yet.
2520         (ServerConnection::initWithServerName): 
2521         (ServerConnection::~ServerConnection):
2522         (ServerConnection::setGlobalContext):
2523         (ServerConnection::pause):
2524         (ServerConnection::resume):
2525         (ServerConnection::stepInto):
2526         (ServerConnection::switchToServerNamed):
2527         (ServerConnection::applicationTerminating):
2528         (ServerConnection::serverConnectionDidDie):
2529         (ServerConnection::currentFrame):
2530         * Drosera/win/ServerConnection.h: Added. Ditto.
2531         (ServerConnection::ServerConnection):
2532
2533 2007-10-19  Alice Liu  <alice.liu@apple.com>
2534
2535         Reviewed by Darin.
2536
2537         Fix for these broken layout tests on Windows:
2538         
2539         fast/forms/focus-selection-input.html
2540         fast/forms/focus-selection-textarea.html
2541         fast/forms/select-accesskey.html
2542         
2543         * DumpRenderTree/win/EventSender.cpp:
2544         (keyDownCallback):
2545         correct the VK code for alt key.
2546         
2547 2007-10-19  Eric Seidel  <eric@webkit.org>
2548
2549         Reviewed by Mark Rowe.
2550         
2551         Make the GtkLauncher code slightly more readable.
2552
2553         * GtkLauncher/main.cpp:
2554         (setupMainMenu): Added.
2555         (setupMainWindowUI): Added.
2556         (main):
2557
2558 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2559
2560         Rubber stamped by Adam.
2561         
2562         - don't delay-load WebKit in DumpRenderTree.
2563
2564         * DumpRenderTree/win/DumpRenderTree.vcproj:
2565
2566 2007-10-18  Dan Bernstein  <mitz@apple.com>
2567
2568         Reviewed by Adam Roben.
2569
2570         - fix <rdar://problem/5313523>
2571         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2572
2573         * DumpRenderTree/mac/DumpRenderTree.mm:
2574         (dump): Changed to use _responseMIMEType.
2575
2576 2007-10-17  Adam Roben  <aroben@apple.com>
2577
2578         Make it possible to have Windows-specific tests and results
2579
2580         When searching for tests to run and the Skipped file, we will only
2581         look in platform/win and the cross-platform directory. When looking
2582         for expected results, we will look in platform/win, then
2583         platform/mac-leopard, then platform/mac, then finally the
2584         cross-platform directory.
2585
2586         Reviewed by Sam.
2587
2588         * Scripts/run-webkit-tests:
2589         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2590         searching in the cross-platform directory.
2591         (sub buildPlatformHierarchy): Removed some unneeded calls to
2592         dirname/basename.
2593
2594 2007-10-17  Adam Roben  <aroben@apple.com>
2595
2596         Add back the call to register WebKit that we had before WebKitInitializer existed
2597
2598         This is needed to ensure that the right WebKit is used when
2599         instantiating COM objects.
2600
2601         Reviewed by Oliver.
2602
2603         * DumpRenderTree/win/debug_internal.vsprops: Define
2604         DEBUG_WEBKIT_HAS_SUFFIX.
2605         * DumpRenderTree/win/DumpRenderTree.cpp:
2606         (initialize):
2607
2608 2007-10-17  Adam Roben  <aroben@apple.com>
2609
2610         Import File::Basename in webkitdirs since we use it
2611
2612         * Scripts/webkitdirs.pm:
2613
2614 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2615
2616         - Updated the tiger leaks list to make the internal bots green.
2617
2618         * Scripts/run-webkit-tests:
2619
2620 2007-10-17  Adam Roben  <aroben@apple.com>
2621
2622         Build fix for VC++ Express
2623
2624         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2625         and ole32.lib.
2626
2627 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2628
2629         Reviewed by Sam.
2630
2631         - Minor mac improvements based on observations I made while implementing the
2632         Windows code.
2633
2634         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2635         then hand it to the Client who will retain it, it should just be the client who
2636         creates and owns the server.
2637         (-[DebuggerApplication attach:]):
2638         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2639         * Drosera/mac/DebuggerClient.mm: Creates the server.
2640         (-[DebuggerClient initWithServerName:]):
2641         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2642         can instead forward declare what it needs.
2643
2644 2007-10-16  Darin Adler  <darin@apple.com>
2645
2646         Reviewed by Geoff Garen.
2647
2648         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2649         want to turn failing tests into platform-specific test results. Also did a
2650         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2651         would take the type of results into account only some of the time.
2652
2653 2007-10-16  Adam Roben  <aroben@apple.com>
2654
2655         Add a new nightly launcher script for Windows
2656
2657         This new script is for versions of Safari that don't delay-load
2658         WebKit. I had to make FindSafari be able to print out the nightly
2659         launcher script on stdout because Windows shell scripts can't capture
2660         the output from a command into an environment variable.
2661
2662         Reviewed by Steve.
2663
2664         * FindSafari/FindSafari.cpp:
2665         (_tmain): Added /printSafariLauncher option.
2666         * Scripts/run-webkit-nightly.cmd: Added.
2667
2668 2007-10-16  Adam Roben  <aroben@apple.com>
2669
2670         Replace WebKitInitializer with FindSafari
2671
2672         We now rely on setting the PATH environment variable to tell Windows
2673         where to find WebKit and its dependencies (similar to
2674         DYLD_FRAMEWORK_PATH on Mac).
2675
2676         This change also make DumpRenderTree no longer delay-load WebKit.
2677
2678         Reviewed by Sam.
2679
2680         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2681         FindSafari.
2682         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2683         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2684         WebKitInitializer, don't delay-load WebKit.
2685         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2686         * Scripts/run-webkit-tests: Ditto.
2687         * Scripts/webkitdirs.pm:
2688         (sub setPathForRunningWebKitApp): Added.
2689         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2690         * WebKitInitializer/WebKitInitializer.h: Removed.
2691         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2692         * WebKitInitializer/debug.vsprops: Removed.
2693         * WebKitInitializer/debug_internal.vsprops: Removed.
2694         * WebKitInitializer/release.vsprops: Removed.
2695
2696 2007-10-16  Adam Roben  <aroben@apple.com>
2697
2698         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2699
2700         http://bugs.webkit.org/show_bug.cgi?id=15532
2701
2702         FindSafari simply prints the location of an installed Safari.exe on
2703         stdout.
2704
2705         Reviewed by Darin.
2706
2707         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2708         (getStringValue):
2709         (getWebViewCLSID):
2710         (getInstalledWebKitDirectory):
2711         (_tmain):
2712         * FindSafari/FindSafari.vcproj: Added.
2713         * Scripts/webkitdirs.pm:
2714         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2715
2716 2007-10-16  Adam Roben  <aroben@apple.com>
2717
2718         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2719
2720         Reviewed by Kevin McCullough.
2721
2722         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2723         when referring to WebKit.dll.
2724         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2725         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2726         * DumpRenderTree/win/release.vsprops: Ditto.
2727         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2728         never have a _debug suffix on WebKit.dll.
2729         * WebKitInitializer/WebKitInitializer.cpp:
2730         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2731         specified.
2732         * WebKitInitializer/debug_internal.vsprops: Added
2733         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2734
2735 2007-10-16  Darin Adler  <darin@apple.com>
2736
2737         Reviewed by Adele.
2738
2739         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2740         Remove now-unneeded control/alt key hack; the tests have been updated.
2741
2742 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2743
2744         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2745         one of the leaks was fixed between that revision and the bot's previous version of
2746         leopard.
2747
2748         * Scripts/run-webkit-tests:
2749
2750 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2751
2752         Reviewed by Tim.
2753
2754         - I encapsulated out the server connecton functionality because it is a specific part
2755         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2756         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2757         Windows.  So the majority of this patch is moving preexisting functionality.
2758
2759         - Also I removed the prefix header and changed to use config.h because it is more
2760         standard on how we use config.h in windows and it didn't make much sense to keep
2761         the prefix header and the config.h
2762
2763         * Drosera/DebuggerDocument.cpp:
2764         (DebuggerDocument::DebuggerDocument):
2765         * Drosera/DebuggerDocument.h:
2766         * Drosera/config.h:
2767         * Drosera/mac/DebuggerApplication.mm:
2768         (-[DebuggerApplication attach:]):
2769         * Drosera/mac/DebuggerClient.h:
2770         * Drosera/mac/DebuggerClient.mm:
2771         (-[DebuggerClient initWithServerConnection:]):
2772         (-[DebuggerClient dealloc]):
2773         (-[DebuggerClient windowDidLoad]):
2774         (-[DebuggerClient windowWillClose:]):
2775         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2776         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2777         * Drosera/mac/DebuggerDocumentPlatform.mm:
2778         (DebuggerDocument::platformPause):
2779         (DebuggerDocument::platformResume):
2780         (DebuggerDocument::platformStepInto):
2781         (DebuggerDocument::platformEvaluateScript):
2782         (DebuggerDocument::getPlatformCurrentFunctionStack):
2783         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2784         (DebuggerDocument::platformValueForScopeVariableNamed):
2785         (DebuggerDocument::platformLog):
2786         * Drosera/mac/Drosera.pch: Removed.
2787         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2788         * Drosera/mac/ServerConnection.h: Added.
2789         * Drosera/mac/ServerConnection.mm: Added.
2790         (-[ServerConnection initWithServerName:]):
2791         (-[ServerConnection dealloc]):
2792         (-[ServerConnection setGlobalContext:]):
2793         (-[ServerConnection pause]):
2794         (-[ServerConnection resume]):
2795         (-[ServerConnection stepInto]):
2796         (-[ServerConnection switchToServerNamed:]):
2797         (-[ServerConnection applicationTerminating:]):
2798         (-[ServerConnection serverConnectionDidDie:]):
2799         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2800         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2801         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2802         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2803         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2804         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2805         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2806         (-[ServerConnection currentFrame]):
2807         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2808         (-[ServerConnection knownServers]):
2809
2810 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2811
2812         Reviewed by Eric.
2813
2814         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2815           Script to automatically search nightly builds for regressions (bisect-builds)
2816
2817         * Scripts/bisect-builds: Added.
2818
2819 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2820
2821         Reviewed by Darin.
2822
2823         - New JavaScript benchmark
2824         http://bugs.webkit.org/show_bug.cgi?id=15515
2825
2826         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2827         current development or release build of JavaScriptCore.
2828
2829 2007-10-15  Mark Rowe  <mrowe@apple.com>
2830
2831         Reviewed by Sam.
2832
2833         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2834
2835         * Scripts/webkitdirs.pm:
2836         - Change checkArgv to remove the options from @ARGV to prevent
2837         them from interfering with further option processing.
2838         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2839         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2840         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2841         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2842
2843 2007-10-15  Darin Adler  <darin@apple.com>
2844
2845         Reviewed by Sam.
2846
2847         - added logging of window.prompt and window.confirm
2848
2849         * DumpRenderTree/mac/UIDelegate.mm:
2850         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2851         Implement the recommended delegate rather than the deprecated one.
2852         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2853         Added.
2854         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2855         Added.
2856
2857         * DumpRenderTree/win/UIDelegate.h:
2858         * DumpRenderTree/win/UIDelegate.cpp:
2859         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2860         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2861         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2862         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2863
2864 2007-10-15  Alice Liu  <alice.liu@apple.com>
2865
2866         Reviewed by Sam Weinig.
2867
2868         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2869
2870         * DumpRenderTree/win/DumpRenderTree.cpp:
2871         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2872         (main): allocate the global policy delegate for DRT's custom use
2873         * DumpRenderTree/win/DumpRenderTree.vcproj:
2874         Adding files to project
2875         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2876         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2877         (LayoutTestController::setCustomPolicyDelegate):
2878         set the webview's policy delegate to DRT's custom one if the test requests it.
2879         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2880         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2881         (PolicyDelegate::PolicyDelegate):
2882         (PolicyDelegate::QueryInterface):
2883         (PolicyDelegate::AddRef):
2884         (PolicyDelegate::Release):
2885         (PolicyDelegate::decidePolicyForNavigationAction):
2886         * DumpRenderTree/win/PolicyDelegate.h: Added.
2887         (PolicyDelegate::decidePolicyForNewWindowAction):
2888         (PolicyDelegate::decidePolicyForMIMEType):
2889         (PolicyDelegate::unableToImplementPolicyWithError):
2890
2891 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2892
2893         Reviewed by Mark.
2894
2895         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2896         when querying for QMAKE_MKSPECS.
2897
2898 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2899
2900         Reviewed by Adam Roben.
2901         
2902         Fix run-webkit-tests is too greedy calculating platform hierarchy
2903         http://bugs.webkit.org/show_bug.cgi?id=15465
2904         
2905         Fix run-webkit-tests being too greedy in trying to split the platform name up
2906         causing it to try and find tests in every directory above the first "-" in the
2907         path to the LayoutTests
2908
2909         * Scripts/run-webkit-tests:
2910
2911 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2912
2913         Reviewed by Darin.
2914
2915         http://bugs.webkit.org/show_bug.cgi?id=15006
2916         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2917         to reduce code duplication.
2918
2919         * Scripts/build-webkit:
2920         * Scripts/webkitdirs.pm:
2921         buildQMakeProject() renamed to buildQMakeQtProject().
2922         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2923         unused $colorize has been removed.
2924
2925 === Start merge of feature-branch 2007-10-12 ===
2926
2927 2007-10-08  Eric Seidel  <eric@webkit.org>
2928
2929         Reviewed by Mark Rowe.
2930
2931         * Scripts/build-webkit: add --help, remove unused --color
2932
2933 2007-10-07  Eric Seidel  <eric@webkit.org>
2934
2935         Reviewed by darin.
2936
2937         * Drosera/mac/DebuggerDocumentPlatform.mm:
2938         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2939
2940 2007-10-03  Rob Buis  <buis@kde.org>
2941
2942         Reviewed by Olliej.
2943
2944         Adapt to changed location of Ahem font.
2945
2946         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2947
2948 2007-10-02  Eric Seidel  <eric@webkit.org>
2949
2950         Reviewed by Adam Roben.
2951         
2952         Make pixel tests more useful!
2953         Finally fix the image diff 0.00% mystery problem
2954         Highlight any image differences in the image diff.
2955         Add a link from image diffs back to original test file.
2956
2957         * DumpRenderTree/mac/ImageDiff.m:
2958         (compareImages): highlight any differences
2959         (computePercentageDifferent): round to two decimal places
2960         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2961
2962 2007-10-02  Eric Seidel  <eric@webkit.org>
2963
2964         Reviewed by Alexey Proskuryakov.
2965
2966         * Scripts/run-webkit-tests: print the % image difference on main results page
2967
2968 2007-10-02  Mark Rowe  <mrowe@apple.com>
2969
2970         Reviewed by Oliver.
2971
2972         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2973
2974         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2975         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2976
2977 2007-10-01  Mark Rowe  <mrowe@apple.com>
2978
2979         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2980
2981 2007-09-25  Eric Seidel  <eric@webkit.org>
2982
2983         Reviewed by Mark Rowe.
2984         
2985         DerivedSources.make was finding "ENABLE_SVG" in the string
2986         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2987         quite correctly.
2988
2989         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2990
2991 2007-09-25  Mark Rowe  <mrowe@apple.com>
2992
2993         Rubber-stamped by Eric.
2994
2995         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2996         This makes it possible to automate nightly builds for the feature-branch.
2997
2998 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2999
3000         Rubber stamped by Mark.
3001
3002         Enable svg experimental features as default here in feature-branch.
3003
3004         * Scripts/build-webkit:
3005
3006 2007-06-29  Antti Koivisto  <antti@apple.com>
3007
3008         Reviewed by Weinig.
3009         
3010         Add VIDEO flag for timed media features
3011
3012         * Scripts/build-webkit
3013         
3014 === End merge of feature-branch 2007-10-12 ===
3015
3016 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3017
3018         Reviewed by Darin.
3019
3020         - Updated rational for the leaks list to be more clear.
3021
3022         * Scripts/run-webkit-tests:
3023
3024 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3025
3026         Rubber Stamp by Sam.
3027
3028         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3029         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3030
3031         * Scripts/run-webkit-tests:
3032
3033 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3034
3035         Reviewed by Lars.
3036
3037         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3038         includes are needed for INT_MAX, std::auto_ptr and the like.
3039
3040         * DumpRenderTree/qt/main.cpp:
3041
3042 2007-10-09  Lars Knoll  <lars@trolltech.com>
3043
3044         Reviewed by Simon.
3045
3046         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3047
3048         * DumpRenderTree/qt/jsobjects.cpp:
3049         (LayoutTestController::encodeHostName):
3050         (LayoutTestController::decodeHostName):
3051         * DumpRenderTree/qt/jsobjects.h:
3052
3053 2007-10-09  Lars Knoll  <lars@trolltech.com>
3054
3055         Reviewed by Simon.
3056
3057         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3058
3059         * DumpRenderTree/qt/DumpRenderTree.cpp:
3060         (WebCore::WebPage::createFrame):
3061         (WebCore::DumpRenderTree::DumpRenderTree):
3062         (WebCore::DumpRenderTree::titleChanged):
3063         * DumpRenderTree/qt/DumpRenderTree.h:
3064         * DumpRenderTree/qt/jsobjects.cpp:
3065         (LayoutTestController::reset):
3066         * DumpRenderTree/qt/jsobjects.h:
3067
3068 2007-10-09  Lars Knoll  <lars@trolltech.com>
3069
3070         Reviewed by Simon.
3071
3072         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3073
3074         * DumpRenderTree/qt/DumpRenderTree.h:
3075         * DumpRenderTree/qt/jsobjects.cpp:
3076         (LayoutTestController::clearBackForwardList):
3077         * DumpRenderTree/qt/jsobjects.h:
3078
3079 2007-10-09  Lars Knoll  <lars@trolltech.com>
3080
3081         Reviewed by Simon.
3082
3083         make --git-reviewer work again.
3084
3085         * Scripts/prepare-ChangeLog:
3086
3087 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3088
3089         Rubber stamped by Eric.
3090
3091         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3092         show the current link inside the statusbar.
3093         This shows how to make use of this signal and allows to easily test
3094         http://bugs.webkit.org/show_bug.cgi?id=15299.
3095
3096         * GtkLauncher/main.cpp:
3097         (hoveringOverLink):
3098         (main):
3099
3100 2007-10-05  Lars Knoll  <lars@trolltech.com>
3101
3102         add proper error messages to the FrameLoaderClient.
3103         Implement ChromeClientQt::closeWindowSoon and
3104         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3105         Some fixes in DRT to make it work correctly with multiple windows.
3106
3107         Reviewed by Maciej.
3108
3109         * DumpRenderTree/qt/DumpRenderTree.cpp:
3110         (WebCore::DumpRenderTree::DumpRenderTree):
3111         (WebCore::DumpRenderTree::createWindow):
3112         (WebCore::DumpRenderTree::windowCount):
3113         * DumpRenderTree/qt/DumpRenderTree.h:
3114         * DumpRenderTree/qt/jsobjects.cpp:
3115         (LayoutTestController::maybeDump):
3116         (LayoutTestController::windowCount):
3117         * DumpRenderTree/qt/jsobjects.h:
3118
3119 2007-10-05  Lars Knoll  <lars@trolltech.com>
3120
3121         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3122         Add support for layoutTextController.setCanOpenWindows() to DRT
3123         fixing another 2 test cases in fast/dom/Window.
3124
3125         Reviewed by Maciej.
3126
3127         * DumpRenderTree/qt/DumpRenderTree.cpp:
3128         (WebCore::WebPage::WebPage):
3129         (WebCore::WebPage::createWindow):
3130         (WebCore::DumpRenderTree::resetJSObjects):
3131         (WebCore::DumpRenderTree::createWindow):
3132         * DumpRenderTree/qt/DumpRenderTree.h:
3133         * DumpRenderTree/qt/DumpRenderTree.pro:
3134         * DumpRenderTree/qt/jsobjects.cpp:
3135         (LayoutTestController::LayoutTestController):
3136         (LayoutTestController::reset):
3137         * DumpRenderTree/qt/jsobjects.h:
3138         * DumpRenderTree/qt/main.cpp:
3139         * DumpRenderTree/qt/testplugin.cpp: Added.
3140         * DumpRenderTree/qt/testplugin.h: Added.
3141
3142 2007-10-04  Sam Weinig  <sam@webkit.org>
3143
3144         Rubber stamped by Adam.
3145
3146         Remove empty directories.
3147
3148         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3149         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3150
3151 2007-10-03  Darin Adler  <darin@apple.com>
3152
3153         Reviewed by Adam.
3154
3155         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3156         we find the internal libraries in the libraries directory. This
3157         is helpful for Safari team engineers at Apple.
3158
3159 2007-10-03  Adam Roben  <aroben@apple.com>
3160
3161         Update the location of AHEM___.TTF after r25968
3162
3163         Reviewed by Sam.
3164
3165         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3166
3167 2007-10-03  Alp Toker  <alp@atoker.com>
3168
3169         Reviewed by Adam.
3170
3171         http://bugs.webkit.org/show_bug.cgi?id=14726
3172         [gtk] API design. Mapping the WebView delegates to signals.
3173
3174         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3175
3176         * GtkLauncher/main.cpp:
3177         (goToURLBarText):
3178         (titleChanged):
3179         (progressChanged):
3180         (menuMainBackCallback):
3181         (menuMainForwardCallback):
3182         (main):
3183
3184 2007-10-03  Lars Knoll  <lars@trolltech.com>
3185
3186         Reviewed by Rob.
3187
3188         This fixes --strict mode in run-webkit-tests again after
3189         the platform dependent test results have been moved.
3190
3191         * Scripts/run-webkit-tests:
3192
3193 2007-10-03  Lars Knoll  <lars@trolltech.com>
3194
3195         Reviewed by bdash.
3196
3197         remove the hack in run-webkit-tests that forced text only test
3198         to be taken from the platform independent dir. It was only left
3199         there from early days.
3200         
3201         Remove platform dependent results for tests that are text only nowadays,
3202         and add one platform dependent result for a text only test that requires it.
3203
3204         * Scripts/run-webkit-tests:
3205
3206 2007-10-03  Lars Knoll  <lars@trolltech.com>
3207
3208         Reviewed by olliej.
3209
3210         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3211
3212         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3213         (WebCore::WebFrame::WebFrame):
3214         (WebCore::WebPage::WebPage):
3215         (WebCore::WebPage::createFrame):
3216         (WebCore::WebPage::javaScriptAlert):
3217         (WebCore::WebPage::javaScriptConsoleMessage):
3218         (WebCore::DumpRenderTree::DumpRenderTree):
3219         (WebCore::DumpRenderTree::~DumpRenderTree):
3220         (WebCore::DumpRenderTree::open):
3221         (WebCore::DumpRenderTree::readStdin):
3222         (WebCore::DumpRenderTree::resetJSObjects):
3223         (WebCore::DumpRenderTree::initJSObjects):
3224         (WebCore::DumpRenderTree::dumpFramesAsText):
3225         (WebCore::DumpRenderTree::dump):
3226         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3227         (WebCore::DumpRenderTree::layoutTestController):
3228         (WebCore::DumpRenderTree::eventSender):
3229         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3230         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3231         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3232         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3233         (HackWebFrame::mousePressEvent):
3234         (HackWebFrame::mouseReleaseEvent):
3235         (HackWebFrame::mouseMoveEvent):
3236         (HackWebFrame::HackWebFrame):
3237         (HackWebFrame::~HackWebFrame):
3238         (LayoutTestController::LayoutTestController):
3239         (LayoutTestController::reset):
3240         (LayoutTestController::maybeDump):
3241         (LayoutTestController::waitUntilDone):
3242         (LayoutTestController::notifyDone):
3243         (LayoutTestController::dumpEditingCallbacks):
3244         (LayoutTestController::queueReload):
3245         (LayoutTestController::provisionalLoad):
3246         (LayoutTestController::timerEvent):
3247         (EventSender::EventSender):
3248         (EventSender::mouseDown):
3249         (EventSender::mouseUp):
3250         (EventSender::mouseMoveTo):
3251         (EventSender::leapForward):
3252         (EventSender::keyDown):
3253         (EventSender::frameUnderMouse):
3254         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3255         (LayoutTestController::isLoading):
3256         (LayoutTestController::setLoading):
3257         (LayoutTestController::shouldDumpAsText):
3258         (LayoutTestController::shouldDumpChildrenAsText):
3259         (LayoutTestController::shouldWaitUntilDone):
3260         (LayoutTestController::dumpAsText):
3261         (LayoutTestController::dumpChildFramesAsText):
3262         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3263         (messageHandler):
3264         (crashHandler):
3265         (main):
3266         * Scripts/run-webkit-tests:
3267
3268 2007-10-03  Mark Rowe  <mrowe@apple.com>
3269
3270         Reviewed by Alp Toker.
3271
3272         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3273         should take precedence over QTDIR when determining which port we are working with.
3274
3275         * Scripts/webkitdirs.pm: 
3276
3277 2007-10-02  Adam Roben  <aroben@apple.com>
3278
3279         Add keychain to the list of default packages to install
3280
3281         Rubberstamped by Sam.
3282
3283         * CygwinDownloader/cygwin-downloader.py:
3284         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3285
3286 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3287
3288         Reviewed by Adam.
3289
3290         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3291         Also makes WebCore regression test case logic work when using git.
3292
3293         * Scripts/prepare-ChangeLog:
3294         (reviewerAndDescriptionForGitCommit): Added.
3295
3296 2007-10-02  Lars Knoll  <lars@trolltech.com>
3297
3298         Reviewed by bdash.
3299
3300         Add API to retrieve the frame name from QWebFrame.
3301         Implement support for DRT::dumpChildrenAsText.
3302
3303         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3304         (WebCore::DumpRenderTree::dumpFramesAsText):
3305         (WebCore::DumpRenderTree::dump):
3306         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3307         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3308         (LayoutTestController::LayoutTestController):
3309         (LayoutTestController::reset):
3310         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3311
3312 2007-10-02  Lars Knoll  <lars@trolltech.com>
3313
3314         Reviewed by bdash.
3315
3316         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3317
3318         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3319         (WebCore::DumpRenderTree::readStdin):
3320
3321 2007-10-02  Mark Rowe  <mrowe@apple.com>
3322
3323         Reviewed by Oliver.
3324
3325         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3326
3327         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3328         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3329
3330 2007-10-02  Mark Rowe  <mrowe@apple.com>
3331
3332         Rubber-stamped by Maciej.
3333
3334         Configuration changes from build.webkit.org.  The major change is refactoring to work
3335         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3336         last few weeks.
3337
3338         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3339         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3340         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3341         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3342         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3343         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3344         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3345         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3346
3347 2007-10-02  Lars Knoll  <lars@trolltech.com>
3348
3349         Reviewed by Maciej.
3350
3351         Add support for eventSender.mouseMove to DRT.
3352         Fixes fast/css/hover-affects-child.html
3353
3354         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3355         (EventSender::mouseMoveTo):
3356
3357 2007-10-01  Mark Rowe  <mrowe@apple.com>
3358
3359         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3360
3361 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3362
3363         Reviewed by Hyatt.
3364
3365         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3366
3367         * Scripts/svn-apply:
3368         (gitdiff2svndiff): Ignore lines beginning with "new file".
3369         * Scripts/svn-unapply:
3370         (gitdiff2svndiff): Ditto.
3371
3372 2007-09-30  George Staikos  <staikos@kde.org>
3373
3374         Qt build fix (Mac OS X specific)
3375
3376         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3377
3378 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3379
3380         Reviewed by Mark.
3381
3382         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3383         Remove Bakefiles from svn.
3384
3385         * GtkLauncher/Bakefiles.bkgen: Removed.
3386         * GtkLauncher/ENV: Removed.
3387         * GtkLauncher/gdklauncher.bkl: Removed.
3388         * GtkLauncher/mk: Removed.
3389         * Scripts/regenerate-makefiles: Removed.
3390
3391 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3392
3393         Reviewed by John.
3394
3395         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3396
3397         * Scripts/run-webkit-tests:
3398
3399 2007-09-26  Adam Roben  <aroben@apple.com>
3400
3401         Make not finding an installed WebKit non-fatal
3402
3403         What really matters is that we are able to load WebKit and its
3404         dependencies, not whether we think we've found an installed WebKit.
3405
3406         Reviewed by Sam.
3407
3408         * WebKitInitializer/WebKitInitializer.cpp:
3409         (getWebViewCLSID): Use new LOG_WARNING macro.
3410         (getInstalledWebKitDirectory): Ditto.
3411         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3412         and use new macros.
3413         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3414
3415 2007-09-26  Adam Roben  <aroben@apple.com>
3416
3417         Committed this file before saving it
3418
3419         * WebKitInitializer/debug_internal.vsprops:
3420
3421 2007-09-26  Adam Roben  <aroben@apple.com>
3422
3423         Load WebKit and its dependencies manually so they come from DllDirectory
3424
3425         I had to change WebKitInitializer to use malloc/free instead of
3426         new/delete to avoid pulling in WebKit (and its dependencies) early
3427         through use of fastMalloc.
3428
3429         Reviewed by Oliver.
3430
3431         * WebKitInitializer/WebKitInitializer.cpp:
3432         (getStringValue): Changed to use malloc/free.
3433         (getInstalledWebKitDirectory): Ditto.
3434         (initializeWebKit): Call SetDllDirectory first, then load all of
3435         WebKit's dependencies manually, finally followed by WebKit itself.
3436         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3437         configuration to match our other projects.
3438         * WebKitInitializer/debug_internal.vsprops: Added.
3439
3440 2007-09-25  Adam Roben  <aroben@apple.com>
3441
3442         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3443
3444         Rubberstamped by Sam.
3445
3446         * WebKitInitializer/WebKitInitializer.vcproj:
3447
3448 2007-09-25  Adam Roben  <aroben@apple.com>
3449
3450         Make DumpRenderTree delay-load its dependencies
3451
3452         This lets WebKitInitializer re-route the dependencies to be loaded out
3453         of the Safari installation directory.
3454
3455         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3456         same thing), since we can't import the kCFAllocatorDefault symbol when
3457         delay-loading CoreFoundation.dll.
3458
3459         Rubberstamped by Sam.
3460
3461         * DumpRenderTree/win/DumpRenderTree.cpp:
3462         (runTest):
3463         (javaScriptThreads):
3464         * DumpRenderTree/win/DumpRenderTree.vcproj:
3465         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3466         (LayoutTestController::setWaitToDump):
3467
3468 2007-09-25  Adam Roben  <aroben@apple.com>
3469
3470         Pull ole32.lib into WebKitInitializer
3471
3472         Rubberstamped by Sam.
3473
3474         * WebKitInitializer/WebKitInitializer.vcproj:
3475
3476 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3477
3478         Reviewed by Adam.
3479
3480         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3481           LGPL'ed files contain incorrect FSF address
3482
3483         * Drosera/config.h:
3484
3485 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3486
3487         Reviewed by Adam.
3488
3489         Make svn-apply and svn-unapply work with git-diff formatted patches.
3490
3491         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3492         (gitdiff2svndiff): Added.
3493         * Scripts/svn-unapply: Ditto.
3494         (gitdiff2svndiff): Added.
3495
3496 2007-09-25  Adam Roben  <aroben@apple.com>
3497
3498         Pull advapi32.lib into WebKitInitializer
3499
3500         This is needed to get the registry functions we use.
3501
3502         Rubberstamped by Sam.
3503
3504         * WebKitInitializer/WebKitInitializer.vcproj:
3505
3506 2007-09-25  Adam Roben  <aroben@apple.com>
3507
3508         Add python and rsync to cygwin-downloader
3509
3510         Our build slaves need this, and it can't hurt for everyone else to
3511         have it, too.
3512
3513         Reviewed by Sam.
3514
3515         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3516         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3517
3518 2007-09-25  Adam Roben  <aroben@apple.com>
3519
3520         Add WebKitInitializer and use it in DumpRenderTree
3521
3522         WebKitInitializer is a static library that has one function,
3523         initializeWebKit(). This registers WebKit and sets up the DLL search
3524         path so that WebKit's dependencies that are installed with Safari can
3525         be found.
3526
3527         Reviewed by Sam.
3528
3529         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3530         DumpRenderTree depend on it.
3531         * DumpRenderTree/win/DumpRenderTree.cpp:
3532         (initialize): Call initializeWebKit.
3533         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3534         WebKitInitializer.lib.
3535         * WebKitInitializer/WebKitInitializer.cpp: Added.
3536         (getStringValue):
3537         (getWebViewCLSID):
3538         (getInstalledWebKitDirectory):
3539         (initializeWebKit):
3540         * WebKitInitializer/WebKitInitializer.h: Added.
3541         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3542         * WebKitInitializer/debug.vsprops: Added.
3543         * WebKitInitializer/release.vsprops: Added.
3544
3545 2007-09-25  Adam Roben  <aroben@apple.com>
3546
3547         Make run-webkit-tests respect set-webkit-configuration
3548
3549         Reviewed by Sam.
3550
3551         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3552         set-webkit-configuration was last set to.
3553
3554 2007-09-25  Mark Rowe  <mrowe@apple.com>
3555
3556         Rubber-stamped by Eric.
3557
3558         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3559         This makes it possible to automate nightly builds for the feature-branch.
3560
3561 2007-09-25  Adam Roben  <aroben@apple.com>
3562
3563         A couple of fixes/enhancements to update-webkit-*-libs
3564
3565         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3566         to tell update-webkit-support-libraries where it should find the
3567         WebKitSupportLibrary.zip file you downloaded.
3568
3569         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3570         Windows-style path.
3571
3572         Reviewed by Sam.
3573
3574         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3575         to $auxiliaryLibsURL and removed an irrelevant comment.
3576         * Scripts/update-webkit-support-libs:
3577
3578 2007-09-25  Adam Treat  <treat@kde.org>
3579
3580         Reviewed by Simon and Lars.
3581
3582         Refactors and cleans up Qt DRT member variable names, member variable
3583         initialization, style fixes and general code cleanup.
3584
3585         Adds queueReload slot to LayoutTestController that some tests require.
3586
3587         Subclasses QWebFrame to make sure that all frames have an associated
3588         LayoutTestController JS window object.
3589
3590         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3591         aren't dumped twice.
3592
3593         EOF fixes.
3594
3595         Together, this patch fixes some 20+ layout tests in QtWebKit.
3596
3597         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3598         (WebCore::WebFrame::WebFrame):
3599         (WebCore::WebPage::WebPage):
3600         (WebCore::WebPage::createFrame):
3601         (WebCore::DumpRenderTree::DumpRenderTree):
3602         (WebCore::DumpRenderTree::open):
3603         (WebCore::DumpRenderTree::readStdin):
3604         (WebCore::DumpRenderTree::initJSObjects):
3605         (WebCore::DumpRenderTree::dump):
3606         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3607         (WebCore::DumpRenderTree::layoutTestController):