1 2007-12-18 Darin Adler <darin@apple.com>
3 * Scripts/do-webcore-rename: Plan more renaming.
5 2007-12-14 Juan A. Suarez Romero <jasuarez@igalia.com>
9 http://bugs.webkit.org/show_bug.cgi?id=16042
10 [GTK] Eliminate webkit_init()
12 Moving webkit initialization to WebView class init.
14 * DumpRenderTree/gtk/DumpRenderTree.cpp:
19 2007-12-17 Luca Bruno <lethalman88@gmail.com>
21 Reviewed by Alp Toker.
23 http://bugs.webkit.org/show_bug.cgi?id=13542
24 gdklauncher doesnt change URL in adress GTKEntry.
27 (load_commit_cb): added
31 2007-12-16 Dimitri Glazkov <dimitri@glazkov.com>
33 Reviewed by Adam Roben.
35 Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
37 * FindSafari/FindSafari.cpp:
40 2007-12-16 Brent Fulgham <bfulgham@gmail.com>
42 Reviewed by Adam Roben.
44 http://bugs.webkit.org/show_bug.cgi?id=16315
45 FindSafari needs a path-only option.
47 * FindSafari/FindSafari.cpp:
50 2007-12-16 Alexey Proskuryakov <ap@webkit.org>
54 http://bugs.webkit.org/show_bug.cgi?id=16462
55 REGRESSION: access keys broken on Windows
57 * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
60 2007-12-15 Sam Weinig <sam@webkit.org>
62 Reviewed by Mark Rowe.
64 Fix urlSuitableForTestResult to correctly identify wstring::npos as
65 the case when wstring.find doesn't find anything.
67 * DumpRenderTree/win/DumpRenderTree.cpp:
68 (urlSuitableForTestResult):
70 2007-12-15 Alp Toker <alp@atoker.com>
72 GTK+ DRT build fix for GLib < 2.14.
74 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
75 (LayoutTestController::setWaitToDump):
77 2007-12-05 Mark Rowe <mrowe@apple.com>
79 Reviewed by Alp Toker.
81 Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm. This prevents
82 many layout tests from hanging while waiting on user responses to dialogs.
84 * DumpRenderTree/gtk/DumpRenderTree.cpp:
85 (invalidateAnyPreviousWaitToDumpWatchdog):
87 (webViewScriptPrompt):
88 (webViewScriptConfirm):
90 * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
91 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
92 (waitToDumpWatchdogFired):
93 (LayoutTestController::setWaitToDump):
95 2007-12-05 Mark Rowe <mrowe@apple.com>
97 Reviewed by Alp Toker.
99 Flesh out DumpRenderTree for Gtk. After these changes, the majority of the tests in fast/js pass.
101 * DumpRenderTree/gtk/DumpRenderTree.cpp:
102 (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
105 (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
106 (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
108 (webViewWindowObjectCleared): Set up window.layoutTestController.
109 (webViewConsoleMessage): Match the console message format expected by the layout test results.
110 (main): Hook up the new signals.
111 * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
112 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
113 dumping multiple times.
114 * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
115 * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways. Use run-launcher to open test results.
117 2007-12-14 Anders Carlsson <andersca@apple.com>
121 Assert that a web frame that's loading a resource always has either a data source or
122 a provisional data source.
124 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
125 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
127 2007-12-14 Darin Adler <darin@apple.com>
129 - fix mistake causing nearly all tests to fail on Windows
131 * DumpRenderTree/win/UIDelegate.cpp:
132 (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
133 npos, not 0. Also pass URL in to URL function rather than passing the entire message.
135 * DumpRenderTree/mac/UIDelegate.mm:
136 (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
137 than passing the entire message.
139 2007-12-14 Darin Adler <darin@apple.com>
143 * DumpRenderTree/mac/UIDelegate.mm:
144 (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
145 new-to-Leopard methods.
147 2007-12-14 Darin Adler <darin@apple.com>
149 * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
150 since it now triggers unwanted icon loading. We only had it because we implemented "all"
151 delegate methods here.
153 2007-12-14 Anders Carlsson <andersca@apple.com>
155 Reviewed by Darin and Geoff.
157 <rdar://problem/5619295>
158 REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
160 Add property getting methods to the plug-in.
162 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
165 2007-12-14 Kevin McCullough <kmccullough@apple.com>
169 - Layout test fix for mac. When dumped to the console local file paths
170 now only show the name of the resource not the whole path. This is to
171 make the results machine and OS independent.
173 * DumpRenderTree/mac/UIDelegate.mm:
174 (-[UIDelegate webView:addMessageToConsole:]):
176 2007-12-13 Kevin McCullough <kmccullough@apple.com>
180 - Layout tests fix. We need a way to remove machine-dependent
181 information from paths in layout test results. The UIDelegate now does
184 * DumpRenderTree/DumpRenderTree.h:
185 * DumpRenderTree/win/DumpRenderTree.cpp:
186 (urlSuitableForTestResult):
187 * DumpRenderTree/win/DumpRenderTreeWin.h:
188 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
189 * DumpRenderTree/win/UIDelegate.cpp:
190 (UIDelegate::webViewAddMessageToConsole):
192 2007-12-13 Alp Toker <alp@atoker.com>
194 Build fix for DRT breakage introduced in r28690.
196 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
197 (LayoutTestController::pathToLocalResource):
199 2007-12-12 Kevin McCullough <kmccullough@apple.com>
201 Reviewed by Alice and Sam.
203 - <rdar://5621435> Need a way to specify local resources (being loaded
204 from HTTP tests) on Windows.
205 - Implemented pathToLocalResource which exposes the functionality of
206 converting a given unix path to the correct location on Windows.
208 * DumpRenderTree/LayoutTestController.cpp:
209 (pathToLocalResourceCallback):
210 (LayoutTestController::staticFunctions):
211 * DumpRenderTree/LayoutTestController.h:
212 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
213 (LayoutTestController::pathToLocalResource):
214 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
215 (LayoutTestController::pathToLocalResource):
217 2007-12-12 Anders Carlsson <andersca@apple.com>
221 <rdar://problem/5132003>
222 dumpResourceLoadCallbacks is not implemented in DRT on Windows.
224 * DumpRenderTree/win/DumpRenderTree.cpp:
226 Set the resource load delegate.
228 * DumpRenderTree/win/DumpRenderTree.vcproj:
230 * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
231 * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
233 2007-12-12 Alexey Proskuryakov <ap@webkit.org>
235 Reviewed by Adam Roben.
237 Fix conversion from double to LPARAM in dispatchMessage().
239 * DumpRenderTree/win/EventSender.cpp:
240 (dispatchMessageCallback):
242 2007-12-11 Dan Bernstein <mitz@apple.com>
244 Reviewed by Mark Rowe and Sam Weinig too!
246 - added Helvetica Oblique and Helvetica Bold Oblique to the list of
247 fonts DumpRenderTree registers.
249 * DumpRenderTree/win/DumpRenderTree.cpp:
252 2007-12-11 Brady Eidson <beidson@apple.com>
256 Make DumpRenderTree on mac use its own path for Databases testing
258 * DumpRenderTree/mac/DumpRenderTree.mm:
259 (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
260 for future DRT-only use, then use it to construct the Databases path and set that default
262 2007-12-07 Alexey Proskuryakov <ap@webkit.org>
266 <rdar://problem/5535636>
267 Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
269 http://bugs.webkit.org/show_bug.cgi?id=13916
270 JavaScript detects Tab as a character input on a textfield validation
272 * DumpRenderTree/mac/EventSendingController.mm:
273 (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
274 Dispatch a keyup to better match what happens when a key is physically pressed.
276 * DumpRenderTree/win/EventSender.cpp:
277 (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
278 returning from keyDown().
279 (getConstantCallback): Fixed a couple copy/paste mistakes.
281 2007-12-07 Kevin McCullough <kmccullough@apple.com>
285 - <rdar://5599845> Drosera: Does not show loal files in the file list
288 * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
289 * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
290 so the open source community can build.
292 2007-12-10 Brady Eidson <beidson@apple.com>
294 Rubberstamped by Sam Weinig
296 Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
298 * DumpRenderTree/mac/UIDelegate.mm:
299 (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
300 (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
302 2007-12-08 Oliver Hunt <oliver@apple.com>
306 Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
308 Fixes <rdar://problem/5620249> Must disable SVG animation
309 <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
311 In order to allow finer grained control over the set of SVG features
312 this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
320 by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
322 Script handles all the new build flags, and allows --svg-experimental
323 to automatically enable all features.
325 * Scripts/build-webkit:
327 2007-12-07 Steve Falkenburg <sfalken@apple.com>
331 Rubber-stamped by Oliver.
333 * Drosera/win/Drosera.vcproj/auto-version.sh:
335 2007-12-07 Steve Falkenburg <sfalken@apple.com>
337 Build modifications for Drosera.
341 * Drosera/DroseraWin.make: Added.
342 * Drosera/win/Drosera.vcproj/Drosera.rc:
343 * Drosera/win/Drosera.vcproj/Drosera.vcproj:
344 * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
345 * Drosera/win/Drosera.vcproj/VERSION: Added.
346 * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
348 2007-12-06 Adam Roben <aroben@apple.com>
350 Explicitly turn on the Mac font ascent hack on Windows
352 This keeps our font metrics matching those from Mac.
356 * DumpRenderTree/win/DumpRenderTree.cpp:
359 2007-12-06 Anders Carlsson <andersca@apple.com>
361 Rename main.c to main.cpp here too.
363 * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
365 2007-12-06 Sam Weinig <sam@webkit.org>
367 Rubber stamped by Geoff.
369 * Scripts/do-webcore-rename: Don't rename kjs_css twice.
371 2007-12-06 Darin Adler <darin@apple.com>
373 * Scripts/do-webcore-rename: Some more renaming plans.
375 2007-12-06 Anders Carlsson <andersca@apple.com>
377 Restore implementation of testGetIntIdentifier that was accidentally
378 removed somehow (possibly when I made PluginObject be a cpp file).
380 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
383 2007-12-05 Anders Carlsson <andersca@apple.com>
385 Make the entry points extern "C".
386 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
388 2007-12-05 Anders Carlsson <andersca@apple.com>
392 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
401 2007-12-05 Anders Carlsson <andersca@apple.com>
403 Add the .cpp files to the TestNetscapePlugIn target.
405 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
407 2007-12-05 Anders Carlsson <andersca@apple.com>
411 Rename the TestNetscapePlugIn .c files to be .cpp.
413 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
414 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
415 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
416 * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
417 * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
418 * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
419 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
420 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
422 2007-12-05 Adam Roben <aroben@apple.com>
424 Fix case of keypresses from the Windows implementation of eventSender.keyDown
426 This fixes several regression tests.
430 * DumpRenderTree/win/EventSender.cpp:
431 (keyDownCallback): Virtual keycodes for ASCII characters are always
432 uppercase, so we need to check the case of the original character
433 passed in to eventSender.keyDown.
435 2007-12-05 Adam Roben <aroben@apple.com>
437 Learn from Tim's mistakes
439 * DumpRenderTree/win/DumpRenderTree.cpp:
440 (runTest): Reset the authorAndUserStylesEnabled preference for each
443 2007-12-05 Alp Toker <alp@atoker.com>
445 Reviewed by Mark Rowe.
447 Initialize GTK+ and WebKit so the tests can run.
449 Reorganize the headers a little.
451 * DumpRenderTree/gtk/DumpRenderTree.cpp:
454 2007-12-04 Anders Carlsson <andersca@apple.com>
456 Remove IWebScriptScope include.
458 * Drosera/win/DebuggerDocumentPlatform.cpp:
460 2007-12-04 Sam Weinig <sam@webkit.org>
462 Rubber stamped by Mark Rowe.
464 Define CF as platform for mac and revert r28409
466 * DumpRenderTree/DumpRenderTree.h:
467 * DumpRenderTree/mac/DumpRenderTreeMac.h:
469 2007-12-04 Sam Weinig <sam@webkit.org>
471 Define CF as platform for windows.
473 Reviewed by Adam Roben.
475 * DumpRenderTree/win/DumpRenderTreeWin.h:
477 2007-12-04 Kevin McCullough <kmccullough@apple.com>
479 Reviewed by Adam and Darin.
481 - Removed a needless BSTR cleanup.
483 * Drosera/win/DebuggerDocumentPlatform.cpp:
484 (DebuggerDocument::getPlatformCurrentFunctionStack):
486 2007-11-27 Adam Roben <aroben@apple.com>
488 Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
492 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
493 (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
495 2007-12-04 Alp Toker <alp@atoker.com>
497 Prospective Win DRT build fix.
499 * DumpRenderTree/DumpRenderTree.h:
501 2007-12-04 Alp Toker <alp@atoker.com>
503 Fix a clobbered copyright header.
505 * DumpRenderTree/gtk/DumpRenderTree.cpp:
507 2007-12-04 Xan Lopez <xan@gnome.org>
509 Reviewed by Alp Toker.
511 http://bugs.webkit.org/show_bug.cgi?id=15561
512 GTK port needs DumpRenderTree implementation
514 Start work on the GTK+ DRT.
516 This does not work yet, and there are a few lingering style issues
517 (nothing major) but this patch has been stuck in the bug tracker for
520 * DumpRenderTree/DumpRenderTree.h:
521 * DumpRenderTree/gtk: Added.
522 * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
524 (shouldLogFrameLoadDelegates):
525 (dumpFrameScrollPosition):
529 (dumpRenderTreeAsText):
533 * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
534 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
535 * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
536 (GCController::collect):
537 (GCController::collectOnAlternateThread):
538 (GCController::getJSObjectCount):
539 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
540 (LayoutTestController::~LayoutTestController):
541 (LayoutTestController::addDisallowedURL):
542 (LayoutTestController::clearBackForwardList):
543 (LayoutTestController::copyDecodedHostName):
544 (LayoutTestController::copyEncodedHostName):
545 (LayoutTestController::display):
546 (LayoutTestController::keepWebHistory):
547 (LayoutTestController::notifyDone):
548 (LayoutTestController::queueBackNavigation):
549 (LayoutTestController::queueForwardNavigation):
550 (LayoutTestController::queueLoad):
551 (LayoutTestController::queueReload):
552 (LayoutTestController::queueScript):
553 (LayoutTestController::setAcceptsEditing):
554 (LayoutTestController::setCustomPolicyDelegate):
555 (LayoutTestController::setMainFrameIsFirstResponder):
556 (LayoutTestController::setTabKeyCyclesThroughElements):
557 (LayoutTestController::setUseDashboardCompatibilityMode):
558 (LayoutTestController::setUserStyleSheetEnabled):
559 (LayoutTestController::setUserStyleSheetLocation):
560 (LayoutTestController::setWindowIsKey):
561 (LayoutTestController::setWaitToDump):
562 (LayoutTestController::windowCount):
563 (LayoutTestController::setPrivateBrowsingEnabled):
564 (LayoutTestController::setAuthorAndUserStylesEnabled):
565 * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
566 (JSStringCopyUTF8CString):
568 (ReloadItem::invoke):
569 (ScriptItem::invoke):
570 (BackForwardItem::invoke):
572 2007-12-03 Sam Weinig <sam@webkit.org>
574 Move JavaScriptCore thread testing code to pthread specific directory
575 and remove the dependance on CoreFoundation by using WTF::HashSet.
577 Reviewed by Geoff and Oliver.
579 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
580 * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
581 * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
582 * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
583 * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
584 * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
585 * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
586 * DumpRenderTree/pthreads: Added.
587 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
589 (runJavaScriptThread):
590 (startJavaScriptThreads):
591 (stopJavaScriptThreads):
593 2007-12-03 Andrew Bonventre <andybons@google.com>
595 Reviewed by Darin Adler.
597 - fix http://bugs.webkit.org/show_bug.cgi?id=16267
598 Symbol lookup menu broken in debugger view
600 * Drosera/debugger.js: Fixed javascript error where document property
601 should have been used instead of contentDocument in switchFunction that
602 was breaking the select symbol dropdown menu. This is because
603 window.frames will return a Window object and not a frame object like
604 the author was originally expecting.
606 2007-12-03 Kevin McCullough <kmccullough@apple.com>
610 - <rdar://5618942> Drosera: Console window does not process everything
612 - <rdar://5619005> Drosera: could be sped up by moving the
613 WebScriptScope stuff into the WebScriptCallFrame.
614 - Now the console can correctly process objects and does not receive
615 notifications from JavaScriptCore about the JavaScript in Drosera's
618 * Drosera/win/DebuggerDocumentPlatform.cpp:
619 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
620 (DebuggerDocument::platformValueForScopeVariableNamed):
622 2007-12-03 Stephanie <slewis@apple.com>
626 Check to see if we are building a debug root
628 * Scripts/check-for-global-initializers:
630 2007-12-03 Dan Bernstein <mitz@apple.com>
632 Reviewed by Darin Adler.
634 - added a testGetIntIdentifier() method to TestNetscapePlugIn
636 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
639 2007-12-03 Alexey Proskuryakov <ap@webkit.org>
643 Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
644 in a more fine-grained manner than eventSender.keyDown().
646 * DumpRenderTree/win/EventSender.cpp:
647 (getConstantCallback):
648 (dispatchMessageCallback):
650 2007-12-02 Darin Adler <darin@apple.com>
652 * Scripts/do-webcore-rename: More planned renaming.
654 2007-12-02 Sam Weinig <sam@webkit.org>
656 Rubber stamped by Anders.
658 Use [NSURL absoluteString] instead of [NSURL description] in order to get
659 more uniform results cross platform.
661 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
662 (-[NSURL _drt_descriptionSuitableForTestResult]):
664 2007-12-02 Sam Weinig <sam@webkit.org>
666 Rubber stamped by Niko.
668 Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
670 * DumpRenderTree/win/DumpRenderTree.cpp:
671 * DumpRenderTree/win/DumpRenderTree.vcproj:
672 * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
673 * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
674 * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
675 * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
677 2007-12-01 Alp Toker <alp@atoker.com>
679 Reviewed by Adam Roben.
681 Make use of the newly introduced webkit.h convenience header.
683 * GtkLauncher/main.c:
685 2007-12-01 Adam Treat <treat@kde.org>
689 * Check to see if the directory exists and exit if not.
691 * DumpRenderTree/qt/main.cpp:
694 2007-12-01 Adam Treat <treat@kde.org>
698 * Don't hide symbols when in Debug mode
699 * On Linux (glibc) provide a backtrace in the test output for debugging purposes
702 * DumpRenderTree/qt/main.cpp:
705 2007-11-30 Alp Toker <alp@atoker.com>
707 Reviewed by Adam Roben.
709 http://bugs.webkit.org/show_bug.cgi?id=15691
710 [GTK] Public API does not follow GTK+ conventions
712 Refactor the WebKit/GTK+ public API. Changes:
713 WebKitPage -> WebKitWebView
714 WebKitFrame -> WebKitWebFrame
716 Public API source and header names have been updated to mirror the API
719 The API is now kept in WebKit/gtk/WebView to match other ports in the
720 same class such as Mac and Win.
722 * GtkLauncher/main.c:
723 (activate_uri_entry_cb):
726 (progress_change_cb):
732 2007-11-30 Adam Roben <aroben@apple.com>
734 Hopefully the final build fix
736 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
737 pull in WTF's assertion/logging functions.
739 2007-11-30 Adam Roben <aroben@apple.com>
743 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
746 2007-11-30 Adam Roben <aroben@apple.com>
750 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
752 * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
754 * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
755 * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
756 WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
758 2007-11-30 Sam Weinig <sam@webkit.org>
760 Reviewed by Adam Roben.
762 Fix drawSelectionRect to actually draw the selection rect.
764 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
767 2007-11-30 Darin Adler <darin@apple.com>
769 * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
771 2007-11-30 Darin Adler <darin@apple.com>
773 * Scripts/do-webcore-rename: Get ready for some future renaming.
775 2007-11-29 Kevin McCullough <kmccullough@apple.com>
779 - Removed some unnecessary functions and changed an unused return type.
781 * Drosera/win/DebuggerClient.cpp:
782 (registerConsoleClass):
783 * Drosera/win/DebuggerClient.h:
784 * Drosera/win/Drosera.cpp:
785 (registerDroseraClass):
787 2007-11-28 Alp Toker <alp@atoker.com>
789 Reviewed by Timothy Hatcher.
791 http://bugs.webkit.org/show_bug.cgi?id=16174
792 [GTK] Use "URI" not "URL" in public API
794 Replace use of the term "URL" with "URI" in public headers,
795 documentation and some internal code to match GLib/GTK+ convention.
797 This is now mentioned in the API guidelines:
798 http://trac.webkit.org/projects/webkit/wiki/HackingGtk
800 * GtkLauncher/main.c:
801 (activate_uri_entry_cb):
806 2007-11-29 Anders Carlsson <andersca@apple.com>
810 <rdar://problem/5230478>
811 FrameLoadDelegate callbacks are not dumped in DRT.
813 * DumpRenderTree/win/DumpRenderTree.cpp:
814 (shouldLogFrameLoadDelegates):
817 * DumpRenderTree/win/FrameLoaderDelegate.cpp:
819 (descriptionSuitableForTestResult):
820 (FrameLoadDelegate::QueryInterface):
821 (FrameLoadDelegate::didStartProvisionalLoadForFrame):
822 (FrameLoadDelegate::didFailProvisionalLoadWithError):
823 (FrameLoadDelegate::didCommitLoadForFrame):
824 (FrameLoadDelegate::didFinishLoadForFrame):
825 (FrameLoadDelegate::willCloseFrame):
826 (FrameLoadDelegate::didClearWindowObject):
827 (FrameLoadDelegate::didFinishDocumentLoadForFrame):
828 (FrameLoadDelegate::didHandleOnloadEventsForFrame):
829 * DumpRenderTree/win/FrameLoaderDelegate.h:
830 (FrameLoadDelegate::windowScriptObjectAvailable):
831 (FrameLoadDelegate::didFirstLayoutInFrame):
833 2007-11-29 Sam Weinig <sam@webkit.org>
837 Add database quota UIDelegates methods to DRT UIDelegate.
839 * DumpRenderTree/mac/UIDelegate.mm:
840 (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
841 (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
843 2007-11-29 Kevin McCullough <kmccullough@apple.com>
847 - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
848 dying and vice versa.
849 - This fix will allow Drosera and Safari to reconnect if either of them
850 closes correctly, but does not fix the case where one of them dies
853 * Drosera/win/ServerConnection.cpp:
854 (ServerConnection::attemptToCreateServerConnection): Added a safety
855 check, because it's possilbe to try to connect to a server that's dying.
856 (ServerConnection::serverDidDie): Implemented. This resets Drosera when
858 * Drosera/win/ServerConnection.h: Added the new function and removed
859 an unnecessary member.
861 2007-11-29 Anders Carlsson <andersca@apple.com>
863 * DumpRenderTree/win/DumpRenderTree.vcproj:
864 Add shlwapi.lib to all configurations.
866 2007-11-29 Kevin McCullough <kmccullough@apple.com>
868 - Build fix. Added additional includes for VS Express to the Release
871 * Drosera/win/Drosera.vcproj/Drosera.vcproj:
873 2007-11-29 Anders Carlsson <andersca@apple.com>
877 <rdar://problem/5132005>
878 setUserStyleSheetEnabled is not fully implemented in Windows DRT.
880 * DumpRenderTree/win/DumpRenderTree.vcproj:
883 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
884 (LayoutTestController::setUserStyleSheetEnabled):
887 (appendComponentToPath):
888 New method which wraps the Win32 API PathAppend.
891 New method which checks if a file points to a shortcut and
892 follows the shortcut.
895 New method that takes a cygwin unix-style path and returns the Win32 path.
897 (cfStringRefToWString):
899 (LayoutTestController::setUserStyleSheetLocation):
902 2007-11-29 Alice Liu <alice.liu@apple.com>
906 Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
908 * DumpRenderTree/win/EventSender.cpp:
910 uppercase letters were being sent as lowercase letters without the shift key down.
912 2007-11-29 Kevin McCullough <kmccullough@apple.com>
914 - Windows build fix. VS express needs some love.
916 * Drosera/win/Drosera.vcproj/Drosera.vcproj:
918 2007-11-28 Darin Adler <darin@apple.com>
920 Reviewed by Adam Roben.
922 * DumpRenderTree/mac/EventSendingController.mm:
923 (-[EventSendingController keyDown:withModifiers:]):
924 Send capital letters through as lowercase letters with the shift key down
925 rather than sending them as if they were highly unusual "capital letter keys".
927 * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
928 where you need to update results and more tests are failing than before.
930 2007-11-28 Anders Carlsson <andersca@apple.com>
934 <rdar://problem/5132001>
935 contextClick is not implemented in DRT on Windows.
937 * DumpRenderTree/win/EventSender.cpp:
938 (contextClickCallback):
939 Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
940 by a WM_RBUTTONUP message.
942 * DumpRenderTree/win/UIDelegate.cpp:
943 (UIDelegate::hasCustomMenuImplementation):
944 (UIDelegate::trackCustomPopupMenu):
945 * DumpRenderTree/win/UIDelegate.h:
946 Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
947 menu from being shown (and causing the DRT to hang).
949 2007-11-27 Maciej Stachowiak <mjs@apple.com>
953 Fix DumpRenderTree ObjC bug comparing strings.
955 * DumpRenderTree/mac/ObjCController.m:
956 (-[ObjCController identityIsEqual::]): Compare strings with string
957 equality instead of identiy equality.
959 2007-11-27 Timothy Hatcher <timothy@apple.com>
963 Reset the authorAndUserStylesEnabled preference
964 back to YES for each test. Fixes the broken tests.
966 * DumpRenderTree/mac/DumpRenderTree.mm:
967 (resetWebViewToConsistentStateBeforeTesting):
969 2007-11-27 Kevin McCullough <kmccullough@apple.com>
973 - Drosera now displays the console window, although it cannot currently
976 * Drosera/win/DebuggerClient.cpp: Shows the console window.
977 (registerConsoleClass): Implemented.
978 (consoleWndProc): Implemented.
979 (DebuggerClient::onSize): Implemented.
980 (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
982 * Drosera/win/DebuggerClient.h: Added needed method and members for
983 creating and maintaining a new window.
984 * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
985 lines of code to more appropriate places.
986 (Drosera::handleCommand):
991 2007-11-27 Timothy Hatcher <timothy@apple.com>
993 Reviewed by Dave Hyatt.
995 <rdar://problem/5569233> Add the ability to disable author and user CSS styles
997 Add support for disabling author and user styles for testing.
999 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1000 * DumpRenderTree/LayoutTestController.cpp:
1001 (setAuthorAndUserStylesEnabledCallback):
1002 (LayoutTestController::staticFunctions):
1003 * DumpRenderTree/LayoutTestController.h:
1004 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1005 (LayoutTestController::setAuthorAndUserStylesEnabled):
1006 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1007 (LayoutTestController::setAuthorAndUserStylesEnabled):
1009 2007-11-26 Dan Bernstein <mitz@apple.com>
1013 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1015 2007-11-26 Kevin McCullough <kmccullough@apple.com>
1019 - Implemented displaying variables for Drosera on Win.
1021 * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1022 that retrieve variables to not hold onto the return value since it's
1023 not returned. Also changed to use the new signatures of the retrieval
1025 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1026 (DebuggerDocument::platformValueForScopeVariableNamed):
1027 * Drosera/win/Drosera.cpp: Removed a needless TODO.
1030 2007-11-26 Sam Weinig <sam@webkit.org>
1032 Cleanup names of painting and repainting functions.
1034 Reviewed by Adam Roben.
1036 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1037 (drawSelectionRect): was drawSelectionRectIntoContext.
1038 (dumpWebViewAsPixelsAndCompareWithExpected):
1039 * DumpRenderTree/cg/PixelDumpSupportCG.h:
1040 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1041 (paintWebView): was drawWebViewIntoContext.
1042 (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1044 2007-11-26 Sam Weinig <sam@webkit.org>
1046 Reviewed by Dan Bernstein.
1050 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1052 2007-11-26 Sam Weinig <sam@webkit.org>
1054 Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1055 Use shared PixelDumpSupport for Mac DRT
1057 Reviewed by Adam Roben.
1059 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1060 * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1061 * DumpRenderTree/cg/ImageDiffCG.cpp:
1062 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1063 (drawSelectionRectIntoContext):
1064 (dumpWebViewAsPixelsAndCompareWithExpected):
1065 * DumpRenderTree/cg/PixelDumpSupportCG.h:
1066 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1067 * DumpRenderTree/mac/DumpRenderTree.mm:
1069 * DumpRenderTree/mac/ImageDiff.m: Removed.
1070 * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1071 * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1072 * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1073 (setDefaultColorProfileToRGB):
1074 (getBitmapContextFromWebView):
1075 (drawWebViewIntoContext):
1076 (repaintWithVerticalSweep):
1077 (repaintWithHorizontalSweep):
1079 * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1081 2007-11-25 David D. Kilzer <ddkilzer@webkit.org>
1083 Bug 16052: prepare-ChangeLog doesn't report deleted files
1084 <http://bugs.webkit.org/show_bug.cgi?id=16052>
1088 * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1090 2007-11-25 David Kilzer <ddkilzer@webkit.org>
1092 Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1093 <http://bugs.webkit.org/show_bug.cgi?id=15864>
1097 Roll functionality of merge-changelog into resolve-ChangeLogs
1098 script. The script now checks for ChangeLog.rej and
1099 ChangeLog.orig files first. If it finds them, it uses the
1100 ChangeLog.rej file as a patch (in old contextual diff format) to
1101 apply with --fuzz=3.
1103 * Scripts/merge-changelog: Removed.
1104 * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1106 2007-11-25 Sam Weinig <sam@webkit.org>
1108 Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1110 Reviewed by Mark Rowe.
1112 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1113 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1114 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1115 * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1116 * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1118 2007-11-25 Sam Weinig <sam@webkit.org>
1120 Convert DumpRenderTree to ues .xcconfig files.
1122 Reviewed by Mark Rowe.
1124 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1125 * DumpRenderTree/mac/Configurations: Added.
1126 * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1127 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1128 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1130 2007-11-25 Sam Weinig <sam@webkit.org>
1132 Add ForwardingHeaders to wtf for DumpRenderTree.
1134 Reviewed by Mark Rowe.
1136 * DumpRenderTree/DumpRenderTree.h:
1137 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1138 * DumpRenderTree/ForwardingHeaders: Added.
1139 * DumpRenderTree/ForwardingHeaders/wtf: Added.
1140 * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1141 * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1142 * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1143 * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1144 * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1145 * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1146 * DumpRenderTree/LayoutTestController.cpp:
1147 * DumpRenderTree/WorkQueue.cpp:
1148 * DumpRenderTree/mac/DumpRenderTree.mm:
1149 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1150 * DumpRenderTree/mac/JavaScriptThreading.cpp:
1151 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1152 * DumpRenderTree/mac/ObjCController.m:
1153 * DumpRenderTree/mac/UIDelegate.mm:
1154 * DumpRenderTree/mac/WorkQueueItemMac.mm:
1156 2007-11-25 Adam Roben <aroben@apple.com>
1158 Fix some test failures caused by r28019
1160 Now that stdout is in binary mode, we need to always use printf
1161 instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1166 * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1168 (UIDelegate::runJavaScriptAlertPanelWithMessage):
1169 (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1170 (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1171 (UIDelegate::webViewAddMessageToConsole):
1173 2007-11-25 Adam Roben <aroben@apple.com>
1175 Set the font smoothing preference in DRT
1177 This makes the pixel results on Windows closer to the Mac results.
1181 * DumpRenderTree/win/DumpRenderTree.cpp:
1182 (initializePreferences):
1184 2007-11-25 Adam Roben <aroben@apple.com>
1186 Port ImageDiff to CG and C++
1188 Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1193 * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1194 * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1196 (createImageFromStdin):
1198 (getDifferenceBitmap):
1199 (computePercentageDifferent):
1200 * DumpRenderTree/win/ImageDiff.vcproj: Added.
1202 2007-11-25 Adam Roben <aroben@apple.com>
1204 Fix image diff link generation on Windows
1208 * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1211 2007-11-25 Adam Roben <aroben@apple.com>
1213 Implement pixel dumping in Windows DRT
1215 Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1220 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1221 (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1222 Content-Length header.
1223 (getMD5HashStringForBitmap):
1224 (dumpWebViewAsPixelsAndCompareWithExpected):
1225 * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1226 * DumpRenderTree/win/DumpRenderTree.cpp:
1227 (dump): Do a pixel dump if requested.
1228 (main): Parse pixel test options.
1229 * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1230 the cg/ subdirectory to the include path.
1231 * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1232 available in a header or import library, so we have to go through this
1233 LoadLibrary/GetProcAddress dance to use them.
1241 * DumpRenderTree/win/MD5.h: Added.
1242 * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1243 moved up to the top level to share it with Mac eventually.
1244 * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1245 (getBitmapContextFromWebView): Forces the WebView to paint using a
1246 WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1248 2007-11-25 Adam Roben <aroben@apple.com>
1250 Clean up Windows DRT's option parsing a little bit
1254 * DumpRenderTree/win/DumpRenderTree.cpp:
1255 (main): Put non-option arguments into a Vector.
1257 2007-11-25 Adam Roben <aroben@apple.com>
1259 Make Windows DRT stop changing LF into CRLF
1263 * DumpRenderTree/win/DumpRenderTree.cpp:
1264 (main): Put stdout in binary mode.
1265 * Scripts/run-webkit-tests: Remove the CRLF hack.
1267 2007-11-24 David Kilzer <ddkilzer@webkit.org>
1269 Removed empty directory.
1271 * Scripts/resources: Removed.
1273 2007-11-23 David D. Kilzer <ddkilzer@webkit.org>
1275 Fix bisect-builds to work with recent WebKit nightly builds.
1279 * Scripts/bisect-builds: Check for the
1280 WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1281 it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1282 to WebKit.app/Contents/Resources.
1284 2007-11-23 Alexey Proskuryakov <ap@webkit.org>
1288 <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1289 not closed (affects digg.com)
1291 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1292 one after finishing with a test to avoid having its delayed onload handler firing when
1293 replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1294 but it helps somewhat.
1296 2007-11-22 Mark Rowe <mrowe@apple.com>
1298 Reviewed by Alp Toker.
1300 Fix build-webkit to propagate make's exit status if it fails.
1302 * Scripts/webkitdirs.pm:
1304 2007-11-22 Dan Bernstein <mitz@apple.com>
1306 Reviewed by Mark Rowe.
1308 - fix crash when running pixel tests
1310 * DumpRenderTree/mac/DumpRenderTree.mm:
1311 (dumpRenderTree): Parse the command line options before setting up the
1312 environment so that we know if we need to set up the pixel dump
1315 2007-11-21 Eric Seidel <eric@webkit.org>
1317 Speculative build fix for Tiger.
1319 * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1321 2007-11-21 Eric Seidel <eric@webkit.org>
1323 Reviewed by Tim Hatcher.
1325 Break out more of DumpRenderTree.mm into individual files
1327 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1328 * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1331 (makeLargeMallocFailSilently):
1332 * DumpRenderTree/mac/CheckedMalloc.h: Added.
1333 * DumpRenderTree/mac/DumpRenderTree.mm:
1336 * DumpRenderTree/mac/DumpRenderTreeMac.h:
1337 * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1338 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1339 * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1340 * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1341 * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1342 (javaScriptThreads):
1343 (runJavaScriptThread):
1344 (startJavaScriptThreads):
1345 (stopJavaScriptThreads):
1346 * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1347 * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1348 * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1349 (restoreColorSpace):
1350 (setDefaultColorProfileToRGB):
1351 (initializeColorSpaceAndScreeBufferForPixelTests):
1352 (md5HashStringForBitmap):
1353 (dumpWebViewAsPixelsAndCompareWithExpected):
1355 2007-11-21 Kevin Ollivier <kevino@theolliviers.com>
1357 Move install-unix-extras to wx directory as it seems only to be used by that
1358 port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
1359 Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1360 have install-unix-extras install into WebKitLibraries as per
1363 Reviewed by Mark Rowe.
1365 * Scripts/install-unix-extras: Removed.
1366 * wx/build-wxwebkit:
1367 * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1369 2007-11-21 Eric Seidel <eric@webkit.org>
1373 More refactoring for greater code readability
1375 * DumpRenderTree/mac/DumpRenderTree.mm:
1376 (initializeGlobalsFromCommandLineOptions):
1377 (initializeColorSpaceAndScreeBufferForPixelTests):
1378 (addTestPluginsToPluginSearchPath):
1379 (useLongRunningServerMode):
1380 (runTestingServerLoop):
1381 (prepareConsistentTestingEnvironment):
1385 (dumpBackForwardListForWebView):
1386 (sizeWebViewForCurrentTest):
1387 (methodNameStringForFailedTest):
1388 (dumpBackForwardListForAllWindows):
1389 (dumpWebViewAsPixelsAndCompareWithExpected):
1390 (invalidateAnyPreviousWaitToDumpWatchdog):
1392 * DumpRenderTree/mac/DumpRenderTreeMac.h:
1393 * DumpRenderTree/mac/UIDelegate.mm:
1394 (-[UIDelegate webView:createWebViewWithRequest:]):
1396 2007-11-21 Eric Seidel <eric@webkit.org>
1398 Reviewed by Tim Hatcher.
1400 Abstract more of DRT into static methods
1402 * DumpRenderTree/mac/DumpRenderTree.mm:
1403 (setDefaultsToConsistentValuesForTesting):
1404 (setupSignalHandlers):
1405 (allocateGlobalControllers):
1407 (releaseGlobalControllers):
1409 (shouldLogFrameLoadDelegates):
1410 (createCFURLFromPathOrURL):
1411 (resetWebViewToConsistentStateBeforeTesting):
1414 2007-11-21 Eric Seidel <eric@webkit.org>
1416 Reviewed by Tim Hatcher.
1418 Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1420 * DumpRenderTree/DumpRenderTree.h:
1421 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1422 * DumpRenderTree/mac/DumpRenderTree.mm:
1426 * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1427 * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1428 (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1429 (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1430 (-[DumpRenderTreePasteboard declareType:owner:]):
1431 (+[LocalPasteboard alloc]):
1432 (-[LocalPasteboard init]):
1433 (-[LocalPasteboard dealloc]):
1434 (-[LocalPasteboard name]):
1435 (-[LocalPasteboard releaseGlobally]):
1436 (-[LocalPasteboard declareTypes:owner:]):
1437 (-[LocalPasteboard addTypes:owner:]):
1438 (-[LocalPasteboard changeCount]):
1439 (-[LocalPasteboard types]):
1440 (-[LocalPasteboard availableTypeFromArray:]):
1441 (-[LocalPasteboard setData:forType:]):
1442 (-[LocalPasteboard dataForType:]):
1443 (-[LocalPasteboard setPropertyList:forType:]):
1444 (-[LocalPasteboard setString:forType:]):
1445 * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1446 * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1447 (+[DumpRenderTreeWindow allWindows]):
1448 (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1449 (-[DumpRenderTreeWindow dealloc]):
1450 (-[DumpRenderTreeWindow isKeyWindow]):
1451 (-[DumpRenderTreeWindow keyDown:]):
1453 2007-11-20 Kevin Ollivier <kevino@theolliviers.com>
1455 wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1456 it indiscriminately copies any headers inside JavaScriptCore,
1457 which includes Tiger ICU headers.
1459 * wx/build-wxwebkit:
1460 Don't run WebCore/move-js-headers.sh any longer.
1462 2007-11-20 Adam Treat <treat@kde.org>
1464 Reviewed by David Kilzer.
1466 * Prepend git branch name to $baseProductDir
1468 * Scripts/VCSUtils.pm:
1469 * Scripts/webkitdirs.pm:
1471 2007-11-20 Mark Rowe <mrowe@apple.com>
1473 Reviewed by Simon Hausmann.
1475 * Scripts/build-webkit: Pass "clean" flag down into buildQMakeProject.
1476 * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1477 Have it trigger a "make distclean" rather than "make clean" to ensure that the
1478 built product and generated Makefile's are removed.
1480 2007-11-19 Alp Toker <alp@atoker.com>
1482 Reviewed by Mark Rowe.
1484 http://bugs.webkit.org/show_bug.cgi?id=16040
1485 [GTK] GtkLauncher should be written in C
1487 Port GtkLauncher to plain C.
1489 Use a more conventional GTK+ coding style.
1491 Use a toolbar instead of menus.
1493 Various signature fixes and cleanups.
1495 Add a license header. Assume all previous modifications were copyright
1496 assigned to Apple Inc. by default.
1498 * GtkLauncher/GtkLauncher.pro:
1499 * GtkLauncher/main.c: Added.
1500 (activate_url_entry_cb):
1504 (progress_change_cb):
1513 * GtkLauncher/main.cpp: Removed.
1515 2007-11-19 Kevin Ollivier <kevino@theolliviers.com>
1517 Build script fixes to ensure they do the right thing for the
1518 wx port, and update build-wxwebkit to reflect the way the
1519 build scripts now work.
1523 * Scripts/build-testkjs:
1524 * Scripts/build-webkit:
1525 * Scripts/run-javascriptcore-tests:
1526 * Scripts/webkitdirs.pm:
1527 * wx/build-wxwebkit:
1529 2007-11-18 Eric Seidel <eric@webkit.org>
1533 Make run-javascriptcore-tests report failures on exit (to support git bisect)
1535 * Scripts/run-javascriptcore-tests:
1537 2007-11-18 Alexey Proskuryakov <ap@webkit.org>
1539 Reviewed by Adam Roben.
1541 Make run-webkit-tests work with Windows debug build.
1543 * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1544 * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1545 as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1546 symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1547 and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1549 2007-11-18 Kevin Ollivier <kevino@theolliviers.com>
1551 Add wxWebKit sample and build script, and integrate it with
1552 build-webkit. Also make build-webkit --clean work for all
1555 Reviewed by Darin Adler.
1557 * Scripts/build-webkit:
1558 * Scripts/webkitdirs.pm:
1560 * wx/browser: Added.
1561 * wx/browser/browser.bkl: Added.
1562 * wx/browser/browser.cpp: Added.
1563 * wx/build-wxwebkit: Added.
1565 2007-11-17 Adam Roben <aroben@apple.com>
1567 Make it easy to run Safari in the debugger on Windows
1569 I've added a new script, debug-safari, which launches Safari in the
1570 debugger. On OS X it just calls gdb-safari.
1572 Reviewed by Mark Rowe.
1574 * FindSafari/FindSafari.cpp:
1575 (_tmain): Added a /debugger flag, which in combination with
1576 /printSafariLauncher will print a script that launches Safari in the
1578 * Scripts/debug-safari: Added.
1579 * Scripts/run-safari: Changed to call runSafari().
1580 * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1581 vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1582 first argument along to FindSafari.
1583 * Scripts/webkitdirs.pm:
1584 (sub runSafari): Added.
1586 2007-11-16 Alexey Proskuryakov <ap@webkit.org>
1588 Reviewed by Adam Roben.
1590 * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
1592 2007-11-16 Ryan Leavengood <leavengood@gmail.com>
1594 Reviewed by David Kilzer.
1596 The git config command was renamed to repo-config at some point. This
1597 change tries git config and then git repo-config if the first fails.
1599 * Scripts/prepare-ChangeLog:
1602 2007-11-16 Dan Bernstein <mitz@apple.com>
1604 Reviewed by Darin Adler and Sam Weinig.
1606 - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1608 * DumpRenderTree/win/EventSender.cpp:
1609 (keyDownCallback): For characters that cannot be entered on the active
1610 keyboard layout, send a WM_CHAR message with the character along with
1611 a WM_KEYDOWN message with a virtual key code of 255.
1613 2007-11-16 Mark Rowe <mrowe@apple.com>
1615 Reviewed by Tim Hatcher.
1617 Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1619 * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1620 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1622 2007-11-15 Adam Roben <aroben@apple.com>
1624 Make run-safari actually work on Windows
1626 * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1629 2007-11-14 Adam Roben <aroben@apple.com>
1631 Updates to Safari launching now that 3.0.4 is released
1635 * FindSafari/FindSafari.cpp:
1636 (getWebViewCLSID): Use version-independent ProgID.
1637 * Scripts/run-safari: Use run-webkit-nightly.cmd.
1639 2007-11-14 Anders Carlsson <andersca@apple.com>
1643 <rdar://problem/5309081>
1644 In DRT, "plugin.logDestroy = true" not working on Windows.
1646 * DumpRenderTree/win/TestNetscapePlugin/main.c:
1649 2007-11-14 Eric Seidel <eric@webkit.org>
1653 * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1655 2007-11-14 Anders Carlsson <andersca@apple.com>
1659 <rdar://problem/5141186>
1660 window.layoutTestController.setWindowIsKey is not implemented in DRT.
1662 Implement setWindowIsKey.
1664 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1665 (LayoutTestController::setWindowIsKey):
1667 2007-11-13 Sam Weinig <sam@webkit.org>
1669 Reviewed by Adam Roben.
1671 Fix for <rdar://problem/5382579>
1672 http/tests/security/cross-frame-access-put.html reports large
1673 negative numbers for screenLeft and screenTop (Mac reports "0")
1675 * DumpRenderTree/win/UIDelegate.cpp:
1676 (UIDelegate::UIDelegate): Initialize the RECT.
1677 (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1678 (UIDelegate::webViewFrame): ditto.
1679 * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1681 2007-11-13 Kevin McCullough <kmccullough@apple.com>
1685 - Make Drosera show source, source URLs, and function stack on Windows,
1686 and some minor fixes.
1688 * Drosera/DebuggerDocument.cpp: Force source to always update display.
1689 (DebuggerDocument::updateFileSource):
1690 * Drosera/debugger.js: Force source to always update display.
1691 * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1693 (DebuggerClient::resume):
1694 (DebuggerClient::pause):
1695 (DebuggerClient::stepInto):
1696 (DebuggerClient::stepOver):
1697 (DebuggerClient::stepOut):
1698 (DebuggerClient::showConsole):
1699 (DebuggerClient::closeCurrentFile):
1700 * Drosera/win/DebuggerClient.h: Ditto.
1701 * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1702 getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1703 removed two bugs. 1) caller could be in a bad state when asked to
1704 assign into it. 2) BSTRs were not created correctly.
1705 (DebuggerDocument::getPlatformCurrentFunctionStack):
1706 * Drosera/win/Drosera.cpp: Hook up the menu controls.
1711 (Drosera::stepInto):
1712 (Drosera::stepOver):
1714 (Drosera::showConsole):
1715 (Drosera::closeCurrentFile):
1716 * Drosera/win/Drosera.h: Hook up the menu controls.
1717 * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1718 functions, added a null check, and fixed another bug where caller could
1719 be in a bad state when asked to assign into it.
1720 (ServerConnection::didLoadMainResourceForDataSource):
1721 (ServerConnection::getCallerFrame):
1722 * Drosera/win/ServerConnection.h: Safety first.
1724 2007-11-13 Dan Bernstein <mitz@apple.com>
1726 Reviewed by Darin Adler.
1728 - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1729 DumpRenderTree --pixel-tests renders each test twice
1731 * DumpRenderTree/mac/DumpRenderTree.mm:
1732 (dumpRenderTree): Removed the --paint option because the painting code
1733 is always exercised as a result of
1734 -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1735 calling -displayIfNeeded.
1736 (dump): Changed to always grab the image from the window since the view
1737 is always displayed.
1740 * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1741 because it always paints.
1743 2007-11-12 Antti Koivisto <antti@apple.com>
1747 Add support for http media tests
1749 * Scripts/run-webkit-tests:
1751 2007-11-12 Sam Weinig <sam@webkit.org>
1753 Reviewed by Adam Roben.
1755 Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1757 * DumpRenderTree/win/DumpRenderTree.cpp:
1759 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1760 (LayoutTestController::setPrivateBrowsingEnabled):
1762 2007-11-12 Adam Roben <aroben@apple.com>
1764 * Scripts/update-webkit-localizable-strings: Changed to only scan the
1765 mac and win subdirectories.
1767 2007-11-11 Adam Roben <aroben@apple.com>
1769 Fix <rdar://5133816> keepWebHistory is not implemented
1771 Fixes fast/history/clicked-link-is-visited.html.
1775 * DumpRenderTree/win/DumpRenderTree.cpp:
1776 (runTest): Clear the optionalSharedHistory.
1777 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1778 (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1780 2007-11-10 Sam Weinig <sam@webkit.org>
1782 Reviewed by Tim Hatcher.
1784 Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
1785 attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
1788 - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1790 Added test: http/tests/security/cross-frame-access-private-browsing.html
1792 * DumpRenderTree/LayoutTestController.cpp:
1793 (setPrivateBrowsingEnabledCallback):
1794 (LayoutTestController::staticFunctions):
1795 * DumpRenderTree/LayoutTestController.h:
1796 * DumpRenderTree/mac/DumpRenderTree.mm:
1797 (runTest): Default to private browsing disabled.
1798 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1799 (LayoutTestController::setPrivateBrowsingEnabled):
1800 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1801 (LayoutTestController::setPrivateBrowsingEnabled):
1803 2007-11-08 Kevin McCullough <kmccullough@apple.com>
1807 - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1810 * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1811 * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1812 * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1813 * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1814 * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1815 * Drosera/win/Drosera.cpp:
1816 * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1818 2007-11-08 Kevin McCullough <kmccullough@apple.com>
1822 - Use the new IWebFrame [local] function signature and get the shared
1825 * Drosera/win/DebuggerClient.cpp:
1826 (DebuggerClient::didFinishLoadForFrame):
1827 * Drosera/win/ServerConnection.cpp:
1828 (ServerConnection::attemptToCreateServerConnection):
1830 2007-11-07 Dan Bernstein <mitz@apple.com>
1832 Reviewed by Darin Adler.
1834 - add an option to run-webkit-tests to ignore pixel test failures where
1835 all pixels differ by no more than a specified threshold
1837 * DumpRenderTree/mac/ImageDiff.m:
1840 (computePercentageDifferent):
1841 * Scripts/run-webkit-tests:
1843 2007-11-07 Simon Hausmann <hausmann@kde.org>
1847 Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1849 * DumpRenderTree/qt/DumpRenderTree.cpp:
1851 2007-11-07 Simon Hausmann <hausmann@kde.org>
1855 Reworked the QWebSettings API.
1856 QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1858 * DumpRenderTree/qt/DumpRenderTree.cpp:
1860 2007-11-07 Simon Hausmann <hausmann@kde.org>
1864 Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1866 * DumpRenderTree/qt/jsobjects.cpp:
1868 2007-11-07 Simon Hausmann <hausmann@kde.org>
1870 Reviewed by Lars Knoll <lars@trolltech.com>.
1872 Add a QWebPage::frameCreated() signal and fix DRT
1874 The removal of createFrame in QWebPage broke the re-implementation
1875 in DumpRenderTree. Instead emit a frameCreated() signal and
1876 connect to it in DumpRenderTree.
1879 * DumpRenderTree/qt/DumpRenderTree.cpp:
1880 (WebCore::WebPage::WebPage):
1881 (WebCore::DumpRenderTree::dump):
1882 (WebCore::DumpRenderTree::connectFrame):
1883 * DumpRenderTree/qt/DumpRenderTree.h:
1885 2007-11-07 Simon Hausmann <hausmann@kde.org>
1887 Reviewed by Lars Knoll <lars@trolltech.com>.
1889 Moved all the event handlers from QWebFrame into QWebPage.
1891 This cleans up the public API and allows us to remove the
1892 HackWebFrame hack in DumpRenderTree.
1895 * DumpRenderTree/qt/jsobjects.cpp:
1896 (EventSender::mouseDown):
1897 (EventSender::mouseUp):
1898 (EventSender::mouseMoveTo):
1900 2007-11-07 Simon Hausmann <hausmann@kde.org>
1904 Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1905 to prevent the default implementation from popping up messageboxes.
1907 * DumpRenderTree/qt/DumpRenderTree.cpp:
1908 (WebCore::WebPage::javaScriptConfirm):
1909 (WebCore::WebPage::javaScriptPrompt):
1911 2007-11-06 Eric Seidel <eric@webkit.org>
1913 * Scripts/build-testkjs: build fix... too many $$
1915 2007-11-06 Eric Seidel <eric@webkit.org>
1917 Reviewed by Mark Rowe.
1919 * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1921 2007-11-05 Adam Roben <aroben@apple.com>
1923 Add support on Windows for WEBKIT_TESTFONTS
1925 This environment variable lets you specify where the fonts to be used
1926 by DumpRenderTree reside. The Qt port is already using this, so I'm
1927 just following their lead.
1931 * DumpRenderTree/win/DumpRenderTree.cpp:
1932 (exePath): Refactored code out of initialize().
1933 (fontsPath): Returns either $WEBKIT_TESTFONTS or
1934 DumpRenderTree.resources.
1935 (initialize): Use the new fontsPath function.
1936 (main): Use the new exePath function.
1937 * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1938 variable to DRT, like Qt does.
1940 2007-11-05 Mark Rowe <mrowe@apple.com>
1942 Rubber-stamped by Alp Toker.
1944 Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1946 * GtkLauncher/main.cpp:
1950 2007-11-04 David D. Kilzer <ddkilzer@webkit.org>
1952 bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1953 <http://bugs.webkit.org/show_bug.cgi?id=15830>
1955 Reviewed by Timothy.
1957 Restrict the range of nightly builds used by the bisect-builds script
1958 based on the version of Safari and the version of Mac OS X being used.
1960 Mac OS X 10.4: Safari 2.0: r11976 or newer
1961 Mac OS X 10.4: Safari 3.0: r19992 or newer
1963 Mac OS X 10.5: Safari 2.0: r19594 or newer
1964 Mac OS X 10.5: Safari 3.0: r25124 or newer
1966 * Scripts/bisect-builds:
1967 (findMacOSXVersion): Added.
1968 (makeNightlyList): Added argument to provide version of Mac OS X.
1969 Restrict range of nightly builds based on Safari and Mac OS X versions.
1971 2007-11-04 Kevin McCullough <kmccullough@apple.com>
1975 - This patch involves several changes, all of them were noticed that
1976 they were needed by the work being done in WebKit to get Drosera and
1977 WebKit working together on Windows.
1979 1) Added a debugger console for output messages.
1980 2) Drosera now listens for the WebKit server (before, the server would
1981 have to be running before Drosera was started.)
1982 3) Fixed a bug where the WebView started out as 0x0 pixels.
1983 4) Fixed a bug when there is no scope.
1984 5) Added the HTML, JS, and CSS to the project file to make them easy to
1986 6) Made the ServerConnection functions virtual.
1988 * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1989 for the WebKit server.
1990 (DebuggerClient::DebuggerClient):
1991 (DebuggerClient::~DebuggerClient):
1992 (DebuggerClient::didFinishLoadForFrame):
1993 (DebuggerClient::serverConnected):
1994 (DebuggerClient::attemptToCreateServerConnection):
1995 * Drosera/win/DebuggerClient.h: Ditto.
1996 * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1998 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1999 (DebuggerDocument::platformValueForScopeVariableNamed):
2000 * Drosera/win/Drosera.cpp:
2001 (_tWinMain): Added a console in debug for output messages.
2002 (Drosera::Drosera): Listen for server.
2003 (Drosera::initUI): The server now Initializes COM.
2004 (Drosera::serverConnected): Part of the listening for the server.
2005 (Drosera::attemptToCreateServerConnection): Ditto.
2006 * Drosera/win/Drosera.h: New interface for listening for the server.
2007 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2008 files to the VS project.
2009 * Drosera/win/ServerConnection.cpp: Part of listening for the server
2011 (ServerConnection::ServerConnection):
2012 (ServerConnection::attemptToCreateServerConnection):
2013 * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2015 (ServerConnection::serverConnected):
2017 2007-11-04 Alexey Proskuryakov <ap@webkit.org>
2021 http://bugs.webkit.org/show_bug.cgi?id=15832
2022 fast/dom/gc-10.html crashes when run alone
2024 Check for !done before using objects that can be already deallocated.
2026 * DumpRenderTree/mac/EditingDelegate.mm:
2027 (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2028 (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2029 (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2030 (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2031 (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2032 (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2033 (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2034 (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2035 (-[EditingDelegate webViewDidBeginEditing:]):
2036 (-[EditingDelegate webViewDidChange:]):
2037 (-[EditingDelegate webViewDidEndEditing:]):
2038 (-[EditingDelegate webViewDidChangeTypingStyle:]):
2039 (-[EditingDelegate webViewDidChangeSelection:]):
2040 * DumpRenderTree/mac/FrameLoadDelegate.mm:
2041 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2042 (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2043 (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2044 (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2045 (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2046 (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2047 (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2048 (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2049 (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2050 (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2051 (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2052 (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2053 (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2054 (-[FrameLoadDelegate webView:willCloseFrame:]):
2055 (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2056 (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2057 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2058 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2059 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2060 (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2061 (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2062 (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2063 (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2065 2007-11-04 Mark Rowe <mrowe@apple.com>
2067 Build fix. Don't use Carbon.h as the prefix header as it triggers
2068 warnings that would otherwise be suppressed due to it being a system header.
2070 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2072 2007-11-03 Maciej Stachowiak <mjs@apple.com>
2074 Rubber stamped by Adam.
2076 - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2078 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2080 2007-11-03 David D. Kilzer <ddkilzer@webkit.org>
2082 Sort files(...); sections of Xcode project files.
2084 Rubber-stamped by Darin.
2086 * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2087 * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2088 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2089 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2091 2007-11-03 David D. Kilzer <ddkilzer@webkit.org>
2093 Script to sort "files(...);" sections in Xcode project.pbxproj files.
2097 * Scripts/sort-Xcode-project-file: Added.
2099 2007-11-02 Darin Adler <darin@apple.com>
2101 * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2103 2007-11-02 Darin Adler <darin@apple.com>
2107 * Scripts/run-sunspider: Pass the "--base" option through.
2109 * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2110 the real script do that. Default configuration to Release to match run-sunspider
2111 so we don't end up building Debug just to compare results.
2113 2007-11-01 Adam Roben <aroben@apple.com>
2115 Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2119 * Scripts/commit-log-editor: Show all the directories beneath the
2120 source root, instead of just the last one.
2122 2007-11-01 Kevin Ollivier <kevino@theolliviers.com>
2124 Reviewed by Adam Roben.
2126 Print out an error message when the Windows build fails
2127 and provide guidance on how to find out what went wrong.
2129 * Scripts/build-webkit:
2130 * Scripts/webkitdirs.pm:
2132 2007-11-01 Alexey Proskuryakov <ap@webkit.org>
2134 Rubber-stamped by Adam Roben.
2136 Rolled out r27326 - debug CRT seems to cause no problems after all.
2138 * DumpRenderTree/win/DumpRenderTree.vcproj:
2140 2007-10-31 Adam Roben <aroben@apple.com>
2142 Switch the Debug configuration to using the non-debug CRT
2144 This matches WebKit.
2148 * DumpRenderTree/win/DumpRenderTree.vcproj:
2150 2007-10-31 Antti Koivisto <antti@apple.com>
2154 Disable media tests when doing leak checking on Tiger.
2155 They crash in QuickTime (rdar://problem/5537157).
2157 * Scripts/run-webkit-tests:
2159 2007-10-29 Antti Koivisto <antti@apple.com>
2163 Build media support by default on OSX only.
2165 * Scripts/build-webkit:
2167 2007-10-30 Kevin McCullough <kmccullough@apple.com>
2169 - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2170 get caught by the pre-commit hooks.
2172 2007-10-30 Kevin McCullough <kmccullough@apple.com>
2176 - This is a collection of relatively unrelated changes and cleanups
2177 to Drosera to prepare it for interacting with WebKit. A lot of these
2178 changes are just correcting mistakes, for example removing included
2179 headers that are no longer needed.
2181 * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2182 this will be needed by the DebuggerClient.
2183 (DebuggerDocument::server):
2184 * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2185 * Drosera/win/DebuggerClient.cpp:
2186 (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2187 (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2188 (DebuggerClient::createWebViewWithRequest): Added comment about its
2190 * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2192 (DebuggerClient::webViewLoaded): Moved.
2193 * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2194 file, since this was the only place it was used.
2196 * Drosera/win/Drosera.h: Cleaned up the includes.
2197 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2198 * Drosera/win/HelperFunctions.h: Removed.
2200 2007-10-30 Kevin McCullough <kmccullough@apple.com>
2204 - Small cleanup in the ServerConnection class.
2206 * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2207 and added an include.
2208 (ServerConnection::currentFrame):
2209 (ServerConnection::getCallerFrame):
2210 * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2211 made a pointer into a COMPtr, and cleaned up the includes.
2213 2007-10-29 Timothy Hatcher <timothy@apple.com>
2215 Reviewed by John Sullivan.
2217 - Place the Localizable.strings file in mac or win directories
2218 if that location exists.
2219 - Also look for UI_STRING in .c files.
2221 * Scripts/extract-localizable-strings:
2223 2007-10-30 Kevin McCullough <kmccullough@apple.com>
2227 - Set the eol-style to native and made all the line endings the same
2228 so that I avoid messy diffs that show eol changes.
2230 * Drosera/win/ServerConnection.cpp:
2231 (ServerConnection::didParseSource):
2232 (ServerConnection::didEnterCallFrame):
2233 (ServerConnection::willExecuteStatement):
2234 (ServerConnection::willLeaveCallFrame):
2235 (ServerConnection::exceptionWasRaised):
2237 2007-10-30 Kevin McCullough <kmccullough@apple.com>
2241 * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2242 functionality that could not have existed previously without the new
2244 (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2245 from a BSTR to a JSValueRef.
2246 (DebuggerDocument::platformEvaluateScript): Implemented.
2247 (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2248 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2250 (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2251 * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2252 * Drosera/win/ServerConnection.cpp: Added a helper function.
2253 (ServerConnection::getCallerFrame):
2254 * Drosera/win/ServerConnection.h: Added a helper function.
2256 2007-10-29 Kevin McCullough <kmccullough@apple.com>
2258 updated reviewers for my previous changelog.
2260 2007-10-29 Kevin McCullough <kmccullough@apple.com>
2261 Reviewed by Maciej and Adam and Geoff.
2263 - Minor mac-side improvements including moving a function to a more
2264 appropriate location, fixing a warning, and correctly checking
2267 * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2268 (DebuggerDocument::willExecuteStatement):
2269 (DebuggerDocument::didEnterCallFrame):
2270 (DebuggerDocument::willLeaveCallFrame):
2271 (DebuggerDocument::windowScriptObjectAvailable):
2272 (DebuggerDocument::callFunctionOnObject):
2273 * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2274 * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2275 webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2276 because it doesn't require the ServerConnection at all.
2277 (NSStringCreateWithJSStringRef): Made an argument const.
2278 (JSValueRefCreateWithNSString): Made an argument const.
2279 (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2280 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2281 * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2282 * Drosera/mac/ServerConnection.mm: Ditto.
2283 (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2285 2007-10-29 Sam Weinig <sam@webkit.org>
2287 Reviewed by Adam Roben.
2289 Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2291 * DumpRenderTree/LayoutTestController.cpp:
2292 (LayoutTestController::LayoutTestController):
2293 (getGlobalFlagCallback):
2294 (setGlobalFlagCallback):
2295 (LayoutTestController::getJSClass):
2296 (LayoutTestController::staticValues):
2297 * DumpRenderTree/LayoutTestController.h:
2298 (LayoutTestController::globalFlag):
2299 (LayoutTestController::setGlobalFlag):
2301 2007-10-29 Darin Adler <darin@apple.com>
2305 * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2306 resolution instead of its default.
2308 2007-10-29 David Kilzer <ddkilzer@webkit.org>
2310 Fixed showStatus() to print status for successfully resolved conflicts when using git.
2312 Reviewed by Mark Rowe.
2314 Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2315 was successfully resolved, but this would not show any status because the change had
2316 already been cached in the index using "git add". The solution is to add an optional
2317 second argument to showStatus() which adds the "--cached" switch to the command.
2319 * Scripts/resolve-ChangeLogs:
2322 2007-10-28 Eric Seidel <eric@webkit.org>
2324 Reviewed by Maciej and Geoff, in unison.
2326 * Scripts/run-webkit-tests: remove broken --svg option
2328 2007-10-28 Darin Adler <darin@apple.com>
2332 * Scripts/run-sunspider: Default to "Release" configuration rather than
2333 defaulting to the last configuration used as other scripts do. This can
2334 still be overriden on the command line with "--debug" if there's some
2335 reason to do so. Also fix a typo.
2337 * Scripts/sunspider-compare-results: Fix a typo.
2339 2007-10-26 Kevin McCullough <kmccullough@apple.com>
2343 - Implemented the WebScriptDebugListener functions now that the
2344 WebScriptDebugServer exists
2346 * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2348 (ServerConnection::currentFrame):
2349 (ServerConnection::didLoadMainResourceForDataSource):
2350 (ServerConnection::didParseSource):
2351 (ServerConnection::failedToParseSource):
2352 (ServerConnection::didEnterCallFrame):
2353 (ServerConnection::willExecuteStatement):
2354 (ServerConnection::willLeaveCallFrame):
2355 (ServerConnection::exceptionWasRaised):
2356 * Drosera/win/ServerConnection.h: Removed unused arguments from the
2357 members arguments list.
2359 2007-10-26 David Kilzer <ddkilzer@webkit.org>
2361 prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2362 <http://bugs.webkit.org/show_bug.cgi?id=15600>
2366 The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2367 a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2368 If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2369 file. Note that it may also be used as a stand-alone script.
2371 * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2372 * Scripts/resolve-ChangeLogs: Added.
2373 * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2375 2007-10-26 Mark Rowe <mrowe@apple.com>
2377 Qt build fix. r27084 added a destructor implementation for LayoutTestController
2378 to the Qt port on the assumption that it was an implementation of the cross-platform
2379 LayoutTestController class. It is not, so it did not need to be changed.
2381 * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2383 2007-10-25 Mark Rowe <mrowe@apple.com>
2387 Fix builds with code coverage enabled.
2389 * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2391 2007-10-25 Darin Adler <darin@apple.com>
2393 Reviewed by Mark Rowe.
2395 * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2396 * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2398 2007-10-25 Stephanie <slewis@apple.com>
2402 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2404 2007-10-25 Stephanie <slewis@apple.com>
2406 Reviewed by Mark Rowe, Adam Roben.
2408 Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2410 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2412 2007-10-25 Alice Liu <alice.liu@apple.com>
2416 Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2418 Moving destructor into platform-specific files
2419 * DumpRenderTree/LayoutTestController.cpp:
2420 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2421 (LayoutTestController::~LayoutTestController):
2422 * DumpRenderTree/qt/jsobjects.cpp:
2423 (LayoutTestController::~LayoutTestController):
2425 LayoutTestController wasn't being destroyed
2426 * DumpRenderTree/win/DumpRenderTree.cpp:
2430 * DumpRenderTree/win/EditingDelegate.h:
2432 Reset certain values on the webview (or related delegate) that might
2433 have changed while running a test
2434 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2435 (LayoutTestController::~LayoutTestController):
2437 2007-10-25 Adam Roben <aroben@apple.com>
2439 Make sunspider-compare-results work with relative paths
2443 * Scripts/sunspider-compare-results: Convert arguments to absolute
2444 paths before we chdir.
2446 2007-10-25 Kevin McCullough <kmccullough@apple.com>
2450 - Implemented server calls now the WebScriptDebugServer exists.
2451 - Also removed no longer needed call to initialize CG.
2453 * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2456 * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2457 (ServerConnection::ServerConnection):
2458 (ServerConnection::~ServerConnection):
2459 (ServerConnection::pause):
2460 (ServerConnection::resume):
2461 (ServerConnection::stepInto):
2462 (ServerConnection::applicationTerminating):
2463 (ServerConnection::serverConnectionDidDie):
2464 * Drosera/win/ServerConnection.h: Now uses the COM class.
2466 2007-10-24 George Staikos <staikos@kde.org>
2470 * Scripts/build-webkit:
2472 2007-10-24 Adam Roben <aroben@apple.com>
2474 Remove now-unnecessary call to InitializeCoreGraphics
2476 WebKit takes care of this now.
2480 * DumpRenderTree/win/DumpRenderTree.cpp:
2483 2007-10-24 Adam Roben <aroben@apple.com>
2485 Use WebTextRenderer in DRT
2489 * DumpRenderTree/win/DumpRenderTree.cpp:
2490 (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2492 2007-10-24 Sven Herzberg <sven@imendio.com>
2494 Reviewed by Mark Rowe.
2496 Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2497 Bug 15614: [GTK] qmake based backends don't build on OS X
2499 * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2500 GTK backend on a Mac
2501 * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2502 isDarwin() to make it reusable in other places (like the workaround-
2503 for-prebuilt-qmake in build-webkit)
2505 2007-10-24 David Kilzer <ddkilzer@webkit.org>
2507 Refurbish update-webkit script.
2511 * Scripts/update-webkit: Add -h|--help switch and usage statement. Check result of
2512 GetOptions() call. Fix -q|--quiet switch to be passed to svn command properly. Use
2513 multi-argument version of system() for flexibility and security. Check for existence
2514 of Internal directory using -d test instead of -x.
2516 2007-10-24 David Kilzer <ddkilzer@webkit.org>
2518 Minor clean-up of prepare-ChangeLog script.
2522 * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2523 of a string. Use multi-argument versions of open() and system() for flexibility and
2526 2007-10-24 Alice Liu <alice.liu@apple.com>
2530 Fix <rdar://5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2532 Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
2533 replay the saved events when we're still processing the mousedown that starts the drag
2534 * DumpRenderTree/win/EventSender.cpp:
2536 * DumpRenderTree/win/UIDelegate.cpp:
2537 (UIDelegate::doDragDrop):
2539 2007-10-24 Kevin McCullough <kmccullough@apple.com>
2541 Reviewed by Sam, Steve and Darin.
2543 - Stubbed out the WebScriptDebugListener functionality in the Server
2544 Connection class to prepare it for receiving those callbacks.
2545 - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2546 and the ServerConnection to not need to be initialized with a server
2547 name, since that is not the way we connect to the WebKit server.
2549 * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2550 no exception. Now it only loggs when there is an exception
2551 (DebuggerDocument::willExecuteStatement):
2552 (DebuggerDocument::didEnterCallFrame):
2553 (DebuggerDocument::willLeaveCallFrame):
2554 (DebuggerDocument::windowScriptObjectAvailable):
2555 (DebuggerDocument::callFunctionOnObject):
2556 * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2557 to be instantiated with a server's name.
2558 (DebuggerClient::DebuggerClient):
2559 (DebuggerClient::didFinishLoadForFrame):
2560 * Drosera/win/DebuggerClient.h: Removed unsued variable.
2561 * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2564 (Drosera::initServer):
2565 * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2566 instantiated with a server's name.
2567 * Drosera/win/ServerConnection.cpp:
2568 (ServerConnection::ServerConnection): No longer needs a server name
2569 (ServerConnection::~ServerConnection): Only release the global context
2571 (ServerConnection::serverConnectionDidDie): Stub for
2572 IWebScriptDebugListener
2573 (ServerConnection::QueryInterface): ditto
2574 (ServerConnection::AddRef): ditto
2575 (ServerConnection::Release): ditto
2576 (ServerConnection::didLoadMainResourceForDataSource): ditto
2577 (ServerConnection::didParseSource): ditto
2578 (ServerConnection::failedToParseSource): ditto
2579 (ServerConnection::didEnterCallFrame): ditto
2580 (ServerConnection::willExecuteStatement): ditto
2581 (ServerConnection::willLeaveCallFrame): ditto
2582 (ServerConnection::exceptionWasRaised): ditto
2583 * Drosera/win/ServerConnection.h: Stubbed out the
2584 IWebScriptDebugListener functions, and this class no longer needs to be
2585 instantiated with a server name.
2587 2007-10-24 Lars Knoll <lars@trolltech.com>
2591 add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2593 * DumpRenderTree/qt/jsobjects.h:
2595 2007-10-24 Lars Knoll <lars@trolltech.com>
2599 add another command.
2601 * DumpRenderTree/qt/jsobjects.cpp:
2602 (TextInputController::doCommand):
2604 2007-10-24 Lars Knoll <lars@trolltech.com>
2608 add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2610 * DumpRenderTree/qt/jsobjects.cpp:
2611 (EventSender::keyDown):
2612 * DumpRenderTree/qt/jsobjects.h:
2614 2007-10-24 Lars Knoll <lars@trolltech.com>
2618 implement eventSender.keyDown().
2620 * DumpRenderTree/qt/jsobjects.cpp:
2621 (EventSender::keyDown):
2623 2007-10-24 Lars Knoll <lars@trolltech.com>
2627 some smaller fixes to the editing support in DRT. Makes another few tests pass.
2629 * DumpRenderTree/qt/DumpRenderTree.cpp:
2630 (WebCore::DumpRenderTree::DumpRenderTree):
2631 (WebCore::DumpRenderTree::initJSObjects):
2632 * DumpRenderTree/qt/jsobjects.cpp:
2633 (TextInputController::doCommand):
2635 2007-10-24 Lars Knoll <lars@trolltech.com>
2639 first bit of implementation for the textinputcontroller.
2641 * DumpRenderTree/qt/DumpRenderTree.cpp:
2642 (WebCore::DumpRenderTree::DumpRenderTree):
2643 * DumpRenderTree/qt/DumpRenderTree.h:
2644 * DumpRenderTree/qt/jsobjects.cpp:
2645 (TextInputController::TextInputController):
2646 (TextInputController::doCommand):
2647 * DumpRenderTree/qt/jsobjects.h:
2649 2007-10-24 Lars Knoll <lars@trolltech.com>
2653 make the man webpage believe it has focus, so the editing tests work correctly.
2655 * DumpRenderTree/qt/DumpRenderTree.cpp:
2656 (WebCore::DumpRenderTree::DumpRenderTree):
2658 2007-10-24 Lars Knoll <lars@trolltech.com>
2662 implement layoutTestController.dumpEditingCallbacks() correctly.
2664 * DumpRenderTree/qt/DumpRenderTree.cpp:
2665 (WebCore::DumpRenderTree::DumpRenderTree):
2666 * DumpRenderTree/qt/jsobjects.cpp:
2667 (LayoutTestController::reset):
2668 (LayoutTestController::dumpEditingCallbacks):
2670 2007-10-24 Lars Knoll <lars@trolltech.com>
2674 Implement support for testing editing.
2676 * DumpRenderTree/qt/DumpRenderTree.cpp:
2677 (WebCore::DumpRenderTree::DumpRenderTree):
2679 2007-10-23 Sam Weinig <sam@webkit.org>
2681 Check for null BSTR that can be passed to the UIDelegate methods
2682 from javascript null and undefined. Fixes a failing test case on
2683 Windows (fast/dom/Window/alert-undefined.html)
2685 Reviewed by Eric Seidel.
2687 * DumpRenderTree/win/UIDelegate.cpp:
2688 (UIDelegate::runJavaScriptAlertPanelWithMessage):
2689 (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2690 (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2691 (UIDelegate::webViewAddMessageToConsole):
2693 2007-10-23 Maciej Stachowiak <mjs@apple.com>
2697 Don't print a massive pile of setenvs from tools that automatically build testkjs.
2699 * Scripts/build-testkjs:
2701 2007-10-23 Maciej Stachowiak <mjs@apple.com>
2705 - add wrapper that finds the right copy of testkjs
2707 * Scripts/sunspider-compare-results: Added.
2709 2007-10-23 Kevin McCullough <kmccullough@apple.com>
2713 - After talking with Steve I now see that the WebKit server must be
2714 running for DCOM to create the distributed objects, which makes sense
2715 and currently WebKit only allows one instance to be running at a time
2716 which avoids accidentally connecting to the wrong server
2717 - In light of this I have removed the code for the attach box and
2718 NotificationServer and known server names, since they are all extranious
2721 * Drosera/win/Drosera.cpp: Removed notification classes and known server
2723 (_tWinMain): Uses init instead of initUI.
2724 (droseraWndProc): No longer creats an attach dialog box.
2725 (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2726 it's not manditory to call init before doing COM stuff.
2727 (Drosera::init): calls initUI and will call attach when the
2728 functionality exists.
2729 (Drosera::initUI): Has changed very little.
2730 (Drosera::attach): Changed the signature to reflect that we no longer
2731 need the dictionary of known server names.
2732 * Drosera/win/Drosera.h: Removed notification classes and known server
2733 names. Also renamed and moved some functions.
2734 * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2735 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2736 headers to the resources folder.
2737 * Drosera/win/resource.h: Removed the Attach box.
2739 2007-10-22 Adam Roben <aroben@apple.com>
2743 * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2745 2007-10-22 Kevin McCullough <kmccullough@apple.com>
2747 - Removed a leak that was fixed.
2749 * Scripts/run-webkit-tests:
2751 2007-10-19 Kevin McCullough <kmccullough@apple.com>
2755 - Changed the Client so that the DebuggerDocument now own the
2756 ServerConnection. This simplifies ownership and cleanup.
2758 * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2760 (DebuggerClient::initWithServerName):
2761 (DebuggerClient::didFinishLoadForFrame):
2762 * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
2764 * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2765 until after we have a server which we are attached to.
2768 * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2771 2007-10-22 Simon Hausmann <hausmann@kde.org>
2773 Reviewed by Nikolas.
2775 When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2777 * Scripts/run-javascriptcore-tests:
2779 2007-10-22 Simon Hausmann <hausmann@kde.org>
2781 Reviewed by Nikolas.
2783 Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2785 * Scripts/build-drosera:
2786 * Scripts/build-dumprendertree:
2787 * Scripts/build-testkjs:
2788 * Scripts/build-webkit:
2789 * Scripts/run-javascriptcore-tests:
2790 * Scripts/run-sunspider:
2791 * Scripts/run-webkit-tests:
2792 * Scripts/webkitdirs.pm:
2794 2007-10-22 Andrew Wellington <proton@wiretapped.net>
2796 Reviewed by Mark Rowe.
2798 Fix for local database support after r26879
2799 Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2801 * Scripts/build-webkit:
2803 2007-10-22 Holger Freyther <zecke@selfish.org>
2805 Reviewed by Simon Hausmann <hausmann@kde.org>.
2807 - Do not build testkjs as an application bundle. This is
2808 needed for run-javascriptcore-tests on OSX.
2809 - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2810 - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2811 as we do not have -rpath on OSX.
2813 * DumpRenderTree/qt/DumpRenderTree.pro:
2814 * Scripts/run-webkit-tests:
2816 2007-10-22 Simon Hausmann <hausmann@kde.org>
2820 Fix support for Signed-off-by detection in prepare-ChangeLog
2821 --git-commit. The Signed-off-by tag does not appear in the header
2822 but usually at the end.
2824 * Scripts/prepare-ChangeLog:
2826 2007-10-21 Mark Rowe <mrowe@apple.com>
2830 Fix run-javascriptcore-tests for Gtk.
2832 * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2834 2007-10-20 Eric Seidel <eric@webkit.org>
2838 * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2840 2007-10-20 Eric Seidel <eric@webkit.org>
2844 Add improved argument handling to run-sunspider, including
2845 --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2846 Also re-factor code into subroutines
2848 * Scripts/build-dumprendertree: removed bogus comments
2849 * Scripts/build-testkjs: Added.
2850 * Scripts/run-javascriptcore-tests: use build-testkjs
2851 * Scripts/run-sunspider: improved argument handling, abstraction
2852 * Scripts/run-webkit-tests: improved abstraction
2854 2007-10-20 Matt Lilek <webkit@mattlilek.com>
2856 Not reviewed, Windows build fix.
2858 * DumpRenderTree/win/EventSender.cpp:
2861 2007-10-20 Darin Adler <darin@apple.com>
2863 Reviewed by Tim Hatcher.
2865 - http://bugs.webkit.org/show_bug.cgi?id=15544
2866 <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2867 not rely on Apple-specific key codes
2869 * DumpRenderTree/mac/EventSendingController.mm:
2870 (-[EventSendingController keyDown:withModifiers:]):
2871 Added named key "rightArrow". Later we could have a whole table of these.
2872 Also tweaked modifiers code a little.
2874 * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2876 2007-10-19 Darin Adler <darin@apple.com>
2880 - http://bugs.webkit.org/show_bug.cgi?id=15566
2881 possible fix for leak seen in DumpRenderTree
2883 * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2884 Delete the item if it's not put on the queue, since the caller has
2885 no way of knowing that. Would be better to have the parameter type
2886 be auto_ptr to express the fact that we take ownership.
2890 * Drosera/mac/main.m: Add missing include.
2892 2007-10-19 Kevin McCullough <kmccullough@apple.com>
2896 - This change should be identical but for some reason was not working
2899 * Scripts/prepare-ChangeLog:
2901 2007-10-19 Kevin McCullough <kmccullough@apple.com>
2903 Reviewed by Oliver and Tim.
2905 - Made use of RetainPtr to avoid retain and release issues and moved the
2906 log function to DebuggerDocumentPlatform, which seems to be a more
2907 logical place for it to live.
2908 - Also moved knownServers from the ServerConnection to
2909 DebuggerApplication to match the Windows code and because it makes sense
2910 that a connection knows its own server but not all of them.
2912 * Drosera/mac/DebuggerClient.h: Moved the log function to
2913 DebuggerDocumentPlatform.
2914 * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2915 Because it's owned by an own Ptr in DebuggerDocument. Also moved the
2916 call for the server name up from the ServerConnection class.
2917 (-[DebuggerClient dealloc]):
2918 (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2919 for the server name up from the ServerConnection.
2920 * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2921 (DebuggerDocument::platformPause):
2922 (DebuggerDocument::platformResume):
2923 (DebuggerDocument::platformStepInto):
2924 (DebuggerDocument::platformEvaluateScript):
2925 (DebuggerDocument::getPlatformCurrentFunctionStack):
2926 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2927 (DebuggerDocument::platformValueForScopeVariableNamed):
2928 (DebuggerDocument::platformLog): Log directly from here. No need to call
2930 * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2931 way I see it, a ServerConnection should only know about its connection
2932 and the group of all possible servers should be kept by the
2934 * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2935 currentServerName, it makes sense that the connection should know that
2937 (-[ServerConnection currentServerName]):
2939 2007-10-19 Kevin McCullough <kmccullough@apple.com>
2943 - Integrated changes from mac drosera. Recently I've encapsulated
2944 out the server connection object from the rest of Drosera because
2945 it is very platform dependent right now and RPC is not implemented on
2946 windows. This functionality, of communicating with the WebKit server
2947 is the next area I will be focusing on in Windows.
2949 - Other changes and cleanup were made to organize the code and add notes
2950 on which parts still need work. Also some mac code is added and
2951 commented out, to act as pseudocode for the logic of those parts.
2953 * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2955 * Drosera/config.h: Added whitespace.
2956 * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2957 these files got moved into Drosera.h/cpp
2958 * Drosera/win/DebuggerApplication.h: Removed.
2959 * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
2960 happened here to better match the logic flow of the same code on the
2961 mac side and to use the new ServerConnection class.
2962 (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2963 (DebuggerClient::initWithServerName): Initializer that will set up the
2964 class to use a ServerConnection object. This was necessary so I could
2965 create a DebuggerClient without having to initilaize it at
2967 (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2968 will be the UIDelegate and FrameLoadDelegate.
2969 (DebuggerClient::AddRef): For IUnknown.
2970 (DebuggerClient::Release): For IUnknown.
2971 (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2972 this still needs to set the global context of the server, but
2973 IWebFrame does not have an accessor for the global context yet.
2974 (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2975 this is a pass through for the same function in the document.
2976 (DebuggerClient::didReceiveTitle): Unimplemented part of
2977 FrameLoadDelegate this would change the title of the window.
2978 (DebuggerClient::createWebViewWithRequest): Part of the
2979 FrameLoadDelegate. This is about new windows via Window.open() and
2980 how their delegates are set.
2981 (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2982 UIDelegate. Just a debug function for printing messages.
2983 * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2984 because the Client should be the UIDelegate and FrameLoadDelegate
2985 to match the delegates on mac.
2986 (DebuggerClient::webViewLoaded): Added accessor method.
2987 * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2988 forgotten to add this file before. This is where the platform
2989 dependent versions of the Documents functions live. Most of these are
2990 unimplemented because some piece of functionality does not exist on
2992 (DebuggerDocument::platformPause):
2993 (DebuggerDocument::platformResume):
2994 (DebuggerDocument::platformStepInto):
2995 (DebuggerDocument::platformEvaluateScript):
2996 (DebuggerDocument::getPlatformCurrentFunctionStack):
2997 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2998 (DebuggerDocument::platformValueForScopeVariableNamed):
2999 (DebuggerDocument::platformLog):
3000 * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3001 responsibilities becaue they belong in the Client. Also I laid the
3002 groundwork for attaching Drosera to a WebKit process
3003 (attachWndProc): Now if a server is selected the Client becomes it's
3005 (Drosera::Drosera): Added the construction of the Client and dictionary
3007 (Drosera::initUI): This is no longer the delegates, the Client is.
3008 (Drosera::webViewLoaded): Now asks the Client instead of holding local
3010 (Drosera::applicationDidFinishLaunching): Placeholder for needed
3011 notification registration when it's possible to implement.
3012 (Drosera::serverLoaded): Ditto
3013 (Drosera::serverUnloaded): Ditto
3014 (Drosera::attach): Attach Drosera to the WebKit server.
3015 * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3018 (Drosera::knownServers):
3019 * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3020 and added the ServerConnection.
3021 * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3022 * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3023 Most of the functions are completely unimlemented because they cannot
3024 connect with the WebKit server, because one does not exist on Windows
3026 (ServerConnection::initWithServerName):
3027 (ServerConnection::~ServerConnection):
3028 (ServerConnection::setGlobalContext):
3029 (ServerConnection::pause):
3030 (ServerConnection::resume):
3031 (ServerConnection::stepInto):
3032 (ServerConnection::switchToServerNamed):
3033 (ServerConnection::applicationTerminating):
3034 (ServerConnection::serverConnectionDidDie):
3035 (ServerConnection::currentFrame):
3036 * Drosera/win/ServerConnection.h: Added. Ditto.
3037 (ServerConnection::ServerConnection):
3039 2007-10-19 Alice Liu <alice.liu@apple.com>
3043 Fix for these broken layout tests on Windows:
3045 fast/forms/focus-selection-input.html
3046 fast/forms/focus-selection-textarea.html
3047 fast/forms/select-accesskey.html
3049 * DumpRenderTree/win/EventSender.cpp:
3051 correct the VK code for alt key.
3053 2007-10-19 Eric Seidel <eric@webkit.org>
3055 Reviewed by Mark Rowe.
3057 Make the GtkLauncher code slightly more readable.
3059 * GtkLauncher/main.cpp:
3060 (setupMainMenu): Added.
3061 (setupMainWindowUI): Added.
3064 2007-10-19 Maciej Stachowiak <mjs@apple.com>
3066 Rubber stamped by Adam.
3068 - don't delay-load WebKit in DumpRenderTree.
3070 * DumpRenderTree/win/DumpRenderTree.vcproj:
3072 2007-10-18 Dan Bernstein <mitz@apple.com>
3074 Reviewed by Adam Roben.
3076 - fix <rdar://problem/5313523>
3077 REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3079 * DumpRenderTree/mac/DumpRenderTree.mm:
3080 (dump): Changed to use _responseMIMEType.
3082 2007-10-17 Adam Roben <aroben@apple.com>
3084 Make it possible to have Windows-specific tests and results
3086 When searching for tests to run and the Skipped file, we will only
3087 look in platform/win and the cross-platform directory. When looking
3088 for expected results, we will look in platform/win, then
3089 platform/mac-leopard, then platform/mac, then finally the
3090 cross-platform directory.
3094 * Scripts/run-webkit-tests:
3095 (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3096 searching in the cross-platform directory.
3097 (sub buildPlatformHierarchy): Removed some unneeded calls to
3100 2007-10-17 Adam Roben <aroben@apple.com>
3102 Add back the call to register WebKit that we had before WebKitInitializer existed
3104 This is needed to ensure that the right WebKit is used when
3105 instantiating COM objects.
3109 * DumpRenderTree/win/debug_internal.vsprops: Define
3110 DEBUG_WEBKIT_HAS_SUFFIX.
3111 * DumpRenderTree/win/DumpRenderTree.cpp:
3114 2007-10-17 Adam Roben <aroben@apple.com>
3116 Import File::Basename in webkitdirs since we use it
3118 * Scripts/webkitdirs.pm:
3120 2007-10-17 Kevin McCullough <kmccullough@apple.com>
3122 - Updated the tiger leaks list to make the internal bots green.
3124 * Scripts/run-webkit-tests:
3126 2007-10-17 Adam Roben <aroben@apple.com>
3128 Build fix for VC++ Express
3130 * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3133 2007-10-16 Kevin McCullough <kmccullough@apple.com>
3137 - Minor mac improvements based on observations I made while implementing the
3140 * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3141 then hand it to the Client who will retain it, it should just be the client who
3142 creates and owns the server.
3143 (-[DebuggerApplication attach:]):
3144 * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3145 * Drosera/mac/DebuggerClient.mm: Creates the server.
3146 (-[DebuggerClient initWithServerName:]):
3147 * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3148 can instead forward declare what it needs.
3150 2007-10-16 Darin Adler <darin@apple.com>
3152 Reviewed by Geoff Garen.
3154 * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3155 want to turn failing tests into platform-specific test results. Also did a
3156 number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3157 would take the type of results into account only some of the time.
3159 2007-10-16 Adam Roben <aroben@apple.com>
3161 Add a new nightly launcher script for Windows
3163 This new script is for versions of Safari that don't delay-load
3164 WebKit. I had to make FindSafari be able to print out the nightly
3165 launcher script on stdout because Windows shell scripts can't capture
3166 the output from a command into an environment variable.
3170 * FindSafari/FindSafari.cpp:
3171 (_tmain): Added /printSafariLauncher option.
3172 * Scripts/run-webkit-nightly.cmd: Added.
3174 2007-10-16 Adam Roben <aroben@apple.com>
3176 Replace WebKitInitializer with FindSafari
3178 We now rely on setting the PATH environment variable to tell Windows
3179 where to find WebKit and its dependencies (similar to
3180 DYLD_FRAMEWORK_PATH on Mac).
3182 This change also make DumpRenderTree no longer delay-load WebKit.
3186 * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3188 * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3189 * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3190 WebKitInitializer, don't delay-load WebKit.
3191 * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3192 * Scripts/run-webkit-tests: Ditto.
3193 * Scripts/webkitdirs.pm:
3194 (sub setPathForRunningWebKitApp): Added.
3195 * WebKitInitializer/WebKitInitializer.cpp: Removed.
3196 * WebKitInitializer/WebKitInitializer.h: Removed.
3197 * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3198 * WebKitInitializer/debug.vsprops: Removed.
3199 * WebKitInitializer/debug_internal.vsprops: Removed.
3200 * WebKitInitializer/release.vsprops: Removed.
3202 2007-10-16 Adam Roben <aroben@apple.com>
3204 Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3206 http://bugs.webkit.org/show_bug.cgi?id=15532
3208 FindSafari simply prints the location of an installed Safari.exe on
3213 * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3216 (getInstalledWebKitDirectory):
3218 * FindSafari/FindSafari.vcproj: Added.
3219 * Scripts/webkitdirs.pm:
3220 (sub installedSafariPath): Added. Calls FindSafari on Windows.
3222 2007-10-16 Adam Roben <aroben@apple.com>
3224 Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3226 Reviewed by Kevin McCullough.
3228 * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3229 when referring to WebKit.dll.
3230 * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3231 * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3232 * DumpRenderTree/win/release.vsprops: Ditto.
3233 * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3234 never have a _debug suffix on WebKit.dll.
3235 * WebKitInitializer/WebKitInitializer.cpp:
3236 (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3238 * WebKitInitializer/debug_internal.vsprops: Added
3239 DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3241 2007-10-16 Darin Adler <darin@apple.com>
3245 * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3246 Remove now-unneeded control/alt key hack; the tests have been updated.
3248 2007-10-16 Kevin McCullough <kmccullough@apple.com>
3250 - Updated leaks list because our internal bot upgraded it's version of leopard and
3251 one of the leaks was fixed between that revision and the bot's previous version of
3254 * Scripts/run-webkit-tests:
3256 2007-10-15 Kevin McCullough <kmccullough@apple.com>
3260 - I encapsulated out the server connecton functionality because it is a specific part
3261 of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3262 into WebCore and C++. But if it is encapsulated out it can be easily replaced on
3263 Windows. So the majority of this patch is moving preexisting functionality.
3265 - Also I removed the prefix header and changed to use config.h because it is more
3266 standard on how we use config.h in windows and it didn't make much sense to keep
3267 the prefix header and the config.h
3269 * Drosera/DebuggerDocument.cpp:
3270 (DebuggerDocument::DebuggerDocument):
3271 * Drosera/DebuggerDocument.h:
3273 * Drosera/mac/DebuggerApplication.mm:
3274 (-[DebuggerApplication attach:]):
3275 * Drosera/mac/DebuggerClient.h:
3276 * Drosera/mac/DebuggerClient.mm:
3277 (-[DebuggerClient initWithServerConnection:]):
3278 (-[DebuggerClient dealloc]):
3279 (-[DebuggerClient windowDidLoad]):
3280 (-[DebuggerClient windowWillClose:]):
3281 (-[DebuggerClient webView:didFinishLoadForFrame:]):
3282 (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3283 * Drosera/mac/DebuggerDocumentPlatform.mm:
3284 (DebuggerDocument::platformPause):
3285 (DebuggerDocument::platformResume):
3286 (DebuggerDocument::platformStepInto):
3287 (DebuggerDocument::platformEvaluateScript):
3288 (DebuggerDocument::getPlatformCurrentFunctionStack):
3289 (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3290 (DebuggerDocument::platformValueForScopeVariableNamed):
3291 (DebuggerDocument::platformLog):
3292 * Drosera/mac/Drosera.pch: Removed.
3293 * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3294 * Drosera/mac/ServerConnection.h: Added.
3295 * Drosera/mac/ServerConnection.mm: Added.
3296 (-[ServerConnection initWithServerName:]):
3297 (-[ServerConnection dealloc]):
3298 (-[ServerConnection setGlobalContext:]):
3299 (-[ServerConnection pause]):
3300 (-[ServerConnection resume]):
3301 (-[ServerConnection stepInto]):
3302 (-[ServerConnection switchToServerNamed:]):
3303 (-[ServerConnection applicationTerminating:]):
3304 (-[ServerConnection serverConnectionDidDie:]):
3305 (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3306 (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3307 (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3308 (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3309 (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3310 (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3311 (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3312 (-[ServerConnection currentFrame]):
3313 (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3314 (-[ServerConnection knownServers]):
3316 2007-10-15 David Kilzer <ddkilzer@webkit.org>
3320 - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3321 Script to automatically search nightly builds for regressions (bisect-builds)
3323 * Scripts/bisect-builds: Added.
3325 2007-10-14 Maciej Stachowiak <mjs@apple.com>
3329 - New JavaScript benchmark
3330 http://bugs.webkit.org/show_bug.cgi?id=15515
3332 * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3333 current development or release build of JavaScriptCore.
3335 2007-10-15 Mark Rowe <mrowe@apple.com>
3339 Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3341 * Scripts/webkitdirs.pm:
3342 - Change checkArgv to remove the options from @ARGV to prevent
3343 them from interfering with further option processing.
3344 - Fix logic error in determineIsQt that would prevent it from bailing out early.
3345 - Change isOSX to mean OS X and not Qt or Gtk. Most of our uses of isOSX assume that this is the meaning
3346 already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3347 incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3349 2007-10-15 Darin Adler <darin@apple.com>
3353 - added logging of window.prompt and window.confirm
3355 * DumpRenderTree/mac/UIDelegate.mm:
3356 (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3357 Implement the recommended delegate rather than the deprecated one.
3358 (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3360 (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3363 * DumpRenderTree/win/UIDelegate.h:
3364 * DumpRenderTree/win/UIDelegate.cpp:
3365 (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3366 (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3367 (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3368 (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3370 2007-10-15 Alice Liu <alice.liu@apple.com>
3372 Reviewed by Sam Weinig.
3374 Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3376 * DumpRenderTree/win/DumpRenderTree.cpp:
3377 (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3378 (main): allocate the global policy delegate for DRT's custom use
3379 * DumpRenderTree/win/DumpRenderTree.vcproj:
3380 Adding files to project
3381 * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3382 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3383 (LayoutTestController::setCustomPolicyDelegate):
3384 set the webview's policy delegate to DRT's custom one if the test requests it.
3385 * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3386 Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3387 (PolicyDelegate::PolicyDelegate):
3388 (PolicyDelegate::QueryInterface):
3389 (PolicyDelegate::AddRef):
3390 (PolicyDelegate::Release):
3391 (PolicyDelegate::decidePolicyForNavigationAction):
3392 * DumpRenderTree/win/PolicyDelegate.h: Added.
3393 (PolicyDelegate::decidePolicyForNewWindowAction):
3394 (PolicyDelegate::decidePolicyForMIMEType):
3395 (PolicyDelegate::unableToImplementPolicyWithError):
3397 2007-10-14 Holger Hans Peter Freyther <zecke@selfish.org>
3401 * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3402 when querying for QMAKE_MKSPECS.
3404 2007-10-14 Andrew Wellington <proton@wiretapped.net>
3406 Reviewed by Adam Roben.
3408 Fix run-webkit-tests is too greedy calculating platform hierarchy
3409 http://bugs.webkit.org/show_bug.cgi?id=15465
3411 Fix run-webkit-tests being too greedy in trying to split the platform name up
3412 causing it to try and find tests in every directory above the first "-" in the
3413 path to the LayoutTests
3415 * Scripts/run-webkit-tests:
3417 2007-10-14 Oleg Sukhodolsky <son.two@gmail.com>
3421 http://bugs.webkit.org/show_bug.cgi?id=15006
3422 Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3423 to reduce code duplication.
3425 * Scripts/build-webkit:
3426 * Scripts/webkitdirs.pm:
3427 buildQMakeProject() renamed to buildQMakeQtProject().
3428 buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3429 unused $colorize has been removed.
3431 === Start merge of feature-branch 2007-10-12 ===
3433 2007-10-08 Eric Seidel <eric@webkit.org>
3435 Reviewed by Mark Rowe.
3437 * Scripts/build-webkit: add --help, remove unused --color
3439 2007-10-07 Eric Seidel <eric@webkit.org>
3443 * Drosera/mac/DebuggerDocumentPlatform.mm:
3444 (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3446 2007-10-03 Rob Buis <buis@kde.org>
3450 Adapt to changed location of Ahem font.
3452 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3454 2007-10-02 Eric Seidel <eric@webkit.org>
3456 Reviewed by Adam Roben.
3458 Make pixel tests more useful!
3459 Finally fix the image diff 0.00% mystery problem
3460 Highlight any image differences in the image diff.
3461 Add a link from image diffs back to original test file.
3463 * DumpRenderTree/mac/ImageDiff.m:
3464 (compareImages): highlight any differences
3465 (computePercentageDifferent): round to two decimal places
3466 * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3468 2007-10-02 Eric Seidel <eric@webkit.org>
3470 Reviewed by Alexey Proskuryakov.
3472 * Scripts/run-webkit-tests: print the % image difference on main results page
3474 2007-10-02 Mark Rowe <mrowe@apple.com>
3478 Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3480 * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3481 * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3483 2007-10-01 Mark Rowe <mrowe@apple.com>
3485 * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3487 2007-09-25 Eric Seidel <eric@webkit.org>
3489 Reviewed by Mark Rowe.
3491 DerivedSources.make was finding "ENABLE_SVG" in the string
3492 "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3495 * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3497 2007-09-25 Mark Rowe <mrowe@apple.com>
3499 Rubber-stamped by Eric.
3501 * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3502 This makes it possible to automate nightly builds for the feature-branch.
3504 2007-07-11 Nikolas Zimmermann <zimmermann@kde.org>
3506 Rubber stamped by Mark.
3508 Enable svg experimental features as default here in feature-branch.
3510 * Scripts/build-webkit:
3512 2007-06-29 Antti Koivisto <antti@apple.com>
3516 Add VIDEO flag for timed media features
3518 * Scripts/build-webkit
3520 === End merge of feature-branch 2007-10-12 ===
3522 2007-10-11 Kevin McCullough <kmccullough@apple.com>
3526 - Updated rational for the leaks list to be more clear.
3528 * Scripts/run-webkit-tests:
3530 2007-10-11 Kevin McCullough <kmccullough@apple.com>
3532 Rubber Stamp by Sam.
3534 Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3535 I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3537 * Scripts/run-webkit-tests:
3539 2007-10-10 Simon Hausmann <hausmann@kde.org>
3543 Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3544 includes are needed for INT_MAX, std::auto_ptr and the like.
3546 * DumpRenderTree/qt/main.cpp:
3548 2007-10-09 Lars Knoll <lars@trolltech.com>
3552 implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3554 * DumpRenderTree/qt/jsobjects.cpp:
3555 (LayoutTestController::encodeHostName):
3556 (LayoutTestController::decodeHostName):
3557 * DumpRenderTree/qt/jsobjects.h:
3559 2007-10-09 Lars Knoll <lars@trolltech.com>
3563 Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3565 * DumpRenderTree/qt/DumpRenderTree.cpp:
3566 (WebCore::WebPage::createFrame):
3567 (WebCore::DumpRenderTree::DumpRenderTree):
3568 (WebCore::DumpRenderTree::titleChanged):
3569 * DumpRenderTree/qt/DumpRenderTree.h:
3570 * DumpRenderTree/qt/jsobjects.cpp:
3571 (LayoutTestController::reset):
3572 * DumpRenderTree/qt/jsobjects.h:
3574 2007-10-09 Lars Knoll <lars@trolltech.com>
3578 add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3580 * DumpRenderTree/qt/DumpRenderTree.h:
3581 * DumpRenderTree/qt/jsobjects.cpp:
3582 (LayoutTestController::clearBackForwardList):
3583 * DumpRenderTree/qt/jsobjects.h:
3585 2007-10-09 Lars Knoll <lars@trolltech.com>
3589 make --git-reviewer work again.
3591 * Scripts/prepare-ChangeLog:
3593 2007-10-07 Holger Hans Peter Freyther <zecke@selfish.org>
3595 Rubber stamped by Eric.
3597 Connect to the "hovering-over-link" signal emitted by WebKitPage and
3598 show the current link inside the statusbar.
3599 This shows how to make use of this signal and allows to easily test
3600 http://bugs.webkit.org/show_bug.cgi?id=15299.
3602 * GtkLauncher/main.cpp:
3606 2007-10-05 Lars Knoll <lars@trolltech.com>
3608 add proper error messages to the FrameLoaderClient.
3609 Implement ChromeClientQt::closeWindowSoon and
3610 FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3611 Some fixes in DRT to make it work correctly with multiple windows.