WebKitTools/ChangeLog

   1 2010-09-28  Adam Roben  <aroben@apple.com>
   2
   3         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
   4         called
   5
   6         Reviewed by Anders Carlsson.
   7
   8         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
   9         Full-page Adobe Reader does not paint until window is resized
  10
  11         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  12         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
  13         this level.
  14
  15         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
  16         NPP_SetWindow.
  17
  18         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
  19         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
  20         the plugin's HWND has a non-zero size and that its size/position
  21         matches that specified in the NPWindow.
  22
  23         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  24         (NPP_SetWindow): Call through to the PluginTest.
  25
  26         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  27         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
  28         the files as it saw fit.
  29
  30 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
  31
  32         Reviewed by Andreas Kling.
  33
  34         [Qt] Remove support for Qt 4.5
  35         https://bugs.webkit.org/show_bug.cgi?id=46718
  36
  37         Remove the code for versions of Qt prior to 4.6.
  38
  39         * DumpRenderTree/qt/EventSenderQt.cpp:
  40         (EventSender::addTouchPoint):
  41         (EventSender::updateTouchPoint):
  42         (EventSender::setTouchModifier):
  43         (EventSender::touchStart):
  44         (EventSender::touchMove):
  45         (EventSender::touchEnd):
  46         (EventSender::clearTouchPoints):
  47         (EventSender::releaseTouchPoint):
  48         (EventSender::sendTouchEvent):
  49         * DumpRenderTree/qt/EventSenderQt.h:
  50         * DumpRenderTree/qt/TextInputControllerQt.cpp:
  51         (TextInputController::setMarkedText):
  52         * QtTestBrowser/launcherwindow.cpp:
  53         (LauncherWindow::LauncherWindow):
  54         (LauncherWindow::initializeView):
  55         (LauncherWindow::createChrome):
  56         (LauncherWindow::sendTouchEvent):
  57         (LauncherWindow::eventFilter):
  58         (LauncherWindow::applyZoom):
  59         (LauncherWindow::setTouchMocking):
  60         * QtTestBrowser/launcherwindow.h:
  61         * QtTestBrowser/utils.cpp:
  62         (urlFromUserInput):
  63         * QtTestBrowser/webview.cpp:
  64         (WebViewGraphicsBased::animatedFlip):
  65         (WebViewGraphicsBased::animatedYFlip):
  66         * QtTestBrowser/webview.h:
  67         (WebViewGraphicsBased::setYRotation):
  68
  69 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
  70
  71         Reviewed by Andreas Kling.
  72
  73         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
  74         which should point to wcecompat installation. Needs wcecompat
  75         library from http://github.com/mauricek/wcecompat .
  76
  77         * DumpRenderTree/qt/DumpRenderTree.pro:
  78         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  79         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  80
  81 2010-09-28  Daniel Bates  <dbates@rim.com>
  82
  83         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
  84         <https://bugs.webkit.org/show_bug.cgi?id=39136>
  85
  86         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
  87         In particular, this change caused Sheriffbot to raise an exception when
  88         trying to parse the bug id on a bug page. We need to look into this
  89         some more.
  90
  91         * Scripts/webkitpy/common/net/bugzilla.py:
  92         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
  93         * Scripts/webkitpy/tool/bot/sheriff.py:
  94         * Scripts/webkitpy/tool/commands/download.py:
  95         * Scripts/webkitpy/tool/commands/queues.py:
  96         * Scripts/webkitpy/tool/commands/upload.py:
  97         * Scripts/webkitpy/tool/steps/closebug.py:
  98         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
  99         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 100         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
 101
 102 2010-09-28  Adam Barth  <abarth@webkit.org>
 103
 104         Reviewed by Eric Seidel.
 105
 106         Move RegressionWindow further up the dependency chain
 107         https://bugs.webkit.org/show_bug.cgi?id=46698
 108
 109         Baby steps towards pushing this information into bug posts.
 110
 111         * Scripts/webkitpy/common/net/buildbot.py:
 112         * Scripts/webkitpy/common/net/buildbot_unittest.py:
 113         * Scripts/webkitpy/common/net/regressionwindow.py:
 114         * Scripts/webkitpy/tool/commands/queries.py:
 115
 116 2010-09-27  Daniel Bates  <dbates@rim.com>
 117
 118         Reviewed by Adam Barth.
 119
 120         sheriffbot can't roll out security patches
 121         https://bugs.webkit.org/show_bug.cgi?id=39136
 122
 123         Make SheriffBot determine if it's authorized to view a bug
 124         whose change it wants to rollout before it tries to rollout
 125         the change.
 126
 127         Moreover, make both webkit-patch and Sheriffbot provide human-
 128         readable error messages when they are not authorized to view
 129         a bug and when a bug number is invalid.
 130
 131         Currently, Sheriffbot does not parse Bugzilla bugs for
 132         <bug error="...">, which indicates an error when retrieving
 133         a bug. In particular, error="NotPermitted" if a person (or bot)
 134         is not authorized to view a bug. For such error="NotPermitted" bugs,
 135         Sheriffbot raises an exception when parsing the bug report and
 136         this exception does not explicitly indicate Sheriffbot's lack
 137         of authorization. Instead, Sheriffbot should explicitly check
 138         for the presence <bug error="..."> before operating on a bug
 139         and error with a human-readable message if it's not permitted
 140         to view it.
 141
 142         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
 143         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
 144           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
 145           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
 146           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
 147         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
 148         * Scripts/webkitpy/tool/commands/download.py: Ditto.
 149         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
 150         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
 151         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
 152         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
 153         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
 154         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
 155
 156 2010-09-27  Adam Barth  <abarth@webkit.org>
 157
 158         Reviewed by Eric Seidel.
 159
 160         Expose more more failure information from Buildbot to SheriffBot
 161         https://bugs.webkit.org/show_bug.cgi?id=46697
 162
 163         This patch moves the information about what tests failured closer to
 164         SheriffBot.  There are still a couple more patches to go before
 165         SheriffBot can post this information to bugs, but this is a step in
 166         that direction.  Yay for unit tests, which caught some bugs in earlier
 167         versions of this patch.
 168
 169         * Scripts/webkitpy/common/net/buildbot.py:
 170         * Scripts/webkitpy/common/net/buildbot_unittest.py:
 171         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
 172         * Scripts/webkitpy/tool/commands/queries.py:
 173
 174 2010-09-27  Eric Seidel  <eric@webkit.org>
 175
 176         Unreviewed.  Fixing 500 error seen in the status server.
 177
 178         It turns out that a = b = []; b.append(1); then a[0] will be 1!
 179         This should have been obvious to me, I guess, but it was not what I was expecting.
 180
 181         * QueueStatusServer/model/activeworkitems.py:
 182
 183 2010-09-27  Adam Barth  <abarth@webkit.org>
 184
 185         Reviewed by Eric Seidel.
 186
 187         commit-queue should reject patches that fail to land
 188         https://bugs.webkit.org/show_bug.cgi?id=46694
 189
 190         This can happen, for example, if there's no reviewer.  Without this
 191         patch, we'll keep retrying the patch.
 192
 193         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 194         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 195
 196 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
 197
 198         Rubber-stamped by Adele Peterson.
 199
 200         Add a harness for running the CSS 2.1 test suite.
 201
 202         This harness assumes that you've got a local a copy of the suite
 203         adjacent to the 'harness' directory.
 204
 205         The harness lets you go through the tests in chapter order,
 206         denoting pass/fail/skipped for each test.
 207
 208         It uses a client-side database to store the results of testing.
 209
 210         * CSSTestSuiteHarness/harness/harness.css: Added.
 211         * CSSTestSuiteHarness/harness/harness.html: Added.
 212         * CSSTestSuiteHarness/harness/harness.js: Added.
 213
 214 2010-09-27  Eric Seidel  <eric@webkit.org>
 215
 216         Reviewed by Adam Barth.
 217
 218         Patch locks should expire if a patch is marked for retry
 219         https://bugs.webkit.org/show_bug.cgi?id=46682
 220
 221         This was part Adam's original CommitQueueTask design,
 222         but support for it was missing from the server.
 223         I added the support, but triggering lock-release based on this
 224         special "retry" status feels a bit strange so I added a FIXME.
 225
 226         I also changed the text in queuestatus.html to say "Lock Acquired"
 227         since "Last Activity" isn't really true.  We only update the lock
 228         date when the patch is started, not on every status update.
 229
 230         I also noticed an exception in next-patch, which I fixed by re-writing
 231         the unzip logic in activeworkitems.py again.
 232
 233         * QueueStatusServer/handlers/updatestatus.py:
 234         * QueueStatusServer/model/activeworkitems.py:
 235         * QueueStatusServer/templates/queuestatus.html:
 236
 237 2010-09-27  Tony Chang  <tony@chromium.org>
 238
 239         Reviewed by David Levin.
 240
 241         [chromium] fix a warning when compiling DRT on 32-bit linux
 242         https://bugs.webkit.org/show_bug.cgi?id=46641
 243
 244         * DumpRenderTree/chromium/TestEventPrinter.cpp:
 245         (DRTPrinter::handleImage):
 246
 247 2010-09-27  Eric Seidel  <eric@webkit.org>
 248
 249         Reviewed by Adam Barth.
 250
 251         queue-status should report when the patch was last locked to a queue
 252         https://bugs.webkit.org/show_bug.cgi?id=46674
 253
 254         This isn't necessarily the best way to expose this information
 255         but having this accessible via the web interface is very
 256         useful until we come up with a nicer way to display this.
 257
 258         I also cleaned up the code in activeworkitems.py a little
 259         to use list comprehensions and to have the code work with
 260         pairs instead of two lists at once.  Eventually I think those
 261         item/time pairs need to be their own little helper class.
 262
 263         * QueueStatusServer/handlers/queuestatus.py:
 264         * QueueStatusServer/model/activeworkitems.py:
 265         * QueueStatusServer/templates/queuestatus.html:
 266
 267 2010-09-27  Tony Chang  <tony@chromium.org>
 268
 269         Reviewed by David Levin.
 270
 271         [chromium] fix detection of missing fonts on DRT
 272         https://bugs.webkit.org/show_bug.cgi?id=46651
 273
 274         * DumpRenderTree/chromium/TestShellGtk.cpp:
 275         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
 276
 277 2010-09-27  Tony Chang  <tony@chromium.org>
 278
 279         Reviewed by Dimitri Glazkov.
 280
 281         add webkit unit tests to the chromium testers
 282         https://bugs.webkit.org/show_bug.cgi?id=46669
 283
 284         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 285         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
 286
 287 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
 288
 289         Unreviewed.
 290
 291         Adding myself to the committers list.
 292
 293         * Scripts/webkitpy/common/config/committers.py:
 294
 295 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
 296
 297         Reviewed by Eric Seidel.
 298
 299         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
 300         https://bugs.webkit.org/show_bug.cgi?id=46634
 301
 302         Use OutputCapture to prevent console spam (and also check for expected
 303         output).
 304
 305         * Scripts/webkitpy/common/system/user_unittest.py:
 306
 307 2010-09-27  Eric Seidel  <eric@webkit.org>
 308
 309         Reviewed by James Robinson.
 310
 311         start-commit-queue should abort any rebases in progress
 312         https://bugs.webkit.org/show_bug.cgi?id=46640
 313
 314         webkit-patch commit-queue would do this itself, but this just
 315         helps ensure that the commit-queue script is properly updated
 316         before we run it (in the case where a previous rebase is in
 317         progress the git svn rebase would not work before we run the
 318         commit-queue).
 319
 320         * EWSTools/start-commit-queue.sh:
 321
 322 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
 323
 324         Reviewed by Gustavo Noronha Silva.
 325
 326         [GTK] Clean up the DRT fonts.conf and switch to Liberation
 327         https://bugs.webkit.org/show_bug.cgi?id=46038
 328
 329         Switch to Liberation fonts for GTK+ layout tests. This will make our
 330         test results metric-compatible with many Windows/Chromium results. It
 331         also simplifies the fonts.conf that we load and prepares the way for
 332         fixing many font bugs.
 333
 334         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 335         (initializeFonts): Initialize a known list of fonts instead of loading
 336         every font in the WEBKIT_TESTFONTS directory.
 337         * DumpRenderTree/gtk/fonts.conf: Removed.
 338         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
 339         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
 340         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
 341         we can load both fonts.conf and AHEM____.TTF from this location.
 342         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
 343         it is no longer used.
 344
 345 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
 346
 347         Reviewed by Ojan Vafai.
 348
 349         new-run-webkit-httpd fails if Perl is not installed
 350         https://bugs.webkit.org/show_bug.cgi?id=46602
 351
 352         Make Port._read_configuration catch all exceptions, since trying to run
 353         perl (because of _webkit_build_directory) when it's not installed throws
 354         a WindowsError or OSError, not an IOError (this became an issue after
 355         r68268, since ChromiumPort ends up calling Port.default_configuration in
 356         its constructor, which means that we're ending up on this codepath in
 357         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
 358         new-run-webkit-httpd).
 359
 360         * Scripts/webkitpy/layout_tests/port/base.py:
 361         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 362
 363 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 364
 365         Reviewed by Antonio Gomes.
 366
 367         [EFL] Add setting API to set a local storage database path.
 368         https://bugs.webkit.org/show_bug.cgi?id=45446
 369
 370         Add a setting API to set local storage database path.
 371
 372         * EWebLauncher/main.c:
 373         (on_key_down):
 374         (browserCreate):
 375         (main):
 376
 377 2010-09-26  Sam Weinig  <sam@webkit.org>
 378
 379         Reviewed by Anders Carlsson.
 380
 381         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
 382         https://bugs.webkit.org/show_bug.cgi?id=46587
 383
 384         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 385
 386 2010-09-26  Antonio Gomes  <agomes@rim.com>
 387
 388         Reviewed by Kenneth Rohde Christiansen.
 389
 390         DRT/Mac nodesFromRect support
 391
 392         [Mac][DRT] Implement LayoutTestController::nodesFromRect
 393         https://bugs.webkit.org/show_bug.cgi?id=46580
 394
 395         Implements LayoutTestController::nodesFromRect for Mac DRT, and
 396         adding stubs for GTK+ and Windows.
 397
 398         * DumpRenderTree/LayoutTestController.cpp:
 399         (nodesFromRectCallback):
 400         (LayoutTestController::staticFunctions):
 401         * DumpRenderTree/LayoutTestController.h:
 402         (LayoutTestController::LayoutTestController::nodesFromRect):
 403         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 404         (LayoutTestController::nodesFromRect):
 405
 406 2010-09-25  Nicolas Weber  <thakis@chromium.org>
 407
 408         Reviewed by Adam Barth.
 409
 410         https://bugs.webkit.org/show_bug.cgi?id=46555
 411         Fix typo in prepare-ChangeLog's help output.
 412
 413         * Scripts/prepare-ChangeLog:
 414
 415 2010-09-24  Sam Weinig  <sam@webkit.org>
 416
 417         Reviewed by Darin Adler.
 418
 419         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
 420         <rdar://problem/8359279>
 421         https://bugs.webkit.org/show_bug.cgi?id=46546
 422
 423         * MiniBrowser/mac/BrowserWindowController.m:
 424         (mouseDidMoveOverElement):
 425         (-[BrowserWindowController awakeFromNib]):
 426         * MiniBrowser/win/BrowserView.cpp:
 427         (mouseDidMoveOverElement):
 428         (BrowserView::create):
 429         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 430         (WTR::InjectedBundlePage::InjectedBundlePage):
 431         * WebKitTestRunner/TestController.cpp:
 432         (WTR::createOtherPage):
 433         (WTR::TestController::initialize):
 434
 435 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
 436
 437         Reviewed by Adam Barth.
 438
 439         Allow rebaselines for webkit-patch rebaseline to be chosen
 440         https://bugs.webkit.org/show_bug.cgi?id=46407
 441
 442         Instead of always rebaselining all failing tests, allow a subset to be
 443         chosen.
 444
 445         * Scripts/webkitpy/common/system/user.py:
 446         * Scripts/webkitpy/tool/commands/rebaseline.py:
 447
 448 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
 449
 450         Reviewed by Tony Chang.
 451
 452         [chromium] Implement TextInputController::firstRectForCharacterRange
 453         https://bugs.webkit.org/show_bug.cgi?id=38100
 454
 455         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
 456         No new tests are added since we need to implement the same feature in chromium side
 457         in order to enable any tests that uses this function.
 458
 459         * DumpRenderTree/chromium/TextInputController.cpp:
 460         (TextInputController::firstRectForCharacterRange): Added.
 461
 462 2010-09-24  Adam Barth  <abarth@webkit.org>
 463
 464         Reviewed by Eric Seidel.
 465
 466         commit-queue reports land failures as "PASS"
 467         https://bugs.webkit.org/show_bug.cgi?id=46530
 468
 469         We were ignoring the return value of land instead of passing it back to
 470         CommitQueue.  Of course, this was the one case I forgot to test!
 471
 472         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 473         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 474
 475 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
 476
 477         Reviewed by Eric Seidel.
 478
 479         new-run-webkit-tests prints out nothing when build-dumprendertree fails
 480         https://bugs.webkit.org/show_bug.cgi?id=37563
 481
 482         Print error message when build-dumprendertree fails.
 483
 484         * Scripts/webkitpy/layout_tests/port/webkit.py:
 485         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 486
 487 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
 488
 489         Reviewed by Tony Chang.
 490
 491         NRWT doesn't respect config set with set-webkit-configuration
 492         https://bugs.webkit.org/show_bug.cgi?id=46278
 493
 494         Use Port.default_configuration() instead of hardcoding Release in
 495         ChromiumPort configuration initialization, so that we still inherit the
 496         configuration set by set-webkit-configuration.
 497
 498         * Scripts/webkitpy/layout_tests/port/chromium.py:
 499         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 500
 501 2010-09-24  Chang Shu  <chang.shu@nokia.com>
 502
 503         Reviewed by Csaba Osztrogonác.
 504
 505         [Qt] Fix the code to check file existence.
 506         https://bugs.webkit.org/show_bug.cgi?id=46465
 507
 508         * QtTestBrowser/main.cpp:
 509         (main):
 510
 511 2010-09-23  Tony Chang  <tony@chromium.org>
 512
 513         Unreviewed, rolling out r68232.
 514         http://trac.webkit.org/changeset/68232
 515
 516         Broken NRWT on the canary bots.
 517
 518         * Scripts/webkitpy/layout_tests/port/chromium.py:
 519
 520 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
 521
 522         Unreviewed, build fix.
 523
 524         r68008 broke new-run-webkit-tests in that the chromium ports no
 525         longer respect set-webkit-configuration. The correct fix for this
 526         is being pursued in bug 46278 (along with a bunch of unit tests),
 527         but in the meantime I'm reverting the particular lines that broke
 528         things. This was tested by hand.
 529
 530         * Scripts/webkitpy/layout_tests/port/chromium.py:
 531
 532 2010-09-23  Sam Weinig  <sam@webkit.org>
 533
 534         Reviewed by Anders Carlsson.
 535
 536         WebKit2 API: Need way to know when a frame is removed from the hierarchy
 537         <rdar://problem/8414062>
 538         https://bugs.webkit.org/show_bug.cgi?id=46432
 539
 540         * MiniBrowser/mac/BrowserWindowController.m:
 541         (didRemoveFrameFromHierarchy):
 542         (-[BrowserWindowController awakeFromNib]):
 543         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 544         (WTR::InjectedBundlePage::InjectedBundlePage):
 545         * WebKitTestRunner/TestController.cpp:
 546         (WTR::TestController::initialize):
 547
 548 2010-09-23  Tony Chang  <tony@chromium.org>
 549
 550         Reviewed by Dimitri Glazkov.
 551
 552         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
 553         https://bugs.webkit.org/show_bug.cgi?id=46426
 554
 555         * DumpRenderTree/chromium/LayoutTestController.cpp:
 556         (LayoutTestController::LayoutTestController):
 557         (LayoutTestController::sampleSVGAnimationForElementAtTime):
 558         * DumpRenderTree/chromium/LayoutTestController.h:
 559
 560 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
 561
 562         Reviewed by Nate Chapin.
 563
 564         [GTK] r68199 introduced two test failures
 565         https://bugs.webkit.org/show_bug.cgi?id=46424
 566
 567         Fix a regression handling preference overrides that are attached to boolean properties.
 568
 569         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 570         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
 571         so we must check for that when converting a string to a boolean.
 572
 573 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
 574
 575         Reviewed by David Levin.
 576
 577         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
 578         https://bugs.webkit.org/show_bug.cgi?id=46406
 579
 580         This breaks when the method is called with specified size of data (image data), and the
 581         buffer hasn't yet reached this size.
 582
 583         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
 584           index larger than 0.
 585
 586 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
 587
 588         Reviewed by Nate Chapin.
 589
 590         [GTK] Some tests from r68174 fail on the GTK+ bots
 591         https://bugs.webkit.org/show_bug.cgi?id=46396
 592
 593         Simplify LayoutTestController::overridePreference to make it easier for
 594         people unfamiliar with the code to keep the list of preferences up to date.
 595         Add the conversion for enable-hyperlink-auditing.
 596
 597         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 598         (LayoutTestController::overridePreference): Use a simple if-else block to determine
 599         out the property name for overrridePreference. Also simplify the logic for setting
 600         string properties. Add the conversion for enable-hyperlink-auditing.
 601
 602 2010-09-23  Tony Chang  <tony@chromium.org>
 603
 604         Reviewed by David Levin.
 605
 606         [chromium] add caretBrowsingEnabled to WebSettings and DRT
 607         https://bugs.webkit.org/show_bug.cgi?id=46388
 608
 609         * DumpRenderTree/chromium/LayoutTestController.cpp:
 610         (LayoutTestController::overridePreference):
 611         * DumpRenderTree/chromium/WebPreferences.cpp:
 612         (WebPreferences::reset):
 613         (WebPreferences::applyTo):
 614         * DumpRenderTree/chromium/WebPreferences.h:
 615
 616 2010-09-23  Nate Chapin  <japhet@chromium.org>
 617
 618         Reviewed by Darin Fisher.
 619
 620         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
 621         https://bugs.webkit.org/show_bug.cgi?id=30458
 622
 623         * DumpRenderTree/chromium/LayoutTestController.cpp:
 624         (LayoutTestController::overridePreference):
 625         * DumpRenderTree/chromium/WebPreferences.cpp:
 626         (WebPreferences::reset):
 627         (WebPreferences::applyTo):
 628         * DumpRenderTree/chromium/WebPreferences.h:
 629         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 630         (resetDefaultsToConsistentValues):
 631         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 632         (LayoutTestController::overridePreference):
 633
 634 2010-09-21  Stephen White  <senorblanco@chromium.org>
 635
 636         Reviewed by David Levin.
 637
 638         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
 639         https://bugs.webkit.org/show_bug.cgi?id=46208
 640
 641         This flag allows the layout tests to be run with or without accelerated
 642         2D canvas rendering.
 643
 644         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 645         (main):
 646         Declare the new flag string, and check for it on startup.
 647         * DumpRenderTree/chromium/TestShell.cpp:
 648         (TestShell::TestShell):
 649         Add a boolean for the new flag, in order to preserve its value over
 650         preferences reset.
 651         (TestShell::resetWebSettings):
 652         Set the new flag to the stored value on reset.
 653         * DumpRenderTree/chromium/TestShell.h:
 654         (TestShell::setAccelerated2dCanvasEnabled):
 655         Add an accessor for the new flag.
 656         * DumpRenderTree/chromium/WebPreferences.cpp:
 657         (WebPreferences::reset):
 658         Initialize the new flag to false.
 659         (WebPreferences::applyTo):
 660         Copy the flag's value to the WebSettings.
 661         * DumpRenderTree/chromium/WebPreferences.h:
 662         Add the new flag.
 663
 664 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 665
 666         Reviewed by Simon Hausmann.
 667
 668         [Qt] Refactor QtWebKitPlatformPlugin interface
 669
 670         Make it easier to keep source-compability for the
 671         QtWebKitPlatformPlugin interface, and run qmake
 672         on the example (but not build) for convenience.
 673
 674         https://bugs.webkit.org/show_bug.cgi?id=46345
 675
 676         * Scripts/webkitdirs.pm:
 677
 678 2010-09-23  Adam Barth  <abarth@webkit.org>
 679
 680         Reviewed by Eric Seidel.
 681
 682         Tweak some status messages that Eric thought were confusing
 683         https://bugs.webkit.org/show_bug.cgi?id=46342
 684
 685         * Scripts/webkitpy/tool/commands/queues.py:
 686         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 687
 688 2010-09-22  Adam Barth  <abarth@webkit.org>
 689
 690         Reviewed by Eric Seidel.
 691
 692         Fix comm-queue typo
 693         https://bugs.webkit.org/show_bug.cgi?id=46339
 694
 695         We were missing a "self".  The real problem is that we didn't have an
 696         integration test for the failure case.
 697
 698         * Scripts/webkitpy/tool/commands/queues.py:
 699         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 700
 701 2010-09-22  Adam Barth  <abarth@webkit.org>
 702
 703         Reviewed by Eric Seidel.
 704
 705         commit-queue should log more detailed messages to the QueueStatusServer
 706         https://bugs.webkit.org/show_bug.cgi?id=46333
 707
 708         When I created CommitQueueTask, I removed most of the previous logging.
 709         This patch adds back more detailed logging so folks can see their patch
 710         progress through the queue.
 711
 712         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 713         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 714         * Scripts/webkitpy/tool/commands/queues.py:
 715         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 716
 717 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
 718
 719         Reviewed by Darin Fisher.
 720
 721         [Chromium] User style layout tests don't pass on Chromium
 722         https://bugs.webkit.org/show_bug.cgi?id=46069
 723
 724         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
 725         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
 726         behavior from other ports.
 727
 728         * DumpRenderTree/chromium/LayoutTestController.cpp:
 729         (LayoutTestController::addUserStyleSheet):
 730
 731 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
 732
 733         Reviewed by Martin Robinson.
 734
 735         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
 736         https://bugs.webkit.org/show_bug.cgi?id=46303.
 737
 738         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
 739         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
 740         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
 741         property sheet.
 742         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
 743         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
 744         appropriate property sheet for the build types.
 745         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
 746         configuration to use appropriate property sheet for CoreFoundation
 747         and CFLite-style builds.
 748
 749 2010-09-22  Adam Barth  <abarth@webkit.org>
 750
 751         Reviewed by Eric Seidel.
 752
 753         Optimize commit-queue performance for green trees
 754         https://bugs.webkit.org/show_bug.cgi?id=46254
 755
 756         This patch redesigns the controller logic for the commit-queue.  In the
 757         new design, the controller exercises much finer-grained control over
 758         the landing process.  In particular:
 759
 760         - Patches that fail to apply now get rejected almost immediately.
 761         - Patches that fail to build get rejects after two builds (instead of
 762           three builds and one test run).
 763         - Patches that run into a flaky test now get accepted after one build
 764           and two test runs instead of three full build-and-test runs.
 765
 766         The main cost of these optimizations is that we don't find out the tree
 767         has a failing test until the very end of the process, but if the tree
 768         has a busted test, there's not much we can do anyway.  We might as well
 769         burn commit-queue resources spinning optimisticly.
 770
 771         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
 772         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
 773         * Scripts/webkitpy/tool/commands/queues.py:
 774
 775 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
 776
 777         Reviewed by Martin Robinson.
 778
 779         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
 780         https://bugs.webkit.org/show_bug.cgi?id=46303.
 781
 782         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
 783         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
 784         WinCairo build.
 785         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
 786         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
 787         build targets that use the new InjectedBundleCFLite.vsprops file.
 788
 789 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
 790
 791         Unreviewed, build fix.
 792
 793         Fix bustage of rebaseline-chromium-webkit-tests resulting from
 794         r67974. Really need better unit tests for this tool :(
 795
 796         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 797
 798 2010-09-22  Adam Roben  <aroben@apple.com>
 799
 800         Unbreak test-webkitpy
 801
 802         * Scripts/webkitpy/test/main.py:
 803         (Tester.run_tests): Add a line that mysteriously got deleted.
 804
 805 2010-09-22  Adam Roben  <aroben@apple.com>
 806
 807         Make test-webkitpy test WebKit2's scripts
 808
 809         These scripts can't be in WebKitTools due to limitations of Apple's
 810         build process. But that doesn't mean we can't test them!
 811
 812         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
 813         WebKit2/Scripts
 814
 815         Reviewed by Adam Barth.
 816
 817         * Scripts/test-webkitpy:
 818         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
 819         Now takes an external_package_paths parameter and cleans both webkitpy
 820         and any external packages.
 821         (init): Added an external_package_paths parameter which we pass along
 822         to _clean_packages_with_test.
 823         (top level): Add WebKit2/Scripts/webkit2 as our only external package
 824         and pass it along to init and Tester.run_tests.
 825
 826         * Scripts/webkitpy/test/main.py:
 827         (Tester.run_tests): Added an optional external_package_paths
 828         parameter. We modify sys.path so that the external packages can be
 829         imported, and search for unittest files inside all external packages
 830         in addition to inside webkitpy.
 831
 832 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
 833
 834         Reviewed by Tony Chang.
 835
 836         new-run-webkit-tests: r68063 broke linux python tests
 837
 838         Add a missing "from __future__ import with_statement" to this
 839         new file; the perils of testing only on the Mac and by review :(
 840
 841         https://bugs.webkit.org/show_bug.cgi?id=46293
 842
 843         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
 844
 845 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
 846
 847         Reviewed by Tony Chang.
 848
 849         Add a 'chromium-gpu' set of ports that will test the accelerated
 850         GPU paths. This patch adds:
 851
 852         - support for the '--accelerated-compositing' and
 853           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
 854           'no-' flags)
 855         - adds a new set of Ports that will look under
 856           platform/chromium-gpu-$OS/ for baselines before looking in the
 857           regular chromium search path
 858         - adds a new test_expectations.txt file in platform/chromium-gpu
 859           that skips all but the tests we actually want to run with
 860           acceleration.
 861
 862         This patch will allow us to run both with and without acceleration
 863         and to change the defaults for both the regular and -gpu options
 864         as the code evolves.
 865
 866         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
 867         each test bot.
 868
 869         https://bugs.webkit.org/show_bug.cgi?id=46225
 870
 871         * Scripts/webkitpy/layout_tests/port/chromium.py:
 872         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
 873         * Scripts/webkitpy/layout_tests/port/factory.py:
 874         * Scripts/webkitpy/layout_tests/port/webkit.py:
 875
 876 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
 877
 878         Reviewed by Kenneth Rohde Christiansen.
 879
 880         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
 881         https://bugs.webkit.org/show_bug.cgi?id=43988
 882
 883         Runs a web debug server on port specified by QtTestBrowser
 884         argument -remote-inspector-port. Property
 885         _q_webInspectorServerPort of the QWebPage instance will be set
 886         according to the argument. All pages with that property set will
 887         be remotely inspectable.
 888
 889         URL for remote inspection of first QWebPage is
 890             http://localhost:9222/webkit/inspector/inspector.html?page=1
 891         where 1 is the number of the QWebPage instance.
 892
 893         The base URL yields an index page with links to the individual inspectors:
 894             http://localhost:9222/
 895
 896         * QtTestBrowser/launcherwindow.cpp:
 897         (LauncherWindow::init):
 898         * QtTestBrowser/launcherwindow.h:
 899         * QtTestBrowser/main.cpp:
 900         (LauncherApplication::handleUserOptions):
 901
 902 2010-09-22  Adam Roben  <aroben@apple.com>
 903
 904         Fix webkit-patch failure-reason now that build.webkit.org has been
 905         updated
 906
 907         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
 908         every time
 909
 910         Reviewed by Eric Seidel.
 911
 912         * Scripts/webkitpy/common/net/buildbot.py:
 913         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
 914         looking for an element that contains text, then returns it.
 915         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
 916         text out of the cells. This way it doesn't matter whether the cells
 917         have <b> children (as for cells in directory rows) or not (as for
 918         cells in file rows)
 919         (BuildBot._parse_twisted_directory_listing): Look for rows that have
 920         the "directory" or "file" class, rather than rows with any class,
 921         since header rows now have a class attribute.
 922
 923         * Scripts/webkitpy/common/net/buildbot_unittest.py:
 924         (BuildBotTest._example_directory_listing): Updated to more closely
 925         match the markup that build.webkit.org is producing now.
 926
 927 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
 928
 929         Unreviewed, build fix.
 930
 931         new-run-webkit-tests: fix bug introduced in r68008 where if you
 932         specify --chromium and no --platform, and you're running on
 933         windows, you use the 'chromium-win' port by default instead of the
 934         version-specific port. This breaks the buildbots.
 935
 936         It will be good for this refactoring to settle down so I can
 937         rewrite the logic for default ports and the unit tests to be
 938         clearer (and the testing more comprehensive).
 939
 940         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 941
 942 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
 943
 944         Reviewed by Adam Barth.
 945
 946         Modify the Port interface to take only a series of keyword arguments
 947         in the constructor, and modify Port/factory.get() to accomodate that,
 948         and to accept user=XXX as an argument so we can pass
 949         webkitpy.common.system.user.User objects in.
 950
 951         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
 952         to use the common routine in webkitpy.common.system.user.open_url()
 953         to display HTML files.
 954
 955         There was a routine in the Port interface to do the same thing,
 956         but I see no need for a port-specific hook for this, since it is
 957         something that will always be executed by the host environment
 958         and displaying web pages has nothing to do with running layout tests.
 959
 960         Note that new-run-webkit-tests used to use test_shell to display
 961         the page; this is potentially useful so that you can actually click
 962         from a result to the broken page; however, since DumpRenderTree
 963         doesn't support this functionality, it will be going away eventually.
 964
 965         https://bugs.webkit.org/show_bug.cgi?id=46128
 966
 967         * Scripts/webkitpy/layout_tests/port/base.py:
 968         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 969         * Scripts/webkitpy/layout_tests/port/chromium.py:
 970         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 971         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 972         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 973         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 974         * Scripts/webkitpy/layout_tests/port/dryrun.py:
 975         * Scripts/webkitpy/layout_tests/port/factory.py:
 976         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
 977         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 978         * Scripts/webkitpy/layout_tests/port/gtk.py:
 979         * Scripts/webkitpy/layout_tests/port/mac.py:
 980         * Scripts/webkitpy/layout_tests/port/qt.py:
 981         * Scripts/webkitpy/layout_tests/port/test.py:
 982         * Scripts/webkitpy/layout_tests/port/webkit.py:
 983         * Scripts/webkitpy/layout_tests/port/win.py:
 984         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 985         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 986         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 987
 988 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
 989
 990         Reviewed by Kenneth Rohde Christiansen.
 991
 992         [EFL] Get fresh theme when running EWebLauncher
 993         https://bugs.webkit.org/show_bug.cgi?id=46210
 994
 995         If user tried to run EWebLauncher outside of the build tree, it would
 996         not find the theme and fallback to the installed one. However, since
 997         EWebLauncher is not installed, we always want to take the theme from
 998         the just compiled source code. If user had never installed WebKit's
 999         EFL port it could even receive a segv since no theme would be found.
1000
1001         Now EWebLauncher does not fallback to the installed theme and CMake
1002         gives as DATA_DIR the directory of the theme it has just built.
1003
1004         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
1005         EWebLauncher.
1006         * EWebLauncher/main.c: Use only the theme from build director. Do not
1007         fallback to others as this could hide real bugs.
1008         (quit):
1009         (browserCreate):
1010         (findThemePath):
1011         (main):
1012
1013 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1014
1015         Unreviewed, build fix.
1016
1017         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
1018         it just confuses it.
1019
1020         https://bugs.webkit.org/show_bug.cgi?id=46230
1021
1022         * Scripts/webkitpy/layout_tests/port/webkit.py:
1023
1024 2010-09-21  Lucas Forschler  <lforschler@apple.com>
1025
1026         Reviewed by Stephanie Lewis.
1027
1028         Make a new buildbot for Leopard Debug Test
1029
1030         * BuildSlaveSupport/build.webkit.org-config/config.json:
1031
1032 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1033
1034         Unreviewed, build fix.
1035
1036         Fix breakage of Chromium Mac DRT port caused by r67905.
1037
1038         https://bugs.webkit.org/show_bug.cgi?id=46230
1039
1040         * Scripts/webkitpy/layout_tests/port/webkit.py:
1041
1042 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1043
1044         Unreviewed, build fix.
1045
1046         Add missing import of 'tempfile'.
1047
1048         * Scripts/webkitpy/layout_tests/port/chromium.py:
1049
1050 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
1051
1052         Reviewed by Ojan Vafai.
1053
1054         new-run-webkit-tests: pull the list of tests from the Port, and
1055            make it possible to run with no actual test files in the filesystem.
1056
1057         This set of changes allows us to delete the special
1058         webkitpy/layout_tests/data directory and test the generic code without
1059         touching the filesystem (except to write results). This speeds up
1060         test-webkitpy substantially.
1061
1062         This also cleans up and removes several code paths in the generic
1063         code and fixes some minor bugs, notably in the test_expectations
1064         parsing, which was previously fragile if the tests weren't present.
1065
1066         We also change the way we diff image results to be able to do so
1067         in memory, without relying on files. This slows down chromium
1068         test_shell, which always writes images to files, but should speed
1069         up DRT and ImageDiff-based implementations slightly.
1070
1071         Note that pulling the list of tests to run from the Port will allow
1072         ports to specify what tests to run as an inclusive list; previously
1073         you could only do this as an exclusive list by using a
1074         test_expectations file or Skipped files; nothing actually uses this
1075         feature yet and it's unclear if it should be used.
1076
1077         Note that there are no functional changes -- apart from now
1078         always printing out the location of the checksum file when we are
1079         tracing test runs -- and the total number of lines of non-test code
1080         actually drops by two.
1081
1082         There is some more cleanup that can be done in the Port/Driver
1083         interface and in some handling of filenames, but I'll save that
1084         for another change.
1085
1086         https://bugs.webkit.org/show_bug.cgi?id=45801
1087
1088         * Scripts/webkitpy/layout_tests/data/*: Removed.
1089             - no longer need special mock layout_tests_directory in the
1090               repository.
1091         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1092             - add code to display missing text files, checksums when tracing
1093             - update to not look at the filesystem directly.
1094         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1095             - add more unit tests
1096         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1097             - remove tests_are_present flag
1098             - update with changes in Port interface - no longer access
1099               the filesystem directly, although we still use os.path for
1100               filename manipulation.
1101         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1102             - add more unit tests
1103         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
1104             - renamed to port/test_files.py
1105         * Scripts/webkitpy/layout_tests/port/base.py:
1106             - change diff_image() to expect actual image data, not filenames
1107             - add expected_checksum(), expected_image(), expected_text() to
1108               return the content of the files so that we don't need a filesystem
1109             - add path_exists(), path_isdir() for filesystem-like access.
1110             - add test_dirs() to keep clobber-test-results from needing to
1111               actually look at a real layout tests dir
1112             - add tests() to return the list of tests to run on the port
1113               (calls port/test_files to do the work).
1114             - add update_baseline() to be able to save new baselines
1115             - add uri_to_test_name() from port/dryrun.py so we can easily check
1116               filename_to_uri()
1117         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1118             - add more unit tests
1119         * Scripts/webkitpy/layout_tests/port/chromium.py:
1120             - change diff_image() to accept image content, not filenames.
1121               This will be slower for test_shell/image_diff, but faster
1122               for DRT/ImageDiff.
1123         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1124             - add more unit tests
1125         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1126             - simplify greatly
1127         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1128             - add more unit tests
1129         * Scripts/webkitpy/layout_tests/port/test.py:
1130             - massive rewrite to use in-script list of tests and expectations
1131         * Scripts/webkitpy/layout_tests/port/test_files.py:
1132             - rename from layout_package/test_files.
1133         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1134             - add unit tests
1135         * Scripts/webkitpy/layout_tests/port/webkit.py:
1136             - update diff_image() to take image contents, not files. Should
1137               make things slightly faster.
1138         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1139             - update with changes to diff_image()
1140         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1141             - update with changes to diff_image()
1142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1143             - remove tests_are_present from test_expectations
1144             - pull the list of tests from port.tests() instead
1145               of calling test_files.py directly.
1146         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1147             - update unit tests
1148         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1149             - update with changes to
1150         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1151             - update with change in Port interface
1152         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1153             - update with change in Port interface
1154         * Scripts/webkitpy/style/checkers/test_expectations.py:
1155             - remove the tests_are_present flag
1156
1157 2010-09-21  Anders Carlsson  <andersca@apple.com>
1158
1159         Disable logging.
1160
1161         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1162
1163 2010-09-21  Tony Chang  <tony@chromium.org>
1164
1165         Reviewed by Kent Tamura.
1166
1167         add a script for running webkit_unit_tests
1168         https://bugs.webkit.org/show_bug.cgi?id=46014
1169
1170         * Scripts/run-chromium-webkit-unit-tests: Added.
1171
1172 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
1173
1174         Reviewed by Martin Robinson.
1175
1176         Fix linking problems on Windows.
1177         https://bugs.webkit.org/show_bug.cgi?id=45844
1178
1179         * GNUmakefile.am: link the executables with winmm.dll
1180
1181 2010-09-21  Adam Barth  <abarth@webkit.org>
1182
1183         Reviewed by Eric Seidel.
1184
1185         feeder-queue svn updates more often than needed
1186         https://bugs.webkit.org/show_bug.cgi?id=46171
1187
1188         We don't need to poll SVN every time we feed the feeders.  Rather, we
1189         can count on the wrapper shell script to auto-update the queue.
1190
1191         * Scripts/webkitpy/tool/commands/queues.py:
1192         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1193
1194 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1195
1196         Reviewed by Andreas Kling.
1197
1198         [Qt] Add robot loader timeout and extra time options.
1199         https://bugs.webkit.org/show_bug.cgi?id=46172
1200
1201         [-robot-timeout <s>]: Load the next page after s seconds if the current
1202         page didn't finish loading.
1203         [-robot-extra-time <s>]: Wait s seconds after the current page finished
1204         loading before loading the next one. This should allow some time for the
1205         page's JavaScript to execute.
1206
1207         * QtTestBrowser/launcherwindow.cpp:
1208         (LauncherWindow::applyPrefs):
1209         * QtTestBrowser/main.cpp:
1210         (LauncherApplication::robotTimeout):
1211         (LauncherApplication::robotExtraTime):
1212         (LauncherApplication::LauncherApplication):
1213         (LauncherApplication::handleUserOptions):
1214         (main):
1215         * QtTestBrowser/urlloader.cpp:
1216         (UrlLoader::UrlLoader):
1217         (UrlLoader::loadNext):
1218         (UrlLoader::loadUrlList):
1219         * QtTestBrowser/urlloader.h:
1220
1221 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
1222
1223         Unreviewed.
1224
1225         Adding myself to the committers list.
1226
1227         * Scripts/webkitpy/common/config/committers.py:
1228
1229 2010-09-20  Philippe Normand  <pnormand@igalia.com>
1230
1231         Reviewed by Eric Carlson.
1232
1233         [GTK] enhanced context menu for media elements
1234         https://bugs.webkit.org/show_bug.cgi?id=45021
1235
1236         EventSender::contextClick() now returns an array of js
1237         objects. Each object has a title property and a click() method.
1238
1239         * DumpRenderTree/gtk/EventSender.cpp:
1240         (getMenuItemTitleCallback):
1241         (setMenuItemTitleCallback):
1242         (menuItemClickCallback):
1243         (getMenuItemClass):
1244         (contextClickCallback):
1245
1246 2010-09-20  Hayato Ito  <hayato@chromium.org>
1247
1248         Unreviewed.
1249         Adding myself to the committers list.
1250
1251         * Scripts/webkitpy/common/config/committers.py:
1252
1253 2010-09-20  Adam Barth  <abarth@webkit.org>
1254
1255         Reviewed by Eric Seidel.
1256
1257         The tool member variable should be called _tool
1258         https://bugs.webkit.org/show_bug.cgi?id=46160
1259
1260         Created by find-and-replace.
1261
1262         * Scripts/webkitpy/tool/commands/download.py:
1263         * Scripts/webkitpy/tool/commands/openbugs.py:
1264         * Scripts/webkitpy/tool/commands/queries.py:
1265         * Scripts/webkitpy/tool/commands/queues.py:
1266         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1267         * Scripts/webkitpy/tool/commands/rebaseline.py:
1268         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1269         * Scripts/webkitpy/tool/commands/upload.py:
1270         * Scripts/webkitpy/tool/multicommandtool.py:
1271
1272 2010-09-20  Adam Barth  <abarth@webkit.org>
1273
1274         I ran the tests before landing but ignored the fact that they failed.  :(
1275
1276         * Scripts/webkitpy/tool/commands/queues.py:
1277
1278 2010-09-20  Adam Barth  <abarth@webkit.org>
1279
1280         Reviewed by Eric Seidel.
1281
1282         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
1283         https://bugs.webkit.org/show_bug.cgi?id=46141
1284
1285         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
1286         list of work items on the status server.  The individual commit-cluster
1287         nodes then grab the patches from the server and process them.
1288
1289         * Scripts/webkitpy/tool/bot/feeders.py: Added.
1290         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
1291         * Scripts/webkitpy/tool/commands/queues.py:
1292         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1293         * Scripts/webkitpy/tool/commands/queuestest.py:
1294
1295 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
1296
1297         Reviewed by Darin Adler.
1298
1299         build-webkit: Add support for CMake build system
1300         https://bugs.webkit.org/show_bug.cgi?id=44979
1301
1302         * Scripts/build-webkit: Add "--efl" command-line option to build the
1303         EFL port of WebKit.
1304         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
1305         buildEflCMakeProject() subroutines.
1306
1307 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
1308
1309         Reviewed by Ojan Vafai.
1310
1311         new-run-webkit-tests: refactor command line args getting passed to DRT
1312
1313         This change cleans up some argument parsing between functions to get
1314         rid of some overlapping data structures. There should be no functional
1315         changes in this patch; it is pure refactoring in preparation for
1316         landing the Chrome GPU port and adding a generic way to pass
1317         args to DRT/TestShell.
1318
1319         https://bugs.webkit.org/show_bug.cgi?id=46135
1320
1321         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1322           - pass the options argument explicitly to the threads and drivers,
1323             also consolidate the passing of options to the driver.
1324           - pass options directly to process_output() to remove a couple
1325             parameters (minor cleanup).
1326         * Scripts/webkitpy/layout_tests/port/base.py:
1327           - pass the options argument to Port.create_driver().
1328         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1329           - update Port.create_driver() test
1330         * Scripts/webkitpy/layout_tests/port/chromium.py:
1331           - pass the options argument to Port.create_driver(), and clean up
1332             building of the cmd line for DRT.
1333         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1334           - pass the options argument to Port.create_driver()
1335         * Scripts/webkitpy/layout_tests/port/test.py:
1336           - pass the options argument to Port.create_driver()
1337         * Scripts/webkitpy/layout_tests/port/webkit.py:
1338           - pass the options argument to Port.create_driver(), and clean up
1339             building of the cmd line for DRT.
1340         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1341           - consolidate args in _get_dump_render_tree_args and rename to
1342             _get_test_args(); move all of the command-line args to the
1343             Port implementations.
1344
1345 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
1346
1347         Revert change which was accidentally committed along with some expectation changes.
1348
1349         * Scripts/webkitpy/layout_tests/port/base.py:
1350
1351 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1352
1353         Reviewed by Adam Barth.
1354
1355         Add explicit --force-patch flag to webkitpy tools
1356         https://bugs.webkit.org/show_bug.cgi?id=46103
1357
1358         It wasn't obvious until I read the applypatch.py source code that
1359         --non-interfactive implies passing --force to patch. Add --force-patch
1360         as an alias to the flag, so that this behavior is more discoverable.
1361
1362         * Scripts/webkitpy/tool/steps/applypatch.py:
1363         * Scripts/webkitpy/tool/steps/options.py:
1364
1365 2010-09-20  Eric Seidel  <eric@webkit.org>
1366
1367         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
1368
1369         commit-queue can't land patches
1370         https://bugs.webkit.org/show_bug.cgi?id=46138
1371
1372         Add a line of code I forgot in my last commit.
1373
1374         * Scripts/webkitpy/common/net/bugzilla.py:
1375         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1376
1377 2010-09-20  Adam Barth  <abarth@webkit.org>
1378
1379         Reviewed by Eric Seidel.
1380
1381         The commit-cluster bots still race to lock patch_ids
1382         https://bugs.webkit.org/show_bug.cgi?id=46130
1383
1384         It turns out we need to use a transaction object to make the
1385         read/modify/write lock operation atomic.  From reading the AppEngine
1386         documentation, I think this patch should do what we want.  It's hard to
1387         test locally because the test instance isn't distributed in the same
1388         way the production instance is.
1389
1390         * QueueStatusServer/handlers/nextpatch.py:
1391         * QueueStatusServer/model/activeworkitems.py: Added.
1392
1393 2010-09-20  Andy Estes  <aestes@apple.com>
1394
1395         Reviewed by Adam Barth.
1396
1397         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
1398         https://bugs.webkit.org/show_bug.cgi?id=40961
1399
1400         Implement WebKitUsePreHTML5ParserQuirks preference.
1401
1402         * DumpRenderTree/mac/DumpRenderTree.mm:
1403         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
1404         to false after a test finishes.
1405
1406 2010-09-20  Adam Roben  <aroben@apple.com>
1407
1408         Windows build fix
1409
1410         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
1411         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
1412         we'll pick up the most recent versions of the headers.
1413
1414 2010-09-20  Eric Seidel  <eric@webkit.org>
1415
1416         Reviewed by Adam Barth.
1417
1418         commit-queue should check commit-queue+ again just before committing
1419         https://bugs.webkit.org/show_bug.cgi?id=32679
1420
1421         Added a _revalidate_patch check, right before landing.
1422
1423         Since _revalidate_patch passes the patch_id from the work item
1424         back to bugzilla, I had to fix all of the previous queue tests to
1425         use valid attachment ids (that's the majority of this change).
1426
1427         In order to validate that the bug was still open, I had to teach
1428         bugzilla.Bug about open/closed states.
1429
1430         * Scripts/webkitpy/common/net/bugzilla.py:
1431         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1432         * Scripts/webkitpy/tool/commands/queues.py:
1433         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1434         * Scripts/webkitpy/tool/commands/queuestest.py:
1435         * Scripts/webkitpy/tool/mocktool.py:
1436
1437 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1438
1439         Unreviewed.
1440
1441         Adding myself as a comitter.
1442
1443         * Scripts/webkitpy/common/config/committers.py:
1444
1445 2010-09-20  Adam Barth  <abarth@webkit.org>
1446
1447         Reviewed by Eric Seidel.
1448
1449         Two instances of commit-queue try to process the same patch
1450         https://bugs.webkit.org/show_bug.cgi?id=46113
1451
1452         This patch makes next-patch atomic so that the server won't vend the
1453         same patch twice in the same hour.
1454
1455         * QueueStatusServer/handlers/nextpatch.py:
1456
1457 2010-09-20  Adam Roben  <aroben@apple.com>
1458
1459         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
1460
1461         We were previously trying to use a CFRunLoopTimer, but since Windows
1462         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
1463         Windows-style timer on Windows.
1464
1465         I also replaced all uses of "watchdog" with "watchdog timer".
1466
1467         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
1468         watchdog timer doesn't work on Windows
1469
1470         Reviewed by Anders Carlsson.
1471
1472         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1473         (WTR::InjectedBundlePage::dump): Updated for rename.
1474
1475         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
1476         platform-specific functions.
1477         (WTR::LayoutTestController::LayoutTestController): Added call to
1478         platformInitialize.
1479         (WTR::LayoutTestController::waitUntilDone): Changed to call
1480         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
1481         right in this function.
1482         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
1483         rename.
1484
1485         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
1486         members needed to support the watchdog timer abstraction. Replaced
1487         some "watchdog"s with "watchdog timer".
1488
1489         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1490         Added.
1491         (WTR::LayoutTestController::platformInitialize): Does nothing on this
1492         platform.
1493         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
1494         from LayoutTestController.cpp and changed to use an early return.
1495         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
1496         LayoutTestController.cpp.
1497         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1498         Moved code here from LayoutTestController::waitUntilDone and changed
1499         to use an early return.
1500
1501         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1502         Added.
1503         (WTR::LayoutTestController::platformInitialize): Initialize our
1504         watchdog timer.
1505         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
1506         Kills and clears the watchdog timer.
1507         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
1508         LayoutTestController member function of the same name.
1509         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1510         Added. Sets up the timer if it isn't already set.
1511
1512         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
1513         LayoutTestControllerMac.mm.
1514
1515         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
1516         LayoutTestControllerWin.cpp.
1517
1518 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
1519
1520         Reviewed by Daniel Bates.
1521
1522         [GTK] fast/forms/listbox-selection.html fails
1523         https://bugs.webkit.org/show_bug.cgi?id=45942
1524
1525         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
1526         strings in keyDownCallback.
1527
1528         * DumpRenderTree/gtk/EventSender.cpp:
1529         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the
1530         modifier parsing logic.
1531
1532 2010-09-19  Sam Weinig  <sam@webkit.org>
1533
1534         Reviewed by Anders Carlsson.
1535
1536         WebKit2 decidePolicyForNavigationAction should include mouse button information
1537         <rdar://problem/8413165>
1538         https://bugs.webkit.org/show_bug.cgi?id=46060
1539
1540         * MiniBrowser/mac/BrowserWindowController.m:
1541         (decidePolicyForNavigationAction):
1542         (decidePolicyForNewWindowAction):
1543
1544 2010-09-19  Daniel Bates  <dbates@rim.com>
1545
1546         Reviewed by Martin Robinson.
1547
1548         Add unit tests for diffs that delete or modify a change log entry
1549         or describe changes that are far apart
1550         https://bugs.webkit.org/show_bug.cgi?id=46046
1551
1552         Add additional unit tests to test change log diffs that contain
1553         deletions or changes that are far apart from each other in the
1554         ChangeLog file.
1555
1556         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1557           - Added the following unit tests:
1558           "fixChangeLogPatch: [no change] In-place change."
1559           "fixChangeLogPatch: [no change] Remove first entry."
1560           "fixChangeLogPatch: [no change] Remove entry in the middle."
1561           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
1562
1563 2010-09-19  Sam Weinig  <sam@webkit.org>
1564
1565         Reviewed by Anders Carlsson.
1566
1567         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
1568         https://bugs.webkit.org/show_bug.cgi?id=46054
1569
1570         The new one acts like WKBundleNodeHandleRef and allows for getting a
1571         wrapper in a specific world for the handle.
1572
1573         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1574         (WTR::propertyValue):
1575         (WTR::propertyValueDouble):
1576         (WTR::propertyValueInt):
1577         (WTR::numericWindowPropertyValue):
1578         (WTR::toStr):
1579         (WTR::InjectedBundlePage::shouldBeginEditing):
1580         (WTR::InjectedBundlePage::shouldEndEditing):
1581         (WTR::InjectedBundlePage::shouldInsertNode):
1582         (WTR::InjectedBundlePage::shouldInsertText):
1583         (WTR::InjectedBundlePage::shouldDeleteRange):
1584         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1585         (WTR::InjectedBundlePage::shouldApplyStyle):
1586         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1587
1588 2010-09-19  Kent Tamura  <tkent@chromium.org>
1589
1590         Unreviewed. Fix WebGL test regressions by r67809.
1591
1592         * DumpRenderTree/chromium/WebPreferences.cpp:
1593         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
1594
1595 2010-09-19  Kent Tamura  <tkent@chromium.org>
1596
1597         Reviewed by Adam Barth.
1598
1599         [DRT/Chromium] Fix a WebSettings handling bug
1600         https://bugs.webkit.org/show_bug.cgi?id=45945
1601
1602         Before this change, Chromium DRT reset WebSettings for every new
1603         window. It was wrong.
1604         If new window is not the first one, we have to apply the same
1605         settings as the first window.  So, we introduce WebPreference to
1606         store the current settings, and apply it to new windows. It's same
1607         as test_shell's behavior.
1608
1609         * DumpRenderTree/DumpRenderTree.gypi:
1610         * DumpRenderTree/chromium/LayoutTestController.cpp:
1611           Use WebPreferences instead of WebSettings.
1612         (LayoutTestController::setUserStyleSheetEnabled):
1613         (LayoutTestController::setUserStyleSheetLocation):
1614         (LayoutTestController::setAuthorAndUserStylesEnabled):
1615         (LayoutTestController::setPopupBlockingEnabled):
1616         (LayoutTestController::disableImageLoading):
1617         (LayoutTestController::setJavaScriptCanAccessClipboard):
1618         (LayoutTestController::setXSSAuditorEnabled):
1619         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1620         (LayoutTestController::setAllowFileAccessFromFileURLs):
1621         (LayoutTestController::overridePreference):
1622         (LayoutTestController::setEditingBehavior):
1623         * DumpRenderTree/chromium/TestShell.cpp:
1624         (TestShell::resetWebSettings): Use WebPreferences.
1625         (TestShell::runFileTest): ditto.
1626         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
1627         * DumpRenderTree/chromium/TestShell.h:
1628         (TestShell::preferences):
1629         (TestShell::applyPreferences):
1630         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
1631         * DumpRenderTree/chromium/WebPreferences.h: Added.
1632
1633 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
1634
1635         Reviewed by David Levin.
1636
1637         update-webkit --chromium spitting out a spurious error
1638         https://bugs.webkit.org/show_bug.cgi?id=45868
1639
1640         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
1641
1642 2010-09-18  Sam Weinig  <sam@webkit.org>
1643
1644         Reviewed by Dan Bernstein.
1645
1646         Improve/unify the PageLoadClient interfaces
1647         https://bugs.webkit.org/show_bug.cgi?id=46043
1648
1649         * MiniBrowser/mac/BrowserWindowController.m:
1650         (didStartProvisionalLoadForFrame):
1651         (didReceiveServerRedirectForProvisionalLoadForFrame):
1652         (didFailProvisionalLoadWithErrorForFrame):
1653         (didCommitLoadForFrame):
1654         (didFinishDocumentLoadForFrame):
1655         (didFinishLoadForFrame):
1656         (didFailLoadWithErrorForFrame):
1657         (didReceiveTitleForFrame):
1658         (didFirstLayoutForFrame):
1659         (didFirstVisuallyNonEmptyLayoutForFrame):
1660         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1661         (WTR::InjectedBundlePage::InjectedBundlePage):
1662         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1663         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1664         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1665         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1666         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1667         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1668         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1669         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1670         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1671         * WebKitTestRunner/TestController.cpp:
1672         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1673         (WTR::TestController::didFinishLoadForFrame):
1674         * WebKitTestRunner/TestController.h:
1675
1676 2010-09-17  Eric Seidel  <eric@webkit.org>
1677
1678         Unreviewed.  Adding a shell script I use to run the
1679         commit-queue. Now that multiple machines run the cq,
1680         it makes sense to share the script between them.
1681
1682         * EWSTools/start-commit-queue.sh: Added.
1683
1684 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
1685
1686         Reviewed by Jon Honeycutt.
1687
1688         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
1689         slightly harder to read, so this reverts the previous background colors for various
1690         states, making it easier to read.
1691
1692         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1693         (.success):
1694         (.failure):
1695         (.warnings):
1696         (.exception):
1697         (.start,.running,td.building):
1698         (.offline,td.offline):
1699
1700 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
1701
1702         Unreviewed, rolling out r67692.
1703         http://trac.webkit.org/changeset/67692
1704         https://bugs.webkit.org/show_bug.cgi?id=46011
1705
1706         broke layout test dashboard (Requested by johnny_g on
1707         #webkit).
1708
1709         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1710         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1711         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1712
1713 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
1714
1715         Reviewed by Oliver Hunt.
1716
1717         Style bot complains about cairo forward declaration naming
1718         https://bugs.webkit.org/show_bug.cgi?id=45867
1719
1720         Exclude Cairo forward declarations from indentifiers with underscores checks.
1721
1722         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
1723         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1724
1725 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
1726
1727         Reviewed by Ojan Vafai.
1728
1729         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
1730         https://bugs.webkit.org/show_bug.cgi?id=45408
1731
1732         This change also tries to remove duplicated upload_results_json methods
1733         in run_webkit_tests.py and json_results_generator.py.
1734
1735         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1736         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1738
1739 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
1740
1741         Reviewed by Andreas Kling.
1742
1743         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
1744
1745         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
1746         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
1747         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
1748         all page specific stuff to the UI.
1749
1750         * QtTestBrowser/launcherwindow.cpp:
1751         (LauncherWindow::initializeView):
1752         * QtTestBrowser/mainwindow.cpp:
1753         (MainWindow::MainWindow):
1754         (MainWindow::buildUI):
1755         (MainWindow::setPage):
1756         * QtTestBrowser/mainwindow.h:
1757
1758 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1759
1760         Reviewed by Andreas Kling.
1761
1762         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
1763
1764         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
1765         object will move to the qgraphicsscene instead of the qgraphicsview.
1766
1767         * QtTestBrowser/webview.cpp:
1768         (WebViewGraphicsBased::setPage):
1769         (WebViewGraphicsBased::setResizesToContents):
1770         (WebViewGraphicsBased::resizeEvent):
1771         (WebViewGraphicsBased::animatedFlip):
1772         * QtTestBrowser/webview.h:
1773         (WebViewGraphicsBased::setItemCacheMode):
1774         (WebViewGraphicsBased::itemCacheMode):
1775
1776 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1777
1778         Reviewed by Andreas Kling.
1779
1780         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
1781
1782         We usually separate methods whose body are larger than a few lines from the class definition.
1783
1784         * QtTestBrowser/webview.h:
1785         (WebViewGraphicsBased::yRotation):
1786         (WebViewGraphicsBased::setYRotation):
1787
1788 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1789
1790         Reviewed by Andreas Kling.
1791
1792         Make initializeView method of LauncherWindow private.
1793
1794         No one else needs to be able to call it but LauncherWindow.
1795         Also moving the declation of isGraphicsBased method down in the same file, in order
1796         to better group related methods.
1797
1798         * QtTestBrowser/launcherwindow.h:
1799
1800 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1801
1802         Reviewed by Andreas Kling.
1803
1804         Make the getter 'page' method of MainWindow const.
1805
1806         * QtTestBrowser/mainwindow.cpp:
1807         (MainWindow::page):
1808         * QtTestBrowser/mainwindow.h:
1809
1810 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
1811
1812         Reviewed by Andreas Kling.
1813
1814         Remove useless parameter from MainWindow class' constructor.
1815
1816         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
1817         not referred in the constructor body and does not make much sense.
1818
1819         * QtTestBrowser/mainwindow.cpp:
1820         (MainWindow::MainWindow):
1821         * QtTestBrowser/mainwindow.h:
1822
1823 2010-09-15  Tony Chang  <tony@chromium.org>
1824
1825         Reviewed by Kent Tamura.
1826
1827         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
1828         https://bugs.webkit.org/show_bug.cgi?id=42151
1829
1830         * DumpRenderTree/chromium/LayoutTestController.cpp:
1831         (LayoutTestController::LayoutTestController):
1832         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1833         (WorkItemLoadHTMLString::run):
1834         (LayoutTestController::queueLoadHTMLString):
1835         (LayoutTestController::reset):
1836         (LayoutTestController::setDeferMainResourceDataLoad):
1837         * DumpRenderTree/chromium/LayoutTestController.h:
1838         (LayoutTestController::deferMainResourceDataLoad):
1839         * DumpRenderTree/chromium/WebViewHost.cpp:
1840         (WebViewHost::didCreateDataSource):
1841
1842 2010-09-16  Adrienne Walker  <enne@google.com>
1843
1844         Reviewed by Kenneth Russell.
1845
1846         Add script to synchronize WebKit and Khronos WebGL tests
1847         https://bugs.webkit.org/show_bug.cgi?id=42336
1848
1849         * Scripts/update-webgl-conformance-tests: Added.
1850         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
1851         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
1852
1853 2010-09-16  Sam Weinig  <sam@webkit.org>
1854
1855         Reviewed by Anders Carlsson.
1856
1857         Add support for sending synchronous messages from the InjectedBundle to the WKContext
1858         <rdar://problem/8365320>
1859         https://bugs.webkit.org/show_bug.cgi?id=44785
1860
1861         * MiniBrowser/mac/AppDelegate.m:
1862         (didReceiveSynchronousMessageFromInjectedBundle):
1863         (-[BrowserAppDelegate init]):
1864         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1865         (didCreatePage):
1866         * WebKitTestRunner/TestController.cpp:
1867         (WTR::TestController::initialize):
1868
1869 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
1870
1871         Reviewed by Andreas Kling.
1872
1873         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
1874         https://bugs.webkit.org/show_bug.cgi?id=45885
1875
1876         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
1877
1878         * QtTestBrowser/launcherwindow.cpp:
1879         (LauncherWindow::screenshot):
1880
1881 2010-09-16  Anders Carlsson  <andersca@apple.com>
1882
1883         Fix clang++ build.
1884
1885         * MiniBrowser/mac/BrowserWindowController.m:
1886         (-[BrowserWindowController zoomIn:]):
1887         (-[BrowserWindowController zoomOut:]):
1888         (-[BrowserWindowController resetZoom:]):
1889         Remove trailing semicolons.
1890
1891 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1892
1893         Unreviewed, rolling out r67628.
1894         http://trac.webkit.org/changeset/67628
1895         https://bugs.webkit.org/show_bug.cgi?id=45904
1896
1897         broke the build (Requested by eric_carlson on #webkit).
1898
1899         * DumpRenderTree/gtk/EventSender.cpp:
1900         (contextClickCallback):
1901
1902 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
1903
1904         Unreviewed.
1905
1906         Adding myself as a comitter.
1907
1908         * Scripts/webkitpy/common/config/committers.py:
1909
1910 2010-09-15  Philippe Normand  <pnormand@igalia.com>
1911
1912         Reviewed by Eric Carlson.
1913
1914         [GTK] enhanced context menu for media elements
1915         https://bugs.webkit.org/show_bug.cgi?id=45021
1916
1917         EventSender::contextClick() now returns an array of js
1918         objects. Each object has a title property and a click() method.
1919
1920         * DumpRenderTree/gtk/EventSender.cpp:
1921         (getMenuItemTitleCallback):
1922         (setMenuItemTitleCallback):
1923         (menuItemClickCallback):
1924         (getMenuItemClass):
1925         (contextClickCallback):
1926
1927 2010-09-14  Philippe Normand  <pnormand@igalia.com>
1928
1929         Reviewed by Eric Carlson and Martin Robinson.
1930
1931         [GTK] eventSender.contextClick() should return the contents of the context menu
1932         https://bugs.webkit.org/show_bug.cgi?id=39102
1933
1934         Make the eventSender use the new private WebKitGtk+ API to
1935         retrieve the context-menu item titles and store them in an array.
1936
1937         * DumpRenderTree/gtk/EventSender.cpp:
1938         (contextClickCallback):
1939
1940 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
1941
1942         Reviewed by Jian Li.
1943
1944         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
1945         https://bugs.webkit.org/show_bug.cgi?id=45798
1946
1947         * Scripts/build-webkit:
1948
1949 2010-09-16  Robert Hogan  <robert@webkit.org>
1950
1951         Reviewed by Antonio Gomes.
1952
1953         [Qt] Support globalhistory tests
1954         https://bugs.webkit.org/show_bug.cgi?id=45774
1955
1956         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1957         (WebCore::isGlobalHistoryTest):
1958         (WebCore::DumpRenderTree::open):
1959         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1960         (LayoutTestController::reset):
1961         (LayoutTestController::dumpHistoryCallbacks):
1962         (LayoutTestController::removeAllVisitedLinks):
1963         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1964
1965 2010-09-10  Tony Chang  <tony@chromium.org>
1966
1967         Reviewed by Eric Seidel.
1968
1969         deduplicate-tests should be runnable from any WebKit directory
1970         https://bugs.webkit.org/show_bug.cgi?id=44709
1971
1972         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1973         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1974
1975 2010-09-15  Tony Chang  <tony@chromium.org>
1976
1977         Reviewed by Kent Tamura.
1978
1979         [chromium] sort testing methods in DRT
1980         https://bugs.webkit.org/show_bug.cgi?id=45850
1981
1982         * DumpRenderTree/chromium/EventSender.cpp:
1983         (EventSender::EventSender):
1984         * DumpRenderTree/chromium/LayoutTestController.cpp:
1985         (LayoutTestController::LayoutTestController):
1986         * DumpRenderTree/chromium/TextInputController.cpp:
1987         (TextInputController::TextInputController):
1988
1989 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
1990
1991         Reviewed by Adam Barth.
1992
1993         CQ status shows items out of order
1994         https://bugs.webkit.org/show_bug.cgi?id=45846
1995
1996         Only group consecutive status items with the same patch ID into the same
1997         group, so that overall item ordering is preserved.
1998
1999         Also don't indent status items that only have a single item in their
2000         group.
2001
2002         * QueueStatusServer/handlers/queuestatus.py:
2003         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
2004         * QueueStatusServer/templates/queuestatus.html:
2005
2006 2010-09-15  Eric Seidel  <eric@webkit.org>
2007
2008         Reviewed by Adam Barth.
2009
2010         Add queue start/stop messages
2011         https://bugs.webkit.org/show_bug.cgi?id=45853
2012
2013         I ended up needing to clean up a bunch of our unit testing
2014         in order to test this new code path nicely.
2015
2016         There are also a few PEP8 changes needed to pass check-webkit-style.
2017
2018         * Scripts/webkitpy/tool/bot/queueengine.py:
2019         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2020         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2021         * Scripts/webkitpy/tool/commands/queues.py:
2022         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2023         * Scripts/webkitpy/tool/commands/queuestest.py:
2024         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2025
2026 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
2027
2028         https://bugs.webkit.org/show_bug.cgi?id=45849
2029         WKURLCreateWithCFURL crashes with null url
2030
2031         Fix MiniBrowser crash when the url is not parseable.
2032
2033         * MiniBrowser/mac/BrowserWindowController.m:
2034         (-[BrowserWindowController fetch:]):
2035
2036 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
2037
2038         Unreviewed.
2039
2040         Adding myself to the committers list.
2041
2042         * Scripts/webkitpy/common/config/committers.py:
2043
2044 2010-09-14  Eric Seidel  <eric@webkit.org>
2045
2046         Reviewed by Adam Barth.
2047
2048         Make it possible to run more than one commit-queue instance
2049         https://bugs.webkit.org/show_bug.cgi?id=45786
2050
2051         Mostly we need to make sure the two (or more) instances get
2052         different patches to work on.  To do this, I re-worked
2053         the code responsible for getting the next work item to
2054         round trip through the status server.  The status server only
2055         vends patches from the work items list, only if those patches
2056         have not had status reported for them in the last hour.
2057
2058         This is another step towards making all queues go through the
2059         status server, thus making it possible to run more than one
2060         instance of various EWS bots (as requested in bug 44292).
2061
2062         The webkitpy changes are already covered by existing unit tests.
2063         The QueueStatusSever sadly has no testing infrastructure yet. :(
2064
2065         * QueueStatusServer/handlers/nextpatch.py: Added.
2066         * QueueStatusServer/index.yaml:
2067         * QueueStatusServer/main.py:
2068         * Scripts/webkitpy/tool/commands/queues.py:
2069
2070 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
2071
2072         Reviewed by Tony Chang.
2073
2074         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
2075         https://bugs.webkit.org/show_bug.cgi?id=45791
2076
2077         Force filenames to be raw bytes before running difflib.unified_diff.
2078
2079         * Scripts/webkitpy/layout_tests/port/base.py:
2080         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2081
2082 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
2083
2084         Reviewed by Tor Arne Vestbø.
2085
2086         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
2087         https://bugs.webkit.org/show_bug.cgi?id=35247
2088
2089         The main issue when changing the views is that the plugins and any other components that
2090         depend on view specific attributes such as the native window id are not teared down.
2091         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
2092         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
2093         we decided to work around this in QtTestBrowser by making toggling between QWebView
2094         and QGraphicsWebView also re-create the page.
2095
2096         * QtTestBrowser/launcherwindow.cpp:
2097         (LauncherWindow::initializeView):
2098         * QtTestBrowser/mainwindow.h:
2099
2100 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
2101
2102         Reviewed by Adam Barth.
2103
2104         Send webkit accessibility notifications to Chromium
2105         https://bugs.webkit.org/show_bug.cgi?id=45156
2106
2107         Move printf inside shouldDumpAccessibilityNotifications check.
2108
2109         * DumpRenderTree/chromium/WebViewHost.cpp:
2110         (WebViewHost::postAccessibilityNotification):
2111
2112 2010-09-14  Tony Chang  <tony@chromium.org>
2113
2114         Reviewed by Kent Tamura.
2115
2116         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
2117         https://bugs.webkit.org/show_bug.cgi?id=45788
2118
2119         * DumpRenderTree/chromium/LayoutTestController.cpp:
2120         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
2121
2122 2010-09-14  Tony Chang  <tony@chromium.org>
2123
2124         Reviewed by Ojan Vafai.
2125
2126         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
2127         https://bugs.webkit.org/show_bug.cgi?id=45768
2128
2129         * DumpRenderTree/chromium/TestShell.cpp:
2130         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
2131
2132 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2133
2134         [wx] Build fix, add newly added directories to the directory list.
2135
2136         * wx/build/settings.py:
2137
2138 2010-09-14  Sam Weinig  <sam@webkit.org>
2139
2140         Reviewed by Anders Carlsson.
2141
2142         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
2143         https://bugs.webkit.org/show_bug.cgi?id=45785
2144
2145         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2146         (WTR::propertyValue):
2147         (WTR::numericWindowPropertyValue):
2148         (WTR::dumpPath):
2149         (WTR::toStr):
2150         (WTR::operator<<):
2151         (WTR::InjectedBundlePage::InjectedBundlePage):
2152         (WTR::InjectedBundlePage::shouldInsertNode):
2153         (WTR::InjectedBundlePage::shouldBeginEditing):
2154         (WTR::InjectedBundlePage::shouldEndEditing):
2155         (WTR::InjectedBundlePage::shouldInsertText):
2156         (WTR::InjectedBundlePage::shouldDeleteRange):
2157         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2158         (WTR::InjectedBundlePage::shouldApplyStyle):
2159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2160
2161 2010-09-14  Adam Barth  <abarth@webkit.org>
2162
2163         Fix two typos in commit-queue.  The first is harmless.  The second
2164         causes the queue to reject patches when the build is broken.  :(
2165
2166         * Scripts/webkitpy/tool/commands/queues.py:
2167         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2168
2169 2010-09-14  Chris Guillory   <chris.guillory@google.com>
2170
2171         Reviewed by Chris Fleizach.
2172
2173         Send all accessibility notifications to Chromium.
2174         https://bugs.webkit.org/show_bug.cgi?id=45156
2175
2176         * DumpRenderTree/chromium/WebViewHost.cpp:
2177         (WebViewHost::postAccessibilityNotification):
2178         * DumpRenderTree/chromium/WebViewHost.h:
2179
2180 2010-09-14  Adam Barth  <abarth@webkit.org>
2181
2182         Reviewed by Eric Seidel.
2183
2184         commit-queue is slow during the day
2185         https://bugs.webkit.org/show_bug.cgi?id=45780
2186
2187         Thanks to the new logging, we've noticed that checkout-is-out-of-date
2188         errors in the first pass of landing don't retry the land.  Instead,
2189         they're treated as failures and cause the commit-queue to do two more
2190         builds before really trying to land the patch.  Worse, in the second
2191         build, we can get bitten by a flaky test.
2192
2193         This patch takes a slightly different approach to the commit-queue's
2194         main control logic.  We now use a separate subprocess for building and
2195         testing and for landing.  This means we should very rarely see the
2196         checkout-is-out-of-date error, and when we do see it, we should retry
2197         more quickly.  If my understanding is correct, this should be a big
2198         speed win for the commit-queue.
2199
2200         * Scripts/webkitpy/tool/commands/download.py:
2201         * Scripts/webkitpy/tool/commands/queues.py:
2202         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2203
2204 2010-09-14  Tony Chang  <tony@chromium.org>
2205
2206         Reviewed by Dimitri Glazkov.
2207
2208         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
2209         https://bugs.webkit.org/show_bug.cgi?id=45762
2210
2211         * DumpRenderTree/chromium/LayoutTestController.cpp:
2212         (LayoutTestController::LayoutTestController):
2213         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2214         * DumpRenderTree/chromium/LayoutTestController.h:
2215
2216 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
2217
2218         Adding myself as a reviewer.
2219
2220         * Scripts/webkitpy/common/config/committers.py:
2221
2222 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
2223
2224         Reviewed by Kenneth Rohde Christiansen.
2225
2226         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
2227         https://bugs.webkit.org/show_bug.cgi?id=45736
2228
2229         Build-webkit has showed a warning when WebKitBuild didn't exist, add
2230         an additional condition to avoid it.
2231
2232         * Scripts/build-webkit:
2233
2234 2010-09-13  Eric Seidel  <eric@webkit.org>
2235
2236         Reviewed by Adam Barth.
2237
2238         commit-queue should log when it's retrying due to checkout out of date error
2239         https://bugs.webkit.org/show_bug.cgi?id=45725
2240
2241         This will allow us to better track how often we see these errors
2242         and how long it takes the queue to recover from them.
2243
2244         In order to pass the tests, I had to correct an error
2245         from a previous change.  The UnitTestPort should not have
2246         ever been using the base port method as that will read
2247         a file from disk.  If the unit tests haven't passed the contents
2248         it should raise an IOError as though the file doesn't exist.
2249
2250         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2251         * Scripts/webkitpy/tool/commands/queues.py:
2252         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2253
2254 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
2255
2256         Reviewed by Adam Barth.
2257
2258         Upload results when cq patch landing fails
2259         https://bugs.webkit.org/show_bug.cgi?id=45683
2260
2261         Include script errors when CommitQueue._land fails.
2262
2263         * Scripts/webkitpy/tool/commands/queues.py:
2264
2265 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2266
2267         Reviewed by David Kilzer.
2268
2269         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
2270         https://bugs.webkit.org/show_bug.cgi?id=45548
2271
2272         * DumpRenderTree/AccessibilityUIElement.cpp:
2273         (isIgnoredCallback):
2274         (AccessibilityUIElement::getJSClass):
2275         * DumpRenderTree/AccessibilityUIElement.h:
2276         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2277         (AccessibilityUIElement::isIgnored):
2278         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2279         (AccessibilityUIElement::isIgnored):
2280         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2281         (AccessibilityUIElement::isIgnored):
2282
2283 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
2284
2285         Reviewed by Andreas Kling.
2286
2287         jscPath() is incorrect in Windows' cmd.exe shell
2288         https://bugs.webkit.org/show_bug.cgi?id=45651
2289
2290         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
2291
2292 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2293
2294         Reviewed by Darin Adler.
2295
2296         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
2297         https://bugs.webkit.org/show_bug.cgi?id=43807
2298
2299         * DumpRenderTree/AccessibilityUIElement.cpp:
2300         (textMarkerForPointCallback):
2301         (AccessibilityUIElement::textMarkerForPoint):
2302         (AccessibilityUIElement::getJSClass):
2303         * DumpRenderTree/AccessibilityUIElement.h:
2304         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2305         (AccessibilityUIElement::textMarkerForPoint):
2306
2307 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
2308
2309         Reviewed by Kenneth Rohde Christiansen.
2310
2311         [Qt] build-webkit: Add --v8 option to build against V8
2312
2313         Note that V8 is picked up from QtScript, so this currently requires building
2314         against the experimental qt-script-v8 branch.
2315
2316         * Scripts/build-webkit:
2317
2318 2010-09-13  Hans Wennborg  <hans@chromium.org>
2319
2320         Reviewed by Jeremy Orlow.
2321
2322         Add WebDeviceOrientationClientMock::create() and use it from DRT.
2323         https://bugs.webkit.org/show_bug.cgi?id=45650
2324
2325         Do not use the WebDeviceOrientationClientMock constructor directly,
2326         but use the create() member function.
2327
2328         This should fix the linker errors for the multi-DLL Chromium DRT build.
2329
2330         * DumpRenderTree/chromium/LayoutTestController.cpp:
2331         (LayoutTestController::setMockDeviceOrientation):
2332         (LayoutTestController::deviceOrientationClient):
2333
2334 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2335
2336         Reviewed by Antti Koivisto.
2337
2338         Add support for testing the viewport meta tag algorithm,
2339         based on the following draft spec:
2340
2341         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
2342
2343         Add common handling of viewport meta tag based on new Opera spec
2344         https://bugs.webkit.org/show_bug.cgi?id=44201
2345
2346         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2347         (LayoutTestController::dumpConfigurationForViewport):
2348         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2349
2350 2010-09-12  Kent Tamura  <tkent@chromium.org>
2351
2352         Reviewed by Tony Chang.
2353
2354         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
2355         https://bugs.webkit.org/show_bug.cgi?id=45517
2356
2357         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
2358
2359         * DumpRenderTree/chromium/ImageDiff.cpp:
2360         (Image::craeteFromStdin):
2361         (Image::createFromFilename):
2362         (diffImages):
2363         * DumpRenderTree/chromium/TestShell.cpp:
2364         (TestShell::dumpImage):
2365
2366 2010-09-10  MORITA Hajime  <morrita@google.com>
2367
2368         Reviewed by Tony Chang.
2369
2370         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
2371         https://bugs.webkit.org/show_bug.cgi?id=45441
2372
2373         Added TextInputController::hasSpellingMarker().
2374
2375         * DumpRenderTree/chromium/TextInputController.cpp:
2376         (TextInputController::TextInputController):
2377         (TextInputController::hasSpellingMarker):
2378         * DumpRenderTree/chromium/TextInputController.h:
2379
2380 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
2381
2382         Unreviewed, build fix.
2383
2384         My last change accidentally contained a local change to the
2385         rebaselinig script; webkit-patch land picked it up without telling
2386         me and committed it :(
2387
2388         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2389
2390 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
2391
2392         Reviewed by Anders Carlsson.
2393
2394         Attempt to fix Windows MiniBrowser build (untested)
2395         https://bugs.webkit.org/show_bug.cgi?id=45609
2396
2397         * MiniBrowser/win/BrowserView.cpp:
2398         (runJavaScriptConfirm):
2399         (runJavaScriptPrompt):
2400
2401 2010-09-11  Sam Weinig  <sam@webkit.org>
2402
2403         Reviewed by Maciej Stachowiak.
2404
2405         Fix zoom related tests when testing WebKit2.
2406
2407         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2408         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
2409
2410 2010-09-11  Sam Weinig  <sam@webkit.org>
2411
2412         Reviewed by Dan Bernstein.
2413
2414         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
2415         <rdar://problem/8359252>
2416         https://bugs.webkit.org/show_bug.cgi?id=45605
2417
2418         * MiniBrowser/mac/BrowserWindowController.m:
2419         (setStatusText):
2420         (contentsSizeChanged):
2421         (-[BrowserWindowController awakeFromNib]):
2422         * MiniBrowser/win/BrowserView.cpp:
2423         (runJavaScriptConfirm):
2424         (runJavaScriptPrompt):
2425         (setStatusText):
2426         (contentsSizeChanged):
2427         (BrowserView::create):
2428         * WebKitTestRunner/TestController.cpp:
2429         (WTR::createOtherPage):
2430         (WTR::TestController::initialize):
2431
2432 2010-09-11  Sam Weinig  <sam@webkit.org>
2433
2434         Reviewed by Dan Bernstein.
2435
2436         Add callback mechanism for the getting the source of a frame
2437         <rdar://problem/8364681>
2438         https://bugs.webkit.org/show_bug.cgi?id=45604
2439
2440         Add ability to dump the main frame's source to the console.
2441
2442         * MiniBrowser/mac/BrowserWindowController.h:
2443         * MiniBrowser/mac/BrowserWindowController.m:
2444         (-[BrowserWindowController dumpSourceToConsole:]):
2445         * MiniBrowser/mac/MainMenu.xib:
2446
2447 2010-09-11  Eric Seidel  <eric@webkit.org>
2448
2449         Reviewed by Adam Barth.
2450
2451         Remove unneeded Empty Queue messages
2452         https://bugs.webkit.org/show_bug.cgi?id=45602
2453
2454         We already have a /gc job to delete these.
2455         recentstatus.py is already smart enough to use the
2456         most recent of the workitems last update or the most recent status,
2457         so removing these should not change the _last_status_date() return
2458         value more than a few milliseconds.
2459
2460         These messages just spam the recent status log.
2461
2462         * Scripts/webkitpy/tool/commands/queues.py:
2463
2464 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2465
2466         Reviewed by Adam Barth.
2467
2468         Fix Python exception when generating synthetic patch IDs
2469         https://bugs.webkit.org/show_bug.cgi?id=45592
2470
2471         Can't concatenate strings and numbers directly.
2472
2473         * QueueStatusServer/handlers/queuestatus.py:
2474
2475 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2476
2477         Reviewed by Adam Barth.
2478
2479         Group statuses in queue status by patch ID
2480         https://bugs.webkit.org/show_bug.cgi?id=45588
2481
2482         Group statuses by patch ID so that the status page is easier
2483         to scan.
2484
2485         * QueueStatusServer/handlers/queuestatus.py:
2486         * QueueStatusServer/stylesheets/dashboard.css:
2487         (.status-group):
2488         (.status-bug):
2489         (.status-group ul):
2490         (.status-group ul li):
2491         (.status-group ul li:hover):
2492         (.status-cell):
2493         (.status-cell:hover):
2494         (.status-cell.pass):
2495         (.status-cell.fail):
2496         (.status-cell.pending):
2497         (.status-cell.error):
2498         * QueueStatusServer/templates/dashboard.html:
2499         * QueueStatusServer/templates/queuestatus.html:
2500
2501 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2502
2503         Reviewed by Tony Chang.
2504
2505         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
2506         https://bugs.webkit.org/show_bug.cgi?id=45479
2507
2508         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
2509         implementation in ResourceLoadDelegate in the Mac port).
2510
2511         * DumpRenderTree/chromium/LayoutTestController.cpp:
2512         (LayoutTestController::LayoutTestController):
2513         (LayoutTestController::dumpResourceResponseMIMETypes):
2514         (LayoutTestController::reset):
2515         * DumpRenderTree/chromium/LayoutTestController.h:
2516         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
2517         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
2518         * DumpRenderTree/chromium/TestShell.h:
2519         (TestShell::shouldDumpResourceResponseMIMETypes):
2520         * DumpRenderTree/chromium/WebViewHost.cpp:
2521         (WebViewHost::didReceiveResponse):
2522
2523 2010-09-11  Eric Seidel  <eric@webkit.org>
2524
2525         Reviewed by Adam Barth.
2526
2527         queues.webkit.org should expose /remote_api for data upload/download
2528         https://bugs.webkit.org/show_bug.cgi?id=45559
2529
2530         * QueueStatusServer/app.yaml:
2531          - /remote_api is a standard app-engine service which allows use of
2532            the bulk uploader for data upload/download.  Exposing this
2533            (for admin access only) allows us to use
2534
2535 2010-09-10  Sam Weinig  <sam@webkit.org>
2536
2537         Reviewed by Dan Bernstein.
2538
2539         Add zoom support to WebKit2 API
2540         <rdar://problem/7660657>
2541         https://bugs.webkit.org/show_bug.cgi?id=45585
2542
2543         - Add zoom options to MiniBrowser that mimic Safari's options using
2544           the new WebKit2 zoom APIs.
2545         - Switch uses of float for the zoom APIs to use double.
2546
2547         * MiniBrowser/mac/BrowserWindowController.h:
2548         * MiniBrowser/mac/BrowserWindowController.m:
2549         (-[BrowserWindowController initWithPageNamespace:]):
2550         (-[BrowserWindowController validateMenuItem:]):
2551         (-[BrowserWindowController validateUserInterfaceItem:]):
2552         (-[BrowserWindowController currentZoomFactor]):
2553         (-[BrowserWindowController setCurrentZoomFactor:]):
2554         (-[BrowserWindowController canZoomIn]):
2555         (-[BrowserWindowController zoomIn:]):
2556         (-[BrowserWindowController canZoomOut]):
2557         (-[BrowserWindowController zoomOut:]):
2558         (-[BrowserWindowController canResetZoom]):
2559         (-[BrowserWindowController resetZoom:]):
2560         (-[BrowserWindowController toggleZoomMode:]):
2561         * MiniBrowser/mac/MainMenu.xib:
2562         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2563         (WTR::EventSendingController::textZoomIn):
2564         (WTR::EventSendingController::textZoomOut):
2565         (WTR::EventSendingController::zoomPageIn):
2566         (WTR::EventSendingController::zoomPageOut):
2567
2568 2010-09-10  Robert Hogan  <robert@webkit.org>
2569
2570         Reviewed by Andreas Kling.
2571
2572         [Qt] Fix crash in DRT in standalone mode
2573
2574         https://bugs.webkit.org/show_bug.cgi?id=45454
2575
2576         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2577         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2578
2579 2010-09-10  Sam Weinig  <sam@webkit.org>
2580
2581         Reviewed by Darin Adler.
2582
2583         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
2584         Precursor to <rdar://problem/7660657>
2585         https://bugs.webkit.org/show_bug.cgi?id=45522
2586
2587         Update for changes to the Bundle API to allow separate control of page and text zoom
2588         levels.
2589
2590         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2591         (WTR::EventSendingController::textZoomIn):
2592         (WTR::EventSendingController::textZoomOut):
2593         (WTR::EventSendingController::zoomPageIn):
2594         (WTR::EventSendingController::zoomPageOut):
2595         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2596         (WTR::InjectedBundlePage::reset):
2597
2598 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
2599
2600         Reviewed by Andreas Kling.
2601
2602         [Qt] Support click event for notifications
2603         https://bugs.webkit.org/show_bug.cgi?id=44836
2604
2605         Add support for simulateDesktopNotificationClick by calling
2606         back to DumpRenderTreeSupportQt.cpp.
2607
2608         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2609         (LayoutTestController::simulateDesktopNotificationClick):
2610         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2611
2612 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
2613
2614         Reviewed by Eric Seidel.
2615
2616         Update queue status when patches fail their first land attempt
2617         https://bugs.webkit.org/show_bug.cgi?id=45583
2618
2619         Add a few more _update_status calls to make it more obvious if a patch is
2620         being retried because tests failed.
2621
2622         * Scripts/webkitpy/tool/commands/queues.py:
2623
2624 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
2625
2626         Reviewed by Andreas Kling.
2627
2628         [Qt] MiniBrowser crashes with multiply windows when closing one of them
2629         https://bugs.webkit.org/show_bug.cgi?id=45536
2630
2631         * MiniBrowser/qt/BrowserView.cpp:
2632         (BrowserView::BrowserView): Reference the context instead of adopting it
2633         because it can be shared across different views.
2634
2635 2010-09-10  Tony Chang  <tony@chromium.org>
2636
2637         Unreviewed, rolling out r67241.
2638         http://trac.webkit.org/changeset/67241
2639         https://bugs.webkit.org/show_bug.cgi?id=44709
2640
2641         Accidentally committed.
2642
2643         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2644         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2645
2646 2010-09-10  Tony Chang  <tony@chromium.org>
2647
2648         Reviewed by Ojan Vafai.
2649
2650         deduplicate-tests should be runnable from any WebKit directory
2651         https://bugs.webkit.org/show_bug.cgi?id=44709
2652
2653         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2654         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2655
2656 2010-09-10  Tony Chang  <tony@chromium.org>
2657
2658         Unreviewed, rolling out r67216.
2659         http://trac.webkit.org/changeset/67216
2660         https://bugs.webkit.org/show_bug.cgi?id=44709
2661
2662         Broke
2663
2664         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2665         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2666
2667 2010-09-10  Tony Chang  <tony@chromium.org>
2668
2669         Reviewed by Ojan Vafai.
2670
2671         deduplicate-tests should be runnable from any WebKit directory
2672         https://bugs.webkit.org/show_bug.cgi?id=44709
2673
2674         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2675         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2676
2677 2010-09-09  Hans Wennborg  <hans@chromium.org>
2678
2679         Reviewed by Jeremy Orlow.
2680
2681         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
2682         https://bugs.webkit.org/show_bug.cgi?id=45460
2683
2684         This enables DumpRenderTree to run layout tests for DeviceOrientation.
2685
2686         Also declare the LayoutTestController destructor out-of-line.
2687         Otherwise the implicit destructor would cause compiler errors because
2688         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
2689
2690         * DumpRenderTree/chromium/LayoutTestController.cpp:
2691         (LayoutTestController::~LayoutTestController):
2692         (LayoutTestController::setMockDeviceOrientation):
2693         (LayoutTestController::deviceOrientationClient):
2694         * DumpRenderTree/chromium/LayoutTestController.h:
2695         * DumpRenderTree/chromium/WebViewHost.cpp:
2696         (WebViewHost::deviceOrientationClient):
2697         * DumpRenderTree/chromium/WebViewHost.h:
2698
2699 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2700
2701         Unreviewed, rolling out r67119.
2702         http://trac.webkit.org/changeset/67119
2703         https://bugs.webkit.org/show_bug.cgi?id=45505
2704
2705         Extra newlines in results (Requested by tony^work on #webkit).
2706
2707         * DumpRenderTree/chromium/LayoutTestController.cpp:
2708         (LayoutTestController::LayoutTestController):
2709         (LayoutTestController::reset):
2710         * DumpRenderTree/chromium/LayoutTestController.h:
2711         * DumpRenderTree/chromium/TestShell.h:
2712         * DumpRenderTree/chromium/WebViewHost.cpp:
2713         (printResponseDescription):
2714         (printNodeDescription):
2715         (printRangeDescription):
2716         (WebViewHost::shouldBeginEditing):
2717         (WebViewHost::shouldEndEditing):
2718         (WebViewHost::shouldInsertNode):
2719         (WebViewHost::shouldChangeSelectedRange):
2720         (WebViewHost::shouldDeleteRange):
2721         (WebViewHost::shouldApplyStyle):
2722         (WebViewHost::didBeginEditing):
2723         (WebViewHost::didChangeSelection):
2724         (WebViewHost::didChangeContents):
2725         (WebViewHost::didEndEditing):
2726         (WebViewHost::decidePolicyForNavigation):
2727         (WebViewHost::didCancelClientRedirect):
2728         (WebViewHost::didStartProvisionalLoad):
2729         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
2730         (WebViewHost::didFailProvisionalLoad):
2731         (WebViewHost::didCommitProvisionalLoad):
2732         (WebViewHost::didFinishDocumentLoad):
2733         (WebViewHost::didHandleOnloadEvents):
2734         (WebViewHost::didFailLoad):
2735         (WebViewHost::didFinishLoad):
2736         (WebViewHost::didChangeLocationWithinPage):
2737         (WebViewHost::willSendRequest):
2738         (WebViewHost::didReceiveResponse):
2739         (WebViewHost::didFinishResourceLoad):
2740         (WebViewHost::didFailResourceLoad):
2741         (WebViewHost::didDisplayInsecureContent):
2742         (WebViewHost::didRunInsecureContent):
2743         (WebViewHost::printFrameDescription):
2744
2745 2010-09-09  Michael Saboff  <msaboff@apple.com>
2746
2747         Unreviewed, adding myself to committers list.
2748
2749         * Scripts/webkitpy/common/config/committers.py:
2750
2751 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
2752
2753         Reviewed by Tony Chang.
2754
2755         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
2756         https://bugs.webkit.org/show_bug.cgi?id=45479
2757
2758         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
2759         implementation in ResourceLoadDelegate in the Mac port).
2760
2761         * DumpRenderTree/chromium/LayoutTestController.cpp:
2762         (LayoutTestController::LayoutTestController):
2763         (LayoutTestController::dumpResourceResponseMIMETypes):
2764         (LayoutTestController::reset):
2765         * DumpRenderTree/chromium/LayoutTestController.h:
2766         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
2767         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
2768         * DumpRenderTree/chromium/TestShell.h:
2769         (TestShell::shouldDumpResourceResponseMIMETypes):
2770         * DumpRenderTree/chromium/WebViewHost.cpp:
2771         (WebViewHost::didReceiveResponse):
2772
2773 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
2774
2775         Reviewed by Daniel Bates.
2776
2777         svn-apply tries to delete directories it shouldn't
2778         https://bugs.webkit.org/show_bug.cgi?id=45424
2779
2780         isDirectoryEmptyForRemoval had the wrong check. If an item in the
2781         directory is itself a directory, then the directory is definitely
2782         not empty.
2783
2784         * Scripts/svn-apply:
2785
2786 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
2787
2788         Fixing GTK and windows build failure.
2789
2790         AX: Support AccessibilityTextMarkers in DRT
2791         https://bugs.webkit.org/show_bug.cgi?id=44778
2792
2793         * DumpRenderTree/AccessibilityTextMarker.h:
2794         (AccessibilityTextMarker::platformTextMarker):
2795         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2796         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2797         (AccessibilityTextMarker::platformTextMarker):
2798         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2799
2800 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
2801
2802         Reviewed by David Kilzer.
2803
2804         AX: Support AccessibilityTextMarkers in DRT
2805         https://bugs.webkit.org/show_bug.cgi?id=44778
2806
2807         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers
2808         that WebCore uses when vending information about its VisiblePositions through AX.
2809
2810         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
2811         methods for encapsulating and checking equality.
2812
2813         This will allow future bug fixes in the text marker system to be adequately tested.
2814
2815         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
2816         (toTextMarker):
2817         (isMarkerEqualCallback):
2818         (markerFinalize):
2819         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
2820         (AccessibilityTextMarker::getJSClass):
2821         (toTextMarkerRange):
2822         (isMarkerRangeEqualCallback):
2823         (markerRangeFinalize):
2824         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
2825         (AccessibilityTextMarkerRange::getJSClass):
2826         * DumpRenderTree/AccessibilityTextMarker.h: Added.
2827         (AccessibilityTextMarker::platformTextMarker):
2828         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2829         (AccessibilityTextMarker::AccessibilityTextMarker):
2830         (AccessibilityTextMarker::~AccessibilityTextMarker):
2831         (AccessibilityTextMarker::isEqual):
2832         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2833         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2834         (AccessibilityTextMarkerRange::isEqual):
2835         * DumpRenderTree/AccessibilityUIElement.cpp:
2836         (textMarkerRangeForElementCallback):
2837         (textMarkerRangeLengthCallback):
2838         (textMarkerRangeForMarkersCallback):
2839         (startTextMarkerForTextMarkerRangeCallback):
2840         (endTextMarkerForTextMarkerRangeCallback):
2841         (accessibilityElementForTextMarkerCallback):
2842         (AccessibilityUIElement::textMarkerRangeForElement):
2843         (AccessibilityUIElement::textMarkerRangeLength):
2844         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2845         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2846         (AccessibilityUIElement::accessibilityElementForTextMarker):
2847         (AccessibilityUIElement::getJSClass):
2848         * DumpRenderTree/AccessibilityUIElement.h:
2849         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2850         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
2851         (AccessibilityTextMarker::AccessibilityTextMarker):
2852         (AccessibilityTextMarker::~AccessibilityTextMarker):
2853         (AccessibilityTextMarker::isEqual):
2854         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2855         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2856         (AccessibilityTextMarkerRange::isEqual):
2857         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2858         (AccessibilityUIElement::textMarkerRangeForElement):
2859         (AccessibilityUIElement::textMarkerRangeLength):
2860         (AccessibilityUIElement::textMarkerRangeForMarkers):
2861         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2862         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2863         (AccessibilityUIElement::accessibilityElementForTextMarker):
2864         * DumpRenderTree/win/DumpRenderTree.vcproj:
2865
2866 2010-08-25  Tony Chang  <tony@chromium.org>
2867
2868         Reviewed by Ojan Vafai.
2869
2870         don't delete duplicates needed because of intermediate results
2871         https://bugs.webkit.org/show_bug.cgi?id=44653
2872
2873         Also, output the full path so we can pipe the output to rm.
2874
2875         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2876         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2877
2878 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
2879
2880         Reviewed by Andreas Kling.
2881
2882         [Qt] MiniBrowser does not starts properly
2883         https://bugs.webkit.org/show_bug.cgi?id=45459
2884
2885         Do not try set up the first window by calling newWindow on a
2886         newly created BrowserWindow since it creates a new object.
2887         * MiniBrowser/qt/BrowserWindow.cpp:
2888         (BrowserWindow::BrowserWindow):
2889         * MiniBrowser/qt/main.cpp:
2890         (main):
2891
2892 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
2893
2894         Reviewed by Xan Lopez.
2895
2896         [GTK] Get ImageDiff building on Win32
2897         https://bugs.webkit.org/show_bug.cgi?id=45353
2898
2899         * DumpRenderTree/gtk/ImageDiff.cpp:
2900         (main): Switch from using strtok to g_strsplit.
2901
2902 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
2903
2904         Reviewed by Andreas Kling.
2905
2906         [Qt] Modify load method of MiniBrowser's BrowserView class
2907         https://bugs.webkit.org/show_bug.cgi?id=45442
2908
2909         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
2910
2911         * MiniBrowser/qt/BrowserView.cpp:
2912         (BrowserView::load):
2913         * MiniBrowser/qt/BrowserView.h:
2914         * MiniBrowser/qt/BrowserWindow.cpp:
2915         (BrowserWindow::load):
2916
2917 2010-09-09  Tony Chang  <tony@chromium.org>
2918
2919         Reviewed by Ojan Vafai.
2920
2921         fix show_results in new-run-webkit-tests
2922         https://bugs.webkit.org/show_bug.cgi?id=45413
2923
2924         * Scripts/webkitpy/layout_tests/port/chromium.py:
2925
2926 2010-09-08  Victor Wang  <victorw@chromium.org>
2927
2928         Reviewed by Ojan Vafai.
2929
2930         [Chromium] Fix test results server to make sure
2931         it does not have corrupted data.
2932
2933         results.json file size coulbe be >1M and we split
2934         the data into multiple data store entries in this
2935         case. This patch fixes the issue that the data may
2936         be corrupted if data store error happens in the middle
2937         of saving multiple entries.
2938
2939         https://bugs.webkit.org/show_bug.cgi?id=45063
2940
2941         * TestResultServer/model/datastorefile.py:
2942
2943 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
2944
2945         Reviewed by Kenneth Rohde Christiansen.
2946
2947         Fix ignoring return value warning in case of gcc 4.4.4
2948         https://bugs.webkit.org/show_bug.cgi?id=45384
2949
2950         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2951         (testPostURLFile):
2952         If fwrite have written zero byte then the testPostURLFile function
2953         returns with false as tempFile can't be opened.
2954         * DumpRenderTree/qt/ImageDiff.cpp:
2955         (main):
2956         Put fwrite function into an if condition without body to avoid
2957         warning. It is safe because this function writes to the stdout.
2958
2959 2010-09-08  Satish Sampath  <satish@chromium.org>
2960
2961         Unreviewed, adding myself to committers list.
2962
2963         * Scripts/webkitpy/common/config/committers.py:
2964
2965 2010-09-08  Hans Wennborg  <hans@chromium.org>
2966
2967         Unreviewed.
2968
2969         Adding myself as a committer in committers.py.
2970
2971         * Scripts/webkitpy/common/config/committers.py:
2972
2973 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
2974
2975         Reviewed by Simon Hausmann.
2976
2977         [Qt] Refactor MiniBrowser
2978         https://bugs.webkit.org/show_bug.cgi?id=45173
2979
2980         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
2981
2982         * MiniBrowser/qt/BrowserView.cpp: Added.
2983         (createNewPage):
2984         (BrowserView::BrowserView):
2985         (BrowserView::resizeEvent):
2986         (BrowserView::load):
2987         (BrowserView::view):
2988         * MiniBrowser/qt/BrowserView.h: Added.
2989         (BrowserView::~BrowserView):
2990         * MiniBrowser/qt/BrowserWindow.cpp:
2991         * MiniBrowser/qt/BrowserWindow.h:
2992         * MiniBrowser/qt/MiniBrowser.pro:
2993
2994 2010-09-08  Adam Barth  <abarth@webkit.org>
2995
2996         Rubber-stamped by Eric Seidel.
2997
2998         Rename DocLoader to CachedResourceLoader because that's what it does.
2999
3000         * Scripts/do-webcore-rename:
3001
3002 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
3003
3004         Reviewed by Ojan Vafai.
3005
3006         Enable incremental results.json generation for non-layout tests.
3007         https://bugs.webkit.org/show_bug.cgi?id=45315
3008
3009         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
3010
3011         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
3012
3013
3014 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3015
3016         Unreviewed, build fix
3017
3018         Missed one test in mac_unittest.py in previous change; for some
3019         reason the method is listed twice. I will fix both for now, but will
3020         figure this out in a later, not-time-sensitive patch.
3021
3022         https://bugs.webkit.org/show_bug.cgi?id=45357
3023
3024         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3025
3026 2010-09-07  Kent Tamura  <tkent@chromium.org>
3027
3028         Reviewed by Tony Chang.
3029
3030         test-webkitpy: Fix load error of
3031         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
3032         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
3033
3034         * Scripts/webkitpy/layout_tests/port/server_process.py:
3035           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
3036           and we don't use server_process.py on Win32 Python. However
3037           unittest.py tries to load everything in a module.
3038
3039 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3040
3041         Reviewed by Kent Tamura.
3042
3043         Fix regression introduced in previous change to new-run-webkit-tests
3044         (bug 45090) to not try to run unittests for the Mac implementation
3045         of the Port interface if we aren't running on a Mac.
3046
3047         Also fix the overrides implementation mock in the chromium unittests
3048         to fix the case where there are overrides checked in that cause
3049         problems.
3050
3051         https://bugs.webkit.org/show_bug.cgi?id=45357
3052
3053         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3054         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3055         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3056
3057 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
3058
3059         Reviewed by Ojan Vafai.
3060
3061         new-run-webkit-tests: still more unit tests
3062
3063         Clean up and remove unnecessary code. Biggest notable change is
3064         moving the chromium-specific imagediff code from port/base to
3065         port/chromium.
3066
3067         Add more unit tests for run_webkit_tests.py, port/base.py,
3068         port/factory.py, port/dryrun.py, and
3069         layout_package/dump_render_tree_thread.py
3070
3071         This covers almost all of the generic and test code paths except for
3072         a few error paths involving invalid or port-specific command line
3073         arguments, and the code path for uploading results files to the
3074         buildbots.
3075
3076         https://bugs.webkit.org/show_bug.cgi?id=45090
3077
3078         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
3079         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3080         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3081         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3082         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3083         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3084         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3085         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3086         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3087         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
3088         * Scripts/webkitpy/layout_tests/port/base.py:
3089         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3090         * Scripts/webkitpy/layout_tests/port/chromium.py:
3091         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3092         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3093         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3094         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
3095         * Scripts/webkitpy/layout_tests/port/server_process.py:
3096         * Scripts/webkitpy/layout_tests/port/test.py:
3097         * Scripts/webkitpy/layout_tests/port/webkit.py:
3098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3099         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3100
3101 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
3102
3103         Reviewed by Darin Adler.
3104
3105         Provide a way to trigger a <select multiple> onchange event on changes
3106         https://bugs.webkit.org/show_bug.cgi?id=45192
3107
3108         Adds a selector on ObjCController for testing
3109         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
3110         its different uses.
3111
3112         * DumpRenderTree/mac/ObjCController.m:
3113         (+[ObjCController isSelectorExcludedFromWebScript:]):
3114         (+[ObjCController webScriptNameForSelector:]):
3115         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
3116
3117 2010-09-07  James Robinson  <jamesr@chromium.org>
3118
3119         Rubber-stamped by Dimitri Glazkov.
3120
3121         Move myself from the committer to the reviewer list.
3122
3123         * Scripts/webkitpy/common/config/committers.py:
3124
3125 2010-09-07  Tony Chang  <tony@chromium.org>
3126
3127         Reviewed by Darin Fisher.
3128
3129         [chromium] Make a public flag for how DRT generates bitmaps on Linux
3130         https://bugs.webkit.org/show_bug.cgi?id=45133
3131
3132         * DumpRenderTree/chromium/TestShell.cpp:
3133         (TestShell::dumpImage):
3134
3135 2010-09-07  Kent Tamura  <tkent@chromium.org>
3136
3137         Reviewed by Dimitri Glazkov.
3138
3139         [DRT/Chromium] Implement --check-layout-test-sys-deps
3140         https://bugs.webkit.org/show_bug.cgi?id=45283
3141
3142         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3143         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
3144         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
3145         * DumpRenderTree/chromium/TestShellGtk.cpp:
3146         (checkLayoutTestSystemDependencies): Add an empty implementation.
3147         * DumpRenderTree/chromium/TestShellMac.mm:
3148         (checkLayoutTestSystemDependencies): Add an empty implementation.
3149         * DumpRenderTree/chromium/TestShellWin.cpp:
3150         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
3151
3152 2010-09-07  Jessie Berlin  <jberlin@apple.com>
3153
3154         Unreviewed. Mac build fix.
3155
3156         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3157         (didClearWindowObjectForFrame):
3158
3159 2010-09-07  Jessie Berlin  <jberlin@apple.com>
3160
3161         Reviewed by Darin Adler.
3162
3163         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
3164         https://bugs.webkit.org/show_bug.cgi?id=45217
3165
3166         Make WebKitTestRunner work with this change.
3167
3168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3169         (WTR::InjectedBundlePage::didClearWindowForFrame):
3170         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
3171         WebFrameLoaderClient.
3172         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3173
3174 2010-09-07  Philippe Normand  <pnormand@igalia.com>
3175
3176         Unreviewed, build fix.
3177
3178         webkit-patch command to find the ports covering a specific layout test
3179         https://bugs.webkit.org/show_bug.cgi?id=42832
3180
3181         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
3182         tests are present when building the expectations. This is needed
3183         for the unittests.
3184
3185 2010-09-06  Philippe Normand  <pnormand@igalia.com>
3186
3187         Reviewed by Adam Barth.
3188
3189         webkit-patch command to find the ports covering a specific layout test
3190         https://bugs.webkit.org/show_bug.cgi?id=42832
3191
3192         To use it: webkit-patch skipped-ports some/layout/test.html
3193
3194         * Scripts/webkitpy/layout_tests/port/base.py:
3195         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3196         * Scripts/webkitpy/layout_tests/port/chromium.py:
3197         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3198         * Scripts/webkitpy/layout_tests/port/factory.py:
3199         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3200         * Scripts/webkitpy/layout_tests/port/test.py:
3201         * Scripts/webkitpy/layout_tests/port/webkit.py:
3202         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3203         * Scripts/webkitpy/tool/commands/queries.py:
3204         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3205         * Scripts/webkitpy/tool/main.py:
3206         * Scripts/webkitpy/tool/mocktool.py:
3207
3208 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3209
3210         Reviewed by Eric Seidel.
3211
3212         [NRWT] Add temp directory to all running drivers.
3213         https://bugs.webkit.org/show_bug.cgi?id=45261
3214
3215         * Scripts/webkitpy/layout_tests/port/webkit.py:
3216
3217 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
3218
3219         Reviewed by Kent Tamura.
3220
3221         [Chromium/DRT] Empty out user stylesheet after each test run.
3222         https://bugs.webkit.org/show_bug.cgi?id=45282
3223
3224         This should significantly cut down on the number of the mysterious flaky tests
3225         whose diffs looked like the page was blown up to a very lage size. This
3226         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
3227         which set the base body font to 100px.
3228
3229         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
3230         the same thread failed.
3231
3232         * DumpRenderTree/chromium/TestShell.cpp:
3233         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
3234
3235 2010-09-06  Kent Tamura  <tkent@chromium.org>
3236
3237         Reviewed by Dimitri Glazkov.
3238
3239         [DRT/Chromium] Do not generate pixel results for text/plain resources
3240         https://bugs.webkit.org/show_bug.cgi?id=45253
3241
3242         * DumpRenderTree/chromium/TestShell.cpp:
3243         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
3244
3245 2010-09-06  Ojan Vafai  <ojan@chromium.org>
3246
3247         Reviewed by Kent Tamura.
3248
3249         print out correct error when a DRT thread dies in NRWT
3250         https://bugs.webkit.org/show_bug.cgi?id=45281
3251
3252         Not sure why, but with the parens, python 2.6.5 on Linux
3253         gives an error that raise takes 5 arguments and 0 were given.
3254         Didn't test other platforms or python versions, but putting it
3255         all on one line fixes it and correctly prints the exception
3256         from the DRT thread.
3257
3258         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3259
3260 2010-09-06  Eric Seidel  <eric@webkit.org>
3261
3262         Unreviewed, just adding some emails from lists.webkit.org.
3263
3264         Update committers.py to include emails from lists.webkit.org
3265         as found by the validate-committer-lists script.
3266
3267         * Scripts/webkitpy/common/config/committers.py:
3268
3269 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
3270
3271         Reviewed by Xan Lopez.
3272
3273         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
3274         https://bugs.webkit.org/show_bug.cgi?id=45213
3275
3276         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3277         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
3278         have to surround the invocation with #ifdefs.
3279         (useLongRunningServerMode): Added.
3280         (runTestingServerLoop): Added.
3281         (initializeGlobalsFromCommandLineOptions): Added.
3282         (runTest): Removed ifdefs.
3283         (main): Use new helper functions.
3284
3285 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
3286
3287         Reviewed by Xan Lopez.
3288
3289         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
3290         https://bugs.webkit.org/show_bug.cgi?id=45235
3291
3292         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
3293         methods of the EventSender.
3294
3295         * DumpRenderTree/gtk/EventSender.cpp:
3296         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
3297         with the current modifiers.
3298         (contextClickCallback): Always send no modifiers when preparing the mouse event.
3299         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
3300         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
3301         (mouseUpCallback): Ditto.
3302
3303 2010-09-05  Peter Kasting  <pkasting@google.com>
3304
3305         Reviewed by Adam Barth.
3306
3307         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
3308         https://bugs.webkit.org/show_bug.cgi?id=45155
3309
3310         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
3311         (EventSender::handleMouseWheel):
3312
3313 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
3314
3315         Reviewed by Joseph Pecoraro.
3316
3317         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
3318         https://bugs.webkit.org/show_bug.cgi?id=45179
3319
3320         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3321         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3322
3323 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
3324
3325         Rubber-stamped by Daniel Bates.
3326
3327         Adding myself as reviewer.
3328
3329         * Scripts/webkitpy/common/config/committers.py:
3330
3331 2010-09-04  Daniel Bates  <dbates@rim.com>
3332
3333         Reviewed by Martin Robinson.
3334
3335         Teach svn-apply/unapply about svn:mergeinfo
3336         https://bugs.webkit.org/show_bug.cgi?id=45236
3337
3338         Recognize the svn:mergeinfo property and ignore it for now.
3339
3340         Currently, svn-apply/unapply recognize only '+' and '-'
3341         property changes within a diff. We should add support
3342         to recognize "Merged" and "Reverse-merged" changes as well.
3343         Because svn:mergeinfo is metadata that is used only by SVN
3344         and tends to be error-prone and/or nuisance (*), we will ignore
3345         it for now.
3346         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
3347
3348         * Scripts/VCSUtils.pm:
3349           - Modified parseSvnProperty() to recognize "Merged" and
3350             "Reverse-merged" as the start of a property value.
3351         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3352           - Added the following unit tests:
3353             "simple: add svn:mergeinfo"
3354             "simple: delete svn:mergeinfo"
3355             "simple: modified svn:mergeinfo"
3356         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3357           - Added the following unit tests:
3358             "simple: add svn:mergeinfo"
3359             "simple: delete svn:mergeinfo"
3360             "simple: modified svn:mergeinfo"
3361             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
3362             "'Merged' change followed by 'Merged' change"
3363             "'Reverse-merged' change followed by 'Reverse-merged' change"
3364         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3365           - Added the following unit tests:
3366             "'Merged' change"
3367             "'Reverse-merged' change"
3368             "'Reverse-merged' change followed by 'Merge' change"
3369             "'Merged' change followed by 'Merge' change"
3370             "'Reverse-merged' change followed by 'Reverse-merged' change"
3371             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
3372
3373 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3374
3375         Reviewed by Kenneth Rohde Christiansen.
3376
3377         [EFL] Move test browser to WebKitTools directory
3378         https://bugs.webkit.org/show_bug.cgi?id=45212
3379
3380         Follow other ports like QT and GTK which moved the test browser to
3381         WebKitTools directory.
3382
3383         * CMakeListsEfl.txt: Added.
3384         * EWebLauncher/main.c: Added.
3385         (print_history):
3386         (zoom_level_set):
3387         (on_ecore_evas_resize):
3388         (title_set):
3389         (viewport_set):
3390         (on_title_changed):
3391         (on_progress):
3392         (on_load_finished):
3393         (on_toolbars_visible_set):
3394         (on_toolbars_visible_get):
3395         (on_statusbar_visible_set):
3396         (on_statusbar_visible_get):
3397         (on_scrollbars_visible_set):
3398         (on_scrollbars_visible_get):
3399         (on_menubar_visible_set):
3400         (on_menubar_visible_get):
3401         (on_tooltip_text_set):
3402         (on_inputmethod_changed):
3403         (on_viewport_changed):
3404         (on_mouse_down):
3405         (on_focus_out):
3406         (on_focus_in):
3407         (on_resized):
3408         (on_key_down):
3409         (on_browser_del):
3410         (on_closeWindow):
3411         (quit):
3412         (browserCreate):
3413         (browserDestroy):
3414         (closeWindow):
3415         (main_signal_exit):
3416         (findThemePath):
3417         (main):
3418
3419 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
3420
3421         Reviewed by Adam Roben.
3422
3423         Set project dependencies so that they build serially. This fixes
3424         issues when running run-webkit-tests if DRT is not built yet.
3425
3426         * DumpRenderTree/DumpRenderTree.sln:
3427
3428 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
3429
3430         Reviewed by Adam Barth.
3431
3432         Fix reading configuraiton in NWRT to work on Windows.
3433         https://bugs.webkit.org/show_bug.cgi?id=45180
3434
3435         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
3436             with the file otherwise.
3437
3438 2010-09-03  Chris Rogers  <crogers@google.com>
3439
3440         Unreviewed
3441
3442         Add myself to the committers list
3443         https://bugs.webkit.org/show_bug.cgi?id=45189
3444
3445         * Scripts/webkitpy/common/config/committers.py:
3446
3447 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
3448
3449         Reviewed by Yury Semikhatsky.
3450
3451         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
3452         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
3453         https://bugs.webkit.org/show_bug.cgi?id=45137
3454
3455         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
3456
3457 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3458
3459         Reviewed by Eric Seidel.
3460
3461         Add feature detection support to NRWT.
3462         https://bugs.webkit.org/show_bug.cgi?id=41842
3463
3464         * Scripts/webkitpy/layout_tests/port/base.py:
3465         * Scripts/webkitpy/layout_tests/port/qt.py:
3466         * Scripts/webkitpy/layout_tests/port/webkit.py:
3467         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
3468
3469 2010-09-03  Hironori Bono  <hbono@chromium.org>
3470
3471         Reviewed by Kent Tamura.
3472
3473         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
3474         and implements it for Mac.
3475         https://bugs.webkit.org/show_bug.cgi?id=41832
3476
3477         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
3478         and bind it so we can call it from JavaScript.
3479         (+[TextInputController isSelectorExcludedFromWebScript:]):
3480         (+[TextInputController webScriptNameForSelector:]):
3481         (-[TextInputController hasSpellingMarker:length:]):
3482
3483 2010-09-02  Eric Seidel  <eric@webkit.org>
3484
3485         Reviewed by Adam Barth.
3486
3487         Add a unit test for commit-queue retries
3488         https://bugs.webkit.org/show_bug.cgi?id=45162
3489
3490         I think commit-queue retries are not correctly avoiding
3491         build and test on retries.  So I started testing the code.
3492         Unfortunately this test did not find the bug.  But now
3493         that we have the test we might as well keep it.
3494         I also fixed a broken import in validate-committer-lists.
3495
3496         * Scripts/validate-committer-lists:
3497         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3498
3499 2010-09-02  Kent Tamura  <tkent@chromium.org>
3500
3501         Reviewed by Dimitri Glazkov.
3502
3503         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
3504         https://bugs.webkit.org/show_bug.cgi?id=45091
3505
3506         Task.{cpp,h} introduces a simpler version of Chromium
3507         base/task.h. It doesn't have TupleN and Method.
3508
3509         * DumpRenderTree/DumpRenderTree.gypi:
3510          Add Task.cpp and Task.h
3511         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3512         (DRTDevToolsAgent::DRTDevToolsAgent):
3513         (DRTDevToolsAgent::reset):
3514         (DRTDevToolsAgent::asyncCall):
3515         (DRTDevToolsAgent::frontendLoaded):
3516         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3517         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
3518         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3519         (DRTDevToolsClient::DRTDevToolsClient):
3520         (DRTDevToolsClient::~DRTDevToolsClient):
3521         (DRTDevToolsClient::reset):
3522         (DRTDevToolsClient::asyncCall):
3523         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3524         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
3525         * DumpRenderTree/chromium/EventSender.cpp:
3526         (EventSender::EventSender):
3527         (EventSender::reset):
3528         (EventSender::scheduleAsynchronousClick):
3529         * DumpRenderTree/chromium/EventSender.h:
3530         (EventSender::taskList): Added to use MethodTask<T>.
3531         * DumpRenderTree/chromium/LayoutTestController.cpp:
3532         (LayoutTestController::LayoutTestController):
3533         (LayoutTestController::WorkQueue::processWorkSoon):
3534         (LayoutTestController::waitUntilDone):
3535         (LayoutTestController::notifyDone):
3536         (LayoutTestController::reset):
3537         * DumpRenderTree/chromium/LayoutTestController.h:
3538         (LayoutTestController::taskList): Added to use MethodTask<T>.
3539         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
3540         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3541         (deferredDisplayDispatch):
3542         (NotificationPresenter::show):
3543         * DumpRenderTree/chromium/Task.cpp: Added.
3544         * DumpRenderTree/chromium/Task.h: Added.
3545
3546 2010-09-02  Steve Block  <steveblock@google.com>
3547
3548         Reviewed by Adam Barth.
3549
3550         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
3551         https://bugs.webkit.org/show_bug.cgi?id=43181
3552
3553         * DumpRenderTree/mac/DumpRenderTree.mm:
3554         (createWebViewAndOffscreenWindow):
3555         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3556         (LayoutTestController::setMockDeviceOrientation):
3557
3558 2010-08-31  Adam Roben  <aroben@apple.com>
3559
3560         Fix flashiness when resizing the browser window on Windows
3561
3562         Reviewed by Sam Weinig.
3563
3564         * MiniBrowser/win/BrowserWindow.cpp:
3565         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
3566         periodically fill the window with white.
3567
3568 2010-09-02  Peter Kasting  <pkasting@google.com>
3569
3570         Reviewed by Dimitri Glazkov.
3571
3572         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
3573         https://bugs.webkit.org/show_bug.cgi?id=45073
3574
3575         * DumpRenderTree/chromium/EventSender.cpp:
3576         (EventSender::EventSender):
3577         (EventSender::mouseScrollBy):
3578         (EventSender::continuousMouseScrollBy):
3579         (EventSender::sendCurrentTouchEvent):
3580         (EventSender::handleMouseWheel):
3581         * DumpRenderTree/chromium/EventSender.h:
3582         * DumpRenderTree/gtk/EventSender.cpp:
3583         (mouseScrollByCallback):
3584         (continuousMouseScrollByCallback):
3585
3586 2010-09-01