Build fix
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-18  Adam Roben  <aroben@apple.com>
2
3         Build fix
4
5         * Scripts/build-webkit:
6
7 2008-01-18  Beth Dakin  <bdakin@apple.com>
8
9         Reviewed by Oliver.
10
11         Update build-webkit to account for foreign-object being disabled by 
12         default.
13
14         * Scripts/build-webkit:
15
16 2008-01-18  Adam Roben  <aroben@apple.com>
17
18         Updated for method renames
19
20         Reviewed by Adele.
21
22         * DumpRenderTree/mac/FrameLoadDelegate.mm:
23         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
24         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
25         (LayoutTestController::setMainFrameIsFirstResponder):
26         (LayoutTestController::setWindowIsKey):
27         * DumpRenderTree/mac/UIDelegate.mm:
28         (-[UIDelegate webViewFocus:]):
29         * DumpRenderTree/win/FrameLoadDelegate.cpp:
30         (FrameLoadDelegate::didCommitLoadForFrame):
31
32 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
33
34         Reviewed by Adam Roben.
35
36         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
37         between DRT and TestNetscapePlugin.
38
39         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
40         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
41
42 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
43
44         Reviewed by Holger.
45
46         Fix fast/dom/Window/window-resize.html
47         
48         In DRT connect the page's geometryChangeRequest signal to a slot that
49         sets the geometry of the view widget.
50         
51
52         * DumpRenderTree/qt/DumpRenderTree.cpp:
53         (WebCore::WebPage::setViewGeometry):
54         (WebCore::WebPage::WebPage):
55
56 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
57
58         Build fix.
59
60         * Drosera/DroseraWin.make:
61
62 2008-01-17  Darin Adler  <darin@apple.com>
63
64         * Scripts/run-webkit-tests: Fixed a bug number.
65
66 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
67
68         Reviewed by Adam Roben.
69
70         http://bugs.webkit.org/show_bug.cgi?id=16908
71         run-webkit-tests complains about missing FindSafari.exe
72
73         * Scripts/webkitdirs.pm: Append _debug as appropriate.
74
75 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
76
77         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
78         
79         Rubber-stamped by Jon Honeycutt.
80
81         * DumpRenderTree/win/DumpRenderTree.vcproj:
82
83 2008-01-16  Alp Toker  <alp@atoker.com>
84
85         Reviewed by Mark Rowe.
86
87         http://bugs.webkit.org/show_bug.cgi?id=16218
88         [GTK] API: Should this entry point be called go_back rather than go_backward?
89
90         Track back/forward API changes in the tools.
91
92         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
93         (BackForwardItem::invoke):
94         * GtkLauncher/main.c:
95         (go_back_cb):
96
97 2008-01-16  Adam Roben  <aroben@apple.com>
98
99         Windows build fix after r29488
100
101         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
102         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
103         expects to find the plugin.
104
105 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
106
107         Reviewed by Sam Weinig.
108         
109         Fixed the waitUntilDone watchdog timer -- the old code never added the
110         timer to the run loop, so it didn't do anything.
111
112         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
113         (LayoutTestController::setWaitToDump):
114         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
115         (LayoutTestController::setWaitToDump):
116
117 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
118
119         Use shared vsprops for most vcproj properties.
120         
121         Reviewed by Darin.
122
123         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
124         * DumpRenderTree/win/DumpRenderTree.vcproj:
125         * DumpRenderTree/win/ImageDiff.vcproj:
126         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
127         * FindSafari/FindSafari.vcproj:
128
129 2008-01-14  Stephanie  <slewis@apple.com>
130
131        Reviewed by NOBODY.
132   
133        revert accidental character.
134
135        * Scripts/run-webkit-tests:
136
137 2008-01-14  Stephanie  <slewis@apple.com>
138
139         RS=Oliver
140
141         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
142
143         * Scripts/run-webkit-tests:
144
145 2008-01-14  Darin Adler  <darin@apple.com>
146
147         * Scripts/do-webcore-rename: Queue up another rename.
148
149 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
150
151         Reviewed by Darin.
152
153         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
154         the tests were ran.
155         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
156
157         * Scripts/run-webkit-tests:
158
159 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
160
161         Reviewed by Darin.
162
163         * Randomize tests array to spot test cases where the results depends on the order
164         the tests are ran.
165         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
166
167         * Scripts/run-webkit-tests:
168
169 2008-01-14  Darin Adler  <darin@apple.com>
170
171         * Scripts/run-webkit-tests: More ignore list tweaking.
172
173 2008-01-14  Darin Adler  <darin@apple.com>
174
175         * Scripts/run-webkit-tests: Add another leak to the ignore list.
176
177 2008-01-14  Dan Bernstein  <mitz@apple.com>
178
179         Reviewed by Adam Roben.
180
181         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
182           build bots
183
184         * DumpRenderTree/win/DumpRenderTree.cpp:
185         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
186
187 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
188
189         Share common files across projects.
190         
191         Unify vsprops files
192         Debug:          common.vsprops, debug.vsprops
193         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
194         Release:        common.vsprops, release.vsprops
195         
196         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
197         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
198
199         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
200
201         Reviewed by Adam Roben.
202
203         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
204         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
205         * Drosera/win/Drosera.vcproj/VERSION: Removed.
206         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
207         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
208         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
209         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
210         * DumpRenderTree/win/DumpRenderTree.vcproj:
211         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
212         * DumpRenderTree/win/debug.vsprops: Removed.
213         * DumpRenderTree/win/debug_internal.vsprops: Removed.
214         * DumpRenderTree/win/release.vsprops: Removed.
215
216 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
217
218         Reviewed by Maciej.
219
220         - http://bugs.webkit.org/show_bug.cgi?id=16314
221           Script to launch Drosera
222
223         * Scripts/gdb-drosera: Added.
224         * Scripts/run-drosera: Added.
225         * Scripts/run-drosera-nightly.cmd: Added.
226         * Scripts/webkitdirs.pm: Added runDrosera function.
227
228 2008-01-13  Dan Bernstein  <mitz@apple.com>
229
230         - fix breakage due to last-minute change
231
232         * DumpRenderTree/win/DumpRenderTree.cpp:
233         (runTest): Declare the loop variable.
234
235 2008-01-13  Dan Bernstein  <mitz@apple.com>
236
237         Reviewed by Adam Roben.
238
239         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
240
241         * DumpRenderTree/win/DumpRenderTree.cpp:
242         (DumpRenderTreeWndProc):
243         (initialize):
244         (dumpBackForwardList):
245         (dumpBackForwardListForAllWindows):
246         (dump):
247         (resetWebViewToConsistentStateBeforeTesting): Factored out of
248         runTest().
249         (runTest):
250         (allWindows): Added. Returns a vector of all open windows.
251         (windowToWebViewMap): Added. Returns a map from open windows to their
252         WebViews.
253         (createWebViewAndOffscreenWindow): Factored out of main() to be
254         reusable for creating extra windows.
255         (main):
256         * DumpRenderTree/win/DumpRenderTreeWin.h:
257         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
258         (LayoutTestController::windowCount): Implemented.
259         * DumpRenderTree/win/UIDelegate.cpp:
260         (UIDelegate::createWebViewWithRequest): Implemented.
261         (UIDelegate::webViewClose): Implemented.
262         * DumpRenderTree/win/UIDelegate.h:
263
264 2008-01-12  Alp Toker  <alp@atoker.com>
265
266         Reviewed by Mark Rowe.
267
268         Hide non-public symbols in GTK+/autotools release builds.
269
270         * GNUmakefile.am:
271
272 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
273
274         Reviewed by Ap.
275
276         * Make launching of the WebKit httpd work on GNU/Debian/Linux
277         
278         The configuration of Apache2 and installation does not depend on
279         the kernel but on the distribution policy. Make launching of httpd
280         work for Debian derived distributions.
281
282         * Scripts/run-webkit-httpd:
283         * Scripts/run-webkit-tests:
284         * Scripts/webkitdirs.pm:
285
286 2008-01-12  Mark Rowe  <mrowe@apple.com>
287
288         Reviewed by Maciej Stachowiak.
289
290         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
291
292         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
293         match the callers expectations that it can take ownership of the string.
294
295 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
296
297         Reviewed by Adam Roben.
298
299         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
300
301         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
302         as these are only posted because the test window is not a normal visible one, and
303         they confuse drag&drop machinery.
304
305 2008-01-11  Adam Roben  <aroben@apple.com>
306
307         Fix a crash when pathToLocalResource fails and a leak
308
309         Reviewed by Darin.
310
311         * DumpRenderTree/LayoutTestController.cpp:
312         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
313         sure not to pass null to JSValueMakeString.
314         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
315         (LayoutTestController::pathToLocalResource): Print an error message if
316         the conversion fails so it's clear what happened.
317
318 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
319
320         Reviewed by John Sullivan.
321
322         * DumpRenderTree/mac/GCControllerMac.mm:
323         (GCController::collectOnAlternateThread): Updated for name change.
324
325 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
326
327         wx build fix. Don't build dftables any longer since it's now a Perl
328         script.
329
330         * wx/build-wxwebkit:
331
332 2008-01-10  Sam Weinig  <sam@webkit.org>
333
334         Reviewed by Anders Carlsson.
335
336         Make DRT track open windows instead of allocated windows so that
337         we can avoid ASSERTION due to late deallocs out of our control.
338
339         * DumpRenderTree/mac/DumpRenderTree.mm:
340         (dumpBackForwardListForAllWindows):
341         (runTest):
342         * DumpRenderTree/mac/DumpRenderTreeMac.h:
343         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
344         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
345         (+[DumpRenderTreeWindow openWindows]):
346         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
347         (-[DumpRenderTreeWindow close]):
348         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
349         (LayoutTestController::windowCount):
350
351 2008-01-10  Ada Chan  <adachan@apple.com>
352
353         Meta key is not the same as Alt key on windows.
354
355         Reviewed by Darin.
356
357         * DumpRenderTree/win/EventSender.cpp:
358         (keyDownCallback):
359
360 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
361
362         Reviewed by Darin, Sam and Adam.
363
364         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
365         link in gmail message displays JavaScript alert falsely complaining
366         about pop-up blocking.
367         - Added the ability to enable the pop-up blocker via the
368         LayoutTestController.
369
370         * DumpRenderTree/LayoutTestController.cpp:
371         (setPopupBlockingEnabledCallback):
372         (LayoutTestController::staticFunctions):
373         * DumpRenderTree/LayoutTestController.h:
374         * DumpRenderTree/mac/DumpRenderTree.mm:
375         (setDefaultsToConsistentValuesForTesting):
376         (resetWebViewToConsistentStateBeforeTesting):
377         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
378         (LayoutTestController::setPopupBlockingEnabled):
379
380 2008-01-10  Lars Knoll  <lars@trolltech.com>
381
382         Reviewed by Simon.
383
384         rename QWebPageHistory to QWebHistory.
385         
386
387         * DumpRenderTree/qt/jsobjects.cpp:
388
389 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
390
391         Reviewed by Darin.
392         
393         - add some more renames, adjust some
394
395         * Scripts/do-webcore-rename:
396
397 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
398
399         Reviewed by Oliver.
400
401         Enable SVG Fonts support by default.
402
403         * Scripts/build-webkit:
404
405 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
406
407         Reviewed by Adam.
408
409         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
410         DRT doesn't handle platform specific pixel test results correctly.
411
412         <test>-expected.txt files and <test>-expected.png files may now live
413         in different directories (ie. a cross-platform <test>-expected.txt file
414         and a platform-specific <test>-expected.png file).
415
416         * Scripts/run-webkit-tests:
417
418 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
419
420         Reviewed by Darin.
421
422         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
423         DRT did not correctly handle printing the '\0' char.  Now it does.
424
425         * DumpRenderTree/win/DumpRenderTree.cpp:
426         (dumpFramesAsText):
427         (dump):
428
429 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
430
431         Reviewed by Lars.
432
433         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
434         
435
436         * DumpRenderTree/qt/main.cpp:
437         * DumpRenderTree/qt/testplugin.cpp:
438         * DumpRenderTree/qt/testplugin.h:
439
440 2008-01-05  Mark Rowe  <mrowe@apple.com>
441
442         Reviewed by Alp Toker.
443
444         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
445
446         * DumpRenderTree/gtk/DumpRenderTree.cpp:
447         (processWork): Process pending work.
448         (webViewLoadFinished): Schedule processing of pending work.
449         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
450
451 2008-01-05  Darin Adler  <darin@apple.com>
452
453         * Scripts/do-webcore-rename: Some more renaming plans.
454
455 2008-01-04  Alice Liu  <alice.liu@apple.com>
456
457         Reviewed by Alexey and Darin.
458
459         Adding "home" and "end" to DRT's keydown since
460         DOM key events can't handle keyIdentifiers at this point. 
461
462         * DumpRenderTree/mac/EventSendingController.mm:
463         (-[EventSendingController keyDown:withModifiers:]):
464         * DumpRenderTree/win/EventSender.cpp:
465         (keyDownCallback):
466
467 2008-01-04  Lars Knoll  <lars@trolltech.com>
468
469         Reviewed by Simon.
470
471         fix DRT after the changes to QWebPage.
472         
473         The great thing is that we actually don't have
474         any regressions from the QWebPage change :)
475         
476
477         * DumpRenderTree/qt/DumpRenderTree.cpp:
478         (WebCore::DumpRenderTree::DumpRenderTree):
479
480 2008-01-04  Lars Knoll  <lars@trolltech.com>
481
482         Reviewed by Simon.
483
484         make QWebPage a QObject and get things to compile.
485         
486         Nothing works currently though.
487         
488
489         * DumpRenderTree/qt/DumpRenderTree.cpp:
490         (WebCore::DumpRenderTree::DumpRenderTree):
491
492 2008-01-04  Lars Knoll  <lars@trolltech.com>
493
494         Reviewed by Simon.
495
496         take a QString as identifier in QWebFrame::addToJSWindowObject.
497
498         * DumpRenderTree/qt/DumpRenderTree.cpp:
499         (WebCore::DumpRenderTree::initJSObjects):
500
501 2008-01-04  Alp Toker  <alp@atoker.com>
502
503         GTK+ DRT build fix for breakage introduced in r29149.
504
505         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
506         (LayoutTestController::execCommand):
507
508 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
509
510         Reviewed by Darin.
511
512         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
513
514         Added layoutTestController.execCommand to access editor commands that are not available
515         via document.execCommand.
516
517         * DumpRenderTree/LayoutTestController.cpp:
518         (execCommandCallback):
519         (LayoutTestController::staticFunctions):
520         * DumpRenderTree/LayoutTestController.h:
521         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
522         (LayoutTestController::execCommand):
523         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
524         (LayoutTestController::queueLoad):
525         (LayoutTestController::execCommand):
526
527 2008-01-03  Alice Liu  <alice.liu@apple.com>
528
529         Reviewed by Darin, Mitz.
530
531         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
532
533         the clickcount should not increase if the last click was at a different location.  it's a new click.
534
535         * DumpRenderTree/mac/DumpRenderTree.mm:
536         (runTest):
537         * DumpRenderTree/mac/EventSendingController.h:
538         * DumpRenderTree/mac/EventSendingController.mm:
539         (-[EventSendingController mouseDown]):
540         (-[EventSendingController mouseUp]):
541
542 2008-01-03  Darin Adler  <darin@apple.com>
543
544         Reviewed by Adam.
545
546         * Scripts/update-webkit: Make this work a little better for the people at Apple
547         who have a directory named Internal.
548
549 2008-01-03  Adam Roben  <aroben@apple.com>
550
551         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
552
553         Rubberstamped by Mark.
554
555         * Scripts/update-webkit-auxiliary-libs:
556
557 2008-01-03  Adam Roben  <aroben@apple.com>
558
559         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
560
561         http://bugs.webkit.org/show_bug.cgi?id=15663
562
563         Added a fuzz factor into the Last-Modified comparison for downloading
564         WebKitAuxiliaryLibrary.zip.
565
566         The zip file is served from a set of mirrors who give Last-Modified
567         times that are off by 1-3 seconds from each other. This was causing
568         the build bots to redownload WebKitAuxiliaryLibrary for every build,
569         which would then cause all of WebCore to rebuild each time.
570
571         Reviewed by Mark.
572
573         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
574         at least 30 seconds newer than the old one -- otherwise we assume that
575         the difference in time is due to the mirrors being slightly offset
576         from each other.
577         (sub lastModifiedToUnixTime): Added.
578
579 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
580
581         Windows build fix.
582
583         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
584
585 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
586
587         Reviewed by Lars.
588
589         Moved QWebPage::open to QWebFrame::load and added setHtml.
590         
591
592         * DumpRenderTree/qt/DumpRenderTree.cpp:
593         (WebCore::DumpRenderTree::open):
594
595 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
596
597         Reviewed by Lars.
598
599         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
600         
601
602         * DumpRenderTree/qt/DumpRenderTree.cpp:
603         (WebCore::DumpRenderTree::DumpRenderTree):
604
605 2008-01-02  Sam Weinig  <sam@webkit.org>
606
607         * Scripts/do-webcore-rename: Yet more renaming ideas.
608
609 2008-01-02  Darin Adler  <darin@apple.com>
610
611         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
612
613 2008-01-02  Alice Liu  <alice.liu@apple.com>
614
615         Reviewed by Sam Weinig.
616
617         fixing assertion hit with editing/selection/move-begin-end.html
618
619         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
620         * DumpRenderTree/win/DumpRenderTree.vcproj:
621         * DumpRenderTree/win/EventSender.cpp:
622         (keyDownCallback):
623         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
624
625 2008-01-02  Darin Adler  <darin@apple.com>
626
627         * Scripts/do-webcore-rename: Some more name change plans.
628
629 2008-01-02  Alice Liu  <alice.liu@apple.com>
630
631         Reviewed by Maciej.
632
633         Added handling for page up and page down in EventSender
634
635         * DumpRenderTree/mac/EventSendingController.mm:
636         (-[EventSendingController keyDown:withModifiers:]):
637         * DumpRenderTree/win/EventSender.cpp:
638         (keyDownCallback):
639
640 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
641
642         Reviewed by Darin.
643
644         Fix fast/events/arrow-keys-on-body.html for real.
645
646         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
647
648 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
649
650         Reviewed by Darin.
651
652         http://bugs.webkit.org/show_bug.cgi?id=16674
653         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
654
655         * Scripts/run-launcher:
656
657 2007-12-31  Darin Adler  <darin@apple.com>
658
659         Suggested by Antti.
660
661         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
662         we get it installed on the build bots.
663
664 2007-12-30  Eric Seidel  <eric@webkit.org>
665
666         Reviewed by Sam.
667
668         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
669
670 2007-12-29  Darin Adler  <darin@apple.com>
671
672         Reviewed by Oliver.
673
674         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
675           leak bot shows createCStringFromNPVariant result leaking
676
677         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
678         (pluginInvoke): Added a missing free.
679
680 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
681
682         Reviewed by Alp Toker.
683
684         http://bugs.webkit.org/show_bug.cgi?id=16390
685         Use autotools or GNU make as the build system for the GTK port
686
687         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
688         * GNUmakefile.am: Added.
689
690 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
691
692         Reviewed by Oliver.
693
694         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
695
696         * DumpRenderTree/win/EventSender.cpp:
697         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
698         of 1, even though WebKit currently ignores it.
699
700 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
701
702         wx buildbot fix. Update libpng dl script to the latest version.
703
704         * wx/install-unix-extras:
705
706 2007-12-22  Antti Koivisto  <antti@apple.com>
707
708         Fix a typo.
709
710         * Scripts/webkitdirs.pm:
711
712 2007-12-21  Sam Weinig  <sam@webkit.org>
713
714         Reviewed by Mark Rowe.
715
716         - Disable the back/forward cache using the new WebPreferences API
717           instead of through the BackForwardList.  This makes us match what
718           we do on Windows.
719
720         * DumpRenderTree/mac/DumpRenderTree.mm:
721         (createWebViewAndOffscreenWindow):
722         (setDefaultsToConsistentValuesForTesting):
723
724 2007-12-21  Dan Bernstein  <mitz@apple.com>
725
726         Reviewed by Mark Rowe.
727
728         - disable the back/forward cache in Windows DumpRenderTree. It is
729           already disabled in Mac DumpRenderTree.
730
731         * DumpRenderTree/win/DumpRenderTree.cpp:
732         (initializePreferences):
733
734 2007-12-13  Antti Koivisto  <antti@apple.com>
735
736         Reviewed by Darin and Steve.
737         
738         - check for QuickTime SDK on Windows.
739         - build media support on Windows by default
740
741         * Scripts/build-webkit:
742         * Scripts/webkitdirs.pm:
743
744 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
745
746         Build script fix for buildbot.
747
748         * wx/build-wxwebkit:
749
750 2007-12-20  Eric Seidel  <eric@webkit.org>
751
752         Reviewed by mjs.
753
754         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
755
756 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
757
758         Reviewed by Steve.
759
760         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
761         WebKit.
762
763         - Drosera and Safari need to use the same ProgIDs in order for
764         CoCreateInstance to work properly.  The most robust way to do this is
765         for WebKit to dynamically publish those ProgIDs.
766
767         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
768         (DebuggerClient::createWebViewWithRequest):
769         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
770         statics.
771         (Drosera::initUI):
772         (Drosera::attach):
773         (Drosera::attemptToCreateServerConnection):
774         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
775         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
776         make use of the published ProgIDs.
777         (ServerConnection::attemptToCreateServerConnection):
778
779 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
780
781         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
782         - Build bot and leak fix.
783
784         * DumpRenderTree/LayoutTestController.cpp:
785         (pathToLocalResourceCallback):
786
787 2007-12-19  David Kilzer  <ddkilzer@apple.com>
788
789         Make svn-apply/svn-unapply work with patches from git-format-patch.
790
791         Reviewed by Darin.
792
793         * Scripts/svn-apply:
794         (patch): If 'Index:' can't be found in the text passed in, print it
795         out with a warning and return early.
796         * Scripts/svn-unapply:
797         (patch): Ditto.
798
799 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
800
801         Reviewed by Alp Toker.
802
803         Build related fixes.
804
805         * wx/build-wxwebkit:
806         - Check to make sure the user is running a supported wx port
807         - More robust checks for Cygwin
808         - Only run install-unix-extras on Mac, it's not the right solution
809           for Linux distros.
810         - Remove outdated Linux instructions after successful build
811         - Clean Bakefile-generated files during a clean operation
812
813 2007-12-18  Darin Adler  <darin@apple.com>
814
815         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
816
817 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
818
819         Add script to run Drosera as part of the nightly.
820         
821         Reviewed by Kevin M.
822
823         * Scripts/run-drosera.cmd: Added.
824
825 2007-12-18  Darin Adler  <darin@apple.com>
826
827         * Scripts/do-webcore-rename: Remove a stray K.
828
829 2007-12-18  Darin Adler  <darin@apple.com>
830
831         * Scripts/do-webcore-rename: Plan more renaming.
832
833 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
834
835         Reviewed by Alp Toker.
836
837         http://bugs.webkit.org/show_bug.cgi?id=16042
838         [GTK] Eliminate webkit_init()
839
840         Moving webkit initialization to WebView class init.
841
842         * DumpRenderTree/gtk/DumpRenderTree.cpp:
843         (main):
844         * GtkLauncher/main.c:
845         (main):
846
847 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
848
849         Reviewed by Alp Toker.
850
851         http://bugs.webkit.org/show_bug.cgi?id=13542
852         gdklauncher doesnt change URL in adress GTKEntry.
853
854         * GtkLauncher/main.c:
855         (load_commit_cb): added
856         (title_change_cb):
857         (create_browser):
858
859 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
860
861         Reviewed by Adam Roben.
862
863         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
864
865         * FindSafari/FindSafari.cpp:
866         (_tmain):
867
868 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
869
870         Reviewed by Adam Roben.
871
872         http://bugs.webkit.org/show_bug.cgi?id=16315
873         FindSafari needs a path-only option.
874
875         * FindSafari/FindSafari.cpp:
876         (_tmain):
877
878 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
879
880         Reviewed by Darin.
881
882         http://bugs.webkit.org/show_bug.cgi?id=16462
883         REGRESSION: access keys broken on Windows
884
885         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
886         if Alt is pressed.
887
888 2007-12-15  Sam Weinig  <sam@webkit.org>
889
890         Reviewed by Mark Rowe.
891
892         Fix urlSuitableForTestResult to correctly identify wstring::npos as
893         the case when wstring.find doesn't find anything.
894
895         * DumpRenderTree/win/DumpRenderTree.cpp:
896         (urlSuitableForTestResult):
897
898 2007-12-15  Alp Toker  <alp@atoker.com>
899
900         GTK+ DRT build fix for GLib < 2.14.
901
902         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
903         (LayoutTestController::setWaitToDump):
904
905 2007-12-05  Mark Rowe  <mrowe@apple.com>
906
907         Reviewed by Alp Toker.
908
909         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
910         many layout tests from hanging while waiting on user responses to dialogs.
911
912         * DumpRenderTree/gtk/DumpRenderTree.cpp:
913         (invalidateAnyPreviousWaitToDumpWatchdog):
914         (webViewScriptAlert):
915         (webViewScriptPrompt):
916         (webViewScriptConfirm):
917         (main):
918         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
919         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
920         (waitToDumpWatchdogFired):
921         (LayoutTestController::setWaitToDump):
922
923 2007-12-05  Mark Rowe  <mrowe@apple.com>
924
925         Reviewed by Alp Toker.
926
927         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
928
929         * DumpRenderTree/gtk/DumpRenderTree.cpp:
930         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
931         (dump):
932         (runTest):
933         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
934         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
935         work queue is empty.
936         (webViewWindowObjectCleared): Set up window.layoutTestController.
937         (webViewConsoleMessage): Match the console message format expected by the layout test results.
938         (main): Hook up the new signals.
939         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
940         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
941         dumping multiple times.
942         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
943         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
944
945 2007-12-14  Anders Carlsson  <andersca@apple.com>
946
947         Reviewed by Brady.
948
949         Assert that a web frame that's loading a resource always has either a data source or 
950         a provisional data source.
951         
952         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
953         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
954
955 2007-12-14  Darin Adler  <darin@apple.com>
956
957         - fix mistake causing nearly all tests to fail on Windows
958
959         * DumpRenderTree/win/UIDelegate.cpp:
960         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
961         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
962
963         * DumpRenderTree/mac/UIDelegate.mm:
964         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
965         than passing the entire message.
966
967 2007-12-14  Darin Adler  <darin@apple.com>
968
969         - fix Tiger build
970
971         * DumpRenderTree/mac/UIDelegate.mm:
972         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
973         new-to-Leopard methods.
974
975 2007-12-14  Darin Adler  <darin@apple.com>
976
977         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
978         since it now triggers unwanted icon loading. We only had it because we implemented "all"
979         delegate methods here.
980
981 2007-12-14  Anders Carlsson  <andersca@apple.com>
982
983         Reviewed by Darin and Geoff.
984
985         <rdar://problem/5619295> 
986         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
987         
988         Add property getting methods to the plug-in.
989         
990         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
991         (pluginInvoke):
992
993 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
994
995         Reviewed by Darin.
996
997         - Layout test fix for mac. When dumped to the console local file paths
998         now only show the name of the resource not the whole path.  This is to
999         make the results machine and OS independent.
1000
1001         * DumpRenderTree/mac/UIDelegate.mm:
1002         (-[UIDelegate webView:addMessageToConsole:]):
1003
1004 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1005
1006         Reviewed by Adam.
1007
1008         - Layout tests fix.  We need a way to remove machine-dependent
1009         information from paths in layout test results. The UIDelegate now does
1010         this.
1011
1012         * DumpRenderTree/DumpRenderTree.h:
1013         * DumpRenderTree/win/DumpRenderTree.cpp:
1014         (urlSuitableForTestResult):
1015         * DumpRenderTree/win/DumpRenderTreeWin.h:
1016         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1017         * DumpRenderTree/win/UIDelegate.cpp:
1018         (UIDelegate::webViewAddMessageToConsole):
1019
1020 2007-12-13  Alp Toker  <alp@atoker.com>
1021
1022         Build fix for DRT breakage introduced in r28690.
1023
1024         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1025         (LayoutTestController::pathToLocalResource):
1026
1027 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1028
1029         Reviewed by Alice and Sam.
1030
1031         - <rdar://5621435> Need a way to specify local resources (being loaded
1032         from HTTP tests) on Windows.
1033         - Implemented pathToLocalResource which exposes the functionality of
1034         converting a given unix path to the correct location on Windows.
1035
1036         * DumpRenderTree/LayoutTestController.cpp:
1037         (pathToLocalResourceCallback):
1038         (LayoutTestController::staticFunctions):
1039         * DumpRenderTree/LayoutTestController.h:
1040         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1041         (LayoutTestController::pathToLocalResource):
1042         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1043         (LayoutTestController::pathToLocalResource):
1044
1045 2007-12-12  Anders Carlsson  <andersca@apple.com>
1046
1047         Reviewed by Sam.
1048
1049         <rdar://problem/5132003>
1050         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1051
1052         * DumpRenderTree/win/DumpRenderTree.cpp:
1053         (main):
1054         Set the resource load delegate.
1055         
1056         * DumpRenderTree/win/DumpRenderTree.vcproj:
1057         
1058         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1059         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1060
1061 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1062
1063         Reviewed by Adam Roben.
1064
1065         Fix conversion from double to LPARAM in dispatchMessage().
1066
1067         * DumpRenderTree/win/EventSender.cpp:
1068         (dispatchMessageCallback):
1069
1070 2007-12-11  Dan Bernstein  <mitz@apple.com>
1071
1072         Reviewed by Mark Rowe and Sam Weinig too!
1073
1074         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1075           fonts DumpRenderTree registers.
1076
1077         * DumpRenderTree/win/DumpRenderTree.cpp:
1078         (initialize):
1079
1080 2007-12-11  Brady Eidson  <beidson@apple.com>
1081
1082         Reviewed by Anders
1083
1084         Make DumpRenderTree on mac use its own path for Databases testing
1085
1086         * DumpRenderTree/mac/DumpRenderTree.mm:
1087         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1088           for future DRT-only use, then use it to construct the Databases path and set that default
1089
1090 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1091
1092         Reviewed by Darin.
1093
1094         <rdar://problem/5535636>
1095         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1096
1097         http://bugs.webkit.org/show_bug.cgi?id=13916
1098         JavaScript detects Tab as a character input on a textfield validation
1099
1100         * DumpRenderTree/mac/EventSendingController.mm:
1101         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1102         Dispatch a keyup to better match what happens when a key is physically pressed.
1103
1104         * DumpRenderTree/win/EventSender.cpp:
1105         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1106         returning from keyDown().
1107         (getConstantCallback): Fixed a couple copy/paste mistakes.
1108
1109 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1110
1111         Reviewed by Oliver.
1112
1113         - <rdar://5599845> Drosera: Does not show loal files in the file list
1114         on the left side.
1115
1116         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1117         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1118         so the open source community can build.
1119
1120 2007-12-10  Brady Eidson  <beidson@apple.com>
1121
1122         Rubberstamped by Sam Weinig
1123
1124         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1125
1126         * DumpRenderTree/mac/UIDelegate.mm:
1127         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1128         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1129
1130 2007-12-08  Oliver Hunt  <oliver@apple.com>
1131
1132         Reviewed by Sam W.
1133
1134         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1135         
1136         Fixes <rdar://problem/5620249> Must disable SVG animation
1137         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1138         
1139         In order to allow finer grained control over the set of SVG features
1140         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1141         distinct flags:
1142         ENABLE_SVG_ANIMATION
1143         ENABLE_SVG_FILTERS
1144         ENABLE_SVG_FONTS
1145         ENABLE_SVG_AS_IMAGE
1146         ENABLE_SVG_USE
1147         
1148         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1149         
1150         Script handles all the new build flags, and allows --svg-experimental
1151         to automatically enable all features.
1152
1153         * Scripts/build-webkit:
1154
1155 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1156
1157         Fix version parsing.
1158
1159         Rubber-stamped by Oliver.
1160
1161         * Drosera/win/Drosera.vcproj/auto-version.sh:
1162
1163 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1164
1165         Build modifications for Drosera.
1166
1167         Reviewed by Adam.
1168
1169         * Drosera/DroseraWin.make: Added.
1170         * Drosera/win/Drosera.vcproj/Drosera.rc:
1171         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1172         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1173         * Drosera/win/Drosera.vcproj/VERSION: Added.
1174         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1175
1176 2007-12-06  Adam Roben  <aroben@apple.com>
1177
1178         Explicitly turn on the Mac font ascent hack on Windows
1179
1180         This keeps our font metrics matching those from Mac.
1181
1182         Reviewed by Hyatt.
1183
1184         * DumpRenderTree/win/DumpRenderTree.cpp:
1185         (main):
1186
1187 2007-12-06  Anders Carlsson  <andersca@apple.com>
1188
1189         Rename main.c to main.cpp here too.
1190         
1191         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1192
1193 2007-12-06  Sam Weinig  <sam@webkit.org>
1194
1195         Rubber stamped by Geoff.
1196
1197         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1198
1199 2007-12-06  Darin Adler  <darin@apple.com>
1200
1201         * Scripts/do-webcore-rename: Some more renaming plans.
1202
1203 2007-12-06  Anders Carlsson  <andersca@apple.com>
1204
1205         Restore implementation of testGetIntIdentifier that was accidentally
1206         removed somehow (possibly when I made PluginObject be a cpp file).
1207         
1208         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1209         (pluginInvoke):
1210
1211 2007-12-05  Anders Carlsson  <andersca@apple.com>
1212
1213         Make the entry points extern "C".
1214         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1215         
1216 2007-12-05  Anders Carlsson  <andersca@apple.com>
1217
1218         C++ warning fixes.
1219         
1220         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1221         (NPP_New):
1222         (NPP_Destroy):
1223         (NPP_SetWindow):
1224         (NPP_NewStream):
1225         (NPP_HandleEvent):
1226         (NPP_URLNotify):
1227         (NPP_GetValue):
1228
1229 2007-12-05  Anders Carlsson  <andersca@apple.com>
1230
1231         Add the .cpp files to the TestNetscapePlugIn target.
1232
1233         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1234
1235 2007-12-05  Anders Carlsson  <andersca@apple.com>
1236
1237         Reviewed by Geoff.
1238         
1239         Rename the TestNetscapePlugIn .c files to be .cpp.
1240
1241         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1242         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1243         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1244         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1245         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1246         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1247         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1248         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1249
1250 2007-12-05  Adam Roben  <aroben@apple.com>
1251
1252         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1253
1254         This fixes several regression tests.
1255
1256         Reviewed by Alice.
1257
1258         * DumpRenderTree/win/EventSender.cpp:
1259         (keyDownCallback): Virtual keycodes for ASCII characters are always
1260         uppercase, so we need to check the case of the original character
1261         passed in to eventSender.keyDown.
1262
1263 2007-12-05  Adam Roben  <aroben@apple.com>
1264
1265         Learn from Tim's mistakes
1266
1267         * DumpRenderTree/win/DumpRenderTree.cpp:
1268         (runTest): Reset the authorAndUserStylesEnabled preference for each
1269         test.
1270
1271 2007-12-05  Alp Toker  <alp@atoker.com>
1272
1273         Reviewed by Mark Rowe.
1274
1275         Initialize GTK+ and WebKit so the tests can run.
1276
1277         Reorganize the headers a little.
1278
1279         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1280         (main):
1281
1282 2007-12-04  Anders Carlsson  <andersca@apple.com>
1283
1284         Remove IWebScriptScope include.
1285         
1286         * Drosera/win/DebuggerDocumentPlatform.cpp:
1287
1288 2007-12-04  Sam Weinig  <sam@webkit.org>
1289
1290         Rubber stamped by Mark Rowe.
1291
1292         Define CF as platform for mac and revert r28409
1293
1294         * DumpRenderTree/DumpRenderTree.h:
1295         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1296
1297 2007-12-04  Sam Weinig  <sam@webkit.org>
1298
1299         Define CF as platform for windows.
1300
1301         Reviewed by Adam Roben.
1302
1303         * DumpRenderTree/win/DumpRenderTreeWin.h:
1304
1305 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1306
1307         Reviewed by Adam and Darin.
1308
1309         - Removed a needless BSTR cleanup.
1310
1311         * Drosera/win/DebuggerDocumentPlatform.cpp:
1312         (DebuggerDocument::getPlatformCurrentFunctionStack):
1313
1314 2007-11-27  Adam Roben  <aroben@apple.com>
1315
1316         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1317
1318         Reviewed by Maciej.
1319
1320         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1321         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1322
1323 2007-12-04  Alp Toker  <alp@atoker.com>
1324
1325         Prospective Win DRT build fix.
1326
1327         * DumpRenderTree/DumpRenderTree.h:
1328
1329 2007-12-04  Alp Toker  <alp@atoker.com>
1330
1331         Fix a clobbered copyright header.
1332
1333         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1334
1335 2007-12-04  Xan Lopez  <xan@gnome.org>
1336
1337         Reviewed by Alp Toker.
1338
1339         http://bugs.webkit.org/show_bug.cgi?id=15561
1340         GTK port needs DumpRenderTree implementation
1341
1342         Start work on the GTK+ DRT.
1343
1344         This does not work yet, and there are a few lingering style issues
1345         (nothing major) but this patch has been stuck in the bug tracker for
1346         too long already.
1347
1348         * DumpRenderTree/DumpRenderTree.h:
1349         * DumpRenderTree/gtk: Added.
1350         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1351         (autocorrectURL):
1352         (shouldLogFrameLoadDelegates):
1353         (dumpFrameScrollPosition):
1354         (displayWebView):
1355         (appendString):
1356         (dumpFramesAsText):
1357         (dumpRenderTreeAsText):
1358         (dump):
1359         (runTest):
1360         (main):
1361         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1362         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1363         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1364         (GCController::collect):
1365         (GCController::collectOnAlternateThread):
1366         (GCController::getJSObjectCount):
1367         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1368         (LayoutTestController::~LayoutTestController):
1369         (LayoutTestController::addDisallowedURL):
1370         (LayoutTestController::clearBackForwardList):
1371         (LayoutTestController::copyDecodedHostName):
1372         (LayoutTestController::copyEncodedHostName):
1373         (LayoutTestController::display):
1374         (LayoutTestController::keepWebHistory):
1375         (LayoutTestController::notifyDone):
1376         (LayoutTestController::queueBackNavigation):
1377         (LayoutTestController::queueForwardNavigation):
1378         (LayoutTestController::queueLoad):
1379         (LayoutTestController::queueReload):
1380         (LayoutTestController::queueScript):
1381         (LayoutTestController::setAcceptsEditing):
1382         (LayoutTestController::setCustomPolicyDelegate):
1383         (LayoutTestController::setMainFrameIsFirstResponder):
1384         (LayoutTestController::setTabKeyCyclesThroughElements):
1385         (LayoutTestController::setUseDashboardCompatibilityMode):
1386         (LayoutTestController::setUserStyleSheetEnabled):
1387         (LayoutTestController::setUserStyleSheetLocation):
1388         (LayoutTestController::setWindowIsKey):
1389         (LayoutTestController::setWaitToDump):
1390         (LayoutTestController::windowCount):
1391         (LayoutTestController::setPrivateBrowsingEnabled):
1392         (LayoutTestController::setAuthorAndUserStylesEnabled):
1393         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1394         (JSStringCopyUTF8CString):
1395         (LoadItem::invoke):
1396         (ReloadItem::invoke):
1397         (ScriptItem::invoke):
1398         (BackForwardItem::invoke):
1399
1400 2007-12-03  Sam Weinig  <sam@webkit.org>
1401
1402         Move JavaScriptCore thread testing code to pthread specific directory
1403         and remove the dependance on CoreFoundation by using WTF::HashSet.
1404
1405         Reviewed by Geoff and Oliver.
1406
1407         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1408         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1409         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1410         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1411         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1412         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1413         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1414         * DumpRenderTree/pthreads: Added.
1415         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1416         (javaScriptThreads):
1417         (runJavaScriptThread):
1418         (startJavaScriptThreads):
1419         (stopJavaScriptThreads):
1420
1421 2007-12-03  Andrew Bonventre  <andybons@google.com>
1422
1423         Reviewed by Darin Adler.
1424
1425         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1426         Symbol lookup menu broken in debugger view
1427
1428         * Drosera/debugger.js: Fixed javascript error where document property
1429         should have been used instead of contentDocument in switchFunction that
1430         was breaking the select symbol dropdown menu.  This is because
1431         window.frames will return a Window object and not a frame object like
1432         the author was originally expecting.
1433
1434 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1435
1436         Reviewed by Adam.
1437
1438         - <rdar://5618942> Drosera: Console window does not process everything
1439         correctly.
1440         - <rdar://5619005> Drosera: could be sped up by moving the 
1441         WebScriptScope stuff into the WebScriptCallFrame.
1442         - Now the console can correctly process objects and does not receive
1443         notifications from JavaScriptCore about the JavaScript in Drosera's
1444         own process.
1445
1446         * Drosera/win/DebuggerDocumentPlatform.cpp:
1447         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1448         (DebuggerDocument::platformValueForScopeVariableNamed):
1449
1450 2007-12-03  Stephanie  <slewis@apple.com>
1451
1452         Reviewed by Darin.
1453
1454         Check to see if we are building a debug root
1455
1456         * Scripts/check-for-global-initializers: 
1457
1458 2007-12-03  Dan Bernstein  <mitz@apple.com>
1459
1460         Reviewed by Darin Adler.
1461
1462         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1463
1464         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1465         (pluginInvoke):
1466
1467 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1468
1469         Reviewed by Oliver.
1470
1471         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1472         in a more fine-grained manner than eventSender.keyDown().
1473
1474         * DumpRenderTree/win/EventSender.cpp:
1475         (getConstantCallback):
1476         (dispatchMessageCallback):
1477
1478 2007-12-02  Darin Adler  <darin@apple.com>
1479
1480         * Scripts/do-webcore-rename: More planned renaming.
1481
1482 2007-12-02  Sam Weinig  <sam@webkit.org>
1483
1484         Rubber stamped by Anders.
1485
1486         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1487         more uniform results cross platform.
1488
1489         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1490         (-[NSURL _drt_descriptionSuitableForTestResult]):
1491
1492 2007-12-02  Sam Weinig  <sam@webkit.org>
1493
1494         Rubber stamped by Niko.
1495
1496         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1497
1498         * DumpRenderTree/win/DumpRenderTree.cpp:
1499         * DumpRenderTree/win/DumpRenderTree.vcproj:
1500         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1501         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1502         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1503         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1504
1505 2007-12-01  Alp Toker  <alp@atoker.com>
1506
1507         Reviewed by Adam Roben.
1508
1509         Make use of the newly introduced webkit.h convenience header.
1510
1511         * GtkLauncher/main.c:
1512
1513 2007-12-01  Adam Treat  <treat@kde.org>
1514
1515         Reviewed by Simon.
1516
1517         * Check to see if the directory exists and exit if not.
1518
1519         * DumpRenderTree/qt/main.cpp:
1520         (main):
1521
1522 2007-12-01  Adam Treat  <treat@kde.org>
1523
1524         Reviewed by Simon.
1525
1526         * Don't hide symbols when in Debug mode
1527         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1528
1529
1530         * DumpRenderTree/qt/main.cpp:
1531         (messageHandler):
1532
1533 2007-11-30  Alp Toker  <alp@atoker.com>
1534
1535         Reviewed by Adam Roben.
1536
1537         http://bugs.webkit.org/show_bug.cgi?id=15691
1538         [GTK] Public API does not follow GTK+ conventions
1539
1540         Refactor the WebKit/GTK+ public API. Changes:
1541           WebKitPage -> WebKitWebView
1542           WebKitFrame -> WebKitWebFrame
1543
1544         Public API source and header names have been updated to mirror the API
1545         changes.
1546
1547         The API is now kept in WebKit/gtk/WebView to match other ports in the
1548         same class such as Mac and Win.
1549
1550         * GtkLauncher/main.c:
1551         (activate_uri_entry_cb):
1552         (link_hover_cb):
1553         (title_change_cb):
1554         (progress_change_cb):
1555         (go_back_cb):
1556         (go_forward_cb):
1557         (create_browser):
1558         (main):
1559
1560 2007-11-30  Adam Roben  <aroben@apple.com>
1561
1562         Hopefully the final build fix
1563
1564         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1565         pull in WTF's assertion/logging functions.
1566
1567 2007-11-30  Adam Roben  <aroben@apple.com>
1568
1569         Another build fix
1570
1571         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1572         WebKit.lib.
1573
1574 2007-11-30  Adam Roben  <aroben@apple.com>
1575
1576         Debug build fix
1577
1578         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1579         configuration.
1580         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1581         projects.
1582         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1583         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1584         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1585
1586 2007-11-30  Sam Weinig  <sam@webkit.org>
1587
1588         Reviewed by Adam Roben.
1589
1590         Fix drawSelectionRect to actually draw the selection rect.
1591
1592         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1593         (drawSelectionRect):
1594
1595 2007-11-30  Darin Adler  <darin@apple.com>
1596
1597         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1598
1599 2007-11-30  Darin Adler  <darin@apple.com>
1600
1601         * Scripts/do-webcore-rename: Get ready for some future renaming.
1602
1603 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1604
1605         Reviewed by Adam.
1606
1607         - Removed some unnecessary functions and changed an unused return type. 
1608
1609         * Drosera/win/DebuggerClient.cpp:
1610         (registerConsoleClass):
1611         * Drosera/win/DebuggerClient.h:
1612         * Drosera/win/Drosera.cpp:
1613         (registerDroseraClass):
1614
1615 2007-11-28  Alp Toker  <alp@atoker.com>
1616
1617         Reviewed by Timothy Hatcher.
1618
1619         http://bugs.webkit.org/show_bug.cgi?id=16174
1620         [GTK] Use "URI" not "URL" in public API
1621
1622         Replace use of the term "URL" with "URI" in public headers,
1623         documentation and some internal code to match GLib/GTK+ convention.
1624
1625         This is now mentioned in the API guidelines:
1626           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1627
1628         * GtkLauncher/main.c:
1629         (activate_uri_entry_cb):
1630         (title_change_cb):
1631         (create_toolbar):
1632         (main):
1633
1634 2007-11-29  Anders Carlsson  <andersca@apple.com>
1635
1636         Reviewed by Sam.
1637
1638         <rdar://problem/5230478>
1639         FrameLoadDelegate callbacks are not dumped in DRT.
1640         
1641         * DumpRenderTree/win/DumpRenderTree.cpp:
1642         (shouldLogFrameLoadDelegates):
1643         (runTest):
1644         (main):
1645         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1646         (BSTRtoString):
1647         (descriptionSuitableForTestResult):
1648         (FrameLoadDelegate::QueryInterface):
1649         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1650         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1651         (FrameLoadDelegate::didCommitLoadForFrame):
1652         (FrameLoadDelegate::didFinishLoadForFrame):
1653         (FrameLoadDelegate::willCloseFrame):
1654         (FrameLoadDelegate::didClearWindowObject):
1655         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1656         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1657         * DumpRenderTree/win/FrameLoaderDelegate.h:
1658         (FrameLoadDelegate::windowScriptObjectAvailable):
1659         (FrameLoadDelegate::didFirstLayoutInFrame):
1660
1661 2007-11-29  Sam Weinig  <sam@webkit.org>
1662
1663         Reviewed by Anders.
1664
1665         Add database quota UIDelegates methods to DRT UIDelegate.
1666
1667         * DumpRenderTree/mac/UIDelegate.mm:
1668         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1669         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1670
1671 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1672
1673         Reviewed by Sam.
1674
1675         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1676         dying and vice versa.
1677         - This fix will allow Drosera and Safari to reconnect if either of them
1678         closes correctly, but does not fix the case where one of them dies
1679         silently.
1680
1681         * Drosera/win/ServerConnection.cpp:
1682         (ServerConnection::attemptToCreateServerConnection): Added a safety
1683         check, because it's possilbe to try to connect to a server that's dying.
1684         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1685         the server has died.
1686         * Drosera/win/ServerConnection.h: Added the new function and removed
1687         an unnecessary member.
1688
1689 2007-11-29  Anders Carlsson  <andersca@apple.com>
1690
1691         * DumpRenderTree/win/DumpRenderTree.vcproj:
1692         Add shlwapi.lib to all configurations.
1693
1694 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1695
1696         - Build fix.  Added additional includes for VS Express to the Release
1697         project.
1698
1699         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1700
1701 2007-11-29  Anders Carlsson  <andersca@apple.com>
1702
1703         Reviewed by Adam.
1704
1705         <rdar://problem/5132005>
1706         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1707         
1708         * DumpRenderTree/win/DumpRenderTree.vcproj:
1709         Add shlwapi.lib
1710         
1711         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1712         (LayoutTestController::setUserStyleSheetEnabled):
1713         Implement this.
1714         
1715         (appendComponentToPath):
1716         New method which wraps the Win32 API PathAppend.
1717         
1718         (followShortcuts):
1719         New method which checks if a file points to a shortcut and
1720         follows the shortcut.
1721         
1722         (resolveCygwinPath):
1723         New method that takes a cygwin unix-style path and returns the Win32 path.
1724         
1725         (cfStringRefToWString):
1726         
1727         (LayoutTestController::setUserStyleSheetLocation):
1728         Implement this.
1729
1730 2007-11-29  Alice Liu  <alice.liu@apple.com>
1731
1732         Reviewed by Adam.
1733
1734         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1735
1736         * DumpRenderTree/win/EventSender.cpp:
1737         (keyDownCallback):
1738         uppercase letters were being sent as lowercase letters without the shift key down.
1739
1740 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1741
1742         - Windows build fix. VS express needs some love.
1743
1744         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1745
1746 2007-11-28  Darin Adler  <darin@apple.com>
1747
1748         Reviewed by Adam Roben.
1749
1750         * DumpRenderTree/mac/EventSendingController.mm:
1751         (-[EventSendingController keyDown:withModifiers:]):
1752         Send capital letters through as lowercase letters with the shift key down
1753         rather than sending them as if they were highly unusual "capital letter keys".
1754
1755         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1756         where you need to update results and more tests are failing than before.
1757
1758 2007-11-28  Anders Carlsson  <andersca@apple.com>
1759
1760         Reviewed by Darin.
1761
1762         <rdar://problem/5132001>
1763         contextClick is not implemented in DRT on Windows.
1764         
1765         * DumpRenderTree/win/EventSender.cpp:
1766         (contextClickCallback):
1767         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1768         by a WM_RBUTTONUP message.
1769         
1770         * DumpRenderTree/win/UIDelegate.cpp:
1771         (UIDelegate::hasCustomMenuImplementation):
1772         (UIDelegate::trackCustomPopupMenu):
1773         * DumpRenderTree/win/UIDelegate.h:
1774         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1775         menu from being shown (and causing the DRT to hang).
1776
1777 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1778
1779         Reviewed by Darin.
1780
1781         Fix DumpRenderTree ObjC bug comparing strings.
1782
1783         * DumpRenderTree/mac/ObjCController.m:
1784         (-[ObjCController identityIsEqual::]): Compare strings with string
1785         equality instead of identiy equality.
1786
1787 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1788
1789         Reviewed by Sam.
1790
1791         Reset the authorAndUserStylesEnabled preference
1792         back to YES for each test. Fixes the broken tests.
1793
1794         * DumpRenderTree/mac/DumpRenderTree.mm:
1795         (resetWebViewToConsistentStateBeforeTesting):
1796
1797 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1798
1799         Reviewed by Adam.
1800
1801         - Drosera now displays the console window, although it cannot currently
1802         process JavaScript.
1803
1804         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1805         (registerConsoleClass): Implemented.
1806         (consoleWndProc): Implemented.
1807         (DebuggerClient::onSize): Implemented.
1808         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1809         new window.
1810         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1811         creating and maintaining a new window.
1812         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1813         lines of code to more appropriate places.
1814         (Drosera::handleCommand):
1815         (Drosera::initUI):
1816         (Drosera::onSize):
1817         (Drosera::attach):
1818
1819 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1820
1821         Reviewed by Dave Hyatt.
1822
1823         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1824         
1825         Add support for disabling author and user styles for testing.
1826
1827         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1828         * DumpRenderTree/LayoutTestController.cpp:
1829         (setAuthorAndUserStylesEnabledCallback):
1830         (LayoutTestController::staticFunctions):
1831         * DumpRenderTree/LayoutTestController.h:
1832         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1833         (LayoutTestController::setAuthorAndUserStylesEnabled):
1834         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1835         (LayoutTestController::setAuthorAndUserStylesEnabled):
1836
1837 2007-11-26  Dan Bernstein  <mitz@apple.com>
1838
1839         - Tiger build fix.
1840
1841         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1842
1843 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1844
1845         Reviewed by Maciej.
1846
1847         - Implemented displaying variables for Drosera on Win.
1848
1849         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1850         that retrieve variables to not hold onto the return value since it's
1851         not returned.  Also changed to use the new signatures of the retrieval
1852         functions.
1853         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1854         (DebuggerDocument::platformValueForScopeVariableNamed):
1855         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1856         (droseraWndProc):
1857
1858 2007-11-26  Sam Weinig  <sam@webkit.org>
1859
1860         Cleanup names of painting and repainting functions.
1861
1862         Reviewed by Adam Roben.
1863
1864         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1865         (drawSelectionRect): was drawSelectionRectIntoContext.
1866         (dumpWebViewAsPixelsAndCompareWithExpected):
1867         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1868         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1869         (paintWebView): was drawWebViewIntoContext.
1870         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1871
1872 2007-11-26  Sam Weinig  <sam@webkit.org>
1873
1874         Reviewed by Dan Bernstein.
1875
1876         - Leopard build fix
1877
1878         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1879
1880 2007-11-26  Sam Weinig  <sam@webkit.org>
1881
1882         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1883         Use shared PixelDumpSupport for Mac DRT
1884
1885         Reviewed by Adam Roben.
1886
1887         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1888         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1889         * DumpRenderTree/cg/ImageDiffCG.cpp:
1890         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1891         (drawSelectionRectIntoContext):
1892         (dumpWebViewAsPixelsAndCompareWithExpected):
1893         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1894         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1895         * DumpRenderTree/mac/DumpRenderTree.mm:
1896         (dump):
1897         * DumpRenderTree/mac/ImageDiff.m: Removed.
1898         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1899         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1900         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1901         (setDefaultColorProfileToRGB):
1902         (getBitmapContextFromWebView):
1903         (drawWebViewIntoContext):
1904         (repaintWithVerticalSweep):
1905         (repaintWithHorizontalSweep):
1906         (getSelectionRect):
1907         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1908
1909 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1910
1911         Bug 16052: prepare-ChangeLog doesn't report deleted files
1912         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1913
1914         Reviewed by Sam.
1915
1916         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1917
1918 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1919
1920         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1921         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1922
1923         Reviewed by Adam.
1924
1925         Roll functionality of merge-changelog into resolve-ChangeLogs
1926         script.  The script now checks for ChangeLog.rej and
1927         ChangeLog.orig files first.  If it finds them, it uses the
1928         ChangeLog.rej file as a patch (in old contextual diff format) to
1929         apply with --fuzz=3.
1930
1931         * Scripts/merge-changelog: Removed.
1932         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1933
1934 2007-11-25  Sam Weinig  <sam@webkit.org>
1935
1936         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1937
1938         Reviewed by Mark Rowe.
1939
1940         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1941         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1942         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1943         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1944         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1945
1946 2007-11-25  Sam Weinig  <sam@webkit.org>
1947
1948         Convert DumpRenderTree to ues .xcconfig files.
1949
1950         Reviewed by Mark Rowe.
1951
1952         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1953         * DumpRenderTree/mac/Configurations: Added.
1954         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1955         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1956         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1957
1958 2007-11-25  Sam Weinig  <sam@webkit.org>
1959
1960         Add ForwardingHeaders to wtf for DumpRenderTree.
1961
1962         Reviewed by Mark Rowe.
1963
1964         * DumpRenderTree/DumpRenderTree.h:
1965         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1966         * DumpRenderTree/ForwardingHeaders: Added.
1967         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1968         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1969         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1970         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1971         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1972         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1973         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1974         * DumpRenderTree/LayoutTestController.cpp:
1975         * DumpRenderTree/WorkQueue.cpp:
1976         * DumpRenderTree/mac/DumpRenderTree.mm:
1977         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1978         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1979         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1980         * DumpRenderTree/mac/ObjCController.m:
1981         * DumpRenderTree/mac/UIDelegate.mm:
1982         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1983
1984 2007-11-25  Adam Roben  <aroben@apple.com>
1985
1986         Fix some test failures caused by r28019
1987
1988         Now that stdout is in binary mode, we need to always use printf
1989         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1990         the output.
1991
1992         Reviewed by Sam.
1993
1994         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1995         printf.
1996         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1997         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1998         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1999         (UIDelegate::webViewAddMessageToConsole):
2000
2001 2007-11-25  Adam Roben  <aroben@apple.com>
2002
2003         Set the font smoothing preference in DRT
2004
2005         This makes the pixel results on Windows closer to the Mac results.
2006
2007         Reviewed by Mitz.
2008
2009         * DumpRenderTree/win/DumpRenderTree.cpp:
2010         (initializePreferences):
2011
2012 2007-11-25  Adam Roben  <aroben@apple.com>
2013
2014         Port ImageDiff to CG and C++
2015
2016         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2017         <rdar://5071708>
2018
2019         Reviewed by Sam.
2020
2021         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2022         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2023         (main):
2024         (createImageFromStdin):
2025         (compareImages):
2026         (getDifferenceBitmap):
2027         (computePercentageDifferent):
2028         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2029
2030 2007-11-25  Adam Roben  <aroben@apple.com>
2031
2032         Fix image diff link generation on Windows
2033
2034         Reviewed by Sam.
2035
2036         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2037         to toURL.
2038
2039 2007-11-25  Adam Roben  <aroben@apple.com>
2040
2041         Implement pixel dumping in Windows DRT
2042
2043         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2044         <rdar://5071708>
2045
2046         Reviewed by Sam.
2047
2048         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2049         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2050         Content-Length header.
2051         (getMD5HashStringForBitmap):
2052         (dumpWebViewAsPixelsAndCompareWithExpected):
2053         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2054         * DumpRenderTree/win/DumpRenderTree.cpp:
2055         (dump): Do a pixel dump if requested.
2056         (main): Parse pixel test options.
2057         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2058         the cg/ subdirectory to the include path.
2059         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2060         available in a header or import library, so we have to go through this
2061         LoadLibrary/GetProcAddress dance to use them.
2062         (cryptDLL):
2063         (init):
2064         (update):
2065         (final):
2066         (MD5_Init):
2067         (MD5_Update):
2068         (MD5_Final):
2069         * DumpRenderTree/win/MD5.h: Added.
2070         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2071         moved up to the top level to share it with Mac eventually.
2072         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2073         (getBitmapContextFromWebView): Forces the WebView to paint using a
2074         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2075
2076 2007-11-25  Adam Roben  <aroben@apple.com>
2077
2078         Clean up Windows DRT's option parsing a little bit
2079
2080         Reviewed by Sam.
2081
2082         * DumpRenderTree/win/DumpRenderTree.cpp:
2083         (main): Put non-option arguments into a Vector.
2084
2085 2007-11-25  Adam Roben  <aroben@apple.com>
2086
2087         Make Windows DRT stop changing LF into CRLF
2088
2089         Reviewed by Sam.
2090
2091         * DumpRenderTree/win/DumpRenderTree.cpp:
2092         (main): Put stdout in binary mode.
2093         * Scripts/run-webkit-tests: Remove the CRLF hack.
2094
2095 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2096
2097         Removed empty directory.
2098
2099         * Scripts/resources: Removed.
2100
2101 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2102
2103         Fix bisect-builds to work with recent WebKit nightly builds.
2104
2105         Reviewed by Dan.
2106
2107         * Scripts/bisect-builds: Check for the 
2108         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2109         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2110         to WebKit.app/Contents/Resources.
2111
2112 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2113
2114         Reviewed by Maciej.
2115
2116         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2117         not closed (affects digg.com)
2118
2119         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2120         one after finishing with a test to avoid having its delayed onload handler firing when
2121         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2122         but it helps somewhat.
2123
2124 2007-11-22  Mark Rowe  <mrowe@apple.com>
2125
2126         Reviewed by Alp Toker.
2127
2128         Fix build-webkit to propagate make's exit status if it fails.
2129
2130         * Scripts/webkitdirs.pm:
2131
2132 2007-11-22  Dan Bernstein  <mitz@apple.com>
2133
2134         Reviewed by Mark Rowe.
2135
2136         - fix crash when running pixel tests
2137
2138         * DumpRenderTree/mac/DumpRenderTree.mm:
2139         (dumpRenderTree): Parse the command line options before setting up the
2140         environment so that we know if we need to set up the pixel dump
2141         machinery.
2142
2143 2007-11-21  Eric Seidel  <eric@webkit.org>
2144
2145         Speculative build fix for Tiger.
2146
2147         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2148
2149 2007-11-21  Eric Seidel  <eric@webkit.org>
2150
2151         Reviewed by Tim Hatcher.
2152
2153         Break out more of DumpRenderTree.mm into individual files
2154
2155         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2156         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2157         (checkedMalloc):
2158         (checkedRealloc):
2159         (makeLargeMallocFailSilently):
2160         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2161         * DumpRenderTree/mac/DumpRenderTree.mm:
2162         (crashHandler):
2163         (dump):
2164         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2165         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2166         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2167         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2168         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2169         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2170         (javaScriptThreads):
2171         (runJavaScriptThread):
2172         (startJavaScriptThreads):
2173         (stopJavaScriptThreads):
2174         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2175         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2176         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2177         (restoreColorSpace):
2178         (setDefaultColorProfileToRGB):
2179         (initializeColorSpaceAndScreeBufferForPixelTests):
2180         (md5HashStringForBitmap):
2181         (dumpWebViewAsPixelsAndCompareWithExpected):
2182
2183 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2184
2185         Move install-unix-extras to wx directory as it seems only to be used by that 
2186         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2187         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2188         have install-unix-extras install into WebKitLibraries as per
2189         convention.
2190         
2191         Reviewed by Mark Rowe.
2192
2193         * Scripts/install-unix-extras: Removed.
2194         * wx/build-wxwebkit:
2195         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2196
2197 2007-11-21  Eric Seidel  <eric@webkit.org>
2198
2199         Reviewed by Adam.
2200
2201         More refactoring for greater code readability
2202
2203         * DumpRenderTree/mac/DumpRenderTree.mm:
2204         (initializeGlobalsFromCommandLineOptions):
2205         (initializeColorSpaceAndScreeBufferForPixelTests):
2206         (addTestPluginsToPluginSearchPath):
2207         (useLongRunningServerMode):
2208         (runTestingServerLoop):
2209         (prepareConsistentTestingEnvironment):
2210         (dumpRenderTree):
2211         (main):
2212         (dumpFramesAsText):
2213         (dumpBackForwardListForWebView):
2214         (sizeWebViewForCurrentTest):
2215         (methodNameStringForFailedTest):
2216         (dumpBackForwardListForAllWindows):
2217         (dumpWebViewAsPixelsAndCompareWithExpected):
2218         (invalidateAnyPreviousWaitToDumpWatchdog):
2219         (dump):
2220         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2221         * DumpRenderTree/mac/UIDelegate.mm:
2222         (-[UIDelegate webView:createWebViewWithRequest:]):
2223
2224 2007-11-21  Eric Seidel  <eric@webkit.org>
2225
2226         Reviewed by Tim Hatcher.
2227
2228         Abstract more of DRT into static methods
2229
2230         * DumpRenderTree/mac/DumpRenderTree.mm:
2231         (setDefaultsToConsistentValuesForTesting):
2232         (setupSignalHandlers):
2233         (allocateGlobalControllers):
2234         (releaseAndZero):
2235         (releaseGlobalControllers):
2236         (dumpRenderTree):
2237         (shouldLogFrameLoadDelegates):
2238         (createCFURLFromPathOrURL):
2239         (resetWebViewToConsistentStateBeforeTesting):
2240         (runTest):
2241
2242 2007-11-21  Eric Seidel  <eric@webkit.org>
2243
2244         Reviewed by Tim Hatcher.
2245
2246         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2247
2248         * DumpRenderTree/DumpRenderTree.h:
2249         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2250         * DumpRenderTree/mac/DumpRenderTree.mm:
2251         (dumpRenderTree):
2252         (dump):
2253         (runTest):
2254         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2255         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2256         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2257         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2258         (-[DumpRenderTreePasteboard declareType:owner:]):
2259         (+[LocalPasteboard alloc]):
2260         (-[LocalPasteboard init]):
2261         (-[LocalPasteboard dealloc]):
2262         (-[LocalPasteboard name]):
2263         (-[LocalPasteboard releaseGlobally]):
2264         (-[LocalPasteboard declareTypes:owner:]):
2265         (-[LocalPasteboard addTypes:owner:]):
2266         (-[LocalPasteboard changeCount]):
2267         (-[LocalPasteboard types]):
2268         (-[LocalPasteboard availableTypeFromArray:]):
2269         (-[LocalPasteboard setData:forType:]):
2270         (-[LocalPasteboard dataForType:]):
2271         (-[LocalPasteboard setPropertyList:forType:]):
2272         (-[LocalPasteboard setString:forType:]):
2273         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2274         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2275         (+[DumpRenderTreeWindow allWindows]):
2276         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2277         (-[DumpRenderTreeWindow dealloc]):
2278         (-[DumpRenderTreeWindow isKeyWindow]):
2279         (-[DumpRenderTreeWindow keyDown:]):
2280
2281 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2282
2283         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2284         it indiscriminately copies any headers inside JavaScriptCore,
2285         which includes Tiger ICU headers. 
2286
2287         * wx/build-wxwebkit:
2288         Don't run WebCore/move-js-headers.sh any longer.
2289
2290 2007-11-20  Adam Treat  <treat@kde.org>
2291
2292         Reviewed by David Kilzer.
2293
2294         * Prepend git branch name to $baseProductDir
2295
2296         * Scripts/VCSUtils.pm:
2297         * Scripts/webkitdirs.pm:
2298
2299 2007-11-20  Mark Rowe  <mrowe@apple.com>
2300
2301         Reviewed by Simon Hausmann.
2302
2303         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2304         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2305         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2306         built product and generated Makefile's are removed.
2307
2308 2007-11-19  Alp Toker  <alp@atoker.com>
2309
2310         Reviewed by Mark Rowe.
2311
2312         http://bugs.webkit.org/show_bug.cgi?id=16040
2313         [GTK] GtkLauncher should be written in C
2314
2315         Port GtkLauncher to plain C.
2316
2317         Use a more conventional GTK+ coding style.
2318
2319         Use a toolbar instead of menus.
2320
2321         Various signature fixes and cleanups.
2322
2323         Add a license header. Assume all previous modifications were copyright
2324         assigned to Apple Inc. by default.
2325
2326         * GtkLauncher/GtkLauncher.pro:
2327         * GtkLauncher/main.c: Added.
2328         (activate_url_entry_cb):
2329         (update_title):
2330         (link_hover_cb):
2331         (title_change_cb):
2332         (progress_change_cb):
2333         (destroy_cb):
2334         (go_back_cb):
2335         (go_forward_cb):
2336         (create_browser):
2337         (create_statusbar):
2338         (create_toolbar):
2339         (create_window):
2340         (main):
2341         * GtkLauncher/main.cpp: Removed.
2342
2343 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2344
2345         Build script fixes to ensure they do the right thing for the 
2346         wx port, and update build-wxwebkit to reflect the way the
2347         build scripts now work.
2348
2349         Reviewed by Adam.
2350
2351         * Scripts/build-testkjs:
2352         * Scripts/build-webkit:
2353         * Scripts/run-javascriptcore-tests:
2354         * Scripts/webkitdirs.pm:
2355         * wx/build-wxwebkit:
2356
2357 2007-11-18  Eric Seidel  <eric@webkit.org>
2358
2359         Reviewed by Anders.
2360
2361         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2362
2363         * Scripts/run-javascriptcore-tests:
2364
2365 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2366
2367         Reviewed by Adam Roben.
2368
2369         Make run-webkit-tests work with Windows debug build.
2370
2371         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2372         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2373         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2374         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2375         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2376
2377 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2378
2379         Add wxWebKit sample and build script, and integrate it with 
2380         build-webkit. Also make build-webkit --clean work for all
2381         ports.
2382
2383         Reviewed by Darin Adler.
2384
2385         * Scripts/build-webkit:
2386         * Scripts/webkitdirs.pm:
2387         * wx: Added.
2388         * wx/browser: Added.
2389         * wx/browser/browser.bkl: Added.
2390         * wx/browser/browser.cpp: Added.
2391         * wx/build-wxwebkit: Added.
2392
2393 2007-11-17  Adam Roben  <aroben@apple.com>
2394
2395         Make it easy to run Safari in the debugger on Windows
2396
2397         I've added a new script, debug-safari, which launches Safari in the
2398         debugger. On OS X it just calls gdb-safari.
2399
2400         Reviewed by Mark Rowe.
2401
2402         * FindSafari/FindSafari.cpp:
2403         (_tmain): Added a /debugger flag, which in combination with
2404         /printSafariLauncher will print a script that launches Safari in the
2405         debugger.
2406         * Scripts/debug-safari: Added.
2407         * Scripts/run-safari: Changed to call runSafari().
2408         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2409         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2410         first argument along to FindSafari.
2411         * Scripts/webkitdirs.pm:
2412         (sub runSafari): Added.
2413
2414 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2415
2416         Reviewed by Adam Roben.
2417
2418         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2419
2420 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2421
2422         Reviewed by David Kilzer.
2423
2424         The git config command was renamed to repo-config at some point. This
2425         change tries git config and then git repo-config if the first fails.
2426
2427         * Scripts/prepare-ChangeLog:
2428         (gitConfig):
2429
2430 2007-11-16  Dan Bernstein  <mitz@apple.com>
2431
2432         Reviewed by Darin Adler and Sam Weinig.
2433
2434         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2435
2436         * DumpRenderTree/win/EventSender.cpp:
2437         (keyDownCallback): For characters that cannot be entered on the active
2438         keyboard layout, send a WM_CHAR message with the character along with
2439         a WM_KEYDOWN message with a virtual key code of 255.
2440
2441 2007-11-16  Mark Rowe  <mrowe@apple.com>
2442
2443         Reviewed by Tim Hatcher.
2444
2445         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2446
2447         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2448         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2449
2450 2007-11-15  Adam Roben  <aroben@apple.com>
2451
2452         Make run-safari actually work on Windows
2453
2454         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2455         chdir call.
2456
2457 2007-11-14  Adam Roben  <aroben@apple.com>
2458
2459         Updates to Safari launching now that 3.0.4 is released
2460
2461         Reviewed by Sam.
2462
2463         * FindSafari/FindSafari.cpp:
2464         (getWebViewCLSID): Use version-independent ProgID.
2465         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2466
2467 2007-11-14  Anders Carlsson  <andersca@apple.com>
2468
2469         Reviewed by Adam.
2470
2471         <rdar://problem/5309081>
2472         In DRT, "plugin.logDestroy = true" not working on Windows.
2473         
2474         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2475         (NPP_Destroy):
2476
2477 2007-11-14  Eric Seidel  <eric@webkit.org>
2478
2479         Reviewed by Sam.
2480
2481         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2482
2483 2007-11-14  Anders Carlsson  <andersca@apple.com>
2484
2485         Reviewed by Adam.
2486
2487         <rdar://problem/5141186>
2488         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2489         
2490         Implement setWindowIsKey.
2491         
2492         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2493         (LayoutTestController::setWindowIsKey):
2494
2495 2007-11-13  Sam Weinig  <sam@webkit.org>
2496
2497         Reviewed by Adam Roben.
2498
2499         Fix for <rdar://problem/5382579>
2500         http/tests/security/cross-frame-access-put.html reports large 
2501         negative numbers for screenLeft and screenTop (Mac reports "0")
2502
2503         * DumpRenderTree/win/UIDelegate.cpp:
2504         (UIDelegate::UIDelegate): Initialize the RECT.
2505         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2506         (UIDelegate::webViewFrame): ditto.
2507         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2508
2509 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2510
2511         Reviewed by Adam.
2512
2513         - Make Drosera show source, source URLs, and function stack on Windows,
2514         and some minor fixes.
2515
2516         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2517         (DebuggerDocument::updateFileSource):
2518         * Drosera/debugger.js: Force source to always update display.
2519         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2520         menu controls.
2521         (DebuggerClient::resume):
2522         (DebuggerClient::pause):
2523         (DebuggerClient::stepInto):
2524         (DebuggerClient::stepOver):
2525         (DebuggerClient::stepOut):
2526         (DebuggerClient::showConsole):
2527         (DebuggerClient::closeCurrentFile):
2528         * Drosera/win/DebuggerClient.h: Ditto.
2529         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2530         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2531         removed two bugs.  1) caller could be in a bad state when asked to
2532         assign into it. 2) BSTRs were not created correctly.
2533         (DebuggerDocument::getPlatformCurrentFunctionStack):
2534         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2535         (droseraWndProc):
2536         (handleCommand):
2537         (Drosera::resume):
2538         (Drosera::pause):
2539         (Drosera::stepInto):
2540         (Drosera::stepOver):
2541         (Drosera::stepOut):
2542         (Drosera::showConsole):
2543         (Drosera::closeCurrentFile):
2544         * Drosera/win/Drosera.h: Hook up the menu controls.
2545         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2546         functions, added a null check, and fixed another bug where caller could
2547         be in a bad state when asked to assign into it.
2548         (ServerConnection::didLoadMainResourceForDataSource):
2549         (ServerConnection::getCallerFrame):
2550         * Drosera/win/ServerConnection.h: Safety first.
2551
2552 2007-11-13  Dan Bernstein  <mitz@apple.com>
2553
2554         Reviewed by Darin Adler.
2555
2556         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2557           DumpRenderTree --pixel-tests renders each test twice
2558
2559         * DumpRenderTree/mac/DumpRenderTree.mm:
2560         (dumpRenderTree): Removed the --paint option because the painting code
2561         is always exercised as a result of
2562         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2563         calling -displayIfNeeded.
2564         (dump): Changed to always grab the image from the window since the view
2565         is always displayed.
2566         (runTest):
2567         (displayWebView):
2568         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2569         because it always paints.
2570
2571 2007-11-12  Antti Koivisto  <antti@apple.com>
2572
2573         Reviewed by Adele.
2574         
2575         Add support for http media tests
2576
2577         * Scripts/run-webkit-tests:
2578
2579 2007-11-12  Sam Weinig  <sam@webkit.org>
2580
2581         Reviewed by Adam Roben.
2582
2583         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2584
2585         * DumpRenderTree/win/DumpRenderTree.cpp:
2586         (runTest):
2587         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2588         (LayoutTestController::setPrivateBrowsingEnabled):
2589
2590 2007-11-12  Adam Roben  <aroben@apple.com>
2591
2592         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2593         mac and win subdirectories.
2594
2595 2007-11-11  Adam Roben  <aroben@apple.com>
2596
2597         Fix <rdar://5133816> keepWebHistory is not implemented
2598
2599         Fixes fast/history/clicked-link-is-visited.html.
2600
2601         Reviewed by Darin.
2602
2603         * DumpRenderTree/win/DumpRenderTree.cpp:
2604         (runTest): Clear the optionalSharedHistory.
2605         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2606         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2607
2608 2007-11-10  Sam Weinig  <sam@webkit.org>
2609
2610         Reviewed by Tim Hatcher.
2611
2612         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2613         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2614         is turned on)
2615
2616         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2617
2618         Added test: http/tests/security/cross-frame-access-private-browsing.html
2619
2620         * DumpRenderTree/LayoutTestController.cpp:
2621         (setPrivateBrowsingEnabledCallback):
2622         (LayoutTestController::staticFunctions):
2623         * DumpRenderTree/LayoutTestController.h:
2624         * DumpRenderTree/mac/DumpRenderTree.mm:
2625         (runTest): Default to private browsing disabled.
2626         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2627         (LayoutTestController::setPrivateBrowsingEnabled):
2628         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2629         (LayoutTestController::setPrivateBrowsingEnabled):
2630
2631 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2632
2633         Reviewed by Adam.
2634
2635         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2636         WebCore's!
2637
2638         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2639         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2640         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2641         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2642         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2643         * Drosera/win/Drosera.cpp:
2644         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2645
2646 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2647
2648         Reviewed by Sam.
2649
2650         - Use the new IWebFrame [local] function signature and get the shared
2651         server correctly.
2652
2653         * Drosera/win/DebuggerClient.cpp:
2654         (DebuggerClient::didFinishLoadForFrame):
2655         * Drosera/win/ServerConnection.cpp:
2656         (ServerConnection::attemptToCreateServerConnection):
2657
2658 2007-11-07  Dan Bernstein  <mitz@apple.com>
2659
2660         Reviewed by Darin Adler.
2661
2662         - add an option to run-webkit-tests to ignore pixel test failures where
2663           all pixels differ by no more than a specified threshold
2664
2665         * DumpRenderTree/mac/ImageDiff.m:
2666         (main):
2667         (compareImages):
2668         (computePercentageDifferent):
2669         * Scripts/run-webkit-tests:
2670
2671 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2672
2673         Reviewed by Lars.
2674
2675         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2676
2677         * DumpRenderTree/qt/DumpRenderTree.cpp:
2678
2679 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2680
2681         Reviewed by Lars.
2682
2683         Reworked the QWebSettings API.
2684         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2685
2686         * DumpRenderTree/qt/DumpRenderTree.cpp:
2687
2688 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2689
2690         Reviewed by Lars.
2691
2692         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2693
2694         * DumpRenderTree/qt/jsobjects.cpp:
2695
2696 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2697
2698         Reviewed by Lars Knoll <lars@trolltech.com>.
2699
2700         Add a QWebPage::frameCreated() signal and fix DRT
2701         
2702         The removal of createFrame in QWebPage broke the re-implementation
2703         in DumpRenderTree. Instead emit a frameCreated() signal and
2704         connect to it in DumpRenderTree.
2705         
2706
2707         * DumpRenderTree/qt/DumpRenderTree.cpp:
2708         (WebCore::WebPage::WebPage):
2709         (WebCore::DumpRenderTree::dump):
2710         (WebCore::DumpRenderTree::connectFrame):
2711         * DumpRenderTree/qt/DumpRenderTree.h:
2712
2713 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2714
2715         Reviewed by Lars Knoll <lars@trolltech.com>.
2716
2717         Moved all the event handlers from QWebFrame into QWebPage.
2718         
2719         This cleans up the public API and allows us to remove the
2720         HackWebFrame hack in DumpRenderTree.
2721         
2722
2723         * DumpRenderTree/qt/jsobjects.cpp:
2724         (EventSender::mouseDown):
2725         (EventSender::mouseUp):
2726         (EventSender::mouseMoveTo):
2727
2728 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2729
2730         Reviewed by Mark.
2731
2732         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2733         to prevent the default implementation from popping up messageboxes.
2734
2735         * DumpRenderTree/qt/DumpRenderTree.cpp:
2736         (WebCore::WebPage::javaScriptConfirm):
2737         (WebCore::WebPage::javaScriptPrompt):
2738
2739 2007-11-06  Eric Seidel  <eric@webkit.org>
2740
2741         * Scripts/build-testkjs: build fix... too many $$
2742
2743 2007-11-06  Eric Seidel  <eric@webkit.org>
2744
2745         Reviewed by Mark Rowe.
2746
2747         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2748
2749 2007-11-05  Adam Roben  <aroben@apple.com>
2750
2751         Add support on Windows for WEBKIT_TESTFONTS
2752
2753         This environment variable lets you specify where the fonts to be used
2754         by DumpRenderTree reside. The Qt port is already using this, so I'm
2755         just following their lead.
2756
2757         Reviewed by Darin.
2758
2759         * DumpRenderTree/win/DumpRenderTree.cpp:
2760         (exePath): Refactored code out of initialize().
2761         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2762         DumpRenderTree.resources.
2763         (initialize): Use the new fontsPath function.
2764         (main): Use the new exePath function.
2765         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2766         variable to DRT, like Qt does.
2767
2768 2007-11-05  Mark Rowe  <mrowe@apple.com>
2769
2770         Rubber-stamped by Alp Toker.
2771
2772         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2773
2774         * GtkLauncher/main.cpp:
2775         (goToURLBarText):
2776         (main):
2777
2778 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2779
2780         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2781         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2782
2783         Reviewed by Timothy.
2784
2785         Restrict the range of nightly builds used by the bisect-builds script
2786         based on the version of Safari and the version of Mac OS X being used.
2787
2788         Mac OS X 10.4: Safari 2.0: r11976 or newer
2789         Mac OS X 10.4: Safari 3.0: r19992 or newer
2790
2791         Mac OS X 10.5: Safari 2.0: r19594 or newer
2792         Mac OS X 10.5: Safari 3.0: r25124 or newer
2793
2794         * Scripts/bisect-builds:
2795         (findMacOSXVersion): Added.
2796         (makeNightlyList): Added argument to provide version of Mac OS X.
2797         Restrict range of nightly builds based on Safari and Mac OS X versions.
2798
2799 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2800
2801         Reviewed by Maciej.
2802
2803         - This patch involves several changes, all of them were noticed that
2804         they were needed by the work being done in WebKit to get Drosera and
2805         WebKit working together on Windows.
2806         - The changes are:
2807         1) Added a debugger console for output messages.
2808         2) Drosera now listens for the WebKit server (before, the server would
2809         have to be running before Drosera was started.)
2810         3) Fixed a bug where the WebView started out as 0x0 pixels.
2811         4) Fixed a bug when there is no scope.
2812         5) Added the HTML, JS, and CSS to the project file to make them easy to
2813         find.
2814         6) Made the ServerConnection functions virtual.
2815
2816         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2817         for the WebKit server.
2818         (DebuggerClient::DebuggerClient):
2819         (DebuggerClient::~DebuggerClient):
2820         (DebuggerClient::didFinishLoadForFrame):
2821         (DebuggerClient::serverConnected):
2822         (DebuggerClient::attemptToCreateServerConnection):
2823         * Drosera/win/DebuggerClient.h: Ditto.
2824         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2825         scope.
2826         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2827         (DebuggerDocument::platformValueForScopeVariableNamed):
2828         * Drosera/win/Drosera.cpp:
2829         (_tWinMain): Added a console in debug for output messages.
2830         (Drosera::Drosera): Listen for server.
2831         (Drosera::initUI): The server now Initializes COM.
2832         (Drosera::serverConnected): Part of the listening for the server.
2833         (Drosera::attemptToCreateServerConnection): Ditto.
2834         * Drosera/win/Drosera.h: New interface for listening for the server.
2835         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2836         files to the VS project.
2837         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2838         connection.
2839         (ServerConnection::ServerConnection):
2840         (ServerConnection::attemptToCreateServerConnection):
2841         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2842         methods.
2843         (ServerConnection::serverConnected):
2844
2845 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2846
2847         Reviewed by Maciej.
2848
2849         http://bugs.webkit.org/show_bug.cgi?id=15832
2850         fast/dom/gc-10.html crashes when run alone
2851
2852         Check for !done before using objects that can be already deallocated.
2853
2854         * DumpRenderTree/mac/EditingDelegate.mm:
2855         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2856         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2857         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2858         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2859         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2860         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2861         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2862         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2863         (-[EditingDelegate webViewDidBeginEditing:]):
2864         (-[EditingDelegate webViewDidChange:]):
2865         (-[EditingDelegate webViewDidEndEditing:]):
2866         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2867         (-[EditingDelegate webViewDidChangeSelection:]):
2868         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2869         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2870         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2871         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2872         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2873         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2874         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2875         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2876         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2877         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2878         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2879         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2880         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2881         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2882         (-[FrameLoadDelegate webView:willCloseFrame:]):
2883         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2884         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2885         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2886         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2887         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2888         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2889         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2890         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2891         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2892
2893 2007-11-04  Mark Rowe  <mrowe@apple.com>
2894
2895         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2896         warnings that would otherwise be suppressed due to it being a system header.
2897
2898         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2899
2900 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2901
2902         Rubber stamped by Adam.
2903         
2904         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2905
2906         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2907
2908 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2909
2910         Sort files(...); sections of Xcode project files.
2911
2912         Rubber-stamped by Darin.
2913
2914         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2915         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2916         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2917         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2918
2919 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2920
2921         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2922
2923         Reviewed by Darin.
2924
2925         * Scripts/sort-Xcode-project-file: Added.
2926
2927 2007-11-02  Darin Adler  <darin@apple.com>
2928
2929         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2930
2931 2007-11-02  Darin Adler  <darin@apple.com>
2932
2933         Reviewed by Maciej.
2934
2935         * Scripts/run-sunspider: Pass the "--base" option through.
2936
2937         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2938         the real script do that. Default configuration to Release to match run-sunspider
2939         so we don't end up building Debug just to compare results.
2940
2941 2007-11-01  Adam Roben  <aroben@apple.com>
2942
2943         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2944
2945         Reviewed by Sam.
2946
2947         * Scripts/commit-log-editor: Show all the directories beneath the
2948         source root, instead of just the last one.
2949
2950 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2951
2952         Reviewed by Adam Roben.
2953
2954         Print out an error message when the Windows build fails
2955         and provide guidance on how to find out what went wrong.
2956
2957         * Scripts/build-webkit:
2958         * Scripts/webkitdirs.pm:
2959
2960 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2961
2962         Rubber-stamped by Adam Roben.
2963
2964         Rolled out r27326 - debug CRT seems to cause no problems after all.
2965
2966         * DumpRenderTree/win/DumpRenderTree.vcproj:
2967
2968 2007-10-31  Adam Roben  <aroben@apple.com>
2969
2970         Switch the Debug configuration to using the non-debug CRT
2971
2972         This matches WebKit.
2973
2974         Reviewed by Steve.
2975
2976         * DumpRenderTree/win/DumpRenderTree.vcproj:
2977
2978 2007-10-31  Antti Koivisto  <antti@apple.com>
2979
2980         Reviewed by bdash.
2981         
2982         Disable media tests when doing leak checking on Tiger.
2983         They crash in QuickTime (rdar://problem/5537157).
2984
2985         * Scripts/run-webkit-tests:
2986
2987 2007-10-29  Antti Koivisto  <antti@apple.com>
2988
2989         Reviewed by Maciej.
2990         
2991         Build media support by default on OSX only.
2992
2993         * Scripts/build-webkit:
2994
2995 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2996
2997         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2998         get caught by the pre-commit hooks.
2999
3000 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3001
3002         Reviewed by Adam.
3003
3004         - This is a collection of relatively unrelated changes and cleanups
3005         to Drosera to prepare it for interacting with WebKit.  A lot of these
3006         changes are just correcting mistakes, for example removing included
3007         headers that are no longer needed.
3008
3009         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3010         this will be needed by the DebuggerClient.
3011         (DebuggerDocument::server):
3012         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3013         * Drosera/win/DebuggerClient.cpp: 
3014         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3015         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3016         (DebuggerClient::createWebViewWithRequest): Added comment about its
3017         purpose. 
3018         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3019         declarations.
3020         (DebuggerClient::webViewLoaded): Moved.
3021         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3022         file, since this was the only place it was used.
3023         (cfStringToBSTR):
3024         * Drosera/win/Drosera.h: Cleaned up the includes.
3025         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3026         * Drosera/win/HelperFunctions.h: Removed.
3027
3028 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3029
3030         Reviewed by Adam.
3031
3032         - Small cleanup in the ServerConnection class.
3033
3034         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3035         and added an include.
3036         (ServerConnection::currentFrame):
3037         (ServerConnection::getCallerFrame):
3038         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3039         made a pointer into a COMPtr, and cleaned up the includes.
3040
3041 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3042
3043         Reviewed by John Sullivan.
3044         
3045         - Place the Localizable.strings file in mac or win directories
3046           if that location exists.
3047         - Also look for UI_STRING in .c files.
3048
3049         * Scripts/extract-localizable-strings:
3050
3051 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3052
3053         Reviewed by Adam.
3054
3055         - Set the eol-style to native and made all the line endings the same
3056         so that I avoid messy diffs that show eol changes.
3057
3058         * Drosera/win/ServerConnection.cpp:
3059         (ServerConnection::didParseSource):
3060         (ServerConnection::didEnterCallFrame):
3061         (ServerConnection::willExecuteStatement):
3062         (ServerConnection::willLeaveCallFrame):
3063         (ServerConnection::exceptionWasRaised):
3064
3065 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3066
3067         Reviewed by Adam.
3068
3069         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3070         functionality that could not have existed previously without the new
3071         interfaces.
3072         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3073         from a BSTR to a JSValueRef.
3074         (DebuggerDocument::platformEvaluateScript): Implemented.
3075         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3076         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3077         Implemented.
3078         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3079         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3080         * Drosera/win/ServerConnection.cpp: Added a helper function.
3081         (ServerConnection::getCallerFrame):
3082         * Drosera/win/ServerConnection.h: Added a helper function.
3083
3084 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3085
3086         updated reviewers for my previous changelog.
3087
3088 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3089         Reviewed by Maciej and Adam and Geoff.
3090
3091         - Minor mac-side improvements including moving a function to a more
3092         appropriate location, fixing a warning, and correctly checking
3093         exceptions.
3094
3095         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3096         (DebuggerDocument::willExecuteStatement):
3097         (DebuggerDocument::didEnterCallFrame):
3098         (DebuggerDocument::willLeaveCallFrame):
3099         (DebuggerDocument::windowScriptObjectAvailable):
3100         (DebuggerDocument::callFunctionOnObject):
3101         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3102         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3103         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3104         because it doesn't require the ServerConnection at all.
3105         (NSStringCreateWithJSStringRef): Made an argument const.
3106         (JSValueRefCreateWithNSString): Made an argument const.
3107         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3108         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3109         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3110         * Drosera/mac/ServerConnection.mm: Ditto.
3111         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3112
3113 2007-10-29  Sam Weinig  <sam@webkit.org>
3114
3115         Reviewed by Adam Roben.
3116
3117         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3118
3119         * DumpRenderTree/LayoutTestController.cpp:
3120         (LayoutTestController::LayoutTestController):
3121         (getGlobalFlagCallback):
3122         (setGlobalFlagCallback):
3123         (LayoutTestController::getJSClass):
3124         (LayoutTestController::staticValues):
3125         * DumpRenderTree/LayoutTestController.h:
3126         (LayoutTestController::globalFlag):
3127         (LayoutTestController::setGlobalFlag):
3128
3129 2007-10-29  Darin Adler  <darin@apple.com>
3130
3131         Reviewed by Maciej.
3132
3133         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3134         resolution instead of its default.
3135
3136 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3137
3138         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3139
3140         Reviewed by Mark Rowe.
3141
3142         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3143         was successfully resolved, but this would not show any status because the change had
3144         already been cached in the index using "git add".  The solution is to add an optional
3145         second argument to showStatus() which adds the "--cached" switch to the command.
3146
3147         * Scripts/resolve-ChangeLogs:
3148         (showStatus):
3149
3150 2007-10-28  Eric Seidel  <eric@webkit.org>
3151
3152         Reviewed by Maciej and Geoff, in unison.
3153
3154         * Scripts/run-webkit-tests: remove broken --svg option
3155
3156 2007-10-28  Darin Adler  <darin@apple.com>
3157
3158         Reviewed by Adam.
3159
3160         * Scripts/run-sunspider: Default to "Release" configuration rather than
3161         defaulting to the last configuration used as other scripts do. This can
3162         still be overriden on the command line with "--debug" if there's some
3163         reason to do so. Also fix a typo.
3164
3165         * Scripts/sunspider-compare-results: Fix a typo.
3166
3167 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3168
3169         Reviewed by Adam.
3170
3171         - Implemented the WebScriptDebugListener functions now that the
3172         WebScriptDebugServer exists
3173
3174         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3175         functions.
3176         (ServerConnection::currentFrame):
3177         (ServerConnection::didLoadMainResourceForDataSource):
3178         (ServerConnection::didParseSource):
3179         (ServerConnection::failedToParseSource):
3180         (ServerConnection::didEnterCallFrame):
3181         (ServerConnection::willExecuteStatement):
3182         (ServerConnection::willLeaveCallFrame):
3183         (ServerConnection::exceptionWasRaised):
3184         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3185         members arguments list.
3186
3187 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3188
3189         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3190         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3191
3192         Reviewed by Darin.
3193
3194         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3195         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3196         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3197         file.  Note that it may also be used as a stand-alone script.
3198
3199         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3200         * Scripts/resolve-ChangeLogs: Added.
3201         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3202
3203 2007-10-26  Mark Rowe  <mrowe@apple.com>
3204
3205         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3206         to the Qt port on the assumption that it was an implementation of the cross-platform
3207         LayoutTestController class.  It is not, so it did not need to be changed.
3208
3209         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3210
3211 2007-10-25  Mark Rowe  <mrowe@apple.com>
3212
3213         Reviewed by Maciej.
3214
3215         Fix builds with code coverage enabled.
3216
3217         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3218
3219 2007-10-25  Darin Adler  <darin@apple.com>
3220
3221         Reviewed by Mark Rowe.
3222
3223         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3224         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3225
3226 2007-10-25  Stephanie  <slewis@apple.com>
3227
3228         build Fix
3229
3230         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3231
3232 2007-10-25  Stephanie  <slewis@apple.com>
3233
3234         Reviewed by Mark Rowe, Adam Roben.
3235
3236         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3237
3238         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3239
3240 2007-10-25  Alice Liu  <alice.liu@apple.com>
3241
3242         Reviewed by Adam.
3243
3244         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3245
3246         Moving destructor into platform-specific files
3247         * DumpRenderTree/LayoutTestController.cpp:
3248         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3249         (LayoutTestController::~LayoutTestController):
3250         * DumpRenderTree/qt/jsobjects.cpp:
3251         (LayoutTestController::~LayoutTestController):
3252
3253         LayoutTestController wasn't being destroyed
3254         * DumpRenderTree/win/DumpRenderTree.cpp:
3255         (runTest):
3256
3257         Added declspec
3258         * DumpRenderTree/win/EditingDelegate.h:
3259
3260         Reset certain values on the webview (or related delegate) that might 
3261         have changed while running a test
3262         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3263         (LayoutTestController::~LayoutTestController):
3264
3265 2007-10-25  Adam Roben  <aroben@apple.com>
3266
3267         Make sunspider-compare-results work with relative paths
3268
3269         Reviewed by Sam.
3270
3271         * Scripts/sunspider-compare-results: Convert arguments to absolute
3272         paths before we chdir.
3273
3274 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3275
3276         Reviewed by Sam.
3277
3278         - Implemented server calls now the WebScriptDebugServer exists.
3279         - Also removed no longer needed call to initialize CG.
3280
3281         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3282         automatically now.
3283         (_tWinMain):
3284         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3285         (ServerConnection::ServerConnection):
3286         (ServerConnection::~ServerConnection):
3287         (ServerConnection::pause):
3288         (ServerConnection::resume):
3289         (ServerConnection::stepInto):
3290         (ServerConnection::applicationTerminating):
3291         (ServerConnection::serverConnectionDidDie):
3292         * Drosera/win/ServerConnection.h: Now uses the COM class.
3293
3294 2007-10-24  George Staikos  <staikos@kde.org>
3295
3296         Unbreak Qt build.
3297
3298         * Scripts/build-webkit:
3299
3300 2007-10-24  Adam Roben  <aroben@apple.com>
3301
3302         Remove now-unnecessary call to InitializeCoreGraphics
3303
3304         WebKit takes care of this now.
3305
3306         Reviewed by Ada.
3307
3308         * DumpRenderTree/win/DumpRenderTree.cpp:
3309         (initialize):
3310
3311 2007-10-24  Adam Roben  <aroben@apple.com>
3312
3313         Use WebTextRenderer in DRT
3314
3315         Reviewed by Ada.
3316
3317         * DumpRenderTree/win/DumpRenderTree.cpp:
3318         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3319
3320 2007-10-24  Sven Herzberg  <sven@imendio.com>
3321
3322         Reviewed by Mark Rowe.
3323
3324         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3325         Bug 15614: [GTK] qmake based backends don't build on OS X
3326
3327         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3328         GTK backend on a Mac
3329         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3330         isDarwin() to make it reusable in other places (like the workaround-
3331         for-prebuilt-qmake in build-webkit)
3332
3333 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3334
3335         Refurbish update-webkit script.
3336
3337         Reviewed by Adam.
3338
3339         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3340         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3341         multi-argument version of system() for flexibility and security.  Check for existence
3342         of Internal directory using -d test instead of -x.
3343
3344 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3345
3346         Minor clean-up of prepare-ChangeLog script.
3347
3348         Reviewed by Adam.
3349
3350         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3351         of a string.  Use multi-argument versions of open() and system() for flexibility and
3352         security.
3353
3354 2007-10-24  Alice Liu  <alice.liu@apple.com>
3355
3356         Reviewed by Oliver.
3357
3358         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3359
3360         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3361         replay the saved events when we're still processing the mousedown that starts the drag
3362         * DumpRenderTree/win/EventSender.cpp:
3363         (doMouseMove):
3364         * DumpRenderTree/win/UIDelegate.cpp:
3365         (UIDelegate::doDragDrop):
3366
3367 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3368
3369         Reviewed by Sam, Steve and Darin.
3370
3371         - Stubbed out the WebScriptDebugListener functionality in the Server
3372         Connection class to prepare it for receiving those callbacks.
3373         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3374         and the ServerConnection to not need to be initialized with a server
3375         name, since that is not the way we connect to the WebKit server. 
3376
3377         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3378         no exception.  Now it only loggs when there is an exception
3379         (DebuggerDocument::willExecuteStatement):
3380         (DebuggerDocument::didEnterCallFrame):
3381         (DebuggerDocument::willLeaveCallFrame):
3382         (DebuggerDocument::windowScriptObjectAvailable):
3383         (DebuggerDocument::callFunctionOnObject):
3384         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3385         to be instantiated with a server's name.
3386         (DebuggerClient::DebuggerClient):
3387         (DebuggerClient::didFinishLoadForFrame):
3388         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3389         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3390         a server name.
3391         (Drosera::init):
3392         (Drosera::initServer):
3393         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3394         instantiated with a server's name.
3395         * Drosera/win/ServerConnection.cpp: 
3396         (ServerConnection::ServerConnection): No longer needs a server name
3397         (ServerConnection::~ServerConnection): Only release the global context
3398         if there is one.
3399         (ServerConnection::serverConnectionDidDie): Stub for
3400         IWebScriptDebugListener
3401         (ServerConnection::QueryInterface): ditto
3402         (ServerConnection::AddRef): ditto
3403         (ServerConnection::Release): ditto
3404         (ServerConnection::didLoadMainResourceForDataSource): ditto
3405         (ServerConnection::didParseSource): ditto
3406         (ServerConnection::failedToParseSource): ditto
3407         (ServerConnection::didEnterCallFrame): ditto
3408         (ServerConnection::willExecuteStatement): ditto
3409         (ServerConnection::willLeaveCallFrame): ditto
3410         (ServerConnection::exceptionWasRaised): ditto
3411         * Drosera/win/ServerConnection.h: Stubbed out the
3412         IWebScriptDebugListener functions, and this class no longer needs to be
3413         instantiated with a server name.
3414
3415 2007-10-24  Lars Knoll  <lars@trolltech.com>
3416
3417         Reviewed by Simon.
3418
3419         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3420
3421         * DumpRenderTree/qt/jsobjects.h:
3422
3423 2007-10-24  Lars Knoll  <lars@trolltech.com>
3424
3425         Reviewed by Simon.
3426
3427         add another command.
3428
3429         * DumpRenderTree/qt/jsobjects.cpp:
3430         (TextInputController::doCommand):
3431
3432 2007-10-24  Lars Knoll  <lars@trolltech.com>
3433
3434         Reviewed by Simon.
3435
3436         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3437
3438         * DumpRenderTree/qt/jsobjects.cpp:
3439         (EventSender::keyDown):
3440         * DumpRenderTree/qt/jsobjects.h:
3441
3442 2007-10-24  Lars Knoll  <lars@trolltech.com>
3443
3444         Reviewed by Simon.
3445
3446         implement eventSender.keyDown().
3447
3448         * DumpRenderTree/qt/jsobjects.cpp:
3449         (EventSender::keyDown):
3450
3451 2007-10-24  Lars Knoll  <lars@trolltech.com>
3452
3453         Reviewed by Simon.
3454
3455         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3456
3457         * DumpRenderTree/qt/DumpRenderTree.cpp:
3458         (WebCore::DumpRenderTree::DumpRenderTree):
3459         (WebCore::DumpRenderTree::initJSObjects):
3460         * DumpRenderTree/qt/jsobjects.cpp:
3461         (TextInputController::doCommand):
3462
3463 2007-10-24  Lars Knoll  <lars@trolltech.com>
3464
3465         Reviewed by Simon.
3466
3467         first bit of implementation for the textinputcontroller.
3468
3469         * DumpRenderTree/qt/DumpRenderTree.cpp:
3470         (WebCore::DumpRenderTree::DumpRenderTree):
3471         * DumpRenderTree/qt/DumpRenderTree.h:
3472         * DumpRenderTree/qt/jsobjects.cpp:
3473         (TextInputController::TextInputController):
3474         (TextInputController::doCommand):
3475         * DumpRenderTree/qt/jsobjects.h:
3476
3477 2007-10-24  Lars Knoll  <lars@trolltech.com>
3478
3479         Reviewed by Simon.
3480
3481         make the man webpage believe it has focus, so the editing tests work correctly.
3482
3483         * DumpRenderTree/qt/DumpRenderTree.cpp:
3484         (WebCore::DumpRenderTree::DumpRenderTree):
3485
3486 2007-10-24  Lars Knoll  <lars@trolltech.com>
3487
3488         Reviewed by Simon.
3489
3490         implement layoutTestController.dumpEditingCallbacks() correctly.
3491
3492         * DumpRenderTree/qt/DumpRenderTree.cpp:
3493         (WebCore::DumpRenderTree::DumpRenderTree):
3494         * DumpRenderTree/qt/jsobjects.cpp:
3495         (LayoutTestController::reset):
3496         (LayoutTestController::dumpEditingCallbacks):
3497
3498 2007-10-24  Lars Knoll  <lars@trolltech.com>
3499
3500         Reviewed by Simon.
3501
3502         Implement support for testing editing.
3503
3504         * DumpRenderTree/qt/DumpRenderTree.cpp:
3505         (WebCore::DumpRenderTree::DumpRenderTree):
3506
3507 2007-10-23  Sam Weinig  <sam@webkit.org>
3508
3509         Check for null BSTR that can be passed to the UIDelegate methods
3510         from javascript null and undefined.  Fixes a failing test case on
3511         Windows (fast/dom/Window/alert-undefined.html)
3512
3513         Reviewed by Eric Seidel.
3514
3515         * DumpRenderTree/win/UIDelegate.cpp:
3516         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3517         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3518         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3519         (UIDelegate::webViewAddMessageToConsole):
3520
3521 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3522
3523         Reviewed by Darin.
3524         
3525         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3526
3527         * Scripts/build-testkjs:
3528
3529 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3530
3531         Reviewed by Darin.
3532
3533         - add wrapper that finds the right copy of testkjs
3534         
3535         * Scripts/sunspider-compare-results: Added.
3536
3537 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3538
3539         Reviewed by Sam.
3540
3541         - After talking with Steve I now see that the WebKit server must be
3542         running for DCOM to create the distributed objects, which makes sense
3543         and currently WebKit only allows one instance to be running at a time
3544         which avoids accidentally connecting to the wrong server
3545         - In light of this I have removed the code for the attach box and
3546         NotificationServer and known server names, since they are all extranious
3547         now.
3548
3549         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3550         names.
3551         (_tWinMain): Uses init instead of initUI.
3552         (droseraWndProc): No longer creats an attach dialog box.
3553         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3554         it's not manditory to call init before doing COM stuff.
3555         (Drosera::init): calls initUI and will call attach when the
3556         functionality exists. 
3557         (Drosera::initUI): Has changed very little.
3558         (Drosera::attach): Changed the signature to reflect that we no longer
3559         need the dictionary of known server names.
3560         * Drosera/win/Drosera.h: Removed notification classes and known server
3561         names.  Also renamed and moved some functions.
3562         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3563         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3564         headers to the resources folder. 
3565         * Drosera/win/resource.h: Removed the Attach box.
3566
3567 2007-10-22  Adam Roben  <aroben@apple.com>
3568
3569         Windows build fix
3570
3571         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3572
3573 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3574
3575         - Removed a leak that was fixed.
3576
3577         * Scripts/run-webkit-tests:
3578
3579 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3580
3581         Reviewed by Darin.
3582
3583         - Changed the Client so that the DebuggerDocument now own the
3584         ServerConnection.  This simplifies ownership and cleanup. 
3585
3586         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3587         ServerConnection.
3588         (DebuggerClient::initWithServerName):
3589         (DebuggerClient::didFinishLoadForFrame):
3590         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3591         ServerConnection.
3592         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3593         until after we have a server which we are attached to.
3594         (Drosera::initUI):
3595         (Drosera::attach):
3596         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3597         out previously.
3598
3599 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3600
3601         Reviewed by Nikolas.
3602
3603         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3604
3605         * Scripts/run-javascriptcore-tests:
3606
3607 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3608
3609         Reviewed by Nikolas.
3610
3611         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3612
3613         * Scripts/build-drosera:
3614         * Scripts/build-dumprendertree:
3615         * Scripts/build-testkjs:
3616         * Scripts/build-webkit:
3617         * Scripts/run-javascriptcore-tests:
3618         * Scripts/run-sunspider:
3619         * Scripts/run-webkit-tests:
3620         * Scripts/webkitdirs.pm:
3621
3622 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3623
3624         Reviewed by Mark Rowe.
3625         
3626         Fix for local database support after r26879
3627         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3628
3629         * Scripts/build-webkit:
3630
3631 2007-10-22  Holger Freyther  <zecke@selfish.org>
3632
3633         Reviewed by Simon Hausmann <hausmann@kde.org>.
3634
3635         - Do not build testkjs as an application bundle. This is
3636         needed for run-javascriptcore-tests on OSX.
3637         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3638         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3639         as we do not have -rpath on OSX.
3640
3641         * DumpRenderTree/qt/DumpRenderTree.pro:
3642         * Scripts/run-webkit-tests:
3643
3644 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3645
3646         Reviewed by aroben.
3647
3648         Fix support for Signed-off-by detection in prepare-ChangeLog
3649         --git-commit. The Signed-off-by tag does not appear in the header
3650         but usually at the end.
3651
3652         * Scripts/prepare-ChangeLog:
3653
3654 2007-10-21  Mark Rowe  <mrowe@apple.com>
3655
3656         Reviewed by Eric.
3657
3658         Fix run-javascriptcore-tests for Gtk.
3659
3660         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3661
3662 2007-10-20  Eric Seidel  <eric@webkit.org>
3663
3664   &nbs