2009-11-25 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-25  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         bugzilla-tool should have a mark-fixed command
6         https://bugs.webkit.org/show_bug.cgi?id=31853
7
8         Pretty simple stuff.
9
10         * Scripts/modules/commands/upload.py:
11
12 2009-11-25  Eric Seidel  <eric@webkit.org>
13
14         Reviewed by Adam Barth.
15
16         'bugzilla-tool help' should only show common commands like how 'git help' does
17         https://bugs.webkit.org/show_bug.cgi?id=31772
18
19         I also took this opportunity to make 'help' a real Command.
20         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
21
22         * Scripts/bugzilla-tool:
23          - change should_show_command_help to should_show_in_main_help
24         * Scripts/modules/commands/download.py:
25          - Mark commands as being shown in main help or not.
26          - show_in_main_help = False is not required (default is false),
27            but it seemed to make the commands more self-documenting.
28         * Scripts/modules/commands/queries.py: ditto
29         * Scripts/modules/commands/queues.py: ditto
30         * Scripts/modules/commands/upload.py: ditto
31         * Scripts/modules/multicommandtool.py:
32          - Make Command hold a pointer to tool in self.tool.  Most Command
33            subclasses do not take advantage of this yet, but it was required
34            for HelpCommand to be able to reach the tool from _help_epilog().
35          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
36          - Move MultiCommandTool._help_epilog to Command._help_epilog
37          - Move "help" logic into HelpCommand.execute()
38          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
39         * Scripts/modules/multicommandtool_unittest.py:
40          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
41
42 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
43
44         Reviewed by Dan Bernstein.
45         
46         Patch by Mark Rowe.
47
48         The buildbots are failing on Windows because when they were upgraded
49         to 4.0.4, Apple Application Support was not in their path. Add it to
50         the path to fix the buildots.
51
52         * Scripts/webkitdirs.pm:
53
54 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
55
56         Reviewed by David Kilzer.
57
58         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
59         https://bugs.webkit.org/show_bug.cgi?id=31799
60
61         * Scripts/run-webkit-tests: Fixed.
62
63 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
64
65         Reviewed by Eric Seidel.
66
67         Change run_command to give back stderr by default
68         https://bugs.webkit.org/show_bug.cgi?id=31734
69
70         Change run_command to give back stderr by default.
71         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
72         Change the related unittest call.
73
74         * Scripts/modules/scm.py:
75         * Scripts/modules/scm_unittest.py:
76
77 2009-11-25  Eric Seidel  <eric@webkit.org>
78
79         Reviewed by Adam Barth.
80
81         Centralize required argument parsing in Command
82         https://bugs.webkit.org/show_bug.cgi?id=31872
83
84         * Scripts/modules/commands/download.py: remove custom required arg message.
85         * Scripts/modules/commands/upload.py: ditto.
86         * Scripts/modules/multicommandtool.py:
87          - Add _parse_required_arguments.
88          - Pass program name off to OptionParser.
89          - Add name() for access to tool name.
90          - Add check_arguments_and_execute and make it return a return code.
91          - Replace a couple uses of + with %.
92         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
93
94 2009-11-25  Eric Seidel  <eric@webkit.org>
95
96         Reviewed by Adam Barth.
97
98         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
99         https://bugs.webkit.org/show_bug.cgi?id=31870
100
101         * Scripts/modules/commands/queries_unittest.py: Use the new class.
102         * Scripts/modules/multicommandtool_unittest.py: Ditto.
103         * Scripts/modules/outputcapture.py: Added.
104
105 2009-11-24  Dmitry Titov  <dimich@chromium.org>
106
107         Reviewed by Eric Seidel.
108
109         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
110         https://bugs.webkit.org/show_bug.cgi?id=31444
111
112         * Scripts/build-webkit:
113
114 2009-11-24  Chris Marrin  <cmarrin@apple.com>
115
116         Reviewed by Simon Fraser.
117
118         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
119         https://bugs.webkit.org/show_bug.cgi?id=27314
120         
121         Now the script allows the directories with these tests to be included on all
122         platforms but Mac, where they behave the same as always. For all other platforms
123         the tests need to be excluded using the Skipped files, which is currently done
124         for all platforms (including win since we're not turned on yet)
125
126         * Scripts/webkitdirs.pm:
127
128 2009-11-24  Eric Seidel  <eric@webkit.org>
129
130         Reviewed by Adam Barth.
131
132         queries_unittest.py should test command output
133         https://bugs.webkit.org/show_bug.cgi?id=31845
134
135         * Scripts/modules/commands/queries_unittest.py:
136          - Capture stdout and stderr and compare with expected strings.
137
138 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
139
140         No Review.
141
142         Fix spelling error ("depenedencies").
143
144         * Scripts/build-webkit:
145
146 2009-11-24  Mark Rowe  <mrowe@apple.com>
147
148         Land the configuration that includes the two debug GTK Linux builders.
149
150         * BuildSlaveSupport/build.webkit.org-config/config.json:
151
152 2009-11-24  David Kilzer  <ddkilzer@apple.com>
153
154         <http://webkit.org/b/31840> bisect-builds broke after r50080
155
156         Reviewed by Dan Bernstein.
157
158         * Scripts/bisect-builds:
159         (mountAndRunNightly): Switched back to using backticks to run
160         the hdiutil command since exec() will terminate the existing
161         script, which is not what we want.  Store the output of
162         File::Spec->devnull() in a variable for use in the hdiutil
163         detach commands.
164
165 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
166
167         Reviewed by Kenneth Rohde Christiansen.
168
169         Include "config.h" to meet Coding Style Guidelines
170         https://bugs.webkit.org/show_bug.cgi?id=31792
171
172         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
173         * DumpRenderTree/qt/jsobjects.cpp:
174         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
175
176 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
177
178         Reviewed by Oliver Hunt.
179
180         Implement new required function to pass test we used to pass. This
181         change is required since r51294.
182
183         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
184         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
185
186 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
187
188         Reviewed by Kenneth Rohde Christiansen.
189
190         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
191         https://bugs.webkit.org/show_bug.cgi?id=31775
192
193         LayoutTestController::dumpBackForwardList() should work with local URLs
194         as well as with normal URLs (in http tests for instance).
195         Currently it does not output the latter properly.
196
197         Unskip a bunch of passing http/navigation tests.
198
199         * DumpRenderTree/qt/DumpRenderTree.cpp:
200         (WebCore::dumpHistoryItem):
201
202 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
203
204         Reviewed by Oliver Hunt.
205
206         ARIA: support aria-flowto
207         https://bugs.webkit.org/show_bug.cgi?id=31762
208
209         * DumpRenderTree/AccessibilityUIElement.cpp:
210         (ariaFlowToElementAtIndexCallback):
211         (AccessibilityUIElement::getJSClass):
212         * DumpRenderTree/AccessibilityUIElement.h:
213         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
214         (AccessibilityUIElement::ariaFlowToElementAtIndex):
215         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
216         (AccessibilityUIElement::ariaFlowToElementAtIndex):
217         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
218         (AccessibilityUIElement::ariaFlowToElementAtIndex):
219
220 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
221
222         Reviewed by Kenneth Christiansen.
223
224         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
225         https://bugs.webkit.org/show_bug.cgi?id=31638
226
227         Unfreeze WorkQueue after each test execution.
228
229         * DumpRenderTree/qt/DumpRenderTree.cpp:
230         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
231
232 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
233
234         Reviewed by Adam Barth.
235
236         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
237         for localhost and 127.0.0.1.
238         https://bugs.webkit.org/show_bug.cgi?id=31783
239
240         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
241
242         * DumpRenderTree/qt/DumpRenderTree.cpp:
243         (WebCore::NetworkAccessManager::NetworkAccessManager):
244         (WebCore::NetworkAccessManager::sslErrorsEncountered):
245         (WebCore::WebPage::WebPage):
246         * DumpRenderTree/qt/DumpRenderTree.h:
247
248 2009-11-22  Chris Evans  <cevans@chromium.org>
249
250         Reviewed by Adam Barth.
251
252         Disable access to file:/// directory listings
253         https://bugs.webkit.org/show_bug.cgi?id=31329
254
255         Implemented setAllowUniversalAccessFromFileURLs to support testing of
256         file URL security.
257
258         * DumpRenderTree/LayoutTestController.cpp:
259         (setAllowUniversalAccessFromFileURLsCallback):
260         (LayoutTestController::staticFunctions):
261         * DumpRenderTree/LayoutTestController.h:
262         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
263         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
264         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
265         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
266         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
267         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
268         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
269         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
270
271 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
272
273         Reviewed by Kenneth Rohde Christiansen.
274
275         [Qt] Fix the timeout of fast/frames/frame-navigation.html
276         https://bugs.webkit.org/show_bug.cgi?id=31638
277
278         The test is timeouting, because it uses the WorkQueue to load a document in one
279         of the child frames and once the loading is finished, the DRT does not dump the
280         tree. This is because it waits for the QWebFrame::loadFinished() signal from
281         the main frame, while it should connect to QWebPage::loadFinished().
282
283         * DumpRenderTree/qt/DumpRenderTree.cpp:
284         (WebCore::DumpRenderTree::DumpRenderTree):
285
286 2009-11-21  Eric Seidel  <eric@webkit.org>
287
288         Reviewed by Adam Barth.
289
290         bugzilla-tool --help spews way too much text
291         https://bugs.webkit.org/show_bug.cgi?id=31771
292
293         * Scripts/bugzilla-tool:
294          - Remove self.cached_scm initialization hack.
295         * Scripts/modules/buildbot.py:
296          - Make default_host accessible to callers.
297         * Scripts/modules/commands/download.py:
298          - Phrase help for all commands consistently and remove spurious help text punctuation.
299         * Scripts/modules/commands/queries.py: Ditto.
300         * Scripts/modules/commands/queues.py: Ditto.
301         * Scripts/modules/commands/upload.py: Ditto.
302         * Scripts/modules/multicommandtool.py:
303          - Add HelpPrintingOptionParser.format_epilog to replace
304            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
305            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
306          - Make --help only show a list of commands like "svn help" and "git help" do --
307            previously --help was listing all commands and options.
308          - Sort list of commands alphabetically.
309
310 2009-11-21  Eric Seidel  <eric@webkit.org>
311
312         No review.  Fixing a typo from the previous patch for bug 31767.
313
314         AbstractQueue.run_bugzilla_tool throws an exception
315         https://bugs.webkit.org/show_bug.cgi?id=31769
316
317         * Scripts/modules/commands/queues.py:
318
319 2009-11-21  Eric Seidel  <eric@webkit.org>
320
321         Reviewed by Adam Barth.
322
323         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
324         https://bugs.webkit.org/show_bug.cgi?id=31767
325
326         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
327         Since we don't have a good way to test BugzillaTool pieces, I've
328         left out a test for now.
329
330         * Scripts/bugzilla-tool:
331          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
332         * Scripts/modules/commands/queues.py:
333          - Use tool.path() instead of __file__.
334         * Scripts/modules/multicommandtool.py:
335          - Add a new path() method to MultiComandTool.
336         * Scripts/modules/multicommandtool_unittest.py:
337          - Provide a path() method.  Little point in testing this mock implementation.
338
339 2009-11-21  Adam Barth  <abarth@webkit.org>
340
341         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
342         WebKitTools.
343
344         * Scripts/modules/commands/download.py:
345
346 2009-11-21  Adam Barth  <abarth@webkit.org>
347
348         Reviewed by Eric Seidel.
349
350         Convert check-style to use LandingSequence
351         https://bugs.webkit.org/show_bug.cgi?id=31763
352
353         Instead of manipulating the working copy by hand, we should use the
354         LandingSequence in CheckStyle.  This will make this code eaiser to
355         test.
356
357         * Scripts/modules/commands/download.py:
358
359 2009-11-20  Adam Barth  <abarth@webkit.org>
360
361         Reviewed by Eric Seidel.
362
363         Unit test query commands
364         https://bugs.webkit.org/show_bug.cgi?id=31755
365
366         These tests are pretty rough, but hopefully they'll grow.
367
368         * Scripts/modules/commands/queries_unittest.py: Added.
369         * Scripts/modules/mock_bugzillatool.py: Added.
370         * Scripts/run-webkit-unittests:
371
372 2009-11-20  Eric Seidel  <eric@webkit.org>
373
374         Reviewed by Adam Barth.
375
376         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
377         https://bugs.webkit.org/show_bug.cgi?id=31758
378
379         * Scripts/modules/multicommandtool.py:
380          - Allow passing of explicit commands to MultiCommandTool.__init__
381         * Scripts/modules/multicommandtool_unittest.py:
382          - Use new Command.name naming system.
383          - Test Command auto-discovery.
384         * Scripts/modules/workqueue.py:
385          - bug_id no longer exists, use patch['bug_id'] instead.
386         * Scripts/modules/workqueue_unittest.py:
387          - WorkQueues require names now.
388          - should_proceed_with_work_item must return a patch object.
389
390 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
391
392         Reviewed by Beth Dakin.
393
394         WAI-ARIA: add support for aria-owns
395         https://bugs.webkit.org/show_bug.cgi?id=31702
396
397         * DumpRenderTree/AccessibilityUIElement.cpp:
398         (ariaOwnsElementAtIndexCallback):
399         (AccessibilityUIElement::getJSClass):
400         * DumpRenderTree/AccessibilityUIElement.h:
401         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
402         (AccessibilityUIElement::ariaOwnsElementAtIndex):
403         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
404         (AccessibilityUIElement::ariaOwnsElementAtIndex):
405         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
406         (AccessibilityUIElement::ariaOwnsElementAtIndex):
407
408 2009-11-20  Eric Seidel  <eric@webkit.org>
409
410         Reviewed by Adam Barth.
411
412         Fix exception thrown when running the commit-queue.
413
414         * Scripts/modules/statusbot.py: patch is optional.
415         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
416
417 2009-11-20  Eric Seidel  <eric@webkit.org>
418
419         Reviewed by Adam Barth.
420
421         Teach the StatusBot how to support more than just the commit-queue
422         https://bugs.webkit.org/show_bug.cgi?id=31754
423
424         * Scripts/modules/workqueue.py: Another typo.
425
426 2009-11-20  Eric Seidel  <eric@webkit.org>
427
428         Reviewed by Adam Barth.
429
430         Teach the StatusBot how to support more than just the commit-queue
431         https://bugs.webkit.org/show_bug.cgi?id=31754
432
433         * Scripts/modules/commands/queues.py: Fix silly typo.
434
435 2009-11-20  Eric Seidel  <eric@webkit.org>
436
437         Reviewed by Adam Barth.
438
439         Teach the StatusBot how to support more than just the commit-queue
440         https://bugs.webkit.org/show_bug.cgi?id=31754
441
442         * CommitQueueStatus/index.yaml:
443          - Add indices required for the new queries.
444         * CommitQueueStatus/queue_status.py:
445          - Add a patch-status page and move update_status to update-status.
446          - Only display "commit-queue" status records for the commit-queue.
447          - Add support for a queue_name property on status records.
448          - Fix _int_from_request to actually work.
449         * CommitQueueStatus/update_status.html:
450          - Add support for a queue_name on status records.
451          - Remove unused list of bug ids.
452          * Scripts/modules/commands/queues.py
453           - Make the queues pass the patch instead of the bug_id to StatusBot.
454         * Scripts/modules/statusbot.py:
455          - Support passing the queue_name to the status updates.
456          - Support fetching patch status with patch_status().
457         * Scripts/modules/workqueue.py:
458          - Pass the patch to the StatusBot instead of the bug_id.
459          - Let WorkQueues have a name.
460
461 2009-11-20  Adam Barth  <abarth@webkit.org>
462
463         Reviewed by Eric Seidel.
464
465         Move bugzilla-tool commands into their own file
466         https://bugs.webkit.org/show_bug.cgi?id=31752
467
468         This will let us write unit tests.
469
470         * Scripts/bugzilla-tool:
471         * Scripts/modules/commands/__init__.py: Added.
472         * Scripts/modules/commands/download.py: Added.
473         * Scripts/modules/commands/queries.py: Added.
474         * Scripts/modules/commands/queues.py: Added.
475         * Scripts/modules/commands/upload.py: Added.
476         * Scripts/modules/grammar.py: Added.
477
478 2009-11-20  Adam Barth  <abarth@webkit.org>
479
480         Reviewed by Eric Seidel.
481
482         BuildQueue should check if the tree is currently buildable
483         https://bugs.webkit.org/show_bug.cgi?id=31744
484
485         * Scripts/bugzilla-tool:
486         * Scripts/modules/landingsequence.py:
487         * Scripts/modules/webkitlandingscripts.py:
488
489 2009-11-20  Adam Barth  <abarth@webkit.org>
490
491         Reviewed by Eric Seidel.
492
493         Move prepare_clean_working_directory into the LandingSequence
494         https://bugs.webkit.org/show_bug.cgi?id=31743
495
496         * Scripts/bugzilla-tool:
497         * Scripts/modules/landingsequence.py:
498
499 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
500
501         Reviewed by Kenneth Rohde Christiansen.
502
503         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
504         https://bugs.webkit.org/show_bug.cgi?id=30460
505
506         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
507
508         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
509         (pluginInvoke):
510
511 2009-11-20  Adam Barth  <abarth@webkit.org>
512
513         Reviewed by Eric Seidel.
514
515         Pass the port information to the child process
516         https://bugs.webkit.org/show_bug.cgi?id=31736
517
518         We need to do this so the child process knows what to build!
519
520         * Scripts/bugzilla-tool:
521         * Scripts/modules/landingsequence.py:
522         * Scripts/modules/webkitport.py:
523         * Scripts/modules/webkitport_unittest.py:
524
525 2009-11-20  Adam Barth  <abarth@webkit.org>
526
527         Reviewed by Eric Seidel.
528
529         Support Qt port in build-queue
530         https://bugs.webkit.org/show_bug.cgi?id=31733
531
532         * Scripts/bugzilla-tool:
533
534 2009-11-20  Adam Barth  <abarth@webkit.org>
535
536         Reviewed by Eric Seidel.
537
538         Implement a build-queue
539         https://bugs.webkit.org/show_bug.cgi?id=31725
540
541         Currently this just builds the first 10 patches in the review queue.
542         We'll want to do something smarter soon.
543
544         * Scripts/bugzilla-tool:
545
546 2009-11-20  Adam Barth  <abarth@webkit.org>
547
548         Reviewed by Eric Seidel.
549
550         Make commit-queue and style-queue show up in help
551         https://bugs.webkit.org/show_bug.cgi?id=31724
552
553         We need to store their names on their class to make these commands
554         properly register themselves with MultiCommandTool.
555
556         * Scripts/bugzilla-tool:
557
558 2009-11-20  Adam Barth  <abarth@webkit.org>
559
560         Reviewed by Eric Seidel.
561
562         Implement bugzilla-tool build-attachment
563         https://bugs.webkit.org/show_bug.cgi?id=31722
564
565         This command builds an attachment from bugzilla.  It leaves the built
566         patch in the working copy.
567
568         * Scripts/bugzilla-tool:
569         * Scripts/modules/landingsequence.py:
570         * Scripts/modules/webkitlandingscripts.py:
571
572 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
573
574         Reviewed by Xan Lopez.
575
576         [GTK] DRT release event does not create the state correctly
577         https://bugs.webkit.org/show_bug.cgi?id=31717
578
579         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
580
581 2009-11-20  Eric Seidel  <eric@webkit.org>
582
583         Reviewed by Adam Barth.
584
585         MultiCommandTool should find Command objects automatically instead of with a manual list
586         https://bugs.webkit.org/show_bug.cgi?id=31710
587
588         * Scripts/bugzilla-tool:
589         * Scripts/modules/multicommandtool.py:
590          - Use some wild python-fu to crawl all the known subclasses of Command.
591
592 2009-11-20  Adam Barth  <abarth@webkit.org>
593
594         Unreviewed "build" fix.  Added missing import.
595
596         * Scripts/bugzilla-tool:
597
598 2009-11-20  Adam Barth  <abarth@webkit.org>
599
600         Unreviewed "build" fix.  I failed to update LandingSequence.test
601         properly.
602
603         * Scripts/modules/landingsequence.py:
604
605 2009-11-20  Adam Barth  <abarth@webkit.org>
606
607         Reviewed by Eric Seidel.
608
609         Create LandingSequence as the all-sing, all-dance landing class
610         https://bugs.webkit.org/show_bug.cgi?id=31709
611
612         Client can inherit from this class to carefully control exactly which
613         steps they wish to have happen in the landing sequence.
614
615         * Scripts/bugzilla-tool:
616         * Scripts/modules/landingsequence.py: Added.
617         * Scripts/modules/webkitlandingscripts.py: Added.
618
619 2009-11-19  Adam Barth  <abarth@webkit.org>
620
621         Reviewed by Eric Seidel.
622
623         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
624         https://bugs.webkit.org/show_bug.cgi?id=31707
625
626         This is to help when we implement build-attachment.
627
628         * Scripts/bugzilla-tool:
629
630 2009-11-19  Adam Barth  <abarth@webkit.org>
631
632         Reviewed by Eric Seidel.
633
634         Support Qt port in bugzilla-tool
635         https://bugs.webkit.org/show_bug.cgi?id=31701
636
637         Now we support building with Qt!
638
639         * Scripts/bugzilla-tool:
640         * Scripts/modules/webkitport.py: Added.
641         * Scripts/modules/webkitport_unittest.py: Added.
642         * Scripts/run-webkit-unittests:
643
644 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
645
646         Reviewed by Adam Barth.
647
648         Remove inserting stderr into patch in bugzilla-tool
649         https://bugs.webkit.org/show_bug.cgi?id=29914
650
651         Modify SCM python module's run_command function to avoid return of stderr
652         by default, so stderr won't be inserted into the patches.
653         Modify the related unit test.
654
655         * Scripts/modules/scm.py:
656         * Scripts/modules/scm_unittest.py:
657
658 2009-11-19  Eric Seidel  <eric@webkit.org>
659
660         Reviewed by Adam Barth.
661
662         bugzilla-tool needs per-command help
663         https://bugs.webkit.org/show_bug.cgi?id=31697
664
665         Added support for "bugzilla-tool help command-name"
666         and a unit test to make sure it works.
667
668         * Scripts/modules/multicommandtool.py:
669         * Scripts/modules/multicommandtool_unittest.py:
670
671 2009-11-19  Eric Seidel  <eric@webkit.org>
672
673         Reviewed by Adam Barth.
674
675         Move MultiCommandTool and Command into a separate file and add some basic unit tests
676         https://bugs.webkit.org/show_bug.cgi?id=31695
677
678         * Scripts/bugzilla-tool:
679         * Scripts/modules/multicommandtool.py: Added.
680         * Scripts/modules/multicommandtool_unittest.py: Added.
681         * Scripts/run-webkit-unittests:
682
683 2009-11-19  Eric Seidel  <eric@webkit.org>
684
685         No review, just adding a FIXME.
686
687         Split out command parsing and help printing from BugzillaTool
688         https://bugs.webkit.org/show_bug.cgi?id=31688
689
690         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
691
692 2009-11-19  Eric Seidel  <eric@webkit.org>
693
694         Reviewed by Adam Barth.
695
696         Split out command parsing and help printing from BugzillaTool
697         https://bugs.webkit.org/show_bug.cgi?id=31688
698
699         * Scripts/bugzilla-tool:
700          - Add new MultiCommandTool class to contain option parsing and help printing logic.
701          - Rename private methods to use _ pattern.
702          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
703          - 
704
705 2009-11-19  Eric Seidel  <eric@webkit.org>
706
707         Reviewed by Adam Barth.
708
709         Re-factor help printing to use modern python idioms
710         https://bugs.webkit.org/show_bug.cgi?id=31685
711
712         * Scripts/bugzilla-tool:
713
714 2009-11-19  Eric Seidel  <eric@webkit.org>
715
716         Reviewed by Darin Adler.
717
718         commit-queue empty queue logs twice
719         https://bugs.webkit.org/show_bug.cgi?id=31679
720
721         * Scripts/bugzilla-tool:
722
723 2009-11-19  Eric Seidel  <eric@webkit.org>
724
725         Reviewed by Darin Adler.
726
727         bugzilla-tool's reviewer/committer rejection message should be clearer
728         https://bugs.webkit.org/show_bug.cgi?id=31126
729
730         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
731
732         * Scripts/modules/bugzilla.py:
733
734 2009-11-19  Eric Z. Ayers  <zundel@google.com>
735
736         Reviewed by Pavel Feldman.
737
738         Forces a WM_PAINT event on calling layoutTestController.display()
739         in order to enable the timeline-paint.html test on Windows.
740         ::UpdateWindow() does not force an event becaue the window is 
741         not visible.
742
743         https://bugs.webkit.org/show_bug.cgi?id=31402
744
745         * DumpRenderTree/win/DumpRenderTree.cpp:
746         (displayWebView):
747
748 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
749
750         No review needed.
751
752         Added myself to committers list.
753
754         * Scripts/modules/committers.py:
755
756 2009-11-19  Adam Barth  <abarth@webkit.org>
757
758         Reviewed by Eric Seidel.
759
760         Bugzilla-tool command classes should match command names
761         https://bugs.webkit.org/show_bug.cgi?id=31666
762
763         I renamed all the commands except CommitMessageForCurrentDiff because
764         the new name would conflict with an existing class.
765
766         * Scripts/bugzilla-tool:
767
768 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
769
770         Reviewed by Gustavo Noronha Silva.
771
772         Web Inspector: Implement "show inspector" in WebKit GTK
773         API and enable console tests.
774
775         https://bugs.webkit.org/show_bug.cgi?id=31669
776
777         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
778         (LayoutTestController::showWebInspector):
779
780 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
781
782         Reviewed by Simon Hausmann.
783
784         Minor refactoring + more documentation.
785
786         * DumpRenderTree/qt/DumpRenderTree.cpp:
787         (WebCore::clearHistory):
788         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
789
790 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
791
792         Reviewed by Eric Seidel.
793
794         Ignore websocket tests when --no-http is specified.
795         https://bugs.webkit.org/show_bug.cgi?id=31662
796
797         * Scripts/run-webkit-tests:
798
799 2009-11-18  Adam Barth  <abarth@webkit.org>
800
801         Reviewed by Eric Seidel.
802
803         Normalize ' and " in bugzilla-tool
804         https://bugs.webkit.org/show_bug.cgi?id=31655
805
806         We decided " is better than ' and we should be consistent.
807
808         * Scripts/bugzilla-tool:
809
810 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
811
812         Reviewed by Kenneth Rohde Christiansen.
813
814         [Qt] Remove support for Qt v4.3 or older versions
815         https://bugs.webkit.org/show_bug.cgi?id=29469
816
817         * DumpRenderTree/qt/DumpRenderTree.pro:
818         * DumpRenderTree/qt/ImageDiff.pro:
819
820 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
821
822         Reviewed by Eric Seidel.
823
824         GitTest.test_create_binary_patch fails if /tmp is symlink
825         https://bugs.webkit.org/show_bug.cgi?id=31536
826
827         * Scripts/modules/scm_unittest.py:
828
829 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
830
831         Reviewed by Darin Adler.
832
833         Configuration for Chromium Build Slaves.
834
835         https://bugs.webkit.org/show_bug.cgi?id=31442
836
837         * BuildSlaveSupport/build.webkit.org-config/config.json:
838         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
839
840 2009-11-18  Eric Seidel  <eric@webkit.org>
841
842         Reviewed by Darin Adler.
843
844         workqueue.py results in totally broken commit-queue UI
845         https://bugs.webkit.org/show_bug.cgi?id=31645
846
847         * Scripts/bugzilla-tool:
848          - Remove unneeded use of PatchCollection.
849          - Grab a new copy of the cq'd patches every run of the queue.
850
851 2009-11-18  Sam Weinig  <sam@webkit.org>
852
853         Reviewed by Anders Carlsson.
854
855         Make the Mac Geolocation API async.
856
857         Update DRT to use the new async Mac Geolocation API.
858
859         * DumpRenderTree/mac/UIDelegate.mm:
860         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
861
862 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
863
864         Reviewed by Kenneth Rohde Christiansen.
865
866         Add and option to toggle HTML5 datalist support to build-webkit
867         https://bugs.webkit.org/show_bug.cgi?id=31599
868
869         * Scripts/build-webkit:
870
871 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
872
873         Reviewed by Kevin Ollivier.
874
875         Enable wx plugin support using the Windows implementation as a base.
876         
877         https://bugs.webkit.org/show_bug.cgi?id=31636
878
879         * wx/build/settings.py:
880
881 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
882
883         Reviewed by Simon Hausmann.
884
885         Change the initialization order so that the controllers
886         will be created before exporting them to the JS DOM window.
887
888         * DumpRenderTree/qt/DumpRenderTree.cpp:
889         (WebCore::DumpRenderTree::DumpRenderTree):
890
891 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
892
893         Reviewed by Simon Hausmann.
894
895         Fix a code copy and paste error. m_page should be page.
896
897         * DumpRenderTree/qt/DumpRenderTree.cpp:
898         (WebCore::DumpRenderTree::createWindow):
899
900 2009-11-17  Mark Rowe  <mrowe@apple.com>
901
902         Reviewed by Alexey Proskuryakov.
903
904         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
905
906         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
907         This prevents symlinks from confusing the descendant check.
908
909 2009-11-17  Mark Rowe  <mrowe@apple.com>
910
911         Reviewed by Alexey Proskuryakov.
912
913         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
914
915         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
916         server to be up rather than having run-webkit-tests abort immediately.
917
918         * Scripts/run-webkit-tests:
919
920 2009-11-17  Eric Seidel  <eric@webkit.org>
921
922         Reviewed by Darin Adler.
923
924         commit-queue is failing to set reviewer in ChangeLogs
925         https://bugs.webkit.org/show_bug.cgi?id=31592
926
927         * Scripts/bugzilla-tool: Clarify the "applying" log message.
928         * Scripts/modules/bugzilla.py:
929          - Add a new _validate_committer_and_reviewer function as a
930            temporary solution until we can make a real Attachment object
931            which knows how to fill in its committer/reviewer fields automatically.
932
933 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
934
935         Unreviewed buildbot fix.
936
937         Revert part of earlier patch and add comment, as it
938         was causing timeouts on the buildbot.
939
940         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
941         (LayoutTestController::notifyDone):
942
943 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
944
945         Reviewed by Oliver Hunt.
946
947         Make the timeout 15 sec as for the other DRT's and make
948         it print out the same output when a test timeout.
949
950         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
951         (LayoutTestController::waitUntilDone):
952         (LayoutTestController::notifyDone):
953         (LayoutTestController::timerEvent):
954
955 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
956
957         Reviewed by Timothy Hatcher.
958
959         Fixed typos in comments.
960
961         * Scripts/modules/committers.py:
962
963 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
964
965         Reviewed by Timothy Hatcher.
966
967         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
968         - Updated DRT to show/close inspector for all tests under /inspector
969         - Introduced LayoutTestController::setTimelineProfilingEnabled and
970           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
971         - Removed reload on each inspector test
972         - Renamed fast/inspector to fast/inspector-support in order not to trigger
973         inspector for those.
974         - Reimplemented timeline tests in order to get rid of reload there.
975         - Moved tests that don't require harness into the fast group.
976
977         https://bugs.webkit.org/show_bug.cgi?id=31472
978
979         * DumpRenderTree/LayoutTestController.cpp:
980         (setTimelineProfilingEnabledCallback):
981         (closeWebInspectorCallback):
982         (LayoutTestController::staticFunctions):
983         * DumpRenderTree/LayoutTestController.h:
984         * DumpRenderTree/gtk/DumpRenderTree.cpp:
985         (shouldOpenWebInspector):
986         (runTest):
987         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
988         (LayoutTestController::setTimelineProfilingEnabled):
989         * DumpRenderTree/mac/DumpRenderTree.mm:
990         (shouldOpenWebInspector):
991         (runTest):
992         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
993         (LayoutTestController::setTimelineProfilingEnabled):
994         * DumpRenderTree/win/DumpRenderTree.cpp:
995         (shouldOpenWebInspector):
996         (runTest):
997         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
998         (LayoutTestController::setTimelineProfilingEnabled):
999
1000 2009-11-17  Oliver Hunt  <oliver@apple.com>
1001
1002         Reviewed by Maciej Stachowiak.
1003
1004         Incorrect use of JavaScriptCore API in DumpRenderTree
1005         https://bugs.webkit.org/show_bug.cgi?id=31577
1006
1007         Return undefined rather than a literal null.
1008
1009         * DumpRenderTree/AccessibilityUIElement.cpp:
1010         (setSelectedTextRangeCallback):
1011         (incrementCallback):
1012         (decrementCallback):
1013         (showMenuCallback):
1014
1015 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1016
1017         Reviewed by Beth Dakin.
1018
1019         AX: aria-labelledby duplicates some of its WAI-ARIA label
1020         https://bugs.webkit.org/show_bug.cgi?id=31565
1021
1022         * DumpRenderTree/AccessibilityUIElement.cpp:
1023         (titleUIElementCallback):
1024         (getIsValidCallback):
1025         (AccessibilityUIElement::getJSClass):
1026
1027 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1028
1029         Reviewed by Simon Hausmann.
1030
1031         r50942 broke output from created windows. Make the
1032         m_enableTextOutput a member of the DRT and not the
1033         WebPage.
1034
1035         * DumpRenderTree/qt/DumpRenderTree.cpp:
1036         (WebCore::WebPage::WebPage):
1037         (WebCore::WebPage::javaScriptAlert):
1038         (WebCore::WebPage::javaScriptConsoleMessage):
1039         (WebCore::WebPage::javaScriptConfirm):
1040         (WebCore::WebPage::javaScriptPrompt):
1041         (WebCore::WebPage::acceptNavigationRequest):
1042         (WebCore::DumpRenderTree::DumpRenderTree):
1043         (WebCore::DumpRenderTree::open):
1044         (WebCore::DumpRenderTree::createWindow):
1045         * DumpRenderTree/qt/DumpRenderTree.h:
1046         (WebCore::DumpRenderTree::setTextOutputEnabled):
1047         (WebCore::DumpRenderTree::isTextOutputEnabled):
1048         (WebCore::WebPage::shouldInterruptJavaScript):
1049         (WebCore::WebPage::isTextOutputEnabled):
1050         (WebCore::WebPage::setViewGeometry):
1051
1052 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1053
1054         Reviewed by Gustavo Noronha Silva.
1055
1056         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1057         as the implementation is being used by at least Qt and Gtk+.
1058
1059         Update buildsystems as well.
1060
1061         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1062         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1063         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1064         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1065         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1066         * GNUmakefile.am:
1067
1068 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1069
1070         Reviewed by Alexey Proskuryakov.
1071
1072         Disable wss until all platforms support pyOpenSSL
1073
1074         https://bugs.webkit.org/show_bug.cgi?id=31479
1075
1076         * Scripts/run-webkit-tests:
1077
1078 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1079
1080         Reviewed by Kenneth Christiansen.
1081
1082         [Qt] Implement load error pages support for Qt's DRT.
1083         https://bugs.webkit.org/show_bug.cgi?id=31509
1084
1085         For now, it will not be a default feature, and layout tests
1086         that want to make use of this have to explicitily call
1087         'handleErrorPages();' for the test source.
1088
1089         Any of the other DumpRenderTree's (mac, win and gtk)
1090         support handling error pages. Qt's will be the first.
1091
1092         * DumpRenderTree/qt/DumpRenderTree.cpp:
1093         (WebCore::WebPage::supportsExtension):
1094         (WebCore::WebPage::extension):
1095         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1096         (LayoutTestController::reset):
1097         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1098         (LayoutTestController::shouldHandleErrorPages):
1099         (LayoutTestController::handleErrorPages):
1100
1101 2009-11-16  Eric Seidel  <eric@webkit.org>
1102
1103         Reviewed by Adam Barth.
1104
1105         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1106         https://bugs.webkit.org/show_bug.cgi?id=31549
1107
1108         Renamed --commit-queue to --non-interactive in most places
1109         and remove the code in land-patches which is no longer needed.
1110
1111         * Scripts/bugzilla-tool:
1112
1113 2009-11-16  Eric Seidel  <eric@webkit.org>
1114
1115         Reviewed by Adam Barth.
1116
1117         The commit-queue should use land-attachment
1118         https://bugs.webkit.org/show_bug.cgi?id=31548
1119
1120         * Scripts/bugzilla-tool:
1121
1122 2009-11-16  Adam Barth  <abarth@webkit.org>
1123
1124         Reviewed by Eric Seidel.
1125
1126         Convert CommitQueue over to PatchCollection
1127         https://bugs.webkit.org/show_bug.cgi?id=31547
1128
1129         Also fixes a bug in workqueue and adds a test!
1130
1131         * Scripts/bugzilla-tool:
1132         * Scripts/modules/workqueue.py:
1133         * Scripts/modules/workqueue_unittest.py:
1134
1135 2009-11-16  Adam Barth  <abarth@webkit.org>
1136
1137         Reviewed by Eric Seidel.
1138
1139         Move StyleQueue over to using PatchCollection
1140         https://bugs.webkit.org/show_bug.cgi?id=31544
1141
1142         That's what the class it's for.
1143
1144         * Scripts/bugzilla-tool:
1145         * Scripts/modules/patchcollection.py:
1146         * Scripts/modules/patchcollection_unittest.py:
1147
1148 2009-11-16  Eric Seidel  <eric@webkit.org>
1149
1150         Reviewed by Adam Barth.
1151
1152         bugzilla-tool needs a land-attachment command
1153         https://bugs.webkit.org/show_bug.cgi?id=31546
1154
1155         * Scripts/bugzilla-tool:
1156          - Move all the logic into AbstractLandingCommand and
1157            add a new LandAttachment command subclass.
1158          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1159
1160 2009-11-16  Eric Seidel  <eric@webkit.org>
1161
1162         Reviewed by Adam Barth.
1163
1164         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1165         https://bugs.webkit.org/show_bug.cgi?id=31543
1166
1167         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1168
1169         * Scripts/bugzilla-tool:
1170
1171 2009-11-16  Eric Seidel  <eric@webkit.org>
1172
1173         Reviewed by Adam Barth.
1174
1175         Disable the style queue from posting to the commit queue status page.
1176
1177         * Scripts/bugzilla-tool:
1178
1179 2009-11-16  Adam Barth  <abarth@webkit.org>
1180
1181         Reviewed by Eric Seidel.
1182
1183         Implement PatchCollection
1184         https://bugs.webkit.org/show_bug.cgi?id=31541
1185
1186         This class holds a set of patches and lets clients iterate through
1187         them.  Optionally, clients can install a filter.
1188
1189         * Scripts/modules/patchcollection.py: Added.
1190         * Scripts/modules/patchcollection_unittest.py: Added.
1191         * Scripts/run-webkit-unittests:
1192
1193 2009-11-16  Eric Seidel  <eric@webkit.org>
1194
1195         Reviewed by Adam Barth.
1196
1197         bugzilla-tool land-patches will close bugs with patches r=?
1198         https://bugs.webkit.org/show_bug.cgi?id=28230
1199
1200         The commit-queue shouldn't close patches with outstanding reviews on them,
1201         even if many reviewers seem to be against multi-patch bugs.
1202
1203         * Scripts/bugzilla-tool:
1204
1205 2009-11-16  Eric Seidel  <eric@webkit.org>
1206
1207         Reviewed by Adam Barth.
1208
1209         bugzilla-tool check-style should work with attachment ids instead of bug ids
1210         https://bugs.webkit.org/show_bug.cgi?id=31540
1211
1212         * Scripts/bugzilla-tool:
1213
1214 2009-11-16  Eric Seidel  <eric@webkit.org>
1215
1216         Reviewed by Adam Barth.
1217
1218         WorkQueue is the only place that should know about special exit codes
1219         https://bugs.webkit.org/show_bug.cgi?id=31534
1220
1221         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1222         and add tests for handling exit codes.
1223         I also cleaned up workqueue_unittest.py more.
1224
1225         * Scripts/bugzilla-tool:
1226         * Scripts/modules/workqueue.py:
1227         * Scripts/modules/workqueue_unittest.py:
1228
1229 2009-11-16  Eric Seidel  <eric@webkit.org>
1230
1231         Reviewed by Adam Barth.
1232
1233         Re-factor workqueue_unittest to allow for more than one test.
1234         https://bugs.webkit.org/show_bug.cgi?id=31535
1235
1236         * Scripts/modules/workqueue_unittest.py:
1237
1238 2009-11-16  Eric Seidel  <eric@webkit.org>
1239
1240         Reviewed by Adam Barth.
1241
1242         land-patches needs to be re-factored into smaller chunks
1243         https://bugs.webkit.org/show_bug.cgi?id=31532
1244
1245         * Scripts/bugzilla-tool: fix a couple obvious typos.
1246
1247 2009-11-16  Eric Seidel  <eric@webkit.org>
1248
1249         Reviewed by Adam Barth.
1250
1251         land-patches needs to be re-factored into smaller chunks
1252         https://bugs.webkit.org/show_bug.cgi?id=31532
1253
1254         The next patch will move these methods into WebKitLandingScripts.
1255
1256         * Scripts/bugzilla-tool:
1257          - Split out _land_patch and _close_bug_if_no_active_patches.
1258
1259 2009-11-16  Adam Barth  <abarth@webkit.org>
1260
1261         Reviewed by Eric Seidel.
1262
1263         Fix silly copy-and-paste code.  I am a terrible coder.
1264
1265         * Scripts/modules/bugzilla.py:
1266
1267 2009-11-16  Adam Barth  <abarth@webkit.org>
1268
1269         Reviewed by Eric Seidel.
1270
1271         Implement a StyleQueue
1272         https://bugs.webkit.org/show_bug.cgi?id=31537
1273
1274         The first iteration of the style queue only produces output locally.
1275         There is also a limit of 10 patches because it's not that useful to
1276         iterate through the entire review queue at this point.  We can remove
1277         the limit later.
1278
1279         * Scripts/bugzilla-tool:
1280         * Scripts/modules/bugzilla.py:
1281
1282 2009-11-16  Adam Barth  <abarth@webkit.org>
1283
1284         Reviewed by Eric Seidel.
1285
1286         Unit test WorkQueue
1287         https://bugs.webkit.org/show_bug.cgi?id=31531
1288
1289         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1290
1291         * Scripts/bugzilla-tool:
1292         * Scripts/modules/statusbot.py:
1293         * Scripts/modules/workqueue.py:
1294         * Scripts/modules/workqueue_unittest.py: Added.
1295         * Scripts/run-webkit-unittests:
1296
1297 2009-11-16  Eric Seidel  <eric@webkit.org>
1298
1299         Reviewed by Adam Barth.
1300
1301         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1302         https://bugs.webkit.org/show_bug.cgi?id=31530
1303
1304         * Scripts/bugzilla-tool:
1305
1306 2009-11-16  Eric Seidel  <eric@webkit.org>
1307
1308         Reviewed by Adam Barth.
1309
1310         bugzilla-tool needs apply-attachment
1311         https://bugs.webkit.org/show_bug.cgi?id=31528
1312
1313         * Scripts/bugzilla-tool:
1314          - Add ApplyAttachment command.
1315          - Abstract applying code into WebKitApplyingScripts.
1316          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1317         * Scripts/modules/bugzilla.py:
1318          - Add fetch_attachment and bug_id_for_attachment_id.
1319         * Scripts/modules/bugzilla_unittest.py:
1320          - Add test for new parsing.
1321          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1322
1323 2009-11-16  Eric Seidel  <eric@webkit.org>
1324
1325         Reviewed by Adam Barth.
1326
1327         Document check-style's use of force_clean.
1328
1329         * Scripts/bugzilla-tool:
1330         * Scripts/modules/scm.py:
1331
1332 2009-11-16  Adam Barth  <abarth@webkit.org>
1333
1334         Reviewed by Eric Seidel.
1335
1336         Move WorkQueue to its own file
1337         https://bugs.webkit.org/show_bug.cgi?id=31529
1338
1339         WorkQueue and WorkQueueDelegate are separate concerns from
1340         bugzilla-tool.  Also added a missing include to logging.py.
1341
1342         * Scripts/bugzilla-tool:
1343         * Scripts/modules/logging.py:
1344         * Scripts/modules/workqueue.py:
1345
1346 2009-11-16  Adam Barth  <abarth@webkit.org>
1347
1348         Reviewed by Eric Seidel.
1349
1350         Move OutputTee to logging.py.
1351
1352         * Scripts/bugzilla-tool:
1353         * Scripts/modules/logging.py:
1354
1355 2009-11-15  Adam Barth  <abarth@webkit.org>
1356
1357         Reviewed by Eric Seidel.
1358
1359         Refactor bugzilla-tool to allow for multiple queues
1360         https://bugs.webkit.org/show_bug.cgi?id=31513
1361
1362         Divide the commit queue class into three class to make creating
1363         additional queues easier.
1364
1365         * Scripts/bugzilla-tool:
1366
1367 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1368
1369         Reviewed by Eric Seidel.
1370
1371         svn-apply may not handle git patches created by bugzilla-tool
1372         https://bugs.webkit.org/show_bug.cgi?id=31457
1373
1374         * Scripts/modules/scm.py:
1375         * Scripts/modules/scm_unittest.py:
1376
1377 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1378
1379         Reviewed by Eric Seidel.
1380
1381         bugzilla-tool should post git binary diff
1382         https://bugs.webkit.org/show_bug.cgi?id=31458
1383
1384         Add --binary option to Git.create_patch.
1385
1386         * Scripts/modules/scm.py:
1387         * Scripts/modules/scm_unittest.py:
1388
1389 2009-11-15  Adam Barth  <abarth@webkit.org>
1390
1391         Reviewed by Darin Adler.
1392
1393         Add bugzilla-tool check-style
1394         https://bugs.webkit.org/show_bug.cgi?id=31515
1395
1396         * Scripts/bugzilla-tool:
1397         * Scripts/modules/bugzilla.py:
1398
1399 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1400
1401         Reviewed by Simon Hausmann.
1402
1403         Make the Qt Linux only --valgrind feature, suppress errors
1404         defined in the SuppressedValgrindErrors file.
1405
1406         * Scripts/run-webkit-tests:
1407
1408 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1409
1410         Reviewed by Simon Hausmann.
1411
1412         Set the locale to C and not to the current one in use on the system.
1413
1414         * DumpRenderTree/qt/DumpRenderTree.cpp:
1415         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1416
1417 2009-11-13  Adam Roben  <aroben@apple.com>
1418
1419         Add support for
1420         http/tests/security/isolatedWorld/didClearWindowObject.html
1421
1422         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1423         window objects in isolated worlds are cleared
1424
1425         Reviewed by Dave Hyatt.
1426
1427         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1428
1429         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1430         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1431         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1432         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1433         Added. Sets a __worldID property on the global object whose value is
1434         the ID of this world.
1435         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1436         Respond to this new delegate callback by calling through to one of the
1437         above new methods.
1438         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1439         (worldMap): Added. Returns a HashMap containing all the worlds we've
1440         created.
1441         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1442         haven't kept track of this world.
1443         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1444         instead of declaring our own.
1445
1446         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1447
1448         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1449         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1450         didClearWindowObjectForFrameInStandardWorld.
1451         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1452         Respond to this new delegate callback by calling through to one of the
1453         below new methods.
1454         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1455         Added. Sets a __worldID property on the gobal object whose value is
1456         the ID of this world.
1457         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1458         Added. Moved code here from didClearWindowObject.
1459
1460         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1461         didClearWindowObjectForFrame* functions.
1462
1463         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1464         (worldMap): Added. Returns a HashMap containing all the worlds we've
1465         created.
1466         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1467         haven't kept track of this world.
1468         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1469         instead of declaring our own.
1470
1471 2009-11-13  Adam Roben  <aroben@apple.com>
1472
1473         Finish replacing worldIDs with world objects
1474
1475         The only remaining use of worldIDs was in a method only used by DRT
1476         for the isolated worlds tests.
1477
1478         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1479
1480         Reviewed by Mark Rowe.
1481
1482         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1483         (LayoutTestController::evaluateScriptInIsolatedWorld):
1484         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1485         (LayoutTestController::evaluateScriptInIsolatedWorld):
1486         Updated for changes to WebFrame. Now holds the map of worldID -> world
1487         at this level instead of making WebKit do it.
1488
1489 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1490
1491         Reviewed by Simon Hausmann.
1492
1493         [Qt] Ensure the DRT does not output anything until first test is run
1494
1495         * DumpRenderTree/qt/DumpRenderTree.cpp:
1496         * DumpRenderTree/qt/DumpRenderTree.h:
1497
1498 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1499
1500         Reviewed by Tor Arne Vestbø.
1501
1502         Clear the undo stack in before each new test run.
1503
1504         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1505
1506         * DumpRenderTree/qt/DumpRenderTree.cpp:
1507         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1508
1509 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1510
1511         Reviewed by Kenneth Rohde Christiansen.
1512
1513         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1514
1515         * DumpRenderTree/qt/DumpRenderTree.cpp:
1516         (WebCore::WebPage::resetSettings):
1517         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1518         (LayoutTestController::overridePreference):
1519
1520 2009-11-13  Eric Seidel  <eric@webkit.org>
1521
1522         Reviewed by Adam Barth.
1523
1524         Update committers.py based on svn records
1525         https://bugs.webkit.org/show_bug.cgi?id=31366
1526
1527         This list was generated using validate-committer-lists from
1528         https://bugs.webkit.org/show_bug.cgi?id=30970
1529         and makes committers.py current for committers who have
1530         committed in the last 3 years.
1531
1532         * Scripts/modules/committers.py:
1533
1534 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1535
1536         Reviewed by Adam Barth.
1537
1538         The document-open.html test was flaky at times. The test invokes the layout test plugin
1539         which in its destroy stream handler opens a new document. This basically tears down the
1540         stream and the associated plugin instance. The pluginLog function in the layout test
1541         plugin attempts to retrieve the window script object on a torn down plugin instance
1542         which crashed consistently on windows in the debugger. The functions which issue
1543         these logs already have a valid window script object. We now have variants of the pluginLog
1544         function which take in a window script object with and without variable arguments. 
1545
1546         https://bugs.webkit.org/show_bug.cgi?id=31067
1547
1548         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1549         (pluginLogWithWindowObject):
1550         (pluginLogWithWindowObjectVariableArgs):
1551         (pluginLog):
1552         (notifyTestCompletion):
1553         (testDocumentOpen):
1554         (testWindowOpen):
1555
1556 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1557
1558         Reviewed by Gustavo Noronha Silva.
1559
1560         https://bugs.webkit.org/show_bug.cgi?id=30997
1561         [Gtk] Implemment AtkDocument
1562
1563         Added testing support.
1564
1565         * DumpRenderTree/AccessibilityUIElement.cpp:
1566         * DumpRenderTree/AccessibilityUIElement.h:
1567         (getDocumentEncodingCallback):
1568         (getDocumentURICallback):
1569         (AccessibilityUIElement::getJSClass):
1570         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1571         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1572         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1573         (AccessibilityUIElement::documentEncoding):
1574         (AccessibilityUIElement::documentURI):
1575
1576 2009-11-12  Adam Roben  <aroben@apple.com>
1577
1578         Replace worldIDs with world objects
1579
1580         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1581         user scripts/stylesheets and isolated worlds
1582
1583         Reviewed by Sam Weinig.
1584
1585         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1586         (LayoutTestController::addUserScript):
1587         (LayoutTestController::addUserStyleSheet):
1588         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1589         (LayoutTestController::addUserScript):
1590         (LayoutTestController::addUserStyleSheet):
1591         Changed these functions to create a new WebJSWorld each time they're
1592         called and to pass that world to WebKit.
1593
1594 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1595
1596         Reviewed by Oliver Hunt.
1597
1598         need to implement aria tree roles
1599         https://bugs.webkit.org/show_bug.cgi?id=31284
1600
1601         * DumpRenderTree/AccessibilityUIElement.cpp:
1602         (disclosedRowAtIndexCallback):
1603         (selectedRowAtIndexCallback):
1604         (isEqualCallback):
1605         (isAttributeSettableCallback):
1606         (isActionSupportedCallback):
1607         (disclosedByRowCallback):
1608         (hierarchicalLevelCallback):
1609         (AccessibilityUIElement::getJSClass):
1610         * DumpRenderTree/AccessibilityUIElement.h:
1611         (AccessibilityUIElement::isEqual):
1612         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1613         (AccessibilityUIElement::hierarchicalLevel):
1614         (AccessibilityUIElement::disclosedRowAtIndex):
1615         (AccessibilityUIElement::selectedRowAtIndex):
1616         (AccessibilityUIElement::disclosedByRow):
1617         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1618         (AccessibilityUIElement::getChildAtIndex):
1619         (AccessibilityUIElement::disclosedRowAtIndex):
1620         (AccessibilityUIElement::selectedRowAtIndex):
1621         (AccessibilityUIElement::titleUIElement):
1622         (AccessibilityUIElement::parentElement):
1623         (AccessibilityUIElement::disclosedByRow):
1624         (AccessibilityUIElement::hierarchicalLevel):
1625         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1626         (AccessibilityUIElement::hierarchicalLevel):
1627         (AccessibilityUIElement::disclosedRowAtIndex):
1628         (AccessibilityUIElement::selectedRowAtIndex):
1629         (AccessibilityUIElement::disclosedByRow):
1630
1631 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1632
1633         Reviewed by Darin Adler.
1634
1635         svn-apply can not handle git binary diffs
1636         https://bugs.webkit.org/show_bug.cgi?id=26830
1637
1638         Support "literal" type git binary diffs.
1639
1640         * Scripts/VCSUtils.pm:
1641         * Scripts/modules/scm_unittest.py:
1642         * Scripts/svn-apply:
1643
1644 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1645
1646         Not reviewed, removing duplicate entry for myself in committers.py.
1647
1648         * Scripts/modules/committers.py:
1649
1650 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1651
1652         Reviewed by Darin Adler and Mark Rowe.
1653
1654         https://bugs.webkit.org/show_bug.cgi?id=31200
1655         Tests in http/tests/security/mixedContent start to fail when new tests are added
1656
1657         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1658
1659 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1660
1661         Reviewed by Jan Alonzo.
1662
1663         Create, and display a window for the inspector, for inspector
1664         tests.
1665
1666         Need to also show/hide the inspector window to avoid having
1667         problems with code assuming it is realized
1668         https://bugs.webkit.org/show_bug.cgi?id=31347
1669
1670         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1671         (webInspectorShowWindow):
1672         (webInspectorCloseWindow):
1673         (webInspectorInspectWebView):
1674         (createWebView):
1675
1676 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1677
1678         Unreviewed Qt buildbot fix.
1679
1680         My previous fix was wrong, so revert that change and fix it by
1681         returning when the document of the frame has no document element.
1682         Idea is borrowed from mac and win DRT.
1683
1684         * DumpRenderTree/qt/DumpRenderTree.cpp:
1685         (WebCore::DumpRenderTree::dumpFramesAsText):
1686
1687 2009-11-11  Eric Seidel  <eric@webkit.org>
1688
1689         Reviewed byg Kenneth Rohde Christiansen.
1690
1691         Update Kenneth's committer record to include the email he
1692         uses on lists.webkit.org.
1693
1694         * Scripts/modules/committers.py:
1695
1696 2009-11-11  Eric Seidel  <eric@webkit.org>
1697
1698         Reviewed by Gustavo Noronha Silva.
1699
1700         Several committers use separate email addresses for bugzilla and svn.webkit.org
1701         https://bugs.webkit.org/show_bug.cgi?id=31364
1702
1703         Update records for existing committers to include email addresses
1704         used in svn.webkit.org and lists.webkit.org.
1705         Most committers use the same email address in all 3 places, but some use
1706         separate addresses.  committers.py needs record of each of these addresses.
1707
1708         * Scripts/modules/committers.py:
1709
1710 2009-11-11  Eric Seidel  <eric@webkit.org>
1711
1712         No review, adding second email address for an existing committer.
1713
1714         Add Yong Li's second bugzilla account to his committer record.
1715         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1716
1717         * Scripts/modules/committers.py:
1718
1719 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1720
1721         Reviewed by Simon Hausmann.
1722
1723         If the frame has no innerText don't append it, and
1724         do not add a newline which breaks some cross platform
1725         results.
1726
1727         * DumpRenderTree/qt/DumpRenderTree.cpp:
1728         (WebCore::DumpRenderTree::dumpFramesAsText):
1729
1730 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1731
1732         Reviewed by Simon Hausmann.
1733
1734         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1735
1736         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1737         (webkit_test_plugin_new_instance):
1738         (webkit_test_plugin_destroy_instance):
1739         (webkit_test_plugin_destroy_stream):
1740
1741 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1742
1743         Reviewed by Mark Rowe.
1744
1745         Implement the functionality needed by plugins/window-open.html
1746
1747         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1748         (webkit_test_plugin_new_instance):
1749         (webkit_test_plugin_set_window):
1750
1751 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1752
1753         Reviewed by Simon Hausmann.
1754
1755         [Qt] Force -graphicssystem raster and -style windows when running DRT
1756
1757         * DumpRenderTree/qt/main.cpp:
1758         * Scripts/run-webkit-tests:
1759
1760 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1761
1762         Reviewed by Simon Hausmann.
1763
1764         Compute correct library paths for Qt
1765
1766         * Scripts/webkitdirs.pm:
1767
1768 2009-11-10  Mark Rowe  <mrowe@apple.com>
1769
1770         Reviewed by Sam Weinig.
1771
1772         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1773
1774         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1775         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1776         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1777         that had enabled frame load delegate logging this would result in extra log messages being generated,
1778         causing the test to fail.
1779
1780         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1781         tests.
1782
1783         * DumpRenderTree/mac/DumpRenderTree.mm:
1784         (dumpRenderTree):
1785         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1786         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1787
1788 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1789
1790         Reviewed by Kenneth Rohde Christiansen.
1791
1792         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1793
1794         * DumpRenderTree/qt/DumpRenderTree.cpp:
1795         (WebCore::DumpRenderTree::DumpRenderTree):
1796
1797 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1798
1799         Reviewed by Jan Alonzo.
1800
1801         [GTK] Remove WebSocket configuration from WebKitWebSettings
1802         https://bugs.webkit.org/show_bug.cgi?id=31244
1803
1804         Follow-up of r50724. Don't set the enable-web-socket property
1805         anymore.
1806
1807         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1808         (resetDefaultsToConsistentValues):
1809
1810 2009-11-10  Oliver Hunt  <oliver@apple.com>
1811
1812         Reviewed by Maciej Stachowiak.
1813
1814         Rename 3D Canvas related classes to use WebGL prefix
1815         https://bugs.webkit.org/show_bug.cgi?id=29095
1816
1817         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1818         and upate webkitdirs script to new method of testing for WebGL.
1819
1820         * Scripts/do-webcore-rename:
1821         * Scripts/webkitdirs.pm:
1822
1823 2009-11-09  Oliver Hunt  <oliver@apple.com>
1824
1825         Reviewed by Geoff Garen.
1826
1827         Make do-webcore-rename work with git.
1828
1829         * Scripts/do-webcore-rename:
1830
1831 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1832
1833         Adding Kenneth to the reviewers list.
1834
1835         * Scripts/modules/committers.py:
1836
1837 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1838
1839         Reviewed by Jan Alonzo.
1840
1841         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1842         https://bugs.webkit.org/show_bug.cgi?id=30482
1843
1844         LayoutTestControllerGtk now uses the exposed
1845         Page::tabKeyCyclesThroughElements API
1846
1847         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1848         (LayoutTestController::setTabKeyCyclesThroughElements):
1849
1850 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1851
1852         Reviewed by Holger Freyther.
1853
1854         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1855         This helps to pass the test case below. Also replaced hardcoded
1856         code numbers with defined constants.
1857         https://bugs.webkit.org/show_bug.cgi?id=31185
1858         
1859         Test: editing/undo/undo-deleteWord.html
1860
1861         * DumpRenderTree/qt/EventSenderQt.cpp:
1862         (EventSender::keyDown):
1863
1864 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1865
1866         Reviewed by Holger Freyther.
1867
1868         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1869         https://bugs.webkit.org/show_bug.cgi?id=31164
1870
1871         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1872
1873         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1874         (LayoutTestController::processWork):
1875
1876 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1877
1878         Reviewed by Holger Freyther.
1879
1880         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1881         https://bugs.webkit.org/show_bug.cgi?id=31158
1882
1883         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1884         always, which from WorkQueue prospective means that a load has been started
1885         and the queue processing should stop and wait for the load to finish.
1886         Spinning it off into a loading and a non-loading variants was the solution
1887         adopted by Mac's DRT to work around this problem. The former keeps returning
1888         'true' while the later executes the script synchronously and returns 'false'
1889         making it possible to the WorkQueue to proceed right away.
1890
1891         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1892         (LayoutTestController::processWork):
1893         (LayoutTestController::queueLoadingScript):
1894         (LayoutTestController::queueNonLoadingScript):
1895         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1896         * DumpRenderTree/qt/WorkQueueItem.h:
1897         (LoadingScriptItem::LoadingScriptItem):
1898         (LoadingScriptItem::invoke):
1899         (NonLoadingScriptItem::NonLoadingScriptItem):
1900         (NonLoadingScriptItem::invoke):
1901
1902 2009-11-07  Mark Rowe  <mrowe@apple.com>
1903
1904         Rubber-stamped by Cameron Zwarich.
1905
1906         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1907
1908         * Scripts/commit-log-editor:
1909
1910 2009-11-07  Mark Rowe  <mrowe@apple.com>
1911
1912         Reviewed by Darin Adler.
1913
1914         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1915         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1916
1917         Move logic for determining the name and email address to use in a ChangeLog entry from
1918         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1919         whether the author of the patch matches committer, and therefore needs access to the
1920         email address that would be used in a ChangeLog entry.
1921
1922         Based on a patch by Pierre d'Herbemont.
1923
1924         * Scripts/VCSUtils.pm:
1925         * Scripts/commit-log-editor:
1926         * Scripts/prepare-ChangeLog:
1927         * Scripts/webkitdirs.pm:
1928
1929 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1930
1931         Reviewed by Adam Barth.
1932
1933         Added functionality to the layout test plugin to invoke document.open and
1934         window.open with default arguments. The associated webkit bug is
1935         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1936         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1937         work in Chromium (V8) if there is no calling javascript context. To achieve this
1938         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1939         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1940
1941         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1942         (testDocumentOpen):
1943         (testWindowOpen):
1944         (pluginAllocate):
1945         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1946         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1947         (NPP_New):
1948         (NPP_SetWindow):
1949         (NPP_DestroyStream):
1950         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1951         (NPP_New):
1952         (NPP_SetWindow):
1953         (NPP_NewStream):
1954         (NPP_DestroyStream):
1955
1956 2009-11-06  Eric Seidel  <eric@webkit.org>
1957
1958         Reviewed by Adam Barth.
1959
1960         bugzilla-tool crashed with exception
1961         https://bugs.webkit.org/show_bug.cgi?id=31092
1962
1963         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1964
1965 2009-11-04  Eric Seidel  <eric@webkit.org>
1966
1967         No review, just add a line which got left out of the patch uploaded for commit.
1968
1969         commit-queue is crashing when trying to reject patches after unknown failures
1970         https://bugs.webkit.org/show_bug.cgi?id=31091
1971
1972         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1973
1974 2009-11-04  Adam Roben  <aroben@apple.com>
1975
1976         Remove bogus else clause in bugzilla-tool
1977
1978         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1979         create-bug raises exception after entering bug description
1980
1981         Reviewed by David Kilzer.
1982
1983         * Scripts/bugzilla-tool:
1984         (CreateBug): else clauses are only hit if no exception is raised, so
1985         it makes no sense to try to re-raise the exception in an else clause.
1986         The exception will automatically be re-raised if it doesn't match any
1987         of the except clauses, so we don't have to do anything special here at
1988         all to get the desired behavior.
1989
1990 2009-11-04  Eric Seidel  <eric@webkit.org>
1991
1992         Reviewed by David Kilzer.
1993
1994         svn-apply's fixChangeLogPatch function seems broken
1995         https://bugs.webkit.org/show_bug.cgi?id=30683
1996
1997         Update fixChangeLogPatch to be able to handle patches which
1998         don't start at line 1.
1999         Add unit tests for svn-apply to scm_unittest.py.
2000
2001         * Scripts/VCSUtils.pm:
2002         * Scripts/modules/scm_unittest.py:
2003
2004 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2005
2006         Reviewed by Beth Dakin.
2007
2008         Need to implement ARIA role="combobox"
2009         https://bugs.webkit.org/show_bug.cgi?id=31096
2010
2011         * DumpRenderTree/AccessibilityUIElement.cpp:
2012         (showMenuCallback):
2013         (getIsExpandedCallback):
2014         (AccessibilityUIElement::getJSClass):
2015         * DumpRenderTree/AccessibilityUIElement.h:
2016         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2017         (AccessibilityUIElement::isExpanded):
2018         (AccessibilityUIElement::showMenu):
2019         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2020         (AccessibilityUIElement::isExpanded):
2021         (AccessibilityUIElement::showMenu):
2022         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2023         (AccessibilityUIElement::isSelected):
2024         (AccessibilityUIElement::isExpanded):
2025         (AccessibilityUIElement::showMenu):
2026
2027 2009-11-04  Eric Seidel  <eric@webkit.org>
2028
2029         Reviewed by Adam Barth.
2030
2031         commit-queue is crashing when trying to reject patches after unknown failures
2032         https://bugs.webkit.org/show_bug.cgi?id=31091
2033
2034         * Scripts/bugzilla-tool:
2035          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2036            so we have to find out what the current patch is by asking bugzilla again.
2037          - Discovered that this code was also leaking file descriptors, so fixed that.
2038
2039 2009-11-04  Adam Roben  <aroben@apple.com>
2040
2041         Make run-webkit-tests work for the Debug_Internal Windows
2042         configuration
2043
2044         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2045         suffix.
2046
2047         Fixes <http://webkit.org/b/31123>.
2048
2049         Reviewed by Sam Weinig.
2050
2051         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2052         Debug_Internal, either.
2053
2054 2009-11-04  Eric Seidel  <eric@webkit.org>
2055
2056         Reviewed by Adam Barth.
2057
2058         committers.py needs a way to store non-bugzilla email addresses
2059         https://bugs.webkit.org/show_bug.cgi?id=31037
2060
2061         Make Committer and Reviewer constructors take a single email or a list of emails.
2062         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2063         Expose reviewers(), used by validate-committer-lists on bug 30970.
2064
2065         * Scripts/modules/committers.py:
2066         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2067
2068 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2069
2070         Reviewed by David Levin.
2071
2072         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2073         https://bugs.webkit.org/show_bug.cgi?id=27491
2074
2075         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2076         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2077
2078         Functions to start or stop Web Socket servers are added.
2079
2080         * Scripts/run-webkit-tests:
2081
2082 2009-11-03  Eric Seidel  <eric@webkit.org>
2083
2084         No review, just changing wording of log message.
2085
2086         Change log string to say "failed" instead of "rejected"
2087         when a commit fails due to an out of date checkout.
2088         This makes grepping the commit-queue log for rejected patches easier.
2089
2090         * Scripts/bugzilla-tool:
2091
2092 2009-11-03  Eric Seidel  <eric@webkit.org>
2093
2094         No review, adding commonly known committers missing from the file.
2095
2096         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2097
2098 2009-11-03  Eric Seidel  <eric@webkit.org>
2099
2100         No review, just sort-order cleanup.
2101
2102         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2103
2104 2009-11-03  Stephen White  <senorblanco@chromium.org>
2105
2106         (Unreviewed).
2107
2108         Add myself to committers.py.
2109
2110         * Scripts/modules/committers.py:
2111
2112 2009-11-03  Robin Dunn  <robin@alldunn.com>
2113
2114         Reviewed by Kevin Ollviier.
2115
2116         Add packaging scripts for Debian-based Linux distros.
2117         
2118         https://bugs.webkit.org/show_bug.cgi?id=31075
2119
2120         * wx/packaging/build-debian-installer.py: Added.
2121         * wx/packaging/debian: Added.
2122
2123 2009-11-03  Dan Bernstein  <mitz@apple.com>
2124
2125         Reviewed by Anders Carlsson and Beth Dakin.
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=31070
2128
2129         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2130         destroyed, it executes the value of the 'ondestroy' parameter as a
2131         script.
2132
2133         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2134         (pluginAllocate): Initialize onDestroy.
2135         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2136         onDestroy.
2137         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2138         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2139         specified.
2140         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2141
2142 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2143
2144         Reviewed by Xan Lopez.
2145
2146         https://bugs.webkit.org/show_bug.cgi?id=31035
2147         [GTK] some accessibility tests hitting assertion in debug builds
2148
2149         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2150
2151         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2152         (AccessibilityController::rootElement):
2153
2154 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2155
2156         Reviewed by Beth Dakin.
2157
2158         Support ARIA "tab" roles
2159         https://bugs.webkit.org/show_bug.cgi?id=30842
2160
2161         * DumpRenderTree/AccessibilityUIElement.cpp:
2162         * DumpRenderTree/AccessibilityUIElement.h:
2163         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2164         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2165         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2166
2167 2009-11-01  Eric Seidel  <eric@webkit.org>
2168
2169         Reviewed by David Levin.
2170
2171         buildbots should use --exit-after-N-failures
2172         https://bugs.webkit.org/show_bug.cgi?id=30809
2173
2174         Make the bots exit after 20 failures to prevent never-ending
2175         test runs where every test spends a minute crashing.
2176
2177         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2178
2179 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2180
2181         Reviewed by Eric Seidel.
2182
2183         Turn on warnings for QtWebKit for gcc
2184         https://bugs.webkit.org/show_bug.cgi?id=30958
2185
2186         * DumpRenderTree/qt/main.cpp: 
2187         (crashHandler): Mark function NO_RETURN
2188
2189 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2190
2191         Adding myself to the committers list.
2192
2193         * Scripts/modules/committers.py:
2194
2195 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2196
2197         Fix an issue that Adam noticed in DRT.
2198
2199         Reviewed by Darin Adler.
2200
2201         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2202         (AccessibilityUIElement::role):
2203         Get the length of the role text, and create a buffer dynamically.
2204
2205 2009-10-30  Eric Seidel  <eric@webkit.org>
2206
2207         No review, rolling out r50105.
2208         http://trac.webkit.org/changeset/50105
2209
2210         This commit was causing:
2211         https://bugs.webkit.org/show_bug.cgi?id=30869
2212         We'll re-implement the feature a different way.
2213
2214         * Scripts/bugzilla-tool:
2215
2216 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2217
2218         Test for MSAA: Accessibility of headings is not correct
2219
2220         https://bugs.webkit.org/show_bug.cgi?id=30937
2221
2222         Reviewed by Adam Roben.
2223
2224         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2225         (AccessibilityUIElement::role):
2226         Allow the role returned to be a BSTR.
2227         (AccessibilityUIElement::description):
2228         Fix a copy/paste error.
2229
2230 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2231
2232         Test for MSAA: Accessibility of links is wrong
2233
2234         https://bugs.webkit.org/show_bug.cgi?id=30928
2235
2236         Reviewed by Darin Adler.
2237
2238         * DumpRenderTree/AccessibilityUIElement.cpp:
2239         (getAccessibilityValueCallback):
2240         Return the accessibility value.
2241         (AccessibilityUIElement::getJSClass):
2242         Added "accessibilityValue" value.
2243
2244         * DumpRenderTree/AccessibilityUIElement.h:
2245
2246         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2247         (AccessibilityUIElement::accessibilityValue):
2248         Stubbed.
2249
2250         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2251         (AccessibilityUIElement::accessibilityValue):
2252         Stubbed.
2253
2254         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2255         (AccessibilityUIElement::accessibilityValue):
2256         Get the object's value, and return it as a JS string.
2257
2258 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2259
2260         Fix typo in command name used by wx build system.
2261
2262         * wx/build/build_utils.py:
2263
2264 2009-10-30  Adam Barth  <abarth@webkit.org>
2265
2266         Reviewed by Darin Adler.
2267
2268         Patch v1 is a dumb default name for patches
2269         https://bugs.webkit.org/show_bug.cgi?id=30952
2270
2271         Let's use "Patch" instead.
2272
2273         * Scripts/bugzilla-tool:
2274
2275 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2276
2277         Unreviewed trivial buildfix.
2278
2279         [Qt] Buildfix for r50333.
2280
2281         * DumpRenderTree/qt/DumpRenderTree.pro:
2282
2283 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2284
2285         Reviewed by Holger Freyther.
2286
2287         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2288         https://bugs.webkit.org/show_bug.cgi?id=30953
2289
2290         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2291         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2292         makes qt DRT to share this implementation (as gtk and mac ports do).
2293
2294         * DumpRenderTree/qt/DumpRenderTree.pro:
2295         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2296         * DumpRenderTree/qt/WorkQueue.h: Removed.
2297
2298 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2299
2300         Unreviewed potential buildbot fix.
2301
2302         Second try: Reset page history before running each test.
2303
2304         Apparently the QWebHistory::clear() keeps the current page
2305         in history which is not what we want, so we not additionally
2306         sets the history capacity to 0 (forces removing everything)
2307         and then sets it back to its original value.
2308
2309         * DumpRenderTree/qt/DumpRenderTree.cpp:
2310         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2311
2312 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2313
2314         Unreviewed potential buildbot fix.
2315
2316         Reset page history before running each test.
2317
2318         * DumpRenderTree/qt/DumpRenderTree.cpp:
2319         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2320
2321 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2322
2323         Reviewed by Eric Seidel.
2324
2325         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2326
2327         Bug 28420 -  Implement HTML5 <ruby> rendering
2328         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2329
2330         No new tests (no functional change).
2331
2332         * Scripts/build-webkit:
2333
2334 2009-10-29  Dan Bernstein  <mitz@apple.com>
2335
2336         Reviewed by Mark Rowe.
2337
2338         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2339         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2340         define it.
2341
2342         * Scripts/VCSUtils.pm:
2343         * Scripts/svn-apply:
2344         * Scripts/svn-unapply:
2345
2346 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2347
2348         Reviewed by Gustavo Noronha.
2349
2350         Use the GTK+ main loop instead of rolling our own mini-version of
2351         it.
2352
2353         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2354         (dump):
2355         (runTest):
2356         (webViewLoadFinished):
2357
2358 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2359
2360         Reviewed by Oliver Hunt.
2361
2362         Implement the Qt version of DRT dumpBackForwardList().
2363
2364         * DumpRenderTree/qt/DumpRenderTree.cpp:
2365         (WebCore::dumpHistoryItem):
2366         (WebCore::DumpRenderTree::dumpBackForwardList):
2367
2368 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2369
2370         Reviewed by Adam Roben.
2371
2372         Implement DRT functionality for Qt introduced in
2373         r28690 and r28705.
2374
2375         - Implemented pathToLocalResource which exposes the functionality of
2376         converting a given unix path to the correct location on Windows.
2377         - Implemented a way to remove machine-dependent information from paths
2378         in layout test results.
2379
2380         * DumpRenderTree/qt/DumpRenderTree.cpp:
2381         (WebCore::urlSuitableForTestResult):
2382         (WebCore::WebPage::javaScriptConsoleMessage):
2383         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2384         (LayoutTestController::pathToLocalResource):
2385         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2386
2387 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2388
2389         Adding myself to the committers list.
2390
2391         * Scripts/modules/committers.py:
2392
2393 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2394
2395         Adding myself to the committers list.
2396
2397         * Scripts/modules/committers.py:
2398
2399 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2400
2401         Reviewed by Jan Alonzo.
2402
2403         [GTK] API to start inspector for a WebView
2404         https://bugs.webkit.org/show_bug.cgi?id=22551
2405
2406         Use the new inspector API to implement the LayoutTestController
2407         interfaces used to test the inspector.
2408
2409         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2410         (webInspectorInspectWebView):
2411         (createWebView):
2412         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2413         (LayoutTestController::showWebInspector):
2414         (LayoutTestController::closeWebInspector):
2415         (LayoutTestController::evaluateInWebInspector):
2416
2417 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2418
2419         Reviewed by Eric Seidel.
2420
2421         [Qt] WebFrame::counterValueForElementById must not be exposed
2422         https://bugs.webkit.org/show_bug.cgi?id=30882
2423
2424         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2425         (LayoutTestController::counterValueForElementById):
2426
2427 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2428
2429         Rubberstamped by Oliver Hunt.
2430
2431         Fix the warning:
2432
2433         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2434         declared with attribute warn_unused_result".
2435
2436         by actually checking the result. In the case it is null, an
2437         error has occoured, so treat it as the other fatal errors.
2438
2439         * DumpRenderTree/qt/DumpRenderTree.cpp:
2440         (WebCore::DumpRenderTree::initializeFonts):
2441
2442 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2443
2444         Reviewed by Darin Adler.
2445
2446         Provide a way to get counter values with layoutTestContoller
2447         https://bugs.webkit.org/show_bug.cgi?id=30555
2448
2449         Define layoutTestContoller.counterValueForElementById.
2450
2451         * DumpRenderTree/LayoutTestController.cpp:
2452         (counterValueForElementByIdCallback):
2453         (LayoutTestController::staticFunctions):
2454         * DumpRenderTree/LayoutTestController.h:
2455         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2456         (LayoutTestController::counterValueForElementById):
2457
2458 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2459
2460         Rubberstamped by Oliver Hunt.
2461
2462         Change two methods to be internal for DRT use only.
2463
2464         Part of [Qt] Review all new API in Qt 4.6
2465         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2466
2467         * DumpRenderTree/qt/DumpRenderTree.cpp:
2468         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2469         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2470         (LayoutTestController::whiteListAccessFromOrigin):
2471
2472 2009-10-27  Eric Seidel  <eric@webkit.org>
2473
2474         Reviewed by Adam Barth.
2475
2476         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2477         https://bugs.webkit.org/show_bug.cgi?id=30826
2478
2479         * Scripts/svn-apply:
2480          - Add () around all system() calls.
2481          - Use the correct system() == 0 or die instead of system() or die
2482          - Add descriptive messages to all die statements.
2483
2484 2009-10-27  Steve Block  <steveblock@google.com>
2485
2486         Reviewed by NOBODY.
2487
2488         Adds steveblock@google.com to list of committers.
2489
2490         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2491
2492 2009-10-27  Eric Seidel  <eric@webkit.org>
2493
2494         Reviewed by Adam Barth.
2495
2496         svn-apply can exit(0) even on patch failure
2497         https://bugs.webkit.org/show_bug.cgi?id=29622
2498
2499         * Scripts/svn-apply:
2500          - Add a bunch of "or die" statements, hopefully catching all
2501            possible cases where failure could still exit(0).
2502
2503 2009-10-27  Eric Seidel  <eric@webkit.org>
2504
2505         Reviewed by Adam Barth.
2506
2507         svn-* scripts should share code through VCSUtils.pm
2508         https://bugs.webkit.org/show_bug.cgi?id=30791
2509
2510         Just moving code into a shared location.
2511
2512         * Scripts/VCSUtils.pm:
2513         * Scripts/prepare-ChangeLog:
2514         * Scripts/resolve-ChangeLogs:
2515         * Scripts/svn-apply:
2516         * Scripts/svn-create-patch:
2517         * Scripts/svn-unapply:
2518         * Scripts/update-webkit:
2519
2520 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2521
2522         Suppress a huge number of MSVC warnings when building wxWebKit.
2523
2524         * wx/build/settings.py:
2525
2526 2009-10-26  Eric Seidel  <eric@webkit.org>
2527
2528         No review, just adding Mike Belshe to the committers list.
2529
2530         * Scripts/modules/committers.py:
2531
2532 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2533
2534         Reviewed by Darin Adler.
2535
2536         Make .rc files compile on Windows without depending on MFC headers
2537         https://bugs.webkit.org/show_bug.cgi?id=30750
2538
2539         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2540         windows.h instead of afxres.h because it exists even when MFC is not 
2541         installed, and is all that's needed here.
2542
2543         * FindSafari/FindSafari.rc: Ditto
2544
2545 2009-10-24  Eric Seidel  <eric@webkit.org>
2546
2547         Reviewed by Adam Barth.
2548
2549         bugzilla-tool post-diff should know how to mark commit-queue=?
2550         https://bugs.webkit.org/show_bug.cgi?id=29202
2551
2552         * Scripts/bugzilla-tool:
2553          - Add --commit-queue option to post-diff, post-commits and create-bug.
2554         * Scripts/modules/bugzilla.py:
2555          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2556          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2557
2558 2009-10-23  Eric Seidel  <eric@webkit.org>
2559
2560         Reviewed by Adam Barth.
2561
2562         bugzilla-tool commit-queue does not notice modifications to committers.py
2563         https://bugs.webkit.org/show_bug.cgi?id=30084
2564
2565         * Scripts/bugzilla-tool:
2566          - Make commit-queue re-exec itself instead of using while(1).
2567          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2568          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2569
2570 2009-10-22  Eric Seidel  <eric@webkit.org>
2571
2572         Reviewed by Adam Barth.
2573
2574         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2575         https://bugs.webkit.org/show_bug.cgi?id=30634
2576
2577         * Scripts/bugzilla-tool:
2578          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2579          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2580
2581 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2582
2583         Reviewed by Eric Seidel.
2584
2585         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2586
2587         https://bugs.webkit.org/show_bug.cgi?id=30763
2588
2589         * pywebsocket/mod_pywebsocket/__init__.py:
2590         * pywebsocket/mod_pywebsocket/dispatch.py:
2591         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2592         * pywebsocket/mod_pywebsocket/standalone.py:
2593         * pywebsocket/setup.py:
2594         * pywebsocket/test/test_dispatch.py:
2595
2596 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2597
2598         Reviewed by David Levin.
2599
2600         REGRESSION: 2 failures in run-webkit-unittests
2601         https://bugs.webkit.org/show_bug.cgi?id=30645
2602
2603         * Scripts/modules/cpp_style_unittest.py:
2604         Fixed a few test scenarios which apparently lost some spaces from 
2605         text literals.
2606
2607 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2608
2609         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2610
2611         * Scripts/webkitdirs.pm:
2612
2613 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2614
2615         Reviewed by Darin Adler.
2616
2617         Unification of using null device in perl scripts.
2618         https://bugs.webkit.org/show_bug.cgi?id=30572
2619
2620         * Scripts/VCSUtils.pm:
2621         * Scripts/bisect-builds:
2622         * Scripts/resolve-ChangeLogs:
2623         * Scripts/run-iexploder-tests:
2624         * Scripts/run-jsc:
2625         * Scripts/run-mangleme-tests:
2626         * Scripts/run-webkit-tests:
2627         * Scripts/webkitdirs.pm:
2628         Using File::Spec->devnull() instead of hard coded /dev/null.
2629
2630 2009-10-26  Eric Seidel  <eric@webkit.org>
2631
2632         Reviewed by Holger Freyther.
2633
2634         Reviewers are missing from committers.py
2635         https://bugs.webkit.org/show_bug.cgi?id=30733
2636
2637         * Scripts/modules/committers.py:
2638
2639 2009-10-23  Eric Seidel  <eric@webkit.org>
2640
2641         No review, only adding Alice to the list of reviewers.
2642
2643         * Scripts/modules/committers.py:
2644
2645 2009-10-23  Eric Seidel  <eric@webkit.org>
2646
2647         Reviewed by Eric Carlson.
2648
2649         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2650         https://bugs.webkit.org/show_bug.cgi?id=30700
2651
2652         * DumpRenderTree/mac/DumpRenderTree.mm:
2653         (resetDefaultsToConsistentValues): Update QuickTime version check.
2654
2655 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2656
2657         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2658         character measurement APIs that are private on Tiger.
2659
2660         * wx/build/settings.py:
2661
2662 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2663
2664         Reviewed by NOBODY (build fix).
2665         Build fix following bug #30696.
2666
2667         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2668         (LayoutTestController::evaluateScriptInIsolatedWorld):
2669
2670 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2671
2672         Reviewed by Sam Weinig & Geoff Garen.
2673
2674         https://bugs.webkit.org/show_bug.cgi?id=30696
2675         Enable isolated-worlds tests on mac.
2676
2677         Add private interface for DRT to invoke execution in a given world.
2678
2679         * DumpRenderTree/LayoutTestController.cpp:
2680         (evaluateScriptInIsolatedWorldCallback):
2681         (LayoutTestController::staticFunctions):
2682         * DumpRenderTree/LayoutTestController.h:
2683         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2684         (LayoutTestController::evaluateScriptInIsolatedWorld):
2685         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2686         (LayoutTestController::evaluateScriptInIsolatedWorld):
2687
2688 2009-10-21  Eric Seidel  <eric@webkit.org>
2689
2690         Reviewed by Adam Barth.
2691
2692         bugzilla-tool's "patch failed to download an apply" error should give more information
2693         https://bugs.webkit.org/show_bug.cgi?id=30632
2694
2695         * Scripts/modules/scm.py:
2696          - Use the common run_command method instead of custom POpen code.
2697          - Make run_command know how to take pipes as input.
2698         * Scripts/modules/scm_unittest.py:
2699          - Add new tests to cover change.
2700          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2701
2702 2009-10-21  Kent Tamura  <tkent@chromium.org>
2703
2704         Unreviewed.  Adding myself to the committers list.
2705
2706         * Scripts/modules/committers.py:
2707
2708 2009-10-21  Robin Dunn  <robin@alldunn.com>
2709
2710         Reviewed by Kevin Ollivier.
2711
2712         Update the Windows installer builder to work with Vista / Win 7 and with git.
2713         
2714         https://bugs.webkit.org/show_bug.cgi?id=30649
2715
2716         * wx/build/build_utils.py:
2717         * wx/packaging/build-mac-installer.py:
2718         * wx/packaging/build-win-installer.py:
2719         * wx/packaging/wxWebKitInstaller.iss.in:
2720
2721 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2722
2723         Reviewed by Gustavo Noronha.
2724
2725         [GTK] Added conditional code to avoid using
2726         gdk_window_get_root_coords if we do not have a gtk+ release newer
2727         than 2.17.3.
2728         https://bugs.webkit.org/show_bug.cgi?id=30636
2729
2730         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2731
2732 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2733
2734         Reviewed by Eric Seidel.
2735
2736         [Qt] Added dummy implementation for keepWebHistory()
2737         https://bugs.webkit.org/show_bug.cgi?id=30592
2738
2739         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2740         (LayoutTestController::keepWebHistory):
2741         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2742
2743 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2744
2745         Reviewed by Xan Lopez.
2746
2747         [GTK] Fixed the double click condition, it is not double click if
2748         we move in just in one direction.
2749         https://bugs.webkit.org/show_bug.cgi?id=30636
2750
2751         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2752
2753 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2754
2755         Reviewed by Xan Lopez.
2756
2757         [GTK] Initialize the events completly before emitting them.
2758         https://bugs.webkit.org/show_bug.cgi?id=30633
2759
2760         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2761
2762 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2763
2764         wx build fix. Fix for when linking using --as-needed with gcc.
2765
2766         * wx/browser/wscript:
2767
2768 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2769
2770         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2771         to support all the features used by CURL backend.
2772         
2773         * wx/build/settings.py:
2774         * wx/install-unix-extras:
2775
2776 2009-10-20  Anton Muhin  <antonm@chromium.org>
2777
2778         Reviewed by Adam Barth.
2779
2780         Add {ager,antonm,yurys}@chromium.org into committers.py
2781         https://bugs.webkit.org/show_bug.cgi?id=30560
2782
2783         * Scripts/modules/committers.py:
2784
2785 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2786
2787         Reviewed by Tor Arne Vestbø.
2788
2789         Make the Netscape Test plugin available to the Qt launcher.
2790
2791         * Scripts/run-launcher:
2792
2793 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2794
2795         Reviewed by David Levin.
2796
2797         Removed WebSocket runtime settings.
2798         https://bugs.webkit.org/show_bug.cgi?id=29896
2799
2800         WebSocket runtime configuration is supported by chromium/v8 only.
2801
2802         * DumpRenderTree/mac/DumpRenderTree.mm:
2803         (resetDefaultsToConsistentValues):
2804         * DumpRenderTree/win/DumpRenderTree.cpp:
2805         (resetDefaultsToConsistentValues):
2806
2807 2009-10-19  Nate Chapin  <japhet@chromium.org>
2808
2809         Reviewed by Adam Barth.
2810
2811         Add testFail() to test plugin so we can test our handling of a
2812         plugin invoke call returning false.
2813
2814         https://bugs.webkit.org/show_bug.cgi?id=30239
2815
2816         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2817         (pluginInvoke):
2818         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2819
2820 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2821
2822         Reviewed by Gustavo Noronha.
2823
2824         Enable DOM pasting when running layout tests.
2825
2826         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2827         (resetDefaultsToConsistentValues):
2828
2829 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2830
2831         Reviewed by Simon Hausmann.
2832
2833         Use the setPreferredContentsSize method instead
2834         of setFixedContentsSize, as the method has been renamed.
2835
2836         * DumpRenderTree/qt/DumpRenderTree.cpp:
2837         (WebCore::DumpRenderTree::open):
2838         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2839         (LayoutTestController::setFixedContentsSize):
2840
2841 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2842
2843         Reviewed by Dan Bernstein.
2844
2845         https://bugs.webkit.org/show_bug.cgi?id=30456
2846         Fixes for new Debug_All Windows build configuration.
2847
2848         * DumpRenderTree/win/DumpRenderTree.cpp:
2849         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2850         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2851
2852 2009-10-16  Eric Seidel  <eric@webkit.org>
2853
2854         Reviewed by Adam Barth.
2855
2856         commit-queue status bot should list which buildbot is blocking the queue
2857         https://bugs.webkit.org/show_bug.cgi?id=30452
2858
2859         Add new methods and testing.
2860
2861         * Scripts/bugzilla-tool:
2862         * Scripts/modules/buildbot.py:
2863         * Scripts/modules/buildbot_unittest.py:
2864
2865 2009-10-16  Eric Seidel  <eric@webkit.org>
2866
2867         Reviewed by Adam Barth.
2868
2869         run-webkit-tests fails when CWD is not inside a WebKit checkout
2870         https://bugs.webkit.org/show_bug.cgi?id=30451
2871
2872         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2873         * Scripts/modules/scm_unittest.py:
2874           - Remove use of original_path (we don't need to restore the CWD).
2875           - Don't use '.' to find the webkit checkout, use __file__ instead.
2876
2877 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2878
2879         Reviewed by Adam Roben.
2880
2881         Add a Debug_All configuration to build entire stack as debug.
2882         Change Debug_Internal to:
2883         - stop using _debug suffix for all WebKit/Safari binaries
2884         - not use _debug as a DLL naming suffix
2885         - use non-debug C runtime lib.
2886
2887         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2888         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2889         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2890         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2891         Add missing debug.vsprops inherited property sheet.
2892         Add Debug_All configuration.
2893         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2894         * WinLauncher/WinLauncher.vcproj:
2895         Removed extraneous definitions inherited from vsprops.
2896         Add Debug_All configuration.
2897
2898 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2899
2900         Reviewed by David Levin.
2901
2902         check-webkit-style is wrong about indent checking in namespaces
2903         in header files and a few other things
2904         https://bugs.webkit.org/show_bug.cgi?id=30362
2905
2906         The few other things include:
2907         + check-webkit-style does not require spaces around the equal sign
2908           inside 'if' statements and around binary operators that take 
2909           numeric literals.
2910         + check-webkit-style reports false errors for the / operator
2911           when part of a filename in the #include directive.
2912
2913         * Scripts/modules/cpp_style.py:
2914         Improved indentation checking and space checking around
2915         binary operators. While the checks are still not perfect,
2916         they are clearly better than before.
2917         * Scripts/modules/cpp_style_unittest.py:
2918         Added test cases for the newly supported checks and modified old
2919         test cases to match the new guidelines
2920
2921 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2922
2923         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2924
2925         * wx/build/settings.py:
2926
2927 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2928
2929         Reviewed by David Levin.
2930
2931         Add mod_pywebsocket to test Web Sockets.
2932         http://code.google.com/p/pywebsocket/
2933         https://bugs.webkit.org/show_bug.cgi?id=27490
2934
2935         * pywebsocket/COPYING: Added.
2936         * pywebsocket/MANIFEST.in: Added.
2937         * pywebsocket/README: Added.
2938         * pywebsocket/example/echo_client.py: Added.
2939         * pywebsocket/example/echo_wsh.py: Added.
2940         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2941         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2942         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2943         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2944         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2945         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2946         * pywebsocket/mod_pywebsocket/util.py: Added.
2947         * pywebsocket/setup.py: Added.
2948         * pywebsocket/test/config.py: Added.
2949         * pywebsocket/test/mock.py: Added.
2950         * pywebsocket/test/run_all.py: Added.
2951         * pywebsocket/test/test_dispatch.py: Added.
2952         * pywebsocket/test/test_handshake.py: Added.
2953         * pywebsocket/test/test_mock.py: Added.
2954         * pywebsocket/test/test_msgutil.py: Added.
2955         * pywebsocket/test/test_util.py: Added.
2956         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2957         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2958         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2959         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2960         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2961         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2962         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2963         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2964
2965 2009-10-15  James Robinson  <jamesr@google.com>
2966
2967         Reviewed by David Levin.
2968
2969         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2970
2971         https://bugs.webkit.org/show_bug.cgi?id=30426
2972
2973         * Scripts/modules/cpp_style.py:
2974         * Scripts/modules/cpp_style_unittest.py:
2975
2976 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2977
2978         Reviewed by Adam Roben.
2979
2980         Fixes <http://webkit.org/b/30411>.
2981         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2982         
2983         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2984         building Chromium.
2985
2986         * Scripts/pdevenv:
2987
2988 2009-10-15  Robin Dunn  <robin@alldunn.com>
2989
2990         Reviewed by Kevin Ollivier.
2991
2992         Add Mac package building scripts for wx.
2993         
2994         https://bugs.webkit.org/show_bug.cgi?id=30405
2995
2996         * wx/build/build_utils.py:
2997         * wx/build/settings.py:
2998         * wx/packaging/build-mac-installer.py: Added.
2999
3000 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3001
3002         Reviewed by Gustavo Noronha.
3003
3004         Enable Web Sockets support when running layout tests.
3005
3006         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3007         (resetDefaultsToConsistentValues):
3008
3009 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3010
3011         Reviewed by Gustavo Noronha.
3012
3013         Need to initialize event.button.button, since in most cases a
3014         button number is not passed as an argument.
3015
3016         * DumpRenderTree/gtk/EventSender.cpp:
3017         (mouseDownCallback):
3018         (mouseUpCallback):
3019
3020 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3021
3022         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3023         the OS if none was explicitly set.
3024
3025         * wx/build/settings.py:
3026
3027 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3028
3029         Reviewed by Timothy Hatcher.
3030
3031         Web Inspector: enable developers extras within inspector layout tests.
3032
3033         https://bugs.webkit.org/show_bug.cgi?id=30014
3034
3035         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3036         (LayoutTestController::showWebInspector):
3037         (LayoutTestController::closeWebInspector):
3038         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3039         (LayoutTestController::showWebInspector):
3040         (LayoutTestController::closeWebInspector):
3041
3042 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3043
3044         Reviewed by Jan Alonzo.
3045
3046         GtkLauncher is using a deprecated signal
3047         https://bugs.webkit.org/show_bug.cgi?id=30364
3048
3049         Modified GtkLauncher to use notify::title signal instead of
3050         deprecated title-changed signal
3051
3052         * GtkLauncher/main.c:
3053         (notify_title_cb):
3054         (create_browser):
3055
3056 2009-10-14  Brady Eidson  <beidson@apple.com>
3057
3058         Reviewed by Sam Weinig.
3059
3060         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3061         1 - Disables WebHistory
3062         2 - Doesn't make sense in that context anyway.
3063
3064         * DumpRenderTree/win/DumpRenderTree.cpp:
3065         (createWebViewAndOffscreenWindow):
3066
3067 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3068
3069         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3070         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3071
3072         * wx/build/settings.py:
3073         * wx/install-unix-extras:
3074
3075 2009-10-14  Brady Eidson  <beidson@apple.com>
3076
3077         Reviewed by Sam Weinig.
3078
3079         WebKit Win API should provide a delegate interface for global history.
3080         https://bugs.webkit.org/show_bug.cgi?id=29905
3081
3082         * DumpRenderTree/LayoutTestController.cpp:
3083         (LayoutTestController::LayoutTestController):
3084         * DumpRenderTree/LayoutTestController.h:
3085         (LayoutTestController::dumpHistoryDelegateCallbacks):
3086         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3087                 
3088         * DumpRenderTree/win/DumpRenderTree.cpp:
3089         (shouldLogHistoryDelegates):
3090         (runTest):
3091         (createWebViewAndOffscreenWindow):
3092         (main):
3093         * DumpRenderTree/win/DumpRenderTree.vcproj:
3094         
3095         Add the IWebHistoryDelegate to DRT Windows:
3096         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3097         (wstringFromBSTR):
3098         (HistoryDelegate::HistoryDelegate):
3099         (HistoryDelegate::~HistoryDelegate):
3100         (HistoryDelegate::QueryInterface):
3101         (HistoryDelegate::AddRef):
3102         (HistoryDelegate::Release):
3103         (HistoryDelegate::didNavigateWithNavigationData):
3104         (HistoryDelegate::didPerformClientRedirectFromURL):
3105         (HistoryDelegate::didPerformServerRedirectFromURL):
3106         (HistoryDelegate::updateHistoryTitle):
3107         (HistoryDelegate::populateVisitedLinksForWebView):
3108         * DumpRenderTree/win/HistoryDelegate.h: Added.
3109
3110         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3111         (LayoutTestController::removeAllVisitedLinks):
3112
3113 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3114
3115         Reviewed by Simon Hausmann.
3116
3117         [Qt] Implement support for setPOSIXLocale on Qt.
3118         https://bugs.webkit.org/show_bug.cgi?id=30268 
3119  
3120         * DumpRenderTree/qt/DumpRenderTree.cpp:
3121         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3122         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3123         (LayoutTestController::setPOSIXLocale):
3124         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3125
3126 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3127
3128         Unreviewed, adding myself to reviewers list.
3129
3130         * Scripts/modules/committers.py:
3131
3132 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3133
3134         Reviewed by Mark Rowe.
3135
3136         Fix null assignment so root tests work again.
3137
3138         * Scripts/webkitdirs.pm:
3139
3140 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3141
3142         Reviewed by Simon Hausmann.
3143
3144         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3145         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3146         This is done in preparation of implementing missing features in DRT.
3147         No functionality changes made yet.
3148
3149         * DumpRenderTree/qt/DumpRenderTree.cpp:
3150         * DumpRenderTree/qt/DumpRenderTree.pro:
3151         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3152         (EventSender::EventSender):
3153         (EventSender::mouseDown):
3154         (EventSender::mouseUp):
3155         (EventSender::mouseMoveTo):
3156         (EventSender::leapForward):
3157         (EventSender::keyDown):
3158         (EventSender::contextClick):
3159         (EventSender::scheduleAsynchronousClick):
3160         (EventSender::frameUnderMouse):
3161         * DumpRenderTree/qt/EventSenderQt.h: Added.
3162         (EventSender::clearKillRing):
3163         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3164         (LayoutTestController::LayoutTestController):
3165         (LayoutTestController::reset):
3166         (LayoutTestController::processWork):
3167         (LayoutTestController::maybeDump):
3168         (LayoutTestController::waitUntilDone):
3169         (LayoutTestController::notifyDone):
3170         (LayoutTestController::windowCount):
3171         (LayoutTestController::clearBackForwardList):
3172         (LayoutTestController::dumpEditingCallbacks):
3173         (LayoutTestController::dumpResourceLoadCallbacks):
3174         (LayoutTestController::queueBackNavigation):
3175         (LayoutTestController::queueForwardNavigation):
3176         (LayoutTestController::queueLoad):
3177         (LayoutTestController::queueReload):
3178         (LayoutTestController::queueScript):
3179         (LayoutTestController::provisionalLoad):
3180         (LayoutTestController::timerEvent):
3181         (LayoutTestController::encodeHostName):
3182         (LayoutTestController::decodeHostName):
3183         (LayoutTestController::setJavaScriptProfilingEnabled):
3184         (LayoutTestController::setFixedContentsSize):
3185         (LayoutTestController::setPrivateBrowsingEnabled):
3186         (LayoutTestController::setPopupBlockingEnabled):
3187         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3188         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3189         (LayoutTestController::numberOfActiveAnimations):
3190         (LayoutTestController::disableImageLoading):
3191         (LayoutTestController::dispatchPendingLoadRequests):
3192         (LayoutTestController::setDatabaseQuota):
3193         (LayoutTestController::clearAllDatabases):
3194         (LayoutTestController::whiteListAccessFromOrigin):
3195         (LayoutTestController::waitForPolicyDelegate):
3196         (LayoutTestController::overridePreference):
3197         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3198         (LayoutTestController::isLoading):
3199         (LayoutTestController::setLoading):
3200         (LayoutTestController::shouldDumpAsText):
3201         (LayoutTestController::shouldDumpBackForwardList):
3202         (LayoutTestController::shouldDumpChildrenAsText):
3203         (LayoutTestController::shouldDumpDatabaseCallbacks):
3204         (LayoutTestController::shouldDumpStatusCallbacks):
3205         (LayoutTestController::shouldWaitUntilDone):
3206         (LayoutTestController::canOpenWindows):
3207         (LayoutTestController::shouldDumpTitleChanges):
3208         (LayoutTestController::waitForPolicy):
3209         (LayoutTestController::dumpAsText):
3210         (LayoutTestController::dumpChildFramesAsText):
3211         (LayoutTestController::dumpDatabaseCallbacks):
3212         (LayoutTestController::dumpStatusCallbacks):
3213         (LayoutTestController::setCanOpenWindows):
3214         (LayoutTestController::dumpBackForwardList):
3215         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3216         (LayoutTestController::display):
3217         (LayoutTestController::dumpTitleChanges):
3218         (LayoutTestController::dumpSelectionRect):
3219         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3220         (TextInputController::TextInputController):
3221         (TextInputController::doCommand):
3222         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3223         * DumpRenderTree/qt/WorkQueue.cpp:
3224         * DumpRenderTree/qt/WorkQueue.h:
3225         * DumpRenderTree/qt/WorkQueueItem.h:
3226         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3227         (findFrameNamed):
3228         (LoadItem::invoke):
3229         (ReloadItem::invoke):
3230         (ScriptItem::invoke):
3231         (BackForwardItem::invoke):
3232         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3233         * DumpRenderTree/qt/jsobjects.h:
3234
3235 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3236
3237         Not reviewed, adding myself to the list of reviewers.
3238
3239         * Scripts/modules/committers.py:
3240
3241 2009-10-13  Anders Carlsson  <andersca@apple.com>
3242
3243         Reviewed by Sam Weinig.
3244
3245         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3246
3247         Make the private browsing mode testable by the test plug-in.
3248         
3249         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3250         (pluginGetProperty):
3251         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3252         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3253         (NPP_New):
3254         (NPP_SetValue):
3255
3256 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3257
3258         No review, just adding self to the list of reviewers.
3259
3260         * Scripts/modules/committers.py:
3261
3262 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3263
3264         Reviewed by Adam Roben.
3265
3266         Web Inspector: Use proper web view in inspector layout
3267         tests for windows.
3268
3269         https://bugs.webkit.org/show_bug.cgi?id=30298
3270
3271         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3272         (LayoutTestController::showWebInspector):
3273         (LayoutTestController::closeWebInspector):
3274         (LayoutTestController::evaluateInWebInspector):
3275
3276 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3277
3278         Reviewed by Sam Weinig.
3279
3280         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3281         https://bugs.webkit.org/show_bug.cgi?id=29841
3282
3283         * DumpRenderTree/mac/DumpRenderTree.mm:
3284         (resetDefaultsToConsistentValues):
3285         * DumpRenderTree/win/DumpRenderTree.cpp:
3286         (resetDefaultsToConsistentValues):
3287
3288 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3289
3290         Reviewed by Dimitri Glazkov.
3291
3292         Chromium Port - Windows
3293         https://bugs.webkit.org/show_bug.cgi?id=29969
3294
3295         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3296         * Scripts/webkitdirs.pm:
3297
3298 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3299
3300         Reviewed by Darin Adler.
3301
3302         jsc scripts cleanup and Qt/GTK fix
3303         https://bugs.webkit.org/show_bug.cgi?id=30288
3304
3305         Duplicated jscPath() moved to webkitdirs.pm.
3306         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3307         Configuration added (release/debug) to path for Qt-port on Windows.
3308
3309         * Scripts/run-javascriptcore-tests:
3310         * Scripts/run-jsc:
3311         * Scripts/run-sunspider:
3312         * Scripts/sunspider-compare-results:
3313         * Scripts/webkitdirs.pm:
3314
3315 2009-10-11  Adam Barth  <abarth@webkit.org>
3316
3317         Unreviewed.  Add Collin to committers.py.
3318
3319         * Scripts/modules/committers.py:
3320
3321 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3322
3323         wx build fix, add bindings to source/include dirs now that there are sources there.
3324
3325         * wx/build/settings.py:
3326
3327 2009-10-09  Mark Rowe  <mrowe@apple.com>
3328
3329         Reviewed by Brady Eidson.
3330
3331         Enable plug-in halting in DumpRenderTree.
3332
3333         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3334         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3335
3336         * DumpRenderTree/mac/DumpRenderTree.mm:
3337         (resetDefaultsToConsistentValues):
3338         * DumpRenderTree/mac/UIDelegate.mm:
3339         (-[UIDelegate webView:shouldHaltPlugin:]):
3340
3341 2009-10-08  Brady Eidson  <beidson@apple.com>
3342
3343         Reviewed by Dan Bernstein.
3344
3345         Ask the History Delegate to populate the visited links hash.
3346         <rdar://problem/7285293> and https://webkit.org/b/29904
3347
3348         Add the ability for LayoutTestController to clear all visited links.
3349         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3350
3351         * DumpRenderTree/LayoutTestController.cpp:
3352         (LayoutTestController::LayoutTestController):
3353         (removeAllVisitedLinksCallback):
3354         (LayoutTestController::staticFunctions):
3355         * DumpRenderTree/LayoutTestController.h:
3356         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3357         (LayoutTestController::removeAllVisitedLinks):
3358
3359         * DumpRenderTree/mac/HistoryDelegate.mm:
3360         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3361
3362         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3363         (LayoutTestController::removeAllVisitedLinks):
3364         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3365         (LayoutTestController::removeAllVisitedLinks):
3366         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3367         (LayoutTestController::removeAllVisitedLinks):
3368
3369
3370 2009-10-08  Daniel Bates  <dbates@webkit.org>
3371
3372         Reviewed by Adam Roben.
3373
3374         https://bugs.webkit.org/show_bug.cgi?id=30175
3375         
3376         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3377         the OLE drag-and-drop return value like the function it emulates. Currently, 
3378         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3379         whether the drag-and-drop operation was successful or was cancelled.
3380         
3381         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3382         return value according to whether the drop operation was successful or not.
3383
3384         * DumpRenderTree/win/EventSender.cpp:
3385         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3386         (replaySavedEvents): Ditto.
3387         * DumpRenderTree/win/EventSender.h:
3388         * DumpRenderTree/win/UIDelegate.cpp:
3389         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3390
3391 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3392
3393         Reviewed by Xan Lopez.
3394
3395         [GTK] Added support for a parameter setting the button that was
3396         pressed in the mouseDown function.
3397         https://bugs.webkit.org/show_bug.cgi?id=30220
3398
3399         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3400
3401 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3402
3403         Reviewed by Xan Lopez.
3404
3405         [GTK] Added a line to the bottom of the expected result to match
3406         the output of the test.
3407         https://bugs.webkit.org/show_bug.cgi?id=30220
3408
3409         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3410         expected.txt:
3411
3412 2009-10-08  Adam Roben  <aroben@apple.com>
3413
3414         Use QueryInterface to get IWebInspectorPrivate
3415
3416         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3417         accessed in a more standard way
3418
3419         Reviewed by John Sullivan and Tim Hatcher.
3420
3421         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3422         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3423         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3424         to the IWebInspectorPrivate interface.
3425
3426 2009-10-07  Adam Roben  <aroben@apple.com>
3427
3428         Implement DRT support for origin whitelisting
3429
3430         Fixes <http://webkit.org/b/30185>.
3431
3432         Reviewed by Eric Seidel.
3433
3434         * DumpRenderTree/win/DumpRenderTree.cpp:
3435         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3436         whitelist, to match Mac DRT.
3437         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3438         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3439         IWebViewPrivate::whiteListAccessFromOrigin.
3440
3441 2009-10-07  Brady Eidson  <beidson@apple.com>
3442
3443         Reviewed by Darin Adler.
3444
3445         Send title changes to the global history delegate.
3446         <rdar://problem/7285293> and https://webkit.org/b/29904
3447
3448         * DumpRenderTree/mac/HistoryDelegate.mm:
3449         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3450
3451 2009-10-07  Adam Barth  <abarth@webkit.org>
3452
3453         Unreviewed.  Remove some folks from committers.py who were listed on
3454         the WebKit Team wiki page but who weren't actually listed as commit+.
3455         At some point, we should coorelate this list with the committers
3456         mailing list.
3457
3458         * Scripts/modules/committers.py:
3459
3460 2009-10-07  Adam Barth  <abarth@webkit.org>
3461
3462         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3463         the wiki into committers.py.
3464
3465         * Scripts/modules/committers.py:
3466
3467 2009-10-07  Adam Barth  <abarth@webkit.org>
3468
3469         Unreviewed.  Added Aaron Boodman to committers.py.
3470
3471         * Scripts/modules/committers.py:
3472
3473 2009-10-07  Evan Martin  <evan@chromium.org>
3474
3475         Reviewed by Darin Adler.
3476
3477         Add API to LayoutTestController for re/setting the system locale.
3478         https://bugs.webkit.org/show_bug.cgi?id=18994
3479
3480         * DumpRenderTree/LayoutTestController.cpp:
3481         (setLocaleCallback):
3482         (LayoutTestController::staticFunctions):
3483         (LayoutTestController::setLocale):
3484         * DumpRenderTree/LayoutTestController.h:
3485
3486 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3487
3488         Reviewed by Jan Alonzo.
3489
3490         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3491         https://bugs.webkit.org/show_bug.cgi?id=29689
3492
3493         Build fix by adding -lfontconfig for DumpRenderTree.
3494
3495         * GNUmakefile.am:
3496
3497 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3498
3499         Reviewed by Simon Hausmann.
3500
3501         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3502
3503         * Scripts/run-webkit-tests:
3504
3505 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3506
3507         Reviewed by Gustavo Noronha.
3508
3509         "delete" in EventSender is the backspace key, not the delete one.
3510
3511         * DumpRenderTree/gtk/EventSender.cpp:
3512         (keyDownCallback):
3513
3514 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3515
3516         Reviewed by Gustavo Noronha.
3517
3518         getChildrenWithRange expects as last parameter the end index, not
3519         the length of the range. Correct this and clarify the variable
3520         names to reflect how the code works.
3521
3522         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3523         (AccessibilityUIElement::getChildrenWithRange):
3524         (AccessibilityUIElement::getChildAtIndex):
3525
3526 2009-10-06  Mark Rowe  <mrowe@apple.com>
3527
3528         Reviewed by Simon Fraser.
3529
3530         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3531
3532         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3533         the fact we have already changed the working directory to the top of the open source tree.
3534
3535 2009-10-06  Julie Parent  <jparent@chromium.org>
3536
3537         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3538         rather than my committer email.
3539
3540         * Scripts/modules/committers.py:
3541
3542 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3543
3544         Reviewed by Eric Seidel.
3545
3546         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3547
3548         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3549         it after each layout test as it should do, making the DRT dump additional output
3550         for all of the subsequent layout tests.
3551
3552         * DumpRenderTree/qt/jsobjects.cpp:
3553         (LayoutTestController::reset):
3554
3555 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3556
3557         Reviewed by Simon Hausmann.
3558
3559         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3560         fast/dom/assign-to-window-status.html test, which is passing as a result.
3561
3562         https://bugs.webkit.org/show_bug.cgi?id=30127
3563
3564         * DumpRenderTree/qt/DumpRenderTree.cpp:
3565         (WebCore::DumpRenderTree::DumpRenderTree):
3566         (WebCore::DumpRenderTree::statusBarMessage):
3567         * DumpRenderTree/qt/DumpRenderTree.h:
3568         * DumpRenderTree/qt/jsobjects.h:
3569         (LayoutTestController::shouldDumpStatusCallbacks):
3570         (LayoutTestController::dumpStatusCallbacks):
3571
3572 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3573
3574         Reviewed by Simon Hausmann.
3575
3576         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3577         ignores the argument indicating which mouse button to trigger.
3578         https://bugs.webkit.org/show_bug.cgi?id=30048
3579
3580         This affects the fast/events/mouse-click-events.html layout test.
3581
3582         * DumpRenderTree/qt/jsobjects.cpp:
3583         (EventSender::mouseDown):
3584         (EventSender::mouseUp):
3585         * DumpRenderTree/qt/jsobjects.h:
3586
3587 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3588
3589         Reviewed by Simon Hausmann.
3590
3591         [Qt] Fix the EventSender::keyDown() implementation
3592         https://bugs.webkit.org/show_bug.cgi?id=30043
3593
3594         It should post both a key press event and a key release event,
3595         just like other ports do.
3596
3597         * DumpRenderTree/qt/jsobjects.cpp:
3598         (EventSender::keyDown):
3599
3600 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3601
3602         wx build fix. Add jpeg to the list of libs to link against.
3603
3604         * wx/build/settings.py:
3605
3606 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3607
3608         Reviewed by Simon Hausmann.
3609
3610         [Qt] EventSender::keyDown() cannot send function-key events.
3611         https://bugs.webkit.org/show_bug.cgi?id=30044
3612
3613         This affects the fast/events/keydown-function-keys.html layout test.
3614
3615         * DumpRenderTree/qt/jsobjects.cpp:
3616         (EventSender::keyDown):
3617
3618 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3619
3620         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3621         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3622
3623         * wx/build/settings.py:
3624         * wx/build/wxpresets.py:
3625
3626 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3627
3628         Reviewed by Timothy Hatcher.
3629
3630         Web Inspector: add testing harness for Web Inspector.
3631
3632         https://bugs.webkit.org/show_bug.cgi?id=30010
3633
3634         * DumpRenderTree/LayoutTestController.cpp:
3635         (showWebInspectorCallback):
3636         (closeWebInspectorCallback):
3637         (evaluateInWebInspectorCallback):
3638         (LayoutTestController::staticFunctions):
3639         * DumpRenderTree/LayoutTestController.h:
3640         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3641         (LayoutTestController::showWebInspector):
3642         (LayoutTestController::closeWebInspector):
3643         (LayoutTestController::evaluateInWebInspector):
3644         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3645         (LayoutTestController::showWebInspector):
3646         (LayoutTestController::closeWebInspector):
3647         (LayoutTestController::evaluateInWebInspector):
3648         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3649         (LayoutTestController::showWebInspector):
3650         (LayoutTestController::closeWebInspector):
3651         (LayoutTestController::evaluateInWebInspector):
3652         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3653         (LayoutTestController::showWebInspector):
3654         (LayoutTestController::closeWebInspector):
3655         (LayoutTestController::evaluateInWebInspector):
3656
3657 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3658
3659         Reviewed by Ariyha Hidayat.
3660
3661         Pass arguments to system() as a string instead of array
3662
3663         When passed as an array entries with a space fail to translate
3664         to two arguments to the child process, so instead of manually
3665         splitting all the entries in @buildArgs we pass the whole thing
3666         as a string instead.
3667
3668         * Scripts/webkitdirs.pm:
3669
3670 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3671
3672         Reviewed by David Levin.
3673
3674         check-webkit-style misses whitespace errors for operators:
3675         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3676         https://bugs.webkit.org/show_bug.cgi?id=30021
3677
3678         * Scripts/modules/cpp_style.py:
3679         Added the operators mentioned above to the same list as == and !=.
3680
3681 2009-10-02  Julie Parent  <jparent@chromium.org>
3682
3683         Unreviewed.