Check to see if we are building a debug root
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-03  Stephanie  <slewis@apple.com>
2
3         Reviewed by Darin.
4
5         Check to see if we are building a debug root
6
7         * Scripts/check-for-global-initializers: 
8
9 2007-12-03  Dan Bernstein  <mitz@apple.com>
10
11         Reviewed by Darin Adler.
12
13         - added a testGetIntIdentifier() method to TestNetscapePlugIn
14
15         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
16         (pluginInvoke):
17
18 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
19
20         Reviewed by Oliver.
21
22         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
23         in a more fine-grained manner than eventSender.keyDown().
24
25         * DumpRenderTree/win/EventSender.cpp:
26         (getConstantCallback):
27         (dispatchMessageCallback):
28
29 2007-12-02  Darin Adler  <darin@apple.com>
30
31         * Scripts/do-webcore-rename: More planned renaming.
32
33 2007-12-02  Sam Weinig  <sam@webkit.org>
34
35         Rubber stamped by Anders.
36
37         Use [NSURL absoluteString] instead of [NSURL description] in order to get
38         more uniform results cross platform.
39
40         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
41         (-[NSURL _drt_descriptionSuitableForTestResult]):
42
43 2007-12-02  Sam Weinig  <sam@webkit.org>
44
45         Rubber stamped by Niko.
46
47         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
48
49         * DumpRenderTree/win/DumpRenderTree.cpp:
50         * DumpRenderTree/win/DumpRenderTree.vcproj:
51         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
52         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
53         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
54         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
55
56 2007-12-01  Alp Toker  <alp@atoker.com>
57
58         Reviewed by Adam Roben.
59
60         Make use of the newly introduced webkit.h convenience header.
61
62         * GtkLauncher/main.c:
63
64 2007-12-01  Adam Treat  <treat@kde.org>
65
66         Reviewed by Simon.
67
68         * Check to see if the directory exists and exit if not.
69
70         * DumpRenderTree/qt/main.cpp:
71         (main):
72
73 2007-12-01  Adam Treat  <treat@kde.org>
74
75         Reviewed by Simon.
76
77         * Don't hide symbols when in Debug mode
78         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
79
80
81         * DumpRenderTree/qt/main.cpp:
82         (messageHandler):
83
84 2007-11-30  Alp Toker  <alp@atoker.com>
85
86         Reviewed by Adam Roben.
87
88         http://bugs.webkit.org/show_bug.cgi?id=15691
89         [GTK] Public API does not follow GTK+ conventions
90
91         Refactor the WebKit/GTK+ public API. Changes:
92           WebKitPage -> WebKitWebView
93           WebKitFrame -> WebKitWebFrame
94
95         Public API source and header names have been updated to mirror the API
96         changes.
97
98         The API is now kept in WebKit/gtk/WebView to match other ports in the
99         same class such as Mac and Win.
100
101         * GtkLauncher/main.c:
102         (activate_uri_entry_cb):
103         (link_hover_cb):
104         (title_change_cb):
105         (progress_change_cb):
106         (go_back_cb):
107         (go_forward_cb):
108         (create_browser):
109         (main):
110
111 2007-11-30  Adam Roben  <aroben@apple.com>
112
113         Hopefully the final build fix
114
115         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
116         pull in WTF's assertion/logging functions.
117
118 2007-11-30  Adam Roben  <aroben@apple.com>
119
120         Another build fix
121
122         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
123         WebKit.lib.
124
125 2007-11-30  Adam Roben  <aroben@apple.com>
126
127         Debug build fix
128
129         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
130         configuration.
131         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
132         projects.
133         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
134         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
135         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
136
137 2007-11-30  Sam Weinig  <sam@webkit.org>
138
139         Reviewed by Adam Roben.
140
141         Fix drawSelectionRect to actually draw the selection rect.
142
143         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
144         (drawSelectionRect):
145
146 2007-11-30  Darin Adler  <darin@apple.com>
147
148         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
149
150 2007-11-30  Darin Adler  <darin@apple.com>
151
152         * Scripts/do-webcore-rename: Get ready for some future renaming.
153
154 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
155
156         Reviewed by Adam.
157
158         - Removed some unnecessary functions and changed an unused return type. 
159
160         * Drosera/win/DebuggerClient.cpp:
161         (registerConsoleClass):
162         * Drosera/win/DebuggerClient.h:
163         * Drosera/win/Drosera.cpp:
164         (registerDroseraClass):
165
166 2007-11-28  Alp Toker  <alp@atoker.com>
167
168         Reviewed by Timothy Hatcher.
169
170         http://bugs.webkit.org/show_bug.cgi?id=16174
171         [GTK] Use "URI" not "URL" in public API
172
173         Replace use of the term "URL" with "URI" in public headers,
174         documentation and some internal code to match GLib/GTK+ convention.
175
176         This is now mentioned in the API guidelines:
177           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
178
179         * GtkLauncher/main.c:
180         (activate_uri_entry_cb):
181         (title_change_cb):
182         (create_toolbar):
183         (main):
184
185 2007-11-29  Anders Carlsson  <andersca@apple.com>
186
187         Reviewed by Sam.
188
189         <rdar://problem/5230478>
190         FrameLoadDelegate callbacks are not dumped in DRT.
191         
192         * DumpRenderTree/win/DumpRenderTree.cpp:
193         (shouldLogFrameLoadDelegates):
194         (runTest):
195         (main):
196         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
197         (BSTRtoString):
198         (descriptionSuitableForTestResult):
199         (FrameLoadDelegate::QueryInterface):
200         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
201         (FrameLoadDelegate::didFailProvisionalLoadWithError):
202         (FrameLoadDelegate::didCommitLoadForFrame):
203         (FrameLoadDelegate::didFinishLoadForFrame):
204         (FrameLoadDelegate::willCloseFrame):
205         (FrameLoadDelegate::didClearWindowObject):
206         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
207         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
208         * DumpRenderTree/win/FrameLoaderDelegate.h:
209         (FrameLoadDelegate::windowScriptObjectAvailable):
210         (FrameLoadDelegate::didFirstLayoutInFrame):
211
212 2007-11-29  Sam Weinig  <sam@webkit.org>
213
214         Reviewed by Anders.
215
216         Add database quota UIDelegates methods to DRT UIDelegate.
217
218         * DumpRenderTree/mac/UIDelegate.mm:
219         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
220         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
221
222 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
223
224         Reviewed by Sam.
225
226         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
227         dying and vice versa.
228         - This fix will allow Drosera and Safari to reconnect if either of them
229         closes correctly, but does not fix the case where one of them dies
230         silently.
231
232         * Drosera/win/ServerConnection.cpp:
233         (ServerConnection::attemptToCreateServerConnection): Added a safety
234         check, because it's possilbe to try to connect to a server that's dying.
235         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
236         the server has died.
237         * Drosera/win/ServerConnection.h: Added the new function and removed
238         an unnecessary member.
239
240 2007-11-29  Anders Carlsson  <andersca@apple.com>
241
242         * DumpRenderTree/win/DumpRenderTree.vcproj:
243         Add shlwapi.lib to all configurations.
244
245 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
246
247         - Build fix.  Added additional includes for VS Express to the Release
248         project.
249
250         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
251
252 2007-11-29  Anders Carlsson  <andersca@apple.com>
253
254         Reviewed by Adam.
255
256         <rdar://problem/5132005>
257         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
258         
259         * DumpRenderTree/win/DumpRenderTree.vcproj:
260         Add shlwapi.lib
261         
262         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
263         (LayoutTestController::setUserStyleSheetEnabled):
264         Implement this.
265         
266         (appendComponentToPath):
267         New method which wraps the Win32 API PathAppend.
268         
269         (followShortcuts):
270         New method which checks if a file points to a shortcut and
271         follows the shortcut.
272         
273         (resolveCygwinPath):
274         New method that takes a cygwin unix-style path and returns the Win32 path.
275         
276         (cfStringRefToWString):
277         
278         (LayoutTestController::setUserStyleSheetLocation):
279         Implement this.
280
281 2007-11-29  Alice Liu  <alice.liu@apple.com>
282
283         Reviewed by Adam.
284
285         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
286
287         * DumpRenderTree/win/EventSender.cpp:
288         (keyDownCallback):
289         uppercase letters were being sent as lowercase letters without the shift key down.
290
291 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
292
293         - Windows build fix. VS express needs some love.
294
295         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
296
297 2007-11-28  Darin Adler  <darin@apple.com>
298
299         Reviewed by Adam Roben.
300
301         * DumpRenderTree/mac/EventSendingController.mm:
302         (-[EventSendingController keyDown:withModifiers:]):
303         Send capital letters through as lowercase letters with the shift key down
304         rather than sending them as if they were highly unusual "capital letter keys".
305
306         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
307         where you need to update results and more tests are failing than before.
308
309 2007-11-28  Anders Carlsson  <andersca@apple.com>
310
311         Reviewed by Darin.
312
313         <rdar://problem/5132001>
314         contextClick is not implemented in DRT on Windows.
315         
316         * DumpRenderTree/win/EventSender.cpp:
317         (contextClickCallback):
318         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
319         by a WM_RBUTTONUP message.
320         
321         * DumpRenderTree/win/UIDelegate.cpp:
322         (UIDelegate::hasCustomMenuImplementation):
323         (UIDelegate::trackCustomPopupMenu):
324         * DumpRenderTree/win/UIDelegate.h:
325         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
326         menu from being shown (and causing the DRT to hang).
327
328 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
329
330         Reviewed by Darin.
331
332         Fix DumpRenderTree ObjC bug comparing strings.
333
334         * DumpRenderTree/mac/ObjCController.m:
335         (-[ObjCController identityIsEqual::]): Compare strings with string
336         equality instead of identiy equality.
337
338 2007-11-27  Timothy Hatcher  <timothy@apple.com>
339
340         Reviewed by Sam.
341
342         Reset the authorAndUserStylesEnabled preference
343         back to YES for each test. Fixes the broken tests.
344
345         * DumpRenderTree/mac/DumpRenderTree.mm:
346         (resetWebViewToConsistentStateBeforeTesting):
347
348 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
349
350         Reviewed by Adam.
351
352         - Drosera now displays the console window, although it cannot currently
353         process JavaScript.
354
355         * Drosera/win/DebuggerClient.cpp: Shows the console window.
356         (registerConsoleClass): Implemented.
357         (consoleWndProc): Implemented.
358         (DebuggerClient::onSize): Implemented.
359         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
360         new window.
361         * Drosera/win/DebuggerClient.h: Added needed method and members for 
362         creating and maintaining a new window.
363         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
364         lines of code to more appropriate places.
365         (Drosera::handleCommand):
366         (Drosera::initUI):
367         (Drosera::onSize):
368         (Drosera::attach):
369
370 2007-11-27  Timothy Hatcher  <timothy@apple.com>
371
372         Reviewed by Dave Hyatt.
373
374         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
375         
376         Add support for disabling author and user styles for testing.
377
378         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
379         * DumpRenderTree/LayoutTestController.cpp:
380         (setAuthorAndUserStylesEnabledCallback):
381         (LayoutTestController::staticFunctions):
382         * DumpRenderTree/LayoutTestController.h:
383         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
384         (LayoutTestController::setAuthorAndUserStylesEnabled):
385         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
386         (LayoutTestController::setAuthorAndUserStylesEnabled):
387
388 2007-11-26  Dan Bernstein  <mitz@apple.com>
389
390         - Tiger build fix.
391
392         * DumpRenderTree/mac/Configurations/Base.xcconfig:
393
394 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
395
396         Reviewed by Maciej.
397
398         - Implemented displaying variables for Drosera on Win.
399
400         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
401         that retrieve variables to not hold onto the return value since it's
402         not returned.  Also changed to use the new signatures of the retrieval
403         functions.
404         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
405         (DebuggerDocument::platformValueForScopeVariableNamed):
406         * Drosera/win/Drosera.cpp: Removed a needless TODO.
407         (droseraWndProc):
408
409 2007-11-26  Sam Weinig  <sam@webkit.org>
410
411         Cleanup names of painting and repainting functions.
412
413         Reviewed by Adam Roben.
414
415         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
416         (drawSelectionRect): was drawSelectionRectIntoContext.
417         (dumpWebViewAsPixelsAndCompareWithExpected):
418         * DumpRenderTree/cg/PixelDumpSupportCG.h:
419         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
420         (paintWebView): was drawWebViewIntoContext.
421         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
422
423 2007-11-26  Sam Weinig  <sam@webkit.org>
424
425         Reviewed by Dan Bernstein.
426
427         - Leopard build fix
428
429         * DumpRenderTree/mac/Configurations/Base.xcconfig:
430
431 2007-11-26  Sam Weinig  <sam@webkit.org>
432
433         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
434         Use shared PixelDumpSupport for Mac DRT
435
436         Reviewed by Adam Roben.
437
438         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
439         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
440         * DumpRenderTree/cg/ImageDiffCG.cpp:
441         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
442         (drawSelectionRectIntoContext):
443         (dumpWebViewAsPixelsAndCompareWithExpected):
444         * DumpRenderTree/cg/PixelDumpSupportCG.h:
445         * DumpRenderTree/mac/Configurations/Base.xcconfig:
446         * DumpRenderTree/mac/DumpRenderTree.mm:
447         (dump):
448         * DumpRenderTree/mac/ImageDiff.m: Removed.
449         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
450         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
451         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
452         (setDefaultColorProfileToRGB):
453         (getBitmapContextFromWebView):
454         (drawWebViewIntoContext):
455         (repaintWithVerticalSweep):
456         (repaintWithHorizontalSweep):
457         (getSelectionRect):
458         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
459
460 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
461
462         Bug 16052: prepare-ChangeLog doesn't report deleted files
463         <http://bugs.webkit.org/show_bug.cgi?id=16052>
464
465         Reviewed by Sam.
466
467         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
468
469 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
470
471         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
472         <http://bugs.webkit.org/show_bug.cgi?id=15864>
473
474         Reviewed by Adam.
475
476         Roll functionality of merge-changelog into resolve-ChangeLogs
477         script.  The script now checks for ChangeLog.rej and
478         ChangeLog.orig files first.  If it finds them, it uses the
479         ChangeLog.rej file as a patch (in old contextual diff format) to
480         apply with --fuzz=3.
481
482         * Scripts/merge-changelog: Removed.
483         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
484
485 2007-11-25  Sam Weinig  <sam@webkit.org>
486
487         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
488
489         Reviewed by Mark Rowe.
490
491         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
492         * DumpRenderTree/mac/Configurations/Base.xcconfig:
493         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
494         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
495         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
496
497 2007-11-25  Sam Weinig  <sam@webkit.org>
498
499         Convert DumpRenderTree to ues .xcconfig files.
500
501         Reviewed by Mark Rowe.
502
503         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
504         * DumpRenderTree/mac/Configurations: Added.
505         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
506         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
507         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
508
509 2007-11-25  Sam Weinig  <sam@webkit.org>
510
511         Add ForwardingHeaders to wtf for DumpRenderTree.
512
513         Reviewed by Mark Rowe.
514
515         * DumpRenderTree/DumpRenderTree.h:
516         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
517         * DumpRenderTree/ForwardingHeaders: Added.
518         * DumpRenderTree/ForwardingHeaders/wtf: Added.
519         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
520         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
521         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
522         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
523         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
524         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
525         * DumpRenderTree/LayoutTestController.cpp:
526         * DumpRenderTree/WorkQueue.cpp:
527         * DumpRenderTree/mac/DumpRenderTree.mm:
528         * DumpRenderTree/mac/FrameLoadDelegate.mm:
529         * DumpRenderTree/mac/JavaScriptThreading.cpp:
530         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
531         * DumpRenderTree/mac/ObjCController.m:
532         * DumpRenderTree/mac/UIDelegate.mm:
533         * DumpRenderTree/mac/WorkQueueItemMac.mm:
534
535 2007-11-25  Adam Roben  <aroben@apple.com>
536
537         Fix some test failures caused by r28019
538
539         Now that stdout is in binary mode, we need to always use printf
540         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
541         the output.
542
543         Reviewed by Sam.
544
545         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
546         printf.
547         (UIDelegate::runJavaScriptAlertPanelWithMessage):
548         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
549         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
550         (UIDelegate::webViewAddMessageToConsole):
551
552 2007-11-25  Adam Roben  <aroben@apple.com>
553
554         Set the font smoothing preference in DRT
555
556         This makes the pixel results on Windows closer to the Mac results.
557
558         Reviewed by Mitz.
559
560         * DumpRenderTree/win/DumpRenderTree.cpp:
561         (initializePreferences):
562
563 2007-11-25  Adam Roben  <aroben@apple.com>
564
565         Port ImageDiff to CG and C++
566
567         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
568         <rdar://5071708>
569
570         Reviewed by Sam.
571
572         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
573         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
574         (main):
575         (createImageFromStdin):
576         (compareImages):
577         (getDifferenceBitmap):
578         (computePercentageDifferent):
579         * DumpRenderTree/win/ImageDiff.vcproj: Added.
580
581 2007-11-25  Adam Roben  <aroben@apple.com>
582
583         Fix image diff link generation on Windows
584
585         Reviewed by Sam.
586
587         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
588         to toURL.
589
590 2007-11-25  Adam Roben  <aroben@apple.com>
591
592         Implement pixel dumping in Windows DRT
593
594         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
595         <rdar://5071708>
596
597         Reviewed by Sam.
598
599         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
600         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
601         Content-Length header.
602         (getMD5HashStringForBitmap):
603         (dumpWebViewAsPixelsAndCompareWithExpected):
604         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
605         * DumpRenderTree/win/DumpRenderTree.cpp:
606         (dump): Do a pixel dump if requested.
607         (main): Parse pixel test options.
608         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
609         the cg/ subdirectory to the include path.
610         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
611         available in a header or import library, so we have to go through this
612         LoadLibrary/GetProcAddress dance to use them.
613         (cryptDLL):
614         (init):
615         (update):
616         (final):
617         (MD5_Init):
618         (MD5_Update):
619         (MD5_Final):
620         * DumpRenderTree/win/MD5.h: Added.
621         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
622         moved up to the top level to share it with Mac eventually.
623         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
624         (getBitmapContextFromWebView): Forces the WebView to paint using a
625         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
626
627 2007-11-25  Adam Roben  <aroben@apple.com>
628
629         Clean up Windows DRT's option parsing a little bit
630
631         Reviewed by Sam.
632
633         * DumpRenderTree/win/DumpRenderTree.cpp:
634         (main): Put non-option arguments into a Vector.
635
636 2007-11-25  Adam Roben  <aroben@apple.com>
637
638         Make Windows DRT stop changing LF into CRLF
639
640         Reviewed by Sam.
641
642         * DumpRenderTree/win/DumpRenderTree.cpp:
643         (main): Put stdout in binary mode.
644         * Scripts/run-webkit-tests: Remove the CRLF hack.
645
646 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
647
648         Removed empty directory.
649
650         * Scripts/resources: Removed.
651
652 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
653
654         Fix bisect-builds to work with recent WebKit nightly builds.
655
656         Reviewed by Dan.
657
658         * Scripts/bisect-builds: Check for the 
659         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
660         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
661         to WebKit.app/Contents/Resources.
662
663 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
664
665         Reviewed by Maciej.
666
667         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
668         not closed (affects digg.com)
669
670         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
671         one after finishing with a test to avoid having its delayed onload handler firing when
672         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
673         but it helps somewhat.
674
675 2007-11-22  Mark Rowe  <mrowe@apple.com>
676
677         Reviewed by Alp Toker.
678
679         Fix build-webkit to propagate make's exit status if it fails.
680
681         * Scripts/webkitdirs.pm:
682
683 2007-11-22  Dan Bernstein  <mitz@apple.com>
684
685         Reviewed by Mark Rowe.
686
687         - fix crash when running pixel tests
688
689         * DumpRenderTree/mac/DumpRenderTree.mm:
690         (dumpRenderTree): Parse the command line options before setting up the
691         environment so that we know if we need to set up the pixel dump
692         machinery.
693
694 2007-11-21  Eric Seidel  <eric@webkit.org>
695
696         Speculative build fix for Tiger.
697
698         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
699
700 2007-11-21  Eric Seidel  <eric@webkit.org>
701
702         Reviewed by Tim Hatcher.
703
704         Break out more of DumpRenderTree.mm into individual files
705
706         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
707         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
708         (checkedMalloc):
709         (checkedRealloc):
710         (makeLargeMallocFailSilently):
711         * DumpRenderTree/mac/CheckedMalloc.h: Added.
712         * DumpRenderTree/mac/DumpRenderTree.mm:
713         (crashHandler):
714         (dump):
715         * DumpRenderTree/mac/DumpRenderTreeMac.h:
716         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
717         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
718         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
719         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
720         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
721         (javaScriptThreads):
722         (runJavaScriptThread):
723         (startJavaScriptThreads):
724         (stopJavaScriptThreads):
725         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
726         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
727         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
728         (restoreColorSpace):
729         (setDefaultColorProfileToRGB):
730         (initializeColorSpaceAndScreeBufferForPixelTests):
731         (md5HashStringForBitmap):
732         (dumpWebViewAsPixelsAndCompareWithExpected):
733
734 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
735
736         Move install-unix-extras to wx directory as it seems only to be used by that 
737         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
738         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
739         have install-unix-extras install into WebKitLibraries as per
740         convention.
741         
742         Reviewed by Mark Rowe.
743
744         * Scripts/install-unix-extras: Removed.
745         * wx/build-wxwebkit:
746         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
747
748 2007-11-21  Eric Seidel  <eric@webkit.org>
749
750         Reviewed by Adam.
751
752         More refactoring for greater code readability
753
754         * DumpRenderTree/mac/DumpRenderTree.mm:
755         (initializeGlobalsFromCommandLineOptions):
756         (initializeColorSpaceAndScreeBufferForPixelTests):
757         (addTestPluginsToPluginSearchPath):
758         (useLongRunningServerMode):
759         (runTestingServerLoop):
760         (prepareConsistentTestingEnvironment):
761         (dumpRenderTree):
762         (main):
763         (dumpFramesAsText):
764         (dumpBackForwardListForWebView):
765         (sizeWebViewForCurrentTest):
766         (methodNameStringForFailedTest):
767         (dumpBackForwardListForAllWindows):
768         (dumpWebViewAsPixelsAndCompareWithExpected):
769         (invalidateAnyPreviousWaitToDumpWatchdog):
770         (dump):
771         * DumpRenderTree/mac/DumpRenderTreeMac.h:
772         * DumpRenderTree/mac/UIDelegate.mm:
773         (-[UIDelegate webView:createWebViewWithRequest:]):
774
775 2007-11-21  Eric Seidel  <eric@webkit.org>
776
777         Reviewed by Tim Hatcher.
778
779         Abstract more of DRT into static methods
780
781         * DumpRenderTree/mac/DumpRenderTree.mm:
782         (setDefaultsToConsistentValuesForTesting):
783         (setupSignalHandlers):
784         (allocateGlobalControllers):
785         (releaseAndZero):
786         (releaseGlobalControllers):
787         (dumpRenderTree):
788         (shouldLogFrameLoadDelegates):
789         (createCFURLFromPathOrURL):
790         (resetWebViewToConsistentStateBeforeTesting):
791         (runTest):
792
793 2007-11-21  Eric Seidel  <eric@webkit.org>
794
795         Reviewed by Tim Hatcher.
796
797         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
798
799         * DumpRenderTree/DumpRenderTree.h:
800         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
801         * DumpRenderTree/mac/DumpRenderTree.mm:
802         (dumpRenderTree):
803         (dump):
804         (runTest):
805         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
806         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
807         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
808         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
809         (-[DumpRenderTreePasteboard declareType:owner:]):
810         (+[LocalPasteboard alloc]):
811         (-[LocalPasteboard init]):
812         (-[LocalPasteboard dealloc]):
813         (-[LocalPasteboard name]):
814         (-[LocalPasteboard releaseGlobally]):
815         (-[LocalPasteboard declareTypes:owner:]):
816         (-[LocalPasteboard addTypes:owner:]):
817         (-[LocalPasteboard changeCount]):
818         (-[LocalPasteboard types]):
819         (-[LocalPasteboard availableTypeFromArray:]):
820         (-[LocalPasteboard setData:forType:]):
821         (-[LocalPasteboard dataForType:]):
822         (-[LocalPasteboard setPropertyList:forType:]):
823         (-[LocalPasteboard setString:forType:]):
824         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
825         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
826         (+[DumpRenderTreeWindow allWindows]):
827         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
828         (-[DumpRenderTreeWindow dealloc]):
829         (-[DumpRenderTreeWindow isKeyWindow]):
830         (-[DumpRenderTreeWindow keyDown:]):
831
832 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
833
834         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
835         it indiscriminately copies any headers inside JavaScriptCore,
836         which includes Tiger ICU headers. 
837
838         * wx/build-wxwebkit:
839         Don't run WebCore/move-js-headers.sh any longer.
840
841 2007-11-20  Adam Treat  <treat@kde.org>
842
843         Reviewed by David Kilzer.
844
845         * Prepend git branch name to $baseProductDir
846
847         * Scripts/VCSUtils.pm:
848         * Scripts/webkitdirs.pm:
849
850 2007-11-20  Mark Rowe  <mrowe@apple.com>
851
852         Reviewed by Simon Hausmann.
853
854         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
855         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
856         Have it trigger a "make distclean" rather than "make clean" to ensure that the
857         built product and generated Makefile's are removed.
858
859 2007-11-19  Alp Toker  <alp@atoker.com>
860
861         Reviewed by Mark Rowe.
862
863         http://bugs.webkit.org/show_bug.cgi?id=16040
864         [GTK] GtkLauncher should be written in C
865
866         Port GtkLauncher to plain C.
867
868         Use a more conventional GTK+ coding style.
869
870         Use a toolbar instead of menus.
871
872         Various signature fixes and cleanups.
873
874         Add a license header. Assume all previous modifications were copyright
875         assigned to Apple Inc. by default.
876
877         * GtkLauncher/GtkLauncher.pro:
878         * GtkLauncher/main.c: Added.
879         (activate_url_entry_cb):
880         (update_title):
881         (link_hover_cb):
882         (title_change_cb):
883         (progress_change_cb):
884         (destroy_cb):
885         (go_back_cb):
886         (go_forward_cb):
887         (create_browser):
888         (create_statusbar):
889         (create_toolbar):
890         (create_window):
891         (main):
892         * GtkLauncher/main.cpp: Removed.
893
894 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
895
896         Build script fixes to ensure they do the right thing for the 
897         wx port, and update build-wxwebkit to reflect the way the
898         build scripts now work.
899
900         Reviewed by Adam.
901
902         * Scripts/build-testkjs:
903         * Scripts/build-webkit:
904         * Scripts/run-javascriptcore-tests:
905         * Scripts/webkitdirs.pm:
906         * wx/build-wxwebkit:
907
908 2007-11-18  Eric Seidel  <eric@webkit.org>
909
910         Reviewed by Anders.
911
912         Make run-javascriptcore-tests report failures on exit (to support git bisect)
913
914         * Scripts/run-javascriptcore-tests:
915
916 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
917
918         Reviewed by Adam Roben.
919
920         Make run-webkit-tests work with Windows debug build.
921
922         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
923         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
924         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
925         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
926         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
927
928 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
929
930         Add wxWebKit sample and build script, and integrate it with 
931         build-webkit. Also make build-webkit --clean work for all
932         ports.
933
934         Reviewed by Darin Adler.
935
936         * Scripts/build-webkit:
937         * Scripts/webkitdirs.pm:
938         * wx: Added.
939         * wx/browser: Added.
940         * wx/browser/browser.bkl: Added.
941         * wx/browser/browser.cpp: Added.
942         * wx/build-wxwebkit: Added.
943
944 2007-11-17  Adam Roben  <aroben@apple.com>
945
946         Make it easy to run Safari in the debugger on Windows
947
948         I've added a new script, debug-safari, which launches Safari in the
949         debugger. On OS X it just calls gdb-safari.
950
951         Reviewed by Mark Rowe.
952
953         * FindSafari/FindSafari.cpp:
954         (_tmain): Added a /debugger flag, which in combination with
955         /printSafariLauncher will print a script that launches Safari in the
956         debugger.
957         * Scripts/debug-safari: Added.
958         * Scripts/run-safari: Changed to call runSafari().
959         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
960         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
961         first argument along to FindSafari.
962         * Scripts/webkitdirs.pm:
963         (sub runSafari): Added.
964
965 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
966
967         Reviewed by Adam Roben.
968
969         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
970
971 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
972
973         Reviewed by David Kilzer.
974
975         The git config command was renamed to repo-config at some point. This
976         change tries git config and then git repo-config if the first fails.
977
978         * Scripts/prepare-ChangeLog:
979         (gitConfig):
980
981 2007-11-16  Dan Bernstein  <mitz@apple.com>
982
983         Reviewed by Darin Adler and Sam Weinig.
984
985         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
986
987         * DumpRenderTree/win/EventSender.cpp:
988         (keyDownCallback): For characters that cannot be entered on the active
989         keyboard layout, send a WM_CHAR message with the character along with
990         a WM_KEYDOWN message with a virtual key code of 255.
991
992 2007-11-16  Mark Rowe  <mrowe@apple.com>
993
994         Reviewed by Tim Hatcher.
995
996         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
997
998         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
999         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1000
1001 2007-11-15  Adam Roben  <aroben@apple.com>
1002
1003         Make run-safari actually work on Windows
1004
1005         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1006         chdir call.
1007
1008 2007-11-14  Adam Roben  <aroben@apple.com>
1009
1010         Updates to Safari launching now that 3.0.4 is released
1011
1012         Reviewed by Sam.
1013
1014         * FindSafari/FindSafari.cpp:
1015         (getWebViewCLSID): Use version-independent ProgID.
1016         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1017
1018 2007-11-14  Anders Carlsson  <andersca@apple.com>
1019
1020         Reviewed by Adam.
1021
1022         <rdar://problem/5309081>
1023         In DRT, "plugin.logDestroy = true" not working on Windows.
1024         
1025         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1026         (NPP_Destroy):
1027
1028 2007-11-14  Eric Seidel  <eric@webkit.org>
1029
1030         Reviewed by Sam.
1031
1032         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1033
1034 2007-11-14  Anders Carlsson  <andersca@apple.com>
1035
1036         Reviewed by Adam.
1037
1038         <rdar://problem/5141186>
1039         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1040         
1041         Implement setWindowIsKey.
1042         
1043         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1044         (LayoutTestController::setWindowIsKey):
1045
1046 2007-11-13  Sam Weinig  <sam@webkit.org>
1047
1048         Reviewed by Adam Roben.
1049
1050         Fix for <rdar://problem/5382579>
1051         http/tests/security/cross-frame-access-put.html reports large 
1052         negative numbers for screenLeft and screenTop (Mac reports "0")
1053
1054         * DumpRenderTree/win/UIDelegate.cpp:
1055         (UIDelegate::UIDelegate): Initialize the RECT.
1056         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1057         (UIDelegate::webViewFrame): ditto.
1058         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1059
1060 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1061
1062         Reviewed by Adam.
1063
1064         - Make Drosera show source, source URLs, and function stack on Windows,
1065         and some minor fixes.
1066
1067         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1068         (DebuggerDocument::updateFileSource):
1069         * Drosera/debugger.js: Force source to always update display.
1070         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1071         menu controls.
1072         (DebuggerClient::resume):
1073         (DebuggerClient::pause):
1074         (DebuggerClient::stepInto):
1075         (DebuggerClient::stepOver):
1076         (DebuggerClient::stepOut):
1077         (DebuggerClient::showConsole):
1078         (DebuggerClient::closeCurrentFile):
1079         * Drosera/win/DebuggerClient.h: Ditto.
1080         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1081         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1082         removed two bugs.  1) caller could be in a bad state when asked to
1083         assign into it. 2) BSTRs were not created correctly.
1084         (DebuggerDocument::getPlatformCurrentFunctionStack):
1085         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1086         (droseraWndProc):
1087         (handleCommand):
1088         (Drosera::resume):
1089         (Drosera::pause):
1090         (Drosera::stepInto):
1091         (Drosera::stepOver):
1092         (Drosera::stepOut):
1093         (Drosera::showConsole):
1094         (Drosera::closeCurrentFile):
1095         * Drosera/win/Drosera.h: Hook up the menu controls.
1096         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1097         functions, added a null check, and fixed another bug where caller could
1098         be in a bad state when asked to assign into it.
1099         (ServerConnection::didLoadMainResourceForDataSource):
1100         (ServerConnection::getCallerFrame):
1101         * Drosera/win/ServerConnection.h: Safety first.
1102
1103 2007-11-13  Dan Bernstein  <mitz@apple.com>
1104
1105         Reviewed by Darin Adler.
1106
1107         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1108           DumpRenderTree --pixel-tests renders each test twice
1109
1110         * DumpRenderTree/mac/DumpRenderTree.mm:
1111         (dumpRenderTree): Removed the --paint option because the painting code
1112         is always exercised as a result of
1113         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1114         calling -displayIfNeeded.
1115         (dump): Changed to always grab the image from the window since the view
1116         is always displayed.
1117         (runTest):
1118         (displayWebView):
1119         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1120         because it always paints.
1121
1122 2007-11-12  Antti Koivisto  <antti@apple.com>
1123
1124         Reviewed by Adele.
1125         
1126         Add support for http media tests
1127
1128         * Scripts/run-webkit-tests:
1129
1130 2007-11-12  Sam Weinig  <sam@webkit.org>
1131
1132         Reviewed by Adam Roben.
1133
1134         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1135
1136         * DumpRenderTree/win/DumpRenderTree.cpp:
1137         (runTest):
1138         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1139         (LayoutTestController::setPrivateBrowsingEnabled):
1140
1141 2007-11-12  Adam Roben  <aroben@apple.com>
1142
1143         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1144         mac and win subdirectories.
1145
1146 2007-11-11  Adam Roben  <aroben@apple.com>
1147
1148         Fix <rdar://5133816> keepWebHistory is not implemented
1149
1150         Fixes fast/history/clicked-link-is-visited.html.
1151
1152         Reviewed by Darin.
1153
1154         * DumpRenderTree/win/DumpRenderTree.cpp:
1155         (runTest): Clear the optionalSharedHistory.
1156         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1157         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1158
1159 2007-11-10  Sam Weinig  <sam@webkit.org>
1160
1161         Reviewed by Tim Hatcher.
1162
1163         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1164         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1165         is turned on)
1166
1167         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1168
1169         Added test: http/tests/security/cross-frame-access-private-browsing.html
1170
1171         * DumpRenderTree/LayoutTestController.cpp:
1172         (setPrivateBrowsingEnabledCallback):
1173         (LayoutTestController::staticFunctions):
1174         * DumpRenderTree/LayoutTestController.h:
1175         * DumpRenderTree/mac/DumpRenderTree.mm:
1176         (runTest): Default to private browsing disabled.
1177         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1178         (LayoutTestController::setPrivateBrowsingEnabled):
1179         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1180         (LayoutTestController::setPrivateBrowsingEnabled):
1181
1182 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1183
1184         Reviewed by Adam.
1185
1186         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1187         WebCore's!
1188
1189         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1190         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1191         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1192         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1193         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1194         * Drosera/win/Drosera.cpp:
1195         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1196
1197 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1198
1199         Reviewed by Sam.
1200
1201         - Use the new IWebFrame [local] function signature and get the shared
1202         server correctly.
1203
1204         * Drosera/win/DebuggerClient.cpp:
1205         (DebuggerClient::didFinishLoadForFrame):
1206         * Drosera/win/ServerConnection.cpp:
1207         (ServerConnection::attemptToCreateServerConnection):
1208
1209 2007-11-07  Dan Bernstein  <mitz@apple.com>
1210
1211         Reviewed by Darin Adler.
1212
1213         - add an option to run-webkit-tests to ignore pixel test failures where
1214           all pixels differ by no more than a specified threshold
1215
1216         * DumpRenderTree/mac/ImageDiff.m:
1217         (main):
1218         (compareImages):
1219         (computePercentageDifferent):
1220         * Scripts/run-webkit-tests:
1221
1222 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1223
1224         Reviewed by Lars.
1225
1226         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1227
1228         * DumpRenderTree/qt/DumpRenderTree.cpp:
1229
1230 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1231
1232         Reviewed by Lars.
1233
1234         Reworked the QWebSettings API.
1235         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1236
1237         * DumpRenderTree/qt/DumpRenderTree.cpp:
1238
1239 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1240
1241         Reviewed by Lars.
1242
1243         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1244
1245         * DumpRenderTree/qt/jsobjects.cpp:
1246
1247 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1248
1249         Reviewed by Lars Knoll <lars@trolltech.com>.
1250
1251         Add a QWebPage::frameCreated() signal and fix DRT
1252         
1253         The removal of createFrame in QWebPage broke the re-implementation
1254         in DumpRenderTree. Instead emit a frameCreated() signal and
1255         connect to it in DumpRenderTree.
1256         
1257
1258         * DumpRenderTree/qt/DumpRenderTree.cpp:
1259         (WebCore::WebPage::WebPage):
1260         (WebCore::DumpRenderTree::dump):
1261         (WebCore::DumpRenderTree::connectFrame):
1262         * DumpRenderTree/qt/DumpRenderTree.h:
1263
1264 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1265
1266         Reviewed by Lars Knoll <lars@trolltech.com>.
1267
1268         Moved all the event handlers from QWebFrame into QWebPage.
1269         
1270         This cleans up the public API and allows us to remove the
1271         HackWebFrame hack in DumpRenderTree.
1272         
1273
1274         * DumpRenderTree/qt/jsobjects.cpp:
1275         (EventSender::mouseDown):
1276         (EventSender::mouseUp):
1277         (EventSender::mouseMoveTo):
1278
1279 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1280
1281         Reviewed by Mark.
1282
1283         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1284         to prevent the default implementation from popping up messageboxes.
1285
1286         * DumpRenderTree/qt/DumpRenderTree.cpp:
1287         (WebCore::WebPage::javaScriptConfirm):
1288         (WebCore::WebPage::javaScriptPrompt):
1289
1290 2007-11-06  Eric Seidel  <eric@webkit.org>
1291
1292         * Scripts/build-testkjs: build fix... too many $$
1293
1294 2007-11-06  Eric Seidel  <eric@webkit.org>
1295
1296         Reviewed by Mark Rowe.
1297
1298         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1299
1300 2007-11-05  Adam Roben  <aroben@apple.com>
1301
1302         Add support on Windows for WEBKIT_TESTFONTS
1303
1304         This environment variable lets you specify where the fonts to be used
1305         by DumpRenderTree reside. The Qt port is already using this, so I'm
1306         just following their lead.
1307
1308         Reviewed by Darin.
1309
1310         * DumpRenderTree/win/DumpRenderTree.cpp:
1311         (exePath): Refactored code out of initialize().
1312         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1313         DumpRenderTree.resources.
1314         (initialize): Use the new fontsPath function.
1315         (main): Use the new exePath function.
1316         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1317         variable to DRT, like Qt does.
1318
1319 2007-11-05  Mark Rowe  <mrowe@apple.com>
1320
1321         Rubber-stamped by Alp Toker.
1322
1323         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1324
1325         * GtkLauncher/main.cpp:
1326         (goToURLBarText):
1327         (main):
1328
1329 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1330
1331         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1332         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1333
1334         Reviewed by Timothy.
1335
1336         Restrict the range of nightly builds used by the bisect-builds script
1337         based on the version of Safari and the version of Mac OS X being used.
1338
1339         Mac OS X 10.4: Safari 2.0: r11976 or newer
1340         Mac OS X 10.4: Safari 3.0: r19992 or newer
1341
1342         Mac OS X 10.5: Safari 2.0: r19594 or newer
1343         Mac OS X 10.5: Safari 3.0: r25124 or newer
1344
1345         * Scripts/bisect-builds:
1346         (findMacOSXVersion): Added.
1347         (makeNightlyList): Added argument to provide version of Mac OS X.
1348         Restrict range of nightly builds based on Safari and Mac OS X versions.
1349
1350 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1351
1352         Reviewed by Maciej.
1353
1354         - This patch involves several changes, all of them were noticed that
1355         they were needed by the work being done in WebKit to get Drosera and
1356         WebKit working together on Windows.
1357         - The changes are:
1358         1) Added a debugger console for output messages.
1359         2) Drosera now listens for the WebKit server (before, the server would
1360         have to be running before Drosera was started.)
1361         3) Fixed a bug where the WebView started out as 0x0 pixels.
1362         4) Fixed a bug when there is no scope.
1363         5) Added the HTML, JS, and CSS to the project file to make them easy to
1364         find.
1365         6) Made the ServerConnection functions virtual.
1366
1367         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1368         for the WebKit server.
1369         (DebuggerClient::DebuggerClient):
1370         (DebuggerClient::~DebuggerClient):
1371         (DebuggerClient::didFinishLoadForFrame):
1372         (DebuggerClient::serverConnected):
1373         (DebuggerClient::attemptToCreateServerConnection):
1374         * Drosera/win/DebuggerClient.h: Ditto.
1375         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1376         scope.
1377         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1378         (DebuggerDocument::platformValueForScopeVariableNamed):
1379         * Drosera/win/Drosera.cpp:
1380         (_tWinMain): Added a console in debug for output messages.
1381         (Drosera::Drosera): Listen for server.
1382         (Drosera::initUI): The server now Initializes COM.
1383         (Drosera::serverConnected): Part of the listening for the server.
1384         (Drosera::attemptToCreateServerConnection): Ditto.
1385         * Drosera/win/Drosera.h: New interface for listening for the server.
1386         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1387         files to the VS project.
1388         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1389         connection.
1390         (ServerConnection::ServerConnection):
1391         (ServerConnection::attemptToCreateServerConnection):
1392         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1393         methods.
1394         (ServerConnection::serverConnected):
1395
1396 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1397
1398         Reviewed by Maciej.
1399
1400         http://bugs.webkit.org/show_bug.cgi?id=15832
1401         fast/dom/gc-10.html crashes when run alone
1402
1403         Check for !done before using objects that can be already deallocated.
1404
1405         * DumpRenderTree/mac/EditingDelegate.mm:
1406         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1407         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1408         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1409         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1410         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1411         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1412         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1413         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1414         (-[EditingDelegate webViewDidBeginEditing:]):
1415         (-[EditingDelegate webViewDidChange:]):
1416         (-[EditingDelegate webViewDidEndEditing:]):
1417         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1418         (-[EditingDelegate webViewDidChangeSelection:]):
1419         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1420         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1421         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1422         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1423         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1424         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1425         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1426         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1427         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1428         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1429         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1430         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1431         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1432         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1433         (-[FrameLoadDelegate webView:willCloseFrame:]):
1434         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1435         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1436         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1437         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1438         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1439         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1440         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1441         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1442         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1443
1444 2007-11-04  Mark Rowe  <mrowe@apple.com>
1445
1446         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1447         warnings that would otherwise be suppressed due to it being a system header.
1448
1449         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1450
1451 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1452
1453         Rubber stamped by Adam.
1454         
1455         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1456
1457         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1458
1459 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1460
1461         Sort files(...); sections of Xcode project files.
1462
1463         Rubber-stamped by Darin.
1464
1465         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1466         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1467         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1468         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1469
1470 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1471
1472         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1473
1474         Reviewed by Darin.
1475
1476         * Scripts/sort-Xcode-project-file: Added.
1477
1478 2007-11-02  Darin Adler  <darin@apple.com>
1479
1480         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1481
1482 2007-11-02  Darin Adler  <darin@apple.com>
1483
1484         Reviewed by Maciej.
1485
1486         * Scripts/run-sunspider: Pass the "--base" option through.
1487
1488         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1489         the real script do that. Default configuration to Release to match run-sunspider
1490         so we don't end up building Debug just to compare results.
1491
1492 2007-11-01  Adam Roben  <aroben@apple.com>
1493
1494         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1495
1496         Reviewed by Sam.
1497
1498         * Scripts/commit-log-editor: Show all the directories beneath the
1499         source root, instead of just the last one.
1500
1501 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1502
1503         Reviewed by Adam Roben.
1504
1505         Print out an error message when the Windows build fails
1506         and provide guidance on how to find out what went wrong.
1507
1508         * Scripts/build-webkit:
1509         * Scripts/webkitdirs.pm:
1510
1511 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1512
1513         Rubber-stamped by Adam Roben.
1514
1515         Rolled out r27326 - debug CRT seems to cause no problems after all.
1516
1517         * DumpRenderTree/win/DumpRenderTree.vcproj:
1518
1519 2007-10-31  Adam Roben  <aroben@apple.com>
1520
1521         Switch the Debug configuration to using the non-debug CRT
1522
1523         This matches WebKit.
1524
1525         Reviewed by Steve.
1526
1527         * DumpRenderTree/win/DumpRenderTree.vcproj:
1528
1529 2007-10-31  Antti Koivisto  <antti@apple.com>
1530
1531         Reviewed by bdash.
1532         
1533         Disable media tests when doing leak checking on Tiger.
1534         They crash in QuickTime (rdar://problem/5537157).
1535
1536         * Scripts/run-webkit-tests:
1537
1538 2007-10-29  Antti Koivisto  <antti@apple.com>
1539
1540         Reviewed by Maciej.
1541         
1542         Build media support by default on OSX only.
1543
1544         * Scripts/build-webkit:
1545
1546 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1547
1548         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1549         get caught by the pre-commit hooks.
1550
1551 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1552
1553         Reviewed by Adam.
1554
1555         - This is a collection of relatively unrelated changes and cleanups
1556         to Drosera to prepare it for interacting with WebKit.  A lot of these
1557         changes are just correcting mistakes, for example removing included
1558         headers that are no longer needed.
1559
1560         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1561         this will be needed by the DebuggerClient.
1562         (DebuggerDocument::server):
1563         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1564         * Drosera/win/DebuggerClient.cpp: 
1565         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1566         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1567         (DebuggerClient::createWebViewWithRequest): Added comment about its
1568         purpose. 
1569         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1570         declarations.
1571         (DebuggerClient::webViewLoaded): Moved.
1572         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1573         file, since this was the only place it was used.
1574         (cfStringToBSTR):
1575         * Drosera/win/Drosera.h: Cleaned up the includes.
1576         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1577         * Drosera/win/HelperFunctions.h: Removed.
1578
1579 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1580
1581         Reviewed by Adam.
1582
1583         - Small cleanup in the ServerConnection class.
1584
1585         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1586         and added an include.
1587         (ServerConnection::currentFrame):
1588         (ServerConnection::getCallerFrame):
1589         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1590         made a pointer into a COMPtr, and cleaned up the includes.
1591
1592 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1593
1594         Reviewed by John Sullivan.
1595         
1596         - Place the Localizable.strings file in mac or win directories
1597           if that location exists.
1598         - Also look for UI_STRING in .c files.
1599
1600         * Scripts/extract-localizable-strings:
1601
1602 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1603
1604         Reviewed by Adam.
1605
1606         - Set the eol-style to native and made all the line endings the same
1607         so that I avoid messy diffs that show eol changes.
1608
1609         * Drosera/win/ServerConnection.cpp:
1610         (ServerConnection::didParseSource):
1611         (ServerConnection::didEnterCallFrame):
1612         (ServerConnection::willExecuteStatement):
1613         (ServerConnection::willLeaveCallFrame):
1614         (ServerConnection::exceptionWasRaised):
1615
1616 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1617
1618         Reviewed by Adam.
1619
1620         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1621         functionality that could not have existed previously without the new
1622         interfaces.
1623         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1624         from a BSTR to a JSValueRef.
1625         (DebuggerDocument::platformEvaluateScript): Implemented.
1626         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1627         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1628         Implemented.
1629         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1630         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1631         * Drosera/win/ServerConnection.cpp: Added a helper function.
1632         (ServerConnection::getCallerFrame):
1633         * Drosera/win/ServerConnection.h: Added a helper function.
1634
1635 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1636
1637         updated reviewers for my previous changelog.
1638
1639 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1640         Reviewed by Maciej and Adam and Geoff.
1641
1642         - Minor mac-side improvements including moving a function to a more
1643         appropriate location, fixing a warning, and correctly checking
1644         exceptions.
1645
1646         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1647         (DebuggerDocument::willExecuteStatement):
1648         (DebuggerDocument::didEnterCallFrame):
1649         (DebuggerDocument::willLeaveCallFrame):
1650         (DebuggerDocument::windowScriptObjectAvailable):
1651         (DebuggerDocument::callFunctionOnObject):
1652         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1653         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1654         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1655         because it doesn't require the ServerConnection at all.
1656         (NSStringCreateWithJSStringRef): Made an argument const.
1657         (JSValueRefCreateWithNSString): Made an argument const.
1658         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1659         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1660         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1661         * Drosera/mac/ServerConnection.mm: Ditto.
1662         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1663
1664 2007-10-29  Sam Weinig  <sam@webkit.org>
1665
1666         Reviewed by Adam Roben.
1667
1668         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1669
1670         * DumpRenderTree/LayoutTestController.cpp:
1671         (LayoutTestController::LayoutTestController):
1672         (getGlobalFlagCallback):
1673         (setGlobalFlagCallback):
1674         (LayoutTestController::getJSClass):
1675         (LayoutTestController::staticValues):
1676         * DumpRenderTree/LayoutTestController.h:
1677         (LayoutTestController::globalFlag):
1678         (LayoutTestController::setGlobalFlag):
1679
1680 2007-10-29  Darin Adler  <darin@apple.com>
1681
1682         Reviewed by Maciej.
1683
1684         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1685         resolution instead of its default.
1686
1687 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1688
1689         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1690
1691         Reviewed by Mark Rowe.
1692
1693         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1694         was successfully resolved, but this would not show any status because the change had
1695         already been cached in the index using "git add".  The solution is to add an optional
1696         second argument to showStatus() which adds the "--cached" switch to the command.
1697
1698         * Scripts/resolve-ChangeLogs:
1699         (showStatus):
1700
1701 2007-10-28  Eric Seidel  <eric@webkit.org>
1702
1703         Reviewed by Maciej and Geoff, in unison.
1704
1705         * Scripts/run-webkit-tests: remove broken --svg option
1706
1707 2007-10-28  Darin Adler  <darin@apple.com>
1708
1709         Reviewed by Adam.
1710
1711         * Scripts/run-sunspider: Default to "Release" configuration rather than
1712         defaulting to the last configuration used as other scripts do. This can
1713         still be overriden on the command line with "--debug" if there's some
1714         reason to do so. Also fix a typo.
1715
1716         * Scripts/sunspider-compare-results: Fix a typo.
1717
1718 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1719
1720         Reviewed by Adam.
1721
1722         - Implemented the WebScriptDebugListener functions now that the
1723         WebScriptDebugServer exists
1724
1725         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1726         functions.
1727         (ServerConnection::currentFrame):
1728         (ServerConnection::didLoadMainResourceForDataSource):
1729         (ServerConnection::didParseSource):
1730         (ServerConnection::failedToParseSource):
1731         (ServerConnection::didEnterCallFrame):
1732         (ServerConnection::willExecuteStatement):
1733         (ServerConnection::willLeaveCallFrame):
1734         (ServerConnection::exceptionWasRaised):
1735         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1736         members arguments list.
1737
1738 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1739
1740         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1741         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1742
1743         Reviewed by Darin.
1744
1745         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1746         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1747         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1748         file.  Note that it may also be used as a stand-alone script.
1749
1750         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1751         * Scripts/resolve-ChangeLogs: Added.
1752         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1753
1754 2007-10-26  Mark Rowe  <mrowe@apple.com>
1755
1756         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1757         to the Qt port on the assumption that it was an implementation of the cross-platform
1758         LayoutTestController class.  It is not, so it did not need to be changed.
1759
1760         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1761
1762 2007-10-25  Mark Rowe  <mrowe@apple.com>
1763
1764         Reviewed by Maciej.
1765
1766         Fix builds with code coverage enabled.
1767
1768         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1769
1770 2007-10-25  Darin Adler  <darin@apple.com>
1771
1772         Reviewed by Mark Rowe.
1773
1774         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1775         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1776
1777 2007-10-25  Stephanie  <slewis@apple.com>
1778
1779         build Fix
1780
1781         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1782
1783 2007-10-25  Stephanie  <slewis@apple.com>
1784
1785         Reviewed by Mark Rowe, Adam Roben.
1786
1787         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1788
1789         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1790
1791 2007-10-25  Alice Liu  <alice.liu@apple.com>
1792
1793         Reviewed by Adam.
1794
1795         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1796
1797         Moving destructor into platform-specific files
1798         * DumpRenderTree/LayoutTestController.cpp:
1799         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1800         (LayoutTestController::~LayoutTestController):
1801         * DumpRenderTree/qt/jsobjects.cpp:
1802         (LayoutTestController::~LayoutTestController):
1803
1804         LayoutTestController wasn't being destroyed
1805         * DumpRenderTree/win/DumpRenderTree.cpp:
1806         (runTest):
1807
1808         Added declspec
1809         * DumpRenderTree/win/EditingDelegate.h:
1810
1811         Reset certain values on the webview (or related delegate) that might 
1812         have changed while running a test
1813         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1814         (LayoutTestController::~LayoutTestController):
1815
1816 2007-10-25  Adam Roben  <aroben@apple.com>
1817
1818         Make sunspider-compare-results work with relative paths
1819
1820         Reviewed by Sam.
1821
1822         * Scripts/sunspider-compare-results: Convert arguments to absolute
1823         paths before we chdir.
1824
1825 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1826
1827         Reviewed by Sam.
1828
1829         - Implemented server calls now the WebScriptDebugServer exists.
1830         - Also removed no longer needed call to initialize CG.
1831
1832         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1833         automatically now.
1834         (_tWinMain):
1835         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1836         (ServerConnection::ServerConnection):
1837         (ServerConnection::~ServerConnection):
1838         (ServerConnection::pause):
1839         (ServerConnection::resume):
1840         (ServerConnection::stepInto):
1841         (ServerConnection::applicationTerminating):
1842         (ServerConnection::serverConnectionDidDie):
1843         * Drosera/win/ServerConnection.h: Now uses the COM class.
1844
1845 2007-10-24  George Staikos  <staikos@kde.org>
1846
1847         Unbreak Qt build.
1848
1849         * Scripts/build-webkit:
1850
1851 2007-10-24  Adam Roben  <aroben@apple.com>
1852
1853         Remove now-unnecessary call to InitializeCoreGraphics
1854
1855         WebKit takes care of this now.
1856
1857         Reviewed by Ada.
1858
1859         * DumpRenderTree/win/DumpRenderTree.cpp:
1860         (initialize):
1861
1862 2007-10-24  Adam Roben  <aroben@apple.com>
1863
1864         Use WebTextRenderer in DRT
1865
1866         Reviewed by Ada.
1867
1868         * DumpRenderTree/win/DumpRenderTree.cpp:
1869         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1870
1871 2007-10-24  Sven Herzberg  <sven@imendio.com>
1872
1873         Reviewed by Mark Rowe.
1874
1875         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1876         Bug 15614: [GTK] qmake based backends don't build on OS X
1877
1878         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1879         GTK backend on a Mac
1880         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1881         isDarwin() to make it reusable in other places (like the workaround-
1882         for-prebuilt-qmake in build-webkit)
1883
1884 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1885
1886         Refurbish update-webkit script.
1887
1888         Reviewed by Adam.
1889
1890         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1891         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1892         multi-argument version of system() for flexibility and security.  Check for existence
1893         of Internal directory using -d test instead of -x.
1894
1895 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1896
1897         Minor clean-up of prepare-ChangeLog script.
1898
1899         Reviewed by Adam.
1900
1901         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1902         of a string.  Use multi-argument versions of open() and system() for flexibility and
1903         security.
1904
1905 2007-10-24  Alice Liu  <alice.liu@apple.com>
1906
1907         Reviewed by Oliver.
1908
1909         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1910
1911         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1912         replay the saved events when we're still processing the mousedown that starts the drag
1913         * DumpRenderTree/win/EventSender.cpp:
1914         (doMouseMove):
1915         * DumpRenderTree/win/UIDelegate.cpp:
1916         (UIDelegate::doDragDrop):
1917
1918 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1919
1920         Reviewed by Sam, Steve and Darin.
1921
1922         - Stubbed out the WebScriptDebugListener functionality in the Server
1923         Connection class to prepare it for receiving those callbacks.
1924         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1925         and the ServerConnection to not need to be initialized with a server
1926         name, since that is not the way we connect to the WebKit server. 
1927
1928         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1929         no exception.  Now it only loggs when there is an exception
1930         (DebuggerDocument::willExecuteStatement):
1931         (DebuggerDocument::didEnterCallFrame):
1932         (DebuggerDocument::willLeaveCallFrame):
1933         (DebuggerDocument::windowScriptObjectAvailable):
1934         (DebuggerDocument::callFunctionOnObject):
1935         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1936         to be instantiated with a server's name.
1937         (DebuggerClient::DebuggerClient):
1938         (DebuggerClient::didFinishLoadForFrame):
1939         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1940         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1941         a server name.
1942         (Drosera::init):
1943         (Drosera::initServer):
1944         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1945         instantiated with a server's name.
1946         * Drosera/win/ServerConnection.cpp: 
1947         (ServerConnection::ServerConnection): No longer needs a server name
1948         (ServerConnection::~ServerConnection): Only release the global context
1949         if there is one.
1950         (ServerConnection::serverConnectionDidDie): Stub for
1951         IWebScriptDebugListener
1952         (ServerConnection::QueryInterface): ditto
1953         (ServerConnection::AddRef): ditto
1954         (ServerConnection::Release): ditto
1955         (ServerConnection::didLoadMainResourceForDataSource): ditto
1956         (ServerConnection::didParseSource): ditto
1957         (ServerConnection::failedToParseSource): ditto
1958         (ServerConnection::didEnterCallFrame): ditto
1959         (ServerConnection::willExecuteStatement): ditto
1960         (ServerConnection::willLeaveCallFrame): ditto
1961         (ServerConnection::exceptionWasRaised): ditto
1962         * Drosera/win/ServerConnection.h: Stubbed out the
1963         IWebScriptDebugListener functions, and this class no longer needs to be
1964         instantiated with a server name.
1965
1966 2007-10-24  Lars Knoll  <lars@trolltech.com>
1967
1968         Reviewed by Simon.
1969
1970         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1971
1972         * DumpRenderTree/qt/jsobjects.h:
1973
1974 2007-10-24  Lars Knoll  <lars@trolltech.com>
1975
1976         Reviewed by Simon.
1977
1978         add another command.
1979
1980         * DumpRenderTree/qt/jsobjects.cpp:
1981         (TextInputController::doCommand):
1982
1983 2007-10-24  Lars Knoll  <lars@trolltech.com>
1984
1985         Reviewed by Simon.
1986
1987         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1988
1989         * DumpRenderTree/qt/jsobjects.cpp:
1990         (EventSender::keyDown):
1991         * DumpRenderTree/qt/jsobjects.h:
1992
1993 2007-10-24  Lars Knoll  <lars@trolltech.com>
1994
1995         Reviewed by Simon.
1996
1997         implement eventSender.keyDown().
1998
1999         * DumpRenderTree/qt/jsobjects.cpp:
2000         (EventSender::keyDown):
2001
2002 2007-10-24  Lars Knoll  <lars@trolltech.com>
2003
2004         Reviewed by Simon.
2005
2006         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2007
2008         * DumpRenderTree/qt/DumpRenderTree.cpp:
2009         (WebCore::DumpRenderTree::DumpRenderTree):
2010         (WebCore::DumpRenderTree::initJSObjects):
2011         * DumpRenderTree/qt/jsobjects.cpp:
2012         (TextInputController::doCommand):
2013
2014 2007-10-24  Lars Knoll  <lars@trolltech.com>
2015
2016         Reviewed by Simon.
2017
2018         first bit of implementation for the textinputcontroller.
2019
2020         * DumpRenderTree/qt/DumpRenderTree.cpp:
2021         (WebCore::DumpRenderTree::DumpRenderTree):
2022         * DumpRenderTree/qt/DumpRenderTree.h:
2023         * DumpRenderTree/qt/jsobjects.cpp:
2024         (TextInputController::TextInputController):
2025         (TextInputController::doCommand):
2026         * DumpRenderTree/qt/jsobjects.h:
2027
2028 2007-10-24  Lars Knoll  <lars@trolltech.com>
2029
2030         Reviewed by Simon.
2031
2032         make the man webpage believe it has focus, so the editing tests work correctly.
2033
2034         * DumpRenderTree/qt/DumpRenderTree.cpp:
2035         (WebCore::DumpRenderTree::DumpRenderTree):
2036
2037 2007-10-24  Lars Knoll  <lars@trolltech.com>
2038
2039         Reviewed by Simon.
2040
2041         implement layoutTestController.dumpEditingCallbacks() correctly.
2042
2043         * DumpRenderTree/qt/DumpRenderTree.cpp:
2044         (WebCore::DumpRenderTree::DumpRenderTree):
2045         * DumpRenderTree/qt/jsobjects.cpp:
2046         (LayoutTestController::reset):
2047         (LayoutTestController::dumpEditingCallbacks):
2048
2049 2007-10-24  Lars Knoll  <lars@trolltech.com>
2050
2051         Reviewed by Simon.
2052
2053         Implement support for testing editing.
2054
2055         * DumpRenderTree/qt/DumpRenderTree.cpp:
2056         (WebCore::DumpRenderTree::DumpRenderTree):
2057
2058 2007-10-23  Sam Weinig  <sam@webkit.org>
2059
2060         Check for null BSTR that can be passed to the UIDelegate methods
2061         from javascript null and undefined.  Fixes a failing test case on
2062         Windows (fast/dom/Window/alert-undefined.html)
2063
2064         Reviewed by Eric Seidel.
2065
2066         * DumpRenderTree/win/UIDelegate.cpp:
2067         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2068         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2069         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2070         (UIDelegate::webViewAddMessageToConsole):
2071
2072 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2073
2074         Reviewed by Darin.
2075         
2076         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2077
2078         * Scripts/build-testkjs:
2079
2080 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2081
2082         Reviewed by Darin.
2083
2084         - add wrapper that finds the right copy of testkjs
2085         
2086         * Scripts/sunspider-compare-results: Added.
2087
2088 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2089
2090         Reviewed by Sam.
2091
2092         - After talking with Steve I now see that the WebKit server must be
2093         running for DCOM to create the distributed objects, which makes sense
2094         and currently WebKit only allows one instance to be running at a time
2095         which avoids accidentally connecting to the wrong server
2096         - In light of this I have removed the code for the attach box and
2097         NotificationServer and known server names, since they are all extranious
2098         now.
2099
2100         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2101         names.
2102         (_tWinMain): Uses init instead of initUI.
2103         (droseraWndProc): No longer creats an attach dialog box.
2104         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2105         it's not manditory to call init before doing COM stuff.
2106         (Drosera::init): calls initUI and will call attach when the
2107         functionality exists. 
2108         (Drosera::initUI): Has changed very little.
2109         (Drosera::attach): Changed the signature to reflect that we no longer
2110         need the dictionary of known server names.
2111         * Drosera/win/Drosera.h: Removed notification classes and known server
2112         names.  Also renamed and moved some functions.
2113         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2114         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2115         headers to the resources folder. 
2116         * Drosera/win/resource.h: Removed the Attach box.
2117
2118 2007-10-22  Adam Roben  <aroben@apple.com>
2119
2120         Windows build fix
2121
2122         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2123
2124 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2125
2126         - Removed a leak that was fixed.
2127
2128         * Scripts/run-webkit-tests:
2129
2130 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2131
2132         Reviewed by Darin.
2133
2134         - Changed the Client so that the DebuggerDocument now own the
2135         ServerConnection.  This simplifies ownership and cleanup. 
2136
2137         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2138         ServerConnection.
2139         (DebuggerClient::initWithServerName):
2140         (DebuggerClient::didFinishLoadForFrame):
2141         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2142         ServerConnection.
2143         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2144         until after we have a server which we are attached to.
2145         (Drosera::initUI):
2146         (Drosera::attach):
2147         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2148         out previously.
2149
2150 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2151
2152         Reviewed by Nikolas.
2153
2154         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2155
2156         * Scripts/run-javascriptcore-tests:
2157
2158 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2159
2160         Reviewed by Nikolas.
2161
2162         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2163
2164         * Scripts/build-drosera:
2165         * Scripts/build-dumprendertree:
2166         * Scripts/build-testkjs:
2167         * Scripts/build-webkit:
2168         * Scripts/run-javascriptcore-tests:
2169         * Scripts/run-sunspider:
2170         * Scripts/run-webkit-tests:
2171         * Scripts/webkitdirs.pm:
2172
2173 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2174
2175         Reviewed by Mark Rowe.
2176         
2177         Fix for local database support after r26879
2178         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2179
2180         * Scripts/build-webkit:
2181
2182 2007-10-22  Holger Freyther  <zecke@selfish.org>
2183
2184         Reviewed by Simon Hausmann <hausmann@kde.org>.
2185
2186         - Do not build testkjs as an application bundle. This is
2187         needed for run-javascriptcore-tests on OSX.
2188         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2189         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2190         as we do not have -rpath on OSX.
2191
2192         * DumpRenderTree/qt/DumpRenderTree.pro:
2193         * Scripts/run-webkit-tests:
2194
2195 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2196
2197         Reviewed by aroben.
2198
2199         Fix support for Signed-off-by detection in prepare-ChangeLog
2200         --git-commit. The Signed-off-by tag does not appear in the header
2201         but usually at the end.
2202
2203         * Scripts/prepare-ChangeLog:
2204
2205 2007-10-21  Mark Rowe  <mrowe@apple.com>
2206
2207         Reviewed by Eric.
2208
2209         Fix run-javascriptcore-tests for Gtk.
2210
2211         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2212
2213 2007-10-20  Eric Seidel  <eric@webkit.org>
2214
2215         Reviewed by aroben.
2216
2217         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2218
2219 2007-10-20  Eric Seidel  <eric@webkit.org>
2220
2221         Reviewed by darin.
2222         
2223         Add improved argument handling to run-sunspider, including
2224         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2225         Also re-factor code into subroutines
2226
2227         * Scripts/build-dumprendertree: removed bogus comments
2228         * Scripts/build-testkjs: Added.
2229         * Scripts/run-javascriptcore-tests: use build-testkjs
2230         * Scripts/run-sunspider: improved argument handling, abstraction
2231         * Scripts/run-webkit-tests: improved abstraction
2232
2233 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2234
2235         Not reviewed, Windows build fix.
2236
2237         * DumpRenderTree/win/EventSender.cpp:
2238         (keyDownCallback):
2239
2240 2007-10-20  Darin Adler  <darin@apple.com>
2241
2242         Reviewed by Tim Hatcher.
2243
2244         - http://bugs.webkit.org/show_bug.cgi?id=15544
2245           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2246           not rely on Apple-specific key codes
2247
2248         * DumpRenderTree/mac/EventSendingController.mm:
2249         (-[EventSendingController keyDown:withModifiers:]):
2250         Added named key "rightArrow". Later we could have a whole table of these.
2251         Also tweaked modifiers code a little.
2252
2253         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2254
2255 2007-10-19  Darin Adler  <darin@apple.com>
2256
2257         Reviewed by Eric.
2258
2259         - http://bugs.webkit.org/show_bug.cgi?id=15566
2260           possible fix for leak seen in DumpRenderTree
2261
2262         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2263         Delete the item if it's not put on the queue, since the caller has
2264         no way of knowing that. Would be better to have the parameter type
2265         be auto_ptr to express the fact that we take ownership.
2266
2267         - unrelated change
2268
2269         * Drosera/mac/main.m: Add missing include.
2270
2271 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2272
2273         Reviewed by Adam.
2274
2275         - This change should be identical but for some reason was not working
2276         on my machine.
2277
2278         * Scripts/prepare-ChangeLog:
2279
2280 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2281
2282         Reviewed by Oliver and Tim.
2283
2284         - Made use of RetainPtr to avoid retain and release issues and moved the
2285         log function to DebuggerDocumentPlatform, which seems to be a more
2286         logical place for it to live.
2287         - Also moved knownServers from the ServerConnection to
2288         DebuggerApplication to match the Windows code and because it makes sense
2289         that a connection knows its own server but not all of them.
2290
2291         * Drosera/mac/DebuggerClient.h: Moved the log function to
2292           DebuggerDocumentPlatform.
2293         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2294           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2295           call for the server name up from the ServerConnection class.
2296         (-[DebuggerClient dealloc]):
2297         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2298           for the server name up from the ServerConnection.
2299         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2300         (DebuggerDocument::platformPause):
2301         (DebuggerDocument::platformResume):
2302         (DebuggerDocument::platformStepInto):
2303         (DebuggerDocument::platformEvaluateScript):
2304         (DebuggerDocument::getPlatformCurrentFunctionStack):
2305         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2306         (DebuggerDocument::platformValueForScopeVariableNamed):
2307         (DebuggerDocument::platformLog): Log directly from here. No need to call
2308           DebuggerClient.
2309         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2310           way I see it, a ServerConnection should only know about its connection
2311           and the group of all possible servers should be kept by the
2312           application.
2313         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2314           currentServerName, it makes sense that the connection should know that
2315           name.
2316         (-[ServerConnection currentServerName]):
2317
2318 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2319
2320         Reviewed by Adam.
2321
2322         - Integrated changes from mac drosera.  Recently I've encapsulated
2323         out the server connection object from the rest of Drosera because
2324         it is very platform dependent right now and RPC is not implemented on
2325         windows.  This functionality, of communicating with the WebKit server
2326         is the next area I will be focusing on in Windows.
2327
2328         - Other changes and cleanup were made to organize the code and add notes
2329         on which parts still need work.  Also some mac code is added and
2330         commented out, to act as pseudocode for the logic of those parts.
2331
2332         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2333           pointer.
2334         * Drosera/config.h: Added whitespace.
2335         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2336           these files got moved into Drosera.h/cpp
2337         * Drosera/win/DebuggerApplication.h: Removed.
2338         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2339           happened here to better match the logic flow of the same code on the 
2340           mac side and to use the new ServerConnection class.
2341         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2342         (DebuggerClient::initWithServerName): Initializer that will set up the
2343           class to use a ServerConnection object.  This was necessary so I could
2344           create a DebuggerClient without having to initilaize it at
2345           construction.
2346         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2347           will be the UIDelegate and FrameLoadDelegate.
2348         (DebuggerClient::AddRef): For IUnknown.
2349         (DebuggerClient::Release): For IUnknown.
2350         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2351           this still needs to set the global context of the server, but
2352           IWebFrame does not have an accessor for the global context yet. 
2353         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2354           this is a pass through for the same function in the document.
2355         (DebuggerClient::didReceiveTitle): Unimplemented part of
2356           FrameLoadDelegate this would change the title of the window.
2357         (DebuggerClient::createWebViewWithRequest): Part of the
2358           FrameLoadDelegate.  This is about new windows via Window.open() and
2359           how their delegates are set.
2360         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2361           UIDelegate.  Just a debug function for printing messages.
2362         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2363           because the Client should be the UIDelegate and FrameLoadDelegate
2364           to match the delegates on mac.
2365         (DebuggerClient::webViewLoaded): Added accessor method.
2366         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2367           forgotten to add this file before.  This is where the platform
2368           dependent versions of the Documents functions live. Most of these are
2369           unimplemented because some piece of functionality does not exist on
2370           Windows yet.
2371         (DebuggerDocument::platformPause):
2372         (DebuggerDocument::platformResume):
2373         (DebuggerDocument::platformStepInto):
2374         (DebuggerDocument::platformEvaluateScript):
2375         (DebuggerDocument::getPlatformCurrentFunctionStack):
2376         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2377         (DebuggerDocument::platformValueForScopeVariableNamed):
2378         (DebuggerDocument::platformLog):
2379         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2380           responsibilities becaue they belong in the Client. Also I laid the
2381           groundwork for attaching Drosera to a WebKit process
2382         (attachWndProc): Now if a server is selected the Client becomes it's
2383           delegate.
2384         (Drosera::Drosera): Added the construction of the Client and dictionary
2385           of server names. 
2386         (Drosera::initUI): This is no longer the delegates, the Client is.
2387         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2388           state. 
2389         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2390           notification registration when it's possible to implement.
2391         (Drosera::serverLoaded): Ditto
2392         (Drosera::serverUnloaded): Ditto
2393         (Drosera::attach): Attach Drosera to the WebKit server.
2394         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2395         (Drosera::getInst): 
2396         (Drosera::setInst):
2397         (Drosera::knownServers):
2398         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2399           and added the ServerConnection.
2400         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2401         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2402           Most of the functions are completely unimlemented because they cannot
2403           connect with the WebKit server, because one does not exist on Windows
2404           yet.
2405         (ServerConnection::initWithServerName): 
2406         (ServerConnection::~ServerConnection):
2407         (ServerConnection::setGlobalContext):
2408         (ServerConnection::pause):
2409         (ServerConnection::resume):
2410         (ServerConnection::stepInto):
2411         (ServerConnection::switchToServerNamed):
2412         (ServerConnection::applicationTerminating):
2413         (ServerConnection::serverConnectionDidDie):
2414         (ServerConnection::currentFrame):
2415         * Drosera/win/ServerConnection.h: Added. Ditto.
2416         (ServerConnection::ServerConnection):
2417
2418 2007-10-19  Alice Liu  <alice.liu@apple.com>
2419
2420         Reviewed by Darin.
2421
2422         Fix for these broken layout tests on Windows:
2423         
2424         fast/forms/focus-selection-input.html
2425         fast/forms/focus-selection-textarea.html
2426         fast/forms/select-accesskey.html
2427         
2428         * DumpRenderTree/win/EventSender.cpp:
2429         (keyDownCallback):
2430         correct the VK code for alt key.
2431         
2432 2007-10-19  Eric Seidel  <eric@webkit.org>
2433
2434         Reviewed by Mark Rowe.
2435         
2436         Make the GtkLauncher code slightly more readable.
2437
2438         * GtkLauncher/main.cpp:
2439         (setupMainMenu): Added.
2440         (setupMainWindowUI): Added.
2441         (main):
2442
2443 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2444
2445         Rubber stamped by Adam.
2446         
2447         - don't delay-load WebKit in DumpRenderTree.
2448
2449         * DumpRenderTree/win/DumpRenderTree.vcproj:
2450
2451 2007-10-18  Dan Bernstein  <mitz@apple.com>
2452
2453         Reviewed by Adam Roben.
2454
2455         - fix <rdar://problem/5313523>
2456         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2457
2458         * DumpRenderTree/mac/DumpRenderTree.mm:
2459         (dump): Changed to use _responseMIMEType.
2460
2461 2007-10-17  Adam Roben  <aroben@apple.com>
2462
2463         Make it possible to have Windows-specific tests and results
2464
2465         When searching for tests to run and the Skipped file, we will only
2466         look in platform/win and the cross-platform directory. When looking
2467         for expected results, we will look in platform/win, then
2468         platform/mac-leopard, then platform/mac, then finally the
2469         cross-platform directory.
2470
2471         Reviewed by Sam.
2472
2473         * Scripts/run-webkit-tests:
2474         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2475         searching in the cross-platform directory.
2476         (sub buildPlatformHierarchy): Removed some unneeded calls to
2477         dirname/basename.
2478
2479 2007-10-17  Adam Roben  <aroben@apple.com>
2480
2481         Add back the call to register WebKit that we had before WebKitInitializer existed
2482
2483         This is needed to ensure that the right WebKit is used when
2484         instantiating COM objects.
2485
2486         Reviewed by Oliver.
2487
2488         * DumpRenderTree/win/debug_internal.vsprops: Define
2489         DEBUG_WEBKIT_HAS_SUFFIX.
2490         * DumpRenderTree/win/DumpRenderTree.cpp:
2491         (initialize):
2492
2493 2007-10-17  Adam Roben  <aroben@apple.com>
2494
2495         Import File::Basename in webkitdirs since we use it
2496
2497         * Scripts/webkitdirs.pm:
2498
2499 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2500
2501         - Updated the tiger leaks list to make the internal bots green.
2502
2503         * Scripts/run-webkit-tests:
2504
2505 2007-10-17  Adam Roben  <aroben@apple.com>
2506
2507         Build fix for VC++ Express
2508
2509         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2510         and ole32.lib.
2511
2512 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2513
2514         Reviewed by Sam.
2515
2516         - Minor mac improvements based on observations I made while implementing the
2517         Windows code.
2518
2519         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2520         then hand it to the Client who will retain it, it should just be the client who
2521         creates and owns the server.
2522         (-[DebuggerApplication attach:]):
2523         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2524         * Drosera/mac/DebuggerClient.mm: Creates the server.
2525         (-[DebuggerClient initWithServerName:]):
2526         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2527         can instead forward declare what it needs.
2528
2529 2007-10-16  Darin Adler  <darin@apple.com>
2530
2531         Reviewed by Geoff Garen.
2532
2533         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2534         want to turn failing tests into platform-specific test results. Also did a
2535         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2536         would take the type of results into account only some of the time.
2537
2538 2007-10-16  Adam Roben  <aroben@apple.com>
2539
2540         Add a new nightly launcher script for Windows
2541
2542         This new script is for versions of Safari that don't delay-load
2543         WebKit. I had to make FindSafari be able to print out the nightly
2544         launcher script on stdout because Windows shell scripts can't capture
2545         the output from a command into an environment variable.
2546
2547         Reviewed by Steve.
2548
2549         * FindSafari/FindSafari.cpp:
2550         (_tmain): Added /printSafariLauncher option.
2551         * Scripts/run-webkit-nightly.cmd: Added.
2552
2553 2007-10-16  Adam Roben  <aroben@apple.com>
2554
2555         Replace WebKitInitializer with FindSafari
2556
2557         We now rely on setting the PATH environment variable to tell Windows
2558         where to find WebKit and its dependencies (similar to
2559         DYLD_FRAMEWORK_PATH on Mac).
2560
2561         This change also make DumpRenderTree no longer delay-load WebKit.
2562
2563         Reviewed by Sam.
2564
2565         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2566         FindSafari.
2567         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2568         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2569         WebKitInitializer, don't delay-load WebKit.
2570         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2571         * Scripts/run-webkit-tests: Ditto.
2572         * Scripts/webkitdirs.pm:
2573         (sub setPathForRunningWebKitApp): Added.
2574         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2575         * WebKitInitializer/WebKitInitializer.h: Removed.
2576         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2577         * WebKitInitializer/debug.vsprops: Removed.
2578         * WebKitInitializer/debug_internal.vsprops: Removed.
2579         * WebKitInitializer/release.vsprops: Removed.
2580
2581 2007-10-16  Adam Roben  <aroben@apple.com>
2582
2583         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2584
2585         http://bugs.webkit.org/show_bug.cgi?id=15532
2586
2587         FindSafari simply prints the location of an installed Safari.exe on
2588         stdout.
2589
2590         Reviewed by Darin.
2591
2592         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2593         (getStringValue):
2594         (getWebViewCLSID):
2595         (getInstalledWebKitDirectory):
2596         (_tmain):
2597         * FindSafari/FindSafari.vcproj: Added.
2598         * Scripts/webkitdirs.pm:
2599         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2600
2601 2007-10-16  Adam Roben  <aroben@apple.com>
2602
2603         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2604
2605         Reviewed by Kevin McCullough.
2606
2607         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2608         when referring to WebKit.dll.
2609         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2610         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2611         * DumpRenderTree/win/release.vsprops: Ditto.
2612         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2613         never have a _debug suffix on WebKit.dll.
2614         * WebKitInitializer/WebKitInitializer.cpp:
2615         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2616         specified.
2617         * WebKitInitializer/debug_internal.vsprops: Added
2618         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2619
2620 2007-10-16  Darin Adler  <darin@apple.com>
2621
2622         Reviewed by Adele.
2623
2624         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2625         Remove now-unneeded control/alt key hack; the tests have been updated.
2626
2627 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2628
2629         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2630         one of the leaks was fixed between that revision and the bot's previous version of
2631         leopard.
2632
2633         * Scripts/run-webkit-tests:
2634
2635 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2636
2637         Reviewed by Tim.
2638
2639         - I encapsulated out the server connecton functionality because it is a specific part
2640         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2641         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2642         Windows.  So the majority of this patch is moving preexisting functionality.
2643
2644         - Also I removed the prefix header and changed to use config.h because it is more
2645         standard on how we use config.h in windows and it didn't make much sense to keep
2646         the prefix header and the config.h
2647
2648         * Drosera/DebuggerDocument.cpp:
2649         (DebuggerDocument::DebuggerDocument):
2650         * Drosera/DebuggerDocument.h:
2651         * Drosera/config.h:
2652         * Drosera/mac/DebuggerApplication.mm:
2653         (-[DebuggerApplication attach:]):
2654         * Drosera/mac/DebuggerClient.h:
2655         * Drosera/mac/DebuggerClient.mm:
2656         (-[DebuggerClient initWithServerConnection:]):
2657         (-[DebuggerClient dealloc]):
2658         (-[DebuggerClient windowDidLoad]):
2659         (-[DebuggerClient windowWillClose:]):
2660         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2661         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2662         * Drosera/mac/DebuggerDocumentPlatform.mm:
2663         (DebuggerDocument::platformPause):
2664         (DebuggerDocument::platformResume):
2665         (DebuggerDocument::platformStepInto):
2666         (DebuggerDocument::platformEvaluateScript):
2667         (DebuggerDocument::getPlatformCurrentFunctionStack):
2668         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2669         (DebuggerDocument::platformValueForScopeVariableNamed):
2670         (DebuggerDocument::platformLog):
2671         * Drosera/mac/Drosera.pch: Removed.
2672         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2673         * Drosera/mac/ServerConnection.h: Added.
2674         * Drosera/mac/ServerConnection.mm: Added.
2675         (-[ServerConnection initWithServerName:]):
2676         (-[ServerConnection dealloc]):
2677         (-[ServerConnection setGlobalContext:]):
2678         (-[ServerConnection pause]):
2679         (-[ServerConnection resume]):
2680         (-[ServerConnection stepInto]):
2681         (-[ServerConnection switchToServerNamed:]):
2682         (-[ServerConnection applicationTerminating:]):
2683         (-[ServerConnection serverConnectionDidDie:]):
2684         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2685         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2686         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2687         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2688         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2689         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2690         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2691         (-[ServerConnection currentFrame]):
2692         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2693         (-[ServerConnection knownServers]):
2694
2695 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2696
2697         Reviewed by Eric.
2698
2699         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2700           Script to automatically search nightly builds for regressions (bisect-builds)
2701
2702         * Scripts/bisect-builds: Added.
2703
2704 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2705
2706         Reviewed by Darin.
2707
2708         - New JavaScript benchmark
2709         http://bugs.webkit.org/show_bug.cgi?id=15515
2710
2711         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2712         current development or release build of JavaScriptCore.
2713
2714 2007-10-15  Mark Rowe  <mrowe@apple.com>
2715
2716         Reviewed by Sam.
2717
2718         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2719
2720         * Scripts/webkitdirs.pm:
2721         - Change checkArgv to remove the options from @ARGV to prevent
2722         them from interfering with further option processing.
2723         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2724         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2725         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2726         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2727
2728 2007-10-15  Darin Adler  <darin@apple.com>
2729
2730         Reviewed by Sam.
2731
2732         - added logging of window.prompt and window.confirm
2733
2734         * DumpRenderTree/mac/UIDelegate.mm:
2735         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2736         Implement the recommended delegate rather than the deprecated one.
2737         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2738         Added.
2739         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2740         Added.
2741
2742         * DumpRenderTree/win/UIDelegate.h:
2743         * DumpRenderTree/win/UIDelegate.cpp:
2744         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2745         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2746         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2747         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2748
2749 2007-10-15  Alice Liu  <alice.liu@apple.com>
2750
2751         Reviewed by Sam Weinig.
2752
2753         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2754
2755         * DumpRenderTree/win/DumpRenderTree.cpp:
2756         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2757         (main): allocate the global policy delegate for DRT's custom use
2758         * DumpRenderTree/win/DumpRenderTree.vcproj:
2759         Adding files to project
2760         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2761         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2762         (LayoutTestController::setCustomPolicyDelegate):
2763         set the webview's policy delegate to DRT's custom one if the test requests it.
2764         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2765         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2766         (PolicyDelegate::PolicyDelegate):
2767         (PolicyDelegate::QueryInterface):
2768         (PolicyDelegate::AddRef):
2769         (PolicyDelegate::Release):
2770         (PolicyDelegate::decidePolicyForNavigationAction):
2771         * DumpRenderTree/win/PolicyDelegate.h: Added.
2772         (PolicyDelegate::decidePolicyForNewWindowAction):
2773         (PolicyDelegate::decidePolicyForMIMEType):
2774         (PolicyDelegate::unableToImplementPolicyWithError):
2775
2776 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2777
2778         Reviewed by Mark.
2779
2780         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2781         when querying for QMAKE_MKSPECS.
2782
2783 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2784
2785         Reviewed by Adam Roben.
2786         
2787         Fix run-webkit-tests is too greedy calculating platform hierarchy
2788         http://bugs.webkit.org/show_bug.cgi?id=15465
2789         
2790         Fix run-webkit-tests being too greedy in trying to split the platform name up
2791         causing it to try and find tests in every directory above the first "-" in the
2792         path to the LayoutTests
2793
2794         * Scripts/run-webkit-tests:
2795
2796 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2797
2798         Reviewed by Darin.
2799
2800         http://bugs.webkit.org/show_bug.cgi?id=15006
2801         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2802         to reduce code duplication.
2803
2804         * Scripts/build-webkit:
2805         * Scripts/webkitdirs.pm:
2806         buildQMakeProject() renamed to buildQMakeQtProject().
2807         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2808         unused $colorize has been removed.
2809
2810 === Start merge of feature-branch 2007-10-12 ===
2811
2812 2007-10-08  Eric Seidel  <eric@webkit.org>
2813
2814         Reviewed by Mark Rowe.
2815
2816         * Scripts/build-webkit: add --help, remove unused --color
2817
2818 2007-10-07  Eric Seidel  <eric@webkit.org>
2819
2820         Reviewed by darin.
2821
2822         * Drosera/mac/DebuggerDocumentPlatform.mm:
2823         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2824
2825 2007-10-03  Rob Buis  <buis@kde.org>
2826
2827         Reviewed by Olliej.
2828
2829         Adapt to changed location of Ahem font.
2830
2831         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2832
2833 2007-10-02  Eric Seidel  <eric@webkit.org>
2834
2835         Reviewed by Adam Roben.
2836         
2837         Make pixel tests more useful!
2838         Finally fix the image diff 0.00% mystery problem
2839         Highlight any image differences in the image diff.
2840         Add a link from image diffs back to original test file.
2841
2842         * DumpRenderTree/mac/ImageDiff.m:
2843         (compareImages): highlight any differences
2844         (computePercentageDifferent): round to two decimal places
2845         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2846
2847 2007-10-02  Eric Seidel  <eric@webkit.org>
2848
2849         Reviewed by Alexey Proskuryakov.
2850
2851         * Scripts/run-webkit-tests: print the % image difference on main results page
2852
2853 2007-10-02  Mark Rowe  <mrowe@apple.com>
2854
2855         Reviewed by Oliver.
2856
2857         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2858
2859         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2860         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2861
2862 2007-10-01  Mark Rowe  <mrowe@apple.com>
2863
2864         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2865
2866 2007-09-25  Eric Seidel  <eric@webkit.org>
2867
2868         Reviewed by Mark Rowe.
2869         
2870         DerivedSources.make was finding "ENABLE_SVG" in the string
2871         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2872         quite correctly.
2873
2874         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2875
2876 2007-09-25  Mark Rowe  <mrowe@apple.com>
2877
2878         Rubber-stamped by Eric.
2879
2880         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2881         This makes it possible to automate nightly builds for the feature-branch.
2882
2883 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2884
2885         Rubber stamped by Mark.
2886
2887         Enable svg experimental features as default here in feature-branch.
2888
2889         * Scripts/build-webkit:
2890
2891 2007-06-29  Antti Koivisto  <antti@apple.com>
2892
2893         Reviewed by Weinig.
2894         
2895         Add VIDEO flag for timed media features
2896
2897         * Scripts/build-webkit
2898         
2899 === End merge of feature-branch 2007-10-12 ===
2900
2901 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2902
2903         Reviewed by Darin.
2904
2905         - Updated rational for the leaks list to be more clear.
2906
2907         * Scripts/run-webkit-tests:
2908
2909 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2910
2911         Rubber Stamp by Sam.
2912
2913         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2914         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2915
2916         * Scripts/run-webkit-tests:
2917
2918 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2919
2920         Reviewed by Lars.
2921
2922         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2923         includes are needed for INT_MAX, std::auto_ptr and the like.
2924
2925         * DumpRenderTree/qt/main.cpp:
2926
2927 2007-10-09  Lars Knoll  <lars@trolltech.com>
2928
2929         Reviewed by Simon.
2930
2931         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2932
2933         * DumpRenderTree/qt/jsobjects.cpp:
2934         (LayoutTestController::encodeHostName):
2935         (LayoutTestController::decodeHostName):
2936         * DumpRenderTree/qt/jsobjects.h:
2937
2938 2007-10-09  Lars Knoll  <lars@trolltech.com>
2939
2940         Reviewed by Simon.
2941
2942         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2943
2944         * DumpRenderTree/qt/DumpRenderTree.cpp:
2945         (WebCore::WebPage::createFrame):
2946         (WebCore::DumpRenderTree::DumpRenderTree):
2947         (WebCore::DumpRenderTree::titleChanged):
2948         * DumpRenderTree/qt/DumpRenderTree.h:
2949         * DumpRenderTree/qt/jsobjects.cpp:
2950         (LayoutTestController::reset):
2951         * DumpRenderTree/qt/jsobjects.h:
2952
2953 2007-10-09  Lars Knoll  <lars@trolltech.com>
2954
2955         Reviewed by Simon.
2956
2957         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2958
2959         * DumpRenderTree/qt/DumpRenderTree.h:
2960         * DumpRenderTree/qt/jsobjects.cpp:
2961         (LayoutTestController::clearBackForwardList):
2962         * DumpRenderTree/qt/jsobjects.h:
2963
2964 2007-10-09  Lars Knoll  <lars@trolltech.com>
2965
2966         Reviewed by Simon.
2967
2968         make --git-reviewer work again.
2969
2970         * Scripts/prepare-ChangeLog:
2971
2972 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2973
2974         Rubber stamped by Eric.
2975
2976         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2977         show the current link inside the statusbar.
2978         This shows how to make use of this signal and allows to easily test
2979         http://bugs.webkit.org/show_bug.cgi?id=15299.
2980
2981         * GtkLauncher/main.cpp:
2982         (hoveringOverLink):
2983         (main):
2984
2985 2007-10-05  Lars Knoll  <lars@trolltech.com>
2986
2987         add proper error messages to the FrameLoaderClient.
2988         Implement ChromeClientQt::closeWindowSoon and
2989         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2990         Some fixes in DRT to make it work correctly with multiple windows.
2991
2992         Reviewed by Maciej.
2993
2994         * DumpRenderTree/qt/DumpRenderTree.cpp:
2995         (WebCore::DumpRenderTree::DumpRenderTree):
2996         (WebCore::DumpRenderTree::createWindow):
2997         (WebCore::DumpRenderTree::windowCount):
2998         * DumpRenderTree/qt/DumpRenderTree.h:
2999         * DumpRenderTree/qt/jsobjects.cpp:
3000         (LayoutTestController::maybeDump):
3001         (LayoutTestController::windowCount):
3002         * DumpRenderTree/qt/jsobjects.h:
3003
3004 2007-10-05  Lars Knoll  <lars@trolltech.com>
3005
3006         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3007         Add support for layoutTextController.setCanOpenWindows() to DRT
3008         fixing another 2 test cases in fast/dom/Window.
3009
3010         Reviewed by Maciej.
3011
3012         * DumpRenderTree/qt/DumpRenderTree.cpp:
3013         (WebCore::WebPage::WebPage):
3014         (WebCore::WebPage::createWindow):
3015         (WebCore::DumpRenderTree::resetJSObjects):
3016         (WebCore::DumpRenderTree::createWindow):
3017         * DumpRenderTree/qt/DumpRenderTree.h:
3018         * DumpRenderTree/qt/DumpRenderTree.pro:
3019         * DumpRenderTree/qt/jsobjects.cpp:
3020         (LayoutTestController::LayoutTestController):
3021         (LayoutTestController::reset):
3022         * DumpRenderTree/qt/jsobjects.h:
3023         * DumpRenderTree/qt/main.cpp:
3024         * DumpRenderTree/qt/testplugin.cpp: Added.
3025         * DumpRenderTree/qt/testplugin.h: Added.
3026
3027 2007-10-04  Sam Weinig  <sam@webkit.org>
3028
3029         Rubber stamped by Adam.
3030
3031         Remove empty directories.
3032
3033         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3034         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3035
3036 2007-10-03  Darin Adler  <darin@apple.com>
3037
3038         Reviewed by Adam.
3039
3040         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3041         we find the internal libraries in the libraries directory. This
3042         is helpful for Safari team engineers at Apple.
3043
3044 2007-10-03  Adam Roben  <aroben@apple.com>
3045
3046         Update the location of AHEM___.TTF after r25968
3047
3048         Reviewed by Sam.
3049
3050         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3051
3052 2007-10-03  Alp Toker  <alp@atoker.com>
3053
3054         Reviewed by Adam.
3055
3056         http://bugs.webkit.org/show_bug.cgi?id=14726
3057         [gtk] API design. Mapping the WebView delegates to signals.
3058
3059         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3060
3061         * GtkLauncher/main.cpp:
3062         (goToURLBarText):
3063         (titleChanged):
3064         (progressChanged):
3065         (menuMainBackCallback):
3066         (menuMainForwardCallback):
3067         (main):
3068
3069 2007-10-03  Lars Knoll  <lars@trolltech.com>
3070
3071         Reviewed by Rob.
3072
3073         This fixes --strict mode in run-webkit-tests again after
3074         the platform dependent test results have been moved.
3075
3076         * Scripts/run-webkit-tests:
3077
3078 2007-10-03  Lars Knoll  <lars@trolltech.com>
3079
3080         Reviewed by bdash.
3081
3082         remove the hack in run-webkit-tests that forced text only test
3083         to be taken from the platform independent dir. It was only left
3084         there from early days.
3085         
3086         Remove platform dependent results for tests that are text only nowadays,
3087         and add one platform dependent result for a text only test that requires it.
3088
3089         * Scripts/run-webkit-tests:
3090
3091 2007-10-03  Lars Knoll  <lars@trolltech.com>
3092
3093         Reviewed by olliej.
3094
3095         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3096
3097         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3098         (WebCore::WebFrame::WebFrame):
3099         (WebCore::WebPage::WebPage):
3100         (WebCore::WebPage::createFrame):
3101         (WebCore::WebPage::javaScriptAlert):
3102         (WebCore::WebPage::javaScriptConsoleMessage):
3103         (WebCore::DumpRenderTree::DumpRenderTree):
3104         (WebCore::DumpRenderTree::~DumpRenderTree):
3105         (WebCore::DumpRenderTree::open):
3106         (WebCore::DumpRenderTree::readStdin):
3107         (WebCore::DumpRenderTree::resetJSObjects):
3108         (WebCore::DumpRenderTree::initJSObjects):
3109         (WebCore::DumpRenderTree::dumpFramesAsText):
3110         (WebCore::DumpRenderTree::dump):
3111         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3112         (WebCore::DumpRenderTree::layoutTestController):
3113         (WebCore::DumpRenderTree::eventSender):
3114         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3115         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3116         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3117         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3118         (HackWebFrame::mousePressEvent):
3119         (HackWebFrame::mouseReleaseEvent):
3120         (HackWebFrame::mouseMoveEvent):
3121         (HackWebFrame::HackWebFrame):
3122         (HackWebFrame::~HackWebFrame):
3123         (LayoutTestController::LayoutTestController):
3124         (LayoutTestController::reset):
3125         (LayoutTestController::maybeDump):
3126         (LayoutTestController::waitUntilDone):
3127         (LayoutTestController::notifyDone):
3128         (LayoutTestController::dumpEditingCallbacks):
3129         (LayoutTestController::queueReload):
3130         (LayoutTestController::provisionalLoad):
3131         (LayoutTestController::timerEvent):
3132         (EventSender::EventSender):
3133         (EventSender::mouseDown):
3134         (EventSender::mouseUp):
3135         (EventSender::mouseMoveTo):
3136         (EventSender::leapForward):
3137         (EventSender::keyDown):
3138         (EventSender::frameUnderMouse):
3139         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3140         (LayoutTestController::isLoading):
3141         (LayoutTestController::setLoading):
3142         (LayoutTestController::shouldDumpAsText):
3143         (LayoutTestController::shouldDumpChildrenAsText):
3144         (LayoutTestController::shouldWaitUntilDone):
3145         (LayoutTestController::dumpAsText):
3146         (LayoutTestController::dumpChildFramesAsText):
3147         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3148         (messageHandler):
3149         (crashHandler):
3150         (main):
3151         * Scripts/run-webkit-tests:
3152
3153 2007-10-03  Mark Rowe  <mrowe@apple.com>
3154
3155         Reviewed by Alp Toker.
3156
3157         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3158         should take precedence over QTDIR when determining which port we are working with.
3159
3160         * Scripts/webkitdirs.pm: 
3161
3162 2007-10-02  Adam Roben  <aroben@apple.com>
3163
3164         Add keychain to the list of default packages to install
3165
3166         Rubberstamped by Sam.
3167
3168         * CygwinDownloader/cygwin-downloader.py:
3169         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3170
3171 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3172
3173         Reviewed by Adam.
3174
3175         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3176         Also makes WebCore regression test case logic work when using git.
3177
3178         * Scripts/prepare-ChangeLog:
3179         (reviewerAndDescriptionForGitCommit): Added.
3180
3181 2007-10-02  Lars Knoll  <lars@trolltech.com>
3182
3183         Reviewed by bdash.
3184
3185         Add API to retrieve the frame name from QWebFrame.
3186         Implement support for DRT::dumpChildrenAsText.
3187
3188         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3189         (WebCore::DumpRenderTree::dumpFramesAsText):
3190         (WebCore::DumpRenderTree::dump):
3191         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3192         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3193         (LayoutTestController::LayoutTestController):
3194         (LayoutTestController::reset):
3195         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3196
3197 2007-10-02  Lars Knoll  <lars@trolltech.com>
3198
3199         Reviewed by bdash.
3200
3201         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3202
3203         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3204         (WebCore::DumpRenderTree::readStdin):
3205
3206 2007-10-02  Mark Rowe  <mrowe@apple.com>
3207
3208         Reviewed by Oliver.
3209
3210         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3211
3212         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3213         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3214
3215 2007-10-02  Mark Rowe  <mrowe@apple.com>
3216
3217         Rubber-stamped by Maciej.
3218
3219         Configuration changes from build.webkit.org.  The major change is refactoring to work
3220         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3221         last few weeks.
3222
3223         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3224         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3225         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3226         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3227         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3228         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3229         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3230         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3231
3232 2007-10-02  Lars Knoll  <lars@trolltech.com>
3233
3234         Reviewed by Maciej.
3235
3236         Add support for eventSender.mouseMove to DRT.
3237         Fixes fast/css/hover-affects-child.html
3238
3239         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3240         (EventSender::mouseMoveTo):
3241
3242 2007-10-01  Mark Rowe  <mrowe@apple.com>
3243
3244         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3245
3246 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3247
3248         Reviewed by Hyatt.
3249
3250         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3251
3252         * Scripts/svn-apply:
3253         (gitdiff2svndiff): Ignore lines beginning with "new file".
3254         * Scripts/svn-unapply:
3255         (gitdiff2svndiff): Ditto.
3256
3257 2007-09-30  George Staikos  <staikos@kde.org>
3258
3259         Qt build fix (Mac OS X specific)
3260
3261         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3262
3263 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3264
3265         Reviewed by Mark.
3266
3267         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3268         Remove Bakefiles from svn.
3269
3270         * GtkLauncher/Bakefiles.bkgen: Removed.
3271         * GtkLauncher/ENV: Removed.
3272         * GtkLauncher/gdklauncher.bkl: Removed.
3273         * GtkLauncher/mk: Removed.
3274         * Scripts/regenerate-makefiles: Removed.
3275
3276 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3277
3278         Reviewed by John.
3279
3280         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3281
3282         * Scripts/run-webkit-tests:
3283
3284 2007-09-26  Adam Roben  <aroben@apple.com>
3285
3286         Make not finding an installed WebKit non-fatal
3287
3288         What really matters is that we are able to load WebKit and its
3289         dependencies, not whether we think we've found an installed WebKit.
3290
3291         Reviewed by Sam.
3292
3293         * WebKitInitializer/WebKitInitializer.cpp:
3294         (getWebViewCLSID): Use new LOG_WARNING macro.
3295         (getInstalledWebKitDirectory): Ditto.
3296         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3297         and use new macros.
3298         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3299
3300 2007-09-26  Adam Roben  <aroben@apple.com>
3301
3302         Committed this file before saving it
3303
3304         * WebKitInitializer/debug_internal.vsprops:
3305
3306 2007-09-26  Adam Roben  <aroben@apple.com>
3307
3308         Load WebKit and its dependencies manually so they come from DllDirectory
3309
3310         I had to change WebKitInitializer to use malloc/free instead of
3311         new/delete to avoid pulling in WebKit (and its dependencies) early
3312         through use of fastMalloc.
3313
3314         Reviewed by Oliver.
3315
3316         * WebKitInitializer/WebKitInitializer.cpp:
3317         (getStringValue): Changed to use malloc/free.
3318         (getInstalledWebKitDirectory): Ditto.
3319         (initializeWebKit): Call SetDllDirectory first, then load all of
3320         WebKit's dependencies manually, finally followed by WebKit itself.
3321         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3322         configuration to match our other projects.
3323         * WebKitInitializer/debug_internal.vsprops: Added.
3324
3325 2007-09-25  Adam Roben  <aroben@apple.com>
3326
3327         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3328
3329         Rubberstamped by Sam.
3330
3331         * WebKitInitializer/WebKitInitializer.vcproj:
3332
3333 2007-09-25  Adam Roben  <aroben@apple.com>
3334
3335         Make DumpRenderTree delay-load its dependencies
3336
3337         This lets WebKitInitializer re-route the dependencies to be loaded out
3338         of the Safari installation directory.
3339
3340         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3341         same thing), since we can't import the kCFAllocatorDefault symbol when
3342         delay-loading CoreFoundation.dll.
3343
3344         Rubberstamped by Sam.
3345
3346         * DumpRenderTree/win/DumpRenderTree.cpp:
3347         (runTest):
3348         (javaScriptThreads):
3349         * DumpRenderTree/win/DumpRenderTree.vcproj:
3350         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3351         (LayoutTestController::setWaitToDump):
3352
3353 2007-09-25  Adam Roben  <aroben@apple.com>
3354
3355         Pull ole32.lib into WebKitInitializer
3356
3357         Rubberstamped by Sam.
3358
3359         * WebKitInitializer/WebKitInitializer.vcproj:
3360
3361 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3362
3363         Reviewed by Adam.
3364
3365         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3366           LGPL'ed files contain incorrect FSF address
3367
3368         * Drosera/config.h:
3369
3370 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3371
3372         Reviewed by Adam.
3373
3374         Make svn-apply and svn-unapply work with git-diff formatted patches.
3375
3376         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3377         (gitdiff2svndiff): Added.
3378         * Scripts/svn-unapply: Ditto.
3379         (gitdiff2svndiff): Added.
3380
3381 2007-09-25  Adam Roben  <aroben@apple.com>
3382
3383         Pull advapi32.lib into WebKitInitializer
3384
3385         This is needed to get the registry functions we use.
3386
3387         Rubberstamped by Sam.
3388
3389         * WebKitInitializer/WebKitInitializer.vcproj:
3390
3391 2007-09-25  Adam Roben  <aroben@apple.com>
3392
3393         Add python and rsync to cygwin-downloader
3394
3395         Our build slaves need this, and it can't hurt for everyone else to
3396         have it, too.
3397
3398         Reviewed by Sam.
3399
3400         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3401         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3402
3403 2007-09-25  Adam Roben  <aroben@apple.com>
3404
3405         Add WebKitInitializer and use it in DumpRenderTree
3406
3407         WebKitInitializer is a static library that has one function,
3408         initializeWebKit(). This registers WebKit and sets up the DLL search
3409         path so that WebKit's dependencies that are installed with Safari can
3410         be found.
3411
3412         Reviewed by Sam.
3413
3414         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3415         DumpRenderTree depend on it.
3416         * DumpRenderTree/win/DumpRenderTree.cpp:
3417         (initialize): Call initializeWebKit.
3418         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3419         WebKitInitializer.lib.
3420         * WebKitInitializer/WebKitInitializer.cpp: Added.
3421         (getStringValue):
3422         (getWebViewCLSID):
3423         (getInstalledWebKitDirectory):
3424         (initializeWebKit):
3425         * WebKitInitializer/WebKitInitializer.h: Added.
3426         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3427         * WebKitInitializer/debug.vsprops: Added.
3428         * WebKitInitializer/release.vsprops: Added.
3429
3430 2007-09-25  Adam Roben  <aroben@apple.com>
3431
3432         Make run-webkit-tests respect set-webkit-configuration
3433
3434         Reviewed by Sam.
3435
3436         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3437         set-webkit-configuration was last set to.
3438
3439 2007-09-25  Mark Rowe  <mrowe@apple.com>
3440
3441         Rubber-stamped by Eric.
3442
3443         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3444         This makes it possible to automate nightly builds for the feature-branch.
3445
3446 2007-09-25  Adam Roben  <aroben@apple.com>
3447
3448         A couple of fixes/enhancements to update-webkit-*-libs
3449
3450         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3451         to tell update-webkit-support-libraries where it should find the
3452         WebKitSupportLibrary.zip file you downloaded.
3453
3454         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3455         Windows-style path.
3456
3457         Reviewed by Sam.
3458
3459         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3460         to $auxiliaryLibsURL and removed an irrelevant comment.
3461         * Scripts/update-webkit-support-libs:
3462
3463 2007-09-25  Adam Treat  <treat@kde.org>
3464
3465         Reviewed by Simon and Lars.
3466
3467         Refactors and cleans up Qt DRT member variable names, member variable
3468         initialization, style fixes and general code cleanup.
3469
3470         Adds queueReload slot to LayoutTestController that some tests require.
3471
3472         Subclasses QWebFrame to make sure that all frames have an associated
3473         LayoutTestController JS window object.
3474
3475         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3476         aren't dumped twice.
3477
3478         EOF fixes.
3479
3480         Together, this patch fixes some 20+ layout tests in QtWebKit.
3481
3482         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3483         (WebCore::WebFrame::WebFrame):
3484         (WebCore::WebPage::WebPage):
3485         (WebCore::WebPage::createFrame):
3486         (WebCore::DumpRenderTree::DumpRenderTree):
3487         (WebCore::DumpRenderTree::open):
3488         (WebCore::DumpRenderTree::readStdin):
3489         (WebCore::DumpRenderTree::initJSObjects):
3490         (WebCore::DumpRenderTree::dump):
3491         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3492         (WebCore::DumpRenderTree::layoutTestController):
3493         (WebCore::DumpRenderTree::eventSender):
3494         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3495         (LayoutTestController::LayoutTestController):
3496         (LayoutTestController::reset):
3497         (LayoutTestController::maybeDump):
3498         (LayoutTestController::waitUntilDone):
3499         (LayoutTestController::notifyDone):
3500         (LayoutTestController::queueReload):
3501         (LayoutTestController::provisionalLoad):
3502         (EventSender::EventSender):
3503         (EventSender::mouseDown):
3504         (EventSender::mouseUp):
3505         (EventSender::mouseMoveTo):
3506         (EventSender::frameUnderMouse):
3507         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3508         (LayoutTestController::isLoading):
3509         (LayoutTestController::setLoading):
3510         (LayoutTestController::dumpAsText):
3511         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3512         (main):
3513
3514 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3515
3516
3517         - Reverted an accidentally checked in file.
3518
3519         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3520
3521 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3522         Reviewed by Sam.
3523
3524         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3525
3526         * DumpRenderTree/win/DumpRenderTree.vcproj:
3527         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3528
3529 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3530
3531         Rubber stamped by Adam.
3532
3533         * GdkLauncher: Removed.
3534         * GdkLauncher/Bakefiles.bkgen: Removed.
3535         * GdkLauncher/ENV: Removed.
3536         * GdkLauncher/GdkLauncher.pro: Removed.
3537         * GdkLauncher/gdklauncher.bkl: Removed.
3538         * GdkLauncher/main.cpp: Removed.
3539         * GdkLauncher/mk: Removed.
3540         * GdkLauncher/simple.svg: Removed.
3541         * GdkLauncher/text.html: Removed.
3542         * GtkLauncher: Added.
3543         * GtkLauncher/GdkLauncher.pro: Removed.
3544         * GtkLauncher/GtkLauncher.pro: Added.
3545         * GtkLauncher/main.cpp:
3546         (updateWindowTitle):
3547         (main):
3548         * Scripts/build-webkit:
3549         * Scripts/regenerate-makefiles:
3550         * Scripts/run-javascriptcore-tests:
3551         * Scripts/run-launcher:
3552         * Scripts/run-webkit-tests:
3553         * Scripts/webkitdirs.pm:
3554
3555 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3556
3557         Reviewed by Darin.
3558
3559         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3560
3561         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3562         This is tested by plugins/root-object-premature-delete-crash.html.
3563
3564         * DumpRenderTree/mac/ObjCController.m:
3565         (-[ObjCController accessStoredWebScriptObject]):
3566
3567 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3568
3569         Reviewed by Oliver.
3570
3571         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3572
3573         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3574         (FrameLoadDelegate::FrameLoadDelegate):
3575
3576 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3577
3578         Reviewed by Adam.
3579
3580         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3581         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3582
3583         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3584         Now isQt() and isGdk() use global variables that are only set once.
3585
3586         An array of all the parameters is now given to build-dumprender which includes
3587         the platform on linux.
3588
3589         * Scripts/build-dumprendertree:
3590         * Scripts/run-webkit-tests:
3591         * Scripts/webkitdirs.pm:
3592
3593 2007-09-19  Adam Roben  <aroben@apple.com>
3594
3595         Rubberstamped by Hyatt.
3596
3597         * Spinneret: Removed.
3598
3599 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3600
3601         Reviewed by David Kilzer.
3602
3603         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3604
3605 2007-09-18  Sam Weinig  <sam@webkit.org>
3606
3607         Add JSRetainPtr.h #include to fix some builds.
3608
3609         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3610
3611 2007-09-18  Mike Hommey  <glandium@debian.org>
3612
3613        &nb