e8754bb3d3146f8d49838bd47fcbd0b652b97d5b
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-01  Adam Treat  <treat@kde.org>
2
3         Reviewed by Simon.
4
5         * Don't hide symbols when in Debug mode
6         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
7
8
9         * DumpRenderTree/qt/main.cpp:
10         (messageHandler):
11
12 2007-11-30  Alp Toker  <alp@atoker.com>
13
14         Reviewed by Adam Roben.
15
16         http://bugs.webkit.org/show_bug.cgi?id=15691
17         [GTK] Public API does not follow GTK+ conventions
18
19         Refactor the WebKit/GTK+ public API. Changes:
20           WebKitPage -> WebKitWebView
21           WebKitFrame -> WebKitWebFrame
22
23         Public API source and header names have been updated to mirror the API
24         changes.
25
26         The API is now kept in WebKit/gtk/WebView to match other ports in the
27         same class such as Mac and Win.
28
29         * GtkLauncher/main.c:
30         (activate_uri_entry_cb):
31         (link_hover_cb):
32         (title_change_cb):
33         (progress_change_cb):
34         (go_back_cb):
35         (go_forward_cb):
36         (create_browser):
37         (main):
38
39 2007-11-30  Adam Roben  <aroben@apple.com>
40
41         Hopefully the final build fix
42
43         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
44         pull in WTF's assertion/logging functions.
45
46 2007-11-30  Adam Roben  <aroben@apple.com>
47
48         Another build fix
49
50         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
51         WebKit.lib.
52
53 2007-11-30  Adam Roben  <aroben@apple.com>
54
55         Debug build fix
56
57         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
58         configuration.
59         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
60         projects.
61         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
62         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
63         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
64
65 2007-11-30  Sam Weinig  <sam@webkit.org>
66
67         Reviewed by Adam Roben.
68
69         Fix drawSelectionRect to actually draw the selection rect.
70
71         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
72         (drawSelectionRect):
73
74 2007-11-30  Darin Adler  <darin@apple.com>
75
76         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
77
78 2007-11-30  Darin Adler  <darin@apple.com>
79
80         * Scripts/do-webcore-rename: Get ready for some future renaming.
81
82 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
83
84         Reviewed by Adam.
85
86         - Removed some unnecessary functions and changed an unused return type. 
87
88         * Drosera/win/DebuggerClient.cpp:
89         (registerConsoleClass):
90         * Drosera/win/DebuggerClient.h:
91         * Drosera/win/Drosera.cpp:
92         (registerDroseraClass):
93
94 2007-11-28  Alp Toker  <alp@atoker.com>
95
96         Reviewed by Timothy Hatcher.
97
98         http://bugs.webkit.org/show_bug.cgi?id=16174
99         [GTK] Use "URI" not "URL" in public API
100
101         Replace use of the term "URL" with "URI" in public headers,
102         documentation and some internal code to match GLib/GTK+ convention.
103
104         This is now mentioned in the API guidelines:
105           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
106
107         * GtkLauncher/main.c:
108         (activate_uri_entry_cb):
109         (title_change_cb):
110         (create_toolbar):
111         (main):
112
113 2007-11-29  Anders Carlsson  <andersca@apple.com>
114
115         Reviewed by Sam.
116
117         <rdar://problem/5230478>
118         FrameLoadDelegate callbacks are not dumped in DRT.
119         
120         * DumpRenderTree/win/DumpRenderTree.cpp:
121         (shouldLogFrameLoadDelegates):
122         (runTest):
123         (main):
124         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
125         (BSTRtoString):
126         (descriptionSuitableForTestResult):
127         (FrameLoadDelegate::QueryInterface):
128         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
129         (FrameLoadDelegate::didFailProvisionalLoadWithError):
130         (FrameLoadDelegate::didCommitLoadForFrame):
131         (FrameLoadDelegate::didFinishLoadForFrame):
132         (FrameLoadDelegate::willCloseFrame):
133         (FrameLoadDelegate::didClearWindowObject):
134         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
135         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
136         * DumpRenderTree/win/FrameLoaderDelegate.h:
137         (FrameLoadDelegate::windowScriptObjectAvailable):
138         (FrameLoadDelegate::didFirstLayoutInFrame):
139
140 2007-11-29  Sam Weinig  <sam@webkit.org>
141
142         Reviewed by Anders.
143
144         Add database quota UIDelegates methods to DRT UIDelegate.
145
146         * DumpRenderTree/mac/UIDelegate.mm:
147         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
148         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
149
150 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
151
152         Reviewed by Sam.
153
154         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
155         dying and vice versa.
156         - This fix will allow Drosera and Safari to reconnect if either of them
157         closes correctly, but does not fix the case where one of them dies
158         silently.
159
160         * Drosera/win/ServerConnection.cpp:
161         (ServerConnection::attemptToCreateServerConnection): Added a safety
162         check, because it's possilbe to try to connect to a server that's dying.
163         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
164         the server has died.
165         * Drosera/win/ServerConnection.h: Added the new function and removed
166         an unnecessary member.
167
168 2007-11-29  Anders Carlsson  <andersca@apple.com>
169
170         * DumpRenderTree/win/DumpRenderTree.vcproj:
171         Add shlwapi.lib to all configurations.
172
173 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
174
175         - Build fix.  Added additional includes for VS Express to the Release
176         project.
177
178         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
179
180 2007-11-29  Anders Carlsson  <andersca@apple.com>
181
182         Reviewed by Adam.
183
184         <rdar://problem/5132005>
185         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
186         
187         * DumpRenderTree/win/DumpRenderTree.vcproj:
188         Add shlwapi.lib
189         
190         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
191         (LayoutTestController::setUserStyleSheetEnabled):
192         Implement this.
193         
194         (appendComponentToPath):
195         New method which wraps the Win32 API PathAppend.
196         
197         (followShortcuts):
198         New method which checks if a file points to a shortcut and
199         follows the shortcut.
200         
201         (resolveCygwinPath):
202         New method that takes a cygwin unix-style path and returns the Win32 path.
203         
204         (cfStringRefToWString):
205         
206         (LayoutTestController::setUserStyleSheetLocation):
207         Implement this.
208
209 2007-11-29  Alice Liu  <alice.liu@apple.com>
210
211         Reviewed by Adam.
212
213         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
214
215         * DumpRenderTree/win/EventSender.cpp:
216         (keyDownCallback):
217         uppercase letters were being sent as lowercase letters without the shift key down.
218
219 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
220
221         - Windows build fix. VS express needs some love.
222
223         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
224
225 2007-11-28  Darin Adler  <darin@apple.com>
226
227         Reviewed by Adam Roben.
228
229         * DumpRenderTree/mac/EventSendingController.mm:
230         (-[EventSendingController keyDown:withModifiers:]):
231         Send capital letters through as lowercase letters with the shift key down
232         rather than sending them as if they were highly unusual "capital letter keys".
233
234         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
235         where you need to update results and more tests are failing than before.
236
237 2007-11-28  Anders Carlsson  <andersca@apple.com>
238
239         Reviewed by Darin.
240
241         <rdar://problem/5132001>
242         contextClick is not implemented in DRT on Windows.
243         
244         * DumpRenderTree/win/EventSender.cpp:
245         (contextClickCallback):
246         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
247         by a WM_RBUTTONUP message.
248         
249         * DumpRenderTree/win/UIDelegate.cpp:
250         (UIDelegate::hasCustomMenuImplementation):
251         (UIDelegate::trackCustomPopupMenu):
252         * DumpRenderTree/win/UIDelegate.h:
253         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
254         menu from being shown (and causing the DRT to hang).
255
256 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
257
258         Reviewed by Darin.
259
260         Fix DumpRenderTree ObjC bug comparing strings.
261
262         * DumpRenderTree/mac/ObjCController.m:
263         (-[ObjCController identityIsEqual::]): Compare strings with string
264         equality instead of identiy equality.
265
266 2007-11-27  Timothy Hatcher  <timothy@apple.com>
267
268         Reviewed by Sam.
269
270         Reset the authorAndUserStylesEnabled preference
271         back to YES for each test. Fixes the broken tests.
272
273         * DumpRenderTree/mac/DumpRenderTree.mm:
274         (resetWebViewToConsistentStateBeforeTesting):
275
276 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
277
278         Reviewed by Adam.
279
280         - Drosera now displays the console window, although it cannot currently
281         process JavaScript.
282
283         * Drosera/win/DebuggerClient.cpp: Shows the console window.
284         (registerConsoleClass): Implemented.
285         (consoleWndProc): Implemented.
286         (DebuggerClient::onSize): Implemented.
287         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
288         new window.
289         * Drosera/win/DebuggerClient.h: Added needed method and members for 
290         creating and maintaining a new window.
291         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
292         lines of code to more appropriate places.
293         (Drosera::handleCommand):
294         (Drosera::initUI):
295         (Drosera::onSize):
296         (Drosera::attach):
297
298 2007-11-27  Timothy Hatcher  <timothy@apple.com>
299
300         Reviewed by Dave Hyatt.
301
302         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
303         
304         Add support for disabling author and user styles for testing.
305
306         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
307         * DumpRenderTree/LayoutTestController.cpp:
308         (setAuthorAndUserStylesEnabledCallback):
309         (LayoutTestController::staticFunctions):
310         * DumpRenderTree/LayoutTestController.h:
311         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
312         (LayoutTestController::setAuthorAndUserStylesEnabled):
313         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
314         (LayoutTestController::setAuthorAndUserStylesEnabled):
315
316 2007-11-26  Dan Bernstein  <mitz@apple.com>
317
318         - Tiger build fix.
319
320         * DumpRenderTree/mac/Configurations/Base.xcconfig:
321
322 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
323
324         Reviewed by Maciej.
325
326         - Implemented displaying variables for Drosera on Win.
327
328         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
329         that retrieve variables to not hold onto the return value since it's
330         not returned.  Also changed to use the new signatures of the retrieval
331         functions.
332         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
333         (DebuggerDocument::platformValueForScopeVariableNamed):
334         * Drosera/win/Drosera.cpp: Removed a needless TODO.
335         (droseraWndProc):
336
337 2007-11-26  Sam Weinig  <sam@webkit.org>
338
339         Cleanup names of painting and repainting functions.
340
341         Reviewed by Adam Roben.
342
343         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
344         (drawSelectionRect): was drawSelectionRectIntoContext.
345         (dumpWebViewAsPixelsAndCompareWithExpected):
346         * DumpRenderTree/cg/PixelDumpSupportCG.h:
347         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
348         (paintWebView): was drawWebViewIntoContext.
349         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
350
351 2007-11-26  Sam Weinig  <sam@webkit.org>
352
353         Reviewed by Dan Bernstein.
354
355         - Leopard build fix
356
357         * DumpRenderTree/mac/Configurations/Base.xcconfig:
358
359 2007-11-26  Sam Weinig  <sam@webkit.org>
360
361         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
362         Use shared PixelDumpSupport for Mac DRT
363
364         Reviewed by Adam Roben.
365
366         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
367         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
368         * DumpRenderTree/cg/ImageDiffCG.cpp:
369         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
370         (drawSelectionRectIntoContext):
371         (dumpWebViewAsPixelsAndCompareWithExpected):
372         * DumpRenderTree/cg/PixelDumpSupportCG.h:
373         * DumpRenderTree/mac/Configurations/Base.xcconfig:
374         * DumpRenderTree/mac/DumpRenderTree.mm:
375         (dump):
376         * DumpRenderTree/mac/ImageDiff.m: Removed.
377         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
378         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
379         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
380         (setDefaultColorProfileToRGB):
381         (getBitmapContextFromWebView):
382         (drawWebViewIntoContext):
383         (repaintWithVerticalSweep):
384         (repaintWithHorizontalSweep):
385         (getSelectionRect):
386         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
387
388 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
389
390         Bug 16052: prepare-ChangeLog doesn't report deleted files
391         <http://bugs.webkit.org/show_bug.cgi?id=16052>
392
393         Reviewed by Sam.
394
395         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
396
397 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
398
399         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
400         <http://bugs.webkit.org/show_bug.cgi?id=15864>
401
402         Reviewed by Adam.
403
404         Roll functionality of merge-changelog into resolve-ChangeLogs
405         script.  The script now checks for ChangeLog.rej and
406         ChangeLog.orig files first.  If it finds them, it uses the
407         ChangeLog.rej file as a patch (in old contextual diff format) to
408         apply with --fuzz=3.
409
410         * Scripts/merge-changelog: Removed.
411         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
412
413 2007-11-25  Sam Weinig  <sam@webkit.org>
414
415         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
416
417         Reviewed by Mark Rowe.
418
419         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
420         * DumpRenderTree/mac/Configurations/Base.xcconfig:
421         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
422         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
423         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
424
425 2007-11-25  Sam Weinig  <sam@webkit.org>
426
427         Convert DumpRenderTree to ues .xcconfig files.
428
429         Reviewed by Mark Rowe.
430
431         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
432         * DumpRenderTree/mac/Configurations: Added.
433         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
434         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
435         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
436
437 2007-11-25  Sam Weinig  <sam@webkit.org>
438
439         Add ForwardingHeaders to wtf for DumpRenderTree.
440
441         Reviewed by Mark Rowe.
442
443         * DumpRenderTree/DumpRenderTree.h:
444         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
445         * DumpRenderTree/ForwardingHeaders: Added.
446         * DumpRenderTree/ForwardingHeaders/wtf: Added.
447         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
448         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
449         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
450         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
451         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
452         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
453         * DumpRenderTree/LayoutTestController.cpp:
454         * DumpRenderTree/WorkQueue.cpp:
455         * DumpRenderTree/mac/DumpRenderTree.mm:
456         * DumpRenderTree/mac/FrameLoadDelegate.mm:
457         * DumpRenderTree/mac/JavaScriptThreading.cpp:
458         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
459         * DumpRenderTree/mac/ObjCController.m:
460         * DumpRenderTree/mac/UIDelegate.mm:
461         * DumpRenderTree/mac/WorkQueueItemMac.mm:
462
463 2007-11-25  Adam Roben  <aroben@apple.com>
464
465         Fix some test failures caused by r28019
466
467         Now that stdout is in binary mode, we need to always use printf
468         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
469         the output.
470
471         Reviewed by Sam.
472
473         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
474         printf.
475         (UIDelegate::runJavaScriptAlertPanelWithMessage):
476         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
477         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
478         (UIDelegate::webViewAddMessageToConsole):
479
480 2007-11-25  Adam Roben  <aroben@apple.com>
481
482         Set the font smoothing preference in DRT
483
484         This makes the pixel results on Windows closer to the Mac results.
485
486         Reviewed by Mitz.
487
488         * DumpRenderTree/win/DumpRenderTree.cpp:
489         (initializePreferences):
490
491 2007-11-25  Adam Roben  <aroben@apple.com>
492
493         Port ImageDiff to CG and C++
494
495         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
496         <rdar://5071708>
497
498         Reviewed by Sam.
499
500         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
501         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
502         (main):
503         (createImageFromStdin):
504         (compareImages):
505         (getDifferenceBitmap):
506         (computePercentageDifferent):
507         * DumpRenderTree/win/ImageDiff.vcproj: Added.
508
509 2007-11-25  Adam Roben  <aroben@apple.com>
510
511         Fix image diff link generation on Windows
512
513         Reviewed by Sam.
514
515         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
516         to toURL.
517
518 2007-11-25  Adam Roben  <aroben@apple.com>
519
520         Implement pixel dumping in Windows DRT
521
522         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
523         <rdar://5071708>
524
525         Reviewed by Sam.
526
527         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
528         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
529         Content-Length header.
530         (getMD5HashStringForBitmap):
531         (dumpWebViewAsPixelsAndCompareWithExpected):
532         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
533         * DumpRenderTree/win/DumpRenderTree.cpp:
534         (dump): Do a pixel dump if requested.
535         (main): Parse pixel test options.
536         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
537         the cg/ subdirectory to the include path.
538         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
539         available in a header or import library, so we have to go through this
540         LoadLibrary/GetProcAddress dance to use them.
541         (cryptDLL):
542         (init):
543         (update):
544         (final):
545         (MD5_Init):
546         (MD5_Update):
547         (MD5_Final):
548         * DumpRenderTree/win/MD5.h: Added.
549         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
550         moved up to the top level to share it with Mac eventually.
551         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
552         (getBitmapContextFromWebView): Forces the WebView to paint using a
553         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
554
555 2007-11-25  Adam Roben  <aroben@apple.com>
556
557         Clean up Windows DRT's option parsing a little bit
558
559         Reviewed by Sam.
560
561         * DumpRenderTree/win/DumpRenderTree.cpp:
562         (main): Put non-option arguments into a Vector.
563
564 2007-11-25  Adam Roben  <aroben@apple.com>
565
566         Make Windows DRT stop changing LF into CRLF
567
568         Reviewed by Sam.
569
570         * DumpRenderTree/win/DumpRenderTree.cpp:
571         (main): Put stdout in binary mode.
572         * Scripts/run-webkit-tests: Remove the CRLF hack.
573
574 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
575
576         Removed empty directory.
577
578         * Scripts/resources: Removed.
579
580 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
581
582         Fix bisect-builds to work with recent WebKit nightly builds.
583
584         Reviewed by Dan.
585
586         * Scripts/bisect-builds: Check for the 
587         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
588         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
589         to WebKit.app/Contents/Resources.
590
591 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
592
593         Reviewed by Maciej.
594
595         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
596         not closed (affects digg.com)
597
598         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
599         one after finishing with a test to avoid having its delayed onload handler firing when
600         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
601         but it helps somewhat.
602
603 2007-11-22  Mark Rowe  <mrowe@apple.com>
604
605         Reviewed by Alp Toker.
606
607         Fix build-webkit to propagate make's exit status if it fails.
608
609         * Scripts/webkitdirs.pm:
610
611 2007-11-22  Dan Bernstein  <mitz@apple.com>
612
613         Reviewed by Mark Rowe.
614
615         - fix crash when running pixel tests
616
617         * DumpRenderTree/mac/DumpRenderTree.mm:
618         (dumpRenderTree): Parse the command line options before setting up the
619         environment so that we know if we need to set up the pixel dump
620         machinery.
621
622 2007-11-21  Eric Seidel  <eric@webkit.org>
623
624         Speculative build fix for Tiger.
625
626         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
627
628 2007-11-21  Eric Seidel  <eric@webkit.org>
629
630         Reviewed by Tim Hatcher.
631
632         Break out more of DumpRenderTree.mm into individual files
633
634         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
635         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
636         (checkedMalloc):
637         (checkedRealloc):
638         (makeLargeMallocFailSilently):
639         * DumpRenderTree/mac/CheckedMalloc.h: Added.
640         * DumpRenderTree/mac/DumpRenderTree.mm:
641         (crashHandler):
642         (dump):
643         * DumpRenderTree/mac/DumpRenderTreeMac.h:
644         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
645         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
646         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
647         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
648         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
649         (javaScriptThreads):
650         (runJavaScriptThread):
651         (startJavaScriptThreads):
652         (stopJavaScriptThreads):
653         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
654         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
655         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
656         (restoreColorSpace):
657         (setDefaultColorProfileToRGB):
658         (initializeColorSpaceAndScreeBufferForPixelTests):
659         (md5HashStringForBitmap):
660         (dumpWebViewAsPixelsAndCompareWithExpected):
661
662 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
663
664         Move install-unix-extras to wx directory as it seems only to be used by that 
665         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
666         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
667         have install-unix-extras install into WebKitLibraries as per
668         convention.
669         
670         Reviewed by Mark Rowe.
671
672         * Scripts/install-unix-extras: Removed.
673         * wx/build-wxwebkit:
674         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
675
676 2007-11-21  Eric Seidel  <eric@webkit.org>
677
678         Reviewed by Adam.
679
680         More refactoring for greater code readability
681
682         * DumpRenderTree/mac/DumpRenderTree.mm:
683         (initializeGlobalsFromCommandLineOptions):
684         (initializeColorSpaceAndScreeBufferForPixelTests):
685         (addTestPluginsToPluginSearchPath):
686         (useLongRunningServerMode):
687         (runTestingServerLoop):
688         (prepareConsistentTestingEnvironment):
689         (dumpRenderTree):
690         (main):
691         (dumpFramesAsText):
692         (dumpBackForwardListForWebView):
693         (sizeWebViewForCurrentTest):
694         (methodNameStringForFailedTest):
695         (dumpBackForwardListForAllWindows):
696         (dumpWebViewAsPixelsAndCompareWithExpected):
697         (invalidateAnyPreviousWaitToDumpWatchdog):
698         (dump):
699         * DumpRenderTree/mac/DumpRenderTreeMac.h:
700         * DumpRenderTree/mac/UIDelegate.mm:
701         (-[UIDelegate webView:createWebViewWithRequest:]):
702
703 2007-11-21  Eric Seidel  <eric@webkit.org>
704
705         Reviewed by Tim Hatcher.
706
707         Abstract more of DRT into static methods
708
709         * DumpRenderTree/mac/DumpRenderTree.mm:
710         (setDefaultsToConsistentValuesForTesting):
711         (setupSignalHandlers):
712         (allocateGlobalControllers):
713         (releaseAndZero):
714         (releaseGlobalControllers):
715         (dumpRenderTree):
716         (shouldLogFrameLoadDelegates):
717         (createCFURLFromPathOrURL):
718         (resetWebViewToConsistentStateBeforeTesting):
719         (runTest):
720
721 2007-11-21  Eric Seidel  <eric@webkit.org>
722
723         Reviewed by Tim Hatcher.
724
725         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
726
727         * DumpRenderTree/DumpRenderTree.h:
728         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
729         * DumpRenderTree/mac/DumpRenderTree.mm:
730         (dumpRenderTree):
731         (dump):
732         (runTest):
733         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
734         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
735         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
736         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
737         (-[DumpRenderTreePasteboard declareType:owner:]):
738         (+[LocalPasteboard alloc]):
739         (-[LocalPasteboard init]):
740         (-[LocalPasteboard dealloc]):
741         (-[LocalPasteboard name]):
742         (-[LocalPasteboard releaseGlobally]):
743         (-[LocalPasteboard declareTypes:owner:]):
744         (-[LocalPasteboard addTypes:owner:]):
745         (-[LocalPasteboard changeCount]):
746         (-[LocalPasteboard types]):
747         (-[LocalPasteboard availableTypeFromArray:]):
748         (-[LocalPasteboard setData:forType:]):
749         (-[LocalPasteboard dataForType:]):
750         (-[LocalPasteboard setPropertyList:forType:]):
751         (-[LocalPasteboard setString:forType:]):
752         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
753         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
754         (+[DumpRenderTreeWindow allWindows]):
755         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
756         (-[DumpRenderTreeWindow dealloc]):
757         (-[DumpRenderTreeWindow isKeyWindow]):
758         (-[DumpRenderTreeWindow keyDown:]):
759
760 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
761
762         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
763         it indiscriminately copies any headers inside JavaScriptCore,
764         which includes Tiger ICU headers. 
765
766         * wx/build-wxwebkit:
767         Don't run WebCore/move-js-headers.sh any longer.
768
769 2007-11-20  Adam Treat  <treat@kde.org>
770
771         Reviewed by David Kilzer.
772
773         * Prepend git branch name to $baseProductDir
774
775         * Scripts/VCSUtils.pm:
776         * Scripts/webkitdirs.pm:
777
778 2007-11-20  Mark Rowe  <mrowe@apple.com>
779
780         Reviewed by Simon Hausmann.
781
782         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
783         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
784         Have it trigger a "make distclean" rather than "make clean" to ensure that the
785         built product and generated Makefile's are removed.
786
787 2007-11-19  Alp Toker  <alp@atoker.com>
788
789         Reviewed by Mark Rowe.
790
791         http://bugs.webkit.org/show_bug.cgi?id=16040
792         [GTK] GtkLauncher should be written in C
793
794         Port GtkLauncher to plain C.
795
796         Use a more conventional GTK+ coding style.
797
798         Use a toolbar instead of menus.
799
800         Various signature fixes and cleanups.
801
802         Add a license header. Assume all previous modifications were copyright
803         assigned to Apple Inc. by default.
804
805         * GtkLauncher/GtkLauncher.pro:
806         * GtkLauncher/main.c: Added.
807         (activate_url_entry_cb):
808         (update_title):
809         (link_hover_cb):
810         (title_change_cb):
811         (progress_change_cb):
812         (destroy_cb):
813         (go_back_cb):
814         (go_forward_cb):
815         (create_browser):
816         (create_statusbar):
817         (create_toolbar):
818         (create_window):
819         (main):
820         * GtkLauncher/main.cpp: Removed.
821
822 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
823
824         Build script fixes to ensure they do the right thing for the 
825         wx port, and update build-wxwebkit to reflect the way the
826         build scripts now work.
827
828         Reviewed by Adam.
829
830         * Scripts/build-testkjs:
831         * Scripts/build-webkit:
832         * Scripts/run-javascriptcore-tests:
833         * Scripts/webkitdirs.pm:
834         * wx/build-wxwebkit:
835
836 2007-11-18  Eric Seidel  <eric@webkit.org>
837
838         Reviewed by Anders.
839
840         Make run-javascriptcore-tests report failures on exit (to support git bisect)
841
842         * Scripts/run-javascriptcore-tests:
843
844 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
845
846         Reviewed by Adam Roben.
847
848         Make run-webkit-tests work with Windows debug build.
849
850         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
851         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
852         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
853         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
854         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
855
856 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
857
858         Add wxWebKit sample and build script, and integrate it with 
859         build-webkit. Also make build-webkit --clean work for all
860         ports.
861
862         Reviewed by Darin Adler.
863
864         * Scripts/build-webkit:
865         * Scripts/webkitdirs.pm:
866         * wx: Added.
867         * wx/browser: Added.
868         * wx/browser/browser.bkl: Added.
869         * wx/browser/browser.cpp: Added.
870         * wx/build-wxwebkit: Added.
871
872 2007-11-17  Adam Roben  <aroben@apple.com>
873
874         Make it easy to run Safari in the debugger on Windows
875
876         I've added a new script, debug-safari, which launches Safari in the
877         debugger. On OS X it just calls gdb-safari.
878
879         Reviewed by Mark Rowe.
880
881         * FindSafari/FindSafari.cpp:
882         (_tmain): Added a /debugger flag, which in combination with
883         /printSafariLauncher will print a script that launches Safari in the
884         debugger.
885         * Scripts/debug-safari: Added.
886         * Scripts/run-safari: Changed to call runSafari().
887         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
888         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
889         first argument along to FindSafari.
890         * Scripts/webkitdirs.pm:
891         (sub runSafari): Added.
892
893 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
894
895         Reviewed by Adam Roben.
896
897         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
898
899 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
900
901         Reviewed by David Kilzer.
902
903         The git config command was renamed to repo-config at some point. This
904         change tries git config and then git repo-config if the first fails.
905
906         * Scripts/prepare-ChangeLog:
907         (gitConfig):
908
909 2007-11-16  Dan Bernstein  <mitz@apple.com>
910
911         Reviewed by Darin Adler and Sam Weinig.
912
913         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
914
915         * DumpRenderTree/win/EventSender.cpp:
916         (keyDownCallback): For characters that cannot be entered on the active
917         keyboard layout, send a WM_CHAR message with the character along with
918         a WM_KEYDOWN message with a virtual key code of 255.
919
920 2007-11-16  Mark Rowe  <mrowe@apple.com>
921
922         Reviewed by Tim Hatcher.
923
924         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
925
926         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
927         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
928
929 2007-11-15  Adam Roben  <aroben@apple.com>
930
931         Make run-safari actually work on Windows
932
933         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
934         chdir call.
935
936 2007-11-14  Adam Roben  <aroben@apple.com>
937
938         Updates to Safari launching now that 3.0.4 is released
939
940         Reviewed by Sam.
941
942         * FindSafari/FindSafari.cpp:
943         (getWebViewCLSID): Use version-independent ProgID.
944         * Scripts/run-safari: Use run-webkit-nightly.cmd.
945
946 2007-11-14  Anders Carlsson  <andersca@apple.com>
947
948         Reviewed by Adam.
949
950         <rdar://problem/5309081>
951         In DRT, "plugin.logDestroy = true" not working on Windows.
952         
953         * DumpRenderTree/win/TestNetscapePlugin/main.c:
954         (NPP_Destroy):
955
956 2007-11-14  Eric Seidel  <eric@webkit.org>
957
958         Reviewed by Sam.
959
960         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
961
962 2007-11-14  Anders Carlsson  <andersca@apple.com>
963
964         Reviewed by Adam.
965
966         <rdar://problem/5141186>
967         window.layoutTestController.setWindowIsKey is not implemented in DRT.
968         
969         Implement setWindowIsKey.
970         
971         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
972         (LayoutTestController::setWindowIsKey):
973
974 2007-11-13  Sam Weinig  <sam@webkit.org>
975
976         Reviewed by Adam Roben.
977
978         Fix for <rdar://problem/5382579>
979         http/tests/security/cross-frame-access-put.html reports large 
980         negative numbers for screenLeft and screenTop (Mac reports "0")
981
982         * DumpRenderTree/win/UIDelegate.cpp:
983         (UIDelegate::UIDelegate): Initialize the RECT.
984         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
985         (UIDelegate::webViewFrame): ditto.
986         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
987
988 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
989
990         Reviewed by Adam.
991
992         - Make Drosera show source, source URLs, and function stack on Windows,
993         and some minor fixes.
994
995         * Drosera/DebuggerDocument.cpp: Force source to always update display.
996         (DebuggerDocument::updateFileSource):
997         * Drosera/debugger.js: Force source to always update display.
998         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
999         menu controls.
1000         (DebuggerClient::resume):
1001         (DebuggerClient::pause):
1002         (DebuggerClient::stepInto):
1003         (DebuggerClient::stepOver):
1004         (DebuggerClient::stepOut):
1005         (DebuggerClient::showConsole):
1006         (DebuggerClient::closeCurrentFile):
1007         * Drosera/win/DebuggerClient.h: Ditto.
1008         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1009         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1010         removed two bugs.  1) caller could be in a bad state when asked to
1011         assign into it. 2) BSTRs were not created correctly.
1012         (DebuggerDocument::getPlatformCurrentFunctionStack):
1013         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1014         (droseraWndProc):
1015         (handleCommand):
1016         (Drosera::resume):
1017         (Drosera::pause):
1018         (Drosera::stepInto):
1019         (Drosera::stepOver):
1020         (Drosera::stepOut):
1021         (Drosera::showConsole):
1022         (Drosera::closeCurrentFile):
1023         * Drosera/win/Drosera.h: Hook up the menu controls.
1024         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1025         functions, added a null check, and fixed another bug where caller could
1026         be in a bad state when asked to assign into it.
1027         (ServerConnection::didLoadMainResourceForDataSource):
1028         (ServerConnection::getCallerFrame):
1029         * Drosera/win/ServerConnection.h: Safety first.
1030
1031 2007-11-13  Dan Bernstein  <mitz@apple.com>
1032
1033         Reviewed by Darin Adler.
1034
1035         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1036           DumpRenderTree --pixel-tests renders each test twice
1037
1038         * DumpRenderTree/mac/DumpRenderTree.mm:
1039         (dumpRenderTree): Removed the --paint option because the painting code
1040         is always exercised as a result of
1041         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1042         calling -displayIfNeeded.
1043         (dump): Changed to always grab the image from the window since the view
1044         is always displayed.
1045         (runTest):
1046         (displayWebView):
1047         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1048         because it always paints.
1049
1050 2007-11-12  Antti Koivisto  <antti@apple.com>
1051
1052         Reviewed by Adele.
1053         
1054         Add support for http media tests
1055
1056         * Scripts/run-webkit-tests:
1057
1058 2007-11-12  Sam Weinig  <sam@webkit.org>
1059
1060         Reviewed by Adam Roben.
1061
1062         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1063
1064         * DumpRenderTree/win/DumpRenderTree.cpp:
1065         (runTest):
1066         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1067         (LayoutTestController::setPrivateBrowsingEnabled):
1068
1069 2007-11-12  Adam Roben  <aroben@apple.com>
1070
1071         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1072         mac and win subdirectories.
1073
1074 2007-11-11  Adam Roben  <aroben@apple.com>
1075
1076         Fix <rdar://5133816> keepWebHistory is not implemented
1077
1078         Fixes fast/history/clicked-link-is-visited.html.
1079
1080         Reviewed by Darin.
1081
1082         * DumpRenderTree/win/DumpRenderTree.cpp:
1083         (runTest): Clear the optionalSharedHistory.
1084         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1085         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1086
1087 2007-11-10  Sam Weinig  <sam@webkit.org>
1088
1089         Reviewed by Tim Hatcher.
1090
1091         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1092         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1093         is turned on)
1094
1095         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1096
1097         Added test: http/tests/security/cross-frame-access-private-browsing.html
1098
1099         * DumpRenderTree/LayoutTestController.cpp:
1100         (setPrivateBrowsingEnabledCallback):
1101         (LayoutTestController::staticFunctions):
1102         * DumpRenderTree/LayoutTestController.h:
1103         * DumpRenderTree/mac/DumpRenderTree.mm:
1104         (runTest): Default to private browsing disabled.
1105         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1106         (LayoutTestController::setPrivateBrowsingEnabled):
1107         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1108         (LayoutTestController::setPrivateBrowsingEnabled):
1109
1110 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1111
1112         Reviewed by Adam.
1113
1114         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1115         WebCore's!
1116
1117         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1118         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1119         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1120         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1121         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1122         * Drosera/win/Drosera.cpp:
1123         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1124
1125 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1126
1127         Reviewed by Sam.
1128
1129         - Use the new IWebFrame [local] function signature and get the shared
1130         server correctly.
1131
1132         * Drosera/win/DebuggerClient.cpp:
1133         (DebuggerClient::didFinishLoadForFrame):
1134         * Drosera/win/ServerConnection.cpp:
1135         (ServerConnection::attemptToCreateServerConnection):
1136
1137 2007-11-07  Dan Bernstein  <mitz@apple.com>
1138
1139         Reviewed by Darin Adler.
1140
1141         - add an option to run-webkit-tests to ignore pixel test failures where
1142           all pixels differ by no more than a specified threshold
1143
1144         * DumpRenderTree/mac/ImageDiff.m:
1145         (main):
1146         (compareImages):
1147         (computePercentageDifferent):
1148         * Scripts/run-webkit-tests:
1149
1150 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1151
1152         Reviewed by Lars.
1153
1154         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1155
1156         * DumpRenderTree/qt/DumpRenderTree.cpp:
1157
1158 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1159
1160         Reviewed by Lars.
1161
1162         Reworked the QWebSettings API.
1163         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1164
1165         * DumpRenderTree/qt/DumpRenderTree.cpp:
1166
1167 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1168
1169         Reviewed by Lars.
1170
1171         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1172
1173         * DumpRenderTree/qt/jsobjects.cpp:
1174
1175 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1176
1177         Reviewed by Lars Knoll <lars@trolltech.com>.
1178
1179         Add a QWebPage::frameCreated() signal and fix DRT
1180         
1181         The removal of createFrame in QWebPage broke the re-implementation
1182         in DumpRenderTree. Instead emit a frameCreated() signal and
1183         connect to it in DumpRenderTree.
1184         
1185
1186         * DumpRenderTree/qt/DumpRenderTree.cpp:
1187         (WebCore::WebPage::WebPage):
1188         (WebCore::DumpRenderTree::dump):
1189         (WebCore::DumpRenderTree::connectFrame):
1190         * DumpRenderTree/qt/DumpRenderTree.h:
1191
1192 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1193
1194         Reviewed by Lars Knoll <lars@trolltech.com>.
1195
1196         Moved all the event handlers from QWebFrame into QWebPage.
1197         
1198         This cleans up the public API and allows us to remove the
1199         HackWebFrame hack in DumpRenderTree.
1200         
1201
1202         * DumpRenderTree/qt/jsobjects.cpp:
1203         (EventSender::mouseDown):
1204         (EventSender::mouseUp):
1205         (EventSender::mouseMoveTo):
1206
1207 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1208
1209         Reviewed by Mark.
1210
1211         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1212         to prevent the default implementation from popping up messageboxes.
1213
1214         * DumpRenderTree/qt/DumpRenderTree.cpp:
1215         (WebCore::WebPage::javaScriptConfirm):
1216         (WebCore::WebPage::javaScriptPrompt):
1217
1218 2007-11-06  Eric Seidel  <eric@webkit.org>
1219
1220         * Scripts/build-testkjs: build fix... too many $$
1221
1222 2007-11-06  Eric Seidel  <eric@webkit.org>
1223
1224         Reviewed by Mark Rowe.
1225
1226         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1227
1228 2007-11-05  Adam Roben  <aroben@apple.com>
1229
1230         Add support on Windows for WEBKIT_TESTFONTS
1231
1232         This environment variable lets you specify where the fonts to be used
1233         by DumpRenderTree reside. The Qt port is already using this, so I'm
1234         just following their lead.
1235
1236         Reviewed by Darin.
1237
1238         * DumpRenderTree/win/DumpRenderTree.cpp:
1239         (exePath): Refactored code out of initialize().
1240         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1241         DumpRenderTree.resources.
1242         (initialize): Use the new fontsPath function.
1243         (main): Use the new exePath function.
1244         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1245         variable to DRT, like Qt does.
1246
1247 2007-11-05  Mark Rowe  <mrowe@apple.com>
1248
1249         Rubber-stamped by Alp Toker.
1250
1251         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1252
1253         * GtkLauncher/main.cpp:
1254         (goToURLBarText):
1255         (main):
1256
1257 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1258
1259         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1260         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1261
1262         Reviewed by Timothy.
1263
1264         Restrict the range of nightly builds used by the bisect-builds script
1265         based on the version of Safari and the version of Mac OS X being used.
1266
1267         Mac OS X 10.4: Safari 2.0: r11976 or newer
1268         Mac OS X 10.4: Safari 3.0: r19992 or newer
1269
1270         Mac OS X 10.5: Safari 2.0: r19594 or newer
1271         Mac OS X 10.5: Safari 3.0: r25124 or newer
1272
1273         * Scripts/bisect-builds:
1274         (findMacOSXVersion): Added.
1275         (makeNightlyList): Added argument to provide version of Mac OS X.
1276         Restrict range of nightly builds based on Safari and Mac OS X versions.
1277
1278 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1279
1280         Reviewed by Maciej.
1281
1282         - This patch involves several changes, all of them were noticed that
1283         they were needed by the work being done in WebKit to get Drosera and
1284         WebKit working together on Windows.
1285         - The changes are:
1286         1) Added a debugger console for output messages.
1287         2) Drosera now listens for the WebKit server (before, the server would
1288         have to be running before Drosera was started.)
1289         3) Fixed a bug where the WebView started out as 0x0 pixels.
1290         4) Fixed a bug when there is no scope.
1291         5) Added the HTML, JS, and CSS to the project file to make them easy to
1292         find.
1293         6) Made the ServerConnection functions virtual.
1294
1295         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1296         for the WebKit server.
1297         (DebuggerClient::DebuggerClient):
1298         (DebuggerClient::~DebuggerClient):
1299         (DebuggerClient::didFinishLoadForFrame):
1300         (DebuggerClient::serverConnected):
1301         (DebuggerClient::attemptToCreateServerConnection):
1302         * Drosera/win/DebuggerClient.h: Ditto.
1303         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1304         scope.
1305         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1306         (DebuggerDocument::platformValueForScopeVariableNamed):
1307         * Drosera/win/Drosera.cpp:
1308         (_tWinMain): Added a console in debug for output messages.
1309         (Drosera::Drosera): Listen for server.
1310         (Drosera::initUI): The server now Initializes COM.
1311         (Drosera::serverConnected): Part of the listening for the server.
1312         (Drosera::attemptToCreateServerConnection): Ditto.
1313         * Drosera/win/Drosera.h: New interface for listening for the server.
1314         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1315         files to the VS project.
1316         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1317         connection.
1318         (ServerConnection::ServerConnection):
1319         (ServerConnection::attemptToCreateServerConnection):
1320         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1321         methods.
1322         (ServerConnection::serverConnected):
1323
1324 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1325
1326         Reviewed by Maciej.
1327
1328         http://bugs.webkit.org/show_bug.cgi?id=15832
1329         fast/dom/gc-10.html crashes when run alone
1330
1331         Check for !done before using objects that can be already deallocated.
1332
1333         * DumpRenderTree/mac/EditingDelegate.mm:
1334         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1335         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1336         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1337         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1338         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1339         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1340         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1341         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1342         (-[EditingDelegate webViewDidBeginEditing:]):
1343         (-[EditingDelegate webViewDidChange:]):
1344         (-[EditingDelegate webViewDidEndEditing:]):
1345         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1346         (-[EditingDelegate webViewDidChangeSelection:]):
1347         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1348         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1349         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1350         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1351         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1352         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1353         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1354         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1355         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1356         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1357         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1358         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1359         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1360         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1361         (-[FrameLoadDelegate webView:willCloseFrame:]):
1362         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1363         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1364         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1365         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1366         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1367         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1368         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1369         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1370         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1371
1372 2007-11-04  Mark Rowe  <mrowe@apple.com>
1373
1374         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1375         warnings that would otherwise be suppressed due to it being a system header.
1376
1377         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1378
1379 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1380
1381         Rubber stamped by Adam.
1382         
1383         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1384
1385         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1386
1387 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1388
1389         Sort files(...); sections of Xcode project files.
1390
1391         Rubber-stamped by Darin.
1392
1393         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1394         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1395         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1396         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1397
1398 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1399
1400         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1401
1402         Reviewed by Darin.
1403
1404         * Scripts/sort-Xcode-project-file: Added.
1405
1406 2007-11-02  Darin Adler  <darin@apple.com>
1407
1408         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1409
1410 2007-11-02  Darin Adler  <darin@apple.com>
1411
1412         Reviewed by Maciej.
1413
1414         * Scripts/run-sunspider: Pass the "--base" option through.
1415
1416         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1417         the real script do that. Default configuration to Release to match run-sunspider
1418         so we don't end up building Debug just to compare results.
1419
1420 2007-11-01  Adam Roben  <aroben@apple.com>
1421
1422         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1423
1424         Reviewed by Sam.
1425
1426         * Scripts/commit-log-editor: Show all the directories beneath the
1427         source root, instead of just the last one.
1428
1429 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1430
1431         Reviewed by Adam Roben.
1432
1433         Print out an error message when the Windows build fails
1434         and provide guidance on how to find out what went wrong.
1435
1436         * Scripts/build-webkit:
1437         * Scripts/webkitdirs.pm:
1438
1439 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1440
1441         Rubber-stamped by Adam Roben.
1442
1443         Rolled out r27326 - debug CRT seems to cause no problems after all.
1444
1445         * DumpRenderTree/win/DumpRenderTree.vcproj:
1446
1447 2007-10-31  Adam Roben  <aroben@apple.com>
1448
1449         Switch the Debug configuration to using the non-debug CRT
1450
1451         This matches WebKit.
1452
1453         Reviewed by Steve.
1454
1455         * DumpRenderTree/win/DumpRenderTree.vcproj:
1456
1457 2007-10-31  Antti Koivisto  <antti@apple.com>
1458
1459         Reviewed by bdash.
1460         
1461         Disable media tests when doing leak checking on Tiger.
1462         They crash in QuickTime (rdar://problem/5537157).
1463
1464         * Scripts/run-webkit-tests:
1465
1466 2007-10-29  Antti Koivisto  <antti@apple.com>
1467
1468         Reviewed by Maciej.
1469         
1470         Build media support by default on OSX only.
1471
1472         * Scripts/build-webkit:
1473
1474 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1475
1476         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1477         get caught by the pre-commit hooks.
1478
1479 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1480
1481         Reviewed by Adam.
1482
1483         - This is a collection of relatively unrelated changes and cleanups
1484         to Drosera to prepare it for interacting with WebKit.  A lot of these
1485         changes are just correcting mistakes, for example removing included
1486         headers that are no longer needed.
1487
1488         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1489         this will be needed by the DebuggerClient.
1490         (DebuggerDocument::server):
1491         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1492         * Drosera/win/DebuggerClient.cpp: 
1493         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1494         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1495         (DebuggerClient::createWebViewWithRequest): Added comment about its
1496         purpose. 
1497         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1498         declarations.
1499         (DebuggerClient::webViewLoaded): Moved.
1500         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1501         file, since this was the only place it was used.
1502         (cfStringToBSTR):
1503         * Drosera/win/Drosera.h: Cleaned up the includes.
1504         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1505         * Drosera/win/HelperFunctions.h: Removed.
1506
1507 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1508
1509         Reviewed by Adam.
1510
1511         - Small cleanup in the ServerConnection class.
1512
1513         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1514         and added an include.
1515         (ServerConnection::currentFrame):
1516         (ServerConnection::getCallerFrame):
1517         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1518         made a pointer into a COMPtr, and cleaned up the includes.
1519
1520 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1521
1522         Reviewed by John Sullivan.
1523         
1524         - Place the Localizable.strings file in mac or win directories
1525           if that location exists.
1526         - Also look for UI_STRING in .c files.
1527
1528         * Scripts/extract-localizable-strings:
1529
1530 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1531
1532         Reviewed by Adam.
1533
1534         - Set the eol-style to native and made all the line endings the same
1535         so that I avoid messy diffs that show eol changes.
1536
1537         * Drosera/win/ServerConnection.cpp:
1538         (ServerConnection::didParseSource):
1539         (ServerConnection::didEnterCallFrame):
1540         (ServerConnection::willExecuteStatement):
1541         (ServerConnection::willLeaveCallFrame):
1542         (ServerConnection::exceptionWasRaised):
1543
1544 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1545
1546         Reviewed by Adam.
1547
1548         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1549         functionality that could not have existed previously without the new
1550         interfaces.
1551         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1552         from a BSTR to a JSValueRef.
1553         (DebuggerDocument::platformEvaluateScript): Implemented.
1554         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1555         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1556         Implemented.
1557         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1558         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1559         * Drosera/win/ServerConnection.cpp: Added a helper function.
1560         (ServerConnection::getCallerFrame):
1561         * Drosera/win/ServerConnection.h: Added a helper function.
1562
1563 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1564
1565         updated reviewers for my previous changelog.
1566
1567 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1568         Reviewed by Maciej and Adam and Geoff.
1569
1570         - Minor mac-side improvements including moving a function to a more
1571         appropriate location, fixing a warning, and correctly checking
1572         exceptions.
1573
1574         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1575         (DebuggerDocument::willExecuteStatement):
1576         (DebuggerDocument::didEnterCallFrame):
1577         (DebuggerDocument::willLeaveCallFrame):
1578         (DebuggerDocument::windowScriptObjectAvailable):
1579         (DebuggerDocument::callFunctionOnObject):
1580         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1581         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1582         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1583         because it doesn't require the ServerConnection at all.
1584         (NSStringCreateWithJSStringRef): Made an argument const.
1585         (JSValueRefCreateWithNSString): Made an argument const.
1586         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1587         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1588         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1589         * Drosera/mac/ServerConnection.mm: Ditto.
1590         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1591
1592 2007-10-29  Sam Weinig  <sam@webkit.org>
1593
1594         Reviewed by Adam Roben.
1595
1596         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1597
1598         * DumpRenderTree/LayoutTestController.cpp:
1599         (LayoutTestController::LayoutTestController):
1600         (getGlobalFlagCallback):
1601         (setGlobalFlagCallback):
1602         (LayoutTestController::getJSClass):
1603         (LayoutTestController::staticValues):
1604         * DumpRenderTree/LayoutTestController.h:
1605         (LayoutTestController::globalFlag):
1606         (LayoutTestController::setGlobalFlag):
1607
1608 2007-10-29  Darin Adler  <darin@apple.com>
1609
1610         Reviewed by Maciej.
1611
1612         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1613         resolution instead of its default.
1614
1615 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1616
1617         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1618
1619         Reviewed by Mark Rowe.
1620
1621         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1622         was successfully resolved, but this would not show any status because the change had
1623         already been cached in the index using "git add".  The solution is to add an optional
1624         second argument to showStatus() which adds the "--cached" switch to the command.
1625
1626         * Scripts/resolve-ChangeLogs:
1627         (showStatus):
1628
1629 2007-10-28  Eric Seidel  <eric@webkit.org>
1630
1631         Reviewed by Maciej and Geoff, in unison.
1632
1633         * Scripts/run-webkit-tests: remove broken --svg option
1634
1635 2007-10-28  Darin Adler  <darin@apple.com>
1636
1637         Reviewed by Adam.
1638
1639         * Scripts/run-sunspider: Default to "Release" configuration rather than
1640         defaulting to the last configuration used as other scripts do. This can
1641         still be overriden on the command line with "--debug" if there's some
1642         reason to do so. Also fix a typo.
1643
1644         * Scripts/sunspider-compare-results: Fix a typo.
1645
1646 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1647
1648         Reviewed by Adam.
1649
1650         - Implemented the WebScriptDebugListener functions now that the
1651         WebScriptDebugServer exists
1652
1653         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1654         functions.
1655         (ServerConnection::currentFrame):
1656         (ServerConnection::didLoadMainResourceForDataSource):
1657         (ServerConnection::didParseSource):
1658         (ServerConnection::failedToParseSource):
1659         (ServerConnection::didEnterCallFrame):
1660         (ServerConnection::willExecuteStatement):
1661         (ServerConnection::willLeaveCallFrame):
1662         (ServerConnection::exceptionWasRaised):
1663         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1664         members arguments list.
1665
1666 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1667
1668         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1669         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1670
1671         Reviewed by Darin.
1672
1673         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1674         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1675         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1676         file.  Note that it may also be used as a stand-alone script.
1677
1678         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1679         * Scripts/resolve-ChangeLogs: Added.
1680         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1681
1682 2007-10-26  Mark Rowe  <mrowe@apple.com>
1683
1684         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1685         to the Qt port on the assumption that it was an implementation of the cross-platform
1686         LayoutTestController class.  It is not, so it did not need to be changed.
1687
1688         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1689
1690 2007-10-25  Mark Rowe  <mrowe@apple.com>
1691
1692         Reviewed by Maciej.
1693
1694         Fix builds with code coverage enabled.
1695
1696         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1697
1698 2007-10-25  Darin Adler  <darin@apple.com>
1699
1700         Reviewed by Mark Rowe.
1701
1702         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1703         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1704
1705 2007-10-25  Stephanie  <slewis@apple.com>
1706
1707         build Fix
1708
1709         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1710
1711 2007-10-25  Stephanie  <slewis@apple.com>
1712
1713         Reviewed by Mark Rowe, Adam Roben.
1714
1715         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1716
1717         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1718
1719 2007-10-25  Alice Liu  <alice.liu@apple.com>
1720
1721         Reviewed by Adam.
1722
1723         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1724
1725         Moving destructor into platform-specific files
1726         * DumpRenderTree/LayoutTestController.cpp:
1727         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1728         (LayoutTestController::~LayoutTestController):
1729         * DumpRenderTree/qt/jsobjects.cpp:
1730         (LayoutTestController::~LayoutTestController):
1731
1732         LayoutTestController wasn't being destroyed
1733         * DumpRenderTree/win/DumpRenderTree.cpp:
1734         (runTest):
1735
1736         Added declspec
1737         * DumpRenderTree/win/EditingDelegate.h:
1738
1739         Reset certain values on the webview (or related delegate) that might 
1740         have changed while running a test
1741         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1742         (LayoutTestController::~LayoutTestController):
1743
1744 2007-10-25  Adam Roben  <aroben@apple.com>
1745
1746         Make sunspider-compare-results work with relative paths
1747
1748         Reviewed by Sam.
1749
1750         * Scripts/sunspider-compare-results: Convert arguments to absolute
1751         paths before we chdir.
1752
1753 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1754
1755         Reviewed by Sam.
1756
1757         - Implemented server calls now the WebScriptDebugServer exists.
1758         - Also removed no longer needed call to initialize CG.
1759
1760         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1761         automatically now.
1762         (_tWinMain):
1763         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1764         (ServerConnection::ServerConnection):
1765         (ServerConnection::~ServerConnection):
1766         (ServerConnection::pause):
1767         (ServerConnection::resume):
1768         (ServerConnection::stepInto):
1769         (ServerConnection::applicationTerminating):
1770         (ServerConnection::serverConnectionDidDie):
1771         * Drosera/win/ServerConnection.h: Now uses the COM class.
1772
1773 2007-10-24  George Staikos  <staikos@kde.org>
1774
1775         Unbreak Qt build.
1776
1777         * Scripts/build-webkit:
1778
1779 2007-10-24  Adam Roben  <aroben@apple.com>
1780
1781         Remove now-unnecessary call to InitializeCoreGraphics
1782
1783         WebKit takes care of this now.
1784
1785         Reviewed by Ada.
1786
1787         * DumpRenderTree/win/DumpRenderTree.cpp:
1788         (initialize):
1789
1790 2007-10-24  Adam Roben  <aroben@apple.com>
1791
1792         Use WebTextRenderer in DRT
1793
1794         Reviewed by Ada.
1795
1796         * DumpRenderTree/win/DumpRenderTree.cpp:
1797         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1798
1799 2007-10-24  Sven Herzberg  <sven@imendio.com>
1800
1801         Reviewed by Mark Rowe.
1802
1803         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1804         Bug 15614: [GTK] qmake based backends don't build on OS X
1805
1806         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1807         GTK backend on a Mac
1808         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1809         isDarwin() to make it reusable in other places (like the workaround-
1810         for-prebuilt-qmake in build-webkit)
1811
1812 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1813
1814         Refurbish update-webkit script.
1815
1816         Reviewed by Adam.
1817
1818         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1819         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1820         multi-argument version of system() for flexibility and security.  Check for existence
1821         of Internal directory using -d test instead of -x.
1822
1823 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1824
1825         Minor clean-up of prepare-ChangeLog script.
1826
1827         Reviewed by Adam.
1828
1829         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1830         of a string.  Use multi-argument versions of open() and system() for flexibility and
1831         security.
1832
1833 2007-10-24  Alice Liu  <alice.liu@apple.com>
1834
1835         Reviewed by Oliver.
1836
1837         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1838
1839         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1840         replay the saved events when we're still processing the mousedown that starts the drag
1841         * DumpRenderTree/win/EventSender.cpp:
1842         (doMouseMove):
1843         * DumpRenderTree/win/UIDelegate.cpp:
1844         (UIDelegate::doDragDrop):
1845
1846 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1847
1848         Reviewed by Sam, Steve and Darin.
1849
1850         - Stubbed out the WebScriptDebugListener functionality in the Server
1851         Connection class to prepare it for receiving those callbacks.
1852         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1853         and the ServerConnection to not need to be initialized with a server
1854         name, since that is not the way we connect to the WebKit server. 
1855
1856         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1857         no exception.  Now it only loggs when there is an exception
1858         (DebuggerDocument::willExecuteStatement):
1859         (DebuggerDocument::didEnterCallFrame):
1860         (DebuggerDocument::willLeaveCallFrame):
1861         (DebuggerDocument::windowScriptObjectAvailable):
1862         (DebuggerDocument::callFunctionOnObject):
1863         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1864         to be instantiated with a server's name.
1865         (DebuggerClient::DebuggerClient):
1866         (DebuggerClient::didFinishLoadForFrame):
1867         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1868         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1869         a server name.
1870         (Drosera::init):
1871         (Drosera::initServer):
1872         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1873         instantiated with a server's name.
1874         * Drosera/win/ServerConnection.cpp: 
1875         (ServerConnection::ServerConnection): No longer needs a server name
1876         (ServerConnection::~ServerConnection): Only release the global context
1877         if there is one.
1878         (ServerConnection::serverConnectionDidDie): Stub for
1879         IWebScriptDebugListener
1880         (ServerConnection::QueryInterface): ditto
1881         (ServerConnection::AddRef): ditto
1882         (ServerConnection::Release): ditto
1883         (ServerConnection::didLoadMainResourceForDataSource): ditto
1884         (ServerConnection::didParseSource): ditto
1885         (ServerConnection::failedToParseSource): ditto
1886         (ServerConnection::didEnterCallFrame): ditto
1887         (ServerConnection::willExecuteStatement): ditto
1888         (ServerConnection::willLeaveCallFrame): ditto
1889         (ServerConnection::exceptionWasRaised): ditto
1890         * Drosera/win/ServerConnection.h: Stubbed out the
1891         IWebScriptDebugListener functions, and this class no longer needs to be
1892         instantiated with a server name.
1893
1894 2007-10-24  Lars Knoll  <lars@trolltech.com>
1895
1896         Reviewed by Simon.
1897
1898         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1899
1900         * DumpRenderTree/qt/jsobjects.h:
1901
1902 2007-10-24  Lars Knoll  <lars@trolltech.com>
1903
1904         Reviewed by Simon.
1905
1906         add another command.
1907
1908         * DumpRenderTree/qt/jsobjects.cpp:
1909         (TextInputController::doCommand):
1910
1911 2007-10-24  Lars Knoll  <lars@trolltech.com>
1912
1913         Reviewed by Simon.
1914
1915         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1916
1917         * DumpRenderTree/qt/jsobjects.cpp:
1918         (EventSender::keyDown):
1919         * DumpRenderTree/qt/jsobjects.h:
1920
1921 2007-10-24  Lars Knoll  <lars@trolltech.com>
1922
1923         Reviewed by Simon.
1924
1925         implement eventSender.keyDown().
1926
1927         * DumpRenderTree/qt/jsobjects.cpp:
1928         (EventSender::keyDown):
1929
1930 2007-10-24  Lars Knoll  <lars@trolltech.com>
1931
1932         Reviewed by Simon.
1933
1934         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1935
1936         * DumpRenderTree/qt/DumpRenderTree.cpp:
1937         (WebCore::DumpRenderTree::DumpRenderTree):
1938         (WebCore::DumpRenderTree::initJSObjects):
1939         * DumpRenderTree/qt/jsobjects.cpp:
1940         (TextInputController::doCommand):
1941
1942 2007-10-24  Lars Knoll  <lars@trolltech.com>
1943
1944         Reviewed by Simon.
1945
1946         first bit of implementation for the textinputcontroller.
1947
1948         * DumpRenderTree/qt/DumpRenderTree.cpp:
1949         (WebCore::DumpRenderTree::DumpRenderTree):
1950         * DumpRenderTree/qt/DumpRenderTree.h:
1951         * DumpRenderTree/qt/jsobjects.cpp:
1952         (TextInputController::TextInputController):
1953         (TextInputController::doCommand):
1954         * DumpRenderTree/qt/jsobjects.h:
1955
1956 2007-10-24  Lars Knoll  <lars@trolltech.com>
1957
1958         Reviewed by Simon.
1959
1960         make the man webpage believe it has focus, so the editing tests work correctly.
1961
1962         * DumpRenderTree/qt/DumpRenderTree.cpp:
1963         (WebCore::DumpRenderTree::DumpRenderTree):
1964
1965 2007-10-24  Lars Knoll  <lars@trolltech.com>
1966
1967         Reviewed by Simon.
1968
1969         implement layoutTestController.dumpEditingCallbacks() correctly.
1970
1971         * DumpRenderTree/qt/DumpRenderTree.cpp:
1972         (WebCore::DumpRenderTree::DumpRenderTree):
1973         * DumpRenderTree/qt/jsobjects.cpp:
1974         (LayoutTestController::reset):
1975         (LayoutTestController::dumpEditingCallbacks):
1976
1977 2007-10-24  Lars Knoll  <lars@trolltech.com>
1978
1979         Reviewed by Simon.
1980
1981         Implement support for testing editing.
1982
1983         * DumpRenderTree/qt/DumpRenderTree.cpp:
1984         (WebCore::DumpRenderTree::DumpRenderTree):
1985
1986 2007-10-23  Sam Weinig  <sam@webkit.org>
1987
1988         Check for null BSTR that can be passed to the UIDelegate methods
1989         from javascript null and undefined.  Fixes a failing test case on
1990         Windows (fast/dom/Window/alert-undefined.html)
1991
1992         Reviewed by Eric Seidel.
1993
1994         * DumpRenderTree/win/UIDelegate.cpp:
1995         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1996         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1997         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1998         (UIDelegate::webViewAddMessageToConsole):
1999
2000 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2001
2002         Reviewed by Darin.
2003         
2004         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2005
2006         * Scripts/build-testkjs:
2007
2008 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2009
2010         Reviewed by Darin.
2011
2012         - add wrapper that finds the right copy of testkjs
2013         
2014         * Scripts/sunspider-compare-results: Added.
2015
2016 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2017
2018         Reviewed by Sam.
2019
2020         - After talking with Steve I now see that the WebKit server must be
2021         running for DCOM to create the distributed objects, which makes sense
2022         and currently WebKit only allows one instance to be running at a time
2023         which avoids accidentally connecting to the wrong server
2024         - In light of this I have removed the code for the attach box and
2025         NotificationServer and known server names, since they are all extranious
2026         now.
2027
2028         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2029         names.
2030         (_tWinMain): Uses init instead of initUI.
2031         (droseraWndProc): No longer creats an attach dialog box.
2032         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2033         it's not manditory to call init before doing COM stuff.
2034         (Drosera::init): calls initUI and will call attach when the
2035         functionality exists. 
2036         (Drosera::initUI): Has changed very little.
2037         (Drosera::attach): Changed the signature to reflect that we no longer
2038         need the dictionary of known server names.
2039         * Drosera/win/Drosera.h: Removed notification classes and known server
2040         names.  Also renamed and moved some functions.
2041         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2042         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2043         headers to the resources folder. 
2044         * Drosera/win/resource.h: Removed the Attach box.
2045
2046 2007-10-22  Adam Roben  <aroben@apple.com>
2047
2048         Windows build fix
2049
2050         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2051
2052 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2053
2054         - Removed a leak that was fixed.
2055
2056         * Scripts/run-webkit-tests:
2057
2058 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2059
2060         Reviewed by Darin.
2061
2062         - Changed the Client so that the DebuggerDocument now own the
2063         ServerConnection.  This simplifies ownership and cleanup. 
2064
2065         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2066         ServerConnection.
2067         (DebuggerClient::initWithServerName):
2068         (DebuggerClient::didFinishLoadForFrame):
2069         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2070         ServerConnection.
2071         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2072         until after we have a server which we are attached to.
2073         (Drosera::initUI):
2074         (Drosera::attach):
2075         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2076         out previously.
2077
2078 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2079
2080         Reviewed by Nikolas.
2081
2082         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2083
2084         * Scripts/run-javascriptcore-tests:
2085
2086 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2087
2088         Reviewed by Nikolas.
2089
2090         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2091
2092         * Scripts/build-drosera:
2093         * Scripts/build-dumprendertree:
2094         * Scripts/build-testkjs:
2095         * Scripts/build-webkit:
2096         * Scripts/run-javascriptcore-tests:
2097         * Scripts/run-sunspider:
2098         * Scripts/run-webkit-tests:
2099         * Scripts/webkitdirs.pm:
2100
2101 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2102
2103         Reviewed by Mark Rowe.
2104         
2105         Fix for local database support after r26879
2106         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2107
2108         * Scripts/build-webkit:
2109
2110 2007-10-22  Holger Freyther  <zecke@selfish.org>
2111
2112         Reviewed by Simon Hausmann <hausmann@kde.org>.
2113
2114         - Do not build testkjs as an application bundle. This is
2115         needed for run-javascriptcore-tests on OSX.
2116         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2117         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2118         as we do not have -rpath on OSX.
2119
2120         * DumpRenderTree/qt/DumpRenderTree.pro:
2121         * Scripts/run-webkit-tests:
2122
2123 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2124
2125         Reviewed by aroben.
2126
2127         Fix support for Signed-off-by detection in prepare-ChangeLog
2128         --git-commit. The Signed-off-by tag does not appear in the header
2129         but usually at the end.
2130
2131         * Scripts/prepare-ChangeLog:
2132
2133 2007-10-21  Mark Rowe  <mrowe@apple.com>
2134
2135         Reviewed by Eric.
2136
2137         Fix run-javascriptcore-tests for Gtk.
2138
2139         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2140
2141 2007-10-20  Eric Seidel  <eric@webkit.org>
2142
2143         Reviewed by aroben.
2144
2145         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2146
2147 2007-10-20  Eric Seidel  <eric@webkit.org>
2148
2149         Reviewed by darin.
2150         
2151         Add improved argument handling to run-sunspider, including
2152         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2153         Also re-factor code into subroutines
2154
2155         * Scripts/build-dumprendertree: removed bogus comments
2156         * Scripts/build-testkjs: Added.
2157         * Scripts/run-javascriptcore-tests: use build-testkjs
2158         * Scripts/run-sunspider: improved argument handling, abstraction
2159         * Scripts/run-webkit-tests: improved abstraction
2160
2161 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2162
2163         Not reviewed, Windows build fix.
2164
2165         * DumpRenderTree/win/EventSender.cpp:
2166         (keyDownCallback):
2167
2168 2007-10-20  Darin Adler  <darin@apple.com>
2169
2170         Reviewed by Tim Hatcher.
2171
2172         - http://bugs.webkit.org/show_bug.cgi?id=15544
2173           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2174           not rely on Apple-specific key codes
2175
2176         * DumpRenderTree/mac/EventSendingController.mm:
2177         (-[EventSendingController keyDown:withModifiers:]):
2178         Added named key "rightArrow". Later we could have a whole table of these.
2179         Also tweaked modifiers code a little.
2180
2181         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2182
2183 2007-10-19  Darin Adler  <darin@apple.com>
2184
2185         Reviewed by Eric.
2186
2187         - http://bugs.webkit.org/show_bug.cgi?id=15566
2188           possible fix for leak seen in DumpRenderTree
2189
2190         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2191         Delete the item if it's not put on the queue, since the caller has
2192         no way of knowing that. Would be better to have the parameter type
2193         be auto_ptr to express the fact that we take ownership.
2194
2195         - unrelated change
2196
2197         * Drosera/mac/main.m: Add missing include.
2198
2199 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2200
2201         Reviewed by Adam.
2202
2203         - This change should be identical but for some reason was not working
2204         on my machine.
2205
2206         * Scripts/prepare-ChangeLog:
2207
2208 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2209
2210         Reviewed by Oliver and Tim.
2211
2212         - Made use of RetainPtr to avoid retain and release issues and moved the
2213         log function to DebuggerDocumentPlatform, which seems to be a more
2214         logical place for it to live.
2215         - Also moved knownServers from the ServerConnection to
2216         DebuggerApplication to match the Windows code and because it makes sense
2217         that a connection knows its own server but not all of them.
2218
2219         * Drosera/mac/DebuggerClient.h: Moved the log function to
2220           DebuggerDocumentPlatform.
2221         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2222           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2223           call for the server name up from the ServerConnection class.
2224         (-[DebuggerClient dealloc]):
2225         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2226           for the server name up from the ServerConnection.
2227         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2228         (DebuggerDocument::platformPause):
2229         (DebuggerDocument::platformResume):
2230         (DebuggerDocument::platformStepInto):
2231         (DebuggerDocument::platformEvaluateScript):
2232         (DebuggerDocument::getPlatformCurrentFunctionStack):
2233         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2234         (DebuggerDocument::platformValueForScopeVariableNamed):
2235         (DebuggerDocument::platformLog): Log directly from here. No need to call
2236           DebuggerClient.
2237         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2238           way I see it, a ServerConnection should only know about its connection
2239           and the group of all possible servers should be kept by the
2240           application.
2241         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2242           currentServerName, it makes sense that the connection should know that
2243           name.
2244         (-[ServerConnection currentServerName]):
2245
2246 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2247
2248         Reviewed by Adam.
2249
2250         - Integrated changes from mac drosera.  Recently I've encapsulated
2251         out the server connection object from the rest of Drosera because
2252         it is very platform dependent right now and RPC is not implemented on
2253         windows.  This functionality, of communicating with the WebKit server
2254         is the next area I will be focusing on in Windows.
2255
2256         - Other changes and cleanup were made to organize the code and add notes
2257         on which parts still need work.  Also some mac code is added and
2258         commented out, to act as pseudocode for the logic of those parts.
2259
2260         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2261           pointer.
2262         * Drosera/config.h: Added whitespace.
2263         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2264           these files got moved into Drosera.h/cpp
2265         * Drosera/win/DebuggerApplication.h: Removed.
2266         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2267           happened here to better match the logic flow of the same code on the 
2268           mac side and to use the new ServerConnection class.
2269         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2270         (DebuggerClient::initWithServerName): Initializer that will set up the
2271           class to use a ServerConnection object.  This was necessary so I could
2272           create a DebuggerClient without having to initilaize it at
2273           construction.
2274         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2275           will be the UIDelegate and FrameLoadDelegate.
2276         (DebuggerClient::AddRef): For IUnknown.
2277         (DebuggerClient::Release): For IUnknown.
2278         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2279           this still needs to set the global context of the server, but
2280           IWebFrame does not have an accessor for the global context yet. 
2281         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2282           this is a pass through for the same function in the document.
2283         (DebuggerClient::didReceiveTitle): Unimplemented part of
2284           FrameLoadDelegate this would change the title of the window.
2285         (DebuggerClient::createWebViewWithRequest): Part of the
2286           FrameLoadDelegate.  This is about new windows via Window.open() and
2287           how their delegates are set.
2288         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2289           UIDelegate.  Just a debug function for printing messages.
2290         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2291           because the Client should be the UIDelegate and FrameLoadDelegate
2292           to match the delegates on mac.
2293         (DebuggerClient::webViewLoaded): Added accessor method.
2294         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2295           forgotten to add this file before.  This is where the platform
2296           dependent versions of the Documents functions live. Most of these are
2297           unimplemented because some piece of functionality does not exist on
2298           Windows yet.
2299         (DebuggerDocument::platformPause):
2300         (DebuggerDocument::platformResume):
2301         (DebuggerDocument::platformStepInto):
2302         (DebuggerDocument::platformEvaluateScript):
2303         (DebuggerDocument::getPlatformCurrentFunctionStack):
2304         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2305         (DebuggerDocument::platformValueForScopeVariableNamed):
2306         (DebuggerDocument::platformLog):
2307         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2308           responsibilities becaue they belong in the Client. Also I laid the
2309           groundwork for attaching Drosera to a WebKit process
2310         (attachWndProc): Now if a server is selected the Client becomes it's
2311           delegate.
2312         (Drosera::Drosera): Added the construction of the Client and dictionary
2313           of server names. 
2314         (Drosera::initUI): This is no longer the delegates, the Client is.
2315         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2316           state. 
2317         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2318           notification registration when it's possible to implement.
2319         (Drosera::serverLoaded): Ditto
2320         (Drosera::serverUnloaded): Ditto
2321         (Drosera::attach): Attach Drosera to the WebKit server.
2322         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2323         (Drosera::getInst): 
2324         (Drosera::setInst):
2325         (Drosera::knownServers):
2326         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2327           and added the ServerConnection.
2328         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2329         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2330           Most of the functions are completely unimlemented because they cannot
2331           connect with the WebKit server, because one does not exist on Windows
2332           yet.
2333         (ServerConnection::initWithServerName): 
2334         (ServerConnection::~ServerConnection):
2335         (ServerConnection::setGlobalContext):
2336         (ServerConnection::pause):
2337         (ServerConnection::resume):
2338         (ServerConnection::stepInto):
2339         (ServerConnection::switchToServerNamed):
2340         (ServerConnection::applicationTerminating):
2341         (ServerConnection::serverConnectionDidDie):
2342         (ServerConnection::currentFrame):
2343         * Drosera/win/ServerConnection.h: Added. Ditto.
2344         (ServerConnection::ServerConnection):
2345
2346 2007-10-19  Alice Liu  <alice.liu@apple.com>
2347
2348         Reviewed by Darin.
2349
2350         Fix for these broken layout tests on Windows:
2351         
2352         fast/forms/focus-selection-input.html
2353         fast/forms/focus-selection-textarea.html
2354         fast/forms/select-accesskey.html
2355         
2356         * DumpRenderTree/win/EventSender.cpp:
2357         (keyDownCallback):
2358         correct the VK code for alt key.
2359         
2360 2007-10-19  Eric Seidel  <eric@webkit.org>
2361
2362         Reviewed by Mark Rowe.
2363         
2364         Make the GtkLauncher code slightly more readable.
2365
2366         * GtkLauncher/main.cpp:
2367         (setupMainMenu): Added.
2368         (setupMainWindowUI): Added.
2369         (main):
2370
2371 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2372
2373         Rubber stamped by Adam.
2374         
2375         - don't delay-load WebKit in DumpRenderTree.
2376
2377         * DumpRenderTree/win/DumpRenderTree.vcproj:
2378
2379 2007-10-18  Dan Bernstein  <mitz@apple.com>
2380
2381         Reviewed by Adam Roben.
2382
2383         - fix <rdar://problem/5313523>
2384         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2385
2386         * DumpRenderTree/mac/DumpRenderTree.mm:
2387         (dump): Changed to use _responseMIMEType.
2388
2389 2007-10-17  Adam Roben  <aroben@apple.com>
2390
2391         Make it possible to have Windows-specific tests and results
2392
2393         When searching for tests to run and the Skipped file, we will only
2394         look in platform/win and the cross-platform directory. When looking
2395         for expected results, we will look in platform/win, then
2396         platform/mac-leopard, then platform/mac, then finally the
2397         cross-platform directory.
2398
2399         Reviewed by Sam.
2400
2401         * Scripts/run-webkit-tests:
2402         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2403         searching in the cross-platform directory.
2404         (sub buildPlatformHierarchy): Removed some unneeded calls to
2405         dirname/basename.
2406
2407 2007-10-17  Adam Roben  <aroben@apple.com>
2408
2409         Add back the call to register WebKit that we had before WebKitInitializer existed
2410
2411         This is needed to ensure that the right WebKit is used when
2412         instantiating COM objects.
2413
2414         Reviewed by Oliver.
2415
2416         * DumpRenderTree/win/debug_internal.vsprops: Define
2417         DEBUG_WEBKIT_HAS_SUFFIX.
2418         * DumpRenderTree/win/DumpRenderTree.cpp:
2419         (initialize):
2420
2421 2007-10-17  Adam Roben  <aroben@apple.com>
2422
2423         Import File::Basename in webkitdirs since we use it
2424
2425         * Scripts/webkitdirs.pm:
2426
2427 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2428
2429         - Updated the tiger leaks list to make the internal bots green.
2430
2431         * Scripts/run-webkit-tests:
2432
2433 2007-10-17  Adam Roben  <aroben@apple.com>
2434
2435         Build fix for VC++ Express
2436
2437         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2438         and ole32.lib.
2439
2440 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2441
2442         Reviewed by Sam.
2443
2444         - Minor mac improvements based on observations I made while implementing the
2445         Windows code.
2446
2447         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2448         then hand it to the Client who will retain it, it should just be the client who
2449         creates and owns the server.
2450         (-[DebuggerApplication attach:]):
2451         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2452         * Drosera/mac/DebuggerClient.mm: Creates the server.
2453         (-[DebuggerClient initWithServerName:]):
2454         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2455         can instead forward declare what it needs.
2456
2457 2007-10-16  Darin Adler  <darin@apple.com>
2458
2459         Reviewed by Geoff Garen.
2460
2461         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2462         want to turn failing tests into platform-specific test results. Also did a
2463         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2464         would take the type of results into account only some of the time.
2465
2466 2007-10-16  Adam Roben  <aroben@apple.com>
2467
2468         Add a new nightly launcher script for Windows
2469
2470         This new script is for versions of Safari that don't delay-load
2471         WebKit. I had to make FindSafari be able to print out the nightly
2472         launcher script on stdout because Windows shell scripts can't capture
2473         the output from a command into an environment variable.
2474
2475         Reviewed by Steve.
2476
2477         * FindSafari/FindSafari.cpp:
2478         (_tmain): Added /printSafariLauncher option.
2479         * Scripts/run-webkit-nightly.cmd: Added.
2480
2481 2007-10-16  Adam Roben  <aroben@apple.com>
2482
2483         Replace WebKitInitializer with FindSafari
2484
2485         We now rely on setting the PATH environment variable to tell Windows
2486         where to find WebKit and its dependencies (similar to
2487         DYLD_FRAMEWORK_PATH on Mac).
2488
2489         This change also make DumpRenderTree no longer delay-load WebKit.
2490
2491         Reviewed by Sam.
2492
2493         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2494         FindSafari.
2495         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2496         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2497         WebKitInitializer, don't delay-load WebKit.
2498         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2499         * Scripts/run-webkit-tests: Ditto.
2500         * Scripts/webkitdirs.pm:
2501         (sub setPathForRunningWebKitApp): Added.
2502         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2503         * WebKitInitializer/WebKitInitializer.h: Removed.
2504         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2505         * WebKitInitializer/debug.vsprops: Removed.
2506         * WebKitInitializer/debug_internal.vsprops: Removed.
2507         * WebKitInitializer/release.vsprops: Removed.
2508
2509 2007-10-16  Adam Roben  <aroben@apple.com>
2510
2511         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2512
2513         http://bugs.webkit.org/show_bug.cgi?id=15532
2514
2515         FindSafari simply prints the location of an installed Safari.exe on
2516         stdout.
2517
2518         Reviewed by Darin.
2519
2520         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2521         (getStringValue):
2522         (getWebViewCLSID):
2523         (getInstalledWebKitDirectory):
2524         (_tmain):
2525         * FindSafari/FindSafari.vcproj: Added.
2526         * Scripts/webkitdirs.pm:
2527         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2528
2529 2007-10-16  Adam Roben  <aroben@apple.com>
2530
2531         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2532
2533         Reviewed by Kevin McCullough.
2534
2535         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2536         when referring to WebKit.dll.
2537         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2538         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2539         * DumpRenderTree/win/release.vsprops: Ditto.
2540         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2541         never have a _debug suffix on WebKit.dll.
2542         * WebKitInitializer/WebKitInitializer.cpp:
2543         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2544         specified.
2545         * WebKitInitializer/debug_internal.vsprops: Added
2546         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2547
2548 2007-10-16  Darin Adler  <darin@apple.com>
2549
2550         Reviewed by Adele.
2551
2552         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2553         Remove now-unneeded control/alt key hack; the tests have been updated.
2554
2555 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2556
2557         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2558         one of the leaks was fixed between that revision and the bot's previous version of
2559         leopard.
2560
2561         * Scripts/run-webkit-tests:
2562
2563 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2564
2565         Reviewed by Tim.
2566
2567         - I encapsulated out the server connecton functionality because it is a specific part
2568         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2569         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2570         Windows.  So the majority of this patch is moving preexisting functionality.
2571
2572         - Also I removed the prefix header and changed to use config.h because it is more
2573         standard on how we use config.h in windows and it didn't make much sense to keep
2574         the prefix header and the config.h
2575
2576         * Drosera/DebuggerDocument.cpp:
2577         (DebuggerDocument::DebuggerDocument):
2578         * Drosera/DebuggerDocument.h:
2579         * Drosera/config.h:
2580         * Drosera/mac/DebuggerApplication.mm:
2581         (-[DebuggerApplication attach:]):
2582         * Drosera/mac/DebuggerClient.h:
2583         * Drosera/mac/DebuggerClient.mm:
2584         (-[DebuggerClient initWithServerConnection:]):
2585         (-[DebuggerClient dealloc]):
2586         (-[DebuggerClient windowDidLoad]):
2587         (-[DebuggerClient windowWillClose:]):
2588         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2589         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2590         * Drosera/mac/DebuggerDocumentPlatform.mm:
2591         (DebuggerDocument::platformPause):
2592         (DebuggerDocument::platformResume):
2593         (DebuggerDocument::platformStepInto):
2594         (DebuggerDocument::platformEvaluateScript):
2595         (DebuggerDocument::getPlatformCurrentFunctionStack):
2596         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2597         (DebuggerDocument::platformValueForScopeVariableNamed):
2598         (DebuggerDocument::platformLog):
2599         * Drosera/mac/Drosera.pch: Removed.
2600         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2601         * Drosera/mac/ServerConnection.h: Added.
2602         * Drosera/mac/ServerConnection.mm: Added.
2603         (-[ServerConnection initWithServerName:]):
2604         (-[ServerConnection dealloc]):
2605         (-[ServerConnection setGlobalContext:]):
2606         (-[ServerConnection pause]):
2607         (-[ServerConnection resume]):
2608         (-[ServerConnection stepInto]):
2609         (-[ServerConnection switchToServerNamed:]):
2610         (-[ServerConnection applicationTerminating:]):
2611         (-[ServerConnection serverConnectionDidDie:]):
2612         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2613         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2614         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2615         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2616         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2617         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2618         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2619         (-[ServerConnection currentFrame]):
2620         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2621         (-[ServerConnection knownServers]):
2622
2623 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2624
2625         Reviewed by Eric.
2626
2627         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2628           Script to automatically search nightly builds for regressions (bisect-builds)
2629
2630         * Scripts/bisect-builds: Added.
2631
2632 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2633
2634         Reviewed by Darin.
2635
2636         - New JavaScript benchmark
2637         http://bugs.webkit.org/show_bug.cgi?id=15515
2638
2639         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2640         current development or release build of JavaScriptCore.
2641
2642 2007-10-15  Mark Rowe  <mrowe@apple.com>
2643
2644         Reviewed by Sam.
2645
2646         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2647
2648         * Scripts/webkitdirs.pm:
2649         - Change checkArgv to remove the options from @ARGV to prevent
2650         them from interfering with further option processing.
2651         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2652         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2653         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2654         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2655
2656 2007-10-15  Darin Adler  <darin@apple.com>
2657
2658         Reviewed by Sam.
2659
2660         - added logging of window.prompt and window.confirm
2661
2662         * DumpRenderTree/mac/UIDelegate.mm:
2663         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2664         Implement the recommended delegate rather than the deprecated one.
2665         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2666         Added.
2667         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2668         Added.
2669
2670         * DumpRenderTree/win/UIDelegate.h:
2671         * DumpRenderTree/win/UIDelegate.cpp:
2672         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2673         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2674         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2675         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2676
2677 2007-10-15  Alice Liu  <alice.liu@apple.com>
2678
2679         Reviewed by Sam Weinig.
2680
2681         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2682
2683         * DumpRenderTree/win/DumpRenderTree.cpp:
2684         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2685         (main): allocate the global policy delegate for DRT's custom use
2686         * DumpRenderTree/win/DumpRenderTree.vcproj:
2687         Adding files to project
2688         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2689         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2690         (LayoutTestController::setCustomPolicyDelegate):
2691         set the webview's policy delegate to DRT's custom one if the test requests it.
2692         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2693         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2694         (PolicyDelegate::PolicyDelegate):
2695         (PolicyDelegate::QueryInterface):
2696         (PolicyDelegate::AddRef):
2697         (PolicyDelegate::Release):
2698         (PolicyDelegate::decidePolicyForNavigationAction):
2699         * DumpRenderTree/win/PolicyDelegate.h: Added.
2700         (PolicyDelegate::decidePolicyForNewWindowAction):
2701         (PolicyDelegate::decidePolicyForMIMEType):
2702         (PolicyDelegate::unableToImplementPolicyWithError):
2703
2704 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2705
2706         Reviewed by Mark.
2707
2708         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2709         when querying for QMAKE_MKSPECS.
2710
2711 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2712
2713         Reviewed by Adam Roben.
2714         
2715         Fix run-webkit-tests is too greedy calculating platform hierarchy
2716         http://bugs.webkit.org/show_bug.cgi?id=15465
2717         
2718         Fix run-webkit-tests being too greedy in trying to split the platform name up
2719         causing it to try and find tests in every directory above the first "-" in the
2720         path to the LayoutTests
2721
2722         * Scripts/run-webkit-tests:
2723
2724 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2725
2726         Reviewed by Darin.
2727
2728         http://bugs.webkit.org/show_bug.cgi?id=15006
2729         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2730         to reduce code duplication.
2731
2732         * Scripts/build-webkit:
2733         * Scripts/webkitdirs.pm:
2734         buildQMakeProject() renamed to buildQMakeQtProject().
2735         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2736         unused $colorize has been removed.
2737
2738 === Start merge of feature-branch 2007-10-12 ===
2739
2740 2007-10-08  Eric Seidel  <eric@webkit.org>
2741
2742         Reviewed by Mark Rowe.
2743
2744         * Scripts/build-webkit: add --help, remove unused --color
2745
2746 2007-10-07  Eric Seidel  <eric@webkit.org>
2747
2748         Reviewed by darin.
2749
2750         * Drosera/mac/DebuggerDocumentPlatform.mm:
2751         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2752
2753 2007-10-03  Rob Buis  <buis@kde.org>
2754
2755         Reviewed by Olliej.
2756
2757         Adapt to changed location of Ahem font.
2758
2759         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2760
2761 2007-10-02  Eric Seidel  <eric@webkit.org>
2762
2763         Reviewed by Adam Roben.
2764         
2765         Make pixel tests more useful!
2766         Finally fix the image diff 0.00% mystery problem
2767         Highlight any image differences in the image diff.
2768         Add a link from image diffs back to original test file.
2769
2770         * DumpRenderTree/mac/ImageDiff.m:
2771         (compareImages): highlight any differences
2772         (computePercentageDifferent): round to two decimal places
2773         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2774
2775 2007-10-02  Eric Seidel  <eric@webkit.org>
2776
2777         Reviewed by Alexey Proskuryakov.
2778
2779         * Scripts/run-webkit-tests: print the % image difference on main results page
2780
2781 2007-10-02  Mark Rowe  <mrowe@apple.com>
2782
2783         Reviewed by Oliver.
2784
2785         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2786
2787         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2788         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2789
2790 2007-10-01  Mark Rowe  <mrowe@apple.com>
2791
2792         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2793
2794 2007-09-25  Eric Seidel  <eric@webkit.org>
2795
2796         Reviewed by Mark Rowe.
2797         
2798         DerivedSources.make was finding "ENABLE_SVG" in the string
2799         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2800         quite correctly.
2801
2802         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2803
2804 2007-09-25  Mark Rowe  <mrowe@apple.com>
2805
2806         Rubber-stamped by Eric.
2807
2808         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2809         This makes it possible to automate nightly builds for the feature-branch.
2810
2811 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2812
2813         Rubber stamped by Mark.
2814
2815         Enable svg experimental features as default here in feature-branch.
2816
2817         * Scripts/build-webkit:
2818
2819 2007-06-29  Antti Koivisto  <antti@apple.com>
2820
2821         Reviewed by Weinig.
2822         
2823         Add VIDEO flag for timed media features
2824
2825         * Scripts/build-webkit
2826         
2827 === End merge of feature-branch 2007-10-12 ===
2828
2829 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2830
2831         Reviewed by Darin.
2832
2833         - Updated rational for the leaks list to be more clear.
2834
2835         * Scripts/run-webkit-tests:
2836
2837 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2838
2839         Rubber Stamp by Sam.
2840
2841         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2842         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2843
2844         * Scripts/run-webkit-tests:
2845
2846 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2847
2848         Reviewed by Lars.
2849
2850         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2851         includes are needed for INT_MAX, std::auto_ptr and the like.
2852
2853         * DumpRenderTree/qt/main.cpp:
2854
2855 2007-10-09  Lars Knoll  <lars@trolltech.com>
2856
2857         Reviewed by Simon.
2858
2859         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2860
2861         * DumpRenderTree/qt/jsobjects.cpp:
2862         (LayoutTestController::encodeHostName):
2863         (LayoutTestController::decodeHostName):
2864         * DumpRenderTree/qt/jsobjects.h:
2865
2866 2007-10-09  Lars Knoll  <lars@trolltech.com>
2867
2868         Reviewed by Simon.
2869
2870         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2871
2872         * DumpRenderTree/qt/DumpRenderTree.cpp:
2873         (WebCore::WebPage::createFrame):
2874         (WebCore::DumpRenderTree::DumpRenderTree):
2875         (WebCore::DumpRenderTree::titleChanged):
2876         * DumpRenderTree/qt/DumpRenderTree.h:
2877         * DumpRenderTree/qt/jsobjects.cpp:
2878         (LayoutTestController::reset):
2879         * DumpRenderTree/qt/jsobjects.h:
2880
2881 2007-10-09  Lars Knoll  <lars@trolltech.com>
2882
2883         Reviewed by Simon.
2884
2885         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2886
2887         * DumpRenderTree/qt/DumpRenderTree.h:
2888         * DumpRenderTree/qt/jsobjects.cpp:
2889         (LayoutTestController::clearBackForwardList):
2890         * DumpRenderTree/qt/jsobjects.h:
2891
2892 2007-10-09  Lars Knoll  <lars@trolltech.com>
2893
2894         Reviewed by Simon.
2895
2896         make --git-reviewer work again.
2897
2898         * Scripts/prepare-ChangeLog:
2899
2900 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2901
2902         Rubber stamped by Eric.
2903
2904         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2905         show the current link inside the statusbar.
2906         This shows how to make use of this signal and allows to easily test
2907         http://bugs.webkit.org/show_bug.cgi?id=15299.
2908
2909         * GtkLauncher/main.cpp:
2910         (hoveringOverLink):
2911         (main):
2912
2913 2007-10-05  Lars Knoll  <lars@trolltech.com>
2914
2915         add proper error messages to the FrameLoaderClient.
2916         Implement ChromeClientQt::closeWindowSoon and
2917         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2918         Some fixes in DRT to make it work correctly with multiple windows.
2919
2920         Reviewed by Maciej.
2921
2922         * DumpRenderTree/qt/DumpRenderTree.cpp:
2923         (WebCore::DumpRenderTree::DumpRenderTree):
2924         (WebCore::DumpRenderTree::createWindow):
2925         (WebCore::DumpRenderTree::windowCount):
2926         * DumpRenderTree/qt/DumpRenderTree.h:
2927         * DumpRenderTree/qt/jsobjects.cpp:
2928         (LayoutTestController::maybeDump):
2929         (LayoutTestController::windowCount):
2930         * DumpRenderTree/qt/jsobjects.h:
2931
2932 2007-10-05  Lars Knoll  <lars@trolltech.com>
2933
2934         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2935         Add support for layoutTextController.setCanOpenWindows() to DRT
2936         fixing another 2 test cases in fast/dom/Window.
2937
2938         Reviewed by Maciej.
2939
2940         * DumpRenderTree/qt/DumpRenderTree.cpp:
2941         (WebCore::WebPage::WebPage):
2942         (WebCore::WebPage::createWindow):
2943         (WebCore::DumpRenderTree::resetJSObjects):
2944         (WebCore::DumpRenderTree::createWindow):
2945         * DumpRenderTree/qt/DumpRenderTree.h:
2946         * DumpRenderTree/qt/DumpRenderTree.pro:
2947         * DumpRenderTree/qt/jsobjects.cpp:
2948         (LayoutTestController::LayoutTestController):
2949         (LayoutTestController::reset):
2950         * DumpRenderTree/qt/jsobjects.h:
2951         * DumpRenderTree/qt/main.cpp:
2952         * DumpRenderTree/qt/testplugin.cpp: Added.
2953         * DumpRenderTree/qt/testplugin.h: Added.
2954
2955 2007-10-04  Sam Weinig  <sam@webkit.org>
2956
2957         Rubber stamped by Adam.
2958
2959         Remove empty directories.
2960
2961         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2962         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2963
2964 2007-10-03  Darin Adler  <darin@apple.com>
2965
2966         Reviewed by Adam.
2967
2968         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2969         we find the internal libraries in the libraries directory. This
2970         is helpful for Safari team engineers at Apple.
2971
2972 2007-10-03  Adam Roben  <aroben@apple.com>
2973
2974         Update the location of AHEM___.TTF after r25968
2975
2976         Reviewed by Sam.
2977
2978         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2979
2980 2007-10-03  Alp Toker  <alp@atoker.com>
2981
2982         Reviewed by Adam.
2983
2984         http://bugs.webkit.org/show_bug.cgi?id=14726
2985         [gtk] API design. Mapping the WebView delegates to signals.
2986
2987         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2988
2989         * GtkLauncher/main.cpp:
2990         (goToURLBarText):
2991         (titleChanged):
2992         (progressChanged):
2993         (menuMainBackCallback):
2994         (menuMainForwardCallback):
2995         (main):
2996
2997 2007-10-03  Lars Knoll  <lars@trolltech.com>
2998
2999         Reviewed by Rob.
3000
3001         This fixes --strict mode in run-webkit-tests again after
3002         the platform dependent test results have been moved.
3003
3004         * Scripts/run-webkit-tests:
3005
3006 2007-10-03  Lars Knoll  <lars@trolltech.com>
3007
3008         Reviewed by bdash.
3009
3010         remove the hack in run-webkit-tests that forced text only test
3011         to be taken from the platform independent dir. It was only left
3012         there from early days.
3013         
3014         Remove platform dependent results for tests that are text only nowadays,
3015         and add one platform dependent result for a text only test that requires it.
3016
3017         * Scripts/run-webkit-tests:
3018
3019 2007-10-03  Lars Knoll  <lars@trolltech.com>
3020
3021         Reviewed by olliej.
3022
3023         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3024
3025         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3026         (WebCore::WebFrame::WebFrame):
3027         (WebCore::WebPage::WebPage):
3028         (WebCore::WebPage::createFrame):
3029         (WebCore::WebPage::javaScriptAlert):
3030         (WebCore::WebPage::javaScriptConsoleMessage):
3031         (WebCore::DumpRenderTree::DumpRenderTree):
3032         (WebCore::DumpRenderTree::~DumpRenderTree):
3033         (WebCore::DumpRenderTree::open):
3034         (WebCore::DumpRenderTree::readStdin):
3035         (WebCore::DumpRenderTree::resetJSObjects):
3036         (WebCore::DumpRenderTree::initJSObjects):
3037         (WebCore::DumpRenderTree::dumpFramesAsText):
3038         (WebCore::DumpRenderTree::dump):
3039         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3040         (WebCore::DumpRenderTree::layoutTestController):
3041         (WebCore::DumpRenderTree::eventSender):
3042         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3043         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3044         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3045         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3046         (HackWebFrame::mousePressEvent):
3047         (HackWebFrame::mouseReleaseEvent):
3048         (HackWebFrame::mouseMoveEvent):
3049         (HackWebFrame::HackWebFrame):
3050         (HackWebFrame::~HackWebFrame):
3051         (LayoutTestController::LayoutTestController):
3052         (LayoutTestController::reset):
3053         (LayoutTestController::maybeDump):
3054         (LayoutTestController::waitUntilDone):
3055         (LayoutTestController::notifyDone):
3056         (LayoutTestController::dumpEditingCallbacks):
3057         (LayoutTestController::queueReload):
3058         (LayoutTestController::provisionalLoad):
3059         (LayoutTestController::timerEvent):
3060         (EventSender::EventSender):
3061         (EventSender::mouseDown):
3062         (EventSender::mouseUp):
3063         (EventSender::mouseMoveTo):
3064         (EventSender::leapForward):
3065         (EventSender::keyDown):
3066         (EventSender::frameUnderMouse):
3067         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3068         (LayoutTestController::isLoading):
3069         (LayoutTestController::setLoading):
3070         (LayoutTestController::shouldDumpAsText):
3071         (LayoutTestController::shouldDumpChildrenAsText):
3072         (LayoutTestController::shouldWaitUntilDone):
3073         (LayoutTestController::dumpAsText):
3074         (LayoutTestController::dumpChildFramesAsText):
3075         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3076         (messageHandler):
3077         (crashHandler):
3078         (main):
3079         * Scripts/run-webkit-tests:
3080
3081 2007-10-03  Mark Rowe  <mrowe@apple.com>
3082
3083         Reviewed by Alp Toker.
3084
3085         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3086         should take precedence over QTDIR when determining which port we are working with.
3087
3088         * Scripts/webkitdirs.pm: 
3089
3090 2007-10-02  Adam Roben  <aroben@apple.com>
3091
3092         Add keychain to the list of default packages to install
3093
3094         Rubberstamped by Sam.
3095
3096         * CygwinDownloader/cygwin-downloader.py:
3097         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3098
3099 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3100
3101         Reviewed by Adam.
3102
3103         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3104         Also makes WebCore regression test case logic work when using git.
3105
3106         * Scripts/prepare-ChangeLog:
3107         (reviewerAndDescriptionForGitCommit): Added.
3108
3109 2007-10-02  Lars Knoll  <lars@trolltech.com>
3110
3111         Reviewed by bdash.
3112
3113         Add API to retrieve the frame name from QWebFrame.
3114         Implement support for DRT::dumpChildrenAsText.
3115
3116         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3117         (WebCore::DumpRenderTree::dumpFramesAsText):
3118         (WebCore::DumpRenderTree::dump):
3119         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3120         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3121         (LayoutTestController::LayoutTestController):
3122         (LayoutTestController::reset):
3123         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3124
3125 2007-10-02  Lars Knoll  <lars@trolltech.com>
3126
3127         Reviewed by bdash.
3128
3129         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3130
3131         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3132         (WebCore::DumpRenderTree::readStdin):
3133
3134 2007-10-02  Mark Rowe  <mrowe@apple.com>
3135
3136         Reviewed by Oliver.
3137
3138         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3139
3140         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3141         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3142
3143 2007-10-02  Mark Rowe  <mrowe@apple.com>
3144
3145         Rubber-stamped by Maciej.
3146
3147         Configuration changes from build.webkit.org.  The major change is refactoring to work
3148         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3149         last few weeks.
3150
3151         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3152         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3153         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3154         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3155         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3156         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3157         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3158         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3159
3160 2007-10-02  Lars Knoll  <lars@trolltech.com>
3161
3162         Reviewed by Maciej.
3163
3164         Add support for eventSender.mouseMove to DRT.
3165         Fixes fast/css/hover-affects-child.html
3166
3167         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3168         (EventSender::mouseMoveTo):
3169
3170 2007-10-01  Mark Rowe  <mrowe@apple.com>
3171
3172         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3173
3174 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3175
3176         Reviewed by Hyatt.
3177
3178         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3179
3180         * Scripts/svn-apply:
3181         (gitdiff2svndiff): Ignore lines beginning with "new file".
3182         * Scripts/svn-unapply:
3183         (gitdiff2svndiff): Ditto.
3184
3185 2007-09-30  George Staikos  <staikos@kde.org>
3186
3187         Qt build fix (Mac OS X specific)
3188
3189         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3190
3191 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3192
3193         Reviewed by Mark.
3194
3195         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3196         Remove Bakefiles from svn.
3197
3198         * GtkLauncher/Bakefiles.bkgen: Removed.
3199         * GtkLauncher/ENV: Removed.
3200         * GtkLauncher/gdklauncher.bkl: Removed.
3201         * GtkLauncher/mk: Removed.
3202         * Scripts/regenerate-makefiles: Removed.
3203
3204 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3205
3206         Reviewed by John.
3207
3208         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3209
3210         * Scripts/run-webkit-tests:
3211
3212 2007-09-26  Adam Roben  <aroben@apple.com>
3213
3214         Make not finding an installed WebKit non-fatal
3215
3216         What really matters is that we are able to load WebKit and its
3217         dependencies, not whether we think we've found an installed WebKit.
3218
3219         Reviewed by Sam.
3220
3221         * WebKitInitializer/WebKitInitializer.cpp:
3222         (getWebViewCLSID): Use new LOG_WARNING macro.
3223         (getInstalledWebKitDirectory): Ditto.
3224         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3225         and use new macros.
3226         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3227
3228 2007-09-26  Adam Roben  <aroben@apple.com>
3229
3230         Committed this file before saving it
3231
3232         * WebKitInitializer/debug_internal.vsprops:
3233
3234 2007-09-26  Adam Roben  <aroben@apple.com>
3235
3236         Load WebKit and its dependencies manually so they come from DllDirectory
3237
3238         I had to change WebKitInitializer to use malloc/free instead of
3239         new/delete to avoid pulling in WebKit (and its dependencies) early
3240         through use of fastMalloc.
3241
3242         Reviewed by Oliver.
3243
3244         * WebKitInitializer/WebKitInitializer.cpp:
3245         (getStringValue): Changed to use malloc/free.
3246         (getInstalledWebKitDirectory): Ditto.
3247         (initializeWebKit): Call SetDllDirectory first, then load all of
3248         WebKit's dependencies manually, finally followed by WebKit itself.
3249         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3250         configuration to match our other projects.
3251         * WebKitInitializer/debug_internal.vsprops: Added.
3252
3253 2007-09-25  Adam Roben  <aroben@apple.com>
3254
3255         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3256
3257         Rubberstamped by Sam.
3258
3259         * WebKitInitializer/WebKitInitializer.vcproj:
3260
3261 2007-09-25  Adam Roben  <aroben@apple.com>
3262
3263         Make DumpRenderTree delay-load its dependencies
3264
3265         This lets WebKitInitializer re-route the dependencies to be loaded out
3266         of the Safari installation directory.
3267
3268         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3269         same thing), since we can't import the kCFAllocatorDefault symbol when
3270         delay-loading CoreFoundation.dll.
3271
3272         Rubberstamped by Sam.
3273
3274         * DumpRenderTree/win/DumpRenderTree.cpp:
3275         (runTest):
3276         (javaScriptThreads):
3277         * DumpRenderTree/win/DumpRenderTree.vcproj:
3278         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3279         (LayoutTestController::setWaitToDump):
3280
3281 2007-09-25  Adam Roben  <aroben@apple.com>
3282
3283         Pull ole32.lib into WebKitInitializer
3284
3285         Rubberstamped by Sam.
3286
3287         * WebKitInitializer/WebKitInitializer.vcproj:
3288
3289 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3290
3291         Reviewed by Adam.
3292
3293         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3294           LGPL'ed files contain incorrect FSF address
3295
3296         * Drosera/config.h:
3297
3298 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3299
3300         Reviewed by Adam.
3301
3302         Make svn-apply and svn-unapply work with git-diff formatted patches.
3303
3304         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3305         (gitdiff2svndiff): Added.
3306         * Scripts/svn-unapply: Ditto.
3307         (gitdiff2svndiff): Added.
3308
3309 2007-09-25  Adam Roben  <aroben@apple.com>
3310
3311         Pull advapi32.lib into WebKitInitializer
3312
3313         This is needed to get the registry functions we use.
3314
3315         Rubberstamped by Sam.
3316
3317         * WebKitInitializer/WebKitInitializer.vcproj:
3318
3319 2007-09-25  Adam Roben  <aroben@apple.com>
3320
3321         Add python and rsync to cygwin-downloader
3322
3323         Our build slaves need this, and it can't hurt for everyone else to
3324         have it, too.
3325
3326         Reviewed by Sam.
3327
3328         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3329         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3330
3331 2007-09-25  Adam Roben  <aroben@apple.com>
3332
3333         Add WebKitInitializer and use it in DumpRenderTree
3334
3335         WebKitInitializer is a static library that has one function,
3336         initializeWebKit(). This registers WebKit and sets up the DLL search
3337         path so that WebKit's dependencies that are installed with Safari can
3338         be found.
3339
3340         Reviewed by Sam.
3341
3342         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3343         DumpRenderTree depend on it.
3344         * DumpRenderTree/win/DumpRenderTree.cpp:
3345         (initialize): Call initializeWebKit.
3346         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3347         WebKitInitializer.lib.
3348         * WebKitInitializer/WebKitInitializer.cpp: Added.
3349         (getStringValue):
3350         (getWebViewCLSID):
3351         (getInstalledWebKitDirectory):
3352         (initializeWebKit):
3353         * WebKitInitializer/WebKitInitializer.h: Added.
3354         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3355         * WebKitInitializer/debug.vsprops: Added.
3356         * WebKitInitializer/release.vsprops: Added.
3357
3358 2007-09-25  Adam Roben  <aroben@apple.com>
3359
3360         Make run-webkit-tests respect set-webkit-configuration
3361
3362         Reviewed by Sam.
3363
3364         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3365         set-webkit-configuration was last set to.
3366
3367 2007-09-25  Mark Rowe  <mrowe@apple.com>
3368
3369         Rubber-stamped by Eric.
3370
3371         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3372         This makes it possible to automate nightly builds for the feature-branch.
3373
3374 2007-09-25  Adam Roben  <aroben@apple.com>
3375
3376         A couple of fixes/enhancements to update-webkit-*-libs
3377
3378         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3379         to tell update-webkit-support-libraries where it should find the
3380         WebKitSupportLibrary.zip file you downloaded.
3381
3382         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3383         Windows-style path.
3384
3385         Reviewed by Sam.
3386
3387         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3388         to $auxiliaryLibsURL and removed an irrelevant comment.
3389         * Scripts/update-webkit-support-libs:
3390
3391 2007-09-25  Adam Treat  <treat@kde.org>
3392
3393         Reviewed by Simon and Lars.
3394
3395         Refactors and cleans up Qt DRT member variable names, member variable
3396         initialization, style fixes and general code cleanup.
3397
3398         Adds queueReload slot to LayoutTestController that some tests require.
3399
3400         Subclasses QWebFrame to make sure that all frames have an associated
3401         LayoutTestController JS window object.
3402
3403         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3404         aren't dumped twice.
3405
3406         EOF fixes.
3407
3408         Together, this patch fixes some 20+ layout tests in QtWebKit.
3409
3410         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3411         (WebCore::WebFrame::WebFrame):
3412         (WebCore::WebPage::WebPage):
3413         (WebCore::WebPage::createFrame):
3414         (WebCore::DumpRenderTree::DumpRenderTree):
3415         (WebCore::DumpRenderTree::open):
3416         (WebCore::DumpRenderTree::readStdin):
3417         (WebCore::DumpRenderTree::initJSObjects):
3418         (WebCore::DumpRenderTree::dump):
3419         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3420         (WebCore::DumpRenderTree::layoutTestController):
3421         (WebCore::DumpRenderTree::eventSender):
3422         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3423         (LayoutTestController::LayoutTestController):
3424         (LayoutTestController::reset):
3425         (LayoutTestController::maybeDump):
3426         (LayoutTestController::waitUntilDone):
3427         (LayoutTestController::notifyDone):
3428         (LayoutTestController::queueReload):
3429         (LayoutTestController::provisionalLoad):
3430         (EventSender::EventSender):
3431         (EventSender::mouseDown):
3432         (EventSender::mouseUp):
3433         (EventSender::mouseMoveTo):
3434         (EventSender::frameUnderMouse):
3435         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3436         (LayoutTestController::isLoading):
3437         (LayoutTestController::setLoading):
3438         (LayoutTestController::dumpAsText):
3439         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3440         (main):
3441
3442 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3443
3444
3445         - Reverted an accidentally checked in file.
3446
3447         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3448
3449 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3450         Reviewed by Sam.
3451
3452         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3453
3454         * DumpRenderTree/win/DumpRenderTree.vcproj:
3455         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3456
3457 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3458
3459         Rubber stamped by Adam.
3460
3461         * GdkLauncher: Removed.
3462         * GdkLauncher/Bakefiles.bkgen: Removed.
3463         * GdkLauncher/ENV: Removed.
3464         * GdkLauncher/GdkLauncher.pro: Removed.
3465         * GdkLauncher/gdklauncher.bkl: Removed.
3466         * GdkLauncher/main.cpp: Removed.
3467         * GdkLauncher/mk: Removed.
3468         * GdkLauncher/simple.svg: Removed.
3469         * GdkLauncher/text.html: Removed.
3470         * GtkLauncher: Added.
3471         * GtkLauncher/GdkLauncher.pro: Removed.
3472         * GtkLauncher/GtkLauncher.pro: Added.
3473         * GtkLauncher/main.cpp:
3474         (updateWindowTitle):
3475         (main):
3476         * Scripts/build-webkit:
3477         * Scripts/regenerate-makefiles:
3478         * Scripts/run-javascriptcore-tests:
3479         * Scripts/run-launcher:
3480         * Scripts/run-webkit-tests:
3481         * Scripts/webkitdirs.pm:
3482
3483 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3484
3485         Reviewed by Darin.
3486
3487         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3488
3489         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3490         This is tested by plugins/root-object-premature-delete-crash.html.
3491
3492         * DumpRenderTree/mac/ObjCController.m:
3493         (-[ObjCController accessStoredWebScriptObject]):
3494
3495 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3496
3497         Reviewed by Oliver.
3498
3499         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3500
3501         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3502         (FrameLoadDelegate::FrameLoadDelegate):
3503
3504 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3505
3506         Reviewed by Adam.
3507
3508         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3509         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3510
3511         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3512         Now isQt() and isGdk() use global variables that are only set once.
3513
3514         An array of all the parameters is now given to build-dumprender which includes
3515         the platform on linux.
3516
3517         * Scripts/build-dumprendertree:
3518         * Scripts/run-webkit-tests:
3519         * Scripts/webkitdirs.pm:
3520
3521 2007-09-19  Adam Roben  <aroben@apple.com>
3522
3523         Rubberstamped by Hyatt.
3524
3525         * Spinneret: Removed.
3526
3527 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3528
3529         Reviewed by David Kilzer.
3530
3531         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3532
3533 2007-09-18  Sam Weinig  <sam@webkit.org>
3534
3535         Add JSRetainPtr.h #include to fix some builds.
3536
3537         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3538
3539 2007-09-18  Mike Hommey  <glandium@debian.org>
3540
3541         Reviewed by Adam.
3542
3543         * Scripts/prepare-ChangeLog:
3544         - Properly parse GECOS field.
3545         - Use git configuration for user name and email when appropriate.
3546
3547 2007-09-17  Sam Weinig  <sam@webkit.org>
3548
3549         Build fix.
3550
3551         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3552
3553 2007-09-17  Sam Weinig  <sam@webkit.org>
3554
3555         Reviewed by Adam Roben.
3556
3557         Share more code between mac and windows DRT.
3558             - GCController is now shared.
3559             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3560
3561         * DumpRenderTree/GCController.cpp:
3562         * DumpRenderTree/win/DumpRenderTree.cpp:
3563         * DumpRenderTree/win/DumpRenderTree.vcproj:
3564         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3565         (FrameLoadDelegate::FrameLoadDelegate):
3566         (FrameLoadDelegate::~FrameLoadDelegate):
3567         (FrameLoadDelegate::windowScriptObjectAvailable):
3568         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3569         * DumpRenderTree/win/GCController.cpp: Removed.
3570         * DumpRenderTree/win/GCController.h: Removed.
3571         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3572         (GCController::collect):
3573         (GCController::collectOnAlternateThread):
3574         (GCController::getJSObjectCount):
3575         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3576         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3577
3578 2007-09-17  Sam Weinig  <sam@webkit.org>
3579
3580         Reviewed by Adam Roben.
3581
3582         Begin sharing code between mac and windows DRT.
3583             - both now share LayoutTestController.h/cpp and implement platform dependant 
3584               operations in LayoutTestControllerMac/Win.
3585             - DumpRenderTree.h is now shared.
3586             - WorkQueue and WorkQueueItem are also shared.
3587
3588         * DumpRenderTree/DumpRenderTree.h:
3589         * DumpRenderTree/LayoutTestController.cpp:
3590         * DumpRenderTree/win/DumpRenderTree.cpp:
3591         (displayWebView):
3592         (dumpFrameScrollPosition):
3593         (dumpFramesAsText):
3594         (dump):
3595         (runTest):
3596         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3597         * DumpRenderTree/win/DumpRenderTree.vcproj:
3598         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3599         * DumpRenderTree/win/EditingDelegate.cpp:
3600         (EditingDelegate::shouldBeginEditingInDOMRange):
3601         (EditingDelegate::shouldEndEditingInDOMRange):
3602         (EditingDelegate::shouldInsertNode):
3603         (EditingDelegate::shouldInsertText):
3604         (EditingDelegate::shouldDeleteDOMRange):
3605         (EditingDelegate::shouldChangeSelectedDOMRange):
3606         (EditingDelegate::shouldApplyStyle):
3607         (EditingDelegate::shouldChangeTypingStyle):
3608         (EditingDelegate::doPlatformCommand):
3609         (EditingDelegate::webViewDidBeginEditing):
3610         (EditingDelegate::webViewDidChange):