e7adfcd57c5fe6c6986097b60f97bbe114645838
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
2
3         Build fix. Be flexible about which version of ICU is used on Windows.
4
5         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
6
7 2009-12-07  Dirk Schulze  <krit@webkit.org>
8
9         Not reviewed, adding myself to the reviewers list.
10
11         * Scripts/modules/committers.py:
12
13 2009-12-06  Eric Seidel  <eric@webkit.org>
14
15         Reviewed by Adam Barth.
16
17         Add an API for uploading results files to StatusBot
18         https://bugs.webkit.org/show_bug.cgi?id=32210
19
20         Add Content-Type: plain/text which was forgotten
21         from the previous commit when I landed with land-patches
22         instead of land-diff.
23
24         * QueueStatusServer/queue_status.py:
25
26 2009-12-06  Eric Seidel  <eric@webkit.org>
27
28         Reviewed by Adam Barth.
29
30         Status Server needs a way to handle uploaded results
31         https://bugs.webkit.org/show_bug.cgi?id=32209
32
33         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
34         * QueueStatusServer/update_status.html: Add file upload.
35
36 2009-12-06  Eric Seidel  <eric@webkit.org>
37
38         Reviewed by Adam Barth.
39
40         Add an API for uploading results files to StatusBot
41         https://bugs.webkit.org/show_bug.cgi?id=32210
42
43         * Scripts/modules/statusbot.py:
44
45 2009-12-06  Eric Seidel  <eric@webkit.org>
46
47         Reviewed by Adam Barth.
48
49         Status Server needs a way to handle uploaded results
50         https://bugs.webkit.org/show_bug.cgi?id=32209
51
52         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
53         * QueueStatusServer/update_status.html: Add file upload.
54
55 2009-12-06  Adam Barth  <abarth@webkit.org>
56
57         Reviewed by Eric Seidel.
58
59         [bzt] BuildAttachment should not check the builders
60         https://bugs.webkit.org/show_bug.cgi?id=32207
61
62         This is code that got copied here by accident when the class was created.
63
64         * Scripts/modules/commands/download.py:
65
66 2009-12-06  Adam Barth  <abarth@webkit.org>
67
68         Reviewed by Eric Seidel.
69
70         [bzt] Make LandingSequence.update aware of ports
71         https://bugs.webkit.org/show_bug.cgi?id=32208
72
73         This is required to make build work on the Chromium port because
74         Chromium has a custom update-webkit.
75
76         * Scripts/modules/landingsequence.py:
77
78 2009-12-06  Adam Barth  <abarth@webkit.org>
79
80         Reviewed by Eric Seidel.
81
82         Add early warning system commands to bugzilla-tool.
83
84         * Scripts/bugzilla-tool:
85         * Scripts/modules/landingsequence.py:
86         * Scripts/modules/webkitport.py:
87
88 2009-12-06  Adam Barth  <abarth@webkit.org>
89
90         Reviewed by Eric Seidel.
91
92         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
93         https://bugs.webkit.org/show_bug.cgi?id=32205
94
95         * Scripts/modules/commands/early_warning_system.py: Added.
96         * Scripts/modules/commands/queues.py:
97
98 2009-12-06  Dan Bernstein  <mitz@apple.com>
99
100         Reviewed by Adele Peterson.
101
102         REGRESSION (r51728): update-webkit fails when the current directory is
103         not inside a Subversion working copy
104         https://bugs.webkit.org/show_bug.cgi?id=32204
105
106         * Scripts/update-webkit: Invoke isSVN() in the correct working
107         directory.
108
109 2009-12-06  Adam Barth  <abarth@webkit.org>
110
111         Reviewed by Eric Seidel.
112
113         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
114         https://bugs.webkit.org/show_bug.cgi?id=32202
115
116         * Scripts/modules/commands/queues.py:
117
118 2009-12-05  Adam Barth  <abarth@webkit.org>
119
120         Reviewed by Eric Seidel.
121
122         [bzt] Implement ChromiumPort
123         https://bugs.webkit.org/show_bug.cgi?id=32182
124
125         * Scripts/modules/webkitport.py:
126         * Scripts/modules/webkitport_unittest.py:
127
128 2009-12-05  Adam Barth  <abarth@webkit.org>
129
130         Reviewed by Eric Seidel.
131
132         Move update-webkit into BuildSteps
133         https://bugs.webkit.org/show_bug.cgi?id=32181
134
135         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
136         that WebKit exists.  The proper place for the knowledge of the existence of
137         update-webkit is in WebKitPort because some ports have specialized update
138         scripts (analogous to build-webkit).
139
140         * Scripts/modules/buildsteps.py:
141         * Scripts/modules/commands/download.py:
142         * Scripts/modules/landingsequence.py:
143         * Scripts/modules/scm.py:
144         * Scripts/modules/webkitport.py:
145
146 2009-12-05  Adam Barth  <abarth@webkit.org>
147
148         Reviewed by Eric Seidel.
149
150         update-webkit should call git svn rebase and resolve-ChangeLogs -f
151         https://bugs.webkit.org/show_bug.cgi?id=27162
152
153         Teach update-webkit about Git.  I didn't add the call to
154         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
155         can iterate from here, however.
156
157         * Scripts/update-webkit:
158
159 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
160
161         Unreviewed build fix.
162
163         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
164
165         * DumpRenderTree/qt/DumpRenderTree.cpp:
166
167 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
168
169         Reviewed by Adam Treat.
170
171         Add some missing methods for showing and hiding the
172         Web Inspector.
173
174         * DumpRenderTree/qt/DumpRenderTree.cpp:
175         (WebCore::WebPage::WebPage):
176         (WebCore::WebPage::~WebPage):
177         (WebCore::WebPage::webInspector):
178         * DumpRenderTree/qt/DumpRenderTree.h:
179         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
180         (LayoutTestController::showWebInspector):
181         (LayoutTestController::hideWebInspector):
182         * DumpRenderTree/qt/LayoutTestControllerQt.h:
183
184 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
185
186         Reviewed by Adam Treat.
187
188         Implement the setAllowUniversalAccessFromFileURLs method
189         for the Qt LayoutTestController.
190
191         * DumpRenderTree/qt/DumpRenderTree.cpp:
192         (WebCore::WebPage::resetSettings):
193         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
194         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
195         * DumpRenderTree/qt/LayoutTestControllerQt.h:
196
197 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
198
199         Reviewed by Darin Adler.
200
201         REGRESSION: AX: buttons now extremely repetitive
202         https://bugs.webkit.org/show_bug.cgi?id=32164
203
204         * DumpRenderTree/AccessibilityUIElement.cpp:
205         (isAttributeSupportedCallback):
206         (AccessibilityUIElement::getJSClass):
207         * DumpRenderTree/AccessibilityUIElement.h:
208         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
209         (AccessibilityUIElement::isAttributeSupported):
210         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
211         (AccessibilityUIElement::isAttributeSupported):
212         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
213         (AccessibilityUIElement::isAttributeSupported):
214
215 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
216
217         Reviewed by David Levin.
218
219         check-webkit-style should check for camelCase variable names
220         https://bugs.webkit.org/show_bug.cgi?id=32051
221
222         * Scripts/modules/cpp_style.py:
223         * Scripts/modules/cpp_style_unittest.py:
224
225 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
226
227         Reviewed by Eric Seidel.
228
229         AX: VO just says "term" on many web sites
230         https://bugs.webkit.org/show_bug.cgi?id=32139
231
232         * DumpRenderTree/AccessibilityUIElement.cpp:
233         (getRoleDescriptionCallback):
234         (AccessibilityUIElement::getJSClass):
235         * DumpRenderTree/AccessibilityUIElement.h:
236         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
237         (AccessibilityUIElement::roleDescription):
238         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
239         (AccessibilityUIElement::roleDescription):
240         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
241         (AccessibilityUIElement::roleDescription):
242
243 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
244
245         Reviewed by Beth Dakin.
246
247         Implement WAI-ARIA scrollbar role and related property aria-orientation
248         https://bugs.webkit.org/show_bug.cgi?id=32126
249
250         * DumpRenderTree/AccessibilityUIElement.cpp:
251         (getOrientationCallback):
252         (AccessibilityUIElement::getJSClass):
253         * DumpRenderTree/AccessibilityUIElement.h:
254         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
255         (AccessibilityUIElement::orientation):
256         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
257         (AccessibilityUIElement::orientation):
258         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
259         (AccessibilityUIElement::orientation):
260
261 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
262
263         Reviewed by Adam Roben.
264
265         Minor correction to r51663.
266
267         * DumpRenderTree/win/DumpRenderTree.cpp:
268         (addQTDirToPATH):
269             GetEnvironmentVariable -> GetEnvironmentVariableW.
270
271 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
272
273         Reviewed by Adam Roben.
274
275         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
276         https://bugs.webkit.org/show_bug.cgi?id=30256
277
278         Add the QuickTime dll directory to the PATH environment variable so
279         inialization can succeed.
280
281         * DumpRenderTree/win/DumpRenderTree.cpp:
282         (addQTDirToPATH):
283         (initialize):
284
285 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
286
287         Reviewed by Kenneth Rohde Christiansen.
288
289         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
290
291         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
292         (LayoutTestController::maybeDump):
293
294 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
295
296         Reviewed by Eric Seidel.
297
298         Update pywebsocket to 0.4.3
299         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
300         Stack trace is logged now in INFO level.
301         https://bugs.webkit.org/show_bug.cgi?id=32097
302
303         * pywebsocket/mod_pywebsocket/dispatch.py:
304         * pywebsocket/mod_pywebsocket/msgutil.py:
305         * pywebsocket/mod_pywebsocket/standalone.py:
306         * pywebsocket/mod_pywebsocket/util.py:
307         * pywebsocket/setup.py:
308         * pywebsocket/test/test_dispatch.py:
309         * pywebsocket/test/test_util.py:
310
311 2009-12-03  Sam Weinig  <sam@webkit.org>
312
313         Reviewed by Gavin Barraclough.
314
315         Fix JSClassRef leak.
316
317         * DumpRenderTree/AccessibilityController.cpp:
318         (AccessibilityController::makeWindowObject):
319         * DumpRenderTree/GCController.cpp:
320         (GCController::makeWindowObject):
321         * DumpRenderTree/LayoutTestController.cpp:
322         (LayoutTestController::makeWindowObject):
323
324 2009-12-03  Brady Eidson  <beidson@apple.com>
325
326         Reviewed by Sam Weinig.
327
328         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
329
330         Keep DRT-win building...
331
332         * DumpRenderTree/win/FrameLoadDelegate.h:
333         (FrameLoadDelegate::didPushStateWithinPageForFrame):
334         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
335         (FrameLoadDelegate::didPopStateWithinPageForFrame):
336
337 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
338
339         Unreviewed build fix.
340
341         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
342
343         * DumpRenderTree/qt/DumpRenderTree.cpp:
344
345 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
346
347         Reviewed by Kenneth Rohde Christiansen.
348
349         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
350         Prevent DRT from showing the main view if these childs get deleted.
351         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
352
353         * DumpRenderTree/qt/DumpRenderTree.cpp:
354         (WebCore::WebPage::WebPage):
355         (WebCore::DumpRenderTree::DumpRenderTree):
356         (WebCore::DumpRenderTree::~DumpRenderTree):
357         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
358         (WebCore::DumpRenderTree::open):
359         (WebCore::DumpRenderTree::closeRemainingWindows):
360         (WebCore::DumpRenderTree::createWindow):
361         (WebCore::DumpRenderTree::windowCount):
362         * DumpRenderTree/qt/DumpRenderTree.h:
363
364 2009-12-02  Eric Seidel  <eric@webkit.org>
365
366         Reviewed by Adam Barth.
367
368         REGRESSION(51595): commit-queue is throwing exceptions
369         https://bugs.webkit.org/show_bug.cgi?id=32083
370
371         * Scripts/modules/commands/queues.py:
372          - Don't use default value of [] as it ends up getting shared.
373          - Make log_progress accept arrays of ints as well as strings.
374          - Return an exit code from execute()
375         * Scripts/modules/commands/queues_unittest.py: Added.
376          - Test to make sure log_progress will accept ints.
377          - Test to make sure run_bugzilla_tool will accept ints.
378         * Scripts/modules/workqueue.py:
379          - Print the stack trace on unexpected exceptions for easier debugging.
380         * Scripts/run-webkit-unittests:
381          - Add queues_unittest.
382
383         * Scripts/modules/commands/queues.py:
384         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
385         * Scripts/modules/mock_bugzillatool.py:
386         * Scripts/modules/workqueue.py:
387         * Scripts/run-webkit-unittests:
388
389 2009-12-02  David Levin  <levin@chromium.org>
390
391         Reviewed by Adam Barth.
392
393         check-webkit-style is too noisy about namespace indenting issues.
394         https://bugs.webkit.org/show_bug.cgi?id=32096
395
396         * Scripts/modules/cpp_style.py:
397         Added a _FileState object to be able to track file level information. In this
398         case, it simply tracks whether the error has already been given, so that it isn't
399         done again.
400         * Scripts/modules/cpp_style_unittest.py:
401         Modified test cases to pass in the _FileState object and fix a test that expected
402         to see the namespace error twice (now it only occurs once). No new tests because
403         existing tests cover the change in functionality.
404
405 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
406
407         Reviewed by Eric Seidel.
408
409         [wx] Get DumpRenderTree building after waf switch.
410         
411         https://bugs.webkit.org/show_bug.cgi?id=32041
412
413         * DumpRenderTree/wscript: Added.
414         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
415         (LayoutTestController::setTimelineProfilingEnabled):
416         (LayoutTestController::evaluateScriptInIsolatedWorld):
417         (LayoutTestController::disableImageLoading):
418         (LayoutTestController::whiteListAccessFromOrigin):
419         (LayoutTestController::counterValueForElementById):
420         * Scripts/build-webkit:
421
422 2009-12-02  Adam Barth  <abarth@webkit.org>
423
424         Reviewed by Eric Seidel.
425
426         [bzt] build-attachment shouldn't check whether the builders are red
427         https://bugs.webkit.org/show_bug.cgi?id=32062
428
429         build-attachment doesn't touch the remote repository, so there isn't a
430         need to hold off when the builders are red.
431
432         * Scripts/modules/commands/download.py:
433         * Scripts/modules/landingsequence.py:
434
435 2009-12-02  Eric Seidel  <eric@webkit.org>
436
437         Reviewed by Adam Barth.
438
439         REGRESSION(51590): style-queue and build-queue think their empty when they are not
440         https://bugs.webkit.org/show_bug.cgi?id=32061
441
442         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
443         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
444
445 2009-12-02  Eric Seidel  <eric@webkit.org>
446
447         Reviewed by Adam Barth.
448
449         build-queue is throwing exceptions and complaining about
450         lack of --no-update on build-attachment.  Make it stop.
451
452         * Scripts/modules/buildsteps.py:
453         * Scripts/modules/commands/download.py:
454
455 2009-12-02  Adam Barth  <abarth@webkit.org>
456
457         Unreviewed "build" fix.  Forgot to declare my variables.  :(
458
459         * QueueStatusServer/queue_status.py:
460
461 2009-12-02  Adam Barth  <abarth@webkit.org>
462
463         Reviewed by Eric Seidel.
464
465         [bzt] Implement status bubble view
466         https://bugs.webkit.org/show_bug.cgi?id=32057
467
468         The status bubble is a compact representation of the queue status for a
469         given patch.  This will eventually help us reduce the comment spam from
470         the queues.
471
472         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
473         * QueueStatusServer/queue_status.py:
474         * QueueStatusServer/status_bubble.html: Added.
475
476 2009-12-02  Eric Seidel  <eric@webkit.org>
477
478         Reviewed by Adam Barth.
479
480         trim commands/*.py includes now that commands are unit tested
481         https://bugs.webkit.org/show_bug.cgi?id=32056
482
483         In the course of ensuring that the unit tests still
484         passed after this change, I had to actually make them
485         pass in the first place.
486
487         * Scripts/modules/bugzilla.py:
488          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
489         * Scripts/modules/commands/download.py: Remove unneeded imports.
490         * Scripts/modules/commands/queries.py: Ditto.
491         * Scripts/modules/commands/queues.py: Ditto.
492         * Scripts/modules/commands/upload.py: Ditto.
493         * Scripts/modules/scm_unittest.py:
494          - Fix to expect the \n after the path since echo adds an \n.
495
496 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
497
498         build-webkit: Remove flex,bison,gperf check for chromium
499         https://bugs.webkit.org/show_bug.cgi?id=32043
500
501         * Scripts/webkitdirs.pm:
502
503 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
504
505         Build fixage for Windows/GTK for DumpRenderTree.
506
507         WAI-ARIA: implement support for ARIA drag and drop
508         https://bugs.webkit.org/show_bug.cgi?id=32007
509
510         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
511         (AccessibilityUIElement::ariaIsGrabbed):
512         (AccessibilityUIElement::ariaDropEffects):
513         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
514         (AccessibilityUIElement::ariaIsGrabbed):
515         (AccessibilityUIElement::ariaDropEffects):
516
517 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
518
519         Reviewed by Darin Adler.
520
521         WAI-ARIA: implement support for ARIA drag and drop
522         https://bugs.webkit.org/show_bug.cgi?id=32007
523
524         * DumpRenderTree/AccessibilityUIElement.cpp:
525         (getARIADropEffectsCallback):
526         (getARIAIsGrabbedCallback):
527         (AccessibilityUIElement::getJSClass):
528         * DumpRenderTree/AccessibilityUIElement.h:
529         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
530         (AccessibilityUIElement::ariaIsGrabbed):
531         (AccessibilityUIElement::ariaDropEffects):
532
533 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
534
535         Not reviewed. GTK DRT try 2.
536
537         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
538         (LayoutTestController::sampleSVGAnimationForElementAtTime):
539
540 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
541
542         Not reviewed. Try to fix gtk DRT build.
543
544         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
545
546 2009-12-01  David Levin  <levin@chromium.org>
547
548         Reviewed by Eric Seidel.
549
550         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
551         https://bugs.webkit.org/show_bug.cgi?id=32033
552
553         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
554                                         instead of startswith.
555         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
556
557 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
558
559         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
560
561         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
562
563 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
564
565         Reviewed by Simon Fraser.
566
567         Add SVG animation test framework with 'snapshot' functionality
568         https://bugs.webkit.org/show_bug.cgi?id=31897
569
570         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
571         used by the new SVG animation testing framework, implemented
572         for qt/gtk/win/mac.
573
574         * DumpRenderTree/LayoutTestController.cpp:
575         (sampleSVGAnimationForElementAtTimeCallback):
576         (LayoutTestController::staticFunctions):
577         * DumpRenderTree/LayoutTestController.h:
578         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
579         (LayoutTestController::sampleSVGAnimationForElementAtTime):
580         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
581         (LayoutTestController::sampleSVGAnimationForElementAtTime):
582         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
583         (LayoutTestController::sampleSVGAnimationForElementAtTime):
584         * DumpRenderTree/qt/LayoutTestControllerQt.h:
585         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
586         (LayoutTestController::sampleSVGAnimationForElementAtTime):
587         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
588         (LayoutTestController::sampleSVGAnimationForElementAtTime):
589
590 2009-12-01  Adam Roben  <aroben@apple.com>
591
592         Remove user content before running each test on Windows
593
594         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
595
596         Reviewed by Alexey Proskuryakov.
597
598         * DumpRenderTree/win/DumpRenderTree.cpp:
599         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
600         before each test, which matches Mac.
601
602 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
603
604         Reviewed by Alexey Proskuryakov.
605
606         Make pywebsocket log errors to a file
607         https://bugs.webkit.org/show_bug.cgi?id=31604
608
609         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
610         (by passing the path to the server via a recently added -l option).
611
612 2009-12-01  Adam Roben  <aroben@apple.com>
613
614         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
615
616         Reviewed by Ada Chan.
617
618         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
619         TestNetscapePlugin fail in Debug_Internal builds
620
621         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
622         directory in Debug and Debug_All builds, but not in Debug_Internal
623         builds.
624
625 2009-12-01  Adam Roben  <aroben@apple.com>
626
627         Re-enable DRT's watchdog timer on Windows
628
629         It was accidentally disabled in r50907.
630
631         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
632         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
633         into an if condition.
634
635 2009-12-01  Adam Barth  <abarth@webkit.org>
636
637         Reviewed by Eric Seidel.
638
639         check-webkit-style complains about #imports with / in them
640         https://bugs.webkit.org/show_bug.cgi?id=32022
641
642         We need to exclude #import directives in addition to #include from the
643         binary operator whitespace checks.
644
645         * Scripts/modules/cpp_style.py:
646         * Scripts/modules/cpp_style_unittest.py:
647
648 2009-11-30  Adam Barth  <abarth@webkit.org>
649
650         Reviewed by Eric Seidel.
651
652         check-webkit-style is slightly too verbose
653         https://bugs.webkit.org/show_bug.cgi?id=32010
654
655         check-webkit-style prints out a bunch of "done" lines that seem redundant,
656         especially for the style-queue.
657
658         * Scripts/modules/cpp_style.py:
659
660 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
661
662         Reviewed by Eric Seidel.
663
664         [GTK] Moved the functions that are closing the result log of the
665         tests to the last line of the runTest function, this avoids
666         reporting crashes in the wrong test if there is a problem when
667         reseting the state after the test.
668
669         * DumpRenderTree/gtk/DumpRenderTree.cpp:
670         (dump):
671         (runTest):
672
673 2009-11-30  Sam Weinig  <sam@webkit.org>
674
675         Reviewed by Geoffrey Garen.
676
677         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
678         fast/js/date-proto-generic-invocation breaks another test
679
680         Don't cache JSClassRefs, a change to the prototype chain will
681         last between tests.
682
683         * DumpRenderTree/AccessibilityController.cpp:
684         (AccessibilityController::getJSClass):
685         * DumpRenderTree/GCController.cpp:
686         (GCController::getJSClass):
687         * DumpRenderTree/GCController.h:
688         * DumpRenderTree/LayoutTestController.cpp:
689         (LayoutTestController::getJSClass):
690
691 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
692
693         Reviewed by Alexey Proskuryakov.
694
695         Update pywebsocket to 0.4.2.1.
696         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
697         https://bugs.webkit.org/show_bug.cgi?id=31976
698
699         * pywebsocket/mod_pywebsocket/standalone.py:
700         * pywebsocket/setup.py:
701
702 2009-11-30  Adam Barth  <abarth@webkit.org>
703
704         Reviewed by Eric Seidel.
705
706         [bzt] Generate pass messages for style-queue
707         https://bugs.webkit.org/show_bug.cgi?id=31995
708
709         With this change, the style-queue posts "pass" messages to bugs as
710         well.  Also, added more information to the state store w.r.t. passing
711         and failing.
712
713         * Scripts/modules/commands/queues.py:
714         * Scripts/modules/patchcollection.py:
715
716 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
717
718         Reviewed by Simon Fraser.
719
720         Check for WEBKIT_TESTFONTS environment variable in
721         run-webkit-tests, for GTK+, to have a more prominent error
722         message.
723
724         * Scripts/run-webkit-tests:
725
726 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
727
728         Reviewed by Dimitri Glazkov.
729
730         update-webkit --chromium forces gclient sync
731
732         https://bugs.webkit.org/show_bug.cgi?id=31967
733
734         * Scripts/update-webkit-chromium:
735
736 2009-11-29  Eric Seidel  <eric@webkit.org>
737
738         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
739
740         * Scripts/modules/committers.py:
741
742 2009-11-29  Eric Seidel  <eric@webkit.org>
743
744         No review, just adding missing svn property.
745
746         Set svn:executable property on new scripts.
747         These were added by commit-queue commits, but the executable
748         property was lost due to a bug in svn-apply:
749         https://bugs.webkit.org/show_bug.cgi?id=27204
750
751         * Scripts/update-webkit-chromium: Added property svn:executable.
752         * Scripts/validate-committer-lists: Added property svn:executable.
753
754 2009-11-29  Eric Seidel  <eric@webkit.org>
755
756         Reviewed by Adam Barth.
757
758         Need a way to validate that committers.py includes all committers/reviewers
759         https://bugs.webkit.org/show_bug.cgi?id=30970
760
761         Add a script which knows how to compare our public committer/reviewer
762         lists and show discrepancies between them.
763
764         Validates mailing lists vs. committers.py:
765         - committers.py committers missing from webkit-committers@lists
766         - webkit-committers@lists members missing from committers.py
767         - committers.py reviewers missing from webkit-reviewers@lists
768         - webkit-reviewers@lists members missing from committers.py
769         - webkit-reviewers@lists members missing from committers.py reviewer list
770
771         Validates committers.py vs. trunk/ SVN history:
772         - committers who have not committed in over a year
773         - SVN committers missing from committers.py
774         - committers.py members who have no record in SVN.
775
776         All of these lists still show "false positives" until a few more committers.py updates are made, like:
777         https://bugs.webkit.org/show_bug.cgi?id=31366
778
779         * Scripts/validate-committer-lists: Added.
780
781 2009-11-28  Adam Barth  <abarth@webkit.org>
782
783         Reviewed by Eric Seidel.
784
785         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
786         https://bugs.webkit.org/show_bug.cgi?id=31950
787
788         Now we cache the last status that we get back from QueueStatusServer.
789         Eventually we'll have to do something more fancy if we want to support
790         a "try again" button on QueueStatusServer, but we can cross that bridge
791         when we come to it.
792
793         * Scripts/modules/patchcollection.py:
794
795 2009-11-28  Adam Barth  <abarth@webkit.org>
796
797         Reviewed by Eric Seidel.
798
799         StyleQueue scans ~100 bug pages every 5 minutes
800         https://bugs.webkit.org/show_bug.cgi?id=31947
801
802         Instead of getting the pending-review attachment ids by scanning each
803         bug (which results in a network request), we should just get them all
804         from webkit.org/pending-review in one shot.
805
806         * Scripts/modules/bugzilla.py:
807         * Scripts/modules/bugzilla_unittest.py:
808         * Scripts/modules/commands/queries.py:
809         * Scripts/modules/commands/queries_unittest.py:
810         * Scripts/modules/commands/queues.py:
811         * Scripts/modules/mock_bugzillatool.py:
812         * Scripts/modules/patchcollection.py:
813
814 2009-11-28  Adam Barth  <abarth@webkit.org>
815
816         Reviewed by Eric Seidel.
817
818         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
819         https://bugs.webkit.org/show_bug.cgi?id=31952
820
821         The mailing list is open for anyone to subscribe.
822
823         * Scripts/modules/bugzilla.py:
824         * Scripts/modules/commands/queues.py:
825
826 2009-11-28  Adam Barth  <abarth@webkit.org>
827
828         Reviewed by Eric Seidel.
829
830         [bzt] style-queue should report style errors to bugzilla
831         https://bugs.webkit.org/show_bug.cgi?id=31945
832
833         Currently, we're just logging the style errors locally.  With this
834         patch we'll actually log the errors to bugzilla.  Note: I plan to run
835         with the "local-only" logging during development.
836
837         * Scripts/modules/commands/queues.py:
838         * Scripts/modules/scm.py:
839
840 2009-11-28  Adam Barth  <abarth@webkit.org>
841
842         Reviewed by Eric Seidel.
843
844         [bzt] style-queue shouldn't reject patches from the commit-queue
845         https://bugs.webkit.org/show_bug.cgi?id=31944
846
847         Currently the style-queue subprocess gets confused and thinks its the
848         commit-queue.  If the patch has an error, it rejects it from the
849         commit-queue.  Instead, we should have style-queue specific logic.
850         This patch doesn't add that logic, but it gives us a callback we can
851         use to add that logic.
852
853         * Scripts/modules/buildsteps.py:
854         * Scripts/modules/commands/queues.py:
855         * Scripts/modules/landingsequence.py:
856
857 2009-11-27  Adam Barth  <abarth@webkit.org>
858
859         Rubber stamped by Eric Seidel.
860
861         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
862
863         * CommitQueueStatus: Removed.
864         * CommitQueueStatus/app.yaml: Removed.
865         * CommitQueueStatus/filters: Removed.
866         * CommitQueueStatus/filters/__init__.py: Removed.
867         * CommitQueueStatus/filters/webkit_extras.py: Removed.
868         * CommitQueueStatus/index.html: Removed.
869         * CommitQueueStatus/index.yaml: Removed.
870         * CommitQueueStatus/queue_status.py: Removed.
871         * CommitQueueStatus/stylesheets: Removed.
872         * CommitQueueStatus/stylesheets/main.css: Removed.
873         * CommitQueueStatus/update_status.html: Removed.
874         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
875
876 2009-11-27  Adam Barth  <abarth@webkit.org>
877
878         Reviewed by Eric Seidel.
879
880         style-queue should only process each patch once
881         https://bugs.webkit.org/show_bug.cgi?id=31939
882
883         Actually address reviewer comments!
884
885         * Scripts/bugzilla-tool:
886
887 2009-11-27  Adam Barth  <abarth@webkit.org>
888
889         Reviewed by Eric Seidel.
890
891         [bzt] style-queue fails to apply a bunch of patches for no reason
892         https://bugs.webkit.org/show_bug.cgi?id=31942
893
894         By passing --non-interactive to check-style, we convince check-style
895         to pass --force to svn-apply, which lets it apply more patches.
896
897         * Scripts/modules/commands/queues.py:
898
899 2009-11-27  Adam Barth  <abarth@webkit.org>
900
901         Reviewed by Eric Seidel.
902
903         [bzt] Support --status-host in style-queue
904         https://bugs.webkit.org/show_bug.cgi?id=31941
905
906         * Scripts/modules/commands/queues.py:
907         * Scripts/modules/statusbot.py:
908
909 2009-11-27  Adam Barth  <abarth@webkit.org>
910
911         Reviewed by Eric Seidel.
912
913         style-queue should only process each patch once
914         https://bugs.webkit.org/show_bug.cgi?id=31939
915
916         Before processing a patch, the try-queues now ask the web service
917         whether they have already processed the patch.  This is an initial cut
918         of this functionality.  I expect we're make it richer over time.
919
920         * Scripts/bugzilla-tool:
921         * Scripts/modules/commands/queues.py:
922         * Scripts/modules/patchcollection.py:
923
924 2009-11-27  Adam Barth  <abarth@webkit.org>
925
926         Reviewed by Eric Seidel.
927
928         PatchStatus does not return status
929         https://bugs.webkit.org/show_bug.cgi?id=31938
930
931         We need to parse attachment_id as an int.  Otherwise, we can't find
932         anything in the datastore.
933
934         * CommitQueueStatus/queue_status.py:
935
936 2009-11-27  Adam Barth  <abarth@webkit.org>
937
938         Reviewed by Eric Seidel.
939
940         Make commit-queue status not throw an exception where there is not
941         status
942         https://bugs.webkit.org/show_bug.cgi?id=31936
943
944         We need to actually fetch the results of the query to see what's in the
945         datastore.
946
947         * CommitQueueStatus/queue_status.py:
948
949 2009-11-27  Adam Barth  <abarth@webkit.org>
950
951         Reviewed by Eric Seidel.
952
953         [bzt] unit test ApplyPatches and ApplyAttachment
954         https://bugs.webkit.org/show_bug.cgi?id=31935
955
956         * Scripts/modules/commands/download.py:
957         * Scripts/modules/commands/download_unittest.py:
958
959 2009-11-27  Adam Barth  <abarth@webkit.org>
960
961         Reviewed by Eric Seidel.
962
963         [bzt] Unit test download commands
964         https://bugs.webkit.org/show_bug.cgi?id=31923
965
966         Adds download_unittest and fixes a bug found while testing.
967
968         * Scripts/modules/commands/commandtest.py:
969         * Scripts/modules/commands/download.py:
970             Fixed a bug where we'd throw an error because [].append returns
971             None.
972         * Scripts/modules/commands/download_unittest.py: Added.
973         * Scripts/modules/mock_bugzillatool.py:
974         * Scripts/run-webkit-unittests:
975
976 2009-11-27  Adam Barth  <abarth@webkit.org>
977
978         Unreviewed "build" fix found while writing unit tests.
979
980         * Scripts/modules/commands/download.py:
981
982 2009-11-27  Adam Barth  <abarth@webkit.org>
983
984         Reviewed by Eric Seidel.
985
986         [bzt] Kill WebKitLandingScripts
987         https://bugs.webkit.org/show_bug.cgi?id=31904
988
989         Step 6: Kill the rest.
990
991         * Scripts/modules/buildsteps.py:
992         * Scripts/modules/commands/download.py:
993         * Scripts/modules/commands/queries.py:
994         * Scripts/modules/commands/upload.py:
995         * Scripts/modules/landingsequence.py:
996         * Scripts/modules/scm.py:
997         * Scripts/modules/webkitlandingscripts.py: Removed.
998
999 2009-11-27  Adam Barth  <abarth@webkit.org>
1000
1001         Reviewed by Eric Seidel.
1002
1003         [bzt] Unit test upload commands
1004         https://bugs.webkit.org/show_bug.cgi?id=31903
1005
1006         Adds unit tests for all but two of the upload commands.  The two
1007         remaining ones are more difficult.  I'll return to them later.  The
1008         goal of these tests is just to run the commands.  We can test more
1009         detailed behavior later.
1010
1011         * Scripts/modules/commands/commandtest.py:
1012         * Scripts/modules/commands/upload.py:
1013         * Scripts/modules/commands/upload_unittest.py:
1014         * Scripts/modules/mock.py: Added.
1015         * Scripts/modules/mock_bugzillatool.py:
1016
1017 2009-11-26  Adam Barth  <abarth@webkit.org>
1018
1019         Reviewed by Eric Seidel.
1020
1021         [bzt] Kill WebKitLandingScripts
1022         https://bugs.webkit.org/show_bug.cgi?id=31904
1023
1024         Step 5: Kill run_and_throw_if_fail.
1025
1026         * Scripts/modules/buildsteps.py:
1027         * Scripts/modules/processutils.py: Added.
1028         * Scripts/modules/webkitlandingscripts.py:
1029
1030 2009-11-26  Adam Barth  <abarth@webkit.org>
1031
1032         Reviewed by Eric Seidel.
1033
1034         [bzt] Kill WebKitLandingScripts
1035         https://bugs.webkit.org/show_bug.cgi?id=31904
1036
1037         Step 4: Kill run_webkit_script.
1038
1039         * Scripts/modules/buildsteps.py:
1040         * Scripts/modules/commands/download.py:
1041         * Scripts/modules/webkitlandingscripts.py:
1042
1043 2009-11-26  Adam Barth  <abarth@webkit.org>
1044
1045         Reviewed by Eric Seidel.
1046
1047         [bzt] Kill WebKitLandingScripts
1048         https://bugs.webkit.org/show_bug.cgi?id=31904
1049
1050         Step 3: Kill build_webkit.
1051
1052         * Scripts/modules/buildsteps.py:
1053         * Scripts/modules/landingsequence.py:
1054         * Scripts/modules/webkitlandingscripts.py:
1055
1056 2009-11-26  Adam Barth  <abarth@webkit.org>
1057
1058         Reviewed by Eric Seidel.
1059
1060         [bzt] Kill WebKitLandingScripts
1061         https://bugs.webkit.org/show_bug.cgi?id=31904
1062
1063         Step 2: Kill ensure_builders_are_green.
1064
1065         * Scripts/modules/buildsteps.py:
1066         * Scripts/modules/commands/download.py:
1067         * Scripts/modules/landingsequence.py:
1068         * Scripts/modules/webkitlandingscripts.py:
1069
1070 2009-11-26  Adam Barth  <abarth@webkit.org>
1071
1072         Reviewed by Eric Seidel.
1073
1074         [bzt] Kill WebKitLandingScripts
1075         https://bugs.webkit.org/show_bug.cgi?id=31904
1076
1077         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
1078
1079         * Scripts/bugzilla-tool:
1080         * Scripts/modules/buildsteps.py: Added.
1081         * Scripts/modules/commands/download.py:
1082         * Scripts/modules/landingsequence.py:
1083         * Scripts/modules/webkitlandingscripts.py:
1084
1085 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
1086
1087         Reviewed by Adam Barth.
1088
1089         Remove directory prefixes from linux commands
1090
1091         SCM unittests can cause errors on some systems if we use absolute reference to
1092         the commands, so directory prefixes have been removed.
1093
1094         * Scripts/modules/scm_unittest.py:
1095
1096 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
1097
1098         Reviewed by Kenneth Rohde Christiansen.
1099
1100         Link DumpRenderTree to the Qt Ui Tools
1101         https://bugs.webkit.org/show_bug.cgi?id=31203
1102
1103         Implement QWebPage::createPlugin using the Qt Ui Tools
1104         to be able to create classes like QProgressBar from within
1105         the <object></object> tags This is required for the
1106         new automatic test of Qt Plugins.
1107
1108         * DumpRenderTree/qt/DumpRenderTree.cpp:
1109         (WebCore::WebPage::createPlugin):
1110         * DumpRenderTree/qt/DumpRenderTree.h:
1111         * DumpRenderTree/qt/DumpRenderTree.pro:
1112
1113 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
1114
1115         Reviewed by Eric Seidel.
1116
1117         Update pywebsocket to 0.4.2
1118
1119         Update pywebsocket to 0.4.2
1120         https://bugs.webkit.org/show_bug.cgi?id=31861
1121
1122         * pywebsocket/example/echo_client.py:
1123         * pywebsocket/example/echo_wsh.py:
1124         * pywebsocket/mod_pywebsocket/__init__.py:
1125         * pywebsocket/mod_pywebsocket/dispatch.py:
1126         * pywebsocket/mod_pywebsocket/msgutil.py:
1127         * pywebsocket/mod_pywebsocket/standalone.py:
1128         * pywebsocket/setup.py:
1129         * pywebsocket/test/test_dispatch.py:
1130         * pywebsocket/test/test_msgutil.py:
1131
1132 2009-11-25  Adam Barth  <abarth@webkit.org>
1133
1134         Reviewed by Eric Seidel.
1135
1136         Add unit test for mark-fixed
1137         https://bugs.webkit.org/show_bug.cgi?id=31896
1138
1139         * Scripts/modules/commands/commandtest.py: Added.
1140         * Scripts/modules/commands/queries_unittest.py:
1141         * Scripts/modules/commands/upload_unittest.py: Added.
1142         * Scripts/modules/mock_bugzillatool.py:
1143         * Scripts/run-webkit-unittests:
1144
1145 2009-11-25  Adam Barth  <abarth@webkit.org>
1146
1147         Reviewed by Eric Seidel.
1148
1149         bugzilla-tool should have a mark-fixed command
1150         https://bugs.webkit.org/show_bug.cgi?id=31853
1151
1152         Pretty simple stuff.
1153
1154         * Scripts/modules/commands/upload.py:
1155
1156 2009-11-25  Eric Seidel  <eric@webkit.org>
1157
1158         Reviewed by Adam Barth.
1159
1160         'bugzilla-tool help' should only show common commands like how 'git help' does
1161         https://bugs.webkit.org/show_bug.cgi?id=31772
1162
1163         I also took this opportunity to make 'help' a real Command.
1164         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
1165
1166         * Scripts/bugzilla-tool:
1167          - change should_show_command_help to should_show_in_main_help
1168         * Scripts/modules/commands/download.py:
1169          - Mark commands as being shown in main help or not.
1170          - show_in_main_help = False is not required (default is false),
1171            but it seemed to make the commands more self-documenting.
1172         * Scripts/modules/commands/queries.py: ditto
1173         * Scripts/modules/commands/queues.py: ditto
1174         * Scripts/modules/commands/upload.py: ditto
1175         * Scripts/modules/multicommandtool.py:
1176          - Make Command hold a pointer to tool in self.tool.  Most Command
1177            subclasses do not take advantage of this yet, but it was required
1178            for HelpCommand to be able to reach the tool from _help_epilog().
1179          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
1180          - Move MultiCommandTool._help_epilog to Command._help_epilog
1181          - Move "help" logic into HelpCommand.execute()
1182          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
1183         * Scripts/modules/multicommandtool_unittest.py:
1184          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
1185
1186 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
1187
1188         Reviewed by Dan Bernstein.
1189         
1190         Patch by Mark Rowe.
1191
1192         The buildbots are failing on Windows because when they were upgraded
1193         to 4.0.4, Apple Application Support was not in their path. Add it to
1194         the path to fix the buildots.
1195
1196         * Scripts/webkitdirs.pm:
1197
1198 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1199
1200         Reviewed by David Kilzer.
1201
1202         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1203         https://bugs.webkit.org/show_bug.cgi?id=31799
1204
1205         * Scripts/run-webkit-tests: Fixed.
1206
1207 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1208
1209         Reviewed by Eric Seidel.
1210
1211         Change run_command to give back stderr by default
1212         https://bugs.webkit.org/show_bug.cgi?id=31734
1213
1214         Change run_command to give back stderr by default.
1215         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1216         Change the related unittest call.
1217
1218         * Scripts/modules/scm.py:
1219         * Scripts/modules/scm_unittest.py:
1220
1221 2009-11-25  Eric Seidel  <eric@webkit.org>
1222
1223         Reviewed by Adam Barth.
1224
1225         Centralize required argument parsing in Command
1226         https://bugs.webkit.org/show_bug.cgi?id=31872
1227
1228         * Scripts/modules/commands/download.py: remove custom required arg message.
1229         * Scripts/modules/commands/upload.py: ditto.
1230         * Scripts/modules/multicommandtool.py:
1231          - Add _parse_required_arguments.
1232          - Pass program name off to OptionParser.
1233          - Add name() for access to tool name.
1234          - Add check_arguments_and_execute and make it return a return code.
1235          - Replace a couple uses of + with %.
1236         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1237
1238 2009-11-25  Eric Seidel  <eric@webkit.org>
1239
1240         Reviewed by Adam Barth.
1241
1242         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1243         https://bugs.webkit.org/show_bug.cgi?id=31870
1244
1245         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1246         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1247         * Scripts/modules/outputcapture.py: Added.
1248
1249 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1250
1251         Reviewed by Eric Seidel.
1252
1253         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1254         https://bugs.webkit.org/show_bug.cgi?id=31444
1255
1256         * Scripts/build-webkit:
1257
1258 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1259
1260         Reviewed by Simon Fraser.
1261
1262         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1263         https://bugs.webkit.org/show_bug.cgi?id=27314
1264         
1265         Now the script allows the directories with these tests to be included on all
1266         platforms but Mac, where they behave the same as always. For all other platforms
1267         the tests need to be excluded using the Skipped files, which is currently done
1268         for all platforms (including win since we're not turned on yet)
1269
1270         * Scripts/webkitdirs.pm:
1271
1272 2009-11-24  Eric Seidel  <eric@webkit.org>
1273
1274         Reviewed by Adam Barth.
1275
1276         queries_unittest.py should test command output
1277         https://bugs.webkit.org/show_bug.cgi?id=31845
1278
1279         * Scripts/modules/commands/queries_unittest.py:
1280          - Capture stdout and stderr and compare with expected strings.
1281
1282 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1283
1284         No Review.
1285
1286         Fix spelling error ("depenedencies").
1287
1288         * Scripts/build-webkit:
1289
1290 2009-11-24  Mark Rowe  <mrowe@apple.com>
1291
1292         Land the configuration that includes the two debug GTK Linux builders.
1293
1294         * BuildSlaveSupport/build.webkit.org-config/config.json:
1295
1296 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1297
1298         <http://webkit.org/b/31840> bisect-builds broke after r50080
1299
1300         Reviewed by Dan Bernstein.
1301
1302         * Scripts/bisect-builds:
1303         (mountAndRunNightly): Switched back to using backticks to run
1304         the hdiutil command since exec() will terminate the existing
1305         script, which is not what we want.  Store the output of
1306         File::Spec->devnull() in a variable for use in the hdiutil
1307         detach commands.
1308
1309 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1310
1311         Reviewed by Kenneth Rohde Christiansen.
1312
1313         Include "config.h" to meet Coding Style Guidelines
1314         https://bugs.webkit.org/show_bug.cgi?id=31792
1315
1316         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1317         * DumpRenderTree/qt/jsobjects.cpp:
1318         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1319
1320 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1321
1322         Reviewed by Oliver Hunt.
1323
1324         Implement new required function to pass test we used to pass. This
1325         change is required since r51294.
1326
1327         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1328         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1329
1330 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1331
1332         Reviewed by Kenneth Rohde Christiansen.
1333
1334         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1335         https://bugs.webkit.org/show_bug.cgi?id=31775
1336
1337         LayoutTestController::dumpBackForwardList() should work with local URLs
1338         as well as with normal URLs (in http tests for instance).
1339         Currently it does not output the latter properly.
1340
1341         Unskip a bunch of passing http/navigation tests.
1342
1343         * DumpRenderTree/qt/DumpRenderTree.cpp:
1344         (WebCore::dumpHistoryItem):
1345
1346 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1347
1348         Reviewed by Oliver Hunt.
1349
1350         ARIA: support aria-flowto
1351         https://bugs.webkit.org/show_bug.cgi?id=31762
1352
1353         * DumpRenderTree/AccessibilityUIElement.cpp:
1354         (ariaFlowToElementAtIndexCallback):
1355         (AccessibilityUIElement::getJSClass):
1356         * DumpRenderTree/AccessibilityUIElement.h:
1357         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1358         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1359         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1360         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1361         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1362         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1363
1364 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1365
1366         Reviewed by Kenneth Christiansen.
1367
1368         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1369         https://bugs.webkit.org/show_bug.cgi?id=31638
1370
1371         Unfreeze WorkQueue after each test execution.
1372
1373         * DumpRenderTree/qt/DumpRenderTree.cpp:
1374         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1375
1376 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1377
1378         Reviewed by Adam Barth.
1379
1380         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1381         for localhost and 127.0.0.1.
1382         https://bugs.webkit.org/show_bug.cgi?id=31783
1383
1384         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1385
1386         * DumpRenderTree/qt/DumpRenderTree.cpp:
1387         (WebCore::NetworkAccessManager::NetworkAccessManager):
1388         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1389         (WebCore::WebPage::WebPage):
1390         * DumpRenderTree/qt/DumpRenderTree.h:
1391
1392 2009-11-22  Chris Evans  <cevans@chromium.org>
1393
1394         Reviewed by Adam Barth.
1395
1396         Disable access to file:/// directory listings
1397         https://bugs.webkit.org/show_bug.cgi?id=31329
1398
1399         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1400         file URL security.
1401
1402         * DumpRenderTree/LayoutTestController.cpp:
1403         (setAllowUniversalAccessFromFileURLsCallback):
1404         (LayoutTestController::staticFunctions):
1405         * DumpRenderTree/LayoutTestController.h:
1406         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1407         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1408         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1409         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1410         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1411         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1412         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1413         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1414
1415 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1416
1417         Reviewed by Kenneth Rohde Christiansen.
1418
1419         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1420         https://bugs.webkit.org/show_bug.cgi?id=31638
1421
1422         The test is timeouting, because it uses the WorkQueue to load a document in one
1423         of the child frames and once the loading is finished, the DRT does not dump the
1424         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1425         the main frame, while it should connect to QWebPage::loadFinished().
1426
1427         * DumpRenderTree/qt/DumpRenderTree.cpp:
1428         (WebCore::DumpRenderTree::DumpRenderTree):
1429
1430 2009-11-21  Eric Seidel  <eric@webkit.org>
1431
1432         Reviewed by Adam Barth.
1433
1434         bugzilla-tool --help spews way too much text
1435         https://bugs.webkit.org/show_bug.cgi?id=31771
1436
1437         * Scripts/bugzilla-tool:
1438          - Remove self.cached_scm initialization hack.
1439         * Scripts/modules/buildbot.py:
1440          - Make default_host accessible to callers.
1441         * Scripts/modules/commands/download.py:
1442          - Phrase help for all commands consistently and remove spurious help text punctuation.
1443         * Scripts/modules/commands/queries.py: Ditto.
1444         * Scripts/modules/commands/queues.py: Ditto.
1445         * Scripts/modules/commands/upload.py: Ditto.
1446         * Scripts/modules/multicommandtool.py:
1447          - Add HelpPrintingOptionParser.format_epilog to replace
1448            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
1449            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
1450          - Make --help only show a list of commands like "svn help" and "git help" do --
1451            previously --help was listing all commands and options.
1452          - Sort list of commands alphabetically.
1453
1454 2009-11-21  Eric Seidel  <eric@webkit.org>
1455
1456         No review.  Fixing a typo from the previous patch for bug 31767.
1457
1458         AbstractQueue.run_bugzilla_tool throws an exception
1459         https://bugs.webkit.org/show_bug.cgi?id=31769
1460
1461         * Scripts/modules/commands/queues.py:
1462
1463 2009-11-21  Eric Seidel  <eric@webkit.org>
1464
1465         Reviewed by Adam Barth.
1466
1467         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
1468         https://bugs.webkit.org/show_bug.cgi?id=31767
1469
1470         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
1471         Since we don't have a good way to test BugzillaTool pieces, I've
1472         left out a test for now.
1473
1474         * Scripts/bugzilla-tool:
1475          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1476         * Scripts/modules/commands/queues.py:
1477          - Use tool.path() instead of __file__.
1478         * Scripts/modules/multicommandtool.py:
1479          - Add a new path() method to MultiComandTool.
1480         * Scripts/modules/multicommandtool_unittest.py:
1481          - Provide a path() method.  Little point in testing this mock implementation.
1482
1483 2009-11-21  Adam Barth  <abarth@webkit.org>
1484
1485         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
1486         WebKitTools.
1487
1488         * Scripts/modules/commands/download.py:
1489
1490 2009-11-21  Adam Barth  <abarth@webkit.org>
1491
1492         Reviewed by Eric Seidel.
1493
1494         Convert check-style to use LandingSequence
1495         https://bugs.webkit.org/show_bug.cgi?id=31763
1496
1497         Instead of manipulating the working copy by hand, we should use the
1498         LandingSequence in CheckStyle.  This will make this code eaiser to
1499         test.
1500
1501         * Scripts/modules/commands/download.py:
1502
1503 2009-11-20  Adam Barth  <abarth@webkit.org>
1504
1505         Reviewed by Eric Seidel.
1506
1507         Unit test query commands
1508         https://bugs.webkit.org/show_bug.cgi?id=31755
1509
1510         These tests are pretty rough, but hopefully they'll grow.
1511
1512         * Scripts/modules/commands/queries_unittest.py: Added.
1513         * Scripts/modules/mock_bugzillatool.py: Added.
1514         * Scripts/run-webkit-unittests:
1515
1516 2009-11-20  Eric Seidel  <eric@webkit.org>
1517
1518         Reviewed by Adam Barth.
1519
1520         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
1521         https://bugs.webkit.org/show_bug.cgi?id=31758
1522
1523         * Scripts/modules/multicommandtool.py:
1524          - Allow passing of explicit commands to MultiCommandTool.__init__
1525         * Scripts/modules/multicommandtool_unittest.py:
1526          - Use new Command.name naming system.
1527          - Test Command auto-discovery.
1528         * Scripts/modules/workqueue.py:
1529          - bug_id no longer exists, use patch['bug_id'] instead.
1530         * Scripts/modules/workqueue_unittest.py:
1531          - WorkQueues require names now.
1532          - should_proceed_with_work_item must return a patch object.
1533
1534 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1535
1536         Reviewed by Beth Dakin.
1537
1538         WAI-ARIA: add support for aria-owns
1539         https://bugs.webkit.org/show_bug.cgi?id=31702
1540
1541         * DumpRenderTree/AccessibilityUIElement.cpp:
1542         (ariaOwnsElementAtIndexCallback):
1543         (AccessibilityUIElement::getJSClass):
1544         * DumpRenderTree/AccessibilityUIElement.h:
1545         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1546         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1547         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1548         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1549         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1550         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1551
1552 2009-11-20  Eric Seidel  <eric@webkit.org>
1553
1554         Reviewed by Adam Barth.
1555
1556         Fix exception thrown when running the commit-queue.
1557
1558         * Scripts/modules/statusbot.py: patch is optional.
1559         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
1560
1561 2009-11-20  Eric Seidel  <eric@webkit.org>
1562
1563         Reviewed by Adam Barth.
1564
1565         Teach the StatusBot how to support more than just the commit-queue
1566         https://bugs.webkit.org/show_bug.cgi?id=31754
1567
1568         * Scripts/modules/workqueue.py: Another typo.
1569
1570 2009-11-20  Eric Seidel  <eric@webkit.org>
1571
1572         Reviewed by Adam Barth.
1573
1574         Teach the StatusBot how to support more than just the commit-queue
1575         https://bugs.webkit.org/show_bug.cgi?id=31754
1576
1577         * Scripts/modules/commands/queues.py: Fix silly typo.
1578
1579 2009-11-20  Eric Seidel  <eric@webkit.org>
1580
1581         Reviewed by Adam Barth.
1582
1583         Teach the StatusBot how to support more than just the commit-queue
1584         https://bugs.webkit.org/show_bug.cgi?id=31754
1585
1586         * CommitQueueStatus/index.yaml:
1587          - Add indices required for the new queries.
1588         * CommitQueueStatus/queue_status.py:
1589          - Add a patch-status page and move update_status to update-status.
1590          - Only display "commit-queue" status records for the commit-queue.
1591          - Add support for a queue_name property on status records.
1592          - Fix _int_from_request to actually work.
1593         * CommitQueueStatus/update_status.html:
1594          - Add support for a queue_name on status records.
1595          - Remove unused list of bug ids.
1596          * Scripts/modules/commands/queues.py
1597           - Make the queues pass the patch instead of the bug_id to StatusBot.
1598         * Scripts/modules/statusbot.py:
1599          - Support passing the queue_name to the status updates.
1600          - Support fetching patch status with patch_status().
1601         * Scripts/modules/workqueue.py:
1602          - Pass the patch to the StatusBot instead of the bug_id.
1603          - Let WorkQueues have a name.
1604
1605 2009-11-20  Adam Barth  <abarth@webkit.org>
1606
1607         Reviewed by Eric Seidel.
1608
1609         Move bugzilla-tool commands into their own file
1610         https://bugs.webkit.org/show_bug.cgi?id=31752
1611
1612         This will let us write unit tests.
1613
1614         * Scripts/bugzilla-tool:
1615         * Scripts/modules/commands/__init__.py: Added.
1616         * Scripts/modules/commands/download.py: Added.
1617         * Scripts/modules/commands/queries.py: Added.
1618         * Scripts/modules/commands/queues.py: Added.
1619         * Scripts/modules/commands/upload.py: Added.
1620         * Scripts/modules/grammar.py: Added.
1621
1622 2009-11-20  Adam Barth  <abarth@webkit.org>
1623
1624         Reviewed by Eric Seidel.
1625
1626         BuildQueue should check if the tree is currently buildable
1627         https://bugs.webkit.org/show_bug.cgi?id=31744
1628
1629         * Scripts/bugzilla-tool:
1630         * Scripts/modules/landingsequence.py:
1631         * Scripts/modules/webkitlandingscripts.py:
1632
1633 2009-11-20  Adam Barth  <abarth@webkit.org>
1634
1635         Reviewed by Eric Seidel.
1636
1637         Move prepare_clean_working_directory into the LandingSequence
1638         https://bugs.webkit.org/show_bug.cgi?id=31743
1639
1640         * Scripts/bugzilla-tool:
1641         * Scripts/modules/landingsequence.py:
1642
1643 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1644
1645         Reviewed by Kenneth Rohde Christiansen.
1646
1647         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1648         https://bugs.webkit.org/show_bug.cgi?id=30460
1649
1650         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1651
1652         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1653         (pluginInvoke):
1654
1655 2009-11-20  Adam Barth  <abarth@webkit.org>
1656
1657         Reviewed by Eric Seidel.
1658
1659         Pass the port information to the child process
1660         https://bugs.webkit.org/show_bug.cgi?id=31736
1661
1662         We need to do this so the child process knows what to build!
1663
1664         * Scripts/bugzilla-tool:
1665         * Scripts/modules/landingsequence.py:
1666         * Scripts/modules/webkitport.py:
1667         * Scripts/modules/webkitport_unittest.py:
1668
1669 2009-11-20  Adam Barth  <abarth@webkit.org>
1670
1671         Reviewed by Eric Seidel.
1672
1673         Support Qt port in build-queue
1674         https://bugs.webkit.org/show_bug.cgi?id=31733
1675
1676         * Scripts/bugzilla-tool:
1677
1678 2009-11-20  Adam Barth  <abarth@webkit.org>
1679
1680         Reviewed by Eric Seidel.
1681
1682         Implement a build-queue
1683         https://bugs.webkit.org/show_bug.cgi?id=31725
1684
1685         Currently this just builds the first 10 patches in the review queue.
1686         We'll want to do something smarter soon.
1687
1688         * Scripts/bugzilla-tool:
1689
1690 2009-11-20  Adam Barth  <abarth@webkit.org>
1691
1692         Reviewed by Eric Seidel.
1693
1694         Make commit-queue and style-queue show up in help
1695         https://bugs.webkit.org/show_bug.cgi?id=31724
1696
1697         We need to store their names on their class to make these commands
1698         properly register themselves with MultiCommandTool.
1699
1700         * Scripts/bugzilla-tool:
1701
1702 2009-11-20  Adam Barth  <abarth@webkit.org>
1703
1704         Reviewed by Eric Seidel.
1705
1706         Implement bugzilla-tool build-attachment
1707         https://bugs.webkit.org/show_bug.cgi?id=31722
1708
1709         This command builds an attachment from bugzilla.  It leaves the built
1710         patch in the working copy.
1711
1712         * Scripts/bugzilla-tool:
1713         * Scripts/modules/landingsequence.py:
1714         * Scripts/modules/webkitlandingscripts.py:
1715
1716 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1717
1718         Reviewed by Xan Lopez.
1719
1720         [GTK] DRT release event does not create the state correctly
1721         https://bugs.webkit.org/show_bug.cgi?id=31717
1722
1723         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1724
1725 2009-11-20  Eric Seidel  <eric@webkit.org>
1726
1727         Reviewed by Adam Barth.
1728
1729         MultiCommandTool should find Command objects automatically instead of with a manual list
1730         https://bugs.webkit.org/show_bug.cgi?id=31710
1731
1732         * Scripts/bugzilla-tool:
1733         * Scripts/modules/multicommandtool.py:
1734          - Use some wild python-fu to crawl all the known subclasses of Command.
1735
1736 2009-11-20  Adam Barth  <abarth@webkit.org>
1737
1738         Unreviewed "build" fix.  Added missing import.
1739
1740         * Scripts/bugzilla-tool:
1741
1742 2009-11-20  Adam Barth  <abarth@webkit.org>
1743
1744         Unreviewed "build" fix.  I failed to update LandingSequence.test
1745         properly.
1746
1747         * Scripts/modules/landingsequence.py:
1748
1749 2009-11-20  Adam Barth  <abarth@webkit.org>
1750
1751         Reviewed by Eric Seidel.
1752
1753         Create LandingSequence as the all-sing, all-dance landing class
1754         https://bugs.webkit.org/show_bug.cgi?id=31709
1755
1756         Client can inherit from this class to carefully control exactly which
1757         steps they wish to have happen in the landing sequence.
1758
1759         * Scripts/bugzilla-tool:
1760         * Scripts/modules/landingsequence.py: Added.
1761         * Scripts/modules/webkitlandingscripts.py: Added.
1762
1763 2009-11-19  Adam Barth  <abarth@webkit.org>
1764
1765         Reviewed by Eric Seidel.
1766
1767         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1768         https://bugs.webkit.org/show_bug.cgi?id=31707
1769
1770         This is to help when we implement build-attachment.
1771
1772         * Scripts/bugzilla-tool:
1773
1774 2009-11-19  Adam Barth  <abarth@webkit.org>
1775
1776         Reviewed by Eric Seidel.
1777
1778         Support Qt port in bugzilla-tool
1779         https://bugs.webkit.org/show_bug.cgi?id=31701
1780
1781         Now we support building with Qt!
1782
1783         * Scripts/bugzilla-tool:
1784         * Scripts/modules/webkitport.py: Added.
1785         * Scripts/modules/webkitport_unittest.py: Added.
1786         * Scripts/run-webkit-unittests:
1787
1788 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1789
1790         Reviewed by Adam Barth.
1791
1792         Remove inserting stderr into patch in bugzilla-tool
1793         https://bugs.webkit.org/show_bug.cgi?id=29914
1794
1795         Modify SCM python module's run_command function to avoid return of stderr
1796         by default, so stderr won't be inserted into the patches.
1797         Modify the related unit test.
1798
1799         * Scripts/modules/scm.py:
1800         * Scripts/modules/scm_unittest.py:
1801
1802 2009-11-19  Eric Seidel  <eric@webkit.org>
1803
1804         Reviewed by Adam Barth.
1805
1806         bugzilla-tool needs per-command help
1807         https://bugs.webkit.org/show_bug.cgi?id=31697
1808
1809         Added support for "bugzilla-tool help command-name"
1810         and a unit test to make sure it works.
1811
1812         * Scripts/modules/multicommandtool.py:
1813         * Scripts/modules/multicommandtool_unittest.py:
1814
1815 2009-11-19  Eric Seidel  <eric@webkit.org>
1816
1817         Reviewed by Adam Barth.
1818
1819         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1820         https://bugs.webkit.org/show_bug.cgi?id=31695
1821
1822         * Scripts/bugzilla-tool:
1823         * Scripts/modules/multicommandtool.py: Added.
1824         * Scripts/modules/multicommandtool_unittest.py: Added.
1825         * Scripts/run-webkit-unittests:
1826
1827 2009-11-19  Eric Seidel  <eric@webkit.org>
1828
1829         No review, just adding a FIXME.
1830
1831         Split out command parsing and help printing from BugzillaTool
1832         https://bugs.webkit.org/show_bug.cgi?id=31688
1833
1834         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1835
1836 2009-11-19  Eric Seidel  <eric@webkit.org>
1837
1838         Reviewed by Adam Barth.
1839
1840         Split out command parsing and help printing from BugzillaTool
1841         https://bugs.webkit.org/show_bug.cgi?id=31688
1842
1843         * Scripts/bugzilla-tool:
1844          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1845          - Rename private methods to use _ pattern.
1846          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1847          - 
1848
1849 2009-11-19  Eric Seidel  <eric@webkit.org>
1850
1851         Reviewed by Adam Barth.
1852
1853         Re-factor help printing to use modern python idioms
1854         https://bugs.webkit.org/show_bug.cgi?id=31685
1855
1856         * Scripts/bugzilla-tool:
1857
1858 2009-11-19  Eric Seidel  <eric@webkit.org>
1859
1860         Reviewed by Darin Adler.
1861
1862         commit-queue empty queue logs twice
1863         https://bugs.webkit.org/show_bug.cgi?id=31679
1864
1865         * Scripts/bugzilla-tool:
1866
1867 2009-11-19  Eric Seidel  <eric@webkit.org>
1868
1869         Reviewed by Darin Adler.
1870
1871         bugzilla-tool's reviewer/committer rejection message should be clearer
1872         https://bugs.webkit.org/show_bug.cgi?id=31126
1873
1874         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1875
1876         * Scripts/modules/bugzilla.py:
1877
1878 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1879
1880         Reviewed by Pavel Feldman.
1881
1882         Forces a WM_PAINT event on calling layoutTestController.display()
1883         in order to enable the timeline-paint.html test on Windows.
1884         ::UpdateWindow() does not force an event becaue the window is 
1885         not visible.
1886
1887         https://bugs.webkit.org/show_bug.cgi?id=31402
1888
1889         * DumpRenderTree/win/DumpRenderTree.cpp:
1890         (displayWebView):
1891
1892 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1893
1894         No review needed.
1895
1896         Added myself to committers list.
1897
1898         * Scripts/modules/committers.py:
1899
1900 2009-11-19  Adam Barth  <abarth@webkit.org>
1901
1902         Reviewed by Eric Seidel.
1903
1904         Bugzilla-tool command classes should match command names
1905         https://bugs.webkit.org/show_bug.cgi?id=31666
1906
1907         I renamed all the commands except CommitMessageForCurrentDiff because
1908         the new name would conflict with an existing class.
1909
1910         * Scripts/bugzilla-tool:
1911
1912 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1913
1914         Reviewed by Gustavo Noronha Silva.
1915
1916         Web Inspector: Implement "show inspector" in WebKit GTK
1917         API and enable console tests.
1918
1919         https://bugs.webkit.org/show_bug.cgi?id=31669
1920
1921         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1922         (LayoutTestController::showWebInspector):
1923
1924 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1925
1926         Reviewed by Simon Hausmann.
1927
1928         Minor refactoring + more documentation.
1929
1930         * DumpRenderTree/qt/DumpRenderTree.cpp:
1931         (WebCore::clearHistory):
1932         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1933
1934 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1935
1936         Reviewed by Eric Seidel.
1937
1938         Ignore websocket tests when --no-http is specified.
1939         https://bugs.webkit.org/show_bug.cgi?id=31662
1940
1941         * Scripts/run-webkit-tests:
1942
1943 2009-11-18  Adam Barth  <abarth@webkit.org>
1944
1945         Reviewed by Eric Seidel.
1946
1947         Normalize ' and " in bugzilla-tool
1948         https://bugs.webkit.org/show_bug.cgi?id=31655
1949
1950         We decided " is better than ' and we should be consistent.
1951
1952         * Scripts/bugzilla-tool:
1953
1954 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1955
1956         Reviewed by Kenneth Rohde Christiansen.
1957
1958         [Qt] Remove support for Qt v4.3 or older versions
1959         https://bugs.webkit.org/show_bug.cgi?id=29469
1960
1961         * DumpRenderTree/qt/DumpRenderTree.pro:
1962         * DumpRenderTree/qt/ImageDiff.pro:
1963
1964 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1965
1966         Reviewed by Eric Seidel.
1967
1968         GitTest.test_create_binary_patch fails if /tmp is symlink
1969         https://bugs.webkit.org/show_bug.cgi?id=31536
1970
1971         * Scripts/modules/scm_unittest.py:
1972
1973 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1974
1975         Reviewed by Darin Adler.
1976
1977         Configuration for Chromium Build Slaves.
1978
1979         https://bugs.webkit.org/show_bug.cgi?id=31442
1980
1981         * BuildSlaveSupport/build.webkit.org-config/config.json:
1982         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1983
1984 2009-11-18  Eric Seidel  <eric@webkit.org>
1985
1986         Reviewed by Darin Adler.
1987
1988         workqueue.py results in totally broken commit-queue UI
1989         https://bugs.webkit.org/show_bug.cgi?id=31645
1990
1991         * Scripts/bugzilla-tool:
1992          - Remove unneeded use of PatchCollection.
1993          - Grab a new copy of the cq'd patches every run of the queue.
1994
1995 2009-11-18  Sam Weinig  <sam@webkit.org>
1996
1997         Reviewed by Anders Carlsson.
1998
1999         Make the Mac Geolocation API async.
2000
2001         Update DRT to use the new async Mac Geolocation API.
2002
2003         * DumpRenderTree/mac/UIDelegate.mm:
2004         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2005
2006 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2007
2008         Reviewed by Kenneth Rohde Christiansen.
2009
2010         Add and option to toggle HTML5 datalist support to build-webkit
2011         https://bugs.webkit.org/show_bug.cgi?id=31599
2012
2013         * Scripts/build-webkit:
2014
2015 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
2016
2017         Reviewed by Kevin Ollivier.
2018
2019         Enable wx plugin support using the Windows implementation as a base.
2020         
2021         https://bugs.webkit.org/show_bug.cgi?id=31636
2022
2023         * wx/build/settings.py:
2024
2025 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2026
2027         Reviewed by Simon Hausmann.
2028
2029         Change the initialization order so that the controllers
2030         will be created before exporting them to the JS DOM window.
2031
2032         * DumpRenderTree/qt/DumpRenderTree.cpp:
2033         (WebCore::DumpRenderTree::DumpRenderTree):
2034
2035 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2036
2037         Reviewed by Simon Hausmann.
2038
2039         Fix a code copy and paste error. m_page should be page.
2040
2041         * DumpRenderTree/qt/DumpRenderTree.cpp:
2042         (WebCore::DumpRenderTree::createWindow):
2043
2044 2009-11-17  Mark Rowe  <mrowe@apple.com>
2045
2046         Reviewed by Alexey Proskuryakov.
2047
2048         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
2049
2050         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
2051         This prevents symlinks from confusing the descendant check.
2052
2053 2009-11-17  Mark Rowe  <mrowe@apple.com>
2054
2055         Reviewed by Alexey Proskuryakov.
2056
2057         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
2058
2059         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
2060         server to be up rather than having run-webkit-tests abort immediately.
2061
2062         * Scripts/run-webkit-tests:
2063
2064 2009-11-17  Eric Seidel  <eric@webkit.org>
2065
2066         Reviewed by Darin Adler.
2067
2068         commit-queue is failing to set reviewer in ChangeLogs
2069         https://bugs.webkit.org/show_bug.cgi?id=31592
2070
2071         * Scripts/bugzilla-tool: Clarify the "applying" log message.
2072         * Scripts/modules/bugzilla.py:
2073          - Add a new _validate_committer_and_reviewer function as a
2074            temporary solution until we can make a real Attachment object
2075            which knows how to fill in its committer/reviewer fields automatically.
2076
2077 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2078
2079         Unreviewed buildbot fix.
2080
2081         Revert part of earlier patch and add comment, as it
2082         was causing timeouts on the buildbot.
2083
2084         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2085         (LayoutTestController::notifyDone):
2086
2087 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2088
2089         Reviewed by Oliver Hunt.
2090
2091         Make the timeout 15 sec as for the other DRT's and make
2092         it print out the same output when a test timeout.
2093
2094         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2095         (LayoutTestController::waitUntilDone):
2096         (LayoutTestController::notifyDone):
2097         (LayoutTestController::timerEvent):
2098
2099 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
2100
2101         Reviewed by Timothy Hatcher.
2102
2103         Fixed typos in comments.
2104
2105         * Scripts/modules/committers.py:
2106
2107 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2108
2109         Reviewed by Timothy Hatcher.
2110
2111         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2112         - Updated DRT to show/close inspector for all tests under /inspector
2113         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2114           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2115         - Removed reload on each inspector test
2116         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2117         inspector for those.
2118         - Reimplemented timeline tests in order to get rid of reload there.
2119         - Moved tests that don't require harness into the fast group.
2120
2121         https://bugs.webkit.org/show_bug.cgi?id=31472
2122
2123         * DumpRenderTree/LayoutTestController.cpp:
2124         (setTimelineProfilingEnabledCallback):
2125         (closeWebInspectorCallback):
2126         (LayoutTestController::staticFunctions):
2127         * DumpRenderTree/LayoutTestController.h:
2128         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2129         (shouldOpenWebInspector):
2130         (runTest):
2131         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2132         (LayoutTestController::setTimelineProfilingEnabled):
2133         * DumpRenderTree/mac/DumpRenderTree.mm:
2134         (shouldOpenWebInspector):
2135         (runTest):
2136         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2137         (LayoutTestController::setTimelineProfilingEnabled):
2138         * DumpRenderTree/win/DumpRenderTree.cpp:
2139         (shouldOpenWebInspector):
2140         (runTest):
2141         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2142         (LayoutTestController::setTimelineProfilingEnabled):
2143
2144 2009-11-17  Oliver Hunt  <oliver@apple.com>
2145
2146         Reviewed by Maciej Stachowiak.
2147
2148         Incorrect use of JavaScriptCore API in DumpRenderTree
2149         https://bugs.webkit.org/show_bug.cgi?id=31577
2150
2151         Return undefined rather than a literal null.
2152
2153         * DumpRenderTree/AccessibilityUIElement.cpp:
2154         (setSelectedTextRangeCallback):
2155         (incrementCallback):
2156         (decrementCallback):
2157         (showMenuCallback):
2158
2159 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2160
2161         Reviewed by Beth Dakin.
2162
2163         AX: aria-labelledby duplicates some of its WAI-ARIA label
2164         https://bugs.webkit.org/show_bug.cgi?id=31565
2165
2166         * DumpRenderTree/AccessibilityUIElement.cpp:
2167         (titleUIElementCallback):
2168         (getIsValidCallback):
2169         (AccessibilityUIElement::getJSClass):
2170
2171 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2172
2173         Reviewed by Simon Hausmann.
2174
2175         r50942 broke output from created windows. Make the
2176         m_enableTextOutput a member of the DRT and not the
2177         WebPage.
2178
2179         * DumpRenderTree/qt/DumpRenderTree.cpp:
2180         (WebCore::WebPage::WebPage):
2181         (WebCore::WebPage::javaScriptAlert):
2182         (WebCore::WebPage::javaScriptConsoleMessage):
2183         (WebCore::WebPage::javaScriptConfirm):
2184         (WebCore::WebPage::javaScriptPrompt):
2185         (WebCore::WebPage::acceptNavigationRequest):
2186         (WebCore::DumpRenderTree::DumpRenderTree):
2187         (WebCore::DumpRenderTree::open):
2188         (WebCore::DumpRenderTree::createWindow):
2189         * DumpRenderTree/qt/DumpRenderTree.h:
2190         (WebCore::DumpRenderTree::setTextOutputEnabled):
2191         (WebCore::DumpRenderTree::isTextOutputEnabled):
2192         (WebCore::WebPage::shouldInterruptJavaScript):
2193         (WebCore::WebPage::isTextOutputEnabled):
2194         (WebCore::WebPage::setViewGeometry):
2195
2196 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2197
2198         Reviewed by Gustavo Noronha Silva.
2199
2200         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2201         as the implementation is being used by at least Qt and Gtk+.
2202
2203         Update buildsystems as well.
2204
2205         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2206         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2207         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2208         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2209         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2210         * GNUmakefile.am:
2211
2212 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2213
2214         Reviewed by Alexey Proskuryakov.
2215
2216         Disable wss until all platforms support pyOpenSSL
2217
2218         https://bugs.webkit.org/show_bug.cgi?id=31479
2219
2220         * Scripts/run-webkit-tests:
2221
2222 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2223
2224         Reviewed by Kenneth Christiansen.
2225
2226         [Qt] Implement load error pages support for Qt's DRT.
2227         https://bugs.webkit.org/show_bug.cgi?id=31509
2228
2229         For now, it will not be a default feature, and layout tests
2230         that want to make use of this have to explicitily call
2231         'handleErrorPages();' for the test source.
2232
2233         Any of the other DumpRenderTree's (mac, win and gtk)
2234         support handling error pages. Qt's will be the first.
2235
2236         * DumpRenderTree/qt/DumpRenderTree.cpp:
2237         (WebCore::WebPage::supportsExtension):
2238         (WebCore::WebPage::extension):
2239         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2240         (LayoutTestController::reset):
2241         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2242         (LayoutTestController::shouldHandleErrorPages):
2243         (LayoutTestController::handleErrorPages):
2244
2245 2009-11-16  Eric Seidel  <eric@webkit.org>
2246
2247         Reviewed by Adam Barth.
2248
2249         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2250         https://bugs.webkit.org/show_bug.cgi?id=31549
2251
2252         Renamed --commit-queue to --non-interactive in most places
2253         and remove the code in land-patches which is no longer needed.
2254
2255         * Scripts/bugzilla-tool:
2256
2257 2009-11-16  Eric Seidel  <eric@webkit.org>
2258
2259         Reviewed by Adam Barth.
2260
2261         The commit-queue should use land-attachment
2262         https://bugs.webkit.org/show_bug.cgi?id=31548
2263
2264         * Scripts/bugzilla-tool:
2265
2266 2009-11-16  Adam Barth  <abarth@webkit.org>
2267
2268         Reviewed by Eric Seidel.
2269
2270         Convert CommitQueue over to PatchCollection
2271         https://bugs.webkit.org/show_bug.cgi?id=31547
2272
2273         Also fixes a bug in workqueue and adds a test!
2274
2275         * Scripts/bugzilla-tool:
2276         * Scripts/modules/workqueue.py:
2277         * Scripts/modules/workqueue_unittest.py:
2278
2279 2009-11-16  Adam Barth  <abarth@webkit.org>
2280
2281         Reviewed by Eric Seidel.
2282
2283         Move StyleQueue over to using PatchCollection
2284         https://bugs.webkit.org/show_bug.cgi?id=31544
2285
2286         That's what the class it's for.
2287
2288         * Scripts/bugzilla-tool:
2289         * Scripts/modules/patchcollection.py:
2290         * Scripts/modules/patchcollection_unittest.py:
2291
2292 2009-11-16  Eric Seidel  <eric@webkit.org>
2293
2294         Reviewed by Adam Barth.
2295
2296         bugzilla-tool needs a land-attachment command
2297         https://bugs.webkit.org/show_bug.cgi?id=31546
2298
2299         * Scripts/bugzilla-tool:
2300          - Move all the logic into AbstractLandingCommand and
2301            add a new LandAttachment command subclass.
2302          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2303
2304 2009-11-16  Eric Seidel  <eric@webkit.org>
2305
2306         Reviewed by Adam Barth.
2307
2308         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2309         https://bugs.webkit.org/show_bug.cgi?id=31543
2310
2311         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2312
2313         * Scripts/bugzilla-tool:
2314
2315 2009-11-16  Eric Seidel  <eric@webkit.org>
2316
2317         Reviewed by Adam Barth.
2318
2319         Disable the style queue from posting to the commit queue status page.
2320
2321         * Scripts/bugzilla-tool:
2322
2323 2009-11-16  Adam Barth  <abarth@webkit.org>
2324
2325         Reviewed by Eric Seidel.
2326
2327         Implement PatchCollection
2328         https://bugs.webkit.org/show_bug.cgi?id=31541
2329
2330         This class holds a set of patches and lets clients iterate through
2331         them.  Optionally, clients can install a filter.
2332
2333         * Scripts/modules/patchcollection.py: Added.
2334         * Scripts/modules/patchcollection_unittest.py: Added.
2335         * Scripts/run-webkit-unittests:
2336
2337 2009-11-16  Eric Seidel  <eric@webkit.org>
2338
2339         Reviewed by Adam Barth.
2340
2341         bugzilla-tool land-patches will close bugs with patches r=?
2342         https://bugs.webkit.org/show_bug.cgi?id=28230
2343
2344         The commit-queue shouldn't close patches with outstanding reviews on them,
2345         even if many reviewers seem to be against multi-patch bugs.
2346
2347         * Scripts/bugzilla-tool:
2348
2349 2009-11-16  Eric Seidel  <eric@webkit.org>
2350
2351         Reviewed by Adam Barth.
2352
2353         bugzilla-tool check-style should work with attachment ids instead of bug ids
2354         https://bugs.webkit.org/show_bug.cgi?id=31540
2355
2356         * Scripts/bugzilla-tool:
2357
2358 2009-11-16  Eric Seidel  <eric@webkit.org>
2359
2360         Reviewed by Adam Barth.
2361
2362         WorkQueue is the only place that should know about special exit codes
2363         https://bugs.webkit.org/show_bug.cgi?id=31534
2364
2365         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2366         and add tests for handling exit codes.
2367         I also cleaned up workqueue_unittest.py more.
2368
2369         * Scripts/bugzilla-tool:
2370         * Scripts/modules/workqueue.py:
2371         * Scripts/modules/workqueue_unittest.py:
2372
2373 2009-11-16  Eric Seidel  <eric@webkit.org>
2374
2375         Reviewed by Adam Barth.
2376
2377         Re-factor workqueue_unittest to allow for more than one test.
2378         https://bugs.webkit.org/show_bug.cgi?id=31535
2379
2380         * Scripts/modules/workqueue_unittest.py:
2381
2382 2009-11-16  Eric Seidel  <eric@webkit.org>
2383
2384         Reviewed by Adam Barth.
2385
2386         land-patches needs to be re-factored into smaller chunks
2387         https://bugs.webkit.org/show_bug.cgi?id=31532
2388
2389         * Scripts/bugzilla-tool: fix a couple obvious typos.
2390
2391 2009-11-16  Eric Seidel  <eric@webkit.org>
2392
2393         Reviewed by Adam Barth.
2394
2395         land-patches needs to be re-factored into smaller chunks
2396         https://bugs.webkit.org/show_bug.cgi?id=31532
2397
2398         The next patch will move these methods into WebKitLandingScripts.
2399
2400         * Scripts/bugzilla-tool:
2401          - Split out _land_patch and _close_bug_if_no_active_patches.
2402
2403 2009-11-16  Adam Barth  <abarth@webkit.org>
2404
2405         Reviewed by Eric Seidel.
2406
2407         Fix silly copy-and-paste code.  I am a terrible coder.
2408
2409         * Scripts/modules/bugzilla.py:
2410
2411 2009-11-16  Adam Barth  <abarth@webkit.org>
2412
2413         Reviewed by Eric Seidel.
2414
2415         Implement a StyleQueue
2416         https://bugs.webkit.org/show_bug.cgi?id=31537
2417
2418         The first iteration of the style queue only produces output locally.
2419         There is also a limit of 10 patches because it's not that useful to
2420         iterate through the entire review queue at this point.  We can remove
2421         the limit later.
2422
2423         * Scripts/bugzilla-tool:
2424         * Scripts/modules/bugzilla.py:
2425
2426 2009-11-16  Adam Barth  <abarth@webkit.org>
2427
2428         Reviewed by Eric Seidel.
2429
2430         Unit test WorkQueue
2431         https://bugs.webkit.org/show_bug.cgi?id=31531
2432
2433         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
2434
2435         * Scripts/bugzilla-tool:
2436         * Scripts/modules/statusbot.py:
2437         * Scripts/modules/workqueue.py:
2438         * Scripts/modules/workqueue_unittest.py: Added.
2439         * Scripts/run-webkit-unittests:
2440
2441 2009-11-16  Eric Seidel  <eric@webkit.org>
2442
2443         Reviewed by Adam Barth.
2444
2445         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
2446         https://bugs.webkit.org/show_bug.cgi?id=31530
2447
2448         * Scripts/bugzilla-tool:
2449
2450 2009-11-16  Eric Seidel  <eric@webkit.org>
2451
2452         Reviewed by Adam Barth.
2453
2454         bugzilla-tool needs apply-attachment
2455         https://bugs.webkit.org/show_bug.cgi?id=31528
2456
2457         * Scripts/bugzilla-tool:
2458          - Add ApplyAttachment command.
2459          - Abstract applying code into WebKitApplyingScripts.
2460          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
2461         * Scripts/modules/bugzilla.py:
2462          - Add fetch_attachment and bug_id_for_attachment_id.
2463         * Scripts/modules/bugzilla_unittest.py:
2464          - Add test for new parsing.
2465          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
2466
2467 2009-11-16  Eric Seidel  <eric@webkit.org>
2468
2469         Reviewed by Adam Barth.
2470
2471         Document check-style's use of force_clean.
2472
2473         * Scripts/bugzilla-tool:
2474         * Scripts/modules/scm.py:
2475
2476 2009-11-16  Adam Barth  <abarth@webkit.org>
2477
2478         Reviewed by Eric Seidel.
2479
2480         Move WorkQueue to its own file
2481         https://bugs.webkit.org/show_bug.cgi?id=31529
2482
2483         WorkQueue and WorkQueueDelegate are separate concerns from
2484         bugzilla-tool.  Also added a missing include to logging.py.
2485
2486         * Scripts/bugzilla-tool:
2487         * Scripts/modules/logging.py:
2488         * Scripts/modules/workqueue.py:
2489
2490 2009-11-16  Adam Barth  <abarth@webkit.org>
2491
2492         Reviewed by Eric Seidel.
2493
2494         Move OutputTee to logging.py.
2495
2496         * Scripts/bugzilla-tool:
2497         * Scripts/modules/logging.py:
2498
2499 2009-11-15  Adam Barth  <abarth@webkit.org>
2500
2501         Reviewed by Eric Seidel.
2502
2503         Refactor bugzilla-tool to allow for multiple queues
2504         https://bugs.webkit.org/show_bug.cgi?id=31513
2505
2506         Divide the commit queue class into three class to make creating
2507         additional queues easier.
2508
2509         * Scripts/bugzilla-tool:
2510
2511 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2512
2513         Reviewed by Eric Seidel.
2514
2515         svn-apply may not handle git patches created by bugzilla-tool
2516         https://bugs.webkit.org/show_bug.cgi?id=31457
2517
2518         * Scripts/modules/scm.py:
2519         * Scripts/modules/scm_unittest.py:
2520
2521 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2522
2523         Reviewed by Eric Seidel.
2524
2525         bugzilla-tool should post git binary diff
2526         https://bugs.webkit.org/show_bug.cgi?id=31458
2527
2528         Add --binary option to Git.create_patch.
2529
2530         * Scripts/modules/scm.py:
2531         * Scripts/modules/scm_unittest.py:
2532
2533 2009-11-15  Adam Barth  <abarth@webkit.org>
2534
2535         Reviewed by Darin Adler.
2536
2537         Add bugzilla-tool check-style
2538         https://bugs.webkit.org/show_bug.cgi?id=31515
2539
2540         * Scripts/bugzilla-tool:
2541         * Scripts/modules/bugzilla.py:
2542
2543 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2544
2545         Reviewed by Simon Hausmann.
2546
2547         Make the Qt Linux only --valgrind feature, suppress errors
2548         defined in the SuppressedValgrindErrors file.
2549
2550         * Scripts/run-webkit-tests:
2551
2552 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2553
2554         Reviewed by Simon Hausmann.
2555
2556         Set the locale to C and not to the current one in use on the system.
2557
2558         * DumpRenderTree/qt/DumpRenderTree.cpp:
2559         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2560
2561 2009-11-13  Adam Roben  <aroben@apple.com>
2562
2563         Add support for
2564         http/tests/security/isolatedWorld/didClearWindowObject.html
2565
2566         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2567         window objects in isolated worlds are cleared
2568
2569         Reviewed by Dave Hyatt.
2570
2571         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
2572
2573         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2574         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2575         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
2576         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2577         Added. Sets a __worldID property on the global object whose value is
2578         the ID of this world.
2579         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
2580         Respond to this new delegate callback by calling through to one of the
2581         above new methods.
2582         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2583         (worldMap): Added. Returns a HashMap containing all the worlds we've
2584         created.
2585         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
2586         haven't kept track of this world.
2587         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2588         instead of declaring our own.
2589
2590         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
2591
2592         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2593         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
2594         didClearWindowObjectForFrameInStandardWorld.
2595         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
2596         Respond to this new delegate callback by calling through to one of the
2597         below new methods.
2598         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
2599         Added. Sets a __worldID property on the gobal object whose value is
2600         the ID of this world.
2601         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2602         Added. Moved code here from didClearWindowObject.
2603
2604         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
2605         didClearWindowObjectForFrame* functions.
2606
2607         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2608         (worldMap): Added. Returns a HashMap containing all the worlds we've
2609         created.
2610         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2611         haven't kept track of this world.
2612         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2613         instead of declaring our own.
2614
2615 2009-11-13  Adam Roben  <aroben@apple.com>
2616
2617         Finish replacing worldIDs with world objects
2618
2619         The only remaining use of worldIDs was in a method only used by DRT
2620         for the isolated worlds tests.
2621
2622         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2623
2624         Reviewed by Mark Rowe.
2625
2626         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2627         (LayoutTestController::evaluateScriptInIsolatedWorld):
2628         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2629         (LayoutTestController::evaluateScriptInIsolatedWorld):
2630         Updated for changes to WebFrame. Now holds the map of worldID -> world
2631         at this level instead of making WebKit do it.
2632
2633 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2634
2635         Reviewed by Simon Hausmann.
2636
2637         [Qt] Ensure the DRT does not output anything until first test is run
2638
2639         * DumpRenderTree/qt/DumpRenderTree.cpp:
2640         * DumpRenderTree/qt/DumpRenderTree.h:
2641
2642 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2643
2644         Reviewed by Tor Arne Vestbø.
2645
2646         Clear the undo stack in before each new test run.
2647
2648         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2649
2650         * DumpRenderTree/qt/DumpRenderTree.cpp:
2651         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2652
2653 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2654
2655         Reviewed by Kenneth Rohde Christiansen.
2656
2657         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2658
2659         * DumpRenderTree/qt/DumpRenderTree.cpp:
2660         (WebCore::WebPage::resetSettings):
2661         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2662         (LayoutTestController::overridePreference):
2663
2664 2009-11-13  Eric Seidel  <eric@webkit.org>
2665
2666         Reviewed by Adam Barth.
2667
2668         Update committers.py based on svn records
2669         https://bugs.webkit.org/show_bug.cgi?id=31366
2670
2671         This list was generated using validate-committer-lists from
2672         https://bugs.webkit.org/show_bug.cgi?id=30970
2673         and makes committers.py current for committers who have
2674         committed in the last 3 years.
2675
2676         * Scripts/modules/committers.py:
2677
2678 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2679
2680         Reviewed by Adam Barth.
2681
2682         The document-open.html test was flaky at times. The test invokes the layout test plugin
2683         which in its destroy stream handler opens a new document. This basically tears down the
2684         stream and the associated plugin instance. The pluginLog function in the layout test
2685         plugin attempts to retrieve the window script object on a torn down plugin instance
2686         which crashed consistently on windows in the debugger. The functions which issue
2687         these logs already have a valid window script object. We now have variants of the pluginLog
2688         function which take in a window script object with and without variable arguments. 
2689
2690         https://bugs.webkit.org/show_bug.cgi?id=31067
2691
2692         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2693         (pluginLogWithWindowObject):
2694         (pluginLogWithWindowObjectVariableArgs):
2695         (pluginLog):
2696         (notifyTestCompletion):
2697         (testDocumentOpen):
2698         (testWindowOpen):
2699
2700 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2701
2702         Reviewed by Gustavo Noronha Silva.
2703
2704         https://bugs.webkit.org/show_bug.cgi?id=30997
2705         [Gtk] Implemment AtkDocument
2706
2707         Added testing support.
2708
2709         * DumpRenderTree/AccessibilityUIElement.cpp:
2710         * DumpRenderTree/AccessibilityUIElement.h:
2711         (getDocumentEncodingCallback):
2712         (getDocumentURICallback):
2713         (AccessibilityUIElement::getJSClass):
2714         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2715         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2716         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2717         (AccessibilityUIElement::documentEncoding):
2718         (AccessibilityUIElement::documentURI):
2719
2720 2009-11-12  Adam Roben  <aroben@apple.com>
2721
2722         Replace worldIDs with world objects
2723
2724         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2725         user scripts/stylesheets and isolated worlds
2726
2727         Reviewed by Sam Weinig.
2728
2729         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2730         (LayoutTestController::addUserScript):
2731         (LayoutTestController::addUserStyleSheet):
2732         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2733         (LayoutTestController::addUserScript):
2734         (LayoutTestController::addUserStyleSheet):
2735         Changed these functions to create a new WebJSWorld each time they're
2736         called and to pass that world to WebKit.
2737
2738 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2739
2740         Reviewed by Oliver Hunt.
2741
2742         need to implement aria tree roles
2743         https://bugs.webkit.org/show_bug.cgi?id=31284
2744
2745         * DumpRenderTree/AccessibilityUIElement.cpp:
2746         (disclosedRowAtIndexCallback):
2747         (selectedRowAtIndexCallback):
2748         (isEqualCallback):
2749         (isAttributeSettableCallback):
2750         (isActionSupportedCallback):
2751         (disclosedByRowCallback):
2752         (hierarchicalLevelCallback):
2753         (AccessibilityUIElement::getJSClass):
2754         * DumpRenderTree/AccessibilityUIElement.h:
2755         (AccessibilityUIElement::isEqual):
2756         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2757         (AccessibilityUIElement::hierarchicalLevel):
2758         (AccessibilityUIElement::disclosedRowAtIndex):
2759         (AccessibilityUIElement::selectedRowAtIndex):
2760         (AccessibilityUIElement::disclosedByRow):
2761         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2762         (AccessibilityUIElement::getChildAtIndex):
2763         (AccessibilityUIElement::disclosedRowAtIndex):
2764         (AccessibilityUIElement::selectedRowAtIndex):
2765         (AccessibilityUIElement::titleUIElement):
2766         (AccessibilityUIElement::parentElement):
2767         (AccessibilityUIElement::disclosedByRow):
2768         (AccessibilityUIElement::hierarchicalLevel):
2769         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2770         (AccessibilityUIElement::hierarchicalLevel):
2771         (AccessibilityUIElement::disclosedRowAtIndex):
2772         (AccessibilityUIElement::selectedRowAtIndex):
2773         (AccessibilityUIElement::disclosedByRow):
2774
2775 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2776
2777         Reviewed by Darin Adler.
2778
2779         svn-apply can not handle git binary diffs
2780         https://bugs.webkit.org/show_bug.cgi?id=26830
2781
2782         Support "literal" type git binary diffs.
2783
2784         * Scripts/VCSUtils.pm:
2785         * Scripts/modules/scm_unittest.py:
2786         * Scripts/svn-apply:
2787
2788 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2789
2790         Not reviewed, removing duplicate entry for myself in committers.py.
2791
2792         * Scripts/modules/committers.py:
2793
2794 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2795
2796         Reviewed by Darin Adler and Mark Rowe.
2797
2798         https://bugs.webkit.org/show_bug.cgi?id=31200
2799         Tests in http/tests/security/mixedContent start to fail when new tests are added
2800
2801         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2802
2803 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2804
2805         Reviewed by Jan Alonzo.
2806
2807         Create, and display a window for the inspector, for inspector
2808         tests.
2809
2810         Need to also show/hide the inspector window to avoid having
2811         problems with code assuming it is realized
2812         https://bugs.webkit.org/show_bug.cgi?id=31347
2813
2814         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2815         (webInspectorShowWindow):
2816         (webInspectorCloseWindow):
2817         (webInspectorInspectWebView):
2818         (createWebView):
2819
2820 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2821
2822         Unreviewed Qt buildbot fix.
2823
2824         My previous fix was wrong, so revert that change and fix it by
2825         returning when the document of the frame has no document element.
2826         Idea is borrowed from mac and win DRT.
2827
2828         * DumpRenderTree/qt/DumpRenderTree.cpp:
2829         (WebCore::DumpRenderTree::dumpFramesAsText):
2830
2831 2009-11-11  Eric Seidel  <eric@webkit.org>
2832
2833         Reviewed byg Kenneth Rohde Christiansen.
2834
2835         Update Kenneth's committer record to include the email he
2836         uses on lists.webkit.org.
2837
2838         * Scripts/modules/committers.py:
2839
2840 2009-11-11  Eric Seidel  <eric@webkit.org>
2841
2842         Reviewed by Gustavo Noronha Silva.
2843
2844         Several committers use separate email addresses for bugzilla and svn.webkit.org
2845         https://bugs.webkit.org/show_bug.cgi?id=31364
2846
2847         Update records for existing committers to include email addresses
2848         used in svn.webkit.org and lists.webkit.org.
2849         Most committers use the same email address in all 3 places, but some use
2850         separate addresses.  committers.py needs record of each of these addresses.
2851
2852         * Scripts/modules/committers.py:
2853
2854 2009-11-11  Eric Seidel  <eric@webkit.org>
2855
2856         No review, adding second email address for an existing committer.
2857
2858         Add Yong Li's second bugzilla account to his committer record.
2859         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2860
2861         * Scripts/modules/committers.py:
2862
2863 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2864
2865         Reviewed by Simon Hausmann.
2866
2867         If the frame has no innerText don't append it, and
2868         do not add a newline which breaks some cross platform
2869         results.
2870
2871         * DumpRenderTree/qt/DumpRenderTree.cpp:
2872         (WebCore::DumpRenderTree::dumpFramesAsText):
2873
2874 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2875
2876         Reviewed by Simon Hausmann.
2877
2878         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2879
2880         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2881         (webkit_test_plugin_new_instance):
2882         (webkit_test_plugin_destroy_instance):
2883         (webkit_test_plugin_destroy_stream):
2884
2885 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2886
2887         Reviewed by Mark Rowe.
2888
2889         Implement the functionality needed by plugins/window-open.html
2890
2891         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2892         (webkit_test_plugin_new_instance):
2893         (webkit_test_plugin_set_window):
2894
2895 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2896
2897         Reviewed by Simon Hausmann.
2898
2899         [Qt] Force -graphicssystem raster and -style windows when running DRT
2900
2901         * DumpRenderTree/qt/main.cpp:
2902         * Scripts/run-webkit-tests:
2903
2904 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2905
2906         Reviewed by Simon Hausmann.
2907
2908         Compute correct library paths for Qt
2909
2910         * Scripts/webkitdirs.pm:
2911
2912 2009-11-10  Mark Rowe  <mrowe@apple.com>
2913
2914         Reviewed by Sam Weinig.
2915
2916         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2917
2918         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2919         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2920         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2921         that had enabled frame load delegate logging this would result in extra log messages being generated,
2922         causing the test to fail.
2923
2924         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2925         tests.
2926
2927         * DumpRenderTree/mac/DumpRenderTree.mm:
2928         (dumpRenderTree):
2929         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2930         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2931
2932 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2933
2934         Reviewed by Kenneth Rohde Christiansen.
2935
2936         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2937
2938         * DumpRenderTree/qt/DumpRenderTree.cpp:
2939         (WebCore::DumpRenderTree::DumpRenderTree):
2940
2941 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2942
2943         Reviewed by Jan Alonzo.
2944
2945         [GTK] Remove WebSocket configuration from WebKitWebSettings
2946         https://bugs.webkit.org/show_bug.cgi?id=31244
2947
2948         Follow-up of r50724. Don't set the enable-web-socket property
2949         anymore.
2950
2951         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2952         (resetDefaultsToConsistentValues):
2953
2954 2009-11-10  Oliver Hunt  <oliver@apple.com>
2955
2956         Reviewed by Maciej Stachowiak.
2957
2958         Rename 3D Canvas related classes to use WebGL prefix
2959         https://bugs.webkit.org/show_bug.cgi?id=29095
2960
2961         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2962         and upate webkitdirs script to new method of testing for WebGL.
2963
2964         * Scripts/do-webcore-rename:
2965         * Scripts/webkitdirs.pm:
2966
2967 2009-11-09  Oliver Hunt  <oliver@apple.com>
2968
2969         Reviewed by Geoff Garen.
2970
2971         Make do-webcore-rename work with git.
2972
2973         * Scripts/do-webcore-rename:
2974
2975 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2976
2977         Adding Kenneth to the reviewers list.
2978
2979         * Scripts/modules/committers.py:
2980
2981 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2982
2983         Reviewed by Jan Alonzo.
2984
2985         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2986         https://bugs.webkit.org/show_bug.cgi?id=30482
2987
2988         LayoutTestControllerGtk now uses the exposed
2989         Page::tabKeyCyclesThroughElements API
2990
2991         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2992         (LayoutTestController::setTabKeyCyclesThroughElements):
2993
2994 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2995
2996         Reviewed by Holger Freyther.
2997
2998         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2999         This helps to pass the test case below. Also replaced hardcoded
3000         code numbers with defined constants.
3001         https://bugs.webkit.org/show_bug.cgi?id=31185
3002         
3003         Test: editing/undo/undo-deleteWord.html
3004
3005         * DumpRenderTree/qt/EventSenderQt.cpp:
3006         (EventSender::keyDown):
3007
3008 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
3009
3010         Reviewed by Holger Freyther.
3011
3012         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
3013         https://bugs.webkit.org/show_bug.cgi?id=31164
3014
3015         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
3016
3017         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3018         (LayoutTestController::processWork):
3019
3020 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
3021
3022         Reviewed by Holger Freyther.
3023
3024         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
3025         https://bugs.webkit.org/show_bug.cgi?id=31158
3026
3027         By invoking a script queue'd by queueScript(), 'true' was beeing returned
3028         always, which from WorkQueue prospective means that a load has been started
3029         and the queue processing should stop and wait for the load to finish.
3030         Spinning it off into a loading and a non-loading variants was the solution
3031         adopted by Mac's DRT to work around this problem. The former keeps returning
3032         'true' while the later executes the script synchronously and returns 'false'
3033         making it possible to the WorkQueue to proceed right away.
3034
3035         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3036         (LayoutTestController::processWork):
3037         (LayoutTestController::queueLoadingScript):
3038         (LayoutTestController::queueNonLoadingScript):
3039         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3040         * DumpRenderTree/qt/WorkQueueItem.h:
3041         (LoadingScriptItem::LoadingScriptItem):
3042         (LoadingScriptItem::invoke):
3043         (NonLoadingScriptItem::NonLoadingScriptItem):
3044         (NonLoadingScriptItem::invoke):
3045
3046 2009-11-07  Mark Rowe  <mrowe@apple.com>
3047
3048         Rubber-stamped by Cameron Zwarich.
3049
3050         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
3051
3052         * Scripts/commit-log-editor:
3053
3054 2009-11-07  Mark Rowe  <mrowe@apple.com>
3055
3056         Reviewed by Darin Adler.
3057
3058         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
3059         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
3060
3061         Move logic for determining the name and email address to use in a ChangeLog entry from
3062         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
3063         whether the author of the patch matches committer, and therefore needs access to the
3064         email address that would be used in a ChangeLog entry.
3065
3066         Based on a patch by Pierre d'Herbemont.
3067
3068         * Scripts/VCSUtils.pm:
3069         * Scripts/commit-log-editor:
3070         * Scripts/prepare-ChangeLog:
3071         * Scripts/webkitdirs.pm:
3072
3073 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3074
3075         Reviewed by Adam Barth.
3076
3077         Added functionality to the layout test plugin to invoke document.open and
3078         window.open with default arguments. The associated webkit bug is
3079         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
3080         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
3081         work in Chromium (V8) if there is no calling javascript context. To achieve this
3082         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
3083         for the window.open test case and in NPP_DestroyStream for the document.open test case.
3084
3085         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3086         (testDocumentOpen):
3087         (testWindowOpen):
3088         (pluginAllocate):
3089         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3090         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3091         (NPP_New):
3092         (NPP_SetWindow):
3093         (NPP_DestroyStream):
3094         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3095         (NPP_New):
3096         (NPP_SetWindow):
3097         (NPP_NewStream):
3098         (NPP_DestroyStream):
3099
3100 2009-11-06  Eric Seidel  <eric@webkit.org>
3101
3102         Reviewed by Adam Barth.
3103
3104         bugzilla-tool crashed with exception
3105         https://bugs.webkit.org/show_bug.cgi?id=31092
3106
3107         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
3108
3109 2009-11-04  Eric Seidel  <eric@webkit.org>
3110
3111         No review, just add a line which got left out of the patch uploaded for commit.
3112
3113         commit-queue is crashing when trying to reject patches after unknown failures
3114         https://bugs.webkit.org/show_bug.cgi?id=31091
3115
3116         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
3117
3118 2009-11-04  Adam Roben  <aroben@apple.com>
3119
3120         Remove bogus else clause in bugzilla-tool
3121
3122         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
3123         create-bug raises exception after entering bug description
3124
3125         Reviewed by David Kilzer.
3126
3127         * Scripts/bugzilla-tool:
3128         (CreateBug): else clauses are only hit if no exception is raised, so
3129         it makes no sense to try to re-raise the exception in an else clause.
3130         The exception will automatically be re-raised if it doesn't match any
3131         of the except clauses, so we don't have to do anything special here at
3132         all to get the desired behavior.
3133
3134 2009-11-04  Eric Seidel  <eric@webkit.org>
3135
3136         Reviewed by David Kilzer.
3137
3138         svn-apply's fixChangeLogPatch function seems broken
3139         https://bugs.webkit.org/show_bug.cgi?id=30683
3140
3141         Update fixChangeLogPatch to be able to handle patches which
3142         don't start at line 1.
3143         Add unit tests for svn-apply to scm_unittest.py.
3144
3145         * Scripts/VCSUtils.pm:
3146         * Scripts/modules/scm_unittest.py:
3147
3148 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3149
3150         Reviewed by Beth Dakin.
3151
3152         Need to implement ARIA role="combobox"
3153         https://bugs.webkit.org/show_bug.cgi?id=31096
3154
3155         * DumpRenderTree/AccessibilityUIElement.cpp:
3156         (showMenuCallback):
3157         (getIsExpandedCallback):
3158         (AccessibilityUIElement::getJSClass):
3159         * DumpRenderTree/AccessibilityUIElement.h:
3160         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3161         (AccessibilityUIElement::isExpanded):
3162         (AccessibilityUIElement::showMenu):
3163         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3164         (AccessibilityUIElement::isExpanded):
3165         (AccessibilityUIElement::showMenu):
3166         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3167         (AccessibilityUIElement::isSelected):
3168         (AccessibilityUIElement::isExpanded):
3169         (AccessibilityUIElement::showMenu):
3170
3171 2009-11-04  Eric Seidel  <eric@webkit.org>
3172
3173         Reviewed by Adam Barth.
3174
3175         commit-queue is crashing when trying to reject patches after unknown failures
3176         https://bugs.webkit.org/show_bug.cgi?id=31091
3177
3178         * Scripts/bugzilla-tool:
3179          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
3180            so we have to find out what the current patch is by asking bugzilla again.
3181          - Discovered that this code was also leaking file descriptors, so fixed that.
3182
3183 2009-11-04  Adam Roben  <aroben@apple.com>
3184
3185         Make run-webkit-tests work for the Debug_Internal Windows
3186         configuration
3187
3188         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
3189         suffix.
3190
3191         Fixes <http://webkit.org/b/31123>.
3192
3193         Reviewed by Sam Weinig.
3194
3195         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3196         Debug_Internal, either.
3197
3198 2009-11-04  Eric Seidel  <eric@webkit.org>
3199
3200         Reviewed by Adam Barth.
3201
3202         committers.py needs a way to store non-bugzilla email addresses
3203         https://bugs.webkit.org/show_bug.cgi?id=31037
3204
3205         Make Committer and Reviewer constructors take a single email or a list of emails.
3206         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3207         Expose reviewers(), used by validate-committer-lists on bug 30970.
3208
3209         * Scripts/modules/committers.py:
3210         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3211
3212 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3213
3214         Reviewed by David Levin.
3215
3216         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3217         https://bugs.webkit.org/show_bug.cgi?id=27491
3218
3219         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3220         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3221
3222         Functions to start or stop Web Socket servers are added.
3223
3224         * Scripts/run-webkit-tests:
3225
3226 2009-11-03  Eric Seidel  <eric@webkit.org>
3227
3228         No review, just changing wording of log message.
3229
3230         Change log string to say "failed" instead of "rejected"
3231         when a commit fails due to an out of date checkout.
3232         This makes grepping the commit-queue log for rejected patches easier.
3233
3234         * Scripts/bugzilla-tool:
3235
3236 2009-11-03  Eric Seidel  <eric@webkit.org>
3237
3238         No review, adding commonly known committers missing from the file.
3239
3240         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3241
3242 2009-11-03  Eric Seidel  <eric@webkit.org>
3243
3244         No review, just sort-order cleanup.
3245
3246         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3247
3248 2009-11-03  Stephen White  <senorblanco@chromium.org>
3249
3250         (Unreviewed).
3251
3252         Add myself to committers.py.
3253
3254         * Scripts/modules/committers.py:
3255
3256 2009-11-03  Robin Dunn  <robin@alldunn.com>
3257
3258         Reviewed by Kevin Ollviier.
3259
3260         Add packaging scripts for Debian-based Linux distros.
3261         
3262         https://bugs.webkit.org/show_bug.cgi?id=31075
3263
3264         * wx/packaging/build-debian-installer.py: Added.
3265         * wx/packaging/debian: Added.
3266
3267 2009-11-03  Dan Bernstein  <mitz@apple.com>
3268
3269         Reviewed by Anders Carlsson and Beth Dakin.
3270
3271         https://bugs.webkit.org/show_bug.cgi?id=31070
3272
3273         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
3274         destroyed, it executes the value of the 'ondestroy' parameter as a
3275         script.
3276
3277         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3278         (pluginAllocate): Initialize onDestroy.
3279         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
3280         onDestroy.
3281         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3282         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
3283         specified.
3284         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
3285
3286 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3287
3288         Reviewed by Xan Lopez.
3289
3290         https://bugs.webkit.org/show_bug.cgi?id=31035
3291         [GTK] some accessibility tests hitting assertion in debug builds
3292
3293         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
3294
3295         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3296         (AccessibilityController::rootElement):
3297
3298 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3299
3300         Reviewed by Beth Dakin.
3301
3302         Support ARIA "tab" roles
3303         https://bugs.webkit.org/show_bug.cgi?id=30842
3304
3305         * DumpRenderTree/AccessibilityUIElement.cpp:
3306         * DumpRenderTree/AccessibilityUIElement.h:
3307         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3308         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3309         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3310
3311 2009-11-01  Eric Seidel  <eric@webkit.org>
3312
3313         Reviewed by David Levin.
3314
3315         buildbots should use --exit-after-N-failures
3316         https://bugs.webkit.org/show_bug.cgi?id=30809
3317
3318         Make the bots exit after 20 failures to prevent never-ending
3319         test runs where every test spends a minute crashing.
3320
3321         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3322
3323 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3324
3325         Reviewed by Eric Seidel.
3326
3327         Turn on warnings for QtWebKit for gcc
3328         https://bugs.webkit.org/show_bug.cgi?id=30958
3329
3330         * DumpRenderTree/qt/main.cpp: 
3331         (crashHandler): Mark function NO_RETURN
3332
3333 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
3334
3335         Adding myself to the committers list.
3336
3337         * Scripts/modules/committers.py:
3338
3339 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
3340
3341         Fix an issue that Adam noticed in DRT.
3342
3343         Reviewed by Darin Adler.
3344
3345         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3346         (AccessibilityUIElement::role):
3347         Get the length of the role text, and create a buffer dynamically.
3348
3349 2009-10-30  Eric Seidel  <eric@webkit.org>
3350
3351         No review, rolling out r50105.
3352         http://trac.webkit.org/changeset/50105
3353
3354         This commit was causing:
3355         https://bugs.webkit.org/show_bug.cgi?id=30869
3356         We'll re-implement the feature a different way.
3357
3358         * Scripts/bugzilla-tool:
3359
3360 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3361
3362         Test for MSAA: Accessibility of headings is not correct
3363
3364         https://bugs.webkit.org/show_bug.cgi?id=30937
3365
3366         Reviewed by Adam Roben.
3367
3368         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3369         (AccessibilityUIElement::role):
3370         Allow the role returned to be a BSTR.
3371         (AccessibilityUIElement::description):
3372         Fix a copy/paste error.
3373
3374 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3375
3376         Test for MSAA: Accessibility of links is wrong
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=30928
3379
3380         Reviewed by Darin Adler.
3381
3382         * DumpRenderTree/AccessibilityUIElement.cpp:
3383         (getAccessibilityValueCallback):
3384         Return the accessibility value.
3385         (AccessibilityUIElement::getJSClass):
3386         Added "accessibilityValue" value.
3387
3388         * DumpRenderTree/AccessibilityUIElement.h:
3389
3390         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3391         (AccessibilityUIElement::accessibilityValue):
3392         Stubbed.
3393
3394         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3395         (AccessibilityUIElement::accessibilityValue):
3396         Stubbed.
3397
3398         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3399         (AccessibilityUIElement::accessibilityValue):
3400         Get the object's value, and return it as a JS string.
3401
3402 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
3403
3404         Fix typo in command name used by wx build system.
3405
3406         * wx/build/build_utils.py:
3407
3408 2009-10-30  Adam Barth  <abarth@webkit.org>
3409
3410         Reviewed by Darin Adler.
3411
3412         Patch v1 is a dumb default name for patches
3413         https://bugs.webkit.org/show_bug.cgi?id=30952
3414
3415         Let's use "Patch" instead.
3416
3417         * Scripts/bugzilla-tool:
3418
3419 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3420
3421         Unreviewed trivial buildfix.
3422
3423         [Qt] Buildfix for r50333.
3424
3425         * DumpRenderTree/qt/DumpRenderTree.pro:
3426
3427 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
3428
3429         Reviewed by Holger Freyther.
3430
3431         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
3432         https://bugs.webkit.org/show_bug.cgi?id=30953
3433
3434         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
3435         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
3436         makes qt DRT to share this implementation (as gtk and mac ports do).
3437
3438         * DumpRenderTree/qt/DumpRenderTree.pro:
3439         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
3440         * DumpRenderTree/qt/WorkQueue.h: Removed.
3441
3442 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3443
3444         Unreviewed potential buildbot fix.
3445
3446         Second try: Reset page history before running each test.
3447
3448         Apparently the QWebHistory::clear() keeps the current page
3449         in history which is not what we want, so we not additionally
3450         sets the history capacity to 0 (forces removing everything)
3451         and then sets it back to its original value.
3452
3453         * DumpRenderTree/qt/DumpRenderTree.cpp:
3454         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3455
3456 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3457
3458         Unreviewed potential buildbot fix.
3459
3460         Reset page history before running each test.
3461
3462         * DumpRenderTree/qt/DumpRenderTree.cpp:
3463         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3464
3465 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
3466
3467         Reviewed by Eric Seidel.
3468
3469         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
3470
3471         Bug 28420 -  Implement HTML5 <ruby> rendering
3472         (https://bugs.webkit.org/show_bug.cgi?id=28420)
3473
3474         No new tests (no functional change).
3475
3476         * Scripts/build-webkit:
3477
3478 2009-10-29  Dan Bernstein  <mitz@apple.com>
3479
3480         Reviewed by Mark Rowe.
3481
3482         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
3483         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
3484         define it.
3485
3486         * Scripts/VCSUtils.pm:
3487         * Scripts/svn-apply:
3488         * Scripts/svn-unapply:
3489
3490 2009-10-29  Xan Lopez  <xlopez@igalia.com>
3491
3492         Reviewed by Gustavo Noronha.
3493
3494         Use the GTK+ main loop instead of rolling our own mini-version of
3495         it.
3496
3497         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3498         (dump):
3499         (runTest):
3500         (webViewLoadFinished):
3501
3502 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3503
3504         Reviewed by Oliver Hunt.
3505
3506         Implement the Qt version of DRT dumpBackForwardList().
3507
3508         * DumpRenderTree/qt/DumpRenderTree.cpp:
3509         (WebCore::dumpHistoryItem):
3510         (WebCore::DumpRenderTree::dumpBackForwardList):
3511
3512 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3513
3514         Reviewed by Adam Roben.
3515
3516         Implement DRT functionality for Qt introduced in
3517         r28690 and r28705.
3518
3519         - Implemented pathToLocalResource which exposes the functionality of
3520         converting a given unix path to the correct location on Windows.
3521         - Implemented a way to remove machine-dependent information from paths
3522         in layout test results.
3523
3524         * DumpRenderTree/qt/DumpRenderTree.cpp:
3525         (WebCore::urlSuitableForTestResult):
3526         (WebCore::WebPage::javaScriptConsoleMessage):
3527         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3528         (LayoutTestController::pathToLocalResource):
3529         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3530
3531 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
3532
3533         Adding myself to the committers list.
3534
3535         * Scripts/modules/committers.py:
3536
3537 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
3538
3539         Adding myself to the committers list.
3540
3541         * Scripts/modules/committers.py:
3542
3543 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3544
3545         Reviewed by Jan Alonzo.
3546
3547         [GTK] API to start inspector for a WebView
3548         https://bugs.webkit.org/show_bug.cgi?id=22551
3549
3550         Use the new inspector API to implement the LayoutTestController
3551         interfaces used to test the inspector.
3552
3553         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3554         (webInspectorInspectWebView):
3555         (createWebView):
3556         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3557         (LayoutTestController::showWebInspector):
3558         (LayoutTestController::closeWebInspector):
3559         (LayoutTestController::evaluateInWebInspector):
3560
3561 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
3562
3563         Reviewed by Eric Seidel.
3564
3565         [Qt] WebFrame::counterValueForElementById must not be exposed
3566         https://bugs.webkit.org/show_bug.cgi?id=30882
3567
3568         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3569         (LayoutTestController::counterValueForElementById):
3570
3571 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3572
3573         Rubberstamped by Oliver Hunt.
3574
3575         Fix the warning:
3576
3577         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
3578         declared with attribute warn_unused_result".
3579
3580         by actually checking the result. In the case it is null, an
3581         error has occoured, so treat it as the other fatal errors.
3582
3583         * DumpRenderTree/qt/DumpRenderTree.cpp:
3584         (WebCore::DumpRenderTree::initializeFonts):
3585
3586 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
3587
3588         Reviewed by Darin Adler.
3589
3590         Provide a way to get counter values with layoutTestContoller
3591         https://bugs.webkit.org/show_bug.cgi?id=30555
3592
3593         Define layoutTestContoller.counterValueForElementById.
3594
3595         * DumpRenderTree/LayoutTestController.cpp:
3596         (counterValueForElementByIdCallback):
3597         (LayoutTestController::staticFunctions):
3598         * DumpRenderTree/LayoutTestController.h:
3599         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3600         (LayoutTestController::counterValueForElementById):
3601
3602 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3603
3604         Rubberstamped by Oliver Hunt.
3605
3606         Change two methods to be internal for DRT use only.
3607
3608         Part of [Qt] Review all new API in Qt 4.6
3609         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
3610
3611         * DumpRenderTree/qt/DumpRenderTree.cpp:
3612         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3613         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3614         (LayoutTestController::whiteListAccessFromOrigin):
3615
3616 2009-10-27  Eric Seidel  <eric@webkit.org>
3617
3618         Reviewed by Adam Barth.
3619
3620         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3621         https://bugs.webkit.org/show_bug.cgi?id=30826
3622
3623         * Scripts/svn-apply:
3624          - Add () around all system() calls.
3625          - Use the correct system() == 0 or die instead of system() or die
3626          - Add descriptive messages to all die statements.
3627
3628 2009-10-27  Steve Block  <steveblock@google.com>
3629
3630         Reviewed by NOBODY.
3631
3632         Adds steveblock@google.com to list of committers.
3633
3634         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3635
3636 2009-10-27  Eric Seidel  <eric@webkit.org>
3637
3638         Reviewed by Adam Barth.
3639
3640         svn-apply can exit(0) even on patch failure
3641         https://bugs.webkit.org/show_bug.cgi?id=29622
3642
3643         * Scripts/svn-apply:
3644          - Add a bunch of "or die" statements, hopefully catching all
3645            possible cases where failure could still exit(0).
3646
3647 2009-10-27  Eric Seidel  <eric@webkit.org>
3648
3649         Reviewed by Adam Barth.
3650
3651         svn-* scripts should share code through VCSUtils.pm
3652         https://bugs.webkit.org/show_bug.cgi?id=30791
3653
3654         Just moving code into a shared location.
3655
3656         * Scripts/VCSUtils.pm:
3657         * Scripts/prepare-ChangeLog:
3658         * Scripts/resolve-ChangeLogs:
3659         * Scripts/svn-apply:
3660         * Scripts/svn-create-patch:
3661         * Scripts/svn-unapply:
3662         * Scripts/update-webkit:
3663
3664 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3665
3666         Suppress a huge number of MSVC warnings when building wxWebKit.
3667
3668         * wx/build/settings.py:
3669
3670 2009-10-26  Eric Seidel  <eric@webkit.org>
3671
3672         No review, just adding Mike Belshe to the committers list.
3673
3674         * Scripts/modules/committers.py:
3675
3676 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3677
3678         Reviewed by Darin Adler.
3679
3680         Make .rc files compile on Windows without depending on MFC headers
3681         https://bugs.webkit.org/show_bug.cgi?id=30750
3682
3683         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3684         windows.h instead of afxres.h because it exists even when MFC is not 
3685         installed, and is all that's needed here.
3686
3687         * FindSafari/FindSafari.rc: Ditto
3688
3689 2009-10-24  Eric Seidel  <eric@webkit.org>
3690
3691         Reviewed by Adam Barth.
3692
3693         bugzilla-tool post-diff should know how to mark commit-queue=?
3694         https://bugs.webkit.org/show_bug.cgi?id=29202
3695
3696         * Scripts/bugzilla-tool:
3697          - Add --commit-queue option to post-diff, post-commits and create-bug.
3698         * Scripts/modules/bugzilla.py:
3699          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3700          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3701
3702 2009-10-23  Eric Seidel  <eric@webkit.org>
3703
3704         Reviewed by Adam Barth.
3705
3706         bugzilla-tool commit-queue does not notice modifications to committers.py
3707         https://bugs.webkit.org/show_bug.cgi?id=30084
3708
3709         * Scripts/bugzilla-tool:
3710          - Make commit-queue re-exec itself instead of using while(1).
3711          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3712          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3713
3714 2009-10-22  Eric Seidel  <eric@webkit.org>
3715
3716         Reviewed by Adam Barth.
3717
3718         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3719         https://bugs.webkit.org/show_bug.cgi?id=30634
3720
3721         * Scripts/bugzilla-tool:
3722          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3723          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3724
3725 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3726
3727         Reviewed by Eric Seidel.
3728
3729         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3730
3731         https://bugs.webkit.org/show_bug.cgi?id=30763
3732
3733         * pywebsocket/mod_pywebsocket/__init__.py:
3734         * pywebsocket/mod_pywebsocket/dispatch.py:
3735         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3736         * pywebsocket/mod_pywebsocket/standalone.py:
3737         * pywebsocket/setup.py:
3738         * pywebsocket/test/test_dispatch.py:
3739
3740 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3741
3742         Reviewed by David Levin.
3743
3744         REGRESSION: 2 failures in run-webkit-unittests
3745         https://bugs.webkit.org/show_bug.cgi?id=30645
3746
3747         * Scripts/modules/cpp_style_unittest.py:
3748         Fixed a few test scenarios which apparently lost some spaces from 
3749         text literals.
3750
3751 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3752
3753         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3754
3755         * Scripts/webkitdirs.pm:
3756
3757 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3758
3759         Reviewed by Darin Adler.
3760
3761         Unification of using null device in perl scripts.
3762         https://bugs.webkit.org/show_bug.cgi?id=30572
3763
3764         * Scripts/VCSUtils.pm:
3765         * Scripts/bisect-builds:
3766         * Scripts/resolve-ChangeLogs:
3767         * Scripts/run-iexploder-tests:
3768         * Scripts/run-jsc:
3769         * Scripts/run-mangleme-tests:
3770         * Scripts/run-webkit-tests:
3771         * Scripts/webkitdirs.pm:
3772         Using File::Spec->devnull() instead of hard coded /dev/null.
3773
3774 2009-10-26  Eric Seidel  <eric@webkit.org>
3775
3776         Reviewed by Holger Freyther.
3777
3778         Reviewers are missing from committers.py
3779         https://bugs.webkit.org/show_bug.cgi?id=30733
3780
3781         * Scripts/modules/committers.py:
3782
3783 2009-10-23  Eric Seidel  <eric@webkit.org>
3784
3785         No review, only adding Alice to the list of reviewers.
3786
3787         * Scripts/modules/committers.py:
3788
3789 2009-10-23  Eric Seidel  <eric@webkit.org>
3790
3791         Reviewed by Eric Carlson.
3792
3793         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3794         https://bugs.webkit.org/show_bug.cgi?id=30700
3795
3796         * DumpRenderTree/mac/DumpRenderTree.mm:
3797         (resetDefaultsToConsistentValues): Update QuickTime version check.
3798
3799 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3800
3801         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3802         character measurement APIs that are private on Tiger.
3803
3804         * wx/build/settings.py:
3805
3806 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3807
3808         Reviewed by NOBODY (build fix).
3809         Build fix following bug #30696.
3810
3811         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3812         (LayoutTestController::evaluateScriptInIsolatedWorld):
3813
3814 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3815
3816         Reviewed by Sam Weinig & Geoff Garen.
3817
3818         https://bugs.webkit.org/show_bug.cgi?id=30696
3819         Enable isolated-worlds tests on mac.
3820
3821         Add private interface for DRT to invoke execution in a given world.
3822
3823         * DumpRenderTree/LayoutTestController.cpp:
3824         (evaluateScriptInIsolatedWorldCallback):
3825         (LayoutTestController::staticFunctions):
3826         * DumpRenderTree/LayoutTestController.h:
3827         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3828         (LayoutTestController::evaluateScriptInIsolatedWorld):
3829         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3830         (LayoutTestController::evaluateScriptInIsolatedWorld):
3831
3832 2009-10-21  Eric Seidel  <eric@webkit.org>
3833
3834         Reviewed by Adam Barth.
3835
3836         bugzilla-tool's "patch failed to download an apply" error should give more information
3837         https://bugs.webkit.org/show_bug.cgi?id=30632
3838
3839         * Scripts/modules/scm.py:
3840          - Use the common run_command method instead of custom POpen code.
3841          - Make run_command know how to take pipes as input.
3842         * Scripts/modules/scm_unittest.py:
3843          - Add new tests to cover change.
3844          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3845
3846 2009-10-21  Kent Tamura  <tkent@chromium.org>
3847
3848         Unreviewed.  Adding myself to the committers list.
3849
3850         * Scripts/modules/committers.py:
3851
3852 2009-10-21  Robin Dunn  <robin@alldunn.com>
3853
3854         Reviewed by Kevin Ollivier.
3855
3856         Update the Windows installer builder to work with Vista / Win 7 and with git.
3857         
3858         https://bugs.webkit.org/show_bug.cgi?id=30649
3859
3860         * wx/build/build_utils.py:
3861         * wx/packaging/build-mac-installer.py:
3862         * wx/packaging/build-win-installer.py:
3863         * wx/packaging/wxWebKitInstaller.iss.in:
3864
3865 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3866
3867         Reviewed by Gustavo Noronha.
3868
3869         [GTK] Added conditional code to avoid using
3870         gdk_window_get_root_coords if we do not have a gtk+ release newer
3871         than 2.17.3.
3872         https://bugs.webkit.org/show_bug.cgi?id=30636
3873
3874         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3875
3876 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3877
3878         Reviewed by Eric Seidel.
3879
3880         [Qt] Added dummy implementation for keepWebHistory()
3881         https://bugs.webkit.org/show_bug.cgi?id=30592
3882
3883         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3884         (LayoutTestController::keepWebHistory):
3885         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3886
3887 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3888
3889         Reviewed by Xan Lopez.
3890
3891         [GTK] Fixed the double click condition, it is not double click if
3892         we move in just in one direction.
3893         https://bugs.webkit.org/show_bug.cgi?id=30636
3894
3895         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3896
3897 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3898
3899         Reviewed by Xan Lopez.
3900
3901         [GTK] Initialize the events completly before emitting them.
3902         https://bugs.webkit.org/show_bug.cgi?id=30633
3903
3904         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3905
3906 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3907
3908         wx build fix. Fix for when linking using --as-needed with gcc.
3909
3910         * wx/browser/wscript:
3911
3912 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3913
3914         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3915         to support all the features used by CURL backend.
3916         
3917         * wx/build/settings.py:
3918         * wx/install-unix-extras:
3919
3920 2009-10-20  Anton Muhin  <antonm@chromium.org>
3921
3922         Reviewed by Adam Barth.
3923
3924         Add {ager,antonm,yurys}@chromium.org into committers.py
3925         https://bugs.webkit.org/show_bug.cgi?id=30560
3926
3927         * Scripts/modules/committers.py:
3928
3929 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3930
3931         Reviewed by Tor Arne Vestbø.
3932
3933         Make the Netscape Test plugin available to the Qt launcher.
3934
3935         * Scripts/run-launcher:
3936
3937 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3938
3939         Reviewed by David Levin.
3940
3941         Removed WebSocket runtime settings.
3942         https://bugs.webkit.org/show_bug.cgi?id=29896
3943
3944         WebSocket runtime configuration is supported by chromium/v8 only.
3945
3946         * DumpRenderTree/mac/DumpRenderTree.mm:
3947         (resetDefaultsToConsistentValues):
3948         * DumpRenderTree/win/DumpRenderTree.cpp:
3949         (resetDefaultsToConsistentValues):
3950
3951 2009-10-19  Nate Chapin  <japhet@chromium.org>
3952
3953         Reviewed by Adam Barth.
3954
3955         Add testFail() to test plugin so we can test our handling of a
3956         plugin invoke call returning false.
3957
3958         https://bugs.webkit.org/show_bug.cgi?id=30239
3959
3960         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3961         (pluginInvoke):
3962         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3963
3964 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3965
3966         Reviewed by Gustavo Noronha.
3967
3968         Enable DOM pasting when running layout tests.
3969
3970         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3971         (resetDefaultsToConsistentValues):
3972
3973 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3974
3975         Reviewed by Simon Hausmann.
3976
3977         Use the setPreferredContentsSize method instead
3978         of setFixedContentsSize, as the method has been renamed.
3979
3980         * DumpRenderTree/qt/DumpRenderTree.cpp:
3981         (WebCore::DumpRenderTree::open):
3982         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3983         (LayoutTestController::setFixedContentsSize):
3984
3985 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3986
3987         Reviewed by Dan Bernstein.
3988
3989         https://bugs.webkit.org/show_bug.cgi?id=30456
3990         Fixes for new Debug_All Windows build configuration.
3991
3992         * DumpRenderTree/win/DumpRenderTree.cpp:
3993         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3994         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3995
3996 2009-10-16  Eric Seidel  <eric@webkit.org>
3997
3998         Reviewed by Adam Barth.
3999
4000         commit-queue status bot should list which buildbot is blocking the queue
4001         https://bugs.webkit.org/show_bug.cgi?id=30452
4002
4003         Add new methods and testing.
4004
4005         * Scripts/bugzilla-tool:
4006         * Scripts/modules/buildbot.py:
4007         * Scripts/modules/buildbot_unittest.py:
4008
4009 2009-10-16  Eric Seidel  <eric@webkit.org>
4010
4011         Reviewed by Adam Barth.
4012
4013         run-webkit-tests fails when CWD is not inside a WebKit checkout
4014         https://bugs.webkit.org/show_bug.cgi?id=30451
4015
4016         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
4017         * Scripts/modules/scm_unittest.py:
4018           - Remove use of original_path (we don't need to restore the CWD).
4019           - Don't use '.' to find the webkit checkout, use __file__ instead.
4020
4021 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
4022
4023         Reviewed by Adam Roben.
4024
4025         Add a Debug_All configuration to build entire stack as debug.
4026         Change Debug_Internal to:
4027         - stop using _debug suffix for all WebKit/Safari binaries
4028         - not use _debug as a DLL naming suffix
4029         - use non-debug C runtime lib.
4030
4031         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
4032         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
4033         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
4034         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4035         Add missing debug.vsprops inherited property sheet.
4036         Add Debug_All configuration.
4037         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
4038         * WinLauncher/WinLauncher.vcproj:
4039         Removed extraneous definitions inherited from vsprops.
4040         Add Debug_All configuration.
4041
4042 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
4043
4044         Reviewed by David Levin.
4045
4046         check-webkit-style is wrong about indent checking in namespaces
4047         in header files and a few other things
4048         https://bugs.webkit.org/show_bug.cgi?id=30362
4049
4050         The few other things include:
4051         + check-webkit-style does not require spaces around the equal sign
4052           inside 'if' statements and around binary operators that take 
4053           numeric literals.
4054         + check-webkit-style reports false errors for the / operator
4055           when part of a filename in the #include directive.
4056
4057         * Scripts/modules/cpp_style.py:
4058         Improved indentation checking and space checking around
4059         binary operators. While the checks are still not perfect,
4060         they are clearly better than before.
4061         * Scripts/modules/cpp_style_unittest.py:
4062         Added test cases for the newly supported checks and modified old
4063         test cases to match the new guidelines
4064
4065 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
4066
4067         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
4068
4069         * wx/build/settings.py:
4070
4071 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
4072
4073         Reviewed by David Levin.
4074
4075         Add mod_pywebsocket to test Web Sockets.
4076         http://code.google.com/p/pywebsocket/
4077         https://bugs.webkit.org/show_bug.cgi?id=27490
4078
4079         * pywebsocket/COPYING: Added.
4080         * pywebsocket/MANIFEST.in: Added.
4081         * pywebsocket/README: Added.
4082         * pywebsocket/example/echo_client.py: Added.
4083         * pywebsocket/example/echo_wsh.py: Added.
4084         * pywebsocket/mod_pywebsocket/__init__.py: Added.
4085         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
4086         * pywebsocket/mod_pywebsocket/handshake.py: Added.
4087         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
4088         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
4089         * pywebsocket/mod_pywebsocket/standalone.py: Added.
4090         * pywebsocket/mod_pywebsocket/util.py: Added.
4091         * pywebsocket/setup.py: Added.
4092         * pywebsocket/test/config.py: Added.
4093         * pywebsocket/test/mock.py: Added.
4094         * pywebsocket/test/run_all.py: Added.
4095         * pywebsocket/test/test_dispatch.py: Added.
4096         * pywebsocket/test/test_handshake.py: Added.
4097         * pywebsocket/test/test_mock.py: Added.
4098         * pywebsocket/test/test_msgutil.py: Added.
4099         * pywebsocket/test/test_util.py: Added.
4100         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
4101         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
4102         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
4103         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
4104         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
4105         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
4106         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
4107         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
4108
4109 2009-10-15  James Robinson  <jamesr@google.com>
4110
4111         Reviewed by David Levin.
4112
4113         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
4114
4115         https://bugs.webkit.org/show_bug.cgi?id=30426
4116
4117         * Scripts/modules/cpp_style.py:
4118         * Scripts/modules/cpp_style_unittest.py:
4119
4120 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
4121
4122         Reviewed by Adam Roben.
4123
4124         Fixes <http://webkit.org/b/30411>.
4125         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
4126         
4127         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
4128         building Chromium.
4129
4130         * Scripts/pdevenv:
4131
4132 2009-10-15  Robin Dunn  <robin@alldunn.com>
4133
4134         Reviewed by Kevin Ollivier.
4135
4136         Add Mac package building scripts for wx.
4137         
4138         https://bugs.webkit.org/show_bug.cgi?id=30405
4139
4140         * wx/build/build_utils.py:
4141         * wx/build/settings.py:
4142         * wx/packaging/build-mac-installer.py: Added.
4143
4144 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
4145
4146         Reviewed by Gustavo Noronha.
4147
4148         Enable Web Sockets support when running layout tests.
4149
4150         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4151         (resetDefaultsToConsistentValues):
4152
4153 2009-10-15  Xan Lopez  <xlopez@igalia.com>
4154
4155         Reviewed by Gustavo Noronha.
4156
4157         Need to initialize event.button.button, since in most cases a
4158         button number is not passed as an argument.
4159
4160         * DumpRenderTree/gtk/EventSender.cpp:
4161         (mouseDownCallback):
4162         (mouseUpCallback):
4163
4164 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
4165
4166         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
4167         the OS if none was explicitly set.
4168
4169         * wx/build/settings.py:
4170
4171 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
4172
4173         Reviewed by Timothy Hatcher.
4174
4175         Web Inspector: enable developers extras within inspector layout tests.
4176
4177         https://bugs.webkit.org/show_bug.cgi?id=30014
4178
4179         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4180         (LayoutTestController::showWebInspector):
4181         (LayoutTestController::closeWebInspector):
4182         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4183         (LayoutTestController::showWebInspector):
4184         (LayoutTestController::closeWebInspector):
4185
4186 2009-10-14  José Millán Soto  <jmillan@igalia.com>
4187
4188         Reviewed by Jan Alonzo.
4189
4190         GtkLauncher is using a deprecated signal
4191         https://bugs.webkit.org/show_bug.cgi?id=30364
4192
4193         Modified GtkLauncher to use notify::title signal instead of
4194         deprecated title-changed signal
4195
4196         * GtkLauncher/main.c:
4197         (notify_title_cb):
4198         (create_browser):
4199
4200 2009-10-14  Brady Eidson  <beidson@apple.com>
4201
4202         Reviewed by Sam Weinig.
4203
4204         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
4205         1 - Disables WebHistory
4206         2 - Doesn't make sense in that context anyway.
4207
4208         * DumpRenderTree/win/DumpRenderTree.cpp:
4209         (createWebViewAndOffscreenWindow):
4210
4211 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
4212
4213         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
4214         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
4215
4216         * wx/build/settings.py:
4217         * wx/install-unix-extras:
4218
4219 2009-10-14  Brady Eidson  <beidson@apple.com>
4220
4221         Reviewed by Sam Weinig.
4222
4223         WebKit Win API should provide a delegate interface for global history.
4224         https://bugs.webkit.org/show_bug.cgi?id=29905
4225
4226         * DumpRenderTree/LayoutTestController.cpp:
4227         (LayoutTestController::LayoutTestController):
4228         * DumpRenderTree/LayoutTestController.h:
4229         (LayoutTestController::dumpHistoryDelegateCallbacks):
4230         (LayoutTestController::setDumpHistoryDelegateCallbacks):
4231                 
4232         * DumpRenderTree/win/DumpRenderTree.cpp:
4233         (shouldLogHistoryDelegates):
4234         (runTest):
4235         (createWebViewAndOffscreenWindow):
4236         (main):
4237         * DumpRenderTree/win/DumpRenderTree.vcproj:
4238         
4239         Add the IWebHistoryDelegate to DRT Windows:
4240         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
4241         (wstringFromBSTR):
4242         (HistoryDelegate::HistoryDelegate):
4243         (HistoryDelegate::~HistoryDelegate):
4244         (HistoryDelegate::QueryInterface):
4245         (HistoryDelegate::AddRef):
4246         (HistoryDelegate::Release):
4247         (HistoryDelegate::didNavigateWithNavigationData):
4248         (HistoryDelegate::didPerformClientRedirectFromURL):
4249         (HistoryDelegate::didPerformServerRedirectFromURL):
4250         (HistoryDelegate::updateHistoryTitle):
4251         (HistoryDelegate::populateVisitedLinksForWebView):
4252         * DumpRenderTree/win/HistoryDelegate.h: Added.
4253
4254         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4255         (LayoutTestController::removeAllVisitedLinks):
4256
4257 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
4258
4259         Reviewed by Simon Hausmann.
4260
4261         [Qt] Implement support for setPOSIXLocale on Qt.
4262         https://bugs.webkit.org/show_bug.cgi?id=30268 
4263  
4264         * DumpRenderTree/qt/DumpRenderTree.cpp:
4265         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4266         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4267         (LayoutTestController::setPOSIXLocale):
4268         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4269
4270 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4271
4272         Unreviewed, adding myself to reviewers list.
4273
4274         * Scripts/modules/committers.py:
4275
4276 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4277
4278         Reviewed by Mark Rowe.
4279
4280         Fix null assignment so root tests work again.
4281
4282         * Scripts/webkitdirs.pm:
4283
4284 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
4285
4286         Reviewed by Simon Hausmann.
4287
4288         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
4289         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
4290         This is done in preparation of implementing missing features in DRT.
4291         No functionality changes made yet.
4292
4293         * DumpRenderTree/qt/DumpRenderTree.cpp:
4294         * DumpRenderTree/qt/DumpRenderTree.pro:
4295         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
4296         (EventSender::EventSender):
4297         (EventSender::mouseDown):
4298         (EventSender::mouseUp):
4299         (EventSender::mouseMoveTo):
4300         (EventSender::leapForward):
4301         (EventSender::keyDown):
4302         (EventSender::contextClick):
4303         (EventSender::scheduleAsynchronousClick):
4304         (EventSender::frameUnderMouse):
4305         * DumpRenderTree/qt/EventSenderQt.h: Added.
4306         (EventSender::clearKillRing):
4307         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
4308         (LayoutTestController::LayoutTestController):
4309         (LayoutTestController::reset):
4310         (LayoutTestController::processWork):
4311         (LayoutTestController::maybeDump):
4312         (LayoutTestController::waitUntilDone):
4313         (LayoutTestController::notifyDone):
4314         (LayoutTestController::windowCount):
4315         (LayoutTestController::clearBackForwardList):
4316         (LayoutTestController::dumpEditingCallbacks):
4317         (LayoutTestController::dumpResourceLoadCallbacks):
4318         (LayoutTestController::queueBackNavigation):
4319         (LayoutTestController::queueForwardNavigation):
4320         (LayoutTestController::queueLoad):
4321         (LayoutTestController::queueReload):
4322         (LayoutTestController::queueScript):
4323         (LayoutTestController::provisionalLoad):
4324         (LayoutTestController::timerEvent):
4325         (LayoutTestController::encodeHostName):
4326         (LayoutTestController::decodeHostName):
4327         (LayoutTestController::setJavaScriptProfilingEnabled):
4328         (LayoutTestController::setFixedContentsSize):
4329         (LayoutTestController::setPrivateBrowsingEnabled):
4330         (LayoutTestController::setPopupBlockingEnabled):
4331         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4332         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4333         (LayoutTestController::numberOfActiveAnimations):
4334         (LayoutTestController::disableImageLoading):
4335         (LayoutTestController::dispatchPendingLoadRequests):
4336         (LayoutTestController::setDatabaseQuota):
4337         (LayoutTestController::clearAllDatabases):
4338         (LayoutTestController::whiteListAccessFromOrigin):
4339         (LayoutTestController::waitForPolicyDelegate):
4340         (LayoutTestController::overridePreference):
4341         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
4342         (LayoutTestController::isLoading):
4343         (LayoutTestController::setLoading):
4344         (LayoutTestController::shouldDumpAsText):
4345         (LayoutTestController::shouldDumpBackForwardList):
4346         (LayoutTestController::shouldDumpChildrenAsText):
4347         (LayoutTestController::shouldDumpDatabaseCallbacks):
4348         (LayoutTestController::shouldDumpStatusCallbacks):
4349         (LayoutTestController::shouldWaitUntilDone):
4350         (LayoutTestController::canOpenWindows):
4351         (LayoutTestController::shouldDumpTitleChanges):
4352         (LayoutTestController::waitForPolicy):
4353         (LayoutTestController::dumpAsText):
4354         (LayoutTestController::dumpChildFramesAsText):
4355         (LayoutTestController::dumpDatabaseCallbacks):
4356         (LayoutTestController::dumpStatusCallbacks):
4357         (LayoutTestController::setCanOpenWindows):
4358         (LayoutTestController::dumpBackForwardList):
4359         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4360         (LayoutTestController::display):
4361         (LayoutTestController::dumpTitleChanges):
4362         (LayoutTestController::dumpSelectionRect):
4363         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
4364         (TextInputController::TextInputController):