WebKitTools/ChangeLog

   1 2009-11-25  Eric Seidel  <eric@webkit.org>
   2
   3         Reviewed by Adam Barth.
   4
   5         Centralize required argument parsing in Command
   6         https://bugs.webkit.org/show_bug.cgi?id=31872
   7
   8         * Scripts/modules/commands/download.py: remove custom required arg message.
   9         * Scripts/modules/commands/upload.py: ditto.
  10         * Scripts/modules/multicommandtool.py:
  11          - Add _parse_required_arguments.
  12          - Pass program name off to OptionParser.
  13          - Add name() for access to tool name.
  14          - Add check_arguments_and_execute and make it return a return code.
  15          - Replace a couple uses of + with %.
  16         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
  17
  18 2009-11-25  Eric Seidel  <eric@webkit.org>
  19
  20         Reviewed by Adam Barth.
  21
  22         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
  23         https://bugs.webkit.org/show_bug.cgi?id=31870
  24
  25         * Scripts/modules/commands/queries_unittest.py: Use the new class.
  26         * Scripts/modules/multicommandtool_unittest.py: Ditto.
  27         * Scripts/modules/outputcapture.py: Added.
  28
  29 2009-11-24  Dmitry Titov  <dimich@chromium.org>
  30
  31         Reviewed by Eric Seidel.
  32
  33         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
  34         https://bugs.webkit.org/show_bug.cgi?id=31444
  35
  36         * Scripts/build-webkit:
  37
  38 2009-11-24  Chris Marrin  <cmarrin@apple.com>
  39
  40         Reviewed by Simon Fraser.
  41
  42         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
  43         https://bugs.webkit.org/show_bug.cgi?id=27314
  44
  45         Now the script allows the directories with these tests to be included on all
  46         platforms but Mac, where they behave the same as always. For all other platforms
  47         the tests need to be excluded using the Skipped files, which is currently done
  48         for all platforms (including win since we're not turned on yet)
  49
  50         * Scripts/webkitdirs.pm:
  51
  52 2009-11-24  Eric Seidel  <eric@webkit.org>
  53
  54         Reviewed by Adam Barth.
  55
  56         queries_unittest.py should test command output
  57         https://bugs.webkit.org/show_bug.cgi?id=31845
  58
  59         * Scripts/modules/commands/queries_unittest.py:
  60          - Capture stdout and stderr and compare with expected strings.
  61
  62 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
  63
  64         No Review.
  65
  66         Fix spelling error ("depenedencies").
  67
  68         * Scripts/build-webkit:
  69
  70 2009-11-24  Mark Rowe  <mrowe@apple.com>
  71
  72         Land the configuration that includes the two debug GTK Linux builders.
  73
  74         * BuildSlaveSupport/build.webkit.org-config/config.json:
  75
  76 2009-11-24  David Kilzer  <ddkilzer@apple.com>
  77
  78         <http://webkit.org/b/31840> bisect-builds broke after r50080
  79
  80         Reviewed by Dan Bernstein.
  81
  82         * Scripts/bisect-builds:
  83         (mountAndRunNightly): Switched back to using backticks to run
  84         the hdiutil command since exec() will terminate the existing
  85         script, which is not what we want.  Store the output of
  86         File::Spec->devnull() in a variable for use in the hdiutil
  87         detach commands.
  88
  89 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
  90
  91         Reviewed by Kenneth Rohde Christiansen.
  92
  93         Include "config.h" to meet Coding Style Guidelines
  94         https://bugs.webkit.org/show_bug.cgi?id=31792
  95
  96         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
  97         * DumpRenderTree/qt/jsobjects.cpp:
  98         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  99
 100 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 101
 102         Reviewed by Oliver Hunt.
 103
 104         Implement new required function to pass test we used to pass. This
 105         change is required since r51294.
 106
 107         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 108         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 109
 110 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
 111
 112         Reviewed by Kenneth Rohde Christiansen.
 113
 114         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
 115         https://bugs.webkit.org/show_bug.cgi?id=31775
 116
 117         LayoutTestController::dumpBackForwardList() should work with local URLs
 118         as well as with normal URLs (in http tests for instance).
 119         Currently it does not output the latter properly.
 120
 121         Unskip a bunch of passing http/navigation tests.
 122
 123         * DumpRenderTree/qt/DumpRenderTree.cpp:
 124         (WebCore::dumpHistoryItem):
 125
 126 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
 127
 128         Reviewed by Oliver Hunt.
 129
 130         ARIA: support aria-flowto
 131         https://bugs.webkit.org/show_bug.cgi?id=31762
 132
 133         * DumpRenderTree/AccessibilityUIElement.cpp:
 134         (ariaFlowToElementAtIndexCallback):
 135         (AccessibilityUIElement::getJSClass):
 136         * DumpRenderTree/AccessibilityUIElement.h:
 137         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 138         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 139         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 140         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 141         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 142         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 143
 144 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
 145
 146         Reviewed by Kenneth Christiansen.
 147
 148         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
 149         https://bugs.webkit.org/show_bug.cgi?id=31638
 150
 151         Unfreeze WorkQueue after each test execution.
 152
 153         * DumpRenderTree/qt/DumpRenderTree.cpp:
 154         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 155
 156 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 157
 158         Reviewed by Adam Barth.
 159
 160         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
 161         for localhost and 127.0.0.1.
 162         https://bugs.webkit.org/show_bug.cgi?id=31783
 163
 164         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
 165
 166         * DumpRenderTree/qt/DumpRenderTree.cpp:
 167         (WebCore::NetworkAccessManager::NetworkAccessManager):
 168         (WebCore::NetworkAccessManager::sslErrorsEncountered):
 169         (WebCore::WebPage::WebPage):
 170         * DumpRenderTree/qt/DumpRenderTree.h:
 171
 172 2009-11-22  Chris Evans  <cevans@chromium.org>
 173
 174         Reviewed by Adam Barth.
 175
 176         Disable access to file:/// directory listings
 177         https://bugs.webkit.org/show_bug.cgi?id=31329
 178
 179         Implemented setAllowUniversalAccessFromFileURLs to support testing of
 180         file URL security.
 181
 182         * DumpRenderTree/LayoutTestController.cpp:
 183         (setAllowUniversalAccessFromFileURLsCallback):
 184         (LayoutTestController::staticFunctions):
 185         * DumpRenderTree/LayoutTestController.h:
 186         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 187         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 188         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 189         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 190         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 191         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 192         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 193         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 194
 195 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 196
 197         Reviewed by Kenneth Rohde Christiansen.
 198
 199         [Qt] Fix the timeout of fast/frames/frame-navigation.html
 200         https://bugs.webkit.org/show_bug.cgi?id=31638
 201
 202         The test is timeouting, because it uses the WorkQueue to load a document in one
 203         of the child frames and once the loading is finished, the DRT does not dump the
 204         tree. This is because it waits for the QWebFrame::loadFinished() signal from
 205         the main frame, while it should connect to QWebPage::loadFinished().
 206
 207         * DumpRenderTree/qt/DumpRenderTree.cpp:
 208         (WebCore::DumpRenderTree::DumpRenderTree):
 209
 210 2009-11-21  Eric Seidel  <eric@webkit.org>
 211
 212         Reviewed by Adam Barth.
 213
 214         bugzilla-tool --help spews way too much text
 215         https://bugs.webkit.org/show_bug.cgi?id=31771
 216
 217         * Scripts/bugzilla-tool:
 218          - Remove self.cached_scm initialization hack.
 219         * Scripts/modules/buildbot.py:
 220          - Make default_host accessible to callers.
 221         * Scripts/modules/commands/download.py:
 222          - Phrase help for all commands consistently and remove spurious help text punctuation.
 223         * Scripts/modules/commands/queries.py: Ditto.
 224         * Scripts/modules/commands/queues.py: Ditto.
 225         * Scripts/modules/commands/upload.py: Ditto.
 226         * Scripts/modules/multicommandtool.py:
 227          - Add HelpPrintingOptionParser.format_epilog to replace
 228            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 229            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 230          - Make --help only show a list of commands like "svn help" and "git help" do --
 231            previously --help was listing all commands and options.
 232          - Sort list of commands alphabetically.
 233
 234 2009-11-21  Eric Seidel  <eric@webkit.org>
 235
 236         No review.  Fixing a typo from the previous patch for bug 31767.
 237
 238         AbstractQueue.run_bugzilla_tool throws an exception
 239         https://bugs.webkit.org/show_bug.cgi?id=31769
 240
 241         * Scripts/modules/commands/queues.py:
 242
 243 2009-11-21  Eric Seidel  <eric@webkit.org>
 244
 245         Reviewed by Adam Barth.
 246
 247         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 248         https://bugs.webkit.org/show_bug.cgi?id=31767
 249
 250         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 251         Since we don't have a good way to test BugzillaTool pieces, I've
 252         left out a test for now.
 253
 254         * Scripts/bugzilla-tool:
 255          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 256         * Scripts/modules/commands/queues.py:
 257          - Use tool.path() instead of __file__.
 258         * Scripts/modules/multicommandtool.py:
 259          - Add a new path() method to MultiComandTool.
 260         * Scripts/modules/multicommandtool_unittest.py:
 261          - Provide a path() method.  Little point in testing this mock implementation.
 262
 263 2009-11-21  Adam Barth  <abarth@webkit.org>
 264
 265         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 266         WebKitTools.
 267
 268         * Scripts/modules/commands/download.py:
 269
 270 2009-11-21  Adam Barth  <abarth@webkit.org>
 271
 272         Reviewed by Eric Seidel.
 273
 274         Convert check-style to use LandingSequence
 275         https://bugs.webkit.org/show_bug.cgi?id=31763
 276
 277         Instead of manipulating the working copy by hand, we should use the
 278         LandingSequence in CheckStyle.  This will make this code eaiser to
 279         test.
 280
 281         * Scripts/modules/commands/download.py:
 282
 283 2009-11-20  Adam Barth  <abarth@webkit.org>
 284
 285         Reviewed by Eric Seidel.
 286
 287         Unit test query commands
 288         https://bugs.webkit.org/show_bug.cgi?id=31755
 289
 290         These tests are pretty rough, but hopefully they'll grow.
 291
 292         * Scripts/modules/commands/queries_unittest.py: Added.
 293         * Scripts/modules/mock_bugzillatool.py: Added.
 294         * Scripts/run-webkit-unittests:
 295
 296 2009-11-20  Eric Seidel  <eric@webkit.org>
 297
 298         Reviewed by Adam Barth.
 299
 300         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 301         https://bugs.webkit.org/show_bug.cgi?id=31758
 302
 303         * Scripts/modules/multicommandtool.py:
 304          - Allow passing of explicit commands to MultiCommandTool.__init__
 305         * Scripts/modules/multicommandtool_unittest.py:
 306          - Use new Command.name naming system.
 307          - Test Command auto-discovery.
 308         * Scripts/modules/workqueue.py:
 309          - bug_id no longer exists, use patch['bug_id'] instead.
 310         * Scripts/modules/workqueue_unittest.py:
 311          - WorkQueues require names now.
 312          - should_proceed_with_work_item must return a patch object.
 313
 314 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 315
 316         Reviewed by Beth Dakin.
 317
 318         WAI-ARIA: add support for aria-owns
 319         https://bugs.webkit.org/show_bug.cgi?id=31702
 320
 321         * DumpRenderTree/AccessibilityUIElement.cpp:
 322         (ariaOwnsElementAtIndexCallback):
 323         (AccessibilityUIElement::getJSClass):
 324         * DumpRenderTree/AccessibilityUIElement.h:
 325         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 326         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 327         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 328         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 329         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 330         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 331
 332 2009-11-20  Eric Seidel  <eric@webkit.org>
 333
 334         Reviewed by Adam Barth.
 335
 336         Fix exception thrown when running the commit-queue.
 337
 338         * Scripts/modules/statusbot.py: patch is optional.
 339         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 340
 341 2009-11-20  Eric Seidel  <eric@webkit.org>
 342
 343         Reviewed by Adam Barth.
 344
 345         Teach the StatusBot how to support more than just the commit-queue
 346         https://bugs.webkit.org/show_bug.cgi?id=31754
 347
 348         * Scripts/modules/workqueue.py: Another typo.
 349
 350 2009-11-20  Eric Seidel  <eric@webkit.org>
 351
 352         Reviewed by Adam Barth.
 353
 354         Teach the StatusBot how to support more than just the commit-queue
 355         https://bugs.webkit.org/show_bug.cgi?id=31754
 356
 357         * Scripts/modules/commands/queues.py: Fix silly typo.
 358
 359 2009-11-20  Eric Seidel  <eric@webkit.org>
 360
 361         Reviewed by Adam Barth.
 362
 363         Teach the StatusBot how to support more than just the commit-queue
 364         https://bugs.webkit.org/show_bug.cgi?id=31754
 365
 366         * CommitQueueStatus/index.yaml:
 367          - Add indices required for the new queries.
 368         * CommitQueueStatus/queue_status.py:
 369          - Add a patch-status page and move update_status to update-status.
 370          - Only display "commit-queue" status records for the commit-queue.
 371          - Add support for a queue_name property on status records.
 372          - Fix _int_from_request to actually work.
 373         * CommitQueueStatus/update_status.html:
 374          - Add support for a queue_name on status records.
 375          - Remove unused list of bug ids.
 376          * Scripts/modules/commands/queues.py
 377           - Make the queues pass the patch instead of the bug_id to StatusBot.
 378         * Scripts/modules/statusbot.py:
 379          - Support passing the queue_name to the status updates.
 380          - Support fetching patch status with patch_status().
 381         * Scripts/modules/workqueue.py:
 382          - Pass the patch to the StatusBot instead of the bug_id.
 383          - Let WorkQueues have a name.
 384
 385 2009-11-20  Adam Barth  <abarth@webkit.org>
 386
 387         Reviewed by Eric Seidel.
 388
 389         Move bugzilla-tool commands into their own file
 390         https://bugs.webkit.org/show_bug.cgi?id=31752
 391
 392         This will let us write unit tests.
 393
 394         * Scripts/bugzilla-tool:
 395         * Scripts/modules/commands/__init__.py: Added.
 396         * Scripts/modules/commands/download.py: Added.
 397         * Scripts/modules/commands/queries.py: Added.
 398         * Scripts/modules/commands/queues.py: Added.
 399         * Scripts/modules/commands/upload.py: Added.
 400         * Scripts/modules/grammar.py: Added.
 401
 402 2009-11-20  Adam Barth  <abarth@webkit.org>
 403
 404         Reviewed by Eric Seidel.
 405
 406         BuildQueue should check if the tree is currently buildable
 407         https://bugs.webkit.org/show_bug.cgi?id=31744
 408
 409         * Scripts/bugzilla-tool:
 410         * Scripts/modules/landingsequence.py:
 411         * Scripts/modules/webkitlandingscripts.py:
 412
 413 2009-11-20  Adam Barth  <abarth@webkit.org>
 414
 415         Reviewed by Eric Seidel.
 416
 417         Move prepare_clean_working_directory into the LandingSequence
 418         https://bugs.webkit.org/show_bug.cgi?id=31743
 419
 420         * Scripts/bugzilla-tool:
 421         * Scripts/modules/landingsequence.py:
 422
 423 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 424
 425         Reviewed by Kenneth Rohde Christiansen.
 426
 427         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 428         https://bugs.webkit.org/show_bug.cgi?id=30460
 429
 430         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 431
 432         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 433         (pluginInvoke):
 434
 435 2009-11-20  Adam Barth  <abarth@webkit.org>
 436
 437         Reviewed by Eric Seidel.
 438
 439         Pass the port information to the child process
 440         https://bugs.webkit.org/show_bug.cgi?id=31736
 441
 442         We need to do this so the child process knows what to build!
 443
 444         * Scripts/bugzilla-tool:
 445         * Scripts/modules/landingsequence.py:
 446         * Scripts/modules/webkitport.py:
 447         * Scripts/modules/webkitport_unittest.py:
 448
 449 2009-11-20  Adam Barth  <abarth@webkit.org>
 450
 451         Reviewed by Eric Seidel.
 452
 453         Support Qt port in build-queue
 454         https://bugs.webkit.org/show_bug.cgi?id=31733
 455
 456         * Scripts/bugzilla-tool:
 457
 458 2009-11-20  Adam Barth  <abarth@webkit.org>
 459
 460         Reviewed by Eric Seidel.
 461
 462         Implement a build-queue
 463         https://bugs.webkit.org/show_bug.cgi?id=31725
 464
 465         Currently this just builds the first 10 patches in the review queue.
 466         We'll want to do something smarter soon.
 467
 468         * Scripts/bugzilla-tool:
 469
 470 2009-11-20  Adam Barth  <abarth@webkit.org>
 471
 472         Reviewed by Eric Seidel.
 473
 474         Make commit-queue and style-queue show up in help
 475         https://bugs.webkit.org/show_bug.cgi?id=31724
 476
 477         We need to store their names on their class to make these commands
 478         properly register themselves with MultiCommandTool.
 479
 480         * Scripts/bugzilla-tool:
 481
 482 2009-11-20  Adam Barth  <abarth@webkit.org>
 483
 484         Reviewed by Eric Seidel.
 485
 486         Implement bugzilla-tool build-attachment
 487         https://bugs.webkit.org/show_bug.cgi?id=31722
 488
 489         This command builds an attachment from bugzilla.  It leaves the built
 490         patch in the working copy.
 491
 492         * Scripts/bugzilla-tool:
 493         * Scripts/modules/landingsequence.py:
 494         * Scripts/modules/webkitlandingscripts.py:
 495
 496 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 497
 498         Reviewed by Xan Lopez.
 499
 500         [GTK] DRT release event does not create the state correctly
 501         https://bugs.webkit.org/show_bug.cgi?id=31717
 502
 503         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 504
 505 2009-11-20  Eric Seidel  <eric@webkit.org>
 506
 507         Reviewed by Adam Barth.
 508
 509         MultiCommandTool should find Command objects automatically instead of with a manual list
 510         https://bugs.webkit.org/show_bug.cgi?id=31710
 511
 512         * Scripts/bugzilla-tool:
 513         * Scripts/modules/multicommandtool.py:
 514          - Use some wild python-fu to crawl all the known subclasses of Command.
 515
 516 2009-11-20  Adam Barth  <abarth@webkit.org>
 517
 518         Unreviewed "build" fix.  Added missing import.
 519
 520         * Scripts/bugzilla-tool:
 521
 522 2009-11-20  Adam Barth  <abarth@webkit.org>
 523
 524         Unreviewed "build" fix.  I failed to update LandingSequence.test
 525         properly.
 526
 527         * Scripts/modules/landingsequence.py:
 528
 529 2009-11-20  Adam Barth  <abarth@webkit.org>
 530
 531         Reviewed by Eric Seidel.
 532
 533         Create LandingSequence as the all-sing, all-dance landing class
 534         https://bugs.webkit.org/show_bug.cgi?id=31709
 535
 536         Client can inherit from this class to carefully control exactly which
 537         steps they wish to have happen in the landing sequence.
 538
 539         * Scripts/bugzilla-tool:
 540         * Scripts/modules/landingsequence.py: Added.
 541         * Scripts/modules/webkitlandingscripts.py: Added.
 542
 543 2009-11-19  Adam Barth  <abarth@webkit.org>
 544
 545         Reviewed by Eric Seidel.
 546
 547         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 548         https://bugs.webkit.org/show_bug.cgi?id=31707
 549
 550         This is to help when we implement build-attachment.
 551
 552         * Scripts/bugzilla-tool:
 553
 554 2009-11-19  Adam Barth  <abarth@webkit.org>
 555
 556         Reviewed by Eric Seidel.
 557
 558         Support Qt port in bugzilla-tool
 559         https://bugs.webkit.org/show_bug.cgi?id=31701
 560
 561         Now we support building with Qt!
 562
 563         * Scripts/bugzilla-tool:
 564         * Scripts/modules/webkitport.py: Added.
 565         * Scripts/modules/webkitport_unittest.py: Added.
 566         * Scripts/run-webkit-unittests:
 567
 568 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 569
 570         Reviewed by Adam Barth.
 571
 572         Remove inserting stderr into patch in bugzilla-tool
 573         https://bugs.webkit.org/show_bug.cgi?id=29914
 574
 575         Modify SCM python module's run_command function to avoid return of stderr
 576         by default, so stderr won't be inserted into the patches.
 577         Modify the related unit test.
 578
 579         * Scripts/modules/scm.py:
 580         * Scripts/modules/scm_unittest.py:
 581
 582 2009-11-19  Eric Seidel  <eric@webkit.org>
 583
 584         Reviewed by Adam Barth.
 585
 586         bugzilla-tool needs per-command help
 587         https://bugs.webkit.org/show_bug.cgi?id=31697
 588
 589         Added support for "bugzilla-tool help command-name"
 590         and a unit test to make sure it works.
 591
 592         * Scripts/modules/multicommandtool.py:
 593         * Scripts/modules/multicommandtool_unittest.py:
 594
 595 2009-11-19  Eric Seidel  <eric@webkit.org>
 596
 597         Reviewed by Adam Barth.
 598
 599         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 600         https://bugs.webkit.org/show_bug.cgi?id=31695
 601
 602         * Scripts/bugzilla-tool:
 603         * Scripts/modules/multicommandtool.py: Added.
 604         * Scripts/modules/multicommandtool_unittest.py: Added.
 605         * Scripts/run-webkit-unittests:
 606
 607 2009-11-19  Eric Seidel  <eric@webkit.org>
 608
 609         No review, just adding a FIXME.
 610
 611         Split out command parsing and help printing from BugzillaTool
 612         https://bugs.webkit.org/show_bug.cgi?id=31688
 613
 614         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 615
 616 2009-11-19  Eric Seidel  <eric@webkit.org>
 617
 618         Reviewed by Adam Barth.
 619
 620         Split out command parsing and help printing from BugzillaTool
 621         https://bugs.webkit.org/show_bug.cgi?id=31688
 622
 623         * Scripts/bugzilla-tool:
 624          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 625          - Rename private methods to use _ pattern.
 626          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 627          -
 628
 629 2009-11-19  Eric Seidel  <eric@webkit.org>
 630
 631         Reviewed by Adam Barth.
 632
 633         Re-factor help printing to use modern python idioms
 634         https://bugs.webkit.org/show_bug.cgi?id=31685
 635
 636         * Scripts/bugzilla-tool:
 637
 638 2009-11-19  Eric Seidel  <eric@webkit.org>
 639
 640         Reviewed by Darin Adler.
 641
 642         commit-queue empty queue logs twice
 643         https://bugs.webkit.org/show_bug.cgi?id=31679
 644
 645         * Scripts/bugzilla-tool:
 646
 647 2009-11-19  Eric Seidel  <eric@webkit.org>
 648
 649         Reviewed by Darin Adler.
 650
 651         bugzilla-tool's reviewer/committer rejection message should be clearer
 652         https://bugs.webkit.org/show_bug.cgi?id=31126
 653
 654         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 655
 656         * Scripts/modules/bugzilla.py:
 657
 658 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 659
 660         Reviewed by Pavel Feldman.
 661
 662         Forces a WM_PAINT event on calling layoutTestController.display()
 663         in order to enable the timeline-paint.html test on Windows.
 664         ::UpdateWindow() does not force an event becaue the window is
 665         not visible.
 666
 667         https://bugs.webkit.org/show_bug.cgi?id=31402
 668
 669         * DumpRenderTree/win/DumpRenderTree.cpp:
 670         (displayWebView):
 671
 672 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 673
 674         No review needed.
 675
 676         Added myself to committers list.
 677
 678         * Scripts/modules/committers.py:
 679
 680 2009-11-19  Adam Barth  <abarth@webkit.org>
 681
 682         Reviewed by Eric Seidel.
 683
 684         Bugzilla-tool command classes should match command names
 685         https://bugs.webkit.org/show_bug.cgi?id=31666
 686
 687         I renamed all the commands except CommitMessageForCurrentDiff because
 688         the new name would conflict with an existing class.
 689
 690         * Scripts/bugzilla-tool:
 691
 692 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 693
 694         Reviewed by Gustavo Noronha Silva.
 695
 696         Web Inspector: Implement "show inspector" in WebKit GTK
 697         API and enable console tests.
 698
 699         https://bugs.webkit.org/show_bug.cgi?id=31669
 700
 701         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 702         (LayoutTestController::showWebInspector):
 703
 704 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 705
 706         Reviewed by Simon Hausmann.
 707
 708         Minor refactoring + more documentation.
 709
 710         * DumpRenderTree/qt/DumpRenderTree.cpp:
 711         (WebCore::clearHistory):
 712         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 713
 714 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 715
 716         Reviewed by Eric Seidel.
 717
 718         Ignore websocket tests when --no-http is specified.
 719         https://bugs.webkit.org/show_bug.cgi?id=31662
 720
 721         * Scripts/run-webkit-tests:
 722
 723 2009-11-18  Adam Barth  <abarth@webkit.org>
 724
 725         Reviewed by Eric Seidel.
 726
 727         Normalize ' and " in bugzilla-tool
 728         https://bugs.webkit.org/show_bug.cgi?id=31655
 729
 730         We decided " is better than ' and we should be consistent.
 731
 732         * Scripts/bugzilla-tool:
 733
 734 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 735
 736         Reviewed by Kenneth Rohde Christiansen.
 737
 738         [Qt] Remove support for Qt v4.3 or older versions
 739         https://bugs.webkit.org/show_bug.cgi?id=29469
 740
 741         * DumpRenderTree/qt/DumpRenderTree.pro:
 742         * DumpRenderTree/qt/ImageDiff.pro:
 743
 744 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 745
 746         Reviewed by Eric Seidel.
 747
 748         GitTest.test_create_binary_patch fails if /tmp is symlink
 749         https://bugs.webkit.org/show_bug.cgi?id=31536
 750
 751         * Scripts/modules/scm_unittest.py:
 752
 753 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 754
 755         Reviewed by Darin Adler.
 756
 757         Configuration for Chromium Build Slaves.
 758
 759         https://bugs.webkit.org/show_bug.cgi?id=31442
 760
 761         * BuildSlaveSupport/build.webkit.org-config/config.json:
 762         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 763
 764 2009-11-18  Eric Seidel  <eric@webkit.org>
 765
 766         Reviewed by Darin Adler.
 767
 768         workqueue.py results in totally broken commit-queue UI
 769         https://bugs.webkit.org/show_bug.cgi?id=31645
 770
 771         * Scripts/bugzilla-tool:
 772          - Remove unneeded use of PatchCollection.
 773          - Grab a new copy of the cq'd patches every run of the queue.
 774
 775 2009-11-18  Sam Weinig  <sam@webkit.org>
 776
 777         Reviewed by Anders Carlsson.
 778
 779         Make the Mac Geolocation API async.
 780
 781         Update DRT to use the new async Mac Geolocation API.
 782
 783         * DumpRenderTree/mac/UIDelegate.mm:
 784         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 785
 786 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 787
 788         Reviewed by Kenneth Rohde Christiansen.
 789
 790         Add and option to toggle HTML5 datalist support to build-webkit
 791         https://bugs.webkit.org/show_bug.cgi?id=31599
 792
 793         * Scripts/build-webkit:
 794
 795 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 796
 797         Reviewed by Kevin Ollivier.
 798
 799         Enable wx plugin support using the Windows implementation as a base.
 800
 801         https://bugs.webkit.org/show_bug.cgi?id=31636
 802
 803         * wx/build/settings.py:
 804
 805 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 806
 807         Reviewed by Simon Hausmann.
 808
 809         Change the initialization order so that the controllers
 810         will be created before exporting them to the JS DOM window.
 811
 812         * DumpRenderTree/qt/DumpRenderTree.cpp:
 813         (WebCore::DumpRenderTree::DumpRenderTree):
 814
 815 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 816
 817         Reviewed by Simon Hausmann.
 818
 819         Fix a code copy and paste error. m_page should be page.
 820
 821         * DumpRenderTree/qt/DumpRenderTree.cpp:
 822         (WebCore::DumpRenderTree::createWindow):
 823
 824 2009-11-17  Mark Rowe  <mrowe@apple.com>
 825
 826         Reviewed by Alexey Proskuryakov.
 827
 828         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 829
 830         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 831         This prevents symlinks from confusing the descendant check.
 832
 833 2009-11-17  Mark Rowe  <mrowe@apple.com>
 834
 835         Reviewed by Alexey Proskuryakov.
 836
 837         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 838
 839         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 840         server to be up rather than having run-webkit-tests abort immediately.
 841
 842         * Scripts/run-webkit-tests:
 843
 844 2009-11-17  Eric Seidel  <eric@webkit.org>
 845
 846         Reviewed by Darin Adler.
 847
 848         commit-queue is failing to set reviewer in ChangeLogs
 849         https://bugs.webkit.org/show_bug.cgi?id=31592
 850
 851         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 852         * Scripts/modules/bugzilla.py:
 853          - Add a new _validate_committer_and_reviewer function as a
 854            temporary solution until we can make a real Attachment object
 855            which knows how to fill in its committer/reviewer fields automatically.
 856
 857 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 858
 859         Unreviewed buildbot fix.
 860
 861         Revert part of earlier patch and add comment, as it
 862         was causing timeouts on the buildbot.
 863
 864         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 865         (LayoutTestController::notifyDone):
 866
 867 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 868
 869         Reviewed by Oliver Hunt.
 870
 871         Make the timeout 15 sec as for the other DRT's and make
 872         it print out the same output when a test timeout.
 873
 874         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 875         (LayoutTestController::waitUntilDone):
 876         (LayoutTestController::notifyDone):
 877         (LayoutTestController::timerEvent):
 878
 879 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 880
 881         Reviewed by Timothy Hatcher.
 882
 883         Fixed typos in comments.
 884
 885         * Scripts/modules/committers.py:
 886
 887 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 888
 889         Reviewed by Timothy Hatcher.
 890
 891         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 892         - Updated DRT to show/close inspector for all tests under /inspector
 893         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 894           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 895         - Removed reload on each inspector test
 896         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 897         inspector for those.
 898         - Reimplemented timeline tests in order to get rid of reload there.
 899         - Moved tests that don't require harness into the fast group.
 900
 901         https://bugs.webkit.org/show_bug.cgi?id=31472
 902
 903         * DumpRenderTree/LayoutTestController.cpp:
 904         (setTimelineProfilingEnabledCallback):
 905         (closeWebInspectorCallback):
 906         (LayoutTestController::staticFunctions):
 907         * DumpRenderTree/LayoutTestController.h:
 908         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 909         (shouldOpenWebInspector):
 910         (runTest):
 911         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 912         (LayoutTestController::setTimelineProfilingEnabled):
 913         * DumpRenderTree/mac/DumpRenderTree.mm:
 914         (shouldOpenWebInspector):
 915         (runTest):
 916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 917         (LayoutTestController::setTimelineProfilingEnabled):
 918         * DumpRenderTree/win/DumpRenderTree.cpp:
 919         (shouldOpenWebInspector):
 920         (runTest):
 921         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 922         (LayoutTestController::setTimelineProfilingEnabled):
 923
 924 2009-11-17  Oliver Hunt  <oliver@apple.com>
 925
 926         Reviewed by Maciej Stachowiak.
 927
 928         Incorrect use of JavaScriptCore API in DumpRenderTree
 929         https://bugs.webkit.org/show_bug.cgi?id=31577
 930
 931         Return undefined rather than a literal null.
 932
 933         * DumpRenderTree/AccessibilityUIElement.cpp:
 934         (setSelectedTextRangeCallback):
 935         (incrementCallback):
 936         (decrementCallback):
 937         (showMenuCallback):
 938
 939 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 940
 941         Reviewed by Beth Dakin.
 942
 943         AX: aria-labelledby duplicates some of its WAI-ARIA label
 944         https://bugs.webkit.org/show_bug.cgi?id=31565
 945
 946         * DumpRenderTree/AccessibilityUIElement.cpp:
 947         (titleUIElementCallback):
 948         (getIsValidCallback):
 949         (AccessibilityUIElement::getJSClass):
 950
 951 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 952
 953         Reviewed by Simon Hausmann.
 954
 955         r50942 broke output from created windows. Make the
 956         m_enableTextOutput a member of the DRT and not the
 957         WebPage.
 958
 959         * DumpRenderTree/qt/DumpRenderTree.cpp:
 960         (WebCore::WebPage::WebPage):
 961         (WebCore::WebPage::javaScriptAlert):
 962         (WebCore::WebPage::javaScriptConsoleMessage):
 963         (WebCore::WebPage::javaScriptConfirm):
 964         (WebCore::WebPage::javaScriptPrompt):
 965         (WebCore::WebPage::acceptNavigationRequest):
 966         (WebCore::DumpRenderTree::DumpRenderTree):
 967         (WebCore::DumpRenderTree::open):
 968         (WebCore::DumpRenderTree::createWindow):
 969         * DumpRenderTree/qt/DumpRenderTree.h:
 970         (WebCore::DumpRenderTree::setTextOutputEnabled):
 971         (WebCore::DumpRenderTree::isTextOutputEnabled):
 972         (WebCore::WebPage::shouldInterruptJavaScript):
 973         (WebCore::WebPage::isTextOutputEnabled):
 974         (WebCore::WebPage::setViewGeometry):
 975
 976 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 977
 978         Reviewed by Gustavo Noronha Silva.
 979
 980         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 981         as the implementation is being used by at least Qt and Gtk+.
 982
 983         Update buildsystems as well.
 984
 985         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 986         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 987         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 988         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 989         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 990         * GNUmakefile.am:
 991
 992 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 993
 994         Reviewed by Alexey Proskuryakov.
 995
 996         Disable wss until all platforms support pyOpenSSL
 997
 998         https://bugs.webkit.org/show_bug.cgi?id=31479
 999
1000         * Scripts/run-webkit-tests:
1001
1002 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1003
1004         Reviewed by Kenneth Christiansen.
1005
1006         [Qt] Implement load error pages support for Qt's DRT.
1007         https://bugs.webkit.org/show_bug.cgi?id=31509
1008
1009         For now, it will not be a default feature, and layout tests
1010         that want to make use of this have to explicitily call
1011         'handleErrorPages();' for the test source.
1012
1013         Any of the other DumpRenderTree's (mac, win and gtk)
1014         support handling error pages. Qt's will be the first.
1015
1016         * DumpRenderTree/qt/DumpRenderTree.cpp:
1017         (WebCore::WebPage::supportsExtension):
1018         (WebCore::WebPage::extension):
1019         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1020         (LayoutTestController::reset):
1021         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1022         (LayoutTestController::shouldHandleErrorPages):
1023         (LayoutTestController::handleErrorPages):
1024
1025 2009-11-16  Eric Seidel  <eric@webkit.org>
1026
1027         Reviewed by Adam Barth.
1028
1029         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1030         https://bugs.webkit.org/show_bug.cgi?id=31549
1031
1032         Renamed --commit-queue to --non-interactive in most places
1033         and remove the code in land-patches which is no longer needed.
1034
1035         * Scripts/bugzilla-tool:
1036
1037 2009-11-16  Eric Seidel  <eric@webkit.org>
1038
1039         Reviewed by Adam Barth.
1040
1041         The commit-queue should use land-attachment
1042         https://bugs.webkit.org/show_bug.cgi?id=31548
1043
1044         * Scripts/bugzilla-tool:
1045
1046 2009-11-16  Adam Barth  <abarth@webkit.org>
1047
1048         Reviewed by Eric Seidel.
1049
1050         Convert CommitQueue over to PatchCollection
1051         https://bugs.webkit.org/show_bug.cgi?id=31547
1052
1053         Also fixes a bug in workqueue and adds a test!
1054
1055         * Scripts/bugzilla-tool:
1056         * Scripts/modules/workqueue.py:
1057         * Scripts/modules/workqueue_unittest.py:
1058
1059 2009-11-16  Adam Barth  <abarth@webkit.org>
1060
1061         Reviewed by Eric Seidel.
1062
1063         Move StyleQueue over to using PatchCollection
1064         https://bugs.webkit.org/show_bug.cgi?id=31544
1065
1066         That's what the class it's for.
1067
1068         * Scripts/bugzilla-tool:
1069         * Scripts/modules/patchcollection.py:
1070         * Scripts/modules/patchcollection_unittest.py:
1071
1072 2009-11-16  Eric Seidel  <eric@webkit.org>
1073
1074         Reviewed by Adam Barth.
1075
1076         bugzilla-tool needs a land-attachment command
1077         https://bugs.webkit.org/show_bug.cgi?id=31546
1078
1079         * Scripts/bugzilla-tool:
1080          - Move all the logic into AbstractLandingCommand and
1081            add a new LandAttachment command subclass.
1082          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1083
1084 2009-11-16  Eric Seidel  <eric@webkit.org>
1085
1086         Reviewed by Adam Barth.
1087
1088         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1089         https://bugs.webkit.org/show_bug.cgi?id=31543
1090
1091         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1092
1093         * Scripts/bugzilla-tool:
1094
1095 2009-11-16  Eric Seidel  <eric@webkit.org>
1096
1097         Reviewed by Adam Barth.
1098
1099         Disable the style queue from posting to the commit queue status page.
1100
1101         * Scripts/bugzilla-tool:
1102
1103 2009-11-16  Adam Barth  <abarth@webkit.org>
1104
1105         Reviewed by Eric Seidel.
1106
1107         Implement PatchCollection
1108         https://bugs.webkit.org/show_bug.cgi?id=31541
1109
1110         This class holds a set of patches and lets clients iterate through
1111         them.  Optionally, clients can install a filter.
1112
1113         * Scripts/modules/patchcollection.py: Added.
1114         * Scripts/modules/patchcollection_unittest.py: Added.
1115         * Scripts/run-webkit-unittests:
1116
1117 2009-11-16  Eric Seidel  <eric@webkit.org>
1118
1119         Reviewed by Adam Barth.
1120
1121         bugzilla-tool land-patches will close bugs with patches r=?
1122         https://bugs.webkit.org/show_bug.cgi?id=28230
1123
1124         The commit-queue shouldn't close patches with outstanding reviews on them,
1125         even if many reviewers seem to be against multi-patch bugs.
1126
1127         * Scripts/bugzilla-tool:
1128
1129 2009-11-16  Eric Seidel  <eric@webkit.org>
1130
1131         Reviewed by Adam Barth.
1132
1133         bugzilla-tool check-style should work with attachment ids instead of bug ids
1134         https://bugs.webkit.org/show_bug.cgi?id=31540
1135
1136         * Scripts/bugzilla-tool:
1137
1138 2009-11-16  Eric Seidel  <eric@webkit.org>
1139
1140         Reviewed by Adam Barth.
1141
1142         WorkQueue is the only place that should know about special exit codes
1143         https://bugs.webkit.org/show_bug.cgi?id=31534
1144
1145         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1146         and add tests for handling exit codes.
1147         I also cleaned up workqueue_unittest.py more.
1148
1149         * Scripts/bugzilla-tool:
1150         * Scripts/modules/workqueue.py:
1151         * Scripts/modules/workqueue_unittest.py:
1152
1153 2009-11-16  Eric Seidel  <eric@webkit.org>
1154
1155         Reviewed by Adam Barth.
1156
1157         Re-factor workqueue_unittest to allow for more than one test.
1158         https://bugs.webkit.org/show_bug.cgi?id=31535
1159
1160         * Scripts/modules/workqueue_unittest.py:
1161
1162 2009-11-16  Eric Seidel  <eric@webkit.org>
1163
1164         Reviewed by Adam Barth.
1165
1166         land-patches needs to be re-factored into smaller chunks
1167         https://bugs.webkit.org/show_bug.cgi?id=31532
1168
1169         * Scripts/bugzilla-tool: fix a couple obvious typos.
1170
1171 2009-11-16  Eric Seidel  <eric@webkit.org>
1172
1173         Reviewed by Adam Barth.
1174
1175         land-patches needs to be re-factored into smaller chunks
1176         https://bugs.webkit.org/show_bug.cgi?id=31532
1177
1178         The next patch will move these methods into WebKitLandingScripts.
1179
1180         * Scripts/bugzilla-tool:
1181          - Split out _land_patch and _close_bug_if_no_active_patches.
1182
1183 2009-11-16  Adam Barth  <abarth@webkit.org>
1184
1185         Reviewed by Eric Seidel.
1186
1187         Fix silly copy-and-paste code.  I am a terrible coder.
1188
1189         * Scripts/modules/bugzilla.py:
1190
1191 2009-11-16  Adam Barth  <abarth@webkit.org>
1192
1193         Reviewed by Eric Seidel.
1194
1195         Implement a StyleQueue
1196         https://bugs.webkit.org/show_bug.cgi?id=31537
1197
1198         The first iteration of the style queue only produces output locally.
1199         There is also a limit of 10 patches because it's not that useful to
1200         iterate through the entire review queue at this point.  We can remove
1201         the limit later.
1202
1203         * Scripts/bugzilla-tool:
1204         * Scripts/modules/bugzilla.py:
1205
1206 2009-11-16  Adam Barth  <abarth@webkit.org>
1207
1208         Reviewed by Eric Seidel.
1209
1210         Unit test WorkQueue
1211         https://bugs.webkit.org/show_bug.cgi?id=31531
1212
1213         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1214
1215         * Scripts/bugzilla-tool:
1216         * Scripts/modules/statusbot.py:
1217         * Scripts/modules/workqueue.py:
1218         * Scripts/modules/workqueue_unittest.py: Added.
1219         * Scripts/run-webkit-unittests:
1220
1221 2009-11-16  Eric Seidel  <eric@webkit.org>
1222
1223         Reviewed by Adam Barth.
1224
1225         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1226         https://bugs.webkit.org/show_bug.cgi?id=31530
1227
1228         * Scripts/bugzilla-tool:
1229
1230 2009-11-16  Eric Seidel  <eric@webkit.org>
1231
1232         Reviewed by Adam Barth.
1233
1234         bugzilla-tool needs apply-attachment
1235         https://bugs.webkit.org/show_bug.cgi?id=31528
1236
1237         * Scripts/bugzilla-tool:
1238          - Add ApplyAttachment command.
1239          - Abstract applying code into WebKitApplyingScripts.
1240          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1241         * Scripts/modules/bugzilla.py:
1242          - Add fetch_attachment and bug_id_for_attachment_id.
1243         * Scripts/modules/bugzilla_unittest.py:
1244          - Add test for new parsing.
1245          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1246
1247 2009-11-16  Eric Seidel  <eric@webkit.org>
1248
1249         Reviewed by Adam Barth.
1250
1251         Document check-style's use of force_clean.
1252
1253         * Scripts/bugzilla-tool:
1254         * Scripts/modules/scm.py:
1255
1256 2009-11-16  Adam Barth  <abarth@webkit.org>
1257
1258         Reviewed by Eric Seidel.
1259
1260         Move WorkQueue to its own file
1261         https://bugs.webkit.org/show_bug.cgi?id=31529
1262
1263         WorkQueue and WorkQueueDelegate are separate concerns from
1264         bugzilla-tool.  Also added a missing include to logging.py.
1265
1266         * Scripts/bugzilla-tool:
1267         * Scripts/modules/logging.py:
1268         * Scripts/modules/workqueue.py:
1269
1270 2009-11-16  Adam Barth  <abarth@webkit.org>
1271
1272         Reviewed by Eric Seidel.
1273
1274         Move OutputTee to logging.py.
1275
1276         * Scripts/bugzilla-tool:
1277         * Scripts/modules/logging.py:
1278
1279 2009-11-15  Adam Barth  <abarth@webkit.org>
1280
1281         Reviewed by Eric Seidel.
1282
1283         Refactor bugzilla-tool to allow for multiple queues
1284         https://bugs.webkit.org/show_bug.cgi?id=31513
1285
1286         Divide the commit queue class into three class to make creating
1287         additional queues easier.
1288
1289         * Scripts/bugzilla-tool:
1290
1291 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1292
1293         Reviewed by Eric Seidel.
1294
1295         svn-apply may not handle git patches created by bugzilla-tool
1296         https://bugs.webkit.org/show_bug.cgi?id=31457
1297
1298         * Scripts/modules/scm.py:
1299         * Scripts/modules/scm_unittest.py:
1300
1301 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1302
1303         Reviewed by Eric Seidel.
1304
1305         bugzilla-tool should post git binary diff
1306         https://bugs.webkit.org/show_bug.cgi?id=31458
1307
1308         Add --binary option to Git.create_patch.
1309
1310         * Scripts/modules/scm.py:
1311         * Scripts/modules/scm_unittest.py:
1312
1313 2009-11-15  Adam Barth  <abarth@webkit.org>
1314
1315         Reviewed by Darin Adler.
1316
1317         Add bugzilla-tool check-style
1318         https://bugs.webkit.org/show_bug.cgi?id=31515
1319
1320         * Scripts/bugzilla-tool:
1321         * Scripts/modules/bugzilla.py:
1322
1323 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1324
1325         Reviewed by Simon Hausmann.
1326
1327         Make the Qt Linux only --valgrind feature, suppress errors
1328         defined in the SuppressedValgrindErrors file.
1329
1330         * Scripts/run-webkit-tests:
1331
1332 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1333
1334         Reviewed by Simon Hausmann.
1335
1336         Set the locale to C and not to the current one in use on the system.
1337
1338         * DumpRenderTree/qt/DumpRenderTree.cpp:
1339         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1340
1341 2009-11-13  Adam Roben  <aroben@apple.com>
1342
1343         Add support for
1344         http/tests/security/isolatedWorld/didClearWindowObject.html
1345
1346         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1347         window objects in isolated worlds are cleared
1348
1349         Reviewed by Dave Hyatt.
1350
1351         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1352
1353         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1354         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1355         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1356         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1357         Added. Sets a __worldID property on the global object whose value is
1358         the ID of this world.
1359         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1360         Respond to this new delegate callback by calling through to one of the
1361         above new methods.
1362         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1363         (worldMap): Added. Returns a HashMap containing all the worlds we've
1364         created.
1365         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1366         haven't kept track of this world.
1367         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1368         instead of declaring our own.
1369
1370         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1371
1372         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1373         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1374         didClearWindowObjectForFrameInStandardWorld.
1375         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1376         Respond to this new delegate callback by calling through to one of the
1377         below new methods.
1378         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1379         Added. Sets a __worldID property on the gobal object whose value is
1380         the ID of this world.
1381         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1382         Added. Moved code here from didClearWindowObject.
1383
1384         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1385         didClearWindowObjectForFrame* functions.
1386
1387         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1388         (worldMap): Added. Returns a HashMap containing all the worlds we've
1389         created.
1390         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1391         haven't kept track of this world.
1392         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1393         instead of declaring our own.
1394
1395 2009-11-13  Adam Roben  <aroben@apple.com>
1396
1397         Finish replacing worldIDs with world objects
1398
1399         The only remaining use of worldIDs was in a method only used by DRT
1400         for the isolated worlds tests.
1401
1402         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1403
1404         Reviewed by Mark Rowe.
1405
1406         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1407         (LayoutTestController::evaluateScriptInIsolatedWorld):
1408         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1409         (LayoutTestController::evaluateScriptInIsolatedWorld):
1410         Updated for changes to WebFrame. Now holds the map of worldID -> world
1411         at this level instead of making WebKit do it.
1412
1413 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1414
1415         Reviewed by Simon Hausmann.
1416
1417         [Qt] Ensure the DRT does not output anything until first test is run
1418
1419         * DumpRenderTree/qt/DumpRenderTree.cpp:
1420         * DumpRenderTree/qt/DumpRenderTree.h:
1421
1422 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1423
1424         Reviewed by Tor Arne Vestbø.
1425
1426         Clear the undo stack in before each new test run.
1427
1428         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1429
1430         * DumpRenderTree/qt/DumpRenderTree.cpp:
1431         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1432
1433 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1434
1435         Reviewed by Kenneth Rohde Christiansen.
1436
1437         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1438
1439         * DumpRenderTree/qt/DumpRenderTree.cpp:
1440         (WebCore::WebPage::resetSettings):
1441         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1442         (LayoutTestController::overridePreference):
1443
1444 2009-11-13  Eric Seidel  <eric@webkit.org>
1445
1446         Reviewed by Adam Barth.
1447
1448         Update committers.py based on svn records
1449         https://bugs.webkit.org/show_bug.cgi?id=31366
1450
1451         This list was generated using validate-committer-lists from
1452         https://bugs.webkit.org/show_bug.cgi?id=30970
1453         and makes committers.py current for committers who have
1454         committed in the last 3 years.
1455
1456         * Scripts/modules/committers.py:
1457
1458 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1459
1460         Reviewed by Adam Barth.
1461
1462         The document-open.html test was flaky at times. The test invokes the layout test plugin
1463         which in its destroy stream handler opens a new document. This basically tears down the
1464         stream and the associated plugin instance. The pluginLog function in the layout test
1465         plugin attempts to retrieve the window script object on a torn down plugin instance
1466         which crashed consistently on windows in the debugger. The functions which issue
1467         these logs already have a valid window script object. We now have variants of the pluginLog
1468         function which take in a window script object with and without variable arguments.
1469
1470         https://bugs.webkit.org/show_bug.cgi?id=31067
1471
1472         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1473         (pluginLogWithWindowObject):
1474         (pluginLogWithWindowObjectVariableArgs):
1475         (pluginLog):
1476         (notifyTestCompletion):
1477         (testDocumentOpen):
1478         (testWindowOpen):
1479
1480 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1481
1482         Reviewed by Gustavo Noronha Silva.
1483
1484         https://bugs.webkit.org/show_bug.cgi?id=30997
1485         [Gtk] Implemment AtkDocument
1486
1487         Added testing support.
1488
1489         * DumpRenderTree/AccessibilityUIElement.cpp:
1490         * DumpRenderTree/AccessibilityUIElement.h:
1491         (getDocumentEncodingCallback):
1492         (getDocumentURICallback):
1493         (AccessibilityUIElement::getJSClass):
1494         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1495         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1496         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1497         (AccessibilityUIElement::documentEncoding):
1498         (AccessibilityUIElement::documentURI):
1499
1500 2009-11-12  Adam Roben  <aroben@apple.com>
1501
1502         Replace worldIDs with world objects
1503
1504         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1505         user scripts/stylesheets and isolated worlds
1506
1507         Reviewed by Sam Weinig.
1508
1509         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1510         (LayoutTestController::addUserScript):
1511         (LayoutTestController::addUserStyleSheet):
1512         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1513         (LayoutTestController::addUserScript):
1514         (LayoutTestController::addUserStyleSheet):
1515         Changed these functions to create a new WebJSWorld each time they're
1516         called and to pass that world to WebKit.
1517
1518 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1519
1520         Reviewed by Oliver Hunt.
1521
1522         need to implement aria tree roles
1523         https://bugs.webkit.org/show_bug.cgi?id=31284
1524
1525         * DumpRenderTree/AccessibilityUIElement.cpp:
1526         (disclosedRowAtIndexCallback):
1527         (selectedRowAtIndexCallback):
1528         (isEqualCallback):
1529         (isAttributeSettableCallback):
1530         (isActionSupportedCallback):
1531         (disclosedByRowCallback):
1532         (hierarchicalLevelCallback):
1533         (AccessibilityUIElement::getJSClass):
1534         * DumpRenderTree/AccessibilityUIElement.h:
1535         (AccessibilityUIElement::isEqual):
1536         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1537         (AccessibilityUIElement::hierarchicalLevel):
1538         (AccessibilityUIElement::disclosedRowAtIndex):
1539         (AccessibilityUIElement::selectedRowAtIndex):
1540         (AccessibilityUIElement::disclosedByRow):
1541         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1542         (AccessibilityUIElement::getChildAtIndex):
1543         (AccessibilityUIElement::disclosedRowAtIndex):
1544         (AccessibilityUIElement::selectedRowAtIndex):
1545         (AccessibilityUIElement::titleUIElement):
1546         (AccessibilityUIElement::parentElement):
1547         (AccessibilityUIElement::disclosedByRow):
1548         (AccessibilityUIElement::hierarchicalLevel):
1549         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1550         (AccessibilityUIElement::hierarchicalLevel):
1551         (AccessibilityUIElement::disclosedRowAtIndex):
1552         (AccessibilityUIElement::selectedRowAtIndex):
1553         (AccessibilityUIElement::disclosedByRow):
1554
1555 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1556
1557         Reviewed by Darin Adler.
1558
1559         svn-apply can not handle git binary diffs
1560         https://bugs.webkit.org/show_bug.cgi?id=26830
1561
1562         Support "literal" type git binary diffs.
1563
1564         * Scripts/VCSUtils.pm:
1565         * Scripts/modules/scm_unittest.py:
1566         * Scripts/svn-apply:
1567
1568 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1569
1570         Not reviewed, removing duplicate entry for myself in committers.py.
1571
1572         * Scripts/modules/committers.py:
1573
1574 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1575
1576         Reviewed by Darin Adler and Mark Rowe.
1577
1578         https://bugs.webkit.org/show_bug.cgi?id=31200
1579         Tests in http/tests/security/mixedContent start to fail when new tests are added
1580
1581         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1582
1583 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1584
1585         Reviewed by Jan Alonzo.
1586
1587         Create, and display a window for the inspector, for inspector
1588         tests.
1589
1590         Need to also show/hide the inspector window to avoid having
1591         problems with code assuming it is realized
1592         https://bugs.webkit.org/show_bug.cgi?id=31347
1593
1594         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1595         (webInspectorShowWindow):
1596         (webInspectorCloseWindow):
1597         (webInspectorInspectWebView):
1598         (createWebView):
1599
1600 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1601
1602         Unreviewed Qt buildbot fix.
1603
1604         My previous fix was wrong, so revert that change and fix it by
1605         returning when the document of the frame has no document element.
1606         Idea is borrowed from mac and win DRT.
1607
1608         * DumpRenderTree/qt/DumpRenderTree.cpp:
1609         (WebCore::DumpRenderTree::dumpFramesAsText):
1610
1611 2009-11-11  Eric Seidel  <eric@webkit.org>
1612
1613         Reviewed byg Kenneth Rohde Christiansen.
1614
1615         Update Kenneth's committer record to include the email he
1616         uses on lists.webkit.org.
1617
1618         * Scripts/modules/committers.py:
1619
1620 2009-11-11  Eric Seidel  <eric@webkit.org>
1621
1622         Reviewed by Gustavo Noronha Silva.
1623
1624         Several committers use separate email addresses for bugzilla and svn.webkit.org
1625         https://bugs.webkit.org/show_bug.cgi?id=31364
1626
1627         Update records for existing committers to include email addresses
1628         used in svn.webkit.org and lists.webkit.org.
1629         Most committers use the same email address in all 3 places, but some use
1630         separate addresses.  committers.py needs record of each of these addresses.
1631
1632         * Scripts/modules/committers.py:
1633
1634 2009-11-11  Eric Seidel  <eric@webkit.org>
1635
1636         No review, adding second email address for an existing committer.
1637
1638         Add Yong Li's second bugzilla account to his committer record.
1639         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1640
1641         * Scripts/modules/committers.py:
1642
1643 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1644
1645         Reviewed by Simon Hausmann.
1646
1647         If the frame has no innerText don't append it, and
1648         do not add a newline which breaks some cross platform
1649         results.
1650
1651         * DumpRenderTree/qt/DumpRenderTree.cpp:
1652         (WebCore::DumpRenderTree::dumpFramesAsText):
1653
1654 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1655
1656         Reviewed by Simon Hausmann.
1657
1658         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1659
1660         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1661         (webkit_test_plugin_new_instance):
1662         (webkit_test_plugin_destroy_instance):
1663         (webkit_test_plugin_destroy_stream):
1664
1665 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1666
1667         Reviewed by Mark Rowe.
1668
1669         Implement the functionality needed by plugins/window-open.html
1670
1671         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1672         (webkit_test_plugin_new_instance):
1673         (webkit_test_plugin_set_window):
1674
1675 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1676
1677         Reviewed by Simon Hausmann.
1678
1679         [Qt] Force -graphicssystem raster and -style windows when running DRT
1680
1681         * DumpRenderTree/qt/main.cpp:
1682         * Scripts/run-webkit-tests:
1683
1684 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1685
1686         Reviewed by Simon Hausmann.
1687
1688         Compute correct library paths for Qt
1689
1690         * Scripts/webkitdirs.pm:
1691
1692 2009-11-10  Mark Rowe  <mrowe@apple.com>
1693
1694         Reviewed by Sam Weinig.
1695
1696         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1697
1698         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1699         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1700         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1701         that had enabled frame load delegate logging this would result in extra log messages being generated,
1702         causing the test to fail.
1703
1704         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1705         tests.
1706
1707         * DumpRenderTree/mac/DumpRenderTree.mm:
1708         (dumpRenderTree):
1709         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1710         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1711
1712 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1713
1714         Reviewed by Kenneth Rohde Christiansen.
1715
1716         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1717
1718         * DumpRenderTree/qt/DumpRenderTree.cpp:
1719         (WebCore::DumpRenderTree::DumpRenderTree):
1720
1721 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1722
1723         Reviewed by Jan Alonzo.
1724
1725         [GTK] Remove WebSocket configuration from WebKitWebSettings
1726         https://bugs.webkit.org/show_bug.cgi?id=31244
1727
1728         Follow-up of r50724. Don't set the enable-web-socket property
1729         anymore.
1730
1731         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1732         (resetDefaultsToConsistentValues):
1733
1734 2009-11-10  Oliver Hunt  <oliver@apple.com>
1735
1736         Reviewed by Maciej Stachowiak.
1737
1738         Rename 3D Canvas related classes to use WebGL prefix
1739         https://bugs.webkit.org/show_bug.cgi?id=29095
1740
1741         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1742         and upate webkitdirs script to new method of testing for WebGL.
1743
1744         * Scripts/do-webcore-rename:
1745         * Scripts/webkitdirs.pm:
1746
1747 2009-11-09  Oliver Hunt  <oliver@apple.com>
1748
1749         Reviewed by Geoff Garen.
1750
1751         Make do-webcore-rename work with git.
1752
1753         * Scripts/do-webcore-rename:
1754
1755 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1756
1757         Adding Kenneth to the reviewers list.
1758
1759         * Scripts/modules/committers.py:
1760
1761 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1762
1763         Reviewed by Jan Alonzo.
1764
1765         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1766         https://bugs.webkit.org/show_bug.cgi?id=30482
1767
1768         LayoutTestControllerGtk now uses the exposed
1769         Page::tabKeyCyclesThroughElements API
1770
1771         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1772         (LayoutTestController::setTabKeyCyclesThroughElements):
1773
1774 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1775
1776         Reviewed by Holger Freyther.
1777
1778         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1779         This helps to pass the test case below. Also replaced hardcoded
1780         code numbers with defined constants.
1781         https://bugs.webkit.org/show_bug.cgi?id=31185
1782
1783         Test: editing/undo/undo-deleteWord.html
1784
1785         * DumpRenderTree/qt/EventSenderQt.cpp:
1786         (EventSender::keyDown):
1787
1788 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1789
1790         Reviewed by Holger Freyther.
1791
1792         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1793         https://bugs.webkit.org/show_bug.cgi?id=31164
1794
1795         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1796
1797         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1798         (LayoutTestController::processWork):
1799
1800 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1801
1802         Reviewed by Holger Freyther.
1803
1804         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1805         https://bugs.webkit.org/show_bug.cgi?id=31158
1806
1807         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1808         always, which from WorkQueue prospective means that a load has been started
1809         and the queue processing should stop and wait for the load to finish.
1810         Spinning it off into a loading and a non-loading variants was the solution
1811         adopted by Mac's DRT to work around this problem. The former keeps returning
1812         'true' while the later executes the script synchronously and returns 'false'
1813         making it possible to the WorkQueue to proceed right away.
1814
1815         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1816         (LayoutTestController::processWork):
1817         (LayoutTestController::queueLoadingScript):
1818         (LayoutTestController::queueNonLoadingScript):
1819         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1820         * DumpRenderTree/qt/WorkQueueItem.h:
1821         (LoadingScriptItem::LoadingScriptItem):
1822         (LoadingScriptItem::invoke):
1823         (NonLoadingScriptItem::NonLoadingScriptItem):
1824         (NonLoadingScriptItem::invoke):
1825
1826 2009-11-07  Mark Rowe  <mrowe@apple.com>
1827
1828         Rubber-stamped by Cameron Zwarich.
1829
1830         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1831
1832         * Scripts/commit-log-editor:
1833
1834 2009-11-07  Mark Rowe  <mrowe@apple.com>
1835
1836         Reviewed by Darin Adler.
1837
1838         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1839         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1840
1841         Move logic for determining the name and email address to use in a ChangeLog entry from
1842         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1843         whether the author of the patch matches committer, and therefore needs access to the
1844         email address that would be used in a ChangeLog entry.
1845
1846         Based on a patch by Pierre d'Herbemont.
1847
1848         * Scripts/VCSUtils.pm:
1849         * Scripts/commit-log-editor:
1850         * Scripts/prepare-ChangeLog:
1851         * Scripts/webkitdirs.pm:
1852
1853 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1854
1855         Reviewed by Adam Barth.
1856
1857         Added functionality to the layout test plugin to invoke document.open and
1858         window.open with default arguments. The associated webkit bug is
1859         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1860         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1861         work in Chromium (V8) if there is no calling javascript context. To achieve this
1862         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1863         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1864
1865         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1866         (testDocumentOpen):
1867         (testWindowOpen):
1868         (pluginAllocate):
1869         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1870         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1871         (NPP_New):
1872         (NPP_SetWindow):
1873         (NPP_DestroyStream):
1874         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1875         (NPP_New):
1876         (NPP_SetWindow):
1877         (NPP_NewStream):
1878         (NPP_DestroyStream):
1879
1880 2009-11-06  Eric Seidel  <eric@webkit.org>
1881
1882         Reviewed by Adam Barth.
1883
1884         bugzilla-tool crashed with exception
1885         https://bugs.webkit.org/show_bug.cgi?id=31092
1886
1887         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1888
1889 2009-11-04  Eric Seidel  <eric@webkit.org>
1890
1891         No review, just add a line which got left out of the patch uploaded for commit.
1892
1893         commit-queue is crashing when trying to reject patches after unknown failures
1894         https://bugs.webkit.org/show_bug.cgi?id=31091
1895
1896         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1897
1898 2009-11-04  Adam Roben  <aroben@apple.com>
1899
1900         Remove bogus else clause in bugzilla-tool
1901
1902         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1903         create-bug raises exception after entering bug description
1904
1905         Reviewed by David Kilzer.
1906
1907         * Scripts/bugzilla-tool:
1908         (CreateBug): else clauses are only hit if no exception is raised, so
1909         it makes no sense to try to re-raise the exception in an else clause.
1910         The exception will automatically be re-raised if it doesn't match any
1911         of the except clauses, so we don't have to do anything special here at
1912         all to get the desired behavior.
1913
1914 2009-11-04  Eric Seidel  <eric@webkit.org>
1915
1916         Reviewed by David Kilzer.
1917
1918         svn-apply's fixChangeLogPatch function seems broken
1919         https://bugs.webkit.org/show_bug.cgi?id=30683
1920
1921         Update fixChangeLogPatch to be able to handle patches which
1922         don't start at line 1.
1923         Add unit tests for svn-apply to scm_unittest.py.
1924
1925         * Scripts/VCSUtils.pm:
1926         * Scripts/modules/scm_unittest.py:
1927
1928 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1929
1930         Reviewed by Beth Dakin.
1931
1932         Need to implement ARIA role="combobox"
1933         https://bugs.webkit.org/show_bug.cgi?id=31096
1934
1935         * DumpRenderTree/AccessibilityUIElement.cpp:
1936         (showMenuCallback):
1937         (getIsExpandedCallback):
1938         (AccessibilityUIElement::getJSClass):
1939         * DumpRenderTree/AccessibilityUIElement.h:
1940         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1941         (AccessibilityUIElement::isExpanded):
1942         (AccessibilityUIElement::showMenu):
1943         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1944         (AccessibilityUIElement::isExpanded):
1945         (AccessibilityUIElement::showMenu):
1946         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1947         (AccessibilityUIElement::isSelected):
1948         (AccessibilityUIElement::isExpanded):
1949         (AccessibilityUIElement::showMenu):
1950
1951 2009-11-04  Eric Seidel  <eric@webkit.org>
1952
1953         Reviewed by Adam Barth.
1954
1955         commit-queue is crashing when trying to reject patches after unknown failures
1956         https://bugs.webkit.org/show_bug.cgi?id=31091
1957
1958         * Scripts/bugzilla-tool:
1959          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1960            so we have to find out what the current patch is by asking bugzilla again.
1961          - Discovered that this code was also leaking file descriptors, so fixed that.
1962
1963 2009-11-04  Adam Roben  <aroben@apple.com>
1964
1965         Make run-webkit-tests work for the Debug_Internal Windows
1966         configuration
1967
1968         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1969         suffix.
1970
1971         Fixes <http://webkit.org/b/31123>.
1972
1973         Reviewed by Sam Weinig.
1974
1975         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1976         Debug_Internal, either.
1977
1978 2009-11-04  Eric Seidel  <eric@webkit.org>
1979
1980         Reviewed by Adam Barth.
1981
1982         committers.py needs a way to store non-bugzilla email addresses
1983         https://bugs.webkit.org/show_bug.cgi?id=31037
1984
1985         Make Committer and Reviewer constructors take a single email or a list of emails.
1986         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1987         Expose reviewers(), used by validate-committer-lists on bug 30970.
1988
1989         * Scripts/modules/committers.py:
1990         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1991
1992 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1993
1994         Reviewed by David Levin.
1995
1996         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1997         https://bugs.webkit.org/show_bug.cgi?id=27491
1998
1999         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2000         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2001
2002         Functions to start or stop Web Socket servers are added.
2003
2004         * Scripts/run-webkit-tests:
2005
2006 2009-11-03  Eric Seidel  <eric@webkit.org>
2007
2008         No review, just changing wording of log message.
2009
2010         Change log string to say "failed" instead of "rejected"
2011         when a commit fails due to an out of date checkout.
2012         This makes grepping the commit-queue log for rejected patches easier.
2013
2014         * Scripts/bugzilla-tool:
2015
2016 2009-11-03  Eric Seidel  <eric@webkit.org>
2017
2018         No review, adding commonly known committers missing from the file.
2019
2020         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2021
2022 2009-11-03  Eric Seidel  <eric@webkit.org>
2023
2024         No review, just sort-order cleanup.
2025
2026         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2027
2028 2009-11-03  Stephen White  <senorblanco@chromium.org>
2029
2030         (Unreviewed).
2031
2032         Add myself to committers.py.
2033
2034         * Scripts/modules/committers.py:
2035
2036 2009-11-03  Robin Dunn  <robin@alldunn.com>
2037
2038         Reviewed by Kevin Ollviier.
2039
2040         Add packaging scripts for Debian-based Linux distros.
2041
2042         https://bugs.webkit.org/show_bug.cgi?id=31075
2043
2044         * wx/packaging/build-debian-installer.py: Added.
2045         * wx/packaging/debian: Added.
2046
2047 2009-11-03  Dan Bernstein  <mitz@apple.com>
2048
2049         Reviewed by Anders Carlsson and Beth Dakin.
2050
2051         https://bugs.webkit.org/show_bug.cgi?id=31070
2052
2053         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2054         destroyed, it executes the value of the 'ondestroy' parameter as a
2055         script.
2056
2057         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2058         (pluginAllocate): Initialize onDestroy.
2059         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2060         onDestroy.
2061         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2062         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2063         specified.
2064         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2065
2066 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2067
2068         Reviewed by Xan Lopez.
2069
2070         https://bugs.webkit.org/show_bug.cgi?id=31035
2071         [GTK] some accessibility tests hitting assertion in debug builds
2072
2073         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2074
2075         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2076         (AccessibilityController::rootElement):
2077
2078 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2079
2080         Reviewed by Beth Dakin.
2081
2082         Support ARIA "tab" roles
2083         https://bugs.webkit.org/show_bug.cgi?id=30842
2084
2085         * DumpRenderTree/AccessibilityUIElement.cpp:
2086         * DumpRenderTree/AccessibilityUIElement.h:
2087         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2088         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2089         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2090
2091 2009-11-01  Eric Seidel  <eric@webkit.org>
2092
2093         Reviewed by David Levin.
2094
2095         buildbots should use --exit-after-N-failures
2096         https://bugs.webkit.org/show_bug.cgi?id=30809
2097
2098         Make the bots exit after 20 failures to prevent never-ending
2099         test runs where every test spends a minute crashing.
2100
2101         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2102
2103 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2104
2105         Reviewed by Eric Seidel.
2106
2107         Turn on warnings for QtWebKit for gcc
2108         https://bugs.webkit.org/show_bug.cgi?id=30958
2109
2110         * DumpRenderTree/qt/main.cpp:
2111         (crashHandler): Mark function NO_RETURN
2112
2113 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2114
2115         Adding myself to the committers list.
2116
2117         * Scripts/modules/committers.py:
2118
2119 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2120
2121         Fix an issue that Adam noticed in DRT.
2122
2123         Reviewed by Darin Adler.
2124
2125         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2126         (AccessibilityUIElement::role):
2127         Get the length of the role text, and create a buffer dynamically.
2128
2129 2009-10-30  Eric Seidel  <eric@webkit.org>
2130
2131         No review, rolling out r50105.
2132         http://trac.webkit.org/changeset/50105
2133
2134         This commit was causing:
2135         https://bugs.webkit.org/show_bug.cgi?id=30869
2136         We'll re-implement the feature a different way.
2137
2138         * Scripts/bugzilla-tool:
2139
2140 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2141
2142         Test for MSAA: Accessibility of headings is not correct
2143
2144         https://bugs.webkit.org/show_bug.cgi?id=30937
2145
2146         Reviewed by Adam Roben.
2147
2148         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2149         (AccessibilityUIElement::role):
2150         Allow the role returned to be a BSTR.
2151         (AccessibilityUIElement::description):
2152         Fix a copy/paste error.
2153
2154 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2155
2156         Test for MSAA: Accessibility of links is wrong
2157
2158         https://bugs.webkit.org/show_bug.cgi?id=30928
2159
2160         Reviewed by Darin Adler.
2161
2162         * DumpRenderTree/AccessibilityUIElement.cpp:
2163         (getAccessibilityValueCallback):
2164         Return the accessibility value.
2165         (AccessibilityUIElement::getJSClass):
2166         Added "accessibilityValue" value.
2167
2168         * DumpRenderTree/AccessibilityUIElement.h:
2169
2170         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2171         (AccessibilityUIElement::accessibilityValue):
2172         Stubbed.
2173
2174         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2175         (AccessibilityUIElement::accessibilityValue):
2176         Stubbed.
2177
2178         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2179         (AccessibilityUIElement::accessibilityValue):
2180         Get the object's value, and return it as a JS string.
2181
2182 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2183
2184         Fix typo in command name used by wx build system.
2185
2186         * wx/build/build_utils.py:
2187
2188 2009-10-30  Adam Barth  <abarth@webkit.org>
2189
2190         Reviewed by Darin Adler.
2191
2192         Patch v1 is a dumb default name for patches
2193         https://bugs.webkit.org/show_bug.cgi?id=30952
2194
2195         Let's use "Patch" instead.
2196
2197         * Scripts/bugzilla-tool:
2198
2199 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2200
2201         Unreviewed trivial buildfix.
2202
2203         [Qt] Buildfix for r50333.
2204
2205         * DumpRenderTree/qt/DumpRenderTree.pro:
2206
2207 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2208
2209         Reviewed by Holger Freyther.
2210
2211         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2212         https://bugs.webkit.org/show_bug.cgi?id=30953
2213
2214         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2215         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2216         makes qt DRT to share this implementation (as gtk and mac ports do).
2217
2218         * DumpRenderTree/qt/DumpRenderTree.pro:
2219         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2220         * DumpRenderTree/qt/WorkQueue.h: Removed.
2221
2222 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2223
2224         Unreviewed potential buildbot fix.
2225
2226         Second try: Reset page history before running each test.
2227
2228         Apparently the QWebHistory::clear() keeps the current page
2229         in history which is not what we want, so we not additionally
2230         sets the history capacity to 0 (forces removing everything)
2231         and then sets it back to its original value.
2232
2233         * DumpRenderTree/qt/DumpRenderTree.cpp:
2234         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2235
2236 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2237
2238         Unreviewed potential buildbot fix.
2239
2240         Reset page history before running each test.
2241
2242         * DumpRenderTree/qt/DumpRenderTree.cpp:
2243         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2244
2245 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2246
2247         Reviewed by Eric Seidel.
2248
2249         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2250
2251         Bug 28420 -  Implement HTML5 <ruby> rendering
2252         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2253
2254         No new tests (no functional change).
2255
2256         * Scripts/build-webkit:
2257
2258 2009-10-29  Dan Bernstein  <mitz@apple.com>
2259
2260         Reviewed by Mark Rowe.
2261
2262         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2263         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2264         define it.
2265
2266         * Scripts/VCSUtils.pm:
2267         * Scripts/svn-apply:
2268         * Scripts/svn-unapply:
2269
2270 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2271
2272         Reviewed by Gustavo Noronha.
2273
2274         Use the GTK+ main loop instead of rolling our own mini-version of
2275         it.
2276
2277         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2278         (dump):
2279         (runTest):
2280         (webViewLoadFinished):
2281
2282 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2283
2284         Reviewed by Oliver Hunt.
2285
2286         Implement the Qt version of DRT dumpBackForwardList().
2287
2288         * DumpRenderTree/qt/DumpRenderTree.cpp:
2289         (WebCore::dumpHistoryItem):
2290         (WebCore::DumpRenderTree::dumpBackForwardList):
2291
2292 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2293
2294         Reviewed by Adam Roben.
2295
2296         Implement DRT functionality for Qt introduced in
2297         r28690 and r28705.
2298
2299         - Implemented pathToLocalResource which exposes the functionality of
2300         converting a given unix path to the correct location on Windows.
2301         - Implemented a way to remove machine-dependent information from paths
2302         in layout test results.
2303
2304         * DumpRenderTree/qt/DumpRenderTree.cpp:
2305         (WebCore::urlSuitableForTestResult):
2306         (WebCore::WebPage::javaScriptConsoleMessage):
2307         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2308         (LayoutTestController::pathToLocalResource):
2309         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2310
2311 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2312
2313         Adding myself to the committers list.
2314
2315         * Scripts/modules/committers.py:
2316
2317 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2318
2319         Adding myself to the committers list.
2320
2321         * Scripts/modules/committers.py:
2322
2323 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2324
2325         Reviewed by Jan Alonzo.
2326
2327         [GTK] API to start inspector for a WebView
2328         https://bugs.webkit.org/show_bug.cgi?id=22551
2329
2330         Use the new inspector API to implement the LayoutTestController
2331         interfaces used to test the inspector.
2332
2333         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2334         (webInspectorInspectWebView):
2335         (createWebView):
2336         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2337         (LayoutTestController::showWebInspector):
2338         (LayoutTestController::closeWebInspector):
2339         (LayoutTestController::evaluateInWebInspector):
2340
2341 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2342
2343         Reviewed by Eric Seidel.
2344
2345         [Qt] WebFrame::counterValueForElementById must not be exposed
2346         https://bugs.webkit.org/show_bug.cgi?id=30882
2347
2348         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2349         (LayoutTestController::counterValueForElementById):
2350
2351 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2352
2353         Rubberstamped by Oliver Hunt.
2354
2355         Fix the warning:
2356
2357         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2358         declared with attribute warn_unused_result".
2359
2360         by actually checking the result. In the case it is null, an
2361         error has occoured, so treat it as the other fatal errors.
2362
2363         * DumpRenderTree/qt/DumpRenderTree.cpp:
2364         (WebCore::DumpRenderTree::initializeFonts):
2365
2366 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2367
2368         Reviewed by Darin Adler.
2369
2370         Provide a way to get counter values with layoutTestContoller
2371         https://bugs.webkit.org/show_bug.cgi?id=30555
2372
2373         Define layoutTestContoller.counterValueForElementById.
2374
2375         * DumpRenderTree/LayoutTestController.cpp:
2376         (counterValueForElementByIdCallback):
2377         (LayoutTestController::staticFunctions):
2378         * DumpRenderTree/LayoutTestController.h:
2379         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2380         (LayoutTestController::counterValueForElementById):
2381
2382 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2383
2384         Rubberstamped by Oliver Hunt.
2385
2386         Change two methods to be internal for DRT use only.
2387
2388         Part of [Qt] Review all new API in Qt 4.6
2389         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2390
2391         * DumpRenderTree/qt/DumpRenderTree.cpp:
2392         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2393         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2394         (LayoutTestController::whiteListAccessFromOrigin):
2395
2396 2009-10-27  Eric Seidel  <eric@webkit.org>
2397
2398         Reviewed by Adam Barth.
2399
2400         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2401         https://bugs.webkit.org/show_bug.cgi?id=30826
2402
2403         * Scripts/svn-apply:
2404          - Add () around all system() calls.
2405          - Use the correct system() == 0 or die instead of system() or die
2406          - Add descriptive messages to all die statements.
2407
2408 2009-10-27  Steve Block  <steveblock@google.com>
2409
2410         Reviewed by NOBODY.
2411
2412         Adds steveblock@google.com to list of committers.
2413
2414         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2415
2416 2009-10-27  Eric Seidel  <eric@webkit.org>
2417
2418         Reviewed by Adam Barth.
2419
2420         svn-apply can exit(0) even on patch failure
2421         https://bugs.webkit.org/show_bug.cgi?id=29622
2422
2423         * Scripts/svn-apply:
2424          - Add a bunch of "or die" statements, hopefully catching all
2425            possible cases where failure could still exit(0).
2426
2427 2009-10-27  Eric Seidel  <eric@webkit.org>
2428
2429         Reviewed by Adam Barth.
2430
2431         svn-* scripts should share code through VCSUtils.pm
2432         https://bugs.webkit.org/show_bug.cgi?id=30791
2433
2434         Just moving code into a shared location.
2435
2436         * Scripts/VCSUtils.pm:
2437         * Scripts/prepare-ChangeLog:
2438         * Scripts/resolve-ChangeLogs:
2439         * Scripts/svn-apply:
2440         * Scripts/svn-create-patch:
2441         * Scripts/svn-unapply:
2442         * Scripts/update-webkit:
2443
2444 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2445
2446         Suppress a huge number of MSVC warnings when building wxWebKit.
2447
2448         * wx/build/settings.py:
2449
2450 2009-10-26  Eric Seidel  <eric@webkit.org>
2451
2452         No review, just adding Mike Belshe to the committers list.
2453
2454         * Scripts/modules/committers.py:
2455
2456 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2457
2458         Reviewed by Darin Adler.
2459
2460         Make .rc files compile on Windows without depending on MFC headers
2461         https://bugs.webkit.org/show_bug.cgi?id=30750
2462
2463         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2464         windows.h instead of afxres.h because it exists even when MFC is not
2465         installed, and is all that's needed here.
2466
2467         * FindSafari/FindSafari.rc: Ditto
2468
2469 2009-10-24  Eric Seidel  <eric@webkit.org>
2470
2471         Reviewed by Adam Barth.
2472
2473         bugzilla-tool post-diff should know how to mark commit-queue=?
2474         https://bugs.webkit.org/show_bug.cgi?id=29202
2475
2476         * Scripts/bugzilla-tool:
2477          - Add --commit-queue option to post-diff, post-commits and create-bug.
2478         * Scripts/modules/bugzilla.py:
2479          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2480          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2481
2482 2009-10-23  Eric Seidel  <eric@webkit.org>
2483
2484         Reviewed by Adam Barth.
2485
2486         bugzilla-tool commit-queue does not notice modifications to committers.py
2487         https://bugs.webkit.org/show_bug.cgi?id=30084
2488
2489         * Scripts/bugzilla-tool:
2490          - Make commit-queue re-exec itself instead of using while(1).
2491          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2492          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2493
2494 2009-10-22  Eric Seidel  <eric@webkit.org>
2495
2496         Reviewed by Adam Barth.
2497
2498         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2499         https://bugs.webkit.org/show_bug.cgi?id=30634
2500
2501         * Scripts/bugzilla-tool:
2502          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2503          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2504
2505 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2506
2507         Reviewed by Eric Seidel.
2508
2509         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2510
2511         https://bugs.webkit.org/show_bug.cgi?id=30763
2512
2513         * pywebsocket/mod_pywebsocket/__init__.py:
2514         * pywebsocket/mod_pywebsocket/dispatch.py:
2515         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2516         * pywebsocket/mod_pywebsocket/standalone.py:
2517         * pywebsocket/setup.py:
2518         * pywebsocket/test/test_dispatch.py:
2519
2520 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2521
2522         Reviewed by David Levin.
2523
2524         REGRESSION: 2 failures in run-webkit-unittests
2525         https://bugs.webkit.org/show_bug.cgi?id=30645
2526
2527         * Scripts/modules/cpp_style_unittest.py:
2528         Fixed a few test scenarios which apparently lost some spaces from
2529         text literals.
2530
2531 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2532
2533         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2534
2535         * Scripts/webkitdirs.pm:
2536
2537 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2538
2539         Reviewed by Darin Adler.
2540
2541         Unification of using null device in perl scripts.
2542         https://bugs.webkit.org/show_bug.cgi?id=30572
2543
2544         * Scripts/VCSUtils.pm:
2545         * Scripts/bisect-builds:
2546         * Scripts/resolve-ChangeLogs:
2547         * Scripts/run-iexploder-tests:
2548         * Scripts/run-jsc:
2549         * Scripts/run-mangleme-tests:
2550         * Scripts/run-webkit-tests:
2551         * Scripts/webkitdirs.pm:
2552         Using File::Spec->devnull() instead of hard coded /dev/null.
2553
2554 2009-10-26  Eric Seidel  <eric@webkit.org>
2555
2556         Reviewed by Holger Freyther.
2557
2558         Reviewers are missing from committers.py
2559         https://bugs.webkit.org/show_bug.cgi?id=30733
2560
2561         * Scripts/modules/committers.py:
2562
2563 2009-10-23  Eric Seidel  <eric@webkit.org>
2564
2565         No review, only adding Alice to the list of reviewers.
2566
2567         * Scripts/modules/committers.py:
2568
2569 2009-10-23  Eric Seidel  <eric@webkit.org>
2570
2571         Reviewed by Eric Carlson.
2572
2573         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2574         https://bugs.webkit.org/show_bug.cgi?id=30700
2575
2576         * DumpRenderTree/mac/DumpRenderTree.mm:
2577         (resetDefaultsToConsistentValues): Update QuickTime version check.
2578
2579 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2580
2581         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2582         character measurement APIs that are private on Tiger.
2583
2584         * wx/build/settings.py:
2585
2586 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2587
2588         Reviewed by NOBODY (build fix).
2589         Build fix following bug #30696.
2590
2591         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2592         (LayoutTestController::evaluateScriptInIsolatedWorld):
2593
2594 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2595
2596         Reviewed by Sam Weinig & Geoff Garen.
2597
2598         https://bugs.webkit.org/show_bug.cgi?id=30696
2599         Enable isolated-worlds tests on mac.
2600
2601         Add private interface for DRT to invoke execution in a given world.
2602
2603         * DumpRenderTree/LayoutTestController.cpp:
2604         (evaluateScriptInIsolatedWorldCallback):
2605         (LayoutTestController::staticFunctions):
2606         * DumpRenderTree/LayoutTestController.h:
2607         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2608         (LayoutTestController::evaluateScriptInIsolatedWorld):
2609         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2610         (LayoutTestController::evaluateScriptInIsolatedWorld):
2611
2612 2009-10-21  Eric Seidel  <eric@webkit.org>
2613
2614         Reviewed by Adam Barth.
2615
2616         bugzilla-tool's "patch failed to download an apply" error should give more information
2617         https://bugs.webkit.org/show_bug.cgi?id=30632
2618
2619         * Scripts/modules/scm.py:
2620          - Use the common run_command method instead of custom POpen code.
2621          - Make run_command know how to take pipes as input.
2622         * Scripts/modules/scm_unittest.py:
2623          - Add new tests to cover change.
2624          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2625
2626 2009-10-21  Kent Tamura  <tkent@chromium.org>
2627
2628         Unreviewed.  Adding myself to the committers list.
2629
2630         * Scripts/modules/committers.py:
2631
2632 2009-10-21  Robin Dunn  <robin@alldunn.com>
2633
2634         Reviewed by Kevin Ollivier.
2635
2636         Update the Windows installer builder to work with Vista / Win 7 and with git.
2637
2638         https://bugs.webkit.org/show_bug.cgi?id=30649
2639
2640         * wx/build/build_utils.py:
2641         * wx/packaging/build-mac-installer.py:
2642         * wx/packaging/build-win-installer.py:
2643         * wx/packaging/wxWebKitInstaller.iss.in:
2644
2645 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2646
2647         Reviewed by Gustavo Noronha.
2648
2649         [GTK] Added conditional code to avoid using
2650         gdk_window_get_root_coords if we do not have a gtk+ release newer
2651         than 2.17.3.
2652         https://bugs.webkit.org/show_bug.cgi?id=30636
2653
2654         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2655
2656 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2657
2658         Reviewed by Eric Seidel.
2659
2660         [Qt] Added dummy implementation for keepWebHistory()
2661         https://bugs.webkit.org/show_bug.cgi?id=30592
2662
2663         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2664         (LayoutTestController::keepWebHistory):
2665         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2666
2667 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2668
2669         Reviewed by Xan Lopez.
2670
2671         [GTK] Fixed the double click condition, it is not double click if
2672         we move in just in one direction.
2673         https://bugs.webkit.org/show_bug.cgi?id=30636
2674
2675         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2676
2677 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2678
2679         Reviewed by Xan Lopez.
2680
2681         [GTK] Initialize the events completly before emitting them.
2682         https://bugs.webkit.org/show_bug.cgi?id=30633
2683
2684         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2685
2686 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2687
2688         wx build fix. Fix for when linking using --as-needed with gcc.
2689
2690         * wx/browser/wscript:
2691
2692 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2693
2694         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2695         to support all the features used by CURL backend.
2696
2697         * wx/build/settings.py:
2698         * wx/install-unix-extras:
2699
2700 2009-10-20  Anton Muhin  <antonm@chromium.org>
2701
2702         Reviewed by Adam Barth.
2703
2704         Add {ager,antonm,yurys}@chromium.org into committers.py
2705         https://bugs.webkit.org/show_bug.cgi?id=30560
2706
2707         * Scripts/modules/committers.py:
2708
2709 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2710
2711         Reviewed by Tor Arne Vestbø.
2712
2713         Make the Netscape Test plugin available to the Qt launcher.
2714
2715         * Scripts/run-launcher:
2716
2717 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2718
2719         Reviewed by David Levin.
2720
2721         Removed WebSocket runtime settings.
2722         https://bugs.webkit.org/show_bug.cgi?id=29896
2723
2724         WebSocket runtime configuration is supported by chromium/v8 only.
2725
2726         * DumpRenderTree/mac/DumpRenderTree.mm:
2727         (resetDefaultsToConsistentValues):
2728         * DumpRenderTree/win/DumpRenderTree.cpp:
2729         (resetDefaultsToConsistentValues):
2730
2731 2009-10-19  Nate Chapin  <japhet@chromium.org>
2732
2733         Reviewed by Adam Barth.
2734
2735         Add testFail() to test plugin so we can test our handling of a
2736         plugin invoke call returning false.
2737
2738         https://bugs.webkit.org/show_bug.cgi?id=30239
2739
2740         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2741         (pluginInvoke):
2742         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2743
2744 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2745
2746         Reviewed by Gustavo Noronha.
2747
2748         Enable DOM pasting when running layout tests.
2749
2750         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2751         (resetDefaultsToConsistentValues):
2752
2753 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2754
2755         Reviewed by Simon Hausmann.
2756
2757         Use the setPreferredContentsSize method instead
2758         of setFixedContentsSize, as the method has been renamed.
2759
2760         * DumpRenderTree/qt/DumpRenderTree.cpp:
2761         (WebCore::DumpRenderTree::open):
2762         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2763         (LayoutTestController::setFixedContentsSize):
2764
2765 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2766
2767         Reviewed by Dan Bernstein.
2768
2769         https://bugs.webkit.org/show_bug.cgi?id=30456
2770         Fixes for new Debug_All Windows build configuration.
2771
2772         * DumpRenderTree/win/DumpRenderTree.cpp:
2773         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2774         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2775
2776 2009-10-16  Eric Seidel  <eric@webkit.org>
2777
2778         Reviewed by Adam Barth.
2779
2780         commit-queue status bot should list which buildbot is blocking the queue
2781         https://bugs.webkit.org/show_bug.cgi?id=30452
2782
2783         Add new methods and testing.
2784
2785         * Scripts/bugzilla-tool:
2786         * Scripts/modules/buildbot.py:
2787         * Scripts/modules/buildbot_unittest.py:
2788
2789 2009-10-16  Eric Seidel  <eric@webkit.org>
2790
2791         Reviewed by Adam Barth.
2792
2793         run-webkit-tests fails when CWD is not inside a WebKit checkout
2794         https://bugs.webkit.org/show_bug.cgi?id=30451
2795
2796         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2797         * Scripts/modules/scm_unittest.py:
2798           - Remove use of original_path (we don't need to restore the CWD).
2799           - Don't use '.' to find the webkit checkout, use __file__ instead.
2800
2801 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2802
2803         Reviewed by Adam Roben.
2804
2805         Add a Debug_All configuration to build entire stack as debug.
2806         Change Debug_Internal to:
2807         - stop using _debug suffix for all WebKit/Safari binaries
2808         - not use _debug as a DLL naming suffix
2809         - use non-debug C runtime lib.
2810
2811         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2812         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2813         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2814         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2815         Add missing debug.vsprops inherited property sheet.
2816         Add Debug_All configuration.
2817         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2818         * WinLauncher/WinLauncher.vcproj:
2819         Removed extraneous definitions inherited from vsprops.
2820         Add Debug_All configuration.
2821
2822 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2823
2824         Reviewed by David Levin.
2825
2826         check-webkit-style is wrong about indent checking in namespaces
2827         in header files and a few other things
2828         https://bugs.webkit.org/show_bug.cgi?id=30362
2829
2830         The few other things include:
2831         + check-webkit-style does not require spaces around the equal sign
2832           inside 'if' statements and around binary operators that take
2833           numeric literals.
2834         + check-webkit-style reports false errors for the / operator
2835           when part of a filename in the #include directive.
2836
2837         * Scripts/modules/cpp_style.py:
2838         Improved indentation checking and space checking around
2839         binary operators. While the checks are still not perfect,
2840         they are clearly better than before.
2841         * Scripts/modules/cpp_style_unittest.py:
2842         Added test cases for the newly supported checks and modified old
2843         test cases to match the new guidelines
2844
2845 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2846
2847         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2848
2849         * wx/build/settings.py:
2850
2851 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2852
2853         Reviewed by David Levin.
2854
2855         Add mod_pywebsocket to test Web Sockets.
2856         http://code.google.com/p/pywebsocket/
2857         https://bugs.webkit.org/show_bug.cgi?id=27490
2858
2859         * pywebsocket/COPYING: Added.
2860         * pywebsocket/MANIFEST.in: Added.
2861         * pywebsocket/README: Added.
2862         * pywebsocket/example/echo_client.py: Added.
2863         * pywebsocket/example/echo_wsh.py: Added.
2864         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2865         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2866         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2867         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2868         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2869         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2870         * pywebsocket/mod_pywebsocket/util.py: Added.
2871         * pywebsocket/setup.py: Added.
2872         * pywebsocket/test/config.py: Added.
2873         * pywebsocket/test/mock.py: Added.
2874         * pywebsocket/test/run_all.py: Added.
2875         * pywebsocket/test/test_dispatch.py: Added.
2876         * pywebsocket/test/test_handshake.py: Added.
2877         * pywebsocket/test/test_mock.py: Added.
2878         * pywebsocket/test/test_msgutil.py: Added.
2879         * pywebsocket/test/test_util.py: Added.
2880         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2881         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2882         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2883         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2884         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2885         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2886         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2887         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2888
2889 2009-10-15  James Robinson  <jamesr@google.com>
2890
2891         Reviewed by David Levin.
2892
2893         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2894
2895         https://bugs.webkit.org/show_bug.cgi?id=30426
2896
2897         * Scripts/modules/cpp_style.py:
2898         * Scripts/modules/cpp_style_unittest.py:
2899
2900 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2901
2902         Reviewed by Adam Roben.
2903
2904         Fixes <http://webkit.org/b/30411>.
2905         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2906
2907         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2908         building Chromium.
2909
2910         * Scripts/pdevenv:
2911
2912 2009-10-15  Robin Dunn  <robin@alldunn.com>
2913
2914         Reviewed by Kevin Ollivier.
2915
2916         Add Mac package building scripts for wx.
2917
2918         https://bugs.webkit.org/show_bug.cgi?id=30405
2919
2920         * wx/build/build_utils.py:
2921         * wx/build/settings.py:
2922         * wx/packaging/build-mac-installer.py: Added.
2923
2924 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2925
2926         Reviewed by Gustavo Noronha.
2927
2928         Enable Web Sockets support when running layout tests.
2929
2930         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2931         (resetDefaultsToConsistentValues):
2932
2933 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2934
2935         Reviewed by Gustavo Noronha.
2936
2937         Need to initialize event.button.button, since in most cases a
2938         button number is not passed as an argument.
2939
2940         * DumpRenderTree/gtk/EventSender.cpp:
2941         (mouseDownCallback):
2942         (mouseUpCallback):
2943
2944 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2945
2946         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2947         the OS if none was explicitly set.
2948
2949         * wx/build/settings.py:
2950
2951 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2952
2953         Reviewed by Timothy Hatcher.
2954
2955         Web Inspector: enable developers extras within inspector layout tests.
2956
2957         https://bugs.webkit.org/show_bug.cgi?id=30014
2958
2959         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2960         (LayoutTestController::showWebInspector):
2961         (LayoutTestController::closeWebInspector):
2962         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2963         (LayoutTestController::showWebInspector):
2964         (LayoutTestController::closeWebInspector):
2965
2966 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2967
2968         Reviewed by Jan Alonzo.
2969
2970         GtkLauncher is using a deprecated signal
2971         https://bugs.webkit.org/show_bug.cgi?id=30364
2972
2973         Modified GtkLauncher to use notify::title signal instead of
2974         deprecated title-changed signal
2975
2976         * GtkLauncher/main.c:
2977         (notify_title_cb):
2978         (create_browser):
2979
2980 2009-10-14  Brady Eidson  <beidson@apple.com>
2981
2982         Reviewed by Sam Weinig.
2983
2984         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2985         1 - Disables WebHistory
2986         2 - Doesn't make sense in that context anyway.
2987
2988         * DumpRenderTree/win/DumpRenderTree.cpp:
2989         (createWebViewAndOffscreenWindow):
2990
2991 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2992
2993         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2994         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2995
2996         * wx/build/settings.py:
2997         * wx/install-unix-extras:
2998
2999 2009-10-14  Brady Eidson  <beidson@apple.com>
3000
3001         Reviewed by Sam Weinig.
3002
3003         WebKit Win API should provide a delegate interface for global history.
3004         https://bugs.webkit.org/show_bug.cgi?id=29905
3005
3006         * DumpRenderTree/LayoutTestController.cpp:
3007         (LayoutTestController::LayoutTestController):
3008         * DumpRenderTree/LayoutTestController.h:
3009         (LayoutTestController::dumpHistoryDelegateCallbacks):
3010         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3011
3012         * DumpRenderTree/win/DumpRenderTree.cpp:
3013         (shouldLogHistoryDelegates):
3014         (runTest):
3015         (createWebViewAndOffscreenWindow):
3016         (main):
3017         * DumpRenderTree/win/DumpRenderTree.vcproj:
3018
3019         Add the IWebHistoryDelegate to DRT Windows:
3020         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3021         (wstringFromBSTR):
3022         (HistoryDelegate::HistoryDelegate):
3023         (HistoryDelegate::~HistoryDelegate):
3024         (HistoryDelegate::QueryInterface):
3025         (HistoryDelegate::AddRef):
3026         (HistoryDelegate::Release):
3027         (HistoryDelegate::didNavigateWithNavigationData):
3028         (HistoryDelegate::didPerformClientRedirectFromURL):
3029         (HistoryDelegate::didPerformServerRedirectFromURL):
3030         (HistoryDelegate::updateHistoryTitle):
3031         (HistoryDelegate::populateVisitedLinksForWebView):
3032         * DumpRenderTree/win/HistoryDelegate.h: Added.
3033
3034         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3035         (LayoutTestController::removeAllVisitedLinks):
3036
3037 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3038
3039         Reviewed by Simon Hausmann.
3040
3041         [Qt] Implement support for setPOSIXLocale on Qt.
3042         https://bugs.webkit.org/show_bug.cgi?id=30268
3043
3044         * DumpRenderTree/qt/DumpRenderTree.cpp:
3045         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3046         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3047         (LayoutTestController::setPOSIXLocale):
3048         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3049
3050 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3051
3052         Unreviewed, adding myself to reviewers list.
3053
3054         * Scripts/modules/committers.py:
3055
3056 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3057
3058         Reviewed by Mark Rowe.
3059
3060         Fix null assignment so root tests work again.
3061
3062         * Scripts/webkitdirs.pm:
3063
3064 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3065
3066         Reviewed by Simon Hausmann.
3067
3068         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3069         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3070         This is done in preparation of implementing missing features in DRT.
3071         No functionality changes made yet.
3072
3073         * DumpRenderTree/qt/DumpRenderTree.cpp:
3074         * DumpRenderTree/qt/DumpRenderTree.pro:
3075         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3076         (EventSender::EventSender):
3077         (EventSender::mouseDown):
3078         (EventSender::mouseUp):
3079         (EventSender::mouseMoveTo):
3080         (EventSender::leapForward):
3081         (EventSender::keyDown):
3082         (EventSender::contextClick):
3083         (EventSender::scheduleAsynchronousClick):
3084         (EventSender::frameUnderMouse):
3085         * DumpRenderTree/qt/EventSenderQt.h: Added.
3086         (EventSender::clearKillRing):
3087         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3088         (LayoutTestController::LayoutTestController):
3089         (LayoutTestController::reset):
3090         (LayoutTestController::processWork):
3091         (LayoutTestController::maybeDump):
3092         (LayoutTestController::waitUntilDone):
3093         (LayoutTestController::notifyDone):
3094         (LayoutTestController::windowCount):
3095         (LayoutTestController::clearBackForwardList):
3096         (LayoutTestController::dumpEditingCallbacks):
3097         (LayoutTestController::dumpResourceLoadCallbacks):
3098         (LayoutTestController::queueBackNavigation):
3099         (LayoutTestController::queueForwardNavigation):
3100         (LayoutTestController::queueLoad):
3101         (LayoutTestController::queueReload):
3102         (LayoutTestController::queueScript):
3103         (LayoutTestController::provisionalLoad):
3104         (LayoutTestController::timerEvent):
3105         (LayoutTestController::encodeHostName):
3106         (LayoutTestController::decodeHostName):
3107         (LayoutTestController::setJavaScriptProfilingEnabled):
3108         (LayoutTestController::setFixedContentsSize):
3109         (LayoutTestController::setPrivateBrowsingEnabled):
3110         (LayoutTestController::setPopupBlockingEnabled):
3111         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3112         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3113         (LayoutTestController::numberOfActiveAnimations):
3114         (LayoutTestController::disableImageLoading):
3115         (LayoutTestController::dispatchPendingLoadRequests):
3116         (LayoutTestController::setDatabaseQuota):
3117         (LayoutTestController::clearAllDatabases):
3118         (LayoutTestController::whiteListAccessFromOrigin):
3119         (LayoutTestController::waitForPolicyDelegate):
3120         (LayoutTestController::overridePreference):
3121         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3122         (LayoutTestController::isLoading):
3123         (LayoutTestController::setLoading):
3124         (LayoutTestController::shouldDumpAsText):
3125         (LayoutTestController::shouldDumpBackForwardList):
3126         (LayoutTestController::shouldDumpChildrenAsText):
3127         (LayoutTestController::shouldDumpDatabaseCallbacks):
3128         (LayoutTestController::shouldDumpStatusCallbacks):
3129         (LayoutTestController::shouldWaitUntilDone):
3130         (LayoutTestController::canOpenWindows):
3131         (LayoutTestController::shouldDumpTitleChanges):
3132         (LayoutTestController::waitForPolicy):
3133         (LayoutTestController::dumpAsText):
3134         (LayoutTestController::dumpChildFramesAsText):
3135         (LayoutTestController::dumpDatabaseCallbacks):
3136         (LayoutTestController::dumpStatusCallbacks):
3137         (LayoutTestController::setCanOpenWindows):
3138         (LayoutTestController::dumpBackForwardList):
3139         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3140         (LayoutTestController::display):
3141         (LayoutTestController::dumpTitleChanges):
3142         (LayoutTestController::dumpSelectionRect):
3143         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3144         (TextInputController::TextInputController):
3145         (TextInputController::doCommand):
3146         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3147         * DumpRenderTree/qt/WorkQueue.cpp:
3148         * DumpRenderTree/qt/WorkQueue.h:
3149         * DumpRenderTree/qt/WorkQueueItem.h:
3150         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3151         (findFrameNamed):
3152         (LoadItem::invoke):
3153         (ReloadItem::invoke):
3154         (ScriptItem::invoke):
3155         (BackForwardItem::invoke):
3156         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3157         * DumpRenderTree/qt/jsobjects.h:
3158
3159 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3160
3161         Not reviewed, adding myself to the list of reviewers.
3162
3163         * Scripts/modules/committers.py:
3164
3165 2009-10-13  Anders Carlsson  <andersca@apple.com>
3166
3167         Reviewed by Sam Weinig.
3168
3169         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3170
3171         Make the private browsing mode testable by the test plug-in.
3172
3173         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3174         (pluginGetProperty):
3175         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3176         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3177         (NPP_New):
3178         (NPP_SetValue):
3179
3180 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3181
3182         No review, just adding self to the list of reviewers.
3183
3184         * Scripts/modules/committers.py:
3185
3186 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3187
3188         Reviewed by Adam Roben.
3189
3190         Web Inspector: Use proper web view in inspector layout
3191         tests for windows.
3192
3193         https://bugs.webkit.org/show_bug.cgi?id=30298
3194
3195         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3196         (LayoutTestController::showWebInspector):
3197         (LayoutTestController::closeWebInspector):
3198         (LayoutTestController::evaluateInWebInspector):
3199
3200 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3201
3202         Reviewed by Sam Weinig.
3203
3204         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3205         https://bugs.webkit.org/show_bug.cgi?id=29841
3206
3207         * DumpRenderTree/mac/DumpRenderTree.mm:
3208         (resetDefaultsToConsistentValues):
3209         * DumpRenderTree/win/DumpRenderTree.cpp:
3210         (resetDefaultsToConsistentValues):
3211
3212 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3213
3214         Reviewed by Dimitri Glazkov.
3215
3216         Chromium Port - Windows
3217         https://bugs.webkit.org/show_bug.cgi?id=29969
3218
3219         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3220         * Scripts/webkitdirs.pm:
3221
3222 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3223
3224         Reviewed by Darin Adler.
3225
3226         jsc scripts cleanup and Qt/GTK fix
3227         https://bugs.webkit.org/show_bug.cgi?id=30288
3228
3229         Duplicated jscPath() moved to webkitdirs.pm.
3230         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3231         Configuration added (release/debug) to path for Qt-port on Windows.
3232
3233         * Scripts/run-javascriptcore-tests:
3234         * Scripts/run-jsc:
3235         * Scripts/run-sunspider:
3236         * Scripts/sunspider-compare-results:
3237         * Scripts/webkitdirs.pm:
3238
3239 2009-10-11  Adam Barth  <abarth@webkit.org>
3240
3241         Unreviewed.  Add Collin to committers.py.
3242
3243         * Scripts/modules/committers.py:
3244
3245 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3246
3247         wx build fix, add bindings to source/include dirs now that there are sources there.
3248
3249         * wx/build/settings.py:
3250
3251 2009-10-09  Mark Rowe  <mrowe@apple.com>
3252
3253         Reviewed by Brady Eidson.
3254
3255         Enable plug-in halting in DumpRenderTree.
3256
3257         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3258         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3259
3260         * DumpRenderTree/mac/DumpRenderTree.mm:
3261         (resetDefaultsToConsistentValues):
3262         * DumpRenderTree/mac/UIDelegate.mm:
3263         (-[UIDelegate webView:shouldHaltPlugin:]):
3264
3265 2009-10-08  Brady Eidson  <beidson@apple.com>
3266
3267         Reviewed by Dan Bernstein.
3268
3269         Ask the History Delegate to populate the visited links hash.
3270         <rdar://problem/7285293> and https://webkit.org/b/29904
3271
3272         Add the ability for LayoutTestController to clear all visited links.
3273         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3274
3275         * DumpRenderTree/LayoutTestController.cpp:
3276         (LayoutTestController::LayoutTestController):
3277         (removeAllVisitedLinksCallback):
3278         (LayoutTestController::staticFunctions):
3279         * DumpRenderTree/LayoutTestController.h:
3280         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3281         (LayoutTestController::removeAllVisitedLinks):
3282
3283         * DumpRenderTree/mac/HistoryDelegate.mm:
3284         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3285
3286         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3287         (LayoutTestController::removeAllVisitedLinks):
3288         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3289         (LayoutTestController::removeAllVisitedLinks):
3290         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3291         (LayoutTestController::removeAllVisitedLinks):
3292
3293
3294 2009-10-08  Daniel Bates  <dbates@webkit.org>
3295
3296         Reviewed by Adam Roben.
3297
3298         https://bugs.webkit.org/show_bug.cgi?id=30175
3299
3300         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3301         the OLE drag-and-drop return value like the function it emulates. Currently,
3302         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3303         whether the drag-and-drop operation was successful or was cancelled.
3304
3305         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3306         return value according to whether the drop operation was successful or not.
3307
3308         * DumpRenderTree/win/EventSender.cpp:
3309         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3310         (replaySavedEvents): Ditto.
3311         * DumpRenderTree/win/EventSender.h:
3312         * DumpRenderTree/win/UIDelegate.cpp:
3313         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3314
3315 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3316
3317         Reviewed by Xan Lopez.
3318
3319         [GTK] Added support for a parameter setting the button that was
3320         pressed in the mouseDown function.
3321         https://bugs.webkit.org/show_bug.cgi?id=30220
3322
3323         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3324
3325 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3326
3327         Reviewed by Xan Lopez.
3328
3329         [GTK] Added a line to the bottom of the expected result to match
3330         the output of the test.
3331         https://bugs.webkit.org/show_bug.cgi?id=30220
3332
3333         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3334         expected.txt:
3335
3336 2009-10-08  Adam Roben  <aroben@apple.com>
3337
3338         Use QueryInterface to get IWebInspectorPrivate
3339
3340         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3341         accessed in a more standard way
3342
3343         Reviewed by John Sullivan and Tim Hatcher.
3344
3345         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3346         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3347         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3348         to the IWebInspectorPrivate interface.
3349
3350 2009-10-07  Adam Roben  <aroben@apple.com>
3351
3352         Implement DRT support for origin whitelisting
3353
3354         Fixes <http://webkit.org/b/30185>.
3355
3356         Reviewed by Eric Seidel.
3357
3358         * DumpRenderTree/win/DumpRenderTree.cpp:
3359         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3360         whitelist, to match Mac DRT.
3361         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3362         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3363         IWebViewPrivate::whiteListAccessFromOrigin.
3364
3365 2009-10-07  Brady Eidson  <beidson@apple.com>
3366
3367         Reviewed by Darin Adler.
3368
3369         Send title changes to the global history delegate.
3370         <rdar://problem/7285293> and https://webkit.org/b/29904
3371
3372         * DumpRenderTree/mac/HistoryDelegate.mm:
3373         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3374
3375 2009-10-07  Adam Barth  <abarth@webkit.org>
3376
3377         Unreviewed.  Remove some folks from committers.py who were listed on
3378         the WebKit Team wiki page but who weren't actually listed as commit+.
3379         At some point, we should coorelate this list with the committers
3380         mailing list.
3381
3382         * Scripts/modules/committers.py:
3383
3384 2009-10-07  Adam Barth  <abarth@webkit.org>
3385
3386         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3387         the wiki into committers.py.
3388
3389         * Scripts/modules/committers.py:
3390
3391 2009-10-07  Adam Barth  <abarth@webkit.org>
3392
3393         Unreviewed.  Added Aaron Boodman to committers.py.
3394
3395         * Scripts/modules/committers.py:
3396
3397 2009-10-07  Evan Martin  <evan@chromium.org>
3398
3399         Reviewed by Darin Adler.
3400
3401         Add API to LayoutTestController for re/setting the system locale.
3402         https://bugs.webkit.org/show_bug.cgi?id=18994
3403
3404         * DumpRenderTree/LayoutTestController.cpp:
3405         (setLocaleCallback):
3406         (LayoutTestController::staticFunctions):
3407         (LayoutTestController::setLocale):
3408         * DumpRenderTree/LayoutTestController.h:
3409
3410 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3411
3412         Reviewed by Jan Alonzo.
3413
3414         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3415         https://bugs.webkit.org/show_bug.cgi?id=29689
3416
3417         Build fix by adding -lfontconfig for DumpRenderTree.
3418
3419         * GNUmakefile.am:
3420
3421 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3422
3423         Reviewed by Simon Hausmann.
3424
3425         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3426
3427         * Scripts/run-webkit-tests:
3428
3429 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3430
3431         Reviewed by Gustavo Noronha.
3432
3433         "delete" in EventSender is the backspace key, not the delete one.
3434
3435         * DumpRenderTree/gtk/EventSender.cpp:
3436         (keyDownCallback):
3437
3438 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3439
3440         Reviewed by Gustavo Noronha.
3441
3442         getChildrenWithRange expects as last parameter the end index, not
3443         the length of the range. Correct this and clarify the variable
3444         names to reflect how the code works.
3445
3446         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3447         (AccessibilityUIElement::getChildrenWithRange):
3448         (AccessibilityUIElement::getChildAtIndex):
3449
3450 2009-10-06  Mark Rowe  <mrowe@apple.com>
3451
3452         Reviewed by Simon Fraser.
3453
3454         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3455
3456         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3457         the fact we have already changed the working directory to the top of the open source tree.
3458
3459 2009-10-06  Julie Parent  <jparent@chromium.org>
3460
3461         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3462         rather than my committer email.
3463
3464         * Scripts/modules/committers.py:
3465
3466 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3467
3468         Reviewed by Eric Seidel.
3469
3470         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3471
3472         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3473         it after each layout test as it should do, making the DRT dump additional output
3474         for all of the subsequent layout tests.
3475
3476         * DumpRenderTree/qt/jsobjects.cpp:
3477         (LayoutTestController::reset):
3478
3479 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3480
3481         Reviewed by Simon Hausmann.
3482
3483         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3484         fast/dom/assign-to-window-status.html test, which is passing as a result.
3485
3486         https://bugs.webkit.org/show_bug.cgi?id=30127
3487
3488         * DumpRenderTree/qt/DumpRenderTree.cpp:
3489         (WebCore::DumpRenderTree::DumpRenderTree):
3490         (WebCore::DumpRenderTree::statusBarMessage):
3491         * DumpRenderTree/qt/DumpRenderTree.h:
3492         * DumpRenderTree/qt/jsobjects.h:
3493         (LayoutTestController::shouldDumpStatusCallbacks):
3494         (LayoutTestController::dumpStatusCallbacks):
3495
3496 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3497
3498         Reviewed by Simon Hausmann.
3499
3500         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3501         ignores the argument indicating which mouse button to trigger.
3502         https://bugs.webkit.org/show_bug.cgi?id=30048
3503
3504         This affects the fast/events/mouse-click-events.html layout test.
3505
3506         * DumpRenderTree/qt/jsobjects.cpp:
3507         (EventSender::mouseDown):
3508         (EventSender::mouseUp):
3509         * DumpRenderTree/qt/jsobjects.h:
3510
3511 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3512
3513         Reviewed by Simon Hausmann.
3514
3515         [Qt] Fix the EventSender::keyDown() implementation
3516         https://bugs.webkit.org/show_bug.cgi?id=30043
3517
3518         It should post both a key press event and a key release event,
3519         just like other ports do.
3520
3521         * DumpRenderTree/qt/jsobjects.cpp:
3522         (EventSender::keyDown):
3523
3524 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3525
3526         wx build fix. Add jpeg to the list of libs to link against.
3527
3528         * wx/build/settings.py:
3529
3530 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3531
3532         Reviewed by Simon Hausmann.
3533
3534         [Qt] EventSender::keyDown() cannot send function-key events.
3535         https://bugs.webkit.org/show_bug.cgi?id=30044
3536
3537         This affects the fast/events/keydown-function-keys.html layout test.
3538
3539         * DumpRenderTree/qt/jsobjects.cpp:
3540         (EventSender::keyDown):
3541
3542 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3543
3544         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3545         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3546
3547         * wx/build/settings.py:
3548         * wx/build/wxpresets.py:
3549
3550 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3551
3552         Reviewed by Timothy Hatcher.
3553
3554         Web Inspector: add testing harness for Web Inspector.
3555
3556         https://bugs.webkit.org/show_bug.cgi?id=30010
3557
3558         * DumpRenderTree/LayoutTestController.cpp:
3559         (showWebInspectorCallback):
3560         (closeWebInspectorCallback):
3561         (evaluateInWebInspectorCallback):
3562         (LayoutTestController::staticFunctions):
3563         * DumpRenderTree/LayoutTestController.h:
3564         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3565         (LayoutTestController::showWebInspector):
3566         (LayoutTestController::closeWebInspector):
3567         (LayoutTestController::evaluateInWebInspector):
3568         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3569         (LayoutTestController::showWebInspector):
3570         (LayoutTestController::closeWebInspector):
3571         (LayoutTestController::evaluateInWebInspector):
3572         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3573         (LayoutTestController::showWebInspector):
3574         (LayoutTestController::closeWebInspector):
3575         (LayoutTestController::evaluateInWebInspector):
3576         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3577         (LayoutTestController::showWebInspector):
3578         (LayoutTestController::closeWebInspector):
3579         (LayoutTestController::evaluateInWebInspector):
3580
3581 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3582
3583         Reviewed by Ariyha Hidayat.
3584
3585         Pass arguments to system() as a string instead of array
3586
3587         When passed as an array entries with a space fail to translate
3588         to two arguments to the child process, so instead of manually
3589         splitting all the entries in @buildArgs we pass the whole thing
3590         as a string instead.
3591
3592         * Scripts/webkitdirs.pm:
3593
3594 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3595
3596         Reviewed by David Levin.
3597
3598         check-webkit-style misses whitespace errors for operators:
3599         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3600         https://bugs.webkit.org/show_bug.cgi?id=30021
3601
3602         * Scripts/modules/cpp_style.py:
3603         Added the operators mentioned above to the same list as == and !=.
3604
3605 2009-10-02  Julie Parent  <jparent@chromium.org>
3606
3607         Unreviewed.
3608
3609         Adding myself and Ojan Vafai as committers, because we are committers.
3610
3611         * Scripts/modules/committers.py:
3612
3613 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3614
3615         Reviewed by Adam Roben.
3616
3617         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3618         this will help the patch merging process when TryBots are used.
3619
3620         * Scripts/svn-create-patch:
3621
3622 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3623
3624         Reviewed by Simon Hausmann.
3625
3626         [Qt] Implement layoutTestController.overridePreference().
3627         https://bugs.webkit.org/show_bug.cgi?id=29970
3628
3629         * DumpRenderTree/qt/DumpRenderTree.cpp:
3630         (WebCore::WebPage::WebPage):
3631         (WebCore::WebPage::resetSettings):
3632         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3633         * DumpRenderTree/qt/jsobjects.cpp:
3634         (LayoutTestController::reset):
3635         (LayoutTestController::setPrivateBrowsingEnabled):
3636         (LayoutTestController::setPopupBlockingEnabled):
3637         (LayoutTestController::overridePreference):
3638         * DumpRenderTree/qt/jsobjects.h:
3639
3640 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3641
3642         Reviewed by Oliver Hunt.
3643
3644         Turn on ENABLE_3D_CANVAS in TOT
3645         https://bugs.webkit.org/show_bug.cgi?id=29906
3646
3647         * Scripts/build-webkit:
3648
3649 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3650
3651         Rubberstamped by Simon Hausmann.
3652
3653         Enable HTTP tests for Qt
3654
3655         * Scripts/run-webkit-tests:
3656
3657 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3658
3659         Reviewed by Dimitri Glazkov.
3660
3661         build-webkit --chromium now also works on cygwin.
3662
3663         https://bugs.webkit.org/show_bug.cgi?id=29973
3664
3665         * Scripts/webkitdirs.pm:
3666
3667 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3668
3669         Reviewed by Simon Hausmann.
3670
3671         [Qt] Don't use TCmalloc in DumpRenderTree
3672         https://bugs.webkit.org/show_bug.cgi?id=27029
3673
3674         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3675
3676         * DumpRenderTree/qt/DumpRenderTree.pro:
3677
3678 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3679
3680         Reviewed by Simon Hausmann.
3681
3682         [Qt] Implement eventSender.scheduleAsynchronousClick().
3683
3684         https://bugs.webkit.org/show_bug.cgi?id=29931
3685
3686         * DumpRenderTree/qt/jsobjects.cpp:
3687         (EventSender::scheduleAsynchronousClick):
3688         * DumpRenderTree/qt/jsobjects.h:
3689
3690 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>