e0f2b40780e025f9519307513d75d3db9c5ee36b
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-21  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Tim Hatcher.
4
5         Break out more of DumpRenderTree.mm into individual files
6
7         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
8         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
9         (checkedMalloc):
10         (checkedRealloc):
11         (makeLargeMallocFailSilently):
12         * DumpRenderTree/mac/CheckedMalloc.h: Added.
13         * DumpRenderTree/mac/DumpRenderTree.mm:
14         (crashHandler):
15         (dump):
16         * DumpRenderTree/mac/DumpRenderTreeMac.h:
17         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
18         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
19         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
20         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
21         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
22         (javaScriptThreads):
23         (runJavaScriptThread):
24         (startJavaScriptThreads):
25         (stopJavaScriptThreads):
26         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
27         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
28         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
29         (restoreColorSpace):
30         (setDefaultColorProfileToRGB):
31         (initializeColorSpaceAndScreeBufferForPixelTests):
32         (md5HashStringForBitmap):
33         (dumpWebViewAsPixelsAndCompareWithExpected):
34
35 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
36
37         Move install-unix-extras to wx directory as it seems only to be used by that 
38         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
39         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
40         have install-unix-extras install into WebKitLibraries as per
41         convention.
42         
43         Reviewed by Mark Rowe.
44
45         * Scripts/install-unix-extras: Removed.
46         * wx/build-wxwebkit:
47         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
48
49 2007-11-21  Eric Seidel  <eric@webkit.org>
50
51         Reviewed by Adam.
52
53         More refactoring for greater code readability
54
55         * DumpRenderTree/mac/DumpRenderTree.mm:
56         (initializeGlobalsFromCommandLineOptions):
57         (initializeColorSpaceAndScreeBufferForPixelTests):
58         (addTestPluginsToPluginSearchPath):
59         (useLongRunningServerMode):
60         (runTestingServerLoop):
61         (prepareConsistentTestingEnvironment):
62         (dumpRenderTree):
63         (main):
64         (dumpFramesAsText):
65         (dumpBackForwardListForWebView):
66         (sizeWebViewForCurrentTest):
67         (methodNameStringForFailedTest):
68         (dumpBackForwardListForAllWindows):
69         (dumpWebViewAsPixelsAndCompareWithExpected):
70         (invalidateAnyPreviousWaitToDumpWatchdog):
71         (dump):
72         * DumpRenderTree/mac/DumpRenderTreeMac.h:
73         * DumpRenderTree/mac/UIDelegate.mm:
74         (-[UIDelegate webView:createWebViewWithRequest:]):
75
76 2007-11-21  Eric Seidel  <eric@webkit.org>
77
78         Reviewed by Tim Hatcher.
79
80         Abstract more of DRT into static methods
81
82         * DumpRenderTree/mac/DumpRenderTree.mm:
83         (setDefaultsToConsistentValuesForTesting):
84         (setupSignalHandlers):
85         (allocateGlobalControllers):
86         (releaseAndZero):
87         (releaseGlobalControllers):
88         (dumpRenderTree):
89         (shouldLogFrameLoadDelegates):
90         (createCFURLFromPathOrURL):
91         (resetWebViewToConsistentStateBeforeTesting):
92         (runTest):
93
94 2007-11-21  Eric Seidel  <eric@webkit.org>
95
96         Reviewed by Tim Hatcher.
97
98         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
99
100         * DumpRenderTree/DumpRenderTree.h:
101         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
102         * DumpRenderTree/mac/DumpRenderTree.mm:
103         (dumpRenderTree):
104         (dump):
105         (runTest):
106         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
107         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
108         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
109         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
110         (-[DumpRenderTreePasteboard declareType:owner:]):
111         (+[LocalPasteboard alloc]):
112         (-[LocalPasteboard init]):
113         (-[LocalPasteboard dealloc]):
114         (-[LocalPasteboard name]):
115         (-[LocalPasteboard releaseGlobally]):
116         (-[LocalPasteboard declareTypes:owner:]):
117         (-[LocalPasteboard addTypes:owner:]):
118         (-[LocalPasteboard changeCount]):
119         (-[LocalPasteboard types]):
120         (-[LocalPasteboard availableTypeFromArray:]):
121         (-[LocalPasteboard setData:forType:]):
122         (-[LocalPasteboard dataForType:]):
123         (-[LocalPasteboard setPropertyList:forType:]):
124         (-[LocalPasteboard setString:forType:]):
125         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
126         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
127         (+[DumpRenderTreeWindow allWindows]):
128         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
129         (-[DumpRenderTreeWindow dealloc]):
130         (-[DumpRenderTreeWindow isKeyWindow]):
131         (-[DumpRenderTreeWindow keyDown:]):
132
133 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
134
135         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
136         it indiscriminately copies any headers inside JavaScriptCore,
137         which includes Tiger ICU headers. 
138
139         * wx/build-wxwebkit:
140         Don't run WebCore/move-js-headers.sh any longer.
141
142 2007-11-20  Adam Treat  <treat@kde.org>
143
144         Reviewed by David Kilzer.
145
146         * Prepend git branch name to $baseProductDir
147
148         * Scripts/VCSUtils.pm:
149         * Scripts/webkitdirs.pm:
150
151 2007-11-20  Mark Rowe  <mrowe@apple.com>
152
153         Reviewed by Simon Hausmann.
154
155         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
156         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
157         Have it trigger a "make distclean" rather than "make clean" to ensure that the
158         built product and generated Makefile's are removed.
159
160 2007-11-19  Alp Toker  <alp@atoker.com>
161
162         Reviewed by Mark Rowe.
163
164         http://bugs.webkit.org/show_bug.cgi?id=16040
165         [GTK] GtkLauncher should be written in C
166
167         Port GtkLauncher to plain C.
168
169         Use a more conventional GTK+ coding style.
170
171         Use a toolbar instead of menus.
172
173         Various signature fixes and cleanups.
174
175         Add a license header. Assume all previous modifications were copyright
176         assigned to Apple Inc. by default.
177
178         * GtkLauncher/GtkLauncher.pro:
179         * GtkLauncher/main.c: Added.
180         (activate_url_entry_cb):
181         (update_title):
182         (link_hover_cb):
183         (title_change_cb):
184         (progress_change_cb):
185         (destroy_cb):
186         (go_back_cb):
187         (go_forward_cb):
188         (create_browser):
189         (create_statusbar):
190         (create_toolbar):
191         (create_window):
192         (main):
193         * GtkLauncher/main.cpp: Removed.
194
195 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
196
197         Build script fixes to ensure they do the right thing for the 
198         wx port, and update build-wxwebkit to reflect the way the
199         build scripts now work.
200
201         Reviewed by Adam.
202
203         * Scripts/build-testkjs:
204         * Scripts/build-webkit:
205         * Scripts/run-javascriptcore-tests:
206         * Scripts/webkitdirs.pm:
207         * wx/build-wxwebkit:
208
209 2007-11-18  Eric Seidel  <eric@webkit.org>
210
211         Reviewed by Anders.
212
213         Make run-javascriptcore-tests report failures on exit (to support git bisect)
214
215         * Scripts/run-javascriptcore-tests:
216
217 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
218
219         Reviewed by Adam Roben.
220
221         Make run-webkit-tests work with Windows debug build.
222
223         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
224         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
225         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
226         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
227         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
228
229 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
230
231         Add wxWebKit sample and build script, and integrate it with 
232         build-webkit. Also make build-webkit --clean work for all
233         ports.
234
235         Reviewed by Darin Adler.
236
237         * Scripts/build-webkit:
238         * Scripts/webkitdirs.pm:
239         * wx: Added.
240         * wx/browser: Added.
241         * wx/browser/browser.bkl: Added.
242         * wx/browser/browser.cpp: Added.
243         * wx/build-wxwebkit: Added.
244
245 2007-11-17  Adam Roben  <aroben@apple.com>
246
247         Make it easy to run Safari in the debugger on Windows
248
249         I've added a new script, debug-safari, which launches Safari in the
250         debugger. On OS X it just calls gdb-safari.
251
252         Reviewed by Mark Rowe.
253
254         * FindSafari/FindSafari.cpp:
255         (_tmain): Added a /debugger flag, which in combination with
256         /printSafariLauncher will print a script that launches Safari in the
257         debugger.
258         * Scripts/debug-safari: Added.
259         * Scripts/run-safari: Changed to call runSafari().
260         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
261         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
262         first argument along to FindSafari.
263         * Scripts/webkitdirs.pm:
264         (sub runSafari): Added.
265
266 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
267
268         Reviewed by Adam Roben.
269
270         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
271
272 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
273
274         Reviewed by David Kilzer.
275
276         The git config command was renamed to repo-config at some point. This
277         change tries git config and then git repo-config if the first fails.
278
279         * Scripts/prepare-ChangeLog:
280         (gitConfig):
281
282 2007-11-16  Dan Bernstein  <mitz@apple.com>
283
284         Reviewed by Darin Adler and Sam Weinig.
285
286         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
287
288         * DumpRenderTree/win/EventSender.cpp:
289         (keyDownCallback): For characters that cannot be entered on the active
290         keyboard layout, send a WM_CHAR message with the character along with
291         a WM_KEYDOWN message with a virtual key code of 255.
292
293 2007-11-16  Mark Rowe  <mrowe@apple.com>
294
295         Reviewed by Tim Hatcher.
296
297         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
298
299         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
300         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
301
302 2007-11-15  Adam Roben  <aroben@apple.com>
303
304         Make run-safari actually work on Windows
305
306         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
307         chdir call.
308
309 2007-11-14  Adam Roben  <aroben@apple.com>
310
311         Updates to Safari launching now that 3.0.4 is released
312
313         Reviewed by Sam.
314
315         * FindSafari/FindSafari.cpp:
316         (getWebViewCLSID): Use version-independent ProgID.
317         * Scripts/run-safari: Use run-webkit-nightly.cmd.
318
319 2007-11-14  Anders Carlsson  <andersca@apple.com>
320
321         Reviewed by Adam.
322
323         <rdar://problem/5309081>
324         In DRT, "plugin.logDestroy = true" not working on Windows.
325         
326         * DumpRenderTree/win/TestNetscapePlugin/main.c:
327         (NPP_Destroy):
328
329 2007-11-14  Eric Seidel  <eric@webkit.org>
330
331         Reviewed by Sam.
332
333         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
334
335 2007-11-14  Anders Carlsson  <andersca@apple.com>
336
337         Reviewed by Adam.
338
339         <rdar://problem/5141186>
340         window.layoutTestController.setWindowIsKey is not implemented in DRT.
341         
342         Implement setWindowIsKey.
343         
344         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
345         (LayoutTestController::setWindowIsKey):
346
347 2007-11-13  Sam Weinig  <sam@webkit.org>
348
349         Reviewed by Adam Roben.
350
351         Fix for <rdar://problem/5382579>
352         http/tests/security/cross-frame-access-put.html reports large 
353         negative numbers for screenLeft and screenTop (Mac reports "0")
354
355         * DumpRenderTree/win/UIDelegate.cpp:
356         (UIDelegate::UIDelegate): Initialize the RECT.
357         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
358         (UIDelegate::webViewFrame): ditto.
359         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
360
361 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
362
363         Reviewed by Adam.
364
365         - Make Drosera show source, source URLs, and function stack on Windows,
366         and some minor fixes.
367
368         * Drosera/DebuggerDocument.cpp: Force source to always update display.
369         (DebuggerDocument::updateFileSource):
370         * Drosera/debugger.js: Force source to always update display.
371         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
372         menu controls.
373         (DebuggerClient::resume):
374         (DebuggerClient::pause):
375         (DebuggerClient::stepInto):
376         (DebuggerClient::stepOver):
377         (DebuggerClient::stepOut):
378         (DebuggerClient::showConsole):
379         (DebuggerClient::closeCurrentFile):
380         * Drosera/win/DebuggerClient.h: Ditto.
381         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
382         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
383         removed two bugs.  1) caller could be in a bad state when asked to
384         assign into it. 2) BSTRs were not created correctly.
385         (DebuggerDocument::getPlatformCurrentFunctionStack):
386         * Drosera/win/Drosera.cpp: Hook up the menu controls.
387         (droseraWndProc):
388         (handleCommand):
389         (Drosera::resume):
390         (Drosera::pause):
391         (Drosera::stepInto):
392         (Drosera::stepOver):
393         (Drosera::stepOut):
394         (Drosera::showConsole):
395         (Drosera::closeCurrentFile):
396         * Drosera/win/Drosera.h: Hook up the menu controls.
397         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
398         functions, added a null check, and fixed another bug where caller could
399         be in a bad state when asked to assign into it.
400         (ServerConnection::didLoadMainResourceForDataSource):
401         (ServerConnection::getCallerFrame):
402         * Drosera/win/ServerConnection.h: Safety first.
403
404 2007-11-13  Dan Bernstein  <mitz@apple.com>
405
406         Reviewed by Darin Adler.
407
408         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
409           DumpRenderTree --pixel-tests renders each test twice
410
411         * DumpRenderTree/mac/DumpRenderTree.mm:
412         (dumpRenderTree): Removed the --paint option because the painting code
413         is always exercised as a result of
414         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
415         calling -displayIfNeeded.
416         (dump): Changed to always grab the image from the window since the view
417         is always displayed.
418         (runTest):
419         (displayWebView):
420         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
421         because it always paints.
422
423 2007-11-12  Antti Koivisto  <antti@apple.com>
424
425         Reviewed by Adele.
426         
427         Add support for http media tests
428
429         * Scripts/run-webkit-tests:
430
431 2007-11-12  Sam Weinig  <sam@webkit.org>
432
433         Reviewed by Adam Roben.
434
435         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
436
437         * DumpRenderTree/win/DumpRenderTree.cpp:
438         (runTest):
439         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
440         (LayoutTestController::setPrivateBrowsingEnabled):
441
442 2007-11-12  Adam Roben  <aroben@apple.com>
443
444         * Scripts/update-webkit-localizable-strings: Changed to only scan the
445         mac and win subdirectories.
446
447 2007-11-11  Adam Roben  <aroben@apple.com>
448
449         Fix <rdar://5133816> keepWebHistory is not implemented
450
451         Fixes fast/history/clicked-link-is-visited.html.
452
453         Reviewed by Darin.
454
455         * DumpRenderTree/win/DumpRenderTree.cpp:
456         (runTest): Clear the optionalSharedHistory.
457         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
458         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
459
460 2007-11-10  Sam Weinig  <sam@webkit.org>
461
462         Reviewed by Tim Hatcher.
463
464         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
465         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
466         is turned on)
467
468         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
469
470         Added test: http/tests/security/cross-frame-access-private-browsing.html
471
472         * DumpRenderTree/LayoutTestController.cpp:
473         (setPrivateBrowsingEnabledCallback):
474         (LayoutTestController::staticFunctions):
475         * DumpRenderTree/LayoutTestController.h:
476         * DumpRenderTree/mac/DumpRenderTree.mm:
477         (runTest): Default to private browsing disabled.
478         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
479         (LayoutTestController::setPrivateBrowsingEnabled):
480         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
481         (LayoutTestController::setPrivateBrowsingEnabled):
482
483 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
484
485         Reviewed by Adam.
486
487         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
488         WebCore's!
489
490         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
491         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
492         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
493         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
494         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
495         * Drosera/win/Drosera.cpp:
496         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
497
498 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
499
500         Reviewed by Sam.
501
502         - Use the new IWebFrame [local] function signature and get the shared
503         server correctly.
504
505         * Drosera/win/DebuggerClient.cpp:
506         (DebuggerClient::didFinishLoadForFrame):
507         * Drosera/win/ServerConnection.cpp:
508         (ServerConnection::attemptToCreateServerConnection):
509
510 2007-11-07  Dan Bernstein  <mitz@apple.com>
511
512         Reviewed by Darin Adler.
513
514         - add an option to run-webkit-tests to ignore pixel test failures where
515           all pixels differ by no more than a specified threshold
516
517         * DumpRenderTree/mac/ImageDiff.m:
518         (main):
519         (compareImages):
520         (computePercentageDifferent):
521         * Scripts/run-webkit-tests:
522
523 2007-11-07  Simon Hausmann  <hausmann@kde.org>
524
525         Reviewed by Lars.
526
527         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
528
529         * DumpRenderTree/qt/DumpRenderTree.cpp:
530
531 2007-11-07  Simon Hausmann  <hausmann@kde.org>
532
533         Reviewed by Lars.
534
535         Reworked the QWebSettings API.
536         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
537
538         * DumpRenderTree/qt/DumpRenderTree.cpp:
539
540 2007-11-07  Simon Hausmann  <hausmann@kde.org>
541
542         Reviewed by Lars.
543
544         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
545
546         * DumpRenderTree/qt/jsobjects.cpp:
547
548 2007-11-07  Simon Hausmann  <hausmann@kde.org>
549
550         Reviewed by Lars Knoll <lars@trolltech.com>.
551
552         Add a QWebPage::frameCreated() signal and fix DRT
553         
554         The removal of createFrame in QWebPage broke the re-implementation
555         in DumpRenderTree. Instead emit a frameCreated() signal and
556         connect to it in DumpRenderTree.
557         
558
559         * DumpRenderTree/qt/DumpRenderTree.cpp:
560         (WebCore::WebPage::WebPage):
561         (WebCore::DumpRenderTree::dump):
562         (WebCore::DumpRenderTree::connectFrame):
563         * DumpRenderTree/qt/DumpRenderTree.h:
564
565 2007-11-07  Simon Hausmann  <hausmann@kde.org>
566
567         Reviewed by Lars Knoll <lars@trolltech.com>.
568
569         Moved all the event handlers from QWebFrame into QWebPage.
570         
571         This cleans up the public API and allows us to remove the
572         HackWebFrame hack in DumpRenderTree.
573         
574
575         * DumpRenderTree/qt/jsobjects.cpp:
576         (EventSender::mouseDown):
577         (EventSender::mouseUp):
578         (EventSender::mouseMoveTo):
579
580 2007-11-07  Simon Hausmann  <hausmann@kde.org>
581
582         Reviewed by Mark.
583
584         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
585         to prevent the default implementation from popping up messageboxes.
586
587         * DumpRenderTree/qt/DumpRenderTree.cpp:
588         (WebCore::WebPage::javaScriptConfirm):
589         (WebCore::WebPage::javaScriptPrompt):
590
591 2007-11-06  Eric Seidel  <eric@webkit.org>
592
593         * Scripts/build-testkjs: build fix... too many $$
594
595 2007-11-06  Eric Seidel  <eric@webkit.org>
596
597         Reviewed by Mark Rowe.
598
599         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
600
601 2007-11-05  Adam Roben  <aroben@apple.com>
602
603         Add support on Windows for WEBKIT_TESTFONTS
604
605         This environment variable lets you specify where the fonts to be used
606         by DumpRenderTree reside. The Qt port is already using this, so I'm
607         just following their lead.
608
609         Reviewed by Darin.
610
611         * DumpRenderTree/win/DumpRenderTree.cpp:
612         (exePath): Refactored code out of initialize().
613         (fontsPath): Returns either $WEBKIT_TESTFONTS or
614         DumpRenderTree.resources.
615         (initialize): Use the new fontsPath function.
616         (main): Use the new exePath function.
617         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
618         variable to DRT, like Qt does.
619
620 2007-11-05  Mark Rowe  <mrowe@apple.com>
621
622         Rubber-stamped by Alp Toker.
623
624         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
625
626         * GtkLauncher/main.cpp:
627         (goToURLBarText):
628         (main):
629
630 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
631
632         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
633         <http://bugs.webkit.org/show_bug.cgi?id=15830>
634
635         Reviewed by Timothy.
636
637         Restrict the range of nightly builds used by the bisect-builds script
638         based on the version of Safari and the version of Mac OS X being used.
639
640         Mac OS X 10.4: Safari 2.0: r11976 or newer
641         Mac OS X 10.4: Safari 3.0: r19992 or newer
642
643         Mac OS X 10.5: Safari 2.0: r19594 or newer
644         Mac OS X 10.5: Safari 3.0: r25124 or newer
645
646         * Scripts/bisect-builds:
647         (findMacOSXVersion): Added.
648         (makeNightlyList): Added argument to provide version of Mac OS X.
649         Restrict range of nightly builds based on Safari and Mac OS X versions.
650
651 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
652
653         Reviewed by Maciej.
654
655         - This patch involves several changes, all of them were noticed that
656         they were needed by the work being done in WebKit to get Drosera and
657         WebKit working together on Windows.
658         - The changes are:
659         1) Added a debugger console for output messages.
660         2) Drosera now listens for the WebKit server (before, the server would
661         have to be running before Drosera was started.)
662         3) Fixed a bug where the WebView started out as 0x0 pixels.
663         4) Fixed a bug when there is no scope.
664         5) Added the HTML, JS, and CSS to the project file to make them easy to
665         find.
666         6) Made the ServerConnection functions virtual.
667
668         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
669         for the WebKit server.
670         (DebuggerClient::DebuggerClient):
671         (DebuggerClient::~DebuggerClient):
672         (DebuggerClient::didFinishLoadForFrame):
673         (DebuggerClient::serverConnected):
674         (DebuggerClient::attemptToCreateServerConnection):
675         * Drosera/win/DebuggerClient.h: Ditto.
676         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
677         scope.
678         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
679         (DebuggerDocument::platformValueForScopeVariableNamed):
680         * Drosera/win/Drosera.cpp:
681         (_tWinMain): Added a console in debug for output messages.
682         (Drosera::Drosera): Listen for server.
683         (Drosera::initUI): The server now Initializes COM.
684         (Drosera::serverConnected): Part of the listening for the server.
685         (Drosera::attemptToCreateServerConnection): Ditto.
686         * Drosera/win/Drosera.h: New interface for listening for the server.
687         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
688         files to the VS project.
689         * Drosera/win/ServerConnection.cpp: Part of listening for the server
690         connection.
691         (ServerConnection::ServerConnection):
692         (ServerConnection::attemptToCreateServerConnection):
693         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
694         methods.
695         (ServerConnection::serverConnected):
696
697 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
698
699         Reviewed by Maciej.
700
701         http://bugs.webkit.org/show_bug.cgi?id=15832
702         fast/dom/gc-10.html crashes when run alone
703
704         Check for !done before using objects that can be already deallocated.
705
706         * DumpRenderTree/mac/EditingDelegate.mm:
707         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
708         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
709         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
710         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
711         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
712         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
713         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
714         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
715         (-[EditingDelegate webViewDidBeginEditing:]):
716         (-[EditingDelegate webViewDidChange:]):
717         (-[EditingDelegate webViewDidEndEditing:]):
718         (-[EditingDelegate webViewDidChangeTypingStyle:]):
719         (-[EditingDelegate webViewDidChangeSelection:]):
720         * DumpRenderTree/mac/FrameLoadDelegate.mm:
721         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
722         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
723         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
724         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
725         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
726         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
727         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
728         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
729         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
730         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
731         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
732         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
733         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
734         (-[FrameLoadDelegate webView:willCloseFrame:]):
735         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
736         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
737         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
738         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
739         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
740         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
741         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
742         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
743         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
744
745 2007-11-04  Mark Rowe  <mrowe@apple.com>
746
747         Build fix.  Don't use Carbon.h as the prefix header as it triggers
748         warnings that would otherwise be suppressed due to it being a system header.
749
750         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
751
752 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
753
754         Rubber stamped by Adam.
755         
756         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
757
758         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
759
760 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
761
762         Sort files(...); sections of Xcode project files.
763
764         Rubber-stamped by Darin.
765
766         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
767         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
768         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
769         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
770
771 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
772
773         Script to sort "files(...);" sections in Xcode project.pbxproj files.
774
775         Reviewed by Darin.
776
777         * Scripts/sort-Xcode-project-file: Added.
778
779 2007-11-02  Darin Adler  <darin@apple.com>
780
781         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
782
783 2007-11-02  Darin Adler  <darin@apple.com>
784
785         Reviewed by Maciej.
786
787         * Scripts/run-sunspider: Pass the "--base" option through.
788
789         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
790         the real script do that. Default configuration to Release to match run-sunspider
791         so we don't end up building Debug just to compare results.
792
793 2007-11-01  Adam Roben  <aroben@apple.com>
794
795         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
796
797         Reviewed by Sam.
798
799         * Scripts/commit-log-editor: Show all the directories beneath the
800         source root, instead of just the last one.
801
802 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
803
804         Reviewed by Adam Roben.
805
806         Print out an error message when the Windows build fails
807         and provide guidance on how to find out what went wrong.
808
809         * Scripts/build-webkit:
810         * Scripts/webkitdirs.pm:
811
812 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
813
814         Rubber-stamped by Adam Roben.
815
816         Rolled out r27326 - debug CRT seems to cause no problems after all.
817
818         * DumpRenderTree/win/DumpRenderTree.vcproj:
819
820 2007-10-31  Adam Roben  <aroben@apple.com>
821
822         Switch the Debug configuration to using the non-debug CRT
823
824         This matches WebKit.
825
826         Reviewed by Steve.
827
828         * DumpRenderTree/win/DumpRenderTree.vcproj:
829
830 2007-10-31  Antti Koivisto  <antti@apple.com>
831
832         Reviewed by bdash.
833         
834         Disable media tests when doing leak checking on Tiger.
835         They crash in QuickTime (rdar://problem/5537157).
836
837         * Scripts/run-webkit-tests:
838
839 2007-10-29  Antti Koivisto  <antti@apple.com>
840
841         Reviewed by Maciej.
842         
843         Build media support by default on OSX only.
844
845         * Scripts/build-webkit:
846
847 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
848
849         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
850         get caught by the pre-commit hooks.
851
852 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
853
854         Reviewed by Adam.
855
856         - This is a collection of relatively unrelated changes and cleanups
857         to Drosera to prepare it for interacting with WebKit.  A lot of these
858         changes are just correcting mistakes, for example removing included
859         headers that are no longer needed.
860
861         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
862         this will be needed by the DebuggerClient.
863         (DebuggerDocument::server):
864         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
865         * Drosera/win/DebuggerClient.cpp: 
866         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
867         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
868         (DebuggerClient::createWebViewWithRequest): Added comment about its
869         purpose. 
870         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
871         declarations.
872         (DebuggerClient::webViewLoaded): Moved.
873         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
874         file, since this was the only place it was used.
875         (cfStringToBSTR):
876         * Drosera/win/Drosera.h: Cleaned up the includes.
877         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
878         * Drosera/win/HelperFunctions.h: Removed.
879
880 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
881
882         Reviewed by Adam.
883
884         - Small cleanup in the ServerConnection class.
885
886         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
887         and added an include.
888         (ServerConnection::currentFrame):
889         (ServerConnection::getCallerFrame):
890         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
891         made a pointer into a COMPtr, and cleaned up the includes.
892
893 2007-10-29  Timothy Hatcher  <timothy@apple.com>
894
895         Reviewed by John Sullivan.
896         
897         - Place the Localizable.strings file in mac or win directories
898           if that location exists.
899         - Also look for UI_STRING in .c files.
900
901         * Scripts/extract-localizable-strings:
902
903 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
904
905         Reviewed by Adam.
906
907         - Set the eol-style to native and made all the line endings the same
908         so that I avoid messy diffs that show eol changes.
909
910         * Drosera/win/ServerConnection.cpp:
911         (ServerConnection::didParseSource):
912         (ServerConnection::didEnterCallFrame):
913         (ServerConnection::willExecuteStatement):
914         (ServerConnection::willLeaveCallFrame):
915         (ServerConnection::exceptionWasRaised):
916
917 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
918
919         Reviewed by Adam.
920
921         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
922         functionality that could not have existed previously without the new
923         interfaces.
924         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
925         from a BSTR to a JSValueRef.
926         (DebuggerDocument::platformEvaluateScript): Implemented.
927         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
928         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
929         Implemented.
930         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
931         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
932         * Drosera/win/ServerConnection.cpp: Added a helper function.
933         (ServerConnection::getCallerFrame):
934         * Drosera/win/ServerConnection.h: Added a helper function.
935
936 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
937
938         updated reviewers for my previous changelog.
939
940 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
941         Reviewed by Maciej and Adam and Geoff.
942
943         - Minor mac-side improvements including moving a function to a more
944         appropriate location, fixing a warning, and correctly checking
945         exceptions.
946
947         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
948         (DebuggerDocument::willExecuteStatement):
949         (DebuggerDocument::didEnterCallFrame):
950         (DebuggerDocument::willLeaveCallFrame):
951         (DebuggerDocument::windowScriptObjectAvailable):
952         (DebuggerDocument::callFunctionOnObject):
953         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
954         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
955         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
956         because it doesn't require the ServerConnection at all.
957         (NSStringCreateWithJSStringRef): Made an argument const.
958         (JSValueRefCreateWithNSString): Made an argument const.
959         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
960         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
961         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
962         * Drosera/mac/ServerConnection.mm: Ditto.
963         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
964
965 2007-10-29  Sam Weinig  <sam@webkit.org>
966
967         Reviewed by Adam Roben.
968
969         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
970
971         * DumpRenderTree/LayoutTestController.cpp:
972         (LayoutTestController::LayoutTestController):
973         (getGlobalFlagCallback):
974         (setGlobalFlagCallback):
975         (LayoutTestController::getJSClass):
976         (LayoutTestController::staticValues):
977         * DumpRenderTree/LayoutTestController.h:
978         (LayoutTestController::globalFlag):
979         (LayoutTestController::setGlobalFlag):
980
981 2007-10-29  Darin Adler  <darin@apple.com>
982
983         Reviewed by Maciej.
984
985         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
986         resolution instead of its default.
987
988 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
989
990         Fixed showStatus() to print status for successfully resolved conflicts when using git.
991
992         Reviewed by Mark Rowe.
993
994         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
995         was successfully resolved, but this would not show any status because the change had
996         already been cached in the index using "git add".  The solution is to add an optional
997         second argument to showStatus() which adds the "--cached" switch to the command.
998
999         * Scripts/resolve-ChangeLogs:
1000         (showStatus):
1001
1002 2007-10-28  Eric Seidel  <eric@webkit.org>
1003
1004         Reviewed by Maciej and Geoff, in unison.
1005
1006         * Scripts/run-webkit-tests: remove broken --svg option
1007
1008 2007-10-28  Darin Adler  <darin@apple.com>
1009
1010         Reviewed by Adam.
1011
1012         * Scripts/run-sunspider: Default to "Release" configuration rather than
1013         defaulting to the last configuration used as other scripts do. This can
1014         still be overriden on the command line with "--debug" if there's some
1015         reason to do so. Also fix a typo.
1016
1017         * Scripts/sunspider-compare-results: Fix a typo.
1018
1019 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1020
1021         Reviewed by Adam.
1022
1023         - Implemented the WebScriptDebugListener functions now that the
1024         WebScriptDebugServer exists
1025
1026         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1027         functions.
1028         (ServerConnection::currentFrame):
1029         (ServerConnection::didLoadMainResourceForDataSource):
1030         (ServerConnection::didParseSource):
1031         (ServerConnection::failedToParseSource):
1032         (ServerConnection::didEnterCallFrame):
1033         (ServerConnection::willExecuteStatement):
1034         (ServerConnection::willLeaveCallFrame):
1035         (ServerConnection::exceptionWasRaised):
1036         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1037         members arguments list.
1038
1039 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1040
1041         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1042         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1043
1044         Reviewed by Darin.
1045
1046         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1047         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1048         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1049         file.  Note that it may also be used as a stand-alone script.
1050
1051         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1052         * Scripts/resolve-ChangeLogs: Added.
1053         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1054
1055 2007-10-26  Mark Rowe  <mrowe@apple.com>
1056
1057         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1058         to the Qt port on the assumption that it was an implementation of the cross-platform
1059         LayoutTestController class.  It is not, so it did not need to be changed.
1060
1061         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1062
1063 2007-10-25  Mark Rowe  <mrowe@apple.com>
1064
1065         Reviewed by Maciej.
1066
1067         Fix builds with code coverage enabled.
1068
1069         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1070
1071 2007-10-25  Darin Adler  <darin@apple.com>
1072
1073         Reviewed by Mark Rowe.
1074
1075         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1076         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1077
1078 2007-10-25  Stephanie  <slewis@apple.com>
1079
1080         build Fix
1081
1082         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1083
1084 2007-10-25  Stephanie  <slewis@apple.com>
1085
1086         Reviewed by Mark Rowe, Adam Roben.
1087
1088         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1089
1090         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1091
1092 2007-10-25  Alice Liu  <alice.liu@apple.com>
1093
1094         Reviewed by Adam.
1095
1096         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1097
1098         Moving destructor into platform-specific files
1099         * DumpRenderTree/LayoutTestController.cpp:
1100         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1101         (LayoutTestController::~LayoutTestController):
1102         * DumpRenderTree/qt/jsobjects.cpp:
1103         (LayoutTestController::~LayoutTestController):
1104
1105         LayoutTestController wasn't being destroyed
1106         * DumpRenderTree/win/DumpRenderTree.cpp:
1107         (runTest):
1108
1109         Added declspec
1110         * DumpRenderTree/win/EditingDelegate.h:
1111
1112         Reset certain values on the webview (or related delegate) that might 
1113         have changed while running a test
1114         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1115         (LayoutTestController::~LayoutTestController):
1116
1117 2007-10-25  Adam Roben  <aroben@apple.com>
1118
1119         Make sunspider-compare-results work with relative paths
1120
1121         Reviewed by Sam.
1122
1123         * Scripts/sunspider-compare-results: Convert arguments to absolute
1124         paths before we chdir.
1125
1126 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1127
1128         Reviewed by Sam.
1129
1130         - Implemented server calls now the WebScriptDebugServer exists.
1131         - Also removed no longer needed call to initialize CG.
1132
1133         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1134         automatically now.
1135         (_tWinMain):
1136         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1137         (ServerConnection::ServerConnection):
1138         (ServerConnection::~ServerConnection):
1139         (ServerConnection::pause):
1140         (ServerConnection::resume):
1141         (ServerConnection::stepInto):
1142         (ServerConnection::applicationTerminating):
1143         (ServerConnection::serverConnectionDidDie):
1144         * Drosera/win/ServerConnection.h: Now uses the COM class.
1145
1146 2007-10-24  George Staikos  <staikos@kde.org>
1147
1148         Unbreak Qt build.
1149
1150         * Scripts/build-webkit:
1151
1152 2007-10-24  Adam Roben  <aroben@apple.com>
1153
1154         Remove now-unnecessary call to InitializeCoreGraphics
1155
1156         WebKit takes care of this now.
1157
1158         Reviewed by Ada.
1159
1160         * DumpRenderTree/win/DumpRenderTree.cpp:
1161         (initialize):
1162
1163 2007-10-24  Adam Roben  <aroben@apple.com>
1164
1165         Use WebTextRenderer in DRT
1166
1167         Reviewed by Ada.
1168
1169         * DumpRenderTree/win/DumpRenderTree.cpp:
1170         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1171
1172 2007-10-24  Sven Herzberg  <sven@imendio.com>
1173
1174         Reviewed by Mark Rowe.
1175
1176         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1177         Bug 15614: [GTK] qmake based backends don't build on OS X
1178
1179         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1180         GTK backend on a Mac
1181         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1182         isDarwin() to make it reusable in other places (like the workaround-
1183         for-prebuilt-qmake in build-webkit)
1184
1185 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1186
1187         Refurbish update-webkit script.
1188
1189         Reviewed by Adam.
1190
1191         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1192         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1193         multi-argument version of system() for flexibility and security.  Check for existence
1194         of Internal directory using -d test instead of -x.
1195
1196 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1197
1198         Minor clean-up of prepare-ChangeLog script.
1199
1200         Reviewed by Adam.
1201
1202         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1203         of a string.  Use multi-argument versions of open() and system() for flexibility and
1204         security.
1205
1206 2007-10-24  Alice Liu  <alice.liu@apple.com>
1207
1208         Reviewed by Oliver.
1209
1210         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1211
1212         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1213         replay the saved events when we're still processing the mousedown that starts the drag
1214         * DumpRenderTree/win/EventSender.cpp:
1215         (doMouseMove):
1216         * DumpRenderTree/win/UIDelegate.cpp:
1217         (UIDelegate::doDragDrop):
1218
1219 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1220
1221         Reviewed by Sam, Steve and Darin.
1222
1223         - Stubbed out the WebScriptDebugListener functionality in the Server
1224         Connection class to prepare it for receiving those callbacks.
1225         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1226         and the ServerConnection to not need to be initialized with a server
1227         name, since that is not the way we connect to the WebKit server. 
1228
1229         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1230         no exception.  Now it only loggs when there is an exception
1231         (DebuggerDocument::willExecuteStatement):
1232         (DebuggerDocument::didEnterCallFrame):
1233         (DebuggerDocument::willLeaveCallFrame):
1234         (DebuggerDocument::windowScriptObjectAvailable):
1235         (DebuggerDocument::callFunctionOnObject):
1236         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1237         to be instantiated with a server's name.
1238         (DebuggerClient::DebuggerClient):
1239         (DebuggerClient::didFinishLoadForFrame):
1240         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1241         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1242         a server name.
1243         (Drosera::init):
1244         (Drosera::initServer):
1245         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1246         instantiated with a server's name.
1247         * Drosera/win/ServerConnection.cpp: 
1248         (ServerConnection::ServerConnection): No longer needs a server name
1249         (ServerConnection::~ServerConnection): Only release the global context
1250         if there is one.
1251         (ServerConnection::serverConnectionDidDie): Stub for
1252         IWebScriptDebugListener
1253         (ServerConnection::QueryInterface): ditto
1254         (ServerConnection::AddRef): ditto
1255         (ServerConnection::Release): ditto
1256         (ServerConnection::didLoadMainResourceForDataSource): ditto
1257         (ServerConnection::didParseSource): ditto
1258         (ServerConnection::failedToParseSource): ditto
1259         (ServerConnection::didEnterCallFrame): ditto
1260         (ServerConnection::willExecuteStatement): ditto
1261         (ServerConnection::willLeaveCallFrame): ditto
1262         (ServerConnection::exceptionWasRaised): ditto
1263         * Drosera/win/ServerConnection.h: Stubbed out the
1264         IWebScriptDebugListener functions, and this class no longer needs to be
1265         instantiated with a server name.
1266
1267 2007-10-24  Lars Knoll  <lars@trolltech.com>
1268
1269         Reviewed by Simon.
1270
1271         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1272
1273         * DumpRenderTree/qt/jsobjects.h:
1274
1275 2007-10-24  Lars Knoll  <lars@trolltech.com>
1276
1277         Reviewed by Simon.
1278
1279         add another command.
1280
1281         * DumpRenderTree/qt/jsobjects.cpp:
1282         (TextInputController::doCommand):
1283
1284 2007-10-24  Lars Knoll  <lars@trolltech.com>
1285
1286         Reviewed by Simon.
1287
1288         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1289
1290         * DumpRenderTree/qt/jsobjects.cpp:
1291         (EventSender::keyDown):
1292         * DumpRenderTree/qt/jsobjects.h:
1293
1294 2007-10-24  Lars Knoll  <lars@trolltech.com>
1295
1296         Reviewed by Simon.
1297
1298         implement eventSender.keyDown().
1299
1300         * DumpRenderTree/qt/jsobjects.cpp:
1301         (EventSender::keyDown):
1302
1303 2007-10-24  Lars Knoll  <lars@trolltech.com>
1304
1305         Reviewed by Simon.
1306
1307         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1308
1309         * DumpRenderTree/qt/DumpRenderTree.cpp:
1310         (WebCore::DumpRenderTree::DumpRenderTree):
1311         (WebCore::DumpRenderTree::initJSObjects):
1312         * DumpRenderTree/qt/jsobjects.cpp:
1313         (TextInputController::doCommand):
1314
1315 2007-10-24  Lars Knoll  <lars@trolltech.com>
1316
1317         Reviewed by Simon.
1318
1319         first bit of implementation for the textinputcontroller.
1320
1321         * DumpRenderTree/qt/DumpRenderTree.cpp:
1322         (WebCore::DumpRenderTree::DumpRenderTree):
1323         * DumpRenderTree/qt/DumpRenderTree.h:
1324         * DumpRenderTree/qt/jsobjects.cpp:
1325         (TextInputController::TextInputController):
1326         (TextInputController::doCommand):
1327         * DumpRenderTree/qt/jsobjects.h:
1328
1329 2007-10-24  Lars Knoll  <lars@trolltech.com>
1330
1331         Reviewed by Simon.
1332
1333         make the man webpage believe it has focus, so the editing tests work correctly.
1334
1335         * DumpRenderTree/qt/DumpRenderTree.cpp:
1336         (WebCore::DumpRenderTree::DumpRenderTree):
1337
1338 2007-10-24  Lars Knoll  <lars@trolltech.com>
1339
1340         Reviewed by Simon.
1341
1342         implement layoutTestController.dumpEditingCallbacks() correctly.
1343
1344         * DumpRenderTree/qt/DumpRenderTree.cpp:
1345         (WebCore::DumpRenderTree::DumpRenderTree):
1346         * DumpRenderTree/qt/jsobjects.cpp:
1347         (LayoutTestController::reset):
1348         (LayoutTestController::dumpEditingCallbacks):
1349
1350 2007-10-24  Lars Knoll  <lars@trolltech.com>
1351
1352         Reviewed by Simon.
1353
1354         Implement support for testing editing.
1355
1356         * DumpRenderTree/qt/DumpRenderTree.cpp:
1357         (WebCore::DumpRenderTree::DumpRenderTree):
1358
1359 2007-10-23  Sam Weinig  <sam@webkit.org>
1360
1361         Check for null BSTR that can be passed to the UIDelegate methods
1362         from javascript null and undefined.  Fixes a failing test case on
1363         Windows (fast/dom/Window/alert-undefined.html)
1364
1365         Reviewed by Eric Seidel.
1366
1367         * DumpRenderTree/win/UIDelegate.cpp:
1368         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1369         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1370         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1371         (UIDelegate::webViewAddMessageToConsole):
1372
1373 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1374
1375         Reviewed by Darin.
1376         
1377         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1378
1379         * Scripts/build-testkjs:
1380
1381 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1382
1383         Reviewed by Darin.
1384
1385         - add wrapper that finds the right copy of testkjs
1386         
1387         * Scripts/sunspider-compare-results: Added.
1388
1389 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1390
1391         Reviewed by Sam.
1392
1393         - After talking with Steve I now see that the WebKit server must be
1394         running for DCOM to create the distributed objects, which makes sense
1395         and currently WebKit only allows one instance to be running at a time
1396         which avoids accidentally connecting to the wrong server
1397         - In light of this I have removed the code for the attach box and
1398         NotificationServer and known server names, since they are all extranious
1399         now.
1400
1401         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1402         names.
1403         (_tWinMain): Uses init instead of initUI.
1404         (droseraWndProc): No longer creats an attach dialog box.
1405         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1406         it's not manditory to call init before doing COM stuff.
1407         (Drosera::init): calls initUI and will call attach when the
1408         functionality exists. 
1409         (Drosera::initUI): Has changed very little.
1410         (Drosera::attach): Changed the signature to reflect that we no longer
1411         need the dictionary of known server names.
1412         * Drosera/win/Drosera.h: Removed notification classes and known server
1413         names.  Also renamed and moved some functions.
1414         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1415         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1416         headers to the resources folder. 
1417         * Drosera/win/resource.h: Removed the Attach box.
1418
1419 2007-10-22  Adam Roben  <aroben@apple.com>
1420
1421         Windows build fix
1422
1423         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1424
1425 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1426
1427         - Removed a leak that was fixed.
1428
1429         * Scripts/run-webkit-tests:
1430
1431 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1432
1433         Reviewed by Darin.
1434
1435         - Changed the Client so that the DebuggerDocument now own the
1436         ServerConnection.  This simplifies ownership and cleanup. 
1437
1438         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1439         ServerConnection.
1440         (DebuggerClient::initWithServerName):
1441         (DebuggerClient::didFinishLoadForFrame):
1442         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1443         ServerConnection.
1444         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1445         until after we have a server which we are attached to.
1446         (Drosera::initUI):
1447         (Drosera::attach):
1448         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1449         out previously.
1450
1451 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1452
1453         Reviewed by Nikolas.
1454
1455         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1456
1457         * Scripts/run-javascriptcore-tests:
1458
1459 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1460
1461         Reviewed by Nikolas.
1462
1463         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1464
1465         * Scripts/build-drosera:
1466         * Scripts/build-dumprendertree:
1467         * Scripts/build-testkjs:
1468         * Scripts/build-webkit:
1469         * Scripts/run-javascriptcore-tests:
1470         * Scripts/run-sunspider:
1471         * Scripts/run-webkit-tests:
1472         * Scripts/webkitdirs.pm:
1473
1474 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1475
1476         Reviewed by Mark Rowe.
1477         
1478         Fix for local database support after r26879
1479         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1480
1481         * Scripts/build-webkit:
1482
1483 2007-10-22  Holger Freyther  <zecke@selfish.org>
1484
1485         Reviewed by Simon Hausmann <hausmann@kde.org>.
1486
1487         - Do not build testkjs as an application bundle. This is
1488         needed for run-javascriptcore-tests on OSX.
1489         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1490         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1491         as we do not have -rpath on OSX.
1492
1493         * DumpRenderTree/qt/DumpRenderTree.pro:
1494         * Scripts/run-webkit-tests:
1495
1496 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1497
1498         Reviewed by aroben.
1499
1500         Fix support for Signed-off-by detection in prepare-ChangeLog
1501         --git-commit. The Signed-off-by tag does not appear in the header
1502         but usually at the end.
1503
1504         * Scripts/prepare-ChangeLog:
1505
1506 2007-10-21  Mark Rowe  <mrowe@apple.com>
1507
1508         Reviewed by Eric.
1509
1510         Fix run-javascriptcore-tests for Gtk.
1511
1512         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1513
1514 2007-10-20  Eric Seidel  <eric@webkit.org>
1515
1516         Reviewed by aroben.
1517
1518         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1519
1520 2007-10-20  Eric Seidel  <eric@webkit.org>
1521
1522         Reviewed by darin.
1523         
1524         Add improved argument handling to run-sunspider, including
1525         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1526         Also re-factor code into subroutines
1527
1528         * Scripts/build-dumprendertree: removed bogus comments
1529         * Scripts/build-testkjs: Added.
1530         * Scripts/run-javascriptcore-tests: use build-testkjs
1531         * Scripts/run-sunspider: improved argument handling, abstraction
1532         * Scripts/run-webkit-tests: improved abstraction
1533
1534 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1535
1536         Not reviewed, Windows build fix.
1537
1538         * DumpRenderTree/win/EventSender.cpp:
1539         (keyDownCallback):
1540
1541 2007-10-20  Darin Adler  <darin@apple.com>
1542
1543         Reviewed by Tim Hatcher.
1544
1545         - http://bugs.webkit.org/show_bug.cgi?id=15544
1546           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1547           not rely on Apple-specific key codes
1548
1549         * DumpRenderTree/mac/EventSendingController.mm:
1550         (-[EventSendingController keyDown:withModifiers:]):
1551         Added named key "rightArrow". Later we could have a whole table of these.
1552         Also tweaked modifiers code a little.
1553
1554         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1555
1556 2007-10-19  Darin Adler  <darin@apple.com>
1557
1558         Reviewed by Eric.
1559
1560         - http://bugs.webkit.org/show_bug.cgi?id=15566
1561           possible fix for leak seen in DumpRenderTree
1562
1563         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1564         Delete the item if it's not put on the queue, since the caller has
1565         no way of knowing that. Would be better to have the parameter type
1566         be auto_ptr to express the fact that we take ownership.
1567
1568         - unrelated change
1569
1570         * Drosera/mac/main.m: Add missing include.
1571
1572 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1573
1574         Reviewed by Adam.
1575
1576         - This change should be identical but for some reason was not working
1577         on my machine.
1578
1579         * Scripts/prepare-ChangeLog:
1580
1581 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1582
1583         Reviewed by Oliver and Tim.
1584
1585         - Made use of RetainPtr to avoid retain and release issues and moved the
1586         log function to DebuggerDocumentPlatform, which seems to be a more
1587         logical place for it to live.
1588         - Also moved knownServers from the ServerConnection to
1589         DebuggerApplication to match the Windows code and because it makes sense
1590         that a connection knows its own server but not all of them.
1591
1592         * Drosera/mac/DebuggerClient.h: Moved the log function to
1593           DebuggerDocumentPlatform.
1594         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1595           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1596           call for the server name up from the ServerConnection class.
1597         (-[DebuggerClient dealloc]):
1598         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1599           for the server name up from the ServerConnection.
1600         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1601         (DebuggerDocument::platformPause):
1602         (DebuggerDocument::platformResume):
1603         (DebuggerDocument::platformStepInto):
1604         (DebuggerDocument::platformEvaluateScript):
1605         (DebuggerDocument::getPlatformCurrentFunctionStack):
1606         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1607         (DebuggerDocument::platformValueForScopeVariableNamed):
1608         (DebuggerDocument::platformLog): Log directly from here. No need to call
1609           DebuggerClient.
1610         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1611           way I see it, a ServerConnection should only know about its connection
1612           and the group of all possible servers should be kept by the
1613           application.
1614         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1615           currentServerName, it makes sense that the connection should know that
1616           name.
1617         (-[ServerConnection currentServerName]):
1618
1619 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1620
1621         Reviewed by Adam.
1622
1623         - Integrated changes from mac drosera.  Recently I've encapsulated
1624         out the server connection object from the rest of Drosera because
1625         it is very platform dependent right now and RPC is not implemented on
1626         windows.  This functionality, of communicating with the WebKit server
1627         is the next area I will be focusing on in Windows.
1628
1629         - Other changes and cleanup were made to organize the code and add notes
1630         on which parts still need work.  Also some mac code is added and
1631         commented out, to act as pseudocode for the logic of those parts.
1632
1633         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1634           pointer.
1635         * Drosera/config.h: Added whitespace.
1636         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1637           these files got moved into Drosera.h/cpp
1638         * Drosera/win/DebuggerApplication.h: Removed.
1639         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1640           happened here to better match the logic flow of the same code on the 
1641           mac side and to use the new ServerConnection class.
1642         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1643         (DebuggerClient::initWithServerName): Initializer that will set up the
1644           class to use a ServerConnection object.  This was necessary so I could
1645           create a DebuggerClient without having to initilaize it at
1646           construction.
1647         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1648           will be the UIDelegate and FrameLoadDelegate.
1649         (DebuggerClient::AddRef): For IUnknown.
1650         (DebuggerClient::Release): For IUnknown.
1651         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1652           this still needs to set the global context of the server, but
1653           IWebFrame does not have an accessor for the global context yet. 
1654         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1655           this is a pass through for the same function in the document.
1656         (DebuggerClient::didReceiveTitle): Unimplemented part of
1657           FrameLoadDelegate this would change the title of the window.
1658         (DebuggerClient::createWebViewWithRequest): Part of the
1659           FrameLoadDelegate.  This is about new windows via Window.open() and
1660           how their delegates are set.
1661         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1662           UIDelegate.  Just a debug function for printing messages.
1663         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1664           because the Client should be the UIDelegate and FrameLoadDelegate
1665           to match the delegates on mac.
1666         (DebuggerClient::webViewLoaded): Added accessor method.
1667         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1668           forgotten to add this file before.  This is where the platform
1669           dependent versions of the Documents functions live. Most of these are
1670           unimplemented because some piece of functionality does not exist on
1671           Windows yet.
1672         (DebuggerDocument::platformPause):
1673         (DebuggerDocument::platformResume):
1674         (DebuggerDocument::platformStepInto):
1675         (DebuggerDocument::platformEvaluateScript):
1676         (DebuggerDocument::getPlatformCurrentFunctionStack):
1677         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1678         (DebuggerDocument::platformValueForScopeVariableNamed):
1679         (DebuggerDocument::platformLog):
1680         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1681           responsibilities becaue they belong in the Client. Also I laid the
1682           groundwork for attaching Drosera to a WebKit process
1683         (attachWndProc): Now if a server is selected the Client becomes it's
1684           delegate.
1685         (Drosera::Drosera): Added the construction of the Client and dictionary
1686           of server names. 
1687         (Drosera::initUI): This is no longer the delegates, the Client is.
1688         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1689           state. 
1690         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1691           notification registration when it's possible to implement.
1692         (Drosera::serverLoaded): Ditto
1693         (Drosera::serverUnloaded): Ditto
1694         (Drosera::attach): Attach Drosera to the WebKit server.
1695         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1696         (Drosera::getInst): 
1697         (Drosera::setInst):
1698         (Drosera::knownServers):
1699         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1700           and added the ServerConnection.
1701         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1702         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1703           Most of the functions are completely unimlemented because they cannot
1704           connect with the WebKit server, because one does not exist on Windows
1705           yet.
1706         (ServerConnection::initWithServerName): 
1707         (ServerConnection::~ServerConnection):
1708         (ServerConnection::setGlobalContext):
1709         (ServerConnection::pause):
1710         (ServerConnection::resume):
1711         (ServerConnection::stepInto):
1712         (ServerConnection::switchToServerNamed):
1713         (ServerConnection::applicationTerminating):
1714         (ServerConnection::serverConnectionDidDie):
1715         (ServerConnection::currentFrame):
1716         * Drosera/win/ServerConnection.h: Added. Ditto.
1717         (ServerConnection::ServerConnection):
1718
1719 2007-10-19  Alice Liu  <alice.liu@apple.com>
1720
1721         Reviewed by Darin.
1722
1723         Fix for these broken layout tests on Windows:
1724         
1725         fast/forms/focus-selection-input.html
1726         fast/forms/focus-selection-textarea.html
1727         fast/forms/select-accesskey.html
1728         
1729         * DumpRenderTree/win/EventSender.cpp:
1730         (keyDownCallback):
1731         correct the VK code for alt key.
1732         
1733 2007-10-19  Eric Seidel  <eric@webkit.org>
1734
1735         Reviewed by Mark Rowe.
1736         
1737         Make the GtkLauncher code slightly more readable.
1738
1739         * GtkLauncher/main.cpp:
1740         (setupMainMenu): Added.
1741         (setupMainWindowUI): Added.
1742         (main):
1743
1744 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1745
1746         Rubber stamped by Adam.
1747         
1748         - don't delay-load WebKit in DumpRenderTree.
1749
1750         * DumpRenderTree/win/DumpRenderTree.vcproj:
1751
1752 2007-10-18  Dan Bernstein  <mitz@apple.com>
1753
1754         Reviewed by Adam Roben.
1755
1756         - fix <rdar://problem/5313523>
1757         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1758
1759         * DumpRenderTree/mac/DumpRenderTree.mm:
1760         (dump): Changed to use _responseMIMEType.
1761
1762 2007-10-17  Adam Roben  <aroben@apple.com>
1763
1764         Make it possible to have Windows-specific tests and results
1765
1766         When searching for tests to run and the Skipped file, we will only
1767         look in platform/win and the cross-platform directory. When looking
1768         for expected results, we will look in platform/win, then
1769         platform/mac-leopard, then platform/mac, then finally the
1770         cross-platform directory.
1771
1772         Reviewed by Sam.
1773
1774         * Scripts/run-webkit-tests:
1775         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1776         searching in the cross-platform directory.
1777         (sub buildPlatformHierarchy): Removed some unneeded calls to
1778         dirname/basename.
1779
1780 2007-10-17  Adam Roben  <aroben@apple.com>
1781
1782         Add back the call to register WebKit that we had before WebKitInitializer existed
1783
1784         This is needed to ensure that the right WebKit is used when
1785         instantiating COM objects.
1786
1787         Reviewed by Oliver.
1788
1789         * DumpRenderTree/win/debug_internal.vsprops: Define
1790         DEBUG_WEBKIT_HAS_SUFFIX.
1791         * DumpRenderTree/win/DumpRenderTree.cpp:
1792         (initialize):
1793
1794 2007-10-17  Adam Roben  <aroben@apple.com>
1795
1796         Import File::Basename in webkitdirs since we use it
1797
1798         * Scripts/webkitdirs.pm:
1799
1800 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1801
1802         - Updated the tiger leaks list to make the internal bots green.
1803
1804         * Scripts/run-webkit-tests:
1805
1806 2007-10-17  Adam Roben  <aroben@apple.com>
1807
1808         Build fix for VC++ Express
1809
1810         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1811         and ole32.lib.
1812
1813 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1814
1815         Reviewed by Sam.
1816
1817         - Minor mac improvements based on observations I made while implementing the
1818         Windows code.
1819
1820         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1821         then hand it to the Client who will retain it, it should just be the client who
1822         creates and owns the server.
1823         (-[DebuggerApplication attach:]):
1824         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1825         * Drosera/mac/DebuggerClient.mm: Creates the server.
1826         (-[DebuggerClient initWithServerName:]):
1827         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1828         can instead forward declare what it needs.
1829
1830 2007-10-16  Darin Adler  <darin@apple.com>
1831
1832         Reviewed by Geoff Garen.
1833
1834         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1835         want to turn failing tests into platform-specific test results. Also did a
1836         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1837         would take the type of results into account only some of the time.
1838
1839 2007-10-16  Adam Roben  <aroben@apple.com>
1840
1841         Add a new nightly launcher script for Windows
1842
1843         This new script is for versions of Safari that don't delay-load
1844         WebKit. I had to make FindSafari be able to print out the nightly
1845         launcher script on stdout because Windows shell scripts can't capture
1846         the output from a command into an environment variable.
1847
1848         Reviewed by Steve.
1849
1850         * FindSafari/FindSafari.cpp:
1851         (_tmain): Added /printSafariLauncher option.
1852         * Scripts/run-webkit-nightly.cmd: Added.
1853
1854 2007-10-16  Adam Roben  <aroben@apple.com>
1855
1856         Replace WebKitInitializer with FindSafari
1857
1858         We now rely on setting the PATH environment variable to tell Windows
1859         where to find WebKit and its dependencies (similar to
1860         DYLD_FRAMEWORK_PATH on Mac).
1861
1862         This change also make DumpRenderTree no longer delay-load WebKit.
1863
1864         Reviewed by Sam.
1865
1866         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1867         FindSafari.
1868         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1869         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1870         WebKitInitializer, don't delay-load WebKit.
1871         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1872         * Scripts/run-webkit-tests: Ditto.
1873         * Scripts/webkitdirs.pm:
1874         (sub setPathForRunningWebKitApp): Added.
1875         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1876         * WebKitInitializer/WebKitInitializer.h: Removed.
1877         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1878         * WebKitInitializer/debug.vsprops: Removed.
1879         * WebKitInitializer/debug_internal.vsprops: Removed.
1880         * WebKitInitializer/release.vsprops: Removed.
1881
1882 2007-10-16  Adam Roben  <aroben@apple.com>
1883
1884         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1885
1886         http://bugs.webkit.org/show_bug.cgi?id=15532
1887
1888         FindSafari simply prints the location of an installed Safari.exe on
1889         stdout.
1890
1891         Reviewed by Darin.
1892
1893         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1894         (getStringValue):
1895         (getWebViewCLSID):
1896         (getInstalledWebKitDirectory):
1897         (_tmain):
1898         * FindSafari/FindSafari.vcproj: Added.
1899         * Scripts/webkitdirs.pm:
1900         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1901
1902 2007-10-16  Adam Roben  <aroben@apple.com>
1903
1904         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1905
1906         Reviewed by Kevin McCullough.
1907
1908         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1909         when referring to WebKit.dll.
1910         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1911         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1912         * DumpRenderTree/win/release.vsprops: Ditto.
1913         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1914         never have a _debug suffix on WebKit.dll.
1915         * WebKitInitializer/WebKitInitializer.cpp:
1916         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1917         specified.
1918         * WebKitInitializer/debug_internal.vsprops: Added
1919         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1920
1921 2007-10-16  Darin Adler  <darin@apple.com>
1922
1923         Reviewed by Adele.
1924
1925         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1926         Remove now-unneeded control/alt key hack; the tests have been updated.
1927
1928 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1929
1930         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1931         one of the leaks was fixed between that revision and the bot's previous version of
1932         leopard.
1933
1934         * Scripts/run-webkit-tests:
1935
1936 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1937
1938         Reviewed by Tim.
1939
1940         - I encapsulated out the server connecton functionality because it is a specific part
1941         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1942         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1943         Windows.  So the majority of this patch is moving preexisting functionality.
1944
1945         - Also I removed the prefix header and changed to use config.h because it is more
1946         standard on how we use config.h in windows and it didn't make much sense to keep
1947         the prefix header and the config.h
1948
1949         * Drosera/DebuggerDocument.cpp:
1950         (DebuggerDocument::DebuggerDocument):
1951         * Drosera/DebuggerDocument.h:
1952         * Drosera/config.h:
1953         * Drosera/mac/DebuggerApplication.mm:
1954         (-[DebuggerApplication attach:]):
1955         * Drosera/mac/DebuggerClient.h:
1956         * Drosera/mac/DebuggerClient.mm:
1957         (-[DebuggerClient initWithServerConnection:]):
1958         (-[DebuggerClient dealloc]):
1959         (-[DebuggerClient windowDidLoad]):
1960         (-[DebuggerClient windowWillClose:]):
1961         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1962         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1963         * Drosera/mac/DebuggerDocumentPlatform.mm:
1964         (DebuggerDocument::platformPause):
1965         (DebuggerDocument::platformResume):
1966         (DebuggerDocument::platformStepInto):
1967         (DebuggerDocument::platformEvaluateScript):
1968         (DebuggerDocument::getPlatformCurrentFunctionStack):
1969         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1970         (DebuggerDocument::platformValueForScopeVariableNamed):
1971         (DebuggerDocument::platformLog):
1972         * Drosera/mac/Drosera.pch: Removed.
1973         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1974         * Drosera/mac/ServerConnection.h: Added.
1975         * Drosera/mac/ServerConnection.mm: Added.
1976         (-[ServerConnection initWithServerName:]):
1977         (-[ServerConnection dealloc]):
1978         (-[ServerConnection setGlobalContext:]):
1979         (-[ServerConnection pause]):
1980         (-[ServerConnection resume]):
1981         (-[ServerConnection stepInto]):
1982         (-[ServerConnection switchToServerNamed:]):
1983         (-[ServerConnection applicationTerminating:]):
1984         (-[ServerConnection serverConnectionDidDie:]):
1985         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1986         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1987         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1988         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1989         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1990         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1991         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1992         (-[ServerConnection currentFrame]):
1993         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1994         (-[ServerConnection knownServers]):
1995
1996 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1997
1998         Reviewed by Eric.
1999
2000         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2001           Script to automatically search nightly builds for regressions (bisect-builds)
2002
2003         * Scripts/bisect-builds: Added.
2004
2005 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2006
2007         Reviewed by Darin.
2008
2009         - New JavaScript benchmark
2010         http://bugs.webkit.org/show_bug.cgi?id=15515
2011
2012         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2013         current development or release build of JavaScriptCore.
2014
2015 2007-10-15  Mark Rowe  <mrowe@apple.com>
2016
2017         Reviewed by Sam.
2018
2019         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2020
2021         * Scripts/webkitdirs.pm:
2022         - Change checkArgv to remove the options from @ARGV to prevent
2023         them from interfering with further option processing.
2024         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2025         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2026         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2027         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2028
2029 2007-10-15  Darin Adler  <darin@apple.com>
2030
2031         Reviewed by Sam.
2032
2033         - added logging of window.prompt and window.confirm
2034
2035         * DumpRenderTree/mac/UIDelegate.mm:
2036         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2037         Implement the recommended delegate rather than the deprecated one.
2038         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2039         Added.
2040         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2041         Added.
2042
2043         * DumpRenderTree/win/UIDelegate.h:
2044         * DumpRenderTree/win/UIDelegate.cpp:
2045         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2046         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2047         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2048         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2049
2050 2007-10-15  Alice Liu  <alice.liu@apple.com>
2051
2052         Reviewed by Sam Weinig.
2053
2054         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2055
2056         * DumpRenderTree/win/DumpRenderTree.cpp:
2057         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2058         (main): allocate the global policy delegate for DRT's custom use
2059         * DumpRenderTree/win/DumpRenderTree.vcproj:
2060         Adding files to project
2061         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2062         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2063         (LayoutTestController::setCustomPolicyDelegate):
2064         set the webview's policy delegate to DRT's custom one if the test requests it.
2065         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2066         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2067         (PolicyDelegate::PolicyDelegate):
2068         (PolicyDelegate::QueryInterface):
2069         (PolicyDelegate::AddRef):
2070         (PolicyDelegate::Release):
2071         (PolicyDelegate::decidePolicyForNavigationAction):
2072         * DumpRenderTree/win/PolicyDelegate.h: Added.
2073         (PolicyDelegate::decidePolicyForNewWindowAction):
2074         (PolicyDelegate::decidePolicyForMIMEType):
2075         (PolicyDelegate::unableToImplementPolicyWithError):
2076
2077 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2078
2079         Reviewed by Mark.
2080
2081         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2082         when querying for QMAKE_MKSPECS.
2083
2084 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2085
2086         Reviewed by Adam Roben.
2087         
2088         Fix run-webkit-tests is too greedy calculating platform hierarchy
2089         http://bugs.webkit.org/show_bug.cgi?id=15465
2090         
2091         Fix run-webkit-tests being too greedy in trying to split the platform name up
2092         causing it to try and find tests in every directory above the first "-" in the
2093         path to the LayoutTests
2094
2095         * Scripts/run-webkit-tests:
2096
2097 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2098
2099         Reviewed by Darin.
2100
2101         http://bugs.webkit.org/show_bug.cgi?id=15006
2102         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2103         to reduce code duplication.
2104
2105         * Scripts/build-webkit:
2106         * Scripts/webkitdirs.pm:
2107         buildQMakeProject() renamed to buildQMakeQtProject().
2108         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2109         unused $colorize has been removed.
2110
2111 === Start merge of feature-branch 2007-10-12 ===
2112
2113 2007-10-08  Eric Seidel  <eric@webkit.org>
2114
2115         Reviewed by Mark Rowe.
2116
2117         * Scripts/build-webkit: add --help, remove unused --color
2118
2119 2007-10-07  Eric Seidel  <eric@webkit.org>
2120
2121         Reviewed by darin.
2122
2123         * Drosera/mac/DebuggerDocumentPlatform.mm:
2124         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2125
2126 2007-10-03  Rob Buis  <buis@kde.org>
2127
2128         Reviewed by Olliej.
2129
2130         Adapt to changed location of Ahem font.
2131
2132         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2133
2134 2007-10-02  Eric Seidel  <eric@webkit.org>
2135
2136         Reviewed by Adam Roben.
2137         
2138         Make pixel tests more useful!
2139         Finally fix the image diff 0.00% mystery problem
2140         Highlight any image differences in the image diff.
2141         Add a link from image diffs back to original test file.
2142
2143         * DumpRenderTree/mac/ImageDiff.m:
2144         (compareImages): highlight any differences
2145         (computePercentageDifferent): round to two decimal places
2146         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2147
2148 2007-10-02  Eric Seidel  <eric@webkit.org>
2149
2150         Reviewed by Alexey Proskuryakov.
2151
2152         * Scripts/run-webkit-tests: print the % image difference on main results page
2153
2154 2007-10-02  Mark Rowe  <mrowe@apple.com>
2155
2156         Reviewed by Oliver.
2157
2158         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2159
2160         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2161         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2162
2163 2007-10-01  Mark Rowe  <mrowe@apple.com>
2164
2165         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2166
2167 2007-09-25  Eric Seidel  <eric@webkit.org>
2168
2169         Reviewed by Mark Rowe.
2170         
2171         DerivedSources.make was finding "ENABLE_SVG" in the string
2172         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2173         quite correctly.
2174
2175         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2176
2177 2007-09-25  Mark Rowe  <mrowe@apple.com>
2178
2179         Rubber-stamped by Eric.
2180
2181         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2182         This makes it possible to automate nightly builds for the feature-branch.
2183
2184 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2185
2186         Rubber stamped by Mark.
2187
2188         Enable svg experimental features as default here in feature-branch.
2189
2190         * Scripts/build-webkit:
2191
2192 2007-06-29  Antti Koivisto  <antti@apple.com>
2193
2194         Reviewed by Weinig.
2195         
2196         Add VIDEO flag for timed media features
2197
2198         * Scripts/build-webkit
2199         
2200 === End merge of feature-branch 2007-10-12 ===
2201
2202 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2203
2204         Reviewed by Darin.
2205
2206         - Updated rational for the leaks list to be more clear.
2207
2208         * Scripts/run-webkit-tests:
2209
2210 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2211
2212         Rubber Stamp by Sam.
2213
2214         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2215         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2216
2217         * Scripts/run-webkit-tests:
2218
2219 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2220
2221         Reviewed by Lars.
2222
2223         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2224         includes are needed for INT_MAX, std::auto_ptr and the like.
2225
2226         * DumpRenderTree/qt/main.cpp:
2227
2228 2007-10-09  Lars Knoll  <lars@trolltech.com>
2229
2230         Reviewed by Simon.
2231
2232         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2233
2234         * DumpRenderTree/qt/jsobjects.cpp:
2235         (LayoutTestController::encodeHostName):
2236         (LayoutTestController::decodeHostName):
2237         * DumpRenderTree/qt/jsobjects.h:
2238
2239 2007-10-09  Lars Knoll  <lars@trolltech.com>
2240
2241         Reviewed by Simon.
2242
2243         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2244
2245         * DumpRenderTree/qt/DumpRenderTree.cpp:
2246         (WebCore::WebPage::createFrame):
2247         (WebCore::DumpRenderTree::DumpRenderTree):
2248         (WebCore::DumpRenderTree::titleChanged):
2249         * DumpRenderTree/qt/DumpRenderTree.h:
2250         * DumpRenderTree/qt/jsobjects.cpp:
2251         (LayoutTestController::reset):
2252         * DumpRenderTree/qt/jsobjects.h:
2253
2254 2007-10-09  Lars Knoll  <lars@trolltech.com>
2255
2256         Reviewed by Simon.
2257
2258         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2259
2260         * DumpRenderTree/qt/DumpRenderTree.h:
2261         * DumpRenderTree/qt/jsobjects.cpp:
2262         (LayoutTestController::clearBackForwardList):
2263         * DumpRenderTree/qt/jsobjects.h:
2264
2265 2007-10-09  Lars Knoll  <lars@trolltech.com>
2266
2267         Reviewed by Simon.
2268
2269         make --git-reviewer work again.
2270
2271         * Scripts/prepare-ChangeLog:
2272
2273 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2274
2275         Rubber stamped by Eric.
2276
2277         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2278         show the current link inside the statusbar.
2279         This shows how to make use of this signal and allows to easily test
2280         http://bugs.webkit.org/show_bug.cgi?id=15299.
2281
2282         * GtkLauncher/main.cpp:
2283         (hoveringOverLink):
2284         (main):
2285
2286 2007-10-05  Lars Knoll  <lars@trolltech.com>
2287
2288         add proper error messages to the FrameLoaderClient.
2289         Implement ChromeClientQt::closeWindowSoon and
2290         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2291         Some fixes in DRT to make it work correctly with multiple windows.
2292
2293         Reviewed by Maciej.
2294
2295         * DumpRenderTree/qt/DumpRenderTree.cpp:
2296         (WebCore::DumpRenderTree::DumpRenderTree):
2297         (WebCore::DumpRenderTree::createWindow):
2298         (WebCore::DumpRenderTree::windowCount):
2299         * DumpRenderTree/qt/DumpRenderTree.h:
2300         * DumpRenderTree/qt/jsobjects.cpp:
2301         (LayoutTestController::maybeDump):
2302         (LayoutTestController::windowCount):
2303         * DumpRenderTree/qt/jsobjects.h:
2304
2305 2007-10-05  Lars Knoll  <lars@trolltech.com>
2306
2307         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2308         Add support for layoutTextController.setCanOpenWindows() to DRT
2309         fixing another 2 test cases in fast/dom/Window.
2310
2311         Reviewed by Maciej.
2312
2313         * DumpRenderTree/qt/DumpRenderTree.cpp:
2314         (WebCore::WebPage::WebPage):
2315         (WebCore::WebPage::createWindow):
2316         (WebCore::DumpRenderTree::resetJSObjects):
2317         (WebCore::DumpRenderTree::createWindow):
2318         * DumpRenderTree/qt/DumpRenderTree.h:
2319         * DumpRenderTree/qt/DumpRenderTree.pro:
2320         * DumpRenderTree/qt/jsobjects.cpp:
2321         (LayoutTestController::LayoutTestController):
2322         (LayoutTestController::reset):
2323         * DumpRenderTree/qt/jsobjects.h:
2324         * DumpRenderTree/qt/main.cpp:
2325         * DumpRenderTree/qt/testplugin.cpp: Added.
2326         * DumpRenderTree/qt/testplugin.h: Added.
2327
2328 2007-10-04  Sam Weinig  <sam@webkit.org>
2329
2330         Rubber stamped by Adam.
2331
2332         Remove empty directories.
2333
2334         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2335         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2336
2337 2007-10-03  Darin Adler  <darin@apple.com>
2338
2339         Reviewed by Adam.
2340
2341         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2342         we find the internal libraries in the libraries directory. This
2343         is helpful for Safari team engineers at Apple.
2344
2345 2007-10-03  Adam Roben  <aroben@apple.com>
2346
2347         Update the location of AHEM___.TTF after r25968
2348
2349         Reviewed by Sam.
2350
2351         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2352
2353 2007-10-03  Alp Toker  <alp@atoker.com>
2354
2355         Reviewed by Adam.
2356
2357         http://bugs.webkit.org/show_bug.cgi?id=14726
2358         [gtk] API design. Mapping the WebView delegates to signals.
2359
2360         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2361
2362         * GtkLauncher/main.cpp:
2363         (goToURLBarText):
2364         (titleChanged):
2365         (progressChanged):
2366         (menuMainBackCallback):
2367         (menuMainForwardCallback):
2368         (main):
2369
2370 2007-10-03  Lars Knoll  <lars@trolltech.com>
2371
2372         Reviewed by Rob.
2373
2374         This fixes --strict mode in run-webkit-tests again after
2375         the platform dependent test results have been moved.
2376
2377         * Scripts/run-webkit-tests:
2378
2379 2007-10-03  Lars Knoll  <lars@trolltech.com>
2380
2381         Reviewed by bdash.
2382
2383         remove the hack in run-webkit-tests that forced text only test
2384         to be taken from the platform independent dir. It was only left
2385         there from early days.
2386         
2387         Remove platform dependent results for tests that are text only nowadays,
2388         and add one platform dependent result for a text only test that requires it.
2389
2390         * Scripts/run-webkit-tests:
2391
2392 2007-10-03  Lars Knoll  <lars@trolltech.com>
2393
2394         Reviewed by olliej.
2395
2396         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2397
2398         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2399         (WebCore::WebFrame::WebFrame):
2400         (WebCore::WebPage::WebPage):
2401         (WebCore::WebPage::createFrame):
2402         (WebCore::WebPage::javaScriptAlert):
2403         (WebCore::WebPage::javaScriptConsoleMessage):
2404         (WebCore::DumpRenderTree::DumpRenderTree):
2405         (WebCore::DumpRenderTree::~DumpRenderTree):
2406         (WebCore::DumpRenderTree::open):
2407         (WebCore::DumpRenderTree::readStdin):
2408         (WebCore::DumpRenderTree::resetJSObjects):
2409         (WebCore::DumpRenderTree::initJSObjects):
2410         (WebCore::DumpRenderTree::dumpFramesAsText):
2411         (WebCore::DumpRenderTree::dump):
2412         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2413         (WebCore::DumpRenderTree::layoutTestController):
2414         (WebCore::DumpRenderTree::eventSender):
2415         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2416         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2417         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2418         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2419         (HackWebFrame::mousePressEvent):
2420         (HackWebFrame::mouseReleaseEvent):
2421         (HackWebFrame::mouseMoveEvent):
2422         (HackWebFrame::HackWebFrame):
2423         (HackWebFrame::~HackWebFrame):
2424         (LayoutTestController::LayoutTestController):
2425         (LayoutTestController::reset):
2426         (LayoutTestController::maybeDump):
2427         (LayoutTestController::waitUntilDone):
2428         (LayoutTestController::notifyDone):
2429         (LayoutTestController::dumpEditingCallbacks):
2430         (LayoutTestController::queueReload):
2431         (LayoutTestController::provisionalLoad):
2432         (LayoutTestController::timerEvent):
2433         (EventSender::EventSender):
2434         (EventSender::mouseDown):
2435         (EventSender::mouseUp):
2436         (EventSender::mouseMoveTo):
2437         (EventSender::leapForward):
2438         (EventSender::keyDown):
2439         (EventSender::frameUnderMouse):
2440         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2441         (LayoutTestController::isLoading):
2442         (LayoutTestController::setLoading):
2443         (LayoutTestController::shouldDumpAsText):
2444         (LayoutTestController::shouldDumpChildrenAsText):
2445         (LayoutTestController::shouldWaitUntilDone):
2446         (LayoutTestController::dumpAsText):
2447         (LayoutTestController::dumpChildFramesAsText):
2448         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2449         (messageHandler):
2450         (crashHandler):
2451         (main):
2452         * Scripts/run-webkit-tests:
2453
2454 2007-10-03  Mark Rowe  <mrowe@apple.com>
2455
2456         Reviewed by Alp Toker.
2457
2458         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2459         should take precedence over QTDIR when determining which port we are working with.
2460
2461         * Scripts/webkitdirs.pm: 
2462
2463 2007-10-02  Adam Roben  <aroben@apple.com>
2464
2465         Add keychain to the list of default packages to install
2466
2467         Rubberstamped by Sam.
2468
2469         * CygwinDownloader/cygwin-downloader.py:
2470         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2471
2472 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2473
2474         Reviewed by Adam.
2475
2476         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2477         Also makes WebCore regression test case logic work when using git.
2478
2479         * Scripts/prepare-ChangeLog:
2480         (reviewerAndDescriptionForGitCommit): Added.
2481
2482 2007-10-02  Lars Knoll  <lars@trolltech.com>
2483
2484         Reviewed by bdash.
2485
2486         Add API to retrieve the frame name from QWebFrame.
2487         Implement support for DRT::dumpChildrenAsText.
2488
2489         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2490         (WebCore::DumpRenderTree::dumpFramesAsText):
2491         (WebCore::DumpRenderTree::dump):
2492         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2493         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2494         (LayoutTestController::LayoutTestController):
2495         (LayoutTestController::reset):
2496         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2497
2498 2007-10-02  Lars Knoll  <lars@trolltech.com>
2499
2500         Reviewed by bdash.
2501
2502         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2503
2504         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2505         (WebCore::DumpRenderTree::readStdin):
2506
2507 2007-10-02  Mark Rowe  <mrowe@apple.com>
2508
2509         Reviewed by Oliver.
2510
2511         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2512
2513         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2514         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2515
2516 2007-10-02  Mark Rowe  <mrowe@apple.com>
2517
2518         Rubber-stamped by Maciej.
2519
2520         Configuration changes from build.webkit.org.  The major change is refactoring to work
2521         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2522         last few weeks.
2523
2524         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2525         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2526         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2527         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2528         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2529         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2530         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2531         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2532
2533 2007-10-02  Lars Knoll  <lars@trolltech.com>
2534
2535         Reviewed by Maciej.
2536
2537         Add support for eventSender.mouseMove to DRT.
2538         Fixes fast/css/hover-affects-child.html
2539
2540         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2541         (EventSender::mouseMoveTo):
2542
2543 2007-10-01  Mark Rowe  <mrowe@apple.com>
2544
2545         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2546
2547 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2548
2549         Reviewed by Hyatt.
2550
2551         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2552
2553         * Scripts/svn-apply:
2554         (gitdiff2svndiff): Ignore lines beginning with "new file".
2555         * Scripts/svn-unapply:
2556         (gitdiff2svndiff): Ditto.
2557
2558 2007-09-30  George Staikos  <staikos@kde.org>
2559
2560         Qt build fix (Mac OS X specific)
2561
2562         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2563
2564 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2565
2566         Reviewed by Mark.
2567
2568         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2569         Remove Bakefiles from svn.
2570
2571         * GtkLauncher/Bakefiles.bkgen: Removed.
2572         * GtkLauncher/ENV: Removed.
2573         * GtkLauncher/gdklauncher.bkl: Removed.
2574         * GtkLauncher/mk: Removed.
2575         * Scripts/regenerate-makefiles: Removed.
2576
2577 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2578
2579         Reviewed by John.
2580
2581         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2582
2583         * Scripts/run-webkit-tests:
2584
2585 2007-09-26  Adam Roben  <aroben@apple.com>
2586
2587         Make not finding an installed WebKit non-fatal
2588
2589         What really matters is that we are able to load WebKit and its
2590         dependencies, not whether we think we've found an installed WebKit.
2591
2592         Reviewed by Sam.
2593
2594         * WebKitInitializer/WebKitInitializer.cpp:
2595         (getWebViewCLSID): Use new LOG_WARNING macro.
2596         (getInstalledWebKitDirectory): Ditto.
2597         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2598         and use new macros.
2599         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2600
2601 2007-09-26  Adam Roben  <aroben@apple.com>
2602
2603         Committed this file before saving it
2604
2605         * WebKitInitializer/debug_internal.vsprops:
2606
2607 2007-09-26  Adam Roben  <aroben@apple.com>
2608
2609         Load WebKit and its dependencies manually so they come from DllDirectory
2610
2611         I had to change WebKitInitializer to use malloc/free instead of
2612         new/delete to avoid pulling in WebKit (and its dependencies) early
2613         through use of fastMalloc.
2614
2615         Reviewed by Oliver.
2616
2617         * WebKitInitializer/WebKitInitializer.cpp:
2618         (getStringValue): Changed to use malloc/free.
2619         (getInstalledWebKitDirectory): Ditto.
2620         (initializeWebKit): Call SetDllDirectory first, then load all of
2621         WebKit's dependencies manually, finally followed by WebKit itself.
2622         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2623         configuration to match our other projects.
2624         * WebKitInitializer/debug_internal.vsprops: Added.
2625
2626 2007-09-25  Adam Roben  <aroben@apple.com>
2627
2628         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2629
2630         Rubberstamped by Sam.
2631
2632         * WebKitInitializer/WebKitInitializer.vcproj:
2633
2634 2007-09-25  Adam Roben  <aroben@apple.com>
2635
2636         Make DumpRenderTree delay-load its dependencies
2637
2638         This lets WebKitInitializer re-route the dependencies to be loaded out
2639         of the Safari installation directory.
2640
2641         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2642         same thing), since we can't import the kCFAllocatorDefault symbol when
2643         delay-loading CoreFoundation.dll.
2644
2645         Rubberstamped by Sam.
2646
2647         * DumpRenderTree/win/DumpRenderTree.cpp:
2648         (runTest):
2649         (javaScriptThreads):
2650         * DumpRenderTree/win/DumpRenderTree.vcproj:
2651         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2652         (LayoutTestController::setWaitToDump):
2653
2654 2007-09-25  Adam Roben  <aroben@apple.com>
2655
2656         Pull ole32.lib into WebKitInitializer
2657
2658         Rubberstamped by Sam.
2659
2660         * WebKitInitializer/WebKitInitializer.vcproj:
2661
2662 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2663
2664         Reviewed by Adam.
2665
2666         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2667           LGPL'ed files contain incorrect FSF address
2668
2669         * Drosera/config.h:
2670
2671 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2672
2673         Reviewed by Adam.
2674
2675         Make svn-apply and svn-unapply work with git-diff formatted patches.
2676
2677         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2678         (gitdiff2svndiff): Added.
2679         * Scripts/svn-unapply: Ditto.
2680         (gitdiff2svndiff): Added.
2681
2682 2007-09-25  Adam Roben  <aroben@apple.com>
2683
2684         Pull advapi32.lib into WebKitInitializer
2685
2686         This is needed to get the registry functions we use.
2687
2688         Rubberstamped by Sam.
2689
2690         * WebKitInitializer/WebKitInitializer.vcproj:
2691
2692 2007-09-25  Adam Roben  <aroben@apple.com>
2693
2694         Add python and rsync to cygwin-downloader
2695
2696         Our build slaves need this, and it can't hurt for everyone else to
2697         have it, too.
2698
2699         Reviewed by Sam.
2700
2701         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2702         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2703
2704 2007-09-25  Adam Roben  <aroben@apple.com>
2705
2706         Add WebKitInitializer and use it in DumpRenderTree
2707
2708         WebKitInitializer is a static library that has one function,
2709         initializeWebKit(). This registers WebKit and sets up the DLL search
2710         path so that WebKit's dependencies that are installed with Safari can
2711         be found.
2712
2713         Reviewed by Sam.
2714
2715         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2716         DumpRenderTree depend on it.
2717         * DumpRenderTree/win/DumpRenderTree.cpp:
2718         (initialize): Call initializeWebKit.
2719         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2720         WebKitInitializer.lib.
2721         * WebKitInitializer/WebKitInitializer.cpp: Added.
2722         (getStringValue):
2723         (getWebViewCLSID):
2724         (getInstalledWebKitDirectory):
2725         (initializeWebKit):
2726         * WebKitInitializer/WebKitInitializer.h: Added.
2727         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2728         * WebKitInitializer/debug.vsprops: Added.
2729         * WebKitInitializer/release.vsprops: Added.
2730
2731 2007-09-25  Adam Roben  <aroben@apple.com>
2732
2733         Make run-webkit-tests respect set-webkit-configuration
2734
2735         Reviewed by Sam.
2736
2737         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2738         set-webkit-configuration was last set to.
2739
2740 2007-09-25  Mark Rowe  <mrowe@apple.com>
2741
2742         Rubber-stamped by Eric.
2743
2744         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2745         This makes it possible to automate nightly builds for the feature-branch.
2746
2747 2007-09-25  Adam Roben  <aroben@apple.com>
2748
2749         A couple of fixes/enhancements to update-webkit-*-libs
2750
2751         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2752         to tell update-webkit-support-libraries where it should find the
2753         WebKitSupportLibrary.zip file you downloaded.
2754
2755         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2756         Windows-style path.
2757
2758         Reviewed by Sam.
2759
2760         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2761         to $auxiliaryLibsURL and removed an irrelevant comment.
2762         * Scripts/update-webkit-support-libs:
2763
2764 2007-09-25  Adam Treat  <treat@kde.org>
2765
2766         Reviewed by Simon and Lars.
2767
2768         Refactors and cleans up Qt DRT member variable names, member variable
2769         initialization, style fixes and general code cleanup.
2770
2771         Adds queueReload slot to LayoutTestController that some tests require.
2772
2773         Subclasses QWebFrame to make sure that all frames have an associated
2774         LayoutTestController JS window object.
2775
2776         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2777         aren't dumped twice.
2778
2779         EOF fixes.
2780
2781         Together, this patch fixes some 20+ layout tests in QtWebKit.
2782
2783         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2784         (WebCore::WebFrame::WebFrame):
2785         (WebCore::WebPage::WebPage):
2786         (WebCore::WebPage::createFrame):
2787         (WebCore::DumpRenderTree::DumpRenderTree):
2788         (WebCore::DumpRenderTree::open):
2789         (WebCore::DumpRenderTree::readStdin):
2790         (WebCore::DumpRenderTree::initJSObjects):
2791         (WebCore::DumpRenderTree::dump):
2792         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2793         (WebCore::DumpRenderTree::layoutTestController):
2794         (WebCore::DumpRenderTree::eventSender):
2795         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2796         (LayoutTestController::LayoutTestController):
2797         (LayoutTestController::reset):
2798         (LayoutTestController::maybeDump):
2799         (LayoutTestController::waitUntilDone):
2800         (LayoutTestController::notifyDone):
2801         (LayoutTestController::queueReload):
2802         (LayoutTestController::provisionalLoad):
2803         (EventSender::EventSender):
2804         (EventSender::mouseDown):
2805         (EventSender::mouseUp):
2806         (EventSender::mouseMoveTo):
2807         (EventSender::frameUnderMouse):
2808         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2809         (LayoutTestController::isLoading):
2810         (LayoutTestController::setLoading):
2811         (LayoutTestController::dumpAsText):
2812         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2813         (main):
2814
2815 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2816
2817
2818         - Reverted an accidentally checked in file.
2819
2820         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2821
2822 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2823         Reviewed by Sam.
2824
2825         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2826
2827         * DumpRenderTree/win/DumpRenderTree.vcproj:
2828         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2829
2830 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2831
2832         Rubber stamped by Adam.
2833
2834         * GdkLauncher: Removed.
2835         * GdkLauncher/Bakefiles.bkgen: Removed.
2836         * GdkLauncher/ENV: Removed.
2837         * GdkLauncher/GdkLauncher.pro: Removed.
2838         * GdkLauncher/gdklauncher.bkl: Removed.
2839         * GdkLauncher/main.cpp: Removed.
2840         * GdkLauncher/mk: Removed.
2841         * GdkLauncher/simple.svg: Removed.
2842         * GdkLauncher/text.html: Removed.
2843         * GtkLauncher: Added.
2844         * GtkLauncher/GdkLauncher.pro: Removed.
2845         * GtkLauncher/GtkLauncher.pro: Added.
2846         * GtkLauncher/main.cpp:
2847         (updateWindowTitle):
2848         (main):
2849         * Scripts/build-webkit:
2850         * Scripts/regenerate-makefiles:
2851         * Scripts/run-javascriptcore-tests:
2852         * Scripts/run-launcher:
2853         * Scripts/run-webkit-tests:
2854         * Scripts/webkitdirs.pm:
2855
2856 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2857
2858         Reviewed by Darin.
2859
2860         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2861
2862         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2863         This is tested by plugins/root-object-premature-delete-crash.html.
2864
2865         * DumpRenderTree/mac/ObjCController.m:
2866         (-[ObjCController accessStoredWebScriptObject]):
2867
2868 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2869
2870         Reviewed by Oliver.
2871
2872         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2873
2874         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2875         (FrameLoadDelegate::FrameLoadDelegate):
2876
2877 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2878
2879         Reviewed by Adam.
2880
2881         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2882         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2883
2884         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2885         Now isQt() and isGdk() use global variables that are only set once.
2886
2887         An array of all the parameters is now given to build-dumprender which includes
2888         the platform on linux.
2889
2890         * Scripts/build-dumprendertree:
2891         * Scripts/run-webkit-tests:
2892         * Scripts/webkitdirs.pm:
2893
2894 2007-09-19  Adam Roben  <aroben@apple.com>
2895
2896         Rubberstamped by Hyatt.
2897
2898         * Spinneret: Removed.
2899
2900 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2901
2902         Reviewed by David Kilzer.
2903
2904         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2905
2906 2007-09-18  Sam Weinig  <sam@webkit.org>
2907
2908         Add JSRetainPtr.h #include to fix some builds.
2909
2910         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2911
2912 2007-09-18  Mike Hommey  <glandium@debian.org>
2913
2914         Reviewed by Adam.
2915
2916         * Scripts/prepare-ChangeLog:
2917         - Properly parse GECOS field.
2918         - Use git configuration for user name and email when appropriate.
2919
2920 2007-09-17  Sam Weinig  <sam@webkit.org>
2921
2922         Build fix.
2923
2924         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2925
2926 2007-09-17  Sam Weinig  <sam@webkit.org>
2927
2928         Reviewed by Adam Roben.
2929
2930         Share more code between mac and windows DRT.
2931             - GCController is now shared.
2932             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2933
2934         * DumpRenderTree/GCController.cpp:
2935         * DumpRenderTree/win/DumpRenderTree.cpp:
2936         * DumpRenderTree/win/DumpRenderTree.vcproj:
2937         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2938         (FrameLoadDelegate::FrameLoadDelegate):
2939         (FrameLoadDelegate::~FrameLoadDelegate):
2940         (FrameLoadDelegate::windowScriptObjectAvailable):
2941         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2942         * DumpRenderTree/win/GCController.cpp: Removed.
2943         * DumpRenderTree/win/GCController.h: Removed.
2944         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2945         (GCController::collect):
2946         (GCController::collectOnAlternateThread):
2947         (GCController::getJSObjectCount):
2948         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2949         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2950
2951 2007-09-17  Sam Weinig  <sam@webkit.org>
2952
2953         Reviewed by Adam Roben.
2954
2955         Begin sharing code between mac and windows DRT.
2956             - both now share LayoutTestController.h/cpp and implement platform dependant 
2957               operations in LayoutTestControllerMac/Win.
2958             - DumpRenderTree.h is now shared.
2959             - WorkQueue and WorkQueueItem are also shared.
2960
2961         * DumpRenderTree/DumpRenderTree.h:
2962         * DumpRenderTree/LayoutTestController.cpp:
2963         * DumpRenderTree/win/DumpRenderTree.cpp:
2964         (displayWebView):
2965         (dumpFrameScrollPosition):
2966         (dumpFramesAsText):
2967         (dump):
2968         (runTest):
2969         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2970         * DumpRenderTree/win/DumpRenderTree.vcproj:
2971         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2972         * DumpRenderTree/win/EditingDelegate.cpp:
2973         (EditingDelegate::shouldBeginEditingInDOMRange):
2974         (EditingDelegate::shouldEndEditingInDOMRange):
2975         (EditingDelegate::shouldInsertNode):
2976         (EditingDelegate::shouldInsertText):
2977         (EditingDelegate::shouldDeleteDOMRange):
2978         (EditingDelegate::shouldChangeSelectedDOMRange):
2979         (EditingDelegate::shouldApplyStyle):
2980         (EditingDelegate::shouldChangeTypingStyle):
2981         (EditingDelegate::doPlatformCommand):
2982         (EditingDelegate::webViewDidBeginEditing):
2983         (EditingDelegate::webViewDidChange):
2984         (EditingDelegate::webViewDidEndEditing):
2985         (EditingDelegate::webViewDidChangeTypingStyle):
2986         (EditingDelegate::webViewDidChangeSelection):
2987         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2988         * DumpRenderTree/win/LayoutTestController.h: Removed.
2989         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2990         (LayoutTestController::addDisallowedURL):
2991         (LayoutTestController::clearBackForwardList):
2992         (LayoutTestController::copyDecodedHostName):
2993         (LayoutTestController::copyEncodedHostName):
2994         (LayoutTestController::display):
2995         (LayoutTestController::keepWebHistory):
2996         (LayoutTestController::notifyDone):
2997         (LayoutTestController::queueBackNavigation):
2998         (LayoutTestController::queueForwardNavigation):
2999         (jsStringRefToWString):
3000         (LayoutTestController::queueLoad):
3001         (LayoutTestController::queueReload):
3002         (LayoutTestController::queueScript):
3003         (LayoutTestController::setAcceptsEditing):
3004         (LayoutTestController::setCustomPolicyDelegate):
3005         (LayoutTestController::setMainFrameIsFirstResponder):
3006         (LayoutTestController::setTabKeyCyclesThroughElements):
3007         (LayoutTestController::setUseDashboardCompatibilityMode):
3008         (LayoutTestController::setUserStyleSheetEnabled):
3009         (LayoutTestController::setUserStyleSheetLocation):
3010         (LayoutTestController::setWindowIsKey):
3011         (waitUntilDoneWatchdogFired):
3012         (LayoutTestController::setWaitToDump):
3013         (LayoutTestController::windowCount):
3014         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3015         (FrameLoadDelegate::didReceiveTitle):
3016         (FrameLoadDelegate::processWork):
3017         (FrameLoadDelegate::locationChangeDone):
3018         (FrameLoadDelegate::windowScriptObjectAvailable):
3019         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3020         * DumpRenderTree/win/WorkQueue.h: Removed.
3021         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3022         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3023         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3024         (jsStringRefToWString):
3025         (LoadItem::invoke):
3026         (ScriptItem::invoke):
3027
3028 2007-09-17  Sam Weinig  <sam@webkit.org>
3029
3030         Reviewed by Adam Roben.
3031
3032         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3033
3034         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3035         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3036         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3037         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3038         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3039         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3040         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3041         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3042         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3043         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3044         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3045         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3046         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3047         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3048         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3049         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3050         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3051         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3052         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3053         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3054         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3055         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3056         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3057         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3058         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3059         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3060         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3061         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3062         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3063         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3064         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3065         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3066         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3067         * DumpRenderTree/win: Added.
3068         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3069         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3070         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3071         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3072         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3073         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3074         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3075         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3076         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3077         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3078         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3079         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3080         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3081         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3082         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3083         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3084         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3085         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3086         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3087         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3088         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3089         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3090         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3091         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3092         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3093         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3094
3095 2007-09-15  Mark Rowe  <mrowe@apple.com>
3096
3097         Build fix for DumpRenderTree.
3098
3099         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3100
3101 2007-09-14  Sam Weinig  <sam@webkit.org>
3102
3103         Rubber stamped by Adam Roben.
3104
3105         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3106           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3107             kept in the WaitUntilDoneDelegate file for the time being.
3108
3109         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3110         (main):
3111         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3112         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3113         (UIDelegate::QueryInterface):
3114         (UIDelegate::AddRef):
3115         (UIDelegate::Release):
3116         (UIDelegate::hasCustomMenuImplementation):
3117         (UIDelegate::setFrame):
3118         (UIDelegate::webViewFrame):
3119         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3120         (UIDelegate::webViewAddMessageToConsole):
3121         (UIDelegate::doDragDrop):
3122         (UIDelegate::webViewGetDlgCode):
3123         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3124         (UIDelegate::UIDelegate):
3125         (UIDelegate::createWebViewWithRequest):
3126         (UIDelegate::webViewShow):
3127         (UIDelegate::webViewClose):
3128         (UIDelegate::webViewFocus):
3129         (UIDelegate::webViewUnfocus):
3130         (UIDelegate::webViewFirstResponder):
3131         (UIDelegate::makeFirstResponder):
3132         (UIDelegate::setStatusText):
3133         (UIDelegate::webViewStatusText):
3134         (UIDelegate::webViewAreToolbarsVisible):
3135         (UIDelegate::setToolbarsVisible):
3136         (UIDelegate::webViewIsStatusBarVisible):
3137         (UIDelegate::setStatusBarVisible):
3138         (UIDelegate::webViewIsResizable):
3139         (UIDelegate::setResizable):
3140         (UIDelegate::setContentRect):
3141         (UIDelegate::webViewContentRect):
3142         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3143         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3144         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3145         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
3146         (UIDelegate::mouseDidMoveOverElement):
3147         (UIDelegate::contextMenuItemsForElement):
3148         (UIDelegate::validateUserInterfaceItem):
3149         (UIDelegate::shouldPerformAction):
3150         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
3151         (UIDelegate::willPerformDragDestinationAction):
3152         (UIDelegate::dragSourceActionMaskForPoint):
3153         (UIDelegate::willPerformDragSourceAction):
3154         (UIDelegate::contextMenuItemSelected):
3155         (UIDelegate::trackCustomPopupMenu):
3156         (UIDelegate::measureCustomMenuItem):
3157         (UIDelegate::drawCustomMenuItem):
3158         (UIDelegate::addCustomMenuDrawingData):
3159         (UIDelegate::cleanUpCustomMenuDrawingData):
3160         (UIDelegate::canTakeFocus):
3161         (UIDelegate::takeFocus):
3162         (UIDelegate::registerUndoWithTarget):
3163         (UIDelegate::removeAllActionsWithTarget):
3164         (UIDelegate::setActionTitle):
3165         (UIDelegate::undo):
3166         (UIDelegate::redo):
3167         (UIDelegate::canUndo):
3168         (UIDelegate::canRedo):
3169         (UIDelegate::webViewResizerRect):
3170         (UIDelegate::webViewDrawResizer):
3171         (UIDelegate::webViewScrolled):
3172         (UIDelegate::webViewShouldInterruptJavaScript):
3173         (UIDelegate::webViewReceivedFocus):
3174         (UIDelegate::webViewLostFocus):
3175         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3176         (FrameLoadDelegate::QueryInterface):
3177         (FrameLoadDelegate::AddRef):
3178         (FrameLoadDelegate::Release):
3179         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3180         (FrameLoadDelegate::didCommitLoadForFrame):
3181         (FrameLoadDelegate::didReceiveTitle):
3182         (FrameLoadDelegate::processWork):
3183         (processWorkTimer):
3184         (FrameLoadDelegate::locationChangeDone):
3185         (FrameLoadDelegate::didFinishLoadForFrame):
3186         (FrameLoadDelegate::didFailLoadWithError):
3187         (FrameLoadDelegate::windowScriptObjectAvailable):
3188         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
3189         (FrameLoadDelegate::FrameLoadDelegate):
3190
3191 2007-09-14  Sam Weinig  <sam@webkit.org>
3192
3193         Reviewed by Kevin McCullough.
3194
3195         Move mac specific globals in to mac/DumpRenderTreeMac.h
3196
3197         * DumpRenderTree/DumpRenderTree.h:
3198         * DumpRenderTree/DumpRenderTree.mm: Removed.
3199         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3200         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
3201         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
3202
3203 2007-09-14  Brady Eidson  <beidson@apple.com>
3204
3205         Rubberstamped by Weinig
3206
3207         You know, Sam, some of us use case-sensitve filesystems...
3208
3209         * DumpRenderTree/DumpRenderTree.h:
3210         * DumpRenderTree/mac/UIDelegate.mm:
3211
3212 2007-09-14  Sam Weinig  <sam@webkit.org>
3213
3214         Rubber stamped by Adam Roben.
3215
3216         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
3217         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
3218
3219         * DumpRenderTree/AppleScriptController.h: Removed.
3220         * DumpRenderTree/AppleScriptController.m: Removed.
3221         * DumpRenderTree/DumpRenderTree.h:
3222         * DumpRenderTree/DumpRenderTree.mm:
3223         (startJavaScriptThreads):
3224         (stopJavaScriptThreads):
3225         (activateAhemFont):
3226         (setDefaultColorProfileToRGB):
3227         (makeLargeMallocFailSilently):
3228         (dumpFrameScrollPosition):
3229         (dumpFramesAsText):
3230         (dump):
3231         (runTest):
3232         (-[DumpRenderTreeWindow isKeyWindow]):
3233         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3234         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
3235         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
3236         * DumpRenderTree/EditingDelegate.h: Removed.
3237         * DumpRenderTree/EditingDelegate.m: Removed.
3238         * DumpRenderTree/EventSendingController.h: Removed.
3239         * DumpRenderTree/EventSendingController.m: Removed.
3240         * DumpRenderTree/FrameLoadDelegate.h: Removed.
3241         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
3242         * DumpRenderTree/GCController.mm: Removed.
3243         * DumpRenderTree/ImageDiff.m: Removed.
3244         * DumpRenderTree/LayoutTestController.cpp:
3245         (LayoutTestController::LayoutTestController):
3246         (dumpAsTextCallback):
3247         (dumpBackForwardListCallback):
3248         (dumpChildFramesAsTextCallback):
3249         (dumpChildFrameScrollPositionsCallback):
3250         (dumpDOMAsWebArchiveCallback):
3251         (dumpEditingCallbacksCallback):
3252         (dumpFrameLoadCallbacksCallback):
3253         (dumpResourceLoadCallbacksCallback):
3254         (dumpSelectionRectCallback):
3255         (dumpSourceAsWebArchiveCallback):
3256         (dumpTitleChangesCallback):
3257         (repaintSweepHorizontallyCallback):
3258         (setCallCloseOnWebViewsCallback):
3259         (setCanOpenWindowsCallback):
3260         (setCloseRemainingWindowsWhenCompleteCallback):
3261         (testRepaintCallback):
3262         (addFileToPasteboardOnDragCallback):
3263         (waitUntilDoneCallback):
3264         * DumpRenderTree/LayoutTestController.h:
3265         (LayoutTestController::dumpAsText):
3266         (LayoutTestController::setDumpAsText):
3267         (LayoutTestController::dumpBackForwardList):
3268         (LayoutTestController::setDumpBackForwardList):
3269         (LayoutTestController::dumpChildFrameScrollPositions):
3270         (LayoutTestController::setDumpChildFrameScrollPositions):
3271         (LayoutTestController::dumpChildFramesAsText):
3272         (LayoutTestController::setDumpChildFramesAsText):
3273         (LayoutTestController::dumpDOMAsWebArchive):
3274         (LayoutTestController::setDumpDOMAsWebArchive):
3275         (LayoutTestController::dumpSelectionRect):
3276         (LayoutTestController::setDumpSelectionRect):
3277         (LayoutTestController::dumpSourceAsWebArchive):
3278         (LayoutTestController::setDumpSourceAsWebArchive):
3279         (LayoutTestController::dumpTitleChanges):
3280         (LayoutTestController::setDumpTitleChanges):
3281         (LayoutTestController::dumpEditingCallbacks):
3282         (LayoutTestController::setDumpEditingCallbacks):
3283         (LayoutTestController::dumpResourceLoadCallbacks):
3284         (LayoutTestController::setDumpResourceLoadCallbacks):
3285         (LayoutTestController::dumpFrameLoadCallbacks):
3286         (LayoutTestController::setDumpFrameLoadCallbacks):
3287         (LayoutTestController::addFileToPasteboardOnDrag):
3288         (LayoutTestController::setAddFileToPasteboardOnDrag):
3289         (LayoutTestController::callCloseOnWebViews):
3290         (LayoutTestController::setCallCloseOnWebViews):
3291         (LayoutTestController::canOpenWindows):
3292         (LayoutTestController::setCanOpenWindows):
3293         (LayoutTestController::closeRemainingWindowsWhenComplete):
3294         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3295         (LayoutTestController::testRepaint):
3296         (LayoutTestController::setTestRepaint):
3297         (LayoutTestController::testRepaintSweepHorizontally):
3298         (LayoutTestController::setTestRepaintSweepHorizontally):
3299         (LayoutTestController::waitToDump):
3300         (LayoutTestController::windowIsKey):
3301         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
3302         * DumpRenderTree/NavigationController.h: Removed.
3303         * DumpRenderTree/NavigationController.m: Removed.
3304         * DumpRenderTree/ObjCController.h: Removed.
3305         * DumpRenderTree/ObjCController.m: Removed.
3306         * DumpRenderTree/ObjCPlugin.h: Removed.
3307         * DumpRenderTree/ObjCPlugin.m: Removed.
3308         * DumpRenderTree/ObjCPluginFunction.h: Removed.
3309         * DumpRenderTree/ObjCPluginFunction.m: Removed.
3310         * DumpRenderTree/PolicyDelegate.h: Removed.
3311         * DumpRenderTree/PolicyDelegate.m: Removed.
3312         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
3313         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
3314         * DumpRenderTree/TextInputController.h: Removed.
3315         * DumpRenderTree/TextInputController.m: Removed.
3316         * DumpRenderTree/UIDelegate.h: Removed.
3317         * DumpRenderTree/UIDelegate.mm: Removed.
3318         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3319         * DumpRenderTree/mac: Added.
3320         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3321         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3322         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3323         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3324         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3325         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3326         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3327         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3328         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3329         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3330         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3331         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3332         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3333         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3334         (-[EditingDelegate webViewDidBeginEditing:]):
3335         (-[EditingDelegate webViewDidChange:]):
3336         (-[EditingDelegate webViewDidEndEditing:]):
3337         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3338         (-[EditingDelegate webViewDidChangeSelection:]):
3339         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3340         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3341         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3342         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3343         (-[FrameLoadDelegate init]):
3344         (-[FrameLoadDelegate dealloc]):
3345         (-[FrameLoadDelegate processWork:]):
3346         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3347         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3348         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3349         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3350         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3351         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3352         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3353         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3354         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3355         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3356         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3357         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3358         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3359         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3360         (-[FrameLoadDelegate webView:willCloseFrame:]):
3361         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3362         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3363         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3364         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3365         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3366         (LayoutTestController::notifyDone):
3367         (LayoutTestController::setWindowIsKey):
3368         (LayoutTestController::setWaitToDump):
3369         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3370         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3371         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3372         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3373         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3374         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3375         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3376         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3377         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3378         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3379         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3380         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3381         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3382         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3383         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3384         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3385         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3386         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3387         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3388         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3389         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3390         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3391         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3392         (-[UIDelegate webViewFocus:]):
3393         (-[UIDelegate webView:createWebViewWithRequest:]):
3394         (-[UIDelegate webViewClose:]):
3395         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3396
3397 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3398
3399         Reviewed by Adam.
3400
3401         - Changing Win version of Drosera work with recent changes.
3402
3403         * Drosera/DebuggerDocument.cpp:
3404         * Drosera/DebuggerDocument.h:
3405         * Drosera/mac/DebuggerDocumentPlatform.mm:
3406         (NSStringCreateWithJSStringRef):
3407         (JSValueRefCreateWithNSString):
3408         * Drosera/win/DebuggerClient.cpp:
3409         (DebuggerClient::stepInto):
3410         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3411
3412 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3413
3414         Reviewed by Tim.
3415
3416         - Moved isPaused into the JS for efficiency and simplicity.
3417
3418         * Drosera/DebuggerDocument.cpp:
3419         (DebuggerDocument::DebuggerDocument):
3420         (DebuggerDocument::pauseCallback):
3421         (DebuggerDocument::resumeCallback):
3422         (DebuggerDocument::isPaused):
3423         (DebuggerDocument::staticFunctions):
3424         * Drosera/DebuggerDocument.h:
3425         * Drosera/console.js:
3426         * Drosera/debugger.js:
3427         * Drosera/mac/DebuggerClient.mm:
3428         (-[DebuggerClient validateUserInterfaceItem:]):
3429
3430 2007-09-13  Sam Weinig  <sam@webkit.org>
3431
3432         Rubber stamped by Darin.
3433
3434         Make DumpRenderTree more cross platform ready.
3435         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3436         - Use CF types instead of NS objects.
3437         - General cleanup.
3438
3439         * DumpRenderTree/DumpRenderTree.h:
3440         * DumpRenderTree/DumpRenderTree.mm:
3441         (dumpRenderTree):
3442         (dump):
3443         (runTest):
3444         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3445         * DumpRenderTree/EditingDelegate.m:
3446         * DumpRenderTree/FrameLoadDelegate.h:
3447         * DumpRenderTree/FrameLoadDelegate.mm:
3448         (-[FrameLoadDelegate init]):
3449         (-[FrameLoadDelegate dealloc]):
3450         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3451         * DumpRenderTree/GCController.cpp: Added.
3452         (GCController::GCController):
3453         (GCController::~GCController):
3454         (collectCallback):
3455         (collectOnAlternateThreadCallback):
3456         (getJSObjectCountCallback):
3457         (GCController::makeWindowObject):
3458         (GCController::getJSClass):
3459         (GCController::staticFunctions):
3460         * DumpRenderTree/GCController.h:
3461         * DumpRenderTree/GCController.mm:
3462         (GCController::collect):
3463         (GCController::collectOnAlternateThread):
3464         (GCController::getJSObjectCount):
3465         * DumpRenderTree/LayoutTestController.cpp:
3466         (LayoutTestController::makeWindowObject):
3467         (LayoutTestController::getJSClass):
3468         * DumpRenderTree/LayoutTestController.h:
3469         * DumpRenderTree/LayoutTestControllerMac.mm:
3470         (LayoutTestController::addDisallowedURL):
3471         (waitUntilDoneWatchdogFired):
3472         (LayoutTestController::waitUntilDone):
3473         * DumpRenderTree/ResourceLoadDelegate.m:
3474         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3475
3476 2007-09-12  Sam Weinig  <sam@webkit.org>
3477
3478         Reviewed by Stephanie.
3479
3480         Fix leaks in mac DumpRenderTree.
3481
3482         * DumpRenderTree/FrameLoadDelegate.mm:
3483         (-[FrameLoadDelegate init]): Initalize in the correct order.
3484         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3485         * DumpRenderTree/LayoutTestController.cpp:
3486         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3487         (encodeHostNameCallback): ditto.
3488         * DumpRenderTree/LayoutTestController.h:
3489         * DumpRenderTree/LayoutTestControllerMac.mm:
3490         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3491         (LayoutTestController::copyEncodedHostName): ditto
3492         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3493
3494 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3495
3496         Reviewed by Geof.
3497
3498         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3499
3500         * Scripts/run-webkit-tests:
3501
3502 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3503
3504         Reviewed by Darin.
3505
3506         - Simplified code paths and extracted out functions to increase encapsulation.
3507
3508         * Drosera/DebuggerDocument.cpp:
3509         (DebuggerDocument::breakpointEditorHTMLCallback):
3510         (DebuggerDocument::isPausedCallback):
3511         (DebuggerDocument::pauseCallback):
3512         (DebuggerDocument::resumeCallback):
3513         (DebuggerDocument::stepIntoCallback):
3514         (DebuggerDocument::evaluateScriptCallback):
3515         (DebuggerDocument::currentFunctionStackCallback):
3516         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3517         (DebuggerDocument::valueForScopeVariableNamedCallback):
3518         (DebuggerDocument::logCallback):
3519         * Drosera/DebuggerDocument.h:
3520         (DebuggerDocument::getPaused):
3521         * Drosera/mac/DebuggerClient.mm:
3522         (-[DebuggerClient pause:]):
3523         (-[DebuggerClient resume:]):
3524         (-[DebuggerClient stepInto:]):
3525         (-[DebuggerClient stepOver:]):
3526         (-[DebuggerClient stepOut:]):
3527         (-[DebuggerClient showConsole:]):
3528         (-[DebuggerClient closeCurrentFile:]):
3529         (-[DebuggerClient validateUserInterfaceItem:]):
3530         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3531         (+[NSString stringOrNilFromWebScriptResult:]):
3532         (DebuggerDocument::platformPause):
3533         (DebuggerDocument::platformResume):
3534         (DebuggerDocument::platformStepInto):
3535         (DebuggerDocument::platformEvaluateScript):
3536         (DebuggerDocument::getPlatformCurrentFunctionStack):
3537         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3538         (DebuggerDocument::platformValueForScopeVariableNamed):
3539         (DebuggerDocument::platformLog):
3540         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3541
3542 2007-09-12  Sam Weinig  <sam@webkit.org>
3543
3544         Build fix for Buildbot.
3545
3546         * DumpRenderTree/DumpRenderTree.mm:
3547         (dump):
3548
3549 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3550
3551         Reviewed by Geoff.
3552
3553         - Updated the leaks list for leopard to help identify regressions.
3554
3555         * Scripts/run-webkit-tests:
3556
3557 2007-09-12  Sam Weinig  <sam@webkit.org>
3558
3559         Rubber stamped by Darin.
3560