2009-11-28 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-28  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
6         https://bugs.webkit.org/show_bug.cgi?id=31950
7
8         Now we cache the last status that we get back from QueueStatusServer.
9         Eventually we'll have to do something more fancy if we want to support
10         a "try again" button on QueueStatusServer, but we can cross that bridge
11         when we come to it.
12
13         * Scripts/modules/patchcollection.py:
14
15 2009-11-28  Adam Barth  <abarth@webkit.org>
16
17         Reviewed by Eric Seidel.
18
19         StyleQueue scans ~100 bug pages every 5 minutes
20         https://bugs.webkit.org/show_bug.cgi?id=31947
21
22         Instead of getting the pending-review attachment ids by scanning each
23         bug (which results in a network request), we should just get them all
24         from webkit.org/pending-review in one shot.
25
26         * Scripts/modules/bugzilla.py:
27         * Scripts/modules/bugzilla_unittest.py:
28         * Scripts/modules/commands/queries.py:
29         * Scripts/modules/commands/queries_unittest.py:
30         * Scripts/modules/commands/queues.py:
31         * Scripts/modules/mock_bugzillatool.py:
32         * Scripts/modules/patchcollection.py:
33
34 2009-11-28  Adam Barth  <abarth@webkit.org>
35
36         Reviewed by Eric Seidel.
37
38         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
39         https://bugs.webkit.org/show_bug.cgi?id=31952
40
41         The mailing list is open for anyone to subscribe.
42
43         * Scripts/modules/bugzilla.py:
44         * Scripts/modules/commands/queues.py:
45
46 2009-11-28  Adam Barth  <abarth@webkit.org>
47
48         Reviewed by Eric Seidel.
49
50         [bzt] style-queue should report style errors to bugzilla
51         https://bugs.webkit.org/show_bug.cgi?id=31945
52
53         Currently, we're just logging the style errors locally.  With this
54         patch we'll actually log the errors to bugzilla.  Note: I plan to run
55         with the "local-only" logging during development.
56
57         * Scripts/modules/commands/queues.py:
58         * Scripts/modules/scm.py:
59
60 2009-11-28  Adam Barth  <abarth@webkit.org>
61
62         Reviewed by Eric Seidel.
63
64         [bzt] style-queue shouldn't reject patches from the commit-queue
65         https://bugs.webkit.org/show_bug.cgi?id=31944
66
67         Currently the style-queue subprocess gets confused and thinks its the
68         commit-queue.  If the patch has an error, it rejects it from the
69         commit-queue.  Instead, we should have style-queue specific logic.
70         This patch doesn't add that logic, but it gives us a callback we can
71         use to add that logic.
72
73         * Scripts/modules/buildsteps.py:
74         * Scripts/modules/commands/queues.py:
75         * Scripts/modules/landingsequence.py:
76
77 2009-11-27  Adam Barth  <abarth@webkit.org>
78
79         Rubber stamped by Eric Seidel.
80
81         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
82
83         * CommitQueueStatus: Removed.
84         * CommitQueueStatus/app.yaml: Removed.
85         * CommitQueueStatus/filters: Removed.
86         * CommitQueueStatus/filters/__init__.py: Removed.
87         * CommitQueueStatus/filters/webkit_extras.py: Removed.
88         * CommitQueueStatus/index.html: Removed.
89         * CommitQueueStatus/index.yaml: Removed.
90         * CommitQueueStatus/queue_status.py: Removed.
91         * CommitQueueStatus/stylesheets: Removed.
92         * CommitQueueStatus/stylesheets/main.css: Removed.
93         * CommitQueueStatus/update_status.html: Removed.
94         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
95
96 2009-11-27  Adam Barth  <abarth@webkit.org>
97
98         Reviewed by Eric Seidel.
99
100         style-queue should only process each patch once
101         https://bugs.webkit.org/show_bug.cgi?id=31939
102
103         Actually address reviewer comments!
104
105         * Scripts/bugzilla-tool:
106
107 2009-11-27  Adam Barth  <abarth@webkit.org>
108
109         Reviewed by Eric Seidel.
110
111         [bzt] style-queue fails to apply a bunch of patches for no reason
112         https://bugs.webkit.org/show_bug.cgi?id=31942
113
114         By passing --non-interactive to check-style, we convince check-style
115         to pass --force to svn-apply, which lets it apply more patches.
116
117         * Scripts/modules/commands/queues.py:
118
119 2009-11-27  Adam Barth  <abarth@webkit.org>
120
121         Reviewed by Eric Seidel.
122
123         [bzt] Support --status-host in style-queue
124         https://bugs.webkit.org/show_bug.cgi?id=31941
125
126         * Scripts/modules/commands/queues.py:
127         * Scripts/modules/statusbot.py:
128
129 2009-11-27  Adam Barth  <abarth@webkit.org>
130
131         Reviewed by Eric Seidel.
132
133         style-queue should only process each patch once
134         https://bugs.webkit.org/show_bug.cgi?id=31939
135
136         Before processing a patch, the try-queues now ask the web service
137         whether they have already processed the patch.  This is an initial cut
138         of this functionality.  I expect we're make it richer over time.
139
140         * Scripts/bugzilla-tool:
141         * Scripts/modules/commands/queues.py:
142         * Scripts/modules/patchcollection.py:
143
144 2009-11-27  Adam Barth  <abarth@webkit.org>
145
146         Reviewed by Eric Seidel.
147
148         PatchStatus does not return status
149         https://bugs.webkit.org/show_bug.cgi?id=31938
150
151         We need to parse attachment_id as an int.  Otherwise, we can't find
152         anything in the datastore.
153
154         * CommitQueueStatus/queue_status.py:
155
156 2009-11-27  Adam Barth  <abarth@webkit.org>
157
158         Reviewed by Eric Seidel.
159
160         Make commit-queue status not throw an exception where there is not
161         status
162         https://bugs.webkit.org/show_bug.cgi?id=31936
163
164         We need to actually fetch the results of the query to see what's in the
165         datastore.
166
167         * CommitQueueStatus/queue_status.py:
168
169 2009-11-27  Adam Barth  <abarth@webkit.org>
170
171         Reviewed by Eric Seidel.
172
173         [bzt] unit test ApplyPatches and ApplyAttachment
174         https://bugs.webkit.org/show_bug.cgi?id=31935
175
176         * Scripts/modules/commands/download.py:
177         * Scripts/modules/commands/download_unittest.py:
178
179 2009-11-27  Adam Barth  <abarth@webkit.org>
180
181         Reviewed by Eric Seidel.
182
183         [bzt] Unit test download commands
184         https://bugs.webkit.org/show_bug.cgi?id=31923
185
186         Adds download_unittest and fixes a bug found while testing.
187
188         * Scripts/modules/commands/commandtest.py:
189         * Scripts/modules/commands/download.py:
190             Fixed a bug where we'd throw an error because [].append returns
191             None.
192         * Scripts/modules/commands/download_unittest.py: Added.
193         * Scripts/modules/mock_bugzillatool.py:
194         * Scripts/run-webkit-unittests:
195
196 2009-11-27  Adam Barth  <abarth@webkit.org>
197
198         Unreviewed "build" fix found while writing unit tests.
199
200         * Scripts/modules/commands/download.py:
201
202 2009-11-27  Adam Barth  <abarth@webkit.org>
203
204         Reviewed by Eric Seidel.
205
206         [bzt] Kill WebKitLandingScripts
207         https://bugs.webkit.org/show_bug.cgi?id=31904
208
209         Step 6: Kill the rest.
210
211         * Scripts/modules/buildsteps.py:
212         * Scripts/modules/commands/download.py:
213         * Scripts/modules/commands/queries.py:
214         * Scripts/modules/commands/upload.py:
215         * Scripts/modules/landingsequence.py:
216         * Scripts/modules/scm.py:
217         * Scripts/modules/webkitlandingscripts.py: Removed.
218
219 2009-11-27  Adam Barth  <abarth@webkit.org>
220
221         Reviewed by Eric Seidel.
222
223         [bzt] Unit test upload commands
224         https://bugs.webkit.org/show_bug.cgi?id=31903
225
226         Adds unit tests for all but two of the upload commands.  The two
227         remaining ones are more difficult.  I'll return to them later.  The
228         goal of these tests is just to run the commands.  We can test more
229         detailed behavior later.
230
231         * Scripts/modules/commands/commandtest.py:
232         * Scripts/modules/commands/upload.py:
233         * Scripts/modules/commands/upload_unittest.py:
234         * Scripts/modules/mock.py: Added.
235         * Scripts/modules/mock_bugzillatool.py:
236
237 2009-11-26  Adam Barth  <abarth@webkit.org>
238
239         Reviewed by Eric Seidel.
240
241         [bzt] Kill WebKitLandingScripts
242         https://bugs.webkit.org/show_bug.cgi?id=31904
243
244         Step 5: Kill run_and_throw_if_fail.
245
246         * Scripts/modules/buildsteps.py:
247         * Scripts/modules/processutils.py: Added.
248         * Scripts/modules/webkitlandingscripts.py:
249
250 2009-11-26  Adam Barth  <abarth@webkit.org>
251
252         Reviewed by Eric Seidel.
253
254         [bzt] Kill WebKitLandingScripts
255         https://bugs.webkit.org/show_bug.cgi?id=31904
256
257         Step 4: Kill run_webkit_script.
258
259         * Scripts/modules/buildsteps.py:
260         * Scripts/modules/commands/download.py:
261         * Scripts/modules/webkitlandingscripts.py:
262
263 2009-11-26  Adam Barth  <abarth@webkit.org>
264
265         Reviewed by Eric Seidel.
266
267         [bzt] Kill WebKitLandingScripts
268         https://bugs.webkit.org/show_bug.cgi?id=31904
269
270         Step 3: Kill build_webkit.
271
272         * Scripts/modules/buildsteps.py:
273         * Scripts/modules/landingsequence.py:
274         * Scripts/modules/webkitlandingscripts.py:
275
276 2009-11-26  Adam Barth  <abarth@webkit.org>
277
278         Reviewed by Eric Seidel.
279
280         [bzt] Kill WebKitLandingScripts
281         https://bugs.webkit.org/show_bug.cgi?id=31904
282
283         Step 2: Kill ensure_builders_are_green.
284
285         * Scripts/modules/buildsteps.py:
286         * Scripts/modules/commands/download.py:
287         * Scripts/modules/landingsequence.py:
288         * Scripts/modules/webkitlandingscripts.py:
289
290 2009-11-26  Adam Barth  <abarth@webkit.org>
291
292         Reviewed by Eric Seidel.
293
294         [bzt] Kill WebKitLandingScripts
295         https://bugs.webkit.org/show_bug.cgi?id=31904
296
297         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
298
299         * Scripts/bugzilla-tool:
300         * Scripts/modules/buildsteps.py: Added.
301         * Scripts/modules/commands/download.py:
302         * Scripts/modules/landingsequence.py:
303         * Scripts/modules/webkitlandingscripts.py:
304
305 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
306
307         Reviewed by Adam Barth.
308
309         Remove directory prefixes from linux commands
310
311         SCM unittests can cause errors on some systems if we use absolute reference to
312         the commands, so directory prefixes have been removed.
313
314         * Scripts/modules/scm_unittest.py:
315
316 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
317
318         Reviewed by Kenneth Rohde Christiansen.
319
320         Link DumpRenderTree to the Qt Ui Tools
321         https://bugs.webkit.org/show_bug.cgi?id=31203
322
323         Implement QWebPage::createPlugin using the Qt Ui Tools
324         to be able to create classes like QProgressBar from within
325         the <object></object> tags This is required for the
326         new automatic test of Qt Plugins.
327
328         * DumpRenderTree/qt/DumpRenderTree.cpp:
329         (WebCore::WebPage::createPlugin):
330         * DumpRenderTree/qt/DumpRenderTree.h:
331         * DumpRenderTree/qt/DumpRenderTree.pro:
332
333 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
334
335         Reviewed by Eric Seidel.
336
337         Update pywebsocket to 0.4.2
338
339         Update pywebsocket to 0.4.2
340         https://bugs.webkit.org/show_bug.cgi?id=31861
341
342         * pywebsocket/example/echo_client.py:
343         * pywebsocket/example/echo_wsh.py:
344         * pywebsocket/mod_pywebsocket/__init__.py:
345         * pywebsocket/mod_pywebsocket/dispatch.py:
346         * pywebsocket/mod_pywebsocket/msgutil.py:
347         * pywebsocket/mod_pywebsocket/standalone.py:
348         * pywebsocket/setup.py:
349         * pywebsocket/test/test_dispatch.py:
350         * pywebsocket/test/test_msgutil.py:
351
352 2009-11-25  Adam Barth  <abarth@webkit.org>
353
354         Reviewed by Eric Seidel.
355
356         Add unit test for mark-fixed
357         https://bugs.webkit.org/show_bug.cgi?id=31896
358
359         * Scripts/modules/commands/commandtest.py: Added.
360         * Scripts/modules/commands/queries_unittest.py:
361         * Scripts/modules/commands/upload_unittest.py: Added.
362         * Scripts/modules/mock_bugzillatool.py:
363         * Scripts/run-webkit-unittests:
364
365 2009-11-25  Adam Barth  <abarth@webkit.org>
366
367         Reviewed by Eric Seidel.
368
369         bugzilla-tool should have a mark-fixed command
370         https://bugs.webkit.org/show_bug.cgi?id=31853
371
372         Pretty simple stuff.
373
374         * Scripts/modules/commands/upload.py:
375
376 2009-11-25  Eric Seidel  <eric@webkit.org>
377
378         Reviewed by Adam Barth.
379
380         'bugzilla-tool help' should only show common commands like how 'git help' does
381         https://bugs.webkit.org/show_bug.cgi?id=31772
382
383         I also took this opportunity to make 'help' a real Command.
384         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
385
386         * Scripts/bugzilla-tool:
387          - change should_show_command_help to should_show_in_main_help
388         * Scripts/modules/commands/download.py:
389          - Mark commands as being shown in main help or not.
390          - show_in_main_help = False is not required (default is false),
391            but it seemed to make the commands more self-documenting.
392         * Scripts/modules/commands/queries.py: ditto
393         * Scripts/modules/commands/queues.py: ditto
394         * Scripts/modules/commands/upload.py: ditto
395         * Scripts/modules/multicommandtool.py:
396          - Make Command hold a pointer to tool in self.tool.  Most Command
397            subclasses do not take advantage of this yet, but it was required
398            for HelpCommand to be able to reach the tool from _help_epilog().
399          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
400          - Move MultiCommandTool._help_epilog to Command._help_epilog
401          - Move "help" logic into HelpCommand.execute()
402          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
403         * Scripts/modules/multicommandtool_unittest.py:
404          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
405
406 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
407
408         Reviewed by Dan Bernstein.
409         
410         Patch by Mark Rowe.
411
412         The buildbots are failing on Windows because when they were upgraded
413         to 4.0.4, Apple Application Support was not in their path. Add it to
414         the path to fix the buildots.
415
416         * Scripts/webkitdirs.pm:
417
418 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
419
420         Reviewed by David Kilzer.
421
422         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
423         https://bugs.webkit.org/show_bug.cgi?id=31799
424
425         * Scripts/run-webkit-tests: Fixed.
426
427 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
428
429         Reviewed by Eric Seidel.
430
431         Change run_command to give back stderr by default
432         https://bugs.webkit.org/show_bug.cgi?id=31734
433
434         Change run_command to give back stderr by default.
435         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
436         Change the related unittest call.
437
438         * Scripts/modules/scm.py:
439         * Scripts/modules/scm_unittest.py:
440
441 2009-11-25  Eric Seidel  <eric@webkit.org>
442
443         Reviewed by Adam Barth.
444
445         Centralize required argument parsing in Command
446         https://bugs.webkit.org/show_bug.cgi?id=31872
447
448         * Scripts/modules/commands/download.py: remove custom required arg message.
449         * Scripts/modules/commands/upload.py: ditto.
450         * Scripts/modules/multicommandtool.py:
451          - Add _parse_required_arguments.
452          - Pass program name off to OptionParser.
453          - Add name() for access to tool name.
454          - Add check_arguments_and_execute and make it return a return code.
455          - Replace a couple uses of + with %.
456         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
457
458 2009-11-25  Eric Seidel  <eric@webkit.org>
459
460         Reviewed by Adam Barth.
461
462         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
463         https://bugs.webkit.org/show_bug.cgi?id=31870
464
465         * Scripts/modules/commands/queries_unittest.py: Use the new class.
466         * Scripts/modules/multicommandtool_unittest.py: Ditto.
467         * Scripts/modules/outputcapture.py: Added.
468
469 2009-11-24  Dmitry Titov  <dimich@chromium.org>
470
471         Reviewed by Eric Seidel.
472
473         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
474         https://bugs.webkit.org/show_bug.cgi?id=31444
475
476         * Scripts/build-webkit:
477
478 2009-11-24  Chris Marrin  <cmarrin@apple.com>
479
480         Reviewed by Simon Fraser.
481
482         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
483         https://bugs.webkit.org/show_bug.cgi?id=27314
484         
485         Now the script allows the directories with these tests to be included on all
486         platforms but Mac, where they behave the same as always. For all other platforms
487         the tests need to be excluded using the Skipped files, which is currently done
488         for all platforms (including win since we're not turned on yet)
489
490         * Scripts/webkitdirs.pm:
491
492 2009-11-24  Eric Seidel  <eric@webkit.org>
493
494         Reviewed by Adam Barth.
495
496         queries_unittest.py should test command output
497         https://bugs.webkit.org/show_bug.cgi?id=31845
498
499         * Scripts/modules/commands/queries_unittest.py:
500          - Capture stdout and stderr and compare with expected strings.
501
502 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
503
504         No Review.
505
506         Fix spelling error ("depenedencies").
507
508         * Scripts/build-webkit:
509
510 2009-11-24  Mark Rowe  <mrowe@apple.com>
511
512         Land the configuration that includes the two debug GTK Linux builders.
513
514         * BuildSlaveSupport/build.webkit.org-config/config.json:
515
516 2009-11-24  David Kilzer  <ddkilzer@apple.com>
517
518         <http://webkit.org/b/31840> bisect-builds broke after r50080
519
520         Reviewed by Dan Bernstein.
521
522         * Scripts/bisect-builds:
523         (mountAndRunNightly): Switched back to using backticks to run
524         the hdiutil command since exec() will terminate the existing
525         script, which is not what we want.  Store the output of
526         File::Spec->devnull() in a variable for use in the hdiutil
527         detach commands.
528
529 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
530
531         Reviewed by Kenneth Rohde Christiansen.
532
533         Include "config.h" to meet Coding Style Guidelines
534         https://bugs.webkit.org/show_bug.cgi?id=31792
535
536         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
537         * DumpRenderTree/qt/jsobjects.cpp:
538         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
539
540 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
541
542         Reviewed by Oliver Hunt.
543
544         Implement new required function to pass test we used to pass. This
545         change is required since r51294.
546
547         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
548         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
549
550 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
551
552         Reviewed by Kenneth Rohde Christiansen.
553
554         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
555         https://bugs.webkit.org/show_bug.cgi?id=31775
556
557         LayoutTestController::dumpBackForwardList() should work with local URLs
558         as well as with normal URLs (in http tests for instance).
559         Currently it does not output the latter properly.
560
561         Unskip a bunch of passing http/navigation tests.
562
563         * DumpRenderTree/qt/DumpRenderTree.cpp:
564         (WebCore::dumpHistoryItem):
565
566 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
567
568         Reviewed by Oliver Hunt.
569
570         ARIA: support aria-flowto
571         https://bugs.webkit.org/show_bug.cgi?id=31762
572
573         * DumpRenderTree/AccessibilityUIElement.cpp:
574         (ariaFlowToElementAtIndexCallback):
575         (AccessibilityUIElement::getJSClass):
576         * DumpRenderTree/AccessibilityUIElement.h:
577         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
578         (AccessibilityUIElement::ariaFlowToElementAtIndex):
579         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
580         (AccessibilityUIElement::ariaFlowToElementAtIndex):
581         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
582         (AccessibilityUIElement::ariaFlowToElementAtIndex):
583
584 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
585
586         Reviewed by Kenneth Christiansen.
587
588         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
589         https://bugs.webkit.org/show_bug.cgi?id=31638
590
591         Unfreeze WorkQueue after each test execution.
592
593         * DumpRenderTree/qt/DumpRenderTree.cpp:
594         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
595
596 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
597
598         Reviewed by Adam Barth.
599
600         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
601         for localhost and 127.0.0.1.
602         https://bugs.webkit.org/show_bug.cgi?id=31783
603
604         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
605
606         * DumpRenderTree/qt/DumpRenderTree.cpp:
607         (WebCore::NetworkAccessManager::NetworkAccessManager):
608         (WebCore::NetworkAccessManager::sslErrorsEncountered):
609         (WebCore::WebPage::WebPage):
610         * DumpRenderTree/qt/DumpRenderTree.h:
611
612 2009-11-22  Chris Evans  <cevans@chromium.org>
613
614         Reviewed by Adam Barth.
615
616         Disable access to file:/// directory listings
617         https://bugs.webkit.org/show_bug.cgi?id=31329
618
619         Implemented setAllowUniversalAccessFromFileURLs to support testing of
620         file URL security.
621
622         * DumpRenderTree/LayoutTestController.cpp:
623         (setAllowUniversalAccessFromFileURLsCallback):
624         (LayoutTestController::staticFunctions):
625         * DumpRenderTree/LayoutTestController.h:
626         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
627         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
628         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
629         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
630         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
631         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
632         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
633         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
634
635 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
636
637         Reviewed by Kenneth Rohde Christiansen.
638
639         [Qt] Fix the timeout of fast/frames/frame-navigation.html
640         https://bugs.webkit.org/show_bug.cgi?id=31638
641
642         The test is timeouting, because it uses the WorkQueue to load a document in one
643         of the child frames and once the loading is finished, the DRT does not dump the
644         tree. This is because it waits for the QWebFrame::loadFinished() signal from
645         the main frame, while it should connect to QWebPage::loadFinished().
646
647         * DumpRenderTree/qt/DumpRenderTree.cpp:
648         (WebCore::DumpRenderTree::DumpRenderTree):
649
650 2009-11-21  Eric Seidel  <eric@webkit.org>
651
652         Reviewed by Adam Barth.
653
654         bugzilla-tool --help spews way too much text
655         https://bugs.webkit.org/show_bug.cgi?id=31771
656
657         * Scripts/bugzilla-tool:
658          - Remove self.cached_scm initialization hack.
659         * Scripts/modules/buildbot.py:
660          - Make default_host accessible to callers.
661         * Scripts/modules/commands/download.py:
662          - Phrase help for all commands consistently and remove spurious help text punctuation.
663         * Scripts/modules/commands/queries.py: Ditto.
664         * Scripts/modules/commands/queues.py: Ditto.
665         * Scripts/modules/commands/upload.py: Ditto.
666         * Scripts/modules/multicommandtool.py:
667          - Add HelpPrintingOptionParser.format_epilog to replace
668            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
669            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
670          - Make --help only show a list of commands like "svn help" and "git help" do --
671            previously --help was listing all commands and options.
672          - Sort list of commands alphabetically.
673
674 2009-11-21  Eric Seidel  <eric@webkit.org>
675
676         No review.  Fixing a typo from the previous patch for bug 31767.
677
678         AbstractQueue.run_bugzilla_tool throws an exception
679         https://bugs.webkit.org/show_bug.cgi?id=31769
680
681         * Scripts/modules/commands/queues.py:
682
683 2009-11-21  Eric Seidel  <eric@webkit.org>
684
685         Reviewed by Adam Barth.
686
687         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
688         https://bugs.webkit.org/show_bug.cgi?id=31767
689
690         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
691         Since we don't have a good way to test BugzillaTool pieces, I've
692         left out a test for now.
693
694         * Scripts/bugzilla-tool:
695          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
696         * Scripts/modules/commands/queues.py:
697          - Use tool.path() instead of __file__.
698         * Scripts/modules/multicommandtool.py:
699          - Add a new path() method to MultiComandTool.
700         * Scripts/modules/multicommandtool_unittest.py:
701          - Provide a path() method.  Little point in testing this mock implementation.
702
703 2009-11-21  Adam Barth  <abarth@webkit.org>
704
705         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
706         WebKitTools.
707
708         * Scripts/modules/commands/download.py:
709
710 2009-11-21  Adam Barth  <abarth@webkit.org>
711
712         Reviewed by Eric Seidel.
713
714         Convert check-style to use LandingSequence
715         https://bugs.webkit.org/show_bug.cgi?id=31763
716
717         Instead of manipulating the working copy by hand, we should use the
718         LandingSequence in CheckStyle.  This will make this code eaiser to
719         test.
720
721         * Scripts/modules/commands/download.py:
722
723 2009-11-20  Adam Barth  <abarth@webkit.org>
724
725         Reviewed by Eric Seidel.
726
727         Unit test query commands
728         https://bugs.webkit.org/show_bug.cgi?id=31755
729
730         These tests are pretty rough, but hopefully they'll grow.
731
732         * Scripts/modules/commands/queries_unittest.py: Added.
733         * Scripts/modules/mock_bugzillatool.py: Added.
734         * Scripts/run-webkit-unittests:
735
736 2009-11-20  Eric Seidel  <eric@webkit.org>
737
738         Reviewed by Adam Barth.
739
740         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
741         https://bugs.webkit.org/show_bug.cgi?id=31758
742
743         * Scripts/modules/multicommandtool.py:
744          - Allow passing of explicit commands to MultiCommandTool.__init__
745         * Scripts/modules/multicommandtool_unittest.py:
746          - Use new Command.name naming system.
747          - Test Command auto-discovery.
748         * Scripts/modules/workqueue.py:
749          - bug_id no longer exists, use patch['bug_id'] instead.
750         * Scripts/modules/workqueue_unittest.py:
751          - WorkQueues require names now.
752          - should_proceed_with_work_item must return a patch object.
753
754 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
755
756         Reviewed by Beth Dakin.
757
758         WAI-ARIA: add support for aria-owns
759         https://bugs.webkit.org/show_bug.cgi?id=31702
760
761         * DumpRenderTree/AccessibilityUIElement.cpp:
762         (ariaOwnsElementAtIndexCallback):
763         (AccessibilityUIElement::getJSClass):
764         * DumpRenderTree/AccessibilityUIElement.h:
765         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
766         (AccessibilityUIElement::ariaOwnsElementAtIndex):
767         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
768         (AccessibilityUIElement::ariaOwnsElementAtIndex):
769         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
770         (AccessibilityUIElement::ariaOwnsElementAtIndex):
771
772 2009-11-20  Eric Seidel  <eric@webkit.org>
773
774         Reviewed by Adam Barth.
775
776         Fix exception thrown when running the commit-queue.
777
778         * Scripts/modules/statusbot.py: patch is optional.
779         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
780
781 2009-11-20  Eric Seidel  <eric@webkit.org>
782
783         Reviewed by Adam Barth.
784
785         Teach the StatusBot how to support more than just the commit-queue
786         https://bugs.webkit.org/show_bug.cgi?id=31754
787
788         * Scripts/modules/workqueue.py: Another typo.
789
790 2009-11-20  Eric Seidel  <eric@webkit.org>
791
792         Reviewed by Adam Barth.
793
794         Teach the StatusBot how to support more than just the commit-queue
795         https://bugs.webkit.org/show_bug.cgi?id=31754
796
797         * Scripts/modules/commands/queues.py: Fix silly typo.
798
799 2009-11-20  Eric Seidel  <eric@webkit.org>
800
801         Reviewed by Adam Barth.
802
803         Teach the StatusBot how to support more than just the commit-queue
804         https://bugs.webkit.org/show_bug.cgi?id=31754
805
806         * CommitQueueStatus/index.yaml:
807          - Add indices required for the new queries.
808         * CommitQueueStatus/queue_status.py:
809          - Add a patch-status page and move update_status to update-status.
810          - Only display "commit-queue" status records for the commit-queue.
811          - Add support for a queue_name property on status records.
812          - Fix _int_from_request to actually work.
813         * CommitQueueStatus/update_status.html:
814          - Add support for a queue_name on status records.
815          - Remove unused list of bug ids.
816          * Scripts/modules/commands/queues.py
817           - Make the queues pass the patch instead of the bug_id to StatusBot.
818         * Scripts/modules/statusbot.py:
819          - Support passing the queue_name to the status updates.
820          - Support fetching patch status with patch_status().
821         * Scripts/modules/workqueue.py:
822          - Pass the patch to the StatusBot instead of the bug_id.
823          - Let WorkQueues have a name.
824
825 2009-11-20  Adam Barth  <abarth@webkit.org>
826
827         Reviewed by Eric Seidel.
828
829         Move bugzilla-tool commands into their own file
830         https://bugs.webkit.org/show_bug.cgi?id=31752
831
832         This will let us write unit tests.
833
834         * Scripts/bugzilla-tool:
835         * Scripts/modules/commands/__init__.py: Added.
836         * Scripts/modules/commands/download.py: Added.
837         * Scripts/modules/commands/queries.py: Added.
838         * Scripts/modules/commands/queues.py: Added.
839         * Scripts/modules/commands/upload.py: Added.
840         * Scripts/modules/grammar.py: Added.
841
842 2009-11-20  Adam Barth  <abarth@webkit.org>
843
844         Reviewed by Eric Seidel.
845
846         BuildQueue should check if the tree is currently buildable
847         https://bugs.webkit.org/show_bug.cgi?id=31744
848
849         * Scripts/bugzilla-tool:
850         * Scripts/modules/landingsequence.py:
851         * Scripts/modules/webkitlandingscripts.py:
852
853 2009-11-20  Adam Barth  <abarth@webkit.org>
854
855         Reviewed by Eric Seidel.
856
857         Move prepare_clean_working_directory into the LandingSequence
858         https://bugs.webkit.org/show_bug.cgi?id=31743
859
860         * Scripts/bugzilla-tool:
861         * Scripts/modules/landingsequence.py:
862
863 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
864
865         Reviewed by Kenneth Rohde Christiansen.
866
867         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
868         https://bugs.webkit.org/show_bug.cgi?id=30460
869
870         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
871
872         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
873         (pluginInvoke):
874
875 2009-11-20  Adam Barth  <abarth@webkit.org>
876
877         Reviewed by Eric Seidel.
878
879         Pass the port information to the child process
880         https://bugs.webkit.org/show_bug.cgi?id=31736
881
882         We need to do this so the child process knows what to build!
883
884         * Scripts/bugzilla-tool:
885         * Scripts/modules/landingsequence.py:
886         * Scripts/modules/webkitport.py:
887         * Scripts/modules/webkitport_unittest.py:
888
889 2009-11-20  Adam Barth  <abarth@webkit.org>
890
891         Reviewed by Eric Seidel.
892
893         Support Qt port in build-queue
894         https://bugs.webkit.org/show_bug.cgi?id=31733
895
896         * Scripts/bugzilla-tool:
897
898 2009-11-20  Adam Barth  <abarth@webkit.org>
899
900         Reviewed by Eric Seidel.
901
902         Implement a build-queue
903         https://bugs.webkit.org/show_bug.cgi?id=31725
904
905         Currently this just builds the first 10 patches in the review queue.
906         We'll want to do something smarter soon.
907
908         * Scripts/bugzilla-tool:
909
910 2009-11-20  Adam Barth  <abarth@webkit.org>
911
912         Reviewed by Eric Seidel.
913
914         Make commit-queue and style-queue show up in help
915         https://bugs.webkit.org/show_bug.cgi?id=31724
916
917         We need to store their names on their class to make these commands
918         properly register themselves with MultiCommandTool.
919
920         * Scripts/bugzilla-tool:
921
922 2009-11-20  Adam Barth  <abarth@webkit.org>
923
924         Reviewed by Eric Seidel.
925
926         Implement bugzilla-tool build-attachment
927         https://bugs.webkit.org/show_bug.cgi?id=31722
928
929         This command builds an attachment from bugzilla.  It leaves the built
930         patch in the working copy.
931
932         * Scripts/bugzilla-tool:
933         * Scripts/modules/landingsequence.py:
934         * Scripts/modules/webkitlandingscripts.py:
935
936 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
937
938         Reviewed by Xan Lopez.
939
940         [GTK] DRT release event does not create the state correctly
941         https://bugs.webkit.org/show_bug.cgi?id=31717
942
943         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
944
945 2009-11-20  Eric Seidel  <eric@webkit.org>
946
947         Reviewed by Adam Barth.
948
949         MultiCommandTool should find Command objects automatically instead of with a manual list
950         https://bugs.webkit.org/show_bug.cgi?id=31710
951
952         * Scripts/bugzilla-tool:
953         * Scripts/modules/multicommandtool.py:
954          - Use some wild python-fu to crawl all the known subclasses of Command.
955
956 2009-11-20  Adam Barth  <abarth@webkit.org>
957
958         Unreviewed "build" fix.  Added missing import.
959
960         * Scripts/bugzilla-tool:
961
962 2009-11-20  Adam Barth  <abarth@webkit.org>
963
964         Unreviewed "build" fix.  I failed to update LandingSequence.test
965         properly.
966
967         * Scripts/modules/landingsequence.py:
968
969 2009-11-20  Adam Barth  <abarth@webkit.org>
970
971         Reviewed by Eric Seidel.
972
973         Create LandingSequence as the all-sing, all-dance landing class
974         https://bugs.webkit.org/show_bug.cgi?id=31709
975
976         Client can inherit from this class to carefully control exactly which
977         steps they wish to have happen in the landing sequence.
978
979         * Scripts/bugzilla-tool:
980         * Scripts/modules/landingsequence.py: Added.
981         * Scripts/modules/webkitlandingscripts.py: Added.
982
983 2009-11-19  Adam Barth  <abarth@webkit.org>
984
985         Reviewed by Eric Seidel.
986
987         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
988         https://bugs.webkit.org/show_bug.cgi?id=31707
989
990         This is to help when we implement build-attachment.
991
992         * Scripts/bugzilla-tool:
993
994 2009-11-19  Adam Barth  <abarth@webkit.org>
995
996         Reviewed by Eric Seidel.
997
998         Support Qt port in bugzilla-tool
999         https://bugs.webkit.org/show_bug.cgi?id=31701
1000
1001         Now we support building with Qt!
1002
1003         * Scripts/bugzilla-tool:
1004         * Scripts/modules/webkitport.py: Added.
1005         * Scripts/modules/webkitport_unittest.py: Added.
1006         * Scripts/run-webkit-unittests:
1007
1008 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1009
1010         Reviewed by Adam Barth.
1011
1012         Remove inserting stderr into patch in bugzilla-tool
1013         https://bugs.webkit.org/show_bug.cgi?id=29914
1014
1015         Modify SCM python module's run_command function to avoid return of stderr
1016         by default, so stderr won't be inserted into the patches.
1017         Modify the related unit test.
1018
1019         * Scripts/modules/scm.py:
1020         * Scripts/modules/scm_unittest.py:
1021
1022 2009-11-19  Eric Seidel  <eric@webkit.org>
1023
1024         Reviewed by Adam Barth.
1025
1026         bugzilla-tool needs per-command help
1027         https://bugs.webkit.org/show_bug.cgi?id=31697
1028
1029         Added support for "bugzilla-tool help command-name"
1030         and a unit test to make sure it works.
1031
1032         * Scripts/modules/multicommandtool.py:
1033         * Scripts/modules/multicommandtool_unittest.py:
1034
1035 2009-11-19  Eric Seidel  <eric@webkit.org>
1036
1037         Reviewed by Adam Barth.
1038
1039         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1040         https://bugs.webkit.org/show_bug.cgi?id=31695
1041
1042         * Scripts/bugzilla-tool:
1043         * Scripts/modules/multicommandtool.py: Added.
1044         * Scripts/modules/multicommandtool_unittest.py: Added.
1045         * Scripts/run-webkit-unittests:
1046
1047 2009-11-19  Eric Seidel  <eric@webkit.org>
1048
1049         No review, just adding a FIXME.
1050
1051         Split out command parsing and help printing from BugzillaTool
1052         https://bugs.webkit.org/show_bug.cgi?id=31688
1053
1054         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1055
1056 2009-11-19  Eric Seidel  <eric@webkit.org>
1057
1058         Reviewed by Adam Barth.
1059
1060         Split out command parsing and help printing from BugzillaTool
1061         https://bugs.webkit.org/show_bug.cgi?id=31688
1062
1063         * Scripts/bugzilla-tool:
1064          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1065          - Rename private methods to use _ pattern.
1066          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1067          - 
1068
1069 2009-11-19  Eric Seidel  <eric@webkit.org>
1070
1071         Reviewed by Adam Barth.
1072
1073         Re-factor help printing to use modern python idioms
1074         https://bugs.webkit.org/show_bug.cgi?id=31685
1075
1076         * Scripts/bugzilla-tool:
1077
1078 2009-11-19  Eric Seidel  <eric@webkit.org>
1079
1080         Reviewed by Darin Adler.
1081
1082         commit-queue empty queue logs twice
1083         https://bugs.webkit.org/show_bug.cgi?id=31679
1084
1085         * Scripts/bugzilla-tool:
1086
1087 2009-11-19  Eric Seidel  <eric@webkit.org>
1088
1089         Reviewed by Darin Adler.
1090
1091         bugzilla-tool's reviewer/committer rejection message should be clearer
1092         https://bugs.webkit.org/show_bug.cgi?id=31126
1093
1094         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1095
1096         * Scripts/modules/bugzilla.py:
1097
1098 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1099
1100         Reviewed by Pavel Feldman.
1101
1102         Forces a WM_PAINT event on calling layoutTestController.display()
1103         in order to enable the timeline-paint.html test on Windows.
1104         ::UpdateWindow() does not force an event becaue the window is 
1105         not visible.
1106
1107         https://bugs.webkit.org/show_bug.cgi?id=31402
1108
1109         * DumpRenderTree/win/DumpRenderTree.cpp:
1110         (displayWebView):
1111
1112 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1113
1114         No review needed.
1115
1116         Added myself to committers list.
1117
1118         * Scripts/modules/committers.py:
1119
1120 2009-11-19  Adam Barth  <abarth@webkit.org>
1121
1122         Reviewed by Eric Seidel.
1123
1124         Bugzilla-tool command classes should match command names
1125         https://bugs.webkit.org/show_bug.cgi?id=31666
1126
1127         I renamed all the commands except CommitMessageForCurrentDiff because
1128         the new name would conflict with an existing class.
1129
1130         * Scripts/bugzilla-tool:
1131
1132 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1133
1134         Reviewed by Gustavo Noronha Silva.
1135
1136         Web Inspector: Implement "show inspector" in WebKit GTK
1137         API and enable console tests.
1138
1139         https://bugs.webkit.org/show_bug.cgi?id=31669
1140
1141         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1142         (LayoutTestController::showWebInspector):
1143
1144 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1145
1146         Reviewed by Simon Hausmann.
1147
1148         Minor refactoring + more documentation.
1149
1150         * DumpRenderTree/qt/DumpRenderTree.cpp:
1151         (WebCore::clearHistory):
1152         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1153
1154 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1155
1156         Reviewed by Eric Seidel.
1157
1158         Ignore websocket tests when --no-http is specified.
1159         https://bugs.webkit.org/show_bug.cgi?id=31662
1160
1161         * Scripts/run-webkit-tests:
1162
1163 2009-11-18  Adam Barth  <abarth@webkit.org>
1164
1165         Reviewed by Eric Seidel.
1166
1167         Normalize ' and " in bugzilla-tool
1168         https://bugs.webkit.org/show_bug.cgi?id=31655
1169
1170         We decided " is better than ' and we should be consistent.
1171
1172         * Scripts/bugzilla-tool:
1173
1174 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1175
1176         Reviewed by Kenneth Rohde Christiansen.
1177
1178         [Qt] Remove support for Qt v4.3 or older versions
1179         https://bugs.webkit.org/show_bug.cgi?id=29469
1180
1181         * DumpRenderTree/qt/DumpRenderTree.pro:
1182         * DumpRenderTree/qt/ImageDiff.pro:
1183
1184 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1185
1186         Reviewed by Eric Seidel.
1187
1188         GitTest.test_create_binary_patch fails if /tmp is symlink
1189         https://bugs.webkit.org/show_bug.cgi?id=31536
1190
1191         * Scripts/modules/scm_unittest.py:
1192
1193 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1194
1195         Reviewed by Darin Adler.
1196
1197         Configuration for Chromium Build Slaves.
1198
1199         https://bugs.webkit.org/show_bug.cgi?id=31442
1200
1201         * BuildSlaveSupport/build.webkit.org-config/config.json:
1202         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1203
1204 2009-11-18  Eric Seidel  <eric@webkit.org>
1205
1206         Reviewed by Darin Adler.
1207
1208         workqueue.py results in totally broken commit-queue UI
1209         https://bugs.webkit.org/show_bug.cgi?id=31645
1210
1211         * Scripts/bugzilla-tool:
1212          - Remove unneeded use of PatchCollection.
1213          - Grab a new copy of the cq'd patches every run of the queue.
1214
1215 2009-11-18  Sam Weinig  <sam@webkit.org>
1216
1217         Reviewed by Anders Carlsson.
1218
1219         Make the Mac Geolocation API async.
1220
1221         Update DRT to use the new async Mac Geolocation API.
1222
1223         * DumpRenderTree/mac/UIDelegate.mm:
1224         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1225
1226 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1227
1228         Reviewed by Kenneth Rohde Christiansen.
1229
1230         Add and option to toggle HTML5 datalist support to build-webkit
1231         https://bugs.webkit.org/show_bug.cgi?id=31599
1232
1233         * Scripts/build-webkit:
1234
1235 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1236
1237         Reviewed by Kevin Ollivier.
1238
1239         Enable wx plugin support using the Windows implementation as a base.
1240         
1241         https://bugs.webkit.org/show_bug.cgi?id=31636
1242
1243         * wx/build/settings.py:
1244
1245 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1246
1247         Reviewed by Simon Hausmann.
1248
1249         Change the initialization order so that the controllers
1250         will be created before exporting them to the JS DOM window.
1251
1252         * DumpRenderTree/qt/DumpRenderTree.cpp:
1253         (WebCore::DumpRenderTree::DumpRenderTree):
1254
1255 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1256
1257         Reviewed by Simon Hausmann.
1258
1259         Fix a code copy and paste error. m_page should be page.
1260
1261         * DumpRenderTree/qt/DumpRenderTree.cpp:
1262         (WebCore::DumpRenderTree::createWindow):
1263
1264 2009-11-17  Mark Rowe  <mrowe@apple.com>
1265
1266         Reviewed by Alexey Proskuryakov.
1267
1268         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1269
1270         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1271         This prevents symlinks from confusing the descendant check.
1272
1273 2009-11-17  Mark Rowe  <mrowe@apple.com>
1274
1275         Reviewed by Alexey Proskuryakov.
1276
1277         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1278
1279         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1280         server to be up rather than having run-webkit-tests abort immediately.
1281
1282         * Scripts/run-webkit-tests:
1283
1284 2009-11-17  Eric Seidel  <eric@webkit.org>
1285
1286         Reviewed by Darin Adler.
1287
1288         commit-queue is failing to set reviewer in ChangeLogs
1289         https://bugs.webkit.org/show_bug.cgi?id=31592
1290
1291         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1292         * Scripts/modules/bugzilla.py:
1293          - Add a new _validate_committer_and_reviewer function as a
1294            temporary solution until we can make a real Attachment object
1295            which knows how to fill in its committer/reviewer fields automatically.
1296
1297 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1298
1299         Unreviewed buildbot fix.
1300
1301         Revert part of earlier patch and add comment, as it
1302         was causing timeouts on the buildbot.
1303
1304         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1305         (LayoutTestController::notifyDone):
1306
1307 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1308
1309         Reviewed by Oliver Hunt.
1310
1311         Make the timeout 15 sec as for the other DRT's and make
1312         it print out the same output when a test timeout.
1313
1314         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1315         (LayoutTestController::waitUntilDone):
1316         (LayoutTestController::notifyDone):
1317         (LayoutTestController::timerEvent):
1318
1319 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1320
1321         Reviewed by Timothy Hatcher.
1322
1323         Fixed typos in comments.
1324
1325         * Scripts/modules/committers.py:
1326
1327 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1328
1329         Reviewed by Timothy Hatcher.
1330
1331         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1332         - Updated DRT to show/close inspector for all tests under /inspector
1333         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1334           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1335         - Removed reload on each inspector test
1336         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1337         inspector for those.
1338         - Reimplemented timeline tests in order to get rid of reload there.
1339         - Moved tests that don't require harness into the fast group.
1340
1341         https://bugs.webkit.org/show_bug.cgi?id=31472
1342
1343         * DumpRenderTree/LayoutTestController.cpp:
1344         (setTimelineProfilingEnabledCallback):
1345         (closeWebInspectorCallback):
1346         (LayoutTestController::staticFunctions):
1347         * DumpRenderTree/LayoutTestController.h:
1348         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1349         (shouldOpenWebInspector):
1350         (runTest):
1351         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1352         (LayoutTestController::setTimelineProfilingEnabled):
1353         * DumpRenderTree/mac/DumpRenderTree.mm:
1354         (shouldOpenWebInspector):
1355         (runTest):
1356         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1357         (LayoutTestController::setTimelineProfilingEnabled):
1358         * DumpRenderTree/win/DumpRenderTree.cpp:
1359         (shouldOpenWebInspector):
1360         (runTest):
1361         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1362         (LayoutTestController::setTimelineProfilingEnabled):
1363
1364 2009-11-17  Oliver Hunt  <oliver@apple.com>
1365
1366         Reviewed by Maciej Stachowiak.
1367
1368         Incorrect use of JavaScriptCore API in DumpRenderTree
1369         https://bugs.webkit.org/show_bug.cgi?id=31577
1370
1371         Return undefined rather than a literal null.
1372
1373         * DumpRenderTree/AccessibilityUIElement.cpp:
1374         (setSelectedTextRangeCallback):
1375         (incrementCallback):
1376         (decrementCallback):
1377         (showMenuCallback):
1378
1379 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1380
1381         Reviewed by Beth Dakin.
1382
1383         AX: aria-labelledby duplicates some of its WAI-ARIA label
1384         https://bugs.webkit.org/show_bug.cgi?id=31565
1385
1386         * DumpRenderTree/AccessibilityUIElement.cpp:
1387         (titleUIElementCallback):
1388         (getIsValidCallback):
1389         (AccessibilityUIElement::getJSClass):
1390
1391 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1392
1393         Reviewed by Simon Hausmann.
1394
1395         r50942 broke output from created windows. Make the
1396         m_enableTextOutput a member of the DRT and not the
1397         WebPage.
1398
1399         * DumpRenderTree/qt/DumpRenderTree.cpp:
1400         (WebCore::WebPage::WebPage):
1401         (WebCore::WebPage::javaScriptAlert):
1402         (WebCore::WebPage::javaScriptConsoleMessage):
1403         (WebCore::WebPage::javaScriptConfirm):
1404         (WebCore::WebPage::javaScriptPrompt):
1405         (WebCore::WebPage::acceptNavigationRequest):
1406         (WebCore::DumpRenderTree::DumpRenderTree):
1407         (WebCore::DumpRenderTree::open):
1408         (WebCore::DumpRenderTree::createWindow):
1409         * DumpRenderTree/qt/DumpRenderTree.h:
1410         (WebCore::DumpRenderTree::setTextOutputEnabled):
1411         (WebCore::DumpRenderTree::isTextOutputEnabled):
1412         (WebCore::WebPage::shouldInterruptJavaScript):
1413         (WebCore::WebPage::isTextOutputEnabled):
1414         (WebCore::WebPage::setViewGeometry):
1415
1416 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1417
1418         Reviewed by Gustavo Noronha Silva.
1419
1420         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1421         as the implementation is being used by at least Qt and Gtk+.
1422
1423         Update buildsystems as well.
1424
1425         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1426         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1427         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1428         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1429         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1430         * GNUmakefile.am:
1431
1432 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1433
1434         Reviewed by Alexey Proskuryakov.
1435
1436         Disable wss until all platforms support pyOpenSSL
1437
1438         https://bugs.webkit.org/show_bug.cgi?id=31479
1439
1440         * Scripts/run-webkit-tests:
1441
1442 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1443
1444         Reviewed by Kenneth Christiansen.
1445
1446         [Qt] Implement load error pages support for Qt's DRT.
1447         https://bugs.webkit.org/show_bug.cgi?id=31509
1448
1449         For now, it will not be a default feature, and layout tests
1450         that want to make use of this have to explicitily call
1451         'handleErrorPages();' for the test source.
1452
1453         Any of the other DumpRenderTree's (mac, win and gtk)
1454         support handling error pages. Qt's will be the first.
1455
1456         * DumpRenderTree/qt/DumpRenderTree.cpp:
1457         (WebCore::WebPage::supportsExtension):
1458         (WebCore::WebPage::extension):
1459         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1460         (LayoutTestController::reset):
1461         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1462         (LayoutTestController::shouldHandleErrorPages):
1463         (LayoutTestController::handleErrorPages):
1464
1465 2009-11-16  Eric Seidel  <eric@webkit.org>
1466
1467         Reviewed by Adam Barth.
1468
1469         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1470         https://bugs.webkit.org/show_bug.cgi?id=31549
1471
1472         Renamed --commit-queue to --non-interactive in most places
1473         and remove the code in land-patches which is no longer needed.
1474
1475         * Scripts/bugzilla-tool:
1476
1477 2009-11-16  Eric Seidel  <eric@webkit.org>
1478
1479         Reviewed by Adam Barth.
1480
1481         The commit-queue should use land-attachment
1482         https://bugs.webkit.org/show_bug.cgi?id=31548
1483
1484         * Scripts/bugzilla-tool:
1485
1486 2009-11-16  Adam Barth  <abarth@webkit.org>
1487
1488         Reviewed by Eric Seidel.
1489
1490         Convert CommitQueue over to PatchCollection
1491         https://bugs.webkit.org/show_bug.cgi?id=31547
1492
1493         Also fixes a bug in workqueue and adds a test!
1494
1495         * Scripts/bugzilla-tool:
1496         * Scripts/modules/workqueue.py:
1497         * Scripts/modules/workqueue_unittest.py:
1498
1499 2009-11-16  Adam Barth  <abarth@webkit.org>
1500
1501         Reviewed by Eric Seidel.
1502
1503         Move StyleQueue over to using PatchCollection
1504         https://bugs.webkit.org/show_bug.cgi?id=31544
1505
1506         That's what the class it's for.
1507
1508         * Scripts/bugzilla-tool:
1509         * Scripts/modules/patchcollection.py:
1510         * Scripts/modules/patchcollection_unittest.py:
1511
1512 2009-11-16  Eric Seidel  <eric@webkit.org>
1513
1514         Reviewed by Adam Barth.
1515
1516         bugzilla-tool needs a land-attachment command
1517         https://bugs.webkit.org/show_bug.cgi?id=31546
1518
1519         * Scripts/bugzilla-tool:
1520          - Move all the logic into AbstractLandingCommand and
1521            add a new LandAttachment command subclass.
1522          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1523
1524 2009-11-16  Eric Seidel  <eric@webkit.org>
1525
1526         Reviewed by Adam Barth.
1527
1528         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1529         https://bugs.webkit.org/show_bug.cgi?id=31543
1530
1531         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1532
1533         * Scripts/bugzilla-tool:
1534
1535 2009-11-16  Eric Seidel  <eric@webkit.org>
1536
1537         Reviewed by Adam Barth.
1538
1539         Disable the style queue from posting to the commit queue status page.
1540
1541         * Scripts/bugzilla-tool:
1542
1543 2009-11-16  Adam Barth  <abarth@webkit.org>
1544
1545         Reviewed by Eric Seidel.
1546
1547         Implement PatchCollection
1548         https://bugs.webkit.org/show_bug.cgi?id=31541
1549
1550         This class holds a set of patches and lets clients iterate through
1551         them.  Optionally, clients can install a filter.
1552
1553         * Scripts/modules/patchcollection.py: Added.
1554         * Scripts/modules/patchcollection_unittest.py: Added.
1555         * Scripts/run-webkit-unittests:
1556
1557 2009-11-16  Eric Seidel  <eric@webkit.org>
1558
1559         Reviewed by Adam Barth.
1560
1561         bugzilla-tool land-patches will close bugs with patches r=?
1562         https://bugs.webkit.org/show_bug.cgi?id=28230
1563
1564         The commit-queue shouldn't close patches with outstanding reviews on them,
1565         even if many reviewers seem to be against multi-patch bugs.
1566
1567         * Scripts/bugzilla-tool:
1568
1569 2009-11-16  Eric Seidel  <eric@webkit.org>
1570
1571         Reviewed by Adam Barth.
1572
1573         bugzilla-tool check-style should work with attachment ids instead of bug ids
1574         https://bugs.webkit.org/show_bug.cgi?id=31540
1575
1576         * Scripts/bugzilla-tool:
1577
1578 2009-11-16  Eric Seidel  <eric@webkit.org>
1579
1580         Reviewed by Adam Barth.
1581
1582         WorkQueue is the only place that should know about special exit codes
1583         https://bugs.webkit.org/show_bug.cgi?id=31534
1584
1585         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1586         and add tests for handling exit codes.
1587         I also cleaned up workqueue_unittest.py more.
1588
1589         * Scripts/bugzilla-tool:
1590         * Scripts/modules/workqueue.py:
1591         * Scripts/modules/workqueue_unittest.py:
1592
1593 2009-11-16  Eric Seidel  <eric@webkit.org>
1594
1595         Reviewed by Adam Barth.
1596
1597         Re-factor workqueue_unittest to allow for more than one test.
1598         https://bugs.webkit.org/show_bug.cgi?id=31535
1599
1600         * Scripts/modules/workqueue_unittest.py:
1601
1602 2009-11-16  Eric Seidel  <eric@webkit.org>
1603
1604         Reviewed by Adam Barth.
1605
1606         land-patches needs to be re-factored into smaller chunks
1607         https://bugs.webkit.org/show_bug.cgi?id=31532
1608
1609         * Scripts/bugzilla-tool: fix a couple obvious typos.
1610
1611 2009-11-16  Eric Seidel  <eric@webkit.org>
1612
1613         Reviewed by Adam Barth.
1614
1615         land-patches needs to be re-factored into smaller chunks
1616         https://bugs.webkit.org/show_bug.cgi?id=31532
1617
1618         The next patch will move these methods into WebKitLandingScripts.
1619
1620         * Scripts/bugzilla-tool:
1621          - Split out _land_patch and _close_bug_if_no_active_patches.
1622
1623 2009-11-16  Adam Barth  <abarth@webkit.org>
1624
1625         Reviewed by Eric Seidel.
1626
1627         Fix silly copy-and-paste code.  I am a terrible coder.
1628
1629         * Scripts/modules/bugzilla.py:
1630
1631 2009-11-16  Adam Barth  <abarth@webkit.org>
1632
1633         Reviewed by Eric Seidel.
1634
1635         Implement a StyleQueue
1636         https://bugs.webkit.org/show_bug.cgi?id=31537
1637
1638         The first iteration of the style queue only produces output locally.
1639         There is also a limit of 10 patches because it's not that useful to
1640         iterate through the entire review queue at this point.  We can remove
1641         the limit later.
1642
1643         * Scripts/bugzilla-tool:
1644         * Scripts/modules/bugzilla.py:
1645
1646 2009-11-16  Adam Barth  <abarth@webkit.org>
1647
1648         Reviewed by Eric Seidel.
1649
1650         Unit test WorkQueue
1651         https://bugs.webkit.org/show_bug.cgi?id=31531
1652
1653         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1654
1655         * Scripts/bugzilla-tool:
1656         * Scripts/modules/statusbot.py:
1657         * Scripts/modules/workqueue.py:
1658         * Scripts/modules/workqueue_unittest.py: Added.
1659         * Scripts/run-webkit-unittests:
1660
1661 2009-11-16  Eric Seidel  <eric@webkit.org>
1662
1663         Reviewed by Adam Barth.
1664
1665         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1666         https://bugs.webkit.org/show_bug.cgi?id=31530
1667
1668         * Scripts/bugzilla-tool:
1669
1670 2009-11-16  Eric Seidel  <eric@webkit.org>
1671
1672         Reviewed by Adam Barth.
1673
1674         bugzilla-tool needs apply-attachment
1675         https://bugs.webkit.org/show_bug.cgi?id=31528
1676
1677         * Scripts/bugzilla-tool:
1678          - Add ApplyAttachment command.
1679          - Abstract applying code into WebKitApplyingScripts.
1680          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1681         * Scripts/modules/bugzilla.py:
1682          - Add fetch_attachment and bug_id_for_attachment_id.
1683         * Scripts/modules/bugzilla_unittest.py:
1684          - Add test for new parsing.
1685          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1686
1687 2009-11-16  Eric Seidel  <eric@webkit.org>
1688
1689         Reviewed by Adam Barth.
1690
1691         Document check-style's use of force_clean.
1692
1693         * Scripts/bugzilla-tool:
1694         * Scripts/modules/scm.py:
1695
1696 2009-11-16  Adam Barth  <abarth@webkit.org>
1697
1698         Reviewed by Eric Seidel.
1699
1700         Move WorkQueue to its own file
1701         https://bugs.webkit.org/show_bug.cgi?id=31529
1702
1703         WorkQueue and WorkQueueDelegate are separate concerns from
1704         bugzilla-tool.  Also added a missing include to logging.py.
1705
1706         * Scripts/bugzilla-tool:
1707         * Scripts/modules/logging.py:
1708         * Scripts/modules/workqueue.py:
1709
1710 2009-11-16  Adam Barth  <abarth@webkit.org>
1711
1712         Reviewed by Eric Seidel.
1713
1714         Move OutputTee to logging.py.
1715
1716         * Scripts/bugzilla-tool:
1717         * Scripts/modules/logging.py:
1718
1719 2009-11-15  Adam Barth  <abarth@webkit.org>
1720
1721         Reviewed by Eric Seidel.
1722
1723         Refactor bugzilla-tool to allow for multiple queues
1724         https://bugs.webkit.org/show_bug.cgi?id=31513
1725
1726         Divide the commit queue class into three class to make creating
1727         additional queues easier.
1728
1729         * Scripts/bugzilla-tool:
1730
1731 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1732
1733         Reviewed by Eric Seidel.
1734
1735         svn-apply may not handle git patches created by bugzilla-tool
1736         https://bugs.webkit.org/show_bug.cgi?id=31457
1737
1738         * Scripts/modules/scm.py:
1739         * Scripts/modules/scm_unittest.py:
1740
1741 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1742
1743         Reviewed by Eric Seidel.
1744
1745         bugzilla-tool should post git binary diff
1746         https://bugs.webkit.org/show_bug.cgi?id=31458
1747
1748         Add --binary option to Git.create_patch.
1749
1750         * Scripts/modules/scm.py:
1751         * Scripts/modules/scm_unittest.py:
1752
1753 2009-11-15  Adam Barth  <abarth@webkit.org>
1754
1755         Reviewed by Darin Adler.
1756
1757         Add bugzilla-tool check-style
1758         https://bugs.webkit.org/show_bug.cgi?id=31515
1759
1760         * Scripts/bugzilla-tool:
1761         * Scripts/modules/bugzilla.py:
1762
1763 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1764
1765         Reviewed by Simon Hausmann.
1766
1767         Make the Qt Linux only --valgrind feature, suppress errors
1768         defined in the SuppressedValgrindErrors file.
1769
1770         * Scripts/run-webkit-tests:
1771
1772 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1773
1774         Reviewed by Simon Hausmann.
1775
1776         Set the locale to C and not to the current one in use on the system.
1777
1778         * DumpRenderTree/qt/DumpRenderTree.cpp:
1779         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1780
1781 2009-11-13  Adam Roben  <aroben@apple.com>
1782
1783         Add support for
1784         http/tests/security/isolatedWorld/didClearWindowObject.html
1785
1786         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1787         window objects in isolated worlds are cleared
1788
1789         Reviewed by Dave Hyatt.
1790
1791         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1792
1793         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1794         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1795         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1796         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1797         Added. Sets a __worldID property on the global object whose value is
1798         the ID of this world.
1799         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1800         Respond to this new delegate callback by calling through to one of the
1801         above new methods.
1802         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1803         (worldMap): Added. Returns a HashMap containing all the worlds we've
1804         created.
1805         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1806         haven't kept track of this world.
1807         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1808         instead of declaring our own.
1809
1810         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1811
1812         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1813         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1814         didClearWindowObjectForFrameInStandardWorld.
1815         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1816         Respond to this new delegate callback by calling through to one of the
1817         below new methods.
1818         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1819         Added. Sets a __worldID property on the gobal object whose value is
1820         the ID of this world.
1821         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1822         Added. Moved code here from didClearWindowObject.
1823
1824         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1825         didClearWindowObjectForFrame* functions.
1826
1827         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1828         (worldMap): Added. Returns a HashMap containing all the worlds we've
1829         created.
1830         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1831         haven't kept track of this world.
1832         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1833         instead of declaring our own.
1834
1835 2009-11-13  Adam Roben  <aroben@apple.com>
1836
1837         Finish replacing worldIDs with world objects
1838
1839         The only remaining use of worldIDs was in a method only used by DRT
1840         for the isolated worlds tests.
1841
1842         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1843
1844         Reviewed by Mark Rowe.
1845
1846         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1847         (LayoutTestController::evaluateScriptInIsolatedWorld):
1848         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1849         (LayoutTestController::evaluateScriptInIsolatedWorld):
1850         Updated for changes to WebFrame. Now holds the map of worldID -> world
1851         at this level instead of making WebKit do it.
1852
1853 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1854
1855         Reviewed by Simon Hausmann.
1856
1857         [Qt] Ensure the DRT does not output anything until first test is run
1858
1859         * DumpRenderTree/qt/DumpRenderTree.cpp:
1860         * DumpRenderTree/qt/DumpRenderTree.h:
1861
1862 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1863
1864         Reviewed by Tor Arne Vestbø.
1865
1866         Clear the undo stack in before each new test run.
1867
1868         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1869
1870         * DumpRenderTree/qt/DumpRenderTree.cpp:
1871         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1872
1873 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1874
1875         Reviewed by Kenneth Rohde Christiansen.
1876
1877         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1878
1879         * DumpRenderTree/qt/DumpRenderTree.cpp:
1880         (WebCore::WebPage::resetSettings):
1881         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1882         (LayoutTestController::overridePreference):
1883
1884 2009-11-13  Eric Seidel  <eric@webkit.org>
1885
1886         Reviewed by Adam Barth.
1887
1888         Update committers.py based on svn records
1889         https://bugs.webkit.org/show_bug.cgi?id=31366
1890
1891         This list was generated using validate-committer-lists from
1892         https://bugs.webkit.org/show_bug.cgi?id=30970
1893         and makes committers.py current for committers who have
1894         committed in the last 3 years.
1895
1896         * Scripts/modules/committers.py:
1897
1898 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1899
1900         Reviewed by Adam Barth.
1901
1902         The document-open.html test was flaky at times. The test invokes the layout test plugin
1903         which in its destroy stream handler opens a new document. This basically tears down the
1904         stream and the associated plugin instance. The pluginLog function in the layout test
1905         plugin attempts to retrieve the window script object on a torn down plugin instance
1906         which crashed consistently on windows in the debugger. The functions which issue
1907         these logs already have a valid window script object. We now have variants of the pluginLog
1908         function which take in a window script object with and without variable arguments. 
1909
1910         https://bugs.webkit.org/show_bug.cgi?id=31067
1911
1912         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1913         (pluginLogWithWindowObject):
1914         (pluginLogWithWindowObjectVariableArgs):
1915         (pluginLog):
1916         (notifyTestCompletion):
1917         (testDocumentOpen):
1918         (testWindowOpen):
1919
1920 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1921
1922         Reviewed by Gustavo Noronha Silva.
1923
1924         https://bugs.webkit.org/show_bug.cgi?id=30997
1925         [Gtk] Implemment AtkDocument
1926
1927         Added testing support.
1928
1929         * DumpRenderTree/AccessibilityUIElement.cpp:
1930         * DumpRenderTree/AccessibilityUIElement.h:
1931         (getDocumentEncodingCallback):
1932         (getDocumentURICallback):
1933         (AccessibilityUIElement::getJSClass):
1934         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1935         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1936         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1937         (AccessibilityUIElement::documentEncoding):
1938         (AccessibilityUIElement::documentURI):
1939
1940 2009-11-12  Adam Roben  <aroben@apple.com>
1941
1942         Replace worldIDs with world objects
1943
1944         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1945         user scripts/stylesheets and isolated worlds
1946
1947         Reviewed by Sam Weinig.
1948
1949         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1950         (LayoutTestController::addUserScript):
1951         (LayoutTestController::addUserStyleSheet):
1952         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1953         (LayoutTestController::addUserScript):
1954         (LayoutTestController::addUserStyleSheet):
1955         Changed these functions to create a new WebJSWorld each time they're
1956         called and to pass that world to WebKit.
1957
1958 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1959
1960         Reviewed by Oliver Hunt.
1961
1962         need to implement aria tree roles
1963         https://bugs.webkit.org/show_bug.cgi?id=31284
1964
1965         * DumpRenderTree/AccessibilityUIElement.cpp:
1966         (disclosedRowAtIndexCallback):
1967         (selectedRowAtIndexCallback):
1968         (isEqualCallback):
1969         (isAttributeSettableCallback):
1970         (isActionSupportedCallback):
1971         (disclosedByRowCallback):
1972         (hierarchicalLevelCallback):
1973         (AccessibilityUIElement::getJSClass):
1974         * DumpRenderTree/AccessibilityUIElement.h:
1975         (AccessibilityUIElement::isEqual):
1976         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1977         (AccessibilityUIElement::hierarchicalLevel):
1978         (AccessibilityUIElement::disclosedRowAtIndex):
1979         (AccessibilityUIElement::selectedRowAtIndex):
1980         (AccessibilityUIElement::disclosedByRow):
1981         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1982         (AccessibilityUIElement::getChildAtIndex):
1983         (AccessibilityUIElement::disclosedRowAtIndex):
1984         (AccessibilityUIElement::selectedRowAtIndex):
1985         (AccessibilityUIElement::titleUIElement):
1986         (AccessibilityUIElement::parentElement):
1987         (AccessibilityUIElement::disclosedByRow):
1988         (AccessibilityUIElement::hierarchicalLevel):
1989         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1990         (AccessibilityUIElement::hierarchicalLevel):
1991         (AccessibilityUIElement::disclosedRowAtIndex):
1992         (AccessibilityUIElement::selectedRowAtIndex):
1993         (AccessibilityUIElement::disclosedByRow):
1994
1995 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1996
1997         Reviewed by Darin Adler.
1998
1999         svn-apply can not handle git binary diffs
2000         https://bugs.webkit.org/show_bug.cgi?id=26830
2001
2002         Support "literal" type git binary diffs.
2003
2004         * Scripts/VCSUtils.pm:
2005         * Scripts/modules/scm_unittest.py:
2006         * Scripts/svn-apply:
2007
2008 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2009
2010         Not reviewed, removing duplicate entry for myself in committers.py.
2011
2012         * Scripts/modules/committers.py:
2013
2014 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2015
2016         Reviewed by Darin Adler and Mark Rowe.
2017
2018         https://bugs.webkit.org/show_bug.cgi?id=31200
2019         Tests in http/tests/security/mixedContent start to fail when new tests are added
2020
2021         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2022
2023 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2024
2025         Reviewed by Jan Alonzo.
2026
2027         Create, and display a window for the inspector, for inspector
2028         tests.
2029
2030         Need to also show/hide the inspector window to avoid having
2031         problems with code assuming it is realized
2032         https://bugs.webkit.org/show_bug.cgi?id=31347
2033
2034         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2035         (webInspectorShowWindow):
2036         (webInspectorCloseWindow):
2037         (webInspectorInspectWebView):
2038         (createWebView):
2039
2040 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2041
2042         Unreviewed Qt buildbot fix.
2043
2044         My previous fix was wrong, so revert that change and fix it by
2045         returning when the document of the frame has no document element.
2046         Idea is borrowed from mac and win DRT.
2047
2048         * DumpRenderTree/qt/DumpRenderTree.cpp:
2049         (WebCore::DumpRenderTree::dumpFramesAsText):
2050
2051 2009-11-11  Eric Seidel  <eric@webkit.org>
2052
2053         Reviewed byg Kenneth Rohde Christiansen.
2054
2055         Update Kenneth's committer record to include the email he
2056         uses on lists.webkit.org.
2057
2058         * Scripts/modules/committers.py:
2059
2060 2009-11-11  Eric Seidel  <eric@webkit.org>
2061
2062         Reviewed by Gustavo Noronha Silva.
2063
2064         Several committers use separate email addresses for bugzilla and svn.webkit.org
2065         https://bugs.webkit.org/show_bug.cgi?id=31364
2066
2067         Update records for existing committers to include email addresses
2068         used in svn.webkit.org and lists.webkit.org.
2069         Most committers use the same email address in all 3 places, but some use
2070         separate addresses.  committers.py needs record of each of these addresses.
2071
2072         * Scripts/modules/committers.py:
2073
2074 2009-11-11  Eric Seidel  <eric@webkit.org>
2075
2076         No review, adding second email address for an existing committer.
2077
2078         Add Yong Li's second bugzilla account to his committer record.
2079         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2080
2081         * Scripts/modules/committers.py:
2082
2083 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2084
2085         Reviewed by Simon Hausmann.
2086
2087         If the frame has no innerText don't append it, and
2088         do not add a newline which breaks some cross platform
2089         results.
2090
2091         * DumpRenderTree/qt/DumpRenderTree.cpp:
2092         (WebCore::DumpRenderTree::dumpFramesAsText):
2093
2094 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2095
2096         Reviewed by Simon Hausmann.
2097
2098         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2099
2100         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2101         (webkit_test_plugin_new_instance):
2102         (webkit_test_plugin_destroy_instance):
2103         (webkit_test_plugin_destroy_stream):
2104
2105 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2106
2107         Reviewed by Mark Rowe.
2108
2109         Implement the functionality needed by plugins/window-open.html
2110
2111         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2112         (webkit_test_plugin_new_instance):
2113         (webkit_test_plugin_set_window):
2114
2115 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2116
2117         Reviewed by Simon Hausmann.
2118
2119         [Qt] Force -graphicssystem raster and -style windows when running DRT
2120
2121         * DumpRenderTree/qt/main.cpp:
2122         * Scripts/run-webkit-tests:
2123
2124 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2125
2126         Reviewed by Simon Hausmann.
2127
2128         Compute correct library paths for Qt
2129
2130         * Scripts/webkitdirs.pm:
2131
2132 2009-11-10  Mark Rowe  <mrowe@apple.com>
2133
2134         Reviewed by Sam Weinig.
2135
2136         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2137
2138         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2139         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2140         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2141         that had enabled frame load delegate logging this would result in extra log messages being generated,
2142         causing the test to fail.
2143
2144         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2145         tests.
2146
2147         * DumpRenderTree/mac/DumpRenderTree.mm:
2148         (dumpRenderTree):
2149         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2150         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2151
2152 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2153
2154         Reviewed by Kenneth Rohde Christiansen.
2155
2156         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2157
2158         * DumpRenderTree/qt/DumpRenderTree.cpp:
2159         (WebCore::DumpRenderTree::DumpRenderTree):
2160
2161 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2162
2163         Reviewed by Jan Alonzo.
2164
2165         [GTK] Remove WebSocket configuration from WebKitWebSettings
2166         https://bugs.webkit.org/show_bug.cgi?id=31244
2167
2168         Follow-up of r50724. Don't set the enable-web-socket property
2169         anymore.
2170
2171         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2172         (resetDefaultsToConsistentValues):
2173
2174 2009-11-10  Oliver Hunt  <oliver@apple.com>
2175
2176         Reviewed by Maciej Stachowiak.
2177
2178         Rename 3D Canvas related classes to use WebGL prefix
2179         https://bugs.webkit.org/show_bug.cgi?id=29095
2180
2181         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2182         and upate webkitdirs script to new method of testing for WebGL.
2183
2184         * Scripts/do-webcore-rename:
2185         * Scripts/webkitdirs.pm:
2186
2187 2009-11-09  Oliver Hunt  <oliver@apple.com>
2188
2189         Reviewed by Geoff Garen.
2190
2191         Make do-webcore-rename work with git.
2192
2193         * Scripts/do-webcore-rename:
2194
2195 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2196
2197         Adding Kenneth to the reviewers list.
2198
2199         * Scripts/modules/committers.py:
2200
2201 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2202
2203         Reviewed by Jan Alonzo.
2204
2205         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2206         https://bugs.webkit.org/show_bug.cgi?id=30482
2207
2208         LayoutTestControllerGtk now uses the exposed
2209         Page::tabKeyCyclesThroughElements API
2210
2211         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2212         (LayoutTestController::setTabKeyCyclesThroughElements):
2213
2214 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2215
2216         Reviewed by Holger Freyther.
2217
2218         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2219         This helps to pass the test case below. Also replaced hardcoded
2220         code numbers with defined constants.
2221         https://bugs.webkit.org/show_bug.cgi?id=31185
2222         
2223         Test: editing/undo/undo-deleteWord.html
2224
2225         * DumpRenderTree/qt/EventSenderQt.cpp:
2226         (EventSender::keyDown):
2227
2228 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2229
2230         Reviewed by Holger Freyther.
2231
2232         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2233         https://bugs.webkit.org/show_bug.cgi?id=31164
2234
2235         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2236
2237         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2238         (LayoutTestController::processWork):
2239
2240 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2241
2242         Reviewed by Holger Freyther.
2243
2244         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2245         https://bugs.webkit.org/show_bug.cgi?id=31158
2246
2247         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2248         always, which from WorkQueue prospective means that a load has been started
2249         and the queue processing should stop and wait for the load to finish.
2250         Spinning it off into a loading and a non-loading variants was the solution
2251         adopted by Mac's DRT to work around this problem. The former keeps returning
2252         'true' while the later executes the script synchronously and returns 'false'
2253         making it possible to the WorkQueue to proceed right away.
2254
2255         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2256         (LayoutTestController::processWork):
2257         (LayoutTestController::queueLoadingScript):
2258         (LayoutTestController::queueNonLoadingScript):
2259         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2260         * DumpRenderTree/qt/WorkQueueItem.h:
2261         (LoadingScriptItem::LoadingScriptItem):
2262         (LoadingScriptItem::invoke):
2263         (NonLoadingScriptItem::NonLoadingScriptItem):
2264         (NonLoadingScriptItem::invoke):
2265
2266 2009-11-07  Mark Rowe  <mrowe@apple.com>
2267
2268         Rubber-stamped by Cameron Zwarich.
2269
2270         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2271
2272         * Scripts/commit-log-editor:
2273
2274 2009-11-07  Mark Rowe  <mrowe@apple.com>
2275
2276         Reviewed by Darin Adler.
2277
2278         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2279         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2280
2281         Move logic for determining the name and email address to use in a ChangeLog entry from
2282         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2283         whether the author of the patch matches committer, and therefore needs access to the
2284         email address that would be used in a ChangeLog entry.
2285
2286         Based on a patch by Pierre d'Herbemont.
2287
2288         * Scripts/VCSUtils.pm:
2289         * Scripts/commit-log-editor:
2290         * Scripts/prepare-ChangeLog:
2291         * Scripts/webkitdirs.pm:
2292
2293 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2294
2295         Reviewed by Adam Barth.
2296
2297         Added functionality to the layout test plugin to invoke document.open and
2298         window.open with default arguments. The associated webkit bug is
2299         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2300         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2301         work in Chromium (V8) if there is no calling javascript context. To achieve this
2302         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2303         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2304
2305         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2306         (testDocumentOpen):
2307         (testWindowOpen):
2308         (pluginAllocate):
2309         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2310         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2311         (NPP_New):
2312         (NPP_SetWindow):
2313         (NPP_DestroyStream):
2314         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2315         (NPP_New):
2316         (NPP_SetWindow):
2317         (NPP_NewStream):
2318         (NPP_DestroyStream):
2319
2320 2009-11-06  Eric Seidel  <eric@webkit.org>
2321
2322         Reviewed by Adam Barth.
2323
2324         bugzilla-tool crashed with exception
2325         https://bugs.webkit.org/show_bug.cgi?id=31092
2326
2327         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2328
2329 2009-11-04  Eric Seidel  <eric@webkit.org>
2330
2331         No review, just add a line which got left out of the patch uploaded for commit.
2332
2333         commit-queue is crashing when trying to reject patches after unknown failures
2334         https://bugs.webkit.org/show_bug.cgi?id=31091
2335
2336         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2337
2338 2009-11-04  Adam Roben  <aroben@apple.com>
2339
2340         Remove bogus else clause in bugzilla-tool
2341
2342         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2343         create-bug raises exception after entering bug description
2344
2345         Reviewed by David Kilzer.
2346
2347         * Scripts/bugzilla-tool:
2348         (CreateBug): else clauses are only hit if no exception is raised, so
2349         it makes no sense to try to re-raise the exception in an else clause.
2350         The exception will automatically be re-raised if it doesn't match any
2351         of the except clauses, so we don't have to do anything special here at
2352         all to get the desired behavior.
2353
2354 2009-11-04  Eric Seidel  <eric@webkit.org>
2355
2356         Reviewed by David Kilzer.
2357
2358         svn-apply's fixChangeLogPatch function seems broken
2359         https://bugs.webkit.org/show_bug.cgi?id=30683
2360
2361         Update fixChangeLogPatch to be able to handle patches which
2362         don't start at line 1.
2363         Add unit tests for svn-apply to scm_unittest.py.
2364
2365         * Scripts/VCSUtils.pm:
2366         * Scripts/modules/scm_unittest.py:
2367
2368 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2369
2370         Reviewed by Beth Dakin.
2371
2372         Need to implement ARIA role="combobox"
2373         https://bugs.webkit.org/show_bug.cgi?id=31096
2374
2375         * DumpRenderTree/AccessibilityUIElement.cpp:
2376         (showMenuCallback):
2377         (getIsExpandedCallback):
2378         (AccessibilityUIElement::getJSClass):
2379         * DumpRenderTree/AccessibilityUIElement.h:
2380         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2381         (AccessibilityUIElement::isExpanded):
2382         (AccessibilityUIElement::showMenu):
2383         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2384         (AccessibilityUIElement::isExpanded):
2385         (AccessibilityUIElement::showMenu):
2386         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2387         (AccessibilityUIElement::isSelected):
2388         (AccessibilityUIElement::isExpanded):
2389         (AccessibilityUIElement::showMenu):
2390
2391 2009-11-04  Eric Seidel  <eric@webkit.org>
2392
2393         Reviewed by Adam Barth.
2394
2395         commit-queue is crashing when trying to reject patches after unknown failures
2396         https://bugs.webkit.org/show_bug.cgi?id=31091
2397
2398         * Scripts/bugzilla-tool:
2399          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2400            so we have to find out what the current patch is by asking bugzilla again.
2401          - Discovered that this code was also leaking file descriptors, so fixed that.
2402
2403 2009-11-04  Adam Roben  <aroben@apple.com>
2404
2405         Make run-webkit-tests work for the Debug_Internal Windows
2406         configuration
2407
2408         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2409         suffix.
2410
2411         Fixes <http://webkit.org/b/31123>.
2412
2413         Reviewed by Sam Weinig.
2414
2415         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2416         Debug_Internal, either.
2417
2418 2009-11-04  Eric Seidel  <eric@webkit.org>
2419
2420         Reviewed by Adam Barth.
2421
2422         committers.py needs a way to store non-bugzilla email addresses
2423         https://bugs.webkit.org/show_bug.cgi?id=31037
2424
2425         Make Committer and Reviewer constructors take a single email or a list of emails.
2426         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2427         Expose reviewers(), used by validate-committer-lists on bug 30970.
2428
2429         * Scripts/modules/committers.py:
2430         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2431
2432 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2433
2434         Reviewed by David Levin.
2435
2436         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2437         https://bugs.webkit.org/show_bug.cgi?id=27491
2438
2439         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2440         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2441
2442         Functions to start or stop Web Socket servers are added.
2443
2444         * Scripts/run-webkit-tests:
2445
2446 2009-11-03  Eric Seidel  <eric@webkit.org>
2447
2448         No review, just changing wording of log message.
2449
2450         Change log string to say "failed" instead of "rejected"
2451         when a commit fails due to an out of date checkout.
2452         This makes grepping the commit-queue log for rejected patches easier.
2453
2454         * Scripts/bugzilla-tool:
2455
2456 2009-11-03  Eric Seidel  <eric@webkit.org>
2457
2458         No review, adding commonly known committers missing from the file.
2459
2460         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2461
2462 2009-11-03  Eric Seidel  <eric@webkit.org>
2463
2464         No review, just sort-order cleanup.
2465
2466         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2467
2468 2009-11-03  Stephen White  <senorblanco@chromium.org>
2469
2470         (Unreviewed).
2471
2472         Add myself to committers.py.
2473
2474         * Scripts/modules/committers.py:
2475
2476 2009-11-03  Robin Dunn  <robin@alldunn.com>
2477
2478         Reviewed by Kevin Ollviier.
2479
2480         Add packaging scripts for Debian-based Linux distros.
2481         
2482         https://bugs.webkit.org/show_bug.cgi?id=31075
2483
2484         * wx/packaging/build-debian-installer.py: Added.
2485         * wx/packaging/debian: Added.
2486
2487 2009-11-03  Dan Bernstein  <mitz@apple.com>
2488
2489         Reviewed by Anders Carlsson and Beth Dakin.
2490
2491         https://bugs.webkit.org/show_bug.cgi?id=31070
2492
2493         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2494         destroyed, it executes the value of the 'ondestroy' parameter as a
2495         script.
2496
2497         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2498         (pluginAllocate): Initialize onDestroy.
2499         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2500         onDestroy.
2501         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2502         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2503         specified.
2504         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2505
2506 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2507
2508         Reviewed by Xan Lopez.
2509
2510         https://bugs.webkit.org/show_bug.cgi?id=31035
2511         [GTK] some accessibility tests hitting assertion in debug builds
2512
2513         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2514
2515         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2516         (AccessibilityController::rootElement):
2517
2518 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2519
2520         Reviewed by Beth Dakin.
2521
2522         Support ARIA "tab" roles
2523         https://bugs.webkit.org/show_bug.cgi?id=30842
2524
2525         * DumpRenderTree/AccessibilityUIElement.cpp:
2526         * DumpRenderTree/AccessibilityUIElement.h:
2527         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2528         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2529         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2530
2531 2009-11-01  Eric Seidel  <eric@webkit.org>
2532
2533         Reviewed by David Levin.
2534
2535         buildbots should use --exit-after-N-failures
2536         https://bugs.webkit.org/show_bug.cgi?id=30809
2537
2538         Make the bots exit after 20 failures to prevent never-ending
2539         test runs where every test spends a minute crashing.
2540
2541         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2542
2543 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2544
2545         Reviewed by Eric Seidel.
2546
2547         Turn on warnings for QtWebKit for gcc
2548         https://bugs.webkit.org/show_bug.cgi?id=30958
2549
2550         * DumpRenderTree/qt/main.cpp: 
2551         (crashHandler): Mark function NO_RETURN
2552
2553 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2554
2555         Adding myself to the committers list.
2556
2557         * Scripts/modules/committers.py:
2558
2559 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2560
2561         Fix an issue that Adam noticed in DRT.
2562
2563         Reviewed by Darin Adler.
2564
2565         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2566         (AccessibilityUIElement::role):
2567         Get the length of the role text, and create a buffer dynamically.
2568
2569 2009-10-30  Eric Seidel  <eric@webkit.org>
2570
2571         No review, rolling out r50105.
2572         http://trac.webkit.org/changeset/50105
2573
2574         This commit was causing:
2575         https://bugs.webkit.org/show_bug.cgi?id=30869
2576         We'll re-implement the feature a different way.
2577
2578         * Scripts/bugzilla-tool:
2579
2580 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2581
2582         Test for MSAA: Accessibility of headings is not correct
2583
2584         https://bugs.webkit.org/show_bug.cgi?id=30937
2585
2586         Reviewed by Adam Roben.
2587
2588         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2589         (AccessibilityUIElement::role):
2590         Allow the role returned to be a BSTR.
2591         (AccessibilityUIElement::description):
2592         Fix a copy/paste error.
2593
2594 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2595
2596         Test for MSAA: Accessibility of links is wrong
2597
2598         https://bugs.webkit.org/show_bug.cgi?id=30928
2599
2600         Reviewed by Darin Adler.
2601
2602         * DumpRenderTree/AccessibilityUIElement.cpp:
2603         (getAccessibilityValueCallback):
2604         Return the accessibility value.
2605         (AccessibilityUIElement::getJSClass):
2606         Added "accessibilityValue" value.
2607
2608         * DumpRenderTree/AccessibilityUIElement.h:
2609
2610         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2611         (AccessibilityUIElement::accessibilityValue):
2612         Stubbed.
2613
2614         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2615         (AccessibilityUIElement::accessibilityValue):
2616         Stubbed.
2617
2618         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2619         (AccessibilityUIElement::accessibilityValue):
2620         Get the object's value, and return it as a JS string.
2621
2622 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2623
2624         Fix typo in command name used by wx build system.
2625
2626         * wx/build/build_utils.py:
2627
2628 2009-10-30  Adam Barth  <abarth@webkit.org>
2629
2630         Reviewed by Darin Adler.
2631
2632         Patch v1 is a dumb default name for patches
2633         https://bugs.webkit.org/show_bug.cgi?id=30952
2634
2635         Let's use "Patch" instead.
2636
2637         * Scripts/bugzilla-tool:
2638
2639 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2640
2641         Unreviewed trivial buildfix.
2642
2643         [Qt] Buildfix for r50333.
2644
2645         * DumpRenderTree/qt/DumpRenderTree.pro:
2646
2647 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2648
2649         Reviewed by Holger Freyther.
2650
2651         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2652         https://bugs.webkit.org/show_bug.cgi?id=30953
2653
2654         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2655         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2656         makes qt DRT to share this implementation (as gtk and mac ports do).
2657
2658         * DumpRenderTree/qt/DumpRenderTree.pro:
2659         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2660         * DumpRenderTree/qt/WorkQueue.h: Removed.
2661
2662 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2663
2664         Unreviewed potential buildbot fix.
2665
2666         Second try: Reset page history before running each test.
2667
2668         Apparently the QWebHistory::clear() keeps the current page
2669         in history which is not what we want, so we not additionally
2670         sets the history capacity to 0 (forces removing everything)
2671         and then sets it back to its original value.
2672
2673         * DumpRenderTree/qt/DumpRenderTree.cpp:
2674         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2675
2676 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2677
2678         Unreviewed potential buildbot fix.
2679
2680         Reset page history before running each test.
2681
2682         * DumpRenderTree/qt/DumpRenderTree.cpp:
2683         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2684
2685 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2686
2687         Reviewed by Eric Seidel.
2688
2689         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2690
2691         Bug 28420 -  Implement HTML5 <ruby> rendering
2692         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2693
2694         No new tests (no functional change).
2695
2696         * Scripts/build-webkit:
2697
2698 2009-10-29  Dan Bernstein  <mitz@apple.com>
2699
2700         Reviewed by Mark Rowe.
2701
2702         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2703         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2704         define it.
2705
2706         * Scripts/VCSUtils.pm:
2707         * Scripts/svn-apply:
2708         * Scripts/svn-unapply:
2709
2710 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2711
2712         Reviewed by Gustavo Noronha.
2713
2714         Use the GTK+ main loop instead of rolling our own mini-version of
2715         it.
2716
2717         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2718         (dump):
2719         (runTest):
2720         (webViewLoadFinished):
2721
2722 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2723
2724         Reviewed by Oliver Hunt.
2725
2726         Implement the Qt version of DRT dumpBackForwardList().
2727
2728         * DumpRenderTree/qt/DumpRenderTree.cpp:
2729         (WebCore::dumpHistoryItem):
2730         (WebCore::DumpRenderTree::dumpBackForwardList):
2731
2732 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2733
2734         Reviewed by Adam Roben.
2735
2736         Implement DRT functionality for Qt introduced in
2737         r28690 and r28705.
2738
2739         - Implemented pathToLocalResource which exposes the functionality of
2740         converting a given unix path to the correct location on Windows.
2741         - Implemented a way to remove machine-dependent information from paths
2742         in layout test results.
2743
2744         * DumpRenderTree/qt/DumpRenderTree.cpp:
2745         (WebCore::urlSuitableForTestResult):
2746         (WebCore::WebPage::javaScriptConsoleMessage):
2747         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2748         (LayoutTestController::pathToLocalResource):
2749         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2750
2751 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2752
2753         Adding myself to the committers list.
2754
2755         * Scripts/modules/committers.py:
2756
2757 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2758
2759         Adding myself to the committers list.
2760
2761         * Scripts/modules/committers.py:
2762
2763 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2764
2765         Reviewed by Jan Alonzo.
2766
2767         [GTK] API to start inspector for a WebView
2768         https://bugs.webkit.org/show_bug.cgi?id=22551
2769
2770         Use the new inspector API to implement the LayoutTestController
2771         interfaces used to test the inspector.
2772
2773         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2774         (webInspectorInspectWebView):
2775         (createWebView):
2776         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2777         (LayoutTestController::showWebInspector):
2778         (LayoutTestController::closeWebInspector):
2779         (LayoutTestController::evaluateInWebInspector):
2780
2781 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2782
2783         Reviewed by Eric Seidel.
2784
2785         [Qt] WebFrame::counterValueForElementById must not be exposed
2786         https://bugs.webkit.org/show_bug.cgi?id=30882
2787
2788         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2789         (LayoutTestController::counterValueForElementById):
2790
2791 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2792
2793         Rubberstamped by Oliver Hunt.
2794
2795         Fix the warning:
2796
2797         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2798         declared with attribute warn_unused_result".
2799
2800         by actually checking the result. In the case it is null, an
2801         error has occoured, so treat it as the other fatal errors.
2802
2803         * DumpRenderTree/qt/DumpRenderTree.cpp:
2804         (WebCore::DumpRenderTree::initializeFonts):
2805
2806 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2807
2808         Reviewed by Darin Adler.
2809
2810         Provide a way to get counter values with layoutTestContoller
2811         https://bugs.webkit.org/show_bug.cgi?id=30555
2812
2813         Define layoutTestContoller.counterValueForElementById.
2814
2815         * DumpRenderTree/LayoutTestController.cpp:
2816         (counterValueForElementByIdCallback):
2817         (LayoutTestController::staticFunctions):
2818         * DumpRenderTree/LayoutTestController.h:
2819         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2820         (LayoutTestController::counterValueForElementById):
2821
2822 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2823
2824         Rubberstamped by Oliver Hunt.
2825
2826         Change two methods to be internal for DRT use only.
2827
2828         Part of [Qt] Review all new API in Qt 4.6
2829         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2830
2831         * DumpRenderTree/qt/DumpRenderTree.cpp:
2832         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2833         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2834         (LayoutTestController::whiteListAccessFromOrigin):
2835
2836 2009-10-27  Eric Seidel  <eric@webkit.org>
2837
2838         Reviewed by Adam Barth.
2839
2840         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2841         https://bugs.webkit.org/show_bug.cgi?id=30826
2842
2843         * Scripts/svn-apply:
2844          - Add () around all system() calls.
2845          - Use the correct system() == 0 or die instead of system() or die
2846          - Add descriptive messages to all die statements.
2847
2848 2009-10-27  Steve Block  <steveblock@google.com>
2849
2850         Reviewed by NOBODY.
2851
2852         Adds steveblock@google.com to list of committers.
2853
2854         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2855
2856 2009-10-27  Eric Seidel  <eric@webkit.org>
2857
2858         Reviewed by Adam Barth.
2859
2860         svn-apply can exit(0) even on patch failure
2861         https://bugs.webkit.org/show_bug.cgi?id=29622
2862
2863         * Scripts/svn-apply:
2864          - Add a bunch of "or die" statements, hopefully catching all
2865            possible cases where failure could still exit(0).
2866
2867 2009-10-27  Eric Seidel  <eric@webkit.org>
2868
2869         Reviewed by Adam Barth.
2870
2871         svn-* scripts should share code through VCSUtils.pm
2872         https://bugs.webkit.org/show_bug.cgi?id=30791
2873
2874         Just moving code into a shared location.
2875
2876         * Scripts/VCSUtils.pm:
2877         * Scripts/prepare-ChangeLog:
2878         * Scripts/resolve-ChangeLogs:
2879         * Scripts/svn-apply:
2880         * Scripts/svn-create-patch:
2881         * Scripts/svn-unapply:
2882         * Scripts/update-webkit:
2883
2884 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2885
2886         Suppress a huge number of MSVC warnings when building wxWebKit.
2887
2888         * wx/build/settings.py:
2889
2890 2009-10-26  Eric Seidel  <eric@webkit.org>
2891
2892         No review, just adding Mike Belshe to the committers list.
2893
2894         * Scripts/modules/committers.py:
2895
2896 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2897
2898         Reviewed by Darin Adler.
2899
2900         Make .rc files compile on Windows without depending on MFC headers
2901         https://bugs.webkit.org/show_bug.cgi?id=30750
2902
2903         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2904         windows.h instead of afxres.h because it exists even when MFC is not 
2905         installed, and is all that's needed here.
2906
2907         * FindSafari/FindSafari.rc: Ditto
2908
2909 2009-10-24  Eric Seidel  <eric@webkit.org>
2910
2911         Reviewed by Adam Barth.
2912
2913         bugzilla-tool post-diff should know how to mark commit-queue=?
2914         https://bugs.webkit.org/show_bug.cgi?id=29202
2915
2916         * Scripts/bugzilla-tool:
2917          - Add --commit-queue option to post-diff, post-commits and create-bug.
2918         * Scripts/modules/bugzilla.py:
2919          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2920          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2921
2922 2009-10-23  Eric Seidel  <eric@webkit.org>
2923
2924         Reviewed by Adam Barth.
2925
2926         bugzilla-tool commit-queue does not notice modifications to committers.py
2927         https://bugs.webkit.org/show_bug.cgi?id=30084
2928
2929         * Scripts/bugzilla-tool:
2930          - Make commit-queue re-exec itself instead of using while(1).
2931          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2932          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2933
2934 2009-10-22  Eric Seidel  <eric@webkit.org>
2935
2936         Reviewed by Adam Barth.
2937
2938         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2939         https://bugs.webkit.org/show_bug.cgi?id=30634
2940
2941         * Scripts/bugzilla-tool:
2942          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2943          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2944
2945 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2946
2947         Reviewed by Eric Seidel.
2948
2949         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2950
2951         https://bugs.webkit.org/show_bug.cgi?id=30763
2952
2953         * pywebsocket/mod_pywebsocket/__init__.py:
2954         * pywebsocket/mod_pywebsocket/dispatch.py:
2955         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2956         * pywebsocket/mod_pywebsocket/standalone.py:
2957         * pywebsocket/setup.py:
2958         * pywebsocket/test/test_dispatch.py:
2959
2960 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2961
2962         Reviewed by David Levin.
2963
2964         REGRESSION: 2 failures in run-webkit-unittests
2965         https://bugs.webkit.org/show_bug.cgi?id=30645
2966
2967         * Scripts/modules/cpp_style_unittest.py:
2968         Fixed a few test scenarios which apparently lost some spaces from 
2969         text literals.
2970
2971 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2972
2973         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2974
2975         * Scripts/webkitdirs.pm:
2976
2977 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2978
2979         Reviewed by Darin Adler.
2980
2981         Unification of using null device in perl scripts.
2982         https://bugs.webkit.org/show_bug.cgi?id=30572
2983
2984         * Scripts/VCSUtils.pm:
2985         * Scripts/bisect-builds:
2986         * Scripts/resolve-ChangeLogs:
2987         * Scripts/run-iexploder-tests:
2988         * Scripts/run-jsc:
2989         * Scripts/run-mangleme-tests:
2990         * Scripts/run-webkit-tests:
2991         * Scripts/webkitdirs.pm:
2992         Using File::Spec->devnull() instead of hard coded /dev/null.
2993
2994 2009-10-26  Eric Seidel  <eric@webkit.org>
2995
2996         Reviewed by Holger Freyther.
2997
2998         Reviewers are missing from committers.py
2999         https://bugs.webkit.org/show_bug.cgi?id=30733
3000
3001         * Scripts/modules/committers.py:
3002
3003 2009-10-23  Eric Seidel  <eric@webkit.org>
3004
3005         No review, only adding Alice to the list of reviewers.
3006
3007         * Scripts/modules/committers.py:
3008
3009 2009-10-23  Eric Seidel  <eric@webkit.org>
3010
3011         Reviewed by Eric Carlson.
3012
3013         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3014         https://bugs.webkit.org/show_bug.cgi?id=30700
3015
3016         * DumpRenderTree/mac/DumpRenderTree.mm:
3017         (resetDefaultsToConsistentValues): Update QuickTime version check.
3018
3019 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3020
3021         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3022         character measurement APIs that are private on Tiger.
3023
3024         * wx/build/settings.py:
3025
3026 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3027
3028         Reviewed by NOBODY (build fix).
3029         Build fix following bug #30696.
3030
3031         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3032         (LayoutTestController::evaluateScriptInIsolatedWorld):
3033
3034 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3035
3036         Reviewed by Sam Weinig & Geoff Garen.
3037
3038         https://bugs.webkit.org/show_bug.cgi?id=30696
3039         Enable isolated-worlds tests on mac.
3040
3041         Add private interface for DRT to invoke execution in a given world.
3042
3043         * DumpRenderTree/LayoutTestController.cpp:
3044         (evaluateScriptInIsolatedWorldCallback):
3045         (LayoutTestController::staticFunctions):
3046         * DumpRenderTree/LayoutTestController.h:
3047         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3048         (LayoutTestController::evaluateScriptInIsolatedWorld):
3049         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3050         (LayoutTestController::evaluateScriptInIsolatedWorld):
3051
3052 2009-10-21  Eric Seidel  <eric@webkit.org>
3053
3054         Reviewed by Adam Barth.
3055
3056         bugzilla-tool's "patch failed to download an apply" error should give more information
3057         https://bugs.webkit.org/show_bug.cgi?id=30632
3058
3059         * Scripts/modules/scm.py:
3060          - Use the common run_command method instead of custom POpen code.
3061          - Make run_command know how to take pipes as input.
3062         * Scripts/modules/scm_unittest.py:
3063          - Add new tests to cover change.
3064          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3065
3066 2009-10-21  Kent Tamura  <tkent@chromium.org>
3067
3068         Unreviewed.  Adding myself to the committers list.
3069
3070         * Scripts/modules/committers.py:
3071
3072 2009-10-21  Robin Dunn  <robin@alldunn.com>
3073
3074         Reviewed by Kevin Ollivier.
3075
3076         Update the Windows installer builder to work with Vista / Win 7 and with git.
3077         
3078         https://bugs.webkit.org/show_bug.cgi?id=30649
3079
3080         * wx/build/build_utils.py:
3081         * wx/packaging/build-mac-installer.py:
3082         * wx/packaging/build-win-installer.py:
3083         * wx/packaging/wxWebKitInstaller.iss.in:
3084
3085 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3086
3087         Reviewed by Gustavo Noronha.
3088
3089         [GTK] Added conditional code to avoid using
3090         gdk_window_get_root_coords if we do not have a gtk+ release newer
3091         than 2.17.3.
3092         https://bugs.webkit.org/show_bug.cgi?id=30636
3093
3094         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3095
3096 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3097
3098         Reviewed by Eric Seidel.
3099
3100         [Qt] Added dummy implementation for keepWebHistory()
3101         https://bugs.webkit.org/show_bug.cgi?id=30592
3102
3103         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3104         (LayoutTestController::keepWebHistory):
3105         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3106
3107 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3108
3109         Reviewed by Xan Lopez.
3110
3111         [GTK] Fixed the double click condition, it is not double click if
3112         we move in just in one direction.
3113         https://bugs.webkit.org/show_bug.cgi?id=30636
3114
3115         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3116
3117 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3118
3119         Reviewed by Xan Lopez.
3120
3121         [GTK] Initialize the events completly before emitting them.
3122         https://bugs.webkit.org/show_bug.cgi?id=30633
3123
3124         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3125
3126 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3127
3128         wx build fix. Fix for when linking using --as-needed with gcc.
3129
3130         * wx/browser/wscript:
3131
3132 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3133
3134         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3135         to support all the features used by CURL backend.
3136         
3137         * wx/build/settings.py:
3138         * wx/install-unix-extras:
3139
3140 2009-10-20  Anton Muhin  <antonm@chromium.org>
3141
3142         Reviewed by Adam Barth.
3143
3144         Add {ager,antonm,yurys}@chromium.org into committers.py
3145         https://bugs.webkit.org/show_bug.cgi?id=30560
3146
3147         * Scripts/modules/committers.py:
3148
3149 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3150
3151         Reviewed by Tor Arne Vestbø.
3152
3153         Make the Netscape Test plugin available to the Qt launcher.
3154
3155         * Scripts/run-launcher:
3156
3157 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3158
3159         Reviewed by David Levin.
3160
3161         Removed WebSocket runtime settings.
3162         https://bugs.webkit.org/show_bug.cgi?id=29896
3163
3164         WebSocket runtime configuration is supported by chromium/v8 only.
3165
3166         * DumpRenderTree/mac/DumpRenderTree.mm:
3167         (resetDefaultsToConsistentValues):
3168         * DumpRenderTree/win/DumpRenderTree.cpp:
3169         (resetDefaultsToConsistentValues):
3170
3171 2009-10-19  Nate Chapin  <japhet@chromium.org>
3172
3173         Reviewed by Adam Barth.
3174
3175         Add testFail() to test plugin so we can test our handling of a
3176         plugin invoke call returning false.
3177
3178         https://bugs.webkit.org/show_bug.cgi?id=30239
3179
3180         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3181         (pluginInvoke):
3182         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3183
3184 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3185
3186         Reviewed by Gustavo Noronha.
3187
3188         Enable DOM pasting when running layout tests.
3189
3190         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3191         (resetDefaultsToConsistentValues):
3192
3193 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3194
3195         Reviewed by Simon Hausmann.
3196
3197         Use the setPreferredContentsSize method instead
3198         of setFixedContentsSize, as the method has been renamed.
3199
3200         * DumpRenderTree/qt/DumpRenderTree.cpp:
3201         (WebCore::DumpRenderTree::open):
3202         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3203         (LayoutTestController::setFixedContentsSize):
3204
3205 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3206
3207         Reviewed by Dan Bernstein.
3208
3209         https://bugs.webkit.org/show_bug.cgi?id=30456
3210         Fixes for new Debug_All Windows build configuration.
3211
3212         * DumpRenderTree/win/DumpRenderTree.cpp:
3213         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3214         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3215
3216 2009-10-16  Eric Seidel  <eric@webkit.org>
3217
3218         Reviewed by Adam Barth.
3219
3220         commit-queue status bot should list which buildbot is blocking the queue
3221         https://bugs.webkit.org/show_bug.cgi?id=30452
3222
3223         Add new methods and testing.
3224
3225         * Scripts/bugzilla-tool:
3226         * Scripts/modules/buildbot.py:
3227         * Scripts/modules/buildbot_unittest.py:
3228
3229 2009-10-16  Eric Seidel  <eric@webkit.org>
3230
3231         Reviewed by Adam Barth.
3232
3233         run-webkit-tests fails when CWD is not inside a WebKit checkout
3234         https://bugs.webkit.org/show_bug.cgi?id=30451
3235
3236         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3237         * Scripts/modules/scm_unittest.py:
3238           - Remove use of original_path (we don't need to restore the CWD).
3239           - Don't use '.' to find the webkit checkout, use __file__ instead.
3240
3241 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3242
3243         Reviewed by Adam Roben.
3244
3245         Add a Debug_All configuration to build entire stack as debug.
3246         Change Debug_Internal to:
3247         - stop using _debug suffix for all WebKit/Safari binaries
3248         - not use _debug as a DLL naming suffix
3249         - use non-debug C runtime lib.
3250
3251         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3252         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3253         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3254         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3255         Add missing debug.vsprops inherited property sheet.
3256         Add Debug_All configuration.
3257         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3258         * WinLauncher/WinLauncher.vcproj:
3259         Removed extraneous definitions inherited from vsprops.
3260         Add Debug_All configuration.
3261
3262 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3263
3264         Reviewed by David Levin.
3265
3266         check-webkit-style is wrong about indent checking in namespaces
3267         in header files and a few other things
3268         https://bugs.webkit.org/show_bug.cgi?id=30362
3269
3270         The few other things include:
3271         + check-webkit-style does not require spaces around the equal sign
3272           inside 'if' statements and around binary operators that take 
3273           numeric literals.
3274         + check-webkit-style reports false errors for the / operator
3275           when part of a filename in the #include directive.
3276
3277         * Scripts/modules/cpp_style.py:
3278         Improved indentation checking and space checking around
3279         binary operators. While the checks are still not perfect,
3280         they are clearly better than before.
3281         * Scripts/modules/cpp_style_unittest.py:
3282         Added test cases for the newly supported checks and modified old
3283         test cases to match the new guidelines
3284
3285 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3286
3287         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3288
3289         * wx/build/settings.py:
3290
3291 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3292
3293         Reviewed by David Levin.
3294
3295         Add mod_pywebsocket to test Web Sockets.
3296         http://code.google.com/p/pywebsocket/
3297         https://bugs.webkit.org/show_bug.cgi?id=27490
3298
3299         * pywebsocket/COPYING: Added.
3300         * pywebsocket/MANIFEST.in: Added.
3301         * pywebsocket/README: Added.
3302         * pywebsocket/example/echo_client.py: Added.
3303         * pywebsocket/example/echo_wsh.py: Added.
3304         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3305         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3306         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3307         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3308         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3309         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3310         * pywebsocket/mod_pywebsocket/util.py: Added.
3311         * pywebsocket/setup.py: Added.
3312         * pywebsocket/test/config.py: Added.
3313         * pywebsocket/test/mock.py: Added.
3314         * pywebsocket/test/run_all.py: Added.
3315         * pywebsocket/test/test_dispatch.py: Added.
3316         * pywebsocket/test/test_handshake.py: Added.
3317         * pywebsocket/test/test_mock.py: Added.
3318         * pywebsocket/test/test_msgutil.py: Added.
3319         * pywebsocket/test/test_util.py: Added.
3320         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3321         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3322         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3323         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3324         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3325         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3326         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3327         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3328
3329 2009-10-15  James Robinson  <jamesr@google.com>
3330
3331         Reviewed by David Levin.
3332
3333         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3334
3335         https://bugs.webkit.org/show_bug.cgi?id=30426
3336
3337         * Scripts/modules/cpp_style.py:
3338         * Scripts/modules/cpp_style_unittest.py:
3339
3340 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3341
3342         Reviewed by Adam Roben.
3343
3344         Fixes <http://webkit.org/b/30411>.
3345         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3346         
3347         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3348         building Chromium.
3349
3350         * Scripts/pdevenv:
3351
3352 2009-10-15  Robin Dunn  <robin@alldunn.com>
3353
3354         Reviewed by Kevin Ollivier.
3355
3356         Add Mac package building scripts for wx.
3357         
3358         https://bugs.webkit.org/show_bug.cgi?id=30405
3359
3360         * wx/build/build_utils.py:
3361         * wx/build/settings.py:
3362         * wx/packaging/build-mac-installer.py: Added.
3363
3364 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3365
3366         Reviewed by Gustavo Noronha.
3367
3368         Enable Web Sockets support when running layout tests.
3369
3370         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3371         (resetDefaultsToConsistentValues):
3372
3373 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3374
3375         Reviewed by Gustavo Noronha.
3376
3377         Need to initialize event.button.button, since in most cases a
3378         button number is not passed as an argument.
3379
3380         * DumpRenderTree/gtk/EventSender.cpp:
3381         (mouseDownCallback):
3382         (mouseUpCallback):
3383
3384 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3385
3386         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3387         the OS if none was explicitly set.
3388
3389         * wx/build/settings.py:
3390
3391 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3392
3393         Reviewed by Timothy Hatcher.
3394
3395         Web Inspector: enable developers extras within inspector layout tests.
3396
3397         https://bugs.webkit.org/show_bug.cgi?id=30014
3398
3399         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3400         (LayoutTestController::showWebInspector):
3401         (LayoutTestController::closeWebInspector):
3402         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3403         (LayoutTestController::showWebInspector):
3404         (LayoutTestController::closeWebInspector):
3405
3406 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3407
3408         Reviewed by Jan Alonzo.
3409
3410         GtkLauncher is using a deprecated signal
3411         https://bugs.webkit.org/show_bug.cgi?id=30364
3412
3413         Modified GtkLauncher to use notify::title signal instead of
3414         deprecated title-changed signal
3415
3416         * GtkLauncher/main.c:
3417         (notify_title_cb):
3418         (create_browser):
3419
3420 2009-10-14  Brady Eidson  <beidson@apple.com>
3421
3422         Reviewed by Sam Weinig.
3423
3424         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3425         1 - Disables WebHistory
3426         2 - Doesn't make sense in that context anyway.
3427
3428         * DumpRenderTree/win/DumpRenderTree.cpp:
3429         (createWebViewAndOffscreenWindow):
3430
3431 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3432
3433         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3434         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3435
3436         * wx/build/settings.py:
3437         * wx/install-unix-extras:
3438
3439 2009-10-14  Brady Eidson  <beidson@apple.com>
3440
3441         Reviewed by Sam Weinig.
3442
3443         WebKit Win API should provide a delegate interface for global history.
3444         https://bugs.webkit.org/show_bug.cgi?id=29905
3445
3446         * DumpRenderTree/LayoutTestController.cpp:
3447         (LayoutTestController::LayoutTestController):
3448         * DumpRenderTree/LayoutTestController.h:
3449         (LayoutTestController::dumpHistoryDelegateCallbacks):
3450         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3451                 
3452         * DumpRenderTree/win/DumpRenderTree.cpp:
3453         (shouldLogHistoryDelegates):
3454         (runTest):
3455         (createWebViewAndOffscreenWindow):
3456         (main):
3457         * DumpRenderTree/win/DumpRenderTree.vcproj:
3458         
3459         Add the IWebHistoryDelegate to DRT Windows:
3460         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3461         (wstringFromBSTR):
3462         (HistoryDelegate::HistoryDelegate):
3463         (HistoryDelegate::~HistoryDelegate):
3464         (HistoryDelegate::QueryInterface):
3465         (HistoryDelegate::AddRef):
3466         (HistoryDelegate::Release):
3467         (HistoryDelegate::didNavigateWithNavigationData):
3468         (HistoryDelegate::didPerformClientRedirectFromURL):
3469         (HistoryDelegate::didPerformServerRedirectFromURL):
3470         (HistoryDelegate::updateHistoryTitle):
3471         (HistoryDelegate::populateVisitedLinksForWebView):
3472         * DumpRenderTree/win/HistoryDelegate.h: Added.
3473
3474         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3475         (LayoutTestController::removeAllVisitedLinks):
3476
3477 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3478
3479         Reviewed by Simon Hausmann.
3480
3481         [Qt] Implement support for setPOSIXLocale on Qt.
3482         https://bugs.webkit.org/show_bug.cgi?id=30268 
3483  
3484         * DumpRenderTree/qt/DumpRenderTree.cpp:
3485         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3486         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3487         (LayoutTestController::setPOSIXLocale):
3488         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3489
3490 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3491
3492         Unreviewed, adding myself to reviewers list.
3493
3494         * Scripts/modules/committers.py:
3495
3496 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3497
3498         Reviewed by Mark Rowe.
3499
3500         Fix null assignment so root tests work again.
3501
3502         * Scripts/webkitdirs.pm:
3503
3504 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3505
3506         Reviewed by Simon Hausmann.
3507
3508         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3509         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3510         This is done in preparation of implementing missing features in DRT.
3511         No functionality changes made yet.
3512
3513         * DumpRenderTree/qt/DumpRenderTree.cpp:
3514         * DumpRenderTree/qt/DumpRenderTree.pro:
3515         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3516         (EventSender::EventSender):
3517         (EventSender::mouseDown):
3518         (EventSender::mouseUp):
3519         (EventSender::mouseMoveTo):
3520         (EventSender::leapForward):
3521         (EventSender::keyDown):
3522         (EventSender::contextClick):
3523         (EventSender::scheduleAsynchronousClick):
3524         (EventSender::frameUnderMouse):
3525         * DumpRenderTree/qt/EventSenderQt.h: Added.
3526         (EventSender::clearKillRing):
3527         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3528         (LayoutTestController::LayoutTestController):
3529         (LayoutTestController::reset):
3530         (LayoutTestController::processWork):
3531         (LayoutTestController::maybeDump):
3532         (LayoutTestController::waitUntilDone):
3533         (LayoutTestController::notifyDone):
3534         (LayoutTestController::windowCount):
3535         (LayoutTestController::clearBackForwardList):
3536         (LayoutTestController::dumpEditingCallbacks):
3537         (LayoutTestController::dumpResourceLoadCallbacks):
3538         (LayoutTestController::queueBackNavigation):
3539         (LayoutTestController::queueForwardNavigation):
3540         (LayoutTestController::queueLoad):
3541         (LayoutTestController::queueReload):
3542         (LayoutTestController::queueScript):
3543         (LayoutTestController::provisionalLoad):
3544         (LayoutTestController::timerEvent):
3545         (LayoutTestController::encodeHostName):
3546         (LayoutTestController::decodeHostName):
3547         (LayoutTestController::setJavaScriptProfilingEnabled):
3548         (LayoutTestController::setFixedContentsSize):
3549         (LayoutTestController::setPrivateBrowsingEnabled):
3550         (LayoutTestController::setPopupBlockingEnabled):
3551         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3552         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3553         (LayoutTestController::numberOfActiveAnimations):
3554         (LayoutTestController::disableImageLoading):
3555         (LayoutTestController::dispatchPendingLoadRequests):
3556         (LayoutTestController::setDatabaseQuota):
3557         (LayoutTestController::clearAllDatabases):
3558         (LayoutTestController::whiteListAccessFromOrigin):
3559         (LayoutTestController::waitForPolicyDelegate):
3560         (LayoutTestController::overridePreference):
3561         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3562         (LayoutTestController::isLoading):
3563         (LayoutTestController::setLoading):
3564         (LayoutTestController::shouldDumpAsText):
3565         (LayoutTestController::shouldDumpBackForwardList):
3566         (LayoutTestController::shouldDumpChildrenAsText):
3567         (LayoutTestController::shouldDumpDatabaseCallbacks):
3568         (LayoutTestController::shouldDumpStatusCallbacks):
3569         (LayoutTestController::shouldWaitUntilDone):
3570         (LayoutTestController::canOpenWindows):
3571         (LayoutTestController::shouldDumpTitleChanges):
3572         (LayoutTestController::waitForPolicy):
3573         (LayoutTestController::dumpAsText):
3574         (LayoutTestController::dumpChildFramesAsText):
3575         (LayoutTestController::dumpDatabaseCallbacks):
3576         (LayoutTestController::dumpStatusCallbacks):
3577         (LayoutTestController::setCanOpenWindows):
3578         (LayoutTestController::dumpBackForwardList):
3579         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3580         (LayoutTestController::display):
3581         (LayoutTestController::dumpTitleChanges):
3582         (LayoutTestController::dumpSelectionRect):
3583         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3584         (TextInputController::TextInputController):
3585         (TextInputController::doCommand):
3586         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3587         * DumpRenderTree/qt/WorkQueue.cpp:
3588         * DumpRenderTree/qt/WorkQueue.h:
3589         * DumpRenderTree/qt/WorkQueueItem.h:
3590         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3591         (findFrameNamed):
3592         (LoadItem::invoke):
3593         (ReloadItem::invoke):
3594         (ScriptItem::invoke):
3595         (BackForwardItem::invoke):
3596         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3597         * DumpRenderTree/qt/jsobjects.h:
3598
3599 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3600
3601         Not reviewed, adding myself to the list of reviewers.
3602
3603         * Scripts/modules/committers.py:
3604
3605 2009-10-13  Anders Carlsson  <andersca@apple.com>
3606
3607         Reviewed by Sam Weinig.
3608
3609         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3610
3611         Make the private browsing mode testable by the test plug-in.
3612         
3613         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3614         (pluginGetProperty):
3615         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3616         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3617         (NPP_New):
3618         (NPP_SetValue):
3619
3620 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3621
3622         No review, just adding self to the list of reviewers.
3623
3624         * Scripts/modules/committers.py:
3625
3626 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3627
3628         Reviewed by Adam Roben.
3629
3630         Web Inspector: Use proper web view in inspector layout
3631         tests for windows.
3632
3633         https://bugs.webkit.org/show_bug.cgi?id=30298
3634
3635         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3636         (LayoutTestController::showWebInspector):
3637         (LayoutTestController::closeWebInspector):
3638         (LayoutTestController::evaluateInWebInspector):
3639
3640 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3641
3642         Reviewed by Sam Weinig.
3643
3644         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3645         https://bugs.webkit.org/show_bug.cgi?id=29841
3646
3647         * DumpRenderTree/mac/DumpRenderTree.mm:
3648         (resetDefaultsToConsistentValues):
3649         * DumpRenderTree/win/DumpRenderTree.cpp:
3650         (resetDefaultsToConsistentValues):
3651
3652 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3653
3654         Reviewed by Dimitri Glazkov.
3655
3656         Chromium Port - Windows
3657         https://bugs.webkit.org/show_bug.cgi?id=29969
3658
3659         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3660         * Scripts/webkitdirs.pm:
3661
3662 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3663
3664         Reviewed by Darin Adler.
3665
3666         jsc scripts cleanup and Qt/GTK fix
3667         https://bugs.webkit.org/show_bug.cgi?id=30288
3668
3669         Duplicated jscPath() moved to webkitdirs.pm.
3670         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3671         Configuration added (release/debug) to path for Qt-port on Windows.
3672
3673         * Scripts/run-javascriptcore-tests:
3674         * Scripts/run-jsc:
3675         * Scripts/run-sunspider:
3676         * Scripts/sunspider-compare-results:
3677         * Scripts/webkitdirs.pm:
3678
3679 2009-10-11  Adam Barth  <abarth@webkit.org>
3680
3681         Unreviewed.  Add Collin to committers.py.
3682
3683         * Scripts/modules/committers.py:
3684
3685 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3686
3687         wx build fix, add bindings to source/include dirs now that there are sources there.