dd55514313094e4bb82dc84f9716894bb7b1ed9a
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-02  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         trim commands/*.py includes now that commands are unit tested
6         https://bugs.webkit.org/show_bug.cgi?id=32056
7
8         In the course of ensuring that the unit tests still
9         passed after this change, I had to actually make them
10         pass in the first place.
11
12         * Scripts/modules/bugzilla.py:
13          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
14         * Scripts/modules/commands/download.py: Remove unneeded imports.
15         * Scripts/modules/commands/queries.py: Ditto.
16         * Scripts/modules/commands/queues.py: Ditto.
17         * Scripts/modules/commands/upload.py: Ditto.
18         * Scripts/modules/scm_unittest.py:
19          - Fix to expect the \n after the path since echo adds an \n.
20
21 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
22
23         build-webkit: Remove flex,bison,gperf check for chromium
24         https://bugs.webkit.org/show_bug.cgi?id=32043
25
26         * Scripts/webkitdirs.pm:
27
28 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
29
30         Build fixage for Windows/GTK for DumpRenderTree.
31
32         WAI-ARIA: implement support for ARIA drag and drop
33         https://bugs.webkit.org/show_bug.cgi?id=32007
34
35         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
36         (AccessibilityUIElement::ariaIsGrabbed):
37         (AccessibilityUIElement::ariaDropEffects):
38         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
39         (AccessibilityUIElement::ariaIsGrabbed):
40         (AccessibilityUIElement::ariaDropEffects):
41
42 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
43
44         Reviewed by Darin Adler.
45
46         WAI-ARIA: implement support for ARIA drag and drop
47         https://bugs.webkit.org/show_bug.cgi?id=32007
48
49         * DumpRenderTree/AccessibilityUIElement.cpp:
50         (getARIADropEffectsCallback):
51         (getARIAIsGrabbedCallback):
52         (AccessibilityUIElement::getJSClass):
53         * DumpRenderTree/AccessibilityUIElement.h:
54         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
55         (AccessibilityUIElement::ariaIsGrabbed):
56         (AccessibilityUIElement::ariaDropEffects):
57
58 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
59
60         Not reviewed. GTK DRT try 2.
61
62         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
63         (LayoutTestController::sampleSVGAnimationForElementAtTime):
64
65 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
66
67         Not reviewed. Try to fix gtk DRT build.
68
69         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
70
71 2009-12-01  David Levin  <levin@chromium.org>
72
73         Reviewed by Eric Seidel.
74
75         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
76         https://bugs.webkit.org/show_bug.cgi?id=32033
77
78         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
79                                         instead of startswith.
80         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
81
82 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
83
84         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
85
86         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
87
88 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
89
90         Reviewed by Simon Fraser.
91
92         Add SVG animation test framework with 'snapshot' functionality
93         https://bugs.webkit.org/show_bug.cgi?id=31897
94
95         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
96         used by the new SVG animation testing framework, implemented
97         for qt/gtk/win/mac.
98
99         * DumpRenderTree/LayoutTestController.cpp:
100         (sampleSVGAnimationForElementAtTimeCallback):
101         (LayoutTestController::staticFunctions):
102         * DumpRenderTree/LayoutTestController.h:
103         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
104         (LayoutTestController::sampleSVGAnimationForElementAtTime):
105         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
106         (LayoutTestController::sampleSVGAnimationForElementAtTime):
107         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
108         (LayoutTestController::sampleSVGAnimationForElementAtTime):
109         * DumpRenderTree/qt/LayoutTestControllerQt.h:
110         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
111         (LayoutTestController::sampleSVGAnimationForElementAtTime):
112         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
113         (LayoutTestController::sampleSVGAnimationForElementAtTime):
114
115 2009-12-01  Adam Roben  <aroben@apple.com>
116
117         Remove user content before running each test on Windows
118
119         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
120
121         Reviewed by Alexey Proskuryakov.
122
123         * DumpRenderTree/win/DumpRenderTree.cpp:
124         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
125         before each test, which matches Mac.
126
127 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
128
129         Reviewed by Alexey Proskuryakov.
130
131         Make pywebsocket log errors to a file
132         https://bugs.webkit.org/show_bug.cgi?id=31604
133
134         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
135         (by passing the path to the server via a recently added -l option).
136
137 2009-12-01  Adam Roben  <aroben@apple.com>
138
139         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
140
141         Reviewed by Ada Chan.
142
143         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
144         TestNetscapePlugin fail in Debug_Internal builds
145
146         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
147         directory in Debug and Debug_All builds, but not in Debug_Internal
148         builds.
149
150 2009-12-01  Adam Roben  <aroben@apple.com>
151
152         Re-enable DRT's watchdog timer on Windows
153
154         It was accidentally disabled in r50907.
155
156         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
157         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
158         into an if condition.
159
160 2009-12-01  Adam Barth  <abarth@webkit.org>
161
162         Reviewed by Eric Seidel.
163
164         check-webkit-style complains about #imports with / in them
165         https://bugs.webkit.org/show_bug.cgi?id=32022
166
167         We need to exclude #import directives in addition to #include from the
168         binary operator whitespace checks.
169
170         * Scripts/modules/cpp_style.py:
171         * Scripts/modules/cpp_style_unittest.py:
172
173 2009-11-30  Adam Barth  <abarth@webkit.org>
174
175         Reviewed by Eric Seidel.
176
177         check-webkit-style is slightly too verbose
178         https://bugs.webkit.org/show_bug.cgi?id=32010
179
180         check-webkit-style prints out a bunch of "done" lines that seem redundant,
181         especially for the style-queue.
182
183         * Scripts/modules/cpp_style.py:
184
185 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
186
187         Reviewed by Eric Seidel.
188
189         [GTK] Moved the functions that are closing the result log of the
190         tests to the last line of the runTest function, this avoids
191         reporting crashes in the wrong test if there is a problem when
192         reseting the state after the test.
193
194         * DumpRenderTree/gtk/DumpRenderTree.cpp:
195         (dump):
196         (runTest):
197
198 2009-11-30  Sam Weinig  <sam@webkit.org>
199
200         Reviewed by Geoffrey Garen.
201
202         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
203         fast/js/date-proto-generic-invocation breaks another test
204
205         Don't cache JSClassRefs, a change to the prototype chain will
206         last between tests.
207
208         * DumpRenderTree/AccessibilityController.cpp:
209         (AccessibilityController::getJSClass):
210         * DumpRenderTree/GCController.cpp:
211         (GCController::getJSClass):
212         * DumpRenderTree/GCController.h:
213         * DumpRenderTree/LayoutTestController.cpp:
214         (LayoutTestController::getJSClass):
215
216 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
217
218         Reviewed by Alexey Proskuryakov.
219
220         Update pywebsocket to 0.4.2.1.
221         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
222         https://bugs.webkit.org/show_bug.cgi?id=31976
223
224         * pywebsocket/mod_pywebsocket/standalone.py:
225         * pywebsocket/setup.py:
226
227 2009-11-30  Adam Barth  <abarth@webkit.org>
228
229         Reviewed by Eric Seidel.
230
231         [bzt] Generate pass messages for style-queue
232         https://bugs.webkit.org/show_bug.cgi?id=31995
233
234         With this change, the style-queue posts "pass" messages to bugs as
235         well.  Also, added more information to the state store w.r.t. passing
236         and failing.
237
238         * Scripts/modules/commands/queues.py:
239         * Scripts/modules/patchcollection.py:
240
241 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
242
243         Reviewed by Simon Fraser.
244
245         Check for WEBKIT_TESTFONTS environment variable in
246         run-webkit-tests, for GTK+, to have a more prominent error
247         message.
248
249         * Scripts/run-webkit-tests:
250
251 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
252
253         Reviewed by Dimitri Glazkov.
254
255         update-webkit --chromium forces gclient sync
256
257         https://bugs.webkit.org/show_bug.cgi?id=31967
258
259         * Scripts/update-webkit-chromium:
260
261 2009-11-29  Eric Seidel  <eric@webkit.org>
262
263         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
264
265         * Scripts/modules/committers.py:
266
267 2009-11-29  Eric Seidel  <eric@webkit.org>
268
269         No review, just adding missing svn property.
270
271         Set svn:executable property on new scripts.
272         These were added by commit-queue commits, but the executable
273         property was lost due to a bug in svn-apply:
274         https://bugs.webkit.org/show_bug.cgi?id=27204
275
276         * Scripts/update-webkit-chromium: Added property svn:executable.
277         * Scripts/validate-committer-lists: Added property svn:executable.
278
279 2009-11-29  Eric Seidel  <eric@webkit.org>
280
281         Reviewed by Adam Barth.
282
283         Need a way to validate that committers.py includes all committers/reviewers
284         https://bugs.webkit.org/show_bug.cgi?id=30970
285
286         Add a script which knows how to compare our public committer/reviewer
287         lists and show discrepancies between them.
288
289         Validates mailing lists vs. committers.py:
290         - committers.py committers missing from webkit-committers@lists
291         - webkit-committers@lists members missing from committers.py
292         - committers.py reviewers missing from webkit-reviewers@lists
293         - webkit-reviewers@lists members missing from committers.py
294         - webkit-reviewers@lists members missing from committers.py reviewer list
295
296         Validates committers.py vs. trunk/ SVN history:
297         - committers who have not committed in over a year
298         - SVN committers missing from committers.py
299         - committers.py members who have no record in SVN.
300
301         All of these lists still show "false positives" until a few more committers.py updates are made, like:
302         https://bugs.webkit.org/show_bug.cgi?id=31366
303
304         * Scripts/validate-committer-lists: Added.
305
306 2009-11-28  Adam Barth  <abarth@webkit.org>
307
308         Reviewed by Eric Seidel.
309
310         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
311         https://bugs.webkit.org/show_bug.cgi?id=31950
312
313         Now we cache the last status that we get back from QueueStatusServer.
314         Eventually we'll have to do something more fancy if we want to support
315         a "try again" button on QueueStatusServer, but we can cross that bridge
316         when we come to it.
317
318         * Scripts/modules/patchcollection.py:
319
320 2009-11-28  Adam Barth  <abarth@webkit.org>
321
322         Reviewed by Eric Seidel.
323
324         StyleQueue scans ~100 bug pages every 5 minutes
325         https://bugs.webkit.org/show_bug.cgi?id=31947
326
327         Instead of getting the pending-review attachment ids by scanning each
328         bug (which results in a network request), we should just get them all
329         from webkit.org/pending-review in one shot.
330
331         * Scripts/modules/bugzilla.py:
332         * Scripts/modules/bugzilla_unittest.py:
333         * Scripts/modules/commands/queries.py:
334         * Scripts/modules/commands/queries_unittest.py:
335         * Scripts/modules/commands/queues.py:
336         * Scripts/modules/mock_bugzillatool.py:
337         * Scripts/modules/patchcollection.py:
338
339 2009-11-28  Adam Barth  <abarth@webkit.org>
340
341         Reviewed by Eric Seidel.
342
343         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
344         https://bugs.webkit.org/show_bug.cgi?id=31952
345
346         The mailing list is open for anyone to subscribe.
347
348         * Scripts/modules/bugzilla.py:
349         * Scripts/modules/commands/queues.py:
350
351 2009-11-28  Adam Barth  <abarth@webkit.org>
352
353         Reviewed by Eric Seidel.
354
355         [bzt] style-queue should report style errors to bugzilla
356         https://bugs.webkit.org/show_bug.cgi?id=31945
357
358         Currently, we're just logging the style errors locally.  With this
359         patch we'll actually log the errors to bugzilla.  Note: I plan to run
360         with the "local-only" logging during development.
361
362         * Scripts/modules/commands/queues.py:
363         * Scripts/modules/scm.py:
364
365 2009-11-28  Adam Barth  <abarth@webkit.org>
366
367         Reviewed by Eric Seidel.
368
369         [bzt] style-queue shouldn't reject patches from the commit-queue
370         https://bugs.webkit.org/show_bug.cgi?id=31944
371
372         Currently the style-queue subprocess gets confused and thinks its the
373         commit-queue.  If the patch has an error, it rejects it from the
374         commit-queue.  Instead, we should have style-queue specific logic.
375         This patch doesn't add that logic, but it gives us a callback we can
376         use to add that logic.
377
378         * Scripts/modules/buildsteps.py:
379         * Scripts/modules/commands/queues.py:
380         * Scripts/modules/landingsequence.py:
381
382 2009-11-27  Adam Barth  <abarth@webkit.org>
383
384         Rubber stamped by Eric Seidel.
385
386         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
387
388         * CommitQueueStatus: Removed.
389         * CommitQueueStatus/app.yaml: Removed.
390         * CommitQueueStatus/filters: Removed.
391         * CommitQueueStatus/filters/__init__.py: Removed.
392         * CommitQueueStatus/filters/webkit_extras.py: Removed.
393         * CommitQueueStatus/index.html: Removed.
394         * CommitQueueStatus/index.yaml: Removed.
395         * CommitQueueStatus/queue_status.py: Removed.
396         * CommitQueueStatus/stylesheets: Removed.
397         * CommitQueueStatus/stylesheets/main.css: Removed.
398         * CommitQueueStatus/update_status.html: Removed.
399         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
400
401 2009-11-27  Adam Barth  <abarth@webkit.org>
402
403         Reviewed by Eric Seidel.
404
405         style-queue should only process each patch once
406         https://bugs.webkit.org/show_bug.cgi?id=31939
407
408         Actually address reviewer comments!
409
410         * Scripts/bugzilla-tool:
411
412 2009-11-27  Adam Barth  <abarth@webkit.org>
413
414         Reviewed by Eric Seidel.
415
416         [bzt] style-queue fails to apply a bunch of patches for no reason
417         https://bugs.webkit.org/show_bug.cgi?id=31942
418
419         By passing --non-interactive to check-style, we convince check-style
420         to pass --force to svn-apply, which lets it apply more patches.
421
422         * Scripts/modules/commands/queues.py:
423
424 2009-11-27  Adam Barth  <abarth@webkit.org>
425
426         Reviewed by Eric Seidel.
427
428         [bzt] Support --status-host in style-queue
429         https://bugs.webkit.org/show_bug.cgi?id=31941
430
431         * Scripts/modules/commands/queues.py:
432         * Scripts/modules/statusbot.py:
433
434 2009-11-27  Adam Barth  <abarth@webkit.org>
435
436         Reviewed by Eric Seidel.
437
438         style-queue should only process each patch once
439         https://bugs.webkit.org/show_bug.cgi?id=31939
440
441         Before processing a patch, the try-queues now ask the web service
442         whether they have already processed the patch.  This is an initial cut
443         of this functionality.  I expect we're make it richer over time.
444
445         * Scripts/bugzilla-tool:
446         * Scripts/modules/commands/queues.py:
447         * Scripts/modules/patchcollection.py:
448
449 2009-11-27  Adam Barth  <abarth@webkit.org>
450
451         Reviewed by Eric Seidel.
452
453         PatchStatus does not return status
454         https://bugs.webkit.org/show_bug.cgi?id=31938
455
456         We need to parse attachment_id as an int.  Otherwise, we can't find
457         anything in the datastore.
458
459         * CommitQueueStatus/queue_status.py:
460
461 2009-11-27  Adam Barth  <abarth@webkit.org>
462
463         Reviewed by Eric Seidel.
464
465         Make commit-queue status not throw an exception where there is not
466         status
467         https://bugs.webkit.org/show_bug.cgi?id=31936
468
469         We need to actually fetch the results of the query to see what's in the
470         datastore.
471
472         * CommitQueueStatus/queue_status.py:
473
474 2009-11-27  Adam Barth  <abarth@webkit.org>
475
476         Reviewed by Eric Seidel.
477
478         [bzt] unit test ApplyPatches and ApplyAttachment
479         https://bugs.webkit.org/show_bug.cgi?id=31935
480
481         * Scripts/modules/commands/download.py:
482         * Scripts/modules/commands/download_unittest.py:
483
484 2009-11-27  Adam Barth  <abarth@webkit.org>
485
486         Reviewed by Eric Seidel.
487
488         [bzt] Unit test download commands
489         https://bugs.webkit.org/show_bug.cgi?id=31923
490
491         Adds download_unittest and fixes a bug found while testing.
492
493         * Scripts/modules/commands/commandtest.py:
494         * Scripts/modules/commands/download.py:
495             Fixed a bug where we'd throw an error because [].append returns
496             None.
497         * Scripts/modules/commands/download_unittest.py: Added.
498         * Scripts/modules/mock_bugzillatool.py:
499         * Scripts/run-webkit-unittests:
500
501 2009-11-27  Adam Barth  <abarth@webkit.org>
502
503         Unreviewed "build" fix found while writing unit tests.
504
505         * Scripts/modules/commands/download.py:
506
507 2009-11-27  Adam Barth  <abarth@webkit.org>
508
509         Reviewed by Eric Seidel.
510
511         [bzt] Kill WebKitLandingScripts
512         https://bugs.webkit.org/show_bug.cgi?id=31904
513
514         Step 6: Kill the rest.
515
516         * Scripts/modules/buildsteps.py:
517         * Scripts/modules/commands/download.py:
518         * Scripts/modules/commands/queries.py:
519         * Scripts/modules/commands/upload.py:
520         * Scripts/modules/landingsequence.py:
521         * Scripts/modules/scm.py:
522         * Scripts/modules/webkitlandingscripts.py: Removed.
523
524 2009-11-27  Adam Barth  <abarth@webkit.org>
525
526         Reviewed by Eric Seidel.
527
528         [bzt] Unit test upload commands
529         https://bugs.webkit.org/show_bug.cgi?id=31903
530
531         Adds unit tests for all but two of the upload commands.  The two
532         remaining ones are more difficult.  I'll return to them later.  The
533         goal of these tests is just to run the commands.  We can test more
534         detailed behavior later.
535
536         * Scripts/modules/commands/commandtest.py:
537         * Scripts/modules/commands/upload.py:
538         * Scripts/modules/commands/upload_unittest.py:
539         * Scripts/modules/mock.py: Added.
540         * Scripts/modules/mock_bugzillatool.py:
541
542 2009-11-26  Adam Barth  <abarth@webkit.org>
543
544         Reviewed by Eric Seidel.
545
546         [bzt] Kill WebKitLandingScripts
547         https://bugs.webkit.org/show_bug.cgi?id=31904
548
549         Step 5: Kill run_and_throw_if_fail.
550
551         * Scripts/modules/buildsteps.py:
552         * Scripts/modules/processutils.py: Added.
553         * Scripts/modules/webkitlandingscripts.py:
554
555 2009-11-26  Adam Barth  <abarth@webkit.org>
556
557         Reviewed by Eric Seidel.
558
559         [bzt] Kill WebKitLandingScripts
560         https://bugs.webkit.org/show_bug.cgi?id=31904
561
562         Step 4: Kill run_webkit_script.
563
564         * Scripts/modules/buildsteps.py:
565         * Scripts/modules/commands/download.py:
566         * Scripts/modules/webkitlandingscripts.py:
567
568 2009-11-26  Adam Barth  <abarth@webkit.org>
569
570         Reviewed by Eric Seidel.
571
572         [bzt] Kill WebKitLandingScripts
573         https://bugs.webkit.org/show_bug.cgi?id=31904
574
575         Step 3: Kill build_webkit.
576
577         * Scripts/modules/buildsteps.py:
578         * Scripts/modules/landingsequence.py:
579         * Scripts/modules/webkitlandingscripts.py:
580
581 2009-11-26  Adam Barth  <abarth@webkit.org>
582
583         Reviewed by Eric Seidel.
584
585         [bzt] Kill WebKitLandingScripts
586         https://bugs.webkit.org/show_bug.cgi?id=31904
587
588         Step 2: Kill ensure_builders_are_green.
589
590         * Scripts/modules/buildsteps.py:
591         * Scripts/modules/commands/download.py:
592         * Scripts/modules/landingsequence.py:
593         * Scripts/modules/webkitlandingscripts.py:
594
595 2009-11-26  Adam Barth  <abarth@webkit.org>
596
597         Reviewed by Eric Seidel.
598
599         [bzt] Kill WebKitLandingScripts
600         https://bugs.webkit.org/show_bug.cgi?id=31904
601
602         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
603
604         * Scripts/bugzilla-tool:
605         * Scripts/modules/buildsteps.py: Added.
606         * Scripts/modules/commands/download.py:
607         * Scripts/modules/landingsequence.py:
608         * Scripts/modules/webkitlandingscripts.py:
609
610 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
611
612         Reviewed by Adam Barth.
613
614         Remove directory prefixes from linux commands
615
616         SCM unittests can cause errors on some systems if we use absolute reference to
617         the commands, so directory prefixes have been removed.
618
619         * Scripts/modules/scm_unittest.py:
620
621 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
622
623         Reviewed by Kenneth Rohde Christiansen.
624
625         Link DumpRenderTree to the Qt Ui Tools
626         https://bugs.webkit.org/show_bug.cgi?id=31203
627
628         Implement QWebPage::createPlugin using the Qt Ui Tools
629         to be able to create classes like QProgressBar from within
630         the <object></object> tags This is required for the
631         new automatic test of Qt Plugins.
632
633         * DumpRenderTree/qt/DumpRenderTree.cpp:
634         (WebCore::WebPage::createPlugin):
635         * DumpRenderTree/qt/DumpRenderTree.h:
636         * DumpRenderTree/qt/DumpRenderTree.pro:
637
638 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
639
640         Reviewed by Eric Seidel.
641
642         Update pywebsocket to 0.4.2
643
644         Update pywebsocket to 0.4.2
645         https://bugs.webkit.org/show_bug.cgi?id=31861
646
647         * pywebsocket/example/echo_client.py:
648         * pywebsocket/example/echo_wsh.py:
649         * pywebsocket/mod_pywebsocket/__init__.py:
650         * pywebsocket/mod_pywebsocket/dispatch.py:
651         * pywebsocket/mod_pywebsocket/msgutil.py:
652         * pywebsocket/mod_pywebsocket/standalone.py:
653         * pywebsocket/setup.py:
654         * pywebsocket/test/test_dispatch.py:
655         * pywebsocket/test/test_msgutil.py:
656
657 2009-11-25  Adam Barth  <abarth@webkit.org>
658
659         Reviewed by Eric Seidel.
660
661         Add unit test for mark-fixed
662         https://bugs.webkit.org/show_bug.cgi?id=31896
663
664         * Scripts/modules/commands/commandtest.py: Added.
665         * Scripts/modules/commands/queries_unittest.py:
666         * Scripts/modules/commands/upload_unittest.py: Added.
667         * Scripts/modules/mock_bugzillatool.py:
668         * Scripts/run-webkit-unittests:
669
670 2009-11-25  Adam Barth  <abarth@webkit.org>
671
672         Reviewed by Eric Seidel.
673
674         bugzilla-tool should have a mark-fixed command
675         https://bugs.webkit.org/show_bug.cgi?id=31853
676
677         Pretty simple stuff.
678
679         * Scripts/modules/commands/upload.py:
680
681 2009-11-25  Eric Seidel  <eric@webkit.org>
682
683         Reviewed by Adam Barth.
684
685         'bugzilla-tool help' should only show common commands like how 'git help' does
686         https://bugs.webkit.org/show_bug.cgi?id=31772
687
688         I also took this opportunity to make 'help' a real Command.
689         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
690
691         * Scripts/bugzilla-tool:
692          - change should_show_command_help to should_show_in_main_help
693         * Scripts/modules/commands/download.py:
694          - Mark commands as being shown in main help or not.
695          - show_in_main_help = False is not required (default is false),
696            but it seemed to make the commands more self-documenting.
697         * Scripts/modules/commands/queries.py: ditto
698         * Scripts/modules/commands/queues.py: ditto
699         * Scripts/modules/commands/upload.py: ditto
700         * Scripts/modules/multicommandtool.py:
701          - Make Command hold a pointer to tool in self.tool.  Most Command
702            subclasses do not take advantage of this yet, but it was required
703            for HelpCommand to be able to reach the tool from _help_epilog().
704          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
705          - Move MultiCommandTool._help_epilog to Command._help_epilog
706          - Move "help" logic into HelpCommand.execute()
707          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
708         * Scripts/modules/multicommandtool_unittest.py:
709          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
710
711 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
712
713         Reviewed by Dan Bernstein.
714         
715         Patch by Mark Rowe.
716
717         The buildbots are failing on Windows because when they were upgraded
718         to 4.0.4, Apple Application Support was not in their path. Add it to
719         the path to fix the buildots.
720
721         * Scripts/webkitdirs.pm:
722
723 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
724
725         Reviewed by David Kilzer.
726
727         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
728         https://bugs.webkit.org/show_bug.cgi?id=31799
729
730         * Scripts/run-webkit-tests: Fixed.
731
732 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
733
734         Reviewed by Eric Seidel.
735
736         Change run_command to give back stderr by default
737         https://bugs.webkit.org/show_bug.cgi?id=31734
738
739         Change run_command to give back stderr by default.
740         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
741         Change the related unittest call.
742
743         * Scripts/modules/scm.py:
744         * Scripts/modules/scm_unittest.py:
745
746 2009-11-25  Eric Seidel  <eric@webkit.org>
747
748         Reviewed by Adam Barth.
749
750         Centralize required argument parsing in Command
751         https://bugs.webkit.org/show_bug.cgi?id=31872
752
753         * Scripts/modules/commands/download.py: remove custom required arg message.
754         * Scripts/modules/commands/upload.py: ditto.
755         * Scripts/modules/multicommandtool.py:
756          - Add _parse_required_arguments.
757          - Pass program name off to OptionParser.
758          - Add name() for access to tool name.
759          - Add check_arguments_and_execute and make it return a return code.
760          - Replace a couple uses of + with %.
761         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
762
763 2009-11-25  Eric Seidel  <eric@webkit.org>
764
765         Reviewed by Adam Barth.
766
767         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
768         https://bugs.webkit.org/show_bug.cgi?id=31870
769
770         * Scripts/modules/commands/queries_unittest.py: Use the new class.
771         * Scripts/modules/multicommandtool_unittest.py: Ditto.
772         * Scripts/modules/outputcapture.py: Added.
773
774 2009-11-24  Dmitry Titov  <dimich@chromium.org>
775
776         Reviewed by Eric Seidel.
777
778         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
779         https://bugs.webkit.org/show_bug.cgi?id=31444
780
781         * Scripts/build-webkit:
782
783 2009-11-24  Chris Marrin  <cmarrin@apple.com>
784
785         Reviewed by Simon Fraser.
786
787         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
788         https://bugs.webkit.org/show_bug.cgi?id=27314
789         
790         Now the script allows the directories with these tests to be included on all
791         platforms but Mac, where they behave the same as always. For all other platforms
792         the tests need to be excluded using the Skipped files, which is currently done
793         for all platforms (including win since we're not turned on yet)
794
795         * Scripts/webkitdirs.pm:
796
797 2009-11-24  Eric Seidel  <eric@webkit.org>
798
799         Reviewed by Adam Barth.
800
801         queries_unittest.py should test command output
802         https://bugs.webkit.org/show_bug.cgi?id=31845
803
804         * Scripts/modules/commands/queries_unittest.py:
805          - Capture stdout and stderr and compare with expected strings.
806
807 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
808
809         No Review.
810
811         Fix spelling error ("depenedencies").
812
813         * Scripts/build-webkit:
814
815 2009-11-24  Mark Rowe  <mrowe@apple.com>
816
817         Land the configuration that includes the two debug GTK Linux builders.
818
819         * BuildSlaveSupport/build.webkit.org-config/config.json:
820
821 2009-11-24  David Kilzer  <ddkilzer@apple.com>
822
823         <http://webkit.org/b/31840> bisect-builds broke after r50080
824
825         Reviewed by Dan Bernstein.
826
827         * Scripts/bisect-builds:
828         (mountAndRunNightly): Switched back to using backticks to run
829         the hdiutil command since exec() will terminate the existing
830         script, which is not what we want.  Store the output of
831         File::Spec->devnull() in a variable for use in the hdiutil
832         detach commands.
833
834 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
835
836         Reviewed by Kenneth Rohde Christiansen.
837
838         Include "config.h" to meet Coding Style Guidelines
839         https://bugs.webkit.org/show_bug.cgi?id=31792
840
841         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
842         * DumpRenderTree/qt/jsobjects.cpp:
843         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
844
845 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
846
847         Reviewed by Oliver Hunt.
848
849         Implement new required function to pass test we used to pass. This
850         change is required since r51294.
851
852         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
853         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
854
855 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
856
857         Reviewed by Kenneth Rohde Christiansen.
858
859         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
860         https://bugs.webkit.org/show_bug.cgi?id=31775
861
862         LayoutTestController::dumpBackForwardList() should work with local URLs
863         as well as with normal URLs (in http tests for instance).
864         Currently it does not output the latter properly.
865
866         Unskip a bunch of passing http/navigation tests.
867
868         * DumpRenderTree/qt/DumpRenderTree.cpp:
869         (WebCore::dumpHistoryItem):
870
871 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
872
873         Reviewed by Oliver Hunt.
874
875         ARIA: support aria-flowto
876         https://bugs.webkit.org/show_bug.cgi?id=31762
877
878         * DumpRenderTree/AccessibilityUIElement.cpp:
879         (ariaFlowToElementAtIndexCallback):
880         (AccessibilityUIElement::getJSClass):
881         * DumpRenderTree/AccessibilityUIElement.h:
882         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
883         (AccessibilityUIElement::ariaFlowToElementAtIndex):
884         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
885         (AccessibilityUIElement::ariaFlowToElementAtIndex):
886         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
887         (AccessibilityUIElement::ariaFlowToElementAtIndex):
888
889 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
890
891         Reviewed by Kenneth Christiansen.
892
893         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
894         https://bugs.webkit.org/show_bug.cgi?id=31638
895
896         Unfreeze WorkQueue after each test execution.
897
898         * DumpRenderTree/qt/DumpRenderTree.cpp:
899         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
900
901 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
902
903         Reviewed by Adam Barth.
904
905         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
906         for localhost and 127.0.0.1.
907         https://bugs.webkit.org/show_bug.cgi?id=31783
908
909         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
910
911         * DumpRenderTree/qt/DumpRenderTree.cpp:
912         (WebCore::NetworkAccessManager::NetworkAccessManager):
913         (WebCore::NetworkAccessManager::sslErrorsEncountered):
914         (WebCore::WebPage::WebPage):
915         * DumpRenderTree/qt/DumpRenderTree.h:
916
917 2009-11-22  Chris Evans  <cevans@chromium.org>
918
919         Reviewed by Adam Barth.
920
921         Disable access to file:/// directory listings
922         https://bugs.webkit.org/show_bug.cgi?id=31329
923
924         Implemented setAllowUniversalAccessFromFileURLs to support testing of
925         file URL security.
926
927         * DumpRenderTree/LayoutTestController.cpp:
928         (setAllowUniversalAccessFromFileURLsCallback):
929         (LayoutTestController::staticFunctions):
930         * DumpRenderTree/LayoutTestController.h:
931         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
932         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
933         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
934         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
935         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
936         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
937         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
938         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
939
940 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
941
942         Reviewed by Kenneth Rohde Christiansen.
943
944         [Qt] Fix the timeout of fast/frames/frame-navigation.html
945         https://bugs.webkit.org/show_bug.cgi?id=31638
946
947         The test is timeouting, because it uses the WorkQueue to load a document in one
948         of the child frames and once the loading is finished, the DRT does not dump the
949         tree. This is because it waits for the QWebFrame::loadFinished() signal from
950         the main frame, while it should connect to QWebPage::loadFinished().
951
952         * DumpRenderTree/qt/DumpRenderTree.cpp:
953         (WebCore::DumpRenderTree::DumpRenderTree):
954
955 2009-11-21  Eric Seidel  <eric@webkit.org>
956
957         Reviewed by Adam Barth.
958
959         bugzilla-tool --help spews way too much text
960         https://bugs.webkit.org/show_bug.cgi?id=31771
961
962         * Scripts/bugzilla-tool:
963          - Remove self.cached_scm initialization hack.
964         * Scripts/modules/buildbot.py:
965          - Make default_host accessible to callers.
966         * Scripts/modules/commands/download.py:
967          - Phrase help for all commands consistently and remove spurious help text punctuation.
968         * Scripts/modules/commands/queries.py: Ditto.
969         * Scripts/modules/commands/queues.py: Ditto.
970         * Scripts/modules/commands/upload.py: Ditto.
971         * Scripts/modules/multicommandtool.py:
972          - Add HelpPrintingOptionParser.format_epilog to replace
973            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
974            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
975          - Make --help only show a list of commands like "svn help" and "git help" do --
976            previously --help was listing all commands and options.
977          - Sort list of commands alphabetically.
978
979 2009-11-21  Eric Seidel  <eric@webkit.org>
980
981         No review.  Fixing a typo from the previous patch for bug 31767.
982
983         AbstractQueue.run_bugzilla_tool throws an exception
984         https://bugs.webkit.org/show_bug.cgi?id=31769
985
986         * Scripts/modules/commands/queues.py:
987
988 2009-11-21  Eric Seidel  <eric@webkit.org>
989
990         Reviewed by Adam Barth.
991
992         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
993         https://bugs.webkit.org/show_bug.cgi?id=31767
994
995         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
996         Since we don't have a good way to test BugzillaTool pieces, I've
997         left out a test for now.
998
999         * Scripts/bugzilla-tool:
1000          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1001         * Scripts/modules/commands/queues.py:
1002          - Use tool.path() instead of __file__.
1003         * Scripts/modules/multicommandtool.py:
1004          - Add a new path() method to MultiComandTool.
1005         * Scripts/modules/multicommandtool_unittest.py:
1006          - Provide a path() method.  Little point in testing this mock implementation.
1007
1008 2009-11-21  Adam Barth  <abarth@webkit.org>
1009
1010         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
1011         WebKitTools.
1012
1013         * Scripts/modules/commands/download.py:
1014
1015 2009-11-21  Adam Barth  <abarth@webkit.org>
1016
1017         Reviewed by Eric Seidel.
1018
1019         Convert check-style to use LandingSequence
1020         https://bugs.webkit.org/show_bug.cgi?id=31763
1021
1022         Instead of manipulating the working copy by hand, we should use the
1023         LandingSequence in CheckStyle.  This will make this code eaiser to
1024         test.
1025
1026         * Scripts/modules/commands/download.py:
1027
1028 2009-11-20  Adam Barth  <abarth@webkit.org>
1029
1030         Reviewed by Eric Seidel.
1031
1032         Unit test query commands
1033         https://bugs.webkit.org/show_bug.cgi?id=31755
1034
1035         These tests are pretty rough, but hopefully they'll grow.
1036
1037         * Scripts/modules/commands/queries_unittest.py: Added.
1038         * Scripts/modules/mock_bugzillatool.py: Added.
1039         * Scripts/run-webkit-unittests:
1040
1041 2009-11-20  Eric Seidel  <eric@webkit.org>
1042
1043         Reviewed by Adam Barth.
1044
1045         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
1046         https://bugs.webkit.org/show_bug.cgi?id=31758
1047
1048         * Scripts/modules/multicommandtool.py:
1049          - Allow passing of explicit commands to MultiCommandTool.__init__
1050         * Scripts/modules/multicommandtool_unittest.py:
1051          - Use new Command.name naming system.
1052          - Test Command auto-discovery.
1053         * Scripts/modules/workqueue.py:
1054          - bug_id no longer exists, use patch['bug_id'] instead.
1055         * Scripts/modules/workqueue_unittest.py:
1056          - WorkQueues require names now.
1057          - should_proceed_with_work_item must return a patch object.
1058
1059 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1060
1061         Reviewed by Beth Dakin.
1062
1063         WAI-ARIA: add support for aria-owns
1064         https://bugs.webkit.org/show_bug.cgi?id=31702
1065
1066         * DumpRenderTree/AccessibilityUIElement.cpp:
1067         (ariaOwnsElementAtIndexCallback):
1068         (AccessibilityUIElement::getJSClass):
1069         * DumpRenderTree/AccessibilityUIElement.h:
1070         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1071         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1072         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1073         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1074         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1075         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1076
1077 2009-11-20  Eric Seidel  <eric@webkit.org>
1078
1079         Reviewed by Adam Barth.
1080
1081         Fix exception thrown when running the commit-queue.
1082
1083         * Scripts/modules/statusbot.py: patch is optional.
1084         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
1085
1086 2009-11-20  Eric Seidel  <eric@webkit.org>
1087
1088         Reviewed by Adam Barth.
1089
1090         Teach the StatusBot how to support more than just the commit-queue
1091         https://bugs.webkit.org/show_bug.cgi?id=31754
1092
1093         * Scripts/modules/workqueue.py: Another typo.
1094
1095 2009-11-20  Eric Seidel  <eric@webkit.org>
1096
1097         Reviewed by Adam Barth.
1098
1099         Teach the StatusBot how to support more than just the commit-queue
1100         https://bugs.webkit.org/show_bug.cgi?id=31754
1101
1102         * Scripts/modules/commands/queues.py: Fix silly typo.
1103
1104 2009-11-20  Eric Seidel  <eric@webkit.org>
1105
1106         Reviewed by Adam Barth.
1107
1108         Teach the StatusBot how to support more than just the commit-queue
1109         https://bugs.webkit.org/show_bug.cgi?id=31754
1110
1111         * CommitQueueStatus/index.yaml:
1112          - Add indices required for the new queries.
1113         * CommitQueueStatus/queue_status.py:
1114          - Add a patch-status page and move update_status to update-status.
1115          - Only display "commit-queue" status records for the commit-queue.
1116          - Add support for a queue_name property on status records.
1117          - Fix _int_from_request to actually work.
1118         * CommitQueueStatus/update_status.html:
1119          - Add support for a queue_name on status records.
1120          - Remove unused list of bug ids.
1121          * Scripts/modules/commands/queues.py
1122           - Make the queues pass the patch instead of the bug_id to StatusBot.
1123         * Scripts/modules/statusbot.py:
1124          - Support passing the queue_name to the status updates.
1125          - Support fetching patch status with patch_status().
1126         * Scripts/modules/workqueue.py:
1127          - Pass the patch to the StatusBot instead of the bug_id.
1128          - Let WorkQueues have a name.
1129
1130 2009-11-20  Adam Barth  <abarth@webkit.org>
1131
1132         Reviewed by Eric Seidel.
1133
1134         Move bugzilla-tool commands into their own file
1135         https://bugs.webkit.org/show_bug.cgi?id=31752
1136
1137         This will let us write unit tests.
1138
1139         * Scripts/bugzilla-tool:
1140         * Scripts/modules/commands/__init__.py: Added.
1141         * Scripts/modules/commands/download.py: Added.
1142         * Scripts/modules/commands/queries.py: Added.
1143         * Scripts/modules/commands/queues.py: Added.
1144         * Scripts/modules/commands/upload.py: Added.
1145         * Scripts/modules/grammar.py: Added.
1146
1147 2009-11-20  Adam Barth  <abarth@webkit.org>
1148
1149         Reviewed by Eric Seidel.
1150
1151         BuildQueue should check if the tree is currently buildable
1152         https://bugs.webkit.org/show_bug.cgi?id=31744
1153
1154         * Scripts/bugzilla-tool:
1155         * Scripts/modules/landingsequence.py:
1156         * Scripts/modules/webkitlandingscripts.py:
1157
1158 2009-11-20  Adam Barth  <abarth@webkit.org>
1159
1160         Reviewed by Eric Seidel.
1161
1162         Move prepare_clean_working_directory into the LandingSequence
1163         https://bugs.webkit.org/show_bug.cgi?id=31743
1164
1165         * Scripts/bugzilla-tool:
1166         * Scripts/modules/landingsequence.py:
1167
1168 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1169
1170         Reviewed by Kenneth Rohde Christiansen.
1171
1172         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1173         https://bugs.webkit.org/show_bug.cgi?id=30460
1174
1175         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1176
1177         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1178         (pluginInvoke):
1179
1180 2009-11-20  Adam Barth  <abarth@webkit.org>
1181
1182         Reviewed by Eric Seidel.
1183
1184         Pass the port information to the child process
1185         https://bugs.webkit.org/show_bug.cgi?id=31736
1186
1187         We need to do this so the child process knows what to build!
1188
1189         * Scripts/bugzilla-tool:
1190         * Scripts/modules/landingsequence.py:
1191         * Scripts/modules/webkitport.py:
1192         * Scripts/modules/webkitport_unittest.py:
1193
1194 2009-11-20  Adam Barth  <abarth@webkit.org>
1195
1196         Reviewed by Eric Seidel.
1197
1198         Support Qt port in build-queue
1199         https://bugs.webkit.org/show_bug.cgi?id=31733
1200
1201         * Scripts/bugzilla-tool:
1202
1203 2009-11-20  Adam Barth  <abarth@webkit.org>
1204
1205         Reviewed by Eric Seidel.
1206
1207         Implement a build-queue
1208         https://bugs.webkit.org/show_bug.cgi?id=31725
1209
1210         Currently this just builds the first 10 patches in the review queue.
1211         We'll want to do something smarter soon.
1212
1213         * Scripts/bugzilla-tool:
1214
1215 2009-11-20  Adam Barth  <abarth@webkit.org>
1216
1217         Reviewed by Eric Seidel.
1218
1219         Make commit-queue and style-queue show up in help
1220         https://bugs.webkit.org/show_bug.cgi?id=31724
1221
1222         We need to store their names on their class to make these commands
1223         properly register themselves with MultiCommandTool.
1224
1225         * Scripts/bugzilla-tool:
1226
1227 2009-11-20  Adam Barth  <abarth@webkit.org>
1228
1229         Reviewed by Eric Seidel.
1230
1231         Implement bugzilla-tool build-attachment
1232         https://bugs.webkit.org/show_bug.cgi?id=31722
1233
1234         This command builds an attachment from bugzilla.  It leaves the built
1235         patch in the working copy.
1236
1237         * Scripts/bugzilla-tool:
1238         * Scripts/modules/landingsequence.py:
1239         * Scripts/modules/webkitlandingscripts.py:
1240
1241 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1242
1243         Reviewed by Xan Lopez.
1244
1245         [GTK] DRT release event does not create the state correctly
1246         https://bugs.webkit.org/show_bug.cgi?id=31717
1247
1248         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1249
1250 2009-11-20  Eric Seidel  <eric@webkit.org>
1251
1252         Reviewed by Adam Barth.
1253
1254         MultiCommandTool should find Command objects automatically instead of with a manual list
1255         https://bugs.webkit.org/show_bug.cgi?id=31710
1256
1257         * Scripts/bugzilla-tool:
1258         * Scripts/modules/multicommandtool.py:
1259          - Use some wild python-fu to crawl all the known subclasses of Command.
1260
1261 2009-11-20  Adam Barth  <abarth@webkit.org>
1262
1263         Unreviewed "build" fix.  Added missing import.
1264
1265         * Scripts/bugzilla-tool:
1266
1267 2009-11-20  Adam Barth  <abarth@webkit.org>
1268
1269         Unreviewed "build" fix.  I failed to update LandingSequence.test
1270         properly.
1271
1272         * Scripts/modules/landingsequence.py:
1273
1274 2009-11-20  Adam Barth  <abarth@webkit.org>
1275
1276         Reviewed by Eric Seidel.
1277
1278         Create LandingSequence as the all-sing, all-dance landing class
1279         https://bugs.webkit.org/show_bug.cgi?id=31709
1280
1281         Client can inherit from this class to carefully control exactly which
1282         steps they wish to have happen in the landing sequence.
1283
1284         * Scripts/bugzilla-tool:
1285         * Scripts/modules/landingsequence.py: Added.
1286         * Scripts/modules/webkitlandingscripts.py: Added.
1287
1288 2009-11-19  Adam Barth  <abarth@webkit.org>
1289
1290         Reviewed by Eric Seidel.
1291
1292         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1293         https://bugs.webkit.org/show_bug.cgi?id=31707
1294
1295         This is to help when we implement build-attachment.
1296
1297         * Scripts/bugzilla-tool:
1298
1299 2009-11-19  Adam Barth  <abarth@webkit.org>
1300
1301         Reviewed by Eric Seidel.
1302
1303         Support Qt port in bugzilla-tool
1304         https://bugs.webkit.org/show_bug.cgi?id=31701
1305
1306         Now we support building with Qt!
1307
1308         * Scripts/bugzilla-tool:
1309         * Scripts/modules/webkitport.py: Added.
1310         * Scripts/modules/webkitport_unittest.py: Added.
1311         * Scripts/run-webkit-unittests:
1312
1313 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1314
1315         Reviewed by Adam Barth.
1316
1317         Remove inserting stderr into patch in bugzilla-tool
1318         https://bugs.webkit.org/show_bug.cgi?id=29914
1319
1320         Modify SCM python module's run_command function to avoid return of stderr
1321         by default, so stderr won't be inserted into the patches.
1322         Modify the related unit test.
1323
1324         * Scripts/modules/scm.py:
1325         * Scripts/modules/scm_unittest.py:
1326
1327 2009-11-19  Eric Seidel  <eric@webkit.org>
1328
1329         Reviewed by Adam Barth.
1330
1331         bugzilla-tool needs per-command help
1332         https://bugs.webkit.org/show_bug.cgi?id=31697
1333
1334         Added support for "bugzilla-tool help command-name"
1335         and a unit test to make sure it works.
1336
1337         * Scripts/modules/multicommandtool.py:
1338         * Scripts/modules/multicommandtool_unittest.py:
1339
1340 2009-11-19  Eric Seidel  <eric@webkit.org>
1341
1342         Reviewed by Adam Barth.
1343
1344         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1345         https://bugs.webkit.org/show_bug.cgi?id=31695
1346
1347         * Scripts/bugzilla-tool:
1348         * Scripts/modules/multicommandtool.py: Added.
1349         * Scripts/modules/multicommandtool_unittest.py: Added.
1350         * Scripts/run-webkit-unittests:
1351
1352 2009-11-19  Eric Seidel  <eric@webkit.org>
1353
1354         No review, just adding a FIXME.
1355
1356         Split out command parsing and help printing from BugzillaTool
1357         https://bugs.webkit.org/show_bug.cgi?id=31688
1358
1359         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1360
1361 2009-11-19  Eric Seidel  <eric@webkit.org>
1362
1363         Reviewed by Adam Barth.
1364
1365         Split out command parsing and help printing from BugzillaTool
1366         https://bugs.webkit.org/show_bug.cgi?id=31688
1367
1368         * Scripts/bugzilla-tool:
1369          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1370          - Rename private methods to use _ pattern.
1371          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1372          - 
1373
1374 2009-11-19  Eric Seidel  <eric@webkit.org>
1375
1376         Reviewed by Adam Barth.
1377
1378         Re-factor help printing to use modern python idioms
1379         https://bugs.webkit.org/show_bug.cgi?id=31685
1380
1381         * Scripts/bugzilla-tool:
1382
1383 2009-11-19  Eric Seidel  <eric@webkit.org>
1384
1385         Reviewed by Darin Adler.
1386
1387         commit-queue empty queue logs twice
1388         https://bugs.webkit.org/show_bug.cgi?id=31679
1389
1390         * Scripts/bugzilla-tool:
1391
1392 2009-11-19  Eric Seidel  <eric@webkit.org>
1393
1394         Reviewed by Darin Adler.
1395
1396         bugzilla-tool's reviewer/committer rejection message should be clearer
1397         https://bugs.webkit.org/show_bug.cgi?id=31126
1398
1399         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1400
1401         * Scripts/modules/bugzilla.py:
1402
1403 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1404
1405         Reviewed by Pavel Feldman.
1406
1407         Forces a WM_PAINT event on calling layoutTestController.display()
1408         in order to enable the timeline-paint.html test on Windows.
1409         ::UpdateWindow() does not force an event becaue the window is 
1410         not visible.
1411
1412         https://bugs.webkit.org/show_bug.cgi?id=31402
1413
1414         * DumpRenderTree/win/DumpRenderTree.cpp:
1415         (displayWebView):
1416
1417 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1418
1419         No review needed.
1420
1421         Added myself to committers list.
1422
1423         * Scripts/modules/committers.py:
1424
1425 2009-11-19  Adam Barth  <abarth@webkit.org>
1426
1427         Reviewed by Eric Seidel.
1428
1429         Bugzilla-tool command classes should match command names
1430         https://bugs.webkit.org/show_bug.cgi?id=31666
1431
1432         I renamed all the commands except CommitMessageForCurrentDiff because
1433         the new name would conflict with an existing class.
1434
1435         * Scripts/bugzilla-tool:
1436
1437 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1438
1439         Reviewed by Gustavo Noronha Silva.
1440
1441         Web Inspector: Implement "show inspector" in WebKit GTK
1442         API and enable console tests.
1443
1444         https://bugs.webkit.org/show_bug.cgi?id=31669
1445
1446         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1447         (LayoutTestController::showWebInspector):
1448
1449 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1450
1451         Reviewed by Simon Hausmann.
1452
1453         Minor refactoring + more documentation.
1454
1455         * DumpRenderTree/qt/DumpRenderTree.cpp:
1456         (WebCore::clearHistory):
1457         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1458
1459 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1460
1461         Reviewed by Eric Seidel.
1462
1463         Ignore websocket tests when --no-http is specified.
1464         https://bugs.webkit.org/show_bug.cgi?id=31662
1465
1466         * Scripts/run-webkit-tests:
1467
1468 2009-11-18  Adam Barth  <abarth@webkit.org>
1469
1470         Reviewed by Eric Seidel.
1471
1472         Normalize ' and " in bugzilla-tool
1473         https://bugs.webkit.org/show_bug.cgi?id=31655
1474
1475         We decided " is better than ' and we should be consistent.
1476
1477         * Scripts/bugzilla-tool:
1478
1479 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1480
1481         Reviewed by Kenneth Rohde Christiansen.
1482
1483         [Qt] Remove support for Qt v4.3 or older versions
1484         https://bugs.webkit.org/show_bug.cgi?id=29469
1485
1486         * DumpRenderTree/qt/DumpRenderTree.pro:
1487         * DumpRenderTree/qt/ImageDiff.pro:
1488
1489 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1490
1491         Reviewed by Eric Seidel.
1492
1493         GitTest.test_create_binary_patch fails if /tmp is symlink
1494         https://bugs.webkit.org/show_bug.cgi?id=31536
1495
1496         * Scripts/modules/scm_unittest.py:
1497
1498 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1499
1500         Reviewed by Darin Adler.
1501
1502         Configuration for Chromium Build Slaves.
1503
1504         https://bugs.webkit.org/show_bug.cgi?id=31442
1505
1506         * BuildSlaveSupport/build.webkit.org-config/config.json:
1507         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1508
1509 2009-11-18  Eric Seidel  <eric@webkit.org>
1510
1511         Reviewed by Darin Adler.
1512
1513         workqueue.py results in totally broken commit-queue UI
1514         https://bugs.webkit.org/show_bug.cgi?id=31645
1515
1516         * Scripts/bugzilla-tool:
1517          - Remove unneeded use of PatchCollection.
1518          - Grab a new copy of the cq'd patches every run of the queue.
1519
1520 2009-11-18  Sam Weinig  <sam@webkit.org>
1521
1522         Reviewed by Anders Carlsson.
1523
1524         Make the Mac Geolocation API async.
1525
1526         Update DRT to use the new async Mac Geolocation API.
1527
1528         * DumpRenderTree/mac/UIDelegate.mm:
1529         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1530
1531 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1532
1533         Reviewed by Kenneth Rohde Christiansen.
1534
1535         Add and option to toggle HTML5 datalist support to build-webkit
1536         https://bugs.webkit.org/show_bug.cgi?id=31599
1537
1538         * Scripts/build-webkit:
1539
1540 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1541
1542         Reviewed by Kevin Ollivier.
1543
1544         Enable wx plugin support using the Windows implementation as a base.
1545         
1546         https://bugs.webkit.org/show_bug.cgi?id=31636
1547
1548         * wx/build/settings.py:
1549
1550 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1551
1552         Reviewed by Simon Hausmann.
1553
1554         Change the initialization order so that the controllers
1555         will be created before exporting them to the JS DOM window.
1556
1557         * DumpRenderTree/qt/DumpRenderTree.cpp:
1558         (WebCore::DumpRenderTree::DumpRenderTree):
1559
1560 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1561
1562         Reviewed by Simon Hausmann.
1563
1564         Fix a code copy and paste error. m_page should be page.
1565
1566         * DumpRenderTree/qt/DumpRenderTree.cpp:
1567         (WebCore::DumpRenderTree::createWindow):
1568
1569 2009-11-17  Mark Rowe  <mrowe@apple.com>
1570
1571         Reviewed by Alexey Proskuryakov.
1572
1573         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1574
1575         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1576         This prevents symlinks from confusing the descendant check.
1577
1578 2009-11-17  Mark Rowe  <mrowe@apple.com>
1579
1580         Reviewed by Alexey Proskuryakov.
1581
1582         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1583
1584         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1585         server to be up rather than having run-webkit-tests abort immediately.
1586
1587         * Scripts/run-webkit-tests:
1588
1589 2009-11-17  Eric Seidel  <eric@webkit.org>
1590
1591         Reviewed by Darin Adler.
1592
1593         commit-queue is failing to set reviewer in ChangeLogs
1594         https://bugs.webkit.org/show_bug.cgi?id=31592
1595
1596         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1597         * Scripts/modules/bugzilla.py:
1598          - Add a new _validate_committer_and_reviewer function as a
1599            temporary solution until we can make a real Attachment object
1600            which knows how to fill in its committer/reviewer fields automatically.
1601
1602 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1603
1604         Unreviewed buildbot fix.
1605
1606         Revert part of earlier patch and add comment, as it
1607         was causing timeouts on the buildbot.
1608
1609         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1610         (LayoutTestController::notifyDone):
1611
1612 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1613
1614         Reviewed by Oliver Hunt.
1615
1616         Make the timeout 15 sec as for the other DRT's and make
1617         it print out the same output when a test timeout.
1618
1619         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1620         (LayoutTestController::waitUntilDone):
1621         (LayoutTestController::notifyDone):
1622         (LayoutTestController::timerEvent):
1623
1624 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1625
1626         Reviewed by Timothy Hatcher.
1627
1628         Fixed typos in comments.
1629
1630         * Scripts/modules/committers.py:
1631
1632 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1633
1634         Reviewed by Timothy Hatcher.
1635
1636         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1637         - Updated DRT to show/close inspector for all tests under /inspector
1638         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1639           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1640         - Removed reload on each inspector test
1641         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1642         inspector for those.
1643         - Reimplemented timeline tests in order to get rid of reload there.
1644         - Moved tests that don't require harness into the fast group.
1645
1646         https://bugs.webkit.org/show_bug.cgi?id=31472
1647
1648         * DumpRenderTree/LayoutTestController.cpp:
1649         (setTimelineProfilingEnabledCallback):
1650         (closeWebInspectorCallback):
1651         (LayoutTestController::staticFunctions):
1652         * DumpRenderTree/LayoutTestController.h:
1653         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1654         (shouldOpenWebInspector):
1655         (runTest):
1656         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1657         (LayoutTestController::setTimelineProfilingEnabled):
1658         * DumpRenderTree/mac/DumpRenderTree.mm:
1659         (shouldOpenWebInspector):
1660         (runTest):
1661         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1662         (LayoutTestController::setTimelineProfilingEnabled):
1663         * DumpRenderTree/win/DumpRenderTree.cpp:
1664         (shouldOpenWebInspector):
1665         (runTest):
1666         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1667         (LayoutTestController::setTimelineProfilingEnabled):
1668
1669 2009-11-17  Oliver Hunt  <oliver@apple.com>
1670
1671         Reviewed by Maciej Stachowiak.
1672
1673         Incorrect use of JavaScriptCore API in DumpRenderTree
1674         https://bugs.webkit.org/show_bug.cgi?id=31577
1675
1676         Return undefined rather than a literal null.
1677
1678         * DumpRenderTree/AccessibilityUIElement.cpp:
1679         (setSelectedTextRangeCallback):
1680         (incrementCallback):
1681         (decrementCallback):
1682         (showMenuCallback):
1683
1684 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1685
1686         Reviewed by Beth Dakin.
1687
1688         AX: aria-labelledby duplicates some of its WAI-ARIA label
1689         https://bugs.webkit.org/show_bug.cgi?id=31565
1690
1691         * DumpRenderTree/AccessibilityUIElement.cpp:
1692         (titleUIElementCallback):
1693         (getIsValidCallback):
1694         (AccessibilityUIElement::getJSClass):
1695
1696 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1697
1698         Reviewed by Simon Hausmann.
1699
1700         r50942 broke output from created windows. Make the
1701         m_enableTextOutput a member of the DRT and not the
1702         WebPage.
1703
1704         * DumpRenderTree/qt/DumpRenderTree.cpp:
1705         (WebCore::WebPage::WebPage):
1706         (WebCore::WebPage::javaScriptAlert):
1707         (WebCore::WebPage::javaScriptConsoleMessage):
1708         (WebCore::WebPage::javaScriptConfirm):
1709         (WebCore::WebPage::javaScriptPrompt):
1710         (WebCore::WebPage::acceptNavigationRequest):
1711         (WebCore::DumpRenderTree::DumpRenderTree):
1712         (WebCore::DumpRenderTree::open):
1713         (WebCore::DumpRenderTree::createWindow):
1714         * DumpRenderTree/qt/DumpRenderTree.h:
1715         (WebCore::DumpRenderTree::setTextOutputEnabled):
1716         (WebCore::DumpRenderTree::isTextOutputEnabled):
1717         (WebCore::WebPage::shouldInterruptJavaScript):
1718         (WebCore::WebPage::isTextOutputEnabled):
1719         (WebCore::WebPage::setViewGeometry):
1720
1721 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1722
1723         Reviewed by Gustavo Noronha Silva.
1724
1725         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1726         as the implementation is being used by at least Qt and Gtk+.
1727
1728         Update buildsystems as well.
1729
1730         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1731         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1732         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1733         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1734         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1735         * GNUmakefile.am:
1736
1737 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1738
1739         Reviewed by Alexey Proskuryakov.
1740
1741         Disable wss until all platforms support pyOpenSSL
1742
1743         https://bugs.webkit.org/show_bug.cgi?id=31479
1744
1745         * Scripts/run-webkit-tests:
1746
1747 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1748
1749         Reviewed by Kenneth Christiansen.
1750
1751         [Qt] Implement load error pages support for Qt's DRT.
1752         https://bugs.webkit.org/show_bug.cgi?id=31509
1753
1754         For now, it will not be a default feature, and layout tests
1755         that want to make use of this have to explicitily call
1756         'handleErrorPages();' for the test source.
1757
1758         Any of the other DumpRenderTree's (mac, win and gtk)
1759         support handling error pages. Qt's will be the first.
1760
1761         * DumpRenderTree/qt/DumpRenderTree.cpp:
1762         (WebCore::WebPage::supportsExtension):
1763         (WebCore::WebPage::extension):
1764         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1765         (LayoutTestController::reset):
1766         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1767         (LayoutTestController::shouldHandleErrorPages):
1768         (LayoutTestController::handleErrorPages):
1769
1770 2009-11-16  Eric Seidel  <eric@webkit.org>
1771
1772         Reviewed by Adam Barth.
1773
1774         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1775         https://bugs.webkit.org/show_bug.cgi?id=31549
1776
1777         Renamed --commit-queue to --non-interactive in most places
1778         and remove the code in land-patches which is no longer needed.
1779
1780         * Scripts/bugzilla-tool:
1781
1782 2009-11-16  Eric Seidel  <eric@webkit.org>
1783
1784         Reviewed by Adam Barth.
1785
1786         The commit-queue should use land-attachment
1787         https://bugs.webkit.org/show_bug.cgi?id=31548
1788
1789         * Scripts/bugzilla-tool:
1790
1791 2009-11-16  Adam Barth  <abarth@webkit.org>
1792
1793         Reviewed by Eric Seidel.
1794
1795         Convert CommitQueue over to PatchCollection
1796         https://bugs.webkit.org/show_bug.cgi?id=31547
1797
1798         Also fixes a bug in workqueue and adds a test!
1799
1800         * Scripts/bugzilla-tool:
1801         * Scripts/modules/workqueue.py:
1802         * Scripts/modules/workqueue_unittest.py:
1803
1804 2009-11-16  Adam Barth  <abarth@webkit.org>
1805
1806         Reviewed by Eric Seidel.
1807
1808         Move StyleQueue over to using PatchCollection
1809         https://bugs.webkit.org/show_bug.cgi?id=31544
1810
1811         That's what the class it's for.
1812
1813         * Scripts/bugzilla-tool:
1814         * Scripts/modules/patchcollection.py:
1815         * Scripts/modules/patchcollection_unittest.py:
1816
1817 2009-11-16  Eric Seidel  <eric@webkit.org>
1818
1819         Reviewed by Adam Barth.
1820
1821         bugzilla-tool needs a land-attachment command
1822         https://bugs.webkit.org/show_bug.cgi?id=31546
1823
1824         * Scripts/bugzilla-tool:
1825          - Move all the logic into AbstractLandingCommand and
1826            add a new LandAttachment command subclass.
1827          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1828
1829 2009-11-16  Eric Seidel  <eric@webkit.org>
1830
1831         Reviewed by Adam Barth.
1832
1833         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1834         https://bugs.webkit.org/show_bug.cgi?id=31543
1835
1836         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1837
1838         * Scripts/bugzilla-tool:
1839
1840 2009-11-16  Eric Seidel  <eric@webkit.org>
1841
1842         Reviewed by Adam Barth.
1843
1844         Disable the style queue from posting to the commit queue status page.
1845
1846         * Scripts/bugzilla-tool:
1847
1848 2009-11-16  Adam Barth  <abarth@webkit.org>
1849
1850         Reviewed by Eric Seidel.
1851
1852         Implement PatchCollection
1853         https://bugs.webkit.org/show_bug.cgi?id=31541
1854
1855         This class holds a set of patches and lets clients iterate through
1856         them.  Optionally, clients can install a filter.
1857
1858         * Scripts/modules/patchcollection.py: Added.
1859         * Scripts/modules/patchcollection_unittest.py: Added.
1860         * Scripts/run-webkit-unittests:
1861
1862 2009-11-16  Eric Seidel  <eric@webkit.org>
1863
1864         Reviewed by Adam Barth.
1865
1866         bugzilla-tool land-patches will close bugs with patches r=?
1867         https://bugs.webkit.org/show_bug.cgi?id=28230
1868
1869         The commit-queue shouldn't close patches with outstanding reviews on them,
1870         even if many reviewers seem to be against multi-patch bugs.
1871
1872         * Scripts/bugzilla-tool:
1873
1874 2009-11-16  Eric Seidel  <eric@webkit.org>
1875
1876         Reviewed by Adam Barth.
1877
1878         bugzilla-tool check-style should work with attachment ids instead of bug ids
1879         https://bugs.webkit.org/show_bug.cgi?id=31540
1880
1881         * Scripts/bugzilla-tool:
1882
1883 2009-11-16  Eric Seidel  <eric@webkit.org>
1884
1885         Reviewed by Adam Barth.
1886
1887         WorkQueue is the only place that should know about special exit codes
1888         https://bugs.webkit.org/show_bug.cgi?id=31534
1889
1890         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1891         and add tests for handling exit codes.
1892         I also cleaned up workqueue_unittest.py more.
1893
1894         * Scripts/bugzilla-tool:
1895         * Scripts/modules/workqueue.py:
1896         * Scripts/modules/workqueue_unittest.py:
1897
1898 2009-11-16  Eric Seidel  <eric@webkit.org>
1899
1900         Reviewed by Adam Barth.
1901
1902         Re-factor workqueue_unittest to allow for more than one test.
1903         https://bugs.webkit.org/show_bug.cgi?id=31535
1904
1905         * Scripts/modules/workqueue_unittest.py:
1906
1907 2009-11-16  Eric Seidel  <eric@webkit.org>
1908
1909         Reviewed by Adam Barth.
1910
1911         land-patches needs to be re-factored into smaller chunks
1912         https://bugs.webkit.org/show_bug.cgi?id=31532
1913
1914         * Scripts/bugzilla-tool: fix a couple obvious typos.
1915
1916 2009-11-16  Eric Seidel  <eric@webkit.org>
1917
1918         Reviewed by Adam Barth.
1919
1920         land-patches needs to be re-factored into smaller chunks
1921         https://bugs.webkit.org/show_bug.cgi?id=31532
1922
1923         The next patch will move these methods into WebKitLandingScripts.
1924
1925         * Scripts/bugzilla-tool:
1926          - Split out _land_patch and _close_bug_if_no_active_patches.
1927
1928 2009-11-16  Adam Barth  <abarth@webkit.org>
1929
1930         Reviewed by Eric Seidel.
1931
1932         Fix silly copy-and-paste code.  I am a terrible coder.
1933
1934         * Scripts/modules/bugzilla.py:
1935
1936 2009-11-16  Adam Barth  <abarth@webkit.org>
1937
1938         Reviewed by Eric Seidel.
1939
1940         Implement a StyleQueue
1941         https://bugs.webkit.org/show_bug.cgi?id=31537
1942
1943         The first iteration of the style queue only produces output locally.
1944         There is also a limit of 10 patches because it's not that useful to
1945         iterate through the entire review queue at this point.  We can remove
1946         the limit later.
1947
1948         * Scripts/bugzilla-tool:
1949         * Scripts/modules/bugzilla.py:
1950
1951 2009-11-16  Adam Barth  <abarth@webkit.org>
1952
1953         Reviewed by Eric Seidel.
1954
1955         Unit test WorkQueue
1956         https://bugs.webkit.org/show_bug.cgi?id=31531
1957
1958         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1959
1960         * Scripts/bugzilla-tool:
1961         * Scripts/modules/statusbot.py:
1962         * Scripts/modules/workqueue.py:
1963         * Scripts/modules/workqueue_unittest.py: Added.
1964         * Scripts/run-webkit-unittests:
1965
1966 2009-11-16  Eric Seidel  <eric@webkit.org>
1967
1968         Reviewed by Adam Barth.
1969
1970         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1971         https://bugs.webkit.org/show_bug.cgi?id=31530
1972
1973         * Scripts/bugzilla-tool:
1974
1975 2009-11-16  Eric Seidel  <eric@webkit.org>
1976
1977         Reviewed by Adam Barth.
1978
1979         bugzilla-tool needs apply-attachment
1980         https://bugs.webkit.org/show_bug.cgi?id=31528
1981
1982         * Scripts/bugzilla-tool:
1983          - Add ApplyAttachment command.
1984          - Abstract applying code into WebKitApplyingScripts.
1985          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1986         * Scripts/modules/bugzilla.py:
1987          - Add fetch_attachment and bug_id_for_attachment_id.
1988         * Scripts/modules/bugzilla_unittest.py:
1989          - Add test for new parsing.
1990          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1991
1992 2009-11-16  Eric Seidel  <eric@webkit.org>
1993
1994         Reviewed by Adam Barth.
1995
1996         Document check-style's use of force_clean.
1997
1998         * Scripts/bugzilla-tool:
1999         * Scripts/modules/scm.py:
2000
2001 2009-11-16  Adam Barth  <abarth@webkit.org>
2002
2003         Reviewed by Eric Seidel.
2004
2005         Move WorkQueue to its own file
2006         https://bugs.webkit.org/show_bug.cgi?id=31529
2007
2008         WorkQueue and WorkQueueDelegate are separate concerns from
2009         bugzilla-tool.  Also added a missing include to logging.py.
2010
2011         * Scripts/bugzilla-tool:
2012         * Scripts/modules/logging.py:
2013         * Scripts/modules/workqueue.py:
2014
2015 2009-11-16  Adam Barth  <abarth@webkit.org>
2016
2017         Reviewed by Eric Seidel.
2018
2019         Move OutputTee to logging.py.
2020
2021         * Scripts/bugzilla-tool:
2022         * Scripts/modules/logging.py:
2023
2024 2009-11-15  Adam Barth  <abarth@webkit.org>
2025
2026         Reviewed by Eric Seidel.
2027
2028         Refactor bugzilla-tool to allow for multiple queues
2029         https://bugs.webkit.org/show_bug.cgi?id=31513
2030
2031         Divide the commit queue class into three class to make creating
2032         additional queues easier.
2033
2034         * Scripts/bugzilla-tool:
2035
2036 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2037
2038         Reviewed by Eric Seidel.
2039
2040         svn-apply may not handle git patches created by bugzilla-tool
2041         https://bugs.webkit.org/show_bug.cgi?id=31457
2042
2043         * Scripts/modules/scm.py:
2044         * Scripts/modules/scm_unittest.py:
2045
2046 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2047
2048         Reviewed by Eric Seidel.
2049
2050         bugzilla-tool should post git binary diff
2051         https://bugs.webkit.org/show_bug.cgi?id=31458
2052
2053         Add --binary option to Git.create_patch.
2054
2055         * Scripts/modules/scm.py:
2056         * Scripts/modules/scm_unittest.py:
2057
2058 2009-11-15  Adam Barth  <abarth@webkit.org>
2059
2060         Reviewed by Darin Adler.
2061
2062         Add bugzilla-tool check-style
2063         https://bugs.webkit.org/show_bug.cgi?id=31515
2064
2065         * Scripts/bugzilla-tool:
2066         * Scripts/modules/bugzilla.py:
2067
2068 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2069
2070         Reviewed by Simon Hausmann.
2071
2072         Make the Qt Linux only --valgrind feature, suppress errors
2073         defined in the SuppressedValgrindErrors file.
2074
2075         * Scripts/run-webkit-tests:
2076
2077 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2078
2079         Reviewed by Simon Hausmann.
2080
2081         Set the locale to C and not to the current one in use on the system.
2082
2083         * DumpRenderTree/qt/DumpRenderTree.cpp:
2084         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2085
2086 2009-11-13  Adam Roben  <aroben@apple.com>
2087
2088         Add support for
2089         http/tests/security/isolatedWorld/didClearWindowObject.html
2090
2091         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2092         window objects in isolated worlds are cleared
2093
2094         Reviewed by Dave Hyatt.
2095
2096         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
2097
2098         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2099         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2100         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
2101         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2102         Added. Sets a __worldID property on the global object whose value is
2103         the ID of this world.
2104         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
2105         Respond to this new delegate callback by calling through to one of the
2106         above new methods.
2107         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2108         (worldMap): Added. Returns a HashMap containing all the worlds we've
2109         created.
2110         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
2111         haven't kept track of this world.
2112         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2113         instead of declaring our own.
2114
2115         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
2116
2117         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2118         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
2119         didClearWindowObjectForFrameInStandardWorld.
2120         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
2121         Respond to this new delegate callback by calling through to one of the
2122         below new methods.
2123         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
2124         Added. Sets a __worldID property on the gobal object whose value is
2125         the ID of this world.
2126         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2127         Added. Moved code here from didClearWindowObject.
2128
2129         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
2130         didClearWindowObjectForFrame* functions.
2131
2132         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2133         (worldMap): Added. Returns a HashMap containing all the worlds we've
2134         created.
2135         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2136         haven't kept track of this world.
2137         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2138         instead of declaring our own.
2139
2140 2009-11-13  Adam Roben  <aroben@apple.com>
2141
2142         Finish replacing worldIDs with world objects
2143
2144         The only remaining use of worldIDs was in a method only used by DRT
2145         for the isolated worlds tests.
2146
2147         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2148
2149         Reviewed by Mark Rowe.
2150
2151         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2152         (LayoutTestController::evaluateScriptInIsolatedWorld):
2153         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2154         (LayoutTestController::evaluateScriptInIsolatedWorld):
2155         Updated for changes to WebFrame. Now holds the map of worldID -> world
2156         at this level instead of making WebKit do it.
2157
2158 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2159
2160         Reviewed by Simon Hausmann.
2161
2162         [Qt] Ensure the DRT does not output anything until first test is run
2163
2164         * DumpRenderTree/qt/DumpRenderTree.cpp:
2165         * DumpRenderTree/qt/DumpRenderTree.h:
2166
2167 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2168
2169         Reviewed by Tor Arne Vestbø.
2170
2171         Clear the undo stack in before each new test run.
2172
2173         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2174
2175         * DumpRenderTree/qt/DumpRenderTree.cpp:
2176         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2177
2178 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2179
2180         Reviewed by Kenneth Rohde Christiansen.
2181
2182         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2183
2184         * DumpRenderTree/qt/DumpRenderTree.cpp:
2185         (WebCore::WebPage::resetSettings):
2186         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2187         (LayoutTestController::overridePreference):
2188
2189 2009-11-13  Eric Seidel  <eric@webkit.org>
2190
2191         Reviewed by Adam Barth.
2192
2193         Update committers.py based on svn records
2194         https://bugs.webkit.org/show_bug.cgi?id=31366
2195
2196         This list was generated using validate-committer-lists from
2197         https://bugs.webkit.org/show_bug.cgi?id=30970
2198         and makes committers.py current for committers who have
2199         committed in the last 3 years.
2200
2201         * Scripts/modules/committers.py:
2202
2203 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2204
2205         Reviewed by Adam Barth.
2206
2207         The document-open.html test was flaky at times. The test invokes the layout test plugin
2208         which in its destroy stream handler opens a new document. This basically tears down the
2209         stream and the associated plugin instance. The pluginLog function in the layout test
2210         plugin attempts to retrieve the window script object on a torn down plugin instance
2211         which crashed consistently on windows in the debugger. The functions which issue
2212         these logs already have a valid window script object. We now have variants of the pluginLog
2213         function which take in a window script object with and without variable arguments. 
2214
2215         https://bugs.webkit.org/show_bug.cgi?id=31067
2216
2217         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2218         (pluginLogWithWindowObject):
2219         (pluginLogWithWindowObjectVariableArgs):
2220         (pluginLog):
2221         (notifyTestCompletion):
2222         (testDocumentOpen):
2223         (testWindowOpen):
2224
2225 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2226
2227         Reviewed by Gustavo Noronha Silva.
2228
2229         https://bugs.webkit.org/show_bug.cgi?id=30997
2230         [Gtk] Implemment AtkDocument
2231
2232         Added testing support.
2233
2234         * DumpRenderTree/AccessibilityUIElement.cpp:
2235         * DumpRenderTree/AccessibilityUIElement.h:
2236         (getDocumentEncodingCallback):
2237         (getDocumentURICallback):
2238         (AccessibilityUIElement::getJSClass):
2239         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2240         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2241         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2242         (AccessibilityUIElement::documentEncoding):
2243         (AccessibilityUIElement::documentURI):
2244
2245 2009-11-12  Adam Roben  <aroben@apple.com>
2246
2247         Replace worldIDs with world objects
2248
2249         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2250         user scripts/stylesheets and isolated worlds
2251
2252         Reviewed by Sam Weinig.
2253
2254         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2255         (LayoutTestController::addUserScript):
2256         (LayoutTestController::addUserStyleSheet):
2257         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2258         (LayoutTestController::addUserScript):
2259         (LayoutTestController::addUserStyleSheet):
2260         Changed these functions to create a new WebJSWorld each time they're
2261         called and to pass that world to WebKit.
2262
2263 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2264
2265         Reviewed by Oliver Hunt.
2266
2267         need to implement aria tree roles
2268         https://bugs.webkit.org/show_bug.cgi?id=31284
2269
2270         * DumpRenderTree/AccessibilityUIElement.cpp:
2271         (disclosedRowAtIndexCallback):
2272         (selectedRowAtIndexCallback):
2273         (isEqualCallback):
2274         (isAttributeSettableCallback):
2275         (isActionSupportedCallback):
2276         (disclosedByRowCallback):
2277         (hierarchicalLevelCallback):
2278         (AccessibilityUIElement::getJSClass):
2279         * DumpRenderTree/AccessibilityUIElement.h:
2280         (AccessibilityUIElement::isEqual):
2281         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2282         (AccessibilityUIElement::hierarchicalLevel):
2283         (AccessibilityUIElement::disclosedRowAtIndex):
2284         (AccessibilityUIElement::selectedRowAtIndex):
2285         (AccessibilityUIElement::disclosedByRow):
2286         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2287         (AccessibilityUIElement::getChildAtIndex):
2288         (AccessibilityUIElement::disclosedRowAtIndex):
2289         (AccessibilityUIElement::selectedRowAtIndex):
2290         (AccessibilityUIElement::titleUIElement):
2291         (AccessibilityUIElement::parentElement):
2292         (AccessibilityUIElement::disclosedByRow):
2293         (AccessibilityUIElement::hierarchicalLevel):
2294         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2295         (AccessibilityUIElement::hierarchicalLevel):
2296         (AccessibilityUIElement::disclosedRowAtIndex):
2297         (AccessibilityUIElement::selectedRowAtIndex):
2298         (AccessibilityUIElement::disclosedByRow):
2299
2300 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2301
2302         Reviewed by Darin Adler.
2303
2304         svn-apply can not handle git binary diffs
2305         https://bugs.webkit.org/show_bug.cgi?id=26830
2306
2307         Support "literal" type git binary diffs.
2308
2309         * Scripts/VCSUtils.pm:
2310         * Scripts/modules/scm_unittest.py:
2311         * Scripts/svn-apply:
2312
2313 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2314
2315         Not reviewed, removing duplicate entry for myself in committers.py.
2316
2317         * Scripts/modules/committers.py:
2318
2319 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2320
2321         Reviewed by Darin Adler and Mark Rowe.
2322
2323         https://bugs.webkit.org/show_bug.cgi?id=31200
2324         Tests in http/tests/security/mixedContent start to fail when new tests are added
2325
2326         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2327
2328 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2329
2330         Reviewed by Jan Alonzo.
2331
2332         Create, and display a window for the inspector, for inspector
2333         tests.
2334
2335         Need to also show/hide the inspector window to avoid having
2336         problems with code assuming it is realized
2337         https://bugs.webkit.org/show_bug.cgi?id=31347
2338
2339         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2340         (webInspectorShowWindow):
2341         (webInspectorCloseWindow):
2342         (webInspectorInspectWebView):
2343         (createWebView):
2344
2345 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2346
2347         Unreviewed Qt buildbot fix.
2348
2349         My previous fix was wrong, so revert that change and fix it by
2350         returning when the document of the frame has no document element.
2351         Idea is borrowed from mac and win DRT.
2352
2353         * DumpRenderTree/qt/DumpRenderTree.cpp:
2354         (WebCore::DumpRenderTree::dumpFramesAsText):
2355
2356 2009-11-11  Eric Seidel  <eric@webkit.org>
2357
2358         Reviewed byg Kenneth Rohde Christiansen.
2359
2360         Update Kenneth's committer record to include the email he
2361         uses on lists.webkit.org.
2362
2363         * Scripts/modules/committers.py:
2364
2365 2009-11-11  Eric Seidel  <eric@webkit.org>
2366
2367         Reviewed by Gustavo Noronha Silva.
2368
2369         Several committers use separate email addresses for bugzilla and svn.webkit.org
2370         https://bugs.webkit.org/show_bug.cgi?id=31364
2371
2372         Update records for existing committers to include email addresses
2373         used in svn.webkit.org and lists.webkit.org.
2374         Most committers use the same email address in all 3 places, but some use
2375         separate addresses.  committers.py needs record of each of these addresses.
2376
2377         * Scripts/modules/committers.py:
2378
2379 2009-11-11  Eric Seidel  <eric@webkit.org>
2380
2381         No review, adding second email address for an existing committer.
2382
2383         Add Yong Li's second bugzilla account to his committer record.
2384         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2385
2386         * Scripts/modules/committers.py:
2387
2388 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2389
2390         Reviewed by Simon Hausmann.
2391
2392         If the frame has no innerText don't append it, and
2393         do not add a newline which breaks some cross platform
2394         results.
2395
2396         * DumpRenderTree/qt/DumpRenderTree.cpp:
2397         (WebCore::DumpRenderTree::dumpFramesAsText):
2398
2399 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2400
2401         Reviewed by Simon Hausmann.
2402
2403         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2404
2405         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2406         (webkit_test_plugin_new_instance):
2407         (webkit_test_plugin_destroy_instance):
2408         (webkit_test_plugin_destroy_stream):
2409
2410 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2411
2412         Reviewed by Mark Rowe.
2413
2414         Implement the functionality needed by plugins/window-open.html
2415
2416         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2417         (webkit_test_plugin_new_instance):
2418         (webkit_test_plugin_set_window):
2419
2420 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2421
2422         Reviewed by Simon Hausmann.
2423
2424         [Qt] Force -graphicssystem raster and -style windows when running DRT
2425
2426         * DumpRenderTree/qt/main.cpp:
2427         * Scripts/run-webkit-tests:
2428
2429 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2430
2431         Reviewed by Simon Hausmann.
2432
2433         Compute correct library paths for Qt
2434
2435         * Scripts/webkitdirs.pm:
2436
2437 2009-11-10  Mark Rowe  <mrowe@apple.com>
2438
2439         Reviewed by Sam Weinig.
2440
2441         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2442
2443         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2444         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2445         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2446         that had enabled frame load delegate logging this would result in extra log messages being generated,
2447         causing the test to fail.
2448
2449         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2450         tests.
2451
2452         * DumpRenderTree/mac/DumpRenderTree.mm:
2453         (dumpRenderTree):
2454         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2455         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2456
2457 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2458
2459         Reviewed by Kenneth Rohde Christiansen.
2460
2461         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2462
2463         * DumpRenderTree/qt/DumpRenderTree.cpp:
2464         (WebCore::DumpRenderTree::DumpRenderTree):
2465
2466 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2467
2468         Reviewed by Jan Alonzo.
2469
2470         [GTK] Remove WebSocket configuration from WebKitWebSettings
2471         https://bugs.webkit.org/show_bug.cgi?id=31244
2472
2473         Follow-up of r50724. Don't set the enable-web-socket property
2474         anymore.
2475
2476         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2477         (resetDefaultsToConsistentValues):
2478
2479 2009-11-10  Oliver Hunt  <oliver@apple.com>
2480
2481         Reviewed by Maciej Stachowiak.
2482
2483         Rename 3D Canvas related classes to use WebGL prefix
2484         https://bugs.webkit.org/show_bug.cgi?id=29095
2485
2486         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2487         and upate webkitdirs script to new method of testing for WebGL.
2488
2489         * Scripts/do-webcore-rename:
2490         * Scripts/webkitdirs.pm:
2491
2492 2009-11-09  Oliver Hunt  <oliver@apple.com>
2493
2494         Reviewed by Geoff Garen.
2495
2496         Make do-webcore-rename work with git.
2497
2498         * Scripts/do-webcore-rename:
2499
2500 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2501
2502         Adding Kenneth to the reviewers list.
2503
2504         * Scripts/modules/committers.py:
2505
2506 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2507
2508         Reviewed by Jan Alonzo.
2509
2510         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2511         https://bugs.webkit.org/show_bug.cgi?id=30482
2512
2513         LayoutTestControllerGtk now uses the exposed
2514         Page::tabKeyCyclesThroughElements API
2515
2516         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2517         (LayoutTestController::setTabKeyCyclesThroughElements):
2518
2519 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2520
2521         Reviewed by Holger Freyther.
2522
2523         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2524         This helps to pass the test case below. Also replaced hardcoded
2525         code numbers with defined constants.
2526         https://bugs.webkit.org/show_bug.cgi?id=31185
2527         
2528         Test: editing/undo/undo-deleteWord.html
2529
2530         * DumpRenderTree/qt/EventSenderQt.cpp:
2531         (EventSender::keyDown):
2532
2533 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2534
2535         Reviewed by Holger Freyther.
2536
2537         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2538         https://bugs.webkit.org/show_bug.cgi?id=31164
2539
2540         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2541
2542         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2543         (LayoutTestController::processWork):
2544
2545 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2546
2547         Reviewed by Holger Freyther.
2548
2549         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2550         https://bugs.webkit.org/show_bug.cgi?id=31158
2551
2552         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2553         always, which from WorkQueue prospective means that a load has been started
2554         and the queue processing should stop and wait for the load to finish.
2555         Spinning it off into a loading and a non-loading variants was the solution
2556         adopted by Mac's DRT to work around this problem. The former keeps returning
2557         'true' while the later executes the script synchronously and returns 'false'
2558         making it possible to the WorkQueue to proceed right away.
2559
2560         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2561         (LayoutTestController::processWork):
2562         (LayoutTestController::queueLoadingScript):
2563         (LayoutTestController::queueNonLoadingScript):
2564         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2565         * DumpRenderTree/qt/WorkQueueItem.h:
2566         (LoadingScriptItem::LoadingScriptItem):
2567         (LoadingScriptItem::invoke):
2568         (NonLoadingScriptItem::NonLoadingScriptItem):
2569         (NonLoadingScriptItem::invoke):
2570
2571 2009-11-07  Mark Rowe  <mrowe@apple.com>
2572
2573         Rubber-stamped by Cameron Zwarich.
2574
2575         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2576
2577         * Scripts/commit-log-editor:
2578
2579 2009-11-07  Mark Rowe  <mrowe@apple.com>
2580
2581         Reviewed by Darin Adler.
2582
2583         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2584         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2585
2586         Move logic for determining the name and email address to use in a ChangeLog entry from
2587         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2588         whether the author of the patch matches committer, and therefore needs access to the
2589         email address that would be used in a ChangeLog entry.
2590
2591         Based on a patch by Pierre d'Herbemont.
2592
2593         * Scripts/VCSUtils.pm:
2594         * Scripts/commit-log-editor:
2595         * Scripts/prepare-ChangeLog:
2596         * Scripts/webkitdirs.pm:
2597
2598 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2599
2600         Reviewed by Adam Barth.
2601
2602         Added functionality to the layout test plugin to invoke document.open and
2603         window.open with default arguments. The associated webkit bug is
2604         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2605         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2606         work in Chromium (V8) if there is no calling javascript context. To achieve this
2607         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2608         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2609
2610         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2611         (testDocumentOpen):
2612         (testWindowOpen):
2613         (pluginAllocate):
2614         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2615         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2616         (NPP_New):
2617         (NPP_SetWindow):
2618         (NPP_DestroyStream):
2619         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2620         (NPP_New):
2621         (NPP_SetWindow):
2622         (NPP_NewStream):
2623         (NPP_DestroyStream):
2624
2625 2009-11-06  Eric Seidel  <eric@webkit.org>
2626
2627         Reviewed by Adam Barth.
2628
2629         bugzilla-tool crashed with exception
2630         https://bugs.webkit.org/show_bug.cgi?id=31092
2631
2632         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2633
2634 2009-11-04  Eric Seidel  <eric@webkit.org>
2635
2636         No review, just add a line which got left out of the patch uploaded for commit.
2637
2638         commit-queue is crashing when trying to reject patches after unknown failures
2639         https://bugs.webkit.org/show_bug.cgi?id=31091
2640
2641         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2642
2643 2009-11-04  Adam Roben  <aroben@apple.com>
2644
2645         Remove bogus else clause in bugzilla-tool
2646
2647         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2648         create-bug raises exception after entering bug description
2649
2650         Reviewed by David Kilzer.
2651
2652         * Scripts/bugzilla-tool:
2653         (CreateBug): else clauses are only hit if no exception is raised, so
2654         it makes no sense to try to re-raise the exception in an else clause.
2655         The exception will automatically be re-raised if it doesn't match any
2656         of the except clauses, so we don't have to do anything special here at
2657         all to get the desired behavior.
2658
2659 2009-11-04  Eric Seidel  <eric@webkit.org>
2660
2661         Reviewed by David Kilzer.
2662
2663         svn-apply's fixChangeLogPatch function seems broken
2664         https://bugs.webkit.org/show_bug.cgi?id=30683
2665
2666         Update fixChangeLogPatch to be able to handle patches which
2667         don't start at line 1.
2668         Add unit tests for svn-apply to scm_unittest.py.
2669
2670         * Scripts/VCSUtils.pm:
2671         * Scripts/modules/scm_unittest.py:
2672
2673 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2674
2675         Reviewed by Beth Dakin.
2676
2677         Need to implement ARIA role="combobox"
2678         https://bugs.webkit.org/show_bug.cgi?id=31096
2679
2680         * DumpRenderTree/AccessibilityUIElement.cpp:
2681         (showMenuCallback):
2682         (getIsExpandedCallback):
2683         (AccessibilityUIElement::getJSClass):
2684         * DumpRenderTree/AccessibilityUIElement.h:
2685         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2686         (AccessibilityUIElement::isExpanded):
2687         (AccessibilityUIElement::showMenu):
2688         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2689         (AccessibilityUIElement::isExpanded):
2690         (AccessibilityUIElement::showMenu):
2691         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2692         (AccessibilityUIElement::isSelected):
2693         (AccessibilityUIElement::isExpanded):
2694         (AccessibilityUIElement::showMenu):
2695
2696 2009-11-04  Eric Seidel  <eric@webkit.org>
2697
2698         Reviewed by Adam Barth.
2699
2700         commit-queue is crashing when trying to reject patches after unknown failures
2701         https://bugs.webkit.org/show_bug.cgi?id=31091
2702
2703         * Scripts/bugzilla-tool:
2704          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2705            so we have to find out what the current patch is by asking bugzilla again.
2706          - Discovered that this code was also leaking file descriptors, so fixed that.
2707
2708 2009-11-04  Adam Roben  <aroben@apple.com>
2709
2710         Make run-webkit-tests work for the Debug_Internal Windows
2711         configuration
2712
2713         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2714         suffix.
2715
2716         Fixes <http://webkit.org/b/31123>.
2717
2718         Reviewed by Sam Weinig.
2719
2720         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2721         Debug_Internal, either.
2722
2723 2009-11-04  Eric Seidel  <eric@webkit.org>
2724
2725         Reviewed by Adam Barth.
2726
2727         committers.py needs a way to store non-bugzilla email addresses
2728         https://bugs.webkit.org/show_bug.cgi?id=31037
2729
2730         Make Committer and Reviewer constructors take a single email or a list of emails.
2731         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2732         Expose reviewers(), used by validate-committer-lists on bug 30970.
2733
2734         * Scripts/modules/committers.py:
2735         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2736
2737 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2738
2739         Reviewed by David Levin.
2740
2741         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2742         https://bugs.webkit.org/show_bug.cgi?id=27491
2743
2744         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2745         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2746
2747         Functions to start or stop Web Socket servers are added.
2748
2749         * Scripts/run-webkit-tests:
2750
2751 2009-11-03  Eric Seidel  <eric@webkit.org>
2752
2753         No review, just changing wording of log message.
2754
2755         Change log string to say "failed" instead of "rejected"
2756         when a commit fails due to an out of date checkout.
2757         This makes grepping the commit-queue log for rejected patches easier.
2758
2759         * Scripts/bugzilla-tool:
2760
2761 2009-11-03  Eric Seidel  <eric@webkit.org>
2762
2763         No review, adding commonly known committers missing from the file.
2764
2765         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2766
2767 2009-11-03  Eric Seidel  <eric@webkit.org>
2768
2769         No review, just sort-order cleanup.
2770
2771         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2772
2773 2009-11-03  Stephen White  <senorblanco@chromium.org>
2774
2775         (Unreviewed).
2776
2777         Add myself to committers.py.
2778
2779         * Scripts/modules/committers.py:
2780
2781 2009-11-03  Robin Dunn  <robin@alldunn.com>
2782
2783         Reviewed by Kevin Ollviier.
2784
2785         Add packaging scripts for Debian-based Linux distros.
2786         
2787         https://bugs.webkit.org/show_bug.cgi?id=31075
2788
2789         * wx/packaging/build-debian-installer.py: Added.
2790         * wx/packaging/debian: Added.
2791
2792 2009-11-03  Dan Bernstein  <mitz@apple.com>
2793
2794         Reviewed by Anders Carlsson and Beth Dakin.
2795
2796         https://bugs.webkit.org/show_bug.cgi?id=31070
2797
2798         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2799         destroyed, it executes the value of the 'ondestroy' parameter as a
2800         script.
2801
2802         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2803         (pluginAllocate): Initialize onDestroy.
2804         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2805         onDestroy.
2806         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2807         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2808         specified.
2809         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2810
2811 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2812
2813         Reviewed by Xan Lopez.
2814
2815         https://bugs.webkit.org/show_bug.cgi?id=31035
2816         [GTK] some accessibility tests hitting assertion in debug builds
2817
2818         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2819
2820         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2821         (AccessibilityController::rootElement):
2822
2823 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2824
2825         Reviewed by Beth Dakin.
2826
2827         Support ARIA "tab" roles
2828         https://bugs.webkit.org/show_bug.cgi?id=30842
2829
2830         * DumpRenderTree/AccessibilityUIElement.cpp:
2831         * DumpRenderTree/AccessibilityUIElement.h:
2832         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2833         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2834         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2835
2836 2009-11-01  Eric Seidel  <eric@webkit.org>
2837
2838         Reviewed by David Levin.
2839
2840         buildbots should use --exit-after-N-failures
2841         https://bugs.webkit.org/show_bug.cgi?id=30809
2842
2843         Make the bots exit after 20 failures to prevent never-ending
2844         test runs where every test spends a minute crashing.
2845
2846         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2847
2848 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2849
2850         Reviewed by Eric Seidel.
2851
2852         Turn on warnings for QtWebKit for gcc
2853         https://bugs.webkit.org/show_bug.cgi?id=30958
2854
2855         * DumpRenderTree/qt/main.cpp: 
2856         (crashHandler): Mark function NO_RETURN
2857
2858 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2859
2860         Adding myself to the committers list.
2861
2862         * Scripts/modules/committers.py:
2863
2864 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2865
2866         Fix an issue that Adam noticed in DRT.
2867
2868         Reviewed by Darin Adler.
2869
2870         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2871         (AccessibilityUIElement::role):
2872         Get the length of the role text, and create a buffer dynamically.
2873
2874 2009-10-30  Eric Seidel  <eric@webkit.org>
2875
2876         No review, rolling out r50105.
2877         http://trac.webkit.org/changeset/50105
2878
2879         This commit was causing:
2880         https://bugs.webkit.org/show_bug.cgi?id=30869
2881         We'll re-implement the feature a different way.
2882
2883         * Scripts/bugzilla-tool:
2884
2885 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2886
2887         Test for MSAA: Accessibility of headings is not correct
2888
2889         https://bugs.webkit.org/show_bug.cgi?id=30937
2890
2891         Reviewed by Adam Roben.
2892
2893         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2894         (AccessibilityUIElement::role):
2895         Allow the role returned to be a BSTR.
2896         (AccessibilityUIElement::description):
2897         Fix a copy/paste error.
2898
2899 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2900
2901         Test for MSAA: Accessibility of links is wrong
2902
2903         https://bugs.webkit.org/show_bug.cgi?id=30928
2904
2905         Reviewed by Darin Adler.
2906
2907         * DumpRenderTree/AccessibilityUIElement.cpp:
2908         (getAccessibilityValueCallback):
2909         Return the accessibility value.
2910         (AccessibilityUIElement::getJSClass):
2911         Added "accessibilityValue" value.
2912
2913         * DumpRenderTree/AccessibilityUIElement.h:
2914
2915         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2916         (AccessibilityUIElement::accessibilityValue):
2917         Stubbed.
2918
2919         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2920         (AccessibilityUIElement::accessibilityValue):
2921         Stubbed.
2922
2923         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2924         (AccessibilityUIElement::accessibilityValue):
2925         Get the object's value, and return it as a JS string.
2926
2927 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2928
2929         Fix typo in command name used by wx build system.
2930
2931         * wx/build/build_utils.py:
2932
2933 2009-10-30  Adam Barth  <abarth@webkit.org>
2934
2935         Reviewed by Darin Adler.
2936
2937         Patch v1 is a dumb default name for patches
2938         https://bugs.webkit.org/show_bug.cgi?id=30952
2939
2940         Let's use "Patch" instead.
2941
2942         * Scripts/bugzilla-tool:
2943
2944 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2945
2946         Unreviewed trivial buildfix.
2947
2948         [Qt] Buildfix for r50333.
2949
2950         * DumpRenderTree/qt/DumpRenderTree.pro:
2951
2952 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2953
2954         Reviewed by Holger Freyther.
2955
2956         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2957         https://bugs.webkit.org/show_bug.cgi?id=30953
2958
2959         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2960         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2961         makes qt DRT to share this implementation (as gtk and mac ports do).
2962
2963         * DumpRenderTree/qt/DumpRenderTree.pro:
2964         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2965         * DumpRenderTree/qt/WorkQueue.h: Removed.
2966
2967 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2968
2969         Unreviewed potential buildbot fix.
2970
2971         Second try: Reset page history before running each test.
2972
2973         Apparently the QWebHistory::clear() keeps the current page
2974         in history which is not what we want, so we not additionally
2975         sets the history capacity to 0 (forces removing everything)
2976         and then sets it back to its original value.
2977
2978         * DumpRenderTree/qt/DumpRenderTree.cpp:
2979         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2980
2981 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2982
2983         Unreviewed potential buildbot fix.
2984
2985         Reset page history before running each test.
2986
2987         * DumpRenderTree/qt/DumpRenderTree.cpp:
2988         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2989
2990 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2991
2992         Reviewed by Eric Seidel.
2993
2994         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2995
2996         Bug 28420 -  Implement HTML5 <ruby> rendering
2997         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2998
2999         No new tests (no functional change).
3000
3001         * Scripts/build-webkit:
3002
3003 2009-10-29  Dan Bernstein  <mitz@apple.com>
3004
3005         Reviewed by Mark Rowe.
3006
3007         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
3008         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
3009         define it.
3010
3011         * Scripts/VCSUtils.pm:
3012         * Scripts/svn-apply:
3013         * Scripts/svn-unapply:
3014
3015 2009-10-29  Xan Lopez  <xlopez@igalia.com>
3016
3017         Reviewed by Gustavo Noronha.
3018
3019         Use the GTK+ main loop instead of rolling our own mini-version of
3020         it.
3021
3022         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3023         (dump):
3024         (runTest):
3025         (webViewLoadFinished):
3026
3027 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3028
3029         Reviewed by Oliver Hunt.
3030
3031         Implement the Qt version of DRT dumpBackForwardList().
3032
3033         * DumpRenderTree/qt/DumpRenderTree.cpp:
3034         (WebCore::dumpHistoryItem):
3035         (WebCore::DumpRenderTree::dumpBackForwardList):
3036
3037 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3038
3039         Reviewed by Adam Roben.
3040
3041         Implement DRT functionality for Qt introduced in
3042         r28690 and r28705.
3043
3044         - Implemented pathToLocalResource which exposes the functionality of
3045         converting a given unix path to the correct location on Windows.
3046         - Implemented a way to remove machine-dependent information from paths
3047         in layout test results.
3048
3049         * DumpRenderTree/qt/DumpRenderTree.cpp:
3050         (WebCore::urlSuitableForTestResult):
3051         (WebCore::WebPage::javaScriptConsoleMessage):
3052         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3053         (LayoutTestController::pathToLocalResource):
3054         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3055
3056 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
3057
3058         Adding myself to the committers list.
3059
3060         * Scripts/modules/committers.py:
3061
3062 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
3063
3064         Adding myself to the committers list.
3065
3066         * Scripts/modules/committers.py:
3067
3068 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3069
3070         Reviewed by Jan Alonzo.
3071
3072         [GTK] API to start inspector for a WebView
3073         https://bugs.webkit.org/show_bug.cgi?id=22551
3074
3075         Use the new inspector API to implement the LayoutTestController
3076         interfaces used to test the inspector.
3077
3078         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3079         (webInspectorInspectWebView):
3080         (createWebView):
3081         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3082         (LayoutTestController::showWebInspector):
3083         (LayoutTestController::closeWebInspector):
3084         (LayoutTestController::evaluateInWebInspector):
3085
3086 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
3087
3088         Reviewed by Eric Seidel.
3089
3090         [Qt] WebFrame::counterValueForElementById must not be exposed
3091         https://bugs.webkit.org/show_bug.cgi?id=30882
3092
3093         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3094         (LayoutTestController::counterValueForElementById):
3095
3096 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3097
3098         Rubberstamped by Oliver Hunt.
3099
3100         Fix the warning:
3101
3102         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
3103         declared with attribute warn_unused_result".
3104
3105         by actually checking the result. In the case it is null, an
3106         error has occoured, so treat it as the other fatal errors.
3107
3108         * DumpRenderTree/qt/DumpRenderTree.cpp:
3109         (WebCore::DumpRenderTree::initializeFonts):
3110
3111 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
3112
3113         Reviewed by Darin Adler.
3114
3115         Provide a way to get counter values with layoutTestContoller
3116         https://bugs.webkit.org/show_bug.cgi?id=30555
3117
3118         Define layoutTestContoller.counterValueForElementById.
3119
3120         * DumpRenderTree/LayoutTestController.cpp:
3121         (counterValueForElementByIdCallback):
3122         (LayoutTestController::staticFunctions):
3123         * DumpRenderTree/LayoutTestController.h:
3124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3125         (LayoutTestController::counterValueForElementById):
3126
3127 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3128
3129         Rubberstamped by Oliver Hunt.
3130
3131         Change two methods to be internal for DRT use only.
3132
3133         Part of [Qt] Review all new API in Qt 4.6
3134         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
3135
3136         * DumpRenderTree/qt/DumpRenderTree.cpp:
3137         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3138         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3139         (LayoutTestController::whiteListAccessFromOrigin):
3140
3141 2009-10-27  Eric Seidel  <eric@webkit.org>
3142
3143         Reviewed by Adam Barth.
3144
3145         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3146         https://bugs.webkit.org/show_bug.cgi?id=30826
3147
3148         * Scripts/svn-apply:
3149          - Add () around all system() calls.
3150          - Use the correct system() == 0 or die instead of system() or die
3151          - Add descriptive messages to all die statements.
3152
3153 2009-10-27  Steve Block  <steveblock@google.com>
3154
3155         Reviewed by NOBODY.
3156
3157         Adds steveblock@google.com to list of committers.
3158
3159         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3160
3161 2009-10-27  Eric Seidel  <eric@webkit.org>
3162
3163         Reviewed by Adam Barth.
3164
3165         svn-apply can exit(0) even on patch failure
3166         https://bugs.webkit.org/show_bug.cgi?id=29622
3167
3168         * Scripts/svn-apply:
3169          - Add a bunch of "or die" statements, hopefully catching all
3170            possible cases where failure could still exit(0).
3171
3172 2009-10-27  Eric Seidel  <eric@webkit.org>
3173
3174         Reviewed by Adam Barth.
3175
3176         svn-* scripts should share code through VCSUtils.pm
3177         https://bugs.webkit.org/show_bug.cgi?id=30791
3178
3179         Just moving code into a shared location.
3180
3181         * Scripts/VCSUtils.pm:
3182         * Scripts/prepare-ChangeLog:
3183         * Scripts/resolve-ChangeLogs:
3184         * Scripts/svn-apply:
3185         * Scripts/svn-create-patch:
3186         * Scripts/svn-unapply:
3187         * Scripts/update-webkit:
3188
3189 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3190
3191         Suppress a huge number of MSVC warnings when building wxWebKit.
3192
3193         * wx/build/settings.py:
3194
3195 2009-10-26  Eric Seidel  <eric@webkit.org>
3196
3197         No review, just adding Mike Belshe to the committers list.
3198
3199         * Scripts/modules/committers.py:
3200
3201 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3202
3203         Reviewed by Darin Adler.
3204
3205         Make .rc files compile on Windows without depending on MFC headers
3206         https://bugs.webkit.org/show_bug.cgi?id=30750
3207
3208         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3209         windows.h instead of afxres.h because it exists even when MFC is not 
3210         installed, and is all that's needed here.
3211
3212         * FindSafari/FindSafari.rc: Ditto
3213
3214 2009-10-24  Eric Seidel  <eric@webkit.org>
3215
3216         Reviewed by Adam Barth.
3217
3218         bugzilla-tool post-diff should know how to mark commit-queue=?
3219         https://bugs.webkit.org/show_bug.cgi?id=29202
3220
3221         * Scripts/bugzilla-tool:
3222          - Add --commit-queue option to post-diff, post-commits and create-bug.
3223         * Scripts/modules/bugzilla.py:
3224          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3225          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3226
3227 2009-10-23  Eric Seidel  <eric@webkit.org>
3228
3229         Reviewed by Adam Barth.
3230
3231         bugzilla-tool commit-queue does not notice modifications to committers.py
3232         https://bugs.webkit.org/show_bug.cgi?id=30084
3233
3234         * Scripts/bugzilla-tool:
3235          - Make commit-queue re-exec itself instead of using while(1).
3236          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3237          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3238
3239 2009-10-22  Eric Seidel  <eric@webkit.org>
3240
3241         Reviewed by Adam Barth.
3242
3243         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3244         https://bugs.webkit.org/show_bug.cgi?id=30634
3245
3246         * Scripts/bugzilla-tool:
3247          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3248          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3249
3250 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3251
3252         Reviewed by Eric Seidel.
3253
3254         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3255
3256         https://bugs.webkit.org/show_bug.cgi?id=30763
3257
3258         * pywebsocket/mod_pywebsocket/__init__.py:
3259         * pywebsocket/mod_pywebsocket/dispatch.py:
3260         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3261         * pywebsocket/mod_pywebsocket/standalone.py:
3262         * pywebsocket/setup.py:
3263         * pywebsocket/test/test_dispatch.py:
3264
3265 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3266
3267         Reviewed by David Levin.
3268
3269         REGRESSION: 2 failures in run-webkit-unittests
3270         https://bugs.webkit.org/show_bug.cgi?id=30645
3271
3272         * Scripts/modules/cpp_style_unittest.py:
3273         Fixed a few test scenarios which apparently lost some spaces from 
3274         text literals.
3275
3276 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3277
3278         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3279
3280         * Scripts/webkitdirs.pm:
3281
3282 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3283
3284         Reviewed by Darin Adler.
3285
3286         Unification of using null device in perl scripts.
3287         https://bugs.webkit.org/show_bug.cgi?id=30572
3288
3289         * Scripts/VCSUtils.pm:
3290         * Scripts/bisect-builds:
3291         * Scripts/resolve-ChangeLogs:
3292         * Scripts/run-iexploder-tests:
3293         * Scripts/run-jsc:
3294         * Scripts/run-mangleme-tests:
3295         * Scripts/run-webkit-tests:
3296         * Scripts/webkitdirs.pm:
3297         Using File::Spec->devnull() instead of hard coded /dev/null.
3298
3299 2009-10-26  Eric Seidel  <eric@webkit.org>
3300
3301         Reviewed by Holger Freyther.
3302
3303         Reviewers are missing from committers.py
3304         https://bugs.webkit.org/show_bug.cgi?id=30733
3305
3306         * Scripts/modules/committers.py:
3307
3308 2009-10-23  Eric Seidel  <eric@webkit.org>
3309
3310         No review, only adding Alice to the list of reviewers.
3311
3312         * Scripts/modules/committers.py:
3313
3314 2009-10-23  Eric Seidel  <eric@webkit.org>
3315
3316         Reviewed by Eric Carlson.
3317
3318         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3319         https://bugs.webkit.org/show_bug.cgi?id=30700
3320
3321         * DumpRenderTree/mac/DumpRenderTree.mm:
3322         (resetDefaultsToConsistentValues): Update QuickTime version check.
3323
3324 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3325
3326         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3327         character measurement APIs that are private on Tiger.
3328
3329         * wx/build/settings.py:
3330
3331 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3332
3333         Reviewed by NOBODY (build fix).
3334         Build fix following bug #30696.
3335
3336         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3337         (LayoutTestController::evaluateScriptInIsolatedWorld):
3338
3339 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3340
3341         Reviewed by Sam Weinig & Geoff Garen.
3342
3343         https://bugs.webkit.org/show_bug.cgi?id=30696
3344         Enable isolated-worlds tests on mac.
3345
3346         Add private interface for DRT to invoke execution in a given world.
3347
3348         * DumpRenderTree/LayoutTestController.cpp:
3349         (evaluateScriptInIsolatedWorldCallback):
3350         (LayoutTestController::staticFunctions):
3351         * DumpRenderTree/LayoutTestController.h:
3352         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3353         (LayoutTestController::evaluateScriptInIsolatedWorld):
3354         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3355         (LayoutTestController::evaluateScriptInIsolatedWorld):
3356
3357 2009-10-21  Eric Seidel  <eric@webkit.org>
3358
3359         Reviewed by Adam Barth.
3360
3361         bugzilla-tool's "patch failed to download an apply" error should give more information
3362         https://bugs.webkit.org/show_bug.cgi?id=30632
3363
3364         * Scripts/modules/scm.py:
3365          - Use the common run_command method instead of custom POpen code.
3366          - Make run_command know how to take pipes as input.
3367         * Scripts/modules/scm_unittest.py:
3368          - Add new tests to cover change.
3369          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3370
3371 2009-10-21  Kent Tamura  <tkent@chromium.org>
3372
3373         Unreviewed.  Adding myself to the committers list.
3374
3375         * Scripts/modules/committers.py:
3376
3377 2009-10-21  Robin Dunn  <robin@alldunn.com>
3378
3379         Reviewed by Kevin Ollivier.
3380
3381         Update the Windows installer builder to work with Vista / Win 7 and with git.
3382         
3383         https://bugs.webkit.org/show_bug.cgi?id=30649
3384
3385         * wx/build/build_utils.py:
3386         * wx/packaging/build-mac-installer.py:
3387         * wx/packaging/build-win-installer.py:
3388         * wx/packaging/wxWebKitInstaller.iss.in:
3389
3390 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3391
3392         Reviewed by Gustavo Noronha.
3393
3394         [GTK] Added conditional code to avoid using
3395         gdk_window_get_root_coords if we do not have a gtk+ release newer
3396         than 2.17.3.
3397         https://bugs.webkit.org/show_bug.cgi?id=30636
3398
3399         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3400
3401 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3402
3403         Reviewed by Eric Seidel.
3404
3405         [Qt] Added dummy implementation for keepWebHistory()
3406         https://bugs.webkit.org/show_bug.cgi?id=30592
3407
3408         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3409         (LayoutTestController::keepWebHistory):
3410         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3411
3412 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3413
3414         Reviewed by Xan Lopez.
3415
3416         [GTK] Fixed the double click condition, it is not double click if
3417         we move in just in one direction.
3418         https://bugs.webkit.org/show_bug.cgi?id=30636
3419
3420         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3421
3422 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3423
3424         Reviewed by Xan Lopez.
3425
3426         [GTK] Initialize the events completly before emitting them.
3427         https://bugs.webkit.org/show_bug.cgi?id=30633
3428
3429         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3430
3431 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3432
3433         wx build fix. Fix for when linking using --as-needed with gcc.
3434
3435         * wx/browser/wscript:
3436
3437 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3438
3439         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3440         to support all the features used by CURL backend.
3441         
3442         * wx/build/settings.py:
3443         * wx/install-unix-extras:
3444
3445 2009-10-20  Anton Muhin  <antonm@chromium.org>
3446
3447         Reviewed by Adam Barth.
3448
3449         Add {ager,antonm,yurys}@chromium.org into committers.py
3450         https://bugs.webkit.org/show_bug.cgi?id=30560
3451
3452         * Scripts/modules/committers.py:
3453
3454 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3455
3456         Reviewed by Tor Arne Vestbø.
3457
3458         Make the Netscape Test plugin available to the Qt launcher.
3459
3460         * Scripts/run-launcher:
3461
3462 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3463
3464         Reviewed by David Levin.
3465
3466         Removed WebSocket runtime settings.
3467         https://bugs.webkit.org/show_bug.cgi?id=29896
3468
3469         WebSocket runtime configuration is supported by chromium/v8 only.
3470
3471         * DumpRenderTree/mac/DumpRenderTree.mm:
3472         (resetDefaultsToConsistentValues):
3473         * DumpRenderTree/win/DumpRenderTree.cpp:
3474         (resetDefaultsToConsistentValues):
3475
3476 2009-10-19  Nate Chapin  <japhet@chromium.org>
3477
3478         Reviewed by Adam Barth.
3479
3480         Add testFail() to test plugin so we can test our handling of a
3481         plugin invoke call returning false.
3482
3483         https://bugs.webkit.org/show_bug.cgi?id=30239
3484
3485         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3486         (pluginInvoke):
3487         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3488
3489 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3490
3491         Reviewed by Gustavo Noronha.
3492
3493         Enable DOM pasting when running layout tests.
3494
3495         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3496         (resetDefaultsToConsistentValues):
3497
3498 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3499
3500         Reviewed by Simon Hausmann.
3501
3502         Use the setPreferredContentsSize method instead
3503         of setFixedContentsSize, as the method has been renamed.
3504
3505         * DumpRenderTree/qt/DumpRenderTree.cpp:
3506         (WebCore::DumpRenderTree::open):
3507         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3508         (LayoutTestController::setFixedContentsSize):
3509
3510 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3511
3512         Reviewed by Dan Bernstein.
3513
3514         https://bugs.webkit.org/show_bug.cgi?id=30456
3515         Fixes for new Debug_All Windows build configuration.
3516
3517         * DumpRenderTree/win/DumpRenderTree.cpp:
3518         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3519         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3520
3521 2009-10-16  Eric Seidel  <eric@webkit.org>
3522
3523         Reviewed by Adam Barth.
3524
3525         commit-queue status bot should list which buildbot is blocking the queue
3526         https://bugs.webkit.org/show_bug.cgi?id=30452
3527
3528         Add new methods and testing.
3529
3530         * Scripts/bugzilla-tool:
3531         * Scripts/modules/buildbot.py:
3532         * Scripts/modules/buildbot_unittest.py:
3533
3534 2009-10-16  Eric Seidel  <eric@webkit.org>
3535
3536         Reviewed by Adam Barth.
3537
3538         run-webkit-tests fails when CWD is not inside a WebKit checkout
3539         https://bugs.webkit.org/show_bug.cgi?id=30451
3540
3541         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3542         * Scripts/modules/scm_unittest.py:
3543           - Remove use of original_path (we don't need to restore the CWD).
3544           - Don't use '.' to find the webkit checkout, use __file__ instead.
3545
3546 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3547
3548         Reviewed by Adam Roben.
3549
3550         Add a Debug_All configuration to build entire stack as debug.
3551         Change Debug_Internal to:
3552         - stop using _debug suffix for all WebKit/Safari binaries
3553         - not use _debug as a DLL naming suffix
3554         - use non-debug C runtime lib.
3555
3556         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3557         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3558         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3559         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3560         Add missing debug.vsprops inherited property sheet.
3561         Add Debug_All configuration.
3562         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3563         * WinLauncher/WinLauncher.vcproj:
3564         Removed extraneous definitions inherited from vsprops.
3565         Add Debug_All configuration.
3566
3567 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3568
3569         Reviewed by David Levin.
3570
3571         check-webkit-style is wrong about indent checking in namespaces
3572         in header files and a few other things
3573         https://bugs.webkit.org/show_bug.cgi?id=30362
3574
3575         The few other things include:
3576         + check-webkit-style does not require spaces around the equal sign
3577           inside 'if' statements and around binary operators that take 
3578           numeric literals.
3579         + check-webkit-style reports false errors for the / operator
3580           when part of a filename in the #include directive.
3581
3582         * Scripts/modules/cpp_style.py:
3583         Improved indentation checking and space checking around
3584         binary operators. While the checks are still not perfect,
3585         they are clearly better than before.
3586         * Scripts/modules/cpp_style_unittest.py:
3587         Added test cases for the newly supported checks and modified old
3588         test cases to match the new guidelines
3589
3590 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3591
3592         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3593
3594         * wx/build/settings.py:
3595
3596 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3597
3598         Reviewed by David Levin.
3599
3600         Add mod_pywebsocket to test Web Sockets.
3601         http://code.google.com/p/pywebsocket/
3602         https://bugs.webkit.org/show_bug.cgi?id=27490
3603
3604         * pywebsocket/COPYING: Added.
3605         * pywebsocket/MANIFEST.in: Added.
3606         * pywebsocket/README: Added.
3607         * pywebsocket/example/echo_client.py: Added.
3608         * pywebsocket/example/echo_wsh.py: Added.
3609         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3610         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3611         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3612         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3613         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3614         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3615         * pywebsocket/mod_pywebsocket/util.py: Added.
3616         * pywebsocket/setup.py: Added.
3617         * pywebsocket/test/config.py: Added.
3618         * pywebsocket/test/mock.py: Added.
3619         * pywebsocket/test/run_all.py: Added.
3620         * pywebsocket/test/test_dispatch.py: Added.
3621         * pywebsocket/test/test_handshake.py: Added.
3622         * pywebsocket/test/test_mock.py: Added.
3623         * pywebsocket/test/test_msgutil.py: Added.
3624         * pywebsocket/test/test_util.py: Added.
3625         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3626         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3627         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3628         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3629         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3630         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3631         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3632         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3633
3634 2009-10-15  James Robinson  <jamesr@google.com>
3635
3636         Reviewed by David Levin.
3637
3638         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3639
3640         https://bugs.webkit.org/show_bug.cgi?id=30426
3641
3642         * Scripts/modules/cpp_style.py:
3643         * Scripts/modules/cpp_style_unittest.py:
3644
3645 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3646
3647         Reviewed by Adam Roben.
3648
3649         Fixes <http://webkit.org/b/30411>.
3650         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3651         
3652         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3653         building Chromium.
3654
3655         * Scripts/pdevenv:
3656
3657 2009-10-15  Robin Dunn  <robin@alldunn.com>
3658
3659         Reviewed by Kevin Ollivier.
3660
3661         Add Mac package building scripts for wx.
3662         
3663         https://bugs.webkit.org/show_bug.cgi?id=30405
3664
3665         * wx/build/build_utils.py:
3666         * wx/build/settings.py:
3667         * wx/packaging/build-mac-installer.py: Added.
3668
3669 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3670
3671         Reviewed by Gustavo Noronha.
3672
3673         Enable Web Sockets support when running layout tests.
3674
3675         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3676         (resetDefaultsToConsistentValues):
3677
3678 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3679
3680         Reviewed by Gustavo Noronha.
3681
3682         Need to initialize event.button.button, since in most cases a
3683         button number is not passed as an argument.
3684
3685         * DumpRenderTree/gtk/EventSender.cpp:
3686         (mouseDownCallback):
3687         (mouseUpCallback):
3688
3689 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3690
3691         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3692         the OS if none was explicitly set.
3693
3694         * wx/build/settings.py:
3695
3696 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3697
3698         Reviewed by Timothy Hatcher.
3699
3700         Web Inspector: enable developers extras within inspector layout tests.
3701
3702         https://bugs.webkit.org/show_bug.cgi?id=30014
3703
3704         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3705         (LayoutTestController::showWebInspector):
3706         (LayoutTestController::closeWebInspector):
3707         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3708         (LayoutTestController::showWebInspector):
3709         (LayoutTestController::closeWebInspector):
3710
3711 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3712
3713         Reviewed by Jan Alonzo.
3714
3715         GtkLauncher is using a deprecated signal
3716         https://bugs.webkit.org/show_bug.cgi?id=30364
3717
3718         Modified GtkLauncher to use notify::title signal instead of
3719         deprecated title-changed signal
3720
3721         * GtkLauncher/main.c:
3722         (notify_title_cb):
3723         (create_browser):
3724
3725 2009-10-14  Brady Eidson  <beidson@apple.com>
3726
3727         Reviewed by Sam Weinig.
3728
3729         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3730         1 - Disables WebHistory
3731         2 - Doesn't make sense in that context anyway.
3732
3733         * DumpRenderTree/win/DumpRenderTree.cpp:
3734         (createWebViewAndOffscreenWindow):
3735
3736 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3737
3738         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3739         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3740
3741         * wx/build/settings.py:
3742         * wx/install-unix-extras:
3743
3744 2009-10-14  Brady Eidson  <beidson@apple.com>
3745
3746         Reviewed by Sam Weinig.
3747
3748         WebKit Win API should provide a delegate interface for global history.
3749         https://bugs.webkit.org/show_bug.cgi?id=29905
3750
3751         * DumpRenderTree/LayoutTestController.cpp:
3752         (LayoutTestController::LayoutTestController):
3753         * DumpRenderTree/LayoutTestController.h:
3754         (LayoutTestController::dumpHistoryDelegateCallbacks):
3755         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3756                 
3757         * DumpRenderTree/win/DumpRenderTree.cpp:
3758         (shouldLogHistoryDelegates):
3759         (runTest):
3760         (createWebViewAndOffscreenWindow):
3761         (main):
3762         * DumpRenderTree/win/DumpRenderTree.vcproj:
3763         
3764         Add the IWebHistoryDelegate to DRT Windows:
3765         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3766         (wstringFromBSTR):
3767         (HistoryDelegate::HistoryDelegate):
3768         (HistoryDelegate::~HistoryDelegate):
3769         (HistoryDelegate::QueryInterface):
3770         (HistoryDelegate::AddRef):
3771         (HistoryDelegate::Release):
3772         (HistoryDelegate::didNavigateWithNavigationData):
3773         (HistoryDelegate::didPerformClientRedirectFromURL):
3774         (HistoryDelegate::didPerformServerRedirectFromURL):
3775         (HistoryDelegate::updateHistoryTitle):
3776         (HistoryDelegate::populateVisitedLinksForWebView):
3777         * DumpRenderTree/win/HistoryDelegate.h: Added.
3778
3779         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3780         (LayoutTestController::removeAllVisitedLinks):
3781
3782 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3783
3784         Reviewed by Simon Hausmann.
3785
3786         [Qt] Implement support for setPOSIXLocale on Qt.
3787         https://bugs.webkit.org/show_bug.cgi?id=30268 
3788  
3789         * DumpRenderTree/qt/DumpRenderTree.cpp:
3790         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3791         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3792         (LayoutTestController::setPOSIXLocale):
3793         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3794
3795 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3796
3797         Unreviewed, adding myself to reviewers list.
3798
3799         * Scripts/modules/committers.py:
3800
3801 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3802
3803         Reviewed by Mark Rowe.
3804
3805         Fix null assignment so root tests work again.
3806
3807         * Scripts/webkitdirs.pm:
3808
3809 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3810
3811         Reviewed by Simon Hausmann.
3812
3813         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3814         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3815         This is done in preparation of implementing missing features in DRT.
3816         No functionality changes made yet.
3817
3818         * DumpRenderTree/qt/DumpRenderTree.cpp:
3819         * DumpRenderTree/qt/DumpRenderTree.pro:
3820         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3821         (EventSender::EventSender):
3822         (EventSender::mouseDown):
3823         (EventSender::mouseUp):
3824         (EventSender::mouseMoveTo):
3825         (EventSender::leapForward):
3826         (EventSender::keyDown):
3827         (EventSender::contextClick):
3828         (EventSender::scheduleAsynchronousClick):
3829         (EventSender::frameUnderMouse):
3830         * DumpRenderTree/qt/EventSenderQt.h: Added.
3831         (EventSender::clearKillRing):
3832         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3833         (LayoutTestController::LayoutTestController):
3834         (LayoutTestController::reset):
3835         (LayoutTestController::processWork):
3836         (LayoutTestController::maybeDump):
3837         (LayoutTestController::waitUntilDone):
3838         (LayoutTestController::notifyDone):
3839         (LayoutTestController::windowCount):
3840         (LayoutTestController::clearBackForwardList):
3841         (LayoutTestController::dumpEditingCallbacks):
3842         (LayoutTestController::dumpResourceLoadCallbacks):
3843         (LayoutTestController::queueBackNavigation):
3844         (LayoutTestController::queueForwardNavigation):
3845         (LayoutTestController::queueLoad):
3846         (LayoutTestController::queueReload):
3847         (LayoutTestController::queueScript):
3848         (LayoutTestController::provisionalLoad):
3849         (LayoutTestController::timerEvent):
3850         (LayoutTestController::encodeHostName):
3851         (LayoutTestController::decodeHostName):
3852         (LayoutTestController::setJavaScriptProfilingEnabled):
3853         (LayoutTestController::setFixedContentsSize):
3854         (LayoutTestController::setPrivateBrowsingEnabled):
3855         (LayoutTestController::setPopupBlockingEnabled):
3856         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3857         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3858         (LayoutTestController::numberOfActiveAnimations):
3859         (LayoutTestController::disableImageLoading):
3860         (LayoutTestController::dispatchPendingLoadRequests):
3861         (LayoutTestController::setDatabaseQuota):
3862         (LayoutTestController::clearAllDatabases):
3863         (LayoutTestController::whiteListAccessFromOrigin):
3864         (LayoutTestController::waitForPolicyDelegate):
3865         (LayoutTestController::overridePreference):
3866         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3867         (LayoutTestController::isLoading):
3868         (LayoutTestController::setLoading):
3869         (LayoutTestController::shouldDumpAsText):
3870         (LayoutTestController::shouldDumpBackForwardList):
3871         (LayoutTestController::shouldDumpChildrenAsText):
3872         (LayoutTestController::shouldDumpDatabaseCallbacks):
3873         (LayoutTestController::shouldDumpStatusCallbacks):
3874         (LayoutTestController::shouldWaitUntilDone):
3875         (LayoutTestController::canOpenWindows):
3876         (LayoutTestController::shouldDumpTitleChanges):
3877         (LayoutTestController::waitForPolicy):
3878         (LayoutTestController::dumpAsText):
3879         (LayoutTestController::dumpChildFramesAsText):
3880         (LayoutTestController::dumpDatabaseCallbacks):
3881         (LayoutTestController::dumpStatusCallbacks):
3882         (LayoutTestController::setCanOpenWindows):
3883         (LayoutTestController::dumpBackForwardList):
3884         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3885         (LayoutTestController::display):
3886         (LayoutTestController::dumpTitleChanges):
3887         (LayoutTestController::dumpSelectionRect):
3888         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3889         (TextInputController::TextInputController):
3890         (TextInputController::doCommand):
3891         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3892         * DumpRenderTree/qt/WorkQueue.cpp:
3893         * DumpRenderTree/qt/WorkQueue.h:
3894         * DumpRenderTree/qt/WorkQueueItem.h:
3895         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3896         (findFrameNamed):
3897         (LoadItem::invoke):
3898         (ReloadItem::invoke):
3899         (ScriptItem::invoke):
3900         (BackForwardItem::invoke):
3901         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3902         * DumpRenderTree/qt/jsobjects.h:
3903
3904 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3905
3906         Not reviewed, adding myself to the list of reviewers.
3907
3908         * Scripts/modules/committers.py:
3909
3910 2009-10-13  Anders Carlsson  <andersca@apple.com>
3911
3912         Reviewed by Sam Weinig.
3913
3914         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3915
3916         Make the private browsing mode testable by the test plug-in.
3917         
3918         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3919         (pluginGetProperty):
3920         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3921         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3922         (NPP_New):
3923         (NPP_SetValue):
3924
3925 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3926
3927         No review, just adding self to the list of reviewers.
3928
3929         * Scripts/modules/committers.py:
3930
3931 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3932
3933         Reviewed by Adam Roben.
3934
3935         Web Inspector: Use proper web view in inspector layout
3936         tests for windows.
3937
3938         https://bugs.webkit.org/show_bug.cgi?id=30298
3939
3940         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3941         (LayoutTestController::showWebInspector):
3942         (LayoutTestController::closeWebInspector):
3943         (LayoutTestController::evaluateInWebInspector):
3944
3945 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3946
3947         Reviewed by Sam Weinig.
3948
3949         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3950         https://bugs.webkit.org/show_bug.cgi?id=29841
3951
3952         * DumpRenderTree/mac/DumpRenderTree.mm:
3953         (resetDefaultsToConsistentValues):
3954         * DumpRenderTree/win/DumpRenderTree.cpp:
3955         (resetDefaultsToConsistentValues):
3956
3957 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3958
3959         Reviewed by Dimitri Glazkov.
3960
3961         Chromium Port - Windows
3962         https://bugs.webkit.org/show_bug.cgi?id=29969
3963
3964         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3965         * Scripts/webkitdirs.pm:
3966
3967 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3968
3969         Reviewed by Darin Adler.
3970
3971         jsc scripts cleanup and Qt/GTK fix
3972         https://bugs.webkit.org/show_bug.cgi?id=30288
3973
3974         Duplicated jscPath() moved to webkitdirs.pm.
3975         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3976         Configuration added (release/debug) to path for Qt-port on Windows.
3977
3978         * Scripts/run-javascriptcore-tests:
3979         * Scripts/run-jsc:
3980         * Scripts/run-sunspider:
3981         * Scripts/sunspider-compare-results:
3982         * Scripts/webkitdirs.pm:
3983
3984 2009-10-11  Adam Barth  <abarth@webkit.org>
3985
3986         Unreviewed.  Add Collin to committers.py.
3987
3988         * Scripts/modules/committers.py:
3989
3990 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3991
3992         wx build fix, add bindings to source/include dirs now that there are sources there.
3993
3994         * wx/build/settings.py:
3995
3996 2009-10-09  Mark Rowe  <mrowe@apple.com>
3997
3998         Reviewed by Brady Eidson.
3999
4000         Enable plug-in halting in DumpRenderTree.
4001
4002         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
4003         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
4004
4005         * DumpRenderTree/mac/DumpRenderTree.mm:
4006         (resetDefaultsToConsistentValues):
4007         * DumpRenderTree/mac/UIDelegate.mm:
4008         (-[UIDelegate webView:shouldHaltPlugin:]):
4009
4010 2009-10-08  Brady Eidson  <beidson@apple.com>
4011
4012         Reviewed by Dan Bernstein.
4013
4014         Ask the History Delegate to populate the visited links hash.
4015         <rdar://problem/7285293> and https://webkit.org/b/29904
4016
4017         Add the ability for LayoutTestController to clear all visited links.
4018         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
4019
4020         * DumpRenderTree/LayoutTestController.cpp:
4021         (LayoutTestController::LayoutTestController):
4022         (removeAllVisitedLinksCallback):
4023         (LayoutTestController::staticFunctions):
4024         * DumpRenderTree/LayoutTestController.h:
4025         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4026         (LayoutTestController::removeAllVisitedLinks):
4027
4028         * DumpRenderTree/mac/HistoryDelegate.mm:
4029         (-[HistoryDelegate populateVisitedLinksForWebView:]):
4030
4031         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4032         (LayoutTestController::removeAllVisitedLinks):
4033         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4034         (LayoutTestController::removeAllVisitedLinks):
4035         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4036         (LayoutTestController::removeAllVisitedLinks):
4037
4038
4039 2009-10-08  Daniel Bates  <dbates@webkit.org>
4040
4041         Reviewed by Adam Roben.
4042
4043         https://bugs.webkit.org/show_bug.cgi?id=30175
4044         
4045         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
4046         the OLE drag-and-drop return value like the function it emulates. Currently, 
4047         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
4048         whether the drag-and-drop operation was successful or was cancelled.
4049         
4050         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
4051         return value according to whether the drop operation was successful or not.
4052
4053         * DumpRenderTree/win/EventSender.cpp:
4054         (doMouseUp): Added parameter oleDragAndDropReturnValue.
4055         (replaySavedEvents): Ditto.
4056         * DumpRenderTree/win/EventSender.h:
4057         * DumpRenderTree/win/UIDelegate.cpp:
4058         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
4059
4060 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
4061
4062         Reviewed by Xan Lopez.
4063
4064         [GTK] Added support for a parameter setting the button that was
4065         pressed in the mouseDown function.
4066         https://bugs.webkit.org/show_bug.cgi?id=30220
4067
4068         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4069
4070 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
4071
4072         Reviewed by Xan Lopez.
4073
4074         [GTK] Added a line to the bottom of the expected result to match
4075         the output of the test.
4076         https://bugs.webkit.org/show_bug.cgi?id=30220
4077
4078         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
4079         expected.txt:
4080
4081 2009-10-08  Adam Roben  <aroben@apple.com>
4082
4083         Use QueryInterface to get IWebInspectorPrivate
4084
4085         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
4086         accessed in a more standard way
4087
4088         Reviewed by John Sullivan and Tim Hatcher.
4089
4090         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4091         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
4092         by calling IWebViewPrivate::inspector, then use QueryInterface to get
4093         to the IWebInspectorPrivate interface.
4094
4095 2009-10-07  Adam Roben  <aroben@apple.com>
4096
4097         Implement DRT support for origin whitelisting
4098
4099         Fixes <http://webkit.org/b/30185>.
4100
4101         Reviewed by Eric Seidel.
4102
4103         * DumpRenderTree/win/DumpRenderTree.cpp:
4104         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
4105         whitelist, to match Mac DRT.
4106         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4107         (LayoutTestController::whiteListAccessFromOrigin): Call through to
4108         IWebViewPrivate::whiteListAccessFromOrigin.
4109
4110 2009-10-07  Brady Eidson  <beidson@apple.com>
4111
4112         Reviewed by Darin Adler.
4113
4114         Send title changes to the global history delegate.
4115         <rdar://problem/7285293> and https://webkit.org/b/29904
4116
4117         * DumpRenderTree/mac/HistoryDelegate.mm:
4118         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
4119
4120 2009-10-07  Adam Barth  <abarth@webkit.org>
4121
4122         Unreviewed.  Remove some folks from committers.py who were listed on
4123         the WebKit Team wiki page but who weren't actually listed as commit+.
4124         At some point, we should coorelate this list with the committers
4125         mailing list.
4126
4127         * Scripts/modules/committers.py:
4128
4129 2009-10-07  Adam Barth  <abarth@webkit.org>
4130
4131         Unreviewed.  Import a bunch of committers from the WebKit Team page on
4132         the wiki into committers.py.
4133
4134         * Scripts/modules/committers.py:
4135
4136 2009-10-07  Adam Barth  <abarth@webkit.org>
4137
4138         Unreviewed.  Added Aaron Boodman to committers.py.
4139
4140         * Scripts/modules/committers.py:
4141
4142 2009-10-07  Evan Martin  <evan@chromium.org>
4143
4144         Reviewed by Darin Adler.
4145
4146         Add API to LayoutTestController for re/setting the system locale.
4147         https://bugs.webkit.org/show_bug.cgi?id=18994
4148
4149         * DumpRenderTree/LayoutTestController.cpp:
4150         (setLocaleCallback):
4151         (LayoutTestController::staticFunctions):
4152         (LayoutTestController::setLocale):
4153         * DumpRenderTree/LayoutTestController.h:
4154
4155 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
4156
4157         Reviewed by Jan Alonzo.
4158
4159         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
4160         https://bugs.webkit.org/show_bug.cgi?id=29689
4161
4162         Build fix by adding -lfontconfig for DumpRenderTree.
4163
4164         * GNUmakefile.am:
4165
4166 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4167
4168         Reviewed by Simon Hausmann.
4169
4170         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
4171
4172         * Scripts/run-webkit-tests:
4173
4174 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4175
4176         Reviewed by Gustavo Noronha.
4177
4178         "delete" in EventSender is the backspace key, not the delete one.
4179
4180         * DumpRenderTree/gtk/EventSender.cpp:
4181         (keyDownCallback):
4182
4183 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4184
4185         Reviewed by Gustavo Noronha.
4186
4187         getChildrenWithRange expects as last parameter the end index, not
4188         the length of the range. Correct this and clarify the variable
4189         names to reflect how the code works.
4190
4191         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4192         (AccessibilityUIElement::getChildrenWithRange):
4193         (AccessibilityUIElement::getChildAtIndex):
4194
4195 2009-10-06  Mark Rowe  <mrowe@apple.com>
4196
4197         Reviewed by Simon Fraser.
4198
4199         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
4200
4201         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
4202         the fact we have already changed the working directory to the top of the open source tree.
4203
4204 2009-10-06  Julie Parent  <jparent@chromium.org>
4205
4206         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
4207         rather than my committer email.
4208
4209         * Scripts/modules/committers.py:
4210
4211 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4212
4213         Reviewed by Eric Seidel.
4214
4215         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
4216
4217         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
4218         it after each layout test as it should do, making the DRT dump additional output
4219         for all of the subsequent layout tests.
4220
4221         * DumpRenderTree/qt/jsobjects.cpp:
4222         (LayoutTestController::reset):
4223
4224 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4225
4226         Reviewed by Simon Hausmann.
4227
4228         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
4229         fast/dom/assign-to-window-status.html test, which is passing as a result.
4230
4231         https://bugs.webkit.org/show_bug.cgi?id=30127
4232
4233         * DumpRenderTree/qt/DumpRenderTree.cpp:
4234         (WebCore::DumpRenderTree::DumpRenderTree):
4235         (WebCore::DumpRenderTree::statusBarMessage):
4236         * DumpRenderTree/qt/DumpRenderTree.h:
4237         * DumpRenderTree/qt/jsobjects.h:
4238         (LayoutTestController::shouldDumpStatusCallbacks):
4239         (LayoutTestController::dumpStatusCallbacks):
4240
4241 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4242
4243         Reviewed by Simon Hausmann.
4244
4245         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
4246         ignores the argument indicating which mouse button to trigger.
4247         https://bugs.webkit.org/show_bug.cgi?id=30048
4248
4249         This affects the fast/events/mouse-click-events.html layout test.
4250
4251         * DumpRenderTree/qt/jsobjects.cpp:
4252         (EventSender::mouseDown):
4253         (EventSender::mouseUp):
4254         * DumpRenderTree/qt/jsobjects.h:
4255
4256 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4257
4258         Reviewed by Simon Hausmann.
4259
4260         [Qt] Fix the EventSender::keyDown() implementation
4261         https://bugs.webkit.org/show_bug.cgi?id=30043
4262
4263         It should post both a key press event and a key release event,
4264         just like other ports do.
4265
4266         * DumpRenderTree/qt/jsobjects.cpp:
4267         (EventSender::keyDown):
4268
4269 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
4270
4271         wx build fix. Add jpeg to the list of libs to link against.
4272
4273         * wx/build/settings.py:
4274
4275 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
4276
4277         Reviewed by Simon Hausmann.
4278
4279         [Qt] EventSender::keyDown() cannot send function-key events.
4280         https://bugs.webkit.org/show_bug.cgi?id=30044
4281
4282         This affects the fast/events/keydown-function-keys.html layout test.
4283
4284         * DumpRenderTree/qt/jsobjects.cpp:
4285         (EventSender::keyDown):
4286
4287 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
4288
4289         Added --wx-compiler-prefix waf option to allow building wxWebKit with
4290         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
4291
4292         * wx/build/settings.py:
4293         * wx/build/wxpresets.py:
4294
4295 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
4296
4297         Reviewed by Timothy Hatcher.
4298
4299         Web Inspector: add testing harness for Web Inspector.
4300
4301         https://bugs.webkit.org/show_bug.cgi?id=30010
4302
4303         * DumpRenderTree/LayoutTestController.cpp:
4304         (showWebInspectorCallback):
4305         (closeWebInspectorCallback):
4306         (evaluateInWebInspectorCallback):
4307         (LayoutTestController::staticFunctions):
4308         * DumpRenderTree/LayoutTestController.h:
4309         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4310         (LayoutTestController::showWebInspector):
4311         (LayoutTestController::closeWebInspector):
4312         (LayoutTestController::evaluateInWebInspector):
4313         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4314         (LayoutTestController::showWebInspector):
4315         (LayoutTestController::closeWebInspector):
4316         (LayoutTestController::evaluateInWebInspector):
4317         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4318         (LayoutTestController::showWebInspector):
4319         (LayoutTestController::closeWebInspector):
4320         (LayoutTestController::evaluateInWebInspector):
4321         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4322         (LayoutTestController::showWebInspector):
4323         (LayoutTestController::closeWebInspector):
4324         (LayoutTestController::evaluateInWebInspector):
4325
4326 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4327
4328         Reviewed by Ariyha Hidayat.
4329
4330         Pass arguments to system() as a string instead of array
4331
4332         When passed as an array entries with a space fail to translate
4333         to two arguments to the child process, so instead of manually
4334         splitting all the entries in @buildArgs we pass the whole thing
4335         as a string instead.
4336
4337         * Scripts/webkitdirs.pm:
4338
4339 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
4340
4341         Reviewed by David Levin.
4342
4343         check-webkit-style misses whitespace errors for operators:
4344         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
4345         https://bugs.webkit.org/show_bug.cgi?id=30021
4346
4347         * Scripts/modules/cpp_style.py:
4348         Added the operators mentioned above to the same list as == and !=.
4349
4350 2009-10-02  Julie Parent  <jparent@chromium.org>
4351
4352         Unreviewed.
4353
4354         Adding myself and Ojan Vafai as committers, because we are committers.
4355
4356         * Scripts/modules/committers.py:
4357
4358 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
4359
4360         Reviewed by Adam Roben.
4361
4362         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
4363         this will help the patch merging process when TryBots are used.
4364