1 2009-10-11 Adam Barth <abarth@webkit.org>
3 Unreviewed. Add Collin to committers.py.
5 * Scripts/modules/committers.py:
7 2009-10-11 Kevin Ollivier <kevino@theolliviers.com>
9 wx build fix, add bindings to source/include dirs now that there are sources there.
11 * wx/build/settings.py:
13 2009-10-09 Mark Rowe <mrowe@apple.com>
15 Reviewed by Brady Eidson.
17 Enable plug-in halting in DumpRenderTree.
19 We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
20 This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
22 * DumpRenderTree/mac/DumpRenderTree.mm:
23 (resetDefaultsToConsistentValues):
24 * DumpRenderTree/mac/UIDelegate.mm:
25 (-[UIDelegate webView:shouldHaltPlugin:]):
27 2009-10-08 Brady Eidson <beidson@apple.com>
29 Reviewed by Dan Bernstein.
31 Ask the History Delegate to populate the visited links hash.
32 <rdar://problem/7285293> and https://webkit.org/b/29904
34 Add the ability for LayoutTestController to clear all visited links.
35 Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
37 * DumpRenderTree/LayoutTestController.cpp:
38 (LayoutTestController::LayoutTestController):
39 (removeAllVisitedLinksCallback):
40 (LayoutTestController::staticFunctions):
41 * DumpRenderTree/LayoutTestController.h:
42 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
43 (LayoutTestController::removeAllVisitedLinks):
45 * DumpRenderTree/mac/HistoryDelegate.mm:
46 (-[HistoryDelegate populateVisitedLinksForWebView:]):
48 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
49 (LayoutTestController::removeAllVisitedLinks):
50 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
51 (LayoutTestController::removeAllVisitedLinks):
52 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
53 (LayoutTestController::removeAllVisitedLinks):
56 2009-10-08 Daniel Bates <dbates@webkit.org>
58 Reviewed by Adam Roben.
60 https://bugs.webkit.org/show_bug.cgi?id=30175
62 The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
63 the OLE drag-and-drop return value like the function it emulates. Currently,
64 UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
65 whether the drag-and-drop operation was successful or was cancelled.
67 This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
68 return value according to whether the drop operation was successful or not.
70 * DumpRenderTree/win/EventSender.cpp:
71 (doMouseUp): Added parameter oleDragAndDropReturnValue.
72 (replaySavedEvents): Ditto.
73 * DumpRenderTree/win/EventSender.h:
74 * DumpRenderTree/win/UIDelegate.cpp:
75 (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
77 2009-10-08 Alejandro G. Castro <alex@igalia.com>
79 Reviewed by Xan Lopez.
81 [GTK] Added support for a parameter setting the button that was
82 pressed in the mouseDown function.
83 https://bugs.webkit.org/show_bug.cgi?id=30220
85 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
87 2009-10-08 Alejandro G. Castro <alex@igalia.com>
89 Reviewed by Xan Lopez.
91 [GTK] Added a line to the bottom of the expected result to match
92 the output of the test.
93 https://bugs.webkit.org/show_bug.cgi?id=30220
95 * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
98 2009-10-08 Adam Roben <aroben@apple.com>
100 Use QueryInterface to get IWebInspectorPrivate
102 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
103 accessed in a more standard way
105 Reviewed by John Sullivan and Tim Hatcher.
107 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
108 (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
109 by calling IWebViewPrivate::inspector, then use QueryInterface to get
110 to the IWebInspectorPrivate interface.
112 2009-10-07 Adam Roben <aroben@apple.com>
114 Implement DRT support for origin whitelisting
116 Fixes <http://webkit.org/b/30185>.
118 Reviewed by Eric Seidel.
120 * DumpRenderTree/win/DumpRenderTree.cpp:
121 (resetWebViewToConsistentStateBeforeTesting): Reset any origin
122 whitelist, to match Mac DRT.
123 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
124 (LayoutTestController::whiteListAccessFromOrigin): Call through to
125 IWebViewPrivate::whiteListAccessFromOrigin.
127 2009-10-07 Brady Eidson <beidson@apple.com>
129 Reviewed by Darin Adler.
131 Send title changes to the global history delegate.
132 <rdar://problem/7285293> and https://webkit.org/b/29904
134 * DumpRenderTree/mac/HistoryDelegate.mm:
135 (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
137 2009-10-07 Adam Barth <abarth@webkit.org>
139 Unreviewed. Remove some folks from committers.py who were listed on
140 the WebKit Team wiki page but who weren't actually listed as commit+.
141 At some point, we should coorelate this list with the committers
144 * Scripts/modules/committers.py:
146 2009-10-07 Adam Barth <abarth@webkit.org>
148 Unreviewed. Import a bunch of committers from the WebKit Team page on
149 the wiki into committers.py.
151 * Scripts/modules/committers.py:
153 2009-10-07 Adam Barth <abarth@webkit.org>
155 Unreviewed. Added Aaron Boodman to committers.py.
157 * Scripts/modules/committers.py:
159 2009-10-07 Evan Martin <evan@chromium.org>
161 Reviewed by Darin Adler.
163 Add API to LayoutTestController for re/setting the system locale.
164 https://bugs.webkit.org/show_bug.cgi?id=18994
166 * DumpRenderTree/LayoutTestController.cpp:
168 (LayoutTestController::staticFunctions):
169 (LayoutTestController::setLocale):
170 * DumpRenderTree/LayoutTestController.h:
172 2009-10-06 Shinichiro Hamaji <hamaji@chromium.org>
174 Reviewed by Jan Alonzo.
176 [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
177 https://bugs.webkit.org/show_bug.cgi?id=29689
179 Build fix by adding -lfontconfig for DumpRenderTree.
183 2009-10-07 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
185 Reviewed by Simon Hausmann.
187 Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
189 * Scripts/run-webkit-tests:
191 2009-10-07 Xan Lopez <xlopez@igalia.com>
193 Reviewed by Gustavo Noronha.
195 "delete" in EventSender is the backspace key, not the delete one.
197 * DumpRenderTree/gtk/EventSender.cpp:
200 2009-10-07 Xan Lopez <xlopez@igalia.com>
202 Reviewed by Gustavo Noronha.
204 getChildrenWithRange expects as last parameter the end index, not
205 the length of the range. Correct this and clarify the variable
206 names to reflect how the code works.
208 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
209 (AccessibilityUIElement::getChildrenWithRange):
210 (AccessibilityUIElement::getChildAtIndex):
212 2009-10-06 Mark Rowe <mrowe@apple.com>
214 Reviewed by Simon Fraser.
216 <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
218 * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
219 the fact we have already changed the working directory to the top of the open source tree.
221 2009-10-06 Julie Parent <jparent@chromium.org>
223 Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
224 rather than my committer email.
226 * Scripts/modules/committers.py:
228 2009-10-06 Jakub Wieczorek <faw217@gmail.com>
230 Reviewed by Eric Seidel.
232 [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
234 r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
235 it after each layout test as it should do, making the DRT dump additional output
236 for all of the subsequent layout tests.
238 * DumpRenderTree/qt/jsobjects.cpp:
239 (LayoutTestController::reset):
241 2009-10-06 Jakub Wieczorek <faw217@gmail.com>
243 Reviewed by Simon Hausmann.
245 [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
246 fast/dom/assign-to-window-status.html test, which is passing as a result.
248 https://bugs.webkit.org/show_bug.cgi?id=30127
250 * DumpRenderTree/qt/DumpRenderTree.cpp:
251 (WebCore::DumpRenderTree::DumpRenderTree):
252 (WebCore::DumpRenderTree::statusBarMessage):
253 * DumpRenderTree/qt/DumpRenderTree.h:
254 * DumpRenderTree/qt/jsobjects.h:
255 (LayoutTestController::shouldDumpStatusCallbacks):
256 (LayoutTestController::dumpStatusCallbacks):
258 2009-10-06 Jakub Wieczorek <faw217@gmail.com>
260 Reviewed by Simon Hausmann.
262 [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
263 ignores the argument indicating which mouse button to trigger.
264 https://bugs.webkit.org/show_bug.cgi?id=30048
266 This affects the fast/events/mouse-click-events.html layout test.
268 * DumpRenderTree/qt/jsobjects.cpp:
269 (EventSender::mouseDown):
270 (EventSender::mouseUp):
271 * DumpRenderTree/qt/jsobjects.h:
273 2009-10-06 Jakub Wieczorek <faw217@gmail.com>
275 Reviewed by Simon Hausmann.
277 [Qt] Fix the EventSender::keyDown() implementation
278 https://bugs.webkit.org/show_bug.cgi?id=30043
280 It should post both a key press event and a key release event,
281 just like other ports do.
283 * DumpRenderTree/qt/jsobjects.cpp:
284 (EventSender::keyDown):
286 2009-10-05 Kevin Ollivier <kevino@theolliviers.com>
288 wx build fix. Add jpeg to the list of libs to link against.
290 * wx/build/settings.py:
292 2009-10-05 Jakub Wieczorek <faw217@gmail.com>
294 Reviewed by Simon Hausmann.
296 [Qt] EventSender::keyDown() cannot send function-key events.
297 https://bugs.webkit.org/show_bug.cgi?id=30044
299 This affects the fast/events/keydown-function-keys.html layout test.
301 * DumpRenderTree/qt/jsobjects.cpp:
302 (EventSender::keyDown):
304 2009-10-05 Vadim Zeitlin <vadim@wxwidgets.org>
306 Added --wx-compiler-prefix waf option to allow building wxWebKit with
307 wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
309 * wx/build/settings.py:
310 * wx/build/wxpresets.py:
312 2009-10-05 Pavel Feldman <pfeldman@chromium.org>
314 Reviewed by Timothy Hatcher.
316 Web Inspector: add testing harness for Web Inspector.
318 https://bugs.webkit.org/show_bug.cgi?id=30010
320 * DumpRenderTree/LayoutTestController.cpp:
321 (showWebInspectorCallback):
322 (closeWebInspectorCallback):
323 (evaluateInWebInspectorCallback):
324 (LayoutTestController::staticFunctions):
325 * DumpRenderTree/LayoutTestController.h:
326 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
327 (LayoutTestController::showWebInspector):
328 (LayoutTestController::closeWebInspector):
329 (LayoutTestController::evaluateInWebInspector):
330 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
331 (LayoutTestController::showWebInspector):
332 (LayoutTestController::closeWebInspector):
333 (LayoutTestController::evaluateInWebInspector):
334 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
335 (LayoutTestController::showWebInspector):
336 (LayoutTestController::closeWebInspector):
337 (LayoutTestController::evaluateInWebInspector):
338 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
339 (LayoutTestController::showWebInspector):
340 (LayoutTestController::closeWebInspector):
341 (LayoutTestController::evaluateInWebInspector):
343 2009-10-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
345 Reviewed by Ariyha Hidayat.
347 Pass arguments to system() as a string instead of array
349 When passed as an array entries with a space fail to translate
350 to two arguments to the child process, so instead of manually
351 splitting all the entries in @buildArgs we pass the whole thing
354 * Scripts/webkitdirs.pm:
356 2009-10-04 Carol Szabo <carol.szabo@nokia.com>
358 Reviewed by David Levin.
360 check-webkit-style misses whitespace errors for operators:
361 <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
362 https://bugs.webkit.org/show_bug.cgi?id=30021
364 * Scripts/modules/cpp_style.py:
365 Added the operators mentioned above to the same list as == and !=.
367 2009-10-02 Julie Parent <jparent@chromium.org>
371 Adding myself and Ojan Vafai as committers, because we are committers.
373 * Scripts/modules/committers.py:
375 2009-10-02 Brian Weinstein <bweinstein@apple.com>
377 Reviewed by Adam Roben.
379 svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
380 this will help the patch merging process when TryBots are used.
382 * Scripts/svn-create-patch:
384 2009-10-02 Jakub Wieczorek <faw217@gmail.com>
386 Reviewed by Simon Hausmann.
388 [Qt] Implement layoutTestController.overridePreference().
389 https://bugs.webkit.org/show_bug.cgi?id=29970
391 * DumpRenderTree/qt/DumpRenderTree.cpp:
392 (WebCore::WebPage::WebPage):
393 (WebCore::WebPage::resetSettings):
394 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
395 * DumpRenderTree/qt/jsobjects.cpp:
396 (LayoutTestController::reset):
397 (LayoutTestController::setPrivateBrowsingEnabled):
398 (LayoutTestController::setPopupBlockingEnabled):
399 (LayoutTestController::overridePreference):
400 * DumpRenderTree/qt/jsobjects.h:
402 2009-10-01 Chris Marrin <cmarrin@apple.com>
404 Reviewed by Oliver Hunt.
406 Turn on ENABLE_3D_CANVAS in TOT
407 https://bugs.webkit.org/show_bug.cgi?id=29906
409 * Scripts/build-webkit:
411 2009-10-01 Kenneth Rohde Christiansen <kenneth@webkit.org>
413 Rubberstamped by Simon Hausmann.
415 Enable HTTP tests for Qt
417 * Scripts/run-webkit-tests:
419 2009-10-01 Yaar Schnitman <yaar@chromium.org>
421 Reviewed by Dimitri Glazkov.
423 build-webkit --chromium now also works on cygwin.
425 https://bugs.webkit.org/show_bug.cgi?id=29973
427 * Scripts/webkitdirs.pm:
429 2009-10-01 Zoltan Horvath <zoltan@webkit.org>
431 Reviewed by Simon Hausmann.
433 [Qt] Don't use TCmalloc in DumpRenderTree
434 https://bugs.webkit.org/show_bug.cgi?id=27029
436 Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
438 * DumpRenderTree/qt/DumpRenderTree.pro:
440 2009-10-01 Jakub Wieczorek <faw217@gmail.com>
442 Reviewed by Simon Hausmann.
444 [Qt] Implement eventSender.scheduleAsynchronousClick().
446 https://bugs.webkit.org/show_bug.cgi?id=29931
448 * DumpRenderTree/qt/jsobjects.cpp:
449 (EventSender::scheduleAsynchronousClick):
450 * DumpRenderTree/qt/jsobjects.h:
452 2009-10-01 Jakub Wieczorek <faw217@gmail.com>
454 Reviewed by Simon Hausmann.
456 [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
457 fast/events/open-window-from-another-frame.html from the Skipped list.
459 https://bugs.webkit.org/show_bug.cgi?id=29930
461 * DumpRenderTree/qt/jsobjects.cpp:
462 (LayoutTestController::setPopupBlockingEnabled):
463 * DumpRenderTree/qt/jsobjects.h:
465 2009-09-30 Cameron McCormack <cam@mcc.id.au>
469 Added myself to the list of committers.
471 * Scripts/modules/committers.py:
473 2009-09-30 Eric Seidel <eric@webkit.org>
475 No review, just adding Geoff to the list of reviewers.
477 * Scripts/modules/committers.py:
479 2009-09-30 Dan Bernstein <mitz@apple.com>
481 Reviewed by Sam Weinig.
483 Added the WebKit Layout Tests fonts that are referenced in
484 LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
486 * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
487 * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
489 2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
491 Reviewed by David Kilzer.
493 Make sunspider scripts work on Windows platform.
494 https://bugs.webkit.org/show_bug.cgi?id=29656
496 * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
497 * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
498 * Scripts/webkitdirs.pm: currentPerlPath() added.
500 2009-09-29 Brady Eidson <beidson@apple.com>
502 Rubberstamped by Dan Bernstein.
504 Fix license and some sorting in new files.
506 * DumpRenderTree/mac/HistoryDelegate.h:
507 * DumpRenderTree/mac/HistoryDelegate.mm:
509 2009-09-29 Yaar Schnitman <yaar@chromium.org>
511 Reviewed by David Kilzer.
513 Fixed how error codes are handled.
514 https://bugs.webkit.org/show_bug.cgi?id=29898
516 * Scripts/update-webkit:
517 * Scripts/update-webkit-chromium:
519 2009-09-29 Brady Eidson <beidson@apple.com>
521 Reviewed by John Sullivan.
523 Updated way-out-of-date sorting throughout the dump methods/flags.
525 * DumpRenderTree/LayoutTestController.cpp:
526 (LayoutTestController::LayoutTestController):
528 (dumpAsTextCallback):
529 (dumpFrameLoadCallbacksCallback):
530 (dumpResourceLoadCallbacksCallback):
531 (LayoutTestController::staticFunctions):
533 * DumpRenderTree/LayoutTestController.h:
534 (LayoutTestController::dumpAsText):
535 (LayoutTestController::setDumpAsText):
536 (LayoutTestController::dumpFrameLoadCallbacks):
537 (LayoutTestController::setDumpFrameLoadCallbacks):
538 (LayoutTestController::dumpSelectionRect):
539 (LayoutTestController::setDumpSelectionRect):
540 (LayoutTestController::dumpSourceAsWebArchive):
541 (LayoutTestController::setDumpSourceAsWebArchive):
542 (LayoutTestController::dumpStatusCallbacks):
543 (LayoutTestController::setDumpStatusCallbacks):
544 (LayoutTestController::dumpTitleChanges):
545 (LayoutTestController::setDumpTitleChanges):
546 (LayoutTestController::dumpWillCacheResponse):
547 (LayoutTestController::setDumpWillCacheResponse):
549 2009-09-29 Brady Eidson <beidson@apple.com>
551 Reviewed by John Sullivan.
553 WebKit Mac API should provide a delegate interface for global history.
554 <rdar://problem/7042773> and https://webkit.org/b/29904
556 Adding the dumping of global history delegate callbacks.
558 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
560 Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
561 * DumpRenderTree/mac/DumpRenderTree.mm:
562 (createWebViewAndOffscreenWindow):
563 (allocateGlobalControllers):
564 (shouldLogFrameLoadDelegates):
565 (shouldLogHistoryDelegates):
568 Dump history delegate callbacks:
569 * DumpRenderTree/mac/HistoryDelegate.h: Added.
570 * DumpRenderTree/mac/HistoryDelegate.mm: Added.
571 (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
572 (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
573 (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
575 2009-09-29 Daniel Bates <dbates@webkit.org>
577 Reviewed by Adam Roben.
579 https://bugs.webkit.org/show_bug.cgi?id=28902
581 Fixes an issue where the drop effect returned by Window Dump Render Tree
582 was always DROPEFFECT_NONE (since it was hard coded to do so).
584 This patch corrects this issue by determining the actual drop effect
585 performed by the corresponding drag-and-drop operation so that we can
588 * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
589 (DraggingInfo::DraggingInfo):
590 (DraggingInfo::performedDropEffect): Added method.
591 (DraggingInfo::setPerformedDropEffect): Added method.
592 * DumpRenderTree/win/EventSender.cpp:
593 (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
594 Moved delete draggingInfo to UIDelegate::doDragDrop.
595 * DumpRenderTree/win/UIDelegate.cpp:
596 (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
598 2009-09-29 Dan Bernstein <mitz@apple.com>
600 Reviewed by Adam Roben.
602 Remove copying of unnecessary or nonexistent files from the ImageDiff
605 * DumpRenderTree/win/ImageDiff.vcproj:
607 2009-09-29 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
609 Reviewed by David Kilzer.
611 [Qt] Make build-webkit script work on Windows
612 https://bugs.webkit.org/show_bug.cgi?id=29802
614 * Scripts/run-webkit-tests:
615 * Scripts/webkitdirs.pm:
616 - Removed unnecessary -p switch for mkdir on Windows.
617 - Use canonical path, which uses slashes or backslashes depends on platform.
618 - isWindows() only test for Windows and not for Cyqwin.
620 2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>
622 Reviewed by Simon Hausmann.
624 Fix time measurement in build-webkit after refactoring done in r48853.
626 * Scripts/build-webkit:
628 2009-09-29 Andras Becsi <becsi.andras@stud.u-szeged.hu>
630 Reviewed by Tor Arne Vestbø.
632 [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
633 This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
635 * DumpRenderTree/qt/DumpRenderTree.cpp:
636 (WebCore::WebPage::WebPage):
638 2009-09-29 Jakub Wieczorek <faw217@gmail.com>
640 Reviewed by Simon Hausmann.
642 [Qt] Implement eventSender.contextClick().
643 https://bugs.webkit.org/show_bug.cgi?id=29821
645 * DumpRenderTree/qt/jsobjects.cpp:
646 (EventSender::contextClick):
647 * DumpRenderTree/qt/jsobjects.h:
649 2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
651 Reviewed by Eric Seidel.
653 Add experimentalWebSocketsEnabled in WebPreferences.
654 https://bugs.webkit.org/show_bug.cgi?id=28941
656 * DumpRenderTree/mac/DumpRenderTree.mm:
657 (resetDefaultsToConsistentValues):
658 * DumpRenderTree/win/DumpRenderTree.cpp:
659 (resetDefaultsToConsistentValues):
661 2009-09-28 Yaar Schnitman <yaar@chromium.org>
663 Reviewed by David Kilzer.
665 Integrated chromium port building into webkit tools update-webkit and
668 https://bugs.webkit.org/show_bug.cgi?id=29749
670 * Scripts/build-webkit: When --chromium is specified, will build
671 the chromium port (currently only Mac is supported).
672 * Scripts/update-webkit: When --chromium is specified, delegates to
673 update-webkit-chromium.
674 * Scripts/webkitdirs.pm: Added chromium specific defs.
675 * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
676 chromium port's dependencies and update its project files.
678 2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
682 Add myself to list of committers.
684 * Scripts/modules/committers.py:
686 2009-09-27 Jakub Wieczorek <faw217@gmail.com>
688 Reviewed by Darin Adler.
690 run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
691 https://bugs.webkit.org/show_bug.cgi?id=29771
693 * Scripts/run-webkit-tests:
695 2009-09-27 Jakub Wieczorek <faw217@gmail.com>
697 Reviewed by Simon Hausmann.
699 [Qt] Implement layoutTestController.waitForPolicyDelegate.
700 https://bugs.webkit.org/show_bug.cgi?id=25037
702 * DumpRenderTree/qt/DumpRenderTree.cpp:
703 (WebCore::WebPage::acceptNavigationRequest):
704 * DumpRenderTree/qt/DumpRenderTree.pro:
705 * DumpRenderTree/qt/jsobjects.cpp:
706 (LayoutTestController::reset):
707 (LayoutTestController::notifyDone):
708 (LayoutTestController::waitForPolicyDelegate):
709 * DumpRenderTree/qt/jsobjects.h:
710 (LayoutTestController::waitForPolicy):
712 2009-09-26 David Kilzer <ddkilzer@apple.com>
714 <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
716 Reviewed by Eric Seidel.
718 The -o|--open switch uses the open(1) command on Mac OS X to
719 open the bug URL in the default web browser. If there are
720 similar mechanisms on other platforms, they may be added later.
722 * Scripts/mark-bug-fixed:
723 (MarkBugFixed.__init__): Added -o|--open switch to list of parse
725 (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
726 code into main() and extracted prompting code into
727 _prompt_user_for_correctness().
728 (MarkBugFixed._open_bug_in_web_browser): Added.
729 (MarkBugFixed._prompt_user_for_correctness): Added.
730 (MarkBugFixed.main): Added logging code from
731 _determine_bug_id_and_svn_revision(). Added code to call
732 _open_bug_in_web_browser() if the switch is set. Added code to
733 call _prompt_user_for_correctness() when needed.
734 * Scripts/modules/bugzilla.py:
735 (Bugzilla.short_bug_url_for_bug_id): Added.
737 2009-09-26 David Kilzer <ddkilzer@apple.com>
739 svn-unapply and svn-apply don't work when used outside multiple svn working directories
741 <http://webkit.org/b/29744>
742 <rdar://problem/7252905>
744 Reviewed by Eric Seidel.
746 Some users have a workflow where svn-create-patch, svn-apply and
747 svn-unapply are used outside of multiple svn working
748 directories. Instead of aborting the scripts in these cases,
749 print a warning and assume that Subversion is being used.
751 * Scripts/VCSUtils.pm:
752 (determineVCSRoot): Call warn() instead of die() if both isGit()
753 and isSVN() initially return false. Set $VCSUtils::isSVN to 1
754 to enforce the assumption about Subversion, then return
756 * Scripts/svn-apply: Switch to using isGit() and isSVN() from
757 VCSUtils.pm. They both already cache their values and checking
758 here is redundant since determineVCSRoot() is called later.
760 2009-09-26 Zan Dobersek <zandobersek@gmail.com>
762 Reviewed by Gustavo Noronha.
764 [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
765 https://bugs.webkit.org/show_bug.cgi?id=29689
767 Load test fonts through FontConfig before each test.
768 This ensures a more proper rendering of the tests.
770 * DumpRenderTree/gtk/DumpRenderTree.cpp:
774 * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
777 2009-09-25 David Kilzer <ddkilzer@apple.com>
779 <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
781 Reviewed by Eric Seidel.
783 * Scripts/mark-bug-fixed:
784 (MarkBugFixed.__init__): Added -u|--update-only switch to list
786 (MarkBugFixed.main): When -u|--update-only is specified, add a
787 comment to the bug without marking it Resolved/Fixed.
789 2009-09-25 Darin Adler <darin@apple.com>
791 Reviewed by Geoffrey Garen.
793 * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
794 out, just as we do for the resources directory.
796 2009-09-25 Adam Barth <abarth@webkit.org>
798 Unreviewed. Added Tony to committers.py because he's a
801 * Scripts/modules/committers.py:
803 2009-09-25 Eric Seidel <eric@webkit.org>
805 Reviewed by Simon Fraser.
807 REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
808 https://bugs.webkit.org/show_bug.cgi?id=28624
810 Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
812 * DumpRenderTree/mac/DumpRenderTree.mm:
813 (resetDefaultsToConsistentValues):
815 2009-09-25 Eric Seidel <eric@webkit.org>
817 Reviewed by Adam Barth.
819 commit-queue should auto-retry patches which fail to commit due to out of date files
820 https://bugs.webkit.org/show_bug.cgi?id=28316
822 * Scripts/bugzilla-tool:
823 - Handle new CheckoutNeedsUpdate exception.
824 * Scripts/modules/logging_unittest.py:
825 - Call the ScriptError constructor correctly (this test had regressed).
826 * Scripts/modules/scm.py:
827 - Added the ability to define custom error handlers for run_command
828 and added a commit_error_handler which throws CheckoutNeedsUpdate
829 instead of ScriptError.
830 - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
831 * Scripts/modules/scm_unittest.py:
832 - Added tests of new error handlers.
834 2009-09-25 Eric Seidel <eric@webkit.org>
836 Reviewed by Adam Barth.
838 commit-queue should give better feedback when failing a patch
839 https://bugs.webkit.org/show_bug.cgi?id=29316
841 * Scripts/bugzilla-tool:
842 - Update ScriptError uses to the new constructor format.
843 - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
844 so that we can print to both stdout as well as an output buffer for error reporting.
845 - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
846 - Use e.message_with_output() when failing a patch (this is the real fix here).
847 I also removed use of "This patch will require manual commit." as that's not always true.
848 - Add missing word "bug" from log message.
849 * Scripts/modules/scm.py:
850 - Make ScriptError save a bunch more data so that error messages can be nicer.
851 - Update ScriptError callers.
853 2009-09-24 John Gregg <johnnyg@google.com>
855 Reviewed by Eric Seidel.
857 Enable switch for notifications (experimental) in Page Settings
858 https://bugs.webkit.org/show_bug.cgi?id=28930
860 Now that desktop notifications are controlled by run-time switch,
861 set that switch to true for DumpRenderTree.
863 * DumpRenderTree/mac/DumpRenderTree.mm:
864 (resetDefaultsToConsistentValues):
865 * DumpRenderTree/win/DumpRenderTree.cpp:
866 (resetDefaultsToConsistentValues):
867 * DumpRenderTree/win/UIDelegate.cpp:
868 (UIDelegate::QueryInterface):
870 2009-09-24 Kevin Ollivier <kevino@theolliviers.com>
872 wx build fix. SnowLeopard fixes for Mac dependencies.
874 * wx/build/build_utils.py:
875 * wx/build/settings.py:
876 * wx/install-unix-extras:
878 2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
880 Reviewed by Oliver Hunt.
882 Add support for DRT to send mouse wheel events.
884 https://bugs.webkit.org/show_bug.cgi?id=29348
885 [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
887 * DumpRenderTree/gtk/EventSender.cpp:
888 (mouseWheelToCallback):
890 2009-09-17 Eric Seidel <eric@webkit.org>
892 Reviewed by David Levin.
894 commit-queue needs web-based status reporting
895 https://bugs.webkit.org/show_bug.cgi?id=29307
897 Add a first-pass web-based status for the commit-queue.
898 The bot is currently reachable at:
899 http://webkit-commit-queue.appspot.com/
901 * CommitQueueStatus/app.yaml: Added.
902 - Application description file required by App Engine.
903 * CommitQueueStatus/filters/__init__.py: Added.
904 - Required by python to treat 'filters' as a module.
905 * CommitQueueStatus/filters/webkit_extras.py: Added.
906 - Support for turning 'bug 123' and 'patch 123' into links.
907 This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
908 * CommitQueueStatus/index.html: Added.
909 * CommitQueueStatus/index.yaml: Added.
910 - Some auto-generated file from app engine.
911 * CommitQueueStatus/queue_status.py: Added.
912 - The core logic of this bot. We could eventually split this file out into pieces.
913 * CommitQueueStatus/stylesheets/main.css: Added.
914 - Some basic lame-o CSS to make the page look less awful.
915 * CommitQueueStatus/update_status.html: Added.
916 - The form that the commit-queue (or a human) can use to update the status.
917 * Scripts/bugzilla-tool:
918 - Add some very basic update_status calls.
919 * Scripts/modules/statusbot.py: Added.
920 - Knows how to post to the CommitQueueStatus web application.
922 2009-09-24 David Kilzer <ddkilzer@apple.com>
924 <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
926 Reviewed by Adam Roben.
928 * Scripts/mark-bug-fixed:
929 (MarkBugFixed.__init__): Added -m|--comment switch to list of
931 (MarkBugFixed.main): When specified, prepend comment from
932 -m|--comment command-line switch to the bug comment.
934 2009-09-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
936 Reviewed by Jan Alonzo.
938 [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
939 https://bugs.webkit.org/show_bug.cgi?id=29693
941 Show the window, to be able to synthesize events correctly.
943 * DumpRenderTree/gtk/DumpRenderTree.cpp:
947 2009-09-24 Oliver Hunt <oliver@apple.com>
949 Reviewed by NOBODY(rollout)
951 Roll out r48712 as it is incorrect.
953 * DumpRenderTree/mac/ObjCController.m:
954 (+[ObjCController isSelectorExcludedFromWebScript:]):
955 (+[ObjCController webScriptNameForSelector:]):
957 2009-09-24 Benjamin Poulain <benjamin.poulain@nokia.com>
959 Reviewed by Eric Seidel.
961 https://bugs.webkit.org/show_bug.cgi?id=29005
962 The indices of RuntimeArray should be enumerated like for a regular array.
964 * DumpRenderTree/mac/ObjCController.m:
965 (+[ObjCController isSelectorExcludedFromWebScript:]):
966 (+[ObjCController webScriptNameForSelector:]):
967 (-[ObjCController arrayOfString]):
969 2009-09-23 David Kilzer <ddkilzer@apple.com>
971 <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
973 Reviewed by Darin Adler.
975 Also fixed a bug where specifying a revision on the command-line
976 as 'r12345' would fail. See <http://webkit.org/b/29699>.
978 * Scripts/bugzilla-tool: Updated module import statements.
979 (parse_bug_id): Removed. Moved to bugzilla.py.
980 (bug_comment_from_svn_revision): Removed. Moved to comments.py.
981 (bug_comment_from_commit_text): Removed. Moved to comments.py.
982 (MarkBugFixed): Removed. Code moved to mark-bug-fixed.
983 (BugzillaTool.__init__): Removed mark-fixed subcommand.
984 * Scripts/mark-bug-fixed: Added.
985 * Scripts/modules/bugzilla.py:
986 (parse_bug_id): Added. Moved from bugzilla-tool.
987 * Scripts/modules/comments.py: Added.
988 (bug_comment_from_svn_revision): Added. Moved from bugzilla-tool.
989 (bug_comment_from_commit_text): Added. Moved from bugzilla-tool.
991 2009-09-23 Marshall Culpepper <mculpepper@appcelerator.com>
993 Reviewed by Eric Seidel.
995 jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
996 "false" in non-implemented stub for setAlwaysAcceptCookies.
997 https://bugs.webkit.org/show_bug.cgi?id=29661
999 * DumpRenderTree/win/DumpRenderTree.vcproj:
1000 * DumpRenderTree/win/DumpRenderTree.cpp:
1002 2009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1004 Reviewed by Xan Lopez.
1006 [GTK] need to dump number of pending unload handlers
1007 https://bugs.webkit.org/show_bug.cgi?id=29685
1009 Implement dumping of the number of pending unload handlers.
1011 The following tests will pass:
1013 fast/loader/unload-form-about-blank.html
1014 fast/loader/unload-form-post-about-blank.html
1015 fast/loader/unload-form-post.html
1016 fast/loader/unload-form.html
1017 fast/loader/unload-hyperlink.html
1018 fast/loader/unload-javascript-url.html
1019 fast/loader/unload-reload.html
1020 fast/loader/unload-window-location.html
1022 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1023 (getFrameNameSuitableForTestResult):
1024 (webViewLoadFinished):
1026 2009-09-22 Shinichiro Hamaji <hamaji@chromium.org>
1028 Reviewed by Eric Seidel.
1030 js tests should move into jstests subdirectory instead of resources/
1031 https://bugs.webkit.org/show_bug.cgi?id=25880
1033 Remove support of resources directory.
1035 * Scripts/make-script-test-wrappers:
1037 2009-09-22 Eric Seidel <eric@webkit.org>
1039 No review, only fixing typo (missing space character).
1041 Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
1043 * Scripts/run-webkit-tests:
1045 2009-09-22 Eric Seidel <eric@webkit.org>
1047 Reviewed by Darin Adler.
1049 run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
1050 https://bugs.webkit.org/show_bug.cgi?id=29220
1052 * Scripts/run-webkit-tests:
1054 2009-09-22 Eric Seidel <eric@webkit.org>
1056 Reviewed by David Kilzer.
1058 svn-apply can't handle single-line binary file additions
1059 https://bugs.webkit.org/show_bug.cgi?id=29100
1061 Fixed the regexp and added a unit test.
1063 * Scripts/modules/scm_unittest.py:
1064 * Scripts/svn-apply:
1066 2009-09-11 Eric Seidel <eric@webkit.org>
1068 Reviewed by David Kilzer.
1070 post-diff and post-commits should be able to find bug urls in ChangeLogs.
1071 https://bugs.webkit.org/show_bug.cgi?id=29206
1073 * Scripts/bugzilla-tool:
1074 - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
1075 - Rename --no-comment to --add-log-as-comment and reverse behavior.
1076 Comments tend to just be noise. I'll eventually remove this argument if no one uses it.
1077 - Split out code into helper functions to try and make execute() more legible.
1078 - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
1079 - Fallback to bug urls in commit diffs, instead of just in commit messages,
1080 meaning post-commits will now find bug urls in ChangeLogs.
1082 2009-09-21 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
1084 Reviewed by Maciej Stachowiak.
1086 --parse-only parameter wasn't passed to SunSpider/sunspider script.
1087 https://bugs.webkit.org/show_bug.cgi?id=29611
1089 * Scripts/run-sunspider: Missing parameter passing added.
1091 2009-09-20 David Kilzer <ddkilzer@apple.com>
1093 <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
1095 Reviewed by Mark Rowe.
1097 The require statement is like the use statement, except that it
1098 is run during script execution instead of during the 'BEGIN'
1099 phase. This makes it possible to change @INC before the require
1100 statement is run. See 'require' and 'use' in the perlfunc(1)
1101 manpage and 'BEGIN' in perlmod(1) manpage.
1103 * Scripts/run-webkit-tests: Replace eval statement with require
1106 2009-09-18 Kevin Ollivier <kevino@theolliviers.com>
1108 wx build fixes. Fix the config name under git and allow users to specify
1109 their own waf install for experimenting with new versions.
1111 * Scripts/webkitdirs.pm:
1112 * wx/build/settings.py:
1114 2009-09-18 Alex Milowski <alex@milowski.com>
1116 Reviewed by Maciej Stachowiak.
1118 Added checkWebCoreMathMLSupport and hasMathMLSupport to support
1119 checking for whether MathML tests should be run
1121 * Scripts/run-webkit-tests:
1122 * Scripts/webkitdirs.pm:
1124 2009-08-28 Darin Adler <darin@apple.com>
1126 Reviewed by Mark Rowe.
1128 Break more of run-webkit-tests into separate functions
1129 https://bugs.webkit.org/show_bug.cgi?id=29497
1131 Some small steps toward improving run-webkit-tests. My goal is to
1132 refactor much more of the script into functions. Later we can add
1133 parallel test running to the tool. But better structure may help
1134 even if someone decides to translate this into another scripting
1137 * Scripts/run-webkit-tests: Break more pieces of the script into
1138 seprate functions. Added readSkippedFiles, findTestsToRun, and
1139 printResults functions. Removed custom code to skip results.html
1140 and instead just put it into the ignoredFiles hash. Fixed some
1141 indentation. Sorted function declarations, global variables,
1142 and options at the top of the file alphabetically so they're not
1143 in a semi-random order.
1145 2009-09-17 Kevin Ollivier <kevino@theolliviers.com>
1147 wx build fix, add missing dependency.
1149 * wx/browser/wscript:
1151 2009-09-16 Mark Rowe <mrowe@apple.com>
1153 Split the SnowLeopard build across a few machines.
1155 * BuildSlaveSupport/build.webkit.org-config/config.json:
1157 2009-09-16 Kevin Ollivier <kevino@theolliviers.com>
1159 wx build fix to support monolithic builds on Windows.
1161 * wx/build/wxpresets.py:
1163 2009-09-16 Kevin Ollivier <kevino@theolliviers.com>
1165 wx build fix, improve debug support and 2.9 support on MSW.
1167 * wx/build/settings.py:
1168 * wx/build/wxpresets.py:
1170 2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1172 Blind try at fixing new test failure on Windows.
1174 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1175 (FrameLoadDelegate::didReceiveTitle):
1177 2009-09-15 Alex Milowski <alex@milowski.com>
1179 Reviewed by Tor Arne Vestbø.
1183 * Scripts/build-webkit:
1185 2009-09-15 Kevin Ollivier <kevino@theolliviers.com>
1187 wx build fix. Allow waf build to support Python < 2.6.
1189 * wx/build/waf_extensions.py:
1191 2009-09-14 Chris Marrin <cmarrin@apple.com>
1193 Reviewed by Oliver Hunt.
1195 Add LayoutTests infrastructure to enable and disable webgl tests.
1196 https://bugs.webkit.org/show_bug.cgi?id=29254
1198 * Scripts/run-webkit-tests:
1199 * Scripts/webkitdirs.pm:
1201 2009-09-14 Simon Fraser <simon.fraser@apple.com>
1203 Reviewed by Darin Adler.
1205 Add --iterations option to run-webkit-tests to repeat the tests N times
1206 https://bugs.webkit.org/show_bug.cgi?id=29263
1208 When run with --iterations N, run-webkit-tests will repeat the tests N times.
1210 * Scripts/run-webkit-tests:
1212 2009-09-14 Brady Eidson <beidson@apple.com>
1214 Not reviewed, maybe should've been:
1216 Cleaning up more Windows-specific fallout from the fix for:
1217 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1219 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1220 (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Correct printf() formatter,
1221 and call the correct method to get the Sender.
1223 2009-09-14 Jon Honeycutt <jhoneycutt@apple.com>
1229 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1230 (AccessibilityController::setLogScrollingStartEvents):
1232 2009-09-11 Jon Honeycutt <jhoneycutt@apple.com>
1235 <rdar://problem/7197644> WebKit should broadcast an MSAA event when
1236 jumping to a named anchor
1238 https://bugs.webkit.org/show_bug.cgi?id=28899
1240 Reviewed by Adam Roben.
1242 * DumpRenderTree/AccessibilityController.cpp:
1243 (logScrollingStartEventsCallback):
1244 Turn on logging of scrolling start events.
1245 (AccessibilityController::getJSClass):
1246 Add a "logScrollingStartEvents" to the AccessibilityController's JS
1248 (AccessibilityController::resetToConsistentState):
1249 Turn off logging of scrolling start events.
1251 * DumpRenderTree/AccessibilityController.h:
1252 Declare setLogScrollingStartEvents(). Add a member for the scrolling
1255 * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
1256 (AccessibilityController::setLogScrollingStartEvents):
1259 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1260 (AccessibilityController::AccessibilityController):
1261 Initialize the handle to 0.
1263 Renamed from logFocusEventProc; now logs scrolling start events, too.
1264 Removed the assertion that the event is a focus event. Added a switch
1265 to print a message for focus, scrolling start, and other, unknown
1267 (AccessibilityController::setLogFocusEvents):
1268 Changed to use logEventProc.
1269 (AccessibilityController::setLogScrollingStartEvents):
1270 If turning logging off, unhook the scrolling start event hook, and clear
1271 the member holding the handle. If turning on, query for the root
1272 accessible, so that accessibility is enabled for the WebView, and call
1273 SetWinEventHook to setup an event hook using logEventProc as the
1276 2009-09-14 Brady Eidson <beidson@apple.com>
1280 * DumpRenderTree/LayoutTestController.cpp:
1281 (setAuthenticationPasswordCallback):
1282 (setAuthenticationUsernameCallback):
1284 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1285 (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1287 2009-09-14 Brady Eidson <beidson@apple.com>
1289 Reviewed by Alexey Proskuryakov.
1291 Safari 4 cannot be used to update firmware on Linksys routers.
1292 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1294 Add the ability for DRT to handle authentication challenges.
1296 * DumpRenderTree/LayoutTestController.cpp:
1297 (setAuthenticationPasswordCallback):
1298 (setAuthenticationUsernameCallback):
1299 (setHandlesAuthenticationChallengesCallback):
1300 (LayoutTestController::staticFunctions):
1302 * DumpRenderTree/LayoutTestController.h:
1303 (LayoutTestController::handlesAuthenticationChallenges):
1304 (LayoutTestController::setHandlesAuthenticationChallenges):
1305 (LayoutTestController::authenticationUsername):
1306 (LayoutTestController::setAuthenticationUsername):
1307 (LayoutTestController::authenticationPassword):
1308 (LayoutTestController::setAuthenticationPassword):
1310 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1311 (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1313 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1314 (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1315 * DumpRenderTree/win/ResourceLoadDelegate.h:
1317 2009-09-12 Mark Rowe <mrowe@apple.com>
1319 Reviewed by Dan Bernstein.
1321 Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
1323 Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
1324 This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
1326 * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1329 2009-09-14 Kevin Ollivier <kevino@theolliviers.com>
1331 wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
1333 * wx/build/build_utils.py:
1334 * wx/build/settings.py:
1336 2009-09-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
1338 Reviewed by Tor Arne Vestbø.
1340 [Qt] Build fix for windows build.
1342 * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
1344 2009-09-13 Kevin Ollivier <kevino@theolliviers.com>
1346 Fix typo accidently landed in last commit.
1348 * wx/build/settings.py:
1350 2009-09-13 Kevin Ollivier <kevino@theolliviers.com>
1352 wx build fix, error out if using the wrong Python.
1354 * wx/build/settings.py:
1356 2009-09-13 Xan Lopez <xlopez@igalia.com>
1358 Build fix for GTK+ < 2.14.
1360 Do not use gtk_widget_get_window, access the window directly
1363 * DumpRenderTree/gtk/EventSender.cpp:
1364 (contextClickCallback):
1365 (mouseDownCallback):
1367 (mouseMoveToCallback):
1370 2009-09-13 Martin Robinson <martin.james.robinson@gmail.com>
1372 Reviewed by Xan Lopez and Jan Alonzo.
1374 [GTK] EventSender does not set 'window' property on synthesized GDK events
1375 https://bugs.webkit.org/show_bug.cgi?id=29169
1377 Set the window property on synthesized GDK events in the GTK+ EventSender.
1379 * DumpRenderTree/gtk/EventSender.cpp:
1380 (contextClickCallback):
1381 (mouseDownCallback):
1383 (mouseMoveToCallback):
1386 2009-09-12 Drew Wilson <atwilson@google.com>
1388 Reviewed by Mark Rowe.
1390 run-webkit-tests has a timeout value that is too low
1391 https://bugs.webkit.org/show_bug.cgi?id=29223
1393 * Scripts/run-webkit-tests:
1394 Changed timeout value to 20 seconds to avoid timing out too early.
1396 2009-09-11 Kevin Ollivier <kevino@theolliviers.com>
1398 wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
1399 architectures are supported for building wxWebKit.
1401 * wx/build/settings.py:
1403 2009-09-11 Eric Seidel <eric@webkit.org>
1405 Reviewed by David Levin.
1407 bugzilla-tool rollout threw exception under svn
1408 https://bugs.webkit.org/show_bug.cgi?id=29211
1410 * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
1411 * Scripts/modules/scm_unittest.py: add testing for this fix.
1413 2009-09-11 Brian Weinstein <bweinstein@apple.com>
1415 Add myself to the committers list.
1417 * Scripts/modules/committers.py:
1419 2009-09-11 Eric Seidel <eric@webkit.org>
1421 Reviewed by Adam Barth.
1423 bugzilla-tool land-patches should only fail-fast in --commit-queue mode
1424 https://bugs.webkit.org/show_bug.cgi?id=29201
1426 * Scripts/bugzilla-tool:
1428 2009-09-11 Adam Roben <aroben@apple.com>
1430 Make commit-log-editor move common prefixes to the top of the log
1432 Fies <http://webkit.org/b/29190> commit-log-editor should move common
1433 prefixes to the top of the commit log
1435 Reviewed by Darin Adler.
1437 * Scripts/commit-log-editor: Find and remove the longest common prefix
1438 ending in a double newline from each ChangeLog entry, then put that
1439 common prefix at the top of the commit log.
1440 (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
1441 removes, and returns the longest common prefix ending in a double
1442 newline from a hash of strings
1444 2009-09-11 Eric Seidel <eric@webkit.org>
1446 Fix obvious typo in previous commit, no review.
1448 bugzilla-tool should automate rollouts
1449 https://bugs.webkit.org/show_bug.cgi?id=26715
1451 * Scripts/bugzilla-tool: add back missing "scm" argument.
1453 2009-09-11 Eric Seidel <eric@webkit.org>
1455 Reviewed by Adam Barth.
1457 bugzilla-tool should automate rollouts
1458 https://bugs.webkit.org/show_bug.cgi?id=26715
1460 bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
1461 The --complete-rollout option will automatically land and update the bug.
1462 Eventually --complete-rollout will be default, but that will require more testing.
1464 This first pass is good enough for others to try and file bugs about.
1466 * Scripts/bugzilla-tool:
1467 - Move modified_changelogs into scm.py.
1468 - Move svn_revision_from_commit_text logic into scm.py.
1469 - Add RolloutCommit command.
1470 * Scripts/modules/bugzilla.py:
1471 - Add reopen_bug command used by RolloutCommit.
1472 * Scripts/modules/scm.py:
1473 - Add functions to support RolloutCommit.
1474 - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
1475 - Add a str() call so that svn_commit_log can take a numeric argument.
1476 - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
1477 - Made dry_run commits return something that svn_revision_from_commit_text can parse.
1478 * Scripts/modules/scm_unittest.py:
1479 - Add read_from_path for easy file reading.
1480 - Put test4 on a new line to make reverts work w/o conflict.
1481 - Add an "svn update" call so that the checkout revision matches the server revision.
1482 - Add tests for svn_revision_from_commit_text.
1483 - Add a simple test for apply_reverse_diff.
1484 - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
1485 - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
1487 2009-09-11 Adam Roben <aroben@apple.com>
1489 Get user script/stylesheet tests running on Windows
1491 Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
1494 Reviewed by John Sullivan.
1496 * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
1497 against comsuppw.lib so we can use _bstr_t.
1499 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
1500 order, added #include of comutil.h for _bstr_t.
1502 (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
1503 (LayoutTestController::addUserScript):
1504 (LayoutTestController::addUserStyleSheet):
1505 Implemented. Implementations were based on those in
1506 LayoutTestControllerMac.mm.
1508 2009-09-10 David Kilzer <ddkilzer@apple.com>
1510 <http://webkit.org/b/29147> run-webkit-tests: make -h show help
1512 Reviewed by Mark Rowe.
1514 * Scripts/run-webkit-tests: Updated to make -h switch show help.
1516 2009-09-10 Fumitoshi Ukai <ukai@chromium.org>
1518 Reviewed by Alexey Proskuryakov.
1520 Add WebCore/websockets directory in wx build system.
1521 https://bugs.webkit.org/show_bug.cgi?id=28038
1523 * wx/build/settings.py:
1525 2009-09-10 Martin Robinson <martin.james.robinson@gmail.com>
1527 [GTK] EventSender does not properly convert some keyDown strings
1528 https://bugs.webkit.org/show_bug.cgi?id=29119
1530 Add more keyDown string to character code conversions for GTK+ EventSender.
1532 * DumpRenderTree/gtk/EventSender.cpp:
1535 2009-09-09 Steve Block <steveblock@google.com>
1537 Reviewed by Maciej Stachowiak.
1539 Geolocation Coordinates::toString() prints bogus values for unspecified properties.
1540 https://bugs.webkit.org/show_bug.cgi?id=29080
1542 * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
1544 2009-09-09 Eric Seidel <eric@webkit.org>
1546 Reviewed by Eric Carlson.
1548 reviewer/committer lookups are backwards
1549 https://bugs.webkit.org/show_bug.cgi?id=29113
1551 I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
1553 * Scripts/modules/bugzilla.py:
1554 * Scripts/modules/committers.py:
1556 2009-09-09 Cameron McCormack <cam@mcc.id.au>
1558 Reviewed by Eric Seidel.
1560 svn-unapply doesn't revert directories correctly
1561 https://bugs.webkit.org/show_bug.cgi?id=29065
1563 * Scripts/svn-unapply: Make svnStatus consistently return status
1564 lines including a newline.
1565 * Scripts/svn-apply: Keep svnStatus in sync with the one in
1566 svn-unapply, in lieu of moving it to a common file.
1568 2009-09-09 Cameron McCormack <cam@mcc.id.au>
1570 Reviewed by Eric Seidel.
1572 svn-apply doesn't handle changes to files copied to new directories properly
1573 https://bugs.webkit.org/show_bug.cgi?id=29059
1575 * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
1576 additions if we know that we've just copied a file to this name.
1578 2009-09-09 Eric Seidel <eric@webkit.org>
1580 Reviewed by David Levin.
1582 commit-queue hangs if a builder has never built
1583 https://bugs.webkit.org/show_bug.cgi?id=29091
1585 * Scripts/modules/buildbot.py:
1586 * Scripts/modules/buildbot_unittest.py:
1588 2009-09-09 Zan Dobersek <zandobersek@gmail.com>
1590 Reviewed by Gustavo Noronha.
1592 [GTK] DumpRenderTree needs eventSender object and implementation
1593 https://bugs.webkit.org/show_bug.cgi?id=25990
1595 Implements most of the EventSender object's functionality for
1596 the DumpRenderTree tool. Implementation still lacks support
1597 for drag and drop tests and forward leaps.
1599 Based on work by Holger Hans Peter Freyther.
1601 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1602 (runTest): Focus on the view before loading a new test.
1603 (webViewWindowObjectCleared):
1604 * DumpRenderTree/gtk/EventSender.cpp: Added.
1605 (getDragModeCallback):
1606 (setDragModeCallback):
1607 (leapForwardCallback):
1608 (contextClickCallback):
1610 (mouseDownCallback):
1612 (mouseMoveToCallback):
1613 (beginDragWithFilesCallback):
1614 (replaySavedEvents):
1616 (textZoomInCallback):
1617 (textZoomOutCallback):
1618 (zoomPageInCallback):
1619 (zoomPageOutCallback):
1622 * DumpRenderTree/gtk/EventSender.h: Added.
1623 * GNUmakefile.am: Add build rules for EventSender.
1625 2009-09-09 Daniel Bates <dbates@webkit.org>
1627 Reviewed by Adam Roben.
1629 https://bugs.webkit.org/show_bug.cgi?id=28953
1631 Added pre- and post- build events so that on build failure, the file
1632 buildfailed is written to the directory $(WebKitOutputDir).
1634 * WinLauncher/WinLauncher.vcproj:
1636 2009-09-09 Kenneth Rohde Christiansen <kenneth@webkit.org>
1640 Add myself to list of committers.
1642 * Scripts/modules/committers.py:
1644 2009-09-08 Eric Seidel <eric@webkit.org>
1646 Reviewed by David Levin.
1648 commit-queue gets stuck if a non-committer sets commit-queue+ or review+
1649 https://bugs.webkit.org/show_bug.cgi?id=28605
1650 https://bugs.webkit.org/show_bug.cgi?id=28916
1652 * Scripts/bugzilla-tool:
1653 - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
1654 comment now that it's used for rejecting patches for invalid committers too.
1655 - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
1656 - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
1657 * Scripts/modules/bugzilla.py:
1658 - Make _parse_attachment_element not validate reviewer/committer.
1659 - Share flag parsing code in _parse_attachment_flag.
1660 - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
1661 - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
1662 - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
1663 * Scripts/modules/bugzilla_unittest.py:
1664 - Update this test to no longer expect committer/reviewer validation.
1665 * Scripts/modules/committers.py:
1666 - Return None on failed lookups instead of raising Exceptions.
1667 * Scripts/modules/committers_unittest.py:
1668 - Update tests to expect None returns instead of exceptions.
1670 2009-09-09 David Kilzer <ddkilzer@apple.com>
1672 <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
1674 Reviewed by Mark Rowe.
1676 No change to layout test results.
1678 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1679 (AccessibilityUIElement::clickPointY): Changed to return y value
1682 2009-09-08 Dimitri Glazkov <dglazkov@chromium.org>
1684 Reviewed by Mark Rowe.
1686 Reduce dglazkov's boboiness by properly concatenating revision value.
1688 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
1691 2009-09-08 Kevin Ollivier <kevino@theolliviers.com>
1693 wxWebKit Python extension build fix - get swig.py if it doesn't exist.
1695 * wx/build/build_utils.py:
1697 2009-09-08 Mark Rowe <mrowe@apple.com>
1699 Fix an incorrect variable name in UpdateChromiumSource.
1701 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1703 2009-09-08 Mark Rowe <mrowe@apple.com>
1705 Don't check for leaks on the release SnowLeopard builder.
1707 * BuildSlaveSupport/build.webkit.org-config/config.json:
1709 2009-09-08 Mark Rowe <mrowe@apple.com>
1711 Add a SnowLeopard release builder.
1713 * BuildSlaveSupport/build.webkit.org-config/config.json:
1715 2009-09-08 David Levin <levin@chromium.org>
1717 Reviewed by Darin Adler.
1719 Remove end of line whitespace check from check-webkit-style.
1720 https://bugs.webkit.org/show_bug.cgi?id=29053
1722 * Scripts/modules/cpp_style.py:
1724 2009-09-08 Cameron McCormack <cam@mcc.id.au>
1726 Reviewed by Darin Adler.
1728 Fix DumpRenderTree build from clean tree on Tiger
1729 https://bugs.webkit.org/show_bug.cgi?id=28927
1731 * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
1732 DerivedSources/DumpRenderTree directory exists when
1735 2009-09-08 Kevin Ollivier <kevino@theolliviers.com>
1737 wx build fix after introduction of platform/mock directory.
1739 * wx/build/settings.py:
1741 2009-09-08 Yael Aharon <yael.aharon@nokia.com>
1745 Add myself to list of committers.
1747 * Scripts/modules/committers.py:
1749 2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1753 Add myself to list of committers.
1755 * Scripts/modules/committers.py:
1757 2009-09-08 Cameron McCormack <cam@mcc.id.au>
1759 Reviewed by Darin Adler.
1761 prepare-ChangeLog too chatty on file additions
1762 https://bugs.webkit.org/show_bug.cgi?id=29019
1764 * Scripts/prepare-ChangeLog: Omit description of added properties
1765 on newly added files.
1767 2009-09-08 Steve Block <steveblock@google.com>
1769 Reviewed by Adam Barth.
1771 Adds a LayoutTestController method to set the permission state for Geolocation.
1772 This is required to use the mock Geolocation service for testing.
1773 https://bugs.webkit.org/show_bug.cgi?id=29027
1775 * DumpRenderTree/LayoutTestController.cpp: Modified.
1776 (setDatabaseQuotaCallback): Modified. Style fix.
1777 (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
1778 (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
1779 * DumpRenderTree/LayoutTestController.h: Modified.
1780 (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
1781 (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
1782 (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
1783 * DumpRenderTree/mac/UIDelegate.mm: Modified.
1784 (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
1786 2009-09-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1788 Reviewed by Simon Hausmann.
1790 [Qt] QtWebKit single API to enable persistency
1791 https://bugs.webkit.org/show_bug.cgi?id=28682
1793 Use the new enablePersistentStorage API instead
1794 of enabling all persistent features one-by-one.
1796 * DumpRenderTree/qt/DumpRenderTree.cpp:
1797 (WebCore::WebPage::WebPage):
1798 (WebCore::DumpRenderTree::DumpRenderTree):
1800 2009-09-07 Andras Becsi <becsi.andras@stud.u-szeged.hu>
1802 Reviewed by Tor Arne Vestbø.
1804 Refactor --strict switch to --ignore-metrics and correct the
1805 implementation to make the feature usable on all platforms.
1806 https://bugs.webkit.org/show_bug.cgi?id=28907
1808 run-webkit-tests --ignore-metrics strips the font related metrics from
1809 the actual and expected data before comparing them.
1810 In this way the render trees can be checked for obvious differences but
1811 a successful test implies by no means that the layout is actually correct.
1813 * Scripts/run-webkit-tests:
1815 2009-09-07 Steve Block <steveblock@google.com>
1817 Reviewed by Adam Barth.
1819 Adds a mock Geolocation service. This will be used to provide predictable behavior of the
1820 Geolocation API for use in LayoutTests. Later changes will integrate the the mock
1821 Geolocation service with DumpRenderTree.
1822 https://bugs.webkit.org/show_bug.cgi?id=28264
1824 * DumpRenderTree/LayoutTestController.cpp: Modified.
1825 (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
1826 (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
1827 (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
1828 * DumpRenderTree/LayoutTestController.h: Modified.
1829 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
1830 (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
1831 (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
1833 2009-09-07 Drew Wilson <atwilson@google.com>
1835 Reviewed by David Levin.
1837 Enable SHARED_WORKERS by default
1838 https://bugs.webkit.org/show_bug.cgi?id=28959
1840 * Scripts/build-webkit:
1842 2009-09-07 Kevin Ollivier <kevino@theolliviers.com>
1844 wx build fixes for wx SVN trunk.
1846 * wx/build/settings.py:
1848 2009-09-04 Kevin Ollivier <kevino@theolliviers.com>
1850 wx build fix. Switch USE_ defines over to the compiler so that they can be
1851 checked by files not including config.h (like WebCorePrefix.h).
1853 * wx/build/settings.py:
1855 2009-09-04 Adam Barth <abarth@webkit.org>
1857 Unreviewed build fix.
1859 Update declaration of FrameLoadDelegate to reflect that
1860 IWebFrameLoadDelegatePrivate2 inherits from
1861 IWebFrameLoadDelegatePrivate.
1863 * DumpRenderTree/win/FrameLoadDelegate.h:
1865 2009-09-04 Adam Barth <abarth@webkit.org>
1867 Reviewed by Eric Seidel.
1869 https://bugs.webkit.org/show_bug.cgi?id=24696
1871 Add testing instrumentation for mixed content.
1873 * DumpRenderTree/mac/FrameLoadDelegate.mm:
1874 (-[FrameLoadDelegate webView:]):
1875 (-[FrameLoadDelegate webView:didRunInsecureContent:]):
1876 * DumpRenderTree/win/FrameLoadDelegate.cpp:
1877 (descriptionSuitableForTestResult):
1878 (FrameLoadDelegate::QueryInterface):
1879 (FrameLoadDelegate::didDisplayInsecureContent):
1880 (FrameLoadDelegate::didRunInsecureContent):
1881 * DumpRenderTree/win/FrameLoadDelegate.h:
1883 2009-09-03 Kevin Watters <kevinwatters@gmail.com>
1885 Reviewed by Kevin Ollivier.
1888 https://bugs.webkit.org/show_bug.cgi?id=19041
1890 * wx/build-wxwebkit:
1892 2009-09-02 David Kilzer <ddkilzer@apple.com>
1894 <http://webkit.org/b/28880> svn-apply --force doesn't actually work
1896 Reviewed by Eric Seidel.
1898 This fixes "svn-apply --force" and adds unit tests for the
1899 scm.apply_patch() method which uses this script.
1901 * Scripts/svn-apply: Created $globalExitCode variable that
1902 defaults to 0. Exit with a value of $globalExitCode when the
1904 (applyPatch): Ignore a non-zero $exitCode if $force is true, but
1905 set $globalExitCode to $exitCode so that svn-apply exits with a
1906 non-zero status if any patches did not apply cleanly. Also
1907 print out the actual patch command if $force was not true.
1909 * Scripts/modules/scm.py:
1910 (scripts_directory): Added. Extracted from script_path().
1911 (script_path): Extracted scripts_directory().
1912 * Scripts/modules/scm_unittest.py: Import urllib.
1913 (SVNTestRepository.setup): Save the original working directory
1914 in test_object since this represents the WebKit repository from
1915 where the unit tests are run.
1916 (SCMTest): Created new super class to hold utility methods.
1917 (SCMTest._create_patch): Creates a patch file on disk and a
1918 dictionary for use with scm.svn_apply().
1919 (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
1920 back to WebKitTools/Scripts in the test repository so that
1921 scm.apply_patch() is able to find the svn-apply script.
1922 (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
1923 (SVNTest.tearDown): Make sure to change directories back to the
1924 original_path before the next test.
1925 (SVNTest.test_apply_svn_patch): New test case for applying an
1926 svn patch with scm.apply_patch().
1927 (SVNTest.test_apply_svn_patch_force): New test case for applying
1928 an svn patch with scm.apply_patch() that conflicts.
1929 (GitTest): Inherit from SCMTest instead of unittest.TestCase.
1930 (GitTest.tearDown): Make sure to change directories back to the
1931 original_path before the next test.
1932 (GitTest.test_apply_git_patch): New test case for applying a git
1933 patch with scm.apply_patch().
1934 (GitTest.test_apply_git_patch_force): New test case for applying
1935 a git patch with scm.apply_patch() that conflicts.
1937 2009-09-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1939 Reviewed by Mark Rowe.
1941 [Qt] Add support for platform-spesific layout-test results
1943 For the Qt port we use the qt-[mac|linux|win] directories and then fall
1944 back to the generic qt directory for both test results and skipped list.
1946 * Scripts/run-webkit-tests:
1947 * Scripts/webkitdirs.pm:
1949 2009-09-02 Laurent Cerveau <lcerveau@me.com>
1951 Reviewed by David Kilzer.
1953 <http://webkit.org/b/25517> build-webkit script should print build time at end
1955 * Scripts/build-webkit:
1956 Added startTime and endTime variable so that the build time is computed and printed as
1957 part of the build message; display formatting has been separated in a dedicated subroutine.
1959 2009-09-02 David Kilzer <ddkilzer@apple.com>
1961 <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
1963 Reviewed by Eric Seidel.
1965 * Scripts/VCSUtils.pm:
1966 (determineSvnRoot): Added back check for repository root that
1967 was removed in r46134 when this code lived in svn-create-patch.
1968 It's necessary to check both the repository root and the
1969 repository UUID in case two different working directories are
1970 checked out from the same repository.
1972 2009-09-02 Timothy Hatcher <timothy@apple.com>
1974 Use new 512x512 icons for nightly builds.
1976 Rubber-stamped by Mark Rowe.
1978 * WebKitLauncher/webkit.icns:
1980 2009-09-02 Kevin Ollivier <kevino@theolliviers.com>
1982 waf build fix. Remove local variable shadowing global.
1984 * wx/build/settings.py:
1986 2009-09-02 Zan Dobersek <zandobersek@gmail.com>
1988 Reviewed by David Kilzer.
1990 Calls exitStatus function from the main package where it is also defined.
1992 * Scripts/VCSUtils.pm:
1994 2009-09-02 Kevin Ollivier <kevino@theolliviers.com>
1996 waf build fixes for Windows/MSVC and Mac/Snow Leopard.
1998 * wx/browser/wscript:
1999 * wx/build/build_utils.py:
2000 * wx/build/settings.py:
2002 2009-08-10 Kevin Ollivier <kevino@theolliviers.com>
2004 Reviewed by Eric Seidel.
2006 Changes needed for build-webkit to support the waf build system for the wx port.
2008 https://bugs.webkit.org/show_bug.cgi?id=27619
2010 * Scripts/build-webkit:
2011 * Scripts/run-launcher:
2012 * Scripts/webkitdirs.pm:
2014 2009-09-02 David Kilzer <ddkilzer@apple.com>
2016 <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
2018 Reviewed by Eric Seidel.
2020 * Scripts/update-webkit: Added "--accept postpone" to
2021 @svnOptions when running with svn-1.6 or newer.
2023 2009-09-02 David Kilzer <ddkilzer@apple.com>
2025 Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
2027 Reviewed by Eric Seidel.
2029 * Scripts/VCSUtils.pm:
2030 (@EXPORT): Added &isSVNVersion16OrNewer.
2031 (svnVersion): Added. Internal method that gets the SVN version
2033 (isSVNVersion16OrNewer): Added. Method that does the SVN 1.6
2035 * Scripts/prepare-ChangeLog: Switched to use new
2036 isSVNVersion16OrNewer() method.
2037 * Scripts/resolve-ChangeLogs: Ditto.
2038 * Scripts/svn-create-patch: Ditto.
2040 2009-09-02 David Kilzer <ddkilzer@apple.com>
2042 Clean up VCSUtils.pm
2044 Reviewed by Eric Seidel.
2046 * Scripts/VCSUtils.pm: Added proper package statement. Fixed
2047 indentation of BEGIN block. Listed each exported method on a
2048 line by itself. Added methods to the export list after adding
2049 the package statement. Sorted module variables. Moved
2050 definiton of $gitRoot next to other module variables.
2052 2009-09-01 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2054 Rubber-stamped by Simon Hausmann.
2056 [Qt] Fix layout-test plugins/plugin-javascript-access.html
2058 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2060 2009-09-02 Shinichiro Hamaji <hamaji@chromium.org>
2062 Reviewed by Eric Seidel.
2064 js tests should move into jstests subdirectory instead of resources/
2065 https://bugs.webkit.org/show_bug.cgi?id=25880
2067 make-script-wrappers supports both resources and script-tests directories.
2068 run-webkit-tests ignores files in script-tests.
2069 Move script tests of animations to check the new script is working.
2071 * Scripts/make-script-test-wrappers:
2072 * Scripts/run-webkit-tests:
2074 2009-09-02 Szabo Carol <carol.szabo@nokia.com>
2076 Reviewed by David Levin.
2078 check-webkit-style uses python from /usr/bin instead of the PATH
2079 https://bugs.webkit.org/show_bug.cgi?id=28225
2081 * Scripts/bugzilla-tool:
2082 * Scripts/check-webkit-style:
2083 * Scripts/run-webkit-unittests:
2084 * Scripts/update-sources-list.py:
2085 Changed the first line from
2088 #!/usr/bin/env python
2089 which causes python to be invoked from the path location returned
2090 by "which python" when any of these scripts are launched.
2091 these are currently all the python scripts in WebKitTools/Scripts.
2093 2009-09-01 David Kilzer <ddkilzer@apple.com>
2095 <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
2097 Reviewed by Adam Barth.
2099 * Scripts/modules/scm.py:
2100 (Git.commit_ids_from_commitish_arguments): Reverse the list of
2101 commits returned from git-rev-list since we always want to post
2102 the oldest patches first to bugs.webkit.org.
2103 * Scripts/modules/scm_unittest.py:
2104 (run): Added return statement to return the output now that we
2106 (SVNTestRepository._setup_test_commits): Added a fourth commit
2107 so the GitTest.test_commitish_order() test has more commits to
2109 (GitTest.test_commitish_order): Added unit test for change to
2110 Git.commit_ids_from_commitish_arguments() in scm.py.
2112 2009-09-01 David Kilzer <ddkilzer@apple.com>
2114 <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
2116 Reviewed by David Levin.
2118 The mark-fixed subcommand is for those times when you don't use
2119 bugzilla-tool to commit a patch, but you want to use it to close
2120 the bug with a committed-revision message.
2122 * Scripts/bugzilla-tool:
2123 (bug_comment_from_svn_revision): Added. Extracted from
2124 bug_comment_from_commit_text().
2125 (bug_comment_from_commit_text): Extracted
2126 bug_comment_from_svn_revision() from this method.
2127 (MarkBugFixed.__init__): Added.
2128 (MarkBugFixed._fetch_commit_log): Added. Retrieves the commit
2129 log from the last commit if no svn revision is specified, else
2130 the commit log for the specified svn revision.
2131 (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
2132 Attempts to determine the bug id and svn revision if one or both
2133 were not defined on the command line.
2134 (MarkBugFixed.execute): Added. Adds a comment about the
2135 revision that fixed the bug and closes the bug.
2136 (BugzillaTool.__init__): Added mark-fixed subcommand.
2137 * Scripts/modules/bugzilla.py:
2138 (Bugzilla.fetch_title_from_bug): Added. Returns the title of a
2140 * Scripts/modules/scm.py:
2141 (SCM.strip_r_from_svn_revision): Added. Utility method to strip
2142 the leading 'r' from an svn revision.
2143 (SCM.svn_commit_log): Added. Subclasses must override.
2144 (SCM.last_svn_commit_log): Added. Subclasses must override.
2145 (SVN.svn_commit_log): Added. Returns svn log for a given
2147 (SVN.last_svn_commit_log): Added. Uses svnversion to find the
2148 last commit in an svn working directory and then runs svn log.
2149 (Git.svn_commit_log): Added. Returns svn log for a given
2151 (Git.last_svn_commit_log): Added. Runs git-svn-log with a limit
2154 2009-09-01 David Kilzer <ddkilzer@apple.com>
2156 <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2158 Reviewed by Brady Eidson.
2160 * Scripts/svn-apply:
2161 (applyPatch): Add "--force" to $options arrayref if $force is
2164 2009-09-01 David Kilzer <ddkilzer@apple.com>
2166 <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
2168 Reviewed by Adam Roben.
2170 When git-filter-branch has been invoked to rewrite ChangeLog
2171 files on series of git commits, it changes directories into
2172 .git-rewrite/t before re-running resolve-ChangeLogs. This
2173 causes determineVCSRoot() in VCSUtils.pm to return
2174 ".git-rewrite/t", which causes that path to be prepended to all
2175 ChangeLog paths, which results in an error like this:
2177 error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
2178 Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
2180 The correct way to fix this is not to try to find the repository
2181 root when invoked by git-filter-branch.
2183 * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
2184 set $relativePath to '.' instead of calling
2185 chdirReturningRelativePath(determineVCSRoot()).
2186 (isInGitFilterBranch): Added. Checks for the existence of the
2187 MAPPED_PREVIOUS_COMMIT environment variable.
2189 2009-09-01 Xan Lopez <xlopez@igalia.com>
2191 Reviewed by Gustavo Noronha.
2193 Add support for Fedora distros in the http tests
2194 https://bugs.webkit.org/show_bug.cgi?id=28263
2196 Add detection code for Fedora distribution, and use the proper
2197 httpd conf file when needed.
2199 * Scripts/run-webkit-httpd:
2200 * Scripts/run-webkit-tests:
2201 * Scripts/webkitdirs.pm:
2203 2009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>
2205 Reviewed by Eric Seidel.
2207 [Gtk] DRT needs implementation of overridePreference
2208 https://bugs.webkit.org/show_bug.cgi?id=28830
2210 Implement overridePreference.
2212 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2213 (resetDefaultsToConsistentValues):
2214 (setDefaultsToConsistentStateValuesForTesting):
2216 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2218 (LayoutTestController::overridePreference):
2220 2009-09-01 Joseph Pecoraro <joepeck@webkit.org>
2222 <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
2224 Reviewed by Eric Seidel.
2226 Jump back and forth between the repository root directory (to apply) and the
2227 directory the script was run from (to find the patch).
2229 * Scripts/svn-apply:
2230 * Scripts/svn-unapply:
2232 2009-08-31 Adam Roben <aroben@apple.com>
2234 Fall back to a Release version of Safari if a Debug one doesn't exist
2236 <http://webkit.org/b/28849>
2238 Reviewed by Sam Weinig.
2240 * Scripts/webkitdirs.pm:
2241 (safariPath): If the user is working with a Debug build, but there's
2242 no Debug version of Safari present, fall back to using a Release
2245 2009-08-31 Adam Roben <aroben@apple.com>
2247 Make safariPath() work for Debug builds of Safari on Windows
2249 <http://webkit.org/b/28849>
2251 Reviewed by Sam Weinig.
2253 * Scripts/webkitdirs.pm:
2254 (safariPath): If the user is working with a Debug build, add the
2255 _debug suffix to Safari.exe.
2257 2009-08-28 Eric Seidel <eric@webkit.org>
2259 Reviewed by Adam Barth.
2261 commit-queue needs a master process
2262 https://bugs.webkit.org/show_bug.cgi?id=28040
2264 Add a bugzilla-tool commit-queue command
2265 Keeps per-bug logs, but doesn't yet upload them anywhere.
2267 * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
2268 * Scripts/modules/buildbot.py: remove noisy log message
2269 * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
2271 2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>
2273 Reviewed by Gustavo Noronha.
2275 [GTK] Geolocation needs permission API before being enabled by default
2277 Build the Gtk port with geolocation enabled. This option is only
2278 enabled for the buildbot. The autotools option will be enabled by
2279 default once the permissions API is implemented.
2281 * Scripts/build-webkit:
2283 2009-08-26 Cameron McCormack <cam@mcc.id.au>
2285 Reviewed by David Kilzer.
2287 Make prepare-ChangeLog notice property changes
2288 https://bugs.webkit.org/show_bug.cgi?id=28675
2290 Make the generated ChangeLog entry include a short description of
2291 property changes if there were such changes. Also make
2292 prepare-ChangeLog not bail if the only changes are property changes.
2294 * Scripts/prepare-ChangeLog:
2296 2009-08-26 Adam Barth <abarth@webkit.org>
2298 Reviewed by Oliver Hunt.
2300 Don't let local files access web URLs
2301 https://bugs.webkit.org/show_bug.cgi?id=28480
2303 A bunch of our LayoutTests rely on our old behavior, so we explicitly
2304 grant local files universal access during testing. Mainly, these tests
2305 involve making XMLHttpRequests for data URLs.
2307 * DumpRenderTree/mac/DumpRenderTree.mm:
2308 (resetDefaultsToConsistentValues):
2309 * DumpRenderTree/qt/DumpRenderTree.cpp:
2310 (WebCore::WebPage::WebPage):
2311 * DumpRenderTree/win/DumpRenderTree.cpp:
2312 (resetDefaultsToConsistentValues):
2314 2009-08-26 John Gregg <johnnyg@google.com>
2316 Reviewed by David Levin.
2318 Minor style correction and include fix for notifications
2319 https://bugs.webkit.org/show_bug.cgi?id=28745
2321 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2322 change to correct EnumStyle
2323 (DRTDesktopNotificationPresenter::checkNotificationPermission):
2325 2009-08-26 David Levin <levin@chromium.org>
2327 Reviewed by Alexey Proskuryakov.
2329 XMLHttpRequest.withCredentials=false shouldn't save cookies.
2330 https://bugs.webkit.org/show_bug.cgi?id=28743
2332 Added the support to the layout test controller on OSX and
2333 Windows (for CFNETWORK) to allow for changing the accept cookie
2336 * DumpRenderTree/LayoutTestController.cpp:
2337 (LayoutTestController::LayoutTestController): Added a bool
2338 to track the state of accepting cookies.
2339 (setAlwaysAcceptCookiesCallback): Standard wrapper method
2340 to go from js to a C++ method.
2341 (LayoutTestController::staticFunctions): Added the
2342 setAlwaysAcceptCookies method to the js layoutTestController.
2343 * DumpRenderTree/LayoutTestController.h:
2344 (LayoutTestController::alwaysAcceptCookies): Returns the value.
2345 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2346 (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2347 * DumpRenderTree/mac/DumpRenderTree.mm:
2348 (resetDefaultsToConsistentValues): Reset the accept cookie to
2350 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2351 (LayoutTestController::setAlwaysAcceptCookies): Does the work for
2352 OSX to change the cookie accept policy.
2353 * DumpRenderTree/win/DumpRenderTree.cpp:
2354 (setAlwaysAcceptCookies): Method to handle all the calls necessary
2355 to change the accept cookie policy on Windows.
2356 (resetDefaultsToConsistentValues): Reset the accept cookie to
2358 * DumpRenderTree/win/DumpRenderTreeWin.h:
2359 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2360 (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2361 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2362 (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2364 2009-08-26 Dimitri Glazkov <dglazkov@chromium.org>
2368 Remove accidentally left in clobber option.
2369 https://bugs.webkit.org/show_bug.cgi?id=28400
2371 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
2373 2009-08-26 Dimitri Glazkov <dglazkov@chromium.org>
2375 Reviewed by Mark Rowe.
2377 Add canary-style Chromium WebKit build slave to the waterfall.
2378 https://bugs.webkit.org/show_bug.cgi?id=28400
2380 * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
2381 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
2383 2009-08-25 Cameron McCormack <cam@mcc.id.au>
2385 Reviewed by Darin Adler.
2387 make-script-test-wrappers should be executable
2388 https://bugs.webkit.org/show_bug.cgi?id=28669
2390 Make make-script-test-wrappers and update-sources-list.py both be
2393 * Scripts/update-sources-list.py:
2394 * Scripts/make-script-test-wrappers:
2396 2009-08-25 Brent Fulgham <bfulgham@webkit.org>
2400 Revise Debug_Cairo targets to point inherit from the
2401 debug_wincairo.vsprops property sheet so that they link
2402 against the proper libraries in Debug build.
2404 * DumpRenderTree/win/DumpRenderTree.vcproj:
2405 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2406 * WinLauncher/WinLauncher.vcproj:
2408 2009-08-25 David Levin <levin@chromium.org>
2410 Reviewed by Adam Roben.
2412 PLATFORM(CFNETWORK) should be USE(CFNETWORK).
2413 https://bugs.webkit.org/show_bug.cgi?id=28713
2415 * DumpRenderTree/win/DumpRenderTree.cpp:
2418 2009-08-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2420 Reviewed by Ariya Hidayat.
2422 [Qt/Mac] Use CONFIG+=build_all only when building libraries
2424 If no configuration is specified when building WebKit we pass the
2425 debug_and_release option to QMake which results in Makefiles for
2426 both configurations being generated.
2428 Previously we built both of these configurations by default, for
2429 all targets (both the QtWebKit framework/dyldlib and the various
2430 executables such as QtLauncher and tests). This makes sense for
2431 the libraries, which get the _debug suffix and can be loaded on
2432 demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
2433 ended up building the same executable twice.
2435 We now only build one instance of each executable, and since this
2436 is a developer build we build the debug-version. Passing either
2437 --debug or --release to build-webkit will override this, and
2438 even in the default case the release version can still be built
2439 by running 'make release' in the the build directory of each
2442 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2443 * Scripts/webkitdirs.pm:
2445 2009-08-24 Hironori Bono <hbono@chromium.org>
2447 Reviewed by Adam Barth.
2449 Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
2450 <https://bugs.webkit.org/show_bug.cgi?id=27827>.
2452 Because of the lack of mappings from GDK key-codes to WebKit key-codes,
2453 Chromium cannot send valid key-codes to JavaScript when a user types
2454 function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
2456 To write layout tests for this issue, added mappings from function-key
2457 names to platform-specific key-codes to EventSendingController objects
2458 so that eventSender.keyDown() can send function-key events without using
2459 platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
2460 is only for Mac. So this change adds this new test to Skipped tests for other
2461 platforms to prevent this change from crashing the build trees.)
2463 * DumpRenderTree/mac/EventSendingController.mm:
2464 (-[EventSendingController keyDown:withModifiers:]):
2466 2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
2468 Reviewed by Xan Lopez.
2470 [Gtk] API for disabling local file access to web URLs
2471 https://bugs.webkit.org/show_bug.cgi?id=28663
2473 Enable this setting for DRT.
2475 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2476 (resetWebViewToConsistentStateBeforeTesting):
2478 2009-08-22 Adam Barth <abarth@webkit.org>
2480 Revert 47684. We're going to do this later once clients have had a
2481 chance to opt into the setting they like.
2483 * DumpRenderTree/mac/DumpRenderTree.mm:
2484 (resetDefaultsToConsistentValues):
2485 * DumpRenderTree/qt/DumpRenderTree.cpp:
2486 (WebCore::WebPage::WebPage):
2487 * DumpRenderTree/win/DumpRenderTree.cpp:
2488 (resetDefaultsToConsistentValues):
2490 2009-08-22 Adam Barth <abarth@webkit.org>
2492 Reviewed by Eric Seidel.
2494 Don't let local files access web URLs
2495 https://bugs.webkit.org/show_bug.cgi?id=28480
2497 A bunch of our LayoutTests rely on our old behavior, so we explicitly
2498 grant local files universal access during testing. Mainly, these tests
2499 involve making XMLHttpRequests for data URLs.
2501 * DumpRenderTree/mac/DumpRenderTree.mm:
2502 (resetDefaultsToConsistentValues):
2503 * DumpRenderTree/qt/DumpRenderTree.cpp:
2504 (WebCore::WebPage::WebPage):
2505 * DumpRenderTree/win/DumpRenderTree.cpp:
2506 (resetDefaultsToConsistentValues):
2508 2009-08-22 Mark Rowe <mrowe@apple.com>
2510 Rubber-stamped by Anders Carlsson.
2512 Bring signed updates to the Mac nightly builds.
2514 * WebKitLauncher/Info.plist:
2515 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2516 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2517 (initializeSparkle):
2518 * WebKitLauncher/nightly.webkit.org.public.pem: Added.
2520 2009-08-21 Jan Michael Alonzo <jmalonzo@webkit.org>
2522 Rubberstamped by Simon Fraser.
2524 Remove GNOME keyring support in build-webkit. This dependency's
2525 already been removed in the Gtk port.
2527 * Scripts/build-webkit:
2529 2009-08-20 Brian Weinstein <bweinstein@apple.com>
2531 Reviewed by Adam Roben.
2532 Based on original patch by Stephanie Lewis.
2534 Added support of the Windows malloc history format to parse-malloc history, so we can
2537 * Scripts/parse-malloc-history:
2539 2009-08-20 Chris Fleizach <cfleizach@apple.com>
2541 Reviewed by Darin Adler.
2543 Enable various "grouping" ARIA roles
2544 https://bugs.webkit.org/show_bug.cgi?id=28486
2546 Expose the ability to retrieve the subrole through accessibility for DRT.
2548 * DumpRenderTree/AccessibilityUIElement.cpp:
2549 * DumpRenderTree/AccessibilityUIElement.h:
2550 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2551 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2552 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2554 2009-08-20 Joseph Pecoraro <joepeck@webkit.org>
2558 Added myself as a committer.
2560 * Scripts/modules/committers.py:
2562 2009-08-20 Xan Lopez <xlopez@igalia.com>
2564 Reviewed by Gustavo Noronha.
2568 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2569 (LayoutTestController::whiteListAccessFromOrigin):
2570 (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2571 (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2573 2009-08-20 Eric Seidel <eric@webkit.org>
2575 Reviewed by Adam Barth.
2577 bugzilla-tool post-diff can post partial diffs from SVN checkouts.
2578 https://bugs.webkit.org/show_bug.cgi?id=28445
2580 Pass the checkout root as the cwd. Also wrote a test to ensure this.
2582 * Scripts/modules/scm.py:
2583 * Scripts/modules/scm_unittest.py:
2585 2009-08-20 Mark Rowe <mrowe@apple.com>
2587 Reviewed by Adele Peterson.
2589 Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
2591 * DumpRenderTree/AccessibilityUIElement.cpp:
2592 (attributeValueCallback):
2594 2009-08-20 Ariya Hidayat <ariya.hidayat@nokia.com>
2596 Unreviewed, build fix.
2598 [Qt] The template-based qMax() compares two qreals.
2600 * DumpRenderTree/qt/ImageDiff.cpp:
2603 2009-08-20 David Levin <levin@chromium.org>
2605 Reviewed by David Kilzer.
2607 bugzilla-tool patch retrieval should handle 302 redirects.
2608 https://bugs.webkit.org/show_bug.cgi?id=28485
2610 * Scripts/modules/scm.py: Pass the --location parameter to curl
2611 so that 302's are followed.
2613 2009-08-20 Aaron Boodman <aa@chromium.org>
2615 One more speculative build for gtk.
2617 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2619 2009-08-20 Aaron Boodman <aa@chromium.org>
2621 Speculative build for gtk.
2623 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2624 (LayoutTestController::whiteListAccessFromOrigin):
2626 2009-08-20 Mark Rowe <mrowe@apple.com>
2628 Ignore some leaks that are known to originate from ImageIO.
2630 * Scripts/run-webkit-tests:
2632 2009-08-20 Aaron Boodman <aa@chromium.org>
2636 Speculative build fix for qt.
2638 * DumpRenderTree/qt/jsobjects.cpp:
2639 (LayoutTestController::whiteListAccessFromOrigin):
2640 * DumpRenderTree/qt/jsobjects.h:
2642 2009-08-19 Mark Rowe <mrowe@apple.com>
2644 Reviewed by Dan Bernstein.
2646 Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
2648 Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
2650 * Scripts/check-for-global-initializers:
2652 2009-08-19 Aaron Boodman <aa@chromium.org>
2654 Reviewed by David Levin.
2656 https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
2657 specify a more granular policy for cross-origin XHR access.
2659 * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
2660 (whiteListAccessFromOriginCallback): Ditto.
2661 (LayoutTestController::staticFunctions): Ditto.
2662 * DumpRenderTree/LayoutTestController.h: Ditto.
2663 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
2664 (LayoutTestController::whiteListAccessToOrigin): Ditto.
2665 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
2666 (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2667 * DumpRenderTree/qt/jsobjects.cpp: Ditto.
2668 (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2669 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
2670 (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2671 * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
2672 (resetWebViewToConsistentStateBeforeTesting): Ditto.
2673 * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
2674 (resetWebViewToConsistentStateBeforeTesting): Ditto.
2675 * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
2676 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
2678 2009-08-19 Mark Rowe <mrowe@apple.com>
2680 Rubber-stamped by Dan Bernstein.
2682 Ignore some leaks that are known to originate from QTKit.
2684 * Scripts/run-webkit-tests:
2686 2009-08-19 Eric Seidel <eric@webkit.org>
2688 Reviewed by Adam Barth.
2690 commit-queue/bugzilla-tool can get wedged if git is mid-rebase
2691 https://bugs.webkit.org/show_bug.cgi?id=28436
2693 Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
2694 This code will only ever be run when --force-clean is passed.
2696 I also added a new unit test to make sure this code actually works. :)
2698 * Scripts/modules/scm.py:
2699 * Scripts/modules/scm_unittest.py:
2701 2009-08-19 Eric Seidel <eric@webkit.org>
2703 Reviewed by David Levin.
2705 WebKit needs a changelogs.py to hold changelog-related code
2706 https://bugs.webkit.org/show_bug.cgi?id=28477
2708 This is moving code and adding tests. There was only one functional
2709 change (which was removing a trailing newline from the last_entry() result).
2711 * Scripts/bugzilla-tool:
2712 * Scripts/modules/changelogs.py: Added.
2713 * Scripts/modules/changelogs_unittest.py: Added.
2714 * Scripts/run-webkit-unittests:
2716 2009-08-20 Eric Seidel <eric@webkit.org>
2718 Reviewed by Adam Barth.
2720 bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
2721 https://bugs.webkit.org/show_bug.cgi?id=28222
2723 Basic support for now. This has been in testing for 24 hours now and worked great!
2725 * Scripts/bugzilla-tool:
2726 * Scripts/modules/buildbot.py: Added.
2727 * Scripts/modules/buildbot_unittest.py: Added.
2728 * Scripts/run-webkit-unittests:
2730 2009-08-19 Jan Michael Alonzo <jmalonzo@webkit.org>
2732 Reviewed by Gustavo Noronha.
2734 [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
2735 default timeout used by run-webkit-tests. Mac and Win ports were
2736 recently bumped in http://trac.webkit.org/changeset/r47465.
2738 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2739 (LayoutTestController::setWaitToDump):
2741 2009-08-19 David D. Kilzer <ddkilzer@webkit.org>
2743 DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
2745 Reviewed by Mark Rowe.
2747 Provide pre-generated swig source files for Tiger so it may
2748 benefit from the faster run-webkit-tests.
2750 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
2752 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
2754 (swig_type_info::SWIG_TypeNameComp):
2755 (swig_type_info::SWIG_TypeEquiv):
2756 (swig_type_info::SWIG_TypeRegisterTL):
2757 (swig_type_info::SWIG_TypeCheck):
2758 (swig_type_info::SWIG_TypeCast):
2759 (swig_type_info::SWIG_TypeDynamicCast):
2760 (swig_type_info::SWIG_TypeName):
2761 (swig_type_info::SWIG_TypePrettyName):
2762 (swig_type_info::SWIG_TypeQueryTL):
2763 (swig_type_info::SWIG_TypeClientDataTL):
2764 (swig_type_info::SWIG_PackData):
2765 (swig_type_info::SWIG_UnpackData):
2766 (swig_type_info::SWIG_PropagateClientDataTL):
2767 (swig_type_info::SWIG_PackVoidPtr):
2768 (swig_type_info::SWIG_UnpackVoidPtr):
2769 (swig_type_info::SWIG_PackDataName):
2770 (swig_type_info::SWIG_UnpackDataName):
2771 * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
2772 Tiger using pre-generated files.
2774 2009-08-18 Shinichiro Hamaji <hamaji@chromium.org>
2776 Reviewed by David Kilzer.
2778 run-webkit-tests hangs when WebCore tries to log too much
2779 https://bugs.webkit.org/show_bug.cgi?id=15743
2781 Read stdout and stderr in parallel.
2783 * Scripts/run-webkit-tests:
2785 2009-08-18 Mark Rowe <mrowe@apple.com>
2787 Rubber-stamped by Oliver Hunt.
2789 Add a new build configuration that checks for leaks during the layout tests,
2790 and hook a new machine up to it.
2792 * BuildSlaveSupport/build.webkit.org-config/config.json:
2793 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2795 2009-08-18 Aaron Boodman <aa@chromium.org>
2797 Reviewed by Maciej Stachowiak.
2799 https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
2801 No new tests: Already covered by existing tests.
2803 * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
2805 2009-08-18 Mark Rowe <mrowe@apple.com>
2807 Rubber-stamped by Geoff Garen.
2809 Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
2811 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2812 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2814 2009-08-18 Brian Weinstein <bweinstein@apple.com>
2816 Rubber-stamped by Adam Roben.
2818 Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
2819 and removed include to fix building on VC++ Express.
2821 * DumpRenderTree/win/UIDelegate.cpp:
2822 (UIDelegate::exceededDatabaseQuota):
2824 2009-08-18 Brian Weinstein <bweinstein@apple.com>
2826 Reviewed by Oliver Hunt.
2828 Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
2829 LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
2831 Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
2832 Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
2834 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2835 (LayoutTestController::setDatabaseQuota):
2836 * DumpRenderTree/win/UIDelegate.cpp:
2837 (UIDelegate::exceededDatabaseQuota):
2839 2009-08-18 Peter Kasting <pkasting@google.com>
2841 Reviewed by Eric Seidel.
2843 https://bugs.webkit.org/show_bug.cgi?id=28415
2844 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
2847 * record-memory-win/record-memory-win.vcproj:
2848 * WinLauncher/WinLauncher.vcproj:
2849 * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2850 * DumpRenderTree/win/ImageDiff.vcproj:
2851 * FindSafari/FindSafari.vcproj:
2853 2009-08-18 Drew Wilson <atwilson@google.com>
2855 Reviewed by Eric Seidel.
2857 Need to extend DumpRenderTree to expose number of worker threads
2858 https://bugs.webkit.org/show_bug.cgi?id=28292
2860 Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
2862 * DumpRenderTree/LayoutTestController.cpp:
2863 (getWorkerThreadCountCallback):
2864 (LayoutTestController::staticValues):
2865 * DumpRenderTree/LayoutTestController.h:
2866 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2867 (LayoutTestController::workerThreadCount):
2868 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2869 (LayoutTestController::workerThreadCount):
2870 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2871 (LayoutTestController::workerThreadCount):
2872 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2873 (LayoutTestController::workerThreadCount):
2875 2009-08-18 Xan Lopez <xlopez@igalia.com>
2877 Reviewed by Jan Alonzo.
2879 Initialize x and y in the GtkAllocation structure to shut up
2882 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2885 2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
2887 Reviewed by Darin Adler.
2889 Some HTMLs are modified by make-script-test-wrappers
2890 https://bugs.webkit.org/show_bug.cgi?id=28213
2892 Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
2893 the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
2894 re-generated wml/* and Geolocation/* .
2896 * Scripts/make-script-test-wrappers:
2898 2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
2900 Reviewed by Eric Seidel.
2902 -webkit-box-orient:horizontal doesn't work on <button> tag
2903 https://bugs.webkit.org/show_bug.cgi?id=34445
2905 Make a flexible button's anonymous child flexible and pass the
2906 parent's box-orient to the anonymous child.
2908 Also, added a renderName for anonymous flexible boxes.
2910 * Scripts/make-script-test-wrappers:
2912 2009-08-17 Eric Seidel <eric@webkit.org>
2914 Reviewed by Darin Adler.
2916 Can no longer --reset-results of a layout test directory
2917 https://bugs.webkit.org/show_bug.cgi?id=28336
2919 --reset-results and --exit-after-n-failures are incompatible.
2921 * Scripts/run-webkit-tests:
2923 2009-08-17 David Kilzer <ddkilzer@apple.com>
2925 <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
2927 Reviewed by Adam Roben.
2930 Committed r12345: <http://trac.webkit.org/changeset/12345>
2932 * Scripts/bugzilla-tool:
2933 (bug_comment_from_commit_text): Print out a compact,
2934 standardized commit message for both git and svn.
2936 2009-08-17 Peter Kasting <pkasting@google.com>
2938 Reviewed by Steve Falkenburg.
2940 https://bugs.webkit.org/show_bug.cgi?id=27323
2941 Only add Cygwin to the path when it isn't already there. This avoids
2942 causing problems for people who purposefully have non-Cygwin versions of
2943 executables like svn in front of the Cygwin ones in their paths.
2945 * DumpRenderTree/win/DumpRenderTree.vcproj:
2946 * DumpRenderTree/win/ImageDiff.vcproj:
2947 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2949 2009-08-17 David Kilzer <ddkilzer@apple.com>
2951 <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
2953 Reviewed by David Levin.
2955 * Scripts/modules/cpp_style.py:
2956 (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
2957 (check_max_min_macros): Added. Returns level 4 error when MAX()
2958 and MIN() macros are used in header files and C++ source files.
2959 (check_style): Added call to check_max_min_macros().
2960 * Scripts/modules/cpp_style_unittest.py: Added unit tests.
2961 (test_max_macro): Added.
2962 (test_min_macro): Added.
2964 2009-08-13 Mike Fenton <mike.fenton@torchmobile.com>
2966 Reviewed by Eric Seidel.
2968 Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
2969 and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
2971 https://bugs.webkit.org/show_bug.cgi?id=28268
2973 * platform/graphics/GraphicsContext.cpp:
2974 (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
2975 * platform/graphics/GraphicsContext.h:
2976 * platform/graphics/cairo/GraphicsContextCairo.cpp:
2977 * platform/graphics/qt/GraphicsContextQt.cpp:
2979 2009-08-10 Mike Fenton <mike.fenton@torchmobile.com>
2981 Reviewed by Adam Treat.
2983 Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
2986 https://bugs.webkit.org/show_bug.cgi?id=28161
2988 * DumpRenderTree/qt/jsobjects.cpp:
2991 (LayoutTestController::provisionalLoad):
2992 (LayoutTestController::timerEvent):
2993 (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2994 (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2995 (LayoutTestController::numberOfActiveAnimations):
2996 (EventSender::keyDown):
2997 (EventSender::frameUnderMouse):
2998 (TextInputController::doCommand):
3000 2009-08-16 David Kilzer <ddkilzer@apple.com>
3002 <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
3004 Reviewed by David Levin.
3006 In <http://webkit.org/b/28355#c1>, it was noted that new source
3007 files use 'using namespace std;' instead of individual
3008 'using std::foo;' statements. This adds a level 4 check for
3011 * Scripts/modules/cpp_style.py:
3012 (_ERROR_CATEGORIES): Added 'build/using_std'.
3013 (check_using_std): Added.
3014 (check_style): Added call to check_using_std().
3015 * Scripts/modules/cpp_style_unittest.py:
3016 (WebKitStyleTest.test_using_std): Added unit test.
3018 2009-08-16 David Kilzer <ddkilzer@apple.com>
3020 Backed out r47343 which was mistakenly committed
3022 * Scripts/bugzilla-tool:
3023 * Scripts/modules/scm.py:
3025 2009-08-16 David Kilzer <ddkilzer@apple.com>
3027 <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
3029 Reviewed by David Levin.
3031 The ScriptError class doesn't exist in bugzilla.py, so any
3032 errors print error messages about ScriptError instead of the
3035 NameError: global name 'ScriptError' is not defined
3037 * Scripts/modules/bugzilla.py:
3038 (BugzillaError): Added class. Modeled after ScriptError class
3040 (Bugzilla.authenticate): Changed to use BugzillaError instead of
3042 (Bugzilla._check_create_bug_response): Ditto.
3044 2009-08-14 Adam Bergkvist <adam.bergkvist@ericsson.com>
3046 Reviewed by Sam Weinig.
3048 Added EventSource to the build script (default on).
3049 https://bugs.webkit.org/show_bug.cgi?id=14997
3051 * Scripts/build-webkit:
3053 2009-08-15 Ryosuke Niwa <rniwa@webkit.org>
3057 Add myself to list of committers.
3059 * Scripts/modules/committers.py:
3061 2009-08-15 Jon Honeycutt <jhoneycutt@apple.com>
3063 Fix layout test failures after r47312.
3065 Reviewed by Cameron Zwarich.
3067 * DumpRenderTree/AccessibilityController.h:
3068 Replaced logFocusEvents() with setLogFocusEvents(), which takes a
3069 boolean argument to turn logging of focus events on or off.
3070 Added a function to reset the AccessibilityController to a consistent
3073 * DumpRenderTree/AccessibilityController.cpp:
3074 (logFocusEventsCallback):
3075 Call setLogFocusEvents() to enable logging.
3076 (AccessibilityController::resetToConsistentState):
3077 Call setLogFocusEvents() to disable logging.
3079 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3080 (AccessibilityController::setLogFocusEvents):
3083 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3084 (AccessibilityController::setLogFocusEvents):
3087 * DumpRenderTree/mac/DumpRenderTree.mm:
3088 (resetWebViewToConsistentStateBeforeTesting):
3089 Call the FrameLoadDelegate's resetToConsistentState method.
3091 * DumpRenderTree/mac/FrameLoadDelegate.h:
3092 Declare the resetToConsistentState method.
3094 * DumpRenderTree/mac/FrameLoadDelegate.mm:
3095 (-[FrameLoadDelegate resetToConsistentState]):
3096 Call the AccessibilityController's resetToConsistentState() function.
3098 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3099 (AccessibilityController::~AccessibilityController):
3100 Turn off focus event logging when the controller is destroyed.
3101 (AccessibilityController::setLogFocusEvents):
3102 If the caller passes false, unhook the focus event, and clear
3105 * DumpRenderTree/win/DumpRenderTree.cpp:
3106 (resetWebViewToConsistentStateBeforeTesting):
3107 Call the FrameLoadDelegate's resetToConsistentState function.
3109 * DumpRenderTree/win/FrameLoadDelegate.h:
3110 Declare the resetToConsistentState() function.
3112 * DumpRenderTree/win/FrameLoadDelegate.cpp:
3113 (FrameLoadDelegate::resetToConsistentState):
3114 Call the AccessibilityController's resetToConsistentState() function.
3117 2009-08-14 Jon Honeycutt <jhoneycutt@apple.com>
3119 Add a mechanism for logging MSAA focus events.
3121 Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
3124 https://bugs.webkit.org/show_bug.cgi?id=20866
3126 Reviewed by Oliver Hunt.
3128 * DumpRenderTree/AccessibilityController.cpp:
3129 (logFocusEventsCallback):
3130 Call the AccessibilityController's logFocusEvents() function.
3131 (AccessibilityController::getJSClass):
3132 Add a "logFocusEvents" function to the AccessibilityController's JS
3135 * DumpRenderTree/AccessibilityController.h:
3136 On Windows, include windows.h, and add a member variable to hold the
3137 handle to the event hook for focus events. Add a declaration for a
3138 function that enables logging of focus events.
3140 * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3141 (AccessibilityController::logFocusEvents):
3144 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3145 (AccessibilityController::logFocusEvents):
3148 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3149 (AccessibilityController::AccessibilityController):
3150 (AccessibilityController::~AccessibilityController):
3151 If we hooked the focus event, unhook it.
3152 (logFocusEventProc):
3153 When we receive a focus event, get the accessible object for the event,
3154 and log its name to stdout.
3155 (AccessibilityController::logFocusEvents):
3156 Setup the focus event hook to listen for events in the current process.
3158 2009-08-14 Eric Seidel <eric@webkit.org>
3160 No review. Fix 5-space indent to be 4-spaces.
3162 * Scripts/bugzilla-tool:
3164 2009-08-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
3166 Reviewed by Simon Hausmann.
3168 [Qt] Public API to configure the storage path for HTML5 localStorage
3169 https://bugs.webkit.org/show_bug.cgi?id=28036
3171 Turn on LocalStorage support for Qt DumpRenderTree since
3172 LocalStorage is now disabled by defult for QtWebkit.
3174 * DumpRenderTree/qt/DumpRenderTree.cpp:
3175 (WebCore::WebPage::WebPage):
3177 2009-08-14 Xan Lopez <xlopez@igalia.com>
3179 Reviewed by Jan Alonzo.
3181 Do not unref the main webview, it's owned by its parent
3182 container. Instead destroy the container, which should take care
3183 of everything (not terribly important since we exit right after
3186 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3189 2009-08-13 Eric Seidel <eric@webkit.org>
3191 No review, correcting obvious python error seen in the commit queue.
3193 args can be a string or an array. Assuming args is always an array results in
3194 double-spaced text in error logs.
3196 * Scripts/bugzilla-tool:
3198 2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3200 Unreviewed build fix. Include stdio.h for using stdout, stderr,
3203 * DumpRenderTree/LayoutTestController.cpp:
3205 2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>
3207 Reviewed by Eric Seidel.
3209 rename make-js-test-wrappers to make-script-test-wrappers
3210 https://bugs.webkit.org/show_bug.cgi?id=28212
3212 * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
3214 2009-08-13 Drew Wilson <atwilson@chromium.org>
3218 Add myself to list of committers.
3220 * Scripts/modules/committers.py:
3222 2009-08-13 John Sullivan <sullivan@apple.com>
3226 Add myself to list of committers.
3228 * Scripts/modules/committers.py:
3230 2009-08-13 Eric Seidel <eric@webkit.org>
3232 Correct spelling error in file name. No review.
3234 * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
3235 * Scripts/run-webkit-unittests:
3237 2009-08-13 Eric Seidel <eric@webkit.org>
3239 Reviewed by Simon Fraser.
3241 REGRESSION(r47175): error running run-webkit-tests
3242 https://bugs.webkit.org/show_bug.cgi?id=28261
3244 Fix "Use of uninitialized value in concatenation (.) or string at
3245 WebKitTools/Scripts/run-webkit-tests line 191." by setting
3246 $testsPerDumpTool to 1000 by default.
3248 * Scripts/run-webkit-tests:
3250 2009-08-13 Nate Chapin <japhet@chromium.org>
3254 Add myself to list of committers.
3256 * Scripts/modules/committers.py:
3258 2009-08-13 Brent Fulgham <bfulgham@webkit.org>
3262 Add 'Brent Fulgham' to the committers list.
3264 * Scripts/modules/committers.py:
3266 2009-08-13 Adam Langley <agl@chromium.org>
3268 Review not required.
3270 * Scripts/modules/committers.py:
3271 Adding myself to this list because Eric told me to.
3273 2009-08-13 Greg Bolsinga <bolsinga@apple.com>
3277 Add 'Greg Bolsinga' to the committers list.
3279 * Scripts/modules/committers.py:
3281 2009-08-13 Adam Roben <aroben@apple.com>
3283 Fix off-by-one result comparisons in media tests on Windows Debug
3286 media/video-played.html seems always to time out in Windows Debug
3287 builds. A race condition between media/video-test.js's "hang" timer and
3288 DumpRenderTree's built-in "watchdog" timer was causing results for
3289 media/video-played.html to be printed twice, causing all future media
3290 tests to be compared to the previous test's results.
3292 The fix is to make the watchdog timer got through the same code path
3293 as calling notifyDone manually, so that the results will only get
3294 printed once. A subsequent patch will remove video-test.js's hang
3295 timer entirely, since it is redundant.
3297 Fixes <http://webkit.org/b/28265>.
3299 Reviewed by Mark Rowe.
3301 * DumpRenderTree/LayoutTestController.cpp:
3302 (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
3303 from Gtk/Mac/Win's watchdog timer handlers, but we now call
3304 notifyDone() instead of dump() so that a subsequent call to
3305 notifyDone() won't print the results out again.
3307 * DumpRenderTree/LayoutTestController.h: Added
3308 waitToDumpWatchdogTimerFired.
3310 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3311 (waitToDumpWatchdogFired):
3312 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3313 (waitUntilDoneWatchdogFired):
3314 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3315 (waitUntilDoneWatchdogFired):
3316 Changed to call waitToDumpWatchdogTimerFired.
3318 2009-08-13 Eric Carlson <eric.carlson@apple.com>
3322 Added 'Eric Carlson' to the committers list.
3324 * Scripts/modules/committers.py:
3326 2009-08-13 Dirk Schulze <krit@webkit.org>
3329 Added 'Dirk Schulze' to the committers list.
3331 * Scripts/modules/committers.py:
3333 2009-08-13 Adam Roben <aroben@apple.com>
3335 Enable running testapi in run-javascriptcore-tests on Windows
3337 Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run
3340 Reviewed by Mark Rowe.
3342 * Scripts/run-javascriptcore-tests: Allow testapi to run if we're in
3343 the AppleWinWebKit configuration.
3345 2009-08-13 Adam Roben <aroben@apple.com>
3347 Re-enable testapi in run-javascriptcore-tests on Mac
3349 This seems to have been mistakenly disabled in r47089.
3351 Rubber-stamped by Mark Rowe.
3353 * Scripts/run-javascriptcore-tests: Removed comment markers that were
3354 preventing running testapi.
3356 2009-08-12 George Staikos <george.staikos@torchmobile.com>
3358 Reviewed by Adam Treat.
3360 Enable WCSS and XHTML-MP flags for build-webkit.
3362 * Scripts/build-webkit:
3364 2009-08-12 David Kilzer <ddkilzer@apple.com>
3366 run-webkit-tests: document --nthly flag in help message
3368 Reviewed by Simon Fraser.
3370 * Scripts/run-webkit-tests: Added --nthly flag to $usage string.
3371 Also noted that -1|--singly implies --nthly 1.
3373 2009-08-12 Eric Seidel <eric@webkit.org>
3375 No review, just fixing mismerged ChangeLogs.
3377 2009-08-12 Eric Seidel <eric@webkit.org>
3379 Reviewed by Mark Rowe.
3381 run-webkit-tests needs a --exit-after-failures=N option
3382 https://bugs.webkit.org/show_bug.cgi?id=28192
3384 Added the option and deployed it to bugzilla-tool.
3386 * Scripts/bugzilla-tool:
3387 * Scripts/run-webkit-tests:
3389 2009-08-11 Eric Seidel <eric@webkit.org>
3391 Reviewed by Mark Rowe.
3393 bugzilla-tool : various improvements for running the commit-queue
3394 https://bugs.webkit.org/show_bug.cgi?id=28199
3396 Make run_and_throw_if_fail silence STDERR as well as STDIN.
3397 I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
3398 Change a few "print" statements to "log" so they appear in the output.
3399 Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
3400 Added a little more logging so that --quiet mode is easier to understand.
3401 Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
3402 Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
3403 Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
3404 Made curl call (downloading patch files) quieter.
3406 * Scripts/bugzilla-tool:
3407 * Scripts/modules/bugzilla.py:
3408 * Scripts/modules/scm.py:
3410 2009-08-12 Peter Kasting <pkasting@google.com>
3412 Reviewed by Darin Adler.
3414 https://bugs.webkit.org/show_bug.cgi?id=27323
3415 Change pattern that strips all trailing whitespace to just remove EOL
3416 chars (\r, \n), to make it clear that varying EOL chars is the primary
3417 problem being solved.
3419 * Scripts/prepare-ChangeLog:
3420 * Scripts/resolve-ChangeLogs:
3421 * Scripts/svn-create-patch:
3422 * Scripts/update-webkit:
3424 2009-08-12 Kevin Ollivier <kevino@theolliviers.com>
3426 wx waf build fix, add new directories to the build.
3428 * wx/build/settings.py:
3430 2009-08-11 Adam Roben <aroben@apple.com>
3432 Update DumpRenderTree for IWebUIDelegatePrivate changes
3434 Reviewed by Dave Hyatt.
3436 * DumpRenderTree/win/UIDelegate.h: Updated to match
3437 IWebUIDelegatePrivate.
3439 2009-08-12 Adam Roben <aroben@apple.com>
3441 Don't try to seek to the end of stdin on Cygwin
3443 Doing so seems to always cause an exception (for unknown reasons).
3445 Fixes <http://webkit.org/b/28159> create-bug throws an exception in
3448 Reviewed by Dave Kilzer.
3450 * Scripts/bugzilla-tool:
3451 (CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
3452 generated by calling sys.stdin.seek, since these seem to be generated
3453 for no good reason on Cygwin.
3455 2009-08-12 Adam Roben <aroben@apple.com>
3457 Don't raise an exception when --cc is not passed to create-bug
3459 Fixes <http://webkit.org/b/28158> create-bug throws an exception if
3460 --cc is not specified
3462 Reviewed by Dave Kilzer.
3464 * Scripts/modules/bugzilla.py:
3465 (Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
3466 string was specified. Otherwise we'll generate an exception about the
3467 "cc" variable not being a string.
3469 2009-08-11 Eric Seidel <eric@webkit.org>
3471 Reviewed by Adam Barth.
3473 bugzilla-tool : various improvements for running the commit-queue
3474 https://bugs.webkit.org/show_bug.cgi?id=28199
3476 Make run_and_throw_if_fail silence STDERR as well as STDIN.
3477 I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
3478 Change a few "print" statements to "log" so they appear in the output.
3479 Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
3480 Added a little more logging so that --quiet mode is easier to understand.
3481 Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
3482 Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
3483 Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
3484 Made curl call (downloading patch files) quieter.
3486 * Scripts/bugzilla-tool:
3487 * Scripts/modules/bugzilla.py:
3488 * Scripts/modules/scm.py:
3490 2009-08-11 Eric Seidel <eric@webkit.org>
3492 No review, script regression fix only.
3494 run-webkit-tests --quiet hangs
3495 https://bugs.webkit.org/show_bug.cgi?id=28202
3497 Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
3498 This was what I came up with after discussions in #perl.
3500 * Scripts/run-webkit-tests:
3502 2009-08-11 John Gregg <johnnyg@google.com>
3504 Reviewed by Maciej Stachowiak.
3506 Switch DumpRenderTree to contain a WebUIDelegate2, which extends
3507 WebUIDelegate, so that the notifications tests will still work.
3508 https://bugs.webkit.org/show_bug.cgi?id=28198
3510 * DumpRenderTree/win/UIDelegate.h:
3512 2009-08-11 Darin Adler <darin@apple.com>
3514 Try to fix GTK build.
3516 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3517 (AccessibilityUIElement::stringForRange): Added.
3519 2009-08-10 Mike Fenton <mike.fenton@torchmobile.com>
3521 Reviewed by Adam Treat.
3523 Add processing for string constants used by the tests to trigger
3524 common actions like up, down, left, right, etc. for the Qt
3525 implementation of DumpRenderTree.
3527 Note this allows fast/forms/textarea-arrow-navigation.html to pass
3530 https://bugs.webkit.org/show_bug.cgi?id=28161
3532 * DumpRenderTree/qt/jsobjects.cpp:
3533 (EventSender::keyDown):
3535 2009-08-11 Chris Fleizach <cfleizach@apple.com>
3537 Reviewed by Darin Adler.
3539 Bug 28200 - ListMarker should be included as part of the text value to parse
3540 https://bugs.webkit.org/show_bug.cgi?id=28200
3542 Add the ability to retrieve a string given a plain NSRange.
3544 * DumpRenderTree/AccessibilityUIElement.cpp:
3545 (stringForRangeCallback):
3546 (AccessibilityUIElement::getJSClass):
3547 * DumpRenderTree/AccessibilityUIElement.h:
3548 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3549 (AccessibilityUIElement::valueDescription):
3550 (AccessibilityUIElement::stringForRange):
3551 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3552 (AccessibilityUIElement::stringForRange):
3554 2009-08-11 Dmitry Titov <dimich@chromium.org>
3556 Reviewed by NOBODY (Speculative fix for the layout test failure).
3558 Fix fast/dom/prototype-inheritance.html
3559 and fast/dom/prototype-inheritance-2.html
3560 broken on Windows by http://trac.webkit.org/changeset/47018
3562 * DumpRenderTree/win/DumpRenderTree.cpp:
3563 (resetDefaultsToConsistentValues): enable app cache in Windows DRT.
3565 2009-08-11 Eric Seidel <eric@webkit.org>
3567 Reviewed by Adam Barth.
3569 bugzilla-tool: Re-factor shared landing logic into helper class to share more code
3570 https://bugs.webkit.org/show_bug.cgi?id=28193
3572 Added new WebKitLandingScripts class to hold this shared logic.
3573 Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core.
3575 * Scripts/bugzilla-tool:
3577 2009-08-11 Kenneth Rohde Christiansen <kenneth@webkit.org>
3579 Reviewed by Adam Treat.
3581 Fix the current failures on the buildbot.
3583 As Qt hooks up the maybeDump to loadFinished, we need to make
3584 sure that calling dump() will not call maybeDump on loadFinished.
3586 As dump is called my emitting done() which calls dump() and then
3587 setting m_isLoading to false. So in the case m_isLoading is false,
3590 The current code is confusing, and should be made more clear
3593 * DumpRenderTree/qt/jsobjects.cpp:
3594 (LayoutTestController::maybeDump):
3595 (LayoutTestController::notifyDone):
3597 2009-08-11 John Gregg <johnnyg@google.com>
3599 Reviewed by Maciej Stachowiak.
3601 Add support for desktop notifications API to DumpRenderTree,
3602 and support for ENABLE_NOTIFICATIONS flag to build-webkit.
3604 * DumpRenderTree/LayoutTestController.cpp:
3605 (grantDesktopNotificationPermissionCallback):
3606 (LayoutTestController::staticFunctions):
3607 (LayoutTestController::grantDesktopNotificationPermission):
3608 (LayoutTestController::checkDesktopNotificationPermission):
3609 * DumpRenderTree/LayoutTestController.h:
3610 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added.
3611 (DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter):
3612 (DRTDesktopNotificationPresenter::QueryInterface):
3613 (DRTDesktopNotificationPresenter::AddRef):
3614 (DRTDesktopNotificationPresenter::Release):
3615 (DRTDesktopNotificationPresenter::showDesktopNotification):
3616 (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3617 (DRTDesktopNotificationPresenter::notificationDestroyed):
3618 (DRTDesktopNotificationPresenter::checkNotificationPermission):
3619 (DRTDesktopNotificationPresenter::requestNotificationPermission):
3620 * DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added.
3621 * DumpRenderTree/win/DumpRenderTree.vcproj:
3622 * DumpRenderTree/win/UIDelegate.cpp:
3623 (UIDelegate::UIDelegate):
3624 (UIDelegate::desktopNotificationsDelegate):
3625 * DumpRenderTree/win/UIDelegate.h:
3626 * Scripts/build-webkit:
3628 2009-08-11 Peter Kasting <pkasting@google.com>
3630 Reviewed by Darin Adler.
3632 https://bugs.webkit.org/show_bug.cgi?id=27323
3633 Handle arbitrary line endings when manufacturing patches for additions
3636 * Scripts/svn-create-patch:
3638 2009-08-11 Peter Kasting <pkasting@google.com>
3640 Reviewed by Darin Adler.
3642 https://bugs.webkit.org/show_bug.cgi?id=28183
3643 Support VS2008 as well as VS2005 in a few scripts.
3645 * Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS.