WebCore:
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
2
3         Reviewed by Oliver.
4
5         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
6
7         * DumpRenderTree/win/EventSender.cpp:
8         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
9         of 1, even though WebKit currently ignores it.
10
11 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
12
13         wx buildbot fix. Update libpng dl script to the latest version.
14
15         * wx/install-unix-extras:
16
17 2007-12-22  Antti Koivisto  <antti@apple.com>
18
19         Fix a typo.
20
21         * Scripts/webkitdirs.pm:
22
23 2007-12-21  Sam Weinig  <sam@webkit.org>
24
25         Reviewed by Mark Rowe.
26
27         - Disable the back/forward cache using the new WebPreferences API
28           instead of through the BackForwardList.  This makes us match what
29           we do on Windows.
30
31         * DumpRenderTree/mac/DumpRenderTree.mm:
32         (createWebViewAndOffscreenWindow):
33         (setDefaultsToConsistentValuesForTesting):
34
35 2007-12-21  Dan Bernstein  <mitz@apple.com>
36
37         Reviewed by Mark Rowe.
38
39         - disable the back/forward cache in Windows DumpRenderTree. It is
40           already disabled in Mac DumpRenderTree.
41
42         * DumpRenderTree/win/DumpRenderTree.cpp:
43         (initializePreferences):
44
45 2007-12-13  Antti Koivisto  <antti@apple.com>
46
47         Reviewed by Darin and Steve.
48         
49         - check for QuickTime SDK on Windows.
50         - build media support on Windows by default
51
52         * Scripts/build-webkit:
53         * Scripts/webkitdirs.pm:
54
55 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
56
57         Build script fix for buildbot.
58
59         * wx/build-wxwebkit:
60
61 2007-12-20  Eric Seidel  <eric@webkit.org>
62
63         Reviewed by mjs.
64
65         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
66
67 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
68
69         Reviewed by Steve.
70
71         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
72         WebKit.
73
74         - Drosera and Safari need to use the same ProgIDs in order for
75         CoCreateInstance to work properly.  The most robust way to do this is
76         for WebKit to dynamically publish those ProgIDs.
77
78         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
79         (DebuggerClient::createWebViewWithRequest):
80         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
81         statics.
82         (Drosera::initUI):
83         (Drosera::attach):
84         (Drosera::attemptToCreateServerConnection):
85         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
86         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
87         make use of the published ProgIDs.
88         (ServerConnection::attemptToCreateServerConnection):
89
90 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
91
92         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
93         - Build bot and leak fix.
94
95         * DumpRenderTree/LayoutTestController.cpp:
96         (pathToLocalResourceCallback):
97
98 2007-12-19  David Kilzer  <ddkilzer@apple.com>
99
100         Make svn-apply/svn-unapply work with patches from git-format-patch.
101
102         Reviewed by Darin.
103
104         * Scripts/svn-apply:
105         (patch): If 'Index:' can't be found in the text passed in, print it
106         out with a warning and return early.
107         * Scripts/svn-unapply:
108         (patch): Ditto.
109
110 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
111
112         Reviewed by Alp Toker.
113
114         Build related fixes.
115
116         * wx/build-wxwebkit:
117         - Check to make sure the user is running a supported wx port
118         - More robust checks for Cygwin
119         - Only run install-unix-extras on Mac, it's not the right solution
120           for Linux distros.
121         - Remove outdated Linux instructions after successful build
122         - Clean Bakefile-generated files during a clean operation
123
124 2007-12-18  Darin Adler  <darin@apple.com>
125
126         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
127
128 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
129
130         Add script to run Drosera as part of the nightly.
131         
132         Reviewed by Kevin M.
133
134         * Scripts/run-drosera.cmd: Added.
135
136 2007-12-18  Darin Adler  <darin@apple.com>
137
138         * Scripts/do-webcore-rename: Remove a stray K.
139
140 2007-12-18  Darin Adler  <darin@apple.com>
141
142         * Scripts/do-webcore-rename: Plan more renaming.
143
144 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
145
146         Reviewed by Alp Toker.
147
148         http://bugs.webkit.org/show_bug.cgi?id=16042
149         [GTK] Eliminate webkit_init()
150
151         Moving webkit initialization to WebView class init.
152
153         * DumpRenderTree/gtk/DumpRenderTree.cpp:
154         (main):
155         * GtkLauncher/main.c:
156         (main):
157
158 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
159
160         Reviewed by Alp Toker.
161
162         http://bugs.webkit.org/show_bug.cgi?id=13542
163         gdklauncher doesnt change URL in adress GTKEntry.
164
165         * GtkLauncher/main.c:
166         (load_commit_cb): added
167         (title_change_cb):
168         (create_browser):
169
170 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
171
172         Reviewed by Adam Roben.
173
174         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
175
176         * FindSafari/FindSafari.cpp:
177         (_tmain):
178
179 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
180
181         Reviewed by Adam Roben.
182
183         http://bugs.webkit.org/show_bug.cgi?id=16315
184         FindSafari needs a path-only option.
185
186         * FindSafari/FindSafari.cpp:
187         (_tmain):
188
189 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
190
191         Reviewed by Darin.
192
193         http://bugs.webkit.org/show_bug.cgi?id=16462
194         REGRESSION: access keys broken on Windows
195
196         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
197         if Alt is pressed.
198
199 2007-12-15  Sam Weinig  <sam@webkit.org>
200
201         Reviewed by Mark Rowe.
202
203         Fix urlSuitableForTestResult to correctly identify wstring::npos as
204         the case when wstring.find doesn't find anything.
205
206         * DumpRenderTree/win/DumpRenderTree.cpp:
207         (urlSuitableForTestResult):
208
209 2007-12-15  Alp Toker  <alp@atoker.com>
210
211         GTK+ DRT build fix for GLib < 2.14.
212
213         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
214         (LayoutTestController::setWaitToDump):
215
216 2007-12-05  Mark Rowe  <mrowe@apple.com>
217
218         Reviewed by Alp Toker.
219
220         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
221         many layout tests from hanging while waiting on user responses to dialogs.
222
223         * DumpRenderTree/gtk/DumpRenderTree.cpp:
224         (invalidateAnyPreviousWaitToDumpWatchdog):
225         (webViewScriptAlert):
226         (webViewScriptPrompt):
227         (webViewScriptConfirm):
228         (main):
229         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
230         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
231         (waitToDumpWatchdogFired):
232         (LayoutTestController::setWaitToDump):
233
234 2007-12-05  Mark Rowe  <mrowe@apple.com>
235
236         Reviewed by Alp Toker.
237
238         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
239
240         * DumpRenderTree/gtk/DumpRenderTree.cpp:
241         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
242         (dump):
243         (runTest):
244         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
245         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
246         work queue is empty.
247         (webViewWindowObjectCleared): Set up window.layoutTestController.
248         (webViewConsoleMessage): Match the console message format expected by the layout test results.
249         (main): Hook up the new signals.
250         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
251         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
252         dumping multiple times.
253         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
254         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
255
256 2007-12-14  Anders Carlsson  <andersca@apple.com>
257
258         Reviewed by Brady.
259
260         Assert that a web frame that's loading a resource always has either a data source or 
261         a provisional data source.
262         
263         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
264         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
265
266 2007-12-14  Darin Adler  <darin@apple.com>
267
268         - fix mistake causing nearly all tests to fail on Windows
269
270         * DumpRenderTree/win/UIDelegate.cpp:
271         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
272         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
273
274         * DumpRenderTree/mac/UIDelegate.mm:
275         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
276         than passing the entire message.
277
278 2007-12-14  Darin Adler  <darin@apple.com>
279
280         - fix Tiger build
281
282         * DumpRenderTree/mac/UIDelegate.mm:
283         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
284         new-to-Leopard methods.
285
286 2007-12-14  Darin Adler  <darin@apple.com>
287
288         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
289         since it now triggers unwanted icon loading. We only had it because we implemented "all"
290         delegate methods here.
291
292 2007-12-14  Anders Carlsson  <andersca@apple.com>
293
294         Reviewed by Darin and Geoff.
295
296         <rdar://problem/5619295> 
297         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
298         
299         Add property getting methods to the plug-in.
300         
301         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
302         (pluginInvoke):
303
304 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
305
306         Reviewed by Darin.
307
308         - Layout test fix for mac. When dumped to the console local file paths
309         now only show the name of the resource not the whole path.  This is to
310         make the results machine and OS independent.
311
312         * DumpRenderTree/mac/UIDelegate.mm:
313         (-[UIDelegate webView:addMessageToConsole:]):
314
315 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
316
317         Reviewed by Adam.
318
319         - Layout tests fix.  We need a way to remove machine-dependent
320         information from paths in layout test results. The UIDelegate now does
321         this.
322
323         * DumpRenderTree/DumpRenderTree.h:
324         * DumpRenderTree/win/DumpRenderTree.cpp:
325         (urlSuitableForTestResult):
326         * DumpRenderTree/win/DumpRenderTreeWin.h:
327         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
328         * DumpRenderTree/win/UIDelegate.cpp:
329         (UIDelegate::webViewAddMessageToConsole):
330
331 2007-12-13  Alp Toker  <alp@atoker.com>
332
333         Build fix for DRT breakage introduced in r28690.
334
335         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
336         (LayoutTestController::pathToLocalResource):
337
338 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
339
340         Reviewed by Alice and Sam.
341
342         - <rdar://5621435> Need a way to specify local resources (being loaded
343         from HTTP tests) on Windows.
344         - Implemented pathToLocalResource which exposes the functionality of
345         converting a given unix path to the correct location on Windows.
346
347         * DumpRenderTree/LayoutTestController.cpp:
348         (pathToLocalResourceCallback):
349         (LayoutTestController::staticFunctions):
350         * DumpRenderTree/LayoutTestController.h:
351         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
352         (LayoutTestController::pathToLocalResource):
353         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
354         (LayoutTestController::pathToLocalResource):
355
356 2007-12-12  Anders Carlsson  <andersca@apple.com>
357
358         Reviewed by Sam.
359
360         <rdar://problem/5132003>
361         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
362
363         * DumpRenderTree/win/DumpRenderTree.cpp:
364         (main):
365         Set the resource load delegate.
366         
367         * DumpRenderTree/win/DumpRenderTree.vcproj:
368         
369         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
370         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
371
372 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
373
374         Reviewed by Adam Roben.
375
376         Fix conversion from double to LPARAM in dispatchMessage().
377
378         * DumpRenderTree/win/EventSender.cpp:
379         (dispatchMessageCallback):
380
381 2007-12-11  Dan Bernstein  <mitz@apple.com>
382
383         Reviewed by Mark Rowe and Sam Weinig too!
384
385         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
386           fonts DumpRenderTree registers.
387
388         * DumpRenderTree/win/DumpRenderTree.cpp:
389         (initialize):
390
391 2007-12-11  Brady Eidson  <beidson@apple.com>
392
393         Reviewed by Anders
394
395         Make DumpRenderTree on mac use its own path for Databases testing
396
397         * DumpRenderTree/mac/DumpRenderTree.mm:
398         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
399           for future DRT-only use, then use it to construct the Databases path and set that default
400
401 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
402
403         Reviewed by Darin.
404
405         <rdar://problem/5535636>
406         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
407
408         http://bugs.webkit.org/show_bug.cgi?id=13916
409         JavaScript detects Tab as a character input on a textfield validation
410
411         * DumpRenderTree/mac/EventSendingController.mm:
412         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
413         Dispatch a keyup to better match what happens when a key is physically pressed.
414
415         * DumpRenderTree/win/EventSender.cpp:
416         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
417         returning from keyDown().
418         (getConstantCallback): Fixed a couple copy/paste mistakes.
419
420 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
421
422         Reviewed by Oliver.
423
424         - <rdar://5599845> Drosera: Does not show loal files in the file list
425         on the left side.
426
427         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
428         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
429         so the open source community can build.
430
431 2007-12-10  Brady Eidson  <beidson@apple.com>
432
433         Rubberstamped by Sam Weinig
434
435         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
436
437         * DumpRenderTree/mac/UIDelegate.mm:
438         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
439         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
440
441 2007-12-08  Oliver Hunt  <oliver@apple.com>
442
443         Reviewed by Sam W.
444
445         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
446         
447         Fixes <rdar://problem/5620249> Must disable SVG animation
448         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
449         
450         In order to allow finer grained control over the set of SVG features
451         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
452         distinct flags:
453         ENABLE_SVG_ANIMATION
454         ENABLE_SVG_FILTERS
455         ENABLE_SVG_FONTS
456         ENABLE_SVG_AS_IMAGE
457         ENABLE_SVG_USE
458         
459         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
460         
461         Script handles all the new build flags, and allows --svg-experimental
462         to automatically enable all features.
463
464         * Scripts/build-webkit:
465
466 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
467
468         Fix version parsing.
469
470         Rubber-stamped by Oliver.
471
472         * Drosera/win/Drosera.vcproj/auto-version.sh:
473
474 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
475
476         Build modifications for Drosera.
477
478         Reviewed by Adam.
479
480         * Drosera/DroseraWin.make: Added.
481         * Drosera/win/Drosera.vcproj/Drosera.rc:
482         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
483         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
484         * Drosera/win/Drosera.vcproj/VERSION: Added.
485         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
486
487 2007-12-06  Adam Roben  <aroben@apple.com>
488
489         Explicitly turn on the Mac font ascent hack on Windows
490
491         This keeps our font metrics matching those from Mac.
492
493         Reviewed by Hyatt.
494
495         * DumpRenderTree/win/DumpRenderTree.cpp:
496         (main):
497
498 2007-12-06  Anders Carlsson  <andersca@apple.com>
499
500         Rename main.c to main.cpp here too.
501         
502         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
503
504 2007-12-06  Sam Weinig  <sam@webkit.org>
505
506         Rubber stamped by Geoff.
507
508         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
509
510 2007-12-06  Darin Adler  <darin@apple.com>
511
512         * Scripts/do-webcore-rename: Some more renaming plans.
513
514 2007-12-06  Anders Carlsson  <andersca@apple.com>
515
516         Restore implementation of testGetIntIdentifier that was accidentally
517         removed somehow (possibly when I made PluginObject be a cpp file).
518         
519         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
520         (pluginInvoke):
521
522 2007-12-05  Anders Carlsson  <andersca@apple.com>
523
524         Make the entry points extern "C".
525         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
526         
527 2007-12-05  Anders Carlsson  <andersca@apple.com>
528
529         C++ warning fixes.
530         
531         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
532         (NPP_New):
533         (NPP_Destroy):
534         (NPP_SetWindow):
535         (NPP_NewStream):
536         (NPP_HandleEvent):
537         (NPP_URLNotify):
538         (NPP_GetValue):
539
540 2007-12-05  Anders Carlsson  <andersca@apple.com>
541
542         Add the .cpp files to the TestNetscapePlugIn target.
543
544         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
545
546 2007-12-05  Anders Carlsson  <andersca@apple.com>
547
548         Reviewed by Geoff.
549         
550         Rename the TestNetscapePlugIn .c files to be .cpp.
551
552         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
553         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
554         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
555         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
556         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
557         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
558         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
559         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
560
561 2007-12-05  Adam Roben  <aroben@apple.com>
562
563         Fix case of keypresses from the Windows implementation of eventSender.keyDown
564
565         This fixes several regression tests.
566
567         Reviewed by Alice.
568
569         * DumpRenderTree/win/EventSender.cpp:
570         (keyDownCallback): Virtual keycodes for ASCII characters are always
571         uppercase, so we need to check the case of the original character
572         passed in to eventSender.keyDown.
573
574 2007-12-05  Adam Roben  <aroben@apple.com>
575
576         Learn from Tim's mistakes
577
578         * DumpRenderTree/win/DumpRenderTree.cpp:
579         (runTest): Reset the authorAndUserStylesEnabled preference for each
580         test.
581
582 2007-12-05  Alp Toker  <alp@atoker.com>
583
584         Reviewed by Mark Rowe.
585
586         Initialize GTK+ and WebKit so the tests can run.
587
588         Reorganize the headers a little.
589
590         * DumpRenderTree/gtk/DumpRenderTree.cpp:
591         (main):
592
593 2007-12-04  Anders Carlsson  <andersca@apple.com>
594
595         Remove IWebScriptScope include.
596         
597         * Drosera/win/DebuggerDocumentPlatform.cpp:
598
599 2007-12-04  Sam Weinig  <sam@webkit.org>
600
601         Rubber stamped by Mark Rowe.
602
603         Define CF as platform for mac and revert r28409
604
605         * DumpRenderTree/DumpRenderTree.h:
606         * DumpRenderTree/mac/DumpRenderTreeMac.h:
607
608 2007-12-04  Sam Weinig  <sam@webkit.org>
609
610         Define CF as platform for windows.
611
612         Reviewed by Adam Roben.
613
614         * DumpRenderTree/win/DumpRenderTreeWin.h:
615
616 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
617
618         Reviewed by Adam and Darin.
619
620         - Removed a needless BSTR cleanup.
621
622         * Drosera/win/DebuggerDocumentPlatform.cpp:
623         (DebuggerDocument::getPlatformCurrentFunctionStack):
624
625 2007-11-27  Adam Roben  <aroben@apple.com>
626
627         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
628
629         Reviewed by Maciej.
630
631         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
632         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
633
634 2007-12-04  Alp Toker  <alp@atoker.com>
635
636         Prospective Win DRT build fix.
637
638         * DumpRenderTree/DumpRenderTree.h:
639
640 2007-12-04  Alp Toker  <alp@atoker.com>
641
642         Fix a clobbered copyright header.
643
644         * DumpRenderTree/gtk/DumpRenderTree.cpp:
645
646 2007-12-04  Xan Lopez  <xan@gnome.org>
647
648         Reviewed by Alp Toker.
649
650         http://bugs.webkit.org/show_bug.cgi?id=15561
651         GTK port needs DumpRenderTree implementation
652
653         Start work on the GTK+ DRT.
654
655         This does not work yet, and there are a few lingering style issues
656         (nothing major) but this patch has been stuck in the bug tracker for
657         too long already.
658
659         * DumpRenderTree/DumpRenderTree.h:
660         * DumpRenderTree/gtk: Added.
661         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
662         (autocorrectURL):
663         (shouldLogFrameLoadDelegates):
664         (dumpFrameScrollPosition):
665         (displayWebView):
666         (appendString):
667         (dumpFramesAsText):
668         (dumpRenderTreeAsText):
669         (dump):
670         (runTest):
671         (main):
672         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
673         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
674         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
675         (GCController::collect):
676         (GCController::collectOnAlternateThread):
677         (GCController::getJSObjectCount):
678         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
679         (LayoutTestController::~LayoutTestController):
680         (LayoutTestController::addDisallowedURL):
681         (LayoutTestController::clearBackForwardList):
682         (LayoutTestController::copyDecodedHostName):
683         (LayoutTestController::copyEncodedHostName):
684         (LayoutTestController::display):
685         (LayoutTestController::keepWebHistory):
686         (LayoutTestController::notifyDone):
687         (LayoutTestController::queueBackNavigation):
688         (LayoutTestController::queueForwardNavigation):
689         (LayoutTestController::queueLoad):
690         (LayoutTestController::queueReload):
691         (LayoutTestController::queueScript):
692         (LayoutTestController::setAcceptsEditing):
693         (LayoutTestController::setCustomPolicyDelegate):
694         (LayoutTestController::setMainFrameIsFirstResponder):
695         (LayoutTestController::setTabKeyCyclesThroughElements):
696         (LayoutTestController::setUseDashboardCompatibilityMode):
697         (LayoutTestController::setUserStyleSheetEnabled):
698         (LayoutTestController::setUserStyleSheetLocation):
699         (LayoutTestController::setWindowIsKey):
700         (LayoutTestController::setWaitToDump):
701         (LayoutTestController::windowCount):
702         (LayoutTestController::setPrivateBrowsingEnabled):
703         (LayoutTestController::setAuthorAndUserStylesEnabled):
704         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
705         (JSStringCopyUTF8CString):
706         (LoadItem::invoke):
707         (ReloadItem::invoke):
708         (ScriptItem::invoke):
709         (BackForwardItem::invoke):
710
711 2007-12-03  Sam Weinig  <sam@webkit.org>
712
713         Move JavaScriptCore thread testing code to pthread specific directory
714         and remove the dependance on CoreFoundation by using WTF::HashSet.
715
716         Reviewed by Geoff and Oliver.
717
718         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
719         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
720         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
721         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
722         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
723         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
724         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
725         * DumpRenderTree/pthreads: Added.
726         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
727         (javaScriptThreads):
728         (runJavaScriptThread):
729         (startJavaScriptThreads):
730         (stopJavaScriptThreads):
731
732 2007-12-03  Andrew Bonventre  <andybons@google.com>
733
734         Reviewed by Darin Adler.
735
736         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
737         Symbol lookup menu broken in debugger view
738
739         * Drosera/debugger.js: Fixed javascript error where document property
740         should have been used instead of contentDocument in switchFunction that
741         was breaking the select symbol dropdown menu.  This is because
742         window.frames will return a Window object and not a frame object like
743         the author was originally expecting.
744
745 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
746
747         Reviewed by Adam.
748
749         - <rdar://5618942> Drosera: Console window does not process everything
750         correctly.
751         - <rdar://5619005> Drosera: could be sped up by moving the 
752         WebScriptScope stuff into the WebScriptCallFrame.
753         - Now the console can correctly process objects and does not receive
754         notifications from JavaScriptCore about the JavaScript in Drosera's
755         own process.
756
757         * Drosera/win/DebuggerDocumentPlatform.cpp:
758         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
759         (DebuggerDocument::platformValueForScopeVariableNamed):
760
761 2007-12-03  Stephanie  <slewis@apple.com>
762
763         Reviewed by Darin.
764
765         Check to see if we are building a debug root
766
767         * Scripts/check-for-global-initializers: 
768
769 2007-12-03  Dan Bernstein  <mitz@apple.com>
770
771         Reviewed by Darin Adler.
772
773         - added a testGetIntIdentifier() method to TestNetscapePlugIn
774
775         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
776         (pluginInvoke):
777
778 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
779
780         Reviewed by Oliver.
781
782         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
783         in a more fine-grained manner than eventSender.keyDown().
784
785         * DumpRenderTree/win/EventSender.cpp:
786         (getConstantCallback):
787         (dispatchMessageCallback):
788
789 2007-12-02  Darin Adler  <darin@apple.com>
790
791         * Scripts/do-webcore-rename: More planned renaming.
792
793 2007-12-02  Sam Weinig  <sam@webkit.org>
794
795         Rubber stamped by Anders.
796
797         Use [NSURL absoluteString] instead of [NSURL description] in order to get
798         more uniform results cross platform.
799
800         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
801         (-[NSURL _drt_descriptionSuitableForTestResult]):
802
803 2007-12-02  Sam Weinig  <sam@webkit.org>
804
805         Rubber stamped by Niko.
806
807         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
808
809         * DumpRenderTree/win/DumpRenderTree.cpp:
810         * DumpRenderTree/win/DumpRenderTree.vcproj:
811         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
812         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
813         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
814         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
815
816 2007-12-01  Alp Toker  <alp@atoker.com>
817
818         Reviewed by Adam Roben.
819
820         Make use of the newly introduced webkit.h convenience header.
821
822         * GtkLauncher/main.c:
823
824 2007-12-01  Adam Treat  <treat@kde.org>
825
826         Reviewed by Simon.
827
828         * Check to see if the directory exists and exit if not.
829
830         * DumpRenderTree/qt/main.cpp:
831         (main):
832
833 2007-12-01  Adam Treat  <treat@kde.org>
834
835         Reviewed by Simon.
836
837         * Don't hide symbols when in Debug mode
838         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
839
840
841         * DumpRenderTree/qt/main.cpp:
842         (messageHandler):
843
844 2007-11-30  Alp Toker  <alp@atoker.com>
845
846         Reviewed by Adam Roben.
847
848         http://bugs.webkit.org/show_bug.cgi?id=15691
849         [GTK] Public API does not follow GTK+ conventions
850
851         Refactor the WebKit/GTK+ public API. Changes:
852           WebKitPage -> WebKitWebView
853           WebKitFrame -> WebKitWebFrame
854
855         Public API source and header names have been updated to mirror the API
856         changes.
857
858         The API is now kept in WebKit/gtk/WebView to match other ports in the
859         same class such as Mac and Win.
860
861         * GtkLauncher/main.c:
862         (activate_uri_entry_cb):
863         (link_hover_cb):
864         (title_change_cb):
865         (progress_change_cb):
866         (go_back_cb):
867         (go_forward_cb):
868         (create_browser):
869         (main):
870
871 2007-11-30  Adam Roben  <aroben@apple.com>
872
873         Hopefully the final build fix
874
875         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
876         pull in WTF's assertion/logging functions.
877
878 2007-11-30  Adam Roben  <aroben@apple.com>
879
880         Another build fix
881
882         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
883         WebKit.lib.
884
885 2007-11-30  Adam Roben  <aroben@apple.com>
886
887         Debug build fix
888
889         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
890         configuration.
891         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
892         projects.
893         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
894         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
895         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
896
897 2007-11-30  Sam Weinig  <sam@webkit.org>
898
899         Reviewed by Adam Roben.
900
901         Fix drawSelectionRect to actually draw the selection rect.
902
903         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
904         (drawSelectionRect):
905
906 2007-11-30  Darin Adler  <darin@apple.com>
907
908         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
909
910 2007-11-30  Darin Adler  <darin@apple.com>
911
912         * Scripts/do-webcore-rename: Get ready for some future renaming.
913
914 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
915
916         Reviewed by Adam.
917
918         - Removed some unnecessary functions and changed an unused return type. 
919
920         * Drosera/win/DebuggerClient.cpp:
921         (registerConsoleClass):
922         * Drosera/win/DebuggerClient.h:
923         * Drosera/win/Drosera.cpp:
924         (registerDroseraClass):
925
926 2007-11-28  Alp Toker  <alp@atoker.com>
927
928         Reviewed by Timothy Hatcher.
929
930         http://bugs.webkit.org/show_bug.cgi?id=16174
931         [GTK] Use "URI" not "URL" in public API
932
933         Replace use of the term "URL" with "URI" in public headers,
934         documentation and some internal code to match GLib/GTK+ convention.
935
936         This is now mentioned in the API guidelines:
937           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
938
939         * GtkLauncher/main.c:
940         (activate_uri_entry_cb):
941         (title_change_cb):
942         (create_toolbar):
943         (main):
944
945 2007-11-29  Anders Carlsson  <andersca@apple.com>
946
947         Reviewed by Sam.
948
949         <rdar://problem/5230478>
950         FrameLoadDelegate callbacks are not dumped in DRT.
951         
952         * DumpRenderTree/win/DumpRenderTree.cpp:
953         (shouldLogFrameLoadDelegates):
954         (runTest):
955         (main):
956         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
957         (BSTRtoString):
958         (descriptionSuitableForTestResult):
959         (FrameLoadDelegate::QueryInterface):
960         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
961         (FrameLoadDelegate::didFailProvisionalLoadWithError):
962         (FrameLoadDelegate::didCommitLoadForFrame):
963         (FrameLoadDelegate::didFinishLoadForFrame):
964         (FrameLoadDelegate::willCloseFrame):
965         (FrameLoadDelegate::didClearWindowObject):
966         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
967         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
968         * DumpRenderTree/win/FrameLoaderDelegate.h:
969         (FrameLoadDelegate::windowScriptObjectAvailable):
970         (FrameLoadDelegate::didFirstLayoutInFrame):
971
972 2007-11-29  Sam Weinig  <sam@webkit.org>
973
974         Reviewed by Anders.
975
976         Add database quota UIDelegates methods to DRT UIDelegate.
977
978         * DumpRenderTree/mac/UIDelegate.mm:
979         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
980         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
981
982 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
983
984         Reviewed by Sam.
985
986         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
987         dying and vice versa.
988         - This fix will allow Drosera and Safari to reconnect if either of them
989         closes correctly, but does not fix the case where one of them dies
990         silently.
991
992         * Drosera/win/ServerConnection.cpp:
993         (ServerConnection::attemptToCreateServerConnection): Added a safety
994         check, because it's possilbe to try to connect to a server that's dying.
995         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
996         the server has died.
997         * Drosera/win/ServerConnection.h: Added the new function and removed
998         an unnecessary member.
999
1000 2007-11-29  Anders Carlsson  <andersca@apple.com>
1001
1002         * DumpRenderTree/win/DumpRenderTree.vcproj:
1003         Add shlwapi.lib to all configurations.
1004
1005 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1006
1007         - Build fix.  Added additional includes for VS Express to the Release
1008         project.
1009
1010         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1011
1012 2007-11-29  Anders Carlsson  <andersca@apple.com>
1013
1014         Reviewed by Adam.
1015
1016         <rdar://problem/5132005>
1017         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1018         
1019         * DumpRenderTree/win/DumpRenderTree.vcproj:
1020         Add shlwapi.lib
1021         
1022         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1023         (LayoutTestController::setUserStyleSheetEnabled):
1024         Implement this.
1025         
1026         (appendComponentToPath):
1027         New method which wraps the Win32 API PathAppend.
1028         
1029         (followShortcuts):
1030         New method which checks if a file points to a shortcut and
1031         follows the shortcut.
1032         
1033         (resolveCygwinPath):
1034         New method that takes a cygwin unix-style path and returns the Win32 path.
1035         
1036         (cfStringRefToWString):
1037         
1038         (LayoutTestController::setUserStyleSheetLocation):
1039         Implement this.
1040
1041 2007-11-29  Alice Liu  <alice.liu@apple.com>
1042
1043         Reviewed by Adam.
1044
1045         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1046
1047         * DumpRenderTree/win/EventSender.cpp:
1048         (keyDownCallback):
1049         uppercase letters were being sent as lowercase letters without the shift key down.
1050
1051 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1052
1053         - Windows build fix. VS express needs some love.
1054
1055         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1056
1057 2007-11-28  Darin Adler  <darin@apple.com>
1058
1059         Reviewed by Adam Roben.
1060
1061         * DumpRenderTree/mac/EventSendingController.mm:
1062         (-[EventSendingController keyDown:withModifiers:]):
1063         Send capital letters through as lowercase letters with the shift key down
1064         rather than sending them as if they were highly unusual "capital letter keys".
1065
1066         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1067         where you need to update results and more tests are failing than before.
1068
1069 2007-11-28  Anders Carlsson  <andersca@apple.com>
1070
1071         Reviewed by Darin.
1072
1073         <rdar://problem/5132001>
1074         contextClick is not implemented in DRT on Windows.
1075         
1076         * DumpRenderTree/win/EventSender.cpp:
1077         (contextClickCallback):
1078         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1079         by a WM_RBUTTONUP message.
1080         
1081         * DumpRenderTree/win/UIDelegate.cpp:
1082         (UIDelegate::hasCustomMenuImplementation):
1083         (UIDelegate::trackCustomPopupMenu):
1084         * DumpRenderTree/win/UIDelegate.h:
1085         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1086         menu from being shown (and causing the DRT to hang).
1087
1088 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1089
1090         Reviewed by Darin.
1091
1092         Fix DumpRenderTree ObjC bug comparing strings.
1093
1094         * DumpRenderTree/mac/ObjCController.m:
1095         (-[ObjCController identityIsEqual::]): Compare strings with string
1096         equality instead of identiy equality.
1097
1098 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1099
1100         Reviewed by Sam.
1101
1102         Reset the authorAndUserStylesEnabled preference
1103         back to YES for each test. Fixes the broken tests.
1104
1105         * DumpRenderTree/mac/DumpRenderTree.mm:
1106         (resetWebViewToConsistentStateBeforeTesting):
1107
1108 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1109
1110         Reviewed by Adam.
1111
1112         - Drosera now displays the console window, although it cannot currently
1113         process JavaScript.
1114
1115         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1116         (registerConsoleClass): Implemented.
1117         (consoleWndProc): Implemented.
1118         (DebuggerClient::onSize): Implemented.
1119         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1120         new window.
1121         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1122         creating and maintaining a new window.
1123         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1124         lines of code to more appropriate places.
1125         (Drosera::handleCommand):
1126         (Drosera::initUI):
1127         (Drosera::onSize):
1128         (Drosera::attach):
1129
1130 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1131
1132         Reviewed by Dave Hyatt.
1133
1134         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1135         
1136         Add support for disabling author and user styles for testing.
1137
1138         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1139         * DumpRenderTree/LayoutTestController.cpp:
1140         (setAuthorAndUserStylesEnabledCallback):
1141         (LayoutTestController::staticFunctions):
1142         * DumpRenderTree/LayoutTestController.h:
1143         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1144         (LayoutTestController::setAuthorAndUserStylesEnabled):
1145         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1146         (LayoutTestController::setAuthorAndUserStylesEnabled):
1147
1148 2007-11-26  Dan Bernstein  <mitz@apple.com>
1149
1150         - Tiger build fix.
1151
1152         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1153
1154 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1155
1156         Reviewed by Maciej.
1157
1158         - Implemented displaying variables for Drosera on Win.
1159
1160         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1161         that retrieve variables to not hold onto the return value since it's
1162         not returned.  Also changed to use the new signatures of the retrieval
1163         functions.
1164         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1165         (DebuggerDocument::platformValueForScopeVariableNamed):
1166         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1167         (droseraWndProc):
1168
1169 2007-11-26  Sam Weinig  <sam@webkit.org>
1170
1171         Cleanup names of painting and repainting functions.
1172
1173         Reviewed by Adam Roben.
1174
1175         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1176         (drawSelectionRect): was drawSelectionRectIntoContext.
1177         (dumpWebViewAsPixelsAndCompareWithExpected):
1178         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1179         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1180         (paintWebView): was drawWebViewIntoContext.
1181         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1182
1183 2007-11-26  Sam Weinig  <sam@webkit.org>
1184
1185         Reviewed by Dan Bernstein.
1186
1187         - Leopard build fix
1188
1189         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1190
1191 2007-11-26  Sam Weinig  <sam@webkit.org>
1192
1193         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1194         Use shared PixelDumpSupport for Mac DRT
1195
1196         Reviewed by Adam Roben.
1197
1198         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1199         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1200         * DumpRenderTree/cg/ImageDiffCG.cpp:
1201         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1202         (drawSelectionRectIntoContext):
1203         (dumpWebViewAsPixelsAndCompareWithExpected):
1204         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1205         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1206         * DumpRenderTree/mac/DumpRenderTree.mm:
1207         (dump):
1208         * DumpRenderTree/mac/ImageDiff.m: Removed.
1209         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1210         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1211         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1212         (setDefaultColorProfileToRGB):
1213         (getBitmapContextFromWebView):
1214         (drawWebViewIntoContext):
1215         (repaintWithVerticalSweep):
1216         (repaintWithHorizontalSweep):
1217         (getSelectionRect):
1218         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1219
1220 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1221
1222         Bug 16052: prepare-ChangeLog doesn't report deleted files
1223         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1224
1225         Reviewed by Sam.
1226
1227         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1228
1229 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1230
1231         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1232         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1233
1234         Reviewed by Adam.
1235
1236         Roll functionality of merge-changelog into resolve-ChangeLogs
1237         script.  The script now checks for ChangeLog.rej and
1238         ChangeLog.orig files first.  If it finds them, it uses the
1239         ChangeLog.rej file as a patch (in old contextual diff format) to
1240         apply with --fuzz=3.
1241
1242         * Scripts/merge-changelog: Removed.
1243         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1244
1245 2007-11-25  Sam Weinig  <sam@webkit.org>
1246
1247         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1248
1249         Reviewed by Mark Rowe.
1250
1251         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1252         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1253         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1254         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1255         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1256
1257 2007-11-25  Sam Weinig  <sam@webkit.org>
1258
1259         Convert DumpRenderTree to ues .xcconfig files.
1260
1261         Reviewed by Mark Rowe.
1262
1263         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1264         * DumpRenderTree/mac/Configurations: Added.
1265         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1266         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1267         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1268
1269 2007-11-25  Sam Weinig  <sam@webkit.org>
1270
1271         Add ForwardingHeaders to wtf for DumpRenderTree.
1272
1273         Reviewed by Mark Rowe.
1274
1275         * DumpRenderTree/DumpRenderTree.h:
1276         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1277         * DumpRenderTree/ForwardingHeaders: Added.
1278         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1279         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1280         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1281         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1282         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1283         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1284         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1285         * DumpRenderTree/LayoutTestController.cpp:
1286         * DumpRenderTree/WorkQueue.cpp:
1287         * DumpRenderTree/mac/DumpRenderTree.mm:
1288         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1289         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1290         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1291         * DumpRenderTree/mac/ObjCController.m:
1292         * DumpRenderTree/mac/UIDelegate.mm:
1293         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1294
1295 2007-11-25  Adam Roben  <aroben@apple.com>
1296
1297         Fix some test failures caused by r28019
1298
1299         Now that stdout is in binary mode, we need to always use printf
1300         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1301         the output.
1302
1303         Reviewed by Sam.
1304
1305         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1306         printf.
1307         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1308         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1309         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1310         (UIDelegate::webViewAddMessageToConsole):
1311
1312 2007-11-25  Adam Roben  <aroben@apple.com>
1313
1314         Set the font smoothing preference in DRT
1315
1316         This makes the pixel results on Windows closer to the Mac results.
1317
1318         Reviewed by Mitz.
1319
1320         * DumpRenderTree/win/DumpRenderTree.cpp:
1321         (initializePreferences):
1322
1323 2007-11-25  Adam Roben  <aroben@apple.com>
1324
1325         Port ImageDiff to CG and C++
1326
1327         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1328         <rdar://5071708>
1329
1330         Reviewed by Sam.
1331
1332         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1333         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1334         (main):
1335         (createImageFromStdin):
1336         (compareImages):
1337         (getDifferenceBitmap):
1338         (computePercentageDifferent):
1339         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1340
1341 2007-11-25  Adam Roben  <aroben@apple.com>
1342
1343         Fix image diff link generation on Windows
1344
1345         Reviewed by Sam.
1346
1347         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1348         to toURL.
1349
1350 2007-11-25  Adam Roben  <aroben@apple.com>
1351
1352         Implement pixel dumping in Windows DRT
1353
1354         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1355         <rdar://5071708>
1356
1357         Reviewed by Sam.
1358
1359         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1360         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1361         Content-Length header.
1362         (getMD5HashStringForBitmap):
1363         (dumpWebViewAsPixelsAndCompareWithExpected):
1364         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1365         * DumpRenderTree/win/DumpRenderTree.cpp:
1366         (dump): Do a pixel dump if requested.
1367         (main): Parse pixel test options.
1368         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1369         the cg/ subdirectory to the include path.
1370         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1371         available in a header or import library, so we have to go through this
1372         LoadLibrary/GetProcAddress dance to use them.
1373         (cryptDLL):
1374         (init):
1375         (update):
1376         (final):
1377         (MD5_Init):
1378         (MD5_Update):
1379         (MD5_Final):
1380         * DumpRenderTree/win/MD5.h: Added.
1381         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1382         moved up to the top level to share it with Mac eventually.
1383         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1384         (getBitmapContextFromWebView): Forces the WebView to paint using a
1385         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1386
1387 2007-11-25  Adam Roben  <aroben@apple.com>
1388
1389         Clean up Windows DRT's option parsing a little bit
1390
1391         Reviewed by Sam.
1392
1393         * DumpRenderTree/win/DumpRenderTree.cpp:
1394         (main): Put non-option arguments into a Vector.
1395
1396 2007-11-25  Adam Roben  <aroben@apple.com>
1397
1398         Make Windows DRT stop changing LF into CRLF
1399
1400         Reviewed by Sam.
1401
1402         * DumpRenderTree/win/DumpRenderTree.cpp:
1403         (main): Put stdout in binary mode.
1404         * Scripts/run-webkit-tests: Remove the CRLF hack.
1405
1406 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1407
1408         Removed empty directory.
1409
1410         * Scripts/resources: Removed.
1411
1412 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1413
1414         Fix bisect-builds to work with recent WebKit nightly builds.
1415
1416         Reviewed by Dan.
1417
1418         * Scripts/bisect-builds: Check for the 
1419         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1420         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1421         to WebKit.app/Contents/Resources.
1422
1423 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1424
1425         Reviewed by Maciej.
1426
1427         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1428         not closed (affects digg.com)
1429
1430         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1431         one after finishing with a test to avoid having its delayed onload handler firing when
1432         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1433         but it helps somewhat.
1434
1435 2007-11-22  Mark Rowe  <mrowe@apple.com>
1436
1437         Reviewed by Alp Toker.
1438
1439         Fix build-webkit to propagate make's exit status if it fails.
1440
1441         * Scripts/webkitdirs.pm:
1442
1443 2007-11-22  Dan Bernstein  <mitz@apple.com>
1444
1445         Reviewed by Mark Rowe.
1446
1447         - fix crash when running pixel tests
1448
1449         * DumpRenderTree/mac/DumpRenderTree.mm:
1450         (dumpRenderTree): Parse the command line options before setting up the
1451         environment so that we know if we need to set up the pixel dump
1452         machinery.
1453
1454 2007-11-21  Eric Seidel  <eric@webkit.org>
1455
1456         Speculative build fix for Tiger.
1457
1458         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1459
1460 2007-11-21  Eric Seidel  <eric@webkit.org>
1461
1462         Reviewed by Tim Hatcher.
1463
1464         Break out more of DumpRenderTree.mm into individual files
1465
1466         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1467         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1468         (checkedMalloc):
1469         (checkedRealloc):
1470         (makeLargeMallocFailSilently):
1471         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1472         * DumpRenderTree/mac/DumpRenderTree.mm:
1473         (crashHandler):
1474         (dump):
1475         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1476         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1477         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1478         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1479         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1480         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1481         (javaScriptThreads):
1482         (runJavaScriptThread):
1483         (startJavaScriptThreads):
1484         (stopJavaScriptThreads):
1485         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1486         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1487         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1488         (restoreColorSpace):
1489         (setDefaultColorProfileToRGB):
1490         (initializeColorSpaceAndScreeBufferForPixelTests):
1491         (md5HashStringForBitmap):
1492         (dumpWebViewAsPixelsAndCompareWithExpected):
1493
1494 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1495
1496         Move install-unix-extras to wx directory as it seems only to be used by that 
1497         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1498         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1499         have install-unix-extras install into WebKitLibraries as per
1500         convention.
1501         
1502         Reviewed by Mark Rowe.
1503
1504         * Scripts/install-unix-extras: Removed.
1505         * wx/build-wxwebkit:
1506         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1507
1508 2007-11-21  Eric Seidel  <eric@webkit.org>
1509
1510         Reviewed by Adam.
1511
1512         More refactoring for greater code readability
1513
1514         * DumpRenderTree/mac/DumpRenderTree.mm:
1515         (initializeGlobalsFromCommandLineOptions):
1516         (initializeColorSpaceAndScreeBufferForPixelTests):
1517         (addTestPluginsToPluginSearchPath):
1518         (useLongRunningServerMode):
1519         (runTestingServerLoop):
1520         (prepareConsistentTestingEnvironment):
1521         (dumpRenderTree):
1522         (main):
1523         (dumpFramesAsText):
1524         (dumpBackForwardListForWebView):
1525         (sizeWebViewForCurrentTest):
1526         (methodNameStringForFailedTest):
1527         (dumpBackForwardListForAllWindows):
1528         (dumpWebViewAsPixelsAndCompareWithExpected):
1529         (invalidateAnyPreviousWaitToDumpWatchdog):
1530         (dump):
1531         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1532         * DumpRenderTree/mac/UIDelegate.mm:
1533         (-[UIDelegate webView:createWebViewWithRequest:]):
1534
1535 2007-11-21  Eric Seidel  <eric@webkit.org>
1536
1537         Reviewed by Tim Hatcher.
1538
1539         Abstract more of DRT into static methods
1540
1541         * DumpRenderTree/mac/DumpRenderTree.mm:
1542         (setDefaultsToConsistentValuesForTesting):
1543         (setupSignalHandlers):
1544         (allocateGlobalControllers):
1545         (releaseAndZero):
1546         (releaseGlobalControllers):
1547         (dumpRenderTree):
1548         (shouldLogFrameLoadDelegates):
1549         (createCFURLFromPathOrURL):
1550         (resetWebViewToConsistentStateBeforeTesting):
1551         (runTest):
1552
1553 2007-11-21  Eric Seidel  <eric@webkit.org>
1554
1555         Reviewed by Tim Hatcher.
1556
1557         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1558
1559         * DumpRenderTree/DumpRenderTree.h:
1560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1561         * DumpRenderTree/mac/DumpRenderTree.mm:
1562         (dumpRenderTree):
1563         (dump):
1564         (runTest):
1565         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1566         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1567         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1568         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1569         (-[DumpRenderTreePasteboard declareType:owner:]):
1570         (+[LocalPasteboard alloc]):
1571         (-[LocalPasteboard init]):
1572         (-[LocalPasteboard dealloc]):
1573         (-[LocalPasteboard name]):
1574         (-[LocalPasteboard releaseGlobally]):
1575         (-[LocalPasteboard declareTypes:owner:]):
1576         (-[LocalPasteboard addTypes:owner:]):
1577         (-[LocalPasteboard changeCount]):
1578         (-[LocalPasteboard types]):
1579         (-[LocalPasteboard availableTypeFromArray:]):
1580         (-[LocalPasteboard setData:forType:]):
1581         (-[LocalPasteboard dataForType:]):
1582         (-[LocalPasteboard setPropertyList:forType:]):
1583         (-[LocalPasteboard setString:forType:]):
1584         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1585         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1586         (+[DumpRenderTreeWindow allWindows]):
1587         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1588         (-[DumpRenderTreeWindow dealloc]):
1589         (-[DumpRenderTreeWindow isKeyWindow]):
1590         (-[DumpRenderTreeWindow keyDown:]):
1591
1592 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1593
1594         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1595         it indiscriminately copies any headers inside JavaScriptCore,
1596         which includes Tiger ICU headers. 
1597
1598         * wx/build-wxwebkit:
1599         Don't run WebCore/move-js-headers.sh any longer.
1600
1601 2007-11-20  Adam Treat  <treat@kde.org>
1602
1603         Reviewed by David Kilzer.
1604
1605         * Prepend git branch name to $baseProductDir
1606
1607         * Scripts/VCSUtils.pm:
1608         * Scripts/webkitdirs.pm:
1609
1610 2007-11-20  Mark Rowe  <mrowe@apple.com>
1611
1612         Reviewed by Simon Hausmann.
1613
1614         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1615         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1616         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1617         built product and generated Makefile's are removed.
1618
1619 2007-11-19  Alp Toker  <alp@atoker.com>
1620
1621         Reviewed by Mark Rowe.
1622
1623         http://bugs.webkit.org/show_bug.cgi?id=16040
1624         [GTK] GtkLauncher should be written in C
1625
1626         Port GtkLauncher to plain C.
1627
1628         Use a more conventional GTK+ coding style.
1629
1630         Use a toolbar instead of menus.
1631
1632         Various signature fixes and cleanups.
1633
1634         Add a license header. Assume all previous modifications were copyright
1635         assigned to Apple Inc. by default.
1636
1637         * GtkLauncher/GtkLauncher.pro:
1638         * GtkLauncher/main.c: Added.
1639         (activate_url_entry_cb):
1640         (update_title):
1641         (link_hover_cb):
1642         (title_change_cb):
1643         (progress_change_cb):
1644         (destroy_cb):
1645         (go_back_cb):
1646         (go_forward_cb):
1647         (create_browser):
1648         (create_statusbar):
1649         (create_toolbar):
1650         (create_window):
1651         (main):
1652         * GtkLauncher/main.cpp: Removed.
1653
1654 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1655
1656         Build script fixes to ensure they do the right thing for the 
1657         wx port, and update build-wxwebkit to reflect the way the
1658         build scripts now work.
1659
1660         Reviewed by Adam.
1661
1662         * Scripts/build-testkjs:
1663         * Scripts/build-webkit:
1664         * Scripts/run-javascriptcore-tests:
1665         * Scripts/webkitdirs.pm:
1666         * wx/build-wxwebkit:
1667
1668 2007-11-18  Eric Seidel  <eric@webkit.org>
1669
1670         Reviewed by Anders.
1671
1672         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1673
1674         * Scripts/run-javascriptcore-tests:
1675
1676 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1677
1678         Reviewed by Adam Roben.
1679
1680         Make run-webkit-tests work with Windows debug build.
1681
1682         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1683         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1684         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1685         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1686         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1687
1688 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1689
1690         Add wxWebKit sample and build script, and integrate it with 
1691         build-webkit. Also make build-webkit --clean work for all
1692         ports.
1693
1694         Reviewed by Darin Adler.
1695
1696         * Scripts/build-webkit:
1697         * Scripts/webkitdirs.pm:
1698         * wx: Added.
1699         * wx/browser: Added.
1700         * wx/browser/browser.bkl: Added.
1701         * wx/browser/browser.cpp: Added.
1702         * wx/build-wxwebkit: Added.
1703
1704 2007-11-17  Adam Roben  <aroben@apple.com>
1705
1706         Make it easy to run Safari in the debugger on Windows
1707
1708         I've added a new script, debug-safari, which launches Safari in the
1709         debugger. On OS X it just calls gdb-safari.
1710
1711         Reviewed by Mark Rowe.
1712
1713         * FindSafari/FindSafari.cpp:
1714         (_tmain): Added a /debugger flag, which in combination with
1715         /printSafariLauncher will print a script that launches Safari in the
1716         debugger.
1717         * Scripts/debug-safari: Added.
1718         * Scripts/run-safari: Changed to call runSafari().
1719         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1720         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1721         first argument along to FindSafari.
1722         * Scripts/webkitdirs.pm:
1723         (sub runSafari): Added.
1724
1725 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1726
1727         Reviewed by Adam Roben.
1728
1729         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1730
1731 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1732
1733         Reviewed by David Kilzer.
1734
1735         The git config command was renamed to repo-config at some point. This
1736         change tries git config and then git repo-config if the first fails.
1737
1738         * Scripts/prepare-ChangeLog:
1739         (gitConfig):
1740
1741 2007-11-16  Dan Bernstein  <mitz@apple.com>
1742
1743         Reviewed by Darin Adler and Sam Weinig.
1744
1745         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1746
1747         * DumpRenderTree/win/EventSender.cpp:
1748         (keyDownCallback): For characters that cannot be entered on the active
1749         keyboard layout, send a WM_CHAR message with the character along with
1750         a WM_KEYDOWN message with a virtual key code of 255.
1751
1752 2007-11-16  Mark Rowe  <mrowe@apple.com>
1753
1754         Reviewed by Tim Hatcher.
1755
1756         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1757
1758         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1759         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1760
1761 2007-11-15  Adam Roben  <aroben@apple.com>
1762
1763         Make run-safari actually work on Windows
1764
1765         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1766         chdir call.
1767
1768 2007-11-14  Adam Roben  <aroben@apple.com>
1769
1770         Updates to Safari launching now that 3.0.4 is released
1771
1772         Reviewed by Sam.
1773
1774         * FindSafari/FindSafari.cpp:
1775         (getWebViewCLSID): Use version-independent ProgID.
1776         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1777
1778 2007-11-14  Anders Carlsson  <andersca@apple.com>
1779
1780         Reviewed by Adam.
1781
1782         <rdar://problem/5309081>
1783         In DRT, "plugin.logDestroy = true" not working on Windows.
1784         
1785         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1786         (NPP_Destroy):
1787
1788 2007-11-14  Eric Seidel  <eric@webkit.org>
1789
1790         Reviewed by Sam.
1791
1792         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1793
1794 2007-11-14  Anders Carlsson  <andersca@apple.com>
1795
1796         Reviewed by Adam.
1797
1798         <rdar://problem/5141186>
1799         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1800         
1801         Implement setWindowIsKey.
1802         
1803         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1804         (LayoutTestController::setWindowIsKey):
1805
1806 2007-11-13  Sam Weinig  <sam@webkit.org>
1807
1808         Reviewed by Adam Roben.
1809
1810         Fix for <rdar://problem/5382579>
1811         http/tests/security/cross-frame-access-put.html reports large 
1812         negative numbers for screenLeft and screenTop (Mac reports "0")
1813
1814         * DumpRenderTree/win/UIDelegate.cpp:
1815         (UIDelegate::UIDelegate): Initialize the RECT.
1816         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1817         (UIDelegate::webViewFrame): ditto.
1818         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1819
1820 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1821
1822         Reviewed by Adam.
1823
1824         - Make Drosera show source, source URLs, and function stack on Windows,
1825         and some minor fixes.
1826
1827         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1828         (DebuggerDocument::updateFileSource):
1829         * Drosera/debugger.js: Force source to always update display.
1830         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1831         menu controls.
1832         (DebuggerClient::resume):
1833         (DebuggerClient::pause):
1834         (DebuggerClient::stepInto):
1835         (DebuggerClient::stepOver):
1836         (DebuggerClient::stepOut):
1837         (DebuggerClient::showConsole):
1838         (DebuggerClient::closeCurrentFile):
1839         * Drosera/win/DebuggerClient.h: Ditto.
1840         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1841         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1842         removed two bugs.  1) caller could be in a bad state when asked to
1843         assign into it. 2) BSTRs were not created correctly.
1844         (DebuggerDocument::getPlatformCurrentFunctionStack):
1845         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1846         (droseraWndProc):
1847         (handleCommand):
1848         (Drosera::resume):
1849         (Drosera::pause):
1850         (Drosera::stepInto):
1851         (Drosera::stepOver):
1852         (Drosera::stepOut):
1853         (Drosera::showConsole):
1854         (Drosera::closeCurrentFile):
1855         * Drosera/win/Drosera.h: Hook up the menu controls.
1856         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1857         functions, added a null check, and fixed another bug where caller could
1858         be in a bad state when asked to assign into it.
1859         (ServerConnection::didLoadMainResourceForDataSource):
1860         (ServerConnection::getCallerFrame):
1861         * Drosera/win/ServerConnection.h: Safety first.
1862
1863 2007-11-13  Dan Bernstein  <mitz@apple.com>
1864
1865         Reviewed by Darin Adler.
1866
1867         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1868           DumpRenderTree --pixel-tests renders each test twice
1869
1870         * DumpRenderTree/mac/DumpRenderTree.mm:
1871         (dumpRenderTree): Removed the --paint option because the painting code
1872         is always exercised as a result of
1873         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1874         calling -displayIfNeeded.
1875         (dump): Changed to always grab the image from the window since the view
1876         is always displayed.
1877         (runTest):
1878         (displayWebView):
1879         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1880         because it always paints.
1881
1882 2007-11-12  Antti Koivisto  <antti@apple.com>
1883
1884         Reviewed by Adele.
1885         
1886         Add support for http media tests
1887
1888         * Scripts/run-webkit-tests:
1889
1890 2007-11-12  Sam Weinig  <sam@webkit.org>
1891
1892         Reviewed by Adam Roben.
1893
1894         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1895
1896         * DumpRenderTree/win/DumpRenderTree.cpp:
1897         (runTest):
1898         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1899         (LayoutTestController::setPrivateBrowsingEnabled):
1900
1901 2007-11-12  Adam Roben  <aroben@apple.com>
1902
1903         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1904         mac and win subdirectories.
1905
1906 2007-11-11  Adam Roben  <aroben@apple.com>
1907
1908         Fix <rdar://5133816> keepWebHistory is not implemented
1909
1910         Fixes fast/history/clicked-link-is-visited.html.
1911
1912         Reviewed by Darin.
1913
1914         * DumpRenderTree/win/DumpRenderTree.cpp:
1915         (runTest): Clear the optionalSharedHistory.
1916         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1917         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1918
1919 2007-11-10  Sam Weinig  <sam@webkit.org>
1920
1921         Reviewed by Tim Hatcher.
1922
1923         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1924         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1925         is turned on)
1926
1927         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1928
1929         Added test: http/tests/security/cross-frame-access-private-browsing.html
1930
1931         * DumpRenderTree/LayoutTestController.cpp:
1932         (setPrivateBrowsingEnabledCallback):
1933         (LayoutTestController::staticFunctions):
1934         * DumpRenderTree/LayoutTestController.h:
1935         * DumpRenderTree/mac/DumpRenderTree.mm:
1936         (runTest): Default to private browsing disabled.
1937         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1938         (LayoutTestController::setPrivateBrowsingEnabled):
1939         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1940         (LayoutTestController::setPrivateBrowsingEnabled):
1941
1942 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1943
1944         Reviewed by Adam.
1945
1946         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1947         WebCore's!
1948
1949         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1950         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1951         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1952         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1953         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1954         * Drosera/win/Drosera.cpp:
1955         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1956
1957 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1958
1959         Reviewed by Sam.
1960
1961         - Use the new IWebFrame [local] function signature and get the shared
1962         server correctly.
1963
1964         * Drosera/win/DebuggerClient.cpp:
1965         (DebuggerClient::didFinishLoadForFrame):
1966         * Drosera/win/ServerConnection.cpp:
1967         (ServerConnection::attemptToCreateServerConnection):
1968
1969 2007-11-07  Dan Bernstein  <mitz@apple.com>
1970
1971         Reviewed by Darin Adler.
1972
1973         - add an option to run-webkit-tests to ignore pixel test failures where
1974           all pixels differ by no more than a specified threshold
1975
1976         * DumpRenderTree/mac/ImageDiff.m:
1977         (main):
1978         (compareImages):
1979         (computePercentageDifferent):
1980         * Scripts/run-webkit-tests:
1981
1982 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1983
1984         Reviewed by Lars.
1985
1986         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1987
1988         * DumpRenderTree/qt/DumpRenderTree.cpp:
1989
1990 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1991
1992         Reviewed by Lars.
1993
1994         Reworked the QWebSettings API.
1995         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1996
1997         * DumpRenderTree/qt/DumpRenderTree.cpp:
1998
1999 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2000
2001         Reviewed by Lars.
2002
2003         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2004
2005         * DumpRenderTree/qt/jsobjects.cpp:
2006
2007 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2008
2009         Reviewed by Lars Knoll <lars@trolltech.com>.
2010
2011         Add a QWebPage::frameCreated() signal and fix DRT
2012         
2013         The removal of createFrame in QWebPage broke the re-implementation
2014         in DumpRenderTree. Instead emit a frameCreated() signal and
2015         connect to it in DumpRenderTree.
2016         
2017
2018         * DumpRenderTree/qt/DumpRenderTree.cpp:
2019         (WebCore::WebPage::WebPage):
2020         (WebCore::DumpRenderTree::dump):
2021         (WebCore::DumpRenderTree::connectFrame):
2022         * DumpRenderTree/qt/DumpRenderTree.h:
2023
2024 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2025
2026         Reviewed by Lars Knoll <lars@trolltech.com>.
2027
2028         Moved all the event handlers from QWebFrame into QWebPage.
2029         
2030         This cleans up the public API and allows us to remove the
2031         HackWebFrame hack in DumpRenderTree.
2032         
2033
2034         * DumpRenderTree/qt/jsobjects.cpp:
2035         (EventSender::mouseDown):
2036         (EventSender::mouseUp):
2037         (EventSender::mouseMoveTo):
2038
2039 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2040
2041         Reviewed by Mark.
2042
2043         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2044         to prevent the default implementation from popping up messageboxes.
2045
2046         * DumpRenderTree/qt/DumpRenderTree.cpp:
2047         (WebCore::WebPage::javaScriptConfirm):
2048         (WebCore::WebPage::javaScriptPrompt):
2049
2050 2007-11-06  Eric Seidel  <eric@webkit.org>
2051
2052         * Scripts/build-testkjs: build fix... too many $$
2053
2054 2007-11-06  Eric Seidel  <eric@webkit.org>
2055
2056         Reviewed by Mark Rowe.
2057
2058         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2059
2060 2007-11-05  Adam Roben  <aroben@apple.com>
2061
2062         Add support on Windows for WEBKIT_TESTFONTS
2063
2064         This environment variable lets you specify where the fonts to be used
2065         by DumpRenderTree reside. The Qt port is already using this, so I'm
2066         just following their lead.
2067
2068         Reviewed by Darin.
2069
2070         * DumpRenderTree/win/DumpRenderTree.cpp:
2071         (exePath): Refactored code out of initialize().
2072         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2073         DumpRenderTree.resources.
2074         (initialize): Use the new fontsPath function.
2075         (main): Use the new exePath function.
2076         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2077         variable to DRT, like Qt does.
2078
2079 2007-11-05  Mark Rowe  <mrowe@apple.com>
2080
2081         Rubber-stamped by Alp Toker.
2082
2083         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2084
2085         * GtkLauncher/main.cpp:
2086         (goToURLBarText):
2087         (main):
2088
2089 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2090
2091         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2092         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2093
2094         Reviewed by Timothy.
2095
2096         Restrict the range of nightly builds used by the bisect-builds script
2097         based on the version of Safari and the version of Mac OS X being used.
2098
2099         Mac OS X 10.4: Safari 2.0: r11976 or newer
2100         Mac OS X 10.4: Safari 3.0: r19992 or newer
2101
2102         Mac OS X 10.5: Safari 2.0: r19594 or newer
2103         Mac OS X 10.5: Safari 3.0: r25124 or newer
2104
2105         * Scripts/bisect-builds:
2106         (findMacOSXVersion): Added.
2107         (makeNightlyList): Added argument to provide version of Mac OS X.
2108         Restrict range of nightly builds based on Safari and Mac OS X versions.
2109
2110 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2111
2112         Reviewed by Maciej.
2113
2114         - This patch involves several changes, all of them were noticed that
2115         they were needed by the work being done in WebKit to get Drosera and
2116         WebKit working together on Windows.
2117         - The changes are:
2118         1) Added a debugger console for output messages.
2119         2) Drosera now listens for the WebKit server (before, the server would
2120         have to be running before Drosera was started.)
2121         3) Fixed a bug where the WebView started out as 0x0 pixels.
2122         4) Fixed a bug when there is no scope.
2123         5) Added the HTML, JS, and CSS to the project file to make them easy to
2124         find.
2125         6) Made the ServerConnection functions virtual.
2126
2127         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2128         for the WebKit server.
2129         (DebuggerClient::DebuggerClient):
2130         (DebuggerClient::~DebuggerClient):
2131         (DebuggerClient::didFinishLoadForFrame):
2132         (DebuggerClient::serverConnected):
2133         (DebuggerClient::attemptToCreateServerConnection):
2134         * Drosera/win/DebuggerClient.h: Ditto.
2135         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2136         scope.
2137         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2138         (DebuggerDocument::platformValueForScopeVariableNamed):
2139         * Drosera/win/Drosera.cpp:
2140         (_tWinMain): Added a console in debug for output messages.
2141         (Drosera::Drosera): Listen for server.
2142         (Drosera::initUI): The server now Initializes COM.
2143         (Drosera::serverConnected): Part of the listening for the server.
2144         (Drosera::attemptToCreateServerConnection): Ditto.
2145         * Drosera/win/Drosera.h: New interface for listening for the server.
2146         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2147         files to the VS project.
2148         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2149         connection.
2150         (ServerConnection::ServerConnection):
2151         (ServerConnection::attemptToCreateServerConnection):
2152         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2153         methods.
2154         (ServerConnection::serverConnected):
2155
2156 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2157
2158         Reviewed by Maciej.
2159
2160         http://bugs.webkit.org/show_bug.cgi?id=15832
2161         fast/dom/gc-10.html crashes when run alone
2162
2163         Check for !done before using objects that can be already deallocated.
2164
2165         * DumpRenderTree/mac/EditingDelegate.mm:
2166         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2167         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2168         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2169         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2170         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2171         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2172         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2173         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2174         (-[EditingDelegate webViewDidBeginEditing:]):
2175         (-[EditingDelegate webViewDidChange:]):
2176         (-[EditingDelegate webViewDidEndEditing:]):
2177         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2178         (-[EditingDelegate webViewDidChangeSelection:]):
2179         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2180         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2181         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2182         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2183         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2184         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2185         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2186         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2187         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2188         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2189         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2190         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2191         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2192         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2193         (-[FrameLoadDelegate webView:willCloseFrame:]):
2194         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2195         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2196         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2197         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2198         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2199         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2200         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2201         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2202         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2203
2204 2007-11-04  Mark Rowe  <mrowe@apple.com>
2205
2206         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2207         warnings that would otherwise be suppressed due to it being a system header.
2208
2209         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2210
2211 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2212
2213         Rubber stamped by Adam.
2214         
2215         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2216
2217         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2218
2219 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2220
2221         Sort files(...); sections of Xcode project files.
2222
2223         Rubber-stamped by Darin.
2224
2225         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2226         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2227         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2228         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2229
2230 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2231
2232         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2233
2234         Reviewed by Darin.
2235
2236         * Scripts/sort-Xcode-project-file: Added.
2237
2238 2007-11-02  Darin Adler  <darin@apple.com>
2239
2240         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2241
2242 2007-11-02  Darin Adler  <darin@apple.com>
2243
2244         Reviewed by Maciej.
2245
2246         * Scripts/run-sunspider: Pass the "--base" option through.
2247
2248         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2249         the real script do that. Default configuration to Release to match run-sunspider
2250         so we don't end up building Debug just to compare results.
2251
2252 2007-11-01  Adam Roben  <aroben@apple.com>
2253
2254         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2255
2256         Reviewed by Sam.
2257
2258         * Scripts/commit-log-editor: Show all the directories beneath the
2259         source root, instead of just the last one.
2260
2261 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2262
2263         Reviewed by Adam Roben.
2264
2265         Print out an error message when the Windows build fails
2266         and provide guidance on how to find out what went wrong.
2267
2268         * Scripts/build-webkit:
2269         * Scripts/webkitdirs.pm:
2270
2271 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2272
2273         Rubber-stamped by Adam Roben.
2274
2275         Rolled out r27326 - debug CRT seems to cause no problems after all.
2276
2277         * DumpRenderTree/win/DumpRenderTree.vcproj:
2278
2279 2007-10-31  Adam Roben  <aroben@apple.com>
2280
2281         Switch the Debug configuration to using the non-debug CRT
2282
2283         This matches WebKit.
2284
2285         Reviewed by Steve.
2286
2287         * DumpRenderTree/win/DumpRenderTree.vcproj:
2288
2289 2007-10-31  Antti Koivisto  <antti@apple.com>
2290
2291         Reviewed by bdash.
2292         
2293         Disable media tests when doing leak checking on Tiger.
2294         They crash in QuickTime (rdar://problem/5537157).
2295
2296         * Scripts/run-webkit-tests:
2297
2298 2007-10-29  Antti Koivisto  <antti@apple.com>
2299
2300         Reviewed by Maciej.
2301         
2302         Build media support by default on OSX only.
2303
2304         * Scripts/build-webkit:
2305
2306 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2307
2308         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2309         get caught by the pre-commit hooks.
2310
2311 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2312
2313         Reviewed by Adam.
2314
2315         - This is a collection of relatively unrelated changes and cleanups
2316         to Drosera to prepare it for interacting with WebKit.  A lot of these
2317         changes are just correcting mistakes, for example removing included
2318         headers that are no longer needed.
2319
2320         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2321         this will be needed by the DebuggerClient.
2322         (DebuggerDocument::server):
2323         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2324         * Drosera/win/DebuggerClient.cpp: 
2325         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2326         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2327         (DebuggerClient::createWebViewWithRequest): Added comment about its
2328         purpose. 
2329         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2330         declarations.
2331         (DebuggerClient::webViewLoaded): Moved.
2332         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2333         file, since this was the only place it was used.
2334         (cfStringToBSTR):
2335         * Drosera/win/Drosera.h: Cleaned up the includes.
2336         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2337         * Drosera/win/HelperFunctions.h: Removed.
2338
2339 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2340
2341         Reviewed by Adam.
2342
2343         - Small cleanup in the ServerConnection class.
2344
2345         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2346         and added an include.
2347         (ServerConnection::currentFrame):
2348         (ServerConnection::getCallerFrame):
2349         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2350         made a pointer into a COMPtr, and cleaned up the includes.
2351
2352 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2353
2354         Reviewed by John Sullivan.
2355         
2356         - Place the Localizable.strings file in mac or win directories
2357           if that location exists.
2358         - Also look for UI_STRING in .c files.
2359
2360         * Scripts/extract-localizable-strings:
2361
2362 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2363
2364         Reviewed by Adam.
2365
2366         - Set the eol-style to native and made all the line endings the same
2367         so that I avoid messy diffs that show eol changes.
2368
2369         * Drosera/win/ServerConnection.cpp:
2370         (ServerConnection::didParseSource):
2371         (ServerConnection::didEnterCallFrame):
2372         (ServerConnection::willExecuteStatement):
2373         (ServerConnection::willLeaveCallFrame):
2374         (ServerConnection::exceptionWasRaised):
2375
2376 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2377
2378         Reviewed by Adam.
2379
2380         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2381         functionality that could not have existed previously without the new
2382         interfaces.
2383         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2384         from a BSTR to a JSValueRef.
2385         (DebuggerDocument::platformEvaluateScript): Implemented.
2386         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2387         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2388         Implemented.
2389         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2390         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2391         * Drosera/win/ServerConnection.cpp: Added a helper function.
2392         (ServerConnection::getCallerFrame):
2393         * Drosera/win/ServerConnection.h: Added a helper function.
2394
2395 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2396
2397         updated reviewers for my previous changelog.
2398
2399 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2400         Reviewed by Maciej and Adam and Geoff.
2401
2402         - Minor mac-side improvements including moving a function to a more
2403         appropriate location, fixing a warning, and correctly checking
2404         exceptions.
2405
2406         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2407         (DebuggerDocument::willExecuteStatement):
2408         (DebuggerDocument::didEnterCallFrame):
2409         (DebuggerDocument::willLeaveCallFrame):
2410         (DebuggerDocument::windowScriptObjectAvailable):
2411         (DebuggerDocument::callFunctionOnObject):
2412         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2413         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2414         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2415         because it doesn't require the ServerConnection at all.
2416         (NSStringCreateWithJSStringRef): Made an argument const.
2417         (JSValueRefCreateWithNSString): Made an argument const.
2418         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2419         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2420         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2421         * Drosera/mac/ServerConnection.mm: Ditto.
2422         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2423
2424 2007-10-29  Sam Weinig  <sam@webkit.org>
2425
2426         Reviewed by Adam Roben.
2427
2428         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2429
2430         * DumpRenderTree/LayoutTestController.cpp:
2431         (LayoutTestController::LayoutTestController):
2432         (getGlobalFlagCallback):
2433         (setGlobalFlagCallback):
2434         (LayoutTestController::getJSClass):
2435         (LayoutTestController::staticValues):
2436         * DumpRenderTree/LayoutTestController.h:
2437         (LayoutTestController::globalFlag):
2438         (LayoutTestController::setGlobalFlag):
2439
2440 2007-10-29  Darin Adler  <darin@apple.com>
2441
2442         Reviewed by Maciej.
2443
2444         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2445         resolution instead of its default.
2446
2447 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2448
2449         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2450
2451         Reviewed by Mark Rowe.
2452
2453         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2454         was successfully resolved, but this would not show any status because the change had
2455         already been cached in the index using "git add".  The solution is to add an optional
2456         second argument to showStatus() which adds the "--cached" switch to the command.
2457
2458         * Scripts/resolve-ChangeLogs:
2459         (showStatus):
2460
2461 2007-10-28  Eric Seidel  <eric@webkit.org>
2462
2463         Reviewed by Maciej and Geoff, in unison.
2464
2465         * Scripts/run-webkit-tests: remove broken --svg option
2466
2467 2007-10-28  Darin Adler  <darin@apple.com>
2468
2469         Reviewed by Adam.
2470
2471         * Scripts/run-sunspider: Default to "Release" configuration rather than
2472         defaulting to the last configuration used as other scripts do. This can
2473         still be overriden on the command line with "--debug" if there's some
2474         reason to do so. Also fix a typo.
2475
2476         * Scripts/sunspider-compare-results: Fix a typo.
2477
2478 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2479
2480         Reviewed by Adam.
2481
2482         - Implemented the WebScriptDebugListener functions now that the
2483         WebScriptDebugServer exists
2484
2485         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2486         functions.
2487         (ServerConnection::currentFrame):
2488         (ServerConnection::didLoadMainResourceForDataSource):
2489         (ServerConnection::didParseSource):
2490         (ServerConnection::failedToParseSource):
2491         (ServerConnection::didEnterCallFrame):
2492         (ServerConnection::willExecuteStatement):
2493         (ServerConnection::willLeaveCallFrame):
2494         (ServerConnection::exceptionWasRaised):
2495         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2496         members arguments list.
2497
2498 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2499
2500         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2501         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2502
2503         Reviewed by Darin.
2504
2505         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2506         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2507         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2508         file.  Note that it may also be used as a stand-alone script.
2509
2510         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2511         * Scripts/resolve-ChangeLogs: Added.
2512         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2513
2514 2007-10-26  Mark Rowe  <mrowe@apple.com>
2515
2516         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2517         to the Qt port on the assumption that it was an implementation of the cross-platform
2518         LayoutTestController class.  It is not, so it did not need to be changed.
2519
2520         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2521
2522 2007-10-25  Mark Rowe  <mrowe@apple.com>
2523
2524         Reviewed by Maciej.
2525
2526         Fix builds with code coverage enabled.
2527
2528         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2529
2530 2007-10-25  Darin Adler  <darin@apple.com>
2531
2532         Reviewed by Mark Rowe.
2533
2534         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2535         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2536
2537 2007-10-25  Stephanie  <slewis@apple.com>
2538
2539         build Fix
2540
2541         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2542
2543 2007-10-25  Stephanie  <slewis@apple.com>
2544
2545         Reviewed by Mark Rowe, Adam Roben.
2546
2547         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2548
2549         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2550
2551 2007-10-25  Alice Liu  <alice.liu@apple.com>
2552
2553         Reviewed by Adam.
2554
2555         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2556
2557         Moving destructor into platform-specific files
2558         * DumpRenderTree/LayoutTestController.cpp:
2559         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2560         (LayoutTestController::~LayoutTestController):
2561         * DumpRenderTree/qt/jsobjects.cpp:
2562         (LayoutTestController::~LayoutTestController):
2563
2564         LayoutTestController wasn't being destroyed
2565         * DumpRenderTree/win/DumpRenderTree.cpp:
2566         (runTest):
2567
2568         Added declspec
2569         * DumpRenderTree/win/EditingDelegate.h:
2570
2571         Reset certain values on the webview (or related delegate) that might 
2572         have changed while running a test
2573         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2574         (LayoutTestController::~LayoutTestController):
2575
2576 2007-10-25  Adam Roben  <aroben@apple.com>
2577
2578         Make sunspider-compare-results work with relative paths
2579
2580         Reviewed by Sam.
2581
2582         * Scripts/sunspider-compare-results: Convert arguments to absolute
2583         paths before we chdir.
2584
2585 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2586
2587         Reviewed by Sam.
2588
2589         - Implemented server calls now the WebScriptDebugServer exists.
2590         - Also removed no longer needed call to initialize CG.
2591
2592         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2593         automatically now.
2594         (_tWinMain):
2595         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2596         (ServerConnection::ServerConnection):
2597         (ServerConnection::~ServerConnection):
2598         (ServerConnection::pause):
2599         (ServerConnection::resume):
2600         (ServerConnection::stepInto):
2601         (ServerConnection::applicationTerminating):
2602         (ServerConnection::serverConnectionDidDie):
2603         * Drosera/win/ServerConnection.h: Now uses the COM class.
2604
2605 2007-10-24  George Staikos  <staikos@kde.org>
2606
2607         Unbreak Qt build.
2608
2609         * Scripts/build-webkit:
2610
2611 2007-10-24  Adam Roben  <aroben@apple.com>
2612
2613         Remove now-unnecessary call to InitializeCoreGraphics
2614
2615         WebKit takes care of this now.
2616
2617         Reviewed by Ada.
2618
2619         * DumpRenderTree/win/DumpRenderTree.cpp:
2620         (initialize):
2621
2622 2007-10-24  Adam Roben  <aroben@apple.com>
2623
2624         Use WebTextRenderer in DRT
2625
2626         Reviewed by Ada.
2627
2628         * DumpRenderTree/win/DumpRenderTree.cpp:
2629         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2630
2631 2007-10-24  Sven Herzberg  <sven@imendio.com>
2632
2633         Reviewed by Mark Rowe.
2634
2635         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2636         Bug 15614: [GTK] qmake based backends don't build on OS X
2637
2638         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2639         GTK backend on a Mac
2640         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2641         isDarwin() to make it reusable in other places (like the workaround-
2642         for-prebuilt-qmake in build-webkit)
2643
2644 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2645
2646         Refurbish update-webkit script.
2647
2648         Reviewed by Adam.
2649
2650         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2651         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2652         multi-argument version of system() for flexibility and security.  Check for existence
2653         of Internal directory using -d test instead of -x.
2654
2655 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2656
2657         Minor clean-up of prepare-ChangeLog script.
2658
2659         Reviewed by Adam.
2660
2661         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2662         of a string.  Use multi-argument versions of open() and system() for flexibility and
2663         security.
2664
2665 2007-10-24  Alice Liu  <alice.liu@apple.com>
2666
2667         Reviewed by Oliver.
2668
2669         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2670
2671         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2672         replay the saved events when we're still processing the mousedown that starts the drag
2673         * DumpRenderTree/win/EventSender.cpp:
2674         (doMouseMove):
2675         * DumpRenderTree/win/UIDelegate.cpp:
2676         (UIDelegate::doDragDrop):
2677
2678 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2679
2680         Reviewed by Sam, Steve and Darin.
2681
2682         - Stubbed out the WebScriptDebugListener functionality in the Server
2683         Connection class to prepare it for receiving those callbacks.
2684         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2685         and the ServerConnection to not need to be initialized with a server
2686         name, since that is not the way we connect to the WebKit server. 
2687
2688         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2689         no exception.  Now it only loggs when there is an exception
2690         (DebuggerDocument::willExecuteStatement):
2691         (DebuggerDocument::didEnterCallFrame):
2692         (DebuggerDocument::willLeaveCallFrame):
2693         (DebuggerDocument::windowScriptObjectAvailable):
2694         (DebuggerDocument::callFunctionOnObject):
2695         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2696         to be instantiated with a server's name.
2697         (DebuggerClient::DebuggerClient):
2698         (DebuggerClient::didFinishLoadForFrame):
2699         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2700         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2701         a server name.
2702         (Drosera::init):
2703         (Drosera::initServer):
2704         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2705         instantiated with a server's name.
2706         * Drosera/win/ServerConnection.cpp: 
2707         (ServerConnection::ServerConnection): No longer needs a server name
2708         (ServerConnection::~ServerConnection): Only release the global context
2709         if there is one.
2710         (ServerConnection::serverConnectionDidDie): Stub for
2711         IWebScriptDebugListener
2712         (ServerConnection::QueryInterface): ditto
2713         (ServerConnection::AddRef): ditto
2714         (ServerConnection::Release): ditto
2715         (ServerConnection::didLoadMainResourceForDataSource): ditto
2716         (ServerConnection::didParseSource): ditto
2717         (ServerConnection::failedToParseSource): ditto
2718         (ServerConnection::didEnterCallFrame): ditto
2719         (ServerConnection::willExecuteStatement): ditto
2720         (ServerConnection::willLeaveCallFrame): ditto
2721         (ServerConnection::exceptionWasRaised): ditto
2722         * Drosera/win/ServerConnection.h: Stubbed out the
2723         IWebScriptDebugListener functions, and this class no longer needs to be
2724         instantiated with a server name.
2725
2726 2007-10-24  Lars Knoll  <lars@trolltech.com>
2727
2728         Reviewed by Simon.
2729
2730         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2731
2732         * DumpRenderTree/qt/jsobjects.h:
2733
2734 2007-10-24  Lars Knoll  <lars@trolltech.com>
2735
2736         Reviewed by Simon.
2737
2738         add another command.
2739
2740         * DumpRenderTree/qt/jsobjects.cpp:
2741         (TextInputController::doCommand):
2742
2743 2007-10-24  Lars Knoll  <lars@trolltech.com>
2744
2745         Reviewed by Simon.
2746
2747         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2748
2749         * DumpRenderTree/qt/jsobjects.cpp:
2750         (EventSender::keyDown):
2751         * DumpRenderTree/qt/jsobjects.h:
2752
2753 2007-10-24  Lars Knoll  <lars@trolltech.com>
2754
2755         Reviewed by Simon.
2756
2757         implement eventSender.keyDown().
2758
2759         * DumpRenderTree/qt/jsobjects.cpp:
2760         (EventSender::keyDown):
2761
2762 2007-10-24  Lars Knoll  <lars@trolltech.com>
2763
2764         Reviewed by Simon.
2765
2766         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2767
2768         * DumpRenderTree/qt/DumpRenderTree.cpp:
2769         (WebCore::DumpRenderTree::DumpRenderTree):
2770         (WebCore::DumpRenderTree::initJSObjects):
2771         * DumpRenderTree/qt/jsobjects.cpp:
2772         (TextInputController::doCommand):
2773
2774 2007-10-24  Lars Knoll  <lars@trolltech.com>
2775
2776         Reviewed by Simon.
2777
2778         first bit of implementation for the textinputcontroller.
2779
2780         * DumpRenderTree/qt/DumpRenderTree.cpp:
2781         (WebCore::DumpRenderTree::DumpRenderTree):
2782         * DumpRenderTree/qt/DumpRenderTree.h:
2783         * DumpRenderTree/qt/jsobjects.cpp:
2784         (TextInputController::TextInputController):
2785         (TextInputController::doCommand):
2786         * DumpRenderTree/qt/jsobjects.h:
2787
2788 2007-10-24  Lars Knoll  <lars@trolltech.com>
2789
2790         Reviewed by Simon.
2791
2792         make the man webpage believe it has focus, so the editing tests work correctly.
2793
2794         * DumpRenderTree/qt/DumpRenderTree.cpp:
2795         (WebCore::DumpRenderTree::DumpRenderTree):
2796
2797 2007-10-24  Lars Knoll  <lars@trolltech.com>
2798
2799         Reviewed by Simon.
2800
2801         implement layoutTestController.dumpEditingCallbacks() correctly.
2802
2803         * DumpRenderTree/qt/DumpRenderTree.cpp:
2804         (WebCore::DumpRenderTree::DumpRenderTree):
2805         * DumpRenderTree/qt/jsobjects.cpp:
2806         (LayoutTestController::reset):
2807         (LayoutTestController::dumpEditingCallbacks):
2808
2809 2007-10-24  Lars Knoll  <lars@trolltech.com>
2810
2811         Reviewed by Simon.
2812
2813         Implement support for testing editing.
2814
2815         * DumpRenderTree/qt/DumpRenderTree.cpp:
2816         (WebCore::DumpRenderTree::DumpRenderTree):
2817
2818 2007-10-23  Sam Weinig  <sam@webkit.org>
2819
2820         Check for null BSTR that can be passed to the UIDelegate methods
2821         from javascript null and undefined.  Fixes a failing test case on
2822         Windows (fast/dom/Window/alert-undefined.html)
2823
2824         Reviewed by Eric Seidel.
2825
2826         * DumpRenderTree/win/UIDelegate.cpp:
2827         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2828         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2829         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2830         (UIDelegate::webViewAddMessageToConsole):
2831
2832 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2833
2834         Reviewed by Darin.
2835         
2836         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2837
2838         * Scripts/build-testkjs:
2839
2840 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2841
2842         Reviewed by Darin.
2843
2844         - add wrapper that finds the right copy of testkjs
2845         
2846         * Scripts/sunspider-compare-results: Added.
2847
2848 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2849
2850         Reviewed by Sam.
2851
2852         - After talking with Steve I now see that the WebKit server must be
2853         running for DCOM to create the distributed objects, which makes sense
2854         and currently WebKit only allows one instance to be running at a time
2855         which avoids accidentally connecting to the wrong server
2856         - In light of this I have removed the code for the attach box and
2857         NotificationServer and known server names, since they are all extranious
2858         now.
2859
2860         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2861         names.
2862         (_tWinMain): Uses init instead of initUI.
2863         (droseraWndProc): No longer creats an attach dialog box.
2864         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2865         it's not manditory to call init before doing COM stuff.
2866         (Drosera::init): calls initUI and will call attach when the
2867         functionality exists. 
2868         (Drosera::initUI): Has changed very little.
2869         (Drosera::attach): Changed the signature to reflect that we no longer
2870         need the dictionary of known server names.
2871         * Drosera/win/Drosera.h: Removed notification classes and known server
2872         names.  Also renamed and moved some functions.
2873         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2874         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2875         headers to the resources folder. 
2876         * Drosera/win/resource.h: Removed the Attach box.
2877
2878 2007-10-22  Adam Roben  <aroben@apple.com>
2879
2880         Windows build fix
2881
2882         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2883
2884 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2885
2886         - Removed a leak that was fixed.
2887
2888         * Scripts/run-webkit-tests:
2889
2890 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2891
2892         Reviewed by Darin.
2893
2894         - Changed the Client so that the DebuggerDocument now own the
2895         ServerConnection.  This simplifies ownership and cleanup. 
2896
2897         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2898         ServerConnection.
2899         (DebuggerClient::initWithServerName):
2900         (DebuggerClient::didFinishLoadForFrame):
2901         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2902         ServerConnection.
2903         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2904         until after we have a server which we are attached to.
2905         (Drosera::initUI):
2906         (Drosera::attach):
2907         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2908         out previously.
2909
2910 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2911
2912         Reviewed by Nikolas.
2913
2914         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2915
2916         * Scripts/run-javascriptcore-tests:
2917
2918 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2919
2920         Reviewed by Nikolas.
2921
2922         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2923
2924         * Scripts/build-drosera:
2925         * Scripts/build-dumprendertree:
2926         * Scripts/build-testkjs:
2927         * Scripts/build-webkit:
2928         * Scripts/run-javascriptcore-tests:
2929         * Scripts/run-sunspider:
2930         * Scripts/run-webkit-tests:
2931         * Scripts/webkitdirs.pm:
2932
2933 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2934
2935         Reviewed by Mark Rowe.
2936         
2937         Fix for local database support after r26879
2938         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2939
2940         * Scripts/build-webkit:
2941
2942 2007-10-22  Holger Freyther  <zecke@selfish.org>
2943
2944         Reviewed by Simon Hausmann <hausmann@kde.org>.
2945
2946         - Do not build testkjs as an application bundle. This is
2947         needed for run-javascriptcore-tests on OSX.
2948         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2949         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2950         as we do not have -rpath on OSX.
2951
2952         * DumpRenderTree/qt/DumpRenderTree.pro:
2953         * Scripts/run-webkit-tests:
2954
2955 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2956
2957         Reviewed by aroben.
2958
2959         Fix support for Signed-off-by detection in prepare-ChangeLog
2960         --git-commit. The Signed-off-by tag does not appear in the header
2961         but usually at the end.
2962
2963         * Scripts/prepare-ChangeLog:
2964
2965 2007-10-21  Mark Rowe  <mrowe@apple.com>
2966
2967         Reviewed by Eric.
2968
2969         Fix run-javascriptcore-tests for Gtk.
2970
2971         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2972
2973 2007-10-20  Eric Seidel  <eric@webkit.org>
2974
2975         Reviewed by aroben.
2976
2977         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2978
2979 2007-10-20  Eric Seidel  <eric@webkit.org>
2980
2981         Reviewed by darin.
2982         
2983         Add improved argument handling to run-sunspider, including
2984         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2985         Also re-factor code into subroutines
2986
2987         * Scripts/build-dumprendertree: removed bogus comments
2988         * Scripts/build-testkjs: Added.
2989         * Scripts/run-javascriptcore-tests: use build-testkjs
2990         * Scripts/run-sunspider: improved argument handling, abstraction
2991         * Scripts/run-webkit-tests: improved abstraction
2992
2993 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2994
2995         Not reviewed, Windows build fix.
2996
2997         * DumpRenderTree/win/EventSender.cpp:
2998         (keyDownCallback):
2999
3000 2007-10-20  Darin Adler  <darin@apple.com>
3001
3002         Reviewed by Tim Hatcher.
3003
3004         - http://bugs.webkit.org/show_bug.cgi?id=15544
3005           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3006           not rely on Apple-specific key codes
3007
3008         * DumpRenderTree/mac/EventSendingController.mm:
3009         (-[EventSendingController keyDown:withModifiers:]):
3010         Added named key "rightArrow". Later we could have a whole table of these.
3011         Also tweaked modifiers code a little.
3012
3013         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3014
3015 2007-10-19  Darin Adler  <darin@apple.com>
3016
3017         Reviewed by Eric.
3018
3019         - http://bugs.webkit.org/show_bug.cgi?id=15566
3020           possible fix for leak seen in DumpRenderTree
3021
3022         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3023         Delete the item if it's not put on the queue, since the caller has
3024         no way of knowing that. Would be better to have the parameter type
3025         be auto_ptr to express the fact that we take ownership.
3026
3027         - unrelated change
3028
3029         * Drosera/mac/main.m: Add missing include.
3030
3031 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3032
3033         Reviewed by Adam.
3034
3035         - This change should be identical but for some reason was not working
3036         on my machine.
3037
3038         * Scripts/prepare-ChangeLog:
3039
3040 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3041
3042         Reviewed by Oliver and Tim.
3043
3044         - Made use of RetainPtr to avoid retain and release issues and moved the
3045         log function to DebuggerDocumentPlatform, which seems to be a more
3046         logical place for it to live.
3047         - Also moved knownServers from the ServerConnection to
3048         DebuggerApplication to match the Windows code and because it makes sense
3049         that a connection knows its own server but not all of them.
3050
3051         * Drosera/mac/DebuggerClient.h: Moved the log function to
3052           DebuggerDocumentPlatform.
3053         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3054           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3055           call for the server name up from the ServerConnection class.
3056         (-[DebuggerClient dealloc]):
3057         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3058           for the server name up from the ServerConnection.
3059         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3060         (DebuggerDocument::platformPause):
3061         (DebuggerDocument::platformResume):
3062         (DebuggerDocument::platformStepInto):
3063         (DebuggerDocument::platformEvaluateScript):
3064         (DebuggerDocument::getPlatformCurrentFunctionStack):
3065         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3066         (DebuggerDocument::platformValueForScopeVariableNamed):
3067         (DebuggerDocument::platformLog): Log directly from here. No need to call
3068           DebuggerClient.
3069         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3070           way I see it, a ServerConnection should only know about its connection
3071           and the group of all possible servers should be kept by the
3072           application.
3073         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3074           currentServerName, it makes sense that the connection should know that
3075           name.
3076         (-[ServerConnection currentServerName]):
3077
3078 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3079
3080         Reviewed by Adam.
3081
3082         - Integrated changes from mac drosera.  Recently I've encapsulated
3083         out the server connection object from the rest of Drosera because
3084         it is very platform dependent right now and RPC is not implemented on
3085         windows.  This functionality, of communicating with the WebKit server
3086         is the next area I will be focusing on in Windows.
3087
3088         - Other changes and cleanup were made to organize the code and add notes
3089         on which parts still need work.  Also some mac code is added and
3090         commented out, to act as pseudocode for the logic of those parts.
3091
3092         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3093           pointer.
3094         * Drosera/config.h: Added whitespace.
3095         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3096           these files got moved into Drosera.h/cpp
3097         * Drosera/win/DebuggerApplication.h: Removed.
3098         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3099           happened here to better match the logic flow of the same code on the 
3100           mac side and to use the new ServerConnection class.
3101         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3102         (DebuggerClient::initWithServerName): Initializer that will set up the
3103           class to use a ServerConnection object.  This was necessary so I could
3104           create a DebuggerClient without having to initilaize it at
3105           construction.
3106         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3107           will be the UIDelegate and FrameLoadDelegate.
3108         (DebuggerClient::AddRef): For IUnknown.
3109         (DebuggerClient::Release): For IUnknown.
3110         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3111           this still needs to set the global context of the server, but
3112           IWebFrame does not have an accessor for the global context yet. 
3113         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3114           this is a pass through for the same function in the document.
3115         (DebuggerClient::didReceiveTitle): Unimplemented part of
3116           FrameLoadDelegate this would change the title of the window.
3117         (DebuggerClient::createWebViewWithRequest): Part of the
3118           FrameLoadDelegate.  This is about new windows via Window.open() and
3119           how their delegates are set.
3120         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3121           UIDelegate.  Just a debug function for printing messages.
3122         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3123           because the Client should be the UIDelegate and FrameLoadDelegate
3124           to match the delegates on mac.
3125         (DebuggerClient::webViewLoaded): Added accessor method.
3126         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3127           forgotten to add this file before.  This is where the platform
3128           dependent versions of the Documents functions live. Most of these are
3129           unimplemented because some piece of functionality does not exist on
3130           Windows yet.
3131         (DebuggerDocument::platformPause):
3132         (DebuggerDocument::platformResume):
3133         (DebuggerDocument::platformStepInto):
3134         (DebuggerDocument::platformEvaluateScript):
3135         (DebuggerDocument::getPlatformCurrentFunctionStack):
3136         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3137         (DebuggerDocument::platformValueForScopeVariableNamed):
3138         (DebuggerDocument::platformLog):
3139         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3140           responsibilities becaue they belong in the Client. Also I laid the
3141           groundwork for attaching Drosera to a WebKit process
3142         (attachWndProc): Now if a server is selected the Client becomes it's
3143           delegate.
3144         (Drosera::Drosera): Added the construction of the Client and dictionary
3145           of server names. 
3146         (Drosera::initUI): This is no longer the delegates, the Client is.
3147         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3148           state. 
3149         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3150           notification registration when it's possible to implement.
3151         (Drosera::serverLoaded): Ditto
3152         (Drosera::serverUnloaded): Ditto
3153         (Drosera::attach): Attach Drosera to the WebKit server.
3154         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3155         (Drosera::getInst): 
3156         (Drosera::setInst):
3157         (Drosera::knownServers):
3158         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3159           and added the ServerConnection.
3160         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3161         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3162           Most of the functions are completely unimlemented because they cannot
3163           connect with the WebKit server, because one does not exist on Windows
3164           yet.
3165         (ServerConnection::initWithServerName): 
3166         (ServerConnection::~ServerConnection):
3167         (ServerConnection::setGlobalContext):
3168         (ServerConnection::pause):
3169         (ServerConnection::resume):
3170         (ServerConnection::stepInto):
3171         (ServerConnection::switchToServerNamed):
3172         (ServerConnection::applicationTerminating):
3173         (ServerConnection::serverConnectionDidDie):
3174         (ServerConnection::currentFrame):
3175         * Drosera/win/ServerConnection.h: Added. Ditto.
3176         (ServerConnection::ServerConnection):
3177
3178 2007-10-19  Alice Liu  <alice.liu@apple.com>
3179
3180         Reviewed by Darin.
3181
3182         Fix for these broken layout tests on Windows:
3183         
3184         fast/forms/focus-selection-input.html
3185         fast/forms/focus-selection-textarea.html
3186         fast/forms/select-accesskey.html
3187         
3188         * DumpRenderTree/win/EventSender.cpp:
3189         (keyDownCallback):
3190         correct the VK code for alt key.
3191         
3192 2007-10-19  Eric Seidel  <eric@webkit.org>
3193
3194         Reviewed by Mark Rowe.
3195         
3196         Make the GtkLauncher code slightly more readable.
3197
3198         * GtkLauncher/main.cpp:
3199         (setupMainMenu): Added.
3200         (setupMainWindowUI): Added.
3201         (main):
3202
3203 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3204
3205         Rubber stamped by Adam.
3206         
3207         - don't delay-load WebKit in DumpRenderTree.
3208
3209         * DumpRenderTree/win/DumpRenderTree.vcproj:
3210
3211 2007-10-18  Dan Bernstein  <mitz@apple.com>
3212
3213         Reviewed by Adam Roben.
3214
3215         - fix <rdar://problem/5313523>
3216         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3217
3218         * DumpRenderTree/mac/DumpRenderTree.mm:
3219         (dump): Changed to use _responseMIMEType.
3220
3221 2007-10-17  Adam Roben  <aroben@apple.com>
3222
3223         Make it possible to have Windows-specific tests and results
3224
3225         When searching for tests to run and the Skipped file, we will only
3226         look in platform/win and the cross-platform directory. When looking
3227         for expected results, we will look in platform/win, then
3228         platform/mac-leopard, then platform/mac, then finally the
3229         cross-platform directory.
3230
3231         Reviewed by Sam.
3232
3233         * Scripts/run-webkit-tests:
3234         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3235         searching in the cross-platform directory.
3236         (sub buildPlatformHierarchy): Removed some unneeded calls to
3237         dirname/basename.
3238
3239 2007-10-17  Adam Roben  <aroben@apple.com>
3240
3241         Add back the call to register WebKit that we had before WebKitInitializer existed
3242
3243         This is needed to ensure that the right WebKit is used when
3244         instantiating COM objects.
3245
3246         Reviewed by Oliver.
3247
3248         * DumpRenderTree/win/debug_internal.vsprops: Define
3249         DEBUG_WEBKIT_HAS_SUFFIX.
3250         * DumpRenderTree/win/DumpRenderTree.cpp:
3251         (initialize):
3252
3253 2007-10-17  Adam Roben  <aroben@apple.com>
3254
3255         Import File::Basename in webkitdirs since we use it
3256
3257         * Scripts/webkitdirs.pm:
3258
3259 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3260
3261         - Updated the tiger leaks list to make the internal bots green.
3262
3263         * Scripts/run-webkit-tests:
3264
3265 2007-10-17  Adam Roben  <aroben@apple.com>
3266
3267         Build fix for VC++ Express
3268
3269         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3270         and ole32.lib.
3271
3272 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3273
3274         Reviewed by Sam.
3275
3276         - Minor mac improvements based on observations I made while implementing the
3277         Windows code.
3278
3279         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3280         then hand it to the Client who will retain it, it should just be the client who
3281         creates and owns the server.
3282         (-[DebuggerApplication attach:]):
3283         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3284         * Drosera/mac/DebuggerClient.mm: Creates the server.
3285         (-[DebuggerClient initWithServerName:]):
3286         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3287         can instead forward declare what it needs.
3288
3289 2007-10-16  Darin Adler  <darin@apple.com>
3290
3291         Reviewed by Geoff Garen.
3292
3293         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3294         want to turn failing tests into platform-specific test results. Also did a
3295         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3296         would take the type of results into account only some of the time.
3297
3298 2007-10-16  Adam Roben  <aroben@apple.com>
3299
3300         Add a new nightly launcher script for Windows
3301
3302         This new script is for versions of Safari that don't delay-load
3303         WebKit. I had to make FindSafari be able to print out the nightly
3304         launcher script on stdout because Windows shell scripts can't capture
3305         the output from a command into an environment variable.
3306
3307         Reviewed by Steve.
3308
3309         * FindSafari/FindSafari.cpp:
3310         (_tmain): Added /printSafariLauncher option.
3311         * Scripts/run-webkit-nightly.cmd: Added.
3312
3313 2007-10-16  Adam Roben  <aroben@apple.com>
3314
3315         Replace WebKitInitializer with FindSafari
3316
3317         We now rely on setting the PATH environment variable to tell Windows
3318         where to find WebKit and its dependencies (similar to
3319         DYLD_FRAMEWORK_PATH on Mac).
3320
3321         This change also make DumpRenderTree no longer delay-load WebKit.
3322
3323         Reviewed by Sam.
3324
3325         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3326         FindSafari.
3327         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3328         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3329         WebKitInitializer, don't delay-load WebKit.
3330         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3331         * Scripts/run-webkit-tests: Ditto.
3332         * Scripts/webkitdirs.pm:
3333         (sub setPathForRunningWebKitApp): Added.
3334         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3335         * WebKitInitializer/WebKitInitializer.h: Removed.
3336         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3337         * WebKitInitializer/debug.vsprops: Removed.
3338         * WebKitInitializer/debug_internal.vsprops: Removed.
3339         * WebKitInitializer/release.vsprops: Removed.
3340
3341 2007-10-16  Adam Roben  <aroben@apple.com>
3342
3343         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3344
3345         http://bugs.webkit.org/show_bug.cgi?id=15532
3346
3347         FindSafari simply prints the location of an installed Safari.exe on
3348         stdout.
3349
3350         Reviewed by Darin.
3351
3352         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3353         (getStringValue):
3354         (getWebViewCLSID):
3355         (getInstalledWebKitDirectory):
3356         (_tmain):
3357         * FindSafari/FindSafari.vcproj: Added.
3358         * Scripts/webkitdirs.pm:
3359         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3360
3361 2007-10-16  Adam Roben  <aroben@apple.com>
3362
3363         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3364
3365         Reviewed by Kevin McCullough.
3366
3367         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3368         when referring to WebKit.dll.
3369         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3370         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3371         * DumpRenderTree/win/release.vsprops: Ditto.
3372         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3373         never have a _debug suffix on WebKit.dll.
3374         * WebKitInitializer/WebKitInitializer.cpp:
3375         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3376         specified.
3377         * WebKitInitializer/debug_internal.vsprops: Added
3378         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3379
3380 2007-10-16  Darin Adler  <darin@apple.com>
3381
3382         Reviewed by Adele.
3383
3384         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3385         Remove now-unneeded control/alt key hack; the tests have been updated.
3386
3387 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3388
3389         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3390         one of the leaks was fixed between that revision and the bot's previous version of
3391         leopard.
3392
3393         * Scripts/run-webkit-tests:
3394
3395 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3396
3397         Reviewed by Tim.
3398
3399         - I encapsulated out the server connecton functionality because it is a specific part
3400         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3401         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3402         Windows.  So the majority of this patch is moving preexisting functionality.
3403
3404         - Also I removed the prefix header and changed to use config.h because it is more
3405         standard on how we use config.h in windows and it didn't make much sense to keep
3406         the prefix header and the config.h
3407
3408         * Drosera/DebuggerDocument.cpp:
3409         (DebuggerDocument::DebuggerDocument):
3410         * Drosera/DebuggerDocument.h:
3411         * Drosera/config.h:
3412         * Drosera/mac/DebuggerApplication.mm:
3413         (-[DebuggerApplication attach:]):
3414         * Drosera/mac/DebuggerClient.h:
3415         * Drosera/mac/DebuggerClient.mm:
3416         (-[DebuggerClient initWithServerConnection:]):
3417         (-[DebuggerClient dealloc]):
3418         (-[DebuggerClient windowDidLoad]):
3419         (-[DebuggerClient windowWillClose:]):
3420         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3421         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3422         * Drosera/mac/DebuggerDocumentPlatform.mm:
3423         (DebuggerDocument::platformPause):
3424         (DebuggerDocument::platformResume):
3425         (DebuggerDocument::platformStepInto):
3426         (DebuggerDocument::platformEvaluateScript):
3427         (DebuggerDocument::getPlatformCurrentFunctionStack):
3428         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3429         (DebuggerDocument::platformValueForScopeVariableNamed):
3430         (DebuggerDocument::platformLog):
3431         * Drosera/mac/Drosera.pch: Removed.
3432         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3433         * Drosera/mac/ServerConnection.h: Added.
3434         * Drosera/mac/ServerConnection.mm: Added.
3435         (-[ServerConnection initWithServerName:]):
3436         (-[ServerConnection dealloc]):
3437         (-[ServerConnection setGlobalContext:]):
3438         (-[ServerConnection pause]):
3439         (-[ServerConnection resume]):
3440         (-[ServerConnection stepInto]):
3441         (-[ServerConnection switchToServerNamed:]):
3442         (-[ServerConnection applicationTerminating:]):
3443         (-[ServerConnection serverConnectionDidDie:]):
3444         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3445         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3446         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3447         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3448         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3449         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3450         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3451         (-[ServerConnection currentFrame]):
3452         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3453         (-[ServerConnection knownServers]):
3454
3455 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3456
3457         Reviewed by Eric.
3458
3459         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3460           Script to automatically search nightly builds for regressions (bisect-builds)
3461
3462         * Scripts/bisect-builds: Added.
3463
3464 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3465
3466         Reviewed by Darin.
3467
3468         - New JavaScript benchmark
3469         http://bugs.webkit.org/show_bug.cgi?id=15515
3470
3471         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3472         current development or release build of JavaScriptCore.
3473
3474 2007-10-15  Mark Rowe  <mrowe@apple.com>
3475
3476         Reviewed by Sam.
3477
3478         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3479
3480         * Scripts/webkitdirs.pm:
3481         - Change checkArgv to remove the options from @ARGV to prevent
3482         them from interfering with further option processing.
3483         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3484         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3485         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3486         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3487
3488 2007-10-15  Darin Adler  <darin@apple.com>
3489
3490         Reviewed by Sam.
3491
3492         - added logging of window.prompt and window.confirm
3493
3494         * DumpRenderTree/mac/UIDelegate.mm:
3495         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3496         Implement the recommended delegate rather than the deprecated one.
3497         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3498         Added.
3499         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3500         Added.
3501
3502         * DumpRenderTree/win/UIDelegate.h:
3503         * DumpRenderTree/win/UIDelegate.cpp:
3504         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3505         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3506         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3507         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3508
3509 2007-10-15  Alice Liu  <alice.liu@apple.com>
3510
3511         Reviewed by Sam Weinig.
3512
3513         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3514
3515         * DumpRenderTree/win/DumpRenderTree.cpp:
3516         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3517         (main): allocate the global policy delegate for DRT's custom use
3518         * DumpRenderTree/win/DumpRenderTree.vcproj:
3519         Adding files to project
3520         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3521         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3522         (LayoutTestController::setCustomPolicyDelegate):
3523         set the webview's policy delegate to DRT's custom one if the test requests it.
3524         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3525         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3526         (PolicyDelegate::PolicyDelegate):
3527         (PolicyDelegate::QueryInterface):
3528         (PolicyDelegate::AddRef):
3529         (PolicyDelegate::Release):
3530         (PolicyDelegate::decidePolicyForNavigationAction):
3531         * DumpRenderTree/win/PolicyDelegate.h: Added.
3532         (PolicyDelegate::decidePolicyForNewWindowAction):
3533         (PolicyDelegate::decidePolicyForMIMEType):
3534         (PolicyDelegate::unableToImplementPolicyWithError):
3535
3536 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3537
3538         Reviewed by Mark.
3539
3540         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3541         when querying for QMAKE_MKSPECS.
3542
3543 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3544
3545         Reviewed by Adam Roben.
3546         
3547         Fix run-webkit-tests is too greedy calculating platform hierarchy
3548         http://bugs.webkit.org/show_bug.cgi?id=15465
3549         
3550         Fix run-webkit-tests being too greedy in trying to split the platform name up
3551         causing it to try and find tests in every directory above the first "-" in the
3552         path to the LayoutTests
3553
3554         * Scripts/run-webkit-tests:
3555
3556 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3557
3558         Reviewed by Darin.
3559
3560         http://bugs.webkit.org/show_bug.cgi?id=15006
3561         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3562         to reduce code duplication.
3563
3564         * Scripts/build-webkit:
3565         * Scripts/webkitdirs.pm:
3566         buildQMakeProject() renamed to buildQMakeQtProject().
3567         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3568         unused $colorize has been removed.
3569
3570 === Start merge of feature-branch 2007-10-12 ===
3571
3572 2007-10-08  Eric Seidel  <eric@webkit.org>
3573
3574         Reviewed by Mark Rowe.
3575
3576         * Scripts/build-webkit: add --help, remove unused --color
3577
3578 2007-10-07  Eric Seidel  <eric@webkit.org>
3579
3580         Reviewed by darin.
3581
3582         * Drosera/mac/DebuggerDocumentPlatform.mm:
3583         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3584
3585 2007-10-03  Rob Buis  <buis@kde.org>
3586
3587         Reviewed by Olliej.
3588
3589         Adapt to changed location of Ahem font.
3590
3591         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3592
3593 2007-10-02  Eric Seidel  <eric@webkit.org>
3594
3595         Reviewed by Adam Roben.
3596         
3597         Make pixel tests more useful!
3598         Finally fix the image diff 0.00% mystery problem
3599         Highlight any image differences in the image diff.
3600         Add a link from image diffs back to original test file.
3601
3602         * DumpRenderTree/mac/ImageDiff.m:
3603         (compareImages): highlight any differences
3604         (computePercentageDifferent): round to two decimal places
3605         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3606
3607 2007-10-02  Eric Seidel  <eric@webkit.org>
3608
3609         Reviewed by Alexey Proskuryakov.
3610
3611         * Scripts/run-webkit-tests: print the % image difference on main results page
3612
3613 2007-10-02  Mark Rowe  <mrowe@apple.com>
3614
3615         Reviewed by Oliver.