2009-11-20 Chris Fleizach <cfleizach@apple.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-20  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         BuildQueue should check if the tree is currently buildable
6         https://bugs.webkit.org/show_bug.cgi?id=31744
7
8         * Scripts/bugzilla-tool:
9         * Scripts/modules/landingsequence.py:
10         * Scripts/modules/webkitlandingscripts.py:
11
12 2009-11-20  Adam Barth  <abarth@webkit.org>
13
14         Reviewed by Eric Seidel.
15
16         Move prepare_clean_working_directory into the LandingSequence
17         https://bugs.webkit.org/show_bug.cgi?id=31743
18
19         * Scripts/bugzilla-tool:
20         * Scripts/modules/landingsequence.py:
21
22 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
23
24         Reviewed by Kenneth Rohde Christiansen.
25
26         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
27         https://bugs.webkit.org/show_bug.cgi?id=30460
28
29         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
30
31         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
32         (pluginInvoke):
33
34 2009-11-20  Adam Barth  <abarth@webkit.org>
35
36         Reviewed by Eric Seidel.
37
38         Pass the port information to the child process
39         https://bugs.webkit.org/show_bug.cgi?id=31736
40
41         We need to do this so the child process knows what to build!
42
43         * Scripts/bugzilla-tool:
44         * Scripts/modules/landingsequence.py:
45         * Scripts/modules/webkitport.py:
46         * Scripts/modules/webkitport_unittest.py:
47
48 2009-11-20  Adam Barth  <abarth@webkit.org>
49
50         Reviewed by Eric Seidel.
51
52         Support Qt port in build-queue
53         https://bugs.webkit.org/show_bug.cgi?id=31733
54
55         * Scripts/bugzilla-tool:
56
57 2009-11-20  Adam Barth  <abarth@webkit.org>
58
59         Reviewed by Eric Seidel.
60
61         Implement a build-queue
62         https://bugs.webkit.org/show_bug.cgi?id=31725
63
64         Currently this just builds the first 10 patches in the review queue.
65         We'll want to do something smarter soon.
66
67         * Scripts/bugzilla-tool:
68
69 2009-11-20  Adam Barth  <abarth@webkit.org>
70
71         Reviewed by Eric Seidel.
72
73         Make commit-queue and style-queue show up in help
74         https://bugs.webkit.org/show_bug.cgi?id=31724
75
76         We need to store their names on their class to make these commands
77         properly register themselves with MultiCommandTool.
78
79         * Scripts/bugzilla-tool:
80
81 2009-11-20  Adam Barth  <abarth@webkit.org>
82
83         Reviewed by Eric Seidel.
84
85         Implement bugzilla-tool build-attachment
86         https://bugs.webkit.org/show_bug.cgi?id=31722
87
88         This command builds an attachment from bugzilla.  It leaves the built
89         patch in the working copy.
90
91         * Scripts/bugzilla-tool:
92         * Scripts/modules/landingsequence.py:
93         * Scripts/modules/webkitlandingscripts.py:
94
95 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
96
97         Reviewed by Xan Lopez.
98
99         [GTK] DRT release event does not create the state correctly
100         https://bugs.webkit.org/show_bug.cgi?id=31717
101
102         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
103
104 2009-11-20  Eric Seidel  <eric@webkit.org>
105
106         Reviewed by Adam Barth.
107
108         MultiCommandTool should find Command objects automatically instead of with a manual list
109         https://bugs.webkit.org/show_bug.cgi?id=31710
110
111         * Scripts/bugzilla-tool:
112         * Scripts/modules/multicommandtool.py:
113          - Use some wild python-fu to crawl all the known subclasses of Command.
114
115 2009-11-20  Adam Barth  <abarth@webkit.org>
116
117         Unreviewed "build" fix.  Added missing import.
118
119         * Scripts/bugzilla-tool:
120
121 2009-11-20  Adam Barth  <abarth@webkit.org>
122
123         Unreviewed "build" fix.  I failed to update LandingSequence.test
124         properly.
125
126         * Scripts/modules/landingsequence.py:
127
128 2009-11-20  Adam Barth  <abarth@webkit.org>
129
130         Reviewed by Eric Seidel.
131
132         Create LandingSequence as the all-sing, all-dance landing class
133         https://bugs.webkit.org/show_bug.cgi?id=31709
134
135         Client can inherit from this class to carefully control exactly which
136         steps they wish to have happen in the landing sequence.
137
138         * Scripts/bugzilla-tool:
139         * Scripts/modules/landingsequence.py: Added.
140         * Scripts/modules/webkitlandingscripts.py: Added.
141
142 2009-11-19  Adam Barth  <abarth@webkit.org>
143
144         Reviewed by Eric Seidel.
145
146         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
147         https://bugs.webkit.org/show_bug.cgi?id=31707
148
149         This is to help when we implement build-attachment.
150
151         * Scripts/bugzilla-tool:
152
153 2009-11-19  Adam Barth  <abarth@webkit.org>
154
155         Reviewed by Eric Seidel.
156
157         Support Qt port in bugzilla-tool
158         https://bugs.webkit.org/show_bug.cgi?id=31701
159
160         Now we support building with Qt!
161
162         * Scripts/bugzilla-tool:
163         * Scripts/modules/webkitport.py: Added.
164         * Scripts/modules/webkitport_unittest.py: Added.
165         * Scripts/run-webkit-unittests:
166
167 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
168
169         Reviewed by Adam Barth.
170
171         Remove inserting stderr into patch in bugzilla-tool
172         https://bugs.webkit.org/show_bug.cgi?id=29914
173
174         Modify SCM python module's run_command function to avoid return of stderr
175         by default, so stderr won't be inserted into the patches.
176         Modify the related unit test.
177
178         * Scripts/modules/scm.py:
179         * Scripts/modules/scm_unittest.py:
180
181 2009-11-19  Eric Seidel  <eric@webkit.org>
182
183         Reviewed by Adam Barth.
184
185         bugzilla-tool needs per-command help
186         https://bugs.webkit.org/show_bug.cgi?id=31697
187
188         Added support for "bugzilla-tool help command-name"
189         and a unit test to make sure it works.
190
191         * Scripts/modules/multicommandtool.py:
192         * Scripts/modules/multicommandtool_unittest.py:
193
194 2009-11-19  Eric Seidel  <eric@webkit.org>
195
196         Reviewed by Adam Barth.
197
198         Move MultiCommandTool and Command into a separate file and add some basic unit tests
199         https://bugs.webkit.org/show_bug.cgi?id=31695
200
201         * Scripts/bugzilla-tool:
202         * Scripts/modules/multicommandtool.py: Added.
203         * Scripts/modules/multicommandtool_unittest.py: Added.
204         * Scripts/run-webkit-unittests:
205
206 2009-11-19  Eric Seidel  <eric@webkit.org>
207
208         No review, just adding a FIXME.
209
210         Split out command parsing and help printing from BugzillaTool
211         https://bugs.webkit.org/show_bug.cgi?id=31688
212
213         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
214
215 2009-11-19  Eric Seidel  <eric@webkit.org>
216
217         Reviewed by Adam Barth.
218
219         Split out command parsing and help printing from BugzillaTool
220         https://bugs.webkit.org/show_bug.cgi?id=31688
221
222         * Scripts/bugzilla-tool:
223          - Add new MultiCommandTool class to contain option parsing and help printing logic.
224          - Rename private methods to use _ pattern.
225          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
226          - 
227
228 2009-11-19  Eric Seidel  <eric@webkit.org>
229
230         Reviewed by Adam Barth.
231
232         Re-factor help printing to use modern python idioms
233         https://bugs.webkit.org/show_bug.cgi?id=31685
234
235         * Scripts/bugzilla-tool:
236
237 2009-11-19  Eric Seidel  <eric@webkit.org>
238
239         Reviewed by Darin Adler.
240
241         commit-queue empty queue logs twice
242         https://bugs.webkit.org/show_bug.cgi?id=31679
243
244         * Scripts/bugzilla-tool:
245
246 2009-11-19  Eric Seidel  <eric@webkit.org>
247
248         Reviewed by Darin Adler.
249
250         bugzilla-tool's reviewer/committer rejection message should be clearer
251         https://bugs.webkit.org/show_bug.cgi?id=31126
252
253         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
254
255         * Scripts/modules/bugzilla.py:
256
257 2009-11-19  Eric Z. Ayers  <zundel@google.com>
258
259         Reviewed by Pavel Feldman.
260
261         Forces a WM_PAINT event on calling layoutTestController.display()
262         in order to enable the timeline-paint.html test on Windows.
263         ::UpdateWindow() does not force an event becaue the window is 
264         not visible.
265
266         https://bugs.webkit.org/show_bug.cgi?id=31402
267
268         * DumpRenderTree/win/DumpRenderTree.cpp:
269         (displayWebView):
270
271 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
272
273         No review needed.
274
275         Added myself to committers list.
276
277         * Scripts/modules/committers.py:
278
279 2009-11-19  Adam Barth  <abarth@webkit.org>
280
281         Reviewed by Eric Seidel.
282
283         Bugzilla-tool command classes should match command names
284         https://bugs.webkit.org/show_bug.cgi?id=31666
285
286         I renamed all the commands except CommitMessageForCurrentDiff because
287         the new name would conflict with an existing class.
288
289         * Scripts/bugzilla-tool:
290
291 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
292
293         Reviewed by Gustavo Noronha Silva.
294
295         Web Inspector: Implement "show inspector" in WebKit GTK
296         API and enable console tests.
297
298         https://bugs.webkit.org/show_bug.cgi?id=31669
299
300         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
301         (LayoutTestController::showWebInspector):
302
303 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
304
305         Reviewed by Simon Hausmann.
306
307         Minor refactoring + more documentation.
308
309         * DumpRenderTree/qt/DumpRenderTree.cpp:
310         (WebCore::clearHistory):
311         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
312
313 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
314
315         Reviewed by Eric Seidel.
316
317         Ignore websocket tests when --no-http is specified.
318         https://bugs.webkit.org/show_bug.cgi?id=31662
319
320         * Scripts/run-webkit-tests:
321
322 2009-11-18  Adam Barth  <abarth@webkit.org>
323
324         Reviewed by Eric Seidel.
325
326         Normalize ' and " in bugzilla-tool
327         https://bugs.webkit.org/show_bug.cgi?id=31655
328
329         We decided " is better than ' and we should be consistent.
330
331         * Scripts/bugzilla-tool:
332
333 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
334
335         Reviewed by Kenneth Rohde Christiansen.
336
337         [Qt] Remove support for Qt v4.3 or older versions
338         https://bugs.webkit.org/show_bug.cgi?id=29469
339
340         * DumpRenderTree/qt/DumpRenderTree.pro:
341         * DumpRenderTree/qt/ImageDiff.pro:
342
343 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
344
345         Reviewed by Eric Seidel.
346
347         GitTest.test_create_binary_patch fails if /tmp is symlink
348         https://bugs.webkit.org/show_bug.cgi?id=31536
349
350         * Scripts/modules/scm_unittest.py:
351
352 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
353
354         Reviewed by Darin Adler.
355
356         Configuration for Chromium Build Slaves.
357
358         https://bugs.webkit.org/show_bug.cgi?id=31442
359
360         * BuildSlaveSupport/build.webkit.org-config/config.json:
361         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
362
363 2009-11-18  Eric Seidel  <eric@webkit.org>
364
365         Reviewed by Darin Adler.
366
367         workqueue.py results in totally broken commit-queue UI
368         https://bugs.webkit.org/show_bug.cgi?id=31645
369
370         * Scripts/bugzilla-tool:
371          - Remove unneeded use of PatchCollection.
372          - Grab a new copy of the cq'd patches every run of the queue.
373
374 2009-11-18  Sam Weinig  <sam@webkit.org>
375
376         Reviewed by Anders Carlsson.
377
378         Make the Mac Geolocation API async.
379
380         Update DRT to use the new async Mac Geolocation API.
381
382         * DumpRenderTree/mac/UIDelegate.mm:
383         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
384
385 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
386
387         Reviewed by Kenneth Rohde Christiansen.
388
389         Add and option to toggle HTML5 datalist support to build-webkit
390         https://bugs.webkit.org/show_bug.cgi?id=31599
391
392         * Scripts/build-webkit:
393
394 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
395
396         Reviewed by Kevin Ollivier.
397
398         Enable wx plugin support using the Windows implementation as a base.
399         
400         https://bugs.webkit.org/show_bug.cgi?id=31636
401
402         * wx/build/settings.py:
403
404 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
405
406         Reviewed by Simon Hausmann.
407
408         Change the initialization order so that the controllers
409         will be created before exporting them to the JS DOM window.
410
411         * DumpRenderTree/qt/DumpRenderTree.cpp:
412         (WebCore::DumpRenderTree::DumpRenderTree):
413
414 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
415
416         Reviewed by Simon Hausmann.
417
418         Fix a code copy and paste error. m_page should be page.
419
420         * DumpRenderTree/qt/DumpRenderTree.cpp:
421         (WebCore::DumpRenderTree::createWindow):
422
423 2009-11-17  Mark Rowe  <mrowe@apple.com>
424
425         Reviewed by Alexey Proskuryakov.
426
427         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
428
429         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
430         This prevents symlinks from confusing the descendant check.
431
432 2009-11-17  Mark Rowe  <mrowe@apple.com>
433
434         Reviewed by Alexey Proskuryakov.
435
436         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
437
438         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
439         server to be up rather than having run-webkit-tests abort immediately.
440
441         * Scripts/run-webkit-tests:
442
443 2009-11-17  Eric Seidel  <eric@webkit.org>
444
445         Reviewed by Darin Adler.
446
447         commit-queue is failing to set reviewer in ChangeLogs
448         https://bugs.webkit.org/show_bug.cgi?id=31592
449
450         * Scripts/bugzilla-tool: Clarify the "applying" log message.
451         * Scripts/modules/bugzilla.py:
452          - Add a new _validate_committer_and_reviewer function as a
453            temporary solution until we can make a real Attachment object
454            which knows how to fill in its committer/reviewer fields automatically.
455
456 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
457
458         Unreviewed buildbot fix.
459
460         Revert part of earlier patch and add comment, as it
461         was causing timeouts on the buildbot.
462
463         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
464         (LayoutTestController::notifyDone):
465
466 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
467
468         Reviewed by Oliver Hunt.
469
470         Make the timeout 15 sec as for the other DRT's and make
471         it print out the same output when a test timeout.
472
473         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
474         (LayoutTestController::waitUntilDone):
475         (LayoutTestController::notifyDone):
476         (LayoutTestController::timerEvent):
477
478 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
479
480         Reviewed by Timothy Hatcher.
481
482         Fixed typos in comments.
483
484         * Scripts/modules/committers.py:
485
486 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
487
488         Reviewed by Timothy Hatcher.
489
490         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
491         - Updated DRT to show/close inspector for all tests under /inspector
492         - Introduced LayoutTestController::setTimelineProfilingEnabled and
493           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
494         - Removed reload on each inspector test
495         - Renamed fast/inspector to fast/inspector-support in order not to trigger
496         inspector for those.
497         - Reimplemented timeline tests in order to get rid of reload there.
498         - Moved tests that don't require harness into the fast group.
499
500         https://bugs.webkit.org/show_bug.cgi?id=31472
501
502         * DumpRenderTree/LayoutTestController.cpp:
503         (setTimelineProfilingEnabledCallback):
504         (closeWebInspectorCallback):
505         (LayoutTestController::staticFunctions):
506         * DumpRenderTree/LayoutTestController.h:
507         * DumpRenderTree/gtk/DumpRenderTree.cpp:
508         (shouldOpenWebInspector):
509         (runTest):
510         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
511         (LayoutTestController::setTimelineProfilingEnabled):
512         * DumpRenderTree/mac/DumpRenderTree.mm:
513         (shouldOpenWebInspector):
514         (runTest):
515         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
516         (LayoutTestController::setTimelineProfilingEnabled):
517         * DumpRenderTree/win/DumpRenderTree.cpp:
518         (shouldOpenWebInspector):
519         (runTest):
520         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
521         (LayoutTestController::setTimelineProfilingEnabled):
522
523 2009-11-17  Oliver Hunt  <oliver@apple.com>
524
525         Reviewed by Maciej Stachowiak.
526
527         Incorrect use of JavaScriptCore API in DumpRenderTree
528         https://bugs.webkit.org/show_bug.cgi?id=31577
529
530         Return undefined rather than a literal null.
531
532         * DumpRenderTree/AccessibilityUIElement.cpp:
533         (setSelectedTextRangeCallback):
534         (incrementCallback):
535         (decrementCallback):
536         (showMenuCallback):
537
538 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
539
540         Reviewed by Beth Dakin.
541
542         AX: aria-labelledby duplicates some of its WAI-ARIA label
543         https://bugs.webkit.org/show_bug.cgi?id=31565
544
545         * DumpRenderTree/AccessibilityUIElement.cpp:
546         (titleUIElementCallback):
547         (getIsValidCallback):
548         (AccessibilityUIElement::getJSClass):
549
550 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
551
552         Reviewed by Simon Hausmann.
553
554         r50942 broke output from created windows. Make the
555         m_enableTextOutput a member of the DRT and not the
556         WebPage.
557
558         * DumpRenderTree/qt/DumpRenderTree.cpp:
559         (WebCore::WebPage::WebPage):
560         (WebCore::WebPage::javaScriptAlert):
561         (WebCore::WebPage::javaScriptConsoleMessage):
562         (WebCore::WebPage::javaScriptConfirm):
563         (WebCore::WebPage::javaScriptPrompt):
564         (WebCore::WebPage::acceptNavigationRequest):
565         (WebCore::DumpRenderTree::DumpRenderTree):
566         (WebCore::DumpRenderTree::open):
567         (WebCore::DumpRenderTree::createWindow):
568         * DumpRenderTree/qt/DumpRenderTree.h:
569         (WebCore::DumpRenderTree::setTextOutputEnabled):
570         (WebCore::DumpRenderTree::isTextOutputEnabled):
571         (WebCore::WebPage::shouldInterruptJavaScript):
572         (WebCore::WebPage::isTextOutputEnabled):
573         (WebCore::WebPage::setViewGeometry):
574
575 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
576
577         Reviewed by Gustavo Noronha Silva.
578
579         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
580         as the implementation is being used by at least Qt and Gtk+.
581
582         Update buildsystems as well.
583
584         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
585         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
586         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
587         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
588         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
589         * GNUmakefile.am:
590
591 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
592
593         Reviewed by Alexey Proskuryakov.
594
595         Disable wss until all platforms support pyOpenSSL
596
597         https://bugs.webkit.org/show_bug.cgi?id=31479
598
599         * Scripts/run-webkit-tests:
600
601 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
602
603         Reviewed by Kenneth Christiansen.
604
605         [Qt] Implement load error pages support for Qt's DRT.
606         https://bugs.webkit.org/show_bug.cgi?id=31509
607
608         For now, it will not be a default feature, and layout tests
609         that want to make use of this have to explicitily call
610         'handleErrorPages();' for the test source.
611
612         Any of the other DumpRenderTree's (mac, win and gtk)
613         support handling error pages. Qt's will be the first.
614
615         * DumpRenderTree/qt/DumpRenderTree.cpp:
616         (WebCore::WebPage::supportsExtension):
617         (WebCore::WebPage::extension):
618         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
619         (LayoutTestController::reset):
620         * DumpRenderTree/qt/LayoutTestControllerQt.h:
621         (LayoutTestController::shouldHandleErrorPages):
622         (LayoutTestController::handleErrorPages):
623
624 2009-11-16  Eric Seidel  <eric@webkit.org>
625
626         Reviewed by Adam Barth.
627
628         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
629         https://bugs.webkit.org/show_bug.cgi?id=31549
630
631         Renamed --commit-queue to --non-interactive in most places
632         and remove the code in land-patches which is no longer needed.
633
634         * Scripts/bugzilla-tool:
635
636 2009-11-16  Eric Seidel  <eric@webkit.org>
637
638         Reviewed by Adam Barth.
639
640         The commit-queue should use land-attachment
641         https://bugs.webkit.org/show_bug.cgi?id=31548
642
643         * Scripts/bugzilla-tool:
644
645 2009-11-16  Adam Barth  <abarth@webkit.org>
646
647         Reviewed by Eric Seidel.
648
649         Convert CommitQueue over to PatchCollection
650         https://bugs.webkit.org/show_bug.cgi?id=31547
651
652         Also fixes a bug in workqueue and adds a test!
653
654         * Scripts/bugzilla-tool:
655         * Scripts/modules/workqueue.py:
656         * Scripts/modules/workqueue_unittest.py:
657
658 2009-11-16  Adam Barth  <abarth@webkit.org>
659
660         Reviewed by Eric Seidel.
661
662         Move StyleQueue over to using PatchCollection
663         https://bugs.webkit.org/show_bug.cgi?id=31544
664
665         That's what the class it's for.
666
667         * Scripts/bugzilla-tool:
668         * Scripts/modules/patchcollection.py:
669         * Scripts/modules/patchcollection_unittest.py:
670
671 2009-11-16  Eric Seidel  <eric@webkit.org>
672
673         Reviewed by Adam Barth.
674
675         bugzilla-tool needs a land-attachment command
676         https://bugs.webkit.org/show_bug.cgi?id=31546
677
678         * Scripts/bugzilla-tool:
679          - Move all the logic into AbstractLandingCommand and
680            add a new LandAttachment command subclass.
681          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
682
683 2009-11-16  Eric Seidel  <eric@webkit.org>
684
685         Reviewed by Adam Barth.
686
687         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
688         https://bugs.webkit.org/show_bug.cgi?id=31543
689
690         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
691
692         * Scripts/bugzilla-tool:
693
694 2009-11-16  Eric Seidel  <eric@webkit.org>
695
696         Reviewed by Adam Barth.
697
698         Disable the style queue from posting to the commit queue status page.
699
700         * Scripts/bugzilla-tool:
701
702 2009-11-16  Adam Barth  <abarth@webkit.org>
703
704         Reviewed by Eric Seidel.
705
706         Implement PatchCollection
707         https://bugs.webkit.org/show_bug.cgi?id=31541
708
709         This class holds a set of patches and lets clients iterate through
710         them.  Optionally, clients can install a filter.
711
712         * Scripts/modules/patchcollection.py: Added.
713         * Scripts/modules/patchcollection_unittest.py: Added.
714         * Scripts/run-webkit-unittests:
715
716 2009-11-16  Eric Seidel  <eric@webkit.org>
717
718         Reviewed by Adam Barth.
719
720         bugzilla-tool land-patches will close bugs with patches r=?
721         https://bugs.webkit.org/show_bug.cgi?id=28230
722
723         The commit-queue shouldn't close patches with outstanding reviews on them,
724         even if many reviewers seem to be against multi-patch bugs.
725
726         * Scripts/bugzilla-tool:
727
728 2009-11-16  Eric Seidel  <eric@webkit.org>
729
730         Reviewed by Adam Barth.
731
732         bugzilla-tool check-style should work with attachment ids instead of bug ids
733         https://bugs.webkit.org/show_bug.cgi?id=31540
734
735         * Scripts/bugzilla-tool:
736
737 2009-11-16  Eric Seidel  <eric@webkit.org>
738
739         Reviewed by Adam Barth.
740
741         WorkQueue is the only place that should know about special exit codes
742         https://bugs.webkit.org/show_bug.cgi?id=31534
743
744         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
745         and add tests for handling exit codes.
746         I also cleaned up workqueue_unittest.py more.
747
748         * Scripts/bugzilla-tool:
749         * Scripts/modules/workqueue.py:
750         * Scripts/modules/workqueue_unittest.py:
751
752 2009-11-16  Eric Seidel  <eric@webkit.org>
753
754         Reviewed by Adam Barth.
755
756         Re-factor workqueue_unittest to allow for more than one test.
757         https://bugs.webkit.org/show_bug.cgi?id=31535
758
759         * Scripts/modules/workqueue_unittest.py:
760
761 2009-11-16  Eric Seidel  <eric@webkit.org>
762
763         Reviewed by Adam Barth.
764
765         land-patches needs to be re-factored into smaller chunks
766         https://bugs.webkit.org/show_bug.cgi?id=31532
767
768         * Scripts/bugzilla-tool: fix a couple obvious typos.
769
770 2009-11-16  Eric Seidel  <eric@webkit.org>
771
772         Reviewed by Adam Barth.
773
774         land-patches needs to be re-factored into smaller chunks
775         https://bugs.webkit.org/show_bug.cgi?id=31532
776
777         The next patch will move these methods into WebKitLandingScripts.
778
779         * Scripts/bugzilla-tool:
780          - Split out _land_patch and _close_bug_if_no_active_patches.
781
782 2009-11-16  Adam Barth  <abarth@webkit.org>
783
784         Reviewed by Eric Seidel.
785
786         Fix silly copy-and-paste code.  I am a terrible coder.
787
788         * Scripts/modules/bugzilla.py:
789
790 2009-11-16  Adam Barth  <abarth@webkit.org>
791
792         Reviewed by Eric Seidel.
793
794         Implement a StyleQueue
795         https://bugs.webkit.org/show_bug.cgi?id=31537
796
797         The first iteration of the style queue only produces output locally.
798         There is also a limit of 10 patches because it's not that useful to
799         iterate through the entire review queue at this point.  We can remove
800         the limit later.
801
802         * Scripts/bugzilla-tool:
803         * Scripts/modules/bugzilla.py:
804
805 2009-11-16  Adam Barth  <abarth@webkit.org>
806
807         Reviewed by Eric Seidel.
808
809         Unit test WorkQueue
810         https://bugs.webkit.org/show_bug.cgi?id=31531
811
812         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
813
814         * Scripts/bugzilla-tool:
815         * Scripts/modules/statusbot.py:
816         * Scripts/modules/workqueue.py:
817         * Scripts/modules/workqueue_unittest.py: Added.
818         * Scripts/run-webkit-unittests:
819
820 2009-11-16  Eric Seidel  <eric@webkit.org>
821
822         Reviewed by Adam Barth.
823
824         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
825         https://bugs.webkit.org/show_bug.cgi?id=31530
826
827         * Scripts/bugzilla-tool:
828
829 2009-11-16  Eric Seidel  <eric@webkit.org>
830
831         Reviewed by Adam Barth.
832
833         bugzilla-tool needs apply-attachment
834         https://bugs.webkit.org/show_bug.cgi?id=31528
835
836         * Scripts/bugzilla-tool:
837          - Add ApplyAttachment command.
838          - Abstract applying code into WebKitApplyingScripts.
839          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
840         * Scripts/modules/bugzilla.py:
841          - Add fetch_attachment and bug_id_for_attachment_id.
842         * Scripts/modules/bugzilla_unittest.py:
843          - Add test for new parsing.
844          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
845
846 2009-11-16  Eric Seidel  <eric@webkit.org>
847
848         Reviewed by Adam Barth.
849
850         Document check-style's use of force_clean.
851
852         * Scripts/bugzilla-tool:
853         * Scripts/modules/scm.py:
854
855 2009-11-16  Adam Barth  <abarth@webkit.org>
856
857         Reviewed by Eric Seidel.
858
859         Move WorkQueue to its own file
860         https://bugs.webkit.org/show_bug.cgi?id=31529
861
862         WorkQueue and WorkQueueDelegate are separate concerns from
863         bugzilla-tool.  Also added a missing include to logging.py.
864
865         * Scripts/bugzilla-tool:
866         * Scripts/modules/logging.py:
867         * Scripts/modules/workqueue.py:
868
869 2009-11-16  Adam Barth  <abarth@webkit.org>
870
871         Reviewed by Eric Seidel.
872
873         Move OutputTee to logging.py.
874
875         * Scripts/bugzilla-tool:
876         * Scripts/modules/logging.py:
877
878 2009-11-15  Adam Barth  <abarth@webkit.org>
879
880         Reviewed by Eric Seidel.
881
882         Refactor bugzilla-tool to allow for multiple queues
883         https://bugs.webkit.org/show_bug.cgi?id=31513
884
885         Divide the commit queue class into three class to make creating
886         additional queues easier.
887
888         * Scripts/bugzilla-tool:
889
890 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
891
892         Reviewed by Eric Seidel.
893
894         svn-apply may not handle git patches created by bugzilla-tool
895         https://bugs.webkit.org/show_bug.cgi?id=31457
896
897         * Scripts/modules/scm.py:
898         * Scripts/modules/scm_unittest.py:
899
900 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
901
902         Reviewed by Eric Seidel.
903
904         bugzilla-tool should post git binary diff
905         https://bugs.webkit.org/show_bug.cgi?id=31458
906
907         Add --binary option to Git.create_patch.
908
909         * Scripts/modules/scm.py:
910         * Scripts/modules/scm_unittest.py:
911
912 2009-11-15  Adam Barth  <abarth@webkit.org>
913
914         Reviewed by Darin Adler.
915
916         Add bugzilla-tool check-style
917         https://bugs.webkit.org/show_bug.cgi?id=31515
918
919         * Scripts/bugzilla-tool:
920         * Scripts/modules/bugzilla.py:
921
922 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
923
924         Reviewed by Simon Hausmann.
925
926         Make the Qt Linux only --valgrind feature, suppress errors
927         defined in the SuppressedValgrindErrors file.
928
929         * Scripts/run-webkit-tests:
930
931 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
932
933         Reviewed by Simon Hausmann.
934
935         Set the locale to C and not to the current one in use on the system.
936
937         * DumpRenderTree/qt/DumpRenderTree.cpp:
938         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
939
940 2009-11-13  Adam Roben  <aroben@apple.com>
941
942         Add support for
943         http/tests/security/isolatedWorld/didClearWindowObject.html
944
945         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
946         window objects in isolated worlds are cleared
947
948         Reviewed by Dave Hyatt.
949
950         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
951
952         * DumpRenderTree/mac/FrameLoadDelegate.mm:
953         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
954         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
955         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
956         Added. Sets a __worldID property on the global object whose value is
957         the ID of this world.
958         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
959         Respond to this new delegate callback by calling through to one of the
960         above new methods.
961         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
962         (worldMap): Added. Returns a HashMap containing all the worlds we've
963         created.
964         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
965         haven't kept track of this world.
966         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
967         instead of declaring our own.
968
969         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
970
971         * DumpRenderTree/win/FrameLoadDelegate.cpp:
972         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
973         didClearWindowObjectForFrameInStandardWorld.
974         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
975         Respond to this new delegate callback by calling through to one of the
976         below new methods.
977         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
978         Added. Sets a __worldID property on the gobal object whose value is
979         the ID of this world.
980         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
981         Added. Moved code here from didClearWindowObject.
982
983         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
984         didClearWindowObjectForFrame* functions.
985
986         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
987         (worldMap): Added. Returns a HashMap containing all the worlds we've
988         created.
989         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
990         haven't kept track of this world.
991         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
992         instead of declaring our own.
993
994 2009-11-13  Adam Roben  <aroben@apple.com>
995
996         Finish replacing worldIDs with world objects
997
998         The only remaining use of worldIDs was in a method only used by DRT
999         for the isolated worlds tests.
1000
1001         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1002
1003         Reviewed by Mark Rowe.
1004
1005         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1006         (LayoutTestController::evaluateScriptInIsolatedWorld):
1007         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1008         (LayoutTestController::evaluateScriptInIsolatedWorld):
1009         Updated for changes to WebFrame. Now holds the map of worldID -> world
1010         at this level instead of making WebKit do it.
1011
1012 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1013
1014         Reviewed by Simon Hausmann.
1015
1016         [Qt] Ensure the DRT does not output anything until first test is run
1017
1018         * DumpRenderTree/qt/DumpRenderTree.cpp:
1019         * DumpRenderTree/qt/DumpRenderTree.h:
1020
1021 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1022
1023         Reviewed by Tor Arne Vestbø.
1024
1025         Clear the undo stack in before each new test run.
1026
1027         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1028
1029         * DumpRenderTree/qt/DumpRenderTree.cpp:
1030         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1031
1032 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1033
1034         Reviewed by Kenneth Rohde Christiansen.
1035
1036         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1037
1038         * DumpRenderTree/qt/DumpRenderTree.cpp:
1039         (WebCore::WebPage::resetSettings):
1040         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1041         (LayoutTestController::overridePreference):
1042
1043 2009-11-13  Eric Seidel  <eric@webkit.org>
1044
1045         Reviewed by Adam Barth.
1046
1047         Update committers.py based on svn records
1048         https://bugs.webkit.org/show_bug.cgi?id=31366
1049
1050         This list was generated using validate-committer-lists from
1051         https://bugs.webkit.org/show_bug.cgi?id=30970
1052         and makes committers.py current for committers who have
1053         committed in the last 3 years.
1054
1055         * Scripts/modules/committers.py:
1056
1057 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1058
1059         Reviewed by Adam Barth.
1060
1061         The document-open.html test was flaky at times. The test invokes the layout test plugin
1062         which in its destroy stream handler opens a new document. This basically tears down the
1063         stream and the associated plugin instance. The pluginLog function in the layout test
1064         plugin attempts to retrieve the window script object on a torn down plugin instance
1065         which crashed consistently on windows in the debugger. The functions which issue
1066         these logs already have a valid window script object. We now have variants of the pluginLog
1067         function which take in a window script object with and without variable arguments. 
1068
1069         https://bugs.webkit.org/show_bug.cgi?id=31067
1070
1071         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1072         (pluginLogWithWindowObject):
1073         (pluginLogWithWindowObjectVariableArgs):
1074         (pluginLog):
1075         (notifyTestCompletion):
1076         (testDocumentOpen):
1077         (testWindowOpen):
1078
1079 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1080
1081         Reviewed by Gustavo Noronha Silva.
1082
1083         https://bugs.webkit.org/show_bug.cgi?id=30997
1084         [Gtk] Implemment AtkDocument
1085
1086         Added testing support.
1087
1088         * DumpRenderTree/AccessibilityUIElement.cpp:
1089         * DumpRenderTree/AccessibilityUIElement.h:
1090         (getDocumentEncodingCallback):
1091         (getDocumentURICallback):
1092         (AccessibilityUIElement::getJSClass):
1093         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1094         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1095         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1096         (AccessibilityUIElement::documentEncoding):
1097         (AccessibilityUIElement::documentURI):
1098
1099 2009-11-12  Adam Roben  <aroben@apple.com>
1100
1101         Replace worldIDs with world objects
1102
1103         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1104         user scripts/stylesheets and isolated worlds
1105
1106         Reviewed by Sam Weinig.
1107
1108         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1109         (LayoutTestController::addUserScript):
1110         (LayoutTestController::addUserStyleSheet):
1111         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1112         (LayoutTestController::addUserScript):
1113         (LayoutTestController::addUserStyleSheet):
1114         Changed these functions to create a new WebJSWorld each time they're
1115         called and to pass that world to WebKit.
1116
1117 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1118
1119         Reviewed by Oliver Hunt.
1120
1121         need to implement aria tree roles
1122         https://bugs.webkit.org/show_bug.cgi?id=31284
1123
1124         * DumpRenderTree/AccessibilityUIElement.cpp:
1125         (disclosedRowAtIndexCallback):
1126         (selectedRowAtIndexCallback):
1127         (isEqualCallback):
1128         (isAttributeSettableCallback):
1129         (isActionSupportedCallback):
1130         (disclosedByRowCallback):
1131         (hierarchicalLevelCallback):
1132         (AccessibilityUIElement::getJSClass):
1133         * DumpRenderTree/AccessibilityUIElement.h:
1134         (AccessibilityUIElement::isEqual):
1135         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1136         (AccessibilityUIElement::hierarchicalLevel):
1137         (AccessibilityUIElement::disclosedRowAtIndex):
1138         (AccessibilityUIElement::selectedRowAtIndex):
1139         (AccessibilityUIElement::disclosedByRow):
1140         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1141         (AccessibilityUIElement::getChildAtIndex):
1142         (AccessibilityUIElement::disclosedRowAtIndex):
1143         (AccessibilityUIElement::selectedRowAtIndex):
1144         (AccessibilityUIElement::titleUIElement):
1145         (AccessibilityUIElement::parentElement):
1146         (AccessibilityUIElement::disclosedByRow):
1147         (AccessibilityUIElement::hierarchicalLevel):
1148         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1149         (AccessibilityUIElement::hierarchicalLevel):
1150         (AccessibilityUIElement::disclosedRowAtIndex):
1151         (AccessibilityUIElement::selectedRowAtIndex):
1152         (AccessibilityUIElement::disclosedByRow):
1153
1154 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1155
1156         Reviewed by Darin Adler.
1157
1158         svn-apply can not handle git binary diffs
1159         https://bugs.webkit.org/show_bug.cgi?id=26830
1160
1161         Support "literal" type git binary diffs.
1162
1163         * Scripts/VCSUtils.pm:
1164         * Scripts/modules/scm_unittest.py:
1165         * Scripts/svn-apply:
1166
1167 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1168
1169         Not reviewed, removing duplicate entry for myself in committers.py.
1170
1171         * Scripts/modules/committers.py:
1172
1173 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1174
1175         Reviewed by Darin Adler and Mark Rowe.
1176
1177         https://bugs.webkit.org/show_bug.cgi?id=31200
1178         Tests in http/tests/security/mixedContent start to fail when new tests are added
1179
1180         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1181
1182 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1183
1184         Reviewed by Jan Alonzo.
1185
1186         Create, and display a window for the inspector, for inspector
1187         tests.
1188
1189         Need to also show/hide the inspector window to avoid having
1190         problems with code assuming it is realized
1191         https://bugs.webkit.org/show_bug.cgi?id=31347
1192
1193         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1194         (webInspectorShowWindow):
1195         (webInspectorCloseWindow):
1196         (webInspectorInspectWebView):
1197         (createWebView):
1198
1199 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1200
1201         Unreviewed Qt buildbot fix.
1202
1203         My previous fix was wrong, so revert that change and fix it by
1204         returning when the document of the frame has no document element.
1205         Idea is borrowed from mac and win DRT.
1206
1207         * DumpRenderTree/qt/DumpRenderTree.cpp:
1208         (WebCore::DumpRenderTree::dumpFramesAsText):
1209
1210 2009-11-11  Eric Seidel  <eric@webkit.org>
1211
1212         Reviewed byg Kenneth Rohde Christiansen.
1213
1214         Update Kenneth's committer record to include the email he
1215         uses on lists.webkit.org.
1216
1217         * Scripts/modules/committers.py:
1218
1219 2009-11-11  Eric Seidel  <eric@webkit.org>
1220
1221         Reviewed by Gustavo Noronha Silva.
1222
1223         Several committers use separate email addresses for bugzilla and svn.webkit.org
1224         https://bugs.webkit.org/show_bug.cgi?id=31364
1225
1226         Update records for existing committers to include email addresses
1227         used in svn.webkit.org and lists.webkit.org.
1228         Most committers use the same email address in all 3 places, but some use
1229         separate addresses.  committers.py needs record of each of these addresses.
1230
1231         * Scripts/modules/committers.py:
1232
1233 2009-11-11  Eric Seidel  <eric@webkit.org>
1234
1235         No review, adding second email address for an existing committer.
1236
1237         Add Yong Li's second bugzilla account to his committer record.
1238         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1239
1240         * Scripts/modules/committers.py:
1241
1242 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1243
1244         Reviewed by Simon Hausmann.
1245
1246         If the frame has no innerText don't append it, and
1247         do not add a newline which breaks some cross platform
1248         results.
1249
1250         * DumpRenderTree/qt/DumpRenderTree.cpp:
1251         (WebCore::DumpRenderTree::dumpFramesAsText):
1252
1253 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1254
1255         Reviewed by Simon Hausmann.
1256
1257         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1258
1259         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1260         (webkit_test_plugin_new_instance):
1261         (webkit_test_plugin_destroy_instance):
1262         (webkit_test_plugin_destroy_stream):
1263
1264 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1265
1266         Reviewed by Mark Rowe.
1267
1268         Implement the functionality needed by plugins/window-open.html
1269
1270         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1271         (webkit_test_plugin_new_instance):
1272         (webkit_test_plugin_set_window):
1273
1274 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1275
1276         Reviewed by Simon Hausmann.
1277
1278         [Qt] Force -graphicssystem raster and -style windows when running DRT
1279
1280         * DumpRenderTree/qt/main.cpp:
1281         * Scripts/run-webkit-tests:
1282
1283 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1284
1285         Reviewed by Simon Hausmann.
1286
1287         Compute correct library paths for Qt
1288
1289         * Scripts/webkitdirs.pm:
1290
1291 2009-11-10  Mark Rowe  <mrowe@apple.com>
1292
1293         Reviewed by Sam Weinig.
1294
1295         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1296
1297         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1298         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1299         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1300         that had enabled frame load delegate logging this would result in extra log messages being generated,
1301         causing the test to fail.
1302
1303         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1304         tests.
1305
1306         * DumpRenderTree/mac/DumpRenderTree.mm:
1307         (dumpRenderTree):
1308         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1309         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1310
1311 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1312
1313         Reviewed by Kenneth Rohde Christiansen.
1314
1315         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1316
1317         * DumpRenderTree/qt/DumpRenderTree.cpp:
1318         (WebCore::DumpRenderTree::DumpRenderTree):
1319
1320 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1321
1322         Reviewed by Jan Alonzo.
1323
1324         [GTK] Remove WebSocket configuration from WebKitWebSettings
1325         https://bugs.webkit.org/show_bug.cgi?id=31244
1326
1327         Follow-up of r50724. Don't set the enable-web-socket property
1328         anymore.
1329
1330         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1331         (resetDefaultsToConsistentValues):
1332
1333 2009-11-10  Oliver Hunt  <oliver@apple.com>
1334
1335         Reviewed by Maciej Stachowiak.
1336
1337         Rename 3D Canvas related classes to use WebGL prefix
1338         https://bugs.webkit.org/show_bug.cgi?id=29095
1339
1340         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1341         and upate webkitdirs script to new method of testing for WebGL.
1342
1343         * Scripts/do-webcore-rename:
1344         * Scripts/webkitdirs.pm:
1345
1346 2009-11-09  Oliver Hunt  <oliver@apple.com>
1347
1348         Reviewed by Geoff Garen.
1349
1350         Make do-webcore-rename work with git.
1351
1352         * Scripts/do-webcore-rename:
1353
1354 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1355
1356         Adding Kenneth to the reviewers list.
1357
1358         * Scripts/modules/committers.py:
1359
1360 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1361
1362         Reviewed by Jan Alonzo.
1363
1364         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1365         https://bugs.webkit.org/show_bug.cgi?id=30482
1366
1367         LayoutTestControllerGtk now uses the exposed
1368         Page::tabKeyCyclesThroughElements API
1369
1370         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1371         (LayoutTestController::setTabKeyCyclesThroughElements):
1372
1373 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1374
1375         Reviewed by Holger Freyther.
1376
1377         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1378         This helps to pass the test case below. Also replaced hardcoded
1379         code numbers with defined constants.
1380         https://bugs.webkit.org/show_bug.cgi?id=31185
1381         
1382         Test: editing/undo/undo-deleteWord.html
1383
1384         * DumpRenderTree/qt/EventSenderQt.cpp:
1385         (EventSender::keyDown):
1386
1387 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1388
1389         Reviewed by Holger Freyther.
1390
1391         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1392         https://bugs.webkit.org/show_bug.cgi?id=31164
1393
1394         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1395
1396         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1397         (LayoutTestController::processWork):
1398
1399 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1400
1401         Reviewed by Holger Freyther.
1402
1403         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1404         https://bugs.webkit.org/show_bug.cgi?id=31158
1405
1406         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1407         always, which from WorkQueue prospective means that a load has been started
1408         and the queue processing should stop and wait for the load to finish.
1409         Spinning it off into a loading and a non-loading variants was the solution
1410         adopted by Mac's DRT to work around this problem. The former keeps returning
1411         'true' while the later executes the script synchronously and returns 'false'
1412         making it possible to the WorkQueue to proceed right away.
1413
1414         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1415         (LayoutTestController::processWork):
1416         (LayoutTestController::queueLoadingScript):
1417         (LayoutTestController::queueNonLoadingScript):
1418         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1419         * DumpRenderTree/qt/WorkQueueItem.h:
1420         (LoadingScriptItem::LoadingScriptItem):
1421         (LoadingScriptItem::invoke):
1422         (NonLoadingScriptItem::NonLoadingScriptItem):
1423         (NonLoadingScriptItem::invoke):
1424
1425 2009-11-07  Mark Rowe  <mrowe@apple.com>
1426
1427         Rubber-stamped by Cameron Zwarich.
1428
1429         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1430
1431         * Scripts/commit-log-editor:
1432
1433 2009-11-07  Mark Rowe  <mrowe@apple.com>
1434
1435         Reviewed by Darin Adler.
1436
1437         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1438         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1439
1440         Move logic for determining the name and email address to use in a ChangeLog entry from
1441         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1442         whether the author of the patch matches committer, and therefore needs access to the
1443         email address that would be used in a ChangeLog entry.
1444
1445         Based on a patch by Pierre d'Herbemont.
1446
1447         * Scripts/VCSUtils.pm:
1448         * Scripts/commit-log-editor:
1449         * Scripts/prepare-ChangeLog:
1450         * Scripts/webkitdirs.pm:
1451
1452 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1453
1454         Reviewed by Adam Barth.
1455
1456         Added functionality to the layout test plugin to invoke document.open and
1457         window.open with default arguments. The associated webkit bug is
1458         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1459         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1460         work in Chromium (V8) if there is no calling javascript context. To achieve this
1461         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1462         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1463
1464         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1465         (testDocumentOpen):
1466         (testWindowOpen):
1467         (pluginAllocate):
1468         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1469         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1470         (NPP_New):
1471         (NPP_SetWindow):
1472         (NPP_DestroyStream):
1473         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1474         (NPP_New):
1475         (NPP_SetWindow):
1476         (NPP_NewStream):
1477         (NPP_DestroyStream):
1478
1479 2009-11-06  Eric Seidel  <eric@webkit.org>
1480
1481         Reviewed by Adam Barth.
1482
1483         bugzilla-tool crashed with exception
1484         https://bugs.webkit.org/show_bug.cgi?id=31092
1485
1486         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1487
1488 2009-11-04  Eric Seidel  <eric@webkit.org>
1489
1490         No review, just add a line which got left out of the patch uploaded for commit.
1491
1492         commit-queue is crashing when trying to reject patches after unknown failures
1493         https://bugs.webkit.org/show_bug.cgi?id=31091
1494
1495         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1496
1497 2009-11-04  Adam Roben  <aroben@apple.com>
1498
1499         Remove bogus else clause in bugzilla-tool
1500
1501         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1502         create-bug raises exception after entering bug description
1503
1504         Reviewed by David Kilzer.
1505
1506         * Scripts/bugzilla-tool:
1507         (CreateBug): else clauses are only hit if no exception is raised, so
1508         it makes no sense to try to re-raise the exception in an else clause.
1509         The exception will automatically be re-raised if it doesn't match any
1510         of the except clauses, so we don't have to do anything special here at
1511         all to get the desired behavior.
1512
1513 2009-11-04  Eric Seidel  <eric@webkit.org>
1514
1515         Reviewed by David Kilzer.
1516
1517         svn-apply's fixChangeLogPatch function seems broken
1518         https://bugs.webkit.org/show_bug.cgi?id=30683
1519
1520         Update fixChangeLogPatch to be able to handle patches which
1521         don't start at line 1.
1522         Add unit tests for svn-apply to scm_unittest.py.
1523
1524         * Scripts/VCSUtils.pm:
1525         * Scripts/modules/scm_unittest.py:
1526
1527 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1528
1529         Reviewed by Beth Dakin.
1530
1531         Need to implement ARIA role="combobox"
1532         https://bugs.webkit.org/show_bug.cgi?id=31096
1533
1534         * DumpRenderTree/AccessibilityUIElement.cpp:
1535         (showMenuCallback):
1536         (getIsExpandedCallback):
1537         (AccessibilityUIElement::getJSClass):
1538         * DumpRenderTree/AccessibilityUIElement.h:
1539         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1540         (AccessibilityUIElement::isExpanded):
1541         (AccessibilityUIElement::showMenu):
1542         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1543         (AccessibilityUIElement::isExpanded):
1544         (AccessibilityUIElement::showMenu):
1545         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1546         (AccessibilityUIElement::isSelected):
1547         (AccessibilityUIElement::isExpanded):
1548         (AccessibilityUIElement::showMenu):
1549
1550 2009-11-04  Eric Seidel  <eric@webkit.org>
1551
1552         Reviewed by Adam Barth.
1553
1554         commit-queue is crashing when trying to reject patches after unknown failures
1555         https://bugs.webkit.org/show_bug.cgi?id=31091
1556
1557         * Scripts/bugzilla-tool:
1558          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1559            so we have to find out what the current patch is by asking bugzilla again.
1560          - Discovered that this code was also leaking file descriptors, so fixed that.
1561
1562 2009-11-04  Adam Roben  <aroben@apple.com>
1563
1564         Make run-webkit-tests work for the Debug_Internal Windows
1565         configuration
1566
1567         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1568         suffix.
1569
1570         Fixes <http://webkit.org/b/31123>.
1571
1572         Reviewed by Sam Weinig.
1573
1574         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1575         Debug_Internal, either.
1576
1577 2009-11-04  Eric Seidel  <eric@webkit.org>
1578
1579         Reviewed by Adam Barth.
1580
1581         committers.py needs a way to store non-bugzilla email addresses
1582         https://bugs.webkit.org/show_bug.cgi?id=31037
1583
1584         Make Committer and Reviewer constructors take a single email or a list of emails.
1585         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1586         Expose reviewers(), used by validate-committer-lists on bug 30970.
1587
1588         * Scripts/modules/committers.py:
1589         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1590
1591 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1592
1593         Reviewed by David Levin.
1594
1595         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1596         https://bugs.webkit.org/show_bug.cgi?id=27491
1597
1598         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1599         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1600
1601         Functions to start or stop Web Socket servers are added.
1602
1603         * Scripts/run-webkit-tests:
1604
1605 2009-11-03  Eric Seidel  <eric@webkit.org>
1606
1607         No review, just changing wording of log message.
1608
1609         Change log string to say "failed" instead of "rejected"
1610         when a commit fails due to an out of date checkout.
1611         This makes grepping the commit-queue log for rejected patches easier.
1612
1613         * Scripts/bugzilla-tool:
1614
1615 2009-11-03  Eric Seidel  <eric@webkit.org>
1616
1617         No review, adding commonly known committers missing from the file.
1618
1619         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1620
1621 2009-11-03  Eric Seidel  <eric@webkit.org>
1622
1623         No review, just sort-order cleanup.
1624
1625         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1626
1627 2009-11-03  Stephen White  <senorblanco@chromium.org>
1628
1629         (Unreviewed).
1630
1631         Add myself to committers.py.
1632
1633         * Scripts/modules/committers.py:
1634
1635 2009-11-03  Robin Dunn  <robin@alldunn.com>
1636
1637         Reviewed by Kevin Ollviier.
1638
1639         Add packaging scripts for Debian-based Linux distros.
1640         
1641         https://bugs.webkit.org/show_bug.cgi?id=31075
1642
1643         * wx/packaging/build-debian-installer.py: Added.
1644         * wx/packaging/debian: Added.
1645
1646 2009-11-03  Dan Bernstein  <mitz@apple.com>
1647
1648         Reviewed by Anders Carlsson and Beth Dakin.
1649
1650         https://bugs.webkit.org/show_bug.cgi?id=31070
1651
1652         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1653         destroyed, it executes the value of the 'ondestroy' parameter as a
1654         script.
1655
1656         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1657         (pluginAllocate): Initialize onDestroy.
1658         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1659         onDestroy.
1660         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1661         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1662         specified.
1663         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1664
1665 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1666
1667         Reviewed by Xan Lopez.
1668
1669         https://bugs.webkit.org/show_bug.cgi?id=31035
1670         [GTK] some accessibility tests hitting assertion in debug builds
1671
1672         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1673
1674         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1675         (AccessibilityController::rootElement):
1676
1677 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1678
1679         Reviewed by Beth Dakin.
1680
1681         Support ARIA "tab" roles
1682         https://bugs.webkit.org/show_bug.cgi?id=30842
1683
1684         * DumpRenderTree/AccessibilityUIElement.cpp:
1685         * DumpRenderTree/AccessibilityUIElement.h:
1686         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1687         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1688         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1689
1690 2009-11-01  Eric Seidel  <eric@webkit.org>
1691
1692         Reviewed by David Levin.
1693
1694         buildbots should use --exit-after-N-failures
1695         https://bugs.webkit.org/show_bug.cgi?id=30809
1696
1697         Make the bots exit after 20 failures to prevent never-ending
1698         test runs where every test spends a minute crashing.
1699
1700         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1701
1702 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1703
1704         Reviewed by Eric Seidel.
1705
1706         Turn on warnings for QtWebKit for gcc
1707         https://bugs.webkit.org/show_bug.cgi?id=30958
1708
1709         * DumpRenderTree/qt/main.cpp: 
1710         (crashHandler): Mark function NO_RETURN
1711
1712 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1713
1714         Adding myself to the committers list.
1715
1716         * Scripts/modules/committers.py:
1717
1718 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1719
1720         Fix an issue that Adam noticed in DRT.
1721
1722         Reviewed by Darin Adler.
1723
1724         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1725         (AccessibilityUIElement::role):
1726         Get the length of the role text, and create a buffer dynamically.
1727
1728 2009-10-30  Eric Seidel  <eric@webkit.org>
1729
1730         No review, rolling out r50105.
1731         http://trac.webkit.org/changeset/50105
1732
1733         This commit was causing:
1734         https://bugs.webkit.org/show_bug.cgi?id=30869
1735         We'll re-implement the feature a different way.
1736
1737         * Scripts/bugzilla-tool:
1738
1739 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1740
1741         Test for MSAA: Accessibility of headings is not correct
1742
1743         https://bugs.webkit.org/show_bug.cgi?id=30937
1744
1745         Reviewed by Adam Roben.
1746
1747         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1748         (AccessibilityUIElement::role):
1749         Allow the role returned to be a BSTR.
1750         (AccessibilityUIElement::description):
1751         Fix a copy/paste error.
1752
1753 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1754
1755         Test for MSAA: Accessibility of links is wrong
1756
1757         https://bugs.webkit.org/show_bug.cgi?id=30928
1758
1759         Reviewed by Darin Adler.
1760
1761         * DumpRenderTree/AccessibilityUIElement.cpp:
1762         (getAccessibilityValueCallback):
1763         Return the accessibility value.
1764         (AccessibilityUIElement::getJSClass):
1765         Added "accessibilityValue" value.
1766
1767         * DumpRenderTree/AccessibilityUIElement.h:
1768
1769         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1770         (AccessibilityUIElement::accessibilityValue):
1771         Stubbed.
1772
1773         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1774         (AccessibilityUIElement::accessibilityValue):
1775         Stubbed.
1776
1777         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1778         (AccessibilityUIElement::accessibilityValue):
1779         Get the object's value, and return it as a JS string.
1780
1781 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1782
1783         Fix typo in command name used by wx build system.
1784
1785         * wx/build/build_utils.py:
1786
1787 2009-10-30  Adam Barth  <abarth@webkit.org>
1788
1789         Reviewed by Darin Adler.
1790
1791         Patch v1 is a dumb default name for patches
1792         https://bugs.webkit.org/show_bug.cgi?id=30952
1793
1794         Let's use "Patch" instead.
1795
1796         * Scripts/bugzilla-tool:
1797
1798 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1799
1800         Unreviewed trivial buildfix.
1801
1802         [Qt] Buildfix for r50333.
1803
1804         * DumpRenderTree/qt/DumpRenderTree.pro:
1805
1806 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1807
1808         Reviewed by Holger Freyther.
1809
1810         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1811         https://bugs.webkit.org/show_bug.cgi?id=30953
1812
1813         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1814         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1815         makes qt DRT to share this implementation (as gtk and mac ports do).
1816
1817         * DumpRenderTree/qt/DumpRenderTree.pro:
1818         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1819         * DumpRenderTree/qt/WorkQueue.h: Removed.
1820
1821 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1822
1823         Unreviewed potential buildbot fix.
1824
1825         Second try: Reset page history before running each test.
1826
1827         Apparently the QWebHistory::clear() keeps the current page
1828         in history which is not what we want, so we not additionally
1829         sets the history capacity to 0 (forces removing everything)
1830         and then sets it back to its original value.
1831
1832         * DumpRenderTree/qt/DumpRenderTree.cpp:
1833         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1834
1835 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1836
1837         Unreviewed potential buildbot fix.
1838
1839         Reset page history before running each test.
1840
1841         * DumpRenderTree/qt/DumpRenderTree.cpp:
1842         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1843
1844 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1845
1846         Reviewed by Eric Seidel.
1847
1848         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1849
1850         Bug 28420 -  Implement HTML5 <ruby> rendering
1851         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1852
1853         No new tests (no functional change).
1854
1855         * Scripts/build-webkit:
1856
1857 2009-10-29  Dan Bernstein  <mitz@apple.com>
1858
1859         Reviewed by Mark Rowe.
1860
1861         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1862         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1863         define it.
1864
1865         * Scripts/VCSUtils.pm:
1866         * Scripts/svn-apply:
1867         * Scripts/svn-unapply:
1868
1869 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1870
1871         Reviewed by Gustavo Noronha.
1872
1873         Use the GTK+ main loop instead of rolling our own mini-version of
1874         it.
1875
1876         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1877         (dump):
1878         (runTest):
1879         (webViewLoadFinished):
1880
1881 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1882
1883         Reviewed by Oliver Hunt.
1884
1885         Implement the Qt version of DRT dumpBackForwardList().
1886
1887         * DumpRenderTree/qt/DumpRenderTree.cpp:
1888         (WebCore::dumpHistoryItem):
1889         (WebCore::DumpRenderTree::dumpBackForwardList):
1890
1891 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1892
1893         Reviewed by Adam Roben.
1894
1895         Implement DRT functionality for Qt introduced in
1896         r28690 and r28705.
1897
1898         - Implemented pathToLocalResource which exposes the functionality of
1899         converting a given unix path to the correct location on Windows.
1900         - Implemented a way to remove machine-dependent information from paths
1901         in layout test results.
1902
1903         * DumpRenderTree/qt/DumpRenderTree.cpp:
1904         (WebCore::urlSuitableForTestResult):
1905         (WebCore::WebPage::javaScriptConsoleMessage):
1906         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1907         (LayoutTestController::pathToLocalResource):
1908         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1909
1910 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1911
1912         Adding myself to the committers list.
1913
1914         * Scripts/modules/committers.py:
1915
1916 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1917
1918         Adding myself to the committers list.
1919
1920         * Scripts/modules/committers.py:
1921
1922 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1923
1924         Reviewed by Jan Alonzo.
1925
1926         [GTK] API to start inspector for a WebView
1927         https://bugs.webkit.org/show_bug.cgi?id=22551
1928
1929         Use the new inspector API to implement the LayoutTestController
1930         interfaces used to test the inspector.
1931
1932         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1933         (webInspectorInspectWebView):
1934         (createWebView):
1935         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1936         (LayoutTestController::showWebInspector):
1937         (LayoutTestController::closeWebInspector):
1938         (LayoutTestController::evaluateInWebInspector):
1939
1940 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1941
1942         Reviewed by Eric Seidel.
1943
1944         [Qt] WebFrame::counterValueForElementById must not be exposed
1945         https://bugs.webkit.org/show_bug.cgi?id=30882
1946
1947         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1948         (LayoutTestController::counterValueForElementById):
1949
1950 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1951
1952         Rubberstamped by Oliver Hunt.
1953
1954         Fix the warning:
1955
1956         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1957         declared with attribute warn_unused_result".
1958
1959         by actually checking the result. In the case it is null, an
1960         error has occoured, so treat it as the other fatal errors.
1961
1962         * DumpRenderTree/qt/DumpRenderTree.cpp:
1963         (WebCore::DumpRenderTree::initializeFonts):
1964
1965 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1966
1967         Reviewed by Darin Adler.
1968
1969         Provide a way to get counter values with layoutTestContoller
1970         https://bugs.webkit.org/show_bug.cgi?id=30555
1971
1972         Define layoutTestContoller.counterValueForElementById.
1973
1974         * DumpRenderTree/LayoutTestController.cpp:
1975         (counterValueForElementByIdCallback):
1976         (LayoutTestController::staticFunctions):
1977         * DumpRenderTree/LayoutTestController.h:
1978         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1979         (LayoutTestController::counterValueForElementById):
1980
1981 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1982
1983         Rubberstamped by Oliver Hunt.
1984
1985         Change two methods to be internal for DRT use only.
1986
1987         Part of [Qt] Review all new API in Qt 4.6
1988         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1989
1990         * DumpRenderTree/qt/DumpRenderTree.cpp:
1991         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1992         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1993         (LayoutTestController::whiteListAccessFromOrigin):
1994
1995 2009-10-27  Eric Seidel  <eric@webkit.org>
1996
1997         Reviewed by Adam Barth.
1998
1999         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2000         https://bugs.webkit.org/show_bug.cgi?id=30826
2001
2002         * Scripts/svn-apply:
2003          - Add () around all system() calls.
2004          - Use the correct system() == 0 or die instead of system() or die
2005          - Add descriptive messages to all die statements.
2006
2007 2009-10-27  Steve Block  <steveblock@google.com>
2008
2009         Reviewed by NOBODY.
2010
2011         Adds steveblock@google.com to list of committers.
2012
2013         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2014
2015 2009-10-27  Eric Seidel  <eric@webkit.org>
2016
2017         Reviewed by Adam Barth.
2018
2019         svn-apply can exit(0) even on patch failure
2020         https://bugs.webkit.org/show_bug.cgi?id=29622
2021
2022         * Scripts/svn-apply:
2023          - Add a bunch of "or die" statements, hopefully catching all
2024            possible cases where failure could still exit(0).
2025
2026 2009-10-27  Eric Seidel  <eric@webkit.org>
2027
2028         Reviewed by Adam Barth.
2029
2030         svn-* scripts should share code through VCSUtils.pm
2031         https://bugs.webkit.org/show_bug.cgi?id=30791
2032
2033         Just moving code into a shared location.
2034
2035         * Scripts/VCSUtils.pm:
2036         * Scripts/prepare-ChangeLog:
2037         * Scripts/resolve-ChangeLogs:
2038         * Scripts/svn-apply:
2039         * Scripts/svn-create-patch:
2040         * Scripts/svn-unapply:
2041         * Scripts/update-webkit:
2042
2043 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2044
2045         Suppress a huge number of MSVC warnings when building wxWebKit.
2046
2047         * wx/build/settings.py:
2048
2049 2009-10-26  Eric Seidel  <eric@webkit.org>
2050
2051         No review, just adding Mike Belshe to the committers list.
2052
2053         * Scripts/modules/committers.py:
2054
2055 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2056
2057         Reviewed by Darin Adler.
2058
2059         Make .rc files compile on Windows without depending on MFC headers
2060         https://bugs.webkit.org/show_bug.cgi?id=30750
2061
2062         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2063         windows.h instead of afxres.h because it exists even when MFC is not 
2064         installed, and is all that's needed here.
2065
2066         * FindSafari/FindSafari.rc: Ditto
2067
2068 2009-10-24  Eric Seidel  <eric@webkit.org>
2069
2070         Reviewed by Adam Barth.
2071
2072         bugzilla-tool post-diff should know how to mark commit-queue=?
2073         https://bugs.webkit.org/show_bug.cgi?id=29202
2074
2075         * Scripts/bugzilla-tool:
2076          - Add --commit-queue option to post-diff, post-commits and create-bug.
2077         * Scripts/modules/bugzilla.py:
2078          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2079          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2080
2081 2009-10-23  Eric Seidel  <eric@webkit.org>
2082
2083         Reviewed by Adam Barth.
2084
2085         bugzilla-tool commit-queue does not notice modifications to committers.py
2086         https://bugs.webkit.org/show_bug.cgi?id=30084
2087
2088         * Scripts/bugzilla-tool:
2089          - Make commit-queue re-exec itself instead of using while(1).
2090          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2091          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2092
2093 2009-10-22  Eric Seidel  <eric@webkit.org>
2094
2095         Reviewed by Adam Barth.
2096
2097         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2098         https://bugs.webkit.org/show_bug.cgi?id=30634
2099
2100         * Scripts/bugzilla-tool:
2101          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2102          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2103
2104 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2105
2106         Reviewed by Eric Seidel.
2107
2108         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2109
2110         https://bugs.webkit.org/show_bug.cgi?id=30763
2111
2112         * pywebsocket/mod_pywebsocket/__init__.py:
2113         * pywebsocket/mod_pywebsocket/dispatch.py:
2114         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2115         * pywebsocket/mod_pywebsocket/standalone.py:
2116         * pywebsocket/setup.py:
2117         * pywebsocket/test/test_dispatch.py:
2118
2119 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2120
2121         Reviewed by David Levin.
2122
2123         REGRESSION: 2 failures in run-webkit-unittests
2124         https://bugs.webkit.org/show_bug.cgi?id=30645
2125
2126         * Scripts/modules/cpp_style_unittest.py:
2127         Fixed a few test scenarios which apparently lost some spaces from 
2128         text literals.
2129
2130 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2131
2132         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2133
2134         * Scripts/webkitdirs.pm:
2135
2136 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2137
2138         Reviewed by Darin Adler.
2139
2140         Unification of using null device in perl scripts.
2141         https://bugs.webkit.org/show_bug.cgi?id=30572
2142
2143         * Scripts/VCSUtils.pm:
2144         * Scripts/bisect-builds:
2145         * Scripts/resolve-ChangeLogs:
2146         * Scripts/run-iexploder-tests:
2147         * Scripts/run-jsc:
2148         * Scripts/run-mangleme-tests:
2149         * Scripts/run-webkit-tests:
2150         * Scripts/webkitdirs.pm:
2151         Using File::Spec->devnull() instead of hard coded /dev/null.
2152
2153 2009-10-26  Eric Seidel  <eric@webkit.org>
2154
2155         Reviewed by Holger Freyther.
2156
2157         Reviewers are missing from committers.py
2158         https://bugs.webkit.org/show_bug.cgi?id=30733
2159
2160         * Scripts/modules/committers.py:
2161
2162 2009-10-23  Eric Seidel  <eric@webkit.org>
2163
2164         No review, only adding Alice to the list of reviewers.
2165
2166         * Scripts/modules/committers.py:
2167
2168 2009-10-23  Eric Seidel  <eric@webkit.org>
2169
2170         Reviewed by Eric Carlson.
2171
2172         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2173         https://bugs.webkit.org/show_bug.cgi?id=30700
2174
2175         * DumpRenderTree/mac/DumpRenderTree.mm:
2176         (resetDefaultsToConsistentValues): Update QuickTime version check.
2177
2178 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2179
2180         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2181         character measurement APIs that are private on Tiger.
2182
2183         * wx/build/settings.py:
2184
2185 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2186
2187         Reviewed by NOBODY (build fix).
2188         Build fix following bug #30696.
2189
2190         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2191         (LayoutTestController::evaluateScriptInIsolatedWorld):
2192
2193 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2194
2195         Reviewed by Sam Weinig & Geoff Garen.
2196
2197         https://bugs.webkit.org/show_bug.cgi?id=30696
2198         Enable isolated-worlds tests on mac.
2199
2200         Add private interface for DRT to invoke execution in a given world.
2201
2202         * DumpRenderTree/LayoutTestController.cpp:
2203         (evaluateScriptInIsolatedWorldCallback):
2204         (LayoutTestController::staticFunctions):
2205         * DumpRenderTree/LayoutTestController.h:
2206         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2207         (LayoutTestController::evaluateScriptInIsolatedWorld):
2208         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2209         (LayoutTestController::evaluateScriptInIsolatedWorld):
2210
2211 2009-10-21  Eric Seidel  <eric@webkit.org>
2212
2213         Reviewed by Adam Barth.
2214
2215         bugzilla-tool's "patch failed to download an apply" error should give more information
2216         https://bugs.webkit.org/show_bug.cgi?id=30632
2217
2218         * Scripts/modules/scm.py:
2219          - Use the common run_command method instead of custom POpen code.
2220          - Make run_command know how to take pipes as input.
2221         * Scripts/modules/scm_unittest.py:
2222          - Add new tests to cover change.
2223          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2224
2225 2009-10-21  Kent Tamura  <tkent@chromium.org>
2226
2227         Unreviewed.  Adding myself to the committers list.
2228
2229         * Scripts/modules/committers.py:
2230
2231 2009-10-21  Robin Dunn  <robin@alldunn.com>
2232
2233         Reviewed by Kevin Ollivier.
2234
2235         Update the Windows installer builder to work with Vista / Win 7 and with git.
2236         
2237         https://bugs.webkit.org/show_bug.cgi?id=30649
2238
2239         * wx/build/build_utils.py:
2240         * wx/packaging/build-mac-installer.py:
2241         * wx/packaging/build-win-installer.py:
2242         * wx/packaging/wxWebKitInstaller.iss.in:
2243
2244 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2245
2246         Reviewed by Gustavo Noronha.
2247
2248         [GTK] Added conditional code to avoid using
2249         gdk_window_get_root_coords if we do not have a gtk+ release newer
2250         than 2.17.3.
2251         https://bugs.webkit.org/show_bug.cgi?id=30636
2252
2253         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2254
2255 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2256
2257         Reviewed by Eric Seidel.
2258
2259         [Qt] Added dummy implementation for keepWebHistory()
2260         https://bugs.webkit.org/show_bug.cgi?id=30592
2261
2262         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2263         (LayoutTestController::keepWebHistory):
2264         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2265
2266 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2267
2268         Reviewed by Xan Lopez.
2269
2270         [GTK] Fixed the double click condition, it is not double click if
2271         we move in just in one direction.
2272         https://bugs.webkit.org/show_bug.cgi?id=30636
2273
2274         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2275
2276 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2277
2278         Reviewed by Xan Lopez.
2279
2280         [GTK] Initialize the events completly before emitting them.
2281         https://bugs.webkit.org/show_bug.cgi?id=30633
2282
2283         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2284
2285 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2286
2287         wx build fix. Fix for when linking using --as-needed with gcc.
2288
2289         * wx/browser/wscript:
2290
2291 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2292
2293         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2294         to support all the features used by CURL backend.
2295         
2296         * wx/build/settings.py:
2297         * wx/install-unix-extras:
2298
2299 2009-10-20  Anton Muhin  <antonm@chromium.org>
2300
2301         Reviewed by Adam Barth.
2302
2303         Add {ager,antonm,yurys}@chromium.org into committers.py
2304         https://bugs.webkit.org/show_bug.cgi?id=30560
2305
2306         * Scripts/modules/committers.py:
2307
2308 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2309
2310         Reviewed by Tor Arne Vestbø.
2311
2312         Make the Netscape Test plugin available to the Qt launcher.
2313
2314         * Scripts/run-launcher:
2315
2316 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2317
2318         Reviewed by David Levin.
2319
2320         Removed WebSocket runtime settings.
2321         https://bugs.webkit.org/show_bug.cgi?id=29896
2322
2323         WebSocket runtime configuration is supported by chromium/v8 only.
2324
2325         * DumpRenderTree/mac/DumpRenderTree.mm:
2326         (resetDefaultsToConsistentValues):
2327         * DumpRenderTree/win/DumpRenderTree.cpp:
2328         (resetDefaultsToConsistentValues):
2329
2330 2009-10-19  Nate Chapin  <japhet@chromium.org>
2331
2332         Reviewed by Adam Barth.
2333
2334         Add testFail() to test plugin so we can test our handling of a
2335         plugin invoke call returning false.
2336
2337         https://bugs.webkit.org/show_bug.cgi?id=30239
2338
2339         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2340         (pluginInvoke):
2341         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2342
2343 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2344
2345         Reviewed by Gustavo Noronha.
2346
2347         Enable DOM pasting when running layout tests.
2348
2349         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2350         (resetDefaultsToConsistentValues):
2351
2352 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2353
2354         Reviewed by Simon Hausmann.
2355
2356         Use the setPreferredContentsSize method instead
2357         of setFixedContentsSize, as the method has been renamed.
2358
2359         * DumpRenderTree/qt/DumpRenderTree.cpp:
2360         (WebCore::DumpRenderTree::open):
2361         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2362         (LayoutTestController::setFixedContentsSize):
2363
2364 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2365
2366         Reviewed by Dan Bernstein.
2367
2368         https://bugs.webkit.org/show_bug.cgi?id=30456
2369         Fixes for new Debug_All Windows build configuration.
2370
2371         * DumpRenderTree/win/DumpRenderTree.cpp:
2372         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2373         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2374
2375 2009-10-16  Eric Seidel  <eric@webkit.org>
2376
2377         Reviewed by Adam Barth.
2378
2379         commit-queue status bot should list which buildbot is blocking the queue
2380         https://bugs.webkit.org/show_bug.cgi?id=30452
2381
2382         Add new methods and testing.
2383
2384         * Scripts/bugzilla-tool:
2385         * Scripts/modules/buildbot.py:
2386         * Scripts/modules/buildbot_unittest.py:
2387
2388 2009-10-16  Eric Seidel  <eric@webkit.org>
2389
2390         Reviewed by Adam Barth.
2391
2392         run-webkit-tests fails when CWD is not inside a WebKit checkout
2393         https://bugs.webkit.org/show_bug.cgi?id=30451
2394
2395         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2396         * Scripts/modules/scm_unittest.py:
2397           - Remove use of original_path (we don't need to restore the CWD).
2398           - Don't use '.' to find the webkit checkout, use __file__ instead.
2399
2400 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2401
2402         Reviewed by Adam Roben.
2403
2404         Add a Debug_All configuration to build entire stack as debug.
2405         Change Debug_Internal to:
2406         - stop using _debug suffix for all WebKit/Safari binaries
2407         - not use _debug as a DLL naming suffix
2408         - use non-debug C runtime lib.
2409
2410         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2411         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2412         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2413         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2414         Add missing debug.vsprops inherited property sheet.
2415         Add Debug_All configuration.
2416         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2417         * WinLauncher/WinLauncher.vcproj:
2418         Removed extraneous definitions inherited from vsprops.
2419         Add Debug_All configuration.
2420
2421 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2422
2423         Reviewed by David Levin.
2424
2425         check-webkit-style is wrong about indent checking in namespaces
2426         in header files and a few other things
2427         https://bugs.webkit.org/show_bug.cgi?id=30362
2428
2429         The few other things include:
2430         + check-webkit-style does not require spaces around the equal sign
2431           inside 'if' statements and around binary operators that take 
2432           numeric literals.
2433         + check-webkit-style reports false errors for the / operator
2434           when part of a filename in the #include directive.
2435
2436         * Scripts/modules/cpp_style.py:
2437         Improved indentation checking and space checking around
2438         binary operators. While the checks are still not perfect,
2439         they are clearly better than before.
2440         * Scripts/modules/cpp_style_unittest.py:
2441         Added test cases for the newly supported checks and modified old
2442         test cases to match the new guidelines
2443
2444 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2445
2446         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2447
2448         * wx/build/settings.py:
2449
2450 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2451
2452         Reviewed by David Levin.
2453
2454         Add mod_pywebsocket to test Web Sockets.
2455         http://code.google.com/p/pywebsocket/
2456         https://bugs.webkit.org/show_bug.cgi?id=27490
2457
2458         * pywebsocket/COPYING: Added.
2459         * pywebsocket/MANIFEST.in: Added.
2460         * pywebsocket/README: Added.
2461         * pywebsocket/example/echo_client.py: Added.
2462         * pywebsocket/example/echo_wsh.py: Added.
2463         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2464         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2465         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2466         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2467         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2468         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2469         * pywebsocket/mod_pywebsocket/util.py: Added.
2470         * pywebsocket/setup.py: Added.
2471         * pywebsocket/test/config.py: Added.
2472         * pywebsocket/test/mock.py: Added.
2473         * pywebsocket/test/run_all.py: Added.
2474         * pywebsocket/test/test_dispatch.py: Added.
2475         * pywebsocket/test/test_handshake.py: Added.
2476         * pywebsocket/test/test_mock.py: Added.
2477         * pywebsocket/test/test_msgutil.py: Added.
2478         * pywebsocket/test/test_util.py: Added.
2479         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2480         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2481         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2482         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2483         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2484         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2485         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2486         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2487
2488 2009-10-15  James Robinson  <jamesr@google.com>
2489
2490         Reviewed by David Levin.
2491
2492         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2493
2494         https://bugs.webkit.org/show_bug.cgi?id=30426
2495
2496         * Scripts/modules/cpp_style.py:
2497         * Scripts/modules/cpp_style_unittest.py:
2498
2499 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2500
2501         Reviewed by Adam Roben.
2502
2503         Fixes <http://webkit.org/b/30411>.
2504         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2505         
2506         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2507         building Chromium.
2508
2509         * Scripts/pdevenv:
2510
2511 2009-10-15  Robin Dunn  <robin@alldunn.com>
2512
2513         Reviewed by Kevin Ollivier.
2514
2515         Add Mac package building scripts for wx.
2516         
2517         https://bugs.webkit.org/show_bug.cgi?id=30405
2518
2519         * wx/build/build_utils.py:
2520         * wx/build/settings.py:
2521         * wx/packaging/build-mac-installer.py: Added.
2522
2523 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2524
2525         Reviewed by Gustavo Noronha.
2526
2527         Enable Web Sockets support when running layout tests.
2528
2529         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2530         (resetDefaultsToConsistentValues):
2531
2532 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2533
2534         Reviewed by Gustavo Noronha.
2535
2536         Need to initialize event.button.button, since in most cases a
2537         button number is not passed as an argument.
2538
2539         * DumpRenderTree/gtk/EventSender.cpp:
2540         (mouseDownCallback):
2541         (mouseUpCallback):
2542
2543 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2544
2545         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2546         the OS if none was explicitly set.
2547
2548         * wx/build/settings.py:
2549
2550 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2551
2552         Reviewed by Timothy Hatcher.
2553
2554         Web Inspector: enable developers extras within inspector layout tests.
2555
2556         https://bugs.webkit.org/show_bug.cgi?id=30014
2557
2558         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2559         (LayoutTestController::showWebInspector):
2560         (LayoutTestController::closeWebInspector):
2561         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2562         (LayoutTestController::showWebInspector):
2563         (LayoutTestController::closeWebInspector):
2564
2565 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2566
2567         Reviewed by Jan Alonzo.
2568
2569         GtkLauncher is using a deprecated signal
2570         https://bugs.webkit.org/show_bug.cgi?id=30364
2571
2572         Modified GtkLauncher to use notify::title signal instead of
2573         deprecated title-changed signal
2574
2575         * GtkLauncher/main.c:
2576         (notify_title_cb):
2577         (create_browser):
2578
2579 2009-10-14  Brady Eidson  <beidson@apple.com>
2580
2581         Reviewed by Sam Weinig.
2582
2583         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2584         1 - Disables WebHistory
2585         2 - Doesn't make sense in that context anyway.
2586
2587         * DumpRenderTree/win/DumpRenderTree.cpp:
2588         (createWebViewAndOffscreenWindow):
2589
2590 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2591
2592         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2593         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2594
2595         * wx/build/settings.py:
2596         * wx/install-unix-extras:
2597
2598 2009-10-14  Brady Eidson  <beidson@apple.com>
2599
2600         Reviewed by Sam Weinig.
2601
2602         WebKit Win API should provide a delegate interface for global history.
2603         https://bugs.webkit.org/show_bug.cgi?id=29905
2604
2605         * DumpRenderTree/LayoutTestController.cpp:
2606         (LayoutTestController::LayoutTestController):
2607         * DumpRenderTree/LayoutTestController.h:
2608         (LayoutTestController::dumpHistoryDelegateCallbacks):
2609         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2610                 
2611         * DumpRenderTree/win/DumpRenderTree.cpp:
2612         (shouldLogHistoryDelegates):
2613         (runTest):
2614         (createWebViewAndOffscreenWindow):
2615         (main):
2616         * DumpRenderTree/win/DumpRenderTree.vcproj:
2617         
2618         Add the IWebHistoryDelegate to DRT Windows:
2619         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2620         (wstringFromBSTR):
2621         (HistoryDelegate::HistoryDelegate):
2622         (HistoryDelegate::~HistoryDelegate):
2623         (HistoryDelegate::QueryInterface):
2624         (HistoryDelegate::AddRef):
2625         (HistoryDelegate::Release):
2626         (HistoryDelegate::didNavigateWithNavigationData):
2627         (HistoryDelegate::didPerformClientRedirectFromURL):
2628         (HistoryDelegate::didPerformServerRedirectFromURL):
2629         (HistoryDelegate::updateHistoryTitle):
2630         (HistoryDelegate::populateVisitedLinksForWebView):
2631         * DumpRenderTree/win/HistoryDelegate.h: Added.
2632
2633         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2634         (LayoutTestController::removeAllVisitedLinks):
2635
2636 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2637
2638         Reviewed by Simon Hausmann.
2639
2640         [Qt] Implement support for setPOSIXLocale on Qt.
2641         https://bugs.webkit.org/show_bug.cgi?id=30268 
2642  
2643         * DumpRenderTree/qt/DumpRenderTree.cpp:
2644         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2645         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2646         (LayoutTestController::setPOSIXLocale):
2647         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2648
2649 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2650
2651         Unreviewed, adding myself to reviewers list.
2652
2653         * Scripts/modules/committers.py:
2654
2655 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2656
2657         Reviewed by Mark Rowe.
2658
2659         Fix null assignment so root tests work again.
2660
2661         * Scripts/webkitdirs.pm:
2662
2663 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2664
2665         Reviewed by Simon Hausmann.
2666
2667         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2668         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2669         This is done in preparation of implementing missing features in DRT.
2670         No functionality changes made yet.
2671
2672         * DumpRenderTree/qt/DumpRenderTree.cpp:
2673         * DumpRenderTree/qt/DumpRenderTree.pro:
2674         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2675         (EventSender::EventSender):
2676         (EventSender::mouseDown):
2677         (EventSender::mouseUp):
2678         (EventSender::mouseMoveTo):
2679         (EventSender::leapForward):
2680         (EventSender::keyDown):
2681         (EventSender::contextClick):
2682         (EventSender::scheduleAsynchronousClick):
2683         (EventSender::frameUnderMouse):
2684         * DumpRenderTree/qt/EventSenderQt.h: Added.
2685         (EventSender::clearKillRing):
2686         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2687         (LayoutTestController::LayoutTestController):
2688         (LayoutTestController::reset):
2689         (LayoutTestController::processWork):
2690         (LayoutTestController::maybeDump):
2691         (LayoutTestController::waitUntilDone):
2692         (LayoutTestController::notifyDone):
2693         (LayoutTestController::windowCount):
2694         (LayoutTestController::clearBackForwardList):
2695         (LayoutTestController::dumpEditingCallbacks):
2696         (LayoutTestController::dumpResourceLoadCallbacks):
2697         (LayoutTestController::queueBackNavigation):
2698         (LayoutTestController::queueForwardNavigation):
2699         (LayoutTestController::queueLoad):
2700         (LayoutTestController::queueReload):
2701         (LayoutTestController::queueScript):
2702         (LayoutTestController::provisionalLoad):
2703         (LayoutTestController::timerEvent):
2704         (LayoutTestController::encodeHostName):
2705         (LayoutTestController::decodeHostName):
2706         (LayoutTestController::setJavaScriptProfilingEnabled):
2707         (LayoutTestController::setFixedContentsSize):
2708         (LayoutTestController::setPrivateBrowsingEnabled):
2709         (LayoutTestController::setPopupBlockingEnabled):
2710         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2711         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2712         (LayoutTestController::numberOfActiveAnimations):
2713         (LayoutTestController::disableImageLoading):
2714         (LayoutTestController::dispatchPendingLoadRequests):
2715         (LayoutTestController::setDatabaseQuota):
2716         (LayoutTestController::clearAllDatabases):
2717         (LayoutTestController::whiteListAccessFromOrigin):
2718         (LayoutTestController::waitForPolicyDelegate):
2719         (LayoutTestController::overridePreference):
2720         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2721         (LayoutTestController::isLoading):
2722         (LayoutTestController::setLoading):
2723         (LayoutTestController::shouldDumpAsText):
2724         (LayoutTestController::shouldDumpBackForwardList):
2725         (LayoutTestController::shouldDumpChildrenAsText):
2726         (LayoutTestController::shouldDumpDatabaseCallbacks):
2727         (LayoutTestController::shouldDumpStatusCallbacks):
2728         (LayoutTestController::shouldWaitUntilDone):
2729         (LayoutTestController::canOpenWindows):
2730         (LayoutTestController::shouldDumpTitleChanges):
2731         (LayoutTestController::waitForPolicy):
2732         (LayoutTestController::dumpAsText):
2733         (LayoutTestController::dumpChildFramesAsText):
2734         (LayoutTestController::dumpDatabaseCallbacks):
2735         (LayoutTestController::dumpStatusCallbacks):
2736         (LayoutTestController::setCanOpenWindows):
2737         (LayoutTestController::dumpBackForwardList):
2738         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2739         (LayoutTestController::display):
2740         (LayoutTestController::dumpTitleChanges):
2741         (LayoutTestController::dumpSelectionRect):
2742         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2743         (TextInputController::TextInputController):
2744         (TextInputController::doCommand):
2745         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2746         * DumpRenderTree/qt/WorkQueue.cpp:
2747         * DumpRenderTree/qt/WorkQueue.h:
2748         * DumpRenderTree/qt/WorkQueueItem.h:
2749         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2750         (findFrameNamed):
2751         (LoadItem::invoke):
2752         (ReloadItem::invoke):
2753         (ScriptItem::invoke):
2754         (BackForwardItem::invoke):
2755         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2756         * DumpRenderTree/qt/jsobjects.h:
2757
2758 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2759
2760         Not reviewed, adding myself to the list of reviewers.
2761
2762         * Scripts/modules/committers.py:
2763
2764 2009-10-13  Anders Carlsson  <andersca@apple.com>
2765
2766         Reviewed by Sam Weinig.
2767
2768         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2769
2770         Make the private browsing mode testable by the test plug-in.
2771         
2772         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2773         (pluginGetProperty):
2774         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2775         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2776         (NPP_New):
2777         (NPP_SetValue):
2778
2779 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2780
2781         No review, just adding self to the list of reviewers.
2782
2783         * Scripts/modules/committers.py:
2784
2785 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2786
2787         Reviewed by Adam Roben.
2788
2789         Web Inspector: Use proper web view in inspector layout
2790         tests for windows.
2791
2792         https://bugs.webkit.org/show_bug.cgi?id=30298
2793
2794         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2795         (LayoutTestController::showWebInspector):
2796         (LayoutTestController::closeWebInspector):
2797         (LayoutTestController::evaluateInWebInspector):
2798
2799 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2800
2801         Reviewed by Sam Weinig.
2802
2803         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2804         https://bugs.webkit.org/show_bug.cgi?id=29841
2805
2806         * DumpRenderTree/mac/DumpRenderTree.mm:
2807         (resetDefaultsToConsistentValues):
2808         * DumpRenderTree/win/DumpRenderTree.cpp:
2809         (resetDefaultsToConsistentValues):
2810
2811 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2812
2813         Reviewed by Dimitri Glazkov.
2814
2815         Chromium Port - Windows
2816         https://bugs.webkit.org/show_bug.cgi?id=29969
2817
2818         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2819         * Scripts/webkitdirs.pm:
2820
2821 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2822
2823         Reviewed by Darin Adler.
2824
2825         jsc scripts cleanup and Qt/GTK fix
2826         https://bugs.webkit.org/show_bug.cgi?id=30288
2827
2828         Duplicated jscPath() moved to webkitdirs.pm.
2829         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2830         Configuration added (release/debug) to path for Qt-port on Windows.
2831
2832         * Scripts/run-javascriptcore-tests:
2833         * Scripts/run-jsc:
2834         * Scripts/run-sunspider:
2835         * Scripts/sunspider-compare-results:
2836         * Scripts/webkitdirs.pm:
2837
2838 2009-10-11  Adam Barth  <abarth@webkit.org>
2839
2840         Unreviewed.  Add Collin to committers.py.
2841
2842         * Scripts/modules/committers.py:
2843
2844 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2845
2846         wx build fix, add bindings to source/include dirs now that there are sources there.
2847
2848         * wx/build/settings.py:
2849
2850 2009-10-09  Mark Rowe  <mrowe@apple.com>
2851
2852         Reviewed by Brady Eidson.
2853
2854         Enable plug-in halting in DumpRenderTree.
2855
2856         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2857         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2858
2859         * DumpRenderTree/mac/DumpRenderTree.mm:
2860         (resetDefaultsToConsistentValues):
2861         * DumpRenderTree/mac/UIDelegate.mm:
2862         (-[UIDelegate webView:shouldHaltPlugin:]):
2863
2864 2009-10-08  Brady Eidson  <beidson@apple.com>
2865
2866         Reviewed by Dan Bernstein.
2867
2868         Ask the History Delegate to populate the visited links hash.
2869         <rdar://problem/7285293> and https://webkit.org/b/29904
2870
2871         Add the ability for LayoutTestController to clear all visited links.
2872         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2873
2874         * DumpRenderTree/LayoutTestController.cpp:
2875         (LayoutTestController::LayoutTestController):
2876         (removeAllVisitedLinksCallback):
2877         (LayoutTestController::staticFunctions):
2878         * DumpRenderTree/LayoutTestController.h:
2879         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2880         (LayoutTestController::removeAllVisitedLinks):
2881
2882         * DumpRenderTree/mac/HistoryDelegate.mm:
2883         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2884
2885         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2886         (LayoutTestController::removeAllVisitedLinks):
2887         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2888         (LayoutTestController::removeAllVisitedLinks):
2889         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2890         (LayoutTestController::removeAllVisitedLinks):
2891
2892
2893 2009-10-08  Daniel Bates  <dbates@webkit.org>
2894
2895         Reviewed by Adam Roben.
2896
2897         https://bugs.webkit.org/show_bug.cgi?id=30175
2898         
2899         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2900         the OLE drag-and-drop return value like the function it emulates. Currently, 
2901         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
2902         whether the drag-and-drop operation was successful or was cancelled.
2903         
2904         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
2905         return value according to whether the drop operation was successful or not.
2906
2907         * DumpRenderTree/win/EventSender.cpp:
2908         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2909         (replaySavedEvents): Ditto.
2910         * DumpRenderTree/win/EventSender.h:
2911         * DumpRenderTree/win/UIDelegate.cpp:
2912         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2913
2914 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2915
2916         Reviewed by Xan Lopez.
2917
2918         [GTK] Added support for a parameter setting the button that was
2919         pressed in the mouseDown function.
2920         https://bugs.webkit.org/show_bug.cgi?id=30220
2921
2922         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2923
2924 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2925
2926         Reviewed by Xan Lopez.
2927
2928         [GTK] Added a line to the bottom of the expected result to match
2929         the output of the test.
2930         https://bugs.webkit.org/show_bug.cgi?id=30220
2931
2932         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2933         expected.txt:
2934
2935 2009-10-08  Adam Roben  <aroben@apple.com>
2936
2937         Use QueryInterface to get IWebInspectorPrivate
2938
2939         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2940         accessed in a more standard way
2941
2942         Reviewed by John Sullivan and Tim Hatcher.
2943
2944         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2945         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2946         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2947         to the IWebInspectorPrivate interface.
2948
2949 2009-10-07  Adam Roben  <aroben@apple.com>
2950
2951         Implement DRT support for origin whitelisting
2952
2953         Fixes <http://webkit.org/b/30185>.
2954
2955         Reviewed by Eric Seidel.
2956
2957         * DumpRenderTree/win/DumpRenderTree.cpp:
2958         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2959         whitelist, to match Mac DRT.
2960         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2961         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2962         IWebViewPrivate::whiteListAccessFromOrigin.
2963
2964 2009-10-07  Brady Eidson  <beidson@apple.com>
2965
2966         Reviewed by Darin Adler.
2967
2968         Send title changes to the global history delegate.
2969         <rdar://problem/7285293> and https://webkit.org/b/29904
2970
2971         * DumpRenderTree/mac/HistoryDelegate.mm:
2972         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2973
2974 2009-10-07  Adam Barth  <abarth@webkit.org>
2975
2976         Unreviewed.  Remove some folks from committers.py who were listed on
2977         the WebKit Team wiki page but who weren't actually listed as commit+.
2978         At some point, we should coorelate this list with the committers
2979         mailing list.
2980
2981         * Scripts/modules/committers.py:
2982
2983 2009-10-07  Adam Barth  <abarth@webkit.org>
2984
2985         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2986         the wiki into committers.py.
2987
2988         * Scripts/modules/committers.py:
2989
2990 2009-10-07  Adam Barth  <abarth@webkit.org>
2991
2992         Unreviewed.  Added Aaron Boodman to committers.py.
2993
2994         * Scripts/modules/committers.py:
2995
2996 2009-10-07  Evan Martin  <evan@chromium.org>
2997
2998         Reviewed by Darin Adler.
2999
3000         Add API to LayoutTestController for re/setting the system locale.
3001         https://bugs.webkit.org/show_bug.cgi?id=18994
3002
3003         * DumpRenderTree/LayoutTestController.cpp:
3004         (setLocaleCallback):
3005         (LayoutTestController::staticFunctions):
3006         (LayoutTestController::setLocale):
3007         * DumpRenderTree/LayoutTestController.h:
3008
3009 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3010
3011         Reviewed by Jan Alonzo.
3012
3013         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3014         https://bugs.webkit.org/show_bug.cgi?id=29689
3015
3016         Build fix by adding -lfontconfig for DumpRenderTree.
3017
3018         * GNUmakefile.am:
3019
3020 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3021
3022         Reviewed by Simon Hausmann.
3023
3024         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3025
3026         * Scripts/run-webkit-tests:
3027
3028 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3029
3030         Reviewed by Gustavo Noronha.
3031
3032         "delete" in EventSender is the backspace key, not the delete one.
3033
3034         * DumpRenderTree/gtk/EventSender.cpp:
3035         (keyDownCallback):
3036
3037 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3038
3039         Reviewed by Gustavo Noronha.
3040
3041         getChildrenWithRange expects as last parameter the end index, not
3042         the length of the range. Correct this and clarify the variable
3043         names to reflect how the code works.
3044
3045         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3046         (AccessibilityUIElement::getChildrenWithRange):
3047         (AccessibilityUIElement::getChildAtIndex):
3048
3049 2009-10-06  Mark Rowe  <mrowe@apple.com>
3050
3051         Reviewed by Simon Fraser.
3052
3053         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3054
3055         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3056         the fact we have already changed the working directory to the top of the open source tree.
3057
3058 2009-10-06  Julie Parent  <jparent@chromium.org>
3059
3060         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3061         rather than my committer email.
3062
3063         * Scripts/modules/committers.py:
3064
3065 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3066
3067         Reviewed by Eric Seidel.
3068
3069         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3070
3071         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3072         it after each layout test as it should do, making the DRT dump additional output
3073         for all of the subsequent layout tests.
3074
3075         * DumpRenderTree/qt/jsobjects.cpp:
3076         (LayoutTestController::reset):
3077
3078 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3079
3080         Reviewed by Simon Hausmann.
3081
3082         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3083         fast/dom/assign-to-window-status.html test, which is passing as a result.
3084
3085         https://bugs.webkit.org/show_bug.cgi?id=30127
3086
3087         * DumpRenderTree/qt/DumpRenderTree.cpp:
3088         (WebCore::DumpRenderTree::DumpRenderTree):
3089         (WebCore::DumpRenderTree::statusBarMessage):
3090         * DumpRenderTree/qt/DumpRenderTree.h:
3091         * DumpRenderTree/qt/jsobjects.h:
3092         (LayoutTestController::shouldDumpStatusCallbacks):
3093         (LayoutTestController::dumpStatusCallbacks):
3094
3095 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3096
3097         Reviewed by Simon Hausmann.
3098
3099         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3100         ignores the argument indicating which mouse button to trigger.
3101         https://bugs.webkit.org/show_bug.cgi?id=30048
3102
3103         This affects the fast/events/mouse-click-events.html layout test.
3104
3105         * DumpRenderTree/qt/jsobjects.cpp:
3106         (EventSender::mouseDown):
3107         (EventSender::mouseUp):
3108         * DumpRenderTree/qt/jsobjects.h:
3109
3110 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3111
3112         Reviewed by Simon Hausmann.
3113
3114         [Qt] Fix the EventSender::keyDown() implementation
3115         https://bugs.webkit.org/show_bug.cgi?id=30043
3116
3117         It should post both a key press event and a key release event,
3118         just like other ports do.
3119
3120         * DumpRenderTree/qt/jsobjects.cpp:
3121         (EventSender::keyDown):
3122
3123 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3124
3125         wx build fix. Add jpeg to the list of libs to link against.
3126
3127         * wx/build/settings.py:
3128
3129 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3130
3131         Reviewed by Simon Hausmann.
3132
3133         [Qt] EventSender::keyDown() cannot send function-key events.
3134         https://bugs.webkit.org/show_bug.cgi?id=30044
3135
3136         This affects the fast/events/keydown-function-keys.html layout test.
3137
3138         * DumpRenderTree/qt/jsobjects.cpp:
3139         (EventSender::keyDown):
3140
3141 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3142
3143         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3144         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3145
3146         * wx/build/settings.py:
3147         * wx/build/wxpresets.py:
3148
3149 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3150
3151         Reviewed by Timothy Hatcher.
3152
3153         Web Inspector: add testing harness for Web Inspector.
3154
3155         https://bugs.webkit.org/show_bug.cgi?id=30010
3156
3157         * DumpRenderTree/LayoutTestController.cpp:
3158         (showWebInspectorCallback):
3159         (closeWebInspectorCallback):
3160         (evaluateInWebInspectorCallback):
3161         (LayoutTestController::staticFunctions):
3162         * DumpRenderTree/LayoutTestController.h:
3163         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3164         (LayoutTestController::showWebInspector):
3165         (LayoutTestController::closeWebInspector):
3166         (LayoutTestController::evaluateInWebInspector):
3167         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3168         (LayoutTestController::showWebInspector):
3169         (LayoutTestController::closeWebInspector):
3170         (LayoutTestController::evaluateInWebInspector):
3171         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3172         (LayoutTestController::showWebInspector):
3173         (LayoutTestController::closeWebInspector):
3174         (LayoutTestController::evaluateInWebInspector):
3175         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3176         (LayoutTestController::showWebInspector):
3177         (LayoutTestController::closeWebInspector):
3178         (LayoutTestController::evaluateInWebInspector):
3179
3180 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3181
3182         Reviewed by Ariyha Hidayat.
3183
3184         Pass arguments to system() as a string instead of array
3185
3186         When passed as an array entries with a space fail to translate
3187         to two arguments to the child process, so instead of manually
3188         splitting all the entries in @buildArgs we pass the whole thing
3189         as a string instead.
3190
3191         * Scripts/webkitdirs.pm:
3192
3193 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3194
3195         Reviewed by David Levin.
3196
3197         check-webkit-style misses whitespace errors for operators:
3198         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3199         https://bugs.webkit.org/show_bug.cgi?id=30021
3200
3201         * Scripts/modules/cpp_style.py:
3202         Added the operators mentioned above to the same list as == and !=.
3203
3204 2009-10-02  Julie Parent  <jparent@chromium.org>
3205
3206         Unreviewed.
3207
3208         Adding myself and Ojan Vafai as committers, because we are committers.
3209
3210         * Scripts/modules/committers.py:
3211
3212 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3213
3214         Reviewed by Adam Roben.
3215
3216         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3217         this will help the patch merging process when TryBots are used.
3218
3219         * Scripts/svn-create-patch:
3220
3221 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3222
3223         Reviewed by Simon Hausmann.
3224
3225         [Qt] Implement layoutTestController.overridePreference().
3226         https://bugs.webkit.org/show_bug.cgi?id=29970
3227
3228         * DumpRenderTree/qt/DumpRenderTree.cpp:
3229         (WebCore::WebPage::WebPage):
3230         (WebCore::WebPage::resetSettings):
3231         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3232         * DumpRenderTree/qt/jsobjects.cpp:
3233         (LayoutTestController::reset):
3234         (LayoutTestController::setPrivateBrowsingEnabled):
3235         (LayoutTestController::setPopupBlockingEnabled):
3236         (LayoutTestController::overridePreference):
3237         * DumpRenderTree/qt/jsobjects.h:
3238
3239 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3240
3241         Reviewed by Oliver Hunt.
3242
3243         Turn on ENABLE_3D_CANVAS in TOT
3244         https://bugs.webkit.org/show_bug.cgi?id=29906
3245
3246         * Scripts/build-webkit:
3247
3248 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3249
3250         Rubberstamped by Simon Hausmann.
3251
3252         Enable HTTP tests for Qt
3253
3254         * Scripts/run-webkit-tests:
3255
3256 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3257
3258         Reviewed by Dimitri Glazkov.
3259
3260         build-webkit --chromium now also works on cygwin.
3261
3262         https://bugs.webkit.org/show_bug.cgi?id=29973
3263
3264         * Scripts/webkitdirs.pm:
3265
3266 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3267
3268         Reviewed by Simon Hausmann.
3269
3270         [Qt] Don't use TCmalloc in DumpRenderTree
3271         https://bugs.webkit.org/show_bug.cgi?id=27029
3272
3273         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3274
3275         * DumpRenderTree/qt/DumpRenderTree.pro:
3276
3277 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3278
3279         Reviewed by Simon Hausmann.
3280
3281         [Qt] Implement eventSender.scheduleAsynchronousClick().
3282
3283         https://bugs.webkit.org/show_bug.cgi?id=29931
3284
3285         * DumpRenderTree/qt/jsobjects.cpp:
3286         (EventSender::scheduleAsynchronousClick):
3287         * DumpRenderTree/qt/jsobjects.h:
3288
3289 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3290
3291         Reviewed by Simon Hausmann.
3292
3293         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3294         fast/events/open-window-from-another-frame.html from the Skipped list.
3295
3296         https://bugs.webkit.org/show_bug.cgi?id=29930
3297
3298         * DumpRenderTree/qt/jsobjects.cpp:
3299         (LayoutTestController::setPopupBlockingEnabled):
3300         * DumpRenderTree/qt/jsobjects.h:
3301
3302 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3303
3304         Unreviewed.
3305
3306         Added myself to the list of committers.
3307
3308         * Scripts/modules/committers.py:
3309
3310 2009-09-30  Eric Seidel  <eric@webkit.org>
3311
3312         No review, just adding Geoff to the list of reviewers.
3313
3314         * Scripts/modules/committers.py:
3315
3316 2009-09-30  Dan Bernstein  <mitz@apple.com>
3317
3318         Reviewed by Sam Weinig.
3319
3320         Added the WebKit Layout Tests fonts that are referenced in
3321         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3322
3323         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3324         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3325
3326 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3327
3328         Reviewed by David Kilzer.
3329
3330         Make sunspider scripts work on Windows platform.
3331         https://bugs.webkit.org/show_bug.cgi?id=29656
3332
3333         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3334         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3335         * Scripts/webkitdirs.pm: currentPerlPath() added.
3336
3337 2009-09-29  Brady Eidson  <beidson@apple.com>
3338
3339         Rubberstamped by Dan Bernstein.
3340
3341         Fix license and some sorting in new files.
3342
3343         * DumpRenderTree/mac/HistoryDelegate.h:
3344         * DumpRenderTree/mac/HistoryDelegate.mm:
3345
3346 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3347
3348         Reviewed by David Kilzer.
3349
3350         Fixed how error codes are handled.
3351         https://bugs.webkit.org/show_bug.cgi?id=29898
3352
3353         * Scripts/update-webkit:
3354         * Scripts/update-webkit-chromium:
3355
3356 2009-09-29  Brady Eidson  <beidson@apple.com>
3357
3358         Reviewed by John Sullivan.
3359
3360         Updated way-out-of-date sorting throughout the dump methods/flags.
3361
3362         * DumpRenderTree/LayoutTestController.cpp:
3363         (LayoutTestController::LayoutTestController):
3364         (dumpAsPDFCallback):
3365         (dumpAsTextCallback):
3366         (dumpFrameLoadCallbacksCallback):
3367         (dumpResourceLoadCallbacksCallback):
3368         (LayoutTestController::staticFunctions):
3369
3370         * DumpRenderTree/LayoutTestController.h:
3371         (LayoutTestController::dumpAsText):
3372         (LayoutTestController::setDumpAsText):
3373         (LayoutTestController::dumpFrameLoadCallbacks):
3374         (LayoutTestController::setDumpFrameLoadCallbacks):
3375         (LayoutTestController::dumpSelectionRect):
3376         (LayoutTestController::setDumpSelectionRect):
3377         (LayoutTestController::dumpSourceAsWebArchive):
3378         (LayoutTestController::setDumpSourceAsWebArchive):
3379         (LayoutTestController::dumpStatusCallbacks):
3380         (LayoutTestController::setDumpStatusCallbacks):
3381         (LayoutTestController::dumpTitleChanges):
3382         (LayoutTestController::setDumpTitleChanges):
3383         (LayoutTestController::dumpWillCacheResponse):
3384         (LayoutTestController::setDumpWillCacheResponse):
3385
3386 2009-09-29  Brady Eidson  <beidson@apple.com>
3387
3388         Reviewed by John Sullivan.
3389
3390         WebKit Mac API should provide a delegate interface for global history.
3391         <rdar://problem/7042773> and https://webkit.org/b/29904
3392
3393         Adding the dumping of global history delegate callbacks.
3394
3395         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3396
3397         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3398         * DumpRenderTree/mac/DumpRenderTree.mm:
3399         (createWebViewAndOffscreenWindow):
3400         (allocateGlobalControllers):
3401         (shouldLogFrameLoadDelegates):
3402         (shouldLogHistoryDelegates):
3403         (runTest):
3404
3405         Dump history delegate callbacks:
3406         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3407         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3408         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3409         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3410         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3411
3412 2009-09-29  Daniel Bates  <dbates@webkit.org>
3413
3414         Reviewed by Adam Roben.
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=28902
3417         
3418         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3419         was always DROPEFFECT_NONE (since it was hard coded to do so).
3420         
3421         This patch corrects this issue by determining the actual drop effect 
3422         performed by the corresponding drag-and-drop operation so that we can 
3423         return it.
3424
3425         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3426         (DraggingInfo::DraggingInfo):
3427         (DraggingInfo::performedDropEffect): Added method.
3428         (DraggingInfo::setPerformedDropEffect): Added method.
3429         * DumpRenderTree/win/EventSender.cpp:
3430         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3431         Moved delete draggingInfo to UIDelegate::doDragDrop.
3432         * DumpRenderTree/win/UIDelegate.cpp:
3433         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3434
3435 2009-09-29  Dan Bernstein  <mitz@apple.com>
3436
3437         Reviewed by Adam Roben.
3438
3439         Remove copying of unnecessary or nonexistent files from the ImageDiff
3440         post-build event.
3441
3442         * DumpRenderTree/win/ImageDiff.vcproj:
3443
3444 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3445
3446         Reviewed by David Kilzer.
3447
3448         [Qt] Make build-webkit script work on Windows
3449         https://bugs.webkit.org/show_bug.cgi?id=29802
3450
3451         * Scripts/run-webkit-tests:
3452         * Scripts/webkitdirs.pm:
3453          - Removed unnecessary -p switch for mkdir on Windows.
3454          - Use canonical path, which uses slashes or backslashes depends on platform.
3455          - isWindows() only test for Windows and not for Cyqwin.
3456
3457 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3458
3459         Reviewed by Simon Hausmann.
3460
3461         Fix time measurement in build-webkit after refactoring done in r48853.
3462
3463         * Scripts/build-webkit:
3464
3465 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3466
3467         Reviewed by Tor Arne Vestbø.
3468
3469         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3470         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3471
3472         * DumpRenderTree/qt/DumpRenderTree.cpp:
3473         (WebCore::WebPage::WebPage):
3474
3475 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3476
3477         Reviewed by Simon Hausmann.
3478
3479         [Qt] Implement eventSender.contextClick().
3480         https://bugs.webkit.org/show_bug.cgi?id=29821
3481
3482         * DumpRenderTree/qt/jsobjects.cpp:
3483         (EventSender::contextClick):
3484         * DumpRenderTree/qt/jsobjects.h:
3485
3486 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3487
3488         Reviewed by Eric Seidel.
3489
3490         Add experimentalWebSocketsEnabled in WebPreferences.
3491         https://bugs.webkit.org/show_bug.cgi?id=28941
3492
3493         * DumpRenderTree/mac/DumpRenderTree.mm:
3494         (resetDefaultsToConsistentValues):
3495         * DumpRenderTree/win/DumpRenderTree.cpp:
3496         (resetDefaultsToConsistentValues):
3497
3498 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3499
3500         Reviewed by David Kilzer.
3501
3502         Integrated chromium port building into webkit tools update-webkit and
3503         build-webkit.
3504
3505         https://bugs.webkit.org/show_bug.cgi?id=29749
3506
3507         * Scripts/build-webkit: When --chromium is specified, will build
3508           the chromium port (currently only Mac is supported).
3509         * Scripts/update-webkit: When --chromium is specified, delegates to
3510           update-webkit-chromium.
3511         * Scripts/webkitdirs.pm: Added chromium specific defs.
3512         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3513           chromium port's dependencies and update its project files.
3514
3515 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3516
3517         Unreviewed.
3518
3519         Add myself to list of committers.
3520
3521         * Scripts/modules/committers.py:
3522
3523 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3524
3525         Reviewed by Darin Adler.
3526
3527         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3528         https://bugs.webkit.org/show_bug.cgi?id=29771
3529
3530         * Scripts/run-webkit-tests:
3531
3532 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3533
3534         Reviewed by Simon Hausmann.
3535
3536         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3537         https://bugs.webkit.org/show_bug.cgi?id=25037
3538
3539         * DumpRenderTree/qt/DumpRenderTree.cpp:
3540         (WebCore::WebPage::acceptNavigationRequest):
3541         * DumpRenderTree/qt/DumpRenderTree.pro:
3542         * DumpRenderTree/qt/jsobjects.cpp:
3543         (LayoutTestController::reset):
3544         (LayoutTestController::notifyDone):
3545         (LayoutTestController::waitForPolicyDelegate):
3546         * DumpRenderTree/qt/jsobjects.h:
3547         (LayoutTestController::waitForPolicy):
3548
3549 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3550
3551         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3552
3553         Reviewed by Eric Seidel.
3554
3555         The -o|--open switch uses the open(1) command on Mac OS X to
3556         open the bug URL in the default web browser.  If there are
3557         similar mechanisms on other platforms, they may be added later.
3558
3559         * Scripts/mark-bug-fixed:
3560         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3561         options.
3562         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3563         code into main() and extracted prompting code into
3564         _prompt_user_for_correctness().
3565         (MarkBugFixed._open_bug_in_web_browser): Added.
3566         (MarkBugFixed._prompt_user_for_correctness): Added.
3567         (MarkBugFixed.main): Added logging code from
3568         _determine_bug_id_and_svn_revision().  Added code to call
3569         _open_bug_in_web_browser() if the switch is set.  Added code to
3570         call _prompt_user_for_correctness() when needed.
3571         * Scripts/modules/bugzilla.py:
3572         (Bugzilla.short_bug_url_for_bug_id): Added.
3573
3574 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3575
3576         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3577
3578         <http://webkit.org/b/29744>
3579         <rdar://problem/7252905>
3580
3581         Reviewed by Eric Seidel.
3582
3583         Some users have a workflow where svn-create-patch, svn-apply and
3584         svn-unapply are used outside of multiple svn working
3585         directories.  Instead of aborting the scripts in these cases,
3586         print a warning and assume that Subversion is being used.
3587
3588         * Scripts/VCSUtils.pm:
3589         (determineVCSRoot): Call warn() instead of die() if both isGit()
3590         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3591         to enforce the assumption about Subversion, then return
3592         determineSVNRoot().
3593         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3594         VCSUtils.pm.  They both already cache their values and checking
3595         here is redundant since determineVCSRoot() is called later.
3596
3597 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3598
3599         Reviewed by Gustavo Noronha.
3600
3601         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3602         https://bugs.webkit.org/show_bug.cgi?id=29689
3603
3604         Load test fonts through FontConfig before each test.
3605         This ensures a more proper rendering of the tests.
3606
3607         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3608         (initializeFonts):
3609         (runTest):
3610         (main):
3611         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3612         * GNUmakefile.am:
3613
3614 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3615
3616         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3617
3618         Reviewed by Eric Seidel.
3619
3620         * Scripts/mark-bug-fixed:
3621         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3622         of parse options.
3623         (MarkBugFixed.main): When -u|--update-only is specified, add a
3624         comment to the bug without marking it Resolved/Fixed.
3625
3626 2009-09-25  Darin Adler  <darin@apple.com>
3627
3628         Reviewed by Geoffrey Garen.
3629
3630         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3631         out, just as we do for the resources directory.
3632
3633 2009-09-25  Adam Barth  <abarth@webkit.org>
3634
3635         Unreviewed.  Added Tony to committers.py because he's a
3636         committer now.
3637
3638         * Scripts/modules/committers.py:
3639
3640 2009-09-25  Eric Seidel  <eric@webkit.org>
3641
3642         Reviewed by Simon Fraser.
3643
3644         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3645         https://bugs.webkit.org/show_bug.cgi?id=28624
3646
3647         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3648
3649         * DumpRenderTree/mac/DumpRenderTree.mm:
3650         (resetDefaultsToConsistentValues):
3651
3652 2009-09-25  Eric Seidel  <eric@webkit.org>
3653
3654         Reviewed by Adam Barth.
3655
3656         commit-queue should auto-retry patches which fail to commit due to out of date files
3657         https://bugs.webkit.org/show_bug.cgi?id=28316
3658
3659         * Scripts/bugzilla-tool:
3660          - Handle new CheckoutNeedsUpdate exception.
3661         * Scripts/modules/logging_unittest.py:
3662          - Call the ScriptError constructor correctly (this test had regressed).
3663         * Scripts/modules/scm.py:
3664          - Added the ability to define custom error handlers for run_command
3665            and added a commit_error_handler which throws CheckoutNeedsUpdate
3666            instead of ScriptError.
3667          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3668         * Scripts/modules/scm_unittest.py:
3669          - Added tests of new error handlers.
3670
3671 2009-09-25  Eric Seidel  <eric@webkit.org>
3672
3673         Reviewed by Adam Barth.
3674
3675         commit-queue should give better feedback when failing a patch
3676         https://bugs.webkit.org/show_bug.cgi?id=29316
3677
3678         * Scripts/bugzilla-tool:
3679          - Update ScriptError uses to the new constructor format.
3680          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3681            so that we can print to both stdout as well as an output buffer for error reporting.
3682          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3683          - Use e.message_with_output() when failing a patch (this is the real fix here).
3684            I also removed use of "This patch will require manual commit." as that's not always true.
3685          - Add missing word "bug" from log message.
3686         * Scripts/modules/scm.py:
3687          - Make ScriptError save a bunch more data so that error messages can be nicer.
3688          - Update ScriptError callers.
3689
3690 2009-09-24  John Gregg  <johnnyg@google.com>
3691
3692         Reviewed by Eric Seidel.
3