[Qt] Split the build process in two different .pro files.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2
3         Reviewed by Simon Hausmann.
4
5         [Qt] Split the build process in two different .pro files.
6         This allows qmake to be run once all source files are available.
7
8         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
9
10 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
11
12         Unreviewed tiny typo fix in docstrings.
13
14         * Scripts/webkitpy/style/checker_unittest.py:
15
16 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
17
18         Reviewed by Shinichiro Hamaji.
19
20         Created a CategoryFilter class to encapsulate the logic of
21         filter rules.
22
23         https://bugs.webkit.org/show_bug.cgi?id=33454
24
25         * Scripts/webkitpy/style/checker.py:
26           - Added CategoryFilter class.
27
28         * Scripts/webkitpy/style/checker_unittest.py:
29           - Added CategoryFilter unit tests.
30
31         * Scripts/webkitpy/style/cpp_style.py:
32           - Updated filter methods to use CategoryFilter.
33
34         * Scripts/webkitpy/style/cpp_style_unittest.py:
35           - Updated references to filters.
36
37 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
38
39         Unreviewed. Now I can review :)
40
41         * Scripts/webkitpy/committers.py:
42
43 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
44
45         Reviewed by Darin Adler.
46
47         Extend WinLauncher example with better printing features.
48
49         * WinLauncher/PrintWebUIDelegate.cpp:
50         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
51          larger margins.
52         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
53          on text metrics.
54         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
55          on text metrics.
56         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
57          with separating line.
58         (PrintWebUIDelegate::drawFooterInRect):
59         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
60         * WinLauncher/WinLauncher.cpp:
61         (PrintView): Correct loop used to print individual pages.
62          Previously it started at 0, which is a wild-card to print all
63          pages at once.
64
65 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
66
67         Reviewed by Darin Adler.
68
69         https://bugs.webkit.org/show_bug.cgi?id=33540
70         Make it possible to build in debug mode with assertions disabled
71
72         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
73
74 2010-01-11  Darin Fisher  <darin@chromium.org>
75
76         Reviewed by Dimitri Glazkov.
77
78         [Chromium] "build-webkit --chromium" should run "make all" on Linux
79         https://bugs.webkit.org/show_bug.cgi?id=33500
80
81         * Scripts/webkitdirs.pm:
82
83 2010-01-12  Eric Seidel  <eric@webkit.org>
84
85         Reviewed by Adam Barth.
86
87         AssignToCommitter does not need to fetch bugs twice
88         https://bugs.webkit.org/show_bug.cgi?id=33530
89
90         This is a no-brainer patch now that we've added Bug.reviewed_patches
91
92         * Scripts/webkitpy/commands/upload.py:
93
94 2010-01-12  Eric Seidel  <eric@webkit.org>
95
96         Reviewed by Adam Barth.
97
98         bugzilla.py should have an Attachment object instead of passing around dictionaries
99         https://bugs.webkit.org/show_bug.cgi?id=31594
100
101         * Scripts/webkitpy/bugzilla.py:
102          - Add a new Attachment class, with accessor methods for all the necessary properties.
103          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
104          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
105          - Move committer validation logic into its own class.
106          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
107            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
108            the case where we want to reject patches in bugzilla.
109          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
110          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
111          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
112          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
113         * Scripts/webkitpy/bugzilla_unittest.py:
114          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
115         * Scripts/webkitpy/commands/download.py:
116          - Store "bug_id" in state instead of making a fake patch object.
117          - Update to use Attachment and Bug objects.
118         * Scripts/webkitpy/commands/download_unittest.py:
119          - Update expected results now that our testing framework covers more code.
120         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
121         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
122         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
123         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
124         * Scripts/webkitpy/commands/queuestest.py: ditto.
125         * Scripts/webkitpy/commands/upload.py: ditto.
126         * Scripts/webkitpy/mock_bugzillatool.py:
127          - Now that more logic has moved into Attachment and Bug, we have to actually
128            provide real reviewer emails as well as real reviewer flags.
129          - Update mock methods to return Attachment objects.
130         * Scripts/webkitpy/scm.py: Update to use Attachment class.
131         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
132         * Scripts/webkitpy/statusserver.py: ditto.
133         * Scripts/webkitpy/steps/applypatch.py: ditto.
134         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
135         * Scripts/webkitpy/steps/closebug.py: ditto.
136         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
137         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
138         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
139         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
140
141 2010-01-12  Adam Barth  <abarth@webkit.org>
142
143         Unreviewed typo fix.  :(
144
145         * Scripts/webkitpy/commands/early_warning_system.py:
146         * Scripts/webkitpy/commands/queues.py:
147
148 2010-01-12  Adam Barth  <abarth@webkit.org>
149
150         Unreviewed.  Add "error" to the right part of the message.
151
152         * Scripts/webkitpy/commands/queues.py:
153
154 2010-01-12  Adam Barth  <abarth@webkit.org>
155
156         Reviewed by Eric Seidel.
157
158         EWS should show purple when svn-apply fails
159         https://bugs.webkit.org/show_bug.cgi?id=33527
160
161         * Scripts/webkitpy/commands/early_warning_system.py:
162         * Scripts/webkitpy/commands/queues.py:
163
164 2010-01-12  Adam Barth  <abarth@webkit.org>
165
166         Reviewed by Eric Seidel.
167
168         Remove copy/paste code from subclasses of AbstractReviewQueue
169         https://bugs.webkit.org/show_bug.cgi?id=33525
170
171         * Scripts/webkitpy/commands/early_warning_system.py:
172         * Scripts/webkitpy/commands/queues.py:
173
174 2010-01-12  Adam Barth  <abarth@webkit.org>
175
176         Reviewed by Eric Seidel.
177
178         Add Gustavo and Xan as gtk-ews watchers
179         https://bugs.webkit.org/show_bug.cgi?id=33519
180
181         * Scripts/webkitpy/commands/early_warning_system.py:
182
183 2010-01-12  Adam Barth  <abarth@webkit.org>
184
185         Reviewed by Eric Seidel.
186
187         webkit-patch shouldn't waste my time for with a component prompt
188         https://bugs.webkit.org/show_bug.cgi?id=33521
189
190         The component field isn't very useful for bugs created with
191         webkit-patch because they're likely to be resolved quickly.  Instead of
192         always prompting for a component, we should just default to the "New
193         Bugs" component.  If the bug stays around for more than five minutes,
194         we can assign it a proper component.
195
196         * Scripts/webkitpy/bugzilla.py:
197
198 2010-01-12  Adam Barth  <abarth@webkit.org>
199
200         Reviewed by Eric Seidel.
201
202         Add experimental "land-safely" command to webkit-patch
203         https://bugs.webkit.org/show_bug.cgi?id=33518
204
205         * Scripts/webkitpy/commands/upload.py:
206         * Scripts/webkitpy/commands/upload_unittest.py:
207         * Scripts/webkitpy/steps/__init__.py:
208         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
209
210 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
211
212         [wx] Build fix after introduction of JS_NO_EXPORT
213         
214         * wx/build/settings.py:
215
216 2010-01-11  Eric Seidel  <eric@webkit.org>
217
218         No review, rolling out r53079.
219         http://trac.webkit.org/changeset/53079
220         https://bugs.webkit.org/show_bug.cgi?id=33197
221
222         Adam doens't think this actually works, and believe it caused
223         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
224         rolling this out.
225
226         * Scripts/test-webkitpy:
227         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
228         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
229         * Scripts/webkitpy/commands/download.py:
230         * Scripts/webkitpy/commands/upload.py:
231         * Scripts/webkitpy/mock_bugzillatool.py:
232
233 2010-01-10  Adam Barth  <abarth@webkit.org>
234
235         Reviewed by David Kilzer.
236
237         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
238         https://bugs.webkit.org/show_bug.cgi?id=33197
239
240         We should just search for bug numbers in the ChangeLogs instead of in
241         the whole diff.
242  
243         * Scripts/test-webkitpy:
244         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
245         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
246         * Scripts/webkitpy/commands/download.py:
247         * Scripts/webkitpy/commands/upload.py:
248         * Scripts/webkitpy/mock_bugzillatool.py:
249
250 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
251
252         Reviewed by David Kilzer.
253
254         Created a unit-tested function to parse the header block of
255         a Git or SVN diff -- for future refactoring of svn-apply and
256         svn-unapply.
257
258         https://bugs.webkit.org/show_bug.cgi?id=33447
259
260         * Scripts/VCSUtils.pm:
261           - Added parseDiffHeader().
262           - Removed irrelevant comment from gitdiff2svndiff().
263
264         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
265           - Added 48 unit tests for parseDiffHeader().
266
267 2010-01-10  Adam Barth  <abarth@webkit.org>
268
269         Rubber stamped by David Kilzer.
270
271         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
272         https://bugs.webkit.org/show_bug.cgi?id=33197
273
274         Fix a typo: Commmand -> Command.
275
276         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
277         * Scripts/webkitpy/commands/download.py:
278         * Scripts/webkitpy/commands/queries.py:
279         * Scripts/webkitpy/commands/upload.py:
280         * Scripts/webkitpy/multicommandtool.py:
281
282 2010-01-10  Adam Barth  <abarth@webkit.org>
283
284         Reviewed by Darin Adler.
285
286         Let webkit-patch work with options in $EDITOR
287         https://bugs.webkit.org/show_bug.cgi?id=33414
288
289         The $EDITOR evironment variable might have command line options like
290         bbedit -w.  This patch lets us run those $EDITORs.
291
292         * Scripts/webkitpy/user.py:
293
294 2010-01-10  Robert Hogan  <robert@roberthogan.net>
295
296         Reviewed by Adam Barth.
297
298         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
299
300         https://bugs.webkit.org/show_bug.cgi?id=33419
301
302         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
303         (WebCore::WebPage::WebPage):
304         (WebCore::WebPage::resetSettings):
305         (WebCore::DumpRenderTree::createWindow):
306         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
307         (LayoutTestController::setXSSAuditorEnabled):
308         * DumpRenderTree/qt/LayoutTestControllerQt.h:
309
310 2010-01-10  Adam Barth  <abarth@webkit.org>
311
312         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
313         because we don't have hardware for it at the moment.
314
315         * QueueStatusServer/templates/statusbubble.html:
316
317 2010-01-09  Daniel Bates  <dbates@webkit.org>
318
319         No review, rolling out r53044.
320         http://trac.webkit.org/changeset/53044
321         https://bugs.webkit.org/show_bug.cgi?id=33419
322         
323         We need to look into this some more because the Qt
324         bot is failing the XSSAuditor tests. See bug #33419
325         for more details.
326
327         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
328         (WebCore::WebPage::WebPage):
329         (WebCore::WebPage::resetSettings):
330         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
331         * DumpRenderTree/qt/LayoutTestControllerQt.h:
332
333 2010-01-09  Daniel Bates  <dbates@webkit.org>
334
335         Reviewed by Adam Barth.
336
337         https://bugs.webkit.org/show_bug.cgi?id=33419
338
339         Adds support for the XSSAuditor to the Qt DRT.
340
341         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
342         (WebCore::WebPage::WebPage):
343         (WebCore::WebPage::resetSettings):
344         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
345         (LayoutTestController::setXSSAuditorEnabled):
346         * DumpRenderTree/qt/LayoutTestControllerQt.h:
347
348 2010-01-09  Adam Barth  <abarth@webkit.org>
349
350         Reviewed by Eric Seidel.
351
352         Retry writes to QueueStatusServer when we get 500 errors
353         https://bugs.webkit.org/show_bug.cgi?id=33412
354
355         This prevents the queues from failing to mark a patch as "pass" or
356         "fail" when AppEngine throws 500 errors.
357
358         * Scripts/test-webkitpy:
359         * Scripts/webkitpy/networktransaction.py: Added.
360         * Scripts/webkitpy/networktransaction_unittest.py: Added.
361         * Scripts/webkitpy/statusserver.py:
362         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
363         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
364         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
365
366 2010-01-09  David Kilzer  <ddkilzer@apple.com>
367
368         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
369
370         Reviewed by Eric Seidel.
371
372         * QueueStatusServer/templates/statusbubble.html: Added
373         -moz-border-radius and -webkit-border-radius to provide rounded
374         borders in older Firefox and Safari browsers.
375
376 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
377
378         Reviewed by David Kilzer.
379
380         Modified VCSUtils::gitdiff2svndiff() to accept strings that
381         end in vertical white space.
382
383         https://bugs.webkit.org/show_bug.cgi?id=33415
384
385         * Scripts/VCSUtils.pm:
386         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
387
388 2010-01-08  Eric Seidel  <eric@webkit.org>
389
390         Reviewed by Adam Barth.
391
392         run-javascriptcore-tests needs a --quiet flag
393         https://bugs.webkit.org/show_bug.cgi?id=33399
394
395         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
396
397         * Scripts/webkitpy/steps/runtests.py:
398
399 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
400
401         Reviewed by Alexey Proskuryakov.
402
403         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
404
405         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
406         the time when Apache and WebSocketServer is locked by tests.
407         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
408         we need to run http and websocket tests after all other tests.
409         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
410         we need to preserve the given order.
411
412         * Scripts/run-webkit-tests:
413
414 2010-01-08  Adam Barth  <abarth@webkit.org>
415
416         Reviewed by Eric Seidel.
417
418         Don't post style-queue pass messages to bugs
419         https://bugs.webkit.org/show_bug.cgi?id=33404
420
421         These messages aren't needed any more now that we have the status
422         bubble reporting pass events passively.
423
424         * Scripts/webkitpy/commands/queues.py:
425
426 2010-01-08  Adam Barth  <abarth@webkit.org>
427
428         Reviewed by Eric Seidel.
429
430         Optimize the number of CPUs used for building Qt and Gtk
431         https://bugs.webkit.org/show_bug.cgi?id=33394
432
433         Instead of hardcoding the number 8, we should read the number of CPUs
434         from the environment.
435
436         * Scripts/webkitpy/executive.py:
437         * Scripts/webkitpy/webkitport.py:
438         * Scripts/webkitpy/webkitport_unittest.py:
439
440 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
441
442         Reviewed by Eric Seidel.
443
444         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
445         https://bugs.webkit.org/show_bug.cgi?id=33300
446
447         * DumpRenderTree/AccessibilityUIElement.h:
448         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
449         (AccessibilityUIElement::AccessibilityUIElement):
450         (AccessibilityUIElement::~AccessibilityUIElement):
451         (_accessibilityNotificationCallback):
452         (AccessibilityUIElement::addNotificationListener):
453
454 2010-01-08  Eric Seidel  <eric@webkit.org>
455
456         Reviewed by Simon Hausmann.
457
458         commit-queue should run run-javascriptcore-tests
459         https://bugs.webkit.org/show_bug.cgi?id=33376
460
461         I also made it run the python and perl unit tests.
462
463         * Scripts/webkitpy/steps/runtests.py:
464         * Scripts/webkitpy/webkitport.py:
465
466 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
467
468         Reviewed by Darin Adler.
469
470         Run the http and websocket tests after all other tests.
471         https://bugs.webkit.org/show_bug.cgi?id=33153
472
473         * Scripts/run-webkit-tests:
474
475 2010-01-07  Adam Barth  <abarth@webkit.org>
476
477         Reviewed by Eric Seidel.
478
479         Fix some test-webkitpy expectations
480         https://bugs.webkit.org/show_bug.cgi?id=33345
481
482         I forgot to change these when I added the CheckStyle step.
483
484         * Scripts/webkitpy/commands/upload_unittest.py:
485
486 2010-01-07  Adam Barth  <abarth@webkit.org>
487
488         Reviewed by Eric Seidel.
489
490         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
491         https://bugs.webkit.org/show_bug.cgi?id=33341
492
493         Fix this by moving to the root directory before editing ChangeLogs.
494         There is a related bug with CheckStyle.
495
496         * Scripts/webkitpy/steps/checkstyle.py:
497         * Scripts/webkitpy/steps/editchangelog.py:
498
499 2010-01-07  Eric Seidel  <eric@webkit.org>
500
501         Reviewed by Nikolas Zimmermann.
502
503         media/unsupported-tracks.html is failing on Snow Leopard Release bot
504         https://bugs.webkit.org/show_bug.cgi?id=32339
505
506         This is a speculative fix.  I do not have a Snow Leopard machine to test on
507         and I've not seen mention of someone being able to reproduce this locally.
508
509         Prevent watchdog timer from firing after a test completes but before
510         the next one starts, causing the error to appear in the next test.
511
512         * DumpRenderTree/mac/DumpRenderTree.mm:
513         (dump): Stop the watchdog before printing #EOF for the test content.
514         We only need to care about the JavaScript of the test running too long
515         or some hang in WebCore.  Any other failures will be covered by the calling
516         script's own watchdog timer.
517
518 2010-01-07  Eric Seidel  <eric@webkit.org>
519
520         Reviewed by Adam Barth.
521
522         commit-queue is stuck spinning due to exception
523         https://bugs.webkit.org/show_bug.cgi?id=33358
524
525         * Scripts/webkitpy/commands/queues.py:
526          - Don't try to stringify the exception.
527
528 2010-01-07  Mark Rowe  <mrowe@apple.com>
529
530         Reviewed by Jon Honeycutt.
531
532         Don't leak a JSStringRef within _accessibilityNotificationCallback.
533
534         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
535         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
536         when it goes out of scope.
537
538 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
539
540         Reviewed by Darin Adler.
541
542         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
543
544         * Scripts/do-webcore-rename:
545
546 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
547
548         Reviewed by Antti Koivisto.
549
550         Wrong state and TouchLists in TouchEvents
551         https://bugs.webkit.org/show_bug.cgi?id=32878
552
553         * DumpRenderTree/qt/EventSenderQt.cpp:
554         (EventSender::touchStart):
555         (EventSender::touchEnd):
556         (EventSender::clearTouchPoints):
557         * DumpRenderTree/qt/EventSenderQt.h:
558
559 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
560
561         Reviewed by Adam Barth.
562
563         Created a module that runs the style package unit tests.
564
565         https://bugs.webkit.org/show_bug.cgi?id=32973
566
567         * Scripts/test-webkitpy:
568         * Scripts/webkitpy/style/unittests.py: Added.
569
570 2010-01-07  Adam Barth  <abarth@webkit.org>
571
572         Reviewed by Maciej Stachowiak.
573
574         Don't print a redundant message when confirming a diff
575         https://bugs.webkit.org/show_bug.cgi?id=33315
576
577         Instead of saying "ERROR: User declined" we should just exit because
578         the use knows they just declined!
579
580         * Scripts/webkitpy/steps/confirmdiff.py:
581
582 2010-01-07  Adam Barth  <abarth@webkit.org>
583
584         Reviewed by Maciej Stachowiak.
585
586         Check style before uploading a patch
587         https://bugs.webkit.org/show_bug.cgi?id=33314
588
589         * Scripts/webkitpy/commands/upload.py:
590         * Scripts/webkitpy/steps/checkstyle.py:
591         * Scripts/webkitpy/steps/options.py:
592
593 2010-01-07  Adam Barth  <abarth@webkit.org>
594
595         Reviewed by Maciej Stachowiak.
596
597         Add prepare and post to webkit-patch main help
598         https://bugs.webkit.org/show_bug.cgi?id=33313
599
600         * Scripts/webkitpy/commands/upload.py:
601
602 2010-01-07  Eric Seidel  <eric@webkit.org>
603
604         Reviewed by Adam Barth.
605
606         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
607         https://bugs.webkit.org/show_bug.cgi?id=33290
608
609         Add the Chromium builders to our list of core builders and test that our regexps work.
610         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
611
612         * Scripts/webkitpy/buildbot.py:
613         * Scripts/webkitpy/buildbot_unittest.py:
614
615 2010-01-07  Adam Barth  <abarth@webkit.org>
616
617         Reviewed by Eric Seidel.
618
619         bugzilla-tool needs a new name
620         https://bugs.webkit.org/show_bug.cgi?id=28459
621
622         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
623         make more sense with the new name.
624
625         * Scripts/bugzilla-tool: Removed.
626         * Scripts/webkit-patch: Added.
627         * Scripts/webkit-tools-completion.sh:
628         * Scripts/webkitpy/bugzilla_unittest.py:
629         * Scripts/webkitpy/commands/download.py:
630         * Scripts/webkitpy/commands/download_unittest.py:
631         * Scripts/webkitpy/commands/early_warning_system.py:
632         * Scripts/webkitpy/commands/queries.py:
633         * Scripts/webkitpy/commands/queues.py:
634         * Scripts/webkitpy/commands/queues_unittest.py:
635         * Scripts/webkitpy/commands/upload.py:
636         * Scripts/webkitpy/commands/upload_unittest.py:
637         * Scripts/webkitpy/queueengine.py:
638         * Scripts/webkitpy/steps/completerollout.py:
639
640 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
641
642         Reviewed by Eric Seidel.
643
644         Moved style-related modules to webkitpy.style sub-package.
645
646         https://bugs.webkit.org/show_bug.cgi?id=32971
647
648         * Scripts/check-webkit-style:
649           - Updated import statement.
650
651         * Scripts/test-webkitpy:
652           - Updated import statements.
653
654         * Scripts/webkitpy/cpp_style.py: Removed.
655           - Moved to webkitpy/style.
656
657         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
658           - Moved to webkitpy/style.
659
660         * Scripts/webkitpy/style.py: Removed.
661           - Moved to webkitpy/style/checker.py.
662
663         * Scripts/webkitpy/style/__init__.py: Added.
664           - Added containing webkitpy directory to package search path.
665
666         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
667         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
668           - Updated import statement.
669
670         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
671         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
672           - Update import statement.
673
674         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
675         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
676         * Scripts/webkitpy/style_unittest.py: Removed.
677           - Moved to webkitpy/style/checker_unittest.py.
678
679         * Scripts/webkitpy/text_style.py: Removed.
680           - Moved to webkitpy/style.
681
682         * Scripts/webkitpy/text_style_unittest.py: Removed.
683           - Moved to webkitpy/style.
684
685 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
686
687         Reviewed by Eric Seidel.
688
689         [Qt] Support the 3rd argument of EventSender.keyDown that
690         has been recently added to report keyLocation
691         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
692         https://bugs.webkit.org/show_bug.cgi?id=33250
693
694         Test: fast/events/keydown-numpad-keys.html
695
696         * DumpRenderTree/qt/EventSenderQt.cpp:
697         (EventSender::keyDown):
698         * DumpRenderTree/qt/EventSenderQt.h:
699
700 2010-01-06  Eric Seidel  <eric@webkit.org>
701
702         Reviewed by Adam Barth.
703
704         Add long_help for all common commands.
705         https://bugs.webkit.org/show_bug.cgi?id=33261
706
707         For now these long_helps are pretty basic.
708         These were all written to just explain the steps
709         that each command runs.  This style long_help could
710         be made easier by using:
711         https://bugs.webkit.org/show_bug.cgi?id=33257
712
713         * Scripts/webkitpy/commands/download.py:
714         * Scripts/webkitpy/commands/queries.py:
715
716 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
717
718         Reviewed by Kenneth Christiansen.
719
720         [Qt] Add page zooming support to Qt DumpRenderTree
721         https://bugs.webkit.org/show_bug.cgi?id=32898
722
723         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
724                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
725                  Afonso Costa <afonso.costa@openbossa.org>
726
727         * DumpRenderTree/qt/EventSenderQt.cpp:
728         (EventSender::zoomPageIn):
729         (EventSender::zoomPageOut):
730         * DumpRenderTree/qt/EventSenderQt.h:
731
732 2010-01-06  Eric Seidel  <eric@webkit.org>
733
734         No review, just adding Mike Belshe's new bugzilla email at his request.
735
736         * Scripts/webkitpy/committers.py:
737
738 2010-01-06  Eric Seidel  <eric@webkit.org>
739
740         Unreviewed.  Rolling out r52869 and r52853 due to bot
741         and local run-webkit-test failures
742
743         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
744         https://bugs.webkit.org/show_bug.cgi?id=33256
745
746         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
747
748         * Scripts/run-webkit-tests:
749
750 2010-01-06  Eric Seidel  <eric@webkit.org>
751
752         Unreviewed "build" fix.  Just adding missing include.
753
754         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
755         https://bugs.webkit.org/show_bug.cgi?id=29212
756
757         * Scripts/webkitpy/steps/completerollout.py:
758
759 2010-01-06  Eric Seidel  <eric@webkit.org>
760
761         Reviewed by Adam Barth.
762
763         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
764         https://bugs.webkit.org/show_bug.cgi?id=29212
765
766         * Scripts/webkitpy/bugzilla.py:
767          - Make reopen_bug robust against the bug already being open.
768         * Scripts/webkitpy/commands/download.py:
769          - Remove dead code from Rollout.
770         * Scripts/webkitpy/steps/completerollout.py:
771          - Improve the rollout comment.
772
773 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
774
775         Reviewed by Darin Adler.
776
777         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
778         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
779
780         * Scripts/run-webkit-tests:
781
782 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
783
784         Reviewed by Darin Adler.
785
786         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
787         and remove the httpd's pidfile directory if httpd terminated.
788
789         * Scripts/run-webkit-tests:
790
791 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
792
793         Reviewed by David Levin.
794
795         Refactored check-webkit-style's argument parser to not rely
796         on global state, and improved its error handling and unit
797         test coverage.
798
799         https://bugs.webkit.org/show_bug.cgi?id=32966
800
801         * Scripts/check-webkit-style:
802           - Adjusted to use new argument parser.
803
804         * Scripts/webkitpy/cpp_style.py:
805           - Changed _CppStyleState to accept an array of filter rules
806             instead of a comma-delimited string.
807           - Eliminated cpp_style._DEFAULT_FILTER_RULES.
808           - Eliminated cpp_style._USAGE.
809
810         * Scripts/webkitpy/cpp_style_unittest.py:
811           - Updated test_filter() and test_default_filter().
812
813         * Scripts/webkitpy/style.py:
814           - Converted style._USAGE to create_usage().
815           - Corrected usage instructions by removing 0 as a valid
816             --verbose flag value.
817           - Removed use_webkit_styles().
818           - Added ProcessorOptions class.
819           - Added ArgumentDefaults class.
820           - Added ArgumentPrinter class.
821           - Removed parse_arguments and added ArgumentParser class.
822           - Moved exit_with_usage() and exit_with_categories() into
823             ArgumentParser.
824           - Refactored parse_arguments() as ArgumentParser.parse().
825           - Improved parser error handling.
826
827         * Scripts/webkitpy/style_unittest.py:
828           - Added DefaultArgumentsTest class.
829           - Addressed FIXME to check style.WEBKIT_FILTER_RULES
830             against style.STYLE_CATEGORIES.
831           - Added ArgumentPrinterTest class.
832           - Added ArgumentParserTest class and rewrote parser unit tests.
833
834 2010-01-05  Adam Roben  <aroben@apple.com>
835
836         Test that it's safe to call IWebView::close when
837         IWebView::initWithFrame hasn't been called
838
839         Part of <http://webkit.org/b/32827> Crash when calling
840         IWebView::close, then releasing the WebView, without calling
841         DestroyWindow
842
843         Reviewed by Steve Falkenburg.
844
845         * WebKitAPITest/tests/WebViewDestruction.cpp:
846         (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
847         without ever calling IWebView::initWithFrame and tests that we don't
848         crash or leak.
849
850 2010-01-05  Adam Roben  <aroben@apple.com>
851
852         Add more WebViewDestruction tests
853
854         Fixes <http://webkit.org/b/33216>.
855
856         Reviewed by Eric Seidel.
857
858         * WebKitAPITest/tests/WebViewDestruction.cpp:
859         (WebKitAPITest::NoInitWithFrame):
860         (WebKitAPITest::CloseThenDestroyViewWindow):
861         (WebKitAPITest::DestroyViewWindowThenClose):
862         (WebKitAPITest::DestroyHostWindow):
863         (WebKitAPITest::DestroyHostWindowThenClose):
864         (WebKitAPITest::CloseThenDestroyHostWindow):
865         Added these tests that exercise tearing down a WebView in various
866         ways, all of which we eventually want to have work. Some of them
867         currently crash or leak.
868
869 2010-01-05  Robert Hogan  <robert@roberthogan.net>
870
871         Reviewed by Eric Seidel.
872
873         [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
874         
875         If you're working from a --minimal or --no-svg build and make changes to the
876         DRT, then recompile, the build will fail.
877         
878         This is because the current behavior at build time is to assume that the
879         previous Qt build supported SVG and consequently delete libQtWebKit.so.
880         Unfortunately, just deleting libQtWebKit.so will not cause the library to
881         re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
882         linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
883         results in a link failure on the DRT.
884         
885         Since re-linking libQtWebKit can take up to ten minutes and should be avoided
886         in cases where not actually required, remove the assumption that
887         the previous Qt build supported SVG, and amend the symbol detection to look for
888         a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
889         for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
890         
891         https://bugs.webkit.org/show_bug.cgi?id=32992
892
893         * Scripts/webkitdirs.pm:
894
895 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
896
897         Reviewed by David Kilzer.
898
899         Switched to generating list of Perl unit test files dynamically,
900         instead of explicitly.
901
902         https://bugs.webkit.org/show_bug.cgi?id=33200
903
904         * Scripts/test-webkitperl:
905
906 2010-01-05  Yael Aharon  <yael.aharon@nokia.com>
907
908         Reviewed by Kenneth Rohde Christiansen.
909
910         [Qt] Reimplement EventSender::leapForward
911         https://bugs.webkit.org/show_bug.cgi?id=33114
912
913         Follow Windows implementation of leapForward. When leapForward is called, 
914         messages are queued and posted after the timeout. A new event loop is created to
915         handle those messages and the additional messages that are created as a result.
916
917         * DumpRenderTree/qt/DumpRenderTree.pro:
918         * DumpRenderTree/qt/EventSenderQt.cpp:
919         (EventSender::EventSender):
920         (EventSender::mouseDown):
921         (EventSender::mouseUp):
922         (EventSender::mouseMoveTo):
923         (EventSender::leapForward):
924         (EventSender::sendOrQueueEvent):
925         (EventSender::replaySavedEvents):
926         (EventSender::eventFilter):
927         * DumpRenderTree/qt/EventSenderQt.h:
928
929 2010-01-05  Adam Barth  <abarth@webkit.org>
930
931         Reviewed by Darin Adler.
932
933         Fix obscure queue crash in queueengine
934         https://bugs.webkit.org/show_bug.cgi?id=33196
935
936         Sometimes we get an exception that can't be stringified.  For example:
937
938         AttributeError: 'ParseError' object has no attribute 'msg'
939
940         In these cases, the whole queue dies because we're in the global
941         exception handler.  Instead of dieing here, we should just print a less
942         informative message to the console.  We're already printing the whole
943         backtrace anyway, so there's not much point to stringifying the
944         exception anyway.
945
946         * Scripts/webkitpy/queueengine.py:
947
948 2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>
949
950         Reviewed by Darin Adler.
951
952         https://bugs.webkit.org/show_bug.cgi?id=32571
953
954         For an object with an aria role of "checkbox" or "radiobutton",
955         use the "aria-checked" attribute to determine if it's checked.
956         These changes add an isChecked() method to AccessibilityUIElement
957         so that we can check for this property from a layout test.
958
959         * DumpRenderTree/AccessibilityUIElement.cpp:
960         (getIsCheckedCallback):
961         (AccessibilityUIElement::getJSClass):
962         * DumpRenderTree/AccessibilityUIElement.h:
963         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
964         (AccessibilityUIElement::isChecked):
965         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
966         (AccessibilityUIElement::isChecked):
967         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
968         (AccessibilityUIElement::isChecked):
969
970 2010-01-05  David Levin  <levin@chromium.org>
971
972         Reviewed by Darin Adler.
973
974         Having a comment for the #endif for a header guard is not required WebKit style.
975         https://bugs.webkit.org/show_bug.cgi?id=33214
976
977         * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
978           early when it has all the needed information to continue.
979         * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
980
981 2010-01-05  Adam Roben  <aroben@apple.com>
982
983         Share more code in the WebViewDestruction tests
984
985         Part of <http://webkit.org/b/33212> Small fixes/improvements to
986         WebKitAPITest
987
988         Reviewed by Sam Weinig.
989
990         * WebKitAPITest/tests/WebViewDestruction.cpp:
991         (WebKitAPITest::createAndInitializeWebView): Renamed from
992         createWebView. Now initializes the HostWindow and returns the
993         WebView's HWND via an out-parameter.
994         (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
995         the CloseWithoutDestroyWindow test.
996         (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
997         CloseWithoutDestroyWindow and changed to use the new functions.
998         (WebKitAPITest::MainFrameAfterClose): Changed to use the new
999         functions.
1000         (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
1001         NoCloseOrDestroyWindow and changed to use the new functions.
1002
1003 2010-01-05  Adam Roben  <aroben@apple.com>
1004
1005         Don't show HostWindows by default
1006
1007         This was making WebKitAPITest very flashy as windows appeared and
1008         disappeared.
1009
1010         Part of <http://webkit.org/b/33212> Small fixes/improvements to
1011         WebKitAPITest
1012
1013         Reviewed by Sam Weinig.
1014
1015         * WebKitAPITest/HostWindow.cpp:
1016         (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
1017         from the window.
1018
1019 2010-01-05  Adam Roben  <aroben@apple.com>
1020
1021         Don't hang in WebKitAPITest if no messages have been posted
1022
1023         Part of <http://webkit.org/b/33212> Small fixes/improvements to
1024         WebKitAPITest
1025
1026         Reviewed by Sam Weinig.
1027
1028         * WebKitAPITest/tests/WebViewDestruction.cpp:
1029         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
1030         to avoid hanging if no messages have been posted.
1031
1032 2010-01-05  Adam Roben  <aroben@apple.com>
1033
1034         Fix WebKitCreateInstance helper
1035
1036         Part of <http://webkit.org/b/33212> Small fixes/improvements to
1037         WebKitAPITest
1038
1039         Reviewed by Sam Weinig.
1040
1041         * WebKitAPITest/tests/WebViewDestruction.cpp:
1042         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
1043         through, instead of taking its address.
1044
1045 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
1046
1047         Reviewed by Darin Fisher.
1048
1049         Reorganize, document and rename OS() platform macros.
1050         https://bugs.webkit.org/show_bug.cgi?id=33198
1051
1052         Adapt to name changes.
1053         
1054         * DumpRenderTree/DumpRenderTree.h:
1055         * DumpRenderTree/config.h:
1056
1057 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
1058
1059         Reviewed by Eric Seidel.
1060
1061         Minor improvements to test-webkit-scripts, as suggested
1062         by an earlier review.
1063
1064         https://bugs.webkit.org/show_bug.cgi?id=33125
1065
1066         * Scripts/test-webkit-scripts:
1067           - Used OptionParser class instead of getopt.getopt().
1068           - Created main() method for __main__ block.
1069           - Enclosed functions in a class.
1070
1071 2010-01-05  Chris Fleizach  <cfleizach@apple.com>
1072
1073         No review. Fix DRT breakage on Tiger/Leopard.
1074
1075         Add ARIA "Live Region" support
1076         https://bugs.webkit.org/show_bug.cgi?id=33117
1077
1078         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1079
1080 2010-01-04  Chris Fleizach  <cfleizach@apple.com>
1081
1082         Reviewed by Darin Adler.
1083
1084         Add ARIA "Live Region" support
1085         https://bugs.webkit.org/show_bug.cgi?id=33117
1086
1087         * DumpRenderTree/AccessibilityUIElement.cpp:
1088         (indexOfChildCallback):
1089         (boolAttributeValueCallback):
1090         (stringAttributeValueCallback):
1091         (addNotificationListenerCallback):
1092         (AccessibilityUIElement::getJSClass):
1093         * DumpRenderTree/AccessibilityUIElement.h:
1094         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1095         (AccessibilityUIElement::indexOfChild):
1096         (AccessibilityUIElement::stringAttributeValue):
1097         (AccessibilityUIElement::boolAttributeValue):
1098         (AccessibilityUIElement::addNotificationListener):
1099         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1100         (AccessibilityUIElement::indexOfChild):
1101         (AccessibilityUIElement::stringAttributeValue):
1102         (AccessibilityUIElement::boolAttributeValue):
1103         (_accessibilityNotificationCallback):
1104         (AccessibilityUIElement::addNotificationListener):
1105         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1106         (AccessibilityUIElement::indexOfChild):
1107         (AccessibilityUIElement::stringAttributeValue):
1108         (AccessibilityUIElement::boolAttributeValue):
1109         (AccessibilityUIElement::addNotificationListener):
1110
1111 2010-01-04  Eric Seidel  <eric@webkit.org>
1112
1113         Reviewed by Adam Barth.
1114
1115         bugzilla-tool rollout should require a reason
1116         https://bugs.webkit.org/show_bug.cgi?id=30810
1117
1118         * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
1119         * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
1120         * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
1121         * Scripts/webkitpy/commands/download_unittest.py: pass required reason
1122         * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
1123
1124 2010-01-04  Jon Honeycutt  <jhoneycutt@apple.com>
1125
1126         MSAA: <select> elements should broadcast value change events
1127
1128         https://bugs.webkit.org/show_bug.cgi?id=33088
1129
1130         <rdar://problem/7332364>
1131
1132         Reviewed by Darin Adler.
1133
1134         * DumpRenderTree/AccessibilityController.cpp:
1135         (logValueChangeEventsCallback):
1136         Start logging value change events.
1137         (AccessibilityController::getJSClass):
1138         Add a "logValueChangeEvents" to the AccessibilityController's JS class
1139         definition.
1140         (AccessibilityController::resetToConsistentState):
1141         Disable logging of value change events.
1142
1143         * DumpRenderTree/AccessibilityController.h:
1144         Declare setLogValueChangeEvents(), and add a member variable for the
1145         value change event hook.
1146
1147         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1148         (AccessibilityController::setLogValueChangeEvents):
1149         Stubbed.
1150
1151         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1152         (AccessibilityController::setLogValueChangeEvents):
1153         Stubbed.
1154
1155         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1156         (AccessibilityController::AccessibilityController):
1157         Initialize new member var.
1158         (AccessibilityController::~AccessibilityController):
1159         Disable logging of value change events.
1160         (logEventProc):
1161         When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
1162         and its value.
1163         (AccessibilityController::setLogValueChangeEvents):
1164         If disabling logging, unhook the event, and clear the event hook
1165         member var. Otherwise, query for the root element to enable
1166         accessibility, and hook EVENT_OBJECT_VALUECHANGE.
1167
1168 2010-01-04  Adam Barth  <abarth@webkit.org>
1169
1170         Reviewed by Eric Seidel.
1171
1172         long_help for submit-patch
1173         https://bugs.webkit.org/show_bug.cgi?id=33184
1174
1175         * Scripts/webkitpy/commands/upload.py:
1176
1177 2010-01-04  Adam Barth  <abarth@webkit.org>
1178
1179         Reviewed by Eric Seidel.
1180
1181         commit-queue can wrongly reject patches if the buildbots are behind
1182         https://bugs.webkit.org/show_bug.cgi?id=30098
1183
1184         Check to make sure we can currently build and test before trying to
1185         land a patch.
1186
1187         * Scripts/webkitpy/commands/queues.py:
1188
1189 2010-01-04  Adam Roben  <aroben@apple.com>
1190
1191         Add a test harness for the Windows WebKit API, and a few tests
1192
1193         We currently only have tests for a handful of bugs regarding WebView
1194         destruction, but more tests can easily be added later. Eventually
1195         we'll run these tests as part of run-webkit-tests.
1196
1197         Fixes <http://webkit.org/b/33167>.
1198
1199         Reviewed by Sam Weinig.
1200
1201         * WebKitAPITest/HostWindow.cpp: Added.
1202         (WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
1203         (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
1204         needed.
1205         (WebKitAPITest::HostWindow::initialize): Create our window.
1206         (WebKitAPITest::HostWindow::clientRect): Return our window's client
1207         rect.
1208         (WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
1209         (WebKitAPITest::HostWindow::wndProc): Just call through to
1210         DefWindowProcW.
1211
1212         * WebKitAPITest/HostWindow.h: Added.
1213         (WebKitAPITest::HostWindow::window): Simple getter.
1214
1215         * WebKitAPITest/Test.h: Added. This file defines some macros useful
1216         for writing tests.
1217
1218         * WebKitAPITest/TestsController.cpp: Added.
1219         (WebKitAPITest::TestsController::TestsController): Initialize our
1220         members.
1221         (WebKitAPITest::TestsController::shared): Return the shared instance.
1222         (WebKitAPITest::TestsController::runAllTests): Run a message pump
1223         until a WM_QUIT message is received, then return whether all tests
1224         succeeded.
1225         (WebKitAPITest::TestsController::addTest): Add the test to m_tests and
1226         start running tests soon.
1227         (WebKitAPITest::TestsController::testFailed): Record the failure and
1228         print a message about it to stdout.
1229         (WebKitAPITest::TestsController::runNextTest): If we don't have any
1230         tests to run, post a WM_QUIT message to stop the message pump.
1231         Otherwise, run the test and print whether it passed, then schedule the
1232         next test.
1233         (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
1234         to run the next test.
1235         (WebKitAPITest::TestsController::registerWindowClass): Does what it
1236         says.
1237         (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
1238         fired, call runNextTest(). Pass everything else through to
1239         DefWindowProcW.
1240
1241         * WebKitAPITest/TestsController.h: Added.
1242
1243         * WebKitAPITest/WebKitAPITest.vcproj: Added.
1244
1245         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
1246
1247         * WebKitAPITest/main.cpp: Added.
1248         (main): (Mostly) just calls TestsController::runAllTests.
1249
1250         * WebKitAPITest/tests/WebViewDestruction.cpp: Added.
1251         (WebKitAPITest::WebKitCreateInstance): Helper function template to
1252         call through to the real WebKitCreateInstance.
1253         (WebKitAPITest::webViewCount): Helper function to call through to
1254         IWebKitStatistics::webViewCount.
1255         (WebKitAPITest::createWebView): Helper function to create a WebView
1256         and put it inside a HostWindow.
1257         (WebKitAPITest::runMessagePump): Helper function to run a message pump
1258         for a specified number of milliseconds, or until a WM_QUIT message is
1259         received.
1260         (WebKitAPITest::CloseWithoutDestroyWindow): Test for
1261         <http://webkit.org/b/32827>.
1262         (WebKitAPITest::MainFrameAfterClose): Test for
1263         <http://webkit.org/b/32868>.
1264         (WebKitAPITest::NoCloseOrDestroyWindow): Test for
1265         <http://webkit.org/b/33162>.
1266
1267 2010-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1268
1269         Reviewed by David Kilzer.
1270
1271         Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
1272
1273         https://bugs.webkit.org/show_bug.cgi?id=32820
1274
1275         * Scripts/VCSUtils.pm:
1276         * Scripts/svn-apply:
1277         * Scripts/svn-unapply:
1278         * Scripts/test-webkitperl: Run gitdiff2svndiff test
1279         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
1280         * Scripts/webkitpy/diff_parser.py:
1281         * Scripts/webkitpy/diff_parser_unittest.py:
1282
1283 2010-01-04  Chris Jerdonek  <chris.jerdonek@gmail.com>
1284
1285         Reviewed by David Kilzer.
1286
1287         Divided the Perl unit tests into separate files and put
1288         them in a separate directory, and renamed test-webkit-perl
1289         to test-webkitperl.
1290
1291         https://bugs.webkit.org/show_bug.cgi?id=33124
1292
1293         * Scripts/VCSUtils.pm:
1294           - Renamed generateRunPatchCommand() to generatePatchCommand().
1295
1296         * Scripts/VCSUtils_unittest.pl: Removed.
1297           - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
1298
1299         * Scripts/test-webkit-perl: Removed.
1300           - Renamed to test-webkitperl.
1301
1302         * Scripts/test-webkit-scripts:
1303           - Updated paths to test-webkitpy and test-webkitperl.
1304
1305         * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
1306           - Added paths to new test files.
1307
1308         * Scripts/webkitperl: Added.
1309         * Scripts/webkitperl/VCSUtils_unittest: Added.
1310         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
1311         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
1312         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
1313
1314 2010-01-04  Eric Seidel  <eric@webkit.org>
1315
1316         Reviewed by Adam Barth.
1317
1318         Make bugzilla-tool rollout include a bug link in the ChangeLog entry
1319         https://bugs.webkit.org/show_bug.cgi?id=33146
1320
1321         One more step towards better rollouts.
1322
1323         * Scripts/webkitpy/changelogs.py:
1324         * Scripts/webkitpy/changelogs_unittest.py:
1325         * Scripts/webkitpy/steps/preparechangelogforrevert.py:
1326
1327 2010-01-04  Adam Barth  <abarth@webkit.org>
1328
1329         Reviewed by Eric Seidel.
1330
1331         Sort the step options
1332         https://bugs.webkit.org/show_bug.cgi?id=33144
1333
1334         * Scripts/webkitpy/steps/options.py:
1335
1336 2010-01-04  Eric Seidel  <eric@webkit.org>
1337
1338         Reviewed by Adam Barth.
1339
1340         Need support for longer text in per-command help
1341         https://bugs.webkit.org/show_bug.cgi?id=33143
1342
1343         Add some minimal additional help to land-diff and
1344         pave the way for adding better help to all commands.
1345
1346         * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
1347         * Scripts/webkitpy/multicommandtool.py: support long_help
1348         * Scripts/webkitpy/multicommandtool_unittest.py: test long_help
1349
1350 2010-01-04  Adam Barth  <abarth@webkit.org>
1351
1352         Reviewed by Eric Seidel.
1353
1354         Add unit test for MarkBugFixed
1355         https://bugs.webkit.org/show_bug.cgi?id=33142
1356
1357         MarkBugFixed is way behind in command technology, but it still needs a
1358         unit test, as the FIXME commands.
1359
1360         Also, remove mark-bug-fixed and create-bug from main help since we have
1361         more modern commands to replace them.
1362
1363         * Scripts/webkitpy/commands/upload.py:
1364         * Scripts/webkitpy/commands/upload_unittest.py:
1365         * Scripts/webkitpy/mock_bugzillatool.py:
1366
1367 2010-01-04  Adam Barth  <abarth@webkit.org>
1368
1369         Reviewed by Eric Seidel.
1370
1371         Add missing unit test for CommitMessageForCurrentDiff
1372         https://bugs.webkit.org/show_bug.cgi?id=33141
1373
1374         * Scripts/webkitpy/commands/upload.py:
1375         * Scripts/webkitpy/commands/upload_unittest.py:
1376
1377 2010-01-04  Adam Barth  <abarth@webkit.org>
1378
1379         Reviewed by Eric Seidel.
1380
1381         Remove raw_input from queues in favor of user.prompt
1382         https://bugs.webkit.org/show_bug.cgi?id=33140
1383
1384         This lets up properly mock out the user interaction instead of hacking
1385         around it with the options.
1386
1387         * Scripts/webkitpy/commands/queues.py:
1388         * Scripts/webkitpy/commands/queuestest.py:
1389
1390 2010-01-04  Eric Seidel  <eric@webkit.org>
1391
1392         Reviewed by Adam Barth.
1393
1394         bugzilla-tool should not require users to install mechanize
1395         https://bugs.webkit.org/show_bug.cgi?id=32635
1396
1397         * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires).
1398
1399 2010-01-04  Eric Seidel  <eric@webkit.org>
1400
1401         Reviewed by Adam Barth.
1402
1403         bugzilla-tool should not require users to install mechanize
1404         https://bugs.webkit.org/show_bug.cgi?id=32635
1405
1406         Use the nifty "autoinstall" module from Daniel Krech:
1407         http://pypi.python.org/pypi/autoinstall/0.2
1408         http://code.google.com/p/pyautoinstall/
1409         It's available under a WebKit-compatible BSD license.
1410
1411         * Scripts/webkitpy/__init__.py:
1412          - bind "mechanize" to an autoinstall importer which will
1413            auto-download mechanize if necessary.
1414         * Scripts/webkitpy/autoinstall.py: Added.
1415         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
1416         * Scripts/webkitpy/statusbot.py: ditto.
1417         * Scripts/webkitpy/webkit_mechanize.py: Removed.
1418
1419 2010-01-04  Adam Barth  <abarth@webkit.org>
1420
1421         Reviewed by Eric Seidel.
1422
1423         [bzt] Move AbstractSequencedCommand to a more general location
1424         https://bugs.webkit.org/show_bug.cgi?id=33137
1425
1426         I do what the FIXME tell me to do.
1427
1428         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
1429         * Scripts/webkitpy/commands/download.py:
1430         * Scripts/webkitpy/commands/upload.py:
1431
1432 2010-01-04  Adam Barth  <abarth@webkit.org>
1433
1434         Reviewed by Eric Seidel.
1435
1436         Rename StatusBot to StatusServer
1437         https://bugs.webkit.org/show_bug.cgi?id=33139
1438
1439         It's not a bot.  It's a server.
1440
1441         * Scripts/bugzilla-tool:
1442         * Scripts/webkitpy/bugzilla.py:
1443         * Scripts/webkitpy/commands/early_warning_system.py:
1444         * Scripts/webkitpy/commands/queues.py:
1445         * Scripts/webkitpy/mock_bugzillatool.py:
1446         * Scripts/webkitpy/queueengine.py:
1447         * Scripts/webkitpy/statusbot.py: Removed.
1448
1449 2010-01-04  Adam Barth  <abarth@webkit.org>
1450
1451         Reviewed by Eric Seidel.
1452
1453         [bzt] submit-pach should have a -o/--open option to open the bug after submit
1454         https://bugs.webkit.org/show_bug.cgi?id=33136
1455
1456         Python makes this very easy.
1457
1458         * Scripts/webkitpy/mock_bugzillatool.py:
1459         * Scripts/webkitpy/steps/options.py:
1460         * Scripts/webkitpy/steps/postdiff.py:
1461         * Scripts/webkitpy/user.py:
1462
1463 2010-01-04  Adam Barth  <abarth@webkit.org>
1464
1465         Reviewed by Eric Seidel.
1466
1467         [bzt] Move steps to a submodule
1468         https://bugs.webkit.org/show_bug.cgi?id=33135
1469
1470         For great victory.  This will probably introduce some regressions
1471         because our test coverage isn't perfect, but I've tried to be careful.
1472
1473         * Scripts/test-webkitpy:
1474         * Scripts/webkitpy/buildsteps.py: Removed.
1475         * Scripts/webkitpy/buildsteps_unittest.py: Removed.
1476         * Scripts/webkitpy/commands/download.py:
1477         * Scripts/webkitpy/commands/upload.py:
1478         * Scripts/webkitpy/steps/__init__.py: Added.
1479         * Scripts/webkitpy/steps/abstractstep.py: Added.
1480         * Scripts/webkitpy/steps/applypatch.py: Added.
1481         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
1482         * Scripts/webkitpy/steps/build.py: Added.
1483         * Scripts/webkitpy/steps/checkstyle.py: Added.
1484         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
1485         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
1486         * Scripts/webkitpy/steps/closebug.py: Added.
1487         * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
1488         * Scripts/webkitpy/steps/closepatch.py: Added.
1489         * Scripts/webkitpy/steps/commit.py: Added.
1490         * Scripts/webkitpy/steps/completerollout.py: Added.
1491         * Scripts/webkitpy/steps/confirmdiff.py: Added.
1492         * Scripts/webkitpy/steps/createbug.py: Added.
1493         * Scripts/webkitpy/steps/editchangelog.py: Added.
1494         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
1495         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
1496         * Scripts/webkitpy/steps/metastep.py: Added.
1497         * Scripts/webkitpy/steps/obsoletepatches.py: Added.
1498         * Scripts/webkitpy/steps/options.py: Added.
1499         * Scripts/webkitpy/steps/postdiff.py: Added.
1500         * Scripts/webkitpy/steps/preparechangelog.py: Added.
1501         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
1502         * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
1503         * Scripts/webkitpy/steps/revertrevision.py: Added.
1504         * Scripts/webkitpy/steps/runtests.py: Added.
1505         * Scripts/webkitpy/steps/steps_unittest.py: Added.
1506         * Scripts/webkitpy/steps/update.py: Added.
1507         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
1508         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
1509         * Scripts/webkitpy/stepsequence.py:
1510
1511 2010-01-04  Daniel Bates  <dbates@webkit.org>
1512
1513         Reviewed by Eric Seidel.
1514
1515         https://bugs.webkit.org/show_bug.cgi?id=33097
1516
1517         Cleans up the File menu to better conform to the File menu in Safari
1518         both in terms of options and keyboard shortcuts. Adds a "Quit" menu
1519         options to close all open windows. Also, renames the Tools menu to
1520         Develop.
1521
1522         * QtLauncher/main.cpp:
1523         (MainWindow::setupUI):
1524
1525 2010-01-04  Daniel Bates  <dbates@webkit.org>
1526
1527         https://bugs.webkit.org/show_bug.cgi?id=33039
1528         
1529         Unreviewed fix.
1530
1531         * Scripts/webkitpy/credentials.py:
1532         * Scripts/webkitpy/credentials_unittest.py:
1533
1534 2010-01-04  Daniel Bates  <dbates@webkit.org>
1535
1536         Reviewed by Eric Seidel.
1537
1538         https://bugs.webkit.org/show_bug.cgi?id=33039
1539
1540         [bzt] Second attempt to fix an issue where bugzilla-tool dies
1541         when the keychain lookup fails to find an entry for bugs.webkit.org.
1542
1543         * Scripts/webkitpy/credentials.py:
1544         * Scripts/webkitpy/credentials_unittest.py:
1545
1546 2010-01-04  Eric Seidel  <eric@webkit.org>
1547
1548         Reviewed by Adam Barth.
1549
1550         Make Rollout an AbstractSequencedCommmand
1551         https://bugs.webkit.org/show_bug.cgi?id=33133
1552
1553         As suggested by Adam in:
1554         https://bugs.webkit.org/show_bug.cgi?id=33131#c2
1555
1556         * Scripts/webkitpy/commands/download.py:
1557
1558 2010-01-04  Eric Seidel  <eric@webkit.org>
1559
1560         Reviewed by Adam Barth.
1561
1562         Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
1563         https://bugs.webkit.org/show_bug.cgi?id=33131
1564
1565         Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
1566         but for now we just deploy it everywhere and don't try to fix up the few valid uses
1567         of Command.
1568
1569         * Scripts/webkitpy/commands/download.py:
1570         * Scripts/webkitpy/commands/queries.py:
1571         * Scripts/webkitpy/commands/upload.py:
1572         * Scripts/webkitpy/multicommandtool.py:
1573
1574 2010-01-03  Adam Barth  <abarth@webkit.org>
1575
1576         Unreviewed "build" fix.  Need to import ScriptError.
1577
1578         * Scripts/webkitpy/buildsteps.py:
1579
1580 2010-01-03  Adam Barth  <abarth@webkit.org>
1581
1582         Reviewed by Eric Seidel.
1583
1584         [bzt] Make it easier to run submit-patch when previous run cancelled
1585         https://bugs.webkit.org/show_bug.cgi?id=33070
1586
1587         This patch renames create-review to submit-patch (as requested by
1588         Maciej).
1589
1590         This patch makes it easier to run submit-patch after the user has
1591         already cancelled a previous run of submit-patch by detecting when we
1592         already have ChangeLogs and reading the bug number from them (and not
1593         attempting to recreate them).  Aside from performance and the extra
1594         edit step, this command should not subsume post-dif.
1595
1596         Also, added a --email command line argument so that the output of
1597         prepare-ChangeLog makes sense when it can't find the user's email
1598         address.
1599
1600         * Scripts/webkitpy/bugzilla.py:
1601         * Scripts/webkitpy/buildsteps.py:
1602         * Scripts/webkitpy/commands/upload.py:
1603         * Scripts/webkitpy/commands/upload_unittest.py:
1604         * Scripts/webkitpy/mock_bugzillatool.py:
1605         * Scripts/webkitpy/user.py:
1606
1607 2010-01-03  Eric Seidel  <eric@webkit.org>
1608
1609         Reviewed by Adam Barth.
1610
1611         Rename Scripts/modules to Scripts/webkitpy
1612         https://bugs.webkit.org/show_bug.cgi?id=33128
1613
1614         Just search-replace and svn mv commands.
1615
1616         * Scripts/bugzilla-tool:
1617         * Scripts/check-webkit-style:
1618         * Scripts/modules: Removed.
1619         * Scripts/modules/BeautifulSoup.py: Removed.
1620         * Scripts/modules/__init__.py: Removed.
1621         * Scripts/modules/bugzilla.py: Removed.
1622         * Scripts/modules/bugzilla_unittest.py: Removed.
1623         * Scripts/modules/buildbot.py: Removed.
1624         * Scripts/modules/buildbot_unittest.py: Removed.
1625         * Scripts/modules/buildsteps.py: Removed.
1626         * Scripts/modules/buildsteps_unittest.py: Removed.
1627         * Scripts/modules/changelogs.py: Removed.
1628         * Scripts/modules/changelogs_unittest.py: Removed.
1629         * Scripts/modules/commands: Removed.
1630         * Scripts/modules/commands/__init__.py: Removed.
1631         * Scripts/modules/commands/commandtest.py: Removed.
1632         * Scripts/modules/commands/download.py: Removed.
1633         * Scripts/modules/commands/download_unittest.py: Removed.
1634         * Scripts/modules/commands/early_warning_system.py: Removed.
1635         * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
1636         * Scripts/modules/commands/queries.py: Removed.
1637         * Scripts/modules/commands/queries_unittest.py: Removed.
1638         * Scripts/modules/commands/queues.py: Removed.
1639         * Scripts/modules/commands/queues_unittest.py: Removed.
1640         * Scripts/modules/commands/queuestest.py: Removed.
1641         * Scripts/modules/commands/upload.py: Removed.
1642         * Scripts/modules/commands/upload_unittest.py: Removed.
1643         * Scripts/modules/comments.py: Removed.
1644         * Scripts/modules/committers.py: Removed.
1645         * Scripts/modules/committers_unittest.py: Removed.
1646         * Scripts/modules/cpp_style.py: Removed.
1647         * Scripts/modules/cpp_style_unittest.py: Removed.
1648         * Scripts/modules/credentials.py: Removed.
1649         * Scripts/modules/credentials_unittest.py: Removed.
1650         * Scripts/modules/diff_parser.py: Removed.
1651         * Scripts/modules/diff_parser_unittest.py: Removed.
1652         * Scripts/modules/executive.py: Removed.
1653         * Scripts/modules/executive_unittest.py: Removed.
1654         * Scripts/modules/grammar.py: Removed.
1655         * Scripts/modules/mock.py: Removed.
1656         * Scripts/modules/mock_bugzillatool.py: Removed.
1657         * Scripts/modules/multicommandtool.py: Removed.
1658         * Scripts/modules/multicommandtool_unittest.py: Removed.
1659         * Scripts/modules/outputcapture.py: Removed.
1660         * Scripts/modules/patchcollection.py: Removed.
1661         * Scripts/modules/queueengine.py: Removed.
1662         * Scripts/modules/queueengine_unittest.py: Removed.
1663         * Scripts/modules/scm.py: Removed.
1664         * Scripts/modules/scm_unittest.py: Removed.
1665         * Scripts/modules/statusbot.py: Removed.
1666         * Scripts/modules/stepsequence.py: Removed.
1667         * Scripts/modules/style: Removed.
1668         * Scripts/modules/style.py: Removed.
1669         * Scripts/modules/style_unittest.py: Removed.
1670         * Scripts/modules/text_style.py: Removed.
1671         * Scripts/modules/text_style_unittest.py: Removed.
1672         * Scripts/modules/user.py: Removed.
1673         * Scripts/modules/webkit_logging.py: Removed.
1674         * Scripts/modules/webkit_logging_unittest.py: Removed.
1675         * Scripts/modules/webkit_mechanize.py: Removed.
1676         * Scripts/modules/webkitport.py: Removed.
1677         * Scripts/modules/webkitport_unittest.py: Removed.
1678         * Scripts/test-webkit-python: Removed.
1679         * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
1680         * Scripts/validate-committer-lists:
1681         * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
1682         * Scripts/webkitpy/bugzilla.py:
1683         * Scripts/webkitpy/bugzilla_unittest.py:
1684         * Scripts/webkitpy/buildbot.py:
1685         * Scripts/webkitpy/buildbot_unittest.py:
1686         * Scripts/webkitpy/buildsteps.py:
1687         * Scripts/webkitpy/buildsteps_unittest.py:
1688         * Scripts/webkitpy/commands/commandtest.py:
1689         * Scripts/webkitpy/commands/download.py:
1690         * Scripts/webkitpy/commands/download_unittest.py:
1691         * Scripts/webkitpy/commands/early_warning_system.py:
1692         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
1693         * Scripts/webkitpy/commands/queries.py:
1694         * Scripts/webkitpy/commands/queries_unittest.py:
1695         * Scripts/webkitpy/commands/queues.py:
1696         * Scripts/webkitpy/commands/queues_unittest.py:
1697         * Scripts/webkitpy/commands/queuestest.py:
1698         * Scripts/webkitpy/commands/upload.py:
1699         * Scripts/webkitpy/commands/upload_unittest.py:
1700         * Scripts/webkitpy/comments.py:
1701         * Scripts/webkitpy/credentials.py:
1702         * Scripts/webkitpy/credentials_unittest.py:
1703         * Scripts/webkitpy/executive.py:
1704         * Scripts/webkitpy/executive_unittest.py:
1705         * Scripts/webkitpy/mock_bugzillatool.py:
1706         * Scripts/webkitpy/multicommandtool.py:
1707         * Scripts/webkitpy/multicommandtool_unittest.py:
1708         * Scripts/webkitpy/queueengine.py:
1709         * Scripts/webkitpy/queueengine_unittest.py:
1710         * Scripts/webkitpy/scm.py:
1711         * Scripts/webkitpy/scm_unittest.py:
1712         * Scripts/webkitpy/statusbot.py:
1713         * Scripts/webkitpy/stepsequence.py:
1714         * Scripts/webkitpy/webkit_logging_unittest.py:
1715         * Scripts/webkitpy/webkitport_unittest.py:
1716
1717 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
1718
1719         Reviewed by Eric Seidel.
1720
1721         Added script to test both Perl and Python, and renamed
1722         run-webkit-unittests to test-webkit-python.
1723
1724         https://bugs.webkit.org/show_bug.cgi?id=33045
1725
1726         * Scripts/VCSUtils_unittest.pl:
1727           - Tweaked so it can be run from outside Scripts directory.
1728
1729         * Scripts/run-webkit-unittests: Removed.
1730           - Renamed to test-webkit-python.
1731
1732         * Scripts/test-webkit-perl:
1733           - Tweaked so it can be run from outside Scripts directory.
1734
1735         * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
1736
1737         * Scripts/test-webkit-scripts: Added.
1738           - Runs both test-webkit-perl and test-webkit-python.
1739
1740 2010-01-03  Adam Barth  <abarth@webkit.org>
1741
1742         Reviewed by Eric Seidel.
1743
1744         commit-queue/bugzilla-tool should build both Debug and Release
1745         https://bugs.webkit.org/show_bug.cgi?id=28450
1746
1747         Add a --build-style command that lets the master process tell the child
1748         process to build both debug and release.  Eventually we want to teach
1749         the test step to understand this option too, but that's a patch for
1750         another day.
1751
1752         * Scripts/modules/buildsteps.py:
1753         * Scripts/modules/commands/queues.py:
1754         * Scripts/modules/webkitport.py:
1755         * Scripts/modules/webkitport_unittest.py:
1756
1757 2010-01-03  Jakub Wieczorek  <faw217@gmail.com>
1758
1759         Reviewed by Eric Seidel.
1760
1761         [Qt] EventSender: add support for Enter key events
1762         https://bugs.webkit.org/show_bug.cgi?id=33064
1763
1764         Unskip 5 tests that are fixed now.
1765
1766         * DumpRenderTree/qt/EventSenderQt.cpp:
1767         (EventSender::keyDown):
1768
1769 2010-01-03  Adam Barth  <abarth@webkit.org>
1770
1771         Reviewed by Eric Seidel.
1772
1773         [bzt] Add test for previous typo fix
1774         https://bugs.webkit.org/show_bug.cgi?id=33083
1775
1776         A trivial test for a trivial fix, as requested by Eric.
1777
1778         * Scripts/modules/bugzilla_unittest.py:
1779
1780 2010-01-03  Adam Barth  <abarth@webkit.org>
1781
1782         Reviewed by Eric Seidel.
1783
1784         Implement mac-ews
1785         https://bugs.webkit.org/show_bug.cgi?id=33072
1786
1787         The mac-ews is slightly different than the other early warning systems
1788         because we can't run Mac OS X inside a VM.  For that reason, we only
1789         process patches that were uploaded by committers.  This isn't as much
1790         coverage as the other EWS bots, but it's better than nothing.
1791
1792         * Scripts/modules/commands/early_warning_system.py:
1793         * Scripts/modules/commands/early_warning_system_unittest.py:
1794         * Scripts/modules/commands/queues.py:
1795         * Scripts/modules/commands/queuestest.py:
1796         * Scripts/modules/mock_bugzillatool.py:
1797
1798 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
1799
1800         Reviewed by David Kilzer.
1801
1802         Refactored svn-apply and svn-unapply to use a common "patch"
1803         command method, and added unit tests for this new method.
1804
1805         https://bugs.webkit.org/show_bug.cgi?id=33098
1806
1807         * Scripts/VCSUtils.pm:
1808           - Added generateRunPatchCommand().
1809           - Added runPatchCommand().
1810           - Added exitStatus() from webkitdirs.pm to address FIXME.
1811
1812         * Scripts/VCSUtils_unittest.pl:
1813           - Added 10 unit tests for generateRunPatchCommand().
1814           - Added 4 unit tests for runPatchCommand().
1815           - Added callSilently() method.
1816
1817         * Scripts/svn-apply:
1818           - Refactored applyPatch().
1819           - Removed $pathScriptWasRunFrom global variable.
1820           - Addressed issue where "--force" option was getting added twice.
1821
1822         * Scripts/svn-unapply:
1823           - Refactored applyPatch().
1824           - Removed $pathScriptWasRunFrom global variable.
1825           - Added support for --force option.
1826           - Enhanced to return meaningful exit status.
1827
1828         * Scripts/webkitdirs.pm:
1829           - Moved exitStatus() implementation to VCSUtils.pm.
1830
1831 2009-12-31  Adam Barth  <abarth@webkit.org>
1832
1833         Reviewed by Eric Seidel.
1834
1835         [bzt] Implement build-and-test
1836         https://bugs.webkit.org/show_bug.cgi?id=33073
1837
1838         Some of the early warning system bots want to use build-and-test so
1839         they can cover LayoutTests in addition to just compilation.
1840
1841         * Scripts/modules/commands/download.py:
1842         * Scripts/modules/commands/download_unittest.py:
1843
1844 2009-12-31  Adam Barth  <abarth@webkit.org>
1845
1846         Reviewed by Eric Seidel.
1847
1848         Show mac-ews status on QueueStatusServer
1849         https://bugs.webkit.org/show_bug.cgi?id=33076
1850
1851         Also make error status purple.
1852
1853         * QueueStatusServer/model/attachment.py:
1854         * QueueStatusServer/model/queues.py:
1855         * QueueStatusServer/templates/dashboard.html:
1856         * QueueStatusServer/templates/statusbubble.html:
1857
1858 2009-12-31  Adam Barth  <abarth@webkit.org>
1859
1860         Unreviewed.
1861
1862         [bzt] REGRESSION: Bugzila is a typo
1863         https://bugs.webkit.org/show_bug.cgi?id=33074
1864
1865         Eric should test his code before landing!  :)
1866
1867         * Scripts/modules/bugzilla.py:
1868
1869 2009-12-31  Adam Barth  <abarth@webkit.org>
1870
1871         Unreviewed.  Fix the unit tests!
1872
1873         * Scripts/run-webkit-unittests:
1874
1875 2009-12-30  Kevin Watters  <kevinwatters@gmail.com>
1876
1877         Reviewed by Kevin Ollivier.
1878
1879         [wx] Alter a couple of default settings in the test app.
1880         
1881         https://bugs.webkit.org/show_bug.cgi?id=32956
1882
1883         * wx/browser/browser.cpp:
1884         (MyApp::OnInit):
1885
1886 2009-12-30  Eric Seidel  <eric@webkit.org>
1887
1888         Reviewed by Adam Barth.
1889
1890         logging.py should be renamed to webkit_logging.py and eventually die
1891         https://bugs.webkit.org/show_bug.cgi?id=33058
1892
1893         Change all imports of "logging" to webkit_logging,
1894         except the ones which came from Google's cpp_lint.py and diff_parser.py
1895         which clearly are assuming python's logging.py.
1896
1897         * Scripts/modules/bugzilla.py:
1898         * Scripts/modules/buildbot.py:
1899         * Scripts/modules/buildsteps.py:
1900         * Scripts/modules/commands/download.py:
1901         * Scripts/modules/commands/queries.py:
1902         * Scripts/modules/commands/queues.py:
1903         * Scripts/modules/commands/upload.py:
1904         * Scripts/modules/credentials.py:
1905         * Scripts/modules/executive.py:
1906         * Scripts/modules/multicommandtool.py:
1907         * Scripts/modules/queueengine.py:
1908         * Scripts/modules/scm.py:
1909         * Scripts/modules/statusbot.py:
1910         * Scripts/modules/stepsequence.py:
1911         * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
1912         * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
1913
1914 2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
1915
1916         Reviewed by Simon Hausmann.
1917
1918         [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
1919         https://bugs.webkit.org/show_bug.cgi?id=33051
1920
1921         Moreover, its primary function is to normalize the path in regard of platform
1922         specific directory separators. Therefore, it can simply make use of the
1923         QDir::toNativeSeparators function.
1924
1925         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1926         (LayoutTestController::pathToLocalResource):
1927
1928 2009-12-30  David D. Kilzer  <ddkilzer@webkit.org>
1929
1930         Fix executable bits for r52646
1931
1932         * Scripts/VCSUtils_unittest.pl: Added property svn:executable.
1933         * Scripts/test-webkit-perl: Ditto.
1934
1935 2009-12-29  Chris Jerdonek  <chris.jerdonek@gmail.com>
1936
1937         Reviewed by David Kilzer.
1938
1939         Fixed a bug in fixChangeLogPatch, made it work correctly in
1940         more circumstances, and added unit tests.
1941
1942         https://bugs.webkit.org/show_bug.cgi?id=32919
1943
1944         * Scripts/VCSUtils.pm:
1945           Rewrote fixChangeLogPatch.
1946           
1947         * Scripts/VCSUtils_unittest.pl: Added.
1948           Added 7 unit tests for fixChangeLogPatch.
1949
1950         * Scripts/test-webkit-perl: Added.
1951           Added test harness for unit tests of Perl code.
1952
1953 2009-12-29  Eric Seidel  <eric@webkit.org>
1954
1955         Reviewed by Adam Barth.
1956
1957         Split out BugzillaQueries class from Bugzilla
1958         https://bugs.webkit.org/show_bug.cgi?id=33042
1959
1960         * Scripts/modules/bugzilla.py:
1961          - Split out BugzillaQueries from Bugzilla.
1962          - Try to isolate self.bugzilla usage into helper functions whenever possible.
1963          - Add a bunch of FIXMEs.
1964          - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
1965         * Scripts/modules/bugzilla_unittest.py:
1966          - Create a new BugzillaQueriesTest testcase and move logic there.
1967         * Scripts/modules/buildsteps_unittest.py:
1968          - Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
1969         * Scripts/modules/commands/queries.py:
1970          - Update to use bugzilla.queries
1971         * Scripts/modules/commands/queues.py:
1972          - Ditto.
1973         * Scripts/modules/commands/upload.py:
1974          - Ditto.
1975         * Scripts/modules/mock_bugzillatool.py:
1976          - Add a MockBugzillaQueries.
1977          - Make patches and bugs global privates.
1978          - Let _id_to_object_dictionary take a variable argument list instead of an array.
1979
1980 2009-12-29  Daniel Bates  <dbates@webkit.org>
1981
1982         Reviewed by Eric Seidel.
1983
1984         https://bugs.webkit.org/show_bug.cgi?id=33041
1985
1986         Speed up the test method test_read_credentials_with_SVN by not actually
1987         creating an SVN repository to test against (by default). Instead, it is
1988         sufficient to create a temporary directory that does not contain a Git
1989         repository.
1990
1991         Also, renamed method test_read_credentials_with_SVN to
1992         test_read_credentials_without_git_repo, to better reflect what it is
1993         testing.
1994
1995         * Scripts/modules/credentials_unittest.py:
1996
1997 2009-12-29  Daniel Bates  <dbates@webkit.org>
1998
1999         Reviewed by Adam Barth.
2000
2001         https://bugs.webkit.org/show_bug.cgi?id=33039
2002
2003         [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
2004         fails to find an entry for bugs.webkit.org.
2005         
2006         Under Mac OS X, bugzilla-tool tries to query the keychain and Security
2007         framework (via /usr/sbin/security) for an internet-password entry for
2008         bugs.webkit.org so that it can use it to login to bugs.webkit.org.
2009         However, if no such entry exists then bugzilla-tool dies with an error.
2010
2011         * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return
2012         [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
2013         * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
2014
2015 2009-12-29  Eric Seidel  <eric@webkit.org>
2016
2017         Rubber-stamped by Adam Barth.
2018
2019         Remove unused BugzillaException.
2020
2021         * Scripts/modules/bugzilla.py:
2022
2023 2009-12-29  Eric Seidel  <eric@webkit.org>
2024
2025         Reviewed by Adam Barth.
2026
2027         Need a script to assign bugs with r+ patches to committers for landing
2028         https://bugs.webkit.org/show_bug.cgi?id=33009
2029
2030         This is just one more small tool to help in the fight against our
2031         ever-growing list of to-be-committed patches.
2032
2033         * Scripts/modules/bugzilla.py:
2034          - Rename assign_to_email to assigned_to_email (typo).
2035          - Add assigned_to_email() method on Bug.
2036          - Add reassign_bug method.
2037          - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
2038         * Scripts/modules/bugzilla_unittest.py:
2039          - Update test after assigned_to_email rename.
2040         * Scripts/modules/commands/commandtest.py:
2041          - Call bind_to_tool to that self.tool works in Command testing.
2042         * Scripts/modules/commands/download.py:
2043          - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
2044         * Scripts/modules/commands/queries_unittest.py:
2045          - One of the test patches is now posted by "eric@webkit.org" which is a committer.
2046          - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
2047         * Scripts/modules/commands/upload.py:
2048          - Add new assign-to-committer command.
2049         * Scripts/modules/commands/upload_unittest.py:
2050          - Add basic assign-to-committer test.
2051         * Scripts/modules/committers.py:
2052          - Add bugzilla_email() accessor.
2053         * Scripts/modules/committers_unittest.py:
2054          - Test our assumption that bugzilla_email is the first email.
2055         * Scripts/modules/mock_bugzillatool.py:
2056          - Add _id_to_object_dictionary for generating bug_cache from list of bugs.
2057          - Remove unused fetch_attachments_from_bug.
2058          - Add fetch_bug support and a bug_cache.
2059         * Scripts/modules/multicommandtool.py:
2060          - Move AbstractDeclarativeCommmand here from download.py
2061
2062 2009-12-29  Adam Barth  <abarth@webkit.org>
2063
2064         Reviewed by Eric Seidel.
2065
2066         [bzt] Don't crash if user types a number during PromptForBugOrTitleStep
2067         https://bugs.webkit.org/show_bug.cgi?id=33038
2068
2069         Simple fix with test.
2070
2071         * Scripts/modules/buildsteps.py:
2072         * Scripts/modules/buildsteps_unittest.py:
2073
2074 2009-12-29  Adam Barth  <abarth@webkit.org>
2075
2076         Reviewed by Eric Seidel.
2077
2078         [bzt] post-diff requires reading to the end
2079         https://bugs.webkit.org/show_bug.cgi?id=33036
2080
2081         Catch the IOError caused by not reading to the end of the diff.  We
2082         don't have a good way to test this currently.
2083
2084         * Scripts/modules/user.py:
2085
2086 2009-12-29  Chang Shu  <Chang.Shu@nokia.com>
2087
2088         Reviewed by Adam Barth.
2089
2090         [Qt] Move logic that handles Qt headers before primary headers
2091         so that Qt headers won't be treated as primary headers by mistake.
2092         https://bugs.webkit.org/show_bug.cgi?id=32991
2093
2094         * Scripts/modules/cpp_style.py:
2095         * Scripts/modules/cpp_style_unittest.py:
2096
2097 2009-12-29  Eric Seidel  <eric@webkit.org>
2098
2099         Reviewed by Adam Barth.
2100
2101         Add the start of a Bug object for bugzilla.py
2102         https://bugs.webkit.org/show_bug.cgi?id=32995
2103
2104         This allowed us to get rid of some duplicated "is_obsolete" checks.
2105
2106         * Scripts/modules/bugzilla.py:
2107          - Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
2108          - Add _fetch_bug_page for possible future mocking.
2109            (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
2110          - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
2111          - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
2112          - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue
2113            using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
2114         * Scripts/modules/bugzilla_unittest.py:
2115          - Remove an unneeded unicode string marker.
2116         * Scripts/modules/buildsteps.py:
2117          - define __all__ to include just the BuildSteps
2118         * Scripts/modules/commands/download.py:
2119          - import * now that we have an __all__ defined.
2120         * Scripts/modules/commands/upload.py:
2121          - Use fetch_bug_dictionary instead of fetch_bug.
2122
2123 2009-12-29  Daniel Bates  <dbates@webkit.org>
2124
2125         Reviewed by Ariya Hidayat.
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=32925
2128
2129         Adds an Open File dialog to make it convenient to open a file
2130         to view in the browser.
2131
2132         Currently a person must either specify the path to a file as a
2133         command-line argument or type a file URL. Instead, we should
2134         have a file dialog to allow a person to open a file without
2135         memorizing its path.
2136
2137         * QtLauncher/main.cpp:
2138         (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded())
2139         to urlEdit->setText(qurl.toString()). 
2140         (MainWindow::openFile): Added.
2141         (MainWindow::changeLocation): Moved code to load URL into method
2142         MainWindow::loadURL.
2143         (MainWindow::loadURL): Added.
2144         (MainWindow::setupUI): Added menu item Open File.
2145
2146 2009-12-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2147
2148         Reviewed by Holger Freyther.
2149
2150         [GTK] fails fast/harness/use-page-cache.html
2151         https://bugs.webkit.org/show_bug.cgi?id=33013
2152
2153         Make sure settings are forwarded to child WebViews.
2154
2155         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2156         (createWebView):
2157
2158 2009-12-29  Daniel Bates  <dbates@webkit.org>
2159
2160         Reviewed by Eric Seidel.
2161
2162         https://bugs.webkit.org/show_bug.cgi?id=32778
2163
2164         Changes $diffPercentage to be a number to resolve Perl
2165         warning about comparing a string to a number.
2166
2167         * Scripts/run-webkit-tests:
2168
2169 2009-12-29  Jakub Wieczorek  <faw217@gmail.com>
2170
2171         Reviewed by Eric Seidel.
2172
2173         [Qt] DRT: Frame loader callbacks differ from the Mac port
2174         https://bugs.webkit.org/show_bug.cgi?id=32989
2175
2176         Remove messages from the callbacks that should not dump them to match
2177         the expected results for the http/loading tests.
2178
2179         Unskip some http/loading tests which succeed now.
2180
2181         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2182         (WebCore::DumpRenderTree::dump):
2183
2184 2009-12-29  Robert Hogan  <robert@roberthogan.net>
2185
2186         Reviewed by Eric Seidel.
2187
2188         [Qt] fix fast/dom/Window/window-onFocus.html
2189         
2190         Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
2191         window.onblur was getting dispatched twice from QtWebKit.
2192         
2193         https://bugs.webkit.org/show_bug.cgi?id=32990
2194
2195         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2196         (WebCore::DumpRenderTree::DumpRenderTree):
2197         (WebCore::DumpRenderTree::switchFocus):
2198         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2199         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2200         (LayoutTestController::setWindowIsKey):
2201         (LayoutTestController::setMainFrameIsFirstResponder):
2202         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2203
2204 2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
2205
2206         Reviewed by Maciej Stachowiak.
2207
2208         Extended EventSender.keyDown method to take another (3rd) argument
2209         for indicating the keyLocation to make numeric pad key events testable.
2210         Expected values for the argument is one of the KeyLocationCode
2211         specified in DOM Level 3
2212         (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
2213         https://bugs.webkit.org/show_bug.cgi?id=28247
2214
2215         Test: fast/events/keydown-numpad-keys.html
2216
2217         * DumpRenderTree/mac/EventSendingController.mm:
2218         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2219         (+[EventSendingController webScriptNameForSelector:]):
2220         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2221
2222 2009-12-28  Ariya Hidayat  <ariya.hidayat@gmail.com>
2223
2224         Unreviewed, update my email address.
2225
2226         * Scripts/modules/committers.py:
2227
2228 2009-12-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2229
2230         Reviewed by Adam Barth.
2231
2232         [Qt] Fix build break for Qt 4.4
2233         https://bugs.webkit.org/show_bug.cgi?id=30327
2234
2235         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
2236         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
2237         * QtLauncher/main.cpp:
2238         (MainWindow::MainWindow): Qt::WA_TranslucentBackground was
2239         introduced in Qt version 4.5
2240
2241 2009-12-28  Adam Barth  <abarth@webkit.org>
2242
2243         Reviewed by Eric Seidel.
2244
2245         [bzt] Add an edit-changelog command
2246         https://bugs.webkit.org/show_bug.cgi?id=32986
2247
2248         This command makes it easier to edit ChangeLogs.  It's similar to
2249         prepare-ChangeLog -o, except it works with already existing ChangeLogs.
2250
2251         * Scripts/modules/commands/upload.py:
2252         * Scripts/modules/commands/upload_unittest.py:
2253
2254 2009-12-28  Adam Barth  <abarth@webkit.org>
2255
2256         Reviewed by Eric Seidel.
2257
2258         [bzt] Create an ASAD command for uploading a patch
2259         https://bugs.webkit.org/show_bug.cgi?id=32979
2260
2261         The create-review command goes through the whole process of preparing a
2262         code review, including creating a bug, editing the ChangeLogs, and
2263         uploading the patch.  It is indeed the All Sing, All Dance upload
2264         command.
2265
2266         * Scripts/modules/buildsteps.py:
2267         * Scripts/modules/commands/upload.py:
2268         * Scripts/modules/commands/upload_unittest.py:
2269         * Scripts/modules/mock_bugzillatool.py:
2270         * Scripts/modules/user.py:
2271
2272 2009-12-28  Adam Barth  <abarth@webkit.org>
2273
2274         Unreviewed "build" fix (with test!).
2275
2276         * Scripts/modules/bugzilla.py:
2277         * Scripts/modules/bugzilla_unittest.py:
2278
2279 2009-12-27  Eric Seidel  <eric@webkit.org>
2280
2281         Reviewed by Adam Barth.
2282
2283         Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
2284         https://bugs.webkit.org/show_bug.cgi?id=32980
2285
2286         * Scripts/modules/bugzilla.py:
2287          - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
2288          - Replace fetch_title_from_bug with a new fetch_bug call instead.
2289          - Use list comprehensions where possible to reduce code duplication.
2290         * Scripts/modules/bugzilla_unittest.py:
2291          - Add a minimal bug parsing test.
2292          - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
2293         * Scripts/modules/commands/upload.py:
2294          - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug
2295
2296 2009-12-27  Adam Barth  <abarth@webkit.org>
2297
2298         Reviewed by Eric Seidel.
2299
2300         Status bubble shouldn't be transparent for bots that haven't run yet
2301         https://bugs.webkit.org/show_bug.cgi?id=32977
2302
2303         * QueueStatusServer/templates/statusbubble.html:
2304
2305 2009-12-27  Adam Barth  <abarth@webkit.org>
2306
2307         Reviewed by Eric Seidel.
2308
2309         [QueueStatusServer] Run gc cron job less often
2310         https://bugs.webkit.org/show_bug.cgi?id=32958
2311
2312         Now that we've cleaned out the backlog of idle messages, we don't need
2313         to run the gc job every half hour.  We could also stop logging the idle
2314         messages, but this seems easier for the time being.
2315
2316         * QueueStatusServer/cron.yaml:
2317
2318 2009-12-27  Daniel Bates  <dbates@webkit.org>
2319
2320         Reviewed by Adam Barth.
2321
2322         https://bugs.webkit.org/show_bug.cgi?id=32896
2323
2324         Fixes an issue where bugzilla-tool tries to read the username and password from
2325         Git regardless of whether Git is installed. In particular, if Git is not
2326         installed then bugzilla-tool dies (with a trace) when it attempts to query Git
2327         for the authentication credentials to log into bugs.webkit.org.
2328
2329         Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
2330         the specified error handler. For instance, the specified error handler will now
2331         be called when the command does not exist (i.e. OSError errno 2).
2332
2333         * Scripts/modules/credentials.py: Added check for Git.
2334         * Scripts/modules/credentials_unittest.py: Added test method
2335         test_read_credentials_with_SVN.
2336         * Scripts/modules/executive.py: Modified method run_command to catch
2337         OSError exceptions (i.e [Errno 2] No such file or directory) and call
2338         the specified error handler.
2339         * Scripts/modules/executive_unittest.py: Added.
2340         * Scripts/run-webkit-unittests: Added import executive_unittest.py.
2341
2342 2009-12-27  Daniel Bates  <dbates@webkit.org>
2343
2344         Unreviewed. Added missing file style_unittest.py that wasn't committed
2345         in change set 52541 (http://trac.webkit.org/changeset/52541) as part of
2346         the patch for bug #32592.
2347
2348         * Scripts/modules/style_unittest.py: Added.
2349
2350 2009-12-27  Daniel Bates  <dbates@webkit.org>
2351
2352         Reviewed by Eric Seidel.
2353
2354         https://bugs.webkit.org/show_bug.cgi?id=32964
2355
2356         [bzt] Updated the unit test based on the change made in bug #32951.
2357
2358         The change made in bug #32951 added the command-line argument:
2359         --makeargs="-j8" to the build-webkit command. However, the associated
2360         unit test was not updated.
2361
2362         * Scripts/modules/webkitport_unittest.py:
2363
2364 2009-12-27  Yael Aharon  <yael.aharon@nokia.com>
2365
2366         Reviewed by Darin Adler.
2367
2368         check-webkit-style should not mark moc files inclusion as errors
2369         https://bugs.webkit.org/show_bug.cgi?id=32669
2370
2371         Add a new header type for moc files, and skip them when checking the order of header files.
2372
2373         * Scripts/modules/cpp_style.py:
2374
2375 2009-12-26  Adam Barth  <abarth@webkit.org>
2376
2377         Reviewed by Eric Seidel.
2378
2379         [bzt] Make the qt build go fast
2380         https://bugs.webkit.org/show_bug.cgi?id=32951
2381
2382         Make use of multiple cores, if available.
2383
2384         * Scripts/modules/webkitport.py:
2385
2386 2009-12-25  Daniel Bates  <dbates@rim.com>
2387
2388         Reviewed by Eric Seidel.
2389
2390         https://bugs.webkit.org/show_bug.cgi?id=32682
2391
2392         Fixes an issue where checkFrameworks always dies with an error under Windows
2393         since the clause "unless (-x $path)" is always satisfied because files under
2394         Windows do not have an explict executable bit.
2395
2396         * Scripts/webkitdirs.pm:
2397
2398 2009-12-23  Eric Seidel  <eric@webkit.org>
2399
2400         Reviewed by Adam Barth.
2401
2402         bugzilla-tool should accept global options anywhere
2403         https://bugs.webkit.org/show_bug.cgi?id=26912
2404
2405         * Scripts/bugzilla-tool:
2406          - Use the new global_options class property.
2407          - Add a handle_global_options callback to avoid needing callbacks for each global option.
2408         * Scripts/modules/multicommandtool.py:
2409          - Make the code use one combined option parser.
2410            This allows us to accept global options anywhere and
2411            individual command options before commands.
2412          - Add a handle_global_options callback to avoid needing callbacks for each global option.
2413          - Make the Command hold the option parser, but allow the tool to override it.
2414          - The default option parser is used for help printing and when Commands are run stand alone,
2415            but are otherwise not used.
2416          - Add Command.main to codify the idea that Commands should support being run stand-alone.
2417          - Change _split_args to _split_command_name_from_args now that args are unified.
2418         * Scripts/modules/multicommandtool_unittest.py:
2419          - Test that "tool" and "tool help" show the same help.
2420          - Test that args are accepted before commands
2421
2422 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
2423
2424         Reviewed by David Levin.
2425
2426         Moved some sections of code in preparation to refactor
2427         check-webkit-style's argument parser to avoid setting
2428         global variables.
2429
2430         https://bugs.webkit.org/show_bug.cgi?id=32592
2431
2432         * Scripts/check-webkit-style:
2433           - Moved _USAGE string to style.py.
2434           - Addressed FIXME by eliminating dependencies on cpp_style.py.
2435
2436         * Scripts/modules/cpp_style.py:
2437           - Moved default arguments and style categories to style.py.
2438           - Moved exit_with_usage(), exit_with_categories(), and
2439             parse_arguments() to style.py.
2440           - Removed references in _CppStyleState to the global
2441             variables now in style.py.
2442
2443         * Scripts/modules/cpp_style_unittest.py:
2444           - Moved parse_arguments() unit tests to style_unittest.py.
2445
2446         * Scripts/modules/style.py:
2447           - Added _USAGE string from check-webkit-style.
2448           - Added default arguments and style categories from cpp_style.py.
2449           - Added exit_with_usage(), exit_with_categories(), and
2450             parse_arguments() from cpp_sstyle.py.
2451
2452         * Scripts/modules/style_unittest.py: Added.
2453           - Added parse_arguments() unit tests from cpp_style_unittest.py.
2454
2455         * Scripts/run-webkit-unittests:
2456           - Added unit tests from style_unittest.py.
2457
2458 2009-12-23  Eric Seidel  <eric@webkit.org>
2459
2460         Reviewed by Adam Barth.
2461
2462         commit-queue should mention bug 30084 when rejecting patches until it can be fixed
2463         https://bugs.webkit.org/show_bug.cgi?id=32911
2464
2465         * Scripts/modules/bugzilla.py: Make the message even more fancy.
2466         * Scripts/modules/bugzilla_unittest.py: Test our new fancy message.
2467
2468 2009-12-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2469
2470         Not reviewed, adding myself to the reviewers list.
2471
2472         * Scripts/modules/committers.py:
2473
2474 2009-12-23  Adam Barth  <abarth@webkit.org>
2475
2476         Reviewed by Eric Seidel.
2477
2478         [bzt] Create a prepare-diff command that creates a bug and a ChangeLog
2479         https://bugs.webkit.org/show_bug.cgi?id=32895
2480
2481         The workflow Maciej and I discussed is as follows:
2482
2483         1) Write code.
2484         2) bugzilla-tool prepare-diff
2485         3) Edit ChangeLogs
2486         4) bugzilla-tool post-diff
2487
2488         We might want to experimenting with combining 2-4 into a single
2489         command, but that might be stressful to edit the ChangeLogs modally.
2490
2491         Removed submit-patch since it has the modal ChangeLog editing but none
2492         oof the bug creating fun.
2493
2494         * Scripts/modules/bugzilla.py:
2495         * Scripts/modules/buildsteps.py:
2496         * Scripts/modules/commands/upload.py:
2497         * Scripts/modules/commands/upload_unittest.py:
2498
2499 2009-12-23  Gabor Loki  <loki@webkit.org>
2500
2501         Unreviewed; added myself to the committers list.
2502
2503         * Scripts/modules/committers.py:
2504
2505 2009-12-22  Adam Barth  <abarth@webkit.org>
2506
2507         Reviewed by Maciej Stachowiak.
2508
2509         [bzt] Don't call create-patch twice during post-diff
2510         https://bugs.webkit.org/show_bug.cgi?id=32893
2511
2512         If we call create-patch to get the bug number, cache the diff in the
2513         state so we don't need to call it again.
2514
2515         * Scripts/modules/buildsteps.py:
2516         * Scripts/modules/commands/upload.py:
2517
2518 2009-12-22  Daniel Bates  <dbates@rim.com>
2519
2520         Reviewed by Eric Seidel.
2521
2522         https://bugs.webkit.org/show_bug.cgi?id=32680
2523
2524         Fixes an issue in builtDylibPathForName so that it returns the correct
2525         path to the built QtWebKit library on the Qt Windows port. Currently,
2526         it returns the path to the file named QtWebKit.dll but this file does
2527         not exist on the Qt Windows build. Instead, the file is named
2528         QtWebKit4.dll.
2529
2530         * Scripts/webkitdirs.pm:
2531
2532 2009-12-22  Marc-Antoine Ruel  <maruel@chromium.org>
2533
2534         Reviewed by Adam Roben.
2535
2536         Remove the only dependency on perl-libwin32 in cygwin
2537
2538         * Scripts/num-cpus:
2539
2540 2009-12-22  Darin Adler  <darin@apple.com>
2541
2542         * pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore
2543         generated ".pyc" files.
2544
2545 2009-12-22  Darin Adler  <darin@apple.com>
2546
2547         Reviewed by Mark Rowe.
2548
2549         Turn off datagrid by default, at least for all platforms Apple ships.
2550         The datagrid implementation isn't ready for general web use yet.
2551
2552         * Scripts/build-webkit: Turn off datagrid by default.
2553
2554 2009-12-22  Eric Seidel  <eric@webkit.org>
2555
2556         Reviewed by Darin Adler.
2557
2558         validate-committer-lists fails when run from an SVN checkout
2559         https://bugs.webkit.org/show_bug.cgi?id=31974
2560
2561         * Scripts/validate-committer-lists:
2562          - Make it print a warning message instead of throwing
2563            an exception when running from an SVN checkout.
2564
2565 2009-12-22  Philippe Normand  <pnormand@igalia.com>
2566
2567         Reviewed by Adam Barth.
2568
2569         check-webkit-style should not warn about NULL usage in g_object_{get,set}
2570         https://bugs.webkit.org/show_bug.cgi?id=32858
2571
2572         * Scripts/modules/cpp_style.py:
2573         * Scripts/modules/cpp_style_unittest.py:
2574
2575 2009-12-22  Simon Hausmann  <simon.hausmann@nokia.com>
2576
2577         Rubber-stamped by Holger Freyther.
2578
2579         Moved QtLauncher from WebKit/qt.
2580
2581         * QtLauncher: Copied from WebKit/qt/QtLauncher.
2582         * QtLauncher/QtLauncher.pro:
2583
2584 2009-12-21  Adam Barth  <abarth@webkit.org>
2585
2586         Reviewed by Eric Seidel.
2587
2588         [bzt] Automate the process of calling prepare-ChangeLog
2589         https://bugs.webkit.org/show_bug.cgi?id=32816
2590
2591         This patch automates the process of creating a bug and patch and
2592         uploading it to bugzilla.  The first cut just calls
2593         prepare-ChangeLog.
2594
2595         This patch required some refactoring of upload.py to the Step
2596         model, but that's worth doing anyway.
2597
2598         * Scripts/bugzilla-tool:
2599         * Scripts/modules/buildsteps.py:
2600         * Scripts/modules/commands/download.py:
2601         * Scripts/modules/commands/upload.py:
2602         * Scripts/modules/commands/upload_unittest.py:
2603         * Scripts/modules/mock_bugzillatool.py:
2604
2605 2009-12-21  Darin Adler  <darin@apple.com>
2606
2607         * Scripts/do-webcore-rename: Did a rename, so checking in the
2608         version of the script I used.
2609
2610 2009-12-21  Adam Barth  <abarth@webkit.org>
2611
2612         Reviewed by Eric Seidel.
2613
2614         Update status-bubble to show all the queues
2615         https://bugs.webkit.org/show_bug.cgi?id=32838
2616
2617         Also, move statusbubble over to use memcache.
2618
2619         * QueueStatusServer/handlers/statusbubble.py:
2620         * QueueStatusServer/templates/statusbubble.html:
2621
2622 2009-12-21  Adam Barth  <abarth@webkit.org>
2623
2624         Reviewed by Eric Seidel.
2625
2626         Delete the boring "Empty queue" status messages in QueueStatusServer
2627         https://bugs.webkit.org/show_bug.cgi?id=32818
2628
2629         * QueueStatusServer/app.yaml:
2630         * QueueStatusServer/cron.yaml:
2631         * QueueStatusServer/handlers/gc.py:
2632         * QueueStatusServer/main.py:
2633
2634 2009-12-21  Adam Barth  <abarth@webkit.org>
2635
2636         Reviewed by Eric Seidel.
2637
2638         Exception on queue status server
2639         https://bugs.webkit.org/show_bug.cgi?id=32812
2640
2641         Turns out we need to pass the id to the filter.
2642
2643         * QueueStatusServer/filters/webkit_extras.py:
2644         * QueueStatusServer/templates/patch.html:
2645         * QueueStatusServer/templates/recentstatus.html:
2646
2647 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
2648
2649         Reviewed by Eric Seidel.
2650
2651         Created "style" folder for code supporting check-webkit-style.
2652
2653         * Scripts/modules/style: Added.
2654
2655 2009-12-20  Adam Barth  <abarth@webkit.org>
2656
2657         Reviewed by Eric Seidel.
2658
2659         REGRESSION: error when running commit-queue
2660         https://bugs.webkit.org/show_bug.cgi?id=32806
2661
2662         Fix typo and add test!
2663
2664         * Scripts/modules/bugzilla.py:
2665         * Scripts/modules/bugzilla_unittest.py:
2666
2667 2009-12-20  Adam Barth  <abarth@webkit.org>
2668
2669         [bzt] Optimize status updates for new dashboard
2670         https://bugs.webkit.org/show_bug.cgi?id=32797
2671
2672         This patch makes the queues slightly more chatty with the web service.
2673         Also, this patch introduces some testing for the queues!
2674
2675         * Scripts/modules/commands/early_warning_system.py:
2676         * Scripts/modules/commands/early_warning_system_unittest.py: Added.
2677         * Scripts/modules/commands/queues.py:
2678         * Scripts/modules/commands/queues_unittest.py:
2679         * Scripts/modules/commands/queuestest.py: Added.
2680         * Scripts/modules/mock_bugzillatool.py:
2681         * Scripts/modules/patchcollection.py:
2682         * Scripts/modules/queueengine.py:
2683         * Scripts/run-webkit-unittests:
2684
2685 2009-12-20  Adam Barth  <abarth@webkit.org>
2686
2687         Reviewed by Eric Seidel.
2688
2689         Prepare QueueStatusServer for new status messages
2690         https://bugs.webkit.org/show_bug.cgi?id=32805
2691
2692         * QueueStatusServer/handlers/recentstatus.py:
2693         * QueueStatusServer/index.html: Removed.
2694         * QueueStatusServer/model/attachment.py:
2695         * QueueStatusServer/model/queues.py: Added.
2696         * QueueStatusServer/templates/recentstatus.html: Added.
2697
2698 2009-12-20  Shinichiro Hamaji  <hamaji@chromium.org>
2699
2700         Reviewed by Adam Barth.
2701
2702         [check-webkit-style] static_cast is not misnamed!
2703         https://bugs.webkit.org/show_bug.cgi?id=32796
2704
2705         * Scripts/modules/cpp_style.py:
2706         * Scripts/modules/cpp_style_unittest.py:
2707
2708 2009-12-20  Alejandro G. Castro  <alex@igalia.com>
2709
2710         Reviewed by Gustavo Noronha Silva.
2711
2712         [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
2713         https://bugs.webkit.org/show_bug.cgi?id=32788
2714
2715         Do not increase the click count if we are using a different button.
2716
2717         * DumpRenderTree/gtk/EventSender.cpp:
2718
2719 2009-12-20  Adam Barth  <abarth@webkit.org>
2720
2721         Reviewed by Eric Seidel.
2722
2723         [QueueStatusServer] Add a per-patch details page
2724         https://bugs.webkit.org/show_bug.cgi?id=32784
2725
2726         This is a first cut at a per-patch details page.  I'm sure we'll have
2727         to iterate.
2728
2729         * QueueStatusServer/filters/webkit_extras.py:
2730         * QueueStatusServer/handlers/patch.py: Added.
2731         * QueueStatusServer/index.yaml:
2732         * QueueStatusServer/main.py:
2733         * QueueStatusServer/model/attachment.py:
2734         * QueueStatusServer/stylesheets/dashboard.css:
2735         * QueueStatusServer/templates/dashboard.html:
2736         * QueueStatusServer/templates/patch.html: Added.
2737
2738 2009-12-20  Adam Barth  <abarth@webkit.org>
2739
2740         Reviewed by Eric Seidel.
2741
2742         Use memcache to make dashboard to fast
2743         https://bugs.webkit.org/show_bug.cgi?id=32780
2744
2745         * QueueStatusServer/app.yaml:
2746         * QueueStatusServer/handlers/dashboard.py:
2747         * QueueStatusServer/handlers/updatestatus.py:
2748         * QueueStatusServer/model/attachment.py: Added.
2749
2750 2009-12-19  Brent Fulgham  <bfulgham@webkit.org>
2751
2752         Reviewed by Adam Roben.
2753
2754         Provide an example implementation for printing under Windows.
2755         http://bugs.webkit.org/show_bug.cgi?id=32504.`
2756
2757         * WinLauncher/PrintWebUIDelegate.cpp: Added.
2758         (PrintWebUIDelegate::QueryInterface):
2759         (PrintWebUIDelegate::AddRef):
2760         (PrintWebUIDelegate::Release):
2761         (PrintWebUIDelegate::webViewPrintingMarginRect):
2762         * WinLauncher/PrintWebUIDelegate.h: Added.
2763         (PrintWebUIDelegate::PrintWebUIDelegate):
2764         (PrintWebUIDelegate::createWebViewWithRequest):
2765         (PrintWebUIDelegate::webViewShow):
2766         (PrintWebUIDelegate::webViewClose):
2767         (PrintWebUIDelegate::webViewFocus):
2768         (PrintWebUIDelegate::webViewUnfocus):
2769         (PrintWebUIDelegate::webViewFirstResponder):
2770         (PrintWebUIDelegate::makeFirstResponder):
2771         (PrintWebUIDelegate::setStatusText):
2772         (PrintWebUIDelegate::webViewStatusText):
2773         (PrintWebUIDelegate::webViewAreToolbarsVisible):
2774         (PrintWebUIDelegate::setToolbarsVisible):
2775         (PrintWebUIDelegate::webViewIsStatusBarVisible):
2776         (PrintWebUIDelegate::setStatusBarVisible):
2777         (PrintWebUIDelegate::webViewIsResizable):
2778         (PrintWebUIDelegate::setResizable):
2779         (PrintWebUIDelegate::setFrame):
2780         (PrintWebUIDelegate::webViewFrame):
2781         (PrintWebUIDelegate::setContentRect):
2782         (PrintWebUIDelegate::webViewContentRect):
2783         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
2784         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
2785         (PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
2786         (PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2787         (PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
2788         (PrintWebUIDelegate::mouseDidMoveOverElement):
2789         (PrintWebUIDelegate::contextMenuItemsForElement):
2790         (PrintWebUIDelegate::validateUserInterfaceItem):
2791         (PrintWebUIDelegate::shouldPerformAction):
2792         (PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
2793         (PrintWebUIDelegate::willPerformDragDestinationAction):
2794         (PrintWebUIDelegate::dragSourceActionMaskForPoint):
2795         (PrintWebUIDelegate::willPerformDragSourceAction):
2796         (PrintWebUIDelegate::contextMenuItemSelected):
2797         (PrintWebUIDelegate::hasCustomMenuImplementation):
2798         (PrintWebUIDelegate::trackCustomPopupMenu):
2799         (PrintWebUIDelegate::measureCustomMenuItem):
2800         (PrintWebUIDelegate::drawCustomMenuItem):
2801         (PrintWebUIDelegate::addCustomMenuDrawingData):
2802         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
2803         (PrintWebUIDelegate::canTakeFocus):
2804         (PrintWebUIDelegate::takeFocus):
2805         (PrintWebUIDelegate::registerUndoWithTarget):
2806         (PrintWebUIDelegate::removeAllActionsWithTarget):
2807         (PrintWebUIDelegate::setActionTitle):
2808         (PrintWebUIDelegate::undo):
2809         (PrintWebUIDelegate::redo):
2810         (PrintWebUIDelegate::canUndo):
2811         (PrintWebUIDelegate::canRedo):
2812         (PrintWebUIDelegate::printFrame):
2813         (PrintWebUIDelegate::ftpDirectoryTemplatePath):
2814         (PrintWebUIDelegate::webViewHeaderHeight):
2815         (PrintWebUIDelegate::webViewFooterHeight):
2816         (PrintWebUIDelegate::drawHeaderInRect):
2817         (PrintWebUIDelegate::drawFooterInRect):
2818         (PrintWebUIDelegate::canRunModal):
2819         (PrintWebUIDelegate::createModalDialog):
2820         (PrintWebUIDelegate::runModal):
2821         (PrintWebUIDelegate::isMenuBarVisible):
2822         (PrintWebUIDelegate::setMenuBarVisible):
2823         (PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
2824         (PrintWebUIDelegate::paintCustomScrollbar):
2825         (PrintWebUIDelegate::paintCustomScrollCorner):
2826         * WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.
2827         (WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
2828         (WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
2829         (WinLauncherWebHost::AddRef): check-webkit-style fixes.
2830         (WinLauncherWebHost::Release): check-webkit-style fixes.
2831         (resizeSubViews): check-webkit-style fixes.
2832         (_tWinMain): check-webkit-style fixes.
2833         (MyRegisterClass): check-webkit-style fixes.
2834         (InitInstance): check-webkit-style fixes.
2835         (AbortProc): New print support function.
2836         (getPrinterDC): New print support function.
2837         (initDocStruct): New print support function.
2838         (PrintView): New printing implementation.
2839         (WndProc): Add support for printing.
2840         (MyEditProc): check-webkit-style fixes.
2841         (About): check-webkit-style fixes.
2842         (loadURL): check-webkit-style fixes.
2843         * WinLauncher/WinLauncher.h:
2844         (WinLauncherWebHost::WinLauncherWebHost):
2845         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
2846         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
2847         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2848         (WinLauncherWebHost::didCommitLoadForFrame):
2849         (WinLauncherWebHost::didReceiveTitle):
2850         (WinLauncherWebHost::didReceiveIcon):
2851         (WinLauncherWebHost::didFinishLoadForFrame):
2852         (WinLauncherWebHost::didFailLoadWithError):
2853         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
2854         (WinLauncherWebHost::willPerformClientRedirectToURL):
2855         (WinLauncherWebHost::didCancelClientRedirectForFrame):
2856         (WinLauncherWebHost::willCloseFrame):
2857         (WinLauncherWebHost::windowScriptObjectAvailable):
2858         * WinLauncher/WinLauncher.rc: Add menu entry for printing.
2859         * WinLauncher/WinLauncher.vcproj: Add new files.
2860         * WinLauncher/resource.h: Add menu entry for printing.
2861
2862 2009-12-19  Adam Barth  <abarth@webkit.org>
2863
2864         Unreviewed.  Tweak the CSS to make the dashboard prettier.
2865
2866         * QueueStatusServer/stylesheets/dashboard.css:
2867         * QueueStatusServer/templates/dashboard.html:
2868
2869 2009-12-19  Adam Barth  <abarth@webkit.org>
2870
2871         Reviewed by Eric Seidel.
2872
2873         QueueStatusServer needs a human readable dashboard
2874         https://bugs.webkit.org/show_bug.cgi?id=32769
2875
2876         Here is a first cut at the dashboard.  There's a lot left to do.
2877
2878         * QueueStatusServer/filters/webkit_extras.py:
2879         * QueueStatusServer/handlers/dashboard.py: Added.
2880         * QueueStatusServer/handlers/patchstatus.py:
2881         * QueueStatusServer/handlers/recentstatus.py:
2882         * QueueStatusServer/handlers/showresults.py:
2883         * QueueStatusServer/handlers/statusbubble.py:
2884         * QueueStatusServer/handlers/updatestatus.py:
2885         * QueueStatusServer/main.py:
2886         * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
2887         * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
2888         * QueueStatusServer/stylesheets/dashboard.css: Added.
2889         * QueueStatusServer/templates/dashboard.html: Added.
2890         * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
2891         * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
2892
2893 2009-12-19  Daniel Bates  <dbates@webkit.org>
2894
2895         Reviewed by Timothy Hatcher.
2896
2897         https://bugs.webkit.org/show_bug.cgi?id=32462
2898
2899         Added --inspector-frontend flag to build-webkit to copy any changes
2900         to the inspector front-end files to the built WebCore framework. This
2901         will make inspector development more consistent with the rest of
2902         WebKit development.
2903
2904         * Scripts/build-webkit:
2905         * Scripts/webkitdirs.pm:
2906
2907 2009-12-19  Adam Barth  <abarth@webkit.org>
2908
2909         Unreviewed fixes for me being terrible at python.
2910
2911         * Scripts/modules/bugzilla.py:
2912         * Scripts/run-webkit-unittests:
2913
2914 2009-12-18  Adam Barth  <abarth@webkit.org>
2915
2916         Reviewed by Eric Seidel.
2917
2918         Split QueueStatus server into modules
2919         https://bugs.webkit.org/show_bug.cgi?id=32768
2920
2921         One monolithic file is no good.
2922
2923         * QueueStatusServer/app.yaml:
2924         * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
2925         * QueueStatusServer/handlers/patchstatus.py: Added.
2926         * QueueStatusServer/handlers/recentstatus.py: Added.
2927         * QueueStatusServer/handlers/showresults.py: Added.
2928         * QueueStatusServer/handlers/statusbubble.py: Added.
2929         * QueueStatusServer/handlers/updatestatus.py: Added.
2930         * QueueStatusServer/main.py: Added.
2931         * QueueStatusServer/model.py: Added.
2932         * QueueStatusServer/queue_status.py: Removed.
2933
2934 2009-12-18  Adam Barth  <abarth@webkit.org>
2935
2936         Rubber stamped by Eric Seidel.
2937
2938         Renamed WorkQueue to QueueEngine.  WorkQueue is not a queue.
2939
2940         * Scripts/modules/commands/queues.py:
2941         * Scripts/modules/queueengine.py: Added.
2942         * Scripts/modules/queueengine_unittest.py: Added.
2943         * Scripts/modules/stepsequence.py:
2944         * Scripts/modules/workqueue.py: Removed.
2945         * Scripts/modules/workqueue_unittest.py: Removed.
2946
2947 2009-12-18  Adam Barth  <abarth@webkit.org>
2948
2949         Reviewed by Eric Seidel.
2950
2951         Add watches for EWS
2952         https://bugs.webkit.org/show_bug.cgi?id=32767
2953
2954         dglazkov wanted to be added.
2955
2956         * Scripts/modules/bugzilla.py:
2957         * Scripts/modules/commands/early_warning_system.py:
2958         * Scripts/modules/commands/queues.py:
2959
2960 2009-12-18  Eric Seidel  <eric@webkit.org>
2961
2962         Reviewed by David Levin.
2963
2964         move bugzilla.py off of urllib2
2965         https://bugs.webkit.org/show_bug.cgi?id=32729
2966
2967         * Scripts/modules/bugzilla.py: use mechanize for all url fetching.
2968
2969 2009-12-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2970
2971         Rubber-stamped by Xan Lopez.
2972
2973         [GTK] New events (pageshow and pagehide) tests failing
2974         https://bugs.webkit.org/show_bug.cgi?id=28823
2975
2976         Original patch by Jan Michael Alonzo.
2977
2978         Disable page cache for tests.
2979
2980         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2981         (resetDefaultsToConsistentValues):
2982         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2983         (copyWebSettingKey):
2984         (LayoutTestController::overridePreference):
2985
2986 2009-12-18  Fumitoshi Ukai  <ukai@chromium.org>
2987
2988         Reviewed by David Levin.
2989
2990         Check one space before end of line comments.
2991         https://bugs.webkit.org/show_bug.cgi?id=32597
2992         
2993         Fix to check one space before end of line comments in whitespace and build/header_guard.
2994         Also fix build/header_guard to use WebKit header guard defines.
2995
2996         * Scripts/modules/cpp_style.py:
2997         * Scripts/modules/cpp_style_unittest.py:
2998
2999 2009-12-17  Sam Weinig  <sam@webkit.org>
3000
3001         Reviewed by Mark Rowe.
3002
3003         Add BUILDING_ON_SNOW_LEOPARD #define.
3004
3005         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3006
3007 2009-12-17  Yuzo Fujishima  <yuzo@google.com>
3008
3009         Reviewed by Alexey Proskuryakov.
3010
3011         Update pywebsocket to 0.4.5 and make handshake checking stricter
3012         https://bugs.webkit.org/show_bug.cgi?id=32249
3013
3014         * Scripts/run-webkit-tests:
3015         * pywebsocket/mod_pywebsocket/handshake.py:
3016         * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
3017         * pywebsocket/mod_pywebsocket/standalone.py:
3018         * pywebsocket/setup.py:
3019         * pywebsocket/test/test_handshake.py:
3020         * pywebsocket/test/test_memorizingfile.py: Added.
3021
3022 2009-12-17  Eric Seidel  <eric@webkit.org>
3023
3024         Reviewed by Adam Barth.
3025
3026         Command.show_in_main_help should default to False
3027         https://bugs.webkit.org/show_bug.cgi?id=32686
3028
3029         * Scripts/modules/commands/download.py:
3030         * Scripts/modules/commands/queries.py:
3031         * Scripts/modules/commands/queues.py:
3032         * Scripts/modules/commands/upload.py:
3033         * Scripts/modules/multicommandtool.py:
3034
3035 2009-12-17  Alejandro G. Castro  <alex@igalia.com>
3036
3037         Reviewed by Eric Seidel.
3038
3039         Added the key WebKitEnableCaretBrowsing to the
3040         layoutTestController.overridePreference in order to activate caret
3041         browsing.
3042         https://bugs.webkit.org/show_bug.cgi?id=32612
3043
3044         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
3045         the setting.
3046         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
3047         key in the keytable.
3048
3049 2009-12-17  Chris Fleizach  <cfleizach@apple.com>
3050
3051         Reviewed by David Kilzer.
3052
3053         AX: DRT needs to support URL for accessibility
3054         https://bugs.webkit.org/show_bug.cgi?id=32666
3055
3056         * DumpRenderTree/AccessibilityUIElement.cpp:
3057         (getURLCallback):
3058         (AccessibilityUIElement::getJSClass):
3059         * DumpRenderTree/AccessibilityUIElement.h:
3060         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3061         (AccessibilityUIElement::url):
3062         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3063         (AccessibilityUIElement::url):
3064         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3065         (AccessibilityUIElement::url):
3066
3067 2009-12-17  Philippe Normand  <pnormand@igalia.com>
3068
3069         Unreviewed; added myself to committers
3070
3071         * Scripts/modules/committers.py:
3072
3073 2009-12-17  Benjamin Otte  <otte@gnome.org>
3074
3075         Unreviewed; added myself to committers
3076
3077         * Scripts/modules/committers.py:
3078
3079 2009-12-17  Adam Barth  <abarth@webkit.org>
3080
3081         Rubber stamp by Seidel.
3082
3083         Clean up exception handling in WorkQueue.  Basically, a bunch of the
3084         delegate messages can throw exceptions because of network errors.  We
3085         want the queues to keep on ticking instead of erroring out.  That means
3086         we want to catch generic exceptions and continue looping.
3087
3088         Also, cleaned up the exception handling in the EWS to properly log
3089         failures.
3090
3091         * Scripts/modules/commands/early_warning_system.py:
3092         * Scripts/modules/commands/queues.py:
3093         * Scripts/modules/workqueue.py:
3094
3095 2009-12-16  Adam Barth  <abarth@webkit.org>
3096
3097         Reviewed by Eric Seidel.
3098
3099         [bzt] Make UpdateStep quiet
3100         https://bugs.webkit.org/show_bug.cgi?id=32599
3101
3102         * Scripts/modules/buildsteps.py:
3103         * Scripts/modules/buildsteps_unittest.py:
3104
3105 2009-12-16  Evan Martin  <evan@chromium.org>
3106
3107         Reviewed by Adam Barth.
3108
3109         Add Gtk to the early warning system WebKit port list.
3110
3111         https://bugs.webkit.org/show_bug.cgi?id=32629
3112
3113         * Scripts/modules/commands/early_warning_system.py:
3114         * Scripts/modules/webkitport.py:
3115         * Scripts/modules/webkitport_unittest.py:
3116
3117 2009-12-16  Eric Seidel  <eric@webkit.org>
3118
3119         Reviewed by Adam Barth.
3120
3121         post-diff is failing with exception under guess_reviewer_from_bug
3122         https://bugs.webkit.org/show_bug.cgi?id=32642
3123
3124         Also refactor output capturing code into
3125         OutputCapture.assert_outputs to share more code between tests.
3126
3127         * Scripts/modules/buildsteps.py:
3128          - Add the missing include.
3129          - Give guess_reviewer_from_bug a private underscore.
3130         * Scripts/modules/buildsteps_unittest.py: Added.
3131          - Test to make sure _guess_reviewer_from_bug works as expected.
3132         * Scripts/modules/commands/commandtest.py:
3133          - Custom code is now obsoleted by OutputCapture.assert_outputs
3134         * Scripts/modules/commands/queues_unittest.py:
3135          - ditto
3136         * Scripts/modules/credentials_unittest.py:
3137          - ditto
3138         * Scripts/modules/mock_bugzillatool.py:
3139          - fetch_reviewed_patches_from_bug can never return None
3140         * Scripts/modules/multicommandtool_unittest.py:
3141          - Custom code is now obsoleted by OutputCapture.assert_outputs
3142         * Scripts/modules/outputcapture.py:
3143          - Add assert_outputs to share more code between tests.
3144         * Scripts/run-webkit-unittests:
3145          - Add buildsteps_unittest.py
3146
3147 2009-12-16  Adam Barth  <abarth@webkit.org>
3148
3149         Unreviewed.  Added a default argument to _update_status so that callers
3150         don't have to explictly pass None when they don't have a patch object.
3151
3152         * Scripts/modules/commands/queues.py:
3153
3154 2009-12-16  Kent Tamura  <tkent@chromium.org>
3155
3156         Reviewed by David Levin.
3157
3158         check-webkit-style supports for TAB check against text files.
3159         https://bugs.webkit.org/show_bug.cgi?id=32538
3160
3161         * Scripts/check-webkit-style:
3162           Move process_patch() to style.py.
3163         * Scripts/modules/cpp_style.py:
3164           Add can_handle().
3165         * Scripts/modules/cpp_style_unittest.py:
3166           Add tests for can_handle().
3167         * Scripts/modules/style.py:
3168           Added. This is a front-end of cpp_style and text_style. It dispatches
3169           files to an appropriate linter.
3170         * Scripts/modules/text_style.py:
3171           Added. This is a linter module for generic text files. It supports
3172           only for TAB checking at this moment.
3173         * Scripts/modules/text_style_unittest.py:
3174           Added. Tests for text_style.py.
3175         * Scripts/run-webkit-unittests:
3176           Add text_style_unittest.
3177
3178 2009-12-16  Eric Seidel  <eric@webkit.org>
3179
3180         Reviewed by David Levin.
3181
3182         bugzilla-tool should not require users to install mechanize
3183         https://bugs.webkit.org/show_bug.cgi?id=32635
3184
3185         Centralize our import logic.
3186
3187         * Scripts/modules/bugzilla.py: use webkit_mechanize
3188         * Scripts/modules/statusbot.py: use webkit_mechanize
3189         * Scripts/modules/webkit_mechanize.py: Added.
3190
3191 2009-12-16  Eric Seidel  <eric@webkit.org>
3192
3193         Reviewed by Adam Barth.
3194
3195         Generalize commit-queue recent status page for all queues
3196         https://bugs.webkit.org/show_bug.cgi?id=32633
3197
3198         * QueueStatusServer/index.html:
3199          - Generalize to support other queues.
3200         * QueueStatusServer/queue_status.py:
3201          - Generalize MainPage to support other queues.
3202
3203 2009-12-16  Evan Martin  <evan@chromium.org>
3204
3205         Reviewed by Adam Barth.
3206
3207         Early warning system server should display output as UTF-8.
3208
3209         https://bugs.webkit.org/show_bug.cgi?id=32625
3210
3211         * QueueStatusServer/queue_status.py:
3212
3213 2009-12-16  Adam Barth  <abarth@webkit.org>
3214
3215         Reviewed by Eric Seidel.
3216
3217         [bzt] Add error handling to the early warning system
3218         https://bugs.webkit.org/show_bug.cgi?id=32594
3219
3220         This should be the last step in making the EWS operational.  When we
3221         have a build error, we post the log to QueueStatusServer and add a link
3222         to the bug.
3223
3224         * Scripts/modules/commands/early_warning_system.py:
3225         * Scripts/modules/commands/queues.py:
3226         * Scripts/modules/executive.py:
3227
3228 2009-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
3229
3230         Reviewed by Holger Freyther.
3231
3232         Fix crash with tests that use custom font faces.
3233
3234         https://bugs.webkit.org/show_bug.cgi?id=32600
3235
3236         In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
3237         that custom font faces between tests don't influence each other. Calling this
3238         function in Qt however also invalidates all existing handles with QFontDatabase.
3239
3240         In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
3241         which implies a call to WebCore::FontCache::fontCache()->invalidate().
3242
3243         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3244         (WebCore::DumpRenderTree::open):
3245
3246 2009-12-16  Andreas Kling  <andreas.kling@nokia.com>
3247
3248         Reviewed by Simon Hausmann.
3249
3250         [Qt] Maintain button state between mouse events.
3251
3252         This allows eventSender to generate drag events.
3253
3254         https://bugs.webkit.org/show_bug.cgi?id=32601
3255
3256         * DumpRenderTree/qt/EventSenderQt.cpp:
3257         (EventSender::mouseDown):
3258         (EventSender::mouseUp):
3259         (EventSender::mouseMoveTo):
3260         * DumpRenderTree/qt/EventSenderQt.h:
3261
3262 2009-12-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
3263
3264         Reviewed by David Levin.
3265
3266         Code clean-up in check-webkit-style as described below.
3267         The only functional changes are minor improvements to the
3268         script's help output.
3269         
3270         https://bugs.webkit.org/show_bug.cgi?id=32487
3271
3272         * Scripts/check-webkit-style:
3273           - Added the module docstring from cpp_style.py.
3274           - Improved wording of the --help output and added some of the
3275             default values as substitution strings.
3276           - Called cpp_style.exit_with_usage instead of sys.stderr.write
3277             in main function.
3278           - Made changes caused by changes to cpp_style.py.
3279
3280         * Scripts/modules/cpp_style.py:
3281           - Removed module docstring, as well as redundant _USAGE string
3282             and main() function obsoleted by check-webkit-style.
3283           - Moved specification of default script values from within a
3284             function definition to global variables.
3285           - Moved the default webkit filter rules to be near the other
3286             global variables.
3287           - Renamed "FILTER" global variables to "FILTER_RULES" to
3288             establish unambiguous terminology.
3289           - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
3290           - Changed _STYLE_CATEGORIES from a string to a list.
3291           - Added default webkit filter rules to --filter= output.
3292           - Renamed "print_" methods to "exit_with_" since they exist
3293             and added a temporary display_help parameter.
3294           - Added a temporary display_help parameter to parse_arguments.
3295
3296         * Scripts/modules/cpp_style_unittest.py:
3297           - Made changes caused by changes to cpp_style.py.
3298           - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 
3299             variables since they are not global.
3300
3301 2009-12-15  Adam Barth  <abarth@webkit.org>
3302
3303         Unreviewed fix for the style-queue.
3304         Typo: _updates_status -> _update_status
3305
3306         We need to improve our testing infrastructure for the queues.
3307
3308         * Scripts/modules/commands/queues.py:
3309
3310 2009-12-15  Adam Barth  <abarth@webkit.org>
3311
3312         Unreviewed fix for the style-queue.  I suspect this is a recent
3313         regression from Eric's change below.
3314
3315         * Scripts/modules/commands/queues.py:
3316
3317 2009-12-15  Yaar Schnitman  <yaar@chromium.org>
3318
3319         Reviewed by Darin Fisher.
3320
3321         update-webkit-chromium to auto-install gclient
3322
3323         https://bugs.webkit.org/show_bug.cgi?id=32587
3324
3325         * Scripts/update-webkit-chromium:
3326
3327 2009-12-15  Eric Seidel  <eric@webkit.org>
3328
3329         Reviewed by Adam Barth.
3330
3331         bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
3332         https://bugs.webkit.org/show_bug.cgi?id=32546
3333
3334         You can see an example of this working in:
3335         https://bugs.webkit.org/show_bug.cgi?id=32585#c3
3336
3337         * QueueStatusServer/queue_status.py:
3338          - Output the id of the newly created status.
3339         * Scripts/modules/commands/queues.py:
3340          - Tweak the commit-queue logging to include a full status link.
3341         * Scripts/modules/statusbot.py:
3342          - update_status should return the newly created status id.
3343
3344 2009-12-15  Andras Becsi  <abecsi@inf.u-szeged.hu>
3345
3346         Reviewed by Tor Arne Vestbø.
3347
3348         [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
3349
3350         * DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
3351         * DumpRenderTree/qt/DumpRenderTree.h: Removed.
3352         * DumpRenderTree/qt/DumpRenderTree.pro: Updated.
3353         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
3354         * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
3355         * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
3356         (GCController::GCController):
3357         * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
3358         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3359         * DumpRenderTree/qt/WorkQueueItem.h: Removed.
3360         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
3361         * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
3362         * DumpRenderTree/qt/jsobjects.cpp: Removed.
3363         * DumpRenderTree/qt/jsobjects.h: Removed.
3364         * DumpRenderTree/qt/main.cpp: Updated includes.
3365
3366 2009-12-15  Adam Barth  <abarth@webkit.org>
3367
3368         Reviewed by Eric Seidel.
3369
3370         We have two mark-fixed commands
3371         https://bugs.webkit.org/show_bug.cgi?id=32073
3372
3373         * Scripts/mark-bug-fixed: Removed.
3374         * Scripts/modules/commands/upload.py:
3375         * Scripts/modules/commands/upload_unittest.py:
3376
3377 2009-12-15  Eric Seidel  <eric@webkit.org>
3378
3379         Reviewed by Adam Barth.
3380
3381         bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
3382         https://bugs.webkit.org/show_bug.cgi?id=28286
3383
3384         * QueueStatusServer/index.html:
3385          - Show [results] links if a results log was uploaded.
3386         * QueueStatusServer/queue_status.py:
3387          - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
3388         * Scripts/modules/commands/queues.py:
3389          - Post to the status bot when a patch fails and include the failure log as a results file.
3390
3391 2009-12-15  Eric Seidel  <eric@webkit.org>
3392
3393         Reviewed by Adam Barth.
3394
3395         queue sub-commands need --status-host so they can report status
3396         https://bugs.webkit.org/show_bug.cgi?id=32313
3397
3398         Make --status-bot a global option and make
3399         run_bugzilla_tool pass --status-bot to sub-commands.
3400
3401         * Scripts/bugzilla-tool:
3402          - Rename _status to status_bot and make it non-lazy.
3403         * Scripts/modules/commands/queues.py:
3404          - Move status updates out of WorkQueue and into individual queues.
3405         * Scripts/modules/commands/queues_unittest.py:
3406          - Test that --status-host is passed to bugzilla-tool when run as subcommand.
3407         * Scripts/modules/mock_bugzillatool.py:
3408          - Add a MockStatusBot
3409         * Scripts/modules/workqueue.py:
3410          - Remove status_host and work_work_logs_directory callbacks.
3411          - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
3412         * Scripts/modules/workqueue_unittest.py:
3413          - Update unit tests to reflect new callbacks.
3414
3415 2009-12-15  Adam Barth  <abarth@webkit.org>
3416
3417         Reviewed by Eric Seidel.
3418
3419         scm_unittest.py is too slow
3420         https://bugs.webkit.org/show_bug.cgi?id=31818
3421
3422         Now we don't run the SCM unit tests unless we get the --all flag on the
3423         command line.  Eric and I were commenting out this test because it was
3424         too painful to run.
3425
3426         * Scripts/run-webkit-unittests:
3427
3428 2009-12-14  Adam Barth  <abarth@webkit.org>
3429
3430         Unreviewed.  Fix failing unittest.
3431
3432         * Scripts/modules/bugzilla_unittest.py:
3433
3434 2009-12-14  Eric Seidel  <eric@webkit.org>
3435
3436         Reviewed by Adam Barth.
3437
3438         Move Credential handling out into a separate module
3439         https://bugs.webkit.org/show_bug.cgi?id=32531
3440
3441         * Scripts/modules/bugzilla.py:
3442         * Scripts/modules/credentials.py: Added.
3443         * Scripts/modules/credentials_unittest.py: Added.
3444         * Scripts/run-webkit-unittests:
3445
3446 2009-12-14  Adam Barth  <abarth@webkit.org>
3447
3448         Reviewed by Eric Seidel.
3449
3450         Kill _create_step_sequence
3451         https://bugs.webkit.org/show_bug.cgi?id=32539
3452
3453         It's cleaner to represent not having these sequences as an empty
3454         sequence instead of None.
3455
3456         * Scripts/modules/commands/download.py:
3457         * Scripts/modules/stepsequence.py:
3458
3459 2009-12-14  Adam Barth  <abarth@webkit.org>
3460
3461         Unreviewed.  Address reviewer comments from an earlier patch.  I didn't
3462         do this earlier because I was worried about conflicts in dependent
3463         patches.
3464
3465         * Scripts/modules/commands/download.py:
3466
3467 2009-12-14  Adam Barth  <abarth@webkit.org>
3468
3469         Reviewed by Eric Seidel.
3470
3471         [bzt] Make download commands declarative
3472         https://bugs.webkit.org/show_bug.cgi?id=32469
3473
3474         This patch "properly" factors most of the download commands.  These
3475         commands are now largely declarative, which is the final step of this
3476         grand refactoring.
3477
3478         * Scripts/modules/buildsteps.py:
3479         * Scripts/modules/commands/download.py:
3480
3481 2009-12-14  Adam Barth  <abarth@webkit.org>
3482
3483         Reviewed by Eric Seidel.
3484
3485         [bzt] Add AbstractPatchSequencingCommand to remove redundant code
3486         https://bugs.webkit.org/show_bug.cgi?id=32468
3487
3488         Redundant code is bad.  This patch moves us towards more declarative
3489         commands.
3490
3491         * Scripts/modules/commands/download.py:
3492
3493 2009-12-14  Adam Barth  <abarth@webkit.org>
3494
3495         Reviewed by Eric Seidel.
3496
3497         [bzt] Kill WebKitApplyingScripts
3498         https://bugs.webkit.org/show_bug.cgi?id=32467
3499
3500         Ah!  I've been wanting to do this for a long time.  This patch brings
3501         the applying commands into the patch processing fold.
3502
3503         * Scripts/bugzilla-tool:
3504         * Scripts/modules/buildsteps.py:
3505         * Scripts/modules/commands/download.py:
3506         * Scripts/modules/commands/download_unittest.py:
3507         * Scripts/modules/mock_bugzillatool.py:
3508
3509 2009-12-14  Adam Barth  <abarth@webkit.org>
3510
3511         Reviewed by Eric Seidel.
3512
3513         [bzt] Convert rollout to StepSequence
3514         https://bugs.webkit.org/show_bug.cgi?id=32406
3515
3516         * Scripts/modules/buildsteps.py:
3517         * Scripts/modules/commands/download.py:
3518         * Scripts/modules/commands/download_unittest.py:
3519         * Scripts/modules/mock_bugzillatool.py:
3520
3521 2009-12-14  Adam Barth  <abarth@webkit.org>
3522
3523         Reviewed by Eric Seidel.
3524
3525         [bzt] Kill LandingSequence
3526         https://bugs.webkit.org/show_bug.cgi?id=32464
3527
3528         Removes LandingSequence in favor of StepSequence.  This required
3529         changing the Step API slightly to carry a general notion of state
3530         instead of carrying patches specifically.
3531
3532         * Scripts/modules/buildsteps.py:
3533         * Scripts/modules/commands/download.py:
3534         * Scripts/modules/commands/queues.py:
3535         * Scripts/modules/landingsequence.py: Removed.
3536         * Scripts/modules/stepsequence.py:
3537
3538 2009-12-14  Robert Hogan  <robert@roberthogan.net>
3539
3540         Reviewed by Eric Seidel.
3541
3542         [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437
3543         
3544         Amend the behaviour of DRT::notifyDone to dump only when
3545         the page has finished loading.
3546         
3547         This fix permits removal of the following tests from the Qt skipped list:
3548         fast/forms/textarea-linewrap-dynamic.html
3549         fast/forms/textarea-setvalue-submit.html
3550         fast/forms/textarea-hard-linewrap-empty.html
3551         fast/forms/submit-to-url-fragment.html
3552         http/tests/misc/percent-sign-in-form-field-name.html
3553         http/tests/security/escape-form-data-field-names.html
3554         
3555         However it also requires the following two to be added to the skipped list:
3556         
3557         http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
3558         svg/custom/use-instanceRoot-as-event-target.xhtml
3559         
3560         It appears the behaviour of notifyDone was masking problems with these two
3561         tests.
3562
3563         * DumpRenderTree/qt/DumpRenderTree.cpp:
3564         (WebCore::DumpRenderTree::DumpRenderTree):
3565         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3566         (LayoutTestController::reset):
3567         (LayoutTestController::processWork):
3568         (LayoutTestController::maybeDump):
3569         (LayoutTestController::notifyDone):
3570         (LayoutTestController::provisionalLoad):
3571         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3572         (LayoutTestController::resetLoadFinished):
3573
3574 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
3575
3576         Reviewed by Holger Freyther.
3577
3578         [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
3579
3580         https://bugs.webkit.org/show_bug.cgi?id=32482
3581
3582         * DumpRenderTree/qt/EventSenderQt.cpp:
3583         (EventSender::setTouchModifier):
3584         (EventSender::clearTouchPoints):
3585         (EventSender::sendTouchEvent):
3586         * DumpRenderTree/qt/EventSenderQt.h:
3587
3588 2009-12-13  Maciej Stachowiak  <mjs@apple.com>
3589
3590         Reviewed by Gavin Barraclaugh.
3591
3592         Fix minor problem in sunspider-compare-results which left it broken.
3593
3594         * Scripts/sunspider-compare-results: Declare $parseonly
3595
3596 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
3597
3598         Reviewed by Oliver Hunt.
3599
3600         Give command-line sunspider the ability to handle multiple suites and versions
3601         https://bugs.webkit.org/show_bug.cgi?id=32477
3602
3603         * Scripts/run-sunspider: Updated for changes to command-line parameters.
3604         * Scripts/sunspider-compare-results: ditto
3605
3606 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
3607
3608         Not reviewed, fixing previous comment.
3609
3610         Remove accidental change to sunspider-compare-results
3611