2010-10-08 Balazs Kelemen <kbalazs@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2
3         Reviewed by Andreas Kling.
4
5         [Qt] TestController needs its platform dependent methods
6         https://bugs.webkit.org/show_bug.cgi?id=47413
7
8         * WebKitTestRunner/qt/TestControllerQt.cpp:
9         (WTR::TestController::initializeInjectedBundlePath):
10         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
11         set then use that otherwise use the path where the bundle
12         lives in a normal trunk build.
13         (WTR::TestController::initializeTestPluginDirectory):
14         Set the bundle's value. It is not used currently.
15         (WTR::TestController::platformInitializeContext):
16         * WebKitTestRunner/qt/WebKitTestRunner.pro:
17
18 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
19
20         Reviewed by Kenneth Rohde Christiansen.
21
22         WTR: Prevent sending the Done message twice on test timeout.
23         https://bugs.webkit.org/show_bug.cgi?id=47410
24
25         When InjectedBundle::done() calls stopLoading, this may trigger
26         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
27         InjectedBundle::done() itself later in the stack.
28         This would output the timeout failure message twice and confuse
29         the run-webkit-tests script.
30
31         This patch adds a third state, Stopping, which prevents WebCore
32         errors to trigger done() when testing is over.
33
34         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
35         (WTR::InjectedBundle::done):
36         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
37
38 2010-10-08  Andras Becsi  <abecsi@webkit.org>
39
40         Reviewed by Kenneth Rohde Christiansen.
41
42         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
43         Original code by Simon Hausmann.
44         https://bugs.webkit.org/show_bug.cgi?id=47402
45
46         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
47         (WTR::activateFonts):
48
49 2010-10-08  Andras Becsi  <abecsi@webkit.org>
50
51         Reviewed by Csaba Osztrogonác.
52
53         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
54         https://bugs.webkit.org/show_bug.cgi?id=47401
55
56         * Scripts/build-webkittestrunner:
57         * Scripts/old-run-webkit-tests:
58
59 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
60
61         Reviewed by Kenneth Rohde Christiansen.
62
63         [Qt] WTR first compile: fix compile issues.
64         https://bugs.webkit.org/show_bug.cgi?id=47343
65
66         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
67         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
68         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
69         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
70         * WebKitTestRunner/TestController.cpp:
71         * WebKitTestRunner/TestInvocation.cpp:
72
73 2010-10-07  Antonio Gomes  <agomes@rim.com>
74
75         Reviewed by Simon Fraser.
76
77         [Mac] [DRT] implement setSpatialNavigationEnabled
78         https://bugs.webkit.org/show_bug.cgi?id=47291
79
80         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
81         so it can track regression on the existing implementation and future improvements
82         we are making.
83
84         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
85         (LayoutTestController::setSpatialNavigationEnabled):
86
87 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
88
89         Reviewed by Adam Barth.
90
91         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
92         hook in the Port infrastructure to generate URIs for the files
93         in its summary HTML report; however, that method is supposed to only
94         be used for test files (and should really be renamed), so this would
95         crash.
96
97         This change adds a new "path" module to the system package with a
98         routine called abspath_to_uri() that handles converting paths to
99         file: URIs independently of anything in the layout_tests package,
100         and changes the code to use this. At some point in the near future
101         the layout_tests/port/* code should use this as well.
102
103         This change also deletes a bunch of unused code and fixes some
104         comments in rebaseline_chromium_webkit_tests.py.
105
106         https://bugs.webkit.org/show_bug.cgi?id=47319
107
108         * Scripts/webkitpy/common/system/path.py: Added.
109         * Scripts/webkitpy/common/system/path_unittest.py: Added.
110         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
111         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
112
113 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
114
115         Reviewed by Gustavo Noronha Silva.
116
117         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
118         https://bugs.webkit.org/show_bug.cgi?id=46216
119
120         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
121
122         * DumpRenderTree/gtk/DumpRenderTree.cpp:
123         (initializeFonts): Also initialize the DevaVu Sans font.
124
125 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
126
127         Reviewed by Tony Chang.
128
129         [chromium] Minor naming cleanup in WebDragData, part 2
130         https://bugs.webkit.org/show_bug.cgi?id=47227
131
132         Update DRT to use the renamed methods.
133
134         * DumpRenderTree/chromium/EventSender.cpp:
135         (EventSender::beginDragWithFiles):
136         * DumpRenderTree/chromium/WebViewHost.cpp:
137         (addDRTFakeFileToDataObject):
138
139 2010-10-07  Anders Carlsson  <andersca@apple.com>
140
141         Reviewed by Sam Weinig.
142
143         Add a WKPageFindClient, hook up WKPageCountStringMatches
144         https://bugs.webkit.org/show_bug.cgi?id=47373
145
146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
147         Remove hard coded paths.
148
149         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
150         (TestWebKitAPI::TEST):
151         Fix expected result.
152
153         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
154         (TestWebKitAPI::didFinishLoadForFrame):
155         (TestWebKitAPI::didCountStringMatches):
156         (TestWebKitAPI::TEST):
157         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
158         Add test for WKPageCountStringMatches.
159
160 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
161
162         Reviewed by Chris Fleizach.
163
164         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
165         https://bugs.webkit.org/show_bug.cgi?id=46216
166
167         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
168         for DejaVu Serif when there is no bold version available. This is necessary to
169         properly test the property in layout tests.
170
171 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
172
173         Reviewed by Kenneth Rohde Christiansen.
174
175         [Qt] Add WTR's InjectedBundle build files.
176         https://bugs.webkit.org/show_bug.cgi?id=47333
177
178         * Scripts/webkitdirs.pm:
179         * WebKitTestRunner/DerivedSources.pro: Added.
180         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
181         * WebKitTestRunner/WebKitTestRunner.pro: Added.
182         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
183         Content merged in ../DerivedSources.pro
184
185 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
186
187         Unreviewed, rolling out r69315.
188         http://trac.webkit.org/changeset/69315
189         https://bugs.webkit.org/show_bug.cgi?id=47363
190
191         Forgot to add the new files (Requested by kbalazs on #webkit).
192
193         * Scripts/webkitdirs.pm:
194         * WebKitTestRunner/qt/DerivedSources.pro: Added.
195
196 2010-10-07  Sam Weinig  <sam@webkit.org>
197
198         Reviewed by Anders Carlsson.
199
200         Change API tester to ask the executable for the list of all
201         tests instead of relying on the directory structure.
202         https://bugs.webkit.org/show_bug.cgi?id=47359
203
204         * Scripts/run-test-webkit-api: Added.
205         * Scripts/webkitdirs.pm:
206         Add additional script to just launch the api tester with the correct settings.
207
208         * Scripts/run-api-tests:
209         Change to use the new --dump-tests options to build the list of tests and change
210         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
211
212         * TestWebKitAPI/Test.h:
213         (TestWebKitAPI::Test::Register::Register):
214         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
215         (TestWebKitAPI::TEST):
216         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
217         (TestWebKitAPI::TEST):
218         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
219         (TestWebKitAPI::TEST):
220         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
221         (TestWebKitAPI::TEST):
222         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
223         (TestWebKitAPI::TEST):
224         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
225         (TestWebKitAPI::TEST):
226         Give each test a suite name in addition to the test name.
227
228         * TestWebKitAPI/TestsController.cpp:
229         (TestWebKitAPI::TestsController::dumpTestNames):
230         (TestWebKitAPI::TestsController::runTestNamed):
231         * TestWebKitAPI/TestsController.h:
232         * TestWebKitAPI/mac/main.mm:
233         (main):
234         Add option to print all registered tests.
235
236 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
237
238         Reviewed by Kenneth Rohde Christiansen.
239
240         [Qt] Add WTR's InjectedBundle build files.
241         https://bugs.webkit.org/show_bug.cgi?id=47333
242
243         * Scripts/webkitdirs.pm:
244         * WebKitTestRunner/DerivedSources.pro: Added.
245         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
246         * WebKitTestRunner/WebKitTestRunner.pro: Added.
247         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
248         Content merged in ../DerivedSources.pro
249
250 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
251
252         Unreviewed. Do a renaming that was recommended by the reviewer
253         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
254
255         * WebKitTestRunner/qt/TestControllerQt.cpp:
256         (WTR::RunUntilConditionLoop::start):
257         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
258         (WTR::TestController::runUntil):
259
260 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
261
262         Reviewed by Kenneth Rohde Christiansen.
263
264         [Qt] Watchdog timer implementation for WTR
265         https://bugs.webkit.org/show_bug.cgi?id=47337
266
267         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
268         the definition of the timer type to a typedef.
269         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
270         Timer implementation with QTimer and a helper QObject class.
271         (WTR::WatchdogTimerHelper::instance):
272         (WTR::WatchdogTimerHelper::timerFired):
273         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
274         (WTR::LayoutTestController::platformInitialize):
275         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
276         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
277
278 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
279
280         Unreviewed buildfix for 69297 again
281
282         * WebKitTestRunner/TestController.cpp:
283         (WTR::blankURL):
284
285 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
286
287         Unreviewed trivial build fix for r69297
288
289         * WebKitTestRunner/TestController.cpp:
290         (WTR::blankURL):
291
292 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
293
294         Reviewed by Kenneth Rohde Christiansen.
295
296         WebKitTestRunner should be portable
297         https://bugs.webkit.org/show_bug.cgi?id=45393
298
299         Use only the WebKit API for working with urls.
300         * WebKitTestRunner/StringFunctions.h:
301         (WTR::createWKURL):
302         * WebKitTestRunner/TestController.cpp:
303         (WTR::blankURL):
304         (WTR::TestController::resetStateToConsistentValues):
305         (WTR::TestController::didFinishLoadForFrame):
306
307 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
308
309         Reviewed by Xan Lopez.
310
311         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
312         https://bugs.webkit.org/show_bug.cgi?id=47332
313
314         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
315         (createBitmapContextFromWebView):
316
317 2010-10-06  Chris Guillory  <chris.guillory@google.com>
318
319         Reviewed by Chris Fleizach.
320
321         Remove unused accessibility functions from webkit.
322         https://bugs.webkit.org/attachment.cgi?bugid=46707
323
324         * DumpRenderTree/chromium/WebViewHost.cpp:
325         (WebViewHost::postAccessibilityNotification):
326         * DumpRenderTree/chromium/WebViewHost.h:
327
328 2010-10-06  Lucas Forschler  <lforschler@apple.com>
329
330         Reviewed by Adam Roben.
331
332         Fix the sunspider-compare-results to actually use the passed in value for $root.
333
334         * Scripts/sunspider-compare-results:
335
336 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
337
338         Reviewed by Kenneth Rohde Christiansen.
339
340         [Qt] Runloop implementation for WTR
341         https://bugs.webkit.org/show_bug.cgi?id=47280
342
343         * WebKitTestRunner/qt/TestControllerQt.cpp:
344         Implemented TestController::runUntil by a timerEvent
345         and a QEventLoop. We step into the event loop from runUntil.
346         While we are waiting in the loop a timerEvent is periodically
347         checking the value of the condition. Once the condition has
348         becoming true the timerEvent wakes us up.
349         (WTR::RunUntilLoop::start):
350         (WTR::RunUntilLoop::RunUntilLoop):
351         (WTR::RunUntilLoop::run):
352         (WTR::RunUntilLoop::timerEvent):
353         (WTR::TestController::platformInitialize):
354         (WTR::TestController::runUntil):
355         * WebKitTestRunner/qt/main.cpp:
356         Start the main event loop first and creating the TestController later.
357         (Launcher::Launcher):
358         (Launcher::~Launcher):
359         (Launcher::launch): Creating the TestController.
360         (main): Setting up a timer for calling Launcher::launch from
361         the main event loop.
362
363 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
364
365         Reviewed by Kenneth Russell.
366
367         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
368         enable 'accelerated-composting' instead of 'accelerated-compositing'.
369
370         https://bugs.webkit.org/show_bug.cgi?id=47312
371
372         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
373         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
374
375 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
376
377         Reviewed by Kenneth Rohde Christiansen.
378
379         [Qt] PlatformWebView implementation for WebKitTestRunner
380         https://bugs.webkit.org/show_bug.cgi?id=47276
381
382         The implementation follows the way how
383         we use the API in MiniBrowser.
384         * WebKitTestRunner/PlatformWebView.h:
385         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
386         (WTR::WebView::wkView):
387         (WTR::WebView::~WebView):
388         (WTR::WebView::WebView):
389         (WTR::PlatformWebView::PlatformWebView):
390         (WTR::PlatformWebView::~PlatformWebView):
391         (WTR::PlatformWebView::resizeTo):
392         (WTR::PlatformWebView::page):
393         (WTR::PlatformWebView::focus):
394         * WebKitTestRunner/qt/WebKitTestRunner.pro:
395
396 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
397
398         Reviewed by Kenneth Rohde Christiansen.
399
400         [Qt] Add WebKitTestRunner's build files
401         https://bugs.webkit.org/show_bug.cgi?id=44155
402
403         Parts was taken by Zoltan Horvath's patch.
404
405         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
406         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
407         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
408         PlatformWKView and PlatformWindow (void* for now).
409         Buildfix the case when __APPLE__ is not defined.
410         * WebKitTestRunner/qt/DerivedSources.pro: Added.
411         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
412         Empty stub implementation.
413         (WTR::registerWindowClass):
414         (WTR::PlatformWebView::PlatformWebView):
415         (WTR::PlatformWebView::~PlatformWebView):
416         (WTR::PlatformWebView::resizeTo):
417         (WTR::PlatformWebView::page):
418         (WTR::PlatformWebView::focus):
419         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
420         Empty stub implementation.
421         (WTR::registerWindowClass):
422         (WTR::TestController::runUntil):
423         (WTR::TestController::platformInitialize):
424         (WTR::TestController::initializeInjectedBundlePath):
425         (WTR::TestController::initializeTestPluginDirectory):
426         (WTR::TestController::platformInitializeContext):
427         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
428         * WebKitTestRunner/qt/main.cpp: Added.
429         (main):
430
431 2010-10-06  Tony Chang  <tony@chromium.org>
432
433         Unreviewed, rolling out r69202.
434         http://trac.webkit.org/changeset/69202
435         https://bugs.webkit.org/show_bug.cgi?id=46937
436
437         Broke compile of test_shell
438
439         * DumpRenderTree/chromium/EventSender.cpp:
440         (EventSender::beginDragWithFiles):
441         * DumpRenderTree/chromium/WebViewHost.cpp:
442         (addDRTFakeFileToDataObject):
443
444 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
445
446         Reviewed by Tony Chang.
447
448         [chromium] Minor naming cleanup in WebDragData, part 2
449         https://bugs.webkit.org/show_bug.cgi?id=46937
450
451         Update DRT to use the renamed methods.
452
453         * DumpRenderTree/chromium/EventSender.cpp:
454         (EventSender::beginDragWithFiles):
455         * DumpRenderTree/chromium/WebViewHost.cpp:
456         (addDRTFakeFileToDataObject):
457
458 2010-10-06  David Kilzer  <ddkilzer@apple.com>
459
460         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
461
462         Reviewed by Adam Roben.
463
464         This is the first step in making webarchive tests work on
465         Windows.
466
467         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
468         new files to the project.
469         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
470         to WebArchiveDumpSupport.mm.
471         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
472         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
473         (serializeWebArchiveToXML):
474
475 2010-10-05  Daniel Bates  <dbates@rim.com>
476
477         Reviewed by David Kilzer.
478
479         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
480         https://bugs.webkit.org/show_bug.cgi?id=46058
481
482         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
483         structure so as to support returning additional information
484         about a change log diff.
485
486         Currently, VCSUtils::fixChangeLogPatch() returns a string that
487         represents the change log diff. Towards supporting the return
488         of additional information, such as whether the change log diff
489         inserts an entry at the top of the ChangeLog file, we need to
490         make VCSUtils::fixChangeLogPatch() return a reference to hash
491         structure.
492
493         * Scripts/VCSUtils.pm:
494           - Modified fixChangeLogPatch() to return a reference to a
495             hash structure.
496           - Added documentation to fixChangeLogPatch().
497           - Modified call site in mergeChangeLogs() as necessary.
498         * Scripts/svn-apply:
499           - Modified call site in patch() as necessary.
500         * Scripts/svn-create-patch:
501           - Modified call site in generateDiff() as necessary.
502         * Scripts/svn-unapply:
503           - Modified call site in patch() as necessary.
504         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
505           - Modified the unit tests as necessary.
506
507 2010-10-05  Tony Chang  <tony@chromium.org>
508
509         Reviewed by Darin Adler.
510
511         fix the link to the expected image on windows
512         https://bugs.webkit.org/show_bug.cgi?id=47228
513
514         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
515             windows, the file must be opened in binary mode when writing
516             binary data.
517
518 2010-10-05  Adam Barth  <abarth@webkit.org>
519
520         Update expected result of unittest to match Tony's change below.
521
522         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
523
524 2010-10-05  Tony Chang  <tony@chromium.org>
525
526         Reviewed by Ojan Vafai (over the shoulder).
527
528         Paper over errors in image_diff so we don't crash the whole test run.
529
530         * Scripts/webkitpy/layout_tests/port/chromium.py:
531
532 2010-10-05  Tony Chang  <tony@chromium.org>
533
534         Unreviewed, make shutil.rmtree more resiliant to errors
535         since windows was raising WindowsError: The process cannot access the file because it
536         is being used by another process.
537
538         * Scripts/webkitpy/layout_tests/port/chromium.py:
539
540 2010-10-05  Tony Chang  <tony@chromium.org>
541
542         Reviewed by Ojan Vafai.
543
544         [chromium] fix image diffing in NRWT
545         https://bugs.webkit.org/show_bug.cgi?id=47128
546
547         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
548             NamedTemporaryFile since it doesn't work on Windows.
549         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
550
551 2010-10-05  Kenneth Russell  <kbr@google.com>
552
553         Reviewed by Tony Chang.
554
555         [chromium] Implement layerTreeAsText in DumpRenderTree
556         https://bugs.webkit.org/show_bug.cgi?id=47216
557
558         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
559         make it callable from DumpRenderTree.
560
561         No new tests; verified with existing compositor layout tests.
562
563         * DumpRenderTree/chromium/LayoutTestController.cpp:
564         (LayoutTestController::LayoutTestController):
565         (LayoutTestController::layerTreeAsText):
566         * DumpRenderTree/chromium/LayoutTestController.h:
567
568 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
569
570         Unreviewed build correction.
571
572         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
573         property sheet so proper libraries are linked.
574
575 2010-10-05  Robert Hogan  <robert@webkit.org>
576
577         Reviewed by Andreas Kling.
578
579         [Qt] Fix url conversion in QWebHistory
580
581         Converting from KURL to WFT::String to QUrl does not
582         permit proper percent encoding later.
583
584         https://bugs.webkit.org/show_bug.cgi?id=47048
585
586         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
587         (WebCore::dumpHistoryItem):
588
589 2010-10-05  Anders Carlsson  <andersca@apple.com>
590
591         Reviewed by Sam Weinig.
592
593         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
594         https://bugs.webkit.org/show_bug.cgi?id=47188
595         <rdar://problem/8514104>
596
597         When constructing the std::string, use the real string length instead of the maximum buffer size.
598
599         * TestWebKitAPI/PlatformUtilities.h:
600         (TestWebKitAPI::Util::toSTD):
601         * WebKitTestRunner/StringFunctions.h:
602         (WTR::toSTD):
603
604 2010-10-04  Sam Weinig  <sam@webkit.org>
605
606         Reviewed by Mark Rowe.
607
608         Add MIMEType accessor to WKFrame
609         <rdar://problem/8347683>
610         https://bugs.webkit.org/show_bug.cgi?id=47138
611
612         * TestWebKitAPI/PlatformUtilities.h:
613         (TestWebKitAPI::Util::toSTD):
614         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
615         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
616         (TestWebKitAPI::didStartProvisionalLoadForFrame):
617         (TestWebKitAPI::didCommitLoadForFrame):
618         (TestWebKitAPI::didFinishLoadForFrame):
619         (TestWebKitAPI::TEST):
620         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
621         (TestWebKitAPI::didStartProvisionalLoadForFrame):
622         (TestWebKitAPI::didCommitLoadForFrame):
623         (TestWebKitAPI::didFinishLoadForFrame):
624         (TestWebKitAPI::TEST):
625         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
626         (TestWebKitAPI::TEST):
627         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
628         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
629         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
630         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
631         (TestWebKitAPI::Util::createURLForResource):
632
633 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
634
635         Reviewed by Ojan Vafai.
636
637         [NRWT] Rename current_dir to current_group because it's not a directory
638         https://bugs.webkit.org/show_bug.cgi?id=47169
639
640         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
641         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
642
643 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
644
645         Unreviewed, build fix.
646
647         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
648         which can't always be done. This test uses tempfile.mkdtemp(), which
649         should be safe.
650
651         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
652
653 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
654
655         Unreviewed, build fix.
656
657         Add missing "from __future__ import with_statement" that was
658         breaking test-webkitpy on the Leopard bots (broke in r69040).
659
660         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
661
662 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
663
664         Unreviewed, rolling out r69066.
665         http://trac.webkit.org/changeset/69066
666         https://bugs.webkit.org/show_bug.cgi?id=47163
667
668         Made NRWT reliability worse. (Requested by tkent on #webkit).
669
670         * Scripts/webkitpy/layout_tests/port/chromium.py:
671         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
672
673 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
674
675         Reviewed by Tony Chang.
676
677         [NRWT] Reverse the http tests to alphabetical order.
678         https://bugs.webkit.org/show_bug.cgi?id=47075
679
680         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
681
682 2010-10-04  Robert Hogan  <robert@webkit.org>
683
684         Reviewed by Andreas Kling.
685
686         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
687
688         We need to queue back and forward navigations in the DRT from the
689         LayoutTestController so that maybeDump() knows about them.
690
691         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
692         (LayoutTestController::queueBackNavigation):
693         (LayoutTestController::queueForwardNavigation):
694
695 2010-10-04  Tony Chang  <tony@chromium.org>
696
697         Reviewed by Kent Tamura.
698
699         [chromium] fix image diffing in NRWT
700         https://bugs.webkit.org/show_bug.cgi?id=47128
701
702         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
703               temp file and check the image_diff error code more carefully
704         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
705
706 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
707
708         Reviewed by Adam Barth.
709
710         aroben's change in r68792 actually broke new-run-webkit-tests when
711         running the DRT code path. His change was intended to fix the
712         way we were converting windows paths to URIs when running under
713         Cygwin (the paths were getting one too many "/" on the front).
714         However, the change ended up breaking the chromium_win port, which
715         had slightly different logic.
716
717         This patch removes the port-specific code and adds tests to make
718         sure we're getting the behavior we expect. The Port object no longer
719         exposes a get_absolute_path() method that can be used outside of
720         of converting test filenames, because it's unreliable otherwise
721         (we don't have the right context to know which conversion is intended).
722
723         https://bugs.webkit.org/show_bug.cgi?id=47140
724
725         * Scripts/webkitpy/layout_tests/port/base.py:
726         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
727         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
728         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
729         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
730
731 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
732
733         Unreviewed, build fix.
734
735         Handle crash introduced in r69040 if we are not running in a
736         Chromium checkout.
737
738         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
739
740 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
741
742         Reviewed by Tony Chang.
743
744         Add a way for us to have test expectations that are specific to the
745         official builds of Google Chrome (as opposed to Chromium). This change
746         looks for an additional "test_expectations_chrome.txt" file in
747         Chromium's repository (webkit/tools/layout_tests), and uses the
748         concatenation of that file and the regular test_expectations.txt
749         file for test overrides.
750
751         https://bugs.webkit.org/show_bug.cgi?id=46854
752
753         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
754         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
755
756 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
757
758         Color tests in the list based on existing pass/fail result.
759         
760         Fix the summary data to account for htmlOnly and nonHTML tests.
761
762         * CSSTestSuiteHarness/harness/harness.css:
763         (#test-list > option.pass):
764         (#test-list > option.fail):
765         (#test-list > option.skipped):
766         * CSSTestSuiteHarness/harness/harness.js:
767         (Test):
768         (Test.prototype.statusForFormat):
769         (TestSuite.prototype.fillTestList):
770         (TestSuite.prototype.updateTestList):
771         (TestSuite.prototype.recordResult):
772         (TestSuite.prototype.markTestCompleted):
773         (TestSuite.prototype.countTestsWithFlag):
774         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
775         (TestSuite.prototype.queryDatabaseForSummary):
776
777 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
778
779         Reviewed by Beth Dakin.
780
781         AX: doAXRangeForLine does not work
782         https://bugs.webkit.org/show_bug.cgi?id=47101
783
784         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
785
786         * DumpRenderTree/AccessibilityUIElement.cpp:
787         (rangeForLineCallback):
788         (AccessibilityUIElement::rangeForLine):
789         (AccessibilityUIElement::getJSClass):
790         * DumpRenderTree/AccessibilityUIElement.h:
791         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
792         (AccessibilityUIElement::rangeForLine):
793
794 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
795
796         Unreviewed. Adding myself to the committers list.
797
798         * Scripts/webkitpy/common/config/committers.py:
799
800 2010-10-04  Sam Weinig  <sam@webkit.org>
801
802         Reviewed by Anders Carlsson.
803
804         Add ability to set the CacheModel in Webkit2
805         https://bugs.webkit.org/show_bug.cgi?id=47066
806
807         * MiniBrowser/mac/AppDelegate.m:
808         (-[BrowserAppDelegate init]): Opt minibrowser into
809         a PrimaryWebBrowser cache model.
810
811 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
812
813         Make sure to enter all tests when creating the database
814         for the first time.
815         
816         When migrating to a new version of the suite, be sure to
817         sync up the database and testinfo.data by removing old
818         tests, and inserting new ones.
819
820         * CSSTestSuiteHarness/harness/harness.js:
821         (TestSuite.prototype.openDatabase.creation):
822         (TestSuite.prototype.databaseCreated):
823         (TestSuite.prototype.populateDatabaseFromTestInfoData):
824         (TestSuite.prototype.insertTest):
825
826 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
827
828         More work on treating HTML4 and XHTML1 independently; when 
829         changing the format, rebuild the test list, and update the 
830         numbers in the chapter popup.
831
832         * CSSTestSuiteHarness/harness/harness.js:
833         (Test):
834         (Test.prototype.runForFormat):
835         (Test.prototype.completedForFormat):
836         (ChapterSection):
837         (ChapterSection.prototype.countTests):
838         (Chapter):
839         (Chapter.prototype.description):
840         (Chapter.prototype.countTests):
841         (Chapter.prototype.testCount):
842         (Chapter.prototype.untestedCount):
843         (TestSuite.prototype.buildChapters):
844         (TestSuite.prototype.loadCurrentTest):
845         (TestSuite.prototype.updateProgressLabel):
846         (TestSuite.prototype.processFlags):
847         (TestSuite.prototype.formatChanged):
848
849 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
850
851         Update test suite version 20101001.
852         
853         Handle database migration, and delete tests from the db that are
854         not present in testinfo.data.
855         
856         Load about:blank into the test frame before the test url, to make
857         missing tests more obvious.
858         
859         * CSSTestSuiteHarness/harness/harness.js:
860         (TestSuite.prototype.loadTest):
861         (TestSuite.prototype.openDatabase.creation):
862         (TestSuite.prototype.openDatabase.migration1_0To1_1):
863         (TestSuite.prototype.openDatabase.if.return):
864         (TestSuite.prototype.databaseReady):
865         (TestSuite.prototype.populateDatabaseFromTestInfoData):
866         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
867         (TestSuite.prototype.syncDatabaseWithTestInfoData):
868
869 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
870
871         Add the ability to jump to a specific test.
872
873         * CSSTestSuiteHarness/harness/harness.html:
874         * CSSTestSuiteHarness/harness/harness.js:
875         (TestSuite.prototype.goToTestByName):
876         (TestSuite.prototype.switchToFormat):
877
878 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
879
880         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
881         as the test.
882
883         * CSSTestSuiteHarness/harness/harness.js:
884         (TestSuite.prototype.loadRef):
885
886 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
887
888         Update the UI to reflect the fact that each test needs to be tested
889         in both HTML4 and XHTML1 format.
890         
891         * CSSTestSuiteHarness/harness/harness.js:
892         (Test):
893         (Chapter.prototype.description):
894         (Chapter.prototype.untestedCount):
895         (TestSuite.prototype.fillChapterPopup):
896         (TestSuite.prototype.updateChapterPopup):
897         (TestSuite.prototype.fillTestList):
898         (TestSuite.prototype.updateTestList):
899         (TestSuite.prototype.goToNextIncompleteTest):
900         (TestSuite.prototype.firstIncompleteTestIndex):
901         (TestSuite.prototype.recordResult):
902         (TestSuite.prototype.formatChanged):
903         (TestSuite.prototype.markTestCompleted):
904         (TestSuite.prototype.resetTestStatus):
905
906 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
907
908         Add the ability to remove results for re-testing, and
909         to import results.
910
911         * CSSTestSuiteHarness/harness/harness.css:
912         (.custom button):
913         (#overlay):
914         (#overlay.visible):
915         (.overlay-contents):
916         (.overlay-contents textarea):
917         (.overlay-contents .buttons):
918         (.overlay-contents .note):
919         (.overlay-contents .buttons button):
920         * CSSTestSuiteHarness/harness/harness.html:
921         * CSSTestSuiteHarness/harness/harness.js:
922         (TestSuite.prototype.importResults):
923         (TestSuite.prototype.clearResults):
924         (TestSuite.prototype.markTestCompleted):
925         (TestSuite.prototype.resetTestStatus):
926         (TestSuite.prototype.storeTestResult):
927         (TestSuite.prototype.importTestResults):
928         (TestSuite.prototype.clearTestResults):
929
930 2010-10-01  Sam Weinig  <sam@webkit.org>
931
932         Reviewed by Jon Honeycutt.
933
934         Deploy the new WKString functions to remove most uses of CF from
935         the WebKitTestRunner.
936
937         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
938         (WTR::InjectedBundle::didReceiveMessage):
939         (WTR::InjectedBundle::done):
940         * WebKitTestRunner/StringFunctions.h:
941         (WTR::toWK):
942         (WTR::toJS):
943         (WTR::toSTD):
944         (WTR::operator<<):
945         (WTR::copyURLString):
946         * WebKitTestRunner/TestController.cpp:
947         (WTR::TestController::resetStateToConsistentValues):
948         (WTR::TestController::didFinishLoadForFrame):
949         * WebKitTestRunner/TestInvocation.cpp:
950         (WTR::TestInvocation::invoke):
951         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
952
953 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
954
955         Unreviewed TestResultsServer change.
956
957         Add files introduced by http://crrev.com/61273 to the list of dashboard 
958         files to update.
959
960         * TestResultServer/handlers/dashboardhandler.py:
961
962 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
963
964         Build Fix for Windows.
965
966         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
967             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
968             ForwardingHeaders to the include path.
969
970 2010-10-01  Sam Weinig  <sam@webkit.org>
971
972         Reviewed by Anders Carlsson.
973
974         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
975
976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
977         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
978         (TestWebKitAPI::TEST):
979         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
980         (TestWebKitAPI::TEST):
981
982 2010-10-01  Sam Weinig  <sam@webkit.org>
983
984         Reviewed by Kenneth Rohde Christiansen.
985
986         Add additional WKString API
987         https://bugs.webkit.org/show_bug.cgi?id=46958
988
989         Add basic WKStringRef tests.
990
991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
992         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
993
994 2010-10-01  Sam Weinig  <sam@webkit.org>
995
996         Reviewed by Dan Bernstein.
997
998         Add makefile for TestWebKitAPI and call it from the base makefile.
999
1000         * Makefile:
1001         * TestWebKitAPI/Makefile: Added.
1002
1003 2010-10-01  Sam Weinig  <sam@webkit.org>
1004
1005         Reviewed by Adam Roben.
1006
1007         Remove unnecessary ForwardingHeaders from test runners.
1008         https://bugs.webkit.org/show_bug.cgi?id=47010
1009
1010         * TestWebKitAPI/Configurations/Base.xcconfig:
1011         * TestWebKitAPI/ForwardingHeaders: Removed.
1012         * WebKitTestRunner/Configurations/Base.xcconfig:
1013         * WebKitTestRunner/ForwardingHeaders: Removed.
1014
1015 2010-09-30  Adam Barth  <abarth@webkit.org>
1016
1017         Reviewed by Eric Seidel.
1018
1019         WebSocket tests are flaky
1020         https://bugs.webkit.org/show_bug.cgi?id=46956
1021
1022         Update these tools to understand how to run the WebSocket tests off the
1023         Apache server.
1024
1025         * Scripts/old-run-webkit-tests:
1026         * Scripts/webkitpy/layout_tests/port/base.py:
1027         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1028         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1029
1030 2010-10-01  Adam Roben  <aroben@apple.com>
1031
1032         Encode Executive command arguments using UTF-8 on Cygwin
1033
1034         Cygwin's Python's os.execv doesn't support unicode command arguments.
1035         Cygwin's execv expects arguments to be encoded using the current code
1036         page. But code pages are limited in what characters they can handle,
1037         and our tests include characters that the English code page can't
1038         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
1039         which can handle all characters but might confuse some commands, for
1040         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
1041         good enough, but we can deal with that when the problem arises.
1042
1043         Reviewed by Adam Barth.
1044
1045         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
1046         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
1047         fails on Windows
1048
1049         * Scripts/webkitpy/common/system/executive.py:
1050         (Executive._run_command_with_teed_output):
1051         (Executive.run_command):
1052         On Cygwin, encode arguments using UTF-8.
1053
1054 2010-10-01  Sam Weinig  <sam@webkit.org>
1055
1056         Reviewed by Adam Roben.
1057
1058         Add simple API tester for WebKit2
1059         https://bugs.webkit.org/show_bug.cgi?id=46953
1060
1061         This adds a very simple testing infrastructure for testing APIs exposed
1062         through the WebKit project. It consists of two parts: 1) a project that
1063         builds the all the tests 2) a script that searches the tests directory and
1064         calls the tester once for each test.
1065
1066         This adds the infrastructure and two tests:
1067         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
1068         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
1069
1070         This currently only works on the mac, but is designed to be easily ported 
1071         to any platform.
1072
1073         * Scripts/run-api-tests: Added.
1074         * Scripts/build-api-tests: Added.
1075         Scripts to build/run the tests.
1076
1077         * TestWebKitAPI: Added.
1078         * TestWebKitAPI/Configurations: Added.
1079         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
1080         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
1081         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
1082         * TestWebKitAPI/ForwardingHeaders: Added.
1083         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
1084         * TestWebKitAPI/PlatformUtilities.h: Added.
1085         * TestWebKitAPI/PlatformWebView.h: Added.
1086         (TestWebKitAPI::PlatformWebView::platformView):
1087         * TestWebKitAPI/StringFunctions.h: Added.
1088         * TestWebKitAPI/Test.h: Added.
1089         (TestWebKitAPI::Test::~Test):
1090         (TestWebKitAPI::Test::name):
1091         (TestWebKitAPI::Test::Register::Register):
1092         (TestWebKitAPI::Test::Register::create):
1093         (TestWebKitAPI::Test::Test):
1094         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
1095         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
1096         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
1097         * TestWebKitAPI/TestsController.cpp: Added.
1098         (TestWebKitAPI::TestsController::shared):
1099         (TestWebKitAPI::TestsController::TestsController):
1100         (TestWebKitAPI::TestsController::runTestNamed):
1101         (TestWebKitAPI::TestsController::testFailed):
1102         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1103         * TestWebKitAPI/TestsController.h: Added.
1104         * TestWebKitAPI/mac: Added.
1105         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
1106         (TestWebKitAPI::Util::run):
1107         (TestWebKitAPI::Util::createURLForResource):
1108         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
1109         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1110         (TestWebKitAPI::PlatformWebView::resizeTo):
1111         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1112         (TestWebKitAPI::PlatformWebView::page):
1113         (TestWebKitAPI::PlatformWebView::focus):
1114         * TestWebKitAPI/mac/main.mm: Added.
1115         Infrastructure.
1116
1117         * TestWebKitAPI/Tests: Added.
1118         * TestWebKitAPI/Tests/WTF: Added.
1119         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
1120         * TestWebKitAPI/Tests/WebKit2: Added.
1121         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
1122         (TestWebKitAPI::State::State):
1123         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
1124         Proof of concept tests.
1125
1126 2010-10-01  Adam Roben  <aroben@apple.com>
1127
1128         Don't assume AccessibleObjectFromEvent succeeds
1129
1130         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
1131         DumpRenderTree!notificationListenerProc when running
1132         plugins/access-after-page-destroyed.html
1133
1134         Reviewed by Sam Weinig.
1135
1136         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1137         (notificationListenerProc): Check both the return value of
1138         AccessibleObjectFromEvent and the object it returns, as MSDN
1139         recommends.
1140
1141 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1142
1143         Reviewed by Tony Chang.
1144
1145         [NRWT] Put the http and websocket tests first in the test list.
1146         https://bugs.webkit.org/show_bug.cgi?id=46453
1147
1148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1149         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1150
1151 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
1152
1153         Unreviewed, adding myself to the committer list.
1154
1155         * Scripts/webkitpy/common/config/committers.py:
1156
1157 2010-10-01  Adam Roben  <aroben@apple.com>
1158
1159         Test NPN_GetValue(NPNVnetscapeWindow)
1160
1161         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
1162         Right-clicking on windowless Flash plugin in WebKit2 makes a context
1163         menu appear in the bottom-right corner of the screen
1164
1165         Reviewed by Anders Carlsson.
1166
1167         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1168         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
1169
1170         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
1171
1172         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
1173         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
1174         (GetValueNetscapeWindow::NPP_SetWindow): Test that
1175         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
1176         isn't our HWND.
1177
1178         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1179         Added GetValueNetscapeWindow.
1180
1181 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
1182
1183         Unreviewed, adding my webkit.org identity to reviewer list.
1184
1185         * Scripts/webkitpy/common/config/committers.py:
1186
1187 2010-09-30  Adam Barth  <abarth@webkit.org>
1188
1189         Reviewed by Eric Seidel.
1190
1191         The WebSocket server should flush its logs
1192         https://bugs.webkit.org/show_bug.cgi?id=46946
1193
1194         The WebSocket server logs are truncated because the driver just
1195         terminates the child.  It should run Python without buffering so we can
1196         see the end of the log.
1197
1198         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1199
1200 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1201
1202         Add a button to jump to the next untested test.
1203         
1204         * CSSTestSuiteHarness/harness/harness.css:
1205         (.test-type):
1206         (.name > button):
1207         * CSSTestSuiteHarness/harness/harness.html:
1208         * CSSTestSuiteHarness/harness/harness.js:
1209         (Chapter.prototype.description):
1210         (Chapter.prototype.untestedCount):
1211         (TestSuite.prototype.testInfoDataLoaded):
1212         (TestSuite.prototype.fillChapterPopup):
1213         (TestSuite.prototype.updateChapterPopup):
1214         (TestSuite.prototype.buildTestListForChapter):
1215         (TestSuite.prototype.goToNextIncompleteTest):
1216         (TestSuite.prototype.firstIncompleteTestIndex):
1217         (TestSuite.prototype.testCompletionStateChanged):
1218
1219 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1220
1221         WebKit2 on Windows should use Windows fonts for the various standard
1222         font families
1223         https://bugs.webkit.org/show_bug.cgi?id=43499
1224         <rdar://problem/8272758>
1225
1226         Reviewed by Adam Roben.
1227
1228         * WebKitTestRunner/TestController.cpp:
1229         (WTR::TestController::resetStateToConsistentValues):
1230         Use the Mac fonts for running tests. This matches DRT behavior.
1231
1232 2010-09-30  Adam Barth  <abarth@webkit.org>
1233
1234         Third attempt.  We need a better integration test environment.
1235
1236         * Scripts/webkitpy/common/net/failuremap.py:
1237         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1238
1239 2010-09-30  Robert Hogan  <robert@webkit.org>
1240
1241         Reviewed by Andreas Kling.
1242
1243         [Qt] Support for PlainTextController
1244
1245         Unskip editing/text-iterator/basic-iteration.html
1246
1247         https://bugs.webkit.org/show_bug.cgi?id=38805
1248
1249         * DumpRenderTree/qt/DumpRenderTree.pro:
1250         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1251         (WebCore::DumpRenderTree::DumpRenderTree):
1252         (WebCore::DumpRenderTree::initJSObjects):
1253         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1254         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1255         (PlainTextController::PlainTextController):
1256         (PlainTextController::plainText):
1257         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1258
1259 2010-09-30  Adam Barth  <abarth@webkit.org>
1260
1261         Unreviewed.  Second attempt to fix sheriffbot.
1262
1263         * Scripts/webkitpy/common/net/buildbot.py:
1264
1265 2010-09-30  Adam Barth  <abarth@webkit.org>
1266
1267         Unreviewed.
1268
1269         This patch should stop the sheriffbot from throwing an exception.
1270
1271         * Scripts/webkitpy/common/net/buildbot.py:
1272
1273 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1274
1275         Reviewed by Adam Roben.
1276
1277         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1278         https://bugs.webkit.org/show_bug.cgi?id=46926
1279
1280         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1281             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1282
1283 2010-09-30  Adam Barth  <abarth@webkit.org>
1284
1285         Reviewed by Eric Seidel.
1286
1287         webkit-patch find-flaky-tests should print results URLs
1288         https://bugs.webkit.org/show_bug.cgi?id=46917
1289
1290         Printing out the results URL makes find-flaky-tests more actionable
1291         because you can see what happens when a test fails.  The output from
1292         the script is still pretty noisy, but it seems useful.
1293
1294         * Scripts/webkitpy/tool/commands/queries.py:
1295
1296 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1297
1298         Reviewed by Simon Fraser.
1299
1300         Make 2D accelerated canvas rendering build on Mac
1301         https://bugs.webkit.org/show_bug.cgi?id=46007
1302         
1303         Added ACCELERATED_2D_CANVAS to build-webkit
1304
1305         * Scripts/build-webkit:
1306
1307 2010-09-29  Kenneth Russell  <kbr@google.com>
1308
1309         Reviewed by Dimitri Glazkov.
1310
1311         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1312         https://bugs.webkit.org/show_bug.cgi?id=46849
1313
1314         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1315         works with the compositor integration in both DumpRenderTree and
1316         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1317         and thereby trigger the compositor's readback code path. Added support
1318         for --enable-accelerated-compositing to DumpRenderTree.
1319
1320         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1321         modifying a compositing layout test, dumping the pixels and verifying
1322         that they matched the output when the compositor was active.
1323
1324         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1325         (main):
1326         * DumpRenderTree/chromium/TestShell.cpp:
1327         (TestShell::TestShell):
1328         (TestShell::resetWebSettings):
1329         * DumpRenderTree/chromium/TestShell.h:
1330         (TestShell::setAcceleratedCompositingEnabled):
1331         * DumpRenderTree/chromium/WebPreferences.cpp:
1332         (WebPreferences::reset):
1333         (WebPreferences::applyTo):
1334         * DumpRenderTree/chromium/WebPreferences.h:
1335         * DumpRenderTree/chromium/WebViewHost.cpp:
1336         (WebViewHost::scheduleComposite):
1337         * DumpRenderTree/chromium/WebViewHost.h:
1338
1339 2010-09-30  Adam Roben  <aroben@apple.com>
1340
1341         Ensure that QueueEngine cleans up its log files when its delegate
1342         tells it to stop processing work
1343
1344         Reviewed by Adam Barth.
1345
1346         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1347         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1348         Windows
1349
1350         * Scripts/webkitpy/tool/bot/queueengine.py:
1351         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1352         files) when the delegate tells us to stop processing work.
1353
1354         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1355         (LoggingDelegate.__init__): Moved code here from
1356         RaisingDelegate.__init__.
1357         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1358         callback.
1359         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1360         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1361         care of for us now.
1362         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1363         message.
1364         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1365         remove the callbacks that are related to processing a single work
1366         item, rather than removing all callbacks after a certain point, as
1367         there are now more callbacks we expect to receive at the end.
1368
1369 2010-09-30  Adam Roben  <aroben@apple.com>
1370
1371         Fix path -> URL conversion on Cygwin
1372
1373         Reviewed by Adam Barth.
1374
1375         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1376         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1377
1378         * Scripts/webkitpy/layout_tests/port/base.py:
1379         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1380         assuming paths already have a leading slash.
1381
1382 2010-09-30  Adam Roben  <aroben@apple.com>
1383
1384         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1385         be called more than once
1386
1387         The NPP_SetWindow call made when the plugin is torn down was confusing
1388         us, and was causing us to spew an error into the next test.
1389
1390         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1391         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1392
1393         Reviewed by Anders Carlsson.
1394
1395         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1396         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1397         Initialize member.
1398         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1399         this isn't the first time this is called.
1400
1401 2010-09-30  Eric Seidel  <eric@webkit.org>
1402
1403         Reviewed by Adam Barth.
1404
1405         webkit-patch upload warns that I'm using Xcode when I'm not
1406         https://bugs.webkit.org/show_bug.cgi?id=46869
1407
1408         String.find returns -1 when not found, so switched to "in".
1409
1410         * Scripts/webkitpy/common/system/user.py:
1411         * Scripts/webkitpy/common/system/user_unittest.py:
1412
1413 2010-09-30  Eric Seidel  <eric@webkit.org>
1414
1415         Reviewed by Adam Barth.
1416
1417         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1418         https://bugs.webkit.org/show_bug.cgi?id=46866
1419
1420         I also made failure-reason use RegressionWindow in a cleaner way.
1421
1422         * Scripts/webkitpy/tool/commands/queries.py:
1423
1424 2010-09-29  Adam Barth  <abarth@webkit.org>
1425
1426         Reviewed by Eric Seidel.
1427
1428         webkit-patch find-flaky-tests
1429         https://bugs.webkit.org/show_bug.cgi?id=46876
1430
1431         This command helps us find flaky tests so we can squash them.
1432
1433         * Scripts/webkitpy/tool/commands/queries.py:
1434
1435 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1436
1437         Fix export to use '?' instead of 'null' for
1438         tests with no results.
1439         
1440         * CSSTestSuiteHarness/harness/harness.js:
1441
1442 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1443
1444         Add a warning when a test requires special steps.
1445         Add a Print Preview button for 'paged' tests that
1446         brings up the print dialog, allowing the user to 
1447         judge paged media tests.
1448
1449         * CSSTestSuiteHarness/harness/harness.css:
1450         * CSSTestSuiteHarness/harness/harness.html:
1451         * CSSTestSuiteHarness/harness/harness.js:
1452         (TestSuite.prototype.loadTest):
1453         (TestSuite.prototype.processFlags):
1454
1455 2010-09-29  Adam Barth  <abarth@webkit.org>
1456
1457         Reviewed by Eric Seidel.
1458
1459         Remove revisions_casuing_failures
1460         https://bugs.webkit.org/show_bug.cgi?id=46872
1461
1462         This function exists only to be unit tested.
1463
1464         * Scripts/webkitpy/common/net/failuremap.py:
1465         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1466         * Scripts/webkitpy/tool/mocktool.py:
1467
1468 2010-09-29  Adam Barth  <abarth@webkit.org>
1469
1470         Reviewed by Eric Seidel.
1471
1472         SheriffBot should post the list of failing tests to bugs
1473         https://bugs.webkit.org/show_bug.cgi?id=46871
1474
1475         * Scripts/webkitpy/common/net/buildbot.py:
1476         * Scripts/webkitpy/common/net/failuremap.py:
1477         * Scripts/webkitpy/common/net/regressionwindow.py:
1478         * Scripts/webkitpy/tool/bot/sheriff.py:
1479         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1480         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1481         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1482         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1483         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1484         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1485         * Scripts/webkitpy/tool/mocktool.py:
1486
1487 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1488
1489         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1490
1491         [WinCairo] Adds a build slave.
1492         https://bugs.webkit.org/show_bug.cgi?id=46360
1493
1494         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1495         entries for a debug build of the WinCairo port.
1496         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1497         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1498         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1499         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1500
1501 2010-09-29  Adam Barth  <abarth@webkit.org>
1502
1503         Reviewed by Eric Seidel.
1504
1505         Move more SheriffBot smarts into FailureMap
1506         https://bugs.webkit.org/show_bug.cgi?id=46703
1507
1508         This patch pushes the FailureMap model object further into the
1509         SheriffBot machine.  In addition, it moves a couple operations on this
1510         object from SheriffBot itself to the model.
1511
1512         Eventually, FailureMap will be the canonical context object for
1513         SheriffBot operations.  FailureMap represents a map of the current
1514         failures on the bots that might require remediation.
1515
1516         * Scripts/webkitpy/common/net/failuremap.py:
1517         * Scripts/webkitpy/common/net/regressionwindow.py:
1518         * Scripts/webkitpy/tool/commands/queries.py:
1519         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1520         * Scripts/webkitpy/tool/mocktool.py:
1521
1522 2010-09-29  Tony Chang  <tony@chromium.org>
1523
1524         Reviewed by James Robinson.
1525
1526         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1527         https://bugs.webkit.org/show_bug.cgi?id=46829
1528
1529         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1530         (DRTDevToolsClient::DRTDevToolsClient):
1531         * DumpRenderTree/chromium/TestShell.cpp:
1532         (TestShell::TestShell):
1533         * DumpRenderTree/chromium/WebViewHost.cpp:
1534         (WebViewHost::postAccessibilityNotification):
1535         (WebViewHost::WebViewHost):
1536
1537 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1538
1539         Reviewed by Darin Adler.
1540
1541         AX: implement CSS3 Speech "speak"
1542         https://bugs.webkit.org/show_bug.cgi?id=46827
1543
1544         * DumpRenderTree/AccessibilityUIElement.cpp:
1545         (speakCallback):
1546         (AccessibilityUIElement::speak):
1547         (AccessibilityUIElement::getJSClass):
1548         * DumpRenderTree/AccessibilityUIElement.h:
1549         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1550         (AccessibilityUIElement::speak):
1551
1552 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1553
1554         Reviewed by Adam Barth.
1555
1556         Record bot ID when updating queue status
1557         https://bugs.webkit.org/show_bug.cgi?id=46764
1558         
1559         Since we now have multiple bots handling patches from the commit queue,
1560         we need to differentiate status updates from them, so that we can group
1561         the queue status page in a less confusing way.
1562
1563         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1564         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1565         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1566         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1567         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1568         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1569         * Scripts/webkitpy/tool/main.py: Add --bot-id
1570         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1571
1572 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1573
1574         No review.
1575         
1576         References always refert to a file in .xht format, even
1577         for HTML tests, so fix their loading.
1578
1579         * CSSTestSuiteHarness/harness/harness.js:
1580         (TestSuite.prototype.loadRef):
1581
1582 2010-09-28  Johnny Ding  <jnd@chromium.org>
1583
1584         Reviewed by Adam Barth.
1585
1586         https://bugs.webkit.org/show_bug.cgi?id=41292
1587         Add a new parameter to the test plugin to allow specifying a script 
1588         and a mouse/keyboard event. The specified script will be evaluated
1589         in the browser when the specified event is received by the plugin.
1590
1591         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1592         (pluginAllocate):
1593         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1594         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1595         (NPP_New):
1596         (handleEventCarbon):
1597         (handleEventCocoa):
1598
1599 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1600
1601         Fix export by adding missing argument.
1602
1603         * CSSTestSuiteHarness/harness/harness.js:
1604         (TestSuite.prototype.showResultsForAllTests):
1605
1606 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1607
1608         [wx] Build fix, add missing import.
1609
1610         * wx/packaging/build-win-installer.py:
1611
1612 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1613
1614         No review
1615         
1616         Show which tests have been run by dimming them out in the test list.
1617         
1618         Adjust some element sizes.
1619         
1620         * CSSTestSuiteHarness/harness/harness.css:
1621         (#test-list > option.untested):
1622         (#test-list > option.completed):
1623         (#output):
1624         (.output-options):
1625         * CSSTestSuiteHarness/harness/harness.js:
1626         (Test):
1627         (TestSuite.prototype.fillTestList):
1628         (TestSuite.prototype.updateTestList):
1629         (TestSuite.prototype.setSelectedChapter):
1630         (TestSuite.prototype.recordResult):
1631         (TestSuite.prototype.markTestCompleted):
1632         (TestSuite.prototype.testCompletionStateChanged):
1633         (TestSuite.prototype.loadTestStatus):
1634
1635 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1636
1637         No review.
1638         
1639         Implement export of various queries on the test database, sharing
1640         code with that which displays results inline.
1641
1642         * CSSTestSuiteHarness/harness/harness.js:
1643         ():
1644         (TestSuite.prototype.exportResultsCompletion.var):
1645         (TestSuite.prototype.exportResultsCompletion):
1646         (TestSuite.prototype.showResultsForCompletedTests):
1647         (TestSuite.prototype.exportResultsForCompletedTests):
1648         (TestSuite.prototype.showResultsForAllTests):
1649         (TestSuite.prototype.exportResultsForAllTests):
1650         (TestSuite.prototype.exportResultsForTestsNotRun):
1651         (TestSuite.prototype.exportResultsForTestsWithStatus):
1652         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1653
1654 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1655
1656         No review.
1657
1658         Work around uncertainty about the order of database
1659         transactions when creating the database, so that we don't
1660         try to query the table before it has been created.
1661
1662         * CSSTestSuiteHarness/harness/harness.js:
1663         (TestSuite):
1664         (TestSuite.prototype.databaseCreated):
1665         (TestSuite.prototype.storeTestResult):
1666         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1667         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1668         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1669         (TestSuite.prototype.queryDatabaseForCompletedTests):
1670         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1671
1672 2010-09-28  Tony Chang  <tony@chromium.org>
1673
1674         Reviewed by Eric Seidel.
1675
1676         add python keyring support to webkit-patch
1677         https://bugs.webkit.org/show_bug.cgi?id=41269
1678
1679         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1680             the python keyring module
1681         * Scripts/webkitpy/common/net/credentials_unittest.py:
1682         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1683         * Scripts/webkitpy/common/system/user_unittest.py:
1684         * Scripts/webkitpy/tool/mocktool.py:
1685
1686 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1687
1688         Reviewed by Gustavo Noronha Silva.
1689
1690         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1691         https://bugs.webkit.org/show_bug.cgi?id=46740
1692
1693         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1694         fonts which can be used to fully test FontConfig rendering settings.
1695
1696 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1697
1698         Reviewed by Gustavo Noronha Silva.
1699
1700         [gtk] Fedora has a different path for the liberation fonts
1701         https://bugs.webkit.org/show_bug.cgi?id=46709
1702
1703         When searching for DRT fonts, also look in the path where those fonts
1704         are commonly found on Fedora systems.
1705
1706         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1707         (initializeFonts): Include logic for looking for Fedora-style font paths.
1708
1709 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1710
1711         Reviewed by Andreas Kling.
1712
1713         run-webkit-tests needs an updated list of directories with webgl tests
1714         https://bugs.webkit.org/show_bug.cgi?id=46747
1715
1716         Update the list of directories containing WebGL tests and a unit test
1717         which depends on this list.
1718
1719         * Scripts/old-run-webkit-tests: Update the list of directories.
1720         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1721         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1722
1723 2010-09-28  Adam Barth  <abarth@webkit.org>
1724
1725         Reviewed by Eric Seidel.
1726
1727         Introduce FailureMap to summaries the failures status of all the bots
1728         https://bugs.webkit.org/show_bug.cgi?id=46700
1729
1730         This patch gives the SheriffBot a handle on the list of failing tests.
1731
1732         * Scripts/webkitpy/common/net/buildbot.py:
1733         * Scripts/webkitpy/common/net/failuremap.py: Added.
1734         * Scripts/webkitpy/tool/commands/queries.py:
1735         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1736         * Scripts/webkitpy/tool/mocktool.py:
1737
1738 2010-09-28  Adam Roben  <aroben@apple.com>
1739
1740         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1741
1742         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1743         tell a WebKit2 client application that a key event was not handled
1744
1745         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1746
1747         * MiniBrowser/mac/BrowserWindowController.m:
1748         (-[BrowserWindowController awakeFromNib]):
1749         * MiniBrowser/win/BrowserView.cpp:
1750         (BrowserView::create):
1751         * WebKitTestRunner/TestController.cpp:
1752         (WTR::createOtherPage):
1753         (WTR::TestController::initialize):
1754
1755 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1756
1757         Unreviewed.
1758
1759         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1760         for the test order, but instead use information from testinfo.data.
1761         
1762         * CSSTestSuiteHarness/harness/harness.html:
1763         * CSSTestSuiteHarness/harness/harness.js:
1764
1765 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1766
1767         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1768         it causes the process to hang on the gitorious repo.
1769
1770         * wx/packaging/build-mac-installer.py:
1771         * wx/packaging/build-win-installer.py:
1772
1773 2010-09-28  Adam Roben  <aroben@apple.com>
1774
1775         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1776         called
1777
1778         Reviewed by Anders Carlsson.
1779
1780         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1781         Full-page Adobe Reader does not paint until window is resized
1782
1783         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1784         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1785         this level.
1786
1787         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1788         NPP_SetWindow.
1789
1790         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1791         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1792         the plugin's HWND has a non-zero size and that its size/position
1793         matches that specified in the NPWindow.
1794
1795         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1796         (NPP_SetWindow): Call through to the PluginTest.
1797
1798         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1799         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1800         the files as it saw fit.
1801
1802 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1803
1804         Reviewed by Andreas Kling.
1805
1806         [Qt] Remove support for Qt 4.5
1807         https://bugs.webkit.org/show_bug.cgi?id=46718
1808
1809         Remove the code for versions of Qt prior to 4.6.
1810
1811         * DumpRenderTree/qt/EventSenderQt.cpp:
1812         (EventSender::addTouchPoint):
1813         (EventSender::updateTouchPoint):
1814         (EventSender::setTouchModifier):
1815         (EventSender::touchStart):
1816         (EventSender::touchMove):
1817         (EventSender::touchEnd):
1818         (EventSender::clearTouchPoints):
1819         (EventSender::releaseTouchPoint):
1820         (EventSender::sendTouchEvent):
1821         * DumpRenderTree/qt/EventSenderQt.h:
1822         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1823         (TextInputController::setMarkedText):
1824         * QtTestBrowser/launcherwindow.cpp:
1825         (LauncherWindow::LauncherWindow):
1826         (LauncherWindow::initializeView):
1827         (LauncherWindow::createChrome):
1828         (LauncherWindow::sendTouchEvent):
1829         (LauncherWindow::eventFilter):
1830         (LauncherWindow::applyZoom):
1831         (LauncherWindow::setTouchMocking):
1832         * QtTestBrowser/launcherwindow.h:
1833         * QtTestBrowser/utils.cpp:
1834         (urlFromUserInput):
1835         * QtTestBrowser/webview.cpp:
1836         (WebViewGraphicsBased::animatedFlip):
1837         (WebViewGraphicsBased::animatedYFlip):
1838         * QtTestBrowser/webview.h:
1839         (WebViewGraphicsBased::setYRotation):
1840
1841 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1842
1843         Reviewed by Andreas Kling.
1844
1845         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1846         which should point to wcecompat installation. Needs wcecompat
1847         library from http://github.com/mauricek/wcecompat .
1848
1849         * DumpRenderTree/qt/DumpRenderTree.pro:
1850         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1851         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1852
1853 2010-09-28  Daniel Bates  <dbates@rim.com>
1854
1855         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1856         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1857
1858         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1859         In particular, this change caused Sheriffbot to raise an exception when
1860         trying to parse the bug id on a bug page. We need to look into this
1861         some more.
1862
1863         * Scripts/webkitpy/common/net/bugzilla.py:
1864         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1865         * Scripts/webkitpy/tool/bot/sheriff.py:
1866         * Scripts/webkitpy/tool/commands/download.py:
1867         * Scripts/webkitpy/tool/commands/queues.py:
1868         * Scripts/webkitpy/tool/commands/upload.py:
1869         * Scripts/webkitpy/tool/steps/closebug.py:
1870         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1871         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1872         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1873
1874 2010-09-28  Adam Barth  <abarth@webkit.org>
1875
1876         Reviewed by Eric Seidel.
1877
1878         Move RegressionWindow further up the dependency chain
1879         https://bugs.webkit.org/show_bug.cgi?id=46698
1880
1881         Baby steps towards pushing this information into bug posts.
1882
1883         * Scripts/webkitpy/common/net/buildbot.py:
1884         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1885         * Scripts/webkitpy/common/net/regressionwindow.py:
1886         * Scripts/webkitpy/tool/commands/queries.py:
1887
1888 2010-09-27  Daniel Bates  <dbates@rim.com>
1889
1890         Reviewed by Adam Barth.
1891
1892         sheriffbot can't roll out security patches
1893         https://bugs.webkit.org/show_bug.cgi?id=39136
1894
1895         Make SheriffBot determine if it's authorized to view a bug
1896         whose change it wants to rollout before it tries to rollout
1897         the change.
1898
1899         Moreover, make both webkit-patch and Sheriffbot provide human-
1900         readable error messages when they are not authorized to view
1901         a bug and when a bug number is invalid.
1902
1903         Currently, Sheriffbot does not parse Bugzilla bugs for
1904         <bug error="...">, which indicates an error when retrieving
1905         a bug. In particular, error="NotPermitted" if a person (or bot)
1906         is not authorized to view a bug. For such error="NotPermitted" bugs,
1907         Sheriffbot raises an exception when parsing the bug report and
1908         this exception does not explicitly indicate Sheriffbot's lack
1909         of authorization. Instead, Sheriffbot should explicitly check
1910         for the presence <bug error="..."> before operating on a bug
1911         and error with a human-readable message if it's not permitted
1912         to view it.
1913
1914         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1915         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1916           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1917           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1918           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1919         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1920         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1921         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1922         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1923         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1924         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1925         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1926         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1927
1928 2010-09-27  Adam Barth  <abarth@webkit.org>
1929
1930         Reviewed by Eric Seidel.
1931
1932         Expose more more failure information from Buildbot to SheriffBot
1933         https://bugs.webkit.org/show_bug.cgi?id=46697
1934
1935         This patch moves the information about what tests failured closer to
1936         SheriffBot.  There are still a couple more patches to go before
1937         SheriffBot can post this information to bugs, but this is a step in
1938         that direction.  Yay for unit tests, which caught some bugs in earlier
1939         versions of this patch.
1940
1941         * Scripts/webkitpy/common/net/buildbot.py:
1942         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1943         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1944         * Scripts/webkitpy/tool/commands/queries.py:
1945
1946 2010-09-27  Eric Seidel  <eric@webkit.org>
1947
1948         Unreviewed.  Fixing 500 error seen in the status server.
1949
1950         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1951         This should have been obvious to me, I guess, but it was not what I was expecting.
1952
1953         * QueueStatusServer/model/activeworkitems.py:
1954
1955 2010-09-27  Adam Barth  <abarth@webkit.org>
1956
1957         Reviewed by Eric Seidel.
1958
1959         commit-queue should reject patches that fail to land
1960         https://bugs.webkit.org/show_bug.cgi?id=46694
1961
1962         This can happen, for example, if there's no reviewer.  Without this
1963         patch, we'll keep retrying the patch.
1964
1965         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1966         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1967
1968 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1969
1970         Rubber-stamped by Adele Peterson.
1971
1972         Add a harness for running the CSS 2.1 test suite.
1973         
1974         This harness assumes that you've got a local a copy of the suite
1975         adjacent to the 'harness' directory.
1976         
1977         The harness lets you go through the tests in chapter order,
1978         denoting pass/fail/skipped for each test.
1979         
1980         It uses a client-side database to store the results of testing.
1981
1982         * CSSTestSuiteHarness/harness/harness.css: Added.
1983         * CSSTestSuiteHarness/harness/harness.html: Added.
1984         * CSSTestSuiteHarness/harness/harness.js: Added.
1985
1986 2010-09-27  Eric Seidel  <eric@webkit.org>
1987
1988         Reviewed by Adam Barth.
1989
1990         Patch locks should expire if a patch is marked for retry
1991         https://bugs.webkit.org/show_bug.cgi?id=46682
1992
1993         This was part Adam's original CommitQueueTask design,
1994         but support for it was missing from the server.
1995         I added the support, but triggering lock-release based on this
1996         special "retry" status feels a bit strange so I added a FIXME.
1997
1998         I also changed the text in queuestatus.html to say "Lock Acquired"
1999         since "Last Activity" isn't really true.  We only update the lock
2000         date when the patch is started, not on every status update.
2001
2002         I also noticed an exception in next-patch, which I fixed by re-writing
2003         the unzip logic in activeworkitems.py again.
2004
2005         * QueueStatusServer/handlers/updatestatus.py:
2006         * QueueStatusServer/model/activeworkitems.py:
2007         * QueueStatusServer/templates/queuestatus.html:
2008
2009 2010-09-27  Tony Chang  <tony@chromium.org>
2010
2011         Reviewed by David Levin.
2012
2013         [chromium] fix a warning when compiling DRT on 32-bit linux
2014         https://bugs.webkit.org/show_bug.cgi?id=46641
2015
2016         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2017         (DRTPrinter::handleImage):
2018
2019 2010-09-27  Eric Seidel  <eric@webkit.org>
2020
2021         Reviewed by Adam Barth.
2022
2023         queue-status should report when the patch was last locked to a queue
2024         https://bugs.webkit.org/show_bug.cgi?id=46674
2025
2026         This isn't necessarily the best way to expose this information
2027         but having this accessible via the web interface is very
2028         useful until we come up with a nicer way to display this.
2029
2030         I also cleaned up the code in activeworkitems.py a little
2031         to use list comprehensions and to have the code work with
2032         pairs instead of two lists at once.  Eventually I think those
2033         item/time pairs need to be their own little helper class.
2034
2035         * QueueStatusServer/handlers/queuestatus.py:
2036         * QueueStatusServer/model/activeworkitems.py:
2037         * QueueStatusServer/templates/queuestatus.html:
2038
2039 2010-09-27  Tony Chang  <tony@chromium.org>
2040
2041         Reviewed by David Levin.
2042
2043         [chromium] fix detection of missing fonts on DRT
2044         https://bugs.webkit.org/show_bug.cgi?id=46651
2045
2046         * DumpRenderTree/chromium/TestShellGtk.cpp:
2047         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
2048
2049 2010-09-27  Tony Chang  <tony@chromium.org>
2050
2051         Reviewed by Dimitri Glazkov.
2052
2053         add webkit unit tests to the chromium testers
2054         https://bugs.webkit.org/show_bug.cgi?id=46669
2055
2056         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2057         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
2058
2059 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
2060
2061         Unreviewed.
2062
2063         Adding myself to the committers list.
2064
2065         * Scripts/webkitpy/common/config/committers.py:
2066
2067 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
2068
2069         Reviewed by Eric Seidel.
2070
2071         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
2072         https://bugs.webkit.org/show_bug.cgi?id=46634
2073         
2074         Use OutputCapture to prevent console spam (and also check for expected
2075         output).
2076
2077         * Scripts/webkitpy/common/system/user_unittest.py:
2078
2079 2010-09-27  Eric Seidel  <eric@webkit.org>
2080
2081         Reviewed by James Robinson.
2082
2083         start-commit-queue should abort any rebases in progress
2084         https://bugs.webkit.org/show_bug.cgi?id=46640
2085
2086         webkit-patch commit-queue would do this itself, but this just
2087         helps ensure that the commit-queue script is properly updated
2088         before we run it (in the case where a previous rebase is in
2089         progress the git svn rebase would not work before we run the
2090         commit-queue).
2091
2092         * EWSTools/start-commit-queue.sh:
2093
2094 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
2095
2096         Reviewed by Gustavo Noronha Silva.
2097
2098         [GTK] Clean up the DRT fonts.conf and switch to Liberation
2099         https://bugs.webkit.org/show_bug.cgi?id=46038
2100
2101         Switch to Liberation fonts for GTK+ layout tests. This will make our
2102         test results metric-compatible with many Windows/Chromium results. It
2103         also simplifies the fonts.conf that we load and prepares the way for
2104         fixing many font bugs.
2105
2106         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2107         (initializeFonts): Initialize a known list of fonts instead of loading
2108         every font in the WEBKIT_TESTFONTS directory.
2109         * DumpRenderTree/gtk/fonts.conf: Removed.
2110         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2111         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
2112         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
2113         we can load both fonts.conf and AHEM____.TTF from this location.
2114         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
2115         it is no longer used.
2116
2117 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
2118
2119         Reviewed by Ojan Vafai.
2120
2121         new-run-webkit-httpd fails if Perl is not installed
2122         https://bugs.webkit.org/show_bug.cgi?id=46602
2123         
2124         Make Port._read_configuration catch all exceptions, since trying to run
2125         perl (because of _webkit_build_directory) when it's not installed throws
2126         a WindowsError or OSError, not an IOError (this became an issue after 
2127         r68268, since ChromiumPort ends up calling Port.default_configuration in
2128         its constructor, which means that we're ending up on this codepath in
2129         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
2130         new-run-webkit-httpd).
2131
2132         * Scripts/webkitpy/layout_tests/port/base.py:
2133         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2134
2135 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2136
2137         Reviewed by Antonio Gomes.
2138
2139         [EFL] Add setting API to set a local storage database path.
2140         https://bugs.webkit.org/show_bug.cgi?id=45446
2141
2142         Add a setting API to set local storage database path.
2143
2144         * EWebLauncher/main.c:
2145         (on_key_down):
2146         (browserCreate):
2147         (main):
2148
2149 2010-09-26  Sam Weinig  <sam@webkit.org>
2150
2151         Reviewed by Anders Carlsson.
2152
2153         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
2154         https://bugs.webkit.org/show_bug.cgi?id=46587
2155
2156         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2157
2158 2010-09-26  Antonio Gomes  <agomes@rim.com>
2159
2160         Reviewed by Kenneth Rohde Christiansen.
2161
2162         DRT/Mac nodesFromRect support
2163
2164         [Mac][DRT] Implement LayoutTestController::nodesFromRect
2165         https://bugs.webkit.org/show_bug.cgi?id=46580
2166
2167         Implements LayoutTestController::nodesFromRect for Mac DRT, and
2168         adding stubs for GTK+ and Windows.
2169
2170         * DumpRenderTree/LayoutTestController.cpp:
2171         (nodesFromRectCallback):
2172         (LayoutTestController::staticFunctions):
2173         * DumpRenderTree/LayoutTestController.h:
2174         (LayoutTestController::LayoutTestController::nodesFromRect):
2175         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2176         (LayoutTestController::nodesFromRect):
2177
2178 2010-09-25  Nicolas Weber  <thakis@chromium.org>
2179
2180         Reviewed by Adam Barth.
2181
2182         https://bugs.webkit.org/show_bug.cgi?id=46555
2183         Fix typo in prepare-ChangeLog's help output.
2184
2185         * Scripts/prepare-ChangeLog:
2186
2187 2010-09-24  Sam Weinig  <sam@webkit.org>
2188
2189         Reviewed by Darin Adler.
2190
2191         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
2192         <rdar://problem/8359279>
2193         https://bugs.webkit.org/show_bug.cgi?id=46546
2194
2195         * MiniBrowser/mac/BrowserWindowController.m:
2196         (mouseDidMoveOverElement):
2197         (-[BrowserWindowController awakeFromNib]):
2198         * MiniBrowser/win/BrowserView.cpp:
2199         (mouseDidMoveOverElement):
2200         (BrowserView::create):
2201         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2202         (WTR::InjectedBundlePage::InjectedBundlePage):
2203         * WebKitTestRunner/TestController.cpp:
2204         (WTR::createOtherPage):
2205         (WTR::TestController::initialize):
2206
2207 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2208
2209         Reviewed by Adam Barth.
2210
2211         Allow rebaselines for webkit-patch rebaseline to be chosen
2212         https://bugs.webkit.org/show_bug.cgi?id=46407
2213         
2214         Instead of always rebaselining all failing tests, allow a subset to be
2215         chosen.
2216
2217         * Scripts/webkitpy/common/system/user.py:
2218         * Scripts/webkitpy/tool/commands/rebaseline.py:
2219
2220 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2221
2222         Reviewed by Tony Chang.
2223
2224         [chromium] Implement TextInputController::firstRectForCharacterRange
2225         https://bugs.webkit.org/show_bug.cgi?id=38100
2226
2227         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2228         No new tests are added since we need to implement the same feature in chromium side
2229         in order to enable any tests that uses this function.
2230
2231         * DumpRenderTree/chromium/TextInputController.cpp:
2232         (TextInputController::firstRectForCharacterRange): Added.
2233
2234 2010-09-24  Adam Barth  <abarth@webkit.org>
2235
2236         Reviewed by Eric Seidel.
2237
2238         commit-queue reports land failures as "PASS"
2239         https://bugs.webkit.org/show_bug.cgi?id=46530
2240
2241         We were ignoring the return value of land instead of passing it back to
2242         CommitQueue.  Of course, this was the one case I forgot to test!
2243
2244         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2245         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2246
2247 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2248
2249         Reviewed by Eric Seidel.
2250
2251         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2252         https://bugs.webkit.org/show_bug.cgi?id=37563
2253
2254         Print error message when build-dumprendertree fails.
2255
2256         * Scripts/webkitpy/layout_tests/port/webkit.py:
2257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2258
2259 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2260
2261         Reviewed by Tony Chang.
2262
2263         NRWT doesn't respect config set with set-webkit-configuration
2264         https://bugs.webkit.org/show_bug.cgi?id=46278
2265         
2266         Use Port.default_configuration() instead of hardcoding Release in
2267         ChromiumPort configuration initialization, so that we still inherit the
2268         configuration set by set-webkit-configuration.
2269
2270         * Scripts/webkitpy/layout_tests/port/chromium.py:
2271         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2272
2273 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2274
2275         Reviewed by Csaba Osztrogonác.
2276
2277         [Qt] Fix the code to check file existence.
2278         https://bugs.webkit.org/show_bug.cgi?id=46465
2279
2280         * QtTestBrowser/main.cpp:
2281         (main):
2282
2283 2010-09-23  Tony Chang  <tony@chromium.org>
2284
2285         Unreviewed, rolling out r68232.
2286         http://trac.webkit.org/changeset/68232
2287
2288         Broken NRWT on the canary bots.
2289
2290         * Scripts/webkitpy/layout_tests/port/chromium.py:
2291
2292 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2293
2294         Unreviewed, build fix.
2295
2296         r68008 broke new-run-webkit-tests in that the chromium ports no
2297         longer respect set-webkit-configuration. The correct fix for this
2298         is being pursued in bug 46278 (along with a bunch of unit tests),
2299         but in the meantime I'm reverting the particular lines that broke
2300         things. This was tested by hand.
2301
2302         * Scripts/webkitpy/layout_tests/port/chromium.py:
2303
2304 2010-09-23  Sam Weinig  <sam@webkit.org>
2305
2306         Reviewed by Anders Carlsson.
2307
2308         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2309         <rdar://problem/8414062>
2310         https://bugs.webkit.org/show_bug.cgi?id=46432
2311
2312         * MiniBrowser/mac/BrowserWindowController.m:
2313         (didRemoveFrameFromHierarchy):
2314         (-[BrowserWindowController awakeFromNib]):
2315         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2316         (WTR::InjectedBundlePage::InjectedBundlePage):
2317         * WebKitTestRunner/TestController.cpp:
2318         (WTR::TestController::initialize):
2319
2320 2010-09-23  Tony Chang  <tony@chromium.org>
2321
2322         Reviewed by Dimitri Glazkov.
2323
2324         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2325         https://bugs.webkit.org/show_bug.cgi?id=46426
2326
2327         * DumpRenderTree/chromium/LayoutTestController.cpp:
2328         (LayoutTestController::LayoutTestController):
2329         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2330         * DumpRenderTree/chromium/LayoutTestController.h:
2331
2332 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2333
2334         Reviewed by Nate Chapin.
2335
2336         [GTK] r68199 introduced two test failures
2337         https://bugs.webkit.org/show_bug.cgi?id=46424
2338
2339         Fix a regression handling preference overrides that are attached to boolean properties.
2340
2341         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2342         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2343         so we must check for that when converting a string to a boolean.
2344
2345 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2346
2347         Reviewed by David Levin.
2348
2349         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2350         https://bugs.webkit.org/show_bug.cgi?id=46406
2351
2352         This breaks when the method is called with specified size of data (image data), and the
2353         buffer hasn't yet reached this size.
2354
2355         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2356           index larger than 0.
2357
2358 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2359
2360         Reviewed by Nate Chapin.
2361
2362         [GTK] Some tests from r68174 fail on the GTK+ bots
2363         https://bugs.webkit.org/show_bug.cgi?id=46396
2364
2365         Simplify LayoutTestController::overridePreference to make it easier for
2366         people unfamiliar with the code to keep the list of preferences up to date.
2367         Add the conversion for enable-hyperlink-auditing.
2368
2369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2370         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2371         out the property name for overrridePreference. Also simplify the logic for setting
2372         string properties. Add the conversion for enable-hyperlink-auditing.
2373
2374 2010-09-23  Tony Chang  <tony@chromium.org>
2375
2376         Reviewed by David Levin.
2377
2378         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2379         https://bugs.webkit.org/show_bug.cgi?id=46388
2380
2381         * DumpRenderTree/chromium/LayoutTestController.cpp:
2382         (LayoutTestController::overridePreference):
2383         * DumpRenderTree/chromium/WebPreferences.cpp:
2384         (WebPreferences::reset):
2385         (WebPreferences::applyTo):
2386         * DumpRenderTree/chromium/WebPreferences.h:
2387
2388 2010-09-23  Nate Chapin  <japhet@chromium.org>
2389
2390         Reviewed by Darin Fisher.
2391
2392         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2393         https://bugs.webkit.org/show_bug.cgi?id=30458
2394
2395         * DumpRenderTree/chromium/LayoutTestController.cpp:
2396         (LayoutTestController::overridePreference):
2397         * DumpRenderTree/chromium/WebPreferences.cpp:
2398         (WebPreferences::reset):
2399         (WebPreferences::applyTo):
2400         * DumpRenderTree/chromium/WebPreferences.h:
2401         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2402         (resetDefaultsToConsistentValues):
2403         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2404         (LayoutTestController::overridePreference):
2405
2406 2010-09-21  Stephen White  <senorblanco@chromium.org>
2407
2408         Reviewed by David Levin.
2409
2410         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2411         https://bugs.webkit.org/show_bug.cgi?id=46208
2412
2413         This flag allows the layout tests to be run with or without accelerated
2414         2D canvas rendering.
2415
2416         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2417         (main):
2418         Declare the new flag string, and check for it on startup.
2419         * DumpRenderTree/chromium/TestShell.cpp:
2420         (TestShell::TestShell):
2421         Add a boolean for the new flag, in order to preserve its value over
2422         preferences reset.
2423         (TestShell::resetWebSettings):
2424         Set the new flag to the stored value on reset.
2425         * DumpRenderTree/chromium/TestShell.h:
2426         (TestShell::setAccelerated2dCanvasEnabled):
2427         Add an accessor for the new flag.
2428         * DumpRenderTree/chromium/WebPreferences.cpp:
2429         (WebPreferences::reset):
2430         Initialize the new flag to false.
2431         (WebPreferences::applyTo):
2432         Copy the flag's value to the WebSettings.
2433         * DumpRenderTree/chromium/WebPreferences.h:
2434         Add the new flag.
2435
2436 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2437
2438         Reviewed by Simon Hausmann.
2439
2440         [Qt] Refactor QtWebKitPlatformPlugin interface
2441
2442         Make it easier to keep source-compability for the
2443         QtWebKitPlatformPlugin interface, and run qmake
2444         on the example (but not build) for convenience. 
2445
2446         https://bugs.webkit.org/show_bug.cgi?id=46345
2447
2448         * Scripts/webkitdirs.pm:
2449
2450 2010-09-23  Adam Barth  <abarth@webkit.org>
2451
2452         Reviewed by Eric Seidel.
2453
2454         Tweak some status messages that Eric thought were confusing
2455         https://bugs.webkit.org/show_bug.cgi?id=46342
2456
2457         * Scripts/webkitpy/tool/commands/queues.py:
2458         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2459
2460 2010-09-22  Adam Barth  <abarth@webkit.org>
2461
2462         Reviewed by Eric Seidel.
2463
2464         Fix comm-queue typo
2465         https://bugs.webkit.org/show_bug.cgi?id=46339
2466
2467         We were missing a "self".  The real problem is that we didn't have an
2468         integration test for the failure case.
2469
2470         * Scripts/webkitpy/tool/commands/queues.py:
2471         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2472
2473 2010-09-22  Adam Barth  <abarth@webkit.org>
2474
2475         Reviewed by Eric Seidel.
2476
2477         commit-queue should log more detailed messages to the QueueStatusServer
2478         https://bugs.webkit.org/show_bug.cgi?id=46333
2479
2480         When I created CommitQueueTask, I removed most of the previous logging.
2481         This patch adds back more detailed logging so folks can see their patch
2482         progress through the queue.
2483
2484         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2485         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2486         * Scripts/webkitpy/tool/commands/queues.py:
2487         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2488
2489 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2490
2491         Reviewed by Darin Fisher.
2492
2493         [Chromium] User style layout tests don't pass on Chromium
2494         https://bugs.webkit.org/show_bug.cgi?id=46069
2495
2496         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2497         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2498         behavior from other ports.
2499
2500         * DumpRenderTree/chromium/LayoutTestController.cpp:
2501         (LayoutTestController::addUserStyleSheet):
2502
2503 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2504
2505         Reviewed by Martin Robinson.
2506
2507         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2508         https://bugs.webkit.org/show_bug.cgi?id=46303.
2509
2510         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2511         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2512         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2513         property sheet.
2514         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2515         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2516         appropriate property sheet for the build types.
2517         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2518         configuration to use appropriate property sheet for CoreFoundation
2519         and CFLite-style builds.
2520
2521 2010-09-22  Adam Barth  <abarth@webkit.org>
2522
2523         Reviewed by Eric Seidel.
2524
2525         Optimize commit-queue performance for green trees
2526         https://bugs.webkit.org/show_bug.cgi?id=46254
2527
2528         This patch redesigns the controller logic for the commit-queue.  In the
2529         new design, the controller exercises much finer-grained control over
2530         the landing process.  In particular:
2531
2532         - Patches that fail to apply now get rejected almost immediately.
2533         - Patches that fail to build get rejects after two builds (instead of
2534           three builds and one test run).
2535         - Patches that run into a flaky test now get accepted after one build
2536           and two test runs instead of three full build-and-test runs.
2537
2538         The main cost of these optimizations is that we don't find out the tree
2539         has a failing test until the very end of the process, but if the tree
2540         has a busted test, there's not much we can do anyway.  We might as well
2541         burn commit-queue resources spinning optimisticly.
2542
2543         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2544         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2545         * Scripts/webkitpy/tool/commands/queues.py:
2546
2547 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2548
2549         Reviewed by Martin Robinson.
2550
2551         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2552         https://bugs.webkit.org/show_bug.cgi?id=46303.
2553
2554         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2555         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2556         WinCairo build.
2557         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2558         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2559         build targets that use the new InjectedBundleCFLite.vsprops file.
2560
2561 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2562
2563         Unreviewed, build fix.
2564
2565         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2566         r67974. Really need better unit tests for this tool :(
2567
2568         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2569
2570 2010-09-22  Adam Roben  <aroben@apple.com>
2571
2572         Unbreak test-webkitpy
2573
2574         * Scripts/webkitpy/test/main.py:
2575         (Tester.run_tests): Add a line that mysteriously got deleted.
2576
2577 2010-09-22  Adam Roben  <aroben@apple.com>
2578
2579         Make test-webkitpy test WebKit2's scripts
2580
2581         These scripts can't be in WebKitTools due to limitations of Apple's
2582         build process. But that doesn't mean we can't test them!
2583
2584         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2585         WebKit2/Scripts
2586
2587         Reviewed by Adam Barth.
2588
2589         * Scripts/test-webkitpy:
2590         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2591         Now takes an external_package_paths parameter and cleans both webkitpy
2592         and any external packages.
2593         (init): Added an external_package_paths parameter which we pass along
2594         to _clean_packages_with_test.
2595         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2596         and pass it along to init and Tester.run_tests.
2597
2598         * Scripts/webkitpy/test/main.py:
2599         (Tester.run_tests): Added an optional external_package_paths
2600         parameter. We modify sys.path so that the external packages can be
2601         imported, and search for unittest files inside all external packages
2602         in addition to inside webkitpy.
2603
2604 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2605
2606         Reviewed by Tony Chang.
2607
2608         new-run-webkit-tests: r68063 broke linux python tests
2609
2610         Add a missing "from __future__ import with_statement" to this
2611         new file; the perils of testing only on the Mac and by review :(
2612
2613         https://bugs.webkit.org/show_bug.cgi?id=46293
2614
2615         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2616
2617 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2618
2619         Reviewed by Tony Chang.
2620
2621         Add a 'chromium-gpu' set of ports that will test the accelerated
2622         GPU paths. This patch adds:
2623
2624         - support for the '--accelerated-compositing' and
2625           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2626           'no-' flags)
2627         - adds a new set of Ports that will look under
2628           platform/chromium-gpu-$OS/ for baselines before looking in the
2629           regular chromium search path
2630         - adds a new test_expectations.txt file in platform/chromium-gpu
2631           that skips all but the tests we actually want to run with
2632           acceleration.
2633
2634         This patch will allow us to run both with and without acceleration
2635         and to change the defaults for both the regular and -gpu options
2636         as the code evolves.
2637
2638         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2639         each test bot.
2640
2641         https://bugs.webkit.org/show_bug.cgi?id=46225
2642
2643         * Scripts/webkitpy/layout_tests/port/chromium.py:
2644         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2645         * Scripts/webkitpy/layout_tests/port/factory.py:
2646         * Scripts/webkitpy/layout_tests/port/webkit.py:
2647
2648 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2649
2650         Reviewed by Kenneth Rohde Christiansen.
2651
2652         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2653         https://bugs.webkit.org/show_bug.cgi?id=43988
2654
2655         Runs a web debug server on port specified by QtTestBrowser
2656         argument -remote-inspector-port. Property
2657         _q_webInspectorServerPort of the QWebPage instance will be set
2658         according to the argument. All pages with that property set will
2659         be remotely inspectable.
2660
2661         URL for remote inspection of first QWebPage is
2662             http://localhost:9222/webkit/inspector/inspector.html?page=1
2663         where 1 is the number of the QWebPage instance.
2664
2665         The base URL yields an index page with links to the individual inspectors:
2666             http://localhost:9222/
2667
2668         * QtTestBrowser/launcherwindow.cpp:
2669         (LauncherWindow::init):
2670         * QtTestBrowser/launcherwindow.h:
2671         * QtTestBrowser/main.cpp:
2672         (LauncherApplication::handleUserOptions):
2673
2674 2010-09-22  Adam Roben  <aroben@apple.com>
2675
2676         Fix webkit-patch failure-reason now that build.webkit.org has been
2677         updated
2678
2679         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2680         every time
2681
2682         Reviewed by Eric Seidel.
2683
2684         * Scripts/webkitpy/common/net/buildbot.py:
2685         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2686         looking for an element that contains text, then returns it.
2687         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2688         text out of the cells. This way it doesn't matter whether the cells
2689         have <b> children (as for cells in directory rows) or not (as for
2690         cells in file rows)
2691         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2692         the "directory" or "file" class, rather than rows with any class,
2693         since header rows now have a class attribute.
2694
2695         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2696         (BuildBotTest._example_directory_listing): Updated to more closely
2697         match the markup that build.webkit.org is producing now.
2698
2699 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2700
2701         Unreviewed, build fix.
2702
2703         new-run-webkit-tests: fix bug introduced in r68008 where if you
2704         specify --chromium and no --platform, and you're running on
2705         windows, you use the 'chromium-win' port by default instead of the
2706         version-specific port. This breaks the buildbots.
2707
2708         It will be good for this refactoring to settle down so I can
2709         rewrite the logic for default ports and the unit tests to be
2710         clearer (and the testing more comprehensive).
2711
2712         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2713
2714 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2715
2716         Reviewed by Adam Barth.
2717
2718         Modify the Port interface to take only a series of keyword arguments
2719         in the constructor, and modify Port/factory.get() to accomodate that,
2720         and to accept user=XXX as an argument so we can pass
2721         webkitpy.common.system.user.User objects in.
2722
2723         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2724         to use the common routine in webkitpy.common.system.user.open_url()
2725         to display HTML files.
2726
2727         There was a routine in the Port interface to do the same thing,
2728         but I see no need for a port-specific hook for this, since it is
2729         something that will always be executed by the host environment
2730         and displaying web pages has nothing to do with running layout tests.
2731
2732         Note that new-run-webkit-tests used to use test_shell to display
2733         the page; this is potentially useful so that you can actually click
2734         from a result to the broken page; however, since DumpRenderTree
2735         doesn't support this functionality, it will be going away eventually.
2736
2737         https://bugs.webkit.org/show_bug.cgi?id=46128
2738
2739         * Scripts/webkitpy/layout_tests/port/base.py:
2740         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2741         * Scripts/webkitpy/layout_tests/port/chromium.py:
2742         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2743         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2744         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2745         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2746         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2747         * Scripts/webkitpy/layout_tests/port/factory.py:
2748         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2749         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2750         * Scripts/webkitpy/layout_tests/port/gtk.py:
2751         * Scripts/webkitpy/layout_tests/port/mac.py:
2752         * Scripts/webkitpy/layout_tests/port/qt.py:
2753         * Scripts/webkitpy/layout_tests/port/test.py:
2754         * Scripts/webkitpy/layout_tests/port/webkit.py:
2755         * Scripts/webkitpy/layout_tests/port/win.py:
2756         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2757         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2758         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2759
2760 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2761
2762         Reviewed by Kenneth Rohde Christiansen.
2763
2764         [EFL] Get fresh theme when running EWebLauncher
2765         https://bugs.webkit.org/show_bug.cgi?id=46210
2766
2767         If user tried to run EWebLauncher outside of the build tree, it would
2768         not find the theme and fallback to the installed one. However, since
2769         EWebLauncher is not installed, we always want to take the theme from
2770         the just compiled source code. If user had never installed WebKit's
2771         EFL port it could even receive a segv since no theme would be found.
2772
2773         Now EWebLauncher does not fallback to the installed theme and CMake
2774         gives as DATA_DIR the directory of the theme it has just built.
2775
2776         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2777         EWebLauncher.
2778         * EWebLauncher/main.c: Use only the theme from build director. Do not
2779         fallback to others as this could hide real bugs.
2780         (quit):
2781         (browserCreate):
2782         (findThemePath):
2783         (main):
2784
2785 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2786
2787         Unreviewed, build fix.
2788
2789         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2790         it just confuses it.
2791
2792         https://bugs.webkit.org/show_bug.cgi?id=46230
2793
2794         * Scripts/webkitpy/layout_tests/port/webkit.py:
2795
2796 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2797
2798         Reviewed by Stephanie Lewis.
2799
2800         Make a new buildbot for Leopard Debug Test
2801
2802         * BuildSlaveSupport/build.webkit.org-config/config.json:
2803
2804 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2805
2806         Unreviewed, build fix.
2807
2808         Fix breakage of Chromium Mac DRT port caused by r67905.
2809
2810         https://bugs.webkit.org/show_bug.cgi?id=46230
2811
2812         * Scripts/webkitpy/layout_tests/port/webkit.py:
2813
2814 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2815
2816         Unreviewed, build fix.
2817
2818         Add missing import of 'tempfile'.
2819
2820         * Scripts/webkitpy/layout_tests/port/chromium.py:
2821
2822 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2823
2824         Reviewed by Ojan Vafai.
2825
2826         new-run-webkit-tests: pull the list of tests from the Port, and
2827            make it possible to run with no actual test files in the filesystem.
2828
2829         This set of changes allows us to delete the special
2830         webkitpy/layout_tests/data directory and test the generic code without
2831         touching the filesystem (except to write results). This speeds up
2832         test-webkitpy substantially.
2833
2834         This also cleans up and removes several code paths in the generic
2835         code and fixes some minor bugs, notably in the test_expectations
2836         parsing, which was previously fragile if the tests weren't present.
2837
2838         We also change the way we diff image results to be able to do so
2839         in memory, without relying on files. This slows down chromium
2840         test_shell, which always writes images to files, but should speed
2841         up DRT and ImageDiff-based implementations slightly.
2842
2843         Note that pulling the list of tests to run from the Port will allow
2844         ports to specify what tests to run as an inclusive list; previously
2845         you could only do this as an exclusive list by using a 
2846         test_expectations file or Skipped files; nothing actually uses this
2847         feature yet and it's unclear if it should be used.
2848
2849         Note that there are no functional changes -- apart from now 
2850         always printing out the location of the checksum file when we are
2851         tracing test runs -- and the total number of lines of non-test code
2852         actually drops by two.
2853
2854         There is some more cleanup that can be done in the Port/Driver 
2855         interface and in some handling of filenames, but I'll save that
2856         for another change.
2857
2858         https://bugs.webkit.org/show_bug.cgi?id=45801
2859
2860         * Scripts/webkitpy/layout_tests/data/*: Removed.
2861             - no longer need special mock layout_tests_directory in the
2862               repository.
2863         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2864             - add code to display missing text files, checksums when tracing
2865             - update to not look at the filesystem directly.
2866         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2867             - add more unit tests
2868         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2869             - remove tests_are_present flag
2870             - update with changes in Port interface - no longer access
2871               the filesystem directly, although we still use os.path for
2872               filename manipulation.
2873         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2874             - add more unit tests
2875         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2876             - renamed to port/test_files.py
2877         * Scripts/webkitpy/layout_tests/port/base.py:
2878             - change diff_image() to expect actual image data, not filenames
2879             - add expected_checksum(), expected_image(), expected_text() to
2880               return the content of the files so that we don't need a filesystem
2881             - add path_exists(), path_isdir() for filesystem-like access.
2882             - add test_dirs() to keep clobber-test-results from needing to
2883               actually look at a real layout tests dir
2884             - add tests() to return the list of tests to run on the port
2885               (calls port/test_files to do the work).
2886             - add update_baseline() to be able to save new baselines
2887             - add uri_to_test_name() from port/dryrun.py so we can easily check
2888               filename_to_uri()
2889         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2890             - add more unit tests
2891         * Scripts/webkitpy/layout_tests/port/chromium.py:
2892             - change diff_image() to accept image content, not filenames.
2893               This will be slower for test_shell/image_diff, but faster
2894               for DRT/ImageDiff.
2895         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2896             - add more unit tests
2897         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2898             - simplify greatly
2899         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2900             - add more unit tests
2901         * Scripts/webkitpy/layout_tests/port/test.py:
2902             - massive rewrite to use in-script list of tests and expectations
2903         * Scripts/webkitpy/layout_tests/port/test_files.py:
2904             - rename from layout_package/test_files.
2905         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2906             - add unit tests
2907         * Scripts/webkitpy/layout_tests/port/webkit.py:
2908             - update diff_image() to take image contents, not files. Should
2909               make things slightly faster.
2910         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2911             - update with changes to diff_image()
2912         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2913             - update with changes to diff_image()
2914         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2915             - remove tests_are_present from test_expectations
2916             - pull the list of tests from port.tests() instead
2917               of calling test_files.py directly.
2918         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2919             - update unit tests
2920         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2921             - update with changes to 
2922         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2923             - update with change in Port interface
2924         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2925             - update with change in Port interface
2926         * Scripts/webkitpy/style/checkers/test_expectations.py:
2927             - remove the tests_are_present flag
2928
2929 2010-09-21  Anders Carlsson  <andersca@apple.com>
2930
2931         Disable logging.
2932
2933         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2934
2935 2010-09-21  Tony Chang  <tony@chromium.org>
2936
2937         Reviewed by Kent Tamura.
2938
2939         add a script for running webkit_unit_tests
2940         https://bugs.webkit.org/show_bug.cgi?id=46014
2941
2942         * Scripts/run-chromium-webkit-unit-tests: Added.
2943
2944 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2945
2946         Reviewed by Martin Robinson.
2947
2948         Fix linking problems on Windows.
2949         https://bugs.webkit.org/show_bug.cgi?id=45844
2950
2951         * GNUmakefile.am: link the executables with winmm.dll
2952
2953 2010-09-21  Adam Barth  <abarth@webkit.org>
2954
2955         Reviewed by Eric Seidel.
2956
2957         feeder-queue svn updates more often than needed
2958         https://bugs.webkit.org/show_bug.cgi?id=46171
2959
2960         We don't need to poll SVN every time we feed the feeders.  Rather, we
2961         can count on the wrapper shell script to auto-update the queue.
2962
2963         * Scripts/webkitpy/tool/commands/queues.py:
2964         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2965
2966 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2967
2968         Reviewed by Andreas Kling.
2969
2970         [Qt] Add robot loader timeout and extra time options.
2971         https://bugs.webkit.org/show_bug.cgi?id=46172
2972
2973         [-robot-timeout <s>]: Load the next page after s seconds if the current
2974         page didn't finish loading.
2975         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2976         loading before loading the next one. This should allow some time for the
2977         page's JavaScript to execute.
2978
2979         * QtTestBrowser/launcherwindow.cpp:
2980         (LauncherWindow::applyPrefs):
2981         * QtTestBrowser/main.cpp:
2982         (LauncherApplication::robotTimeout):
2983         (LauncherApplication::robotExtraTime):
2984         (LauncherApplication::LauncherApplication):
2985         (LauncherApplication::handleUserOptions):
2986         (main):
2987         * QtTestBrowser/urlloader.cpp:
2988         (UrlLoader::UrlLoader):
2989         (UrlLoader::loadNext):
2990         (UrlLoader::loadUrlList):
2991         * QtTestBrowser/urlloader.h:
2992
2993 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2994
2995         Unreviewed.
2996
2997         Adding myself to the committers list.
2998
2999         * Scripts/webkitpy/common/config/committers.py:
3000
3001 2010-09-20  Philippe Normand  <pnormand@igalia.com>
3002
3003         Reviewed by Eric Carlson.
3004
3005         [GTK] enhanced context menu for media elements
3006         https://bugs.webkit.org/show_bug.cgi?id=45021
3007
3008         EventSender::contextClick() now returns an array of js
3009         objects. Each object has a title property and a click() method.
3010
3011         * DumpRenderTree/gtk/EventSender.cpp:
3012         (getMenuItemTitleCallback):
3013         (setMenuItemTitleCallback):
3014         (menuItemClickCallback):
3015         (getMenuItemClass):
3016         (contextClickCallback):
3017
3018 2010-09-20  Hayato Ito  <hayato@chromium.org>
3019
3020         Unreviewed.
3021         Adding myself to the committers list.
3022
3023         * Scripts/webkitpy/common/config/committers.py:
3024
3025 2010-09-20  Adam Barth  <abarth@webkit.org>
3026
3027         Reviewed by Eric Seidel.
3028
3029         The tool member variable should be called _tool
3030         https://bugs.webkit.org/show_bug.cgi?id=46160
3031
3032         Created by find-and-replace.
3033
3034         * Scripts/webkitpy/tool/commands/download.py:
3035         * Scripts/webkitpy/tool/commands/openbugs.py:
3036         * Scripts/webkitpy/tool/commands/queries.py:
3037         * Scripts/webkitpy/tool/commands/queues.py:
3038         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3039         * Scripts/webkitpy/tool/commands/rebaseline.py:
3040         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3041         * Scripts/webkitpy/tool/commands/upload.py:
3042         * Scripts/webkitpy/tool/multicommandtool.py:
3043
3044 2010-09-20  Adam Barth  <abarth@webkit.org>
3045
3046         I ran the tests before landing but ignored the fact that they failed.  :(
3047
3048         * Scripts/webkitpy/tool/commands/queues.py:
3049
3050 2010-09-20  Adam Barth  <abarth@webkit.org>
3051
3052         Reviewed by Eric Seidel.
3053
3054         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
3055         https://bugs.webkit.org/show_bug.cgi?id=46141
3056
3057         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
3058         list of work items on the status server.  The individual commit-cluster
3059         nodes then grab the patches from the server and process them.
3060
3061         * Scripts/webkitpy/tool/bot/feeders.py: Added.
3062         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
3063         * Scripts/webkitpy/tool/commands/queues.py:
3064         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3065         * Scripts/webkitpy/tool/commands/queuestest.py:
3066
3067 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
3068
3069         Reviewed by Darin Adler.
3070
3071         build-webkit: Add support for CMake build system
3072         https://bugs.webkit.org/show_bug.cgi?id=44979
3073
3074         * Scripts/build-webkit: Add "--efl" command-line option to build the
3075         EFL port of WebKit.
3076         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
3077         buildEflCMakeProject() subroutines.
3078
3079 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
3080
3081         Reviewed by Ojan Vafai.
3082
3083         new-run-webkit-tests: refactor command line args getting passed to DRT
3084
3085         This change cleans up some argument parsing between functions to get
3086         rid of some overlapping data structures. There should be no functional
3087         changes in this patch; it is pure refactoring in preparation for
3088         landing the Chrome GPU port and adding a generic way to pass
3089         args to DRT/TestShell.
3090
3091         https://bugs.webkit.org/show_bug.cgi?id=46135
3092
3093         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3094           - pass the options argument explicitly to the threads and drivers,
3095             also consolidate the passing of options to the driver.
3096           - pass options directly to process_output() to remove a couple
3097             parameters (minor cleanup).
3098         * Scripts/webkitpy/layout_tests/port/base.py:
3099           - pass the options argument to Port.create_driver().
3100         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3101           - update Port.create_driver() test
3102         * Scripts/webkitpy/layout_tests/port/chromium.py:
3103           - pass the options argument to Port.create_driver(), and clean up
3104             building of the cmd line for DRT.
3105         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3106           - pass the options argument to Port.create_driver()
3107         * Scripts/webkitpy/layout_tests/port/test.py:
3108           - pass the options argument to Port.create_driver()
3109         * Scripts/webkitpy/layout_tests/port/webkit.py:
3110           - pass the options argument to Port.create_driver(), and clean up
3111             building of the cmd line for DRT.
3112         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3113           - consolidate args in _get_dump_render_tree_args and rename to
3114             _get_test_args(); move all of the command-line args to the
3115             Port implementations.
3116
3117 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
3118
3119         Revert change which was accidentally committed along with some expectation changes.
3120
3121         * Scripts/webkitpy/layout_tests/port/base.py:
3122
3123 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3124
3125         Reviewed by Adam Barth.
3126
3127         Add explicit --force-patch flag to webkitpy tools
3128         https://bugs.webkit.org/show_bug.cgi?id=46103
3129         
3130         It wasn't obvious until I read the applypatch.py source code that
3131         --non-interfactive implies passing --force to patch. Add --force-patch
3132         as an alias to the flag, so that this behavior is more discoverable.
3133
3134         * Scripts/webkitpy/tool/steps/applypatch.py:
3135         * Scripts/webkitpy/tool/steps/options.py:
3136
3137 2010-09-20  Eric Seidel  <eric@webkit.org>
3138
3139         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
3140
3141         commit-queue can't land patches
3142         https://bugs.webkit.org/show_bug.cgi?id=46138
3143
3144         Add a line of code I forgot in my last commit.
3145
3146         * Scripts/webkitpy/common/net/bugzilla.py:
3147         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3148
3149 2010-09-20  Adam Barth  <abarth@webkit.org>
3150
3151         Reviewed by Eric Seidel.
3152
3153         The commit-cluster bots still race to lock patch_ids
3154         https://bugs.webkit.org/show_bug.cgi?id=46130
3155
3156         It turns out we need to use a transaction object to make the
3157         read/modify/write lock operation atomic.  From reading the AppEngine
3158         documentation, I think this patch should do what we want.  It's hard to
3159         test locally because the test instance isn't distributed in the same
3160         way the production instance is.
3161
3162         * QueueStatusServer/handlers/nextpatch.py:
3163         * QueueStatusServer/model/activeworkitems.py: Added.
3164
3165 2010-09-20  Andy Estes  <aestes@apple.com>
3166
3167         Reviewed by Adam Barth.
3168
3169         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
3170         https://bugs.webkit.org/show_bug.cgi?id=40961
3171
3172         Implement WebKitUsePreHTML5ParserQuirks preference.
3173
3174         * DumpRenderTree/mac/DumpRenderTree.mm:
3175         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
3176         to false after a test finishes.
3177
3178 2010-09-20  Adam Roben  <aroben@apple.com>
3179
3180         Windows build fix
3181
3182         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
3183         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
3184         we'll pick up the most recent versions of the headers.
3185
3186 2010-09-20  Eric Seidel  <eric@webkit.org>
3187
3188         Reviewed by Adam Barth.
3189
3190         commit-queue should check commit-queue+ again just before committing
3191         https://bugs.webkit.org/show_bug.cgi?id=32679
3192
3193         Added a _revalidate_patch check, right before landing.
3194
3195         Since _revalidate_patch passes the patch_id from the work item
3196         back to bugzilla, I had to fix all of the previous queue tests to
3197         use valid attachment ids (that's the majority of this change).
3198
3199         In order to validate that the bug was still open, I had to teach
3200         bugzilla.Bug about open/closed states.
3201
3202         * Scripts/webkitpy/common/net/bugzilla.py:
3203         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3204         * Scripts/webkitpy/tool/commands/queues.py:
3205         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3206         * Scripts/webkitpy/tool/commands/queuestest.py:
3207         * Scripts/webkitpy/tool/mocktool.py:
3208
3209 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3210
3211         Unreviewed.
3212
3213         Adding myself as a comitter.
3214
3215         * Scripts/webkitpy/common/config/committers.py:
3216
3217 2010-09-20  Adam Barth  <abarth@webkit.org>
3218
3219         Reviewed by Eric Seidel.
3220
3221         Two instances of commit-queue try to process the same patch
3222         https://bugs.webkit.org/show_bug.cgi?id=46113
3223
3224         This patch makes next-patch atomic so that the server won't vend the
3225         same patch twice in the same hour.
3226
3227         * QueueStatusServer/handlers/nextpatch.py:
3228
3229 2010-09-20  Adam Roben  <aroben@apple.com>
3230
3231         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
3232
3233         We were previously trying to use a CFRunLoopTimer, but since Windows
3234         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
3235         Windows-style timer on Windows.
3236
3237         I also replaced all uses of "watchdog" with "watchdog timer".
3238
3239         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
3240         watchdog timer doesn't work on Windows
3241
3242         Reviewed by Anders Carlsson.
3243
3244         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3245         (WTR::InjectedBundlePage::dump): Updated for rename.
3246
3247         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
3248         platform-specific functions.
3249         (WTR::LayoutTestController::LayoutTestController): Added call to
3250         platformInitialize.
3251         (WTR::LayoutTestController::waitUntilDone): Changed to call
3252         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
3253         right in this function.
3254         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
3255         rename.
3256
3257         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
3258         members needed to support the watchdog timer abstraction. Replaced
3259         some "watchdog"s with "watchdog timer".
3260
3261         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3262         Added.
3263         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3264         platform.
3265         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3266         from LayoutTestController.cpp and changed to use an early return.
3267         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3268         LayoutTestController.cpp.
3269         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3270         Moved code here from LayoutTestController::waitUntilDone and changed
3271         to use an early return.
3272
3273         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3274         Added.
3275         (WTR::LayoutTestController::platformInitialize): Initialize our
3276         watchdog timer.
3277         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3278         Kills and clears the watchdog timer.
3279         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3280         LayoutTestController member function of the same name.
3281         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3282         Added. Sets up the timer if it isn't already set.
3283
3284         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3285         LayoutTestControllerMac.mm.
3286
3287         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3288         LayoutTestControllerWin.cpp.
3289
3290 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3291
3292         Reviewed by Daniel Bates.
3293
3294         [GTK] fast/forms/listbox-selection.html fails
3295         https://bugs.webkit.org/show_bug.cgi?id=45942
3296
3297         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3298         strings in keyDownCallback.
3299
3300         * DumpRenderTree/gtk/EventSender.cpp:
3301         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3302         modifier parsing logic.
3303
3304 2010-09-19  Sam Weinig  <sam@webkit.org>
3305
3306         Reviewed by Anders Carlsson.
3307
3308         WebKit2 decidePolicyForNavigationAction should include mouse button information
3309         <rdar://problem/8413165>
3310         https://bugs.webkit.org/show_bug.cgi?id=46060
3311
3312         * MiniBrowser/mac/BrowserWindowController.m:
3313         (decidePolicyForNavigationAction):
3314         (decidePolicyForNewWindowAction):
3315
3316 2010-09-19  Daniel Bates  <dbates@rim.com>
3317
3318         Reviewed by Martin Robinson.
3319
3320         Add unit tests for diffs that delete or modify a change log entry
3321         or describe changes that are far apart
3322         https://bugs.webkit.org/show_bug.cgi?id=46046
3323
3324         Add additional unit tests to test change log diffs that contain
3325         deletions or changes that are far apart from each other in the
3326         ChangeLog file.
3327
3328         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3329           - Added the following unit tests:
3330           "fixChangeLogPatch: [no change] In-place change."
3331           "fixChangeLogPatch: [no change] Remove first entry."
3332           "fixChangeLogPatch: [no change] Remove entry in the middle."
3333           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3334
3335 2010-09-19  Sam Weinig  <sam@webkit.org>
3336
3337         Reviewed by Anders Carlsson.
3338
3339         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3340         https://bugs.webkit.org/show_bug.cgi?id=46054
3341
3342         The new one acts like WKBundleNodeHandleRef and allows for getting a
3343         wrapper in a specific world for the handle.
3344
3345         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3346         (WTR::propertyValue):
3347         (WTR::propertyValueDouble):
3348         (WTR::propertyValueInt):
3349         (WTR::numericWindowPropertyValue):
3350         (WTR::toStr):
3351         (WTR::InjectedBundlePage::shouldBeginEditing):
3352         (WTR::InjectedBundlePage::shouldEndEditing):
3353         (WTR::InjectedBundlePage::shouldInsertNode):
3354         (WTR::InjectedBundlePage::shouldInsertText):
3355         (WTR::InjectedBundlePage::shouldDeleteRange):
3356         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3357         (WTR::InjectedBundlePage::shouldApplyStyle):
3358         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3359
3360 2010-09-19  Kent Tamura  <tkent@chromium.org>
3361
3362         Unreviewed. Fix WebGL test regressions by r67809.
3363
3364         * DumpRenderTree/chromium/WebPreferences.cpp:
3365         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3366
3367 2010-09-19  Kent Tamura  <tkent@chromium.org>
3368
3369         Reviewed by Adam Barth.
3370
3371         [DRT/Chromium] Fix a WebSettings handling bug
3372         https://bugs.webkit.org/show_bug.cgi?id=45945
3373
3374         Before this change, Chromium DRT reset WebSettings for every new
3375         window. It was wrong.
3376         If new window is not the first one, we have to apply the same
3377         settings as the first window.  So, we introduce WebPreference to
3378         store the current settings, and apply it to new windows. It's same
3379         as test_shell's behavior.
3380
3381         * DumpRenderTree/DumpRenderTree.gypi:
3382         * DumpRenderTree/chromium/LayoutTestController.cpp:
3383           Use WebPreferences instead of WebSettings.
3384         (LayoutTestController::setUserStyleSheetEnabled):
3385         (LayoutTestController::setUserStyleSheetLocation):
3386         (LayoutTestController::setAuthorAndUserStylesEnabled):
3387         (LayoutTestController::setPopupBlockingEnabled):
3388         (LayoutTestController::disableImageLoading):
3389         (LayoutTestController::setJavaScriptCanAccessClipboard):
3390         (LayoutTestController::setXSSAuditorEnabled):
3391         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3392         (LayoutTestController::setAllowFileAccessFromFileURLs):
3393         (LayoutTestController::overridePreference):
3394         (LayoutTestController::setEditingBehavior):
3395         * DumpRenderTree/chromium/TestShell.cpp:
3396         (TestShell::resetWebSettings): Use WebPreferences.
3397         (TestShell::runFileTest): ditto.
3398         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3399         * DumpRenderTree/chromium/TestShell.h:
3400         (TestShell::preferences):
3401         (TestShell::applyPreferences):
3402         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3403         * DumpRenderTree/chromium/WebPreferences.h: Added.
3404
3405 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3406
3407         Reviewed by David Levin.
3408
3409         update-webkit --chromium spitting out a spurious error
3410         https://bugs.webkit.org/show_bug.cgi?id=45868
3411
3412         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3413
3414 2010-09-18  Sam Weinig  <sam@webkit.org>
3415
3416         Reviewed by Dan Bernstein.
3417
3418         Improve/unify the PageLoadClient interfaces
3419         https://bugs.webkit.org/show_bug.cgi?id=46043
3420
3421         * MiniBrowser/mac/BrowserWindowController.m:
3422         (didStartProvisionalLoadForFrame):
3423         (didReceiveServerRedirectForProvisionalLoadForFrame):
3424         (didFailProvisionalLoadWithErrorForFrame):
3425         (didCommitLoadForFrame):
3426         (didFinishDocumentLoadForFrame):
3427         (didFinishLoadForFrame):
3428         (didFailLoadWithErrorForFrame):
3429         (didReceiveTitleForFrame):
3430         (didFirstLayoutForFrame):
3431         (didFirstVisuallyNonEmptyLayoutForFrame):
3432         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3433         (WTR::InjectedBundlePage::InjectedBundlePage):
3434         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3435         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3436         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3437         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3438         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3439         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3440         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3441         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3442         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3443         * WebKitTestRunner/TestController.cpp:
3444         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3445         (WTR::TestController::didFinishLoadForFrame):
3446         * WebKitTestRunner/TestController.h:
3447
3448 2010-09-17  Eric Seidel  <eric@webkit.org>
3449
3450         Unreviewed.  Adding a shell script I use to run the
3451         commit-queue. Now that multiple machines run the cq,
3452         it makes sense to share the script between them.
3453
3454         * EWSTools/start-commit-queue.sh: Added.
3455
3456 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3457
3458         Reviewed by Jon Honeycutt.
3459
3460         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3461         slightly harder to read, so this reverts the previous background colors for various
3462         states, making it easier to read.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3465         (.success):
3466         (.failure):
3467         (.warnings):
3468         (.exception):
3469         (.start,.running,td.building):
3470         (.offline,td.offline):
3471
3472 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3473
3474         Unreviewed, rolling out r67692.
3475         http://trac.webkit.org/changeset/67692
3476         https://bugs.webkit.org/show_bug.cgi?id=46011
3477
3478         broke layout test dashboard (Requested by johnny_g on
3479         #webkit).
3480
3481         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3482         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3483         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3484
3485 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3486
3487         Reviewed by Oliver Hunt.
3488
3489         Style bot complains about cairo forward declaration naming
3490         https://bugs.webkit.org/show_bug.cgi?id=45867
3491
3492         Exclude Cairo forward declarations from indentifiers with underscores checks.
3493
3494         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3495         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3496
3497 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3498
3499         Reviewed by Ojan Vafai.
3500
3501         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3502         https://bugs.webkit.org/show_bug.cgi?id=45408
3503
3504         This change also tries to remove duplicated upload_results_json methods
3505         in run_webkit_tests.py and json_results_generator.py.
3506
3507         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3508         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3509         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3510
3511 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3512
3513         Reviewed by Andreas Kling.
3514
3515         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3516
3517         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3518         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3519         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3520         all page specific stuff to the UI.
3521
3522         * QtTestBrowser/launcherwindow.cpp:
3523         (LauncherWindow::initializeView):
3524         * QtTestBrowser/mainwindow.cpp:
3525         (MainWindow::MainWindow):
3526         (MainWindow::buildUI):
3527         (MainWindow::setPage):
3528         * QtTestBrowser/mainwindow.h:
3529
3530 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3531
3532         Reviewed by Andreas Kling.
3533
3534         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3535
3536         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3537         object will move to the qgraphicsscene instead of the qgraphicsview.
3538
3539         * QtTestBrowser/webview.cpp:
3540         (WebViewGraphicsBased::setPage):
3541         (WebViewGraphicsBased::setResizesToContents):
3542         (WebViewGraphicsBased::resizeEvent):
3543         (WebViewGraphicsBased::animatedFlip):
3544         * QtTestBrowser/webview.h:
3545         (WebViewGraphicsBased::setItemCacheMode):
3546         (WebViewGraphicsBased::itemCacheMode):
3547
3548 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3549
3550         Reviewed by Andreas Kling.
3551
3552         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3553
3554         We usually separate methods whose body are larger than a few lines from the class definition.
3555
3556         * QtTestBrowser/webview.h:
3557         (WebViewGraphicsBased::yRotation):
3558         (WebViewGraphicsBased::setYRotation):
3559
3560 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3561
3562         Reviewed by Andreas Kling.
3563
3564         Make initializeView method of LauncherWindow private.
3565
3566         No one else needs to be able to call it but LauncherWindow.
3567         Also moving the declation of isGraphicsBased method down in the same file, in order
3568         to better group related methods.
3569
3570         * QtTestBrowser/launcherwindow.h:
3571
3572 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3573
3574         Reviewed by Andreas Kling.
3575
3576         Make the getter 'page' method of MainWindow const.
3577
3578         * QtTestBrowser/mainwindow.cpp:
3579         (MainWindow::page):
3580         * QtTestBrowser/mainwindow.h:
3581
3582 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3583